helloadhavan/github_issues huggingface dataset:
Repository: huggingface/transformers
Pull request: Fix typo in model proposal template

# What does this PR do?

This PR fixes a grammatical error.

## Before submitting
- [x] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
- [x] Did you read the [contributor guideline](https://github.com/huggingface/transformers/blob/main/CONTRIBUTING.md#create-a-pull-request),
      Pull Request section?
- [ ] Was this discussed/approved via a Github issue or the [forum](https://discuss.huggingface.co/)? Please add a link
      to it if that's the case.
- [x] Did you make sure to update the documentation with your changes? Here are the
      [documentation guidelines](https://github.com/huggingface/transformers/tree/main/docs), and
      [here are tips on formatting docstrings](https://github.com/huggingface/transformers/tree/main/docs#writing-source-documentation).
- [x] Did you write any new necessary tests?


## Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR. @stevhiku

Changed files:
filename: templates/adding_a_new_model/ADD_NEW_MODEL_PROPOSAL_TEMPLATE.md
patch: @@ -491,7 +491,7 @@ precision of 0.001! Since it is normal that the exact same model written
 in different libraries can give a slightly different output depending on
 the library framework, we accept an error tolerance of 1e-3 (0.001). It
 is not enough if the model gives nearly the same output, they have to be
-the almost identical. Therefore, you will certainly compare the
+almost identical. Therefore, you will certainly compare the
 intermediate outputs of the 🤗 Transformers version multiple times
 against the intermediate outputs of the original implementation of
 *[camelcase name of model]* in which case an **efficient** debugging environment
Repository: denoland/deno
Pull request: feat(config): support include and exclude in deploy config


Changed files:
filename: cli/schemas/config-file.v1.json
patch: @@ -522,6 +522,20 @@
               "default": false
             }
           }
+        },
+        "include": {
+          "type": "array",
+          "description": "List of files, directories or globs that will be included in deployments.",
+          "items": {
+            "type": "string"
+          }
+        },
+        "exclude": {
+          "type": "array",
+          "description": "List of files, directories or globs that will not be included in deployments.",
+          "items": {
+            "type": "string"
+          }
         }
       }
     },

filename: libs/config/deno_json/mod.rs
patch: @@ -1066,11 +1066,42 @@ impl NodeModulesDirMode {
   }
 }
 
+/// `deploy` config representation for serde
+///
+/// fields `include` and `exclude` are expanded from [SerializedFilesConfig].
 #[derive(Clone, Debug, Deserialize, PartialEq)]
 #[serde(deny_unknown_fields)]
+struct SerializedDeployConfig {
+  pub org: String,
+  pub app: Option<String>,
+  #[serde(default)]
+  pub include: Option<Vec<String>>,
+  #[serde(default)]
+  pub exclude: Vec<String>,
+}
+
+impl SerializedDeployConfig {
+  pub fn into_resolved(
+    self,
+    config_file_specifier: &Url,
+  ) -> Result<DeployConfig, IntoResolvedError> {
+    let files = SerializedFilesConfig {
+      include: self.include,
+      exclude: self.exclude,
+    };
+    Ok(DeployConfig {
+      org: self.org,
+      app: self.app,
+      files: files.into_resolved(config_file_specifier)?,
+    })
+  }
+}
+
+#[derive(Clone, Debug, PartialEq)]
 pub struct DeployConfig {
   pub org: String,
   pub app: Option<String>,
+  pub files: FilePatterns,
 }
 
 #[derive(Clone, Debug, Eq, PartialEq, Serialize, Deserialize)]
@@ -2117,14 +2148,26 @@ impl ConfigFile {
   pub fn to_deploy_config(
     &self,
   ) -> Result<Option<DeployConfig>, ToInvalidConfigError> {
-    match &self.json.deploy {
+    match self.json.deploy.clone() {
       Some(config) => {
-        Ok(Some(serde_json::from_value(config.clone()).map_err(
-          |error| ToInvalidConfigError::Parse {
+        let mut exclude_patterns = self.resolve_exclude_patterns()?;
+        let mut serialized: SerializedDeployConfig =
+          serde_json::from_value(config).map_err(|error| {
+            ToInvalidConfigError::Parse {
+              config: "deploy",
+              source: error,
+            }
+          })?;
+        // top level excludes at the start because they're lower priority
+        exclude_patterns.extend(std::mem::take(&mut serialized.exclude));
+        serialized.exclude = exclude_patterns;
+        serialized
+          .into_resolved(&self.specifier)
+          .map(Some)
+          .map_err(|error| ToInvalidConfigError::InvalidConfig {
             config: "deploy",
             source: error,
-          },
-        )?))
+          })
       }
       None => Ok(None),
     }
Repository: electron/electron
Pull request: fix: crash calling `Fetch.continueResponse` with `WebContentsView`

#### Description of Change

Closes https://github.com/electron/electron/issues/46109

Fixes an issue where calling `Fetch.continueResponse` via debugger with `WebContentsView` could cause a crash. Some light investigation showed that `RenderFrameDevToolsAgentHost::{Connect|Disconnect}WebContents()` relied on the primary main frame of the passed `webContents` to attach, but it might be the case that the `RenderFrameHost` at hand is not in its primary main frame. If the new `RenderFrameHost` is not the primary main frame, we don't want to reconnect otherwise we'll end up potentially trying to reconnect to a `RenderFrameHost` that already has a `DevToolsAgentHost` associated with it.

See also this known [bug in Chromium](https://source.chromium.org/chromium/chromium/src/+/main:content/browser/devtools/render_frame_devtools_agent_host.cc;l=303-307;drc=5e74ac5d42bce00b534d992272e7fa09b53b300f;bpv=1;bpt=1).

#### Checklist
<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

- [x] PR description included and stakeholders cc'd
- [x] `npm test` passes
- [x] [PR release notes](https://github.com/electron/clerk/blob/main/README.md) describe the change in a way relevant to app developers, and are [capitalized, punctuated, and past tense](https://github.com/electron/clerk/blob/main/README.md#examples).

#### Release Notes

Notes: Fixed an issue where calling `Fetch.continueResponse` via debugger with `WebContentsView` could cause a crash.

Changed files:
filename: shell/browser/api/electron_api_debugger.cc
patch: @@ -81,7 +81,11 @@ void Debugger::DispatchProtocolMessage(DevToolsAgentHost* agent_host,
 
 void Debugger::RenderFrameHostChanged(content::RenderFrameHost* old_rfh,
                                       content::RenderFrameHost* new_rfh) {
-  if (agent_host_) {
+  // ConnectWebContents uses the primary main frame of the webContents,
+  // so if the new_rfh is not the primary main frame, we don't want to
+  // reconnect otherwise we'll end up trying to reconnect to a RenderFrameHost
+  // that already has a DevToolsAgentHost associated with it.
+  if (agent_host_ && new_rfh->IsInPrimaryMainFrame()) {
     agent_host_->DisconnectWebContents();
     auto* web_contents = content::WebContents::FromRenderFrameHost(new_rfh);
     agent_host_->ConnectWebContents(web_contents);
Repository: ollama/ollama
Pull request: Update troubleshooting link


Changed files:
filename: gpu/amd_linux.go
patch: @@ -113,7 +113,7 @@ func AMDGetGPUInfo(resp *GpuInfo) {
 			if !slices.Contains[[]string, string](supported, v.ToGFXString()) {
 				slog.Warn(fmt.Sprintf("amdgpu [%d] %s is not supported by %s %v", i, v.ToGFXString(), libDir, supported))
 				// TODO - consider discrete markdown just for ROCM troubleshooting?
-				slog.Warn("See https://github.com/ollama/ollama/blob/main/docs/troubleshooting.md for HSA_OVERRIDE_GFX_VERSION usage")
+				slog.Warn("See https://github.com/ollama/ollama/blob/main/docs/gpu.md#overrides for HSA_OVERRIDE_GFX_VERSION usage")
 				skip[i] = struct{}{}
 			} else {
 				slog.Info(fmt.Sprintf("amdgpu [%d] %s is supported", i, v.ToGFXString()))
Repository: facebook/react
Pull request: [ci] Fix invalid username and email in synthetic commit

Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom):
* __->__ #30486



Changed files:
filename: .github/workflows/runtime_commit_artifacts.yml
patch: @@ -230,8 +230,8 @@ jobs:
 
             DiffTrain build for [${{ github.event.workflow_run.head_sha }}](https://github.com/facebook/react/commit/${{ github.event.workflow_run.head_sha }})
           branch: builds/facebook-www
-          commit_user_name: ${{ github.event.workflow_run.actor.name }}
-          commit_user_email: ${{ github.event.workflow_run.actor.email || format('{0}@users.noreply.github.com', github.event.workflow_run.actor.name) }}
+          commit_user_name: ${{ github.event.workflow_run.triggering_actor.login }}
+          commit_user_email: ${{ github.event.workflow_run.triggering_actor.email || format('{0}@users.noreply.github.com', github.event.workflow_run.triggering_actor.login) }}
           create_branch: true
 
   commit_fbsource_artifacts:
@@ -388,6 +388,6 @@ jobs:
 
             DiffTrain build for commit https://github.com/facebook/react/commit/${{ github.event.workflow_run.head_sha }}.
           branch: builds/facebook-fbsource
-          commit_user_name: ${{ github.event.workflow_run.actor.name }}
-          commit_user_email: ${{ github.event.workflow_run.actor.email || format('{0}@users.noreply.github.com', github.event.workflow_run.actor.name) }}
+          commit_user_name: ${{ github.event.workflow_run.triggering_actor.login }}
+          commit_user_email: ${{ github.event.workflow_run.triggering_actor.email || format('{0}@users.noreply.github.com', github.event.workflow_run.triggering_actor.login) }}
           create_branch: true
Repository: facebook/react
Pull request: [ci] Update prepare-release-from-ci to dl from GH

Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom):
* #30481
* __->__ #30485
* #30484

Updates this script to download from GH actions instead, to prepare for
moving the cron jobs over to GH actions.

Changed files:
filename: scripts/release/shared-commands/download-build-artifacts-ghaction.js
patch: @@ -22,7 +22,9 @@ const GITHUB_HEADERS = `
   -H "X-GitHub-Api-Version: 2022-11-28"`.trim();
 
 function getWorkflowId() {
-  if (existsSync(join(__dirname, `../../.github/workflows/${WORKFLOW_ID}`))) {
+  if (
+    existsSync(join(__dirname, `../../../.github/workflows/${WORKFLOW_ID}`))
+  ) {
     return WORKFLOW_ID;
   } else {
     throw new Error(
@@ -86,7 +88,7 @@ async function downloadArtifactsFromGitHub(commit, releaseChannel) {
   const artifact = await getArtifact(workflowRunId, 'artifacts_combined');
 
   // Download and extract artifact
-  const cwd = join(__dirname, '..', '..');
+  const cwd = join(__dirname, '..', '..', '..');
   await exec(`rm -rf ./build`, {cwd});
   await exec(
     `curl -L ${GITHUB_HEADERS} ${artifact.archive_download_url} \
Repository: denoland/deno
Pull request: fix(ext/node): add `host_arch` to `process.config.variables`

## Summary
- Adds `host_arch` property to `process.config.variables` to match Node.js behavior
- Changes `process.config` to use a lazy getter so `arch` is available at access time (not during snapshot creation)
- Fixes packages like `neo4j-driver` that access `process.config.variables.host_arch`

Closes #27556

## Test plan
- [x] Added assertion in `tests/unit_node/process_test.ts` that `process.config.variables.host_arch === process.arch`
- [x] Verified `neo4j-driver@5.27.0` loads and creates a driver without crashing
- [x] Dev build succeeds (snapshot creation works with lazy getter)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Changed files:
filename: ext/node/polyfills/process.ts
patch: @@ -676,14 +676,24 @@ Object.defineProperty(process, "argv0", {
 process.chdir = chdir;
 
 /** https://nodejs.org/api/process.html#processconfig */
-process.config = Object.freeze({
-  target_defaults: Object.freeze({
-    default_configuration: "Release",
-  }),
-  variables: Object.freeze({
-    llvm_version: "0.0",
-    enable_lto: "false",
-  }),
+let _configCache: Record<string, unknown> | undefined;
+Object.defineProperty(process, "config", {
+  get() {
+    if (_configCache === undefined) {
+      _configCache = Object.freeze({
+        target_defaults: Object.freeze({
+          default_configuration: "Release",
+        }),
+        variables: Object.freeze({
+          llvm_version: "0.0",
+          enable_lto: "false",
+          host_arch: arch,
+        }),
+      });
+    }
+    return _configCache;
+  },
+  configurable: true,
 });
 
 process.cpuUsage = cpuUsage;

filename: tests/unit_node/process_test.ts
patch: @@ -951,6 +951,7 @@ Deno.test("process.config", () => {
   assert(process.config !== undefined);
   assert(process.config.target_defaults !== undefined);
   assert(process.config.variables !== undefined);
+  assertEquals(process.config.variables.host_arch, process.arch);
 });
 
 Deno.test("process._exiting", () => {
Repository: ollama/ollama
Pull request: fix: workflows


Changed files:
filename: .github/workflows/test.yaml
patch: @@ -15,10 +15,13 @@ jobs:
       GENERATE_CUDA: ${{ steps.changes.outputs.GENERATE_CUDA }}
       GENERATE_ROCM: ${{ steps.changes.outputs.GENERATE_ROCM }}
     steps:
+      - uses: actions/checkout@v4
+        with:
+          fetch-depth: 0
       - id: changes
         run: |
           changed() {
-            git diff-tree -r --no-commit-id --name-only $GITHUB_BASE_REF $GITHUB_HEAD_REF \
+            git diff-tree -r --no-commit-id --name-only ${{ github.event.pull_request.base.sha }} ${{ github.event.pull_request.head.sha }} \
               | xargs python3 -c "import sys; print(any([x.startswith('$1') for x in sys.argv[1:]]))"
           }
Repository: ggml-org/llama.cpp
Pull request: metal : print node names for debugging

Minor QoL

Changed files:
filename: ggml/src/ggml-metal/ggml-metal-ops.cpp
patch: @@ -221,7 +221,7 @@ static int ggml_metal_op_encode_impl(ggml_metal_op_t ctx, int idx) {
         }
 
         if (ctx->debug_graph > 0) {
-            GGML_LOG_DEBUG("%s: node[%5d] - %-12s %s\n", __func__, idx, ggml_op_name(node->op), is_concurrent ? "(concurrent)" : "");
+            GGML_LOG_DEBUG("%s: node[%5d] - %-12s %-12s %s\n", __func__, idx, ggml_op_name(node->op), ggml_get_name(node), is_concurrent ? "(concurrent)" : "");
         }
         if (ctx->debug_graph > 1) {
             GGML_TENSOR_LOCALS( int64_t, ne0, node->src[0], ne);
Repository: facebook/react
Pull request: [circleci] Remove build_and_test workflow

Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom):
* #30481
* __->__ #30480
* #30479

Now that we've fully migrated the PR CI workflow (build_and_test) to GH,
we can fully delete the workflow altogether. This will break
https://react-builds.vercel.app/ unfortunately but I'll wait for
@acdlite to come back from vacation and work with him to fix it.

The remaining jobs in circleci are for publishing prereleases of React
to npm. I'll work on migrating those next.

Changed files:
filename: .circleci/config.yml
patch: @@ -48,40 +48,6 @@ parameters:
     default: ''
 
 jobs:
-  yarn_build:
-    docker: *docker
-    environment: *environment
-    parallelism: 40
-    steps:
-      - checkout
-      - setup_node_modules
-      - run: yarn build --ci=circleci
-      - persist_to_workspace:
-          root: .
-          paths:
-            - build
-
-  process_artifacts_combined:
-    docker: *docker
-    environment: *environment
-    steps:
-      - checkout
-      - attach_workspace:
-          at: .
-      - setup_node_modules
-      - run: echo "<< pipeline.git.revision	>>" >> build/COMMIT_SHA
-      - run: |
-          mkdir -p ./build/__test_utils__
-          node ./scripts/print-warnings/print-warnings.js > build/__test_utils__/ReactAllWarnings.js
-      # Compress build directory into a single tarball for easy download
-      - run: tar -zcvf ./build.tgz ./build
-        # TODO: Migrate scripts to use `build` directory instead of `build2`
-      - run: cp ./build.tgz ./build2.tgz
-      - store_artifacts:
-          path: ./build2.tgz
-      - store_artifacts:
-          path: ./build.tgz
-
   publish_prerelease:
     parameters:
       commit_sha:
@@ -105,19 +71,6 @@ jobs:
             scripts/release/publish.js --ci --tags << parameters.dist_tag >>
 
 workflows:
-
-  build_and_test:
-    unless: << pipeline.parameters.prerelease_commit_sha >>
-    jobs:
-      - yarn_build:
-          filters:
-            branches:
-              ignore:
-                - builds/facebook-www
-      - process_artifacts_combined:
-          requires:
-            - yarn_build
-
   # Used to publish a prerelease manually via the command line
   publish_preleases:
     when: << pipeline.parameters.prerelease_commit_sha >>
Repository: denoland/deno
Pull request: fix(node/buffer): fix latin1Slice and hexSlice returning wrong results

## Summary
- Fix `Buffer.prototype.latin1Slice` and `Buffer.prototype.hexSlice` having an extraneous `string` parameter that shifted all arguments passed to the underlying `_latin1Slice`/`_hexSlice` functions
- Fix `_latin1Slice` not handling missing `start`/`end` arguments, causing it to return empty strings when called with no arguments
- Add unit tests for both methods

Fixes #32276

## Test plan
- [x] `cargo test unit_node::buffer_test` passes
- [x] Manually verified `Buffer.of(1,2,3,0xff).latin1Slice()` returns a 4-character string (previously returned empty string)
- [x] Manually verified `hexSlice()` and `hexSlice(start, end)` return correct results

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Changed files:
filename: ext/node/polyfills/internal/buffer.mjs
patch: @@ -1011,16 +1011,12 @@ Buffer.prototype.hexWrite = function hexWrite(string, offset, length) {
   );
 };
 
-Buffer.prototype.hexSlice = function hexSlice(string, offset, length) {
-  return _hexSlice(this, string, offset, length);
+Buffer.prototype.hexSlice = function hexSlice(offset, length) {
+  return _hexSlice(this, offset, length);
 };
 
-Buffer.prototype.latin1Slice = function latin1Slice(
-  string,
-  offset,
-  length,
-) {
-  return _latin1Slice(this, string, offset, length);
+Buffer.prototype.latin1Slice = function latin1Slice(offset, length) {
+  return _latin1Slice(this, offset, length);
 };
 
 Buffer.prototype.latin1Write = function latin1Write(
@@ -1192,7 +1188,12 @@ function _utf8Slice(buf, start, end) {
 
 function _latin1Slice(buf, start, end) {
   let ret = "";
-  end = MathMin(buf.length, end);
+  if (!start || start < 0) {
+    start = 0;
+  }
+  if (end === undefined || end > buf.length) {
+    end = buf.length;
+  }
   for (let i = start; i < end; ++i) {
     ret += StringFromCharCode(buf[i]);
   }

filename: tests/unit_node/buffer_test.ts
patch: @@ -717,3 +717,24 @@ Deno.test({
     assertEquals(file instanceof Blob, true);
   },
 });
+
+Deno.test({
+  name: "[node/buffer] latin1Slice returns correct string",
+  fn() {
+    // deno-lint-ignore no-explicit-any
+    const buf: any = Buffer.of(1, 2, 3, 0xff);
+    assertEquals(buf.latin1Slice().length, 4);
+    assertEquals(buf.latin1Slice(), "\x01\x02\x03\xff");
+    assertEquals(buf.latin1Slice(1, 3), "\x02\x03");
+  },
+});
+
+Deno.test({
+  name: "[node/buffer] hexSlice returns correct string",
+  fn() {
+    // deno-lint-ignore no-explicit-any
+    const buf: any = Buffer.of(1, 2, 3, 0xff);
+    assertEquals(buf.hexSlice(), "010203ff");
+    assertEquals(buf.hexSlice(1, 3), "0203");
+  },
+});
Repository: facebook/react
Pull request: [ci] Update runtime_commit_artifacts step versions

Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom):
* #30481
* #30480
* __->__ #30479

These were outdated and emitting warnings

Changed files:
filename: .github/workflows/runtime_commit_artifacts.yml
patch: @@ -142,11 +142,11 @@ jobs:
           echo "current_version_classic=$VERSION_CLASSIC" >> "$GITHUB_OUTPUT"
           echo "current_version_modern=$VERSION_MODERN" >> "$GITHUB_OUTPUT"
           echo "current_version_rn=$VERSION_NATIVE_FB" >> "$GITHUB_OUTPUT"
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         with:
           name: compiled
           path: compiled/
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         with:
           name: compiled-rn
           path: compiled-rn/
@@ -161,7 +161,7 @@ jobs:
           ref: builds/facebook-www
       - name: Ensure clean directory
         run: rm -rf compiled
-      - uses: actions/download-artifact@v3
+      - uses: actions/download-artifact@v4
         with:
           name: compiled
           path: compiled/
@@ -244,7 +244,7 @@ jobs:
           ref: builds/facebook-fbsource
       - name: Ensure clean directory
         run: rm -rf compiled-rn
-      - uses: actions/download-artifact@v3
+      - uses: actions/download-artifact@v4
         with:
           name: compiled-rn
           path: compiled-rn/
@@ -293,7 +293,7 @@ jobs:
           git add .
       - name: Signing files
         if: steps.check_should_commit.outputs.should_commit == 'true'
-        uses: actions/github-script@v6
+        uses: actions/github-script@v7
         with:
           script: |
             // TODO: Move this to a script file.
Repository: nodejs/node
Pull request: doc: link to `TypedArray.from()` in signature

I've been going through the beta documentation generator looking for any bugs, and in the process, I noticed that this should be linked, right?

Changed files:
filename: doc/api/buffer.md
patch: @@ -405,7 +405,7 @@ implementations. Specifically, the {TypedArray} variants accept a second
 argument that is a mapping function that is invoked on every element of the
 typed array:
 
-* `TypedArray.from(source[, mapFn[, thisArg]])`
+* [`TypedArray.from(source[, mapFn[, thisArg]])`][`TypedArray.from()`]
 
 The `Buffer.from()` method, however, does not support the use of a mapping
 function: