helloadhavan/github_issues huggingface dataset:
Repository: facebook/react
Pull request: Don't dist-tag canaries with `rc`

We used to tag canaries with `rc` whenever we were in the RC phase of a release cycle. But now that publish "real" versioned canaries like 19.0.0-rc.1, it's confusing that the `rc` dist-tag could point to an even newer version than that.

So this removes the `rc` dist-tag from the canary publish workflow.

Changed files:
filename: .github/workflows/runtime_prereleases_manual.yml
patch: @@ -27,7 +27,7 @@ jobs:
       # because this used to be called the "next" channel and some
       # downstream consumers might still expect that tag. We can remove this
       # after some time has elapsed and the change has been communicated.
-      dist_tag: canary,next,rc
+      dist_tag: canary,next
     secrets:
       NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
 

filename: .github/workflows/runtime_prereleases_nightly.yml
patch: @@ -15,7 +15,7 @@ jobs:
     with:
       commit_sha: ${{ github.sha }}
       release_channel: stable
-      dist_tag: canary,next,rc
+      dist_tag: canary,next
     secrets:
       NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
Repository: vuejs/vue
Pull request: Preserve cursor position when changing input from Vuex.

Fixes https://github.com/vuejs/vuex/issues/162

textarea works different and we need to set it as before.

Same issue is also present on v2.0. @yyx990803 should I open PR for 2.0 too?


Changed files:
filename: src/directives/public/bind.js
patch: @@ -110,11 +110,15 @@ export default {
       attrWithPropsRE.test(attr) &&
       attr in el
     ) {
-      el[attr] = attr === 'value'
+      var attrValue = attr === 'value'
         ? value == null // IE9 will set input.value to "null" for null...
           ? ''
           : value
         : value
+
+      if (el[attr] !== attrValue) {
+        el[attr] = attrValue
+      }
     }
     // set model props
     var modelProp = modelProps[attr]
Repository: nodejs/node
Pull request: benchmark: use non-deprecated WriteUtf8V2 method

<!--
Before submitting a pull request, please read:

- the CONTRIBUTING guide at https://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md
- the commit message formatting guidelines at
  https://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#commit-message-guidelines

For code changes:
1. Include tests for any bug fixes or new features.
2. Update documentation if relevant.
3. Ensure that `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes.

If you believe this PR should be highlighted in the Node.js CHANGELOG
please add the `notable-change` label.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.
-->


Changed files:
filename: benchmark/napi/function_args/binding.cc
patch: @@ -23,7 +23,8 @@ void CallWithString(const FunctionCallbackInfo<Value>& args) {
     Local<String> str = args[0].As<String>();
     const size_t length = str->Utf8LengthV2(args.GetIsolate()) + 1;
     char* buf = new char[length];
-    str->WriteUtf8(args.GetIsolate(), buf, length);
+    str->WriteUtf8V2(
+        args.GetIsolate(), buf, length, String::WriteFlags::kNullTerminate);
     delete[] buf;
   }
 }
Repository: ollama/ollama
Pull request: Add windows radeon concurrency note


Changed files:
filename: docs/faq.md
patch: @@ -266,8 +266,10 @@ If there is insufficient available memory to load a new model request while one
 
 Parallel request processing for a given model results in increasing the context size by the number of parallel requests.  For example, a 2K context with 4 parallel requests will result in an 8K context and additional memory allocation.
 
-The following server settings may be used to adjust how Ollama handles concurrent requests:
+The following server settings may be used to adjust how Ollama handles concurrent requests on most platforms:
 
 - `OLLAMA_MAX_LOADED_MODELS` - The maximum number of models that can be loaded concurrently provided they fit in available memory.  The default is 3 * the number of GPUs or 3 for CPU inference.
 - `OLLAMA_NUM_PARALLEL` - The maximum number of parallel requests each model will process at the same time.  The default will auto-select either 4 or 1 based on available memory.
 - `OLLAMA_MAX_QUEUE` - The maximum number of requests Ollama will queue when busy before rejecting additional requests. The default is 512
+
+Note: Windows with Radeon GPUs currently default to 1 model maximum due to limitations in ROCm v5.7 for available VRAM reporting.  Once ROCm v6 is available, Windows Radeon will follow the defaults above.  You may enable concurrent model loads on Radeon on Windows, but ensure you don't load more models than will fit into your GPUs VRAM.
\ No newline at end of file
Repository: electron/electron
Pull request: fix: snapped restoration after minimization

Backport of #48142

See that PR for details.


Notes: Fixed an issue where snapped corner state wasn't properly restored after minimizing and then restoring.

Changed files:
filename: shell/browser/native_window_views.h
patch: @@ -310,6 +310,9 @@ class NativeWindowViews : public NativeWindow,
   // Whether the window is currently being moved.
   bool is_moving_ = false;
 
+  // Whether or not the window was previously snapped e.g. before minimizing.
+  bool was_snapped_ = false;
+
   std::variant<std::monostate, bool, SkColor> accent_color_;
 
   std::optional<gfx::Rect> pending_bounds_change_;

filename: shell/browser/native_window_views_win.cc
patch: @@ -462,11 +462,12 @@ bool NativeWindowViews::PreHandleMSG(UINT message,
       return false;
     }
     case WM_SYSCOMMAND: {
-      // Mask is needed to account for double clicking title bar to maximize
-      WPARAM max_mask = 0xFFF0;
-      if (transparent() && ((w_param & max_mask) == SC_MAXIMIZE)) {
+      WPARAM cmd = w_param & 0xFFF0;
+      // Needed to account for double clicking title bar to maximize.
+      if (transparent() && (cmd == SC_MAXIMIZE))
         return true;
-      }
+      if (cmd == SC_MINIMIZE)
+        was_snapped_ = IsSnapped();
       return false;
     }
     case WM_INITMENU: {
@@ -519,8 +520,13 @@ void NativeWindowViews::HandleSizeEvent(WPARAM w_param, LPARAM l_param) {
       // multiple times for one resize because of the SetWindowPlacement call.
       if (w_param == SIZE_MAXIMIZED &&
           last_window_state_ != ui::mojom::WindowShowState::kMaximized) {
-        if (last_window_state_ == ui::mojom::WindowShowState::kMinimized)
+        if (last_window_state_ == ui::mojom::WindowShowState::kMinimized) {
+          if (was_snapped_) {
+            SetRoundedCorners(false);
+            was_snapped_ = false;
+          }
           NotifyWindowRestore();
+        }
         last_window_state_ = ui::mojom::WindowShowState::kMaximized;
         NotifyWindowMaximize();
         ResetWindowControls();
@@ -542,6 +548,10 @@ void NativeWindowViews::HandleSizeEvent(WPARAM w_param, LPARAM l_param) {
             last_window_state_ = ui::mojom::WindowShowState::kFullscreen;
             NotifyWindowEnterFullScreen();
           } else {
+            if (was_snapped_) {
+              SetRoundedCorners(false);
+              was_snapped_ = false;
+            }
             last_window_state_ = ui::mojom::WindowShowState::kNormal;
             NotifyWindowRestore();
           }
Repository: ggml-org/llama.cpp
Pull request: llama : check returned fn ptrs from ggml_backend_reg_get_proc_address

This commit adds check for two function pointers returned from ggml_backend_reg_get_proc_address.

The motivation for this is that the function pointer could be nullptr if the get proc address function changes in the future. This is also consistent with all the other calls to ggml_backend_reg_get_proc_address in the code base.


Changed files:
filename: src/llama-context.cpp
patch: @@ -1447,7 +1447,9 @@ ggml_status llama_context::graph_compute(
     if (backend_cpu != nullptr) {
         auto * reg = ggml_backend_dev_backend_reg(ggml_backend_get_device(backend_cpu));
         auto * set_threadpool_fn = (decltype(ggml_backend_cpu_set_threadpool) *) ggml_backend_reg_get_proc_address(reg, "ggml_backend_cpu_set_threadpool");
-        set_threadpool_fn(backend_cpu, tp);
+        if (set_threadpool_fn) {
+            set_threadpool_fn(backend_cpu, tp);
+        }
     }
 
     // set the number of threads for all the backends

filename: src/llama.cpp
patch: @@ -83,7 +83,9 @@ void llama_numa_init(enum ggml_numa_strategy numa) {
         GGML_ASSERT(dev && "CPU backend is not loaded");
         auto * reg = ggml_backend_dev_backend_reg(dev);
         auto * numa_init_fn = (decltype(ggml_numa_init) *) ggml_backend_reg_get_proc_address(reg, "ggml_backend_cpu_numa_init");
-        numa_init_fn(numa);
+        if (numa_init_fn) {
+            numa_init_fn(numa);
+        }
     }
 }
Repository: ggml-org/llama.cpp
Pull request: server : fix typos in server.cpp comments [no ci]


Changed files:
filename: tools/server/server.cpp
patch: @@ -3608,7 +3608,7 @@ struct server_context {
                 slot.task->params.sampling.preserved_tokens.find(token) != slot.task->params.sampling.preserved_tokens.end();
         };
 
-        // frist, add sampled tokens from any ongoing sequences
+        // first, add sampled tokens from any ongoing sequences
         for (auto & slot : slots) {
             if (slot.state != SLOT_STATE_GENERATING) {
                 continue;
@@ -3950,7 +3950,7 @@ struct server_context {
                     // If using an alora, there may be uncached tokens that come
                     // before the invocation sequence. When this happens, the
                     // tokens before the invocation sequence need to be
-                    // processed without the adpter in a separate batch, then
+                    // processed without the adapter in a separate batch, then
                     // the adapter needs to be enabled for the remaining tokens.
                     if (lora_all_alora(slot.lora) && slot.alora_invocation_start - 1 > slot.prompt.n_tokens()) {
                         SLT_DBG(slot, "processing pre-alora tokens without the adapter (n_tokens = %d, alora_invocation_start = %d)\n", slot.prompt.n_tokens(), slot.alora_invocation_start);
Repository: electron/electron
Pull request: fix: snapped restoration after minimization

Backport of #48142

See that PR for details.


Notes: Fixed an issue where snapped corner state wasn't properly restored after minimizing and then restoring.

Changed files:
filename: shell/browser/native_window_views.h
patch: @@ -311,6 +311,9 @@ class NativeWindowViews : public NativeWindow,
   // Whether the window is currently being moved.
   bool is_moving_ = false;
 
+  // Whether or not the window was previously snapped e.g. before minimizing.
+  bool was_snapped_ = false;
+
   std::variant<std::monostate, bool, SkColor> accent_color_;
 
   std::optional<gfx::Rect> pending_bounds_change_;

filename: shell/browser/native_window_views_win.cc
patch: @@ -464,11 +464,12 @@ bool NativeWindowViews::PreHandleMSG(UINT message,
       return false;
     }
     case WM_SYSCOMMAND: {
-      // Mask is needed to account for double clicking title bar to maximize
-      WPARAM max_mask = 0xFFF0;
-      if (transparent() && ((w_param & max_mask) == SC_MAXIMIZE)) {
+      WPARAM cmd = w_param & 0xFFF0;
+      // Needed to account for double clicking title bar to maximize.
+      if (transparent() && (cmd == SC_MAXIMIZE))
         return true;
-      }
+      if (cmd == SC_MINIMIZE)
+        was_snapped_ = IsSnapped();
       return false;
     }
     case WM_INITMENU: {
@@ -521,8 +522,13 @@ void NativeWindowViews::HandleSizeEvent(WPARAM w_param, LPARAM l_param) {
       // multiple times for one resize because of the SetWindowPlacement call.
       if (w_param == SIZE_MAXIMIZED &&
           last_window_state_ != ui::mojom::WindowShowState::kMaximized) {
-        if (last_window_state_ == ui::mojom::WindowShowState::kMinimized)
+        if (last_window_state_ == ui::mojom::WindowShowState::kMinimized) {
+          if (was_snapped_) {
+            SetRoundedCorners(false);
+            was_snapped_ = false;
+          }
           NotifyWindowRestore();
+        }
         last_window_state_ = ui::mojom::WindowShowState::kMaximized;
         NotifyWindowMaximize();
         ResetWindowControls();
@@ -544,6 +550,10 @@ void NativeWindowViews::HandleSizeEvent(WPARAM w_param, LPARAM l_param) {
             last_window_state_ = ui::mojom::WindowShowState::kFullscreen;
             NotifyWindowEnterFullScreen();
           } else {
+            if (was_snapped_) {
+              SetRoundedCorners(false);
+              was_snapped_ = false;
+            }
             last_window_state_ = ui::mojom::WindowShowState::kNormal;
             NotifyWindowRestore();
           }
Repository: facebook/react
Pull request: [compiler] Disable emit of .tsbuildinfo

## Summary
`@rollup/plugin-typescript` emits a warning while building, hinting that `outputToFilesystem` defaults to true.

Although "noEmit" is set to `true` for the tsconfig, rollup writes a `dist/.tsbuildinfo`. That file is then also shipped inside the npm module and doesn't offer any benefit for library consumers. Setting this option to false results in the file not being written and thus omitted from the npm module.

## How did you test this change?
`dist/.tsbuildinfo` is not emitted any more.

Changed files:
filename: compiler/packages/babel-plugin-react-compiler/package.json
patch: @@ -5,7 +5,8 @@
   "main": "dist/index.js",
   "license": "MIT",
   "files": [
-    "dist"
+    "dist",
+    "!*.tsbuildinfo"
   ],
   "scripts": {
     "build": "rimraf dist && rollup --config --bundleConfigAsCjs",

filename: compiler/packages/babel-plugin-react-compiler/rollup.config.js
patch: @@ -28,6 +28,7 @@ const DEV_ROLLUP_CONFIG = {
   plugins: [
     typescript({
       tsconfig: './tsconfig.json',
+      outputToFilesystem: true,
       compilerOptions: {
         noEmit: true,
       },
Repository: vuejs/vue
Pull request: CSS fixes for "Grid" example

Because `-user-select` on its own is not a valid CSS attribute, and because we don't discriminate browsers ;)


Changed files:
filename: examples/grid/style.css
patch: @@ -16,7 +16,8 @@ th {
   cursor: pointer;
   -webkit-user-select: none;
   -moz-user-select: none;
-  -user-select: none;
+  -ms-user-select: none;
+  user-select: none;
 }
 
 td {
@@ -55,4 +56,4 @@ th.active .arrow {
   border-left: 4px solid transparent;
   border-right: 4px solid transparent;
   border-top: 4px solid #fff;
-}
\ No newline at end of file
+}
Repository: facebook/react
Pull request: Log passive commit phase when it wasn't delayed

Fixes a bug.

We're supposed to not log "Waiting for Paint" if the passive effect phase was forced since we weren't really waiting until the paint. Instead we just log an empty string when we force it to still ensure continuity.

We should always log the passive phase. This check was in the wrong place.


Changed files:
filename: packages/react-reconciler/src/ReactFiberPerformanceTrack.js
patch: @@ -221,12 +221,19 @@ export function logCommitPhase(startTime: number, endTime: number): void {
   }
 }
 
-export function logPaintYieldPhase(startTime: number, endTime: number): void {
+export function logPaintYieldPhase(
+  startTime: number,
+  endTime: number,
+  delayedUntilPaint: boolean,
+): void {
   if (supportsUserTiming) {
     reusableLaneDevToolDetails.color = 'secondary-light';
     reusableLaneOptions.start = startTime;
     reusableLaneOptions.end = endTime;
-    performance.measure('Waiting for Paint', reusableLaneOptions);
+    performance.measure(
+      delayedUntilPaint ? 'Waiting for Paint' : '',
+      reusableLaneOptions,
+    );
   }
 }
 

filename: packages/react-reconciler/src/ReactFiberWorkLoop.js
patch: @@ -3550,7 +3550,11 @@ function flushPassiveEffectsImpl(wasDelayedCommit: void | boolean) {
   let passiveEffectStartTime = 0;
   if (enableProfilerTimer && enableComponentPerformanceTrack) {
     passiveEffectStartTime = now();
-    logPaintYieldPhase(commitEndTime, passiveEffectStartTime);
+    logPaintYieldPhase(
+      commitEndTime,
+      passiveEffectStartTime,
+      !!wasDelayedCommit,
+    );
   }
 
   if (enableSchedulingProfiler) {
@@ -3587,9 +3591,7 @@ function flushPassiveEffectsImpl(wasDelayedCommit: void | boolean) {
 
   if (enableProfilerTimer && enableComponentPerformanceTrack) {
     const passiveEffectsEndTime = now();
-    if (wasDelayedCommit) {
-      logPassiveCommitPhase(passiveEffectStartTime, passiveEffectsEndTime);
-    }
+    logPassiveCommitPhase(passiveEffectStartTime, passiveEffectsEndTime);
     finalizeRender(lanes, passiveEffectsEndTime);
   }
Repository: huggingface/transformers
Pull request: DataCollatorForLanguageModeling warning error fixed

# What does this PR do?

This PR fixes a bug in the `DataCollatorForLanguageModeling` class that causes a `TypeError` when instantiating the data collator with `whole_word_mask=True`.

## Problem

When users try to instantiate `DataCollatorForLanguageModeling` with `whole_word_mask=True`, they encounter the following error:

```python
TypeError: category must be a Warning subclass, not 'str'
This error occurs in the __post_init__ method at line 724-727, where warnings.warn() is called incorrectly with two separate string arguments. The second string is being interpreted as the category parameter, which must be a Warning subclass (like UserWarning), not a string.
Solution
The fix combines the two warning message strings into a single message and explicitly passes UserWarning as the category parameter, following the pattern used elsewhere in the same file (e.g., line 719-722). Before:
warnings.warn(
    "Random token replacement is not supported with whole word masking.",
    "Setting mask_replace_prob to 1.",
)
After:
warnings.warn(
    "Random token replacement is not supported with whole word masking. "
    "Setting mask_replace_prob to 1.",
    UserWarning,
)
This ensures the data collator can be instantiated correctly when using whole word masking for masked language modeling tasks.
Before submitting
 This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
 Did you read the [contributor guideline](https://github.com/huggingface/transformers/blob/main/CONTRIBUTING.md#create-a-pull-request), Pull Request section?
 Was this discussed/approved via a Github issue or the [forum](https://discuss.huggingface.co/)? Please add a link to it if that's the case.
 Did you make sure to update the documentation with your changes? Here are the [documentation guidelines](https://github.com/huggingface/transformers/tree/main/docs), and [here are tips on formatting docstrings](https://github.com/huggingface/transformers/tree/main/docs#writing-source-documentation).
 Did you write any new necessary tests?
Who can review?
@SunMarc @ArthurZucker - This is a small bug fix in the data collator that prevents instantiation with whole word masking enabled.
Note: Discovered and fixed by @mjaliz
y


Changed files:
filename: src/transformers/data/data_collator.py
patch: @@ -723,7 +723,7 @@ def __post_init__(self):
 
             if self.mask_replace_prob < 1:
                 warnings.warn(
-                    "Random token replacement is not supported with whole word masking.",
+                    "Random token replacement is not supported with whole word masking. "
                     "Setting mask_replace_prob to 1.",
                 )
                 self.mask_replace_prob = 1
Repository: ollama/ollama
Pull request: Switch ARM64 container image base to rocky 8

The centos 7 arm mirrors have disappeared due to the EOL 2 days ago, and the vault sed workaround which works for x86 doesn't work for arm.

Changed files:
filename: Dockerfile
patch: @@ -70,12 +70,12 @@ RUN OLLAMA_SKIP_STATIC_GENERATE=1 OLLAMA_CPU_TARGET="cpu_avx" sh gen_linux.sh
 FROM --platform=linux/amd64 cpu-builder-amd64 AS cpu_avx2-build-amd64
 RUN OLLAMA_SKIP_STATIC_GENERATE=1 OLLAMA_CPU_TARGET="cpu_avx2" sh gen_linux.sh
 
-FROM --platform=linux/arm64 centos:7 AS cpu-builder-arm64
+FROM --platform=linux/arm64 rockylinux:8 AS cpu-builder-arm64
 ARG CMAKE_VERSION
 ARG GOLANG_VERSION
 COPY ./scripts/rh_linux_deps.sh /
 RUN CMAKE_VERSION=${CMAKE_VERSION} GOLANG_VERSION=${GOLANG_VERSION} sh /rh_linux_deps.sh
-ENV PATH /opt/rh/devtoolset-10/root/usr/bin:$PATH
+ENV PATH /opt/rh/gcc-toolset-10/root/usr/bin:$PATH
 COPY --from=llm-code / /go/src/github.com/ollama/ollama/
 ARG OLLAMA_CUSTOM_CPU_DEFS
 ARG CGO_CFLAGS
Repository: vercel/next.js
Pull request: Turbopack: move whole_app_module_graphs to top level

### What?

That makes a tracing look a bit better

Changed files:
filename: crates/napi/src/next_api/project.rs
patch: @@ -1008,8 +1008,9 @@ async fn output_assets_operation(
     container: ResolvedVc<ProjectContainer>,
     app_dir_only: bool,
 ) -> Result<Vc<OutputAssets>> {
-    let endpoint_assets = container
-        .project()
+    let project = container.project();
+    let whole_app_module_graphs = project.whole_app_module_graphs();
+    let endpoint_assets = project
         .get_all_endpoints(app_dir_only)
         .await?
         .iter()
@@ -1022,7 +1023,9 @@ async fn output_assets_operation(
         .flat_map(|assets| assets.iter().copied())
         .collect();
 
-    let nft = next_server_nft_assets(container.project()).await?;
+    let nft = next_server_nft_assets(project).await?;
+
+    whole_app_module_graphs.as_side_effect().await?;
 
     Ok(Vc::cell(
         output_assets