helloadhavan/github_issues huggingface dataset:
Repository: nodejs/node
Pull request: deps: update corepack to 0.34.0

This is an automated update of corepack to 0.34.0.

Changed files:
filename: deps/corepack/CHANGELOG.md
patch: @@ -1,5 +1,21 @@
 # Changelog
 
+## [0.34.0](https://github.com/nodejs/corepack/compare/v0.33.0...v0.34.0) (2025-07-19)
+
+
+### ⚠ BREAKING CHANGES
+
+* drop Node.js 18.x and 23.x support
+
+### Features
+
+* update package manager versions ([#719](https://github.com/nodejs/corepack/issues/719)) ([7707ea7](https://github.com/nodejs/corepack/commit/7707ea7350c129ad3aae8ca08e9e80fcf164dcb6))
+
+
+### Miscellaneous Chores
+
+* remove Node.js 18.x and 23.x usage, add 24.x ([#718](https://github.com/nodejs/corepack/issues/718)) ([783a42f](https://github.com/nodejs/corepack/commit/783a42fbe35371964e9dde75e2263b179f53bc0c))
+
 ## [0.33.0](https://github.com/nodejs/corepack/compare/v0.32.0...v0.33.0) (2025-06-02)
 
 

filename: deps/corepack/README.md
patch: @@ -11,7 +11,7 @@ and pnpm without having to install them**.
 
 ### Default Installs
 
-Corepack is [distributed by default with all recent Node.js versions](https://nodejs.org/api/corepack.html).
+Corepack is distributed with Node.js from version 14.19.0 up to (but not including) 25.0.0.
 Run `corepack enable` to install the required Yarn and pnpm binaries on your path.
 
 ### Manual Installs

filename: deps/corepack/dist/lib/corepack.cjs
patch: @@ -21683,7 +21683,7 @@ function String2(descriptor, ...args) {
 }
 
 // package.json
-var version = "0.33.0";
+var version = "0.34.0";
 
 // sources/Engine.ts
 var import_fs9 = __toESM(require("fs"));
@@ -21697,7 +21697,7 @@ var import_valid4 = __toESM(require_valid2());
 var config_default = {
   definitions: {
     npm: {
-      default: "11.4.1+sha1.80350af543069991de20657ebcd07d9624cfad06",
+      default: "11.4.2+sha1.6f1519a03f7e04023a957a22b812832d0c4a4b33",
       fetchLatestFrom: {
         type: "npm",
         package: "npm"
@@ -21734,7 +21734,7 @@ var config_default = {
       }
     },
     pnpm: {
-      default: "10.11.0+sha1.4048eeefd564ff1ab248fac3e2854d38245fe2f1",
+      default: "10.13.1+sha1.aa8c167c4509c97519542ef77a09e4b8ab59fb6a",
       fetchLatestFrom: {
         type: "npm",
         package: "pnpm"
@@ -21798,7 +21798,7 @@ var config_default = {
         package: "yarn"
       },
       transparent: {
-        default: "4.9.1+sha224.4285002185abb91fe2b781f27fd1e078086c37a7b095f6ea4ee25971",
+        default: "4.9.2+sha224.b8e0b161ae590950fbda696e6f3ca071362768e5280c5fbfdadf064b",
         commands: [
           [
             "yarn",

filename: deps/corepack/package.json
patch: @@ -1,6 +1,6 @@
 {
   "name": "corepack",
-  "version": "0.33.0",
+  "version": "0.34.0",
   "homepage": "https://github.com/nodejs/corepack#readme",
   "bugs": {
     "url": "https://github.com/nodejs/corepack/issues"
@@ -10,7 +10,7 @@
     "url": "https://github.com/nodejs/corepack.git"
   },
   "engines": {
-    "node": "^18.17.1 || ^20.10.0 || >=22.11.0"
+    "node": "^20.10.0 || ^22.11.0 || >=24.0.0"
   },
   "exports": {
     "./package.json": "./package.json"
Repository: ggml-org/llama.cpp
Pull request: ggml : fix GGML_DEBUG with OpenMP

last_graph is only available without OpenMP, but
ggml_graph_compute_thread() is called in both cases.

Changed files:
filename: ggml/src/ggml-cpu/ggml-cpu.c
patch: @@ -2947,7 +2947,11 @@ static thread_ret_t ggml_graph_compute_thread(void * data) {
         /*.use_ref    =*/ cplan->use_ref,
     };
 
-    GGML_PRINT_DEBUG("thread #%d compute-start cplan %p last-graph %d \n", state->ith, cplan, state->last_graph);
+#ifdef GGML_USE_OPENMP
+    GGML_PRINT_DEBUG("thread #%d compute-start cplan %p\n", state->ith, (const void *)cplan);
+#else
+    GGML_PRINT_DEBUG("thread #%d compute-start cplan %p last-graph %d\n", state->ith, (const void *)cplan, state->last_graph);
+#endif
 
     for (int node_n = 0; node_n < cgraph->n_nodes && atomic_load_explicit(&tp->abort, memory_order_relaxed) != node_n; node_n++) {
         struct ggml_tensor * node = cgraph->nodes[node_n];
@@ -2974,7 +2978,11 @@ static thread_ret_t ggml_graph_compute_thread(void * data) {
         }
     }
 
-    GGML_PRINT_DEBUG("thread #%d compute-done cplan %p last-graph %d \n", state->ith, cplan, state->last_graph);
+#ifdef GGML_USE_OPENMP
+    GGML_PRINT_DEBUG("thread #%d compute-done cplan %p\n", state->ith, (const void *)cplan);
+#else
+    GGML_PRINT_DEBUG("thread #%d compute-done cplan %p last-graph %d\n", state->ith, (const void *)cplan, state->last_graph);
+#endif
 
     ggml_barrier(state->threadpool);
Repository: ollama/ollama
Pull request: Add basic mllama integration tests

Draft until I run it against a few more systems and make sure the timeout values are reasonable

Changed files:
filename: integration/llm_image_test.go
patch: @@ -12,7 +12,7 @@ import (
 	"github.com/stretchr/testify/require"
 )
 
-func TestIntegrationMultimodal(t *testing.T) {
+func TestIntegrationLlava(t *testing.T) {
 	image, err := base64.StdEncoding.DecodeString(imageEncoding)
 	require.NoError(t, err)
 	req := api.GenerateRequest{
@@ -39,6 +39,33 @@ func TestIntegrationMultimodal(t *testing.T) {
 	DoGenerate(ctx, t, client, req, []string{resp}, 120*time.Second, 30*time.Second)
 }
 
+func TestIntegrationMllama(t *testing.T) {
+	image, err := base64.StdEncoding.DecodeString(imageEncoding)
+	require.NoError(t, err)
+	req := api.GenerateRequest{
+		// TODO fix up once we publish the final image
+		Model:  "x/llama3.2-vision",
+		Prompt: "what does the text in this image say?",
+		Stream: &stream,
+		Options: map[string]interface{}{
+			"seed":        42,
+			"temperature": 0.0,
+		},
+		Images: []api.ImageData{
+			image,
+		},
+	}
+
+	resp := "the ollamas"
+	ctx, cancel := context.WithTimeout(context.Background(), 5*time.Minute)
+	defer cancel()
+	client, _, cleanup := InitServerConnection(ctx, t)
+	defer cleanup()
+	require.NoError(t, PullIfMissing(ctx, client, req.Model))
+	// mllama models on CPU can be quite slow to start,
+	DoGenerate(ctx, t, client, req, []string{resp}, 240*time.Second, 30*time.Second)
+}
+
 const imageEncoding = `iVBORw0KGgoAAAANSUhEUgAAANIAAAB4CAYAAACHHqzKAAAAAXNSR0IArs4c6QAAAIRlWElmTU0AKgAAAAgABQESAAMAAAABAAEAAAEaAAUAAAABAAAASgEb
 AAUAAAABAAAAUgEoAAMAAAABAAIAAIdpAAQAAAABAAAAWgAAAAAAAABIAAAAAQAAAEgAAAABAAOgAQADAAAAAQABAACgAgAEAAAAAQAAANKgAwAEAAAAAQAA
 AHgAAAAAXdsepgAAAAlwSFlzAAALEwAACxMBAJqcGAAAAVlpVFh0WE1MOmNvbS5hZG9iZS54bXAAAAAAADx4OnhtcG1ldGEgeG1sbnM6eD0iYWRvYmU6bnM6
Repository: facebook/react
Pull request: [ci] mkdir before mv


Missed this earlier.


Changed files:
filename: .github/workflows/runtime_commit_artifacts.yml
patch: @@ -108,6 +108,7 @@ jobs:
           mv build/__test_utils__/ReactAllWarnings.js ./compiled/facebook-www/__test_utils__/ReactAllWarnings.js
 
           # Move eslint-plugin-react-hooks into eslint-plugin-react-hooks
+          mkdir ./compiled/eslint-plugin-react-hooks
           mv build/oss-experimental/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js \
             ./compiled/eslint-plugin-react-hooks/index.js
Repository: ggml-org/llama.cpp
Pull request: build : NetBSD support

Add NetBSD build support, tested on both Linux (Ubuntu/amd64) and NetBSD (amd64).

Changed files:
filename: common/common.cpp
patch: @@ -879,7 +879,8 @@ std::string fs_get_cache_directory() {
     if (getenv("LLAMA_CACHE")) {
         cache_directory = std::getenv("LLAMA_CACHE");
     } else {
-#if defined(__linux__) || defined(__FreeBSD__) || defined(_AIX) || defined(__OpenBSD__)
+#if defined(__linux__) || defined(__FreeBSD__) || defined(_AIX) || \
+        defined(__OpenBSD__) || defined(__NetBSD__)
         if (std::getenv("XDG_CACHE_HOME")) {
             cache_directory = std::getenv("XDG_CACHE_HOME");
         } else if (std::getenv("HOME")) {

filename: tools/rpc/rpc-server.cpp
patch: @@ -132,7 +132,8 @@ static std::string fs_get_cache_directory() {
     if (getenv("LLAMA_CACHE")) {
         cache_directory = std::getenv("LLAMA_CACHE");
     } else {
-#if defined(__linux__) || defined(__FreeBSD__) || defined(_AIX) || defined(__OpenBSD__)
+#if defined(__linux__) || defined(__FreeBSD__) || defined(_AIX) || \
+    defined(__OpenBSD__) || defined(__NetBSD__)
         if (std::getenv("XDG_CACHE_HOME")) {
             cache_directory = std::getenv("XDG_CACHE_HOME");
         } else if (std::getenv("HOME")) {
Repository: vuejs/vue
Pull request: feat: Add `async` to body scripts (update: Use `defer` instead)


**What kind of change does this PR introduce?** (check at least one)

- [x] Feature

**Does this PR introduce a breaking change?** (check one)

- [x] No

If yes, please describe the impact and migration path for existing applications:

**The PR fulfills these requirements:**

- [x] It's submitted to the `dev` branch for v2.x (or to a previous version branch), _not_ the `master` branch
- [x] New/updated tests are included
- [x] All tests are passing: https://github.com/vuejs/vue/blob/dev/.github/CONTRIBUTING.md#development-setup

If adding a **new feature**, the PR's description includes:

`async` tag let the scripts to not block the render of the page, and since it's for SSR, the scripts don't have to be loaded before the first render.



Changed files:
filename: src/server/template-renderer/index.js
patch: @@ -209,7 +209,7 @@ export default class TemplateRenderer {
       const async = this.getUsedAsyncFiles(context)
       const needed = [initial[0]].concat(async || [], initial.slice(1))
       return needed.filter(isJS).map(file => {
-        return `<script src="${this.publicPath}/${file}"></script>`
+        return `<script src="${this.publicPath}/${file}" defer></script>`
       }).join('')
     } else {
       return ''

filename: test/ssr/ssr-template.spec.js
patch: @@ -238,10 +238,10 @@ describe('SSR: template option', () => {
       // state should be inlined before scripts
       `<script>window.${options.stateKey || '__INITIAL_STATE__'}={"a":1}</script>` +
       // manifest chunk should be first
-      `<script src="/manifest.js"></script>` +
+      `<script src="/manifest.js" defer></script>` +
       // async chunks should be before main chunk
-      `<script src="/0.js"></script>` +
-      `<script src="/main.js"></script>` +
+      `<script src="/0.js" defer></script>` +
+      `<script src="/main.js" defer></script>` +
     `</body></html>`
 
   createClientManifestAssertions(true)
Repository: ollama/ollama
Pull request: Give unicode test more time to run

Some slower GPUs (or partial CPU/GPU loads) can take more than the default 30s to complete this test

Changed files:
filename: integration/basic_test.go
patch: @@ -31,7 +31,7 @@ func TestOrcaMiniBlueSky(t *testing.T) {
 }
 
 func TestUnicode(t *testing.T) {
-	ctx, cancel := context.WithTimeout(context.Background(), 2*time.Minute)
+	ctx, cancel := context.WithTimeout(context.Background(), 3*time.Minute)
 	defer cancel()
 	// Set up the test data
 	req := api.GenerateRequest{
@@ -42,9 +42,15 @@ func TestUnicode(t *testing.T) {
 		Options: map[string]interface{}{
 			"temperature": 0,
 			"seed":        123,
+			// Workaround deepseek context shifting bug
+			"num_ctx":     8192,
+			"num_predict": 2048,
 		},
 	}
-	GenerateTestHelper(ctx, t, req, []string{"散射", "频率"})
+	client, _, cleanup := InitServerConnection(ctx, t)
+	defer cleanup()
+	require.NoError(t, PullIfMissing(ctx, client, req.Model))
+	DoGenerate(ctx, t, client, req, []string{"散射", "频率"}, 120*time.Second, 120*time.Second)
 }
 
 func TestExtendedUnicodeOutput(t *testing.T) {
@@ -60,7 +66,10 @@ func TestExtendedUnicodeOutput(t *testing.T) {
 			"seed":        123,
 		},
 	}
-	GenerateTestHelper(ctx, t, req, []string{"😀", "😊", "😁", "😂", "😄", "😃"})
+	client, _, cleanup := InitServerConnection(ctx, t)
+	defer cleanup()
+	require.NoError(t, PullIfMissing(ctx, client, req.Model))
+	DoGenerate(ctx, t, client, req, []string{"😀", "😊", "😁", "😂", "😄", "😃"}, 120*time.Second, 120*time.Second)
 }
 
 func TestUnicodeModelDir(t *testing.T) {

filename: integration/concurrency_test.go
patch: @@ -60,7 +60,8 @@ func TestMultiModelConcurrency(t *testing.T) {
 	for i := 0; i < len(req); i++ {
 		go func(i int) {
 			defer wg.Done()
-			DoGenerate(ctx, t, client, req[i], resp[i], 60*time.Second, 10*time.Second)
+			// Note: CPU based inference can crawl so don't give up too quickly
+			DoGenerate(ctx, t, client, req[i], resp[i], 90*time.Second, 30*time.Second)
 		}(i)
 	}
 	wg.Wait()
Repository: vercel/next.js
Pull request: Add pino-related packages to server-external-packages

Closes #86099

Changed files:
filename: docs/01-app/03-api-reference/05-config/01-next-config-js/serverExternalPackages.mdx
patch: @@ -73,6 +73,9 @@ Next.js includes a [short list of popular packages](https://github.com/vercel/ne
 - `onnxruntime-node`
 - `oslo`
 - `pg`
+- `pino`
+- `pino-pretty`
+- `pino-roll`
 - `playwright`
 - `playwright-core`
 - `postcss`
@@ -86,8 +89,9 @@ Next.js includes a [short list of popular packages](https://github.com/vercel/ne
 - `sharp`
 - `shiki`
 - `sqlite3`
-- `ts-node`
+- `thread-stream`
 - `ts-morph`
+- `ts-node`
 - `typescript`
 - `vscode-oniguruma`
 - `webpack`

filename: docs/02-pages/04-api-reference/04-config/01-next-config-js/serverExternalPackages.mdx
patch: @@ -73,6 +73,9 @@ Next.js includes a [short list of popular packages](https://github.com/vercel/ne
 - `onnxruntime-node`
 - `oslo`
 - `pg`
+- `pino`
+- `pino-pretty`
+- `pino-roll`
 - `playwright`
 - `playwright-core`
 - `postcss`
@@ -86,8 +89,9 @@ Next.js includes a [short list of popular packages](https://github.com/vercel/ne
 - `sharp`
 - `shiki`
 - `sqlite3`
-- `ts-node`
+- `thread-stream`
 - `ts-morph`
+- `ts-node`
 - `typescript`
 - `vscode-oniguruma`
 - `webpack`

filename: packages/next/src/lib/server-external-packages.jsonc
patch: @@ -65,6 +65,14 @@
   "onnxruntime-node",
   "oslo",
   "pg",
+  // pino@10.1.0/lib/transport.js passes `join(__dirname, 'worker.js')` to thread-stream which ends
+  // up `require`ing that filepath, leading to
+  // `Cannot find module '/ROOT/node_modules/.pnpm/pino@10.1.0/node_modules/pino/lib/worker.js'`
+  "pino",
+  // A "plugin" that is passed to pino as a string (and is then required in a worker)
+  "pino-pretty",
+  // A "plugin" that is passed to pino as a string (and is then required in a worker)
+  "pino-roll",
   "playwright",
   "playwright-core",
   "postcss",
@@ -80,9 +88,12 @@
   "sharp",
   "shiki",
   "sqlite3",
-  "ts-node",
+  // dynamic `new Worker` call in thread-stream@3.1.0/index.js which pulls in various non-code files
+  // as well (trying to parse README and invalid test files)
+  "thread-stream",
   // Slow to compile because it pulls in typescript
   "ts-morph",
+  "ts-node",
   "typescript",
   "vscode-oniguruma",
   "webpack",
Repository: nodejs/node
Pull request: doc: add scroll margin to links

Before: Opening a section link like [this one](https://nodejs.org/docs/latest/api/os.html#oscpus) would hide the section title behind the sticky stability header:

<img width="312" alt="Screenshot 2025-07-07 at 15 45 46" src="https://github.com/user-attachments/assets/862647fa-500d-4e45-af19-e05c30b59505" />

After: Page scroll is offset by 50px so the section header is visible:

<img width="312" alt="Screenshot 2025-07-07 at 15 45 57" src="https://github.com/user-attachments/assets/97ceb6b3-6650-4e44-a601-8bd32aead833" />

The value change is undone below 600px where it is not an issue because the page header is not sticky.

Changed files:
filename: doc/api_assets/style.css
patch: @@ -373,6 +373,11 @@ p {
   padding-bottom: 2rem;
 }
 
+/* prevent the module-level sticky stability header from overlapping the section headers when clicked */
+#apicontent:has(> .api_stability) a {
+  scroll-margin-top: 50px;
+}
+
 table {
   border-collapse: collapse;
   margin: 0 0 1.5rem;
@@ -837,6 +842,9 @@ kbd {
   .api_stability {
     top: 0;
   }
+  #apicontent a {
+    scroll-margin-top: 0;
+  }
 }
 
 @media not screen, (max-height: 1000px) {
Repository: facebook/react
Pull request: [ci] Update eslint-plugin-react-hooks output location for Meta builds


Updates where this file is output so we can sync it independently to another directory.


Changed files:
filename: .github/workflows/runtime_commit_artifacts.yml
patch: @@ -107,9 +107,9 @@ jobs:
           mkdir ./compiled/facebook-www/__test_utils__
           mv build/__test_utils__/ReactAllWarnings.js ./compiled/facebook-www/__test_utils__/ReactAllWarnings.js
 
-          # Move eslint-plugin-react-hooks into facebook-www
+          # Move eslint-plugin-react-hooks into eslint-plugin-react-hooks
           mv build/oss-experimental/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js \
-            ./compiled/facebook-www/eslint-plugin-react-hooks.js
+            ./compiled/eslint-plugin-react-hooks/index.js
 
           # Move unstable_server-external-runtime.js into facebook-www
           mv build/oss-experimental/react-dom/unstable_server-external-runtime.js \
Repository: ollama/ollama
Pull request: Move windows app out of preview


Changed files:
filename: README.md
patch: @@ -12,7 +12,7 @@ Get up and running with large language models.
 
 [Download](https://ollama.com/download/Ollama-darwin.zip)
 
-### Windows preview
+### Windows
 
 [Download](https://ollama.com/download/OllamaSetup.exe)
 

filename: docs/windows.md
patch: @@ -1,22 +1,15 @@
-# Ollama Windows Preview
+# Ollama Windows
 
-Welcome to the Ollama Windows preview.
+Welcome to Ollama for Windows.
 
 No more WSL required!
 
 Ollama now runs as a native Windows application, including NVIDIA and AMD Radeon GPU support.
-After installing Ollama Windows Preview, Ollama will run in the background and
+After installing Ollama for Windows, Ollama will run in the background and
 the `ollama` command line is available in `cmd`, `powershell` or your favorite
 terminal application. As usual the Ollama [api](./api.md) will be served on
 `http://localhost:11434`.
 
-As this is a preview release, you should expect a few bugs here and there.  If
-you run into a problem you can reach out on
-[Discord](https://discord.gg/ollama), or file an
-[issue](https://github.com/ollama/ollama/issues).
-Logs will often be helpful in diagnosing the problem (see
-[Troubleshooting](#troubleshooting) below)
-
 ## System Requirements
 
 * Windows 10 22H2 or newer, Home or Pro
@@ -60,10 +53,6 @@ Here's a quick example showing API access from `powershell`
 
 ## Troubleshooting
 
-While we're in preview, `OLLAMA_DEBUG` is always enabled, which adds
-a "view logs" menu item to the app, and increases logging for the GUI app and
-server.
-
 Ollama on Windows stores files in a few different locations.  You can view them in
 the explorer window by hitting `<cmd>+R` and type in:
 - `explorer %LOCALAPPDATA%\Ollama` contains logs, and downloaded updates
Repository: vuejs/vue
Pull request: fix: prefetch should not have `as` attribute


**What kind of change does this PR introduce?**

- [x] Bugfix

**Does this PR introduce a breaking change?**

- [x] No

**The PR fulfills these requirements:**

- [x] It's submitted to the `dev` branch for v2.x (or to a previous version branch), _not_ the `master` branch
- [x] All tests are passing: https://github.com/vuejs/vue/blob/dev/.github/CONTRIBUTING.md#development-setup
- [x] New/updated tests are included

**Other information:**

Actually, `vue-server-renderer` does not generate valid HTML because of the `as` attribute on `rel="prefetch"`, this PR fix this issue.

![screenshot_2017-05-16_17-36-56](https://cloud.githubusercontent.com/assets/904724/26116449/7c701838-3a63-11e7-9c17-ed64b5b5cbd3.png)


Changed files:
filename: src/server/template-renderer/index.js
patch: @@ -181,7 +181,7 @@ export default class TemplateRenderer {
       }
       return this.prefetchFiles.map(file => {
         if (!alreadyRendered(file)) {
-          return `<link rel="prefetch" href="${this.publicPath}/${file}" as="script">`
+          return `<link rel="prefetch" href="${this.publicPath}/${file}">`
         } else {
           return ''
         }

filename: test/ssr/ssr-template.spec.js
patch: @@ -230,7 +230,7 @@ describe('SSR: template option', () => {
       (options.preloadOtherAssets ? `<link rel="preload" href="/test.png" as="image">` : ``) +
       (options.preloadOtherAssets ? `<link rel="preload" href="/test.woff2" as="font" type="font/woff2" crossorigin>` : ``) +
       // unused chunks should have prefetch
-      `<link rel="prefetch" href="/1.js" as="script">` +
+      `<link rel="prefetch" href="/1.js">` +
       // css assets should be loaded
       `<link rel="stylesheet" href="/test.css">` +
     `</head><body>` +
Repository: electron/electron
Pull request: fix: the parent window remained interactive after the modal window was opened

Backport of #48770

See that PR for details.


Notes: Fixed the issue where the parent window remained interactive after the modal window was opened.

Changed files:
filename: shell/browser/native_window.cc
patch: @@ -104,7 +104,8 @@ NativeWindow::NativeWindow(const gin_helper::Dictionary& options,
       transparent_{options.ValueOrDefault(options::kTransparent, false)},
       enable_larger_than_screen_{
           options.ValueOrDefault(options::kEnableLargerThanScreen, false)},
-      is_modal_{parent != nullptr && options.ValueOrDefault("modal", false)},
+      is_modal_{parent != nullptr &&
+                options.ValueOrDefault(options::kModal, false)},
       has_frame_{options.ValueOrDefault(options::kFrame, true) &&
                  title_bar_style_ == TitleBarStyle::kNormal},
       parent_{parent} {

filename: shell/browser/native_window_views.cc
patch: @@ -553,7 +553,7 @@ bool NativeWindowViews::IsFocused() const {
 }
 
 void NativeWindowViews::Show() {
-  if (is_modal() && NativeWindow::parent() && !widget()->IsVisible())
+  if (is_modal() && NativeWindow::parent())
     static_cast<NativeWindowViews*>(parent())->IncrementChildModals();
 
   widget()->native_widget_private()->Show(GetRestoredState(), gfx::Rect());

filename: shell/common/options_switches.h
patch: @@ -222,6 +222,8 @@ inline constexpr std::string_view kSpellcheck = "spellcheck";
 inline constexpr std::string_view kEnableDeprecatedPaste =
     "enableDeprecatedPaste";
 
+inline constexpr std::string_view kModal = "modal";
+
 }  // namespace options
 
 // Following are actually command line switches, should be moved to other files.
Repository: vercel/next.js
Pull request: Turbopack: handle non-serializable cell content for cell update operation

### What?

A `TypedSharedReference` might not be serializable, so we might not be able to serialize the UpdateCellOperation. This avoids the suspend points while we store non-serializable content.

Changed files:
filename: turbopack/crates/turbo-tasks-backend/src/backend/operation/update_cell.rs
patch: @@ -165,12 +165,29 @@ impl UpdateCellOperation {
             in_progress.event.notify(usize::MAX);
         }
     }
+
+    fn is_serializable(&self) -> bool {
+        match self {
+            UpdateCellOperation::InvalidateWhenCellDependency {
+                is_serializable_cell_content,
+                ..
+            } => *is_serializable_cell_content,
+            UpdateCellOperation::FinalCellChange {
+                is_serializable_cell_content,
+                ..
+            } => *is_serializable_cell_content,
+            UpdateCellOperation::AggregationUpdate { .. } => true,
+            UpdateCellOperation::Done => true,
+        }
+    }
 }
 
 impl Operation for UpdateCellOperation {
     fn execute(mut self, ctx: &mut impl ExecuteContext) {
         loop {
-            ctx.operation_suspend_point(&self);
+            if self.is_serializable() {
+                ctx.operation_suspend_point(&self);
+            }
             match self {
                 UpdateCellOperation::InvalidateWhenCellDependency {
                     is_serializable_cell_content,