helloadhavan/github_issues huggingface dataset:
Repository: huggingface/transformers
Pull request: Update torchcodec to match torchaudio version

There is an issue in the latest AMD container: along with ROCm, `torch` was updated, so the `torchcodec` version does not match anymore. This PR fixes this, which in turn fixes `whisper` tests, and I imagine other audio model's tests.

Changed files:
filename: docker/transformers-pytorch-amd-gpu/Dockerfile
patch: @@ -34,7 +34,7 @@ RUN python3 -m pip uninstall py3nvml pynvml nvidia-ml-py apex -y
 RUN python3 -m pip uninstall -y kernels
 
 # On ROCm, torchcodec is required to decode audio files and 0.4 or 0.6 fails
-RUN python3 -m pip install --no-cache-dir "torchcodec==0.5"
+RUN python3 -m pip install --no-cache-dir "torchcodec==0.7"
 
 # Install flash attention from source. Tested with commit 6387433156558135a998d5568a9d74c1778666d8
 RUN git clone https://github.com/ROCm/flash-attention/ -b tridao && \
Repository: ggml-org/llama.cpp
Pull request: ggml-cpu: aarm64: remove asserts always evaluating to false in repack

I got an email reporting the issue. I can't find the original comment.
For gemv these asserts don't make sense, as nr will always be 1

Changed files:
filename: ggml/src/ggml-cpu/arch/arm/repack.cpp
patch: @@ -505,7 +505,6 @@ void ggml_gemv_q4_K_8x4_q8_K(int n, float * GGML_RESTRICT s, size_t bs, const vo
     constexpr int blocklen          = 8;
 
     assert(n % qk == 0);
-    assert(nr % 4 == 0);
     assert(nc % ncols_interleaved == 0);
 
     UNUSED(nb);
@@ -645,7 +644,6 @@ void ggml_gemv_q4_K_8x8_q8_K(int                        n,
     constexpr int blocklen          = 8;
 
     assert(n % qk == 0);
-    assert(nr % 4 == 0);
     assert(nc % ncols_interleaved == 0);
 
     UNUSED(nb);
Repository: nodejs/node
Pull request: test: increase debugger waitFor timeout on macOS

`test/parallel/test-debugger-exceptions.js` is flaky on macOS in GitHub Action workflow.
Increase the timeout to reduce the flakyness.

Refs: https://github.com/nodejs/node/actions/runs/18694915575/job/53309761263?pr=60343

Changed files:
filename: test/common/debugger.js
patch: @@ -7,12 +7,10 @@ const BREAK_MESSAGE = new RegExp('(?:' + [
   'exception', 'other', 'promiseRejection', 'step',
 ].join('|') + ') in', 'i');
 
-// Some macOS machines require more time to receive the outputs from the client.
 let TIMEOUT = common.platformTimeout(10000);
-if (common.isWindows) {
-  // Some of the windows machines in the CI need more time to receive
-  // the outputs from the client.
-  // https://github.com/nodejs/build/issues/3014
+// Some macOS and Windows machines require more time to receive the outputs from the client.
+// https://github.com/nodejs/build/issues/3014
+if (common.isWindows || common.isMacOS) {
   TIMEOUT = common.platformTimeout(15000);
 }
Repository: vuejs/vue
Pull request: warn user calling Vue() without new

Hi,

Open to different wording on the error & I wasn't sure where to put these tests so I've put them in a new file for now. 

An alternative to this PR would be something like:

``` diff
function Vue (options) {
+  if (!(this instanceof Vue)) {
+    return new Vue(options)
+  }
   this._init(options)
}
```

I'm not sure which would be better in the long run but the alternative would be more forgiving.

I could also wrap this in env check so this is left out of the production build, but it's also not a lot of code to leave in.

Let me know what you think.


Changed files:
filename: src/core/instance/index.js
patch: @@ -3,8 +3,13 @@ import { stateMixin } from './state'
 import { renderMixin } from './render'
 import { eventsMixin } from './events'
 import { lifecycleMixin } from './lifecycle'
+import { warn } from '../util/index'
 
 function Vue (options) {
+  if (process.env.NODE_ENV !== 'production' &&
+    !(this instanceof Vue)) {
+    warn('Vue is a constructor and should be called with the `new` keyword')
+  }
   this._init(options)
 }
 

filename: test/unit/features/instance/init.spec.js
patch: @@ -0,0 +1,12 @@
+import Vue from 'vue'
+
+describe('Initialization', () => {
+  it('without new', () => {
+    try { Vue() } catch (e) {}
+    expect('Vue is a constructor and should be called with the `new` keyword').toHaveBeenWarned()
+  })
+
+  it('with new', () => {
+    expect(new Vue() instanceof Vue).toBe(true)
+  })
+})
Repository: ggml-org/llama.cpp
Pull request: model : add correct type for GLM 4.7 Flash

Fix the displayed model type in the logs:

```bash
# before
deepseek2 ?B Q8_0  

# after
deepseek2 30B.A3B Q8_0  
```

Changed files:
filename: src/llama-model.cpp
patch: @@ -1737,6 +1737,7 @@ void llama_model::load_hparams(llama_model_loader & ml) {
 
                 switch (hparams.n_layer) {
                     case 27: type = LLM_TYPE_16B; break;
+                    case 47: type = LLM_TYPE_30B_A3B; break;
                     case 60: type = LLM_TYPE_236B; break;
                     case 61: type = LLM_TYPE_671B; break;
                     default: type = LLM_TYPE_UNKNOWN;
Repository: vuejs/vue
Pull request: fix IE/Edge select remembering selection

Fix for https://github.com/vuejs/vue/issues/3798


Changed files:
filename: src/platforms/web/runtime/directives/model.js
patch: @@ -35,9 +35,11 @@ export default {
       setSelected(el, binding, vnode.context)
       /* istanbul ignore if */
       if (isIE || isEdge) {
-        nextTick(() => {
+        const cb = () => {
           setSelected(el, binding, vnode.context)
-        })
+        }
+        nextTick(cb)
+        setTimeout(cb, 0)
       }
     } else if (vnode.tag === 'textarea' || el.type === 'text') {
       if (!isAndroid) {
Repository: electron/electron
Pull request: build: fixup chromedriver and mksnapshot

Backport of #48470

See that PR for details.


Notes: <!-- Please add a one-line description for app developers to read in the release notes, or 'none' if no notes relevant to app developers. Examples and help on special cases: https://github.com/electron/clerk/blob/main/README.md#examples -->none

Changed files:
filename: .github/actions/build-electron/action.yml
patch: @@ -79,7 +79,7 @@ runs:
       shell: bash
       run: |
         cd src
-        e build --target electron:electron_mksnapshot
+        e build --target electron:electron_mksnapshot_zip
         ELECTRON_DEPOT_TOOLS_DISABLE_LOG=1 e d gn desc out/Default v8:run_mksnapshot_default args > out/Default/mksnapshot_args
         # Remove unused args from mksnapshot_args
         SEDOPTION="-i"
@@ -89,7 +89,6 @@ runs:
         sed $SEDOPTION '/.*builtins-pgo/d' out/Default/mksnapshot_args
         sed $SEDOPTION '/--turbo-profiling-input/d' out/Default/mksnapshot_args
 
-        e build --target electron:electron_mksnapshot_zip
         if [ "${{ inputs.target-platform }}" = "win" ]; then
           cd out/Default
           powershell Compress-Archive -update mksnapshot_args mksnapshot.zip
@@ -123,7 +122,6 @@ runs:
       shell: bash
       run: |
         cd src
-        e build --target electron:electron_chromedriver
         e build --target electron:electron_chromedriver_zip
     - name: Build Node.js headers ${{ inputs.step-suffix }}
       shell: bash

filename: .github/actions/install-build-tools/action.yml
patch: @@ -15,7 +15,7 @@ runs:
         git config --global core.preloadindex true
         git config --global core.longpaths true
       fi
-      export BUILD_TOOLS_SHA=c13f4bdb50e65da46a4703f8f882079dd21fd99e
+      export BUILD_TOOLS_SHA=706147b2376f55078f718576b28129a0457f1795
       npm i -g @electron/build-tools
       # Update depot_tools to ensure python
       e d update_depot_tools

filename: .github/workflows/pipeline-segment-electron-test.yml
patch: @@ -164,22 +164,18 @@ jobs:
         path: ./src_artifacts_${{ matrix.build-type }}_${{ inputs.target-arch }}
     - name: Restore Generated Artifacts
       run: ./src/electron/script/actions/restore-artifacts.sh
-    - name: Unzip Dist, Mksnapshot & Chromedriver (win)
+    - name: Unzip Dist (win)
       if: ${{ inputs.target-platform == 'win' }}
       shell: powershell
       run: |
         Set-ExecutionPolicy Bypass -Scope Process -Force
         cd src/out/Default
         Expand-Archive -Force dist.zip -DestinationPath ./
-        Expand-Archive -Force chromedriver.zip -DestinationPath ./
-        Expand-Archive -Force mksnapshot.zip -DestinationPath ./
-    - name: Unzip Dist, Mksnapshot & Chromedriver (unix)
+    - name: Unzip Dist (unix)
       if: ${{ inputs.target-platform != 'win' }}
       run: |
         cd src/out/Default
         unzip -:o dist.zip
-        unzip -:o chromedriver.zip
-        unzip -:o mksnapshot.zip
     - name: Import & Trust Self-Signed Codesigning Cert on MacOS
       if: ${{ inputs.target-platform == 'macos' && inputs.target-arch == 'x64' }}
       run: |
Repository: ollama/ollama
Pull request: return tool calls finish reason for openai


Changed files:
filename: openai/openai.go
patch: @@ -218,6 +218,9 @@ func toChatCompletion(id string, r api.ChatResponse) ChatCompletion {
 			Index:   0,
 			Message: Message{Role: r.Message.Role, Content: r.Message.Content, ToolCalls: toolCalls},
 			FinishReason: func(reason string) *string {
+				if len(toolCalls) > 0 {
+					reason = "tool_calls"
+				}
 				if len(reason) > 0 {
 					return &reason
 				}
Repository: huggingface/transformers
Pull request: Fix validation checks order in benchmark_v2

- Reorder the validation checks in the benchmarker to avoid TypeError when required arguments are missing.
- Fix `adapt_configs()` preserving old benchmark names (e.g., s128_n128) when parameters are changed via command-line arguments. Remove the name field from the config dict so it gets re-inferred with the updated sequence length and token generation values. 

----
@remi-or 


Changed files:
filename: benchmark_v2/framework/benchmark_config.py
patch: @@ -203,6 +203,8 @@ def adapt_configs(
             config["sequence_length"] = seqlen
             config["num_tokens_to_generate"] = ntok
             config["gpu_monitoring"] = monitor
+            # Remove the old name so it gets re-inferred with the updated values
+            config.pop("name", None)
             adapted_configs.append(BenchmarkConfig.from_dict(config))
     return adapted_configs
 

filename: benchmark_v2/run_benchmarks.py
patch: @@ -80,16 +80,16 @@
     logger.info(f"Benchmark run UUID: {benchmark_run_uuid}")
     logger.info(f"Output directory: {args.output_dir}")
 
-    # We cannot compute ITL if we don't have at least two measurements
-    if any(n <= 1 for n in args.num_tokens_to_generate):
-        raise ValueError("--num_tokens_to_generate arguments should be larger than 1")
-
     # Error out if one of the arguments is not provided
-    if len(args.batch_size) * len(args.sequence_length) * len(args.num_tokens_to_generate) == 0:
+    if any(arg is None for arg in [args.batch_size, args.sequence_length, args.num_tokens_to_generate]):
         raise ValueError(
-            "At least one of the arguments --batch-size, --sequence-length, or --num-tokens-to-generate is required"
+            "All of the arguments --batch-size, --sequence-length, and --num-tokens-to-generate are required"
         )
 
+    # We cannot compute ITL if we don't have at least two measurements
+    if any(n <= 1 for n in args.num_tokens_to_generate):
+        raise ValueError("--num_tokens_to_generate arguments should be larger than 1")
+
     # Get the configs for the given coverage level
     configs = get_config_by_level(args.level)
     # Adapt the configs to the given arguments
Repository: nodejs/node
Pull request: doc: remove unnecessary statement of web storage

For now, web storage is enabled by default.

Refs: https://github.com/nodejs/node/pull/57666

<!--
Before submitting a pull request, please read:

- the CONTRIBUTING guide at https://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md
- the commit message formatting guidelines at
  https://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#commit-message-guidelines

For code changes:
1. Include tests for any bug fixes or new features.
2. Update documentation if relevant.
3. Ensure that `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes.

If you believe this PR should be highlighted in the Node.js CHANGELOG
please add the `notable-change` label.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.
-->


Changed files:
filename: doc/api/globals.md
patch: @@ -1105,8 +1105,7 @@ added: v0.0.1
 added: v22.4.0
 -->
 
-> Stability: 1.0 - Early development. Enable this API with the
-> \[`--experimental-webstorage`]\[] CLI flag.
+> Stability: 1.0 - Early development.
 
 A browser-compatible implementation of {Storage}. Disable this API with the
 [`--no-webstorage`][] (or its alias `--no-experimental-webstorage`) CLI flag.
Repository: vuejs/vue
Pull request: Update `$refs` type declaration

According to the [doc](https://rc.vuejs.org/api/#ref), `$refs` is a dictionary of `Vue` instance or `Element`. This pull request reflect this by a union type. So users can declare html elements in `$refs`. 

A test is also added. User defined components may have better knowledge about `$refs`' data structure. So users can also reify special properties to more specific types.

@ktsn your review is appreciated, thanks.


Changed files:
filename: types/test/vue-test.ts
patch: @@ -13,6 +13,20 @@ class Test extends Vue {
     this.$isServer;
   }
 
+  // test property reification
+  $refs: {
+    vue: Vue,
+    element: HTMLInputElement,
+    vues: Vue[],
+    elements: HTMLInputElement[]
+  }
+  testReification() {
+    this.$refs.vue.$data;
+    this.$refs.element.value;
+    this.$refs.vues[0].$data;
+    this.$refs.elements[0].value;
+  }
+
   testMethods() {
     this.$mount("#app", false);
     this.$forceUpdate();

filename: types/vue.d.ts
patch: @@ -19,7 +19,7 @@ export declare class Vue {
   readonly $parent: Vue;
   readonly $root: Vue;
   readonly $children: Vue[];
-  readonly $refs: { [key: string]: Vue };
+  readonly $refs: { [key: string]: Vue | Element | Vue[] | Element[]};
   readonly $slots: { [key: string]: VNode[] };
   readonly $isServer: boolean;
Repository: vuejs/vue
Pull request: fix directive sort compare

fix #3768 

Object.keys(groupedMap) returns an array whose elements are strings, so it breaks the sort function.


Changed files:
filename: src/compiler/compile.js
patch: @@ -122,18 +122,20 @@ function sortDirectives (dirs) {
 
   var groupedMap = {}
   var i, j, k, l
+  var index = 0
+  var priorities = []
   for (i = 0, j = dirs.length; i < j; i++) {
     var dir = dirs[i]
     var priority = dir.descriptor.def.priority || DEFAULT_PRIORITY
     var array = groupedMap[priority]
     if (!array) {
       array = groupedMap[priority] = []
+      priorities.push(priority)
     }
     array.push(dir)
   }
 
-  var index = 0
-  var priorities = Object.keys(groupedMap).sort(function (a, b) {
+  priorities.sort(function (a, b) {
     return a > b ? -1 : a === b ? 0 : 1
   })
   for (i = 0, j = priorities.length; i < j; i++) {

filename: test/unit/specs/compiler/compile_spec.js
patch: @@ -53,8 +53,8 @@ describe('Compile', function () {
   it('normal directives', function () {
     el.setAttribute('v-a', 'b')
     el.innerHTML = '<p v-a:hello.a.b="a" v-b="1">hello</p><div v-b.literal="foo"></div>'
-    var defA = { priority: 1 }
-    var defB = { priority: 2 }
+    var defA = { priority: 250 }
+    var defB = { priority: 1100 }
     var options = _.mergeOptions(Vue.options, {
       directives: {
         a: defA,
Repository: facebook/react
Pull request: DevTools: fix Compiler inegration test with 18.2

Currently failing with `TypeError: Invalid Version: 19`, looks like I've overlooked this one in https://github.com/facebook/react/pull/31241.

Changed files:
filename: scripts/ci/download_devtools_regression_build.js
patch: @@ -110,7 +110,7 @@ async function downloadRegressionBuild() {
     );
   }
 
-  if (semver.gte(reactVersion, '18.2.0') && semver.lt(reactVersion, '19')) {
+  if (semver.gte(reactVersion, '18.2.0') && semver.lt(reactVersion, '19.0.0')) {
     console.log(chalk.white(`Downloading react-compiler-runtime\n`));
     await exec(
       `npm install --prefix ${REGRESSION_FOLDER} react-compiler-runtime`
Repository: vercel/next.js
Pull request: [ci]: fix retry_deploy_test workflow

When we fixed deploy tests to consistently run with the explicitly provided Next.js release version, it broke this job which was relying on an explicit match on the "test e2e deploy canary" string. 

Changed files:
filename: .github/workflows/retry_deploy_test.yml
patch: @@ -17,8 +17,8 @@ jobs:
     name: retry failed jobs
     # Retry the test-e2e-deploy-release workflow up to 2 times
     if: >-
-      ${{ 
-        github.event.workflow_run.display_title == 'test-e2e-deploy canary' &&
+      ${{
+        startsWith(github.event.workflow_run.display_title, 'test-e2e-deploy') &&
         github.event.workflow_run.conclusion == 'failure' &&
         github.repository == 'vercel/next.js' &&
         github.event.workflow_run.run_attempt < 2
@@ -39,8 +39,8 @@ jobs:
     name: report failure to slack
     # Report the failure to Slack if the test-e2e-deploy-release workflow has failed 2 times
     if: >-
-      ${{ 
-        github.event.workflow_run.display_title == 'test-e2e-deploy canary' &&
+      ${{
+        startsWith(github.event.workflow_run.display_title, 'test-e2e-deploy') &&
         github.event.workflow_run.conclusion == 'failure' &&
         github.event.workflow_run.run_attempt >= 2 &&
         !github.event.workflow_run.head_repository.fork
Repository: nodejs/node
Pull request: build: ibmi follow aix visibility

After this commit - https://github.com/nodejs/node/commit/3437e1c4bd529e51d96ea581b6435bbeb77ef524
we are getting the following error on IBM i

Error:
```
ld: 0711-407 ERROR: Symbol _ZNKSt5ctypeIcE8do_widenEc
Visibility is not allowed on a reference to an imported symbol.
```

and IBM i follow AIX visibility.
<!--
Before submitting a pull request, please read:

- the CONTRIBUTING guide at https://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md
- the commit message formatting guidelines at
  https://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#commit-message-guidelines

For code changes:
1. Include tests for any bug fixes or new features.
2. Update documentation if relevant.
3. Ensure that `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes.

If you believe this PR should be highlighted in the Node.js CHANGELOG
please add the `notable-change` label.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.
-->

Changed files:
filename: tools/v8_gypfiles/v8.gyp
patch: @@ -50,7 +50,7 @@
       # including unnecessary internal symbols, which may lead to run-time fixups.
       # This is not done on AIX where symbols are exported by tools/create_expfile.sh
       # see https://github.com/nodejs/node/pull/56290#issuecomment-2582703109
-      ['OS!="aix"', {
+      ['OS!="aix" and OS!="os400"', {
         'defines': [
           'BUILDING_V8_SHARED',  # Make V8_EXPORT visible.
         ]
@@ -65,7 +65,7 @@
           'GCC_SYMBOLS_PRIVATE_EXTERN': 'YES',  # -fvisibility=hidden
           'GCC_INLINES_ARE_PRIVATE_EXTERN': 'YES'  # -fvisibility-inlines-hidden
         },
-      }, 'OS!="aix" and (OS!="win" or clang==1)', {
+      }, '(OS!="aix" and OS!="os400") and (OS!="win" or clang==1)', {
         'cflags': [
           '-fvisibility=hidden',
           '-fvisibility-inlines-hidden'
Repository: vuejs/vue
Pull request: Warn when using v-model with input[type=file]


Changed files:
filename: src/platforms/web/compiler/directives/model.js
patch: @@ -108,6 +108,16 @@ function genDefaultModel (
   if (isNative && needCompositionGuard) {
     code = `if($event.target.composing)return;${code}`
   }
+  // inputs with type="file" are read only and setting the input's
+  // value will throw an error.
+  if (process.env.NODE_ENV !== 'production' &&
+      type === 'file') {
+    warn(
+      `<${el.tag} v-model="${value}" type="file">:\n` +
+      'File inputs are read only. You should use @change instead:\n' +
+      `<${el.tag} @change="${value} = $event.target.files" type="file">`
+    )
+  }
   addProp(el, 'value', isNative ? `_s(${value})` : `(${value})`)
   addHandler(el, event, code, null, true)
   if (needCompositionGuard) {

filename: test/unit/features/directives/model-file.spec.js
patch: @@ -0,0 +1,13 @@
+import Vue from 'vue'
+
+describe('Directive v-model file', () => {
+  it('warn to use @change instead', () => {
+    new Vue({
+      data: {
+        file: ''
+      },
+      template: '<input v-model="file" type="file">'
+    }).$mount()
+    expect('use @change instead').toHaveBeenWarned()
+  })
+})