helloadhavan/github_issues huggingface dataset:
Repository: vercel/next.js
Pull request: Update Rspack development test manifest

This auto-generated PR updates the development integration test manifest used when testing Rspack.

Changed files:
filename: test/rspack-dev-tests-manifest.json
patch: @@ -817,6 +817,15 @@
     "flakey": [],
     "runtimeError": false
   },
+  "test/development/app-dir/hmr-iframe/hmr-iframe.test.ts": {
+    "passed": [],
+    "failed": [
+      "hmr-iframe should do HMR when rendering two server component changes at the same time"
+    ],
+    "pending": [],
+    "flakey": [],
+    "runtimeError": false
+  },
   "test/development/app-dir/hmr-intercept-routes/hmr-intercept-routes.test.ts": {
     "passed": [],
     "failed": [],
@@ -1813,11 +1822,12 @@
       "client-dev-overlay should be able to minimize the fullscreen overlay",
       "client-dev-overlay should be possible to hide the minimized overlay when there are no errors",
       "client-dev-overlay should have a role of \"dialog\" if the page is focused",
-      "client-dev-overlay should keep the error indicator visible when there are errors",
+      "client-dev-overlay should keep the error indicator visible when there are errors"
+    ],
+    "failed": [
       "client-dev-overlay should nudge to use Turbopack unless Turbopack is disabled",
       "client-dev-overlay with Cache Components should show Cache Components as enabled in the devtools menu"
     ],
-    "failed": [],
     "pending": [],
     "flakey": [],
     "runtimeError": false
Repository: ollama/ollama
Pull request: llama: gather transitive dependencies for rocm for dist packaging

Go generate equivalent logic is [here](https://github.com/ollama/ollama/blob/main/llm/generate/gen_linux.sh#L283-L290)

Changed files:
filename: llama/Makefile
patch: @@ -130,7 +130,10 @@ ifneq ($(HIPCC),)
 		ROCM_VARIANT = _v$(ROCM_VERSION)
 	endif
 	ROCM_LIBS = $(wildcard $(addsuffix .$(SHARED_EXT),$(addprefix $(HIP_LIB_DIR)/$(SHARED_PREFIX),$(ROCM_LIBS_SHORT))))
-	ROCM_LIB_DEPS = $(addprefix $(ROCM_DEPS_DIR)/,$(notdir $(ROCM_LIBS)))
+	ifeq ($(OS),linux)
+		ROCM_TRANSITIVE_LIBS = $(shell ldd $(ROCM_LIBS) | grep "=>" | cut -f2 -d= | cut -f2 -d' '  | grep -e rocm -e amdgpu -e libtinfo -e libnuma -e libelf | sort -u )
+	endif
+	ROCM_LIB_DEPS = $(addprefix $(ROCM_DEPS_DIR)/,$(notdir $(ROCM_LIBS)) $(notdir $(ROCM_TRANSITIVE_LIBS)))
 	ROCBLAS_DEP_MANIFEST = $(ROCM_DEPS_DIR)/rocblas/library/TensileManifest.txt
 endif
 endif
@@ -367,7 +370,7 @@ $(RUNNERS_BUILD_DIR)/rocm$(ROCM_VARIANT)/$(SHARED_PREFIX)ggml_hipblas.$(SHARED_E
 
 $(ROCM_LIB_DEPS): 
 	@-mkdir -p $(dir $@)
-	$(CP) $(HIP_LIB_DIR)/$(notdir $@)* $(dir $@)
+	$(CP) $(dir $(filter %$(notdir $@),$(ROCM_LIBS) $(ROCM_TRANSITIVE_LIBS)))/$(notdir $@)* $(dir $@)
 
 $(RUNNERS_BUILD_DIR)/$(DEFAULT_RUNNER)/ollama_llama_server$(EXE_EXT): TARGET_CPU_FLAGS=
 $(RUNNERS_BUILD_DIR)/$(DEFAULT_RUNNER)/ollama_llama_server$(EXE_EXT): *.go ./runner/*.go $(COMMON_SRCS) $(COMMON_HDRS)
Repository: vuejs/vue
Pull request: fix no change triggered after reassigned state, Fix #5191

<!--
Please make sure to read the Pull Request Guidelines:
https://github.com/vuejs/vue/blob/dev/.github/CONTRIBUTING.md#pull-request-guidelines
-->

<!-- PULL REQUEST TEMPLATE -->
<!-- (Update "[ ]" to "[x]" to check a box) -->

**What kind of change does this PR introduce?** (check at least one)

- [x] Bugfix
- [ ] Feature
- [ ] Code style update
- [ ] Refactor
- [ ] Build-related changes
- [ ] Other, please describe:

**Does this PR introduce a breaking change?** (check one)

- [ ] Yes
- [x] No

If yes, please describe the impact and migration path for existing applications:

**The PR fulfills these requirements:**

- [x] It's submitted to the `dev` branch for v2.x (or to a previous version branch), _not_ the `master` branch
- [ ] When resolving a specific issue, it's referenced in the PR's title (e.g. `fix #xxx[,#xxx]`, where "xxx" is the issue number)
- [x] All tests are passing: https://github.com/vuejs/vue/blob/dev/.github/CONTRIBUTING.md#development-setup
- [ ] New/updated tests are included

If adding a **new feature**, the PR's description includes:
- [ ] A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

**Other information:**
#5191 

Changed files:
filename: src/core/observer/scheduler.js
patch: @@ -69,10 +69,14 @@ function flushSchedulerQueue () {
     }
   }
 
+  // reset scheduler before updated hook called
+  const oldQueue = queue.slice()
+  resetSchedulerState()
+
   // call updated hooks
-  index = queue.length
+  index = oldQueue.length
   while (index--) {
-    watcher = queue[index]
+    watcher = oldQueue[index]
     vm = watcher.vm
     if (vm._watcher === watcher && vm._isMounted) {
       callHook(vm, 'updated')
@@ -84,8 +88,6 @@ function flushSchedulerQueue () {
   if (devtools && config.devtools) {
     devtools.emit('flush')
   }
-
-  resetSchedulerState()
 }
 
 /**

filename: test/unit/modules/observer/scheduler.spec.js
patch: @@ -144,4 +144,35 @@ describe('Scheduler', () => {
       expect(callOrder).toEqual([1, 2, 3])
     }).then(done)
   })
+
+  // Github issue #5191
+  it('emit should work when updated hook called', done => {
+    const el = document.createElement('div')
+    const vm = new Vue({
+      template: `<div><child @change="bar" :foo="foo"></child></div>`,
+      data: {
+        foo: 0
+      },
+      methods: {
+        bar: spy
+      },
+      components: {
+        child: {
+          template: `<div>{{foo}}</div>`,
+          props: ['foo'],
+          updated () {
+            this.$emit('change')
+          }
+        }
+      }
+    }).$mount(el)
+    vm.$nextTick(() => {
+      vm.foo = 1
+      vm.$nextTick(() => {
+        expect(vm.$el.innerHTML).toBe('<div>1</div>')
+        expect(spy).toHaveBeenCalled()
+        done()
+      })
+    })
+  })
 })
Repository: ggml-org/llama.cpp
Pull request: common : remove unused token util functions

This commit removes two unused functions `common_lcp` and `common_lcs`. The last usage of these functions was removed in Commit 33eff4024084d1f0c8441b79f7208a52fad79858 ("server : vision support via libmtmd") and are no longer used anywhere in the codebase.


Changed files:
filename: common/common.cpp
patch: @@ -1469,66 +1469,6 @@ void common_batch_add(
     batch.n_tokens++;
 }
 
-//
-// Token utils
-//
-
-size_t common_lcp(const llama_tokens & a, const llama_tokens & b) {
-    size_t i;
-    for (i = 0; i < a.size() && i < b.size() && a[i] == b[i]; i++) {}
-
-    return i;
-}
-
-size_t common_lcs(const llama_tokens & a, const llama_tokens & b) {
-    // check for empty sequences
-    if (a.empty() || b.empty()) {
-        return 0;
-    }
-
-    // get the lengths of the input sequences
-    size_t a_len = a.size();
-    size_t b_len = b.size();
-
-    // initialize the maximum length of the longest common subsequence (LCS)
-    size_t max_length = 0;
-
-    // use two rows instead of a 2D matrix to optimize space
-    std::vector<size_t> prev_row(b_len + 1, 0);
-    std::vector<size_t> curr_row(b_len + 1, 0);
-
-    // iterate through the elements of a
-    for (size_t i = 1; i <= a_len; i++) {
-        // iterate through the elements of b
-        for (size_t j = 1; j <= b_len; j++) {
-            // if elements at the current positions match
-            if (a[i - 1] == b[j - 1]) {
-                // if it's the first element of either sequences, set LCS length to 1
-                if (i == 1 || j == 1) {
-                    curr_row[j] = 1;
-                } else {
-                    // increment LCS length by 1 compared to the previous element
-                    curr_row[j] = prev_row[j - 1] + 1;
-                }
-
-                // update max_length if necessary
-                if (curr_row[j] > max_length) {
-                    max_length = curr_row[j];
-                }
-            } else {
-                // reset LCS length if elements don't match
-                curr_row[j] = 0;
-            }
-        }
-
-        // update the previous row for the next iteration
-        prev_row = curr_row;
-    }
-
-    // return the maximum length of the LCS
-    return max_length;
-}
-
 //
 // Vocab utils
 //

filename: common/common.h
patch: @@ -779,16 +779,6 @@ void common_batch_add(
     const std::vector<llama_seq_id> & seq_ids,
                                bool   logits);
 
-//
-// Token utils
-//
-
-// longest common prefix
-size_t common_lcp(const llama_tokens & a, const llama_tokens & b);
-
-// longet common subsequence
-size_t common_lcs(const llama_tokens & a, const llama_tokens & b);
-
 //
 // Vocab utils
 //
Repository: electron/electron
Pull request: build: apply additional compression on upload

Backport of #48766

See that PR for details.


Notes: none


Changed files:
filename: script/lib/util.py
patch: @@ -70,17 +70,17 @@ def make_zip(zip_file_path, files, dirs):
   safe_unlink(zip_file_path)
   if sys.platform == 'darwin':
     allfiles = files + dirs
-    execute(['zip', '-r', '-y', zip_file_path] + allfiles)
+    execute(['zip', '-r', '-y', '-9', zip_file_path] + allfiles)
   else:
     with zipfile.ZipFile(zip_file_path, "w",
                          zipfile.ZIP_DEFLATED,
                          allowZip64=True) as zip_file:
       for filename in files:
-        zip_file.write(filename, filename)
+        zip_file.write(filename, filename, compress_type=zipfile.ZIP_DEFLATED, compresslevel=9)
       for dirname in dirs:
         for root, _, filenames in os.walk(dirname):
           for f in filenames:
-            zip_file.write(os.path.join(root, f))
+            zip_file.write(os.path.join(root, f), compress_type=zipfile.ZIP_DEFLATED, compresslevel=9)
       zip_file.close()
Repository: facebook/react
Pull request: [flags] make enableComponentPerformanceTrack dynamic


Changed files:
filename: packages/shared/forks/ReactFeatureFlags.www-dynamic.js
patch: @@ -39,6 +39,7 @@ export const enableUseEffectCRUDOverload = __VARIANT__;
 export const enableFastAddPropertiesInDiffing = __VARIANT__;
 export const enableLazyPublicInstanceInFabric = false;
 export const enableViewTransition = __VARIANT__;
+export const enableComponentPerformanceTrack = __VARIANT__;
 export const enableScrollEndPolyfill = __VARIANT__;
 
 // TODO: These flags are hard-coded to the default values used in open source.

filename: packages/shared/forks/ReactFeatureFlags.www.js
patch: @@ -37,6 +37,7 @@ export const {
   transitionLaneExpirationMs,
   enableFastAddPropertiesInDiffing,
   enableViewTransition,
+  enableComponentPerformanceTrack,
   enableScrollEndPolyfill,
 } = dynamicFeatureFlags;
 
@@ -63,8 +64,6 @@ export const enableThrottledScheduling = false;
 
 export const enableHydrationLaneScheduling = true;
 
-export const enableComponentPerformanceTrack = false;
-
 // Logs additional User Timing API marks for use with an experimental profiling tool.
 export const enableSchedulingProfiler: boolean =
   __PROFILE__ && dynamicFeatureFlags.enableSchedulingProfiler;
Repository: vercel/next.js
Pull request: Update Rspack production test manifest

This auto-generated PR updates the production integration test manifest used when testing Rspack.

Changed files:
filename: test/rspack-build-tests-manifest.json
patch: @@ -17794,10 +17794,10 @@
     "runtimeError": false
   },
   "test/integration/next-image-legacy/asset-prefix/test/index.test.ts": {
-    "passed": [],
-    "failed": [
+    "passed": [
       "Image Component assetPrefix Tests production mode should use base64 data url with placeholder=blur during next start"
     ],
+    "failed": [],
     "pending": [
       "Image Component assetPrefix Tests development mode should include assetPrefix when placeholder=blur during next dev"
     ],
@@ -20975,6 +20975,16 @@
     "flakey": [],
     "runtimeError": false
   },
+  "test/production/chunk-load-failure/chunk-load-failure.test.ts": {
+    "passed": [
+      "chunk-load-failure should report aborted chunks when navigating away",
+      "chunk-load-failure should report async chunk load failures"
+    ],
+    "failed": [],
+    "pending": [],
+    "flakey": [],
+    "runtimeError": false
+  },
   "test/production/ci-missing-typescript-deps/index.test.ts": {
     "passed": [
       "ci-missing-typescript-deps should not throw an error if beta version of @types/react and @types/react-dom is installed",
Repository: nodejs/node
Pull request: doc: correct tls ALPNProtocols types

Artifact introduced by imprecise wording in the initial feature commit; the error has been extrapolated many times since.

The only valid array elements are strings, as they are passed to `buffer.write()`.

Changed files:
filename: doc/api/tls.md
patch: @@ -1705,11 +1705,9 @@ changes:
     verification fails; `err.code` contains the OpenSSL error code. **Default:**
     `true`.
   * `pskCallback` {Function} For TLS-PSK negotiation, see [Pre-shared keys][].
-  * `ALPNProtocols` {string\[]|Buffer\[]|TypedArray\[]|DataView\[]|Buffer|
-    TypedArray|DataView}
-    An array of strings, `Buffer`s, `TypedArray`s, or `DataView`s, or a
-    single `Buffer`, `TypedArray`, or `DataView` containing the supported ALPN
-    protocols. `Buffer`s should have the format `[len][name][len][name]...`
+  * `ALPNProtocols` {string\[]|Buffer|TypedArray|DataView} An array of strings,
+    or a single `Buffer`, `TypedArray`, or `DataView` containing the supported
+    ALPN protocols. Buffers should have the format `[len][name][len][name]...`
     e.g. `'\x08http/1.1\x08http/1.0'`, where the `len` byte is the length of the
     next protocol name. Passing an array is usually much simpler, e.g.
     `['http/1.1', 'http/1.0']`. Protocols earlier in the list have higher
@@ -2120,11 +2118,9 @@ changes:
 -->
 
 * `options` {Object}
-  * `ALPNProtocols` {string\[]|Buffer\[]|TypedArray\[]|DataView\[]|Buffer|
-    TypedArray|DataView}
-    An array of strings, `Buffer`s, `TypedArray`s, or `DataView`s, or a single
-    `Buffer`, `TypedArray`, or `DataView` containing the supported ALPN
-    protocols. `Buffer`s should have the format `[len][name][len][name]...`
+  * `ALPNProtocols` {string\[]|Buffer|TypedArray|DataView} An array of strings,
+    or a single `Buffer`, `TypedArray`, or `DataView` containing the supported
+    ALPN protocols. Buffers should have the format `[len][name][len][name]...`
     e.g. `0x05hello0x05world`, where the first byte is the length of the next
     protocol name. Passing an array is usually much simpler, e.g.
     `['hello', 'world']`. (Protocols should be ordered by their priority.)
Repository: ggml-org/llama.cpp
Pull request: build : fix case in dSYMs path for build-macos [no ci]

This commit updates an incorrect dSYMs where the the 's' was uppercase by mistake.

The motivation for fixing this is that this can cause issues on case sensitive operating systems.

Refs: https://github.com/ggml-org/whisper.cpp/pull/3630

Changed files:
filename: build-xcframework.sh
patch: @@ -534,7 +534,7 @@ xcodebuild -create-xcframework \
     -framework $(pwd)/build-ios-device/framework/llama.framework \
     -debug-symbols $(pwd)/build-ios-device/dSYMs/llama.dSYM \
     -framework $(pwd)/build-macos/framework/llama.framework \
-    -debug-symbols $(pwd)/build-macos/dSYMS/llama.dSYM \
+    -debug-symbols $(pwd)/build-macos/dSYMs/llama.dSYM \
     -framework $(pwd)/build-visionos/framework/llama.framework \
     -debug-symbols $(pwd)/build-visionos/dSYMs/llama.dSYM \
     -framework $(pwd)/build-visionos-sim/framework/llama.framework \
Repository: vercel/next.js
Pull request: [test] app-basepath less agressive request reading

Hopefully helps with this
```
  ● app dir - basepath › should properly stream an internal server action redirect() with a relative URL

    request.allHeaders: Target page, context or browser has been closed

      77 |         beforePageLoad(page) {
      78 |           page.on('request', (request) => {
    > 79 |             return request.allHeaders().then((headers) => {
         |                            ^
      80 |               if (
      81 |                 headers['rsc'] === '1' &&
      82 |                 // Prefetches also include `rsc`

      at Page.allHeaders (e2e/app-dir/app-basepath/index.test.ts:79:28)
```

Changed files:
filename: test/e2e/app-dir/app-basepath/index.test.ts
patch: @@ -75,16 +75,29 @@ describe('app dir - basepath', () => {
       let rscRequests = []
       const browser = await next.browser(path, {
         beforePageLoad(page) {
-          page.on('request', (request) => {
-            return request.allHeaders().then((headers) => {
+          page.on('request', async (request) => {
+            let headers: { [key: string]: string }
+            try {
+              headers = await request.allHeaders()
+            } catch (e) {
               if (
-                headers['rsc'] === '1' &&
-                // Prefetches also include `rsc`
-                headers['next-router-prefetch'] !== '1'
+                e.message.includes(
+                  'Target page, context or browser has been closed'
+                )
               ) {
-                rscRequests.push(request.url())
+                // Ignore errors caused by closed browser during test teardown
+                return
               }
-            })
+              throw e
+            }
+
+            if (
+              headers['rsc'] === '1' &&
+              // Prefetches also include `rsc`
+              headers['next-router-prefetch'] !== '1'
+            ) {
+              rscRequests.push(request.url())
+            }
           })
         },
       })
Repository: vuejs/vue
Pull request: fix wrong order of generate modifier code

#5146

@posva 
review need

Changed files:
filename: src/compiler/codegen/events.js
patch: @@ -63,10 +63,11 @@ function genHandler (
       : `function($event){${handler.value}}` // inline statement
   } else {
     let code = ''
+    let genModifierCode = ''
     const keys = []
     for (const key in handler.modifiers) {
       if (modifierCode[key]) {
-        code += modifierCode[key]
+        genModifierCode += modifierCode[key]
         // left/right
         if (keyCodes[key]) {
           keys.push(key)
@@ -78,6 +79,10 @@ function genHandler (
     if (keys.length) {
       code += genKeyFilter(keys)
     }
+    // Make sure modifiers like prevent and stop get executed after key filtering
+    if (genModifierCode) {
+      code += genModifierCode
+    }
     const handlerCode = isMethodPath
       ? handler.value + '($event)'
       : isFunctionExpression

filename: test/unit/features/directives/on.spec.js
patch: @@ -527,4 +527,25 @@ describe('Directive v-on', () => {
     expect(spyUp.calls.count()).toBe(1)
     expect(spyDown.calls.count()).toBe(1)
   })
+
+  // Github Issues #5146
+  it('should only prevent when match keycode', () => {
+    let prevented = false
+    vm = new Vue({
+      el,
+      template: `
+        <input ref="input" @keydown.enter.prevent="foo">
+      `,
+      methods: {
+        foo ($event) {
+          prevented = $event.defaultPrevented
+        }
+      }
+    })
+
+    triggerEvent(vm.$refs.input, 'keydown', e => { e.keyCode = 32 })
+    expect(prevented).toBe(false)
+    triggerEvent(vm.$refs.input, 'keydown', e => { e.keyCode = 13 })
+    expect(prevented).toBe(true)
+  })
 })

filename: test/unit/modules/compiler/codegen.spec.js
patch: @@ -268,6 +268,19 @@ describe('codegen', () => {
     )
   })
 
+  // Github Issues #5146
+  it('generate events with generic modifiers and keycode correct order', () => {
+    assertCodegen(
+      '<input @keydown.enter.prevent="onInput">',
+      `with(this){return _c('input',{on:{"keydown":function($event){if(!('button' in $event)&&_k($event.keyCode,"enter",13))return null;$event.preventDefault();onInput($event)}}})}`
+    )
+
+    assertCodegen(
+      '<input @keydown.enter.stop="onInput">',
+      `with(this){return _c('input',{on:{"keydown":function($event){if(!('button' in $event)&&_k($event.keyCode,"enter",13))return null;$event.stopPropagation();onInput($event)}}})}`
+    )
+  })
+
   it('generate events with mouse event modifiers', () => {
     assertCodegen(
       '<input @click.ctrl="onClick">',
Repository: huggingface/transformers
Pull request: Fix Ernie Moe Test

Flaky test: 
- `pytest tests/models/ernie4_5_moe/test_modeling_ernie4_5_moe.py -k test_load_balancing_loss --flake-finder --flake-runs=1000`
- Encounter 0 failures

Hope it's more robust again

Changed files:
filename: tests/models/ernie4_5_moe/test_modeling_ernie4_5_moe.py
patch: @@ -97,24 +97,27 @@ def test_load_balancing_loss(self):
         config, input_dict = self.model_tester.prepare_config_and_inputs_for_common()
         config.num_labels = 3
         config.num_experts = 3
-        config.expert_interval = 2
         config.output_router_logits = True
         input_ids = input_dict["input_ids"]
-        attention_mask = input_ids.ne(1).to(torch_device)
+        attention_mask = input_ids.ne(config.pad_token_id).to(torch_device)
         model = Ernie4_5_MoeForCausalLM(config)
         model.to(torch_device)
         model.eval()
         result = model(input_ids, attention_mask=attention_mask)
-        self.assertEqual(result.router_logits[0].shape, (91, config.num_experts))
+        bs, seqlen = input_ids.shape
+        self.assertEqual(result.router_logits[0].shape, (bs * seqlen, config.num_experts))
         torch.testing.assert_close(result.aux_loss.cpu(), torch.tensor(2, dtype=torch.float32), rtol=1e-2, atol=1e-2)
 
         # First, we make sure that adding padding tokens doesn't change the loss
         # loss(input_ids, attention_mask=None) == loss(input_ids + padding, attention_mask=attention_mask_with_padding)
+        # (This length is selected from experiments)
         pad_length = input_ids.shape[1] * 4
-        # Add padding tokens (assume that pad_token_id=1) to input_ids
-        padding_block = torch.ones(input_ids.shape[0], pad_length, dtype=torch.int32).to(torch_device)
+        # Add padding tokens to input_ids
+        padding_block = config.pad_token_id * torch.ones(input_ids.shape[0], pad_length, dtype=torch.int32).to(
+            torch_device
+        )
         padded_input_ids = torch.cat((padding_block, input_ids), dim=1)  # this is to simulate padding to the left
-        padded_attention_mask = padded_input_ids.ne(1).to(torch_device)
+        padded_attention_mask = padded_input_ids.ne(config.pad_token_id).to(torch_device)
 
         padded_result = model(padded_input_ids, attention_mask=padded_attention_mask)
         torch.testing.assert_close(result.aux_loss.cpu(), padded_result.aux_loss.cpu(), rtol=1e-4, atol=1e-4)