helloadhavan/github_issues huggingface dataset:
Repository: ggml-org/llama.cpp
Pull request: ci : use openssl for openEuler-latest-cmake-cann

Quick PR to validate #18775

Changed files:
filename: .github/workflows/build.yml
patch: @@ -1463,12 +1463,14 @@ jobs:
             "${{ steps.cann-image.outputs.image }}" \
             bash -lc '
               set -e
-              yum install -y --setopt=install_weak_deps=False --setopt=tsflags=nodocs git gcc gcc-c++ make cmake libcurl-devel
+              yum install -y --setopt=install_weak_deps=False --setopt=tsflags=nodocs git gcc gcc-c++ make cmake openssl-devel
               yum clean all && rm -rf /var/cache/yum
               git config --global --add safe.directory "/workspace"
               export LD_LIBRARY_PATH=${ASCEND_TOOLKIT_HOME}/lib64:${ASCEND_TOOLKIT_HOME}/$(uname -m)-linux/devlib/:${LD_LIBRARY_PATH}
               cmake -S . -B build \
                   -DCMAKE_BUILD_TYPE=${BUILD_TYPE} \
+                  -DLLAMA_CURL=OFF \
+                  -DLLAMA_OPENSSL=ON \
                   -DGGML_CANN=on \
                   -DSOC_TYPE=${SOC_TYPE}
               cmake --build build -j $(nproc)
Repository: ollama/ollama
Pull request: remove confusing log message

chat template isn't being used so there's no reason to validate

Changed files:
filename: llm/ext_server/server.cpp
patch: @@ -56,7 +56,6 @@ struct server_params {
     std::string hostname = "127.0.0.1";
     std::vector<std::string> api_keys;
     std::string public_path = "examples/server/public";
-    std::string chat_template = "";
     int32_t port = 8080;
     int32_t read_timeout = 600;
     int32_t write_timeout = 600;
@@ -427,16 +426,6 @@ struct llama_server_context
         return true;
     }
 
-    void validate_model_chat_template(server_params & sparams) {
-        llama_chat_message chat[] = {{"user", "test"}};
-        std::vector<char> buf(1);
-        int res = llama_chat_apply_template(model, nullptr, chat, 1, true, buf.data(), buf.size());
-        if (res < 0) {
-            LOG_ERROR("The chat template comes with this model is not yet supported, falling back to chatml. This may cause the model to output suboptimal responses", {});
-            sparams.chat_template = "chatml";
-        }
-    }
-
     void initialize() {
         // create slots
         all_slots_are_idle = true;
@@ -2535,7 +2524,6 @@ static void server_params_parse(int argc, char **argv, server_params &sparams, g
                 invalid_param = true;
                 break;
             }
-            sparams.chat_template = argv[i];
         }
         else if (arg == "--override-kv")
         {
@@ -3008,11 +2996,6 @@ int main(int argc, char **argv) {
     }
     const auto model_meta = llama.model_meta();
 
-    if (sparams.chat_template.empty()) { // custom chat template is not supplied
-        // check if the template comes with the model is supported by us
-        llama.validate_model_chat_template(sparams);
-    }
-
     // Middleware for API key validation
     auto validate_api_key = [&sparams](const httplib::Request &req, httplib::Response &res) -> bool {
         // If API key is not set, skip validation
Repository: huggingface/transformers
Pull request: [deepspeed tests fixes]

Fixing a few deepspeed tests


Changed files:
filename: tests/deepspeed/test_deepspeed.py
patch: @@ -756,13 +756,9 @@ def test_gradient_accumulation(self, stage, dtype):
             self.assertNotEqual(yes_grad_accum_a, a)
 
         # training with half the batch size but accumulation steps as 2 should give the same
-        # weights, but sometimes get a slight difference still of 1e-6
-        if torch_device == "hpu":
-            self.assertAlmostEqual(no_grad_accum_a, yes_grad_accum_a, delta=1e-4)
-            self.assertAlmostEqual(no_grad_accum_b, yes_grad_accum_b, delta=1e-4)
-        else:
-            self.assertAlmostEqual(no_grad_accum_a, yes_grad_accum_a, places=5)
-            self.assertAlmostEqual(no_grad_accum_b, yes_grad_accum_b, places=5)
+        # weights, but sometimes get a slight difference still
+        self.assertAlmostEqual(no_grad_accum_a, yes_grad_accum_a, delta=1e-4)
+        self.assertAlmostEqual(no_grad_accum_b, yes_grad_accum_b, delta=1e-4)
 
         # Relative difference. See the note above how to get identical loss on a small bs
         self.assertTrue((no_grad_accum_loss - yes_grad_accum_loss) / (no_grad_accum_loss + 1e-15) <= 1e-3)
Repository: vercel/next.js
Pull request: Fix crash when suspending in Components using `useActionQueue`

With https://github.com/vercel/next.js/pull/84580, we are creating a new Promise during render. `useMemo` doesn't guarantee that this Promise is cached resulting in an infinite loop that ends in an error due to uncache Promises. We're now using a `WeakMap` keyed on the original Promise to cache the Promise.

This also gates the behavior on dev since async debug info is a dev-only feature.

I don't know how to test this functionality. Timing for "rsc stream" is unaffected.

Update: The actual bug is that the state update changing the `state` of `useActionQueue` is not wrapped in `startTransition`. Once the re-render is in a Transition, we can use `useMemo` to cache a Promise. This is a harder refactor so we're keeping this change but it needs to be removed ultimately to flush out bugs where the state update is not wrapped in a Transition.

Closes NAR-460

Changed files:
filename: packages/next/src/client/components/use-action-queue.ts
patch: @@ -22,6 +22,12 @@ export function dispatchAppRouterAction(action: ReducerActions) {
   dispatch(action)
 }
 
+const __DEV__ = process.env.NODE_ENV !== 'production'
+const promisesWithDebugInfo: WeakMap<
+  Promise<AppRouterState>,
+  Promise<AppRouterState> & { _debugInfo?: Array<unknown> }
+> = __DEV__ ? new WeakMap() : (null as any)
+
 export function useActionQueue(
   actionQueue: AppRouterActionQueue
 ): AppRouterState {
@@ -56,15 +62,27 @@ export function useActionQueue(
   // passed to React (via `use`) so that the latency is accurately represented
   // in the React DevTools.
   const stateWithDebugInfo = useMemo(() => {
+    if (!__DEV__) {
+      return state
+    }
+
     if (isThenable(state)) {
-      const debugInfo: Array<unknown> = []
-      const promiseWithDebugInfo = Promise.resolve(state).then((asyncState) => {
-        if (asyncState.debugInfo !== null) {
-          debugInfo.push(...asyncState.debugInfo)
-        }
-        return asyncState
-      }) as Promise<AppRouterState> & { _debugInfo?: Array<unknown> }
-      promiseWithDebugInfo._debugInfo = debugInfo
+      // useMemo can't be used to cache a Promise since the memoized value is thrown
+      // away when we suspend. So we use a WeakMap to cache the Promise with debug info.
+      let promiseWithDebugInfo = promisesWithDebugInfo.get(state)
+      if (promiseWithDebugInfo === undefined) {
+        const debugInfo: Array<unknown> = []
+        promiseWithDebugInfo = Promise.resolve(state).then((asyncState) => {
+          if (asyncState.debugInfo !== null) {
+            debugInfo.push(...asyncState.debugInfo)
+          }
+          return asyncState
+        }) as Promise<AppRouterState> & { _debugInfo?: Array<unknown> }
+        promiseWithDebugInfo._debugInfo = debugInfo
+
+        promisesWithDebugInfo.set(state, promiseWithDebugInfo)
+      }
+
       return promiseWithDebugInfo
     }
     return state
Repository: facebook/react
Pull request: Allow `useEffect(fn, undefined)` in `react-hooks/exhaustive-deps`.

## Summary

There is a bug in the `react-hooks/exhaustive-deps` rule that forbids the dependencies argument from being `undefined`. It triggers the error that the dependency list is not an array literal. This makes sense in pre ES5 strict-mode environments as undefined could be redefined, but should not be a concern in today's JS environments.

**Justification:**
* The deps argument being undefined (for `useEffect` calls etc.) is a valid use case for hooks that should re-run on every render.
* The deps argument being omitted is considered a valid use case by the `exhaustive-deps` rule already.
* The TypeScript type definitions support passing `undefined` because hooks are typed as `useEffect(effect: EffectCallback, deps?: DependencyList): void;`.
* Since omitting an argument and passing `undefined` are considered equivalent, this eslint rule should consider them as equivalent too.

Further, I accidentally forgot passing a dependency array to `useEffect` in code that I shared on Twitter, and people started abusing me about it. I'd like to create an eslint rule for my projects that requires me to provide a dep argument in all cases (`undefined`, `[]` or the list of dependencies) so that I can avoid such problems in the future. This would also force me to always think about the dependencies instead of accidentally forgetting them and my hook running on each render. In an audit of my own codebase I had about 3% of hooks that I want to run on each render, and adding an explicit `undefined` seems reasonable in those situations.

It could be argued this could be an option or part of the `exhaustive-deps` rule, but it's probably better to merge this PR, make a release and see if my custom eslint rule gains traction in the future.

## How did you test this change?

* Added a test.
* `yarn test ESLintRuleExhaustiveDeps-test`
* Careful code inspection.

Changed files:
filename: packages/eslint-plugin-react-hooks/__tests__/ESLintRuleExhaustiveDeps-test.js
patch: @@ -1452,6 +1452,15 @@ const tests = {
         }
       `,
     },
+    {
+      code: normalizeIndent`
+        function MyComponent() {
+          useEffect(() => {
+            console.log('banana banana banana');
+          }, undefined);
+        }
+      `,
+    },
   ],
   invalid: [
     {

filename: packages/eslint-plugin-react-hooks/src/ExhaustiveDeps.js
patch: @@ -1161,7 +1161,12 @@ export default {
       const callback = node.arguments[callbackIndex];
       const reactiveHook = node.callee;
       const reactiveHookName = getNodeWithoutReactNamespace(reactiveHook).name;
-      const declaredDependenciesNode = node.arguments[callbackIndex + 1];
+      const maybeNode = node.arguments[callbackIndex + 1];
+      const declaredDependenciesNode =
+        maybeNode &&
+        !(maybeNode.type === 'Identifier' && maybeNode.name === 'undefined')
+          ? maybeNode
+          : undefined;
       const isEffect = /Effect($|[^a-z])/g.test(reactiveHookName);
 
       // Check whether a callback is supplied. If there is no callback supplied
Repository: huggingface/transformers
Pull request: Revert back to use GitHub context 

# What does this PR do?

Revert back to use GitHub context .

After the previous PR

Avoid explicit checkout in workflow (#42057), when a PR touched a lot of files, we get 

> Error: An error occurred trying to start process '/home/runner/actions-runner/cached/externals/node20/bin/node' with working directory '/home/runner/work/transformers/transformers'. Argument list too long

Changed files:
filename: .github/workflows/pr_slow_ci_suggestion.yml
patch: @@ -28,13 +28,15 @@ jobs:
         with:
           fetch-depth: "0"
 
+      # We need to use `${{ ... }}` here to avoid `Argument list too long` error when a PR changes a lot of files.
+      # (We could also try to use artifact approach, but it's more involved).
+      # `CodeQL` doesn't identify any security issue here. Also `PR_FILES` is from `get-pr-info.yml` by using an api
+      # `github.rest.pulls.listFiles`, which is fine.
       - name: Write pr_files file
-        uses: actions/github-script@v7
-        with:
-          script: |
-            const fs = require('node:fs');
-            const prFilesJson = `${{ needs.get-pr-info.outputs.PR_FILES }}`;
-            fs.writeFileSync('pr_files.txt', prFilesJson);
+        run: |
+          cat > pr_files.txt << 'EOF'
+          ${{ needs.get-pr-info.outputs.PR_FILES }}
+          EOF
 
       - name: Get repository content
         id: repo_content
Repository: nodejs/node
Pull request: deps: update ada to 3.3.0

This is an automated update of ada to 3.3.0.

Changed files:
filename: deps/ada/ada.cpp
patch: @@ -1,4 +1,4 @@
-/* auto-generated on 2025-09-22 20:51:08 -0400. Do not edit! */
+/* auto-generated on 2025-09-23 12:57:35 -0400. Do not edit! */
 /* begin file src/ada.cpp */
 #include "ada.h"
 /* begin file src/checkers.cpp */

filename: deps/ada/ada.h
patch: @@ -1,4 +1,4 @@
-/* auto-generated on 2025-09-22 20:51:08 -0400. Do not edit! */
+/* auto-generated on 2025-09-23 12:57:35 -0400. Do not edit! */
 /* begin file include/ada.h */
 /**
  * @file ada.h
@@ -10515,14 +10515,14 @@ constructor_string_parser<regex_provider>::parse(std::string_view input) {
 #ifndef ADA_ADA_VERSION_H
 #define ADA_ADA_VERSION_H
 
-#define ADA_VERSION "3.2.9"
+#define ADA_VERSION "3.3.0"
 
 namespace ada {
 
 enum {
   ADA_VERSION_MAJOR = 3,
-  ADA_VERSION_MINOR = 2,
-  ADA_VERSION_REVISION = 9,
+  ADA_VERSION_MINOR = 3,
+  ADA_VERSION_REVISION = 0,
 };
 
 }  // namespace ada
Repository: vuejs/vue
Pull request: Fix/order by primitives

Bug introduced in 04a213b3215067de0e05ea65603273a7d92baf7a
Usage shown in the doc: http://vuejs.org/api/#orderBy
`arr | orderBy true`


Changed files:
filename: src/filters/array-filters.js
patch: @@ -75,16 +75,18 @@ export function filterBy (arr, search, delimiter) {
  * Filter filter for arrays
  *
  * @param {String|Array<String>} sortKeys
- * @param {String} reverse
+ * @param {Boolean} [order]
  */
 
-export function orderBy (arr, sortKeys, reverse) {
+export function orderBy (arr, sortKeys, order) {
   arr = convertArray(arr)
-  let order = (reverse && reverse < 0) ? -1 : 1
+  order = (order && order < 0) ? -1 : 1
 
   if (typeof sortKeys === 'string') {
     sortKeys = [sortKeys]
-  } else if (!sortKeys || !sortKeys.length) {
+  } else if (!sortKeys || (sortKeys !== true && !sortKeys.length)) {
+    // we check if sortKeys === true because you can sort primitive values with
+    // array | orderBy true: http://vuejs.org/api/#orderBy
     return arr
   }
 
@@ -101,7 +103,9 @@ export function orderBy (arr, sortKeys, reverse) {
 
   function recursiveCompare (a, b, i) {
     i = i || 0
-    if (i === sortKeys.length - 1) return compare(a, b, i)
+    if (sortKeys === true || i === sortKeys.length - 1) {
+      return compare(a, b, i)
+    }
     return compare(a, b, i) || recursiveCompare(a, b, i + 1)
   }
 

filename: test/unit/specs/filters/filters_spec.js
patch: @@ -230,6 +230,13 @@ describe('Filters', function () {
     assertArray(res, [arr[1], arr[2], arr[0]])
   })
 
+  it('orderBy primitive values', function () {
+    var filter = filters.orderBy
+    var arr = [9, 11, 1, 2]
+    var res = filter(arr, true)
+    assertArray(res, [arr[2], arr[3], arr[0], arr[1]])
+  })
+
   it('orderBy multiple fields', function () {
     var filter = filters.orderBy
     var arr = [
Repository: electron/electron
Pull request: fix: `shell.openPath` should be non-blocking

#### Description of Change

Closes https://github.com/electron/electron/issues/47668.

Fixes an issue where `shell.openPath` was not non-blocking as expected.

#### Checklist
<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

- [x] PR description included and stakeholders cc'd
- [x] `npm test` passes
- [x] [PR release notes](https://github.com/electron/clerk/blob/main/README.md) describe the change in a way relevant to app developers, and are [capitalized, punctuated, and past tense](https://github.com/electron/clerk/blob/main/README.md#examples).

#### Release Notes

Notes: Fixed an issue where `shell.openPath` was not non-blocking as expected.

Changed files:
filename: shell/common/platform_util_linux.cc
patch: @@ -342,7 +342,7 @@ void ShowItemInFolder(const base::FilePath& full_path) {
 
 void OpenPath(const base::FilePath& full_path, OpenCallback callback) {
   // This is async, so we don't care about the return value.
-  XDGOpen(full_path.DirName(), full_path.value(), true, std::move(callback));
+  XDGOpen(full_path.DirName(), full_path.value(), false, std::move(callback));
 }
 
 void OpenFolder(const base::FilePath& full_path) {
Repository: ollama/ollama
Pull request: Fix bad symbol load detection

pointer deref's weren't correct on a few libraries, which explains some crashes on older systems or miswired symlinks for discovery libraries.

Fixes #4982 

Changed files:
filename: gpu/gpu_info_cudart.c
patch: @@ -40,7 +40,7 @@ void cudart_init(char *cudart_lib_path, cudart_init_resp_t *resp) {
 
   for (i = 0; l[i].s != NULL; i++) {
     *l[i].p = LOAD_SYMBOL(resp->ch.handle, l[i].s);
-    if (!l[i].p) {
+    if (!*(l[i].p)) {
       char *msg = LOAD_ERR();
       LOG(resp->ch.verbose, "dlerr: %s\n", msg);
       UNLOAD_LIBRARY(resp->ch.handle);

filename: gpu/gpu_info_nvcuda.c
patch: @@ -43,7 +43,7 @@ void nvcuda_init(char *nvcuda_lib_path, nvcuda_init_resp_t *resp) {
 
   for (i = 0; l[i].s != NULL; i++) {
     *l[i].p = LOAD_SYMBOL(resp->ch.handle, l[i].s);
-    if (!*l[i].p) {
+    if (!*(l[i].p)) {
       char *msg = LOAD_ERR();
       LOG(resp->ch.verbose, "dlerr: %s\n", msg);
       UNLOAD_LIBRARY(resp->ch.handle);

filename: gpu/gpu_info_nvml.c
patch: @@ -42,7 +42,7 @@ void nvml_init(char *nvml_lib_path, nvml_init_resp_t *resp) {
     // LOG(resp->ch.verbose, "dlsym: %s\n", l[i].s);
 
     *l[i].p = LOAD_SYMBOL(resp->ch.handle, l[i].s);
-    if (!l[i].p) {
+    if (!*(l[i].p)) {
       resp->ch.handle = NULL;
       char *msg = LOAD_ERR();
       LOG(resp->ch.verbose, "dlerr: %s\n", msg);
Repository: facebook/react
Pull request: Remove trim_trailing_whitespace from editorconfig

This setting breaks `toMatchInlineSnapshot` by removing whitespace in snapshots.

Changed files:
filename: .editorconfig
patch: @@ -8,11 +8,9 @@ indent_size = 2
 indent_style = space
 insert_final_newline = true
 max_line_length = 80
-trim_trailing_whitespace = true
 
 [*.md]
 max_line_length = 0
-trim_trailing_whitespace = false
 
 [COMMIT_EDITMSG]
 max_line_length = 0
Repository: vercel/next.js
Pull request: [test] Deflake cache-components-allow-otel-spans

The server startup may take a while. Now we use the same timeout as `client-trace-metadata.test.ts` (15s) which also uses OTEL.

Changed files:
filename: test/e2e/app-dir/cache-components-allow-otel-spans/cache-components-allow-otel-spans.test.ts
patch: @@ -4,6 +4,9 @@ describe('hello-world', () => {
   const { next, isTurbopack } = nextTestSetup({
     files: __dirname,
     dependencies: require('./package.json').dependencies,
+    // This test sometimes takes longer than the default timeout, extending it bit longer
+    // to avoid flakiness.
+    startServerTimeout: 15_000,
   })
 
   if (isNextDev) {
Repository: nodejs/node
Pull request: lib: remove util.getCallSite

This API has been replaced by util.getCallSites().

It was previously experimental with a warning about its usage and its removal in a semver-minor PR. Here it is.

Changed files:
filename: lib/util.js
patch: @@ -473,11 +473,6 @@ module.exports = {
   format,
   styleText,
   formatWithOptions,
-  // Deprecated getCallSite.
-  // This API can be removed in next semver-minor release.
-  getCallSite: deprecate(getCallSites,
-                         'The `util.getCallSite` API has been renamed to `util.getCallSites()`.',
-                         'ExperimentalWarning'),
   getCallSites,
   getSystemErrorMap,
   getSystemErrorName,

filename: test/parallel/test-util-getcallsite.js
patch: @@ -1,9 +0,0 @@
-'use strict';
-
-require('../common');
-const { getCallSite } = require('node:util');
-const { expectWarning } = require('../common');
-
-const warning = 'The `util.getCallSite` API has been renamed to `util.getCallSites()`.';
-expectWarning('ExperimentalWarning', warning);
-getCallSite();
Repository: huggingface/transformers
Pull request: Fix KeyError in _is_package_available for packages with dotted names

# What does this PR do?

Fixes #41981

I ran into this issue while testing with `optimum.quanto`. The function was crashing with `KeyError` when checking for packages with dotted names.

The problem is in `import_utils.py` line 56 - when it tries to look up the package in `PACKAGE_DISTRIBUTION_MAPPING`, packages with dots in the name (like `optimum.quanto`) aren't always there. The mapping might only have `optimum` as a key, not `optimum.quanto`.

The function already has fallback logic to handle cases where package metadata can't be found - it imports the package directly and checks for `__version__`. But the exception handler only caught `PackageNotFoundError`, not `KeyError`.

I added `KeyError` to the exception handler so the fallback works for both cases. Now when a package name isn't in the mapping, it'll use the same fallback path instead of crashing.

This is a one-line change that handles the edge case without affecting normal operation. The existing tests should still pass since the behavior for normal packages is unchanged.


Changed files:
filename: src/transformers/utils/import_utils.py
patch: @@ -58,7 +58,7 @@ def _is_package_available(pkg_name: str, return_version: bool = False) -> tuple[
             # pick the first item of the list as best guess (it's almost always a list of length 1 anyway)
             distribution_name = pkg_name if pkg_name in distributions else distributions[0]
             package_version = importlib.metadata.version(distribution_name)
-        except importlib.metadata.PackageNotFoundError:
+        except (importlib.metadata.PackageNotFoundError, KeyError):
             # If we cannot find the metadata (because of editable install for example), try to import directly.
             # Note that this branch will almost never be run, so we do not import packages for nothing here
             package = importlib.import_module(pkg_name)
Repository: vuejs/vue
Pull request: fix: array $remove method jsdoc


Changed files:
filename: src/observer/array.js
patch: @@ -69,10 +69,9 @@ def(
 )
 
 /**
- * Convenience method to remove the element at given index.
+ * Convenience method to remove the element at given index or target element reference.
  *
- * @param {Number} index
- * @param {*} val
+ * @param {*} item
  */
 
 def(
Repository: facebook/react
Pull request: Reenable lazy context propagation

Reverts facebook/react#31403 to reenable lazy context propagation

The disabling was to produce a build that could help track down whether this flag is causing a possibly related bug in transitions but we don't intend to disable it just fix forward once we figure out what the problem is

Changed files:
filename: packages/shared/ReactFeatureFlags.js
patch: @@ -101,7 +101,7 @@ export const enableObjectFiber = false;
 
 export const enableTransitionTracing = false;
 
-export const enableLazyContextPropagation = false;
+export const enableLazyContextPropagation = true;
 
 // Expose unstable useContext for performance testing
 export const enableContextProfiling = false;
Repository: huggingface/transformers
Pull request: Fix another `Argument list too long` in `pr_slow_ci_suggestion.yml`

# What does this PR do?

Fix another `Argument list too long` in `pr_slow_ci_suggestion.yml`

Changed files:
filename: .github/workflows/pr_slow_ci_suggestion.yml
patch: @@ -29,12 +29,12 @@ jobs:
           fetch-depth: "0"
 
       - name: Write pr_files file
-        env:
-          PR_FILES: ${{ needs.get-pr-info.outputs.PR_FILES }}
-        run: |
-          cat > pr_files.txt << EOF
-          $PR_FILES
-          EOF
+        uses: actions/github-script@v7
+        with:
+          script: |
+            const fs = require('node:fs');
+            const prFilesJson = `${{ needs.get-pr-info.outputs.PR_FILES }}`;
+            fs.writeFileSync('pr_files.txt', prFilesJson);
 
       - name: Get repository content
         id: repo_content