helloadhavan/github_issues huggingface dataset:
Repository: ggml-org/llama.cpp
Pull request: server: fix crash when batch > ubatch with embeddings (#12836)

Fixes #12836

## Problem
Server crashes with `GGML_ASSERT` failure when running embeddings with `-b > -ub`:
Embeddings use non-causal attention which requires all tokens in a single ubatch. When `n_batch > n_ubatch`, the server attempts to split processing, triggering the assertion.

## Solution

Add parameter validation in `main()` after `common_params_parse()`:
- Detect when `--embedding` is enabled and `n_batch > n_ubatch`
- Log warnings explaining the auto-correction
- Set `n_batch = n_ubatch` to prevent crash

Follows @ggerganov's suggested approach in #12836.

## Testing

- ✅ Built server with fix
- ✅ Tested with problematic config: `./llama-server -m model.gguf --embedding -b 2048 -ub 512`
- ✅ Confirmed warning logs appear and parameters are auto-corrected
- ✅ Verified server starts successfully (no GGML_ASSERT crash)
- ✅ Tested valid configurations to ensure no false positives


## Note

Supersedes stalled PR #12940 which attempted a runtime fix in the old `examples/server/` location. This implementation validates at startup in `tools/server/` (current location) per maintainer guidance.

Changed files:
filename: tools/server/server.cpp
patch: @@ -73,8 +73,18 @@ int main(int argc, char ** argv, char ** envp) {
         return 1;
     }
 
+    // validate batch size for embeddings
+    // embeddings require all tokens to be processed in a single ubatch
+    // see https://github.com/ggml-org/llama.cpp/issues/12836
+    if (params.embedding && params.n_batch > params.n_ubatch) {
+        LOG_WRN("%s: embeddings enabled with n_batch (%d) > n_ubatch (%d)\n", __func__, params.n_batch, params.n_ubatch);
+        LOG_WRN("%s: setting n_batch = n_ubatch = %d to avoid assertion failure\n", __func__, params.n_ubatch);
+        params.n_batch = params.n_ubatch;
+    }
+
     if (params.n_parallel < 0) {
         LOG_INF("%s: n_parallel is set to auto, using n_parallel = 4 and kv_unified = true\n", __func__);
+
         params.n_parallel = 4;
         params.kv_unified = true;
     }
Repository: denoland/deno
Pull request: fix: set `process.features.openssl_is_boringssl` to `true`

- [x] Investigate test-crypto-certificate.js failure
- [x] Identify root cause: `process.features.openssl_is_boringssl` is `false` but Deno uses aws-lc (BoringSSL-based)
- [x] Fix `openssl_is_boringssl` to `true` in `ext/node/polyfills/process.ts`
- [x] Add `test-crypto-certificate.js` to `tests/node_compat/config.jsonc`
- [x] Verify the test passes (both `test-crypto-certificate.js` and `test-process-features.js`)
- [x] Run code review and security checks

<!-- START COPILOT CODING AGENT TIPS -->
---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more [Copilot coding agent tips](https://gh.io/copilot-coding-agent-tips) in the docs.

Changed files:
filename: ext/node/polyfills/process.ts
patch: @@ -959,8 +959,9 @@ const features = {
   // deno-lint-ignore camelcase
   tls_ocsp: true,
   tls: true,
+  // Deno uses aws-lc, which is BoringSSL-based.
   // deno-lint-ignore camelcase
-  openssl_is_boringssl: false,
+  openssl_is_boringssl: true,
   // deno-lint-ignore camelcase
   cached_builtins: true,
   // deno-lint-ignore camelcase

filename: tests/node_compat/config.jsonc
patch: @@ -250,6 +250,7 @@
     "parallel/test-console-sync-write-error.js": {},
     "parallel/test-console-table.js": {},
     "parallel/test-console-with-frozen-intrinsics.js": {},
+    "parallel/test-crypto-certificate.js": {},
     "parallel/test-crypto-dh-constructor.js": {},
     "parallel/test-crypto-dh-leak.js": {},
     "parallel/test-crypto-dh-odd-key.js": {},
Repository: nodejs/node
Pull request: doc: add Miles Guicent as triager

<!--
Before submitting a pull request, please read:

- the CONTRIBUTING guide at https://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md
- the commit message formatting guidelines at
  https://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#commit-message-guidelines

For code changes:
1. Include tests for any bug fixes or new features.
2. Update documentation if relevant.
3. Ensure that `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes.

If you believe this PR should be highlighted in the Node.js CHANGELOG
please add the `notable-change` label.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.
-->
I would like to apply to be a triager for this project.

I have been very active on the official discord server, and @avivkeller & @ovflowd suggested I become a member of the triage team to be able to extend my supports work to the node project directly.
I want to help people, and through this keep broadening my knowledge of nodejs.

As I back-end developer for now ten years, I always want to contribute to the FOSS projects I rely on, so I also hope this can be a first step toward a deeper involvement in the project.

I have read the Code of Conduct, and swear to abide by it.

Changed files:
filename: README.md
patch: @@ -767,6 +767,8 @@ maintaining the Node.js project.
   **Akhil Marsonya** <<akhil.marsonya27@gmail.com>> (he/him)
 * [meixg](https://github.com/meixg) -
   **Xuguang Mei** <<meixuguang@gmail.com>> (he/him)
+* [milesguicent](https://github.com/milesguicent) -
+  **Miles Guicent** <<guicent@pm.me>> (he/him)
 * [preveen-stack](https://github.com/preveen-stack) -
   **Preveen Padmanabhan** <<wide4head@gmail.com>> (he/him)
 * [RaisinTen](https://github.com/RaisinTen) -
Repository: electron/electron
Pull request: fix: silent printing of PDFs with `webContents.print`

Backport of #47378

See that PR for details.


Notes: Fixed an issue where printing PDFs with `webContents.print({ silent: true })` would fail. 


Changed files:
filename: patches/chromium/printing.patch
patch: @@ -666,7 +666,7 @@ index 6809c4576c71bc1e1a6ad4e0a37707272a9a10f4..3aad10424a6a31dab2ca393d00149ec6
    PrintingFailed(int32 cookie, PrintFailureReason reason);
  
 diff --git a/components/printing/renderer/print_render_frame_helper.cc b/components/printing/renderer/print_render_frame_helper.cc
-index 08af2c8458fdc2539b437c3ff7e3fa2b5d36eeda..5a8d2f3cc57a66535afb027ee43eebc3b3ffe41c 100644
+index 08af2c8458fdc2539b437c3ff7e3fa2b5d36eeda..bac316baaf4340848666085b3de69c99ee522abe 100644
 --- a/components/printing/renderer/print_render_frame_helper.cc
 +++ b/components/printing/renderer/print_render_frame_helper.cc
 @@ -52,6 +52,7 @@
@@ -744,7 +744,7 @@ index 08af2c8458fdc2539b437c3ff7e3fa2b5d36eeda..5a8d2f3cc57a66535afb027ee43eebc3
    print_preview_context_.OnPrintPreview();
  
  #if BUILDFLAG(IS_CHROMEOS)
-@@ -2062,17 +2068,19 @@ void PrintRenderFrameHelper::PrintNode(const blink::WebNode& node) {
+@@ -2062,17 +2068,25 @@ void PrintRenderFrameHelper::PrintNode(const blink::WebNode& node) {
  
  void PrintRenderFrameHelper::Print(blink::WebLocalFrame* frame,
                                     const blink::WebNode& node,
@@ -759,6 +759,12 @@ index 08af2c8458fdc2539b437c3ff7e3fa2b5d36eeda..5a8d2f3cc57a66535afb027ee43eebc3
    FrameReference frame_ref(frame);
  
 -  if (!InitPrintSettings(frame, node)) {
++  // If we're silently printing a PDF, we bypass settings logic
++  // that sets modifiability to false so ensure it's set here.
++  if (silent && IsPrintingPdfFrame(frame, node)) {
++    settings.Set(kSettingPreviewModifiable, false);
++  }
++
 +  if (!InitPrintSettings(frame, node, std::move(settings))) {
      // Browser triggered this code path. It already knows about the failure.
      notify_browser_of_print_failure_ = false;
@@ -767,7 +773,7 @@ index 08af2c8458fdc2539b437c3ff7e3fa2b5d36eeda..5a8d2f3cc57a66535afb027ee43eebc3
      DidFinishPrinting(PrintingResult::kFailPrintInit);
      return;
    }
-@@ -2093,8 +2101,15 @@ void PrintRenderFrameHelper::Print(blink::WebLocalFrame* frame,
+@@ -2093,8 +2107,15 @@ void PrintRenderFrameHelper::Print(blink::WebLocalFrame* frame,
          print_pages_params_->params->print_scaling_option;
  
      auto self = weak_ptr_factory_.GetWeakPtr();
@@ -784,7 +790,7 @@ index 08af2c8458fdc2539b437c3ff7e3fa2b5d36eeda..5a8d2f3cc57a66535afb027ee43eebc3
      // Check if `this` is still valid.
      if (!self)
        return;
-@@ -2362,29 +2377,43 @@ void PrintRenderFrameHelper::IPCProcessed() {
+@@ -2362,29 +2383,43 @@ void PrintRenderFrameHelper::IPCProcessed() {
  }
  
  bool PrintRenderFrameHelper::InitPrintSettings(blink::WebLocalFrame* frame,
Repository: huggingface/transformers
Pull request: Fix detectron2 import

# What does this PR do?

Detectron2 does not uninstall correctly for some reason (probably the setup as the lib needs to be installed from source) so we need this cc @ydshieh 

Changed files:
filename: src/transformers/utils/import_utils.py
patch: @@ -724,7 +724,15 @@ def is_datasets_available() -> bool:
 
 @lru_cache
 def is_detectron2_available() -> bool:
-    return _is_package_available("detectron2")
+    # We need this try/except block because otherwise after uninstalling the library, it stays available for some reason
+    # i.e. `import detectron2` and `import detectron2.modeling` still work, even though the library is uninstalled
+    # (the package exists but the objects are not reachable) - so here we explicitly try to import an object from it
+    try:
+        from detectron2.modeling import META_ARCH_REGISTRY  # noqa
+
+        return True
+    except Exception:
+        return False
 
 
 @lru_cache
Repository: ggml-org/llama.cpp
Pull request: model-conversion : add note about verifying previous models

This commit adds a note to the README in the model-conversion examples, advising developers to verify that previous versions of models pass logits verification before adding new models from the same family.


Changed files:
filename: examples/model-conversion/README.md
patch: @@ -10,6 +10,13 @@ and in some cases perplexity checked of the quantized model. And finally the
 model/models need to the ggml-org on Hugging Face. This tool/example tries to
 help with this process.
 
+> 📝 **Note:** When adding a new model from an existing family, verify the
+> previous version passes logits verification first. Existing models can have
+> subtle numerical differences that don't affect generation quality but cause
+> logits mismatches. Identifying these upfront whether they exist in llama.cpp,
+> the conversion script, or in an upstream implementation, can save significant
+> debugging time.
+
 ### Overview
 The idea is that the makefile targets and scripts here can be used in the
 development/conversion process assisting with things like:
Repository: nodejs/node
Pull request: src: use non-deprecated Get/SetPrototype methods

Refs: https://github.com/v8/v8/commit/5e139e98d1e4d8bbcccf7b15cd8e7d08b28e4a81

<!--
Before submitting a pull request, please read:

- the CONTRIBUTING guide at https://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md
- the commit message formatting guidelines at
  https://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#commit-message-guidelines

For code changes:
1. Include tests for any bug fixes or new features.
2. Update documentation if relevant.
3. Ensure that `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes.

If you believe this PR should be highlighted in the Node.js CHANGELOG
please add the `notable-change` label.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.
-->


Changed files:
filename: src/node_sqlite.cc
patch: @@ -2111,9 +2111,9 @@ void StatementSync::Iterate(const FunctionCallbackInfo<Value>& args) {
       StatementSyncIterator::Create(env, BaseObjectPtr<StatementSync>(stmt));
 
   if (iter->object()
-          ->GetPrototype()
+          ->GetPrototypeV2()
           .As<Object>()
-          ->SetPrototype(context, js_iterator_prototype)
+          ->SetPrototypeV2(context, js_iterator_prototype)
           .IsNothing()) {
     return;
   }
Repository: huggingface/transformers
Pull request: Remove outdated flags

# What does this PR do?

Those features disappeared recently, but those models were added in the middle so they still have the flags

Changed files:
filename: tests/models/cwm/test_modeling_cwm.py
patch: @@ -75,8 +75,6 @@ class CwmModelTest(CausalLMModelTest, unittest.TestCase):
         if is_torch_available()
         else {}
     )
-    test_headmasking = False
-    test_pruning = False
     fx_compatible = False
     model_tester_class = CwmModelTester
 

filename: tests/models/lfm2_moe/test_modeling_lfm2_moe.py
patch: @@ -62,8 +62,6 @@ class Lfm2MoeModelTest(CausalLMModelTest, unittest.TestCase):
         if is_torch_available()
         else {}
     )
-    test_headmasking = False
-    test_pruning = False
     fx_compatible = False
     model_tester_class = Lfm2MoeModelTester
     # used in `test_torch_compile_for_training`
Repository: denoland/deno
Pull request: perf(npm): actually improve `npm install -g deno` binary startup performance

Last pr didn't work: https://github.com/denoland/deno/pull/32439

Changed files:
filename: .github/workflows/npm_publish.yml
patch: @@ -168,6 +168,18 @@ jobs:
           echo "$ACTUAL"
           [ "$ACTUAL" = "$EXPECTED_VERSION" ] || { echo "Version mismatch: expected '$EXPECTED_VERSION', got '$ACTUAL'"; exit 1; }
           deno eval "console.log('global npm install works')"
+          # Verify the global bin entry points directly at the native binary, not bin.cjs
+          if [ "$RUNNER_OS" = "Windows" ]; then
+            DENO_CMD="$(npm prefix -g)/deno.cmd"
+            grep -q "bin.cjs" "$DENO_CMD" && { echo "ERROR: deno.cmd still points to bin.cjs"; exit 1; }
+            echo "deno.cmd correctly points to native binary"
+          else
+            DENO_LINK="$(which deno)"
+            LINK_TARGET="$(readlink "$DENO_LINK")"
+            echo "deno symlink target: $LINK_TARGET"
+            echo "$LINK_TARGET" | grep -q "bin.cjs" && { echo "ERROR: deno symlink still points to bin.cjs"; exit 1; }
+            echo "deno symlink correctly points to native binary"
+          fi
           npm uninstall -g deno
 
       - name: Test npm global install deno (--ignore-scripts)

filename: tools/release/npm/install_api.cjs
patch: @@ -191,6 +191,22 @@ function replaceBinEntry(exePath) {
 }
 
 function findBinDir() {
+  // For global installs, npm sets npm_config_global=true and npm_config_prefix
+  // to the install prefix. The bin dir is {prefix}/bin on Linux/Mac or
+  // {prefix} on Windows (e.g. %APPDATA%\npm).
+  if (process.env.npm_config_global === "true") {
+    const prefix = process.env.npm_config_prefix;
+    if (prefix) {
+      const binDir = os.platform() === "win32"
+        ? prefix
+        : path.join(prefix, "bin");
+      if (isBinDirForThisPackage(binDir)) {
+        return binDir;
+      }
+    }
+  }
+
+  // For local installs, walk up looking for node_modules/.bin
   let dir = __dirname;
   for (let i = 0; i < 64; i++) {
     const parent = path.dirname(dir);
Repository: ggml-org/llama.cpp
Pull request: Update README.md incorrect argument

detected error in readme quoting `n-gpu-layer` which is incorrect
argument is `n-gpu-layers` with the 's'
verified correct from to doco on L83
https://github.com/ggml-org/llama.cpp/blob/d6a1e18c651a46109cbf2ad3b299581f0651128f/tools/server/README.md?plain=1#L83


*Make sure to read the [contributing guidelines](https://github.com/ggml-org/llama.cpp/blob/master/CONTRIBUTING.md) before submitting a PR*

i have read contributing guidelines
documentation typo fix only, no code impacted

typo in Commit f32ca51


Changed files:
filename: tools/server/README.md
patch: @@ -1430,7 +1430,7 @@ Model presets allow advanced users to define custom configurations using an `.in
 llama-server --models-preset ./my-models.ini
 ```
 
-Each section in the file defines a new preset. Keys within a section correspond to command-line arguments (without leading dashes). For example, the argument `--n-gpu-layer 123` is written as `n-gpu-layer = 123`.
+Each section in the file defines a new preset. Keys within a section correspond to command-line arguments (without leading dashes). For example, the argument `--n-gpu-layers 123` is written as `n-gpu-layers = 123`.
 
 Short argument forms (e.g., `c`, `ngl`) and environment variable names (e.g., `LLAMA_ARG_N_GPU_LAYERS`) are also supported as keys.
 
@@ -1445,7 +1445,7 @@ version = 1
 ; string value
 chat-template = chatml
 ; numeric value
-n-gpu-layer = 123
+n-gpu-layers = 123
 ; flag value (for certain flags, you need to use the "no-" prefix for negation)
 jinja = true
 ; shorthand argument (for example, context size)
Repository: facebook/react
Pull request: Fix unstable_useContextWithBailout incorrect dispatcher assignment

Fixing a mistaken copy from another dispatcher property assignment

Changed files:
filename: packages/react-reconciler/src/ReactFiberHooks.js
patch: @@ -4839,7 +4839,7 @@ if (__DEV__) {
       };
   }
   if (enableContextProfiling) {
-    (HooksDispatcherOnUpdateInDEV: Dispatcher).unstable_useContextWithBailout =
+    (InvalidNestedHooksDispatcherOnMountInDEV: Dispatcher).unstable_useContextWithBailout =
       function <T>(
         context: ReactContext<T>,
         select: (T => Array<mixed>) | null,
Repository: denoland/deno
Pull request: fix(deploy): correctly handle version lookup


Changed files:
filename: cli/tools/deploy.rs
patch: @@ -47,7 +47,7 @@ pub async fn deploy(
       let file = factory
         .file_fetcher()?
         .fetch_bypass_permissions(
-          &registry_url.join("@deploy/deno/meta.json").unwrap(),
+          &registry_url.join("@deno/deploy/meta.json").unwrap(),
         )
         .await?;
       let info = serde_json::from_slice::<JsrPackageInfo>(&file.source)?;

filename: tests/registry/jsr/@deno/deploy/0.220.1/main.ts
patch: @@ -0,0 +1,2 @@
+console.log("foo");
+

filename: tests/registry/jsr/@deno/deploy/0.220.1_meta.json
patch: @@ -0,0 +1,5 @@
+{
+  "exports": {
+    ".": "./main.ts"
+  }
+}

filename: tests/registry/jsr/@deno/deploy/meta.json
patch: @@ -0,0 +1,8 @@
+{
+  "scope": "std",
+  "name": "assert",
+  "latest": "0.220.1",
+  "versions": {
+    "0.220.1": {}
+  }
+}

filename: tests/specs/deploy/help_success/__test__.jsonc
patch: @@ -0,0 +1,4 @@
+{
+  "args": "deploy --help",
+  "output": "[WILDCARD]"
+}
Repository: ollama/ollama
Pull request: AMD gfx patch rev is hex

Correctly handle gfx90a discovery

Fixes #3809 

Changed files:
filename: gpu/amd_linux.go
patch: @@ -140,7 +140,7 @@ func AMDGetGPUInfo() []GpuInfo {
 		}
 
 		if int(major) < RocmComputeMin {
-			slog.Warn(fmt.Sprintf("amdgpu too old gfx%d%d%d", major, minor, patch), "gpu", gpuID)
+			slog.Warn(fmt.Sprintf("amdgpu too old gfx%d%d%x", major, minor, patch), "gpu", gpuID)
 			continue
 		}
 
@@ -266,7 +266,7 @@ func AMDGetGPUInfo() []GpuInfo {
 				}
 				slog.Debug("rocm supported GPUs", "types", supported)
 			}
-			gfx := fmt.Sprintf("gfx%d%d%d", gpuInfo.Major, gpuInfo.Minor, gpuInfo.Patch)
+			gfx := fmt.Sprintf("gfx%d%d%x", gpuInfo.Major, gpuInfo.Minor, gpuInfo.Patch)
 			if !slices.Contains[[]string, string](supported, gfx) {
 				slog.Warn("amdgpu is not supported", "gpu", gpuInfo.ID, "gpu_type", gfx, "library", libDir, "supported_types", supported)
 				// TODO - consider discrete markdown just for ROCM troubleshooting?

filename: gpu/amd_windows.go
patch: @@ -149,13 +149,16 @@ func AMDGetGPUInfo() []GpuInfo {
 			}
 		}
 		if patch != "" {
-			gpuInfo.Patch, err = strconv.Atoi(patch)
+			// Patch rev is hex; e.g. gfx90a
+			p, err := strconv.ParseInt(patch, 16, 0)
 			if err != nil {
 				slog.Info("failed to parse version", "version", gfx, "error", err)
+			} else {
+				gpuInfo.Patch = int(p)
 			}
 		}
 		if gpuInfo.Major < RocmComputeMin {
-			slog.Warn(fmt.Sprintf("amdgpu [%s] too old gfx%d%d%d", gpuInfo.ID, gpuInfo.Major, gpuInfo.Minor, gpuInfo.Patch))
+			slog.Warn(fmt.Sprintf("amdgpu [%s] too old gfx%d%d%x", gpuInfo.ID, gpuInfo.Major, gpuInfo.Minor, gpuInfo.Patch))
 			continue
 		}