helloadhavan/github_issues huggingface dataset:
Repository: electron/electron
Pull request: ci: fixup mac runner hang

Backport of #47982

See that PR for details.


Notes: <!-- Please add a one-line description for app developers to read in the release notes, or 'none' if no notes relevant to app developers. Examples and help on special cases: https://github.com/electron/clerk/blob/main/README.md#examples -->none


Changed files:
filename: .github/actions/free-space-macos/action.yml
patch: @@ -6,6 +6,8 @@ runs:
     - name: Free Space on MacOS
       shell: bash
       run: |
+        echo "Disk usage before cleanup:"
+        df -h
         sudo mkdir -p $TMPDIR/del-target
 
         tmpify() {
@@ -62,4 +64,5 @@ runs:
 
         # lipo off some huge binaries arm64 versions to save space
         strip_universal_deep $(xcode-select -p)/../SharedFrameworks
-        # strip_arm_deep /System/Volumes/Data/Library/Developer/CommandLineTools/usr
\ No newline at end of file
+        # strip_arm_deep /System/Volumes/Data/Library/Developer/CommandLineTools/usr
+        sudo mdutil -a -i off

filename: .github/workflows/pipeline-segment-electron-test.yml
patch: @@ -104,6 +104,8 @@ jobs:
             "'kTCCServiceCamera','/usr/local/opt/runner/provisioner/provisioner',1,2,4,1,NULL,NULL,0,'UNUSED',NULL,0,1687786159"
             "'kTCCServiceBluetoothAlways','/usr/local/opt/runner/provisioner/provisioner',1,2,4,1,NULL,NULL,0,'UNUSED',NULL,0,1687786159"
             "'kTCCServiceAppleEvents','/usr/local/opt/runner/provisioner/provisioner',1,2,4,1,NULL,NULL,0,'UNUSED',NULL,0,1687786159"
+            "'kTCCServiceCamera','/opt/hca/hosted-compute-agent',1,2,4,1,NULL,NULL,0,'UNUSED',NULL,0,1687786159"
+            "'kTCCServiceBluetoothAlways','/opt/hca/hosted-compute-agent',1,2,4,1,NULL,NULL,0,'UNUSED',NULL,0,1687786159"
         )
         for values in "${userValuesArray[@]}"; do
           # Sonoma and higher have a few extra values

filename: spec/chromium-spec.ts
patch: @@ -3089,7 +3089,7 @@ describe('iframe using HTML fullscreen API while window is OS-fullscreened', ()
   });
 });
 
-ifdescribe(process.platform !== 'darwin' || process.arch !== 'arm64')('navigator.serial', () => {
+describe('navigator.serial', () => {
   let w: BrowserWindow;
   before(async () => {
     w = new BrowserWindow({
@@ -3113,6 +3113,7 @@ ifdescribe(process.platform !== 'darwin' || process.arch !== 'arm64')('navigator
   });
 
   it('does not return a port if select-serial-port event is not defined', async () => {
+    // Take screenshot to verify the test is running
     w.loadFile(path.join(fixturesPath, 'pages', 'blank.html'));
     const port = await getPorts();
     expect(port).to.equal(notFoundError);
@@ -3629,7 +3630,7 @@ ifdescribe((process.platform !== 'linux' || app.isUnityRunning()))('navigator.se
   });
 });
 
-ifdescribe(process.platform !== 'darwin' || process.arch !== 'arm64')('navigator.bluetooth', () => {
+describe('navigator.bluetooth', () => {
   let w: BrowserWindow;
   before(async () => {
     w = new BrowserWindow({
Repository: huggingface/transformers
Pull request: add back `logging_dir`

# What does this PR do?

This PR adds back `logging_dir` from @BenjaminBossan suggestion. It might be more used than I thought due to its generic name even though users might not be using tensorboard.

Changed files:
filename: src/transformers/training_args.py
patch: @@ -885,6 +885,12 @@ class TrainingArguments:
             )
         },
     )
+    logging_dir: Optional[str] = field(
+        default=None,
+        metadata={
+            "help": "Deprecated and will be removed in v5.2. Set env var `TENSORBOARD_LOGGING_DIR` instead. TensorBoard log directory."
+        },
+    )
     logging_strategy: Union[IntervalStrategy, str] = field(
         default="steps",
         metadata={"help": "The logging strategy to use."},
@@ -1695,6 +1701,11 @@ def __post_init__(self):
         if isinstance(self.include_num_input_tokens_seen, bool):
             self.include_num_input_tokens_seen = "all" if self.include_num_input_tokens_seen else "no"
 
+        if self.logging_dir is not None:
+            logger.warning(
+                "`logging_dir` is deprecated and will be removed in v5.2. Please set `TENSORBOARD_LOGGING_DIR` instead."
+            )
+
     def __str__(self):
         self_as_dict = asdict(self)
Repository: electron/electron
Pull request: ci: fixup mac runner hang

Backport of #47982

See that PR for details.


Notes: <!-- Please add a one-line description for app developers to read in the release notes, or 'none' if no notes relevant to app developers. Examples and help on special cases: https://github.com/electron/clerk/blob/main/README.md#examples -->none

Changed files:
filename: .github/actions/free-space-macos/action.yml
patch: @@ -6,6 +6,8 @@ runs:
     - name: Free Space on MacOS
       shell: bash
       run: |
+        echo "Disk usage before cleanup:"
+        df -h
         sudo mkdir -p $TMPDIR/del-target
 
         tmpify() {
@@ -62,4 +64,5 @@ runs:
 
         # lipo off some huge binaries arm64 versions to save space
         strip_universal_deep $(xcode-select -p)/../SharedFrameworks
-        # strip_arm_deep /System/Volumes/Data/Library/Developer/CommandLineTools/usr
\ No newline at end of file
+        # strip_arm_deep /System/Volumes/Data/Library/Developer/CommandLineTools/usr
+        sudo mdutil -a -i off

filename: .github/workflows/pipeline-segment-electron-test.yml
patch: @@ -103,6 +103,9 @@ jobs:
             "'kTCCServiceMicrophone','/usr/local/opt/runner/provisioner/provisioner',1,2,4,1,NULL,NULL,0,'UNUSED',NULL,0,1687786159"
             "'kTCCServiceCamera','/usr/local/opt/runner/provisioner/provisioner',1,2,4,1,NULL,NULL,0,'UNUSED',NULL,0,1687786159"
             "'kTCCServiceBluetoothAlways','/usr/local/opt/runner/provisioner/provisioner',1,2,4,1,NULL,NULL,0,'UNUSED',NULL,0,1687786159"
+            "'kTCCServiceAppleEvents','/usr/local/opt/runner/provisioner/provisioner',1,2,4,1,NULL,NULL,0,'UNUSED',NULL,0,1687786159"
+            "'kTCCServiceCamera','/opt/hca/hosted-compute-agent',1,2,4,1,NULL,NULL,0,'UNUSED',NULL,0,1687786159"
+            "'kTCCServiceBluetoothAlways','/opt/hca/hosted-compute-agent',1,2,4,1,NULL,NULL,0,'UNUSED',NULL,0,1687786159"
         )
         for values in "${userValuesArray[@]}"; do
           # Sonoma and higher have a few extra values

filename: spec/chromium-spec.ts
patch: @@ -3089,7 +3089,7 @@ describe('iframe using HTML fullscreen API while window is OS-fullscreened', ()
   });
 });
 
-ifdescribe(process.platform !== 'darwin' || process.arch !== 'arm64')('navigator.serial', () => {
+describe('navigator.serial', () => {
   let w: BrowserWindow;
   before(async () => {
     w = new BrowserWindow({
@@ -3621,7 +3621,7 @@ ifdescribe((process.platform !== 'linux' || app.isUnityRunning()))('navigator.se
   });
 });
 
-ifdescribe(process.platform !== 'darwin' || process.arch !== 'arm64')('navigator.bluetooth', () => {
+describe('navigator.bluetooth', () => {
   let w: BrowserWindow;
   before(async () => {
     w = new BrowserWindow({
Repository: facebook/react
Pull request: [ci:compiler] Only add latest tag to non-experimental



It turns out npm sets the latest tag by default so simply removing it didn't change the previous behavior.

The `latest` tag is typically used for stable release versions, and other tags for unstable versions such as prereleases. Since the compiler is still in prerelease, let's set the latest tag only for non-experimental releases to help signal which version is the safest to try out.
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/31288).
* #31289
* __->__ #31288

Changed files:
filename: compiler/scripts/release/publish.js
patch: @@ -163,6 +163,21 @@ async function main() {
       if (otp != null) {
         opts.push(`--otp=${otp}`);
       }
+      /**
+       * Typically, the `latest` tag is reserved for stable package versions. Since the the compiler
+       * is still pre-release, until we have a stable release let's only add the
+       * `latest` tag to non-experimental releases.
+       *
+       * `latest` is added by default, so we only override it for experimental releases so that
+       * those don't get the `latest` tag.
+       *
+       * TODO: Update this when we have a stable release.
+       */
+      if (argv.tag === 'experimental') {
+        opts.push('--tag=experimental');
+      } else {
+        opts.push('--tag=latest');
+      }
       try {
         await spawnHelper(
           'npm',
Repository: vercel/next.js
Pull request: [test] Fix test-dev with --projects

Initial version switched commands but that doesn't work

Broke in https://github.com/vercel/next.js/issues/84394

Need to update defaults


Changed files:
filename: jest.config.js
patch: @@ -5,7 +5,7 @@ const createJestConfig = nextJest()
 // Any custom config you want to pass to Jest
 /** @type {import('jest').Config} */
 const customJestConfig = {
-  displayName: process.env.TURBOPACK ? 'turbopack' : 'default',
+  displayName: process.env.IS_WEBPACK_TEST ? 'webpack' : 'Turbopack',
   testMatch: ['**/*.test.js', '**/*.test.ts', '**/*.test.jsx', '**/*.test.tsx'],
   setupFilesAfterEnv: ['<rootDir>/jest-setup-after-env.ts'],
   verbose: true,

filename: test/jest-setup-files.turbopack.js
patch: @@ -1 +1,2 @@
 process.env.IS_TURBOPACK_TEST = '1'
+delete process.env.IS_WEBPACK_TEST
Repository: denoland/deno
Pull request: fix(ext/node): fire fs.watch events for immediate writes (#32935)

## Summary
- Fix `fs.watch` missing change events when a file is written immediately after
  watcher setup
- The Node.js compat `fs.watch()` wrapped the `Deno.watchFs()` call in a 5ms
  `setTimeout`, creating a window where filesystem events were silently lost
- Removed the `setTimeout` and start the watcher synchronously, matching Node.js
  behavior
- Added a spec test for this scenario

Fixes #32935

## Test plan
- [x] New spec test: `tests/specs/node/fs_watch_immediate_write/`
- [x] Manual verification: immediate write after `fs.watch()` now fires change event
- [x] Delayed writes still work (no regression)


Changed files:
filename: ext/node/polyfills/fs.ts
patch: @@ -3034,31 +3034,24 @@ function watch(
   // deno-lint-ignore prefer-primordials
   const watchPath = getValidatedPath(filename).toString();
 
-  let iterator: Deno.FsWatcher;
-  // Start the actual watcher a few msec later to avoid race condition
-  // error in test case in compat test case
-  // (parallel/test-fs-watch.js, parallel/test-fs-watchfile.js)
-  const timer = setTimeout(() => {
-    iterator = Deno.watchFs(watchPath, {
-      recursive: options?.recursive || false,
-    });
+  const iterator: Deno.FsWatcher = Deno.watchFs(watchPath, {
+    recursive: options?.recursive || false,
+  });
 
-    asyncIterableToCallback<Deno.FsEvent>(iterator, (val, done) => {
-      if (done) return;
-      fsWatcher.emit(
-        "change",
-        convertDenoFsEventToNodeFsEvent(val.kind),
-        basename(val.paths[0]),
-      );
-    }, (e) => {
-      fsWatcher.emit("error", e);
-    });
-  }, 5);
+  asyncIterableToCallback<Deno.FsEvent>(iterator, (val, done) => {
+    if (done) return;
+    fsWatcher.emit(
+      "change",
+      convertDenoFsEventToNodeFsEvent(val.kind),
+      basename(val.paths[0]),
+    );
+  }, (e) => {
+    fsWatcher.emit("error", e);
+  });
 
   const fsWatcher = new FSWatcher(() => {
-    clearTimeout(timer);
     try {
-      iterator?.close();
+      iterator.close();
     } catch (e) {
       if (
         ObjectPrototypeIsPrototypeOf(Deno.errors.BadResource.prototype, e)

filename: tests/node_compat/config.jsonc
patch: @@ -1044,6 +1044,8 @@
     "parallel/test-fs-util-validateoffsetlength.js": {},
     "parallel/test-fs-utimes-y2K38.js": {},
     "parallel/test-fs-utimes.js": {},
+    "parallel/test-fs-watch.js": {},
+    "parallel/test-fs-watchfile.js": {},
     "parallel/test-fs-whatwg-url.js": {},
     "parallel/test-fs-write-buffer-large.js": {},
     "parallel/test-fs-write-buffer.js": {},
Repository: ggml-org/llama.cpp
Pull request: scripts : add pr2wt.sh

Helper script for quickly creating a git worktree from a PR.

Sample usage:

```bash
# create worktree in ../llama.cpp-pr-12345
./scripts/pr2wt.sh 12345

# create worktree and start opencode in it
./scripts/pr2wt.sh 12345 opencode

# chain multiple commands:
./scripts/pr2wt.sh 12345 "cmake -B build && cmake --build build"
```

Changed files:
filename: .gitignore
patch: @@ -130,6 +130,7 @@ poetry.toml
 # Local scripts
 /run-vim.sh
 /run-chat.sh
+/run-spec.sh
 /.ccache/
 
 # IDE

filename: scripts/pr2wt.sh
patch: @@ -0,0 +1,65 @@
+#!/usr/bin/env bash
+
+# intialize a new worktree from a PR number:
+#
+# - creates a new remote using the fork's clone URL
+# - creates a local branch tracking the remote branch
+# - creates a new worktree in a parent folder, suffixed with "-pr-${PR}"
+#
+# sample usage:
+#   ./scripts/pr2wt.sh 12345
+#   ./scripts/pr2wt.sh 12345 opencode
+
+function usage() {
+    echo "usage: $0 <pr_number> [cmd]"
+    exit 1
+}
+
+# check we are in the right directory
+if [[ ! -f "scripts/pr2wt.sh" ]]; then
+    echo "error: this script must be run from the root of the repository"
+    exit 1
+fi
+
+if [[ $# -lt 1 || $# -gt 2 ]]; then
+    usage
+fi
+
+PR=$1
+[[ "$PR" =~ ^[0-9]+$ ]] || { echo "error: PR number must be numeric"; exit 1; }
+
+url_origin=$(git config --get remote.origin.url) || {
+    echo "error: no remote named 'origin' in this repository"
+    exit 1
+}
+
+org_repo=$(echo $url_origin | cut -d/ -f4-)
+
+echo "org/repo: $org_repo"
+
+meta=$(curl -sSf -H "Accept: application/vnd.github+json" "https://api.github.com/repos/${org_repo}/pulls/${PR}")
+
+url_remote=$(echo "$meta" | jq -r '.head.repo.clone_url')
+head_ref=$(echo "$meta" | jq -r '.head.ref')
+
+echo "url:      $url_remote"
+echo "head_ref: $head_ref"
+
+git remote rm  pr/${PR}
+git remote add pr/${PR} $url_remote
+git fetch      pr/${PR} $head_ref
+
+dir=$(basename $(pwd))
+
+git branch -D pr/$PR 2> /dev/null
+git worktree add -b pr/$PR ../$dir-pr-$PR pr/$PR/${head_ref} 2> /dev/null
+
+wt_path=$(cd ../$dir-pr-$PR && pwd)
+
+echo "git worktree created in $wt_path"
+
+# if a command was provided, execute it
+if [[ $# -eq 2 ]]; then
+    cd ../$dir-pr-$PR
+    exec $2
+fi
Repository: huggingface/transformers
Pull request: Fix continuous batching tests

The continuous batching tests call `apply_chat_template` and broke due to the changed default args in https://github.com/huggingface/transformers/pull/41626. This was a real problem because those tests spin up threads via the `Manager` class, which I think persisted as zombie threads as a result (there was a lot of memory usage and very slow cleanup after these failures).

This PR fixes the tests and hopefully also the rest of our generation CI!

Changed files:
filename: tests/generation/test_continuous_batching.py
patch: @@ -350,9 +350,9 @@ def test_streaming_request(self) -> None:
 
         messages = [{"content": "What is the Transformers library known for?", "role": "user"}]
 
-        inputs = tokenizer.apply_chat_template(messages, return_tensors="pt", add_generation_prompt=True).to(
-            model.device
-        )[0]
+        inputs = tokenizer.apply_chat_template(
+            messages, return_tensors="pt", add_generation_prompt=True, return_dict=False
+        ).to(model.device)[0]
 
         request_id = manager.add_request(inputs, max_new_tokens=max_new_tokens, streaming=True)
 
@@ -382,9 +382,9 @@ def test_non_streaming_request(self) -> None:
 
         messages = [{"content": "What is the Transformers library known for?", "role": "user"}]
 
-        inputs = tokenizer.apply_chat_template(messages, return_tensors="pt", add_generation_prompt=True).to(
-            model.device
-        )[0]
+        inputs = tokenizer.apply_chat_template(
+            messages, return_tensors="pt", add_generation_prompt=True, return_dict=False
+        ).to(model.device)[0]
 
         request_id = manager.add_request(inputs, max_new_tokens=max_new_tokens, streaming=False)
 
@@ -409,9 +409,9 @@ def test_streaming_and_non_streaming_requests_can_alternate(self) -> None:
 
         messages = [{"content": "What is the Transformers library known for?", "role": "user"}]
 
-        inputs = tokenizer.apply_chat_template(messages, return_tensors="pt", add_generation_prompt=True).to(
-            model.device
-        )[0]
+        inputs = tokenizer.apply_chat_template(
+            messages, return_tensors="pt", add_generation_prompt=True, return_dict=False
+        ).to(model.device)[0]
 
         # Non-streaming request
         request_id = manager.add_request(inputs, max_new_tokens=max_new_tokens, streaming=False)
Repository: facebook/react
Pull request: [ci] Don't auto push to latest tag


By default let's stop pushing to the latest tag now that we have a non-experimental release.


Changed files:
filename: compiler/scripts/release/publish.js
patch: @@ -166,14 +166,7 @@ async function main() {
       try {
         await spawnHelper(
           'npm',
-          [
-            'publish',
-            ...opts,
-            '--registry=https://registry.npmjs.org',
-            // For now, since the compiler is experimental only, to simplify installation we push
-            // to the `latest` tag
-            '--tag=latest',
-          ],
+          ['publish', ...opts, '--registry=https://registry.npmjs.org'],
           {
             cwd: pkgDir,
             stdio: 'inherit',
Repository: denoland/deno
Pull request: ci: fix start_release workflow

Little mistake

Changed files:
filename: tools/release/00_start_release.ts
patch: @@ -3,7 +3,7 @@
 
 // deno-lint-ignore-file no-console
 
-import { $, createOctoKit, increment, semver } from "./deps.ts";
+import { $, createOctoKit, semver } from "./deps.ts";
 
 const currentDirPath = $.path(import.meta.dirname!);
 
@@ -48,7 +48,7 @@ function getNextVersion(originalVersion: semver.SemVer) {
     } else if (v.prerelease[0] != tag) {
       v = { ...v, prerelease: undefined };
     }
-    return increment(v, "prerelease", { prerelease: tag });
+    return semver.increment(v, "prerelease", { prerelease: tag });
   } else if (Deno.args.some((a) => a === "--patch")) {
     return semver.increment(originalVersion, "patch");
   } else if (Deno.args.some((a) => a === "--minor")) {
Repository: facebook/react
Pull request: [ci] Allow passing various params to compiler publish script


Allow passing in a few more inputs when manually publishing.


Changed files:
filename: .github/workflows/compiler_prereleases.yml
patch: @@ -13,6 +13,9 @@ on:
       dist_tag:
         required: true
         type: string
+      version_name:
+        required: true
+        type: string
     secrets:
       NPM_TOKEN:
         required: true
@@ -49,4 +52,4 @@ jobs:
       - name: Publish packages to npm
         run: |
           cp ./scripts/release/ci-npmrc ~/.npmrc
-          scripts/release/publish.js --frfr --ci --versionName=0.0.0 --tag ${{ inputs.dist_tag }}
+          scripts/release/publish.js --frfr --ci --versionName=${{ inputs.version_name }} --tag ${{ inputs.dist_tag }}

filename: .github/workflows/compiler_prereleases_manual.yml
patch: @@ -5,6 +5,15 @@ on:
     inputs:
       prerelease_commit_sha:
         required: false
+      release_channel:
+        required: true
+        type: string
+      dist_tag:
+        required: true
+        type: string
+      version_name:
+        required: true
+        type: string
 
 env:
   TZ: /usr/share/zoneinfo/America/Los_Angeles
@@ -15,7 +24,8 @@ jobs:
     uses: facebook/react/.github/workflows/compiler_prereleases.yml@main
     with:
       commit_sha: ${{ inputs.prerelease_commit_sha || github.sha }}
-      release_channel: experimental
-      dist_tag: experimental
+      release_channel: ${{ inputs.release_channel }}
+      dist_tag: ${{ inputs.dist_tag }}
+      version_name: ${{ inputs.version_name }}
     secrets:
       NPM_TOKEN: ${{ secrets.NPM_TOKEN }}

filename: .github/workflows/compiler_prereleases_nightly.yml
patch: @@ -16,5 +16,6 @@ jobs:
       commit_sha: ${{ github.sha }}
       release_channel: experimental
       dist_tag: experimental
+      version_name: '0.0.0'
     secrets:
       NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
Repository: electron/electron
Pull request: feat: add ffmpeg.dll to delay load configuration

#### Description of Change

Added ffmpeg.dll to the /DELAYLOAD linker configuration in BUILD.gn to reduce startup overhead and avoid unnecessary loading when ffmpeg-related functionality is not used.

E.g., the browser process was unnecessarily loading it:
![image](https://github.com/user-attachments/assets/4ed8d69e-dfa7-4e45-9b52-c71555964de2)

<!--
Thank you for your Pull Request. Please provide a description above and review
the requirements below.

Contributors guide: https://github.com/electron/electron/blob/main/CONTRIBUTING.md
-->

#### Checklist
<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

- [ ] PR description included and stakeholders cc'd
- [ ] `npm test` passes
- [ ] tests are [changed or added](https://github.com/electron/electron/blob/main/docs/development/testing.md)
- [ ] relevant API documentation, tutorials, and examples are updated and follow the [documentation style guide](https://github.com/electron/electron/blob/main/docs/development/style-guide.md)
- [x] [PR release notes](https://github.com/electron/clerk/blob/main/README.md) describe the change in a way relevant to app developers, and are [capitalized, punctuated, and past tense](https://github.com/electron/clerk/blob/main/README.md#examples).

#### Release Notes

Notes: Added `ffmpeg.dll` to delay load configuration.


Changed files:
filename: BUILD.gn
patch: @@ -1246,7 +1246,7 @@ if (is_mac) {
         "//components/crash/core/app:run_as_crashpad_handler",
       ]
 
-      ldflags = []
+      ldflags = [ "/DELAYLOAD:ffmpeg.dll" ]
 
       libs = [
         "comctl32.lib",
Repository: ggml-org/llama.cpp
Pull request: ci : run cann build unconditionally

The builds aren't particularly heavy, just run them to avoid issues like this https://github.com/ggml-org/llama.cpp/pull/18624#issuecomment-3717107203

Changed files:
filename: .github/workflows/build.yml
patch: @@ -1418,7 +1418,6 @@ jobs:
           echo "FIXME: test on devices"
 
   openEuler-latest-cmake-cann:
-    if: ${{ github.event_name != 'pull_request' || contains(github.event.pull_request.labels.*.name, 'Ascend NPU') }}
     defaults:
       run:
         shell: bash -el {0}