helloadhavan/github_issues huggingface dataset:
Repository: denoland/deno
Pull request: fix(ext/node): enable node compat test for v8.getHeapStatistics

Enables `parallel/test-v8-stats.js` in `tests/node_compat/config.jsonc`

Ref https://github.com/denoland/deno/issues/32706

Changed files:
filename: ext/node/ops/v8.rs
patch: @@ -37,6 +37,7 @@ pub fn op_v8_get_heap_statistics(
   buffer[11] = stats.total_global_handles_size() as f64;
   buffer[12] = stats.used_global_handles_size() as f64;
   buffer[13] = stats.external_memory() as f64;
+  buffer[14] = stats.total_allocated_bytes() as f64;
 }
 
 #[op2(fast)]

filename: ext/node/polyfills/v8.ts
patch: @@ -87,7 +87,7 @@ export function getHeapSpaceStatistics() {
   return heapSpaceStatistics;
 }
 
-const buffer = new Float64Array(14);
+const buffer = new Float64Array(15);
 
 export function getHeapStatistics() {
   op_v8_get_heap_statistics(buffer);
@@ -107,6 +107,7 @@ export function getHeapStatistics() {
     total_global_handles_size: buffer[11],
     used_global_handles_size: buffer[12],
     external_memory: buffer[13],
+    total_allocated_bytes: buffer[14],
   };
 }
 

filename: tests/node_compat/config.jsonc
patch: @@ -2231,7 +2231,7 @@
     "parallel/test-v8-flag-pool-size-0.js": {},
     "parallel/test-v8-getheapsnapshot-twice.js": {},
     "parallel/test-v8-global-setter.js": {},
-    // "parallel/test-v8-stats.js": {}, // https://github.com/denoland/deno/issues/32706
+    "parallel/test-v8-stats.js": {},
     "parallel/test-vm-access-process-env.js": {},
     "parallel/test-vm-api-handles-getter-errors.js": {},
     "parallel/test-vm-attributes-property-not-on-sandbox.js": {},

filename: tests/unit_node/v8_test.ts
patch: @@ -25,6 +25,7 @@ Deno.test({
       "number_of_detached_contexts",
       "number_of_native_contexts",
       "peak_malloced_memory",
+      "total_allocated_bytes",
       "total_available_size",
       "total_global_handles_size",
       "total_heap_size",
Repository: ggml-org/llama.cpp
Pull request: model-conversion : use CONVERTED_MODEL for compare-embeddings

This commit updates the causal model verification script to use the CONVERTED_MODEL environment variable instead of using the MODEL_PATH (the original model path) as the basis for the converted model file name.

The motivation for this that currently if the converted model file name differs from the original model directory/name the verification script will look for the wrong .bin file that was generating when running the converted model.

This similar to the change made for the embeddings models script in Commit db81d5ec4b0a9cb19e98c4533731c9554eb025db ("model-conversion : use CONVERTED_EMBEDDING_MODEL for embedding_verify_logits (#18079)"), but we also verify the embeddings of for causal models.


Changed files:
filename: examples/model-conversion/scripts/causal/compare-embeddings-logits.sh
patch: @@ -5,8 +5,11 @@ set -e
 MODEL_PATH="${1:-"$MODEL_PATH"}"
 MODEL_NAME="${2:-$(basename "$MODEL_PATH")}"
 
+CONVERTED_MODEL_PATH="${1:-"$CONVERTED_MODEL"}"
+CONVERTED_MODEL_NAME="${2:-$(basename "$CONVERTED_MODEL_PATH" ".gguf")}"
+
 if [ -t 0 ]; then
-    CPP_EMBEDDINGS="data/llamacpp-${MODEL_NAME}-embeddings.bin"
+    CPP_EMBEDDINGS="data/llamacpp-${CONVERTED_MODEL_NAME}-embeddings.bin"
 else
     # Process piped JSON data and convert to binary (matching logits.cpp format)
     TEMP_FILE=$(mktemp /tmp/tmp.XXXXXX.binn)
Repository: electron/electron
Pull request: build: fix ffmpeg generation on Windows non-x64

#### Description of Change

Closes https://github.com/electron/electron/issues/47766
Refs https://github.com/electron/electron/pull/45466

Fixes an issue where ffmpeg builds didn't get built correctly on Windows arm64 or ia32

```
src on git:7a73d3ec5a6e8 ❯ file ~/Downloads/x64ffmpeg.dll                    10:25AM
/Users/codebytere/Downloads/ffmpeg.dll: PE32+ executable (DLL) (console) x86-64, for MS Windows

src on git:7a73d3ec5a6e8 ❯ file ~/Downloads/arm64ffmpeg.dll                    10:25AM
/Users/codebytere/Downloads/ffmpeg.dll: PE32+ executable (DLL) (console) x86-64, for MS Windows

src on git:7a73d3ec5a6e8 ❯ file ~/Downloads/ia32ffmpeg.dll                    10:25AM
/Users/codebytere/Downloads/ffmpeg.dll: PE32+ executable (DLL) (console) x86-64, for MS Windows
```

It seems we didn't properly set `GN_EXTRA_ARGS` for those platforms - i went back and checked our old appveyor configs and it's there:

<img width="688" height="525" alt="Screenshot 2025-07-16 at 10 40 00 AM" src="https://github.com/user-attachments/assets/e4b8f16f-1aac-460b-a711-9d4c323b656c" />

so we need to add that back here.

#### Checklist
<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

- [x] PR description included and stakeholders cc'd
- [x] `npm test` passes
- [x] [PR release notes](https://github.com/electron/clerk/blob/main/README.md) describe the change in a way relevant to app developers, and are [capitalized, punctuated, and past tense](https://github.com/electron/clerk/blob/main/README.md#examples).

#### Release Notes

Notes: none.


Changed files:
filename: .github/actions/build-electron/action.yml
patch: @@ -38,6 +38,12 @@ runs:
       run: |
         GN_APPENDED_ARGS="$GN_EXTRA_ARGS target_cpu=\"x64\" v8_snapshot_toolchain=\"//build/toolchain/mac:clang_x64\""
         echo "GN_EXTRA_ARGS=$GN_APPENDED_ARGS" >> $GITHUB_ENV
+    - name: Set GN_EXTRA_ARGS for Windows
+      shell: bash
+      if: ${{inputs.target-arch != 'x64' && inputs.target-platform == 'win' }}
+      run: |
+        GN_APPENDED_ARGS="$GN_EXTRA_ARGS target_cpu=\"${{ inputs.target-arch }}\""
+        echo "GN_EXTRA_ARGS=$GN_APPENDED_ARGS" >> $GITHUB_ENV
     - name: Add Clang problem matcher
       shell: bash
       run: echo "::add-matcher::src/electron/.github/problem-matchers/clang.json"
@@ -184,8 +190,8 @@ runs:
           electron/script/zip-symbols.py -b $BUILD_PATH
         fi
     - name: Generate FFMpeg ${{ inputs.step-suffix }}
-      shell: bash
       if: ${{ inputs.is-release == 'true' }}
+      shell: bash
       run: |
         cd src
         gn gen out/ffmpeg --args="import(\"//electron/build/args/ffmpeg.gn\") use_remoteexec=true $GN_EXTRA_ARGS"
Repository: ollama/ollama
Pull request: update the FAQ to be more clear about windows env variables


Changed files:
filename: docs/faq.md
patch: @@ -80,17 +80,19 @@ If Ollama is run as a systemd service, environment variables should be set using
 
 ### Setting environment variables on Windows
 
-On windows, Ollama inherits your user and system environment variables.
+On Windows, Ollama inherits your user and system environment variables.
 
-1. First Quit Ollama by clicking on it in the task bar
+1. First Quit Ollama by clicking on it in the task bar.
 
-2. Edit system environment variables from the control panel
+2. Start the Settings (Windows 11) or Control Panel (Windows 10) application and search for _environment variables_.
 
-3. Edit or create New variable(s) for your user account for `OLLAMA_HOST`, `OLLAMA_MODELS`, etc.
+3. Click on _Edit environment variables for your account_.
 
-4. Click OK/Apply to save
+4. Edit or create a new variable for your user account for `OLLAMA_HOST`, `OLLAMA_MODELS`, etc.
 
-5. Run `ollama` from a new terminal window
+5. Click OK/Apply to save.
+
+6. Start the Ollama application from the Windows Start menu.
 
 
 ## How can I expose Ollama on my network?
@@ -237,4 +239,4 @@ If you wish to override the `OLLAMA_KEEP_ALIVE` setting, use the `keep_alive` AP
 
 If too many requests are sent to the server, it will respond with a 503 error
 indicating the server is overloaded.  You can adjust how many requests may be
-queue by setting `OLLAMA_MAX_QUEUE`
\ No newline at end of file
+queue by setting `OLLAMA_MAX_QUEUE`
Repository: ggml-org/llama.cpp
Pull request: webui: fix prompt progress ETA calculation

The ETA can be calculated independently (stateless) for each of the progress report based the math formula follow:

(Note: t = time and P = number of tokens)

$$ \frac{t_{eta}}{t_{elapsed}} = \frac{P_{eta}}{P_{done}} $$

Equivalent to:

$$ t_{eta} = \frac{P_{eta} * t_{elapsed}}{P_{done}} $$

Given:

$$ P_{eta} = P_{total} - P_{done} $$

Therefore:

$$ t_{eta} = \frac{(P_{total} - P_{done} ) * t_{elapsed}}{P_{done}} $$

$$ t_{eta} = ( \frac{P_{total}}{P_{done}} - 1 ) * t_{elapsed} $$



https://github.com/user-attachments/assets/4d2e5ecf-e121-48f3-89f3-0fd1166588c1





Changed files:
filename: tools/server/webui/src/lib/hooks/use-processing-state.svelte.ts
patch: @@ -6,6 +6,7 @@ export interface LiveProcessingStats {
 	totalTokens: number;
 	timeMs: number;
 	tokensPerSecond: number;
+	etaSecs?: number;
 }
 
 export interface LiveGenerationStats {
@@ -82,6 +83,15 @@ export function useProcessingState(): UseProcessingStateReturn {
 		}
 	});
 
+	function getETASecs(done: number, total: number, elapsedMs: number): number | undefined {
+		const elapsedSecs = elapsedMs / 1000;
+		const progressETASecs =
+			done === 0 || elapsedSecs < 0.5
+				? undefined // can be the case for the 0% progress report
+				: elapsedSecs * (total / done - 1);
+		return progressETASecs;
+	}
+
 	function startMonitoring(): void {
 		if (isMonitoring) return;
 		isMonitoring = true;
@@ -178,6 +188,12 @@ export function useProcessingState(): UseProcessingStateReturn {
 		const actualProcessed = processed - cache;
 		const actualTotal = total - cache;
 		const percent = Math.round((actualProcessed / actualTotal) * 100);
+		const eta = getETASecs(actualProcessed, actualTotal, processingState.promptProgress.time_ms);
+
+		if (eta !== undefined) {
+			const etaSecs = Math.ceil(eta);
+			return `Processing ${percent}% (ETA: ${etaSecs}s)`;
+		}
 
 		return `Processing ${percent}%`;
 	}

filename: tools/server/webui/src/lib/stores/chat.svelte.ts
patch: @@ -303,11 +303,17 @@ class ChatStore {
 		const currentConfig = config();
 		const outputTokensMax = currentConfig.max_tokens || -1;
 
+		// Note: for timings data, the n_prompt does NOT include cache tokens
 		const contextUsed = promptTokens + cacheTokens + predictedTokens;
 		const outputTokensUsed = predictedTokens;
 
+		// Note: for prompt progress, the "processed" DOES include cache tokens
+		// we need to exclude them to get the real prompt tokens processed count
+		const progressCache = promptProgress?.cache || 0;
+		const progressActualDone = (promptProgress?.processed ?? 0) - progressCache;
+		const progressActualTotal = (promptProgress?.total ?? 0) - progressCache;
 		const progressPercent = promptProgress
-			? Math.round((promptProgress.processed / promptProgress.total) * 100)
+			? Math.round((progressActualDone / progressActualTotal) * 100)
 			: undefined;
 
 		return {
Repository: ollama/ollama
Pull request: removed inconsistent punctuation

Removed the period in `ollama serve -h`

Resolves https://github.com/ollama/ollama/issues/4410



Changed files:
filename: cmd/cmd.go
patch: @@ -1090,9 +1090,9 @@ func NewCLI() *cobra.Command {
 Environment Variables:
 
     OLLAMA_HOST         The host:port to bind to (default "127.0.0.1:11434")
-    OLLAMA_ORIGINS      A comma separated list of allowed origins.
-    OLLAMA_MODELS       The path to the models directory (default is "~/.ollama/models")
-    OLLAMA_KEEP_ALIVE   The duration that models stay loaded in memory (default is "5m")
+    OLLAMA_ORIGINS      A comma separated list of allowed origins
+    OLLAMA_MODELS       The path to the models directory (default "~/.ollama/models")
+    OLLAMA_KEEP_ALIVE   The duration that models stay loaded in memory (default "5m")
     OLLAMA_DEBUG        Set to 1 to enable additional debug logging
 `)
Repository: vercel/next.js
Pull request: [cache components]: prevent expired entries from being served

The `allowStale` value is currently erroneously also allowing expired values to be served, because it's happening in the `file-system-cache`, before expiration values are checked.

This removes the handling all together to prevent the possibility of serving data that has been expired (eg via`updateTag`). 

Changed files:
filename: packages/next/src/build/templates/app-page.ts
patch: @@ -828,10 +828,6 @@ export async function handler(
             kind: IncrementalCacheKind.APP_PAGE,
             isRoutePPREnabled: true,
             isFallback: false,
-            // CRITICAL: we need to allow stale here as we'll revalidate in the
-            // background if it's stale. We _want_ to possibly serve a stale
-            // response here as it'll be consistent with the static render.
-            allowStale: true,
           }
         )
 

filename: packages/next/src/server/lib/incremental-cache/file-system-cache.ts
patch: @@ -293,16 +293,6 @@ export default class FileSystemCache implements CacheHandler {
       }
     }
 
-    // If enabled, this will return the possibly stale data without validating
-    // that the tags have expired or not yet been revalidated.
-    if ('allowStale' in ctx && ctx.allowStale) {
-      if (FileSystemCache.debug) {
-        console.log('FileSystemCache: allow stale', ctx.allowStale)
-      }
-
-      return data ?? null
-    }
-
     if (
       data?.value?.kind === CachedRouteKind.APP_PAGE ||
       data?.value?.kind === CachedRouteKind.APP_ROUTE ||

filename: packages/next/src/server/response-cache/types.ts
patch: @@ -228,11 +228,6 @@ export interface GetIncrementalResponseCacheContext {
    * True if this is a fallback request.
    */
   isFallback: boolean
-
-  /**
-   * True if stale data is allowed to be returned.
-   */
-  allowStale?: boolean
 }
 
 export interface SetIncrementalFetchCacheContext {

filename: test/production/app-dir/resume-data-cache/app/revalidate/route.ts
patch: @@ -1,6 +1,6 @@
 import { revalidateTag } from 'next/cache'
 
 export function POST() {
-  revalidateTag('test', 'expireNow')
+  revalidateTag('test', 'seconds')
   return new Response(null, { status: 200 })
 }

filename: test/production/app-dir/resume-data-cache/next.config.js
patch: @@ -5,13 +5,6 @@ const nextConfig = {
   experimental: {
     cacheComponents: true,
     clientSegmentCache: true,
-    cacheLife: {
-      expireNow: {
-        stale: 0,
-        expire: 0,
-        revalidate: 0,
-      },
-    },
   },
 }
Repository: nodejs/node
Pull request: crypto: fix EVPKeyCtxPointer::publicCheck()

Commit 206ebeb44764d58c6a505657edab3a7a78a0b977 added an additional call to `EVP_PKEY_public_check` and an unconditional return from `publicCheck()`. This prevents the control flow from reaching the original call to either `EVP_PKEY_public_check` or `EVP_PKEY_public_check_quick`.

This change restores the previous behavior, which calls `EVP_PKEY_public_check_quick` instead, if possible.

Refs: https://github.com/nodejs/node/pull/56812

<!--
Before submitting a pull request, please read:

- the CONTRIBUTING guide at https://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md
- the commit message formatting guidelines at
  https://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#commit-message-guidelines

For code changes:
1. Include tests for any bug fixes or new features.
2. Update documentation if relevant.
3. Ensure that `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes.

If you believe this PR should be highlighted in the Node.js CHANGELOG
please add the `notable-change` label.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.
-->


Changed files:
filename: deps/ncrypto/ncrypto.cc
patch: @@ -3643,7 +3643,6 @@ EVPKeyPointer EVPKeyCtxPointer::paramgen() const {
 bool EVPKeyCtxPointer::publicCheck() const {
   if (!ctx_) return false;
 #ifndef OPENSSL_IS_BORINGSSL
-  return EVP_PKEY_public_check(ctx_.get()) == 1;
 #if OPENSSL_VERSION_MAJOR >= 3
   return EVP_PKEY_public_check_quick(ctx_.get()) == 1;
 #else
Repository: facebook/react
Pull request: Fix runtime_commit_artifacts workflow

Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom):
* __->__ #31028

I messed up the yml syntax and also realized that our script doesn't
currently handle renames or deletes, so I fixed that

Changed files:
filename: .github/workflows/runtime_commit_artifacts.yml
patch: @@ -377,10 +377,14 @@ jobs:
                 );
               } else {
                 files.forEach(line => {
-                  if (line.startsWith(' D ')) {
+                  let file = null;
+                  if (line.startsWith('D ')) {
                     return;
+                  } else if (line.startsWith('R ')) {
+                    file = line.slice(line.indexOf('->') + 3);
+                  } else {
+                    file = line.slice(3).trim();
                   }
-                  const file = line.slice(3).trim();
                   if (file) {
                     console.log('  Signing file:', file);
                     const originalContents = fs.readFileSync(file, 'utf8');
Repository: huggingface/transformers
Pull request: Add a safeguard around a flaky test in gemma2

The test `tests/models/gemma2/test_modeling_gemma2.py::Gemma2IntegrationTest::test_model_2b_pipeline_bf16_flex_attention` is flaky because of the `_compile` flag at https://github.com/huggingface/transformers/blob/fe11cbb808b4301399240e40c5cb6cca9bb00d4d/src/transformers/masking_utils.py#L675
The issue is solved when upgrading torch to nightly 2.10, so it makes little sense to change the code.
But when the test causes an error, it causes all subsequent tests to fail. So this PR adds the `@run_test_using_subprocess` decorator around the test so this does not happen anymore. And a TODO to remove this once the fix is in the stable version of torch.

Changed files:
filename: tests/models/gemma2/test_modeling_gemma2.py
patch: @@ -34,6 +34,7 @@
     require_torch_accelerator,
     require_torch_large_accelerator,
     require_torch_large_gpu,
+    run_test_using_subprocess,
     slow,
     torch_device,
 )
@@ -136,6 +137,9 @@ def test_model_9b_pipeline_bf16(self):
         self.assertEqual(output[0][0]["generated_text"], EXPECTED_TEXTS[0])
         self.assertEqual(output[1][0]["generated_text"], EXPECTED_TEXTS[1])
 
+    # TODO: run_test_using_subprocess was added because of an issue in torch 2.9, which is already fixed in nightly
+    # We can remove this once we upgrade to torch 2.10
+    @run_test_using_subprocess
     @require_read_token
     def test_model_2b_pipeline_bf16_flex_attention(self):
         # See https://github.com/huggingface/transformers/pull/31747 -- pipeline was broken for Gemma2 before this PR
Repository: facebook/react
Pull request: Allow forcing a build in artifacts workflow dispatch

Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom):
* __->__ #31027

Sometimes it is useful to bypass the revision check when we need to make
changes to the runtime_commit_artifacts script. The `force` input can be
passed via the GitHub UI for manual runs of the workflow.

![Screenshot 2024-09-23 at 3 31 35 PM](https://github.com/user-attachments/assets/238813de-7270-4c09-be80-569f90ac6b45)

Changed files:
filename: .github/workflows/runtime_commit_artifacts.yml
patch: @@ -12,7 +12,7 @@ on:
         required: false
         type: string
       force:
-        description: 'True to force a commit to the builds/... branches'
+        description: 'Force a commit to the builds/... branches'
         required: true
         default: false
         type: boolean
Repository: facebook/react
Pull request: Fix missing trailing / in commit artifacts workflow

Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom):
* __->__ #31026

The trailing / was being omitted, so instead of moving the cjs
directory itself, it would move only its contents instead. This broke
some internal path assumptions.

Additionally, updates the step to create the react-dom directory prior
to moving.

Changed files:
filename: .github/workflows/runtime_commit_artifacts.yml
patch: @@ -118,14 +118,14 @@ jobs:
         run: |
           BASE_FOLDER='compiled-rn/facebook-fbsource/xplat/js'
           mkdir -p ${BASE_FOLDER}/react-native-github/Libraries/Renderer/
-          mkdir -p ${BASE_FOLDER}/RKJSModules/vendor/react/{scheduler,react,react-is,react-test-renderer}/
+          mkdir -p ${BASE_FOLDER}/RKJSModules/vendor/react/{scheduler,react,react-dom,react-is,react-test-renderer}/
 
           # Move React Native renderer
           mv build/react-native/implementations/ $BASE_FOLDER/react-native-github/Libraries/Renderer/
           mv build/react-native/shims/ $BASE_FOLDER/react-native-github/Libraries/Renderer/
           mv build/facebook-react-native/scheduler/cjs/ $BASE_FOLDER/RKJSModules/vendor/react/scheduler/
           mv build/facebook-react-native/react/cjs/ $BASE_FOLDER/RKJSModules/vendor/react/react/
-          mv build/facebook-react-native/react-dom/cjs $BASE_FOLDER/RKJSModules/vendor/react/react-dom/
+          mv build/facebook-react-native/react-dom/cjs/ $BASE_FOLDER/RKJSModules/vendor/react/react-dom/
           mv build/facebook-react-native/react-is/cjs/ $BASE_FOLDER/RKJSModules/vendor/react/react-is/
           mv build/facebook-react-native/react-test-renderer/cjs/ $BASE_FOLDER/RKJSModules/vendor/react/react-test-renderer/