helloadhavan/github_issues huggingface dataset:
Repository: electron/electron
Pull request: ci: fix sending Slack message in CI audit workflow

#### Description of Change

<!--
Thank you for your Pull Request. Please provide a description above and review
the requirements below.

Contributors guide: https://github.com/electron/electron/blob/main/CONTRIBUTING.md
-->

Follow-up to #47404 which was a little too zealous in quieting the Slack messages and now they're not sending at all. The `always()` condition is needed for the rest of the conditional to be evaluated when the audit fails.

#### Checklist
<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

- [x] PR description included and stakeholders cc'd

#### Release Notes

Notes: none <!-- Please add a one-line description for app developers to read in the release notes, or 'none' if no notes relevant to app developers. Examples and help on special cases: https://github.com/electron/clerk/blob/main/README.md#examples -->


Changed files:
filename: .github/workflows/audit-branch-ci.yml
patch: @@ -136,7 +136,7 @@ jobs:
 
             await core.summary.write();
       - name: Send Slack message if errors
-        if: ${{ steps.audit-errors.outputs.errorsFound && github.ref == 'refs/heads/main' }}
+        if: ${{ always() && steps.audit-errors.outputs.errorsFound && github.ref == 'refs/heads/main' }}
         uses: slackapi/slack-github-action@b0fa283ad8fea605de13dc3f449259339835fc52 # v2.1.0
         with:
           payload: |
Repository: vercel/next.js
Pull request: [Breaking] Bump minimum TypeScript version to 5.1.0

This PR bumps the minimum TS version required for Next.js to `5.1.0`, which is the version that supports React Components that return a promise via `JSX.ElementType`.

https://devblogs.microsoft.com/typescript/announcing-typescript-5-1/#decoupled-type-checking-between-jsx-elements-and-jsx-tag-types

Changed files:
filename: docs/01-app/01-getting-started/01-installation.mdx
patch: @@ -284,7 +284,7 @@ export default function Page() {
 
 ## Set up TypeScript
 
-> Minimum TypeScript version: `v4.5.2`
+> Minimum TypeScript version: `v5.1.0`
 
 Next.js comes with built-in TypeScript support. To add TypeScript to your project, rename a file to `.ts` / `.tsx` and run `next dev`. Next.js will automatically install the necessary dependencies and add a `tsconfig.json` file with the recommended config options.
 

filename: packages/next/src/lib/typescript/writeConfigurationDefaults.ts
patch: @@ -51,13 +51,8 @@ function getDesiredCompilerOptions(
     allowJs: { suggested: true },
     skipLibCheck: { suggested: true },
     strict: { suggested: false },
-    ...(semver.lt(typescriptVersion, '5.0.0')
-      ? { forceConsistentCasingInFileNames: { suggested: true } }
-      : undefined),
     noEmit: { suggested: true },
-    ...(semver.gte(typescriptVersion, '4.4.2')
-      ? { incremental: { suggested: true } }
-      : undefined),
+    incremental: { suggested: true },
 
     // These values are required and cannot be changed by the user
     // Keep this in sync with the webpack config

filename: packages/next/src/lib/verify-typescript-setup.ts
patch: @@ -113,9 +113,9 @@ export async function verifyTypeScriptSetup({
 
     const typescriptVersion = typescriptPackageJson.version
 
-    if (semver.lt(typescriptVersion, '4.5.2')) {
+    if (semver.lt(typescriptVersion, '5.1.0')) {
       log.warn(
-        `Minimum recommended TypeScript version is v4.5.2, older versions can potentially be incompatible with Next.js. Detected: ${typescriptVersion}`
+        `Minimum recommended TypeScript version is v5.1.0, older versions can potentially be incompatible with Next.js. Detected: ${typescriptVersion}`
       )
     }
 

filename: test/e2e/typescript-version-warning/typescript-version-warning.test.ts
patch: @@ -22,7 +22,7 @@ describe('typescript-version-warning', () => {
   it('should print warning when old typescript version is used with next build', async () => {
     await next.start().catch(() => {})
     expect(next.cliOutput).toContain(
-      'Minimum recommended TypeScript version is v4.5.2, older versions can potentially be incompatible with Next.js. Detected: 4.0.6'
+      'Minimum recommended TypeScript version is v5.1.0, older versions can potentially be incompatible with Next.js. Detected: 4.0.6'
     )
   })
 })
Repository: huggingface/transformers
Pull request: Fix incorrect assignment in `update_device_map` for GPTQ quantizer

# What does this PR do?

## Before submitting
- [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
- [x] Did you read the [contributor guideline](https://github.com/huggingface/transformers/blob/main/CONTRIBUTING.md#create-a-pull-request),
      Pull Request section?
- [ ] Was this discussed/approved via a Github issue or the [forum](https://discuss.huggingface.co/)? Please add a link
      to it if that's the case.
- [ ] Did you make sure to update the documentation with your changes? Here are the
      [documentation guidelines](https://github.com/huggingface/transformers/tree/main/docs), and
      [here are tips on formatting docstrings](https://github.com/huggingface/transformers/tree/main/docs#writing-source-documentation).
- [ ] Did you write any new necessary tests?


## Who can review?
@SunMarc @MekkCyber

Changed files:
filename: src/transformers/quantizers/quantizer_gptq.py
patch: @@ -92,7 +92,7 @@ def update_device_map(self, device_map):
             device_map = {"": torch.device("cpu")}
         # Only with auto-gptq do not support CPU, we should move the model to cuda if available.
         if not is_gptqmodel_available() and device_map in ("cpu", {"": torch.device("cpu")}):
-            device_map == {"": 0}
+            device_map = {"": 0}
         return device_map
 
     def _process_model_before_weight_loading(self, model: "PreTrainedModel", **kwargs):
Repository: denoland/deno
Pull request: fix(cli): load multiple env files in the correct order

Closes #32350

Previously we reverse the env file orders because we're using `dotenvy` that as stated by their [docs](https://docs.rs/dotenvy/latest/dotenvy/fn.from_filename.html):
> Where multiple declarations for the same environment variable exist in your .env file, the first one is applied.

Changed files:
filename: cli/util/watch_env_tracker.rs
patch: @@ -241,7 +241,7 @@ pub fn load_env_variables_from_env_files(
     return;
   };
 
-  for env_file_name in env_file_names.iter().rev() {
+  for env_file_name in env_file_names.iter() {
     match deno_dotenv::from_path(env_file_name) {
       Ok(_) => (),
       Err(error) => {

filename: tests/specs/run/env_file/multiple_env_file.out
patch: @@ -1,4 +1,4 @@
-BAR
-ANOTHER_${FOO}
+OVERRIDEN_BY_ENV_TWO
+OVERRIDEN_BY_ENV_ONE
 First Line
 Second Line
Repository: facebook/react
Pull request: [ci] Make some workflows dispatchable

Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom):
* #30531
* #30530
* __->__ #30529

The previous checks for prerelease_commit_sha was incorrectly
implemented for devtools regression tests so I fixed it. I also made
some other workflows dispatchable so they can be manually run from
GitHub's UI as needed.

Test plan: https://github.com/facebook/react/actions/runs/10165564989

Changed files:
filename: .github/workflows/devtools_regression_tests.yml
patch: @@ -5,8 +5,9 @@ on:
     - cron: 0 0 * * *
   workflow_dispatch:
     inputs:
-      prerelease_commit_sha:
+      commit_sha:
         required: false
+        type: string
 
 env:
   TZ: /usr/share/zoneinfo/America/Los_Angeles
@@ -15,7 +16,6 @@ env:
 
 jobs:
   download_build:
-    if: inputs.prerelease_commit_sha == ''
     name: Download base build
     runs-on: ubuntu-latest
     steps:
@@ -37,7 +37,7 @@ jobs:
       - name: Download react-devtools artifacts for base revision
         run: |
           git fetch origin main
-          GH_TOKEN=${{ github.token }} scripts/release/download-experimental-build.js --commit=$(git rev-parse origin/main)
+          GH_TOKEN=${{ github.token }} scripts/release/download-experimental-build.js --commit=${{ inputs.commit_sha || '$(git rev-parse origin/main)' }}
       - name: Display structure of build
         run: ls -R build
       - name: Archive build

filename: .github/workflows/runtime_commit_artifacts.yml
patch: @@ -6,6 +6,11 @@ on:
     types: [completed]
     branches:
       - main
+  workflow_dispatch:
+    inputs:
+      commit_sha:
+        required: false
+        type: string
 
 env:
   TZ: /usr/share/zoneinfo/America/Los_Angeles
@@ -72,7 +77,7 @@ jobs:
         working-directory: scripts/release
       - name: Download artifacts for base revision
         run: |
-          GH_TOKEN=${{ github.token }} scripts/release/download-experimental-build.js --commit=${{ github.event.workflow_run.head_sha }}
+          GH_TOKEN=${{ github.token }} scripts/release/download-experimental-build.js --commit=${{ inputs.commit_sha || github.event.workflow_run.head_sha }}
       - name: Display structure of build
         run: ls -R build
       - name: Strip @license from eslint plugin and react-refresh

filename: .github/workflows/runtime_fuzz_tests.yml
patch: @@ -1,24 +1,19 @@
 name: (Runtime) Fuzz tests
+
 on:
   schedule:
-  - cron: 0 * * * *
+    - cron: 0 * * * *
   push:
     branches:
       - main
   workflow_dispatch:
-    inputs:
-      prerelease_commit_sha:
-        required: false
 
 env:
   TZ: /usr/share/zoneinfo/America/Los_Angeles
 
 jobs:
   test_fuzz:
-    if: inputs.prerelease_commit_sha == ''
     runs-on: ubuntu-latest
-    env:
-      TZ: "/usr/share/zoneinfo/America/Los_Angeles"
     steps:
     - uses: actions/checkout@v4.1.0
     - uses: actions/setup-node@v4

filename: .github/workflows/shared_stale.yml
patch: @@ -4,6 +4,7 @@ on:
   schedule:
     # Run hourly
     - cron: '0 * * * *'
+  workflow_dispatch:
 
 env:
   TZ: /usr/share/zoneinfo/America/Los_Angeles
Repository: nodejs/node
Pull request: doc: add personal pronouns option

Refs: https://github.com/nodejs/node/pull/11089#issuecomment-277060503

Changed files:
filename: README.md
patch: @@ -399,7 +399,7 @@ For information about the governance of the Node.js project, see
 * [oyyd](https://github.com/oyyd) -
   **Ouyang Yadong** <<oyydoibh@gmail.com>> (he/him)
 * [panva](https://github.com/panva) -
-  **Filip Skokan** <<panva.ip@gmail.com>>
+  **Filip Skokan** <<panva.ip@gmail.com>> (he/him)
 * [puzpuzpuz](https://github.com/puzpuzpuz) -
   **Andrey Pechkurov** <<apechkurov@gmail.com>> (he/him)
 * [Qard](https://github.com/Qard) -
Repository: huggingface/transformers
Pull request: Fix early CUDA initialisation

This import added in https://github.com/huggingface/transformers/pull/41370 was identified to be causing CUDA to initialise early.

It was identified in vLLM's Transformers nightly test https://buildkite.com/vllm/ci/builds/33777/steps/canvas?sid=0199bcd4-8cf7-442a-a94d-df2969d65bde

Changed files:
filename: src/transformers/generation/continuous_batching/continuous_api.py
patch: @@ -27,7 +27,6 @@
 
 from ...configuration_utils import PreTrainedConfig
 from ...generation.configuration_utils import GenerationConfig
-from ...integrations.hub_kernels import load_and_register_kernel
 from ...utils.logging import logging
 from ...utils.metrics import ContinuousBatchProcessorMetrics, attach_tracer, traced
 from .cache import PagedAttentionCache
@@ -609,6 +608,8 @@ def __init__(
         """
         self.model = model.eval()
         if "paged|" not in model.config._attn_implementation:
+            from ...integrations.hub_kernels import load_and_register_kernel
+
             attn_implementation = "paged|" + self.model.config._attn_implementation
             load_and_register_kernel(attn_implementation)
             model.set_attn_implementation(attn_implementation)
Repository: facebook/react
Pull request: [ci] Add polling to download-build-artifacts

Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom):
* __->__ #30515
* #30510
* #30509
* #30508
* #30507
* #30506

Several CI workflows depend on the runtime_build_and_test.yml workflow
to complete before it can successfully download the build artifact.
However it is possible to encounter a race condition where the build
hasn't completed when the new workflow is started.

This PR adds a simple polling mechanism that waits up to 6 minutes for
the build for that revision to complete.

Changed files:
filename: scripts/rollup/build.js
patch: @@ -813,7 +813,7 @@ function handleRollupError(error) {
   }
 }
 
-async function buildEverything(index, total) {
+async function buildEverything() {
   if (!argv['unsafe-partial']) {
     await asyncRimRaf('build');
   }
@@ -850,7 +850,7 @@ async function buildEverything(index, total) {
     return !shouldSkipBundle(bundle, bundleType);
   });
 
-  if (process.env.CI_TOTAL != null && process.env.CI_INDEX != null) {
+  if (process.env.CI_TOTAL && process.env.CI_INDEX) {
     const nodeTotal = parseInt(process.env.CI_TOTAL, 10);
     const nodeIndex = parseInt(process.env.CI_INDEX, 10);
     bundles = bundles.filter((_, i) => i % nodeTotal === nodeIndex);
Repository: denoland/deno
Pull request: fix: Update libffi and libffi-sys to fix build

Bumps libffi and libffi-sys to latest versions.

Fixes: #32281

Changed files:
filename: Cargo.lock
patch: @@ -6254,19 +6254,19 @@ dependencies = [
 
 [[package]]
 name = "libffi"
-version = "4.1.2"
+version = "5.1.0"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "b0feebbe0ccd382a2790f78d380540500d7b78ed7a3498b68fcfbc1593749a94"
+checksum = "0498fe5655f857803e156523e644dcdcdc3b3c7edda42ea2afdae2e09b2db87b"
 dependencies = [
  "libc",
  "libffi-sys",
 ]
 
 [[package]]
 name = "libffi-sys"
-version = "3.3.3"
+version = "4.1.0"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "90c6c6e17136d4bc439d43a2f3c6ccf0731cccc016d897473a29791d3c2160c3"
+checksum = "71d4f1d4ce15091955144350b75db16a96d4a63728500122706fb4d29a26afbb"
 dependencies = [
  "cc",
 ]

filename: Cargo.toml
patch: @@ -418,8 +418,8 @@ x509-parser = "0.15.0"
 cranelift = "0.116"
 cranelift-native = "0.116"
 dlopen2 = "0.6.1"
-libffi = "=4.1.2"
-libffi-sys = "=3.3.3"
+libffi = "=5.1.0"
+libffi-sys = "=4.1.0"
 memmap2 = "0.9"
 
 # napi

filename: ext/ffi/ir.rs
patch: @@ -97,7 +97,7 @@ pub union NativeValue {
 }
 
 impl NativeValue {
-  pub unsafe fn as_arg(&self, native_type: &NativeType) -> Arg {
+  pub unsafe fn as_arg(&self, native_type: &NativeType) -> Arg<'_> {
     #[allow(clippy::undocumented_unsafe_blocks)]
     unsafe {
       match native_type {
Repository: facebook/react
Pull request: [ci] Deprecate yarn publish-prereleases

Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom):
* #30515
* __->__ #30510
* #30509
* #30508
* #30507
* #30506

Added instructions on the new workflow. Let's keep this short around for
now as it may be used again due to muscle memory and emit a helpful
message instead.

Changed files:
filename: scripts/rollup/build.js
patch: @@ -813,7 +813,7 @@ function handleRollupError(error) {
   }
 }
 
-async function buildEverything(index, total) {
+async function buildEverything() {
   if (!argv['unsafe-partial']) {
     await asyncRimRaf('build');
   }
@@ -850,7 +850,7 @@ async function buildEverything(index, total) {
     return !shouldSkipBundle(bundle, bundleType);
   });
 
-  if (process.env.CI_TOTAL != null && process.env.CI_INDEX != null) {
+  if (process.env.CI_TOTAL && process.env.CI_INDEX) {
     const nodeTotal = parseInt(process.env.CI_TOTAL, 10);
     const nodeIndex = parseInt(process.env.CI_INDEX, 10);
     bundles = bundles.filter((_, i) => i % nodeTotal === nodeIndex);
Repository: ollama/ollama
Pull request: Add test case for context exhaustion

Confirmed this fails on 0.1.30 with known regression but passes on main

Changed files:
filename: integration/context_test.go
patch: @@ -0,0 +1,29 @@
+//go:build integration
+
+package integration
+
+import (
+	"context"
+	"net/http"
+	"testing"
+	"time"
+
+	"github.com/ollama/ollama/api"
+)
+
+func TestContextExhaustion(t *testing.T) {
+	ctx, cancel := context.WithTimeout(context.Background(), 2*time.Minute) // TODO maybe shorter?
+	defer cancel()
+	// Set up the test data
+	req := api.GenerateRequest{
+		Model:  "llama2",
+		Prompt: "Write me a story with a ton of emojis?",
+		Stream: &stream,
+		Options: map[string]interface{}{
+			"temperature": 0,
+			"seed":        123,
+			"num_ctx":     128,
+		},
+	}
+	GenerateTestHelper(ctx, t, &http.Client{}, req, []string{"once", "upon", "lived"})
+}
Repository: facebook/react
Pull request: [ci] Cleanup more references to circleci

Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom):
* #30515
* #30510
* __->__ #30509
* #30508
* #30507
* #30506



Changed files:
filename: scripts/rollup/build.js
patch: @@ -813,7 +813,7 @@ function handleRollupError(error) {
   }
 }
 
-async function buildEverything(index, total) {
+async function buildEverything() {
   if (!argv['unsafe-partial']) {
     await asyncRimRaf('build');
   }
@@ -850,7 +850,7 @@ async function buildEverything(index, total) {
     return !shouldSkipBundle(bundle, bundleType);
   });
 
-  if (process.env.CI_TOTAL != null && process.env.CI_INDEX != null) {
+  if (process.env.CI_TOTAL && process.env.CI_INDEX) {
     const nodeTotal = parseInt(process.env.CI_TOTAL, 10);
     const nodeIndex = parseInt(process.env.CI_INDEX, 10);
     bundles = bundles.filter((_, i) => i % nodeTotal === nodeIndex);
Repository: ollama/ollama
Pull request: fix dll compress in windows building

The compiled DLL on the Windows platform has not been properly compressed.

Changed files:
filename: llm/generate/gen_windows.ps1
patch: @@ -146,7 +146,7 @@ function compress {
     }
 
     write-host "Compressing dlls..."
-    $binaries = dir "${script:buildDir}/bin/*.dll"
+    $dlls = dir "${script:buildDir}/bin/*.dll"
     foreach ($file in $dlls) {
         & "$script:GZIP" --best -f $file
     }
Repository: facebook/react
Pull request: [ci] Cleanup --ci flag

Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom):
* #30515
* #30510
* #30509
* __->__ #30508
* #30507
* #30506

This can be restored back to being a boolean instead of an enum

Changed files:
filename: scripts/rollup/build.js
patch: @@ -813,7 +813,7 @@ function handleRollupError(error) {
   }
 }
 
-async function buildEverything(index, total) {
+async function buildEverything() {
   if (!argv['unsafe-partial']) {
     await asyncRimRaf('build');
   }
@@ -850,7 +850,7 @@ async function buildEverything(index, total) {
     return !shouldSkipBundle(bundle, bundleType);
   });
 
-  if (process.env.CI_TOTAL != null && process.env.CI_INDEX != null) {
+  if (process.env.CI_TOTAL && process.env.CI_INDEX) {
     const nodeTotal = parseInt(process.env.CI_TOTAL, 10);
     const nodeIndex = parseInt(process.env.CI_INDEX, 10);
     bundles = bundles.filter((_, i) => i % nodeTotal === nodeIndex);
Repository: electron/electron
Pull request: build: add siso backend.star

Pairs with https://github.com/electron/build-tools/pull/731

Notes: none

Changed files:
filename: build/siso/backend.star
patch: @@ -0,0 +1,21 @@
+# -*- bazel-starlark -*-
+
+load("@builtin//struct.star", "module")
+
+def __platform_properties(ctx):
+    container_image = "docker://gcr.io/chops-public-images-prod/rbe/siso-chromium/linux@sha256:ef35d347f4a4a2d32b76fd908e66e96f59bf8ba7379fd5626548244c45343b2b"
+    return {
+        "default": {
+            "OSFamily": "Linux",
+            "container-image": container_image,
+        },
+        "large": {
+            "OSFamily": "Linux",
+            "container-image": container_image,
+        },
+    }
+
+backend = module(
+    "backend",
+    platform_properties = __platform_properties,
+)
Repository: facebook/react
Pull request: [ci] Rename scripts/circleci to scripts/ci

Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom):
* #30515
* #30510
* #30509
* #30508
* __->__ #30507
* #30506



Changed files:
filename: scripts/rollup/build.js
patch: @@ -813,7 +813,7 @@ function handleRollupError(error) {
   }
 }
 
-async function buildEverything(index, total) {
+async function buildEverything() {
   if (!argv['unsafe-partial']) {
     await asyncRimRaf('build');
   }
@@ -850,7 +850,7 @@ async function buildEverything(index, total) {
     return !shouldSkipBundle(bundle, bundleType);
   });
 
-  if (process.env.CI_TOTAL != null && process.env.CI_INDEX != null) {
+  if (process.env.CI_TOTAL && process.env.CI_INDEX) {
     const nodeTotal = parseInt(process.env.CI_TOTAL, 10);
     const nodeIndex = parseInt(process.env.CI_INDEX, 10);
     bundles = bundles.filter((_, i) => i % nodeTotal === nodeIndex);
Repository: nodejs/node
Pull request: test: enable api-invalid-label.any.js in encoding WPTs

Enables `api-invalid-label.any.js` WPTs to run.

Changed files:
filename: test/wpt/status/encoding.json
patch: @@ -2,9 +2,6 @@
   "api-basics.any.js": {
     "requires": ["small-icu"]
   },
-  "api-invalid-label.any.js": {
-    "skip": "location is not defined"
-  },
   "textdecoder-fatal-streaming.any.js": {
     "requires": ["small-icu"]
   },
@@ -91,7 +88,7 @@
     "requires": ["small-icu"]
   },
   "single-byte-decoder.window.js": {
-    "skip": "location is not defined"
+    "skip": "document is not defined"
   },
   "textdecoder-eof.any.js": {
     "requires": ["small-icu"]

filename: test/wpt/test-encoding.js
patch: @@ -4,6 +4,7 @@ const { WPTRunner } = require('../common/wpt');
 const runner = new WPTRunner('encoding');
 
 runner.setInitScript(`
+  globalThis.location ||= {};
   const { MessageChannel } = require('worker_threads');
   global.MessageChannel = MessageChannel;
 `);
Repository: facebook/react
Pull request: [ci] Cleanup forked build files

Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom):
* #30515
* #30510
* #30509
* #30508
* #30507
* __->__ #30506

Unforks these scripts now that we are fully migrated to GH.

Changed files:
filename: scripts/rollup/build.js
patch: @@ -813,7 +813,7 @@ function handleRollupError(error) {
   }
 }
 
-async function buildEverything(index, total) {
+async function buildEverything() {
   if (!argv['unsafe-partial']) {
     await asyncRimRaf('build');
   }
@@ -850,7 +850,7 @@ async function buildEverything(index, total) {
     return !shouldSkipBundle(bundle, bundleType);
   });
 
-  if (process.env.CI_TOTAL != null && process.env.CI_INDEX != null) {
+  if (process.env.CI_TOTAL && process.env.CI_INDEX) {
     const nodeTotal = parseInt(process.env.CI_TOTAL, 10);
     const nodeIndex = parseInt(process.env.CI_INDEX, 10);
     bundles = bundles.filter((_, i) => i % nodeTotal === nodeIndex);
Repository: ollama/ollama
Pull request: Fail fast if mingw missing on windows


Changed files:
filename: llm/generate/gen_windows.ps1
patch: @@ -183,9 +183,17 @@ if ($null -eq ${env:OLLAMA_SKIP_CPU_GENERATE}) {
 
 # GCC build for direct linking into the Go binary
 init_vars
+# cmake will silently fallback to msvc compilers if mingw isn't in the path, so detect and fail fast
+# as we need this to be compiled by gcc for golang to be able to link with itx
+write-host "Checking for MinGW..."
+# error action ensures we exit on failure
+get-command gcc
+get-command mingw32-make
 $script:cmakeTargets = @("llama", "ggml")
 $script:cmakeDefs = @(
     "-G", "MinGW Makefiles"
+    "-DCMAKE_C_COMPILER=gcc.exe",
+    "-DCMAKE_CXX_COMPILER=g++.exe",
     "-DBUILD_SHARED_LIBS=off",
     "-DLLAMA_NATIVE=off",
     "-DLLAMA_AVX=off",
Repository: ollama/ollama
Pull request: CI missing archive


Changed files:
filename: .github/workflows/release.yaml
patch: @@ -99,7 +99,9 @@ jobs:
       - uses: actions/upload-artifact@v4
         with:
           name: generate-windows-cpu
-          path: llm/build/**/bin/*
+          path: |
+            llm/build/**/bin/*
+            llm/build/**/*.a
 
   # ROCm generation step
   generate-windows-rocm: