Repository: nodejs/node
Pull request: src: clean up generic counter implementation

This addresses late review comments for the recently landed cfbfc1b05080 and aligns the new code with the pre-existing V8 fast call counters.

Refs: https://github.com/nodejs/node/pull/60434#pullrequestreview-3386035944

<!--
Before submitting a pull request, please read:

- the CONTRIBUTING guide at https://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md
- the commit message formatting guidelines at
  https://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#commit-message-guidelines

For code changes:
1. Include tests for any bug fixes or new features.
2. Update documentation if relevant.
3. Ensure that `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes.

If you believe this PR should be highlighted in the Node.js CHANGELOG
please add the `notable-change` label.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.
-->


Changed files:
filename: src/node_debug.cc
patch: @@ -24,17 +24,16 @@ using v8::Number;
 using v8::Object;
 using v8::Value;
 
-thread_local std::unordered_map<std::string, int> generic_usage_counters;
+thread_local std::unordered_map<FastStringKey, int, FastStringKey::Hash>
+    generic_usage_counters;
 thread_local std::unordered_map<FastStringKey, int, FastStringKey::Hash>
     v8_fast_api_call_counts;
 
-void CountGenericUsage(const char* counter_name) {
-  if (generic_usage_counters.find(counter_name) == generic_usage_counters.end())
-    generic_usage_counters[counter_name] = 0;
+void CountGenericUsage(FastStringKey counter_name) {
   generic_usage_counters[counter_name]++;
 }
 
-int GetGenericUsageCount(const char* counter_name) {
+int GetGenericUsageCount(FastStringKey counter_name) {
   return generic_usage_counters[counter_name];
 }
 
@@ -53,8 +52,8 @@ void GetGenericUsageCount(const FunctionCallbackInfo<Value>& args) {
     return;
   }
   Utf8Value utf8_key(env->isolate(), args[0]);
-  args.GetReturnValue().Set(
-      GetGenericUsageCount(utf8_key.ToStringView().data()));
+  args.GetReturnValue().Set(GetGenericUsageCount(
+      FastStringKey::AllowDynamic(utf8_key.ToStringView())));
 }
 
 void GetV8FastApiCallCount(const FunctionCallbackInfo<Value>& args) {

filename: src/node_debug.h
patch: @@ -13,8 +13,9 @@ namespace debug {
 void TrackV8FastApiCall(FastStringKey key);
 int GetV8FastApiCallCount(FastStringKey key);
 
-void CountGenericUsage(const char* counter_name);
-#define COUNT_GENERIC_USAGE(name) node::debug::CountGenericUsage(name)
+void CountGenericUsage(FastStringKey counter_name);
+#define COUNT_GENERIC_USAGE(name)                                              \
+  node::debug::CountGenericUsage(FastStringKey(name))
 
 #define TRACK_V8_FAST_API_CALL(key)                                            \
   node::debug::TrackV8FastApiCall(FastStringKey(key))