helloadhavan/github_issues huggingface dataset:
Repository: nodejs/node
Pull request: src: mark realm leaf classes final

Since these classes use virtual methods extensively, adding `final` should allow compilers to optimize accesses better.

<!--
Before submitting a pull request, please read:

- the CONTRIBUTING guide at https://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md
- the commit message formatting guidelines at
  https://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#commit-message-guidelines

For code changes:
1. Include tests for any bug fixes or new features.
2. Update documentation if relevant.
3. Ensure that `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes.

If you believe this PR should be highlighted in the Node.js CHANGELOG
please add the `notable-change` label.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.
-->


Changed files:
filename: src/node_realm.h
patch: @@ -209,7 +209,7 @@ class Realm : public MemoryRetainer {
   CppgcWrapperList cppgc_wrapper_list_;
 };
 
-class PrincipalRealm : public Realm {
+class PrincipalRealm final : public Realm {
  public:
   PrincipalRealm(Environment* env,
                  v8::Local<v8::Context> context,

filename: src/node_shadow_realm.h
patch: @@ -9,7 +9,7 @@
 namespace node {
 namespace shadow_realm {
 
-class ShadowRealm : public Realm {
+class ShadowRealm final : public Realm {
  public:
   static ShadowRealm* New(Environment* env);
Repository: ollama/ollama
Pull request: Always add token to cache_tokens

The diff is a bit hard to read, but this is the actual fix for our `01` patch that fixes due to the kv cache being full

I believe this fixes #2339 and #1458

Changed files:
filename: llm/patches/01-cache.diff
patch: @@ -1,30 +1,21 @@
 diff --git a/examples/server/server.cpp b/examples/server/server.cpp
-index d86d7e04..7d71c766 100644
+index d86d7e04..2694e92e 100644
 --- a/examples/server/server.cpp
 +++ b/examples/server/server.cpp
-@@ -1598,12 +1598,6 @@ struct llama_server_context
-                         LOG_TEE("slot %d : in cache: %i tokens | to process: %i tokens\n", slot.id, slot.n_past, slot.num_prompt_tokens_processed);
-                     }
- 
--                    LOG_TEE("slot %d : kv cache rm - [%d, end)\n", slot.id, (int) system_tokens.size() + slot.n_past);
--
--                    llama_kv_cache_seq_rm(ctx, slot.id, system_tokens.size() + slot.n_past, -1);
--
--                    slot.cache_tokens = prompt_tokens;
--
-                     if (slot.n_past == slot.num_prompt_tokens && slot.n_past > 0)
-                     {
-                         // we have to evaluate at least 1 token to generate logits.
-@@ -1615,6 +1609,12 @@ struct llama_server_context
-                         }
-                     }
- 
-+                    LOG_TEE("slot %d : kv cache rm - [%d, end)\n", slot.id, (int) system_tokens.size() + slot.n_past);
+@@ -901,13 +901,15 @@ struct llama_server_context
+                 slot.sent_count += result.text_to_send.size();
+                 // add the token to slot queue and cache
+             }
+-            slot.add_token_string(result);
 +
-+                    llama_kv_cache_seq_rm(ctx, slot.id, system_tokens.size() + slot.n_past, -1);
-+
-+                    slot.cache_tokens = prompt_tokens;
+             if (slot.params.stream)
+             {
+                 send_partial_response(slot, result);
+             }
+         }
+ 
++        slot.add_token_string(result);
 +
-                     LOG_VERBOSE("prompt ingested", {
-                                                     {"n_past",  slot.n_past},
-                                                     {"cached",  tokens_to_str(ctx, slot.cache_tokens.cbegin(), slot.cache_tokens.cbegin() + slot.n_past)},
+         if (incomplete)
+         {
+             slot.has_next_token = true;
Repository: denoland/deno
Pull request: feat(cli/tsc): show progress bar for TSGO downloads

Fixes #31884 

## Problem
When using `DENO_UNSTABLE_TSGO=1 deno check`, users receive no feedback during the TypeScript Go compiler download, making them think the process is stuck or frozen.

## Solution
Added two console messages in `cli/tsc/go/setup.rs`:
- "Downloading TypeScript Go compiler..." displayed before the download starts
- "TypeScript Go compiler downloaded successfully." displayed after successful completion

These messages provide clear feedback to users about the download progress without being overly verbose.

## Changes
- Modified `cli/tsc/go/setup.rs` to add `eprintln!` messages around the download process
- Messages are displayed to stderr to avoid interfering with command output
- No functional changes to the download logic itself

## Testing
The changes compile successfully and preserve existing functionality while improving user experience for the experimental TSGO feature.

Changed files:
filename: cli/tsc/go/setup.rs
patch: @@ -7,11 +7,14 @@ use std::sync::OnceLock;
 
 use deno_core::error::AnyError;
 use deno_error::JsErrorBox;
+use http::HeaderMap;
 use sha2::Digest;
 
 use super::tsgo_version;
 use crate::cache::DenoDir;
 use crate::http_util::HttpClientProvider;
+use crate::util::progress_bar::ProgressBar;
+use crate::util::progress_bar::ProgressBarStyle;
 
 fn get_download_url(platform: &str) -> String {
   format!(
@@ -134,17 +137,25 @@ pub async fn ensure_tsgo(
   let temp = tempfile::tempdir().map_err(DownloadError::CreateTempDirFailed)?;
   let path = temp.path().join("tsgo.zip");
   log::debug!("Downloading tsgo to {}", path.display());
-  let data = client
-    .download(
-      deno_core::url::Url::parse(&download_url)
-        .map_err(|e| DownloadError::InvalidDownloadUrl(download_url, e))?,
-    )
-    .await
-    .map_err(DownloadError::DownloadFailed)?;
 
-  verify_hash(platform, &data)?;
+  let data = {
+    let progress_bar = ProgressBar::new(ProgressBarStyle::DownloadBars);
+    let progress = progress_bar.update(download_url.as_str());
+    client
+      .download_with_progress_and_retries(
+        deno_core::url::Url::parse(&download_url)
+          .map_err(|e| DownloadError::InvalidDownloadUrl(download_url, e))?,
+        &HeaderMap::new(),
+        &progress,
+      )
+      .await
+      .map_err(DownloadError::DownloadFailed)?
+  };
+
+  let bytes = data.into_bytes().map_err(DownloadError::DownloadFailed)?;
+  verify_hash(platform, &bytes)?;
 
-  std::fs::write(&path, &data).map_err(|e| {
+  std::fs::write(&path, &bytes).map_err(|e| {
     DownloadError::WriteZipFailed(path.display().to_string(), e)
   })?;
 
@@ -157,7 +168,7 @@ pub async fn ensure_tsgo(
     crate::util::archive::unpack_into_dir(crate::util::archive::UnpackArgs {
       exe_name: "tsgo",
       archive_name: "tsgo.zip",
-      archive_data: &data,
+      archive_data: &bytes,
       is_windows: cfg!(windows),
       dest_path: temp.path(),
     })
Repository: ollama/ollama
Pull request: add faq for proxies


Changed files:
filename: docs/faq.md
patch: @@ -102,3 +102,34 @@ No. Anything you do with Ollama, such as generate a response from the model, sta
 ## How can I use Ollama in Visual Studio Code?
 
 There is already a large collection of plugins available for VSCode as well as other editors that leverage Ollama. You can see the list of [extensions & plugins](https://github.com/jmorganca/ollama#extensions--plugins) at the bottom of the main repository readme.
+
+## How do I use Ollama behind a proxy?
+
+Ollama is compatible with proxy servers if `HTTP_PROXY` or `HTTPS_PROXY` are configured. When using either variables, ensure it is set where `ollama serve` can access the values.
+
+When using `HTTPS_PROXY`, ensure the proxy certificate is installed as a system certificate.
+
+On macOS:
+
+```bash
+HTTPS_PROXY=http://proxy.example.com ollama serve
+```
+
+On Linux:
+
+```bash
+echo "Environment=HTTPS_PROXY=https://proxy.example.com" >>/etc/systemd/system/ollama.service.d/environment.conf
+```
+
+Reload `systemd` and restart Ollama:
+
+```bash
+systemctl daemon-reload
+systemctl restart ollama
+```
+
+### How do I use Ollama behind a proxy in Docker?
+
+Ollama Docker container can be configured to use a proxy by passing `-e HTTPS_PROXY=https://proxy.example.com` when starting the container. Ensure the certificate is installed as a system certificate when using HTTPS.
+
+Alternatively, Docker daemon can be configured to use a proxy. Instructions are available for Docker Desktop on [macOS](https://docs.docker.com/desktop/settings/mac/#proxies), [Windows](https://docs.docker.com/desktop/settings/windows/#proxies), and [Linux](https://docs.docker.com/desktop/settings/linux/#proxies), and Docker [daemon with systemd](https://docs.docker.com/config/daemon/systemd/#httphttps-proxy).
Repository: electron/electron
Pull request: fix: explicit microtask scope DCHECK condition

Backport of #47134

See that PR for details.


Notes: none


Changed files:
filename: shell/common/node_util.cc
patch: @@ -15,6 +15,7 @@
 #include "shell/browser/javascript_environment.h"
 #include "shell/common/gin_converters/callback_converter.h"
 #include "shell/common/node_includes.h"
+#include "shell/common/process_util.h"
 #include "third_party/electron_node/src/node_process-inl.h"
 
 namespace electron::util {
@@ -132,7 +133,17 @@ node::Environment* CreateEnvironment(v8::Isolate* isolate,
 
 ExplicitMicrotasksScope::ExplicitMicrotasksScope(v8::MicrotaskQueue* queue)
     : microtask_queue_(queue), original_policy_(queue->microtasks_policy()) {
-  DCHECK_EQ(microtask_queue_->GetMicrotasksScopeDepth(), 0);
+  // In browser-like processes, some nested run loops (macOS usually) may
+  // re-enter. This is safe because we expect the policy was explicit in the
+  // first place for those processes. However, in renderer processes, there may
+  // be unexpected behavior if this code is triggered within a pending microtask
+  // scope.
+  if (electron::IsBrowserProcess() || electron::IsUtilityProcess()) {
+    DCHECK_EQ(original_policy_, v8::MicrotasksPolicy::kExplicit);
+  } else {
+    DCHECK_EQ(microtask_queue_->GetMicrotasksScopeDepth(), 0);
+  }
+
   microtask_queue_->set_microtasks_policy(v8::MicrotasksPolicy::kExplicit);
 }
Repository: nodejs/node
Pull request: doc: fix missing reference links for server.keepAliveTimeoutBuffer

This PR fixes missing or broken Markdown reference links in [http.md#serverkeepalivetimeout](https://github.com/nodejs/node/blob/main/doc/api/http.md#serverkeepalivetimeout)

There was an issue where some Markdown reference links were not rendered correctly in the generated documentation, as shown in the screenshot below:

<img width="762" height="406" alt="image" src="https://github.com/user-attachments/assets/0651f302-5859-475f-9269-d79d2783b4cc" />



Changed files:
filename: doc/api/http.md
patch: @@ -1945,7 +1945,7 @@ incoming data, after it has finished writing the last response, before a socket
 will be destroyed.
 
 This timeout value is combined with the
-\[`server.keepAliveTimeoutBuffer`]\[] option to determine the actual socket
+[`server.keepAliveTimeoutBuffer`][] option to determine the actual socket
 timeout, calculated as:
 socketTimeout = keepAliveTimeout + keepAliveTimeoutBuffer
 If the server receives new data before the keep-alive timeout has fired, it
@@ -4453,6 +4453,7 @@ const agent2 = new http.Agent({ proxyEnv: process.env });
 [`response.writeHead()`]: #responsewriteheadstatuscode-statusmessage-headers
 [`server.close()`]: #serverclosecallback
 [`server.headersTimeout`]: #serverheaderstimeout
+[`server.keepAliveTimeoutBuffer`]: #serverkeepalivetimeoutbuffer
 [`server.keepAliveTimeout`]: #serverkeepalivetimeout
 [`server.listen()`]: net.md#serverlisten
 [`server.requestTimeout`]: #serverrequesttimeout
Repository: facebook/react
Pull request: [ci] Add new flow GitHub action

Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom):
* #30030
* #30029
* #30028
* #30026
* __->__ #30025

Copies the existing circleci workflow for flow into GitHub actions. I
didn't remove the circleci job for now just to check for parity.

Changed files:
filename: .github/workflows/flow.yml
patch: @@ -0,0 +1,25 @@
+name: Flow
+
+on:
+  push:
+    branches: [main]
+  pull_request:
+
+jobs:
+  flow:
+    name: Run flow
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: actions/setup-node@v4
+        with:
+          node-version: 18.x
+          cache: "yarn"
+          cache-dependency-path: yarn.lock
+      - name: Restore cached node_modules
+        uses: actions/cache@v4
+        with:
+          path: "**/node_modules"
+          key: ${{ runner.arch }}-${{ runner.os }}-modules-${{ hashFiles('yarn.lock') }}
+      - run: yarn install --frozen-lockfile
+      - run: node ./scripts/tasks/flow-ci
Repository: vercel/next.js
Pull request: Turbopack: "connect" tasks in turbo_tasks::run too

### What?

Calling turbo tasks functions in `turbo_tasks::run` leads to a minimal connect, which schedules the task when it has not yet been computed.

Connecting OperationVc should lead to the same behavior. 

Closes PACK-5508

Changed files:
filename: turbopack/crates/turbo-tasks-backend/src/backend/mod.rs
patch: @@ -3044,10 +3044,10 @@ impl<B: BackingStorage> Backend for TurboTasksBackend<B> {
     fn connect_task(
         &self,
         task: TaskId,
-        parent_task: TaskId,
+        parent_task: Option<TaskId>,
         turbo_tasks: &dyn TurboTasksBackendApi<Self>,
     ) {
-        self.0.connect_task(task, Some(parent_task), turbo_tasks);
+        self.0.connect_task(task, parent_task, turbo_tasks);
     }
 
     fn create_transient_task(

filename: turbopack/crates/turbo-tasks/src/backend.rs
patch: @@ -652,7 +652,7 @@ pub trait Backend: Sync + Send {
     fn connect_task(
         &self,
         task: TaskId,
-        parent_task: TaskId,
+        parent_task: Option<TaskId>,
         turbo_tasks: &dyn TurboTasksBackendApi<Self>,
     );
 

filename: turbopack/crates/turbo-tasks/src/manager.rs
patch: @@ -1345,9 +1345,8 @@ impl<B: Backend + 'static> TurboTasksApi for TurboTasks<B> {
     }
 
     fn connect_task(&self, task: TaskId) {
-        if let Some(current_task) = current_task_if_available("connecting task") {
-            self.backend.connect_task(task, current_task, self);
-        }
+        self.backend
+            .connect_task(task, current_task_if_available("connecting task"), self);
     }
 
     fn mark_own_task_as_finished(&self, task: TaskId) {
Repository: facebook/react
Pull request: [ci] Remove circleci yarn_lint job

Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom):
* #30028
* #30026
* #30025
* __->__ #30024
* #30023
* #30022
* #30021

This was migrated to GitHub actions

Changed files:
filename: .github/workflows/lint.yml
patch: @@ -20,7 +20,7 @@ jobs:
         uses: actions/cache@v4
         with:
           path: "**/node_modules"
-          key: ${{ runner.arch }}-${{ runner.os }}-modules-${{ hashFiles('yarn.lock') }}
+          key: ${{ runner.arch }}-${{ runner.os }}-modules-${{ hashFiles('**/yarn.lock') }}
       - run: yarn install --frozen-lockfile
       - run: yarn prettier-check
Repository: denoland/deno
Pull request: fix(ext/web): export PerformanceObserver and PerformanceObserverEntryList

Follow up https://github.com/denoland/deno/pull/31875 that exposes Web APIs on the global scope.

Note to self: update MDN when doing a minor release.

Changed files:
filename: runtime/js/98_global_scope_shared.js
patch: @@ -83,6 +83,10 @@ const windowOrWorkerGlobalScope = {
   PerformanceEntry: core.propNonEnumerable(performance.PerformanceEntry),
   PerformanceMark: core.propNonEnumerable(performance.PerformanceMark),
   PerformanceMeasure: core.propNonEnumerable(performance.PerformanceMeasure),
+  PerformanceObserver: core.propNonEnumerable(performance.PerformanceObserver),
+  PerformanceObserverEntryList: core.propNonEnumerable(
+    performance.PerformanceObserverEntryList,
+  ),
   PromiseRejectionEvent: core.propNonEnumerable(event.PromiseRejectionEvent),
   ProgressEvent: core.propNonEnumerable(event.ProgressEvent),
   ReadableStream: core.propNonEnumerable(streams.ReadableStream),

filename: tests/wpt/runner/expectation.json
patch: @@ -5397,8 +5397,8 @@
   "user-timing": {
     "buffered-flag.any.html": false,
     "buffered-flag.any.worker.html": false,
-    "case-sensitivity.any.html": false,
-    "case-sensitivity.any.worker.html": false,
+    "case-sensitivity.any.html": true,
+    "case-sensitivity.any.worker.html": true,
     "clear_all_marks.any.html": true,
     "clear_all_marks.any.worker.html": true,
     "clear_all_measures.any.html": true,
@@ -5419,8 +5419,12 @@
     "mark-entry-constructor.any.worker.html": true,
     "mark-errors.any.html": true,
     "mark-errors.any.worker.html": true,
-    "mark-l3.any.html": false,
-    "mark-l3.any.worker.html": false,
+    "mark-l3.any.html": [
+      "mark entries' detail and startTime are customizable"
+    ],
+    "mark-l3.any.worker.html": [
+      "mark entries' detail and startTime are customizable"
+    ],
     "mark-measure-return-objects.any.html": true,
     "mark-measure-return-objects.any.worker.html": true,
     "mark.any.html": true,
@@ -5437,8 +5441,16 @@
     "measure_syntax_err.any.worker.html": true,
     "structured-serialize-detail.any.html": true,
     "structured-serialize-detail.any.worker.html": true,
-    "supported-usertiming-types.any.html": false,
-    "supported-usertiming-types.any.worker.html": false,
+    "supported-usertiming-types.any.html": [
+      "supportedEntryTypes contains 'mark' and 'measure'",
+      "'mark' entries should be observable",
+      "'measure' entries should be observable"
+    ],
+    "supported-usertiming-types.any.worker.html": [
+      "supportedEntryTypes contains 'mark' and 'measure'",
+      "'mark' entries should be observable",
+      "'measure' entries should be observable"
+    ],
     "user_timing_exists.any.html": true,
     "user_timing_exists.any.worker.html": true,
     "invoke_with_timing_attributes.worker.html": true,
Repository: facebook/react
Pull request: [ci] Add new lint GitHub action

Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom):
* #30028
* #30026
* #30025
* #30024
* __->__ #30023
* #30022
* #30021

Copies the existing circleci workflow for linting into GitHub actions. I
didn't remove the circleci for now just to check for parity.

Changed files:
filename: .github/workflows/lint.yml
patch: @@ -20,7 +20,7 @@ jobs:
         uses: actions/cache@v4
         with:
           path: "**/node_modules"
-          key: ${{ runner.arch }}-${{ runner.os }}-modules-${{ hashFiles('yarn.lock') }}
+          key: ${{ runner.arch }}-${{ runner.os }}-modules-${{ hashFiles('**/yarn.lock') }}
       - run: yarn install --frozen-lockfile
       - run: yarn prettier-check
Repository: electron/electron
Pull request: fix: explicit microtask scope DCHECK condition

#### Description of Change

Changes the DCHECK condition in `ExplicitMicrotasksScope` (added in #46973) to exclude the browser/utility processes from the scoped microtask check and replace it with a check for the assumption that they are always using the explicit microtask policy.

Fixes #47019

#### Checklist

- [x] PR description included and stakeholders cc'd
- [x] `npm test` passes

#### Release Notes

Notes: none


Changed files:
filename: shell/common/node_util.cc
patch: @@ -15,6 +15,7 @@
 #include "shell/browser/javascript_environment.h"
 #include "shell/common/gin_converters/callback_converter.h"
 #include "shell/common/node_includes.h"
+#include "shell/common/process_util.h"
 #include "third_party/electron_node/src/node_process-inl.h"
 
 namespace electron::util {
@@ -132,7 +133,17 @@ node::Environment* CreateEnvironment(v8::Isolate* isolate,
 
 ExplicitMicrotasksScope::ExplicitMicrotasksScope(v8::MicrotaskQueue* queue)
     : microtask_queue_(queue), original_policy_(queue->microtasks_policy()) {
-  DCHECK_EQ(microtask_queue_->GetMicrotasksScopeDepth(), 0);
+  // In browser-like processes, some nested run loops (macOS usually) may
+  // re-enter. This is safe because we expect the policy was explicit in the
+  // first place for those processes. However, in renderer processes, there may
+  // be unexpected behavior if this code is triggered within a pending microtask
+  // scope.
+  if (electron::IsBrowserProcess() || electron::IsUtilityProcess()) {
+    DCHECK_EQ(original_policy_, v8::MicrotasksPolicy::kExplicit);
+  } else {
+    DCHECK_EQ(microtask_queue_->GetMicrotasksScopeDepth(), 0);
+  }
+
   microtask_queue_->set_microtasks_policy(v8::MicrotasksPolicy::kExplicit);
 }
Repository: facebook/react
Pull request: [prettier] Run prettier

Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom):
* #30028
* #30026
* #30025
* #30024
* #30023
* __->__ #30022
* #30021



Changed files:
filename: scripts/prettier/index.js
patch: @@ -56,10 +56,9 @@ const files = glob
       '**/*.d.ts',
       '**/node_modules/**',
       '**/cjs/**',
-      'packages/**/*.ts',
-      'compiler/**/node_modules/**',
-      'compiler/**/dist/**',
-      'compiler/**/__snapshots__/**',
+      '**/dist/**',
+      '**/__snapshots__/**',
+      'packages/**/*.ts', // runtime prettier uses Flow parser
       ...ignoredPathsListedInPrettierIgnoreInGlobFormat,
     ],
   })