Repository: nodejs/node
Pull request: test: fix status when compiled without inspector

<!--
Before submitting a pull request, please read:

- the CONTRIBUTING guide at https://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md
- the commit message formatting guidelines at
  https://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#commit-message-guidelines

For code changes:
1. Include tests for any bug fixes or new features.
2. Update documentation if relevant.
3. Ensure that `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes.

If you believe this PR should be highlighted in the Node.js CHANGELOG
please add the `notable-change` label.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.
-->


Changed files:
filename: test/common/index.js
patch: @@ -54,6 +54,7 @@ const noop = () => {};
 const hasCrypto = Boolean(process.versions.openssl) &&
                   !process.env.NODE_SKIP_CRYPTO;
 
+const hasInspector = Boolean(process.features.inspector);
 const hasSQLite = Boolean(process.versions.sqlite);
 
 const hasQuic = hasCrypto && !!process.features.quic;
@@ -711,7 +712,7 @@ function expectsError(validator, exact) {
 }
 
 function skipIfInspectorDisabled() {
-  if (!process.features.inspector) {
+  if (!hasInspector) {
     skip('V8 inspector is disabled');
   }
 }
@@ -930,6 +931,7 @@ const common = {
   hasIntl,
   hasCrypto,
   hasQuic,
+  hasInspector,
   hasSQLite,
   invalidArgTypeHelper,
   isAlive,

filename: test/common/index.mjs
patch: @@ -17,6 +17,7 @@ const {
   getTTYfd,
   hasCrypto,
   hasQuic,
+  hasInspector,
   hasSQLite,
   hasIntl,
   hasIPv6,
@@ -68,6 +69,7 @@ export {
   getTTYfd,
   hasCrypto,
   hasQuic,
+  hasInspector,
   hasSQLite,
   hasIntl,
   hasIPv6,

filename: test/common/wpt.js
patch: @@ -412,6 +412,9 @@ class BuildRequirement {
     // Not using common.hasCrypto because of the global leak checks
     this.hasCrypto = Boolean(process.versions.openssl) &&
       !process.env.NODE_SKIP_CRYPTO;
+
+    // Not using common.hasInspector because of the global leak checks
+    this.hasInspector = Boolean(process.features.inspector);
   }
 
   /**
@@ -429,6 +432,9 @@ class BuildRequirement {
     if (requires.has('crypto') && !this.hasCrypto) {
       return 'crypto';
     }
+    if (requires.has('inspector') && !this.hasInspector) {
+      return 'inspector';
+    }
     return false;
   }
 }

filename: test/parallel/test-process-get-builtin.mjs
patch: @@ -1,4 +1,4 @@
-import { hasCrypto, hasIntl, hasSQLite } from '../common/index.mjs';
+import { hasCrypto, hasIntl, hasInspector, hasSQLite } from '../common/index.mjs';
 import assert from 'node:assert';
 import { builtinModules } from 'node:module';
 import { isMainThread } from 'node:worker_threads';
@@ -39,6 +39,10 @@ if (!hasIntl) {
 // TODO(@jasnell): Remove this once node:quic graduates from unflagged.
 publicBuiltins.delete('node:quic');
 
+if (!hasInspector) {
+  publicBuiltins.delete('inspector');
+  publicBuiltins.delete('inspector/promises');
+}
 if (!hasSQLite) {
   publicBuiltins.delete('node:sqlite');
 }

filename: test/wpt/status/console.json
patch: @@ -1,7 +1,7 @@
 {
   "idlharness.any.js": {
     "note": "https://github.com/nodejs/node/issues/44185",
-    "requires": ["crypto", "small-icu"]
+    "requires": ["crypto", "inspector", "small-icu"]
   },
   "idlharness-shadowrealm.window.js": {
     "skip": "ShadowRealm support is not enabled"