helloadhavan/github_issues huggingface dataset:
Repository: facebook/react
Pull request: eslint-plugin-react-hooks: Release 5.0.0

## Summary

Adds a changelog for the planned 5.0.0 release of `eslint-plugin-react-hooks`.

I used `git log --oneline $(git merge-base v18.3.1 HEAD)...HEAD -- packages/eslint-plugin-react-hooks/` as a base and removed commits that don't affect consumers.

Changed files:
filename: packages/eslint-plugin-react-hooks/CHANGELOG.md
patch: @@ -1,7 +1,21 @@
-## 5.0.0 (next release)
+## 5.0.0
 
 * **New Violations:** Component names now need to start with an uppercase letter instead of a non-lowercase letter. This means `_Button` or `_component` are no longer valid. ([@kassens](https://github.com/kassens)) in [#25162](https://github.com/facebook/react/pull/25162)
 
+- Consider dispatch from `useActionState` stable. ([@eps1lon](https://github.com/eps1lon) in [#29665](https://github.com/facebook/react/pull/29665))
+- Add support for ESLint v9. ([@eps1lon](https://github.com/eps1lon) in [#28773](https://github.com/facebook/react/pull/28773))
+- Accept `as` expression in callback. ([@StyleShit](https://github.com/StyleShit) in [#28202](https://github.com/facebook/react/pull/28202))
+- Accept `as` expressions in deps array. ([@StyleShit](https://github.com/StyleShit) in [#28189](https://github.com/facebook/react/pull/28189))
+- Treat `React.use()` the same as `use()`. ([@kassens](https://github.com/kassens) in [#27769](https://github.com/facebook/react/pull/27769))
+- Move `use()` lint to non-experimental. ([@kassens](https://github.com/kassens) in [#27768](https://github.com/facebook/react/pull/27768))
+- Support Flow `as` expressions. ([@cpojer](https://github.com/cpojer) in [#27590](https://github.com/facebook/react/pull/27590))
+- Allow `useEffect(fn, undefined)`. ([@kassens](https://github.com/kassens) in [#27525](https://github.com/facebook/react/pull/27525))
+- Disallow hooks in async functions. ([@acdlite](https://github.com/acdlite) in [#27045](https://github.com/facebook/react/pull/27045))
+- Rename experimental `useEvent` to `useEffectEvent`. ([@sebmarkbage](https://github.com/sebmarkbage) in [#25881](https://github.com/facebook/react/pull/25881))
+- Lint for presence of `useEvent` functions in dependency lists. ([@poteto](https://github.com/poteto) in [#25512](https://github.com/facebook/react/pull/25512))
+- Check `useEvent` references instead. ([@poteto](https://github.com/poteto) in [#25319](https://github.com/facebook/react/pull/25319))
+- Update `RulesOfHooks` with `useEvent` rules. ([@poteto](https://github.com/poteto) in [#25285](https://github.com/facebook/react/pull/25285))
+
 ## 4.6.0
 
 ## 4.5.0
Repository: vuejs/vue
Pull request: fix type definition links

NOTE:
Everytime, we tried not to change links.

Changed files:
filename: packages/vue-template-compiler/README.md
patch: @@ -38,7 +38,7 @@ The optional `options` object can contain the following:
 
 - `modules`
 
-  An array of compiler modules. For details on compiler modules, refer to its [type definition](https://github.com/vuejs/vue/blob/dev/flow/compiler.js#L35) and the [built-in modules](https://github.com/vuejs/vue/tree/dev/src/platforms/web/compiler/modules).
+  An array of compiler modules. For details on compiler modules, refer to the `ModuleOptions` type in [flow declarations](https://github.com/vuejs/vue/blob/dev/flow/compiler.js) and the [built-in modules](https://github.com/vuejs/vue/tree/dev/src/platforms/web/compiler/modules).
 
 - `directives`
 
@@ -80,7 +80,7 @@ This is only useful at runtime with pre-configured builds, so it doesn't accept
 
 ### compiler.parseComponent(file, [options])
 
-Parse a SFC (single-file component, or `*.vue` file) into a [descriptor](https://github.com/vuejs/vue/blob/dev/flow/compiler.js#L137). This is used in SFC build tools like `vue-loader` and `vueify`.
+Parse a SFC (single-file component, or `*.vue` file) into a descriptor (refer to the `SFCDescriptor` type in [flow declarations](https://github.com/vuejs/vue/blob/dev/flow/compiler.js)). This is used in SFC build tools like `vue-loader` and `vueify`.
 
 #### Options
Repository: ollama/ollama
Pull request: Align cmake define for cuda no peer copy

This feel out of sync on recent updates to llama.cpp.

Changed files:
filename: llm/generate/gen_linux.sh
patch: @@ -252,7 +252,7 @@ if [ -z "${OLLAMA_SKIP_ROCM_GENERATE}" -a -d "${ROCM_PATH}" ]; then
         ROCM_VARIANT=_v$(ls ${ROCM_PATH}/lib/librocblas.so.*.*.????? | cut -f5 -d. || true)
     fi
     init_vars
-    CMAKE_DEFS="${COMMON_CMAKE_DEFS} ${CMAKE_DEFS} -DGGML_HIPBLAS=on -DLLAMA_CUDA_NO_PEER_COPY=on -DCMAKE_C_COMPILER=$ROCM_PATH/llvm/bin/clang -DCMAKE_CXX_COMPILER=$ROCM_PATH/llvm/bin/clang++ -DAMDGPU_TARGETS=$(amdGPUs) -DGPU_TARGETS=$(amdGPUs)"
+    CMAKE_DEFS="${COMMON_CMAKE_DEFS} ${CMAKE_DEFS} -DGGML_HIPBLAS=on -DGGML_CUDA_NO_PEER_COPY=on -DCMAKE_C_COMPILER=$ROCM_PATH/llvm/bin/clang -DCMAKE_CXX_COMPILER=$ROCM_PATH/llvm/bin/clang++ -DAMDGPU_TARGETS=$(amdGPUs) -DGPU_TARGETS=$(amdGPUs)"
     # Users building from source can tune the exact flags we pass to cmake for configuring llama.cpp
     if [ -n "${OLLAMA_CUSTOM_ROCM_DEFS}" ]; then
         echo "OLLAMA_CUSTOM_ROCM_DEFS=\"${OLLAMA_CUSTOM_ROCM_DEFS}\""

filename: llm/generate/gen_windows.ps1
patch: @@ -355,7 +355,7 @@ function build_rocm() {
             "-DCMAKE_C_COMPILER=clang.exe",
             "-DCMAKE_CXX_COMPILER=clang++.exe",
             "-DGGML_HIPBLAS=on",
-            "-DLLAMA_CUDA_NO_PEER_COPY=on",
+            "-DGGML_CUDA_NO_PEER_COPY=on",
             "-DHIP_PLATFORM=amd",
             "-DGGML_AVX=on",
             "-DGGML_AVX2=off",
Repository: facebook/react
Pull request: [ci] Remove build_devtools_and_process_artifacts as a dependency to run_devtools_e2e_tests


I just noticed that we don't actually need to let the devtools build finish first because the e2e tests don't use those built files. We can decouple them to allow them to run in paralllel.


Changed files:
filename: .github/workflows/runtime_build_and_test.yml
patch: @@ -533,21 +533,27 @@ jobs:
           RELEASE_CHANNEL: experimental
       - name: Display structure of build
         run: ls -R build
-      - name: Archive devtools build
-        uses: actions/upload-artifact@v4
-        with:
-          name: react-devtools-${{ matrix.browser }}
-          path: build/devtools.tgz
       # Simplifies getting the extension for local testing
       - name: Archive ${{ matrix.browser }} extension
         uses: actions/upload-artifact@v4
         with:
           name: react-devtools-${{ matrix.browser }}-extension
           path: build/devtools/${{ matrix.browser }}-extension.zip
 
+  merge_devtools_artifacts:
+    name: Merge DevTools artifacts
+    needs: build_devtools_and_process_artifacts
+    runs-on: ubuntu-latest
+    steps:
+      - name: Merge artifacts
+        uses: actions/upload-artifact/merge@v4
+        with:
+          name: react-devtools
+          pattern: react-devtools-*-extension
+
   run_devtools_e2e_tests:
     name: Run DevTools e2e tests
-    needs: build_devtools_and_process_artifacts
+    needs: build_and_lint
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
Repository: facebook/react
Pull request: [Fiber] Read the class name from props.layout

Copypasta typo.

Changed files:
filename: packages/react-reconciler/src/ReactFiberCommitWork.js
patch: @@ -1212,7 +1212,7 @@ function measureUpdateViewTransition(
   );
   const layoutClassName: ?string = getViewTransitionClassName(
     props.className,
-    props.update,
+    props.layout,
   );
   let className: ?string;
   if (updateClassName === 'none') {
Repository: electron/electron
Pull request: fix: devtools crashing on Linux in detach mode

Backport of #48600

See that PR for details.


Notes: Fixed an issue where calling `webContents.openDevTools({ mode: 'detach' })` would cause a crash on Wayland.


Changed files:
filename: shell/browser/ui/views/electron_views_delegate.cc
patch: @@ -8,6 +8,7 @@
 
 #include "ui/views/widget/desktop_aura/desktop_native_widget_aura.h"
 #include "ui/views/widget/native_widget_aura.h"
+#include "ui/views/window/default_frame_view.h"
 
 #if BUILDFLAG(IS_LINUX)
 #include "base/environment.h"
@@ -62,7 +63,7 @@ gfx::ImageSkia* ViewsDelegate::GetDefaultWindowIcon() const {
 
 std::unique_ptr<views::FrameView> ViewsDelegate::CreateDefaultFrameView(
     views::Widget* widget) {
-  return nullptr;
+  return std::make_unique<views::DefaultFrameView>(widget);
 }
 
 void ViewsDelegate::OnBeforeWidgetInit(
Repository: vercel/next.js
Pull request: Turbopack: add bundle-analyzer to versioning and add dependency

### What?

fix lerna config and add dependency to make turborepo happy

Changed files:
filename: apps/bundle-analyzer/package.json
patch: @@ -1,6 +1,6 @@
 {
   "name": "@next/bundle-analyzer-ui",
-  "version": "16.0.2-canary.16",
+  "version": "16.0.2-canary.27",
   "private": true,
   "scripts": {
     "build": "cross-env NEXT_TEST_NATIVE_DIR=no next build --no-mangling",

filename: lerna.json
patch: @@ -2,7 +2,8 @@
   "npmClient": "pnpm",
   "useWorkspaces": true,
   "packages": [
-    "packages/*"
+    "packages/*",
+    "apps/bundle-analyzer"
   ],
   "command": {
     "version": {

filename: packages/next/package.json
patch: @@ -162,6 +162,7 @@
     "@modelcontextprotocol/sdk": "1.18.1",
     "@mswjs/interceptors": "0.23.0",
     "@napi-rs/triples": "1.2.0",
+    "@next/bundle-analyzer-ui": "16.0.2-canary.27",
     "@next/font": "16.0.2-canary.27",
     "@next/polyfill-module": "16.0.2-canary.27",
     "@next/polyfill-nomodule": "16.0.2-canary.27",

filename: pnpm-lock.yaml
patch: @@ -1200,6 +1200,9 @@ importers:
       '@napi-rs/triples':
         specifier: 1.2.0
         version: 1.2.0
+      '@next/bundle-analyzer-ui':
+        specifier: 16.0.2-canary.27
+        version: link:../../apps/bundle-analyzer
       '@next/font':
         specifier: 16.0.2-canary.27
         version: link:../font
Repository: facebook/react
Pull request: Expose new method in Fabric renderer to access root instance from root tag

Summary:
X-link: https://github.com/facebook/react-native/pull/49011

Changelog: [internal]

This exposes the new `getPublicInstanceFromRoot` method from the React renderer in our RN façades, preparing for the new change to implement the document interface in RN.

Reviewed By: javache

Differential Revision: D68767143


Changed files:
filename: compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/shims/ReactNativeTypes.js
patch: @@ -262,6 +262,9 @@ export type ReactFabricType = {
   getPublicInstanceFromInternalInstanceHandle(
     internalInstanceHandle: InternalInstanceHandle,
   ): PublicInstance | PublicTextInstance | null,
+  getPublicInstanceFromRootTag(
+    rootTag: number,
+  ): PublicRootInstance | null,
   ...
 };
Repository: vuejs/vue
Pull request: Set default value for ignoredElements to [].

Update default value for `ignoredElements` so that the docs (https://vuejs.org/v2/api/#ignoredElements) don't lie.

Changed files:
filename: src/core/config.js
patch: @@ -8,7 +8,7 @@ export type Config = {
   silent: boolean;
   devtools: boolean;
   errorHandler: ?Function;
-  ignoredElements: ?Array<string>;
+  ignoredElements: Array<string>;
   keyCodes: { [key: string]: number };
   // platform
   isReservedTag: (x?: string) => boolean;
@@ -46,7 +46,7 @@ const config: Config = {
   /**
    * Ignore certain custom elements
    */
-  ignoredElements: null,
+  ignoredElements: [],
 
   /**
    * Custom user key aliases for v-on
Repository: huggingface/transformers
Pull request: Fix the "test_offline" test

Unfortunately it turned out to be a bit harder to patch than initially thought.

Changed files:
filename: tests/utils/test_modeling_utils.py
patch: @@ -290,22 +290,20 @@ def forward(self, mask, inputs_embeds):
             return attention_mask
 
     class TestOffline(unittest.TestCase):
-        @patch("huggingface_hub.constants")
-        def test_offline(self, mock_hf_hub_constants):
+        def test_offline(self):
             with tempfile.TemporaryDirectory() as tmpdir:
-                mock_hf_hub_constants.HF_HUB_OFFLINE = True
-
                 # First offline load should fail
-                with pytest.raises(OSError):
-                    AutoModelForImageClassification.from_pretrained(TINY_IMAGE_CLASSIF, cache_dir=tmpdir)
+                with patch("transformers.utils.hub.is_offline_mode", return_value=True):
+                    with pytest.raises(OSError):
+                        AutoModelForImageClassification.from_pretrained(TINY_IMAGE_CLASSIF, cache_dir=tmpdir)
 
-                # Download model from Hub
-                mock_hf_hub_constants.HF_HUB_OFFLINE = False
-                snapshot_download(TINY_IMAGE_CLASSIF, cache_dir=tmpdir)
+                # Enable online mode for download
+                with patch("transformers.utils.hub.is_offline_mode", return_value=False):
+                    snapshot_download(TINY_IMAGE_CLASSIF, cache_dir=tmpdir)
 
                 # Load again in offline mode - should work now
-                mock_hf_hub_constants.HF_HUB_OFFLINE = True
-                AutoModelForImageClassification.from_pretrained(TINY_IMAGE_CLASSIF, cache_dir=tmpdir)
+                with patch("transformers.utils.hub.is_offline_mode", return_value=True):
+                    AutoModelForImageClassification.from_pretrained(TINY_IMAGE_CLASSIF, cache_dir=tmpdir)
 
         def test_local_files_only(self):
             with tempfile.TemporaryDirectory() as tmpdir:
Repository: huggingface/transformers
Pull request: FIX: Minimal fix for loading PEFT weights

# What does this PR do?

After the weight conversion PR #41580, some adjustments were still required for loading PEFT weights. This PR presents a minimal fix to make it work again.

Besides renaming keys, this PR does not address possible conversions that might be required to be applied to the PEFT weights themselves (most wouldn't work anyway, but e.g. chunking should be possible to implement).

As for test, the existing test_peft_from_pretrained in test_peft_integration.py actually fails on main right now, this PR fixes it. As the tests are slow tests, normal CI won't pick this up though.

## Before submitting
- [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
- [x] Did you read the [contributor guideline](https://github.com/huggingface/transformers/blob/main/CONTRIBUTING.md#create-a-pull-request),
      Pull Request section?
- [x] Was this discussed/approved on slack.
- [ ] Did you make sure to update the documentation with your changes? Here are the
      [documentation guidelines](https://github.com/huggingface/transformers/tree/main/docs), and
      [here are tips on formatting docstrings](https://github.com/huggingface/transformers/tree/main/docs#writing-source-documentation).
- [ ] Did you write any new necessary tests?


Changed files:
filename: src/transformers/integrations/peft.py
patch: @@ -15,9 +15,9 @@
 import inspect
 import json
 import os
-import re
 from typing import Any, Literal
 
+from ..core_model_loading import WeightRenaming, build_glob_alternation, repl
 from ..utils import (
     CONFIG_NAME,
     cached_file,
@@ -302,12 +302,10 @@ def load_adapter(
             else:
                 new_key = key
 
-            if key_mapping:  # TODO dynamic weight loader for adapters
-                for pattern, replacement in key_mapping.items():
-                    new_key, n_replace = re.subn(pattern, replacement, new_key)
-                    # Early exit of the loop
-                    if n_replace > 0:
-                        break
+            if key_mapping:
+                renamings = [entry for entry in key_mapping if isinstance(entry, WeightRenaming)]
+                rename_alt, _, rename_by_group = build_glob_alternation(renamings)
+                new_key = rename_alt.sub(lambda m: repl(m, rename_by_group), new_key).replace("\\", "")
 
             # For hotswapping, we need the adapter name to be present in the state dict keys
             if hotswap:
Repository: vercel/next.js
Pull request: fix issue -  #86365

Fix issue [#86365](https://github.com/vercel/next.js/issues/86365)

Changed files:
filename: packages/next/README.md
patch: @@ -39,7 +39,7 @@ Contributions to Next.js are welcome and highly appreciated. However, before you
 
 ### Good First Issues:
 
-We have a list of **[good first issues](https://github.com/vercel/next.js/labels/%22good%20first%20issue%22)** that contain bugs that have a relatively limited scope. This is a great place for newcomers and beginners alike to get started, gain experience, and get familiar with our contribution process.
+We have a list of **[good first issues](https://github.com/vercel/next.js/labels/good%20first%20issue)** that contain bugs that have a relatively limited scope. This is a great place for newcomers and beginners alike to get started, gain experience, and get familiar with our contribution process.
 
 ---
 ## Security
Repository: vuejs/vue
Pull request: Add missing string handler in v-for

<!--
Please make sure to read the Pull Request Guidelines:
https://github.com/vuejs/vue/blob/dev/.github/CONTRIBUTING.md#pull-request-guidelines
-->

Fix #4497 

At first I added an else if at the end since strings are rarely used in v-for loops but it felt wrong not to reuse the first if

Changed files:
filename: src/core/instance/render.js
patch: @@ -178,7 +178,7 @@ export function renderMixin (Vue: Class<Component>) {
     render: () => VNode
   ): ?Array<VNode> {
     let ret: ?Array<VNode>, i, l, keys, key
-    if (Array.isArray(val)) {
+    if (Array.isArray(val) || typeof val === 'string') {
       ret = new Array(val.length)
       for (i = 0, l = val.length; i < l; i++) {
         ret[i] = render(val[i], i)

filename: test/unit/features/directives/for.spec.js
patch: @@ -428,4 +428,22 @@ describe('Directive v-for', () => {
       expect(vm.$el.textContent).toMatch(/\s+foo\s+bar\s+/)
     }).then(done)
   })
+
+  it('strings', done => {
+    const vm = new Vue({
+      data: {
+        text: 'foo'
+      },
+      template: `
+        <div>
+          <span v-for="letter in text">{{ letter }}.</span
+        </div>
+      `
+    }).$mount()
+    expect(vm.$el.textContent).toMatch('f.o.o.')
+    vm.text += 'bar'
+    waitForUpdate(() => {
+      expect(vm.$el.textContent).toMatch('f.o.o.b.a.r.')
+    }).then(done)
+  })
 })
Repository: facebook/react
Pull request: Update MAINTAINERS

https://github.com/reactjs/react.dev/pull/7438

Changed files:
filename: MAINTAINERS
patch: @@ -2,24 +2,21 @@ acdlite
 eps1lon
 gaearon
 gnoff
-gsathya
+unstubbable
 hoxyq
 jackpope
 jbonta
 jbrown215
 josephsavona
 kassens
-lunaleaps
 mattcarrollcode
 mofeiZ
 mvitousek
-noahlemen
 pieterv
 poteto
 rickhanlonii
 sebmarkbage
 sethwebster
 sophiebits
 elicwhite
-tyao1
 yuzhi
Repository: ggml-org/llama.cpp
Pull request: ggml: added cleanups in ggml_quantize_free

Add missing cleanup calls for IQ2_S, IQ1_M quantization types and IQ3XS with 512 blocks during quantization cleanup.


Changed files:
filename: ggml/src/ggml.c
patch: @@ -7517,8 +7517,11 @@ void ggml_quantize_free(void) {
 
     iq2xs_free_impl(GGML_TYPE_IQ2_XXS);
     iq2xs_free_impl(GGML_TYPE_IQ2_XS);
+    iq2xs_free_impl(GGML_TYPE_IQ2_S);
     iq2xs_free_impl(GGML_TYPE_IQ1_S);
+    iq2xs_free_impl(GGML_TYPE_IQ1_M);
     iq3xs_free_impl(256);
+    iq3xs_free_impl(512);
 
     ggml_critical_section_end();
 }
Repository: ollama/ollama
Pull request: fix: chmod new layer to 0o644 when creating it

fix https://github.com/ollama/ollama/issues/6373

Changed files:
filename: server/layer.go
patch: @@ -51,6 +51,9 @@ func NewLayer(r io.Reader, mediatype string) (Layer, error) {
 		if err := os.Rename(temp.Name(), blob); err != nil {
 			return Layer{}, err
 		}
+		if err := os.Chmod(blob, 0o644); err != nil {
+			return Layer{}, err
+		}
 	}
 
 	return Layer{
Repository: ollama/ollama
Pull request: CI: remove directories from dist dir before upload step


Changed files:
filename: .github/workflows/release.yaml
patch: @@ -474,6 +474,7 @@ jobs:
           ls -lh dist/
           (cd dist; find . -type f | xargs sha256sum > ../sha256sum.txt)
           mv sha256sum.txt dist/
+          mv dist/linux-???64 .
           cat dist/sha256sum.txt
       - name: Create or update Release
         run: |
Repository: ollama/ollama
Pull request: CI: handle directories during checksum


Changed files:
filename: .github/workflows/release.yaml
patch: @@ -472,7 +472,8 @@ jobs:
           merge-multiple: true
       - run: |
           ls -lh dist/
-          (cd dist; sha256sum * > sha256sum.txt)
+          (cd dist; find . -type f | xargs sha256sum > ../sha256sum.txt)
+          mv sha256sum.txt dist/
           cat dist/sha256sum.txt
       - name: Create or update Release
         run: |
Repository: vuejs/vue
Pull request: Update normalize children (fix 4466)

fix #4466 . Check boolean type

Changed files:
filename: src/core/vdom/helpers/normalize-children.js
patch: @@ -16,7 +16,7 @@ function normalizeArrayChildren (children: any, nestedIndex?: string): Array<VNo
   let i, c, last
   for (i = 0; i < children.length; i++) {
     c = children[i]
-    if (c == null) continue
+    if (c == null || typeof c === 'boolean') continue
     last = res[res.length - 1]
     //  nested
     if (Array.isArray(c)) {

filename: test/unit/modules/vdom/create-element.spec.js
patch: @@ -98,6 +98,17 @@ describe('create-element', () => {
     expect(vnode.children[2].tag).toBe('br')
   })
 
+  it('render vnode with children, including boolean and null type', () => {
+    const vm = new Vue({})
+    const h = vm.$createElement
+    const vnode = h('p', [h('br'), true, 123, h('br'), 'abc', null])
+    expect(vnode.children.length).toBe(4)
+    expect(vnode.children[0].tag).toBe('br')
+    expect(vnode.children[1].text).toBe('123')
+    expect(vnode.children[2].tag).toBe('br')
+    expect(vnode.children[3].text).toBe('abc')
+  })
+
   it('render svg elements with correct namespace', () => {
     const vm = new Vue({})
     const h = vm.$createElement