helloadhavan/github_issues huggingface dataset:
Repository: facebook/react
Pull request: [ci] Use correct actor when checking if maintainer


The discord notification workflows were checking the label event's actor (ie a bot) instead of the pull request's actor. To fix this, parameterize the shared maintainer check workflow and always use the pull request user as the input.


Changed files:
filename: .github/workflows/compiler_discord_notify.yml
patch: @@ -10,6 +10,8 @@ on:
 jobs:
   check_maintainer:
     uses: facebook/react/.github/workflows/shared_check_maintainer.yml@main
+    with:
+      actor: ${{ github.event.pull_request.user.login }}
 
   notify:
     if: ${{ needs.check_maintainer.outputs.is_core_team == 'true' }}

filename: .github/workflows/runtime_discord_notify.yml
patch: @@ -10,6 +10,8 @@ on:
 jobs:
   check_maintainer:
     uses: facebook/react/.github/workflows/shared_check_maintainer.yml@main
+    with:
+      actor: ${{ github.event.pull_request.user.login }}
 
   notify:
     if: ${{ needs.check_maintainer.outputs.is_core_team == 'true' }}

filename: .github/workflows/shared_check_maintainer.yml
patch: @@ -2,6 +2,10 @@ name: (Shared) Check maintainer
 
 on:
   workflow_call:
+    inputs:
+      actor:
+        required: true
+        type: string
     outputs:
       is_core_team:
         value: ${{ jobs.check_maintainer.outputs.is_core_team }}
@@ -24,7 +28,7 @@ jobs:
         with:
           script: |
             const fs = require('fs');
-            const actor = '${{ github.actor }}';
+            const actor = '${{ inputs.actor }}';
             const data = await fs.readFileSync('./MAINTAINERS', { encoding: 'utf8' });
             const maintainers = new Set(data.split('\n'));
             if (maintainers.has(actor)) {

filename: .github/workflows/shared_label_core_team_prs.yml
patch: @@ -11,6 +11,8 @@ env:
 jobs:
   check_maintainer:
     uses: facebook/react/.github/workflows/shared_check_maintainer.yml@main
+    with:
+      actor: ${{ github.event.pull_request.user.login }}
 
   label:
     if: ${{ needs.check_maintainer.outputs.is_core_team == 'true' }}
Repository: vercel/next.js
Pull request: [test] Disable flaky prefetching.stale-times test

70% failure rate and we haven't been able to identify the issue for a while.

Changed files:
filename: test/e2e/app-dir/app-prefetch/prefetching.stale-times.test.ts
patch: @@ -127,7 +127,8 @@ describe('app dir - prefetching (custom staleTime)', () => {
     }, 'no-requests')
   })
 
-  it('should not re-fetch cached data when navigating back to a route group', async () => {
+  // FIXME: Flaky test - investigate and re-enable
+  it.skip('should not re-fetch cached data when navigating back to a route group', async () => {
     let act: ReturnType<typeof createRouterAct>
     // Just installing so that the page doesn't automatically move past dynamic stale time
     createTimeController()
Repository: electron/electron
Pull request: fix: fixed white flash on call to BrowserWindow.show

#### Description of Change
Fixes https://github.com/electron/electron/issues/47149 by showing native NSView corresponding to window's content view before showing the window on a call to `BrowserWindow.show`/`BrowserWindow.showInactive`.
<!--
Thank you for your Pull Request. Please provide a description above and review
the requirements below.

Contributors guide: https://github.com/electron/electron/blob/main/CONTRIBUTING.md
-->

#### Checklist
<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

- [x] PR description included and stakeholders cc'd
- [x] `npm test` passes
- [ ] tests are [changed or added](https://github.com/electron/electron/blob/main/docs/development/testing.md)
- [x] relevant API documentation, tutorials, and examples are updated and follow the [documentation style guide](https://github.com/electron/electron/blob/main/docs/development/style-guide.md)
- [x] PR release notes](https://github.com/electron/clerk/blob/main/README.md) describe the change in a way relevant to app developers, and are [capitalized, punctuated, and past tense](https://github.com/electron/clerk/blob/main/README.md#examples).

#### Release Notes

Notes: fixed white flash on call to BrowserWindow.show


Changed files:
filename: shell/browser/api/electron_api_base_window.h
patch: @@ -106,8 +106,8 @@ class BaseWindow : public gin_helper::TrackableObject<BaseWindow>,
   virtual void Focus();
   virtual void Blur();
   bool IsFocused() const;
-  void Show();
-  void ShowInactive();
+  virtual void Show();
+  virtual void ShowInactive();
   void Hide();
   bool IsVisible() const;
   bool IsEnabled() const;

filename: shell/browser/api/electron_api_browser_window.cc
patch: @@ -280,7 +280,6 @@ v8::Local<v8::Value> BrowserWindow::GetWebContents(v8::Isolate* isolate) {
 }
 
 void BrowserWindow::OnWindowShow() {
-  web_contents()->WasShown();
   BaseWindow::OnWindowShow();
 }
 
@@ -289,6 +288,19 @@ void BrowserWindow::OnWindowHide() {
   BaseWindow::OnWindowHide();
 }
 
+void BrowserWindow::Show() {
+  web_contents()->WasShown();
+  BaseWindow::Show();
+}
+
+void BrowserWindow::ShowInactive() {
+  // This method doesn't make sense for modal window.
+  if (IsModal())
+    return;
+  web_contents()->WasShown();
+  BaseWindow::ShowInactive();
+}
+
 // static
 gin_helper::WrappableBase* BrowserWindow::New(gin_helper::ErrorThrower thrower,
                                               gin::Arguments* args) {

filename: shell/browser/api/electron_api_browser_window.h
patch: @@ -67,6 +67,8 @@ class BrowserWindow : public BaseWindow,
   void SetBackgroundMaterial(const std::string& material) override;
   void OnWindowShow() override;
   void OnWindowHide() override;
+  void Show() override;
+  void ShowInactive() override;
 
   // BrowserWindow APIs.
   void FocusOnWebView();
Repository: vuejs/vue
Pull request: Add undefined check for instance methods

Adding an undefined property to `methods` on vue components leads to a very ambiguous error message: `Uncaught TypeError: Cannot read property 'length' of undefined`

Example:

``` js
import stuff from './stuff'

export default {
  template: '...',
  methods: {
    someMethod: stuff.someMetod // typo!!!
  }
}
```

It's an easy mistake to make. This checks for undefined properties and warns if it finds one.


Changed files:
filename: src/core/instance/state.js
patch: @@ -142,7 +142,11 @@ function initMethods (vm: Component) {
   const methods = vm.$options.methods
   if (methods) {
     for (const key in methods) {
-      vm[key] = bind(methods[key], vm)
+      if (methods[key] != null) {
+        vm[key] = bind(methods[key], vm)
+      } else if (process.env.NODE_ENV !== 'production') {
+        warn(`The method ${key} on vue instance is undefined.`, vm)
+      }
     }
   }
 }
Repository: nodejs/node
Pull request: doc: clarify Linux runtime requirements for >=25

Due to the switch to Clang on Linux for building the official releases, the binaries now require libatomic to run.

I am not quite sure if this footnote really does the job, but I guess it's at least a bit more explicit than the current wording.

Refs: https://github.com/nodejs/node/issues/37219
Refs: https://github.com/nodejs/build/issues/4091

<!--
Before submitting a pull request, please read:

- the CONTRIBUTING guide at https://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md
- the commit message formatting guidelines at
  https://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#commit-message-guidelines

For code changes:
1. Include tests for any bug fixes or new features.
2. Update documentation if relevant.
3. Ensure that `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes.

If you believe this PR should be highlighted in the Node.js CHANGELOG
please add the `notable-change` label.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.
-->


Changed files:
filename: BUILDING.md
patch: @@ -175,6 +175,11 @@ Binaries at <https://nodejs.org/download/release/> are produced on:
 | win-arm64               | Windows Server 2022 (x64) with Visual Studio 2022             |
 | win-x64                 | Windows Server 2022 (x64) with Visual Studio 2022             |
 
+Starting with Node.js 25, official Linux binaries are linked with `libatomic` and these systems
+must have the `libatomic` runtime installed and available at execution time to run the binaries.
+The package name for the `libatomic` runtime is typically `libatomic` or `libatomic1` depending
+on your Linux distibution.
+
 <!--lint disable final-definition-->
 
 [^5]: Binaries produced on these systems require libstdc++12, available
Repository: ggml-org/llama.cpp
Pull request: nix: fix nix develop .#python-scripts

Without this I get:

> * Getting build dependencies for wheel...
> * Building wheel...
> Successfully built gguf-0.17.1-py3-none-any.whl
> Finished creating a wheel...
> Finished executing pypaBuildPhase
> Running phase: pythonRuntimeDepsCheckHook
> Executing pythonRuntimeDepsCheck
> Checking runtime dependencies for gguf-0.17.1-py3-none-any.whl
>   - requests not installed
For full logs, run:
    nix log /nix/store/x0c4a251l68bvdgang9d8v2fsmqay8a4-python3.12-gguf-0.0.0.drv

I changed a bit the style to make it more terse ~> more elegant in my opinion.

*Make sure to read the [contributing guidelines](https://github.com/ggml-org/llama.cpp/blob/master/CONTRIBUTING.md) before submitting a PR*


Changed files:
filename: .devops/nix/package-gguf-py.nix
patch: @@ -3,6 +3,7 @@
   llamaVersion,
   numpy,
   tqdm,
+  requests,
   sentencepiece,
   pyyaml,
   poetry-core,
@@ -20,6 +21,7 @@ buildPythonPackage {
     tqdm
     sentencepiece
     pyyaml
+    requests
   ];
   src = lib.cleanSource ../../gguf-py;
   pythonImportsCheck = [

filename: .devops/nix/scope.nix
patch: @@ -7,13 +7,6 @@
 
 let
   pythonPackages = python3.pkgs;
-  buildPythonPackage = pythonPackages.buildPythonPackage;
-  numpy = pythonPackages.numpy;
-  tqdm = pythonPackages.tqdm;
-  sentencepiece = pythonPackages.sentencepiece;
-  pyyaml = pythonPackages.pyyaml;
-  poetry-core = pythonPackages.poetry-core;
-  pytestCheckHook = pythonPackages.pytestCheckHook;
 in
 
 # We're using `makeScope` instead of just writing out an attrset
@@ -23,17 +16,18 @@ in
 lib.makeScope newScope (self: {
   inherit llamaVersion;
   gguf-py = self.callPackage ./package-gguf-py.nix {
-    inherit
-      buildPythonPackage
+    inherit (pythonPackages)
       numpy
       tqdm
       sentencepiece
-      poetry-core
       pyyaml
       pytestCheckHook
+      requests
+      buildPythonPackage
+      poetry-core
       ;
   };
-  python-scripts = self.callPackage ./python-scripts.nix { inherit buildPythonPackage poetry-core; };
+  python-scripts = self.callPackage ./python-scripts.nix { inherit (pythonPackages) buildPythonPackage poetry-core; };
   llama-cpp = self.callPackage ./package.nix { };
   docker = self.callPackage ./docker.nix { };
   docker-min = self.callPackage ./docker.nix { interactive = false; };
Repository: facebook/react
Pull request: Fix moveBefore feature detection

`moveBefore` was moved to the `ParentNode` mixin as per https://github.com/whatwg/dom/pull/1307#discussion_r1881981120 _(and was committed in https://github.com/whatwg/dom/commit/3f3e94c5beda922962dacaeb606087f57bd7f7be)_

As a result, its existence can no longer be checked on `Node.prototype` but must be checked in `Element.prototype`

Changed files:
filename: packages/react-dom-bindings/src/client/ReactFiberConfigDOM.js
patch: @@ -780,7 +780,7 @@ const supportsMoveBefore =
   // $FlowFixMe[prop-missing]: We're doing the feature detection here.
   enableMoveBefore &&
   typeof window !== 'undefined' &&
-  typeof window.Node.prototype.moveBefore === 'function';
+  typeof window.Element.prototype.moveBefore === 'function';
 
 export function appendChild(
   parentInstance: Instance,
Repository: facebook/react
Pull request: [ci] Fix maintainer output condition check


It appears GH actions treats outputs from workflow_calls to [always be strings](https://github.com/orgs/community/discussions/9343) so we need to do an explicit comparison.


Changed files:
filename: .github/workflows/compiler_discord_notify.yml
patch: @@ -12,7 +12,7 @@ jobs:
     uses: facebook/react/.github/workflows/shared_check_maintainer.yml@main
 
   notify:
-    if: ${{ needs.check_maintainer.outputs.is_core_team }}
+    if: ${{ needs.check_maintainer.outputs.is_core_team == 'true' }}
     needs: check_maintainer
     runs-on: ubuntu-latest
     steps:

filename: .github/workflows/runtime_discord_notify.yml
patch: @@ -12,7 +12,7 @@ jobs:
     uses: facebook/react/.github/workflows/shared_check_maintainer.yml@main
 
   notify:
-    if: ${{ needs.check_maintainer.outputs.is_core_team }}
+    if: ${{ needs.check_maintainer.outputs.is_core_team == 'true' }}
     needs: check_maintainer
     runs-on: ubuntu-latest
     steps:
Repository: facebook/react
Pull request: Fix maintainer check condition

<!--
  Thanks for submitting a pull request!
  We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.

  Before submitting a pull request, please make sure the following is done:

  1. Fork [the repository](https://github.com/facebook/react) and create your branch from `main`.
  2. Run `yarn` in the repository root.
  3. If you've fixed a bug or added code that should be tested, add tests!
  4. Ensure the test suite passes (`yarn test`). Tip: `yarn test --watch TestName` is helpful in development.
  5. Run `yarn test --prod` to test in the production environment. It supports the same options as `yarn test`.
  6. If you need a debugger, run `yarn test --debug --watch TestName`, open `chrome://inspect`, and press "Inspect".
  7. Format your code with [prettier](https://github.com/prettier/prettier) (`yarn prettier`).
  8. Make sure your code lints (`yarn lint`). Tip: `yarn linc` to only check changed files.
  9. Run the [Flow](https://flowtype.org/) type checks (`yarn flow`).
  10. If you haven't already, complete the CLA.

  Learn more about contributing: https://reactjs.org/docs/how-to-contribute.html
-->

## Summary

I've noticed that the value stored under `is_core_team` gets stringified, so some PRs may be mislabelled as coming from the core team.

I've checked this on my fork and saw stringified `null` returned by the `is_core_team`, and this PR explicitly checks for the correct value. Feel free to close this PR if you want to go with another approach.

## How did you test this change?

Checked this change on my fork with and without listing myself in the maintainers file.

Changed files:
filename: .github/workflows/shared_label_core_team_prs.yml
patch: @@ -13,7 +13,7 @@ jobs:
     uses: facebook/react/.github/workflows/shared_check_maintainer.yml@main
 
   label:
-    if: ${{ needs.check_maintainer.outputs.is_core_team }}
+    if: ${{ needs.check_maintainer.outputs.is_core_team == 'true' }}
     runs-on: ubuntu-latest
     needs: check_maintainer
     steps:
Repository: vuejs/vue
Pull request: Add missing lifecycle definition

We forget about activated/deactivated in keep-alive component :scream:  @ktsn @kaorun343 

Adding two optional fields are compatible to older typing API, so this is not a breaking change.

Changed files:
filename: types/options.d.ts
patch: @@ -32,6 +32,8 @@ export interface ComponentOptions<V extends Vue> {
   mounted?(this: V): void;
   beforeUpdate?(this: V): void;
   updated?(this: V): void;
+  activated?(this: V): void;
+  deactivated?(this: V): void;
 
   directives?: { [key: string]: DirectiveOptions | DirectiveFunction };
   components?: { [key: string]: Component | AsyncComponent };

filename: types/test/options-test.ts
patch: @@ -123,6 +123,8 @@ Vue.component('component', {
   mounted() {},
   beforeUpdate() {},
   updated() {},
+  activated() {},
+  deactivated() {},
 
   directives: {
     a: {
Repository: electron/electron
Pull request: fix: auth required websocket crash

Backport of #48510

See that PR for details.


Notes: Fixes an issue where authentication via websockets can crash.

Changed files:
filename: shell/browser/net/proxying_websocket.cc
patch: @@ -401,7 +401,7 @@ void ProxyingWebSocket::OnHeadersReceivedCompleteForAuth(
 
   auto continuation = base::BindRepeating(
       &ProxyingWebSocket::OnAuthRequiredComplete, weak_factory_.GetWeakPtr());
-  auto auth_rv = AuthRequiredResponse::kIoPending;
+  auto auth_rv = AuthRequiredResponse::kCancelAuth;
   PauseIncomingMethodCallProcessing();
 
   OnAuthRequiredComplete(auth_rv);
Repository: vuejs/vue
Pull request: Fix v-move class when name isn't specified

If `name` isn't specified for a `<transition-group>`, then the class name vue uses for moving items will be `undefined-move` instead of `v-move`.

Changed files:
filename: src/platforms/web/runtime/components/transition-group.js
patch: @@ -89,7 +89,7 @@ export default {
 
   updated () {
     const children = this.prevChildren
-    const moveClass = this.moveClass || (this.name + '-move')
+    const moveClass = this.moveClass || ((this.name || 'v') + '-move')
     if (!children.length || !this.hasMove(children[0].elm, moveClass)) {
       return
     }
Repository: facebook/react
Pull request: fix[DevTools]: support useResourceEffect

Since we've started experimenting with it, I've started seeing a spike in errors:
```
Unsupported hook in the react-debug-tools package: Missing method in Dispatcher: useResourceEffect
```

Adding missing hook to the `Dispatcher` that is proxied by React DevTools.

I can't really add an example that will use it to our RDT testing shell, because it uses experimental builds of `react`, which don't have this hook. I've tested it manually by rebuilding artifacts with `enableUseResourceEffectHook` flag enabled.

![Screenshot 2025-01-16 at 15 20 00](https://github.com/user-attachments/assets/a0d63fd6-1f17-4710-a2b2-82d484b8987f)


Changed files:
filename: packages/react-debug-tools/src/ReactDebugHooks.js
patch: @@ -731,6 +731,24 @@ function useHostTransitionStatus(): TransitionStatus {
   return status;
 }
 
+function useResourceEffect(
+  create: () => mixed,
+  createDeps: Array<mixed> | void | null,
+  update: ((resource: mixed) => void) | void,
+  updateDeps: Array<mixed> | void | null,
+  destroy: ((resource: mixed) => void) | void,
+) {
+  nextHook();
+  hookLog.push({
+    displayName: null,
+    primitive: 'ResourceEffect',
+    stackError: new Error(),
+    value: create,
+    debugInfo: null,
+    dispatcherHookName: 'ResourceEffect',
+  });
+}
+
 const Dispatcher: DispatcherType = {
   use,
   readContext,
@@ -755,6 +773,7 @@ const Dispatcher: DispatcherType = {
   useFormState,
   useActionState,
   useHostTransitionStatus,
+  useResourceEffect,
 };
 
 // create a proxy to throw a custom error
@@ -943,6 +962,10 @@ function parseHookName(functionName: void | string): string {
     startIndex += 'unstable_'.length;
   }
 
+  if (functionName.slice(startIndex).startsWith('unstable_')) {
+    startIndex += 'experimental_'.length;
+  }
+
   if (functionName.slice(startIndex, startIndex + 3) === 'use') {
     if (functionName.length - startIndex === 3) {
       return 'Use';
Repository: facebook/react
Pull request: [ci] Only notify after labeling

---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/32103).
* __->__ #32103
* #32102

Changed files:
filename: .github/workflows/compiler_discord_notify.yml
patch: @@ -2,6 +2,7 @@ name: (Compiler) Discord Notify
 
 on:
   pull_request_target:
+    types: [labeled]
     paths:
       - compiler/**
       - .github/workflows/compiler_**.yml

filename: .github/workflows/runtime_discord_notify.yml
patch: @@ -2,6 +2,7 @@ name: (Runtime) Discord Notify
 
 on:
   pull_request_target:
+    types: [labeled]
     paths-ignore:
       - compiler/**
       - .github/workflows/compiler_**.yml

filename: .github/workflows/shared_core_label.yml
patch: @@ -1,41 +0,0 @@
-name: (Shared) Core Label
-
-on:
-  pull_request_target:
-
-env:
-  TZ: /usr/share/zoneinfo/America/Los_Angeles
-  # https://github.com/actions/cache/blob/main/tips-and-workarounds.md#cache-segment-restore-timeout
-  SEGMENT_DOWNLOAD_TIMEOUT_MINS: 1
-
-jobs:
-  core_label:
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v4
-      - name: Check if actor is maintainer
-        id: check_maintainer
-        uses: actions/github-script@v7
-        with:
-          script: |
-            const fs = require('fs');
-            const actor = '${{ github.actor }}';
-            const data = await fs.readFileSync('./MAINTAINERS', { encoding: 'utf8' });
-            const maintainers = new Set(data.split('\n'));
-            if (maintainers.has(actor)) {
-              console.log(`🟢 ${actor} is a maintainer`);
-              return true;
-            }
-            console.log(`🔴 ${actor} is NOT a maintainer`);
-            return null;
-      - name: Label PR as React Core Team
-        if: ${{ steps.check_maintainer.outputs.result }}
-        uses: actions/github-script@v7
-        with:
-          script: |
-            github.rest.issues.addLabels({
-              owner: context.repo.owner,
-              repo: context.repo.repo,
-              issue_number: ${{ github.event.number }},
-              labels: ['React Core Team']
-            });
Repository: facebook/react
Pull request: Fix outdated maintainers list


I made a few mistakes while adding the initial list
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/32102).
* #32103
* __->__ #32102

Changed files:
filename: MAINTAINERS
patch: @@ -1,5 +1,4 @@
 acdlite
-bvaughn
 eps1lon
 gaearon
 gnoff
@@ -13,7 +12,9 @@ kassens
 lunaleaps
 mattcarrollcode
 mofeiZ
+mvitousek
 noahlemen
+pieterv
 poteto
 rickhanlonii
 sebmarkbage
Repository: electron/electron
Pull request: build: run on macOS 15

Backport of #48563

See that PR for details.


Notes: none

Changed files:
filename: .github/workflows/macos-publish.yml
patch: @@ -47,7 +47,7 @@ jobs:
     needs: checkout-macos
     with:
       environment: production-release
-      build-runs-on: macos-14-xlarge
+      build-runs-on: macos-15-xlarge
       target-platform: macos
       target-arch: x64
       target-variant: darwin
@@ -62,7 +62,7 @@ jobs:
     needs: checkout-macos
     with:
       environment: production-release
-      build-runs-on: macos-14-xlarge
+      build-runs-on: macos-15-xlarge
       target-platform: macos
       target-arch: x64
       target-variant: mas
@@ -77,7 +77,7 @@ jobs:
     needs: checkout-macos
     with:
       environment: production-release
-      build-runs-on: macos-14-xlarge
+      build-runs-on: macos-15-xlarge
       target-platform: macos
       target-arch: arm64
       target-variant: darwin
@@ -92,7 +92,7 @@ jobs:
     needs: checkout-macos
     with:
       environment: production-release
-      build-runs-on: macos-14-xlarge
+      build-runs-on: macos-15-xlarge
       target-platform: macos
       target-arch: arm64
       target-variant: mas