helloadhavan/github_issues huggingface dataset:
Repository: facebook/react
Pull request: [ci] Don't run some checks for non-members/collaborators


There's really no need to even run the workflow for non-members or collaborators for the labeling and discord notification workflows. We can exit early.


Changed files:
filename: .github/workflows/compiler_discord_notify.yml
patch: @@ -10,7 +10,19 @@ on:
 permissions: {}
 
 jobs:
+  check_access:
+    runs-on: ubuntu-latest
+    outputs:
+      is_member_or_collaborator: ${{ steps.check_access.outputs.result }}
+    steps:
+      - name: Check access
+        id: check_access
+        if: ${{ github.event.pull_request.author_association == 'MEMBER' || github.event.pull_request.author_association == 'COLLABORATOR' }}
+        run: echo "is_member_or_collaborator=true" >> "$GITHUB_OUTPUT"
+
   check_maintainer:
+    if: ${{ needs.check_access.outputs.is_member_or_collaborator == 'true' }}
+    needs: [check_access]
     uses: facebook/react/.github/workflows/shared_check_maintainer.yml@main
     permissions:
       # Used by check_maintainer

filename: .github/workflows/runtime_discord_notify.yml
patch: @@ -10,7 +10,19 @@ on:
 permissions: {}
 
 jobs:
+  check_access:
+    runs-on: ubuntu-latest
+    outputs:
+      is_member_or_collaborator: ${{ steps.check_access.outputs.result }}
+    steps:
+      - name: Check access
+        id: check_access
+        if: ${{ github.event.pull_request.author_association == 'MEMBER' || github.event.pull_request.author_association == 'COLLABORATOR' }}
+        run: echo "is_member_or_collaborator=true" >> "$GITHUB_OUTPUT"
+
   check_maintainer:
+    if: ${{ needs.check_access.outputs.is_member_or_collaborator == 'true' }}
+    needs: [check_access]
     uses: facebook/react/.github/workflows/shared_check_maintainer.yml@main
     permissions:
       # Used by check_maintainer

filename: .github/workflows/shared_label_core_team_prs.yml
patch: @@ -11,7 +11,19 @@ env:
   SEGMENT_DOWNLOAD_TIMEOUT_MINS: 1
 
 jobs:
+  check_access:
+    runs-on: ubuntu-latest
+    outputs:
+      is_member_or_collaborator: ${{ steps.check_access.outputs.result }}
+    steps:
+      - name: Check access
+        id: check_access
+        if: ${{ github.event.pull_request.author_association == 'MEMBER' || github.event.pull_request.author_association == 'COLLABORATOR' }}
+        run: echo "is_member_or_collaborator=true" >> "$GITHUB_OUTPUT"
+
   check_maintainer:
+    if: ${{ needs.check_access.outputs.is_member_or_collaborator == 'true' }}
+    needs: [check_access]
     uses: facebook/react/.github/workflows/shared_check_maintainer.yml@main
     permissions:
       # Used by check_maintainer
Repository: ollama/ollama
Pull request: Update README.md

Add database app example: Kangaroo

Changed files:
filename: README.md
patch: @@ -409,6 +409,7 @@ See the [API documentation](./docs/api.md) for all endpoints.
 
 - [MindsDB](https://github.com/mindsdb/mindsdb/blob/staging/mindsdb/integrations/handlers/ollama_handler/README.md) (Connects Ollama models with nearly 200 data platforms and apps)
 - [chromem-go](https://github.com/philippgille/chromem-go/blob/v0.5.0/embed_ollama.go) with [example](https://github.com/philippgille/chromem-go/tree/v0.5.0/examples/rag-wikipedia-ollama)
+- [Kangaroo](https://github.com/dbkangaroo/kangaroo) (AI-powered SQL client and admin tool for popular databases)
 
 ### Package managers
Repository: ollama/ollama
Pull request: Lowercase hostname for CORS.

Origins check fails when Host header is not lowercase.

Fixes https://github.com/ollama/ollama/issues/5838.

Changed files:
filename: server/routes.go
patch: @@ -1071,11 +1071,13 @@ func isLocalIP(ip netip.Addr) bool {
 }
 
 func allowedHost(host string) bool {
+	host = strings.ToLower(host)
+
 	if host == "" || host == "localhost" {
 		return true
 	}
 
-	if hostname, err := os.Hostname(); err == nil && host == hostname {
+	if hostname, err := os.Hostname(); err == nil && host == strings.ToLower(hostname) {
 		return true
 	}
Repository: ggml-org/llama.cpp
Pull request: common : add more aliases for sampler CLI params

Adds two CLI argument aliases for sampler parameters:
- `--top-n-sigma` (for existing `--top-nsigma`)
- `--temperature` (for existing `--temp`)

*Make sure to read the [contributing guidelines](https://github.com/ggml-org/llama.cpp/blob/master/CONTRIBUTING.md) before submitting a PR*

Changed files:
filename: common/arg.cpp
patch: @@ -1578,7 +1578,7 @@ common_params_context common_params_parser_init(common_params & params, llama_ex
         }
     ).set_sparam());
     add_opt(common_arg(
-        {"--temp"}, "N",
+        {"--temp", "--temperature"}, "N",
         string_format("temperature (default: %.2f)", (double)params.sampling.temp),
         [](common_params & params, const std::string & value) {
             params.sampling.temp = std::stof(value);
@@ -1611,7 +1611,7 @@ common_params_context common_params_parser_init(common_params & params, llama_ex
         }
     ).set_sparam());
     add_opt(common_arg(
-        {"--top-nsigma"}, "N",
+        {"--top-nsigma", "--top-n-sigma"}, "N",
         string_format("top-n-sigma sampling (default: %.2f, -1.0 = disabled)", params.sampling.top_n_sigma),
         [](common_params & params, const std::string & value) {
             params.sampling.top_n_sigma = std::stof(value);
@@ -1634,7 +1634,7 @@ common_params_context common_params_parser_init(common_params & params, llama_ex
         }
     ).set_sparam());
     add_opt(common_arg(
-        {"--typical"}, "N",
+        {"--typical", "--typical-p"}, "N",
         string_format("locally typical sampling, parameter p (default: %.2f, 1.0 = disabled)", (double)params.sampling.typ_p),
         [](common_params & params, const std::string & value) {
             params.sampling.typ_p = std::stof(value);
Repository: ollama/ollama
Pull request: Remove unused runner CpuFeatures

The final implementation of #7499 removed dynamic vector requirements in favor of a simpler [filename based model](https://github.com/ollama/ollama/blob/main/runners/common.go#L125-L132), and this was left over logic that is no longer needed.

Changed files:
filename: llama/llama.go
patch: @@ -96,8 +96,6 @@ import (
 	"unsafe"
 )
 
-var CpuFeatures = ""
-
 func BackendInit() {
 	C.llama_backend_init()
 }

filename: make/Makefile.cpu
patch: @@ -2,7 +2,7 @@
 
 include make/common-defs.make
 
-CPU_GOFLAGS="-ldflags=-w -s \"-X=github.com/ollama/ollama/version.Version=$(VERSION)\" \"-X=github.com/ollama/ollama/llama.CpuFeatures=$(subst $(space),$(comma),$(TARGET_CPU_FLAGS))\" $(TARGET_LDFLAGS)"
+CPU_GOFLAGS="-ldflags=-w -s \"-X=github.com/ollama/ollama/version.Version=$(VERSION)\"  $(TARGET_LDFLAGS)"
 ifeq ($(ARCH),amd64)
 ifeq ($(origin CUSTOM_CPU_FLAGS),undefined)
 	RUNNERS = cpu_avx cpu_avx2

filename: make/Makefile.ollama
patch: @@ -6,7 +6,7 @@ exe: $(OLLAMA_EXE)
 dist_exe dist_ollama: $(DIST_OLLAMA_EXE)
 
 GO_DEPS=$(foreach dir,$(shell go list -deps -f '{{.Dir}}' . ),$(wildcard $(dir)/*.go))
-CPU_GOFLAGS="-ldflags=-w -s \"-X=github.com/ollama/ollama/version.Version=$(VERSION)\" \"-X=github.com/ollama/ollama/llama.CpuFeatures=$(subst $(space),$(comma),$(TARGET_CPU_FLAGS))\" $(EXTRA_GOLDFLAGS) $(TARGET_LDFLAGS)"
+CPU_GOFLAGS="-ldflags=-w -s \"-X=github.com/ollama/ollama/version.Version=$(VERSION)\" $(EXTRA_GOLDFLAGS) $(TARGET_LDFLAGS)"
 
 $(OLLAMA_EXE) $(DIST_OLLAMA_EXE): TARGET_CPU_FLAGS=$(CUSTOM_CPU_FLAGS)
 $(OLLAMA_EXE) $(DIST_OLLAMA_EXE): $(COMMON_SRCS) $(COMMON_HDRS) $(GO_DEPS)

filename: make/gpu.make
patch: @@ -5,7 +5,7 @@ dummy:
 	$(error This makefile is not meant to build directly, but instead included in other Makefiles that set required variables)
 endif
 
-GPU_GOFLAGS="-ldflags=-w -s \"-X=github.com/ollama/ollama/version.Version=$(VERSION)\" \"-X=github.com/ollama/ollama/llama.CpuFeatures=$(subst $(space),$(comma),$(GPU_RUNNER_CPU_FLAGS))\" $(EXTRA_GOLDFLAGS) $(TARGET_LDFLAGS)"
+GPU_GOFLAGS="-ldflags=-w -s \"-X=github.com/ollama/ollama/version.Version=$(VERSION)\" $(EXTRA_GOLDFLAGS) $(TARGET_LDFLAGS)"
 
 # TODO Unify how we handle dependencies in the dist/packaging and install flow
 # today, cuda is bundled, but rocm is split out.  Should split them each out by runner
Repository: facebook/react
Pull request: [DevTools] Make Toggle hover state more visible

This change adds a background color to Toggles to make them easier to see. This is especially important when DevTools are not in focus, and it's harder to see.

Test plan:
1. `yarn build:chrome:local`
2. Inspect components 
3. Hover over "Select an Element in page to inspect it"
4. Observe background change 


Changed files:
filename: packages/react-devtools-shared/src/devtools/constants.js
patch: @@ -27,6 +27,7 @@ export const THEME_STYLES: {[style: Theme | DisplayDensity]: any, ...} = {
     '--color-background-selected': '#0088fa',
     '--color-button-background': '#ffffff',
     '--color-button-background-focus': '#ededed',
+    '--color-button-background-hover': 'rgba(0, 0, 0, 0.2)',
     '--color-button': '#5f6673',
     '--color-button-disabled': '#cfd1d5',
     '--color-button-active': '#0088fa',
@@ -174,6 +175,7 @@ export const THEME_STYLES: {[style: Theme | DisplayDensity]: any, ...} = {
     '--color-background-selected': '#178fb9',
     '--color-button-background': '#282c34',
     '--color-button-background-focus': '#3d424a',
+    '--color-button-background-hover': 'rgba(255, 255, 255, 0.2)',
     '--color-button': '#afb3b9',
     '--color-button-active': '#61dafb',
     '--color-button-disabled': '#4f5766',

filename: packages/react-devtools-shared/src/devtools/views/Toggle.css
patch: @@ -20,10 +20,17 @@
   background: var(--color-button-background);
   color: var(--color-button);
 }
+
 .ToggleOff:hover {
   color: var(--color-button-hover);
 }
 
+.ToggleOn:hover,
+.ToggleOff:hover {
+ background-color: var(--color-button-background-hover);
+}
+
+
 .ToggleOn,
 .ToggleOn:active {
   color: var(--color-button-active);
Repository: vuejs/vue
Pull request: fix(transition-group): work around rollup tree shaking, fix #6792

<!--
Please make sure to read the Pull Request Guidelines:
https://github.com/vuejs/vue/blob/dev/.github/CONTRIBUTING.md#pull-request-guidelines
-->

<!-- PULL REQUEST TEMPLATE -->
<!-- (Update "[ ]" to "[x]" to check a box) -->

**What kind of change does this PR introduce?** (check at least one)

- [x] Bugfix
- [ ] Feature
- [ ] Code style update
- [ ] Refactor
- [ ] Build-related changes
- [ ] Other, please describe:

**Does this PR introduce a breaking change?** (check one)

- [ ] Yes
- [x] No

If yes, please describe the impact and migration path for existing applications:

**The PR fulfills these requirements:**

- [x] It's submitted to the `dev` branch for v2.x (or to a previous version branch), _not_ the `master` branch
- [x] When resolving a specific issue, it's referenced in the PR's title (e.g. `fix #xxx[,#xxx]`, where "xxx" is the issue number)
- [x] All tests are passing: https://github.com/vuejs/vue/blob/dev/.github/CONTRIBUTING.md#development-setup
- [ ] New/updated tests are included

If adding a **new feature**, the PR's description includes:
- [ ] A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

**Other information:**
fix #6792 

Changed files:
filename: src/platforms/web/runtime/components/transition-group.js
patch: @@ -101,8 +101,9 @@ export default {
     children.forEach(applyTranslation)
 
     // force reflow to put everything in position
-    const body: any = document.body
-    const f: number = body.offsetHeight // eslint-disable-line
+    // assign to this to avoid being removed in tree-shaking
+    // $flow-disable-line
+    this._reflow = document.body.offsetHeight
 
     children.forEach((c: VNode) => {
       if (c.data.moved) {
Repository: ollama/ollama
Pull request: Avoid underflow when FreeMemory < overhead

Fixes: #8011

Changed files:
filename: llm/memory.go
patch: @@ -182,7 +182,7 @@ func EstimateGPULayers(gpus []discover.GpuInfo, ggml *GGML, projectors []string,
 			gzo = gpuZeroOverhead
 		}
 		// Only include GPUs that can fit the graph, gpu minimum, the layer buffer and at least more layer
-		if (gpus[i].FreeMemory - overhead) < gzo+max(graphPartialOffload, graphFullOffload)+gpus[i].MinimumMemory+2*layerSize {
+		if gpus[i].FreeMemory < overhead+gzo+max(graphPartialOffload, graphFullOffload)+gpus[i].MinimumMemory+2*layerSize {
 			slog.Debug("gpu has too little memory to allocate any layers",
 				"id", gpus[i].ID,
 				"library", gpus[i].Library,
@@ -228,7 +228,7 @@ func EstimateGPULayers(gpus []discover.GpuInfo, ggml *GGML, projectors []string,
 		for j := len(gpusWithSpace); j > 0; j-- {
 			g := gpusWithSpace[i%j]
 			used := gpuAllocations[g.i] + max(graphPartialOffload, graphFullOffload)
-			if (g.g.FreeMemory - overhead) > used+layerSize {
+			if g.g.FreeMemory > overhead+used+layerSize {
 				gpuAllocations[g.i] += layerSize
 				layerCounts[g.i]++
 				layerCount++
@@ -251,7 +251,7 @@ func EstimateGPULayers(gpus []discover.GpuInfo, ggml *GGML, projectors []string,
 		for j := len(gpusWithSpace); j > 0; j-- {
 			g := gpusWithSpace[layerCount%j]
 			used := gpuAllocations[g.i] + max(graphPartialOffload, graphFullOffload)
-			if (g.g.FreeMemory - overhead) > used+memoryLayerOutput {
+			if g.g.FreeMemory > overhead+used+memoryLayerOutput {
 				gpuAllocations[g.i] += memoryLayerOutput
 				layerCounts[g.i]++
 				layerCount++
Repository: electron/electron
Pull request: fix: icon in Windows toast notification

#### Description of Change

Closes https://github.com/electron/electron/issues/48536.
Refs https://github.com/electron/electron/commit/f28d08ad8690d8b9ded8f33781ee990027fd16d0

The `image` attribute should have an ID. Also cleaned up and added checks for missing icons when saving an icon to the filesystem for use in a toast.

#### Checklist
<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

- [x] PR description included and stakeholders cc'd
- [x] `npm test` passes
- [x] [PR release notes](https://github.com/electron/clerk/blob/main/README.md) describe the change in a way relevant to app developers, and are [capitalized, punctuated, and past tense](https://github.com/electron/clerk/blob/main/README.md#examples).

#### Release Notes

Notes: Fixed an issue where icons didn't show up as expected on Windows Toast notifications.


Changed files:
filename: shell/browser/notifications/win/notification_presenter_win.cc
patch: @@ -30,9 +30,8 @@ namespace {
 bool SaveIconToPath(const SkBitmap& bitmap, const base::FilePath& path) {
   std::optional<std::vector<uint8_t>> png_data =
       gfx::PNGCodec::EncodeBGRASkBitmap(bitmap, false);
-  if (!png_data.has_value())
+  if (!png_data.has_value() || !png_data.value().size())
     return false;
-
   return base::WriteFile(path, png_data.value());
 }
 
@@ -64,8 +63,10 @@ bool NotificationPresenterWin::Init() {
 std::wstring NotificationPresenterWin::SaveIconToFilesystem(
     const SkBitmap& icon,
     const GURL& origin) {
-  std::string filename;
+  if (icon.drawsNothing())
+    return L"";
 
+  std::string filename;
   if (origin.is_valid()) {
     filename = base::MD5String(origin.spec()) + ".png";
   } else {
@@ -75,11 +76,11 @@ std::wstring NotificationPresenterWin::SaveIconToFilesystem(
 
   ScopedAllowBlockingForElectron allow_blocking;
   base::FilePath path = temp_dir_.GetPath().Append(base::UTF8ToWide(filename));
-  if (base::PathExists(path))
-    return path.value();
-  if (SaveIconToPath(icon, path))
-    return path.value();
-  return base::UTF8ToWide(origin.spec());
+
+  if (!SaveIconToPath(icon, path))
+    return L"";
+
+  return path.value();
 }
 
 Notification* NotificationPresenterWin::CreateNotificationObject(

filename: shell/browser/notifications/win/windows_toast_notification.cc
patch: @@ -353,6 +353,7 @@ std::u16string WindowsToastNotification::GetToastXml(
   // Optional icon as app logo override (small icon).
   if (!icon_path.empty()) {
     xml_writer.StartElement(kImage);
+    xml_writer.AddAttribute(kID, "1");
     xml_writer.AddAttribute(kPlacement, kAppLogoOverride);
     xml_writer.AddAttribute(kHintCrop, kHintCropNone);
     xml_writer.AddAttribute(kSrc, base::WideToUTF8(icon_path));
Repository: nodejs/node
Pull request: stream: fix isErrored/isWritable for WritableStreams

The underlying machinery for these was missed.

Changed files:
filename: lib/internal/webstreams/writablestream.js
patch: @@ -76,6 +76,8 @@ const {
 
 const {
   kIsClosedPromise,
+  kIsErrored,
+  kIsWritable,
   kControllerErrorFunction,
 } = require('internal/streams/utils');
 
@@ -183,6 +185,14 @@ class WritableStream {
       size);
   }
 
+  get [kIsErrored]() {
+    return this[kState].state === 'errored';
+  }
+
+  get [kIsWritable]() {
+    return this[kState].state === 'writable';
+  }
+
   /**
    * @readonly
    * @type {boolean}

filename: test/parallel/test-whatwg-writablestream.js
patch: @@ -4,6 +4,8 @@
 const common = require('../common');
 const assert = require('assert');
 
+const { isErrored, isWritable } = require('stream');
+
 const {
   WritableStream,
   WritableStreamDefaultController,
@@ -171,6 +173,27 @@ class Sink {
   }));
 }
 
+{
+  const stream = new WritableStream();
+  assert.strictEqual(isWritable(stream), true);
+  stream.close().then(common.mustCall(() => {
+    assert.strictEqual(isWritable(stream), false);
+  }));
+}
+
+{
+  const stream = new WritableStream({
+    write: common.mustCall((chunk, controller) => {
+      controller.error(new Error());
+    })
+  });
+  const writer = stream.getWriter();
+  assert.strictEqual(isErrored(stream), false);
+  writer.write().then(common.mustCall(() => {
+    assert.strictEqual(isErrored(stream), true);
+  }));
+}
+
 {
   assert.throws(() => Reflect.get(WritableStream.prototype, 'locked', {}), {
     code: 'ERR_INVALID_THIS',
Repository: huggingface/transformers
Pull request: fix FastSpeech2ConformerTokenizer crash in tokenize


- tokenizers: @ArthurZucker and @itazap

how to reproduce:
```
from transformers import FastSpeech2ConformerTokenizer
tokenizer = FastSpeech2ConformerTokenizer.from_pretrained("espnet/fastspeech2_conformer")
text = "Test that this generates speech"
input_ids = tokenizer(text, return_tensors="pt")
```

Traceback (most recent call last):
  File "/transformers/bug.py", line 4, in <module>
    input_ids = tokenizer(text, return_tensors="pt")
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/transformers/src/transformers/tokenization_utils_base.py", line 2566, in __call__
    encodings = self._encode_plus(
                ^^^^^^^^^^^^^^^^^^
  File "/transformers/src/transformers/tokenization_python.py", line 814, in _encode_plus
    return self.prepare_for_model(
           ^^^^^^^^^^^^^^^^^^^^^^^
  File "/transformers/src/transformers/tokenization_python.py", line 1193, in prepare_for_model
    encoded_inputs = self.pad(
                     ^^^^^^^^^
  File "/transformers/src/transformers/tokenization_utils_base.py", line 2742, in pad
    raise ValueError(
ValueError: type of None unknown: <class 'NoneType'>. Should be one of a python, numpy, or pytorch object.




Changed files:
filename: src/transformers/models/fastspeech2_conformer/tokenization_fastspeech2_conformer.py
patch: @@ -79,6 +79,7 @@ def __init__(
             unk_token=unk_token,
             pad_token=pad_token,
             should_strip_spaces=should_strip_spaces,
+            special_tokens_pattern="none",
             **kwargs,
         )
Repository: vercel/next.js
Pull request: Update Rspack production test manifest

This auto-generated PR updates the production integration test manifest used when testing Rspack.

Changed files:
filename: test/rspack-build-tests-manifest.json
patch: @@ -2299,6 +2299,15 @@
     "flakey": [],
     "runtimeError": false
   },
+  "test/e2e/app-dir/cdn-cache-control-header/cdn-cache-control-header.test.ts": {
+    "passed": [
+      "cdn-cache-control-header should use custom CDN cache control header name from experimental config"
+    ],
+    "failed": [],
+    "pending": [],
+    "flakey": [],
+    "runtimeError": false
+  },
   "test/e2e/app-dir/client-module-with-package-type/index.test.ts": {
     "passed": [
       "esm-client-module-without-exports \"type\": \"commonjs\" in package.json should render without errors: import cjs",
@@ -2667,6 +2676,19 @@
     "flakey": [],
     "runtimeError": false
   },
+  "test/e2e/app-dir/default-error-page-ui/default-error-page-ui.test.ts": {
+    "passed": [
+      "app dir - default error page UI should display server error page with Error reference",
+      "app dir - default error page UI should have left-aligned text in error page",
+      "app dir - default error page UI should have proper styling in the default error page",
+      "app dir - default error page UI should reload the page when Reload page button is clicked",
+      "app dir - default error page UI should render client error page with correct UI elements"
+    ],
+    "failed": [],
+    "pending": [],
+    "flakey": [],
+    "runtimeError": false
+  },
   "test/e2e/app-dir/dev-overlay/portal-not-affect-parent/portal-not-affect-parent.test.ts": {
     "passed": [
       "dev-overlay - portal-not-affect-parent should not affect parent display"
@@ -7643,6 +7665,7 @@
       "use-cache can reference server actions in \"use cache\" functions",
       "use-cache renders the not-found page when `notFound()` is used",
       "use-cache shares caches between the page/layout and generateMetadata",
+      "use-cache should NOT update immediately after revalidateTag with profile (stale-while-revalidate)",
       "use-cache should be able to revalidate a page using revalidateTag",
       "use-cache should cache complex args",
       "use-cache should cache fetch without no-store",
@@ -22158,6 +22181,15 @@
     "flakey": [],
     "runtimeError": false
   },
+  "test/production/typescript-build-output/typescript-build-output.test.ts": {
+    "passed": [
+      "typescript-build-output should show \"Finished TypeScript\" message in build output"
+    ],
+    "failed": [],
+    "pending": [],
+    "flakey": [],
+    "runtimeError": false
+  },
   "test/production/typescript-checked-side-effect-imports/index.test.ts": {
     "passed": [
       "Imports of server/client-only with noUncheckedSideEffectImports Should build without typescript errors"