helloadhavan/github_issues huggingface dataset:
Repository: vuejs/vue
Pull request: fix: check js assets more accurate in ssr webpack plugin

<!--
Please make sure to read the Pull Request Guidelines:
https://github.com/vuejs/vue/blob/dev/.github/CONTRIBUTING.md#pull-request-guidelines
-->

<!-- PULL REQUEST TEMPLATE -->
<!-- (Update "[ ]" to "[x]" to check a box) -->

**What kind of change does this PR introduce?** (check at least one)

- [x] Bugfix
- [ ] Feature
- [ ] Code style update
- [ ] Refactor
- [ ] Build-related changes
- [ ] Other, please describe:

**Does this PR introduce a breaking change?** (check one)

- [ ] Yes
- [x] No

**Other information:**

If we config `chunkName` as `'[name].js?v=[chunkhash]'`, the previous regex cannot match the js assets in webpack plugin, so use `isJS` to perfect match files

Pr will aslo resove https://github.com/nuxt/nuxt.js/issues/3387

Changed files:
filename: src/server/webpack-plugin/server.js
patch: @@ -43,7 +43,7 @@ export default class VueSSRServerPlugin {
       }
 
       stats.assets.forEach(asset => {
-        if (asset.name.match(/\.js$/)) {
+        if (isJS(asset.name)) {
           bundle.files[asset.name] = compilation.assets[asset.name].source()
         } else if (asset.name.match(/\.js\.map$/)) {
           bundle.maps[asset.name.replace(/\.map$/, '')] = JSON.parse(compilation.assets[asset.name].source())
Repository: facebook/react
Pull request: Disable moveBefore experiment

There seems to be some bugs still to work out in Chrome. See #33187.

Additionally, since you can't really rely on this function existing across browsers, it's hard to depend on its behavior anyway. In fact, you now have a source of inconsistent behaviors across browsers to deal with.

Ideally it would also be more widely spread in fake DOM implementations like JSDOM so that we can use it unconditionally. #33177.

We still want to enable this since it's a great feature but maybe not until it's more widely available cross-browsers with fewer bugs.

Changed files:
filename: packages/shared/ReactFeatureFlags.js
patch: @@ -194,7 +194,7 @@ export const disableLegacyContext = true;
 export const disableLegacyContextForFunctionComponents = true;
 
 // Enable the moveBefore() alternative to insertBefore(). This preserves states of moves.
-export const enableMoveBefore = __EXPERIMENTAL__;
+export const enableMoveBefore = false;
 
 // Disabled caching behavior of `react/cache` in client runtimes.
 export const disableClientCache = true;
Repository: electron/electron
Pull request: build: roll build-tools SHA to `4430e4a`

Fixes

```
npm error HEAD is now at a5d9f90 fix: macOS SDK regex on line breaks (#760)
npm error Failed to install build-tools:  Error: ENOENT: no such file or directory, scandir '/github/home/.electron_build_tools/.yarn/releases'
npm error     at readdirSync (node:fs:1583:26)
npm error     at install (file:///usr/lib/node_modules/@electron/build-tools/preinstall.js:57:23)
npm error     at file:///usr/lib/node_modules/@electron/build-tools/preinstall.js:81:1
npm error     at ModuleJob.run (node:internal/modules/esm/module_job:329:25)
npm error     at async onImport.tracePromise.__proto__ (node:internal/modules/esm/loader:644:26)
npm error     at async asyncRunEntryPointWithESMLoader (node:internal/modules/run_main:117:5) {
npm error   errno: -2,
npm error   code: 'ENOENT',
npm error   syscall: 'scandir',
npm error   path: '/github/home/.electron_build_tools/.yarn/releases'
npm error }
```

build-tools was pinned to a SHA prior to yarn@4 migration.

---

Notes: none

Changed files:
filename: .github/actions/install-build-tools/action.yml
patch: @@ -15,7 +15,7 @@ runs:
         git config --global core.preloadindex true
         git config --global core.longpaths true
       fi
-      export BUILD_TOOLS_SHA=a5d9f9052dcc36ee88bef5c8b13acbefd87b7d8d
+      export BUILD_TOOLS_SHA=4430e4a505e0f4fa2a41b707a10a36f780bbdd26
       npm i -g @electron/build-tools
       # Update depot_tools to ensure python
       e d update_depot_tools
Repository: huggingface/transformers
Pull request: Fix generation config validation

# What does this PR do?

Fixes an issue reported by @BenjaminBossan . The default of caching was `True` so we assume that new default of `None` is also `True`. So we need to check only if `False` is set explicitly by the user

```python
from transformers import AutoModelForCausalLM

model_id = 'hf-internal-testing/tiny-random-Gemma3ForCausalLM'
model = AutoModelForCausalLM.from_pretrained(model_id)
tmp_dirname = "/tmp/save-gemma3"
model.save_pretrained(tmp_dirname)

```


Changed files:
filename: src/transformers/generation/configuration_utils.py
patch: @@ -687,7 +687,7 @@ def validate(self, strict=False):
                 )
 
         # 2.5. check cache-related arguments
-        if self.use_cache is not True:
+        if self.use_cache is False:
             # In this case, all cache-related arguments should be unset. However, since `use_cache=False` is often used
             # passed to `generate` directly to hot-fix cache issues, let's raise a warning instead of an error
             # (otherwise a user might need to overwrite several parameters).

filename: tests/generation/test_utils.py
patch: @@ -2686,6 +2686,13 @@ def test_generation_config_defaults(self):
         out = model.generate(input_ids, generation_config=generation_config)
         self.assertTrue(len(out[0]) == 20)  # generated max_length=20 tokens, not 50!
 
+        # Lastly try saving to make sure no errors are raised about
+        # "generation params in config" or during config validation (#43175)
+        with tempfile.TemporaryDirectory() as tmpdirname:
+            model.generation_config.cache_implementation = "dynamic"
+            model.generation_config.use_cache = None
+            model.save_pretrained(tmpdirname)
+
     # TODO joao, manuel: remove in v4.62.0
     @slow
     def test_diverse_beam_search(self):
Repository: vercel/next.js
Pull request: fix: capture promisified setImmediate separately

### What?

  Capture `setImmediate[promisify.custom]` at module initialization instead of lazily accessing it when needed. 

```
    RangeError: Maximum call stack size exceeded

      at patchedSetImmediatePromise (node_modules/.pnpm/next@16.1.1_@babel+core@7.28.5_react-dom@19.2.3_react@19.2.3__react@19.2.3/node_modules/next/src/server/node-environment-extensions/fast-set-immediate.external.ts:626:27)
      at originalPromisify (node_modules/.pnpm/next@16.1.1_@babel+core@7.28.5_react-dom@19.2.3_react@19.2.3__react@19.2.3/node_modules/next/src/server/node-environment-extensions/fast-set-immediate.external.ts:627:12)
```

  This was discovered upgrading from `16.0.10` to `16.1.0`

  ### Why?

  When `util.promisify(setImmediate)` is called and `currentExecution === null`, the code was accessing `originalSetImmediate[promisify.custom]` at call time. However, `promisify.custom` can get lost or return `undefined` after the module patches `setImmediate`, causing `promisify(setImmediate)` to fail. Specifically, when used with `jest`.

  Reproduction: https://github.com/jgeschwendt/nextjs-setimmediate-promisify-repro
  - Failing: https://github.com/jgeschwendt/nextjs-setimmediate-promisify-repro/actions/runs/20864170776
  - Passing (with fix): https://github.com/jgeschwendt/nextjs-setimmediate-promisify-repro/actions/runs/20864380068
    - https://github.com/jgeschwendt/nextjs-setimmediate-promisify-repro/pull/1

  ### How?

  Move the capture of `originalSetImmediate[promisify.custom]` to module initialization time (alongside `originalSetImmediate`, `originalClearImmediate`, and `originalNextTick`), ensuring the original promisified implementation is preserved before any patching occurs.

Changed files:
filename: packages/next/src/server/node-environment-extensions/fast-set-immediate.external.ts
patch: @@ -22,6 +22,9 @@ let currentExecution: Execution | null = null
 const originalSetImmediate = globalThis.setImmediate
 const originalClearImmediate = globalThis.clearImmediate
 const originalNextTick = process.nextTick
+const originalSetImmediatePromisify: (typeof setImmediate)['__promisify__'] =
+  // @ts-expect-error: the types for `promisify.custom` are strange
+  originalSetImmediate[promisify.custom]
 
 export { originalSetImmediate as unpatchedSetImmediate }
 
@@ -621,10 +624,7 @@ function patchedSetImmediatePromise<T = void>(
   options?: import('node:timers').TimerOptions
 ): Promise<T> {
   if (currentExecution === null) {
-    const originalPromisify: (typeof setImmediate)['__promisify__'] =
-      // @ts-expect-error: the types for `promisify.custom` are strange
-      originalSetImmediate[promisify.custom]
-    return originalPromisify(value, options)
+    return originalSetImmediatePromisify(value, options)
   }
 
   return new Promise<T>((resolve, reject) => {
Repository: nodejs/node
Pull request: fs: fix rmSync to handle non-ASCII characters

This is a fresh version of PR https://github.com/nodejs/node/pull/56934

Update fs.rmSync to properly handle file paths that include non-ASCII characters. This change prevents crashes and errors when attempting to delete files with international or special characters in their names.

Add a test in test/parallel to ensure that files with non-ASCII characters can be deleted without issues. This covers cases that previously caused unexpected behavior or crashes on certain file systems.

Fixes: https://github.com/nodejs/node/issues/56049

If this gets merged, I will be working on the additional errors part.

@joyeecheung Please review this. Thank you!

Changed files:
filename: src/node_file.cc
patch: @@ -1634,7 +1634,7 @@ static void RmSync(const FunctionCallbackInfo<Value>& args) {
   ToNamespacedPath(env, &path);
   THROW_IF_INSUFFICIENT_PERMISSIONS(
       env, permission::PermissionScope::kFileSystemWrite, path.ToStringView());
-  auto file_path = std::filesystem::path(path.ToStringView());
+  auto file_path = path.ToPath();
   std::error_code error;
   auto file_status = std::filesystem::symlink_status(file_path, error);
 
@@ -1649,8 +1649,7 @@ static void RmSync(const FunctionCallbackInfo<Value>& args) {
   // File is a directory and recursive is false
   if (file_status.type() == std::filesystem::file_type::directory &&
       !recursive) {
-    return THROW_ERR_FS_EISDIR(
-        isolate, "Path is a directory: %s", file_path.c_str());
+    return THROW_ERR_FS_EISDIR(isolate, "Path is a directory: %s", path);
   }
 
   // Allowed errors are:

filename: test/parallel/test-fs-rmSync-special-char.js
patch: @@ -0,0 +1,32 @@
+'use strict';
+require('../common');
+const tmpdir = require('../common/tmpdir');
+const assert = require('node:assert');
+const fs = require('node:fs');
+const path = require('node:path');
+
+// This test ensures that fs.rmSync handles non-ASCII characters in file paths,
+// and that errors contain correctly encoded paths and err.path values.
+
+tmpdir.refresh(); // Prepare a clean temporary directory
+
+// Define paths with non-ASCII characters
+const dirPath = path.join(tmpdir.path, '速_dir');
+const filePath = path.join(tmpdir.path, '速.txt');
+
+// Create a directory and a file with non-ASCII characters
+fs.mkdirSync(dirPath);
+fs.writeFileSync(filePath, 'This is a test file with special characters.');
+fs.rmSync(filePath);
+assert.strictEqual(fs.existsSync(filePath), false);
+
+// Ensure rmSync throws an error when trying to remove a directory without recursive
+assert.throws(() => {
+  fs.rmSync(dirPath, { recursive: false });
+}, (err) => {
+  // Assert the error code and check that the error message includes the correct non-ASCII path
+  assert.strictEqual(err.code, 'ERR_FS_EISDIR');
+  assert(err.message.includes(dirPath), 'Error message should include the directory path');
+  assert.strictEqual(err.path, dirPath);
+  return true;
+});
Repository: facebook/react
Pull request: [eslint] Add an option to require dependencies on effect hooks


Summary:

To prepare for automatic effect dependencies, some codebases may want to codemod
existing useEffect calls with no deps to include an explicit undefined second argument
in order to preserve the "run on every render" behavior. In sufficiently large codebases,
this may require a temporary enforcement period where all effects provide an explicit
dependencies argument.

Outside of migration, relying on a component to render can lead to real bugs,
especially when working with memoization.


Changed files:
filename: packages/eslint-plugin-react-hooks/__tests__/ESLintRuleExhaustiveDeps-test.js
patch: @@ -8344,6 +8344,23 @@ const testsTypescript = {
         },
       ],
     },
+    {
+      code: normalizeIndent`
+        function MyComponent(props) {
+          useEffect(() => {
+            console.log(props.foo);
+          });
+        }
+      `,
+      options: [{requireExplicitEffectDeps: true}],
+      errors: [
+        {
+          message:
+            'React Hook useEffect always requires dependencies. Please add a dependency array or an explicit `undefined`',
+          suggestions: undefined,
+        },
+      ],
+    },
   ],
 };
 

filename: packages/eslint-plugin-react-hooks/src/rules/ExhaustiveDeps.ts
patch: @@ -67,6 +67,9 @@ const rule = {
               type: 'string',
             },
           },
+          requireExplicitEffectDeps: {
+            type: 'boolean',
+          }
         },
       },
     ],
@@ -90,10 +93,13 @@ const rule = {
         ? rawOptions.experimental_autoDependenciesHooks
         : [];
 
+    const requireExplicitEffectDeps: boolean = rawOptions && rawOptions.requireExplicitEffectDeps || false;
+
     const options = {
       additionalHooks,
       experimental_autoDependenciesHooks,
       enableDangerousAutofixThisMayCauseInfiniteLoops,
+      requireExplicitEffectDeps,
     };
 
     function reportProblem(problem: Rule.ReportDescriptor) {
@@ -1340,6 +1346,15 @@ const rule = {
         return;
       }
 
+      if (!maybeNode && isEffect && options.requireExplicitEffectDeps) {
+        reportProblem({
+          node: reactiveHook,
+          message:
+            `React Hook ${reactiveHookName} always requires dependencies. ` +
+            `Please add a dependency array or an explicit \`undefined\``
+        });
+      }
+
       const isAutoDepsHook =
         options.experimental_autoDependenciesHooks.includes(reactiveHookName);
Repository: facebook/react
Pull request: Fix incorrect use of NoLanes in executionContext check

## Summary

This PR fixes a likely incorrect condition in the `scheduleUpdateOnFiber` function inside `ReactFiberWorkLoop.js`.

Previously, the code checked:

```js
(executionContext & RenderContext) !== NoLanes
````

However, `NoLanes` is part of the lane priority system, not the execution context flags. The intent here seems to be to detect whether the current execution context includes `RenderContext`, which should be compared against `NoContext`, not `NoLanes`.

This fix replaces `NoLanes` with `NoContext` for semantic correctness and consistency with other checks throughout the codebase.

**Fixes [[#33169](https://github.com/facebook/react/issues/33169)](https://github.com/facebook/react/issues/33169)**

---

## How did you test this change?

I ran the following commands to validate correctness and ensure nothing was broken:

* `yarn lint`
* `yarn linc`
* `yarn test`
* `yarn test --prod`
* `yarn flow`
* `yarn prettier`

All checks passed. Since this is a minor internal logic fix and doesn't change public behavior or APIs, no additional tests are necessary at this time.



Changed files:
filename: packages/react-reconciler/src/ReactFiberWorkLoop.js
patch: @@ -908,7 +908,7 @@ export function scheduleUpdateOnFiber(
   markRootUpdated(root, lane);
 
   if (
-    (executionContext & RenderContext) !== NoLanes &&
+    (executionContext & RenderContext) !== NoContext &&
     root === workInProgressRoot
   ) {
     // This update was dispatched during the render phase. This is a mistake
Repository: ollama/ollama
Pull request: docker: upgrade rocm to 6.3.3

This patch upgrades the rocm version to the latest available for consumption.

Fixes: #7941

Changed files:
filename: Dockerfile
patch: @@ -2,17 +2,17 @@
 
 ARG FLAVOR=${TARGETARCH}
 
-ARG ROCMVERSION=6.1.2
+ARG ROCMVERSION=6.3.3
 ARG JETPACK5VERSION=r35.4.1
 ARG JETPACK6VERSION=r36.2.0
 ARG CMAKEVERSION=3.31.2
 
-FROM --platform=linux/amd64 rocm/dev-centos-7:${ROCMVERSION}-complete AS base-amd64
+FROM --platform=linux/amd64 rocm/dev-almalinux-8:${ROCMVERSION}-complete AS base-amd64
 RUN sed -i -e 's/mirror.centos.org/vault.centos.org/g' -e 's/^#.*baseurl=http/baseurl=http/g' -e 's/^mirrorlist=http/#mirrorlist=http/g' /etc/yum.repos.d/*.repo \
-    && yum install -y yum-utils devtoolset-10-gcc devtoolset-10-gcc-c++ \
-    && yum-config-manager --add-repo https://developer.download.nvidia.com/compute/cuda/repos/rhel7/x86_64/cuda-rhel7.repo \
+    && yum install -y yum-utils gcc-toolset-11-gcc gcc-toolset-11-gcc-c++ \
+    && yum-config-manager --add-repo https://developer.download.nvidia.com/compute/cuda/repos/rhel8/x86_64/cuda-rhel8.repo \
     && curl -s -L https://github.com/ccache/ccache/releases/download/v4.10.2/ccache-4.10.2-linux-x86_64.tar.xz | tar -Jx -C /usr/local/bin --strip-components 1
-ENV PATH=/opt/rh/devtoolset-10/root/usr/bin:/opt/rh/devtoolset-11/root/usr/bin:$PATH
+ENV PATH=/opt/rh/gcc-toolset-11/root/usr/bin:$PATH
 
 FROM --platform=linux/arm64 rockylinux:8 AS base-arm64
 # install epel-release for ccache
@@ -29,9 +29,7 @@ COPY ml/backend/ggml/ggml ml/backend/ggml/ggml
 ENV LDFLAGS=-s
 
 FROM base AS cpu
-# amd64 uses gcc which requires devtoolset-11 for AVX extensions while arm64 uses clang
-RUN if [ "$(uname -m)" = "x86_64" ]; then yum install -y devtoolset-11-gcc devtoolset-11-gcc-c++; fi
-ENV PATH=/opt/rh/devtoolset-11/root/usr/bin:$PATH
+# amd64 uses gcc which requires gcc-toolset-11 for AVX extensions while arm64 uses clang
 RUN --mount=type=cache,target=/root/.ccache \
     cmake --preset 'CPU' \
         && cmake --build --parallel --preset 'CPU' \
@@ -104,7 +102,7 @@ COPY --from=cuda-12 dist/lib/ollama/cuda_v12 /lib/ollama/cuda_v12
 COPY --from=jetpack-5 dist/lib/ollama/cuda_v11 lib/ollama/cuda_jetpack5
 COPY --from=jetpack-6 dist/lib/ollama/cuda_v12 lib/ollama/cuda_jetpack6
 
-FROM --platform=linux/arm64 scratch AS rocm
+FROM scratch AS rocm
 COPY --from=rocm-6 dist/lib/ollama/rocm /lib/ollama/rocm
 
 FROM ${FLAVOR} AS archive
Repository: ollama/ollama
Pull request: Updating the link suggested by PR review

Requested by PR review https://github.com/ollama/ollama/pull/9336

Changed files:
filename: docs/development.md
patch: @@ -41,7 +41,7 @@ Install prerequisites:
 - [CMake](https://cmake.org/download/)
 - [Visual Studio 2022](https://visualstudio.microsoft.com/downloads/) including the Native Desktop Workload
 - (Optional) AMD GPU support
-    - [ROCm](https://rocm.github.io/install.html)
+    - [ROCm](https://rocm.docs.amd.com/en/latest/)
     - [Ninja](https://github.com/ninja-build/ninja/releases)
 - (Optional) NVIDIA GPU support
     - [CUDA SDK](https://developer.nvidia.com/cuda-downloads?target_os=Windows&target_arch=x86_64&target_version=11&target_type=exe_network)
@@ -127,4 +127,4 @@ Ollama looks for acceleration libraries in the following paths relative to the `
 * `.` (macOS)
 * `build/lib/ollama` (for development)
 
-If the libraries are not found, Ollama will not run with any acceleration libraries.
\ No newline at end of file
+If the libraries are not found, Ollama will not run with any acceleration libraries.
Repository: electron/electron
Pull request: feat: import shared texture supports p010le

#### Description of Change

This PR adds support for the p010le pixel format to SharedTextureImportTextureInfo.
p010le is a 4:2:0 10-bit YUV format commonly used by video decoders and GPU pipelines.

cc: @reitowo

#### Checklist
- [x] PR description included and stakeholders cc'd
- [x] `npm test` passes
- [x] relevant API documentation, tutorials, and examples are updated and follow the [documentation style guide](https://github.com/electron/electron/blob/main/docs/development/style-guide.md)
- [x] [PR release notes](https://github.com/electron/clerk/blob/main/README.md) describe the change in a way relevant to app developers, and are [capitalized, punctuated, and past tense](https://github.com/electron/clerk/blob/main/README.md#examples).

#### Release Notes

Notes: Added support for importing shared textures using the p010le 10-bit YUV pixel format.


Changed files:
filename: docs/api/structures/shared-texture-import-texture-info.md
patch: @@ -5,6 +5,7 @@
   * `rgba` - 32bpp RGBA (byte-order), 1 plane.
   * `rgbaf16` - Half float RGBA, 1 plane.
   * `nv12` - 12bpp with Y plane followed by a 2x2 interleaved UV plane.
+  * `p010le` - 4:2:0 10-bit YUV (little-endian), Y plane followed by a 2x2 interleaved UV plane.
 * `colorSpace` [ColorSpace](color-space.md) (optional) - The color space of the texture.
 * `codedSize` [Size](size.md) - The full dimensions of the shared texture.
 * `visibleRect` [Rectangle](rectangle.md) (optional) - A subsection of [0, 0, codedSize.width, codedSize.height]. In common cases, it is the full section area.

filename: shell/common/api/electron_api_shared_texture.cc
patch: @@ -127,6 +127,8 @@ std::string TransferVideoPixelFormatToString(media::VideoPixelFormat format) {
       return "rgbaf16";
     case media::PIXEL_FORMAT_NV12:
       return "nv12";
+    case media::PIXEL_FORMAT_P010LE:
+      return "p010le";
     default:
       NOTREACHED();
   }
@@ -569,6 +571,8 @@ struct Converter<ImportSharedTextureInfo> {
         out->pixel_format = media::PIXEL_FORMAT_RGBAF16;
       else if (pixel_format_str == "nv12")
         out->pixel_format = media::PIXEL_FORMAT_NV12;
+      else if (pixel_format_str == "p010le")
+        out->pixel_format = media::PIXEL_FORMAT_P010LE;
       else
         return false;
     }