Repository: nodejs/node
Pull request: sqlite: improve error messages for tag store

When using SQLite tag store functions (`sql.get`, `sql.run`, etc.), preparation errors now show descriptive SQLite error messages instead of the generic 'Failed to prepare statement' message.

The tag store's `GetOrCreateStatement` function now passes the database object to THROW_ERR_SQLITE_ERROR, thus retrieving the actual error message from `sqlite3_errmsg()`, and matching the behavior of the regular db.prepare() method.

Included an appropriate test as well.

Fixes: #61051  

EDIT: Since this is my first PR to a major open source project, I would appreciate any sort of guidance given. Thank you!

<!--
Before submitting a pull request, please read:

- the CONTRIBUTING guide at https://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md
- the commit message formatting guidelines at
  https://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#commit-message-guidelines

For code changes:
1. Include tests for any bug fixes or new features.
2. Update documentation if relevant.
3. Ensure that `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes.

If you believe this PR should be highlighted in the Node.js CHANGELOG
please add the `notable-change` label.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.
-->


Changed files:
filename: src/node_sqlite.cc
patch: @@ -2946,7 +2946,7 @@ BaseObjectPtr<StatementSync> SQLTagStore::PrepareStatement(
         session->database_->connection_, sql.data(), sql.size(), &s, 0);
 
     if (r != SQLITE_OK) {
-      THROW_ERR_SQLITE_ERROR(isolate, "Failed to prepare statement");
+      THROW_ERR_SQLITE_ERROR(isolate, session->database_.get());
       sqlite3_finalize(s);
       return BaseObjectPtr<StatementSync>();
     }

filename: test/parallel/test-sqlite-template-tag.js
patch: @@ -102,3 +102,25 @@ test('TagStore capacity, size, and clear', () => {
 test('sql.db returns the associated DatabaseSync instance', () => {
   assert.strictEqual(sql.db, db);
 });
+
+test('sql error messages are descriptive', () => {
+  assert.strictEqual(sql.run`INSERT INTO foo (text) VALUES (${'test'})`.changes, 1);
+
+  // Test with non-existent column
+  assert.throws(() => {
+    const result = sql.get`SELECT nonexistent_column FROM foo`;
+    assert.fail(`Expected error, got: ${JSON.stringify(result)}`);
+  }, {
+    code: 'ERR_SQLITE_ERROR',
+    message: /no such column/i,
+  });
+
+  // Test with non-existent table
+  assert.throws(() => {
+    const result = sql.get`SELECT * FROM nonexistent_table`;
+    assert.fail(`Expected error, got: ${JSON.stringify(result)}`);
+  }, {
+    code: 'ERR_SQLITE_ERROR',
+    message: /no such table/i,
+  });
+});