helloadhavan/github_issues huggingface dataset:
Repository: ggml-org/llama.cpp
Pull request: common : fix incorrect uses of stoul

Fixes #20308

Changed files:
filename: common/arg.cpp
patch: @@ -2427,11 +2427,11 @@ common_params_context common_params_parser_init(common_params & params, llama_ex
                 );
             }
             if (split_arg.size() == 1) {
-                std::fill(params.fit_params_target.begin(), params.fit_params_target.end(), std::stoul(split_arg[0]) * 1024*1024);
+                std::fill(params.fit_params_target.begin(), params.fit_params_target.end(), std::stoull(split_arg[0]) * 1024*1024);
                 return;
             }
             for (size_t i = 0; i < split_arg.size(); i++) {
-                params.fit_params_target[i] = std::stoul(split_arg[i]) * 1024*1024;
+                params.fit_params_target[i] = std::stoull(split_arg[i]) * 1024*1024;
             }
         }
     ).set_env("LLAMA_ARG_FIT_TARGET"));

filename: common/json-schema-to-grammar.cpp
patch: @@ -790,7 +790,7 @@ class common_schema_converter {
                             } else if (target.is_array()) {
                                 size_t sel_index;
                                 try {
-                                    sel_index = std::stoul(sel);
+                                    sel_index = std::stoull(sel);
                                 } catch (const std::invalid_argument & e) {
                                     sel_index = target.size();
                                 }

filename: src/llama-grammar.cpp
patch: @@ -601,7 +601,7 @@ const char * llama_grammar_parser::parse_sequence(
                 throw std::runtime_error(std::string("expecting an int at ") + pos);
             }
             const char * int_end = parse_int(pos);
-            uint64_t min_times = std::stoul(std::string(pos, int_end - pos));
+            uint64_t min_times = std::stoull(std::string(pos, int_end - pos));
             pos = parse_space(int_end, is_nested);
 
             uint64_t max_times = UINT64_MAX; // default: no max limit
@@ -614,7 +614,7 @@ const char * llama_grammar_parser::parse_sequence(
 
                 if (is_digit_char(*pos)) {
                     const char * int_end = parse_int(pos);
-                    max_times = std::stoul(std::string(pos, int_end - pos));
+                    max_times = std::stoull(std::string(pos, int_end - pos));
                     pos = parse_space(int_end, is_nested);
                 }
Repository: facebook/react
Pull request: [sync] Fix noop for xplat

Noop detection for xplat syncs broke because `eslint-plugin-react-hooks` uses versions like:

- `0.0.0-experimental-d85f86cf-20250514`

But xplat expects them to be of the form:

- `19.2.0-native-fb-63d664b2-20250514`

This PR fixes the noop by ignoring `eslint-plugin-react-hooks/package.json` changes. This means we won't create a sync if only that package.json changes, but that should be rare and we can follow up with better detection if needed.

[Example failed action](https://github.com/facebook/react/actions/runs/15032346805/job/42247414406):

<img width="1031" alt="Screenshot 2025-05-15 at 11 31 17 AM" src="https://github.com/user-attachments/assets/d902079c-1afe-4e18-af1d-25e60e28929e" />

I believe the regression was caused by https://github.com/facebook/react/pull/33104


Changed files:
filename: .github/workflows/runtime_commit_artifacts.yml
patch: @@ -332,10 +332,10 @@ jobs:
           git --no-pager diff -U0 --cached | grep '^[+-]' | head -n 100
           echo "===================="
           # Ignore REVISION or lines removing @generated headers.
-          if git diff --cached ':(exclude)*REVISION' | grep -vE "^(@@|diff|index|\-\-\-|\+\+\+|\- \* @generated SignedSource)" | grep "^[+-]" > /dev/null; then
+          if git diff --cached ':(exclude)*REVISION' ':(exclude)*/eslint-plugin-react-hooks/package.json' | grep -vE "^(@@|diff|index|\-\-\-|\+\+\+|\- \* @generated SignedSource)" | grep "^[+-]" > /dev/null; then
             echo "Changes detected"
             echo "===== Changes ====="
-            git --no-pager diff --cached ':(exclude)*REVISION' | grep -vE "^(@@|diff|index|\-\-\-|\+\+\+|\- \* @generated SignedSource)" | grep "^[+-]" | head -n 50
+            git --no-pager diff --cached ':(exclude)*REVISION' ':(exclude)*/eslint-plugin-react-hooks/package.json' | grep -vE "^(@@|diff|index|\-\-\-|\+\+\+|\- \* @generated SignedSource)" | grep "^[+-]" | head -n 50
             echo "==================="
             echo "should_commit=true" >> "$GITHUB_OUTPUT"
           else
Repository: huggingface/transformers
Pull request: Fix failing `DebertaV2ModelIntegrationTest`

# What does this PR do?
Fixes this failing [DebertaV2ModelIntegrationTest](https://github.com/huggingface/transformers/actions/runs/20706072009/job/59437072475#step:14:1608).

<img width="1327" height="147" alt="image" src="https://github.com/user-attachments/assets/6cef8469-03ae-4e46-b533-ec94627f4dd9" />

## Before submitting
- [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
- [x] Did you read the [contributor guideline](https://github.com/huggingface/transformers/blob/main/CONTRIBUTING.md#create-a-pull-request),
      Pull Request section?
- [ ] Was this discussed/approved via a Github issue or the [forum](https://discuss.huggingface.co/)? Please add a link
      to it if that's the case.
- [ ] Did you make sure to update the documentation with your changes? Here are the
      [documentation guidelines](https://github.com/huggingface/transformers/tree/main/docs), and
      [here are tips on formatting docstrings](https://github.com/huggingface/transformers/tree/main/docs#writing-source-documentation).
- [ ] Did you write any new necessary tests?


## Who can review?
@Rocketknight1 @zucchini-nlp

Changed files:
filename: tests/models/deberta_v2/test_modeling_deberta_v2.py
patch: @@ -301,7 +301,7 @@ def test_inference_masked_lm(self):
 
     @slow
     def test_inference_no_head(self):
-        model = DebertaV2Model.from_pretrained("microsoft/deberta-v2-xlarge")
+        model = DebertaV2Model.from_pretrained("microsoft/deberta-v2-xlarge", dtype=torch.float32)
 
         input_ids = torch.tensor([[0, 31414, 232, 328, 740, 1140, 12695, 69, 46078, 1588, 2]])
         attention_mask = torch.tensor([[0, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1]])
Repository: vercel/next.js
Pull request: Update Rspack production test manifest

This auto-generated PR updates the production integration test manifest used when testing Rspack.

Changed files:
filename: test/rspack-build-tests-manifest.json
patch: @@ -2299,15 +2299,6 @@
     "flakey": [],
     "runtimeError": false
   },
-  "test/e2e/app-dir/cdn-cache-control-header/cdn-cache-control-header.test.ts": {
-    "passed": [
-      "cdn-cache-control-header should use custom CDN cache control header name from experimental config"
-    ],
-    "failed": [],
-    "pending": [],
-    "flakey": [],
-    "runtimeError": false
-  },
   "test/e2e/app-dir/client-module-with-package-type/index.test.ts": {
     "passed": [
       "esm-client-module-without-exports \"type\": \"commonjs\" in package.json should render without errors: import cjs",
@@ -6149,7 +6140,10 @@
   "test/e2e/app-dir/resume-data-cache/resume-data-cache.test.ts": {
     "passed": [
       "resume-data-cache should have consistent data between static and dynamic renders with fetch cache",
-      "resume-data-cache should have consistent data between static and dynamic renders with use cache"
+      "resume-data-cache should have consistent data between static and dynamic renders with use cache",
+      "resume-data-cache should see fresh data after updateTag in server action with fetch cache",
+      "resume-data-cache should see fresh data after updateTag in server action with use cache",
+      "resume-data-cache should use RDC for server action re-renders"
     ],
     "failed": [],
     "pending": [],
@@ -7308,9 +7302,9 @@
     "runtimeError": false
   },
   "test/e2e/app-dir/static-shell-debugging/static-shell-debugging.test.ts": {
-    "passed": ["static-shell-debugging should render the full page"],
+    "passed": [],
     "failed": [],
-    "pending": [],
+    "pending": ["static-shell-debugging should render the full page"],
     "flakey": [],
     "runtimeError": false
   },
@@ -20879,11 +20873,11 @@
     "runtimeError": false
   },
   "test/production/app-dir/metadata-streaming-config/metadata-streaming-config-customized.test.ts": {
-    "passed": [
+    "passed": [],
+    "failed": [],
+    "pending": [
       "app-dir - metadata-streaming-config-customized should have the customized streaming metadata config output in routes-manifest.json"
     ],
-    "failed": [],
-    "pending": [],
     "flakey": [],
     "runtimeError": false
   },
Repository: vuejs/vue
Pull request: fix(types): make VNodeDirective properties optional, fix #8013

<!--
Please make sure to read the Pull Request Guidelines:
https://github.com/vuejs/vue/blob/dev/.github/CONTRIBUTING.md#pull-request-guidelines
-->

<!-- PULL REQUEST TEMPLATE -->
<!-- (Update "[ ]" to "[x]" to check a box) -->

**What kind of change does this PR introduce?** (check at least one)

- [x] Bugfix - fixes #8013
- [ ] Feature
- [ ] Code style update
- [ ] Refactor
- [ ] Build-related changes
- [ ] Other, please describe:

**Does this PR introduce a breaking change?** (check one)

- [ ] Yes
- [x] No

If yes, please describe the impact and migration path for existing applications:

**The PR fulfills these requirements:**

- [x] It's submitted to the `dev` branch for v2.x (or to a previous version branch), _not_ the `master` branch
- [x] When resolving a specific issue, it's referenced in the PR's title (e.g. `fix #xxx[,#xxx]`, where "xxx" is the issue number)
- [x] All tests are passing: https://github.com/vuejs/vue/blob/dev/.github/CONTRIBUTING.md#development-setup
- [x] New/updated tests are included

If adding a **new feature**, the PR's description includes:
- [ ] A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

**Other information:**
Prevents `Property 'oldValue' is missing in type '{ name: string; value: string; }'.` when using directives in a render function (see test). 

There should probably actually be three different `VNodeDirective`s:
 - In `h('', data)` - mostly optional, not readonly
 - In `VNodeData` (returned from createElement) - normalised, not readonly
 - In `DirectiveFunction` - the current definition (before this change)

Changed files:
filename: types/options.d.ts
patch: @@ -160,9 +160,13 @@ export interface WatchOptionsWithHandler<T> extends WatchOptions {
   handler: WatchHandler<T>;
 }
 
+export interface DirectiveBinding extends Readonly<VNodeDirective> {
+  readonly modifiers: { [key: string]: boolean };
+}
+
 export type DirectiveFunction = (
   el: HTMLElement,
-  binding: VNodeDirective,
+  binding: DirectiveBinding,
   vnode: VNode,
   oldVnode: VNode
 ) => void;

filename: types/test/options-test.ts
patch: @@ -154,6 +154,10 @@ Vue.component('component', {
       props: {
         myProp: "bar"
       },
+      directives: [{
+        name: 'a',
+        value: 'foo'
+      }],
       domProps: {
         innerHTML: "baz"
       },

filename: types/vnode.d.ts
patch: @@ -58,10 +58,10 @@ export interface VNodeData {
 }
 
 export interface VNodeDirective {
-  readonly name: string;
-  readonly value: any;
-  readonly oldValue: any;
-  readonly expression: any;
-  readonly arg: string;
-  readonly modifiers: { [key: string]: boolean };
+  name: string;
+  value?: any;
+  oldValue?: any;
+  expression?: any;
+  arg?: string;
+  modifiers?: { [key: string]: boolean };
 }
Repository: ollama/ollama
Pull request: OpenAI: accept x-stainless-timeout header to fix CORS error

Related to https://github.com/ollama/ollama/issues/9236, I add the `timeout` header for openai npm package.

Changed files:
filename: server/routes.go
patch: @@ -1131,7 +1131,7 @@ func (s *Server) GenerateRoutes() http.Handler {
 	config.AllowWildcard = true
 	config.AllowBrowserExtensions = true
 	config.AllowHeaders = []string{"Authorization", "Content-Type", "User-Agent", "Accept", "X-Requested-With"}
-	openAIProperties := []string{"lang", "package-version", "os", "arch", "retry-count", "runtime", "runtime-version", "async", "helper-method", "poll-helper", "custom-poll-interval"}
+	openAIProperties := []string{"lang", "package-version", "os", "arch", "retry-count", "runtime", "runtime-version", "async", "helper-method", "poll-helper", "custom-poll-interval", "timeout"}
 	for _, prop := range openAIProperties {
 		config.AllowHeaders = append(config.AllowHeaders, "x-stainless-"+prop)
 	}
Repository: facebook/react
Pull request: [ci] Log author_association


For debugging purposes, log author_association


Changed files:
filename: .github/workflows/compiler_discord_notify.yml
patch: @@ -15,6 +15,7 @@ jobs:
     outputs:
       is_member_or_collaborator: ${{ steps.check_is_member_or_collaborator.outputs.is_member_or_collaborator }}
     steps:
+      - run: echo ${{ github.event.pull_request.author_association }}
       - name: Check is member or collaborator
         id: check_is_member_or_collaborator
         if: ${{ github.event.pull_request.author_association == 'MEMBER' || github.event.pull_request.author_association == 'COLLABORATOR' }}

filename: .github/workflows/runtime_discord_notify.yml
patch: @@ -15,6 +15,7 @@ jobs:
     outputs:
       is_member_or_collaborator: ${{ steps.check_is_member_or_collaborator.outputs.is_member_or_collaborator }}
     steps:
+      - run: echo ${{ github.event.pull_request.author_association }}
       - name: Check is member or collaborator
         id: check_is_member_or_collaborator
         if: ${{ github.event.pull_request.author_association == 'MEMBER' || github.event.pull_request.author_association == 'COLLABORATOR' }}

filename: .github/workflows/shared_label_core_team_prs.yml
patch: @@ -17,6 +17,7 @@ jobs:
     outputs:
       is_member_or_collaborator: ${{ steps.check_is_member_or_collaborator.outputs.is_member_or_collaborator }}
     steps:
+      - run: echo ${{ github.event.pull_request.author_association }}
       - name: Check is member or collaborator
         id: check_is_member_or_collaborator
         if: ${{ github.event.pull_request.author_association == 'MEMBER' || github.event.pull_request.author_association == 'COLLABORATOR' }}
Repository: vercel/next.js
Pull request: Update Rspack development test manifest

This auto-generated PR updates the development integration test manifest used when testing Rspack.

Changed files:
filename: test/rspack-dev-tests-manifest.json
patch: @@ -4612,15 +4612,6 @@
     "flakey": [],
     "runtimeError": false
   },
-  "test/e2e/app-dir/cdn-cache-control-header/cdn-cache-control-header.test.ts": {
-    "passed": [
-      "cdn-cache-control-header should use custom CDN cache control header name from experimental config"
-    ],
-    "failed": [],
-    "pending": [],
-    "flakey": [],
-    "runtimeError": false
-  },
   "test/e2e/app-dir/client-module-with-package-type/index.test.ts": {
     "passed": [
       "esm-client-module-without-exports \"type\": \"commonjs\" in package.json should render without errors: import cjs",
@@ -9379,9 +9370,9 @@
     "runtimeError": false
   },
   "test/e2e/app-dir/static-shell-debugging/static-shell-debugging.test.ts": {
-    "passed": ["static-shell-debugging should render the full page"],
+    "passed": [],
     "failed": [],
-    "pending": [],
+    "pending": ["static-shell-debugging should render the full page"],
     "flakey": [],
     "runtimeError": false
   },
@@ -9735,10 +9726,11 @@
     "runtimeError": false
   },
   "test/e2e/app-dir/use-cache-without-experimental-flag/use-cache-without-experimental-flag.test.ts": {
-    "passed": ["use-cache-without-experimental-flag should show a build error"],
-    "failed": [
-      "use-cache-without-experimental-flag should recover from the build error if useCache flag is set"
+    "passed": [
+      "use-cache-without-experimental-flag should recover from the build error if useCache flag is set",
+      "use-cache-without-experimental-flag should show a build error"
     ],
+    "failed": [],
     "pending": [],
     "flakey": [],
     "runtimeError": false
Repository: huggingface/transformers
Pull request: Fixed failing `BioGPT` batch generation test

# What does this PR do?
Fixes this failing [BioGPT-batch generation test](https://github.com/huggingface/transformers/actions/runs/20706072009/job/59437072400#step:14:1607). From this PR [Generation Config defaults are now None](https://github.com/huggingface/transformers/pull/42702/)

<img width="1321" height="171" alt="image" src="https://github.com/user-attachments/assets/ccb8f737-b33b-4c47-91e3-0f756ad013ee" />

## Before submitting
- [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
- [x] Did you read the [contributor guideline](https://github.com/huggingface/transformers/blob/main/CONTRIBUTING.md#create-a-pull-request),
      Pull Request section?
- [ ] Was this discussed/approved via a Github issue or the [forum](https://discuss.huggingface.co/)? Please add a link
      to it if that's the case.
- [ ] Did you make sure to update the documentation with your changes? Here are the
      [documentation guidelines](https://github.com/huggingface/transformers/tree/main/docs), and
      [here are tips on formatting docstrings](https://github.com/huggingface/transformers/tree/main/docs#writing-source-documentation).
- [ ] Did you write any new necessary tests?


## Who can review?
@Rocketknight1 @zucchini-nlp 

Changed files:
filename: tests/models/biogpt/test_modeling_biogpt.py
patch: @@ -335,9 +335,8 @@ def test_batch_generation(self):
 
         num_paddings = inputs_non_padded.shape[-1] - inputs["attention_mask"][-1].long().sum().item()
         inputs_padded = tokenizer(sentences[1], return_tensors="pt").input_ids.to(torch_device)
-        output_padded = model.generate(
-            input_ids=inputs_padded, max_length=model.generation_config.max_length - num_paddings
-        )
+        # 20 is the default max_length in the generation config
+        output_padded = model.generate(input_ids=inputs_padded, max_length=20 - num_paddings)
 
         batch_out_sentence = tokenizer.batch_decode(outputs, skip_special_tokens=True)
         non_padded_sentence = tokenizer.decode(output_non_padded[0], skip_special_tokens=True)
Repository: vuejs/vue
Pull request: remove useless code

remove useless code

Changed files:
filename: src/server/webpack-plugin/client.js
patch: @@ -54,12 +54,6 @@ export default class VueSSRClientPlugin {
         }
       })
 
-      // const debug = (file, obj) => {
-      //   require('fs').writeFileSync(__dirname + '/' + file, JSON.stringify(obj, null, 2))
-      // }
-      // debug('stats.json', stats)
-      // debug('client-manifest.json', manifest)
-
       const json = JSON.stringify(manifest, null, 2)
       compilation.assets[this.options.filename] = {
         source: () => json,
Repository: ollama/ollama
Pull request: build: remove backend build for sapphirerapids

sapphire rapids has amx support but it ends up having a negative performance impact.

emerald rapids also has amx support with a positive performance impact however there's no reasonable way in ggml to differentiate between the two. the impact is small (~6.5%) so disable amx entirely for simplicity

some quick tests

sapphire rapids
```
0.5.7 mean: 7.130 tokens/s stdev: 0.044 n: 3
0.5.11 mean: 6.513 tokens/s stdev: 0.015 n: 3
noamx mean: 7.220 tokens/s stdev: 0.061 n: 3
percent change
0.5.7 --> 0.5.11 -8.649%
0.5.11 --> noamx 10.850%
0.5.7 --> noamx 1.262%
```

emerald rapids
```
0.5.7 mean: 4.853 tokens/s stdev: 0.015 n: 3
0.5.11 mean: 5.797 tokens/s stdev: 0.012 n: 3
noamx mean: 5.407 tokens/s stdev: 0.012 n: 3
percent change
0.5.7 --> 0.5.11 19.437%
0.5.11 --> noamx -6.728%
0.5.7 --> noamx 11.401%
```

resolves #9087 

Changed files:
filename: llama/patches/0018-remove-amx.patch
patch: @@ -0,0 +1,24 @@
+From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
+From: Michael Yang <mxyng@pm.me>
+Date: Tue, 18 Feb 2025 14:47:21 -0800
+Subject: [PATCH] remove amx
+
+---
+ ggml/src/CMakeLists.txt | 4 ----
+ 1 file changed, 4 deletions(-)
+
+diff --git a/ggml/src/CMakeLists.txt b/ggml/src/CMakeLists.txt
+index 72b488dd..50828717 100644
+--- a/ggml/src/CMakeLists.txt
++++ b/ggml/src/CMakeLists.txt
+@@ -293,10 +293,6 @@ if (GGML_CPU_ALL_VARIANTS)
+     ggml_add_cpu_backend_variant(skylakex       AVX F16C AVX2 FMA AVX512)
+     ggml_add_cpu_backend_variant(icelake        AVX F16C AVX2 FMA AVX512 AVX512_VBMI AVX512_VNNI)
+     ggml_add_cpu_backend_variant(alderlake      AVX F16C AVX2 FMA AVX_VNNI)
+-    if (NOT MSVC)
+-        # MSVC doesn't support AMX
+-        ggml_add_cpu_backend_variant(sapphirerapids AVX F16C AVX2 FMA AVX512 AVX512_VBMI AVX512_VNNI AVX512_BF16 AMX_TILE AMX_INT8)
+-    endif()
+ else ()
+     ggml_add_cpu_backend_variant_impl("")
+ endif()

filename: ml/backend/ggml/ggml/src/CMakeLists.txt
patch: @@ -293,10 +293,6 @@ if (GGML_CPU_ALL_VARIANTS)
     ggml_add_cpu_backend_variant(skylakex       AVX F16C AVX2 FMA AVX512)
     ggml_add_cpu_backend_variant(icelake        AVX F16C AVX2 FMA AVX512 AVX512_VBMI AVX512_VNNI)
     ggml_add_cpu_backend_variant(alderlake      AVX F16C AVX2 FMA AVX_VNNI)
-    if (NOT MSVC)
-        # MSVC doesn't support AMX
-        ggml_add_cpu_backend_variant(sapphirerapids AVX F16C AVX2 FMA AVX512 AVX512_VBMI AVX512_VNNI AVX512_BF16 AMX_TILE AMX_INT8)
-    endif()
 else ()
     ggml_add_cpu_backend_variant_impl("")
 endif()
Repository: nodejs/node
Pull request: src: add HandleScope to loop in heap_utils

added HandleScope to loop in heap_utils

Changed files:
filename: src/heap_utils.cc
patch: @@ -180,6 +180,7 @@ class JSGraph : public EmbedderGraph {
       size_t i = 0;
       size_t j = 0;
       for (const auto& edge : edge_info.second) {
+        HandleScope handle_scope(isolate_);
         Local<Object> to_object = info_objects[edge.second];
         Local<Object> edge_obj = Object::New(isolate_);
         Local<Value> edge_name_value;
Repository: vuejs/vue
Pull request: fix: add placeholder firebase example

<!--
Please make sure to read the Pull Request Guidelines:
https://github.com/vuejs/vue/blob/dev/.github/CONTRIBUTING.md#pull-request-guidelines
-->

Before: 
![2018-04-07 22 27 53](https://user-images.githubusercontent.com/11417813/38455434-020cd7f6-3ab3-11e8-8e95-12c58c712bba.png)

After:
![2018-04-07 22 27 30](https://user-images.githubusercontent.com/11417813/38455438-0b031c8a-3ab3-11e8-995d-385ca2f7cbe6.png)

<!-- PULL REQUEST TEMPLATE -->
<!-- (Update "[ ]" to "[x]" to check a box) -->

**What kind of change does this PR introduce?** (check at least one)

- [x] Code style update

**Does this PR introduce a breaking change?** (check one)

- [x] No

If yes, please describe the impact and migration path for existing applications:

**The PR fulfills these requirements:**

- [x] It's submitted to the `dev` branch for v2.x (or to a previous version branch), _not_ the `master` branch
- [x] When resolving a specific issue, it's referenced in the PR's title (e.g. `fix #xxx[,#xxx]`, where "xxx" is the issue number)
- [x] All tests are passing: https://github.com/vuejs/vue/blob/dev/.github/CONTRIBUTING.md#development-setup
- [x] New/updated tests are included

If adding a **new feature**, the PR's description includes:
- [x] A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

**Other information:**


Changed files:
filename: examples/firebase/index.html
patch: @@ -21,8 +21,8 @@
         </li>
       </ul>
       <form id="form" v-on:submit.prevent="addUser">
-        <input v-model="newUser.name">
-        <input v-model="newUser.email">
+        <input v-model="newUser.name" placeholder="Add Name">
+        <input v-model="newUser.email" placeholder="Add Email">
         <input type="submit" value="Add User">
       </form>
       <ul class="errors">