Repository: nodejs/node
Pull request: src: release context frame in AsyncWrap::EmitDestroy

Release the async context frame in `AsyncWrap::EmitDestroy` to allow gc to collect it.

This is in special relevant for reused resources like `HTTPParser` otherwise they might keep ALS stores alive.

Fixes: https://github.com/nodejs/node/issues/61882
Refs: https://github.com/nodejs/node/pull/48528

<!--
Before submitting a pull request, please read:

- the CONTRIBUTING guide at https://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md
- the commit message formatting guidelines at
  https://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#commit-message-guidelines

For code changes:
1. Include tests for any bug fixes or new features.
2. Update documentation if relevant.
3. Ensure that `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes.

If you believe this PR should be highlighted in the Node.js CHANGELOG
please add the `notable-change` label.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.
-->


Changed files:
filename: src/async_wrap.cc
patch: @@ -25,6 +25,9 @@
 #include "env-inl.h"
 #include "node_errors.h"
 #include "node_external_reference.h"
+#ifdef DEBUG
+#include <node_process-inl.h>
+#endif
 #include "tracing/traced_value.h"
 #include "util-inl.h"
 
@@ -333,9 +336,12 @@ void AsyncWrap::EmitDestroy(bool from_gc) {
   // Ensure no double destroy is emitted via AsyncReset().
   async_id_ = kInvalidAsyncId;
 
-  if (!persistent().IsEmpty() && !from_gc) {
-    HandleScope handle_scope(env()->isolate());
-    USE(object()->Set(env()->context(), env()->resource_symbol(), object()));
+  if (!from_gc) {
+    if (!persistent().IsEmpty()) {
+      HandleScope handle_scope(env()->isolate());
+      USE(object()->Set(env()->context(), env()->resource_symbol(), object()));
+    }
+    context_frame_.Reset();
   }
 }
 
@@ -659,6 +665,14 @@ MaybeLocal<Value> AsyncWrap::MakeCallback(const Local<Function> cb,
                                           Local<Value>* argv) {
   EmitTraceEventBefore();
 
+#ifdef DEBUG
+  if (context_frame_.IsEmpty()) {
+    ProcessEmitWarning(env(),
+                       "MakeCallback() called without context_frame, "
+                       "likely use after destroy of AsyncWrap.");
+  }
+#endif
+
   ProviderType provider = provider_type();
   async_context context { get_async_id(), get_trigger_async_id() };
   MaybeLocal<Value> ret =

filename: test/parallel/test-async-local-storage-http-parser-leak.js
patch: @@ -0,0 +1,29 @@
+// Flags: --expose-gc
+'use strict';
+
+const common = require('../common');
+const { onGC } = require('../common/gc');
+const assert = require('node:assert');
+const { AsyncLocalStorage } = require('node:async_hooks');
+const { freeParser, parsers, HTTPParser } = require('_http_common');
+
+let storeGCed = false;
+
+const als = new AsyncLocalStorage();
+
+function test() {
+  const store = {};
+  onGC(store, { ongc: common.mustCall(() => { storeGCed = true; }) });
+  let parser;
+  als.run(store, common.mustCall(() => {
+    parser = parsers.alloc();
+    parser.initialize(HTTPParser.RESPONSE, {});
+  }));
+  freeParser(parser);
+}
+
+test();
+global.gc();
+setImmediate(common.mustCall(() => {
+  assert.ok(storeGCed);
+}));