helloadhavan/github_issues huggingface dataset:
Repository: nodejs/node
Pull request: doc: correct options for net.Socket class and socket.connect

blockList, keepAlive, keepAliveInitialDelay and noDelay are wrongly documented for socket.connect options and missing on net.Socket constructor options documentation

Fixes: https://github.com/nodejs/node/issues/59823

Changed files:
filename: doc/api/net.md
patch: @@ -759,8 +759,17 @@ changes:
     automatically end the writable side when the readable side ends. See
     [`net.createServer()`][] and the [`'end'`][] event for details. **Default:**
     `false`.
+  * `blockList` {net.BlockList} `blockList` can be used for disabling outbound
+    access to specific IP addresses, IP ranges, or IP subnets.
   * `fd` {number} If specified, wrap around an existing socket with
     the given file descriptor, otherwise a new socket will be created.
+  * `keepAlive` {boolean} If set to `true`, it enables keep-alive functionality on
+    the socket immediately after the connection is established, similarly on what
+    is done in [`socket.setKeepAlive()`][]. **Default:** `false`.
+  * `keepAliveInitialDelay` {number} If set to a positive number, it sets the
+    initial delay before the first keepalive probe is sent on an idle socket. **Default:** `0`.
+  * `noDelay` {boolean} If set to `true`, it disables the use of Nagle's algorithm
+    immediately after the socket is established. **Default:** `false`.
   * `onread` {Object} If specified, incoming data is stored in a single `buffer`
     and passed to the supplied `callback` when data arrives on the socket.
     This will cause the streaming functionality to not provide any data.
@@ -1123,20 +1132,10 @@ For TCP connections, available `options` are:
   `0` indicates that both IPv4 and IPv6 addresses are allowed. **Default:** `0`.
 * `hints` {number} Optional [`dns.lookup()` hints][].
 * `host` {string} Host the socket should connect to. **Default:** `'localhost'`.
-* `keepAlive` {boolean} If set to `true`, it enables keep-alive functionality on
-  the socket immediately after the connection is established, similarly on what
-  is done in [`socket.setKeepAlive()`][]. **Default:** `false`.
-* `keepAliveInitialDelay` {number} If set to a positive number, it sets the
-  initial delay before the first keepalive probe is sent on an idle socket.
-  **Default:** `0`.
 * `localAddress` {string} Local address the socket should connect from.
 * `localPort` {number} Local port the socket should connect from.
 * `lookup` {Function} Custom lookup function. **Default:** [`dns.lookup()`][].
-* `noDelay` {boolean} If set to `true`, it disables the use of Nagle's algorithm
-  immediately after the socket is established. **Default:** `false`.
 * `port` {number} Required. Port the socket should connect to.
-* `blockList` {net.BlockList} `blockList` can be used for disabling outbound
-  access to specific IP addresses, IP ranges, or IP subnets.
 
 For [IPC][] connections, available `options` are:
Repository: vuejs/vue
Pull request: fix(types): add refInFor to VNodeData

<!--
Please make sure to read the Pull Request Guidelines:
https://github.com/vuejs/vue/blob/dev/.github/CONTRIBUTING.md#pull-request-guidelines
-->

<!-- PULL REQUEST TEMPLATE -->
<!-- (Update "[ ]" to "[x]" to check a box) -->

**What kind of change does this PR introduce?** (check at least one)

- [x] Bugfix
- [ ] Feature
- [ ] Code style update
- [ ] Refactor
- [ ] Build-related changes
- [ ] Other, please describe:

**Does this PR introduce a breaking change?** (check one)

- [ ] Yes
- [x] No

If yes, please describe the impact and migration path for existing applications:

**The PR fulfills these requirements:**

- [x] It's submitted to the `dev` branch for v2.x (or to a previous version branch), _not_ the `master` branch
- [ ] When resolving a specific issue, it's referenced in the PR's title (e.g. `fix #xxx[,#xxx]`, where "xxx" is the issue number)
- [x] All tests are passing: https://github.com/vuejs/vue/blob/dev/.github/CONTRIBUTING.md#development-setup
- [x] New/updated tests are included

If adding a **new feature**, the PR's description includes:
- [ ] A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

**Other information:**
See #4035 and #8225
`refInFor` is also mentioned in https://github.com/vuejs/babel-plugin-transform-vue-jsx#difference-from-react-jsx and can be seen in the generated code on https://vuejs.org/v2/guide/render-function.html#Template-Compilation


Changed files:
filename: types/test/options-test.ts
patch: @@ -176,7 +176,8 @@ Vue.component('component', {
         fontSize: '14px'
       },
       key: 'myKey',
-      ref: 'myRef'
+      ref: 'myRef',
+      refInFor: true
     }, [
       createElement(),
       createElement("div", "message"),

filename: types/vnode.d.ts
patch: @@ -36,6 +36,7 @@ export interface VNodeData {
   slot?: string;
   scopedSlots?: { [key: string]: ScopedSlot };
   ref?: string;
+  refInFor?: boolean;
   tag?: string;
   staticClass?: string;
   class?: any;
Repository: facebook/react
Pull request: Remove leftover Rust script


For now we removed Rust from the codebase, remove this leftover script.

Also remove some dupes and Rust related files from `.gitignore`.


Changed files:
filename: compiler/.gitignore
patch: @@ -1,28 +1,14 @@
 .DS_Store
 .spr.yml
 
-# Generated by Cargo
-# will have compiled files and executables
-debug/
-target/
-
-# These are backup files generated by rustfmt
-**/*.rs.bk
-
-# MSVC Windows builds of rustc generate these, which store debugging information
-*.pdb
-
 node_modules
 .watchmanconfig
 .watchman-cookie-*
 dist
 .vscode
 !packages/playground/.vscode
-.spr.yml
 testfilter.txt
 
-bundle-oss.sh
-
 # forgive
 *.vsix
 .vscode-test

filename: compiler/scripts/rustfmt.sh
patch: @@ -1,12 +0,0 @@
-#!/usr/bin/env bash
-# Copyright (c) Meta Platforms, Inc. and affiliates.
-#
-# This source code is licensed under the MIT license found in the
-# LICENSE file in the root directory of this source tree.
-
-set -eo pipefail
-
-# Executes rustfmt using a nightly build of the compiler
-# NOTE: this command must exactly match the Rust Lint command in .github/workflows/rust.yml
-rustup toolchain list | grep -q nightly-2023-08-01 || (echo "Expected Rust version missing, try running: 'rustup toolchain install nightly-2023-08-01'" && exit 1)
-grep -r --include "*.rs" --files-without-match "@generated" crates | xargs rustup run nightly-2023-08-01 rustfmt --config="skip_children=true" "$@"
Repository: ollama/ollama
Pull request: ml/backend/ggml: fix rms norm


Changed files:
filename: ml/backend/ggml/ggml.go
patch: @@ -485,7 +485,7 @@ func (t *Tensor) LayerNorm(ctx ml.Context, w, b ml.Tensor, eps float32) ml.Tenso
 }
 
 func (t *Tensor) RMSNorm(ctx ml.Context, w ml.Tensor, eps float32) ml.Tensor {
-	return (&Tensor{t: C.ggml_norm(ctx.(*Context).ctx, t.t, C.float(eps))}).Mul(ctx, w)
+	return (&Tensor{t: C.ggml_rms_norm(ctx.(*Context).ctx, t.t, C.float(eps))}).Mul(ctx, w)
 }
 
 func (t *Tensor) Pad(ctx ml.Context, shape ...int) ml.Tensor {
Repository: huggingface/transformers
Pull request: Fix Fuyu processor width dimension bug in `_get_num_multimodal_tokens`

# What does this PR do?

This PR fixes a critical bug in the Fuyu processor's `_get_num_multimodal_tokens` method where the image width calculation incorrectly uses the height dimension.

## The Bug

In `src/transformers/models/fuyu/processing_fuyu.py` at line 629, the code was:

```python
image_unpadded_h = min(int(image_size[0] * optimal_scale_factor), image_size[0])
image_unpadded_w = min(int(image_size[0] * optimal_scale_factor), image_size[0])  # BUG: uses [0] twice!

```

Both height and width were being calculated using `image_size[0]` (the height dimension). The width should use `image_size[1]`.

## The Fix

Changed line 629 to correctly use `image_size[1]` for the width calculation:

```python
image_unpadded_h = min(int(image_size[0] * optimal_scale_factor), image_size[0])
image_unpadded_w = min(int(image_size[1] * optimal_scale_factor), image_size[1])  # Fixed

```

## Impact

This bug caused incorrect image padding calculations for multimodal inputs in Fuyu, resulting in:

* **Wrong aspect ratio preservation** for images.
* **Incorrect token count computation** for variable-sized images.
* **Distorted image processing** when .

The fix ensures proper scaling of both dimensions independently, matching the intended behavior shown in the corresponding `image_processing_fuyu.py` file.

---

## Before submitting

* [x] This PR fixes a bug in model implementation.
* [x] Did you read the [[contributor guideline](https://github.com/huggingface/transformers/blob/main/CONTRIBUTING.md)](https://github.com/huggingface/transformers/blob/main/CONTRIBUTING.md)?
* [ ] Was this discussed/approved via a Github issue or the forum?
* [x] This is a minimal change that does not require documentation updates.
* [ ] Did you write any new necessary tests? (Fix is self-evident and covered by existing tests).

## Who can review?

@zucchini-nlp (multimodal models) @molbap (vision models)

Changed files:
filename: src/transformers/models/fuyu/processing_fuyu.py
patch: @@ -625,7 +625,7 @@ def _get_num_multimodal_tokens(self, image_sizes=None, **kwargs):
                 optimal_scale_factor = min(height_scale_factor, width_scale_factor)
 
                 image_unpadded_h = min(int(image_size[0] * optimal_scale_factor), image_size[0])
-                image_unpadded_w = min(int(image_size[0] * optimal_scale_factor), image_size[0])
+                image_unpadded_w = min(int(image_size[1] * optimal_scale_factor), image_size[1])
 
                 # We can use torch here because Fuyu processor has hard dependency on torch. NOTE: Fuyu can't do multi-image
                 # thus the below (1, 1, 1) is hardcoded. Same as when calling the processor
Repository: ollama/ollama
Pull request: doc(README): add `RockChinQ/LangBot` to integrations list

Thank you for your incredible work. Our project [LangBot](https://github.com/RockChinQ/LangBot) is a platform for building instant messaging bots, it's free and supports multiple messaging platforms (e.g. Telegram, Discord, WeChat ...). Currently has up to 8000 stars and 30+ contributors.

Changed files:
filename: README.md
patch: @@ -385,6 +385,7 @@ See the [API documentation](./docs/api.md) for all endpoints.
 - [AntSK](https://github.com/AIDotNet/AntSK) (Out-of-the-box & Adaptable RAG Chatbot)
 - [MaxKB](https://github.com/1Panel-dev/MaxKB/) (Ready-to-use & flexible RAG Chatbot)
 - [yla](https://github.com/danielekp/yla) (Web interface to freely interact with your customized models)
+- [LangBot](https://github.com/RockChinQ/LangBot) (LLM-based instant messaging bots platform, with Agents, RAG features, supports multiple platforms)
 
 ### Cloud
Repository: vuejs/vue
Pull request: allow functional components to return multiple VNodes (fix #8191)

<!--
Please make sure to read the Pull Request Guidelines:
https://github.com/vuejs/vue/blob/dev/.github/CONTRIBUTING.md#pull-request-guidelines
-->

<!-- PULL REQUEST TEMPLATE -->
<!-- (Update "[ ]" to "[x]" to check a box) -->

**What kind of change does this PR introduce?** (check at least one)

- [x] Bugfix
- [ ] Feature
- [ ] Code style update
- [ ] Refactor
- [ ] Build-related changes
- [ ] Other, please describe:

**Does this PR introduce a breaking change?** (check one)

- [ ] Yes
- [x] No

If yes, please describe the impact and migration path for existing applications:

**The PR fulfills these requirements:**

- [x] It's submitted to the `dev` branch for v2.x (or to a previous version branch), _not_ the `master` branch
- [x] When resolving a specific issue, it's referenced in the PR's title (e.g. `fix #xxx[,#xxx]`, where "xxx" is the issue number)
- [x] All tests are passing: https://github.com/vuejs/vue/blob/dev/.github/CONTRIBUTING.md#development-setup
- [x] New/updated tests are included

If adding a **new feature**, the PR's description includes:
- [ ] A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

**Other information:**


Changed files:
filename: types/options.d.ts
patch: @@ -113,7 +113,7 @@ export interface FunctionalComponentOptions<Props = DefaultProps, PropDefs = Pro
   props?: PropDefs;
   inject?: InjectOptions;
   functional: boolean;
-  render?(this: undefined, createElement: CreateElement, context: RenderContext<Props>): VNode;
+  render?(this: undefined, createElement: CreateElement, context: RenderContext<Props>): VNode | VNode[];
 }
 
 export interface RenderContext<Props=DefaultProps> {

filename: types/test/options-test.ts
patch: @@ -354,6 +354,16 @@ Vue.component('functional-component-check-optional', {
   functional: true
 })
 
+Vue.component('functional-component-multi-root', {
+  functional: true,
+  render(h) {
+    return [
+      h("tr", [h("td", "foo"), h("td", "bar")]),
+      h("tr", [h("td", "lorem"), h("td", "ipsum")])
+    ]
+  }
+})
+
 Vue.component("async-component", ((resolve, reject) => {
   setTimeout(() => {
     resolve(Vue.component("component"));
Repository: nodejs/node
Pull request: lib: gbk decoder is gb18030 decoder per spec

Tracking: #61041 

Spec ref: https://encoding.spec.whatwg.org/#gbk-decoder

Without this, TextDecoder fails tests on `gbk` encoding


Changed files:
filename: lib/internal/encoding.js
patch: @@ -430,7 +430,9 @@ function makeTextDecoderICU() {
 
     #prepareConverter() {
       if (this[kHandle] !== undefined) return;
-      const handle = getConverter(this[kEncoding], this[kFlags]);
+      let icuEncoding = this[kEncoding];
+      if (icuEncoding === 'gbk') icuEncoding = 'gb18030'; // 10.1.1. GBK's decoder is gb18030's decoder
+      const handle = getConverter(icuEncoding, this[kFlags]);
       if (handle === undefined)
         throw new ERR_ENCODING_NOT_SUPPORTED(this[kEncoding]);
       this[kHandle] = handle;
Repository: ggml-org/llama.cpp
Pull request: common: reduce level of content parser warning message to avoid log spam on non-debug verbosity

Fixes #20309 

Changed files:
filename: common/chat.cpp
patch: @@ -1620,8 +1620,8 @@ common_chat_msg common_chat_peg_parse(const common_peg_arena &          src_pars
         build_chat_peg_parser([](common_chat_peg_builder & p) { return p.content(p.rest()) + p.end(); }) :
         src_parser;
 
-        if (src_parser.empty()) {
-        LOG_WRN("No parser definition detected, assuming pure content parser.");
+    if (src_parser.empty()) {
+        LOG_DBG("No parser definition detected, assuming pure content parser.");
     }
 
     LOG_DBG("Parsing PEG input with format %s: %s\n", common_chat_format_name(params.format), input.c_str());
Repository: electron/electron
Pull request: fix: try clearing `InspectableWebContents` delegate earlier

Backport of #49406

See that PR for details.


Notes: Fixed a potential race condition crash when opening DevTools.


Changed files:
filename: shell/browser/api/electron_api_web_contents.cc
patch: @@ -1037,6 +1037,9 @@ void WebContents::InitWithWebContents(
 }
 
 WebContents::~WebContents() {
+  if (inspectable_web_contents_)
+    inspectable_web_contents_->GetView()->SetDelegate(nullptr);
+
   if (owner_window_) {
     owner_window_->RemoveBackgroundThrottlingSource(this);
   }
@@ -1051,8 +1054,6 @@ WebContents::~WebContents() {
     return;
   }
 
-  inspectable_web_contents_->GetView()->SetDelegate(nullptr);
-
   // This event is only for internal use, which is emitted when WebContents is
   // being destroyed.
   Emit("will-destroy");
@@ -2189,8 +2190,8 @@ void WebContents::DevToolsOpened() {
   // Inherit owner window in devtools when it doesn't have one.
   auto* devtools = inspectable_web_contents_->GetDevToolsWebContents();
   bool has_window = devtools->GetUserData(NativeWindowRelay::UserDataKey());
-  if (owner_window_ && !has_window) {
-    DCHECK(!owner_window_.WasInvalidated());
+  if (owner_window() && !has_window) {
+    CHECK(!owner_window_.WasInvalidated());
     DCHECK_EQ(handle->owner_window(), nullptr);
     handle->SetOwnerWindow(devtools, owner_window());
   }
Repository: huggingface/transformers
Pull request: [CB] Minor fix in kwargs

This PR fixes an error in the `fork` method of the continuous batching API. The arguments name were lacking a `_`

Changed files:
filename: src/transformers/generation/continuous_batching/requests.py
patch: @@ -242,13 +242,13 @@ def fork(self, new_request_id: str) -> "RequestState":
             generated_tokens=self.generated_tokens[:],
             allocated_blocks=self.allocated_blocks,
             position_offset=self.position_offset,
-            status=self.status,
+            _status=self.status,
             max_new_tokens=self.max_new_tokens,
             eos_token_id=self.eos_token_id,
             streaming=self.streaming,
             created_time=t,
             lifespan=(t, -1),
-            timestamps=None if self.timestamps is None else self.timestamps[:],
+            _timestamps=None if self.timestamps is None else self.timestamps[:],
             error=self.error,
             record_timestamps=self.record_timestamps,
         )

filename: tests/generation/test_continuous_batching.py
patch: @@ -504,6 +504,8 @@ def test_block_sharing_with_hybrid_model(self) -> None:
 
         return self._test_block_sharing(model_id, num_layer_groups, input_msg, expected_generated_tokens)
 
+    # The test always passes on H100 with torch 2.9, but only passed case 0 on A100 with torch 2.6 and fails on A100
+    # with torch 2.9. This might be due to a GPU diff, so test might be flaky on the CI which runs on A10.
     @parameterized.expand([True, False])
     @require_torch_accelerator
     def test_num_return_sequences(self, allow_block_sharing: bool) -> None:
Repository: facebook/react
Pull request: Move SuspenseListProps into a shared/ReactTypes

So they can be shared by server. Incorporates the types from definitely typed too.

Changed files:
filename: packages/react-reconciler/src/ReactFiberBeginWork.js
patch: @@ -14,6 +14,9 @@ import type {
   ViewTransitionProps,
   ActivityProps,
   SuspenseProps,
+  SuspenseListProps,
+  SuspenseListRevealOrder,
+  SuspenseListTailMode,
   TracingMarkerProps,
   CacheProps,
   ProfilerProps,
@@ -26,7 +29,6 @@ import type {ActivityState} from './ReactFiberActivityComponent';
 import type {
   SuspenseState,
   SuspenseListRenderState,
-  SuspenseListTailMode,
 } from './ReactFiberSuspenseComponent';
 import type {SuspenseContext} from './ReactFiberSuspenseContext';
 import type {
@@ -3222,8 +3224,6 @@ function findLastContentRow(firstChild: null | Fiber): null | Fiber {
   return lastContentRow;
 }
 
-type SuspenseListRevealOrder = 'forwards' | 'backwards' | 'together' | void;
-
 function validateRevealOrder(revealOrder: SuspenseListRevealOrder) {
   if (__DEV__) {
     if (
@@ -3410,7 +3410,7 @@ function updateSuspenseListComponent(
   workInProgress: Fiber,
   renderLanes: Lanes,
 ) {
-  const nextProps = workInProgress.pendingProps;
+  const nextProps: SuspenseListProps = workInProgress.pendingProps;
   const revealOrder: SuspenseListRevealOrder = nextProps.revealOrder;
   const tailMode: SuspenseListTailMode = nextProps.tail;
   const newChildren = nextProps.children;

filename: packages/react-reconciler/src/ReactFiberSuspenseComponent.js
patch: @@ -7,7 +7,7 @@
  * @flow
  */
 
-import type {Wakeable} from 'shared/ReactTypes';
+import type {Wakeable, SuspenseListTailMode} from 'shared/ReactTypes';
 import type {Fiber} from './ReactInternalTypes';
 import type {SuspenseInstance} from './ReactFiberConfig';
 import type {Lane} from './ReactFiberLane';
@@ -42,8 +42,6 @@ export type SuspenseState = {
   hydrationErrors: Array<CapturedValue<mixed>> | null,
 };
 
-export type SuspenseListTailMode = 'collapsed' | 'hidden' | void;
-
 export type SuspenseListRenderState = {
   isBackwards: boolean,
   // The currently rendering tail row.

filename: packages/shared/ReactTypes.js
patch: @@ -290,6 +290,30 @@ export type SuspenseProps = {
   name?: string,
 };
 
+export type SuspenseListRevealOrder =
+  | 'forwards'
+  | 'backwards'
+  | 'together'
+  | void;
+
+export type SuspenseListTailMode = 'collapsed' | 'hidden' | void;
+
+type DirectionalSuspenseListProps = {
+  children?: ReactNodeList,
+  revealOrder: 'forwards' | 'backwards',
+  tail?: SuspenseListTailMode,
+};
+
+type NonDirectionalSuspenseListProps = {
+  children?: ReactNodeList,
+  revealOrder?: 'together' | void,
+  tail?: void,
+};
+
+export type SuspenseListProps =
+  | DirectionalSuspenseListProps
+  | NonDirectionalSuspenseListProps;
+
 export type TracingMarkerProps = {
   name: string,
   children?: ReactNodeList,
Repository: vercel/next.js
Pull request: [ci] Don't retry/notify for failed deploy tests with custom tarball URLs

Fixes a regression from #85981 where manual deploy tests with custom tarball URLs incorrectly trigger retries and Slack notifications. Now only release-triggered runs and manually-triggered canary tests are retried/reported.

Changed files:
filename: .github/workflows/retry_deploy_test.yml
patch: @@ -18,7 +18,10 @@ jobs:
     # Retry the test-e2e-deploy-release workflow once
     if: >-
       ${{
-        startsWith(github.event.workflow_run.display_title, 'test-e2e-deploy') &&
+        (
+          github.event.workflow_run.event == 'release' ||
+          github.event.workflow_run.display_title == 'test-e2e-deploy canary'
+        ) &&
         github.event.workflow_run.conclusion == 'failure' &&
         github.repository == 'vercel/next.js' &&
         github.event.workflow_run.run_attempt < 2
@@ -40,7 +43,10 @@ jobs:
     # Report the failure to Slack if the test-e2e-deploy-release workflow has failed 2 times
     if: >-
       ${{
-        startsWith(github.event.workflow_run.display_title, 'test-e2e-deploy') &&
+        (
+          github.event.workflow_run.event == 'release' ||
+          github.event.workflow_run.display_title == 'test-e2e-deploy canary'
+        ) &&
         github.event.workflow_run.conclusion == 'failure' &&
         github.event.workflow_run.run_attempt >= 2 &&
         !github.event.workflow_run.head_repository.fork