helloadhavan/github_issues huggingface dataset:
Repository: vuejs/vue
Pull request: fix(types): Make SetupBindings optional (fix #12726, #12717)

**What kind of change does this PR introduce?** (check at least one)

- [x] Bugfix
- [ ] Feature
- [ ] Code style update
- [ ] Refactor
- [ ] Build-related changes
- [ ] Other, please describe:

**Does this PR introduce a breaking change?** (check one)

- [ ] Yes
- [x] No

If yes, please describe the impact and migration path for existing applications:

**The PR fulfills these requirements:**

- [x] It's submitted to the `dev` branch for v2.x (or to a previous version branch), _not_ the `master` branch
- [x] When resolving a specific issue, it's referenced in the PR's title (e.g. `fix #xxx[,#xxx]`, where "xxx" is the issue number)
- [x] All tests are passing: https://github.com/vuejs/vue/blob/dev/.github/CONTRIBUTING.md#development-setup
- [x] New/updated tests are included

If adding a **new feature**, the PR's description includes:
- [x] A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

**Other information:**

This PR makes the `SetupBindings` parameter optional on types `ExtendedVue` and `CombinedVueInstance`.
See 
- https://github.com/vuejs/vue/issues/12726
- https://github.com/vuejs/vue/issues/12717

Steps to repro:
```
git clone git@github.com:jf-paradis/demo-vue-issues.git
cd demo-vue-issues
npm install
npm run test
```

Changed files:
filename: types/vue.d.ts
patch: @@ -100,7 +100,7 @@ export type CombinedVueInstance<
   Methods,
   Computed,
   Props,
-  SetupBindings
+  SetupBindings = {}
 > = Data &
   Methods &
   Computed &
@@ -114,7 +114,7 @@ export type ExtendedVue<
   Methods,
   Computed,
   Props,
-  SetupBindings
+  SetupBindings = {}
 > = VueConstructor<
   CombinedVueInstance<Instance, Data, Methods, Computed, Props, SetupBindings> &
     Vue
Repository: facebook/react
Pull request: [DevTools] Fix inspected element scroll in Suspense tab

Broke in https://github.com/facebook/react/pull/34299 leading to resize bars not fully snapping to the cursor.

https://github.com/user-attachments/assets/bcdd18be-bad2-49e3-b6a0-ea46fa50af87



Changed files:
filename: packages/react-devtools-shared/src/devtools/views/SuspenseTab/SuspenseTab.css
patch: @@ -16,14 +16,15 @@
 
 .TreeWrapper {
   border-top: 1px solid var(--color-border);
-  flex: 1 1 var(--horizontal-resize-tree-percentage);
+  flex: 1 1 65%;
   display: flex;
   flex-direction: row;
   height: 100%;
+  overflow: auto;
 }
 
 .InspectedElementWrapper {
-  flex: 1 1 35%;
+  flex: 0 0 calc(100% - var(--horizontal-resize-tree-percentage));
   overflow-x: hidden;
   overflow-y: auto;
 }
@@ -59,12 +60,12 @@
 
   .TreeWrapper {
     border-top: 1px solid var(--color-border);
-    flex: 1 1 var(--vertical-resize-tree-percentage);
+    flex: 1 1 50%;
     overflow: hidden;
   }
 
   .InspectedElementWrapper {
-    flex: 1 1 50%;
+    flex: 0 0 calc(100% - var(--vertical-resize-tree-percentage));
   }
 
   .TreeWrapper + .ResizeBarWrapper .ResizeBar {

filename: packages/react-devtools-shared/src/devtools/views/SuspenseTab/SuspenseTimeline.css
patch: @@ -9,6 +9,11 @@
   display: flex;
   flex-direction: column;
   flex-grow: 1;
+  /* 
+   * `overflow: auto` will add scrollbars but the input will not actually grow beyond visible content.
+   * `overflow: hidden` will constrain the input to its visible content.
+   */
+  overflow: hidden;
 }
 
 .SuspenseTimelineRootSwitcher {

filename: packages/react-devtools-shared/src/devtools/views/SuspenseTab/SuspenseTreeList.js
patch: @@ -10,5 +10,5 @@
 import * as React from 'react';
 
 export default function SuspenseTreeList(_: {}): React$Node {
-  return <div>Activity slices</div>;
+  return <div>Activity slices not implemented yet</div>;
 }
Repository: facebook/react
Pull request: [Flight] Only assign `_store` in dev mode when creating lazy types

Small follow-up to #34350. The `_store` property is now only assigned in development mode when creating lazy types. It also uses the `validated` value that was passed to `createElement`, if applicable.

Changed files:
filename: packages/react-client/src/ReactFlightClient.js
patch: @@ -1172,7 +1172,7 @@ function createElement(
   props: mixed,
   owner: ?ReactComponentInfo, // DEV-only
   stack: ?ReactStackTrace, // DEV-only
-  validated: number, // DEV-only
+  validated: 0 | 1 | 2, // DEV-only
 ):
   | React$Element<any>
   | LazyComponent<React$Element<any>, SomeChunk<React$Element<any>>> {
@@ -1268,7 +1268,7 @@ function createElement(
         }
         erroredChunk._debugInfo = [erroredComponent];
       }
-      return createLazyChunkWrapper(erroredChunk);
+      return createLazyChunkWrapper(erroredChunk, validated);
     }
     if (handler.deps > 0) {
       // We have blocked references inside this Element but we can turn this into
@@ -1277,7 +1277,7 @@ function createElement(
         createBlockedChunk(response);
       handler.value = element;
       handler.chunk = blockedChunk;
-      const lazyType = createLazyChunkWrapper(blockedChunk);
+      const lazyType = createLazyChunkWrapper(blockedChunk, validated);
       if (__DEV__) {
         // After we have initialized any blocked references, initialize stack etc.
         const init = initializeElement.bind(null, response, element, lazyType);
@@ -1295,18 +1295,20 @@ function createElement(
 
 function createLazyChunkWrapper<T>(
   chunk: SomeChunk<T>,
+  validated: 0 | 1 | 2, // DEV-only
 ): LazyComponent<T, SomeChunk<T>> {
   const lazyType: LazyComponent<T, SomeChunk<T>> = {
     $$typeof: REACT_LAZY_TYPE,
     _payload: chunk,
-    _store: {validated: 0},
     _init: readChunk,
   };
   if (__DEV__) {
     // Ensure we have a live array to track future debug info.
     const chunkDebugInfo: ReactDebugInfo =
       chunk._debugInfo || (chunk._debugInfo = ([]: ReactDebugInfo));
     lazyType._debugInfo = chunkDebugInfo;
+    // Initialize a store for key validation by the JSX runtime.
+    lazyType._store = {validated: validated};
   }
   return lazyType;
 }
@@ -2111,7 +2113,7 @@ function parseModelString(
         }
         // We create a React.lazy wrapper around any lazy values.
         // When passed into React, we'll know how to suspend on this.
-        return createLazyChunkWrapper(chunk);
+        return createLazyChunkWrapper(chunk, 0);
       }
       case '@': {
         // Promise

filename: packages/react/src/ReactLazy.js
patch: @@ -59,8 +59,9 @@ export type LazyComponent<T, P> = {
   $$typeof: symbol | number,
   _payload: P,
   _init: (payload: P) => T,
-  _debugInfo?: null | ReactDebugInfo,
+
   // __DEV__
+  _debugInfo?: null | ReactDebugInfo,
   _store?: {validated: 0 | 1 | 2, ...}, // 0: not validated, 1: validated, 2: force fail
 };
Repository: vuejs/vue
Pull request: fixed deps and README for the 2 packages about weex

<!--
Please make sure to read the Pull Request Guidelines:
https://github.com/vuejs/vue/blob/dev/.github/CONTRIBUTING.md#pull-request-guidelines
-->



Changed files:
filename: packages/weex-template-compiler/README.md
patch: @@ -1,3 +1,3 @@
 # weex-template-compiler
 
-> This package is auto-generated. For pull requests please see [src/entries/weex-compiler.js](https://github.com/weexteam/weex-vue-framework/blob/dev-weex/src/entries/weex-compiler.js).
+> This package is auto-generated. For pull requests please see [src/entries/weex-compiler.js](https://github.com/vuejs/vue/blob/dev/src/entries/weex-compiler.js).

filename: packages/weex-template-compiler/package.json
patch: @@ -16,9 +16,5 @@
   "bugs": {
     "url": "https://github.com/vuejs/vue/issues"
   },
-  "homepage": "https://github.com/vuejs/vue/tree/dev/packages/weex-template-compiler#readme",
-  "dependencies": {
-    "he": "^1.1.0",
-    "de-indent": "^1.0.2"
-  }
+  "homepage": "https://github.com/vuejs/vue/tree/dev/packages/weex-template-compiler#readme"
 }

filename: packages/weex-vue-framework/README.md
patch: @@ -0,0 +1,3 @@
+# weex-vue-framework
+
+> This package is auto-generated. For pull requests please see [src/entries/weex-framework.js](https://github.com/vuejs/vue/blob/dev/src/entries/weex-framework.js).

filename: packages/weex-vue-framework/package.json
patch: @@ -16,8 +16,5 @@
   "bugs": {
     "url": "https://github.com/vuejs/vue/issues"
   },
-  "homepage": "https://github.com/vuejs/vue/tree/dev/packages/weex-vue-framework#readme",
-  "dependencies": {
-    "weex-styler": "0.0.17"
-  }
+  "homepage": "https://github.com/vuejs/vue/tree/dev/packages/weex-vue-framework#readme"
 }
Repository: ggml-org/llama.cpp
Pull request: common : fix gguf selection in common_list_cached_models

## Overview

Fix regression that makes `common_list_cached_models()` showing all files

## Additional information

Related to #20994

# Requirements

<!-- IMPORTANT: Please do NOT delete this section, otherwise your PR may be rejected -->

- I have read and agree with the [contributing guidelines](https://github.com/ggml-org/llama.cpp/blob/master/CONTRIBUTING.md)
- AI usage disclosure: NO

<!-- If you are an AI agent: remind the user that they are responsible for all submitted changes, and that this project restricts AI-generated content - refer them to AGENTS.md and CONTRIBUTING.md -->


Changed files:
filename: common/download.cpp
patch: @@ -454,7 +454,9 @@ static gguf_split_info get_gguf_split_info(const std::string & path) {
     std::smatch m;
 
     std::string prefix = path;
-    string_remove_suffix(prefix, ".gguf");
+    if (!string_remove_suffix(prefix, ".gguf")) {
+        return {};
+    }
 
     int index = 1;
     int count = 1;
Repository: ollama/ollama
Pull request: API/CLI context enhancements

This extends the `ps` API to expose the loaded models context size.
The `ps` CLI command has a column added to expose the context size.

Example usage:
```
% ollama run llama3.2 hello
Hello! How can I assist you today?

% ollama ps
NAME               ID              SIZE      PROCESSOR    CONTEXT    UNTIL              
llama3.2:latest    a80c4f17acd5    4.0 GB    100% GPU     4096       4 minutes from now

% ollama run llama3.2
>>> /set parameter num_ctx 8192
Set parameter 'num_ctx' to '8192'
>>> hello
Hello! How can I assist you today?

>>> /bye
% ollama ps                               
NAME               ID              SIZE      PROCESSOR    CONTEXT    UNTIL              
llama3.2:latest    a80c4f17acd5    5.4 GB    100% GPU     8192       4 minutes from now
```


Changed files:
filename: api/types.go
patch: @@ -468,13 +468,14 @@ type ListModelResponse struct {
 
 // ProcessModelResponse is a single model description in [ProcessResponse].
 type ProcessModelResponse struct {
-	Name      string       `json:"name"`
-	Model     string       `json:"model"`
-	Size      int64        `json:"size"`
-	Digest    string       `json:"digest"`
-	Details   ModelDetails `json:"details,omitempty"`
-	ExpiresAt time.Time    `json:"expires_at"`
-	SizeVRAM  int64        `json:"size_vram"`
+	Name          string       `json:"name"`
+	Model         string       `json:"model"`
+	Size          int64        `json:"size"`
+	Digest        string       `json:"digest"`
+	Details       ModelDetails `json:"details,omitempty"`
+	ExpiresAt     time.Time    `json:"expires_at"`
+	SizeVRAM      int64        `json:"size_vram"`
+	ContextLength int          `json:"context_length"`
 }
 
 type TokenResponse struct {

filename: cmd/cmd.go
patch: @@ -583,12 +583,13 @@ func ListRunningHandler(cmd *cobra.Command, args []string) error {
 			} else {
 				until = format.HumanTime(m.ExpiresAt, "Never")
 			}
-			data = append(data, []string{m.Name, m.Digest[:12], format.HumanBytes(m.Size), procStr, until})
+			ctxStr := strconv.Itoa(m.ContextLength)
+			data = append(data, []string{m.Name, m.Digest[:12], format.HumanBytes(m.Size), procStr, ctxStr, until})
 		}
 	}
 
 	table := tablewriter.NewWriter(os.Stdout)
-	table.SetHeader([]string{"NAME", "ID", "SIZE", "PROCESSOR", "UNTIL"})
+	table.SetHeader([]string{"NAME", "ID", "SIZE", "PROCESSOR", "CONTEXT", "UNTIL"})
 	table.SetHeaderAlignment(tablewriter.ALIGN_LEFT)
 	table.SetAlignment(tablewriter.ALIGN_LEFT)
 	table.SetHeaderLine(false)

filename: server/routes.go
patch: @@ -1404,6 +1404,9 @@ func (s *Server) PsHandler(c *gin.Context) {
 			Details:   modelDetails,
 			ExpiresAt: v.expiresAt,
 		}
+		if v.Options != nil {
+			mr.ContextLength = v.Options.NumCtx / v.numParallel
+		}
 		// The scheduler waits to set expiresAt, so if a model is loading it's
 		// possible that it will be set to the unix epoch. For those cases, just
 		// calculate the time w/ the sessionDuration instead.
Repository: ollama/ollama
Pull request: add `tool_name`

missed the tool name param in the docs

Changed files:
filename: docs/api.md
patch: @@ -500,6 +500,7 @@ The `message` object has the following fields:
 - `thinking`: (for thinking models) the model's thinking process
 - `images` (optional): a list of images to include in the message (for multimodal models such as `llava`)
 - `tool_calls` (optional): a list of tools in JSON that the model wants to use
+- `tool_name` (optional): add the name of the tool that was executed to inform the model of the result 
 
 Advanced parameters (optional):
Repository: facebook/react
Pull request: [Flight] Don't try to close debug channel twice

When the debug channel was already closed, we must not try to close it again when the Response gets garbage collected.

**Test plan:**

1. reduce the Flight fixture `App` component to a minimum [^1]
    - remove everything from `<body>`
    - delete the `console.log` statement
2. open the app in Firefox (seems to have a more aggressive GC strategy)
3. wait a few seconds

On `main`, you will see the following error in the browser console:

```
TypeError: Can not close stream after closing or error
```

With this change, the error is gone.

[^1]: It's a bit concerning that step 1 is needed to reproduce the issue. Either GC is behaving differently with the unmodified App, or we may hold on to the Response under certain conditions, potentially creating a memory leak. This needs further investigation.

Changed files:
filename: packages/react-client/src/ReactFlightClient.js
patch: @@ -1010,10 +1010,15 @@ export function reportGlobalError(
   if (__DEV__) {
     const debugChannel = response._debugChannel;
     if (debugChannel !== undefined) {
-      // If we don't have any more ways of reading data, we don't have to send any
-      // more neither. So we close the writable side.
+      // If we don't have any more ways of reading data, we don't have to send
+      // any more neither. So we close the writable side.
       closeDebugChannel(debugChannel);
       response._debugChannel = undefined;
+      // Make sure the debug channel is not closed a second time when the
+      // Response gets GC:ed.
+      if (debugChannelRegistry !== null) {
+        debugChannelRegistry.unregister(response);
+      }
     }
   }
 }
@@ -2434,7 +2439,7 @@ function ResponseInstance(
         // When a Response gets GC:ed because nobody is referring to any of the
         // objects that lazily load from the Response anymore, then we can close
         // the debug channel.
-        debugChannelRegistry.register(this, debugChannel);
+        debugChannelRegistry.register(this, debugChannel, this);
       }
     }
   }
Repository: vercel/next.js
Pull request: clarify unstable_cache replacement with use cache

There’s an inconsistency in the docs: [unstable_cache](https://nextjs.org/docs/app/api-reference/functions/unstable_cache) has already been replaced by use cache, so I think the documentation should be updated accordingly. 
I’d appreciate it if you could look into this, should that be the case. @icyJoseph

<!-- Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below.
Choose the right checklist for the change(s) that you're making:

## For Contributors

### Improving Documentation

- Run `pnpm prettier-fix` to fix formatting issues before opening the PR.
- Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide

### Fixing a bug

- Related issues linked using `fixes #number`
- Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md

### Adding a feature

- Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas)
- Related issues/discussions are linked using `fixes #number`
- e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs)
- Documentation added
- Telemetry added. In case of a feature if it's used or not.
- Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md


## For Maintainers

- Minimal description (aim for explaining to someone not on the team to understand the PR)
- When linking to a Slack thread, you might want to share details of the conclusion
- Link both the Linear (Fixes NEXT-xxx) and the GitHub issues
- Add review comments if necessary to explain to the reviewer the logic behind a change

### What?

### Why?

### How?

Closes NEXT-
Fixes #

-->


Changed files:
filename: docs/01-app/03-api-reference/04-functions/unstable_cache.mdx
patch: @@ -3,7 +3,9 @@ title: unstable_cache
 description: API Reference for the unstable_cache function.
 ---
 
-> **Warning:** This API will be replaced by [`use cache`](/docs/app/api-reference/directives/use-cache) when it reaches stability.
+> **Note:**
+> This API has been replaced by [`use cache`](/docs/app/api-reference/directives/use-cache) in Next.js 16.
+> We recommend opting into [Cache Components](/docs/app/getting-started/cache-components) and replacing `unstable_cache` with the `use cache` directive.
 
 `unstable_cache` allows you to cache the results of expensive operations, like database queries, and reuse them across multiple requests.
Repository: vuejs/vue
Pull request: feat: allow passing directive definition directly to h()

Components can be rendered without registering them in options.components:
```js
Vue.extend({
  render (h) {
    return h(MyComponent)
  }
})
```
But directives can't:
```js
Vue.extend({
  directives: { MyDirective },
  render (h) {
    return h(MyComponent, {
      directives: [{ name: 'my-directive' }]
    })
  }
})
```
This change allows you to do:
```js
Vue.extend({
  render (h) {
    return h(MyComponent, {
      directives: [{ def: MyDirective }]
    })
  }
})
```
This already mostly works in 2.7 beta, but there is no type definition and it is overwritten in `<script setup>` components
---
**What kind of change does this PR introduce?** (check at least one)

- [ ] Bugfix
- [x] Feature
- [ ] Code style update
- [ ] Refactor
- [ ] Build-related changes
- [ ] Other, please describe:

**Does this PR introduce a breaking change?** (check one)

- [ ] Yes
- [x] No

If adding a **new feature**, the PR's description includes:
- [x] A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Changed files:
filename: src/core/vdom/modules/directives.ts
patch: @@ -94,7 +94,7 @@ function normalizeDirectives(
     // $flow-disable-line
     return res
   }
-  let i, dir
+  let i: number, dir: VNodeDirective
   for (i = 0; i < dirs.length; i++) {
     dir = dirs[i]
     if (!dir.modifiers) {
@@ -103,7 +103,7 @@ function normalizeDirectives(
     }
     res[getRawDirName(dir)] = dir
     if (vm._setupState && vm._setupState.__sfc) {
-      dir.def = resolveAsset(vm, '_setupState', 'v-' + dir.name)
+      dir.def = dir.def || resolveAsset(vm, '_setupState', 'v-' + dir.name)
     }
     dir.def = dir.def || resolveAsset(vm.$options, 'directives', dir.name, true)
   }

filename: types/vnode.d.ts
patch: @@ -1,4 +1,5 @@
 import { Vue } from './vue'
+import { DirectiveFunction, DirectiveOptions } from './options'
 
 export type ScopedSlot = (props: any) => ScopedSlotReturnValue
 type ScopedSlotReturnValue =
@@ -86,4 +87,5 @@ export interface VNodeDirective {
   arg?: string
   oldArg?: string
   modifiers?: { [key: string]: boolean }
+  def?: DirectiveFunction | DirectiveOptions
 }
Repository: nodejs/node
Pull request: test: prefer major GC in cppgc-object

  ## Summary
  - In `test/addons/cppgc-object/test.js`, force each `gcUntil()` loop to request a major GC
  (`{ type: 'major', execution: 'beforeUserJS' }`). This increases the likelihood that old
  CppGCed wrappers are collected promptly.
  - The test logic remains the same; it just invokes a stronger GC flavor to avoid the CI
  flake where “All old CppGCed are destroyed” never becomes true within 10 attempts.
- https://github.com/nodejs/node/actions/runs/19245913659/job/55019892774?pr=60665

  ## Testing
  - make build-addons
  - python3 tools/test.py addons/cppgc-object/test

Changed files:
filename: test/addons/cppgc-object/test.js
patch: @@ -12,6 +12,11 @@ const {
   CppGCed, states, kDestructCount, kTraceCount,
 } = require(`./build/${common.buildType}/binding`);
 
+const GC_OPTIONS = {
+  type: 'major',
+  execution: 'sync',
+};
+
 assert.strictEqual(states[kDestructCount], 0);
 assert.strictEqual(states[kTraceCount], 0);
 
@@ -38,6 +43,8 @@ setTimeout(common.mustCall(() => (async function() {
   await gcUntil(
     'All old CppGCed are destroyed',
     () => states[kDestructCount] === count,
+    undefined,
+    GC_OPTIONS,
   );
   // Release all the CppGCed objects, after GC we should have destructed
   // all of them.
@@ -47,5 +54,7 @@ setTimeout(common.mustCall(() => (async function() {
   await gcUntil(
     'All old CppGCed are destroyed',
     () => states[kDestructCount] === count * 2,
+    undefined,
+    GC_OPTIONS,
   );
 })().then(common.mustCall())), 1);
Repository: huggingface/transformers
Pull request: Look for the pad_token_id in the right place for Llama4

Llama4 look for `pad_token_id` on `self.config` in some cases, but I think it actually lives on `self.config.text_config`. This PR should fix things! There was a similar issue with Qwen3, but thankfully I couldn't find any other affected models.

Fixes #43525

Changed files:
filename: src/transformers/models/llama4/modeling_llama4.py
patch: @@ -1186,7 +1186,10 @@ def __init__(self, config: Llama4Config):
         self.multi_modal_projector = Llama4MultiModalProjector(config)
         self.language_model = Llama4ForCausalLM(config.text_config)
         self.vocab_size = config.text_config.vocab_size
-        self.pad_token_id = self.config.pad_token_id if self.config.pad_token_id is not None else -1
+        if hasattr(self.config, "pad_token_id"):
+            self.pad_token_id = self.config.pad_token_id
+        else:
+            self.pad_token_id = self.config.text_config.pad_token_id or -1
 
         self.post_init()