helloadhavan/github_issues huggingface dataset:
Repository: nodejs/node
Pull request: tools: only report commit validation failure on Slack

Refs: https://github.com/nodejs/node/pull/61050#issuecomment-3674352808

<!--
Before submitting a pull request, please read:

- the CONTRIBUTING guide at https://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md
- the commit message formatting guidelines at
  https://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#commit-message-guidelines

For code changes:
1. Include tests for any bug fixes or new features.
2. Update documentation if relevant.
3. Ensure that `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes.

If you believe this PR should be highlighted in the Node.js CHANGELOG
please add the `notable-change` label.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.
-->


Changed files:
filename: .github/workflows/notify-on-push.yml
patch: @@ -36,11 +36,12 @@ jobs:
         with:
           persist-credentials: false
       - name: Check commit message
+        id: commit-check
         run: npx -q core-validate-commit "$COMMIT"
         env:
           COMMIT: ${{ github.event.after }}
       - name: Slack Notification
-        if: failure()
+        if: ${{ failure() && steps.commit-check.conclusion == 'failure' }}
         uses: rtCamp/action-slack-notify@e31e87e03dd19038e411e38ae27cbad084a90661  # 2.3.3
         env:
           SLACK_COLOR: '#DE512A'
Repository: huggingface/transformers
Pull request: Update cpu torchao usage

Update doc for CPU torchao int4 weight-only usage as api changed.

Changed files:
filename: docs/source/en/quantization/torchao.md
patch: @@ -387,16 +387,14 @@ print(tokenizer.decode(output[0], skip_special_tokens=True))
 <hfoption id="int4-weight-only">
 
 > [!TIP]
-> Run the quantized model on a CPU by changing `device_map` to `"cpu"` and `layout` to `Int4CPULayout()`.
+> CPU int4 weight-only quantization requires torchao version 0.15.0 or later.
 
 ```py
 import torch
 from transformers import TorchAoConfig, AutoModelForCausalLM, AutoTokenizer
-from torchao.quantization import Int4WeightOnlyConfig
-from torchao.dtypes import Int4CPULayout
+from torchao.prototype.int4_opaque_tensor import Int4WeightOnlyOpaqueTensorConfig
 
-quant_config = Int4WeightOnlyConfig(group_size=128, layout=Int4CPULayout(), int4_packing_format="opaque")
-quantization_config = TorchAoConfig(quant_type=quant_config)
+quantization_config = TorchAoConfig(Int4WeightOnlyOpaqueTensorConfig(group_size=128))
 
 # Load and quantize the model
 quantized_model = AutoModelForCausalLM.from_pretrained(
Repository: vuejs/vue
Pull request: fix(codegen): support IE11 and Edge use of "Esc" key (close #7880)

Closes #7880

IE11 and Edge use "Esc" as key name, other browsers use "Escape".

I was able to test on Edge 16/15/14 and IE11.

- More reference: https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/5290772/
- Reproduction link: http://codepen.io/anon/pen/QjxPGB

![screenshot 2018-03-23 13 05 45](https://user-images.githubusercontent.com/1292945/37840101-f5ed1270-2e9a-11e8-890c-f0c761de0abc.png)




<!-- PULL REQUEST TEMPLATE -->
<!-- (Update "[ ]" to "[x]" to check a box) -->

**What kind of change does this PR introduce?** (check at least one)

- [x] Bugfix
- [ ] Feature
- [ ] Code style update
- [ ] Refactor
- [ ] Build-related changes
- [ ] Other, please describe:

**Does this PR introduce a breaking change?** (check one)

- [ ] Yes
- [x] No

If yes, please describe the impact and migration path for existing applications:

**The PR fulfills these requirements:**

- [x] It's submitted to the `dev` branch for v2.x (or to a previous version branch), _not_ the `master` branch
- [x] When resolving a specific issue, it's referenced in the PR's title (e.g. `fix #xxx[,#xxx]`, where "xxx" is the issue number)
- [x] All tests are passing: https://github.com/vuejs/vue/blob/dev/.github/CONTRIBUTING.md#development-setup
- [ ] New/updated tests are included

If adding a **new feature**, the PR's description includes:
- [x] A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)


Changed files:
filename: src/compiler/codegen/events.js
patch: @@ -18,7 +18,8 @@ const keyCodes: { [key: string]: number | Array<number> } = {
 
 // KeyboardEvent.key aliases
 const keyNames: { [key: string]: string | Array<string> } = {
-  esc: 'Escape',
+  // #7880: IE11 and Edge use `Esc` for Escape key name.
+  esc: ['Esc', 'Escape'],
   tab: 'Tab',
   enter: 'Enter',
   space: ' ',
Repository: vercel/next.js
Pull request: Warn when overriding Cache-Control header on `/_next/` routes

Custom `Cache-Control` headers on `/_next/` routes can cause hard-to-debug development behaviors. Normally the dev server sends no-cache values to ensure that assets are always fresh. If a developer sets the max-age or immutable flag,, the browser can cache resources between requests, even if the source changes.

Adding a warning will at least make this problem easier to debug.

Changed files:
filename: packages/next/src/lib/load-custom-routes.ts
patch: @@ -725,6 +725,27 @@ export default async function loadCustomRoutes(
     )
   }
 
+  const cacheControlSources: string[] = []
+  for (const headerRoute of headers) {
+    if (!headerRoute.source.startsWith('/_next/')) {
+      continue
+    }
+    for (const header of headerRoute.headers) {
+      if (header.key.toLowerCase() === 'cache-control') {
+        cacheControlSources.push(headerRoute.source)
+        break
+      }
+    }
+  }
+  if (cacheControlSources.length > 0) {
+    console.warn(
+      bold(yellow(`Warning: `)) +
+        `Custom Cache-Control headers detected for the following routes:\n` +
+        cacheControlSources.map((source) => `  - ${source}`).join('\n') +
+        `\n\nSetting a custom Cache-Control header can break Next.js development behavior.`
+    )
+  }
+
   if (config.experimental?.useSkewCookie && config.deploymentId) {
     headers.unshift({
       source: '/:path*',
Repository: vercel/next.js
Pull request: [test] Remove obsolete reference to `NEXT_TEST_SKIP_RETRY_MANIFEST`

The manifest is not used anymore as of #76361.

Changed files:
filename: run-tests.js
patch: @@ -57,12 +57,6 @@ const isTestJob = !!process.env.NEXT_TEST_JOB
 const shouldContinueTestsOnError =
   process.env.NEXT_TEST_CONTINUE_ON_ERROR === 'true'
 
-// Check env to load a list of test paths to skip retry. This is to be used in conjunction with NEXT_TEST_CONTINUE_ON_ERROR,
-// When try to run all of the tests regardless of pass / fail and want to skip retrying `known` failed tests.
-// manifest should be a json file with an array of test paths.
-const skipRetryTestManifest = process.env.NEXT_TEST_SKIP_RETRY_MANIFEST
-  ? require(process.env.NEXT_TEST_SKIP_RETRY_MANIFEST)
-  : []
 const KV_TIMINGS_KEY = 'test-timings'
 
 const kvClient =
@@ -671,24 +665,10 @@ ${ENDGROUP}`)
   const runTest = async (/** @type {TestFile} */ test) => {
     let passed = false
 
-    const shouldSkipRetries = skipRetryTestManifest.find((t) =>
-      t.includes(test.file)
-    )
-    const numRetries = shouldSkipRetries ? 0 : originalRetries
-    if (shouldSkipRetries) {
-      console.log(
-        `Skipping retry for ${test.file} due to skipRetryTestManifest`
-      )
-    }
-
     for (let i = 0; i < numRetries + 1; i++) {
       try {
         console.log(`Starting ${test.file} retry ${i}/${numRetries}`)
-        const time = await runTestOnce(
-          test,
-          shouldSkipRetries || i === numRetries,
-          shouldSkipRetries || i > 0
-        )
+        const time = await runTestOnce(test, i === numRetries, i > 0)
         timings.push({
           file: test.file,
           time,
@@ -765,7 +745,6 @@ ${ENDGROUP}`)
 
   const directorySemas = new Map()
 
-  const originalRetries = numRetries
   const results = await Promise.allSettled(
     tests.map(async (test) => {
       const dirName = path.dirname(test.file)
Repository: ollama/ollama
Pull request: doc: add link to Lunary integration to the Observability section


Changed files:
filename: README.md
patch: @@ -551,7 +551,7 @@ See the [API documentation](./docs/api.md) for all endpoints.
 - [llama.cpp](https://github.com/ggerganov/llama.cpp) project founded by Georgi Gerganov.
 
 ### Observability
-
+- [Lunary](https://lunary.ai/docs/integrations/ollama) is the leading open-source LLM observability platform. It provides a variety of enterprise-grade features such as real-time analytics, prompt templates management, PII masking, and comprehensive agent tracing.
 - [OpenLIT](https://github.com/openlit/openlit) is an OpenTelemetry-native tool for monitoring Ollama Applications & GPUs using traces and metrics.
 - [HoneyHive](https://docs.honeyhive.ai/integrations/ollama) is an AI observability and evaluation platform for AI agents. Use HoneyHive to evaluate agent performance, interrogate failures, and monitor quality in production.
 - [Langfuse](https://langfuse.com/docs/integrations/ollama) is an open source LLM observability platform that enables teams to collaboratively monitor, evaluate and debug AI applications.
Repository: ggml-org/llama.cpp
Pull request: Adding LLMKube to Infrastructure list on README

LLMKube is a Kubernetes operator for llama.cpp. It handles model downloads, GPU scheduling (Nvidia CUDA and Apple Silicon Metal), health probes, and Prometheus metrics through Metal and InferenceService CRDs.

Related: #6546

Changed files:
filename: README.md
patch: @@ -259,6 +259,8 @@ Instructions for adding support for new models: [HOWTO-add-model.md](docs/develo
 - [llama-swap](https://github.com/mostlygeek/llama-swap) - transparent proxy that adds automatic model switching with llama-server
 - [Kalavai](https://github.com/kalavai-net/kalavai-client) - Crowdsource end to end LLM deployment at any scale
 - [llmaz](https://github.com/InftyAI/llmaz) - ☸️ Easy, advanced inference platform for large language models on Kubernetes.
+- [LLMKube](https://github.com/defilantech/llmkube) - Kubernetes operator for llama.cpp with multi-GPU and Apple Silicon Metal
+  support"
 </details>
 
 <details>
Repository: vercel/next.js
Pull request: [scripts] Avoid conflicting type for `pack-next --compress`

`type: 'string'` conflicts with `choices: T[]`. It's basically `string | T` which just collapses to `string` if `T` is a union of string literals. 

Before:
```console
$ p pack-next --help
...
 --compress ... [string] [choices: "none", "strip"]
```

After: 
```console
$ p pack-next --help
...
 --compress ... [choices: "none", "strip"]

Changed files:
filename: scripts/pack-next.ts
patch: @@ -24,14 +24,6 @@ const NEXT_BA_TARBALL = `${TARBALLS}/next-bundle-analyzer.tar`
 
 type CompressOpt = 'none' | 'strip' | 'objcopy-zlib' | 'objcopy-zstd'
 
-interface CliOptions {
-  jsBuild?: boolean
-  project?: string
-  tar?: boolean
-  compress?: CompressOpt
-  _: string[]
-}
-
 const cliOptions = yargs(hideBin(process.argv))
   .scriptName('pack-next')
   .command('$0', 'Pack Next.js for testing in external projects')
@@ -50,7 +42,6 @@ const cliOptions = yargs(hideBin(process.argv))
     describe: 'Create tarballs instead of direct reflinks',
   })
   .option('compress', {
-    type: 'string',
     describe:
       'How compress the binary, useful on platforms where tarballs can ' +
       'exceed 2 GiB, which causes ERR_FS_FILE_TOO_LARGE with pnpm. Defaults ' +
@@ -59,22 +50,24 @@ const cliOptions = yargs(hideBin(process.argv))
     choices: [
       'none',
       'strip',
-      ...(process.platform === 'linux' ? ['objcopy-zlib', 'objcopy-zstd'] : []),
+      ...(process.platform === 'linux'
+        ? (['objcopy-zlib', 'objcopy-zstd'] as const)
+        : ([] as const)),
     ] as const,
   })
   .check((opts) => {
-    const compress = opts.compress as CompressOpt | undefined
+    const compress = opts.compress
     if (!opts.tar && (compress ?? 'none') !== 'none') {
       throw new Error('--compress is only valid in combination with --tar')
     }
     return true
   })
   .middleware((opts) => {
     if (opts.tar && process.platform === 'linux' && opts.compress == null) {
-      ;(opts as CliOptions).compress = 'strip'
+      opts.compress = 'strip'
     }
   })
-  .strict().argv as unknown as CliOptions
+  .strict().argv
 
 interface PackageFiles {
   nextFile: string
@@ -97,7 +90,7 @@ async function main(): Promise<void> {
     await Promise.all(binaries.map((bin) => fs.rm(bin)))
   }
 
-  await buildNative(cliOptions._)
+  await buildNative(cliOptions._ as string[])
 
   if (cliOptions.tar) {
     await fs.mkdir(TARBALLS, { recursive: true })
Repository: ggml-org/llama.cpp
Pull request: server : correct index on finish in OAI completion streams

When calling `/v1/chat/completions` with `"stream": true` and an `n` value greater than 1, the stop message would always have its `index` set to `0` instead of the correct index, making it impossible to tell which stream actually finished.

Changed files:
filename: tools/server/server-task.cpp
patch: @@ -827,7 +827,7 @@ json server_task_result_cmpl_final::to_json_oaicompat_chat_stream() {
             {"choices", json::array({
                 json {
                     {"finish_reason", nullptr},
-                    {"index", 0},
+                    {"index", index},
                     {"delta", common_chat_msg_diff_to_json_oaicompat(diff)},
                 },
             })},
@@ -843,7 +843,7 @@ json server_task_result_cmpl_final::to_json_oaicompat_chat_stream() {
         {"choices", json::array({
             json {
                 {"finish_reason", finish_reason},
-                {"index", 0},
+                {"index", index},
                 {"delta", json::object()},
             },
         })},
Repository: ollama/ollama
Pull request: fix default modelfile for create


Changed files:
filename: cmd/cmd.go
patch: @@ -59,7 +59,7 @@ func getModelfileName(cmd *cobra.Command) (string, error) {
 
 	_, err = os.Stat(absName)
 	if err != nil {
-		return filename, err
+		return "", err
 	}
 
 	return absName, nil

filename: cmd/cmd_test.go
patch: @@ -279,7 +279,7 @@ func TestGetModelfileName(t *testing.T) {
 			name:          "no modelfile specified, no modelfile exists",
 			modelfileName: "",
 			fileExists:    false,
-			expectedName:  "Modelfile",
+			expectedName:  "",
 			expectedErr:   os.ErrNotExist,
 		},
 		{
@@ -293,7 +293,7 @@ func TestGetModelfileName(t *testing.T) {
 			name:          "modelfile specified, no modelfile exists",
 			modelfileName: "crazyfile",
 			fileExists:    false,
-			expectedName:  "crazyfile",
+			expectedName:  "",
 			expectedErr:   os.ErrNotExist,
 		},
 		{
Repository: facebook/react
Pull request: Clean up findFiberByHostInstance from DevTools Hook

The need for this was removed in https://github.com/facebook/react/pull/30831

Since the new DevTools version has been released for a while and we expect people to more or less auto-update. Future versions of React don't need this.

Once we remove the remaining uses of `getInstanceFromNode` e.g. in the deprecated internal `findDOMNode`/`findNodeHandle` and the event system, we can completely remove the tagging of DOM nodes.

Changed files:
filename: packages/react-reconciler/src/ReactFiberReconciler.js
patch: @@ -42,7 +42,6 @@ import {enableSchedulingProfiler} from 'shared/ReactFeatureFlags';
 import ReactSharedInternals from 'shared/ReactSharedInternals';
 import {
   getPublicInstance,
-  getInstanceFromNode,
   rendererVersion,
   rendererPackageName,
   extraDevToolsConfig,
@@ -847,7 +846,6 @@ export function injectIntoDevTools(): boolean {
     version: rendererVersion,
     rendererPackageName: rendererPackageName,
     currentDispatcherRef: ReactSharedInternals,
-    findFiberByHostInstance: getInstanceFromNode,
     // Enables DevTools to detect reconciler version rather than renderer version
     // which may not match for third party renderers.
     reconcilerVersion: ReactVersion,
Repository: ggml-org/llama.cpp
Pull request: cli: Don't clear system prompt when using '/clear'

Add system prompt to messages when clearing chat history.


Changed files:
filename: tools/cli/cli.cpp
patch: @@ -382,12 +382,15 @@ int main(int argc, char ** argv) {
         modalities += ", audio";
     }
 
-    if (!params.system_prompt.empty()) {
-        ctx_cli.messages.push_back({
-            {"role",    "system"},
-            {"content", params.system_prompt}
-        });
-    }
+    auto add_system_prompt = [&]() {
+        if (!params.system_prompt.empty()) {
+            ctx_cli.messages.push_back({
+                {"role",    "system"},
+                {"content", params.system_prompt}
+            });
+        }
+    };
+    add_system_prompt();
 
     console::log("\n");
     console::log("%s\n", LLAMA_ASCII_LOGO);
@@ -477,6 +480,8 @@ int main(int argc, char ** argv) {
             }
         } else if (string_starts_with(buffer, "/clear")) {
             ctx_cli.messages.clear();
+            add_system_prompt();
+
             ctx_cli.input_files.clear();
             console::log("Chat history cleared.\n");
             continue;
Repository: ollama/ollama
Pull request: ci: use windows-2022 to sign and bundle

ollama requires `vcruntime140_1.dll` which isn't found on 2019. previously the job used the windows runner (2019) but it explicitly installs 2022 to build the app. since the sign job doesn't actually build anything, it can use the windows-2022 runner instead.

resolves #8936 

Changed files:
filename: .github/workflows/release.yaml
patch: @@ -242,7 +242,7 @@ jobs:
             dist\${{ matrix.os }}-${{ matrix.arch }}-app.exe
 
   windows-sign:
-    runs-on: windows
+    runs-on: windows-2022
     environment: release
     needs: [windows-depends, windows-build]
     steps:

filename: scripts/build_windows.ps1
patch: @@ -162,8 +162,11 @@ function gatherDependencies() {
         $depArch=$script:TARGET_ARCH
     }
     if ($depArch -eq "x64") {
+        write-host "cp ${env:VCToolsRedistDir}\${depArch}\Microsoft.VC*.CRT\msvcp140*.dll ${script:DIST_DIR}\lib\ollama\"
         cp "${env:VCToolsRedistDir}\${depArch}\Microsoft.VC*.CRT\msvcp140*.dll" "${script:DIST_DIR}\lib\ollama\"
+        write-host "cp ${env:VCToolsRedistDir}\${depArch}\Microsoft.VC*.CRT\vcruntime140.dll ${script:DIST_DIR}\lib\ollama\"
         cp "${env:VCToolsRedistDir}\${depArch}\Microsoft.VC*.CRT\vcruntime140.dll" "${script:DIST_DIR}\lib\ollama\"
+        write-host "cp ${env:VCToolsRedistDir}\${depArch}\Microsoft.VC*.CRT\vcruntime140_1.dll ${script:DIST_DIR}\lib\ollama\"
         cp "${env:VCToolsRedistDir}\${depArch}\Microsoft.VC*.CRT\vcruntime140_1.dll" "${script:DIST_DIR}\lib\ollama\"
         $llvmCrtDir="$env:VCToolsRedistDir\..\..\..\Tools\Llvm\${depArch}\bin"
         foreach ($part in $("runtime", "stdio", "filesystem", "math", "convert", "heap", "string", "time", "locale", "environment")) {
Repository: nodejs/node
Pull request: process: preserve AsyncLocalStorage on queueMicrotask only when needed

Does the same optimization as https://github.com/nodejs/node/pull/59873 for `queueMicrotask`

branch:

```sh
./node benchmark/run.js --filter queue-microtask process

process/queue-microtask-breadth.js
process/queue-microtask-breadth.js n=400000: 18,938,347.488090977

process/queue-microtask-depth.js
process/queue-microtask-depth.js n=1200000: 35,862,646.06556887
```

main

```sh
./node benchmark/run.js --filter queue-microtask process

process/queue-microtask-breadth.js
process/queue-microtask-breadth.js n=400000: 5,198,220.087856157

process/queue-microtask-depth.js
process/queue-microtask-depth.js n=1200000: 12,707,696.847598467
```

Changed files:
filename: lib/internal/process/task_queues.js
patch: @@ -25,6 +25,7 @@ const {
 
 const {
   getDefaultTriggerAsyncId,
+  getHookArrays,
   newAsyncId,
   initHooksExist,
   emitInit,
@@ -158,13 +159,18 @@ const defaultMicrotaskResourceOpts = { requireManualDestroy: true };
 function queueMicrotask(callback) {
   validateFunction(callback, 'callback');
 
-  const asyncResource = new AsyncResource(
-    'Microtask',
-    defaultMicrotaskResourceOpts,
-  );
-  asyncResource.callback = callback;
-
-  enqueueMicrotask(FunctionPrototypeBind(runMicrotask, asyncResource));
+  const contextFrame = AsyncContextFrame.current();
+  if (contextFrame || getHookArrays()[0].length > 0) {
+    const asyncResource = new AsyncResource(
+      'Microtask',
+      defaultMicrotaskResourceOpts,
+    );
+    asyncResource.callback = callback;
+    enqueueMicrotask(FunctionPrototypeBind(runMicrotask, asyncResource));
+  } else {
+    // Fast path: no AsyncLocalStorage in use
+    enqueueMicrotask(callback);
+  }
 }
 
 module.exports = {

filename: test/fixtures/errors/async_error_nexttick_main.snapshot
patch: @@ -1,7 +1,7 @@
 Error: test
     at one (*fixtures*async-error.js:4:9)
     at two (*fixtures*async-error.js:17:9)
-    at process.processTicksAndRejections (node:internal*process*task_queues:103:5)
+    at process.processTicksAndRejections (node:internal*process*task_queues:104:5)
     at async three (*fixtures*async-error.js:20:3)
     at async four (*fixtures*async-error.js:24:3)
     at async main (*async_error_nexttick_main.js:7:5)