helloadhavan/github_issues huggingface dataset:
Repository: rust-lang/rust
Pull request: Don't use disk-cache for query `def_kind`

<!-- homu-ignore:start -->
*[View all comments](https://triagebot.infra.rust-lang.org/gh-comments/rust-lang/rust/pull/154292)*
<!-- homu-ignore:end -->

From what I can tell, the `def_kind` query has no local provider, and is always given its value via query feeding, usually from `TyCtxt::create_def`.

If that's the case, there should never be any opportunity for a previous value to be loaded from disk-cache, so serializing the current-session values is a waste of time.


Changed files:
filename: compiler/rustc_middle/src/queries.rs
patch: @@ -1436,8 +1436,10 @@ rustc_queries! {
 
     query def_kind(def_id: DefId) -> DefKind {
         desc { "looking up definition kind of `{}`", tcx.def_path_str(def_id) }
-        cache_on_disk
         separate_provide_extern
+        // This query has no local provider. For defs in the current crate,
+        // its value is always set by feeding when the `DefId` is created,
+        // usually in `TyCtxt::create_def`.
         feedable
     }
Repository: electron/electron
Pull request: ci: fetch clang-tidy package in fix-sync

Backport of #50704

See that PR for details.


Notes: none

Changed files:
filename: .github/actions/fix-sync/action.yml
patch: @@ -27,6 +27,7 @@ runs:
         python3 src/tools/clang/scripts/update.py
         # Refs https://chromium-review.googlesource.com/c/chromium/src/+/6667681
         python3 src/tools/clang/scripts/update.py --package objdump
+        python3 src/tools/clang/scripts/update.py --package clang-tidy
     - name: Fix esbuild
       if: ${{ inputs.target-platform != 'linux' }}
       uses: ./src/electron/.github/actions/cipd-install
Repository: ollama/ollama
Pull request: app: default app home view to new chat instead of launch


Changed files:
filename: app/store/database.go
patch: @@ -82,7 +82,7 @@ func (db *database) init() error {
 		websearch_enabled BOOLEAN NOT NULL DEFAULT 0,
 		selected_model TEXT NOT NULL DEFAULT '',
 		sidebar_open BOOLEAN NOT NULL DEFAULT 0,
-		last_home_view TEXT NOT NULL DEFAULT 'launch',
+		last_home_view TEXT NOT NULL DEFAULT 'chat',
 		think_enabled BOOLEAN NOT NULL DEFAULT 0,
 		think_level TEXT NOT NULL DEFAULT '',
 		cloud_setting_migrated BOOLEAN NOT NULL DEFAULT 0,
@@ -527,7 +527,7 @@ func (db *database) migrateV14ToV15() error {
 
 // migrateV15ToV16 adds the last_home_view column to the settings table
 func (db *database) migrateV15ToV16() error {
-	_, err := db.conn.Exec(`ALTER TABLE settings ADD COLUMN last_home_view TEXT NOT NULL DEFAULT 'launch'`)
+	_, err := db.conn.Exec(`ALTER TABLE settings ADD COLUMN last_home_view TEXT NOT NULL DEFAULT 'chat'`)
 	if err != nil && !duplicateColumnError(err) {
 		return fmt.Errorf("add last_home_view column: %w", err)
 	}

filename: app/store/store.go
patch: @@ -393,7 +393,7 @@ func (s *Store) Settings() (Settings, error) {
 	}
 
 	if settings.LastHomeView == "" {
-		settings.LastHomeView = "launch"
+		settings.LastHomeView = "chat"
 	}
 
 	return settings, nil

filename: app/ui/app/src/hooks/useSettings.ts
patch: @@ -52,7 +52,7 @@ export function useSettings() {
       thinkLevel: settingsData?.settings?.ThinkLevel ?? "none",
       selectedModel: settingsData?.settings?.SelectedModel ?? "",
       sidebarOpen: settingsData?.settings?.SidebarOpen ?? false,
-      lastHomeView: settingsData?.settings?.LastHomeView ?? "launch",
+      lastHomeView: settingsData?.settings?.LastHomeView ?? "chat",
     }),
     [settingsData?.settings],
   );

filename: app/ui/app/src/routes/index.tsx
patch: @@ -7,7 +7,8 @@ export const Route = createFileRoute("/")({
       queryKey: ["settings"],
       queryFn: getSettings,
     });
-    const chatId = settingsData?.settings?.LastHomeView === "chat" ? "new" : "launch";
+    const lastHomeView = settingsData?.settings?.LastHomeView ?? "chat";
+    const chatId = lastHomeView === "chat" ? "new" : "launch";
 
     throw redirect({
       to: "/c/$chatId",
Repository: facebook/react
Pull request: Fix typos: occured->occurred, teh->the, accomodate->accommodate

Fixed spelling errors in comments and error messages:
- Fixed 'occured' -> 'occurred' in ReactAsyncActions-test.js
- Fixed 'teh' -> 'the' in ReactFiberConfigDOM.js
- Fixed 'occured' -> 'occurred' in ErrorBoundary.js
- Fixed 'accomodate' -> 'accommodate' in InferMutationAliasingEffects.ts

<!--
  Thanks for submitting a pull request!
  We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.

  Before submitting a pull request, please make sure the following is done:

  1. Fork [the repository](https://github.com/facebook/react) and create your branch from `main`.
  2. Run `yarn` in the repository root.
  3. If you've fixed a bug or added code that should be tested, add tests!
  4. Ensure the test suite passes (`yarn test`). Tip: `yarn test --watch TestName` is helpful in development.
  5. Run `yarn test --prod` to test in the production environment. It supports the same options as `yarn test`.
  6. If you need a debugger, run `yarn test --debug --watch TestName`, open `chrome://inspect`, and press "Inspect".
  7. Format your code with [prettier](https://github.com/prettier/prettier) (`yarn prettier`).
  8. Make sure your code lints (`yarn lint`). Tip: `yarn linc` to only check changed files.
  9. Run the [Flow](https://flowtype.org/) type checks (`yarn flow`).
  10. If you haven't already, complete the CLA.

  Learn more about contributing: https://reactjs.org/docs/how-to-contribute.html
-->

## Summary

<!--
 Explain the **motivation** for making this change. What existing problem does the pull request solve?
-->

## How did you test this change?

<!--
  Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes the user interface.
  How exactly did you verify that your PR solves the issue you wanted to solve?
  If you leave this empty, your PR will very likely be closed.
-->


Changed files:
filename: packages/react-devtools-shared/src/devtools/views/ErrorBoundary/ErrorBoundary.js
patch: @@ -156,7 +156,7 @@ export default class ErrorBoundary extends Component<Props, State> {
           <CaughtErrorView
             callStack={callStack}
             componentStack={componentStack}
-            errorMessage={errorMessage || 'Error occured in inspected element'}
+            errorMessage={errorMessage || 'Error occurred in inspected element'}
             info={
               <>
                 React DevTools encountered an error while trying to inspect the
Repository: ollama/ollama
Pull request: Revert "enable flash attention for gemma4 (#15296)"

This reverts commit c8e0878814b4d19200d65571d3d2d35b4b48fd3e.

Fixes a performance regression - Perf run comparison:
```
                                    │ /tmp/0.20.0.log │       /tmp/0.20.1-flash.log        │     /tmp/0.20.1-no-flash.log      │
                                    │    token/sec    │  token/sec   vs base               │  token/sec   vs base              │
Model/name=gemma4:e2b/step=prefill        3.035k ± 1%   1.227k ± 2%  -59.57% (p=0.002 n=6)   3.040k ± 1%       ~ (p=0.310 n=6)
Model/name=gemma4:e2b/step=generate       144.92 ± 3%    95.09 ± 6%  -34.39% (p=0.002 n=6)   146.20 ± 2%  +0.89% (p=0.026 n=6)
Model/name=gemma4:e4b/step=prefill        1508.1 ± 5%    827.4 ± 3%  -45.14% (p=0.002 n=6)   1533.3 ± 2%       ~ (p=0.180 n=6)
Model/name=gemma4:e4b/step=generate        93.55 ± 1%    66.75 ± 5%  -28.64% (p=0.002 n=6)    94.75 ± 2%  +1.29% (p=0.026 n=6)
Model/name=gemma4:26b/step=prefill        1497.5 ± 1%    689.7 ± 1%  -53.95% (p=0.002 n=6)   1556.9 ± 1%  +3.97% (p=0.002 n=6)
Model/name=gemma4:26b/step=generate        86.95 ± 3%    70.63 ± 4%  -18.77% (p=0.002 n=6)    88.78 ± 1%  +2.09% (p=0.009 n=6)
geomean                                    447.9         260.7       -41.80%                  455.4       +1.67%
```

Changed files:
filename: fs/ggml/ggml.go
patch: @@ -890,7 +890,6 @@ func (f GGML) FlashAttention() bool {
 	return slices.Contains([]string{
 		"bert",
 		"gemma3",
-		"gemma4",
 		"glm4moelite",
 		"glmocr",
 		"gptoss", "gpt-oss",
Repository: ollama/ollama
Pull request: ggml: fix ROCm build for cublasGemmBatchedEx reserve wrapper

Add missing cublasGemmAlgo_t to hipblasGemmAlgo_t type mapping and cast away const qualifiers that hipblasGemmBatchedEx doesn't accept.

Changed files:
filename: llama/patches/0020-ggml-No-alloc-mode.patch
patch: @@ -229,7 +229,7 @@ diff --git a/ggml/src/ggml-cuda/common.cuh b/ggml/src/ggml-cuda/common.cuh
 index 9fcb2f9fd..e800ee8f6 100644
 --- a/ggml/src/ggml-cuda/common.cuh
 +++ b/ggml/src/ggml-cuda/common.cuh
-@@ -37,6 +37,62 @@
+@@ -37,6 +37,64 @@
  #include "vendors/cuda.h"
  #endif // defined(GGML_USE_HIP)
  
@@ -273,8 +273,10 @@ index 9fcb2f9fd..e800ee8f6 100644
 +        cublasComputeType_t computeType, cublasGemmAlgo_t algo) {
 +    if (!reserving_graph) {
 +        return cublasGemmBatchedEx(handle, transa, transb, m, n, k,
-+            alpha, Aarray, Atype, lda, Barray, Btype, ldb,
-+            beta, Carray, Ctype, ldc, batchCount, computeType, algo);
++            alpha, const_cast<const void **>(Aarray), Atype, lda,
++            const_cast<const void **>(Barray), Btype, ldb,
++            beta, const_cast<void **>(Carray), Ctype, ldc,
++            batchCount, computeType, algo);
 +    } else {
 +        return CUBLAS_STATUS_SUCCESS;
 +    }
@@ -343,6 +345,18 @@ index 9fcb2f9fd..e800ee8f6 100644
  };
  
  struct ggml_cuda_mm_fusion_args_host {
+diff --git a/ggml/src/ggml-cuda/vendors/hip.h b/ggml/src/ggml-cuda/vendors/hip.h
+index d89e35a8e..fe4b5349f 100644
+--- a/ggml/src/ggml-cuda/vendors/hip.h
++++ b/ggml/src/ggml-cuda/vendors/hip.h
+@@ -39,6 +39,7 @@
+ #define cublasCreate hipblasCreate
+ #define cublasDestroy hipblasDestroy
+ #define cublasGemmEx hipblasGemmEx
++#define cublasGemmAlgo_t hipblasGemmAlgo_t
+ #define cublasGemmBatchedEx hipblasGemmBatchedEx
+ #define cublasGemmStridedBatchedEx hipblasGemmStridedBatchedEx
+ #define cublasHandle_t hipblasHandle_t
 diff --git a/ggml/src/ggml-cuda/ggml-cuda.cu b/ggml/src/ggml-cuda/ggml-cuda.cu
 index 25548629d..eeaae3fe4 100644
 --- a/ggml/src/ggml-cuda/ggml-cuda.cu

filename: ml/backend/ggml/ggml/src/ggml-cuda/common.cuh
patch: @@ -77,8 +77,10 @@ static cublasStatus_t cublasGemmBatchedExReserve(
         cublasComputeType_t computeType, cublasGemmAlgo_t algo) {
     if (!reserving_graph) {
         return cublasGemmBatchedEx(handle, transa, transb, m, n, k,
-            alpha, Aarray, Atype, lda, Barray, Btype, ldb,
-            beta, Carray, Ctype, ldc, batchCount, computeType, algo);
+            alpha, const_cast<const void **>(Aarray), Atype, lda,
+            const_cast<const void **>(Barray), Btype, ldb,
+            beta, const_cast<void **>(Carray), Ctype, ldc,
+            batchCount, computeType, algo);
     } else {
         return CUBLAS_STATUS_SUCCESS;
     }

filename: ml/backend/ggml/ggml/src/ggml-cuda/vendors/hip.h
patch: @@ -39,6 +39,7 @@
 #define cublasCreate hipblasCreate
 #define cublasDestroy hipblasDestroy
 #define cublasGemmEx hipblasGemmEx
+#define cublasGemmAlgo_t hipblasGemmAlgo_t
 #define cublasGemmBatchedEx hipblasGemmBatchedEx
 #define cublasGemmStridedBatchedEx hipblasGemmStridedBatchedEx
 #define cublasHandle_t hipblasHandle_t
Repository: rust-lang/rust
Pull request: Avoid creating async return opaques for foreign async fns

Fixes https://github.com/rust-lang/rust/issues/146754

Previously, def collection created the desugared async return opaque for foreign `async fn` items, but AST lowering won't lower that opaque for foreign items. That left a `DefId` without a corresponding HIR owner, which later caused an ICE during analysis.

Changed files:
filename: compiler/rustc_resolve/src/def_collector.rs
patch: @@ -209,12 +209,15 @@ impl<'a, 'ra, 'tcx> visit::Visitor<'a> for DefCollector<'a, 'ra, 'tcx> {
     fn visit_fn(&mut self, fn_kind: FnKind<'a>, _: &AttrVec, span: Span, _: NodeId) {
         match fn_kind {
             FnKind::Fn(
-                _ctxt,
+                ctxt,
                 _vis,
                 Fn {
                     sig: FnSig { header, decl, span: _ }, ident, generics, contract, body, ..
                 },
-            ) if let Some(coroutine_kind) = header.coroutine_kind => {
+            ) if let Some(coroutine_kind) = header.coroutine_kind
+                // Foreign ones are denied, so don't create them here.
+                && ctxt != visit::FnCtxt::Foreign =>
+            {
                 self.visit_ident(ident);
                 self.visit_fn_header(header);
                 self.visit_generics(generics);

filename: tests/ui/extern/bad-external-async-fn-issue-146754.rs
patch: @@ -0,0 +1,8 @@
+//@ edition:2024
+#![crate_type = "lib"]
+
+unsafe extern "C" {
+    async fn function() -> [(); || {}];
+    //~^ ERROR functions in `extern` blocks cannot have `async` qualifier
+    //~^^ ERROR mismatched types
+}

filename: tests/ui/extern/bad-external-async-fn-issue-146754.stderr
patch: @@ -0,0 +1,21 @@
+error: functions in `extern` blocks cannot have `async` qualifier
+  --> $DIR/bad-external-async-fn-issue-146754.rs:5:5
+   |
+LL | unsafe extern "C" {
+   | ----------------- in this `extern` block
+LL |     async fn function() -> [(); || {}];
+   |     ^^^^^ help: remove the `async` qualifier
+
+error[E0308]: mismatched types
+  --> $DIR/bad-external-async-fn-issue-146754.rs:5:33
+   |
+LL |     async fn function() -> [(); || {}];
+   |                                 ^^^^^ expected `usize`, found closure
+   |
+   = note: expected type `usize`
+           found closure `{closure@$DIR/bad-external-async-fn-issue-146754.rs:5:33: 5:35}`
+   = note: array length can only be `usize`
+
+error: aborting due to 2 previous errors
+
+For more information about this error, try `rustc --explain E0308`.
Repository: electron/electron
Pull request: ci: fetch clang-tidy package in fix-sync

`fix-sync` re-downloads `llvm-build` on macOS/Windows with the base `clang` and `objdump` packages, but not `clang-tidy`. A local `gclient sync` does pull `clang-tidy` (Electron's DEPS sets `checkout_clang_tidy: True`), so CI's `llvm-build` tree ends up missing a file that a local checkout has.

siso uploads the whole toolchain directory as action input, so the hash computed on CI (without `clang-tidy`) doesn't match the hash computed locally (with it). Cache-only local runs against the CI-populated RBE cache miss because the input is absent.

Linux is unaffected — it uses the cached `llvm-build` from the Linux-hosted `gclient sync`, which already includes `clang-tidy`.

Notes: none

Changed files:
filename: .github/actions/fix-sync/action.yml
patch: @@ -27,6 +27,7 @@ runs:
         python3 src/tools/clang/scripts/update.py
         # Refs https://chromium-review.googlesource.com/c/chromium/src/+/6667681
         python3 src/tools/clang/scripts/update.py --package objdump
+        python3 src/tools/clang/scripts/update.py --package clang-tidy
     - name: Fix esbuild
       if: ${{ inputs.target-platform != 'linux' }}
       uses: ./src/electron/.github/actions/cipd-install
Repository: ollama/ollama
Pull request: gemma4: enable flash attention

~~This patches additional code paths in the GGML CUDA backend for the memory prediction flow.~~

~~Fixes #15249~~

Enable flash attention for gemma4

Changed files:
filename: fs/ggml/ggml.go
patch: @@ -890,6 +890,7 @@ func (f GGML) FlashAttention() bool {
 	return slices.Contains([]string{
 		"bert",
 		"gemma3",
+		"gemma4",
 		"glm4moelite",
 		"glmocr",
 		"gptoss", "gpt-oss",
Repository: vercel/next.js
Pull request: turbo-persistence: remove Unmergeable mmap advice

### What?

Remove the `MADV_UNMERGEABLE` (Unmergeable) mmap advice from `turbo-persistence`'s `advise_mmap_for_persistence` helper in `mmap_helper.rs`.

### Why?

The WSL (Windows Subsystem for Linux) kernel does not support `MADV_UNMERGEABLE` and returns an error when it is applied, causing turbo-persistence to fail on WSL. See: https://x.com/von_cronen/status/2034944304712392891

Additionally, `MADV_UNMERGEABLE` is already the **default** state for memory pages — KSM (Kernel Same-page Merging) is opt-in via `MADV_MERGEABLE`. Explicitly setting `MADV_UNMERGEABLE` on pages that were never marked mergeable is a no-op on standard kernels, so the call provides no benefit while breaking WSL users.

The `MADV_DONTFORK` advice is retained, as it has a clear correctness benefit (prevents mmap regions from being inherited by child processes on `fork()`).

### How?

Removed the `mmap.advise(memmap2::Advice::Unmergeable)` call and its associated doc comment from `turbopack/crates/turbo-persistence/src/mmap_helper.rs`.

Changed files:
filename: turbopack/crates/turbo-persistence/src/mmap_helper.rs
patch: @@ -2,15 +2,11 @@
 ///
 /// - `DontFork`: prevents mmap regions from being copied into child processes on `fork()`, avoiding
 ///   unnecessary memory duplication and potential SIGBUS.
-/// - `Unmergeable`: opts pages out of KSM (Kernel Same-page Merging) since our data is unique
-///   compressed content that won't benefit from deduplication scanning.
 #[cfg(target_os = "linux")]
 pub fn advise_mmap_for_persistence(mmap: &memmap2::Mmap) -> anyhow::Result<()> {
     use anyhow::Context;
     mmap.advise(memmap2::Advice::DontFork)
         .context("Failed to advise mmap DontFork")?;
-    mmap.advise(memmap2::Advice::Unmergeable)
-        .context("Failed to advise mmap Unmergeable")?;
     Ok(())
 }
Repository: huggingface/transformers
Pull request: Fix tf32 issue: set `torch.backends.cudnn.conv.fp32_precision` explicitly.

# What does this PR do?

PR #42428 change the way to enable / disable torch's TF32 using torch new API. It turns out set 

> torch.backends.fp32_precision = False

would still have

> torch.backends.cudnn.conv.fp32_precision = "tf32"
> torch.backends.cudnn.rnn.fp32_precision = "tf32"

It's not clear if it's a bug or a design in `torch`, I will talk to people at torch conference next week.

For now, this issue causes ~60 `test_batching_equivalence` failing. Set `torch.backends.cudnn.conv.fp32_precision = "ieee"` explicitly will have no such failing tests (on the commit of the linked PR).

I will merge this PR directly to move fast. If `torch` team says that it's a design instead of a bug, we could move the logic to our `enable_tf32`.

Keep in mind, even with this fix, there are still 37 failing `test_batching_equivalence`, which are caused by other issues introduced after #42428 , which should be fixed in separated PR(s).

Note: this PR bring the `vit` and `clip` CI back to ✅ 

Changed files:
filename: conftest.py
patch: @@ -149,6 +149,22 @@ def check_output(self, want, got, optionflags):
     # The flag below controls whether to allow TF32 on cuDNN. This flag defaults to True.
     # We set it to `False` for CI. See https://github.com/pytorch/pytorch/issues/157274#issuecomment-3090791615
     enable_tf32(False)
+    # # torch.backends.fp32_precision does not cascade to torch.backends.cudnn.conv.fp32_precision and torch.backends.cudnn.rnn.fp32_precision
+    # TODO: Considering move this to `enable_tf32`, or report a bug to `torch`.
+    import torch
+
+    # In order to set `torch.backends.cudnn.conv.fp32_precision = "ieee"` below (new API), we still need to set this
+    # (old API) because it defaults to `True` (and not changed automatically when we change `cudnn.conv.fp32_precision`)
+    # and such inconsistency cause `torch` to complain `RuntimeError: PyTorch is checking whether allow_tf32 is enabled for cuDNN without a specific operator name,but the current flag(s) indica
+    # te that cuDNN conv and cuDNN RNN have different TF32 flags.This combination indicates that you have used a mix of the legacy and new APIs
+    #  to set the TF32 flags. We suggest only using the new API to set the TF32 flag(s).`.
+    # TODO: report a bug to `torch`
+    if hasattr(torch.backends.cudnn, "allow_tf32"):
+        torch.backends.cudnn.allow_tf32 = False
+
+    # This is necessary to make several `test_batching_equivalence` pass (within the tolerance `1e-5`)
+    if hasattr(torch.backends.cudnn.conv, "fp32_precision"):
+        torch.backends.cudnn.conv.fp32_precision = "ieee"
 
     # patch `torch.compile`: if `TORCH_COMPILE_FORCE_FULLGRAPH=1` (or values considered as true, e.g. yes, y, etc.),
     # the patched version will always run with `fullgraph=True`.
Repository: facebook/react
Pull request: Fix typo: accomodate -> accommodate

Fixed spelling error in comment:
- Fixed 'accomodate' -> 'accommodate' in InferMutationAliasingEffects.ts

<!--
  Thanks for submitting a pull request!
  We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.

  Before submitting a pull request, please make sure the following is done:

  1. Fork [the repository](https://github.com/facebook/react) and create your branch from `main`.
  2. Run `yarn` in the repository root.
  3. If you've fixed a bug or added code that should be tested, add tests!
  4. Ensure the test suite passes (`yarn test`). Tip: `yarn test --watch TestName` is helpful in development.
  5. Run `yarn test --prod` to test in the production environment. It supports the same options as `yarn test`.
  6. If you need a debugger, run `yarn test --debug --watch TestName`, open `chrome://inspect`, and press "Inspect".
  7. Format your code with [prettier](https://github.com/prettier/prettier) (`yarn prettier`).
  8. Make sure your code lints (`yarn lint`). Tip: `yarn linc` to only check changed files.
  9. Run the [Flow](https://flowtype.org/) type checks (`yarn flow`).
  10. If you haven't already, complete the CLA.

  Learn more about contributing: https://reactjs.org/docs/how-to-contribute.html
-->

## Summary

<!--
 Explain the **motivation** for making this change. What existing problem does the pull request solve?
-->

## How did you test this change?

<!--
  Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes the user interface.
  How exactly did you verify that your PR solves the issue you wanted to solve?
  If you leave this empty, your PR will very likely be closed.
-->


Changed files:
filename: compiler/packages/babel-plugin-react-compiler/src/Inference/InferMutationAliasingEffects.ts
patch: @@ -1315,7 +1315,7 @@ class InferenceState {
   #values: Map<InstructionValue, AbstractValue>;
   /*
    * The set of values pointed to by each identifier. This is a set
-   * to accomodate phi points (where a variable may have different
+   * to accommodate phi points (where a variable may have different
    * values from different control flow paths).
    */
   #variables: Map<IdentifierId, Set<InstructionValue>>;