helloadhavan/github_issues huggingface dataset:
Repository: facebook/react
Pull request: [eslint-plugin-react-hooks] update fbsource build


In order to sync the lint rules directly to internal, include the eslint plugin in the build output for fbsource.


Changed files:
filename: .github/workflows/runtime_commit_artifacts.yml
patch: @@ -132,9 +132,9 @@ jobs:
           mkdir ./compiled/facebook-www/__test_utils__
           mv build/__test_utils__/ReactAllWarnings.js ./compiled/facebook-www/__test_utils__/ReactAllWarnings.js
 
-          # Move eslint-plugin-react-hooks into eslint-plugin-react-hooks
+          # Copy eslint-plugin-react-hooks
           mkdir ./compiled/eslint-plugin-react-hooks
-          mv build/oss-experimental/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js \
+          cp build/oss-experimental/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js \
             ./compiled/eslint-plugin-react-hooks/index.js
 
           # Move unstable_server-external-runtime.js into facebook-www
@@ -167,6 +167,13 @@ jobs:
           rm $RENDERER_FOLDER/ReactFabric-{dev,prod,profiling}.js
           rm $RENDERER_FOLDER/ReactNativeRenderer-{dev,prod,profiling}.js
 
+          # Copy eslint-plugin-react-hooks
+          # NOTE: This is different from www, here we include the full package
+          #       including package.json to include dependencies in fbsource.
+          mkdir $BASE_FOLDER/RKJSModules/vendor/react/eslint-plugin-react-hooks
+          cp -r build/oss-experimental/eslint-plugin-react-hooks \
+            $BASE_FOLDER/RKJSModules/vendor/react/eslint-plugin-react-hooks
+
           # Move React Native version file
           mv build/facebook-react-native/VERSION_NATIVE_FB ./compiled-rn/VERSION_NATIVE_FB
Repository: nodejs/node
Pull request: test: skip sea tests on riscv64

As documented in https://github.com/nodejs/node/issues/61110 - these tests do not pass on most currently available RISC-V systems.

This matches the approach used for [macos/x64](https://github.com/nodejs/node/pull/60250) and [Linux/ppc64le](https://github.com/nodejs/node/pull/59563).

Changed files:
filename: test/sea/sea.status
patch: @@ -14,6 +14,10 @@ test-single-executable-application*: SKIP
 # https://github.com/nodejs/node/issues/59561
 test-single-executable-application*: SKIP
 
+[$system==linux && $arch==riscv64]
+# https://github.com/nodejs/node/issues/61110
+test-single-executable-application*: SKIP
+
 [$system==win32]
 # https://github.com/nodejs/node/issues/49630
 test-single-executable-application-snapshot: PASS, FLAKY
Repository: electron/electron
Pull request: build: add logging to notes generator

Backport of #49300

See that PR for details.


Notes: <!-- Please add a one-line description for app developers to read in the release notes, or 'none' if no notes relevant to app developers. Examples and help on special cases: https://github.com/electron/clerk/blob/main/README.md#examples -->none


Changed files:
filename: script/release/notes/notes.ts
patch: @@ -105,12 +105,17 @@ class Pool {
  **/
 
 const runGit = async (dir: string, args: string[]) => {
+  console.log(`Running git ${args.join(' ')} in ${dir}`);
   const response = spawnSync('git', args, {
     cwd: dir,
     encoding: 'utf8',
     stdio: ['inherit', 'pipe', 'pipe']
   });
   if (response.status !== 0) {
+    console.error(`Git command failed: git ${args.join(' ')}`);
+    console.error('STDERR was ' + response.stderr.trim());
+    console.error('STDOUT was ' + response.stdout.trim());
+    console.log('Response status:', response.status);
     throw new Error(response.stderr.trim());
   }
   return response.stdout.trim();
Repository: ollama/ollama
Pull request: Ollama getting index oob exception

When looking at some of the tickets, I was noticing a lot of them revolving around: #8745

Ollama Server is getting Index OOB on line 175 of server/downloads.go.

It seemed to be something common, with the array being empty and trying to reference the first index.  This should resolve it.

Changed files:
filename: server/download.go
patch: @@ -170,9 +170,9 @@ func (b *blobDownload) Prepare(ctx context.Context, requestURL *url.URL, opts *r
 
 			offset += size
 		}
+	} else {
+		slog.Info(fmt.Sprintf("downloading %s in %d %s part(s)", b.Digest[7:19], len(b.Parts), format.HumanBytes(b.Parts[0].Size)))
 	}
-
-	slog.Info(fmt.Sprintf("downloading %s in %d %s part(s)", b.Digest[7:19], len(b.Parts), format.HumanBytes(b.Parts[0].Size)))
 	return nil
 }
Repository: nodejs/node
Pull request: doc: correct invalid collaborator profile

fix broken GitHub profile link for Node.js contributor

Replace outdated profile URL (DavidCai1993) with current URL (DavidCai1111). The previous link was returning 404. New profile confirmed as Node.js contributor.

<!--
Before submitting a pull request, please read:

- the CONTRIBUTING guide at https://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md
- the commit message formatting guidelines at
  https://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#commit-message-guidelines

For code changes:
1. Include tests for any bug fixes or new features.
2. Update documentation if relevant.
3. Ensure that `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes.

If you believe this PR should be highlighted in the Node.js CHANGELOG
please add the `notable-change` label.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.
-->


Changed files:
filename: README.md
patch: @@ -507,7 +507,7 @@ For information about the governance of the Node.js project, see
   **Daniel Bevenius** <<daniel.bevenius@gmail.com>> (he/him)
 * [danielleadams](https://github.com/danielleadams) -
   **Danielle Adams** <<adamzdanielle@gmail.com>> (she/her)
-* [DavidCai1993](https://github.com/DavidCai1993) -
+* [DavidCai1111](https://github.com/DavidCai1111) -
   **David Cai** <<davidcai1993@yahoo.com>> (he/him)
 * [davisjam](https://github.com/davisjam) -
   **Jamie Davis** <<davisjam@vt.edu>> (he/him)
Repository: electron/electron
Pull request: build: add logging to notes generator

#### Description of Change
Sudowoodo is failing to generate release notes.  This PR adds debugging so that we can track down the issue.

<!--
Thank you for your Pull Request. Please provide a description above and review
the requirements below.

Contributors guide: https://github.com/electron/electron/blob/main/CONTRIBUTING.md
-->

#### Checklist
<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

- [ ] PR description included and stakeholders cc'd
- [ ] `npm test` passes
- [ ] tests are [changed or added](https://github.com/electron/electron/blob/main/docs/development/testing.md)
- [ ] relevant API documentation, tutorials, and examples are updated and follow the [documentation style guide](https://github.com/electron/electron/blob/main/docs/development/style-guide.md)
- [ ] [PR release notes](https://github.com/electron/clerk/blob/main/README.md) describe the change in a way relevant to app developers, and are [capitalized, punctuated, and past tense](https://github.com/electron/clerk/blob/main/README.md#examples).

#### Release Notes

Notes: <!-- Please add a one-line description for app developers to read in the release notes, or 'none' if no notes relevant to app developers. Examples and help on special cases: https://github.com/electron/clerk/blob/main/README.md#examples -->none


Changed files:
filename: script/release/notes/notes.ts
patch: @@ -105,12 +105,17 @@ class Pool {
  **/
 
 const runGit = async (dir: string, args: string[]) => {
+  console.log(`Running git ${args.join(' ')} in ${dir}`);
   const response = spawnSync('git', args, {
     cwd: dir,
     encoding: 'utf8',
     stdio: ['inherit', 'pipe', 'pipe']
   });
   if (response.status !== 0) {
+    console.error(`Git command failed: git ${args.join(' ')}`);
+    console.error('STDERR was ' + response.stderr.trim());
+    console.error('STDOUT was ' + response.stdout.trim());
+    console.log('Response status:', response.status);
     throw new Error(response.stderr.trim());
   }
   return response.stdout.trim();
Repository: ollama/ollama
Pull request: server: always print upload/download part info


Changed files:
filename: server/download.go
patch: @@ -170,9 +170,12 @@ func (b *blobDownload) Prepare(ctx context.Context, requestURL *url.URL, opts *r
 
 			offset += size
 		}
-	} else {
+	}
+
+	if len(b.Parts) > 0 {
 		slog.Info(fmt.Sprintf("downloading %s in %d %s part(s)", b.Digest[7:19], len(b.Parts), format.HumanBytes(b.Parts[0].Size)))
 	}
+
 	return nil
 }
 

filename: server/upload.go
patch: @@ -108,7 +108,9 @@ func (b *blobUpload) Prepare(ctx context.Context, requestURL *url.URL, opts *reg
 		offset += size
 	}
 
-	slog.Info(fmt.Sprintf("uploading %s in %d %s part(s)", b.Digest[7:19], len(b.Parts), format.HumanBytes(b.Parts[0].Size)))
+	if len(b.Parts) > 0 {
+		slog.Info(fmt.Sprintf("uploading %s in %d %s part(s)", b.Digest[7:19], len(b.Parts), format.HumanBytes(b.Parts[0].Size)))
+	}
 
 	requestURL, err = url.Parse(location)
 	if err != nil {
Repository: huggingface/transformers
Pull request: Hardcode the factor in caching allocator

# What does this PR do?

As per the title. It's a nit, but as quantizers got their behavior aligned for warmup, I feel like it's clearer like this

Changed files:
filename: src/transformers/modeling_utils.py
patch: @@ -4590,8 +4590,6 @@ def caching_allocator_warmup(model: PreTrainedModel, expanded_device_map: dict,
     - Loading speed bottleneck is now almost only tensor copy (i.e. changing the dtype) and moving the tensors to the devices.
     However, we cannot really improve on those aspects obviously, as the data needs to be moved/copied in the end.
     """
-    factor = 2
-
     # Remove disk, cpu and meta devices, and cast to proper torch.device
     accelerator_device_map = {
         param: torch.device(device) for param, device in expanded_device_map.items() if is_accelerator_device(device)
@@ -4620,7 +4618,8 @@ def caching_allocator_warmup(model: PreTrainedModel, expanded_device_map: dict,
                 index
             ) - torch_accelerator_module.memory_allocated(index)
             byte_count = int(max(0, byte_count - unused_memory))
-        _ = torch.empty(byte_count // factor, dtype=torch.float16, device=device, requires_grad=False)
+        # We divide by 2 here as we allocate in fp16
+        _ = torch.empty(byte_count // 2, dtype=torch.float16, device=device, requires_grad=False)
 
 
 class AttentionInterface(GeneralInterface):

filename: tests/test_modeling_common.py
patch: @@ -1214,18 +1214,14 @@ def test_all_tensors_are_parameter_or_buffer(self):
             # Now, run all the inits
             model.init_weights()
 
-            # Prepare inputs to correct device
+            # Prepare inputs
             inputs = self._prepare_for_class(inputs_dict, model_class)
-            final_inputs = {}
-            for k, v in inputs.items():
-                if isinstance(v, torch.Tensor):
-                    final_inputs[k] = v.to(device="cpu")
-                else:
-                    final_inputs[k] = v
+            # Inputs may be on cuda -> move to cpu, we don't care about accelerator for this test
+            inputs = {k: v.to("cpu") if isinstance(v, torch.Tensor) else v for k, v in inputs.items()}
 
             # Try running a forward, to see if a tensor stayed on meta somewhere
             try:
-                _ = model(**final_inputs)
+                _ = model(**inputs)
             except (RuntimeError, NotImplementedError) as e:
                 # Re-raise a more friendly exception (unfortunately, we cannot know which tensor it was...)
                 if "Cannot copy out of meta tensor; no data!" in str(
Repository: vuejs/vue
Pull request: fix(core): Give warning for set/delete methods on null, undefined, String, Number and Boolean values. Fixes #7381

**What kind of change does this PR introduce?** (check at least one)

- [x] Bugfix
- [ ] Feature
- [ ] Code style update
- [ ] Refactor
- [ ] Build-related changes
- [ ] Other, please describe:

**Does this PR introduce a breaking change?** (check one)

- [ ] Yes
- [x] No

If yes, please describe the impact and migration path for existing applications:

**The PR fulfills these requirements:**

- [x] It's submitted to the `dev` branch for v2.x (or to a previous version branch), _not_ the `master` branch
- [x] When resolving a specific issue, it's referenced in the PR's title (e.g. `fix #xxx[,#xxx]`, where "xxx" is the issue number)
- [x] All tests are passing: https://github.com/vuejs/vue/blob/dev/.github/CONTRIBUTING.md#development-setup
- [x] New/updated tests are included

If adding a **new feature**, the PR's description includes:
- [ ] A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

**Other information:**


Changed files:
filename: src/core/observer/index.js
patch: @@ -194,6 +194,12 @@ export function defineReactive (
  * already exist.
  */
 export function set (target: Array<any> | Object, key: any, val: any): any {
+  if (process.env.NODE_ENV !== 'production' &&
+    !Array.isArray(target) &&
+    !isObject(target)
+  ) {
+    warn(`Cannot set reactive property on non-object/array value: ${target}`)
+  }
   if (Array.isArray(target) && isValidArrayIndex(key)) {
     target.length = Math.max(target.length, key)
     target.splice(key, 1, val)
@@ -224,6 +230,12 @@ export function set (target: Array<any> | Object, key: any, val: any): any {
  * Delete a property and trigger change if necessary.
  */
 export function del (target: Array<any> | Object, key: any) {
+  if (process.env.NODE_ENV !== 'production' &&
+    !Array.isArray(target) &&
+    !isObject(target)
+  ) {
+    warn(`Cannot delete reactive property on non-object/array value: ${target}`)
+  }
   if (Array.isArray(target) && isValidArrayIndex(key)) {
     target.splice(key, 1)
     return

filename: test/unit/modules/observer/observer.spec.js
patch: @@ -356,6 +356,18 @@ describe('Observer', () => {
     })
   })
 
+  it('warn set/delete on non valid values', () => {
+    try {
+      setProp(null, 'foo', 1)
+    } catch (e) {}
+    expect(`Cannot set reactive property on non-object/array value`).toHaveBeenWarned()
+
+    try {
+      delProp(null, 'foo')
+    } catch (e) {}
+    expect(`Cannot delete reactive property on non-object/array value`).toHaveBeenWarned()
+  })
+
   it('should lazy invoke existing getters', () => {
     const obj = {}
     let called = false
Repository: facebook/react
Pull request: [mcp] Move to /tools


Moves to a tools directory.
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/33083).
* #33085
* #33084
* __->__ #33083

Changed files:
filename: compiler/packages/react-mcp-server/src/index.ts
patch: @@ -20,7 +20,7 @@ import * as cheerio from 'cheerio';
 import {queryAlgolia} from './utils/algolia';
 import assertExhaustive from './utils/assertExhaustive';
 import {convert} from 'html-to-text';
-import {measurePerformance} from './utils/runtimePerf';
+import {measurePerformance} from './tools/runtimePerf';
 
 const server = new McpServer({
   name: 'React',
Repository: vuejs/vue
Pull request: Fix #7404: skip v-model & value binding collision check with dynamic type binding

**What kind of change does this PR introduce?** (check at least one)

- [x] Bugfix
- [ ] Feature
- [ ] Code style update
- [ ] Refactor
- [ ] Build-related changes
- [ ] Other, please describe:

**Does this PR introduce a breaking change?** (check one)

- [ ] Yes
- [x] No

If yes, please describe the impact and migration path for existing applications:

**The PR fulfills these requirements:**

None.

- [x] It's submitted to the `dev` branch for v2.x (or to a previous version branch), _not_ the `master` branch
- [x] When resolving a specific issue, it's referenced in the PR's title (e.g. `fix #xxx[,#xxx]`, where "xxx" is the issue number)
- [x] All tests are passing: https://github.com/vuejs/vue/blob/dev/.github/CONTRIBUTING.md#development-setup
- [x] New/updated tests are included

If adding a **new feature**, the PR's description includes:
- [ ] A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

**Other information:**

None.

Changed files:
filename: src/platforms/web/compiler/directives/model.js
patch: @@ -130,9 +130,11 @@ function genDefaultModel (
   const type = el.attrsMap.type
 
   // warn if v-bind:value conflicts with v-model
+  // except for inputs with v-bind:type
   if (process.env.NODE_ENV !== 'production') {
     const value = el.attrsMap['v-bind:value'] || el.attrsMap[':value']
-    if (value) {
+    const typeBinding = el.attrsMap['v-bind:type'] || el.attrsMap[':type']
+    if (value && !typeBinding) {
       const binding = el.attrsMap['v-bind:value'] ? 'v-bind:value' : ':value'
       warn(
         `${binding}="${value}" conflicts with v-model on the same element ` +

filename: test/unit/features/directives/model-text.spec.js
patch: @@ -289,6 +289,17 @@ describe('Directive v-model text', () => {
     expect('conflicts with v-model').not.toHaveBeenWarned()
   })
 
+  it('should not warn on input with dynamic type binding', () => {
+    new Vue({
+      data: {
+        type: 'checkbox',
+        test: 'foo'
+      },
+      template: '<input :type="type" v-model="test" :value="test">'
+    }).$mount()
+    expect('conflicts with v-model').not.toHaveBeenWarned()
+  })
+
   if (!isAndroid) {
     it('does not trigger extra input events with single compositionend', () => {
       const spy = jasmine.createSpy()
Repository: nodejs/node
Pull request: doc: add a tip about developer mode on Windows

On Windows, creating symlinks requires Developer Mode to be enabled or running the command as Administrator. Tests that rely on creating symlinks may fail with EPERM errors if symlink creation is not permitted. Add a tip about this for the docs about running tests on Windows.

<!--
Before submitting a pull request, please read:

- the CONTRIBUTING guide at https://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md
- the commit message formatting guidelines at
  https://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#commit-message-guidelines

For code changes:
1. Include tests for any bug fixes or new features.
2. Update documentation if relevant.
3. Ensure that `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes.

If you believe this PR should be highlighted in the Node.js CHANGELOG
please add the `notable-change` label.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.
-->


Changed files:
filename: BUILDING.md
patch: @@ -870,6 +870,11 @@ To test if Node.js was built correctly:
 Release\node -e "console.log('Hello from Node.js', process.version)"
 ```
 
+> \[!TIP]
+> On Windows, creating symlinks requires [Developer Mode][] to be enabled or
+> running the command as Administrator. Tests that rely on creating symlinks
+> may fail with EPERM errors if symlink creation is not permitted.
+
 ##### Using ccache:
 
 Follow <https://github.com/ccache/ccache/wiki/MS-Visual-Studio>, and you
@@ -1140,4 +1145,5 @@ by opening a pull request against the registry available at
 <https://github.com/nodejs/node/blob/HEAD/doc/abi_version_registry.json>.
 
 [AIX toolbox]: https://www.ibm.com/support/pages/aix-toolbox-open-source-software-overview
+[Developer Mode]: https://learn.microsoft.com/en-us/windows/advanced-settings/developer-mode
 [Python versions]: https://devguide.python.org/versions/
Repository: ollama/ollama
Pull request: ci: fix extra quote


Changed files:
filename: .github/workflows/release.yaml
patch: @@ -408,7 +408,7 @@ jobs:
         working-directory: dist
       - name: Create or update Release
         run: |
-          RELEASE_VERSION=$(echo ${GITHUB_REF_NAME} | cut -f1 -d-)"
+          RELEASE_VERSION="$(echo ${GITHUB_REF_NAME} | cut -f1 -d-)"
 
           echo "Looking for existing release for ${RELEASE_VERSION}"
           OLD_TAG=$(gh release ls --json name,tagName | jq -r ".[] | select(.name == \"${RELEASE_VERSION}\") | .tagName")
Repository: facebook/react
Pull request: [mcp] Update plugins


Adds typescript support.
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/33082).
* #33085
* #33084
* #33083
* __->__ #33082
* #33101

Changed files:
filename: compiler/packages/react-mcp-server/src/utils/runtimePerf.ts
patch: @@ -6,8 +6,9 @@ export async function measurePerformance(code: string) {
     configFile: false,
     babelrc: false,
     presets: [
-      require.resolve('@babel/preset-env'),
-      require.resolve('@babel/preset-react'),
+      '@babel/preset-typescript',
+      '@babel/preset-env',
+      '@babel/preset-react',
     ],
   };