# Buggy code
def rr_present(
    name,
    HostedZoneId=None,
    DomainName=None,
    PrivateZone=False,
    Name=None,
    Type=None,
    SetIdentifier=None,
    Weight=None,
    Region=None,
    GeoLocation=None,
    Failover=None,
    TTL=None,
    ResourceRecords=None,
    AliasTarget=None,
    HealthCheckId=None,
    TrafficPolicyInstanceId=None,
    region=None,
    key=None,
    keyid=None,
    profile=None,
):
    """
    Ensure the Route53 record is present.

    name
        The name of the state definition.  This will be used for Name if the latter is
        not provided.

    HostedZoneId
        The ID of a zone to create the record in.  Exclusive with DomainName.

    DomainName
        The domain name of a zone to create the record in.  Exclusive with HostedZoneId.

    PrivateZone
        Set to True if the resource record should be in a private zone, False if public.

    Name
        Name of the Route 53 resource record being managed.

    Type
        The record type (A, NS, MX, TXT, etc.)

    SetIdentifier
        Valid for Weighted, Latency, Geolocation, and Failover resource record sets only.
        An identifier that differentiates among multiple resource record sets that have the same
        combination of DNS name and type.  The value of SetIdentifier must be unique for each
        resource record set that has the same combination of DNS name and type. Omit SetIdentifier
        for any other types of record sets.

    Weight
        Valid for Weighted resource record sets only.  Among resource record sets that have the
        same combination of DNS name and type, a value that determines the proportion of DNS
        queries that Amazon Route 53 responds to using the current resource record set. Amazon Route
        53 calculates the sum of the weights for the resource record sets that have the same
        combination of DNS name and type. Amazon Route 53 then responds to queries based on the
        ratio of a resource's weight to the total.

        Note the following:
          - You must specify a value for the Weight element for every weighted resource record set.
          - You can only specify one ResourceRecord per weighted resource record set.
          - You can't create latency, failover, or geolocation resource record sets that have the
            same values for the Name and Type elements as weighted resource record sets.
          - You can create a maximum of 100 weighted resource record sets that have the same values
            for the Name and Type elements.
          - For weighted (but not weighted alias) resource record sets, if you set Weight to 0 for a
            resource record set, Amazon Route 53 never responds to queries with the applicable value
            for that resource record set.  However, if you set Weight to 0 for all resource record
            sets that have the same combination of DNS name and type, traffic is routed to all
            resources with equal probability.  The effect of setting Weight to 0 is different when
            you associate health checks with weighted resource record sets. For more information,
            see `Options for Configuring Amazon Route 53 Active-Active and Active-Passive Failover`__
            in the Amazon Route 53 Developer Guide.
            .. __: http://docs.aws.amazon.com/Route53/latest/DeveloperGuide/dns-failover-configuring-options.html

    Region
        Valid for Latency-based resource record sets only.  The Amazon EC2 Region where the resource
        that is specified in this resource record set resides. The resource typically is an AWS
        resource, such as an EC2 instance or an ELB load balancer, and is referred to by an IP
        address or a DNS domain name, depending on the record type.

    GeoLocation
        Geo location resource record sets only.  A dict that lets you control how Route 53 responds
        to DNS queries based on the geographic origin of the query.  For example, if you want all
        queries from Africa to be routed to a web server with an IP address of 192.0.2.111, create a
        resource record set with a Type of A and a ContinentCode of AF.

            ContinentCode
                The two-letter code for the continent.
                Valid values: AF | AN | AS | EU | OC | NA | SA
                Constraint: Specifying ContinentCode with either CountryCode or SubdivisionCode
                            returns an InvalidInput error.
            CountryCode
                The two-letter code for the country.
            SubdivisionCode
                The code for the subdivision, for example, a state in the United States or a
                province in Canada.

        Notes
          - Creating geolocation and geolocation alias resource record sets in private hosted zones
            is not supported.
          - If you create separate resource record sets for overlapping geographic regions (for
            example, one resource record set for a continent and one for a country on the same
            continent), priority goes to the smallest geographic region. This allows you to route
            most queries for a continent to one resource and to route queries for a country on that
            continent to a different resource.
          - You can't create two geolocation resource record sets that specify the same geographic
            location.
          - The value * in the CountryCode element matches all geographic locations that aren't
            specified in other geolocation resource record sets that have the same values for the
            Name and Type elements.
          - Geolocation works by mapping IP addresses to locations.  However, some IP addresses
            aren't mapped to geographic locations, so even if you create geolocation resource
            record sets that cover all seven continents, Amazon Route 53 will receive some DNS
            queries from locations that it can't identify.  We recommend that you create a resource
            record set for which the value of CountryCode is *, which handles both queries that
            come from locations for which you haven't created geolocation resource record sets and
            queries from IP addresses that aren't mapped to a location.  If you don't create a *
            resource record set, Amazon Route 53 returns a "no answer" response for queries from
            those locations.
          - You can't create non-geolocation resource record sets that have the same values for the
            Name and Type elements as geolocation resource record sets.

    TTL
        The resource record cache time to live (TTL), in seconds.
        Note the following:
          - If you're creating an alias resource record set, omit TTL. Amazon Route 53 uses the
            value of TTL for the alias target.
          - If you're associating this resource record set with a health check (if you're adding
            a HealthCheckId element), we recommend that you specify a TTL of 60 seconds or less so
            clients respond quickly to changes in health status.
          - All of the resource record sets in a group of weighted, latency, geolocation, or
            failover resource record sets must have the same value for TTL.
          - If a group of weighted resource record sets includes one or more weighted alias
            resource record sets for which the alias target is an ELB load balancer, we recommend
            that you specify a TTL of 60 seconds for all of the non-alias weighted resource record
            sets that have the same name and type. Values other than 60 seconds (the TTL for load
            balancers) will change the effect of the values that you specify for Weight.

    ResourceRecords
        A list, containing one or more values for the resource record.  No single value can exceed
        4,000 characters.  For details on how to format values for different record types, see
        `Supported DNS Resource Record Types`__ in the Amazon Route 53 Developer Guide.
        .. __: http://docs.aws.amazon.com/Route53/latest/DeveloperGuide/ResourceRecordTypes.html

        Note:  You can specify more than one value for all record types except CNAME and SOA.

        It is also possible to pass "magic" strings as resource record values.  This functionality
        can easily be extended, but for the moment supports the following:

            'magic:ec2_instance_tag:some_tag_name:some_string:some_instance_attr'

        This tells salt to lookup an EC2 instance with a tag 'some_tag_name' which has the value
        'some_string' and substitute the 'some_instance_attr' attribute of that instance as the
        resource record value being evaluated.

        This should work generally for any EC2 instance tags, as long as the instance attribute
        being fetched is available to getattr(instance, 'attribute') as seen in the code below.
        Anything else will most likely require this function to be extended to handle it.

        The canonical use-case for this (at least at our site) is to query the Name tag (which
        we always populate with the host's FQDN) to lookup the public or private IPs bound to the
        instance, so we can then automgically create Route 53 records for them.

    AliasTarget
        The rules governing how to define an AliasTarget for the various supported use-cases are
        obtuse beyond reason and attempting to paraphrase them (or even worse, cut-and-paste them
        in their entirety) would be silly and counterproductive.  If you need this feature, then
        Read The Fine Materials at the `Boto 3 Route 53 page`__ and/or the `AWS Route 53 docs`__
        and suss them for yourself - I sure won't claim to understand them partcularly well.
        .. __: http://boto3.readthedocs.io/en/latest/reference/services/route53.html#Route53.Client.change_resource_record_sets
        .. __: http://docs.aws.amazon.com/Route53/latest/APIReference/API_AliasTarget.html

    region
        The region to connect to.

    key
        Secret key to be used.

    keyid
        Access key to be used.

    profile
        Dict, or pillar key pointing to a dict, containing AWS region/key/keyid.
    """
    Name = Name if Name else name
    Name = _to_aws_encoding(Name)

    if Type is None:
        raise SaltInvocationError(
            "'Type' is a required parameter when adding or updatingresource records."
        )
    ret = {"name": name, "result": True, "comment": "", "changes": {}}

    args = {
        "Id": HostedZoneId,
        "Name": DomainName,
        "PrivateZone": PrivateZone,
        "region": region,
        "key": key,
        "keyid": keyid,
        "profile": profile,
    }
    zone = __salt__["boto3_route53.find_hosted_zone"](**args)
    if not zone:
        ret["comment"] = "Route 53 {} hosted zone {} not found".format(
            "private" if PrivateZone else "public", DomainName
        )
        log.info(ret["comment"])
        return ret
    zone = zone[0]
    HostedZoneId = zone["HostedZone"]["Id"]

    # Convert any magic RR values to something AWS will understand, and otherwise clean them up.
    fixed_rrs = []
    for rr in ResourceRecords:
        if rr.startswith("magic:"):
            fields = rr.split(":")
            if fields[1] == "ec2_instance_tag":
                if len(fields) != 5:
                    log.warning(
                        "Invalid magic RR value seen: '%s'.  Passing as-is.", rr
                    )
                    fixed_rrs += [rr]
                    continue
                tag_name = fields[2]
                tag_value = fields[3]
                instance_attr = fields[4]
                good_states = ("pending", "rebooting", "running", "stopping", "stopped")
                r = __salt__["boto_ec2.find_instances"](
                    tags={tag_name: tag_value},
                    return_objs=True,
                    in_states=good_states,
                    region=region,
                    key=key,
                    keyid=keyid,
                    profile=profile,
                )
                if len(r) < 1:
                    ret["comment"] = "No EC2 instance with tag {} == {} found".format(
                        tag_name, tag_value
                    )
                    log.error(ret["comment"])
                    ret["result"] = False
                    return ret
                if len(r) > 1:
                    ret["comment"] = (
                        "Multiple EC2 instances with tag {} == {} found".format(
                            tag_name, tag_value
                        )
                    )
                    log.error(ret["comment"])
                    ret["result"] = False
                    return ret
                instance = r[0]
                res = getattr(instance, instance_attr, None)
                if res:
                    log.debug(
                        "Found %s %s for instance %s", instance_attr, res, instance.id
                    )
                    fixed_rrs += [_to_aws_encoding(res)]
                else:
                    ret["comment"] = "Attribute {} not found on instance {}".format(
                        instance_attr, instance.id
                    )
                    log.error(ret["comment"])
                    ret["result"] = False
                    return ret
            else:
                ret["comment"] = (
                    "Unknown RR magic value seen: {}.  Please extend the "
                    "boto3_route53 state module to add support for your preferred "
                    "incantation.".format(fields[1])
                )
                log.error(ret["comment"])
                ret["result"] = False
                return ret
        else:
            fixed_rrs += [rr]
    ResourceRecords = [{"Value": rr} for rr in sorted(fixed_rrs)]

    recordsets = __salt__["boto3_route53.get_resource_records"](
        HostedZoneId=HostedZoneId,
        StartRecordName=Name,
        StartRecordType=Type,
        region=region,
        key=key,
        keyid=keyid,
        profile=profile,
    )

    if SetIdentifier and recordsets:
        log.debug(
            "Filter recordsets %s by SetIdentifier %s.", recordsets, SetIdentifier
        )
        recordsets = [r for r in recordsets if r.get("SetIdentifier") == SetIdentifier]
        log.debug("Resulted in recordsets %s.", recordsets)

    create = False
    update = False
    updatable = [
        "SetIdentifier",
        "Weight",
        "Region",
        "GeoLocation",
        "Failover",
        "TTL",
        "AliasTarget",
        "HealthCheckId",
        "TrafficPolicyInstanceId",
    ]
    if not recordsets:
        create = True
        if __opts__["test"]:
            ret["comment"] = (
                "Route 53 resource record {} with type {} would be added.".format(
                    Name, Type
                )
            )
            ret["result"] = None
            return ret
    elif len(recordsets) > 1:
        ret["comment"] = "Given criteria matched more than one ResourceRecordSet."
        log.error(ret["comment"])
        ret["result"] = False
        return ret
    else:
        rrset = recordsets[0]
        for u in updatable:
            if locals().get(u) != rrset.get(u):
                update = True
                break
        if ResourceRecords != sorted(
            rrset.get("ResourceRecords"), key=lambda x: x["Value"]
        ):
            update = True

    if not create and not update:
        ret["comment"] = (
            "Route 53 resource record {} with type {} is already in the desired state."
            "".format(Name, Type)
        )
        log.info(ret["comment"])
        return ret
    else:
        if __opts__["test"]:
            ret["comment"] = (
                "Route 53 resource record {} with type {} would be updated.".format(
                    Name, Type
                )
            )
            ret["result"] = None
            return ret
        ResourceRecordSet = {
            "Name": Name,
            "Type": Type,
            "ResourceRecords": ResourceRecords,
        }
        for u in updatable:
            ResourceRecordSet.update({u: locals().get(u)}) if locals().get(u) else None

        ChangeBatch = {
            "Changes": [
                {
                    "Action": "UPSERT",
                    "ResourceRecordSet": ResourceRecordSet,
                }
            ]
        }

        if __salt__["boto3_route53.change_resource_record_sets"](
            HostedZoneId=HostedZoneId,
            ChangeBatch=ChangeBatch,
            region=region,
            key=key,
            keyid=keyid,
            profile=profile,
        ):
            ret["comment"] = "Route 53 resource record {} with type {} {}.".format(
                Name, Type, "created" if create else "updated"
            )
            log.info(ret["comment"])
            if create:
                ret["changes"]["old"] = None
            else:
                ret["changes"]["old"] = rrset
            ret["changes"]["new"] = ResourceRecordSet
        else:
            ret["comment"] = (
                "Failed to {} Route 53 resource record {} with type {}.".format(
                    "create" if create else "update", Name, Type
                )
            )
            log.error(ret["comment"])
            ret["result"] = False

    return ret


# Traceback (TypeError)
----------
ID: elb APEX fake.news.domain
Function: boto_helper.route53_elb_apex_present
Name: fake.news.domain
Result: False
Comment: Traceback (most recent call last):
File "var/cache/salt/minion/extmods/states/boto_helper.py", line 27, in route53_elb_apex_present
return __states__['boto3_route53.rr_present'](name, DomainName=DomainName, Name=name, Type='A', AliasTarget=AliasTarget, region=region, key=key, keyid=keyid)
File "lib/python2.7/site-packages/salt/loader.py", line 1795, in wrapper
return f(*args, **kwargs)
File "lib/python2.7/site-packages/salt/states/boto3_route53.py", line 598, in rr_present
for rr in ResourceRecords:
TypeError: 'NoneType' object is not iterable
Started: 08:54:52.413520
Duration: 3059.639 ms
Changes:

# Fixed code
def rr_present(
    name,
    HostedZoneId=None,
    DomainName=None,
    PrivateZone=False,
    Name=None,
    Type=None,
    SetIdentifier=None,
    Weight=None,
    Region=None,
    GeoLocation=None,
    Failover=None,
    TTL=None,
    ResourceRecords=None,
    AliasTarget=None,
    HealthCheckId=None,
    TrafficPolicyInstanceId=None,
    region=None,
    key=None,
    keyid=None,
    profile=None,
):
    """
    Ensure the Route53 record is present.

    name
        The name of the state definition.  This will be used for Name if the latter is
        not provided.

    HostedZoneId
        The ID of a zone to create the record in.  Exclusive with DomainName.

    DomainName
        The domain name of a zone to create the record in.  Exclusive with HostedZoneId.

    PrivateZone
        Set to True if the resource record should be in a private zone, False if public.

    Name
        Name of the Route 53 resource record being managed.

    Type
        The record type (A, NS, MX, TXT, etc.)

    SetIdentifier
        Valid for Weighted, Latency, Geolocation, and Failover resource record sets only.
        An identifier that differentiates among multiple resource record sets that have the same
        combination of DNS name and type.  The value of SetIdentifier must be unique for each
        resource record set that has the same combination of DNS name and type. Omit SetIdentifier
        for any other types of record sets.

    Weight
        Valid for Weighted resource record sets only.  Among resource record sets that have the
        same combination of DNS name and type, a value that determines the proportion of DNS
        queries that Amazon Route 53 responds to using the current resource record set. Amazon Route
        53 calculates the sum of the weights for the resource record sets that have the same
        combination of DNS name and type. Amazon Route 53 then responds to queries based on the
        ratio of a resource's weight to the total.

        Note the following:
          - You must specify a value for the Weight element for every weighted resource record set.
          - You can only specify one ResourceRecord per weighted resource record set.
          - You can't create latency, failover, or geolocation resource record sets that have the
            same values for the Name and Type elements as weighted resource record sets.
          - You can create a maximum of 100 weighted resource record sets that have the same values
            for the Name and Type elements.
          - For weighted (but not weighted alias) resource record sets, if you set Weight to 0 for a
            resource record set, Amazon Route 53 never responds to queries with the applicable value
            for that resource record set.  However, if you set Weight to 0 for all resource record
            sets that have the same combination of DNS name and type, traffic is routed to all
            resources with equal probability.  The effect of setting Weight to 0 is different when
            you associate health checks with weighted resource record sets. For more information,
            see `Options for Configuring Amazon Route 53 Active-Active and Active-Passive Failover`__
            in the Amazon Route 53 Developer Guide.
            .. __: http://docs.aws.amazon.com/Route53/latest/DeveloperGuide/dns-failover-configuring-options.html

    Region
        Valid for Latency-based resource record sets only.  The Amazon EC2 Region where the resource
        that is specified in this resource record set resides. The resource typically is an AWS
        resource, such as an EC2 instance or an ELB load balancer, and is referred to by an IP
        address or a DNS domain name, depending on the record type.

    GeoLocation
        Geo location resource record sets only.  A dict that lets you control how Route 53 responds
        to DNS queries based on the geographic origin of the query.  For example, if you want all
        queries from Africa to be routed to a web server with an IP address of 192.0.2.111, create a
        resource record set with a Type of A and a ContinentCode of AF.

            ContinentCode
                The two-letter code for the continent.
                Valid values: AF | AN | AS | EU | OC | NA | SA
                Constraint: Specifying ContinentCode with either CountryCode or SubdivisionCode
                            returns an InvalidInput error.
            CountryCode
                The two-letter code for the country.
            SubdivisionCode
                The code for the subdivision, for example, a state in the United States or a
                province in Canada.

        Notes
          - Creating geolocation and geolocation alias resource record sets in private hosted zones
            is not supported.
          - If you create separate resource record sets for overlapping geographic regions (for
            example, one resource record set for a continent and one for a country on the same
            continent), priority goes to the smallest geographic region. This allows you to route
            most queries for a continent to one resource and to route queries for a country on that
            continent to a different resource.
          - You can't create two geolocation resource record sets that specify the same geographic
            location.
          - The value * in the CountryCode element matches all geographic locations that aren't
            specified in other geolocation resource record sets that have the same values for the
            Name and Type elements.
          - Geolocation works by mapping IP addresses to locations.  However, some IP addresses
            aren't mapped to geographic locations, so even if you create geolocation resource
            record sets that cover all seven continents, Amazon Route 53 will receive some DNS
            queries from locations that it can't identify.  We recommend that you create a resource
            record set for which the value of CountryCode is *, which handles both queries that
            come from locations for which you haven't created geolocation resource record sets and
            queries from IP addresses that aren't mapped to a location.  If you don't create a *
            resource record set, Amazon Route 53 returns a "no answer" response for queries from
            those locations.
          - You can't create non-geolocation resource record sets that have the same values for the
            Name and Type elements as geolocation resource record sets.

    TTL
        The resource record cache time to live (TTL), in seconds.
        Note the following:
          - If you're creating an alias resource record set, omit TTL. Amazon Route 53 uses the
            value of TTL for the alias target.
          - If you're associating this resource record set with a health check (if you're adding
            a HealthCheckId element), we recommend that you specify a TTL of 60 seconds or less so
            clients respond quickly to changes in health status.
          - All of the resource record sets in a group of weighted, latency, geolocation, or
            failover resource record sets must have the same value for TTL.
          - If a group of weighted resource record sets includes one or more weighted alias
            resource record sets for which the alias target is an ELB load balancer, we recommend
            that you specify a TTL of 60 seconds for all of the non-alias weighted resource record
            sets that have the same name and type. Values other than 60 seconds (the TTL for load
            balancers) will change the effect of the values that you specify for Weight.

    ResourceRecords
        A list, containing one or more values for the resource record.  No single value can exceed
        4,000 characters.  For details on how to format values for different record types, see
        `Supported DNS Resource Record Types`__ in the Amazon Route 53 Developer Guide.
        .. __: http://docs.aws.amazon.com/Route53/latest/DeveloperGuide/ResourceRecordTypes.html

        Note:  You can specify more than one value for all record types except CNAME and SOA.

        It is also possible to pass "magic" strings as resource record values.  This functionality
        can easily be extended, but for the moment supports the following:

            'magic:ec2_instance_tag:some_tag_name:some_string:some_instance_attr'

        This tells salt to lookup an EC2 instance with a tag 'some_tag_name' which has the value
        'some_string' and substitute the 'some_instance_attr' attribute of that instance as the
        resource record value being evaluated.

        This should work generally for any EC2 instance tags, as long as the instance attribute
        being fetched is available to getattr(instance, 'attribute') as seen in the code below.
        Anything else will most likely require this function to be extended to handle it.

        The canonical use-case for this (at least at our site) is to query the Name tag (which
        we always populate with the host's FQDN) to lookup the public or private IPs bound to the
        instance, so we can then automgically create Route 53 records for them.

    AliasTarget
        The rules governing how to define an AliasTarget for the various supported use-cases are
        obtuse beyond reason and attempting to paraphrase them (or even worse, cut-and-paste them
        in their entirety) would be silly and counterproductive.  If you need this feature, then
        Read The Fine Materials at the `Boto 3 Route 53 page`__ and/or the `AWS Route 53 docs`__
        and suss them for yourself - I sure won't claim to understand them partcularly well.
        .. __: http://boto3.readthedocs.io/en/latest/reference/services/route53.html#Route53.Client.change_resource_record_sets
        .. __: http://docs.aws.amazon.com/Route53/latest/APIReference/API_AliasTarget.html

    region
        The region to connect to.

    key
        Secret key to be used.

    keyid
        Access key to be used.

    profile
        Dict, or pillar key pointing to a dict, containing AWS region/key/keyid.
    """
    Name = Name if Name else name
    Name = _to_aws_encoding(Name)

    if Type is None:
        raise SaltInvocationError(
            "'Type' is a required parameter when adding or updatingresource records."
        )
    ret = {"name": name, "result": True, "comment": "", "changes": {}}

    args = {
        "Id": HostedZoneId,
        "Name": DomainName,
        "PrivateZone": PrivateZone,
        "region": region,
        "key": key,
        "keyid": keyid,
        "profile": profile,
    }
    zone = __salt__["boto3_route53.find_hosted_zone"](**args)
    if not zone:
        ret["comment"] = "Route 53 {} hosted zone {} not found".format(
            "private" if PrivateZone else "public", DomainName
        )
        log.info(ret["comment"])
        return ret
    zone = zone[0]
    HostedZoneId = zone["HostedZone"]["Id"]

    # Convert any magic RR values to something AWS will understand, and otherwise clean them up.
    fixed_rrs = []
    if ResourceRecords:
        for rr in ResourceRecords:
            if rr.startswith("magic:"):
                fields = rr.split(":")
                if fields[1] == "ec2_instance_tag":
                    if len(fields) != 5:
                        log.warning(
                            "Invalid magic RR value seen: '%s'.  Passing as-is.", rr
                        )
                        fixed_rrs += [rr]
                        continue
                    tag_name = fields[2]
                    tag_value = fields[3]
                    instance_attr = fields[4]
                    good_states = (
                        "pending",
                        "rebooting",
                        "running",
                        "stopping",
                        "stopped",
                    )
                    r = __salt__["boto_ec2.find_instances"](
                        tags={tag_name: tag_value},
                        return_objs=True,
                        in_states=good_states,
                        region=region,
                        key=key,
                        keyid=keyid,
                        profile=profile,
                    )
                    if len(r) < 1:
                        ret["comment"] = (
                            "No EC2 instance with tag {} == {} found".format(
                                tag_name, tag_value
                            )
                        )
                        log.error(ret["comment"])
                        ret["result"] = False
                        return ret
                    if len(r) > 1:
                        ret["comment"] = (
                            "Multiple EC2 instances with tag {} == {} found".format(
                                tag_name, tag_value
                            )
                        )
                        log.error(ret["comment"])
                        ret["result"] = False
                        return ret
                    instance = r[0]
                    res = getattr(instance, instance_attr, None)
                    if res:
                        log.debug(
                            "Found %s %s for instance %s",
                            instance_attr,
                            res,
                            instance.id,
                        )
                        fixed_rrs += [_to_aws_encoding(res)]
                    else:
                        ret["comment"] = "Attribute {} not found on instance {}".format(
                            instance_attr, instance.id
                        )
                        log.error(ret["comment"])
                        ret["result"] = False
                        return ret
                else:
                    ret["comment"] = (
                        "Unknown RR magic value seen: {}.  Please extend the "
                        "boto3_route53 state module to add support for your preferred "
                        "incantation.".format(fields[1])
                    )
                    log.error(ret["comment"])
                    ret["result"] = False
                    return ret
            else:
                fixed_rrs += [rr]
        ResourceRecords = [{"Value": rr} for rr in sorted(fixed_rrs)]

    recordsets = __salt__["boto3_route53.get_resource_records"](
        HostedZoneId=HostedZoneId,
        StartRecordName=Name,
        StartRecordType=Type,
        region=region,
        key=key,
        keyid=keyid,
        profile=profile,
    )

    if SetIdentifier and recordsets:
        log.debug(
            "Filter recordsets %s by SetIdentifier %s.", recordsets, SetIdentifier
        )
        recordsets = [r for r in recordsets if r.get("SetIdentifier") == SetIdentifier]
        log.debug("Resulted in recordsets %s.", recordsets)

    create = False
    update = False
    updatable = [
        "SetIdentifier",
        "Weight",
        "Region",
        "GeoLocation",
        "Failover",
        "TTL",
        "AliasTarget",
        "HealthCheckId",
        "TrafficPolicyInstanceId",
    ]
    if not recordsets:
        create = True
        if __opts__["test"]:
            ret["comment"] = (
                "Route 53 resource record {} with type {} would be added.".format(
                    Name, Type
                )
            )
            ret["result"] = None
            return ret
    elif len(recordsets) > 1:
        ret["comment"] = "Given criteria matched more than one ResourceRecordSet."
        log.error(ret["comment"])
        ret["result"] = False
        return ret
    else:
        rrset = recordsets[0]
        for u in updatable:
            if locals().get(u) != rrset.get(u):
                update = True
                break
        if ResourceRecords != sorted(
            rrset.get("ResourceRecords"), key=lambda x: x["Value"]
        ):
            update = True

    if not create and not update:
        ret["comment"] = (
            "Route 53 resource record {} with type {} is already in the desired state."
            "".format(Name, Type)
        )
        log.info(ret["comment"])
        return ret
    else:
        if __opts__["test"]:
            ret["comment"] = (
                "Route 53 resource record {} with type {} would be updated.".format(
                    Name, Type
                )
            )
            ret["result"] = None
            return ret
        ResourceRecordSet = {"Name": Name, "Type": Type}
        if ResourceRecords:
            ResourceRecordSet["ResourceRecords"] = ResourceRecords
        for u in updatable:
            ResourceRecordSet.update({u: locals().get(u)}) if locals().get(u) else None

        ChangeBatch = {
            "Changes": [
                {
                    "Action": "UPSERT",
                    "ResourceRecordSet": ResourceRecordSet,
                }
            ]
        }

        if __salt__["boto3_route53.change_resource_record_sets"](
            HostedZoneId=HostedZoneId,
            ChangeBatch=ChangeBatch,
            region=region,
            key=key,
            keyid=keyid,
            profile=profile,
        ):
            ret["comment"] = "Route 53 resource record {} with type {} {}.".format(
                Name, Type, "created" if create else "updated"
            )
            log.info(ret["comment"])
            if create:
                ret["changes"]["old"] = None
            else:
                ret["changes"]["old"] = rrset
            ret["changes"]["new"] = ResourceRecordSet
        else:
            ret["comment"] = (
                "Failed to {} Route 53 resource record {} with type {}.".format(
                    "create" if create else "update", Name, Type
                )
            )
            log.error(ret["comment"])
            ret["result"] = False

    return ret