# Buggy code
def install(self):
    # the file is a tar, so open it that way and extract it
    # to the specified (or default) roles directory
    local_file = False

    if self.scm:
        # create tar file from scm url
        tmp_file = RoleRequirement.scm_archive_role(**self.spec)
    elif self.src:
        if os.path.isfile(self.src):
            # installing a local tar.gz
            local_file = True
            tmp_file = self.src
        elif "://" in self.src:
            role_data = self.src
            tmp_file = self.fetch(role_data)
        else:
            api = GalaxyAPI(self.galaxy)
            role_data = api.lookup_role_by_name(self.src)
            if not role_data:
                raise AnsibleError(
                    "- sorry, %s was not found on %s." % (self.src, api.api_server)
                )

            if role_data.get("role_type") == "CON" and not os.environ.get(
                "ANSIBLE_CONTAINER"
            ):
                # Container Enabled, running outside of a container
                display.warning(
                    "%s is a Container Enabled role and should only be installed using "
                    "Ansible Container" % self.name
                )

            if role_data.get("role_type") == "APP":
                # Container Role
                display.warning(
                    "%s is a Container App role and should only be installed using Ansible "
                    "Container" % self.name
                )

            role_versions = api.fetch_role_related("versions", role_data["id"])
            if not self.version:
                # convert the version names to LooseVersion objects
                # and sort them to get the latest version. If there
                # are no versions in the list, we'll grab the head
                # of the master branch
                if len(role_versions) > 0:
                    loose_versions = [
                        LooseVersion(a.get("name", None)) for a in role_versions
                    ]
                    loose_versions.sort()
                    self.version = str(loose_versions[-1])
                elif role_data.get("github_branch", None):
                    self.version = role_data["github_branch"]
                else:
                    self.version = "master"
            elif self.version != "master":
                if role_versions and str(self.version) not in [
                    a.get("name", None) for a in role_versions
                ]:
                    raise AnsibleError(
                        "- the specified version (%s) of %s was not found in the list of available versions (%s)."
                        % (self.version, self.name, role_versions)
                    )

            tmp_file = self.fetch(role_data)

    else:
        raise AnsibleError("No valid role data found")

    if tmp_file:
        display.debug("installing from %s" % tmp_file)

        if not tarfile.is_tarfile(tmp_file):
            raise AnsibleError("the file downloaded was not a tar.gz")
        else:
            if tmp_file.endswith(".gz"):
                role_tar_file = tarfile.open(tmp_file, "r:gz")
            else:
                role_tar_file = tarfile.open(tmp_file, "r")
            # verify the role's meta file
            meta_file = None
            members = role_tar_file.getmembers()
            # next find the metadata file
            for member in members:
                if self.META_MAIN in member.name:
                    meta_file = member
                    break
            if not meta_file:
                raise AnsibleError(
                    "this role does not appear to have a meta/main.yml file."
                )
            else:
                try:
                    self._metadata = yaml.safe_load(
                        role_tar_file.extractfile(meta_file)
                    )
                except:
                    raise AnsibleError(
                        "this role does not appear to have a valid meta/main.yml file."
                    )

            # we strip off the top-level directory for all of the files contained within
            # the tar file here, since the default is 'github_repo-target', and change it
            # to the specified role's name
            installed = False
            while not installed:
                display.display("- extracting %s to %s" % (self.name, self.path))
                try:
                    if os.path.exists(self.path):
                        if not os.path.isdir(self.path):
                            raise AnsibleError(
                                "the specified roles path exists and is not a directory."
                            )
                        elif not getattr(self.options, "force", False):
                            raise AnsibleError(
                                "the specified role %s appears to already exist. Use --force to replace it."
                                % self.name
                            )
                        else:
                            # using --force, remove the old path
                            if not self.remove():
                                raise AnsibleError(
                                    "%s doesn't appear to contain a role.\n  please remove this directory manually if you really want to put the role here."
                                    % self.path
                                )
                    else:
                        os.makedirs(self.path)

                    # now we do the actual extraction to the path
                    for member in members:
                        # we only extract files, and remove any relative path
                        # bits that might be in the file for security purposes
                        # and drop the leading directory, as mentioned above
                        if member.isreg() or member.issym():
                            parts = member.name.split(os.sep)[1:]
                            final_parts = []
                            for part in parts:
                                if part != ".." and "~" not in part and "$" not in part:
                                    final_parts.append(part)
                            member.name = os.path.join(*final_parts)
                            role_tar_file.extract(member, self.path)

                    # write out the install info file for later use
                    self._write_galaxy_install_info()
                    installed = True
                except OSError as e:
                    error = True
                    if e[0] == 13 and len(self.paths) > 1:
                        current = self.paths.index(self.path)
                        nextidx = current + 1
                        if len(self.paths) >= current:
                            self.path = self.paths[nextidx]
                            error = False
                    if error:
                        raise AnsibleError(
                            "Could not update files in %s: %s" % (self.path, str(e))
                        )

            # return the parsed yaml metadata
            display.display("- %s was installed successfully" % str(self))
            if not local_file:
                try:
                    os.unlink(tmp_file)
                except (OSError, IOError) as e:
                    display.warning(
                        "Unable to remove tmp file (%s): %s" % (tmp_file, str(e))
                    )
            return True

    return False


# Traceback (TypeError)
$ mkdir -p /tmp/test; cd /tmp/test
$ git clone https://github.com/name/ansible-role-repository

$ tar -czf ansible-role-repository-folder.tar.gz ansible-role-repository
$ cd ansible-role-repository
$ tar -czf ansible-role-repository-cwd.tar.gz *; mv ansible-role-repository-cwd.tar.gz ..
# Upload the two archives somewhere

$ cat << EOF > ansible-role-requirements.yml
- name: role-folder
src: http://somewhere/ansible-role-folder.tar.gz
- name: role-cwd
src: http://somewhere/ansible-role-cwd.tar.gz
EOF

$ ansible-galaxy install -r ansible-role-requirements.yml -vvv --force
Opened /home/dmsimard/.ansible_galaxy
Validate TLS certificates: True
Connecting to galaxy_server: https://galaxy.ansible.com
Base API: https://galaxy.ansible.com/api/v1
found role {'scm': None, 'src': 'http://somewhere/ansible-role-folder.tar.gz', 'version': '', 'name': 'role-folder'} in yaml file
Validate TLS certificates: True
found role {'scm': None, 'src': 'http://somewhere/ansible-role-cwd.tar.gz', 'version': '', 'name': 'role-cwd'} in yaml file
Validate TLS certificates: True
Installing role role-folder
- downloading role from http://somewhere/ansible-role-folder.tar.gz
- extracting role-folder to playbooks/roles/role-folder
- role-folder was installed successfully
Installing role role-cwd
- downloading role from http://somewhere/ansible-role-cwd.tar.gz
- extracting role-cwd to playbooks/roles/role-cwd
ERROR! Unexpected Exception: join() takes at least 1 argument (0 given)
the full traceback was:

Traceback (most recent call last):
File "/home/dmsimard/dev/openstack/src/ansible/bin/ansible-galaxy", line 92, in <module>
exit_code = cli.run()
File "/home/dmsimard/dev/openstack/src/ansible/lib/ansible/cli/galaxy.py", line 157, in run
self.execute()
File "/home/dmsimard/dev/openstack/src/ansible/lib/ansible/cli/__init__.py", line 100, in execute
fn()
File "/home/dmsimard/dev/openstack/src/ansible/lib/ansible/cli/galaxy.py", line 409, in execute_install
installed = role.install()
File "/home/dmsimard/dev/openstack/src/ansible/lib/ansible/galaxy/role.py", line 291, in install
member.name = os.path.join(*final_parts)
TypeError: join() takes at least 1 argument (0 given)

# Fixed code
def install(self):
    # the file is a tar, so open it that way and extract it
    # to the specified (or default) roles directory
    local_file = False

    if self.scm:
        # create tar file from scm url
        tmp_file = RoleRequirement.scm_archive_role(**self.spec)
    elif self.src:
        if os.path.isfile(self.src):
            # installing a local tar.gz
            local_file = True
            tmp_file = self.src
        elif "://" in self.src:
            role_data = self.src
            tmp_file = self.fetch(role_data)
        else:
            api = GalaxyAPI(self.galaxy)
            role_data = api.lookup_role_by_name(self.src)
            if not role_data:
                raise AnsibleError(
                    "- sorry, %s was not found on %s." % (self.src, api.api_server)
                )

            if role_data.get("role_type") == "CON" and not os.environ.get(
                "ANSIBLE_CONTAINER"
            ):
                # Container Enabled, running outside of a container
                display.warning(
                    "%s is a Container Enabled role and should only be installed using "
                    "Ansible Container" % self.name
                )

            if role_data.get("role_type") == "APP":
                # Container Role
                display.warning(
                    "%s is a Container App role and should only be installed using Ansible "
                    "Container" % self.name
                )

            role_versions = api.fetch_role_related("versions", role_data["id"])
            if not self.version:
                # convert the version names to LooseVersion objects
                # and sort them to get the latest version. If there
                # are no versions in the list, we'll grab the head
                # of the master branch
                if len(role_versions) > 0:
                    loose_versions = [
                        LooseVersion(a.get("name", None)) for a in role_versions
                    ]
                    loose_versions.sort()
                    self.version = str(loose_versions[-1])
                elif role_data.get("github_branch", None):
                    self.version = role_data["github_branch"]
                else:
                    self.version = "master"
            elif self.version != "master":
                if role_versions and str(self.version) not in [
                    a.get("name", None) for a in role_versions
                ]:
                    raise AnsibleError(
                        "- the specified version (%s) of %s was not found in the list of available versions (%s)."
                        % (self.version, self.name, role_versions)
                    )

            tmp_file = self.fetch(role_data)

    else:
        raise AnsibleError("No valid role data found")

    if tmp_file:
        display.debug("installing from %s" % tmp_file)

        if not tarfile.is_tarfile(tmp_file):
            raise AnsibleError("the file downloaded was not a tar.gz")
        else:
            if tmp_file.endswith(".gz"):
                role_tar_file = tarfile.open(tmp_file, "r:gz")
            else:
                role_tar_file = tarfile.open(tmp_file, "r")
            # verify the role's meta file
            meta_file = None
            members = role_tar_file.getmembers()
            # next find the metadata file
            for member in members:
                if self.META_MAIN in member.name:
                    # Look for parent of meta/main.yml
                    # Due to possibility of sub roles each containing meta/main.yml
                    # look for shortest length parent
                    meta_parent_dir = os.path.dirname(os.path.dirname(member.name))
                    if not meta_file:
                        archive_parent_dir = meta_parent_dir
                        meta_file = member
                    else:
                        if len(meta_parent_dir) < len(archive_parent_dir):
                            archive_parent_dir = meta_parent_dir
                            meta_file = member
            if not meta_file:
                raise AnsibleError(
                    "this role does not appear to have a meta/main.yml file."
                )
            else:
                try:
                    self._metadata = yaml.safe_load(
                        role_tar_file.extractfile(meta_file)
                    )
                except:
                    raise AnsibleError(
                        "this role does not appear to have a valid meta/main.yml file."
                    )

            # we strip off any higher-level directories for all of the files contained within
            # the tar file here. The default is 'github_repo-target'. Gerrit instances, on the other
            # hand, does not have a parent directory at all.
            installed = False
            while not installed:
                display.display("- extracting %s to %s" % (self.name, self.path))
                try:
                    if os.path.exists(self.path):
                        if not os.path.isdir(self.path):
                            raise AnsibleError(
                                "the specified roles path exists and is not a directory."
                            )
                        elif not getattr(self.options, "force", False):
                            raise AnsibleError(
                                "the specified role %s appears to already exist. Use --force to replace it."
                                % self.name
                            )
                        else:
                            # using --force, remove the old path
                            if not self.remove():
                                raise AnsibleError(
                                    "%s doesn't appear to contain a role.\n  please remove this directory manually if you really want to put the role here."
                                    % self.path
                                )
                    else:
                        os.makedirs(self.path)

                    # now we do the actual extraction to the path
                    for member in members:
                        # we only extract files, and remove any relative path
                        # bits that might be in the file for security purposes
                        # and drop any containing directory, as mentioned above
                        if member.isreg() or member.issym():
                            parts = member.name.replace(archive_parent_dir, "").split(
                                os.sep
                            )
                            final_parts = []
                            for part in parts:
                                if part != ".." and "~" not in part and "$" not in part:
                                    final_parts.append(part)
                            member.name = os.path.join(*final_parts)
                            role_tar_file.extract(member, self.path)

                    # write out the install info file for later use
                    self._write_galaxy_install_info()
                    installed = True
                except OSError as e:
                    error = True
                    if e[0] == 13 and len(self.paths) > 1:
                        current = self.paths.index(self.path)
                        nextidx = current + 1
                        if len(self.paths) >= current:
                            self.path = self.paths[nextidx]
                            error = False
                    if error:
                        raise AnsibleError(
                            "Could not update files in %s: %s" % (self.path, str(e))
                        )

            # return the parsed yaml metadata
            display.display("- %s was installed successfully" % str(self))
            if not local_file:
                try:
                    os.unlink(tmp_file)
                except (OSError, IOError) as e:
                    display.warning(
                        "Unable to remove tmp file (%s): %s" % (tmp_file, str(e))
                    )
            return True

    return False