giseldo/neodataset huggingface dataset:
missing subcircuit schematic sheet reusability (lp:#1853479)

[Original report](https://bugs.launchpad.net/bugs/1853479) created by **daddyzaur (daddyzaur)**
```
KiCAD 5.1.4
Existing subcircuit schematic sheets must be re-built with input/output
pins any time when used
```
Original tags: eeschema ngspice

Story points: 6.0
wrong semantic for read-only when started from command line (lp:#1853421)

[Original report](https://bugs.launchpad.net/bugs/1853421) created by **M. Scholz (srtlg)**
```
Hello.

Kicad uses wxFileName.IsDirWritable in KICAD_MANAGER_FRAME::LoadProject to
determine whether a project is read-only. This does not work properly when
you start it in the command line from the directory the .pro file is
located in.  I was genuinely surprised and didn't understand why my project
was read only when this occurred.

./test test
GetName() test
GetFullPath() test
Exists() 1
IsAbsolute() 0
IsDirWritable() 0

./test ./test
GetName() test
GetFullPath() ./test
Exists() 1
IsAbsolute() 0
IsDirWritable() 1

A possible fix is appended.
```

Story points: 6.0
ERC pin not driven points to wrong pin (lp:#1853413)

[Original report](https://bugs.launchpad.net/bugs/1853413) created by **Rene Poeschl (poeschlr)**
```
During testing for https://bugs.launchpad.net/kicad/+bug/1827773 i noticed
that ERC points to the pin of a resistor with an ERC error that should
point to the power input pin of a connected IC.

KiCad version
Application: KiCad
Version: (5.1.4)-1, release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.61.1 OpenSSL/1.1.1 (WinSSL) zlib/1.2.11 brotli/1.0.6
libidn2/2.0.5 libpsl/0.20.2 (+libidn2/2.0.5) nghttp2/1.34.0
Platform: Windows 8 (build 9200), 64-bit edition, 64 bit, Little endian,
wxMSW
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8)
    Boost: 1.68.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.61.1
    Compiler: GCC 8.2.0 with C++ ABI 1013

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON
```
Original tags: eeschema erc

Story points: 6.0
pcbnew segfaults on footprint search (lp:#1853380)

[Original report](https://bugs.launchpad.net/bugs/1853380) created by **evils (evils)**
```
when searching for a footprint in pcbnew's "add footprint", it segfaults

i encountered this issue on NixOS on kicad 5.1.4, i've since built kicad
from git revision 3be1862

triggering the crash via valgrind is somewhat tricky, most of the time the
search lists results but the footprint preview says "footprint not found"
in which case this it does not segfault.
i've succeeded at this several times and i am under the impression the
address accessed is not always 0x0
here are a few more segfaults caught via just gdb
https://paste.ee/p/tVFgB

included as comments are the gdb bt full and valgrind output for pcbnew
from 3be1862 with the most recent footprints etc for that commit
the .pcbnew-wrapped and all the /nix/store/[hash] stuff is due to this
running on NixOS
i'm fairly sure this issue isn't due to NixOS, due to an anecdotal report
on the freenode #kicad IRC channel of someone experiencing this issue on
debian10 when using xfwm (i'm using i3wm)
further information is available here,
https://github.com/NixOS/nixpkgs/issues/72248
most relevant to my build setup may be this, https://github.com/Evils-
Devils/nixpkgs/tree/kicad-unstable

Application: KiCad
Version: 5.99.0-2019-11-20, debug build
Libraries:
    wxWidgets 3.1.2
    libcurl/7.66.0 OpenSSL/1.1.1d zlib/1.2.11 libssh2/1.9.0 nghttp2/1.39.2
Platform: Linux 4.19.80 x86_64, 64 bit, Little endian, wxGTK
Build Info:
    Build date: Jan  1 1970 00:00:01
    wxWidgets: 3.1.2 (wchar_t,wx containers) GTK+ 3.24
    Boost: 1.67.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.66.0
    Compiler: GCC 8.3.0 with C++ ABI 1013

Build settings:
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=ON
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON
    KICAD_STDLIB_DEBUG=ON
    KICAD_SANITIZE=OFF
```
Original tags: pcbnew

Story points: 8.0
eeschema erc: Duplicate hierarchical sheet labels do not cause ERC errors. (lp:#1853344)

[Original report](https://bugs.launchpad.net/bugs/1853344) created by **Victor W (vicw)**
```
When running ERC on EEScheme, it is possible for child sheets to have
duplicate hierarchical sheet labels, and this does not trigger an ERC
warning or error.

Additionally, this results in those pins sharing a net.

I believe this is a bug because I can't think of a reasonable case in which
it is desirable to have duplicate hierarchical sheet labels that need to be
connected upstream; if you need to share a net, then the reasonable thing
to do is to have a single hierarchical label port (say, VCC), then use
internal net labels to connect them to several other ports.

However, if you don't realize that you have duplicate hierarchical labels
(as what may happen if you copy/paste hierarchical labels, and forget to
change one of them, but have different net labels), then you've
unintentionally caused a short in your design.

===
Example 1:

1. On the top level sheet of a hierarchical design, add a child sheet, with
some ports.

2. From within the child design, rename two of the ports to have the same
name, and synchronize it within the parent design.

4. Run eeschema DRC.

===

RESULT:

1. No errors or violations will be noted.

===

Expected:

1. I expect that duplicate hierarchical labels should trigger a warning;
it's not obvious that someone would do this intentionally. It's far more
likely that this was unintentional and should be flagged as a warning or
error.
```
Original tags: eeschema erc

Story points: 6.0
eeschema sigsegv on symbol filtering (lp:#1853341)

[Original report](https://bugs.launchpad.net/bugs/1853341) created by **Mike (5-ubuntu1)**
```
On my Mac version of eeschema, I can reliably crash it by filtering symbols
when going to add.

Reproduction information:

1. Start eeschema
2. Hit 'a' to add a symbol to your schematic
3. Scroll down (I used the trackpad) a bit and pick something (I picked
FX614 from Interface_Telecom)
4. Type 'jj' or some similar garbage into the search box, which returns no
results on mine
5. Delete the contents of the search box (Select-All, then Backspace),
which returns you to the selection of FX614
6. Type anything into the now-empty search box, and it will crash

Version information:

Application: kicad
Version: (5.0.0-3-g5ebb6b6), release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.54.0 LibreSSL/2.6.5 zlib/1.2.11 nghttp2/1.24.1
Platform: Mac OS X (Darwin 18.7.0 x86_64), 64 bit, Little endian, wxMac
Build Info:
    wxWidgets: 3.0.4 (UTF-8,STL containers,compatible with 2.8)
    Boost: 1.67.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.51.0
    Compiler: Clang 8.0.0 with C++ ABI 1002

Build settings:
    USE_WX_GRAPHICS_CONTEXT=ON
    USE_WX_OVERLAY=ON
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_ACTION_MENU=OFF
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

I have attached the crash log from macOS and will try to reproduce this bug
on a newer stable version of KiCad.
```

Story points: 6.0
Overzealous warning when creating new board (lp:#1853338)

[Original report](https://bugs.launchpad.net/bugs/1853338) created by **Ian McInerney (imcinerney)**
```
When running pcbnew in standalone mode, if you have a board open and saved,
clicking on the new board menu item will give a dialog saying that the
current board will be lost. It does this even if there have been no
modifications since the last time the board was saved.

This warning should be modified to warn the user if there are unsaved
changes (and maybe give the option to save the board then), and say that it
will be closed. Saying that the board will be lost is a very drastic
warning if the board is actually saved to disk already, and therefore is
still openable from the disk (saying it will be lost makes it sound like
you will not be able to recover it).


Application: Pcbnew
Version: (5.99.0-397-g3c828750c-dirty), debug build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.65.3 OpenSSL/1.1.1c-fips zlib/1.2.11 brotli/1.0.7
libidn2/2.2.0 libpsl/0.20.2 (+libidn2/2.0.5) libssh/0.9.0/openssl/zlib
nghttp2/1.38.0
Platform: Linux 5.1.18-300.fc30.x86_64 x86_64, 64 bit, Little endian, wxGTK
Build Info:
    Build date: Nov 19 2019 17:30:36
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8) GTK+ 3.24
    Boost: 1.69.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.65.3
    Compiler: Clang 8.0.0 with C++ ABI 1002

Build settings:
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=ON
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON
    KICAD_STDLIB_DEBUG=OFF
    KICAD_STDLIB_LIGHT_DEBUG=ON
    KICAD_SANITIZE=ON
```
Original tags: pcbnew ui

Story points: 6.0
Footprint Editor: Deleting a pad from Locked Footprint chrashes KiCad (lp:#1853104)

[Original report](https://bugs.launchpad.net/bugs/1853104) created by **dhaillant (david-haillant)**
```
In ModEdit, with a Locked footprint ("Footprint properties"/"Lock
footprint" checked), when I try to delete a pad (delete key), the editor
freezes (a partial window border appears where the mouse cursor was
located) and then few seconds later, KiCad crashes.

(Something similar happens when deleting locked components within pcbnew).

If the footprint is not tagged "Lock footprint", then deletion is possible.


Application: ModEdit
Version: 5.1.4-e60b266~84~ubuntu16.04.1, release build
Libraries:
    wxWidgets 3.0.2
    libcurl/7.47.0 OpenSSL/1.0.2g zlib/1.2.8 libidn/1.32 librtmp/2.3
Platform: Linux 4.4.0-166-generic x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.2 (wchar_t,wx containers,compatible with 2.8) GTK+ 2.24
    Boost: 1.58.0
    OpenCASCADE Community Edition: 6.8.0
    Curl: 7.47.0
    Compiler: GCC 5.4.0 with C++ ABI 1009
Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON
```

Story points: 6.0
Bus entry mirror and rotate not working (lp:#1853079)

[Original report](https://bugs.launchpad.net/bugs/1853079) created by **Franck78 (fbourdonnec)**
```
there is no reason why shortcuts R,X,Y don't act the same way on
-adding a bus entry
-existing bus entry !

V6 only (5.990.0-341)

V5 probably but there is no visual icon to see.
```
Original tags: eeschema

Story points: 10.0
Canceling "add component dialog" does not end "add component mode" (lp:#1853077)

[Original report](https://bugs.launchpad.net/bugs/1853077) created by **Franck78 (fbourdonnec)**
```
open eeschema
'A' to add a component
select one
Validate
Place your component

click again, the dialog opens again

maybe you wanted another component, fine.
Or you choose cancel.

and you want to return to normal 'select' mode, NOT SEE THE SAME DIALOG
when you click something.

V5 & V6
```
Original tags: eeschema

Story points: 6.0
edge.cuts polygons (lp:#1853073)

[Original report](https://bugs.launchpad.net/bugs/1853073) created by **Franck78 (fbourdonnec)**
```
select edges.cuts layer
draw a valid polygon
it is converted into 'lines'

select silk layer
draw a valid polygon
(what's the purpose of this btw?)
edit polygon's properties
change layer to edges.cuts.

Polygone stays polygon and this is very good because contrario to some
belief, a polygon works WELL in this layer
See image

It also WORKS WELL in footprint editor despite edge.cuts layer being
disabled for no reason.

=>stop destroying polygons
=>make them without background color also

v5 & v6 same behaviour
Application: KiCad
Version: (5.99.0-341-g9d288968e), debug build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.58.0 GnuTLS/3.5.18 zlib/1.2.11 libidn2/2.0.4 libpsl/0.19.1
(+libidn2/2.0.4) nghttp2/1.30.0 librtmp/2.3
Platform: Linux 4.15.0-66-generic x86_64, 64 bit, Little endian, wxGTK
Build Info:
    Build date: Nov 11 2019 11:57:46
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8) GTK+ 3.22
    Boost: 1.65.1
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.58.0
    Compiler: GCC 7.4.0 with C++ ABI 1011

Build settings:
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=OFF
    KICAD_STDLIB_DEBUG=ON
    KICAD_SANITIZE=OFF
```
Original tags: pcbnew

Story points: 6.0
pcbnew segfault on deletion of locked objects (lp:#1853072)

[Original report](https://bugs.launchpad.net/bugs/1853072) created by **Damien Walsh (m4infr4me)**
```
Application: Pcbnew
Version: (5.1.4-0-10_14), release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.54.0 LibreSSL/2.6.5 zlib/1.2.11 nghttp2/1.24.1
Platform: Mac OS X (Darwin 18.7.0 x86_64), 64 bit, Little endian, wxMac
Build Info:
    wxWidgets: 3.0.4 (wchar_t,STL containers,compatible with 2.8)
    Boost: 1.69.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.54.0
    Compiler: Clang 9.0.0 with C++ ABI 1002

Build settings:
    USE_WX_GRAPHICS_CONTEXT=ON
    USE_WX_OVERLAY=ON
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

Steps to reproduce:

Create an empty board.
Place a via or track.
Open properties for the via or track and mark it as locked.
Click OK.
Delete the via or track (press backspace or use the Edit menu with the via
or track selected).

Note: for footprints, the warning message appears as expected but pcbnew
still crashes upon confirmation.
```

Story points: 6.0
pcbnew: overlapping vias in high contrast (lp:#1853068)

[Original report](https://bugs.launchpad.net/bugs/1853068) created by **Fabien Corona (drinausaur)**
```
With the high contrast mode, if two microvias / blind vias are overlapping,
the displayed result may be incorrect.
example : I set a microvia from layer 2 to 3 and another from 4 to 5.
The draw order of these two vias seems constant whatever the active layer
is.
Therefore if the first microvia has the highest priority, then I see a
darkened via when looking at layer 4 or 5, but I should be seeing the
second via.

Maybe the draw priority for vias should depend on the active layer.
for information, the layer affected are : LAYER_VIA_MICROVIA,
LAYER_VIA_BBLIND and LAYER_VIAS_HOLES

See video.


Application: Pcbnew
Version: 5.99.0-unknown-f8aea24~100~ubuntu18.04.1, release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.58.0 OpenSSL/1.1.1 zlib/1.2.11 libidn2/2.0.4 libpsl/0.19.1
(+libidn2/2.0.4) nghttp2/1.30.0 librtmp/2.3
Platform: Linux 4.15.0-54-generic x86_64, 64 bit, Little endian, wxGTK
Build Info:
    Build date: Nov 16 2019 00:34:10
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8) GTK+ 3.22
    Boost: 1.65.1
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.58.0
    Compiler: GCC 7.4.0 with C++ ABI 1011

Build settings:
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=ON
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON
```
Original tags: pcbnew

Story points: 6.0
keep out area layer select issue (lp:#1853039)

[Original report](https://bugs.launchpad.net/bugs/1853039) created by **ocb-hd-ccb (ocb-hd-ccb)**
```
Alright, I have never used the keepout tool before. I selected both layers
in the properties and also checked the keepout copper pours. When I went to
edit the properties again the B.Cu wasn't selected. So, I selected it and
hit OK. Then I went back to check and it still wasn't 'ON'.

I than ran DRC and got this error: See attached image

```
Application: Pcbnew
Version: (5.99.0-355-g65994e4a7), debug build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.64.1 SecureTransport (LibreSSL/2.8.3) zlib/1.2.11
nghttp2/1.39.2
Platform: Mac OS X (Darwin 19.0.0 x86_64), 64 bit, Little endian, wxMac
Build Info:
    Build date: Nov 11 2019 16:27:56
    wxWidgets: 3.0.4 (wchar_t,STL containers,compatible with 2.8)
    Boost: 1.69.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.54.0
    Compiler: Clang 9.0.0 with C++ ABI 1002

Build settings:
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON
    KICAD_STDLIB_DEBUG=OFF
    KICAD_STDLIB_LIGHT_DEBUG=OFF
    KICAD_SANITIZE=OFF
```
```
Original tags: pcbnew

Story points: 6.0
Board edge rendering issue with ray tracing (lp:#1852970)

[Original report](https://bugs.launchpad.net/bugs/1852970) created by **Enrico (eatis)**
```
I stumbled upon a rendering issue with the ray tracing renderer. When I
turned on the ray tracing, the edges of my 6 layer board looked kind of
sketchy and one was even completely transparent. I tried to reproduce the
issue with a minimum of components.
1) I can't reproduce the same effect
2) Something else happened - one board side has a black king of overlay
3) It only seems to happen if the board has more than two layers

I left the settings for the ray tracing renderer "as is" and only disabled
"add floor" but this particular setting makes no difference. I attached
some screen shots and my minimum (not) working example. Some people from
the forum confirmed that they also see the issue
(https://forum.kicad.info/t/transparent-board-edge-with-ray-
tracing/19857/4).
I can't share with you the board file with the transparent edge because I'm
working under an NDA but I will try to help as best as I can.

Application: KiCad
Version: 5.1.4-e60b266~84~ubuntu18.04.1, release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.58.0 OpenSSL/1.1.1 zlib/1.2.11 libidn2/2.0.4 libpsl/0.19.1
(+libidn2/2.0.4) nghttp2/1.30.0 librtmp/2.3
Platform: Linux 4.15.0-70-generic x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8) GTK+ 3.22
    Boost: 1.65.1
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.58.0
    Compiler: GCC 7.4.0 with C++ ABI 1011

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=ON
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=ON
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON
```
Original tags: 3d-viewer

Story points: 8.0
macOS Mojave moving window between retina/non-retina results in viewport scaling wrong and mouse being offset (lp:#1852953)

[Original report](https://bugs.launchpad.net/bugs/1852953) created by **Eli (elijahg)**
```
Moving an Eeschema or Pcbnew window from a retina (hidpi) display to non-
retina display results in the mouse that Kicad displays being offset from
the mouse the OS displays. Moving a window from non-retina to retina
results in the canvas being positioned in the bottom left of the window, at
1/4 size, again with the mouse offset.

Twiddling the canvas scale setting in preferences presumably causes a
redraw which fixes the scaling issue and mouse issue in both directions.
However, the "automatic" setting seems to adjust the scale based on which
window the preferences window is in, not the window the main editor is in.
It does correctly scale the UI by 1 on non-retina, and 2 on retina though.


Application: KiCad
Version: (5.1.4-0-10_14), release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.54.0 LibreSSL/2.6.5 zlib/1.2.11 nghttp2/1.24.1
Platform: Mac OS X (Darwin 18.7.0 x86_64), 64 bit, Little endian, wxMac
Build Info:
    wxWidgets: 3.0.4 (wchar_t,STL containers,compatible with 2.8)
    Boost: 1.69.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.54.0
    Compiler: Clang 9.0.0 with C++ ABI 1002

Build settings:
    USE_WX_GRAPHICS_CONTEXT=ON
    USE_WX_OVERLAY=ON
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON
```
Original tags: macos

Story points: 6.0
gerbview aperture macros optional arguments to primitives ignored (lp:#1852924)

[Original report](https://bugs.launchpad.net/bugs/1852924) created by **julian (joposter)**
```
Gerber allows optional primitive arguments (e.g. for circles an optional
rotation parameter can be given). While the appropriate behaviour to handle
them is is properly documented in the code, it is not implemented.

This results in the 'sample_macro.gbr' of the Ucamco test suite
(https://www.ucamco.com/files/downloads/file/210/gerber_file_format_examples%2020181113.zip)
 getting parsed incorrectly (see attached images).

The fix is simple. I have attached a patch.
```
Original tags: gerber gerbview import

Story points: 6.0
Project manager: files in nested dir are not added to hierarchy (lp:#1852904)

[Original report](https://bugs.launchpad.net/bugs/1852904) created by **Mikołaj Wielgus (mwielgus)**
```
When a file is created in or renamed into a subdirectory of a project
subdirectory, it's not visible in the project manager hierarchy. It becomes
visible after restarting Kicad.

This is most likely due to the most-nested directory not being added to the
filesystem watcher on its creation. Interestingly, this happens only to
subdirectories of project subdirectories, and not to subdirectories of the
project itself.

Application: KiCad
Version: (5.99.0-385-g911470903-dirty), release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.67.0 OpenSSL/1.1.1d (Schannel) zlib/1.2.11 brotli/1.0.7
libidn2/2.2.0 libpsl/0.21.0 (+libidn2/2.1.1) nghttp2/1.39.2
Platform: Windows 8 (build 9200), 64-bit edition, 64 bit, Little endian,
wxMSW
Build Info:
    Build date: Nov 17 2019 12:21:11
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8)
    Boost: 1.71.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.67.0
    Compiler: GCC 9.2.0 with C++ ABI 1013

Build settings:
    KICAD_SCRIPTING=OFF
    KICAD_SCRIPTING_MODULES=OFF
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=OFF
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=OFF
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON
```

Story points: 6.0