giseldo/neodataset huggingface dataset:
Fork ngx-plyr and fix the type issues reported by Ben

Ben reported some issues in ngx-plyr here which is the official plugin for angular plyr. The maintainers are behind the eightball, so it will be easier for us to fork and maintain our own version


https://github.com/smnbbrv/ngx-plyr/issues/31

- [x] Fork the ngx-plyr library
- [x] Fix the type issues that Ben reported
- [ ] Make sure we wrap the internal libraries in try catches so that way we can shut up all of the run time errors clogging up sentry

Story points: 8.0
Group SEO missing image

<!---
Please read this!

Before opening a new issue, make sure to search for keywords in the issues
filtered by the "T - Bug" label and verify the issue you're about to submit isn't a duplicate.
--->

### Summary

https://www.minds.com/media/1078363097386270720

### Steps to reproduce

1. Copy a group e.g. https://www.minds.com/groups/profile/936081718591709184/feed
2. Paste it into the new post box
3. Await iframely response
4. No image

### Platform information 

Cross-platform web

### What is the current *bug* behavior?

iframely does not see an image for the rich-embed.

### What is the expected *correct* behavior?

the image should be in whatever meta-tag iframely is using to get the image.

### Relevant logs and/or screenshots

![image](/uploads/dae680b67c1207529a7e9fd9d36bfb7f/image.png)

### Possible fixes

(If you can, link to the line of code that might be responsible for the problem)

Story points: 4.0
Ckeditor styling fixes and clean up

- [x] Get rid of the outline when the editor has focus

- [x] Make the tool bars match our existing editor
https://www.evernote.com/l/AGv3mcp6MGdNM41RQ3ftKilTiP6YJYa90cIB/image.png

- [x] Editor font size

- [x] Colors in light mode and dark mode

- [x] Tool bar should appear above the text

- [x] Left hand plus button to enable media upload and embed

Add the left hand plus button via the block editor plugin so we have nice controls on the left hand side
https://ckeditor.com/docs/ckeditor5/latest/features/blocktoolbar.html

Story points: 6.0
Onboarding 2fa confirmation undesigned

![Screenshot_20200220-175452_Zulip](/uploads/bf6252a7c1612f0b5177b2afd50c9d9f/Screenshot_20200220-175452_Zulip.jpg)

- [x] Fix the formatting issues with 2fa
- [ ] Use the existing styles for the new onboarding. We should be able to infer how it will look. Let me know if we need to get Michael to design it.
- [ ] Light mode and dark mode

Story points: 4.0
Implement the Your Devices screen

Currently our /v1/settings/endpoint only returns the number of sessions with a button to close them all.

I've created a backend card for @markeharding to either extend the session available information or to assign it with details on how we should make this change, since we're only storing jwts and none of the required information.

Roll this card with the "you currently have X" sessions functionality and the existing close all sessions until we get clarity on implementing the specific mocks below

Story points: 4.0
Implement the actual settings panels with update calls to the backend

This should be reskinning of existing functionality on the settings / dropdown. The harder stuff is in separate cards


- [x] Account

https://design.minds.com/hosted/web/michael/front%232153-settings/

https://design.minds.com/hosted/web/michael/front%232153-settings/#artboard1

- [x] Saving of Display Name

https://design.minds.com/hosted/web/michael/front%232153-settings/#artboard2

- [x] Email address

https://design.minds.com/hosted/web/michael/front%232153-settings/#artboard3

- [x] Language

https://design.minds.com/hosted/web/michael/front%232153-settings/#artboard4

- [x] Password

https://design.minds.com/hosted/web/michael/front%232153-settings/#artboard5

- [x] Notifications

https://design.minds.com/hosted/web/michael/front%232153-settings/#artboard6

- [x] NSFW

https://design.minds.com/hosted/web/michael/front%232153-settings/#artboard7

- [x] Deactivate 

https://design.minds.com/hosted/web/michael/front%232153-settings/#artboard8

https://design.minds.com/hosted/web/michael/front%232153-settings/#artboard9

- [x] Delete

https://design.minds.com/hosted/web/michael/front%232153-settings/#artboard10

https://design.minds.com/hosted/web/michael/front%232153-settings/#artboard11

- [ ] Security

https://design.minds.com/hosted/web/michael/front%232153-settings/#artboard12

https://design.minds.com/hosted/web/michael/front%232153-settings/#artboard13

https://design.minds.com/hosted/web/michael/front%232153-settings/#artboard14

https://design.minds.com/hosted/web/michael/front%232153-settings/#artboard15

- [ ] Billing

https://design.minds.com/hosted/web/michael/front%232153-settings/#artboard16

https://design.minds.com/hosted/web/michael/front%232153-settings/#artboard17

https://design.minds.com/hosted/web/michael/front%232153-settings/#artboard18

https://design.minds.com/hosted/web/michael/front%232153-settings/#artboard19

- [x] Other

https://design.minds.com/hosted/web/michael/front%232153-settings/#artboard9

https://design.minds.com/hosted/web/michael/front%232153-settings/#artboard8

https://design.minds.com/hosted/web/michael/front%232153-settings/#artboard11

any settings left over from the old design should go under Other

- [x] Dark mode

https://design.minds.com/hosted/web/michael/front%232153-settings/#artboard21

- [x] Responsive

https://design.minds.com/hosted/web/michael/front%232153-settings/#artboard22

https://design.minds.com/hosted/web/michael/front%232153-settings/#artboard23

https://design.minds.com/hosted/web/michael/front%232153-settings/#artboard24

https://design.minds.com/hosted/web/michael/front%232153-settings/#artboard25

https://design.minds.com/hosted/web/michael/front%232153-settings/#artboard26

https://design.minds.com/hosted/web/michael/front%232153-settings/#artboard27

- [ ] e2e tests
- [ ] unit tests
- [x] Light mode

Story points: 24.0
Implement new compose buttons and menus on web, small phone screens responsive layout

- [x] In the new compose, implement the various responsive buttons and their fly out menus
- [x] Implement tag menu
- [x] Implement tag history dropdown from device storage
- [x] Tag selection
- [x] Tag type ahead
- [x] ~~Licensing menu~~ (Already done in #2504)
- [x] ~~Visibility~~ (Already done in #2504)
- [x] Paywall
- [x] Paywall confirmation
- [x] NSFW menu
- [x] Responsive
- [x] Implement small phone screens responsiveness
- [x] Light mode
- [x] Dark mode
- [ ] e2e tests
- [ ] Unit tests

Mocks
https://design.minds.com/hosted/web/michael/front%231280-composer/#artboard9
https://design.minds.com/hosted/web/michael/front%231280-composer/#artboard10
https://design.minds.com/hosted/web/michael/front%231280-composer/#artboard11
https://design.minds.com/hosted/web/michael/front%231280-composer/#artboard12
https://design.minds.com/hosted/web/michael/front%231280-composer/#artboard13
https://design.minds.com/hosted/web/michael/front%231280-composer/#artboard14
https://design.minds.com/hosted/web/michael/front%231280-composer/#artboard15
https://design.minds.com/hosted/web/michael/front%231280-composer/#artboard16
https://design.minds.com/hosted/web/michael/front%231280-composer/#artboard17

Story points: 36.0
Reimplement our "change cover photo" video thumbnail picker + the ability to upload a thumbnail in the new Compose

When a video has been uploaded, transcoded and thumbnailed, provide the thumbnail picker format

- [ ] Ability to pick from transcoded thumbnails
- [ ] Ability to upload one image as a thumb nail / screen
- [ ] Uploading an image should replace the custom thumbnail
- [ ] X button deletes custom thumbnail
- [ ] Light mode
- [ ] Dark mode
- [ ] Responsive
- [ ] E2E tests
- [ ] Unit tests

Mocks:
https://design.minds.com/hosted/web/michael/front%231280-composer/#artboard3
https://design.minds.com/hosted/web/michael/front%231280-composer/#artboard4
https://design.minds.com/hosted/web/michael/front%231280-composer/#artboard5

Story points: 6.0
Build a minified bundle of CKEditor 5 with the required plugin

- [x] Get @markeharding to setup a new repository for our new npm package
- [x] Initialize the npm repo with a CI buildable and auto publishing minds-blog-editor
- [x] Setup a build script for the ckeditor, balloon and attachment prototype
- [x] Minify and compress the bundle as much as we can
- [x] Provide an importable angular component so we can just reference the editor wherever we need it to be

End result is the same as any other npm package, we need a ci job that listens to commits to master and pushes to npm so it auto updates.

Story points: 16.0
Fix custom domain signup modal on action

Improve visual appearance.

Conversation from Zulip:

Bill Ottman8:14 AM
I mean, you could also just make the title look better and get rid of the blank space if the logo isn't working. anything, but we should never look at a screen like that and let it through

Ben8:18 AM
Okay, I'll log it as an urgent issue, and see what I can do with the styling. Might end up having to be a bit shorter.

Mark Harding8:18 AM
I remember talking about the issue, we're using the wrong value

 8:18 AM
for the logo guid

Ben8:19 AM
There was a fix pending for it for a while, but we couldn't get the subdomains to work on sandboxes if i recall correctly, so ended up removing the modal from showing on scroll

xander-miller8:20 AM
The wire button looks out of place there too. We could just have the wire button on the top level on pro sites. I doesn't need to be on every post.
pasted image




Story points: 4.0
Pro settings subscription page nav

### Summary

Unable to navigate away from the Pro settings/subscription page to other Pro settings pages.  (Also the cancel subscription button should probably be red/grey and not green) 

### Steps to reproduce

Go to Pro settings, click the 'Pro Subscription' link in the sidebar. Once there, try to navigate to any of the other links in the Pro settings sidebar.  The url changes, but the component doesn't. 

### Platform information 

Macbook pro 15"

### What is the current *bug* behavior?

Getting stuck on the Pro settings/subscription page.

### What is the expected *correct* behavior?

You should be able to go to other settings pages and not get stuck

### Relevant logs and/or screenshots

![image](/uploads/0a951325846b6149329f02f0ee3e89ff/image.png)


/label ~"T \- Bug" ~"S \- Triage:new" 


Story points: 4.0
Changing general setting in firefox does not enable save button


### Summary

Changing general settings in Firefox does not enable save button. Email settings does work in firefox, use that as a template.

### Steps to reproduce

1. Go to https://www.minds.com/settings/general
2. Edit Mature Content checkbox save button will not enable

### Platform information 

Browser, Firefox

### What is the current *bug* behavior?

Save button on https://www.minds.com/settings/general does not enable

### What is the expected *correct* behavior?

Save button should enable like save button on https://www.minds.com/settings/emails when settings are changed

### Relevant logs and/or screenshots

![image](/uploads/f54c16a2d72dc7382ec4c36c7660355d/image.png)

Story points: 4.0
Fix Composer Issues from Design QA

- [x] Schedule post menu should anchor to bottom right of the button
- [x] Visibility/License menu should anchor top left of the ellipsis trigger
- [x] 2nd level menus (License/Visibility) should anchor top right left of the parent option
- [x] 2nd level menus (License/Visibility) should overlap a little over its parent menu
- [x] Add right padding on general text body and trending tags list on Hashtags popup
- [x] Title spacing, paddings and bottom bar height (action button) should be the same on main composer and popups
- [x] Avoid height jumping when adding a new tag on Hashtags popup
- [x] Avoid height jumping on calendar when browsing through months on Schedule Post popup
- [x] Avoid height jumping when clicking Enable Paywall on Monetize popup
- [x] The popup [X] button should be replaced with a "Close" label

Story points: 2.0
Implement the new account settings screen

Under the new nav, we're creating a new two column layout for the settings screen


https://design.minds.com/hosted/web/michael/front%232153-settings/#artboard0

- [ ] Left hand panel with the settings nav
- [ ] Right hand panel with the individual settings screens
- [ ] Light mode
- [ ] Dark mode
- [ ] Unit tests
- [ ] End to end tests
- [ ] Behind a "settings" feature flag that must be mapped on the backend in the feature flags service

Story points: 6.0
Upgrade to Angular 9

## Current issues

### Angular Universal
`Cannot read property 'id' of undefined ;`

```
front_1                             | Unhandled Promise rejection: Cannot read property 'id' of undefined ; Zone: <root> ; Task: Promise.then ; Value: front_1                             |TypeError: Cannot read property 'id' of undefined
front_1                             |     at registerNgModuleType (/dist/server/main.js:68358:31)
front_1                             |     at /dist/server/main.js:68369:51
front_1                             |     at Array.forEach (<anonymous>)
front_1                             |     at registerNgModuleType (/dist/server/main.js:68369:21)
front_1                             |     at /dist/server/main.js:68369:51
front_1                             |     at Array.forEach (<anonymous>)
front_1                             |     at registerNgModuleType (/dist/server/main.js:68369:21)
front_1                             |     at /dist/server/main.js:68369:51
front_1                             |     at Array.forEach (<anonymous>)
front_1                             |     at registerNgModuleType (/dist/server/main.js:68369:21) TypeError: Cannot read property 'id' of undefined
front_1                             |     at registerNgModuleType (/dist/server/main.js:68358:31)
front_1                             |     at /dist/server/main.js:68369:51
front_1                             |     at Array.forEach (<anonymous>)
front_1                             |     at registerNgModuleType (/dist/server/main.js:68369:21)
front_1                             |     at /dist/server/main.js:68369:51
front_1                             |     at Array.forEach (<anonymous>)
front_1                             |     at registerNgModuleType (/dist/server/main.js:68369:21)
front_1                             |     at /dist/server/main.js:68369:51
front_1                             |     at Array.forEach (<anonymous>)
front_1                             |     at registerNgModuleType (/dist/server/main.js:68369:21)
```

## Channel
Channels do not load. Error noting that multiple `m-channel` ids exist.

## MetaService

Analytics service needs updating. Issues with `@SkipSelf`.

## i18n

```
Localized bundle generation failed: Unexpected messageParts for `$localize` (expected an array of strings).
```

Story points: 3.0
Temporarily disable the group and channel selectors for the new onboarding

We want to roll out our new onboarding ui, but the recommendations need to be overhauled. We'll be turning them back on when get the recommendations engine sorted out. Let's try to get onboarding turned on by Monday
- [x] disable (but keep) the suggested channels onboarding step
- [x] disable (but keep) the suggested groups onboarding step
- [x] onboarding should flow as normal
- [x] disable the e2e tests that check for groups and onboarding

Story points: 2.0
Legacy USD boost prompt still appears

<!---
Please read this!

Before opening a new issue, make sure to search for keywords in the issues
filtered by the "T - Bug" label and verify the issue you're about to submit isn't a duplicate.
--->

### Summary

Legacy boost prompt that allows payment in USD still appears sometimes.

### Steps to reproduce

1. Click boost on your post and notice the token prompt (this is correct behavior)
2. Go to someone else's channel and click to Wire them on a post. 
3. Toggle over to send them USD. 
4. Exit wire prompt without making payment.
5. Go back to your channel and click boost on your post. 
6. Notice the legacy USD prompt - this should be removed and never show up

### Platform information 

iOS Catalina, MacBook, Chrome

### What is the expected *correct* behavior?

Only the token boost prompt should ever appear.

### Relevant logs and/or screenshots

![Screen_Shot_2020-02-04_at_3.27.11_PM](/uploads/998d10c8bf6a17b481ae6448b6bca819/Screen_Shot_2020-02-04_at_3.27.11_PM.png)

### Possible fixes

(If you can, link to the line of code that might be responsible for the problem)

Story points: 4.0
New Channel Registration, Signup button remains disabled

New Channels cannot register because registration button remains disabled even after credentials are filled in. There is an element id collision on the page that may be related.

![image](/uploads/a321e1e9e93a945bf267ec9ac27d90d8/image.png)

![image](/uploads/d14af02d772ae35b110c20bcb7cf837e/image.png)

Story points: 4.0
Test SSR on Staging

- [x] On staging (www.minds.com with staging=1), run through your test plan created by Xander on https://minds.tenant.kiwitcms.org/
- [x] Update your front to master and make sure it builds and runs properly
- [x] Update your existing MRs (for the sprint) and make sure they work, especially the e2e tests for whatever you're touching.

Story points: 2.0
Test SSR on Staging

- [ ] On staging (www.minds.com with staging=1), run through your test plan created by Xander on https://minds.tenant.kiwitcms.org/
- [ ] Update your front to master and make sure it builds and runs properly
- [ ] Update your existing MRs (for the sprint) and make sure they work, especially the e2e tests for whatever you're touching.

Story points: 2.0
Test SSR on Staging

- [x] On staging (www.minds.com with staging=1), run through your test plan created by Xander on https://minds.tenant.kiwitcms.org/
- [x] Update your front to master and make sure it builds and runs properly
- [ ] Update your existing MRs (for the sprint) and make sure they work, especially the e2e tests for whatever you're touching.

Story points: 2.0
Usernames with special characters unable to unsub from emails

hi. it has been very interestng year trying to unsubscribe from your newsletter. I tried every time I got an email from you.
the page that loads after clicking on "Unsubscribe" link in the email shows empty @ handle currently. 
If I have to try once more to unsubscribe from your list, I'll report you to whatever authority this falls under.
I am sure you realize how bad you look if such simple thing cannot be handled properly by your developers. I have no trust in you as software platform.


Brave browser, on android phones, also on different computers. 
The page after loading says that I am successfully unsubscribed (!) but the handle it displays stays empty in my case. My guess is that using special characters in username is an overkill for your developers. Why do you allow these characters if you dont encode them? Why did no-one write unit tests for these things? Or even worse, did anyone?
I repeat that i was trying to unsubscribe for probably over a year now - isn't that pretty bad experience?

username okram_ovič

Story points: 1.0
Volume Control Disappears When Using Blink (Chromium) Based Browsers

<!---
Please read this!

Before opening a new issue, make sure to search for keywords in the issues
filtered by the "T - Bug" label and verify the issue you're about to submit isn't a duplicate.
--->

### Summary

When using a browser that is based on the Blink rendering engine (ie. Chromium based), videos that are using the Minds video player fail to display volume control.

### Steps to reproduce
Access the following URLs within a Blink based browser.

### Platform information 

Tested with:
* Chromium (x86_64 - v79.0 - Blink)
* Opera (x86_64 - v65.0 - Blink)
* Brave (x86_64 - v1.0.1 - Blink)
* Firefox (x86_64 - v70.0 - Quantum)
* Midori (x86_64 - v69.0 - Webkit)

Firefox and Midori works fine. Chromium, Brave and Opera fails. Suspect that all Blink / Chromium based browsers are affected with this issue.

### What is the current *bug* behavior?
Volume control appears and then suddenly disappears, which results in no access to said control / UI element.

### What is the expected *correct* behavior?
Volume control / UI element should be accessible

### Relevant logs and/or screenshots

* https://www.minds.com/newsfeed/1068760255372918784
* https://www.minds.com/media/1069342265038675968

![audiobug](/uploads/004c5f2e690b9e3305ea532a8bc705a8/audiobug.mp4)

### Possible fixes
Suspect possible CSS issue. Possibly caused by a stylestyle that contains something similar to the following code:
`.element{display:none;}`

Alternatively, some php or javascript issue which results in the above outcome.

Story points: 4.0
Wire button should not be 2 lines on Media Modal

<!---
Please read this!

Before opening a new issue, make sure to search for keywords in the issues
filtered by the "T - Bug" label and verify the issue you're about to submit isn't a duplicate.
--->

### Summary

Wire button should not be 2 lines

### Steps to reproduce

1. Open modal
2. Look at button

### Platform information
 
Cross-platform web.

### What is the current *bug* behavior?

Looks far too squashed.

### What is the expected *correct* behavior?

Wire button should be on its own line.

### Relevant logs and/or screenshots

![20200130_114618](/uploads/5bc090c82dbe970045e3f4c32a8087aa/20200130_114618.jpg)

### Possible fixes

(If you can, link to the line of code that might be responsible for the problem)

/label ~"T \- Bug" ~"S \- Triage:new" 


Story points: 2.0
[GAT] Android - Device back button is not functional on Report comment screen.

Actual Results
"Device back button is not functional on Report comment screen."

Expected Results
"All device buttons are working when navigating within the app"

https://testers.testerwork.com/videos/7f58fa1d30f509fb53a687a43cdb954cd66607fffd15cb40a1b152726eb1887694faa3558f8a4251af79a0d6eb665421

Story points: 2.0
[GAT] iOS - The email subject and content are not correctly codified in the referral sharing

Actual Results
"The email subject and content are not correctly codified in the referral sharing"

Expected Results
"The email subject and content are correctly codified in the referral sharing"

https://testers.testerwork.com/images/7cf80e8b0b7e86a42009fa5f2d9ebdcb8ef4095036b1038b409d3afaaeb7892f2ff90a82efa3d770bc1a2036cd6371ff

https://testers.testerwork.com/images/1a6381a3f6d286d4de2d4eccb0787620f3034691ccb37333220531b8451cad1c7454d86dcb7d15d0b80c49e146086437

Story points: 2.0
[GAT] iOS - It can be noticed that the app gets stuck on an infinite loading after the user swipes right on the 2FA modal window when updating the email address

Actual Results
"It can be noticed that the app gets stuck on an infinite loading after the user swipes right on the 2FA modal window when updating the email address
"

Expected Results
"The app will keep working without getting stuck
"

https://testers.testerwork.com/videos/6d8070e4e6050cd0ff7c9049c0173483c83caffb7d61edf99d61bbaa700551df806232831c1cb531d401ab33b217570a

Story points: 1.0
[GAT] iOS - It can be noticed that the date of birth field is abruptly removed when the user taps on any key on the text keypad when attempting to input the date of birth

Actual Results
"It can be noticed that the date of birth field is abruptly removed when the user taps on any key on the text keypad when attempting to input the date of birth"

Expected Results
"The date of the birth field will remain available without issues"

https://testers.testerwork.com/videos/27421bba46388e0194265aa009673b13ed1c758895d735d693b01a3695c5c15aee9c800e09856e98887d053bc8ee7c88

Story points: 2.0