Project: moodle
Issue MDL-45292: Bad RTL filepicker styles
A few CSS styles in the filepicker only look good on LTR, or at the very least don't consider RTL circumstances. *2.5.x:* _theme/base/filemanager.css_ * line 72, {{.fp-toolbar div}} padding-right rule ** applies erroneously under RTL * line 72, {{.dir-rtl .fp-toolbar div}} width:100px rule ** this rule came in with MDL-32479 and seems like a really, really bad idea (see https://tracker.moodle.org/secure/attachment/37967/Private%20files%20RTL.png ) * line 74, {{.fp-toolbar img}} margin-right rule ** applies erroneously under RTL * line 79, {{.fp-viewbar}} style definition includes an 8px margin-right under LTR (Recent files LTR.png) ** not a problem under RTL since in that circumstance the element in question floats left; this rule should be removed ** need a text-align rule (and an RTL rule to match) because the viewbar is actually narrower than 72px; it takes up 72px, but due to negative margins actually appears smaller. * line 81, {{.dir-rtl .fp-viewbar}} definition includes an explicit width declaration @ 100px (Private files RTL.png) ** 72px is enough and we need horizontal space for Alfresco's selectbox (see MDL-36836) *2.6.x:* ( https://tracker.moodle.org/secure/attachment/37975/26%20Private%20files.png ) _theme/base/filemanager.css_ * line 73, {{.file-picker .fp-toolbar div, .fp-navbar .filemanager-toolbar .fp-toolbar div}} margin rule ** no matching RTL definition * line 89, {{.dir-rtl .file-picker .fp-viewbar}} margin-left:0 rule ** erroneous - puts the viewbar right up against the border
Story points: 5