Project: titanium
Issue TIMOB-23575: Windows: CLI does not check correct directories when detecting app icons
h5.Description When building for Windows Platform currently the following is performed when generating app icons, [as seen in the code|https://github.com/appcelerator/titanium_mobile_windows/blob/master/cli/commands/_build/copy.js#L343-L344] # Check for icon in \app\assets\windows # Check for icon in \ # Check for presence of \DefaultIcon-windows.png and generate using this if it exists # Check for presence of \DefaultIcon.png and generate using this if it exists To be in parity with other platforms the locations should be changed to the following in this order: # Check for icon in \Resources\windows\ # Check for icon in \Resources\ # Check for \DefaultIcon-windows.png and generate using this if it exists # Check for \DefaultIcon.png and generate using this if it exists h5.Steps to reproduce # Build a classic Titanium project for the Windows Platform using {{appc run -p windows -T wp-device --build-only}} # Copy the icons from {{\build\windows\Assets\}} to {{\Resources\windows\}} # Build the project using {{appc run -p windows -T wp-device --build-only}} # Copy the icons from {{\build\windows\Assets\}} to {{\Resources\}} # Build the project using {{appc run -p windows -T wp-device --build-only}} h5.Actual result In both step 3 and 5, app icons will be generated h5.Expected result In both step 3 and 5, app icons should not be generated as they are located in the correct locations
Story points: 5