Project: titanium
Issue TIMOB-19138: Windows: DefaultLanguage property should be set (to "en") in manifest
We [default|https://github.com/appcelerator/titanium_mobile_windows/blob/master/cli/commands/_build/generate.js#L45-L47] to English for generating strings, but we don't set the [DefaultLangauge|https://msdn.microsoft.com/en-us/library/windows/apps/ff769509(v=vs.105).aspx#BKMK_DEFAULTLANGUAGEandLANGUAGESelements] in the manifest. This defaults to the language of the OS you build on so as long as this is also English, all is OK. But if you build on a system with a different language you get errors like this during the build and it will probably not work well. The resolution is simple, it should set the {{DefaultLanguage}} in the generated manifest. Also take note of TIMOB-16356 {code} [WARN] Build succeeded. "C:\Users\Fokke\AppData\Local\Temp\appc-liveviewer-app\phone.x86\LiveViewer.sln" (rebuild target) (1) -> "C:\Users\Fokke\AppData\Local\Temp\appc-liveviewer-app\phone.x86\LiveViewer.vcxproj.metaproj" (Rebuild target) (2 ) -> "C:\Users\Fokke\AppData\Local\Temp\appc-liveviewer-app\phone.x86\Native\TitaniumWindows_Native.vcxproj.metaproj" (Rebuild target) (3) -> "C:\Users\Fokke\AppData\Local\Temp\appc-liveviewer-app\phone.x86\Native\TitaniumWindows_Native.vcxproj" (Rebuild target) (5) -> (_GetDefaultResourceLanguage target) -> C:\Program Files (x86)\MSBuild\Microsoft\VisualStudio\v12.0\AppxPackage\Microsoft.AppXPackage.Targets(2893,9): warning APPX1901: The DefaultLanguage property is either missing from the project file or does not have a value. The fal lback language is set to the Visual Studio language: nl-NL. [C:\Users\Fokke\AppData\Local\Temp\appc-liveviewer-app\phone .x86\Native\TitaniumWindows_Native.vcxproj] "C:\Users\Fokke\AppData\Local\Temp\appc-liveviewer-app\phone.x86\LiveViewer.sln" (rebuild target) (1) -> "C:\Users\Fokke\AppData\Local\Temp\appc-liveviewer-app\phone.x86\LiveViewer.vcxproj.metaproj" (Rebuild target) (2 ) -> "C:\Users\Fokke\AppData\Local\Temp\appc-liveviewer-app\phone.x86\LiveViewer.vcxproj" (Rebuild target) (6) -> (PrepareForBuild target) -> C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V120\Microsoft.CppBuild.targets(396,5): warning MSB8029: The Intermediate directory or Output directory cannot reside under the Temporary directory as it could lead to issues with i ncremental build. [C:\Users\Fokke\AppData\Local\Temp\appc-liveviewer-app\phone.x86\LiveViewer.vcxproj] "C:\Users\Fokke\AppData\Local\Temp\appc-liveviewer-app\phone.x86\LiveViewer.sln" (rebuild target) (1) -> "C:\Users\Fokke\AppData\Local\Temp\appc-liveviewer-app\phone.x86\LiveViewer.vcxproj.metaproj" (Rebuild target) (2 ) -> "C:\Users\Fokke\AppData\Local\Temp\appc-liveviewer-app\phone.x86\LiveViewer.vcxproj" (Rebuild target) (6) -> (_GetDefaultResourceLanguage target) -> C:\Program Files (x86)\MSBuild\Microsoft\VisualStudio\v12.0\AppxPackage\Microsoft.AppXPackage.Targets(2893,9): warning APPX1901: The DefaultLanguage property is either missing from the project file or does not have a value. The fal lback language is set to the Visual Studio language: nl-NL. [C:\Users\Fokke\AppData\Local\Temp\appc-liveviewer-app\phone .x86\LiveViewer.vcxproj] "C:\Users\Fokke\AppData\Local\Temp\appc-liveviewer-app\phone.x86\LiveViewer.sln" (rebuild target) (1) -> "C:\Users\Fokke\AppData\Local\Temp\appc-liveviewer-app\phone.x86\LiveViewer.vcxproj.metaproj" (Rebuild target) (2 ) -> "C:\Users\Fokke\AppData\Local\Temp\appc-liveviewer-app\phone.x86\LiveViewer.vcxproj" (Rebuild target) (6) -> (_GenerateProjectPriFileCore target) -> MakePRI : warning 0xdef00522: Resources found for language(s) 'en' but no resources found for default language( s): 'nl-NL'. Change the default language or qualify resources with the default language. http://go.microsoft.com/fwlink/ ?LinkId=231899 [C:\Users\Fokke\AppData\Local\Temp\appc-liveviewer-app\phone.x86\LiveViewer.vcxproj] MakePRI : warning 0xdef01051: No default or neutral resource given for 'Resources/app_name'. The application ma y throw an exception for certain user configurations when retrieving the resources. [C:\Users\Fokke\AppData\Local\Temp\a ppc-liveviewer-app\phone.x86\LiveViewer.vcxproj] "C:\Users\Fokke\AppData\Local\Temp\appc-liveviewer-app\phone.x86\LiveViewer.sln" (rebuild target) (1) -> "C:\Users\Fokke\AppData\Local\Temp\appc-liveviewer-app\phone.x86\LiveViewer.vcxproj.metaproj" (Rebuild target) (2 ) -> "C:\Users\Fokke\AppData\Local\Temp\appc-liveviewer-app\phone.x86\LiveViewer.vcxproj" (Rebuild target) (6) -> (_SplitResourcesPri target) -> MakePRI : warning 0xdef01051: No default or neutral resource given for 'Resources/app_name'. The application ma y throw an exception for certain user configurations when retrieving the resources. [C:\Users\Fokke\AppData\Local\Temp\a ppc-liveviewer-app\phone.x86\LiveViewer.vcxproj] 9 Warning(s) 0 Error(s) Time Elapsed 00:00:44.17 {code}
Story points: 3