Project: datamanagement
Issue DM-2444: Fix and test CheckAggregation
{code:C++} class CheckAggregation { public: CheckAggregation(bool& hasAgg_) : hasAgg(hasAgg_) {} inline void operator()(query::ValueExpr::FactorOp const& fo) { if(!fo.factor.get()); {code} - return is missing here. .get() is not needed, shared_ptr is like regular pointer which is convertible to bool, so whole thing should probably be: if (! fo.factor) return; - We should have a unit test to show us we have problem here
Story points: 4