Project: talenddataquality
Issue TDQ-11124: investigate more for "createStatement(...)"
After TDQ-10991 ,Email from Sebastiao: ResultSetHelper has several methods to get a result set. But when we call them, we don't know whether it will call createStatementOnlyForwardAndFetchSize or simply createStatement. That's why I ask why we don't use the same method in all methods of ResultSetHelper. From the caller perspective, it's not clear. can you find who used these options in the analysis and see why? According to the documentation, TYPE_SCROLL_INSENSITIVE means that the resultset is not updated whatever happens in the database. That's what we want in the analysis and that's probably what we want also in the reservoir sampling algorithm. What I'd like to see is a unified way to retrieve the result set. I don't see any good reason why we would need a different way for the analysis and for the sample. Can you investigate this a bit more?
Story points: 13