Repository: iluwatar/java-design-patterns
Issue: Remove maven-pmd-plugin from project
Labels: info: good first issue
epic: build issue
epic: dependencies

We are using SonarCloud for static source code analysis so maven-pmd-plugin is included really for no particular reason. Let's remove it from the project.

Issue comments:
Hello.
Can I claim this? :)
Sure @Shumyk I'll assign it to you

Pull request review comments:

Patch that resolved the issue:
diff --git a/exclude-pmd.properties b/exclude-pmd.properties
deleted file mode 100644
index 5a4bb138834e..000000000000
--- a/exclude-pmd.properties
+++ /dev/null
@@ -1,27 +0,0 @@
-#
-# The MIT License
-# Copyright (c) 2014-2016 Ilkka Seppälä
-#
-# Permission is hereby granted, free of charge, to any person obtaining a copy
-# of this software and associated documentation files (the "Software"), to deal
-# in the Software without restriction, including without limitation the rights
-# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
-# copies of the Software, and to permit persons to whom the Software is
-# furnished to do so, subject to the following conditions:
-#
-# The above copyright notice and this permission notice shall be included in
-# all copies or substantial portions of the Software.
-#
-# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
-# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
-# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
-# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
-# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
-# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
-# THE SOFTWARE.
-#
-
-com.iluwatar.servicelayer.common.BaseEntity=UnusedPrivateField
-com.iluwatar.doublechecked.locking.App=EmptyStatementNotInLoop,EmptyWhileStmt
-com.iluwatar.doublechecked.locking.InventoryTest=EmptyStatementNotInLoop,EmptyWhileStmt
-domainapp.dom.modules.simple.QSimpleObject=UnusedFormalParameter
\ No newline at end of file
diff --git a/pom.xml b/pom.xml
index d812d27c4c54..bb3e31d300fb 100644
--- a/pom.xml
+++ b/pom.xml
@@ -54,7 +54,6 @@
         <aws-lambda-log4j.version>1.0.0</aws-lambda-log4j.version>
         <aws-lambda-java-events.version>2.0.1</aws-lambda-java-events.version>
         <jackson.version>2.8.5</jackson.version>
-        <pmd.version>3.12.0</pmd.version>
         <log4j.version>1.2.17</log4j.version>
         <jaxb-api.version>2.3.0</jaxb-api.version>
         <annotation-api.version>1.3.1</annotation-api.version>
@@ -434,26 +433,6 @@
                     </execution>
                 </executions>
             </plugin>
-            <plugin>
-                <groupId>org.apache.maven.plugins</groupId>
-                <artifactId>maven-pmd-plugin</artifactId>
-                <version>${pmd.version}</version>
-                <configuration>
-                    <failOnViolation>true</failOnViolation>
-                    <failurePriority>5</failurePriority>
-                    <printFailingErrors>true</printFailingErrors>
-                </configuration>
-                <executions>
-                    <execution>
-                        <goals>
-                            <goal>check</goal>
-                        </goals>
-                        <configuration>
-                            <excludeFromFailureFile>exclude-pmd.properties</excludeFromFailureFile>
-                        </configuration>
-                    </execution>
-                </executions>
-            </plugin>
 
             <plugin>
                 <groupId>com.mycila</groupId>
@@ -481,11 +460,6 @@
 
     <reporting>
         <plugins>
-            <plugin>
-                <groupId>org.apache.maven.plugins</groupId>
-                <artifactId>maven-pmd-plugin</artifactId>
-                <version>${pmd.version}</version>
-            </plugin>
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-jxr-plugin</artifactId>


Test patch: