Repository: bazelbuild/bazel
Issue: Remove deprecated remote flags
Labels: team-Remote-Exec

As Part of #7205 a few flags got deprecated, for instance, `exeprimental_retry-*` 
Those flags have to be removed, including related functionality/tests (see TODOs in the code).

Issue comments:

Pull request review comments:

Patch that resolved the issue:
diff --git a/src/main/java/com/google/devtools/build/lib/remote/options/RemoteOptions.java b/src/main/java/com/google/devtools/build/lib/remote/options/RemoteOptions.java
index 755b6e5ea7da18..c5a72a1bbbd133 100644
--- a/src/main/java/com/google/devtools/build/lib/remote/options/RemoteOptions.java
+++ b/src/main/java/com/google/devtools/build/lib/remote/options/RemoteOptions.java
@@ -120,36 +120,6 @@ public final class RemoteOptions extends OptionsBase {
       help = "Value to pass as instance_name in the remote execution API.")
   public String remoteInstanceName;
 
-  @Deprecated
-  @Option(
-      name = "experimental_remote_retry",
-      defaultValue = "true",
-      documentationCategory = OptionDocumentationCategory.REMOTE,
-      deprecationWarning = "Deprecated. Use --remote_retries instead.",
-      effectTags = {OptionEffectTag.NO_OP},
-      help = "This flag is deprecated and has no effect. Use --remote_retries instead.")
-  public boolean experimentalRemoteRetry;
-
-  @Deprecated
-  @Option(
-      name = "experimental_remote_retry_start_delay_millis",
-      defaultValue = "100",
-      documentationCategory = OptionDocumentationCategory.REMOTE,
-      deprecationWarning = "Deprecated. Use --remote_retries instead.",
-      effectTags = {OptionEffectTag.UNKNOWN},
-      help = "The initial delay before retrying a transient error. Use --remote_retries instead.")
-  public long experimentalRemoteRetryStartDelayMillis;
-
-  @Deprecated
-  @Option(
-      name = "experimental_remote_retry_max_delay_millis",
-      defaultValue = "5000",
-      documentationCategory = OptionDocumentationCategory.REMOTE,
-      deprecationWarning = "Deprecated. Use --remote_retries instead.",
-      effectTags = {OptionEffectTag.NO_OP},
-      help = "This flag is deprecated and has no effect. Use --remote_retries instead.")
-  public long experimentalRemoteRetryMaxDelayMillis;
-
   @Option(
       name = "remote_retries",
       oldName = "experimental_remote_retry_max_attempts",
@@ -161,26 +131,6 @@ public final class RemoteOptions extends OptionsBase {
               + "If set to 0, retries are disabled.")
   public int remoteMaxRetryAttempts;
 
-  @Deprecated
-  @Option(
-      name = "experimental_remote_retry_multiplier",
-      defaultValue = "2",
-      documentationCategory = OptionDocumentationCategory.REMOTE,
-      deprecationWarning = "Deprecated. Use --remote_retries instead.",
-      effectTags = {OptionEffectTag.NO_OP},
-      help = "This flag is deprecated and has no effect. Use --remote_retries instead.")
-  public double experimentalRemoteRetryMultiplier;
-
-  @Deprecated
-  @Option(
-      name = "experimental_remote_retry_jitter",
-      defaultValue = "0.1",
-      documentationCategory = OptionDocumentationCategory.REMOTE,
-      deprecationWarning = "Deprecated. Use --remote_retries instead.",
-      effectTags = {OptionEffectTag.NO_OP},
-      help = "This flag is deprecated and has no effect. Use --remote_retries instead.")
-  public double experimentalRemoteRetryJitter;
-
   @Option(
       name = "disk_cache",
       defaultValue = "null",


Test patch: