Repository: iluwatar/java-design-patterns
Issue: module/output.txt & module/error.txt change on build
Labels: info: help wanted
info: good first issue

First off great project here, thanks for spending time collating all this information! :+1: 

Something very minor I noticed when building the project locally with `mvn clean package` is that the files:

`module/output.txt` and `module/error.txt` end up being change to not include the MIT licence.

Perhaps they should be removed with `git rm` and then added to the ignore file as they are generated by tests? Or the [test](https://github.com/iluwatar/java-design-patterns/blob/master/module/src/test/java/com/iluwatar/module/FileLoggerModuleTest.java) should use a [temporary file](https://docs.oracle.com/javase/7/docs/api/java/nio/file/Files.html#createTempFile(java.nio.file.Path,%20java.lang.String,%20java.lang.String,%20java.nio.file.attribute.FileAttribute...))?

I've attached a diff for what it is worth: [diff.txt](https://github.com/iluwatar/java-design-patterns/files/2396099/diff.txt)

Issue comments:
@LyndonArmitage thanks for the improvement suggestion. I think those files could be removed from git and added to `.gitignore`. I would be glad to accept pull request for this.
See PR: #796

Pull request review comments:

Patch that resolved the issue:
diff --git a/module/.gitignore b/module/.gitignore
new file mode 100644
index 000000000000..ecfa5dd4617e
--- /dev/null
+++ b/module/.gitignore
@@ -0,0 +1,2 @@
+error.txt
+output.txt
diff --git a/module/error.txt b/module/error.txt
deleted file mode 100644
index ee28c3c1cf7e..000000000000
--- a/module/error.txt
+++ /dev/null
@@ -1,23 +0,0 @@
-====
-    The MIT License
-    Copyright (c) 2014 Ilkka Seppälä
-
-    Permission is hereby granted, free of charge, to any person obtaining a copy
-    of this software and associated documentation files (the "Software"), to deal
-    in the Software without restriction, including without limitation the rights
-    to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
-    copies of the Software, and to permit persons to whom the Software is
-    furnished to do so, subject to the following conditions:
-
-    The above copyright notice and this permission notice shall be included in
-    all copies or substantial portions of the Software.
-
-    THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
-    IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
-    FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
-    AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
-    LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
-    OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
-    THE SOFTWARE.
-====
-
diff --git a/module/output.txt b/module/output.txt
deleted file mode 100644
index ee28c3c1cf7e..000000000000
--- a/module/output.txt
+++ /dev/null
@@ -1,23 +0,0 @@
-====
-    The MIT License
-    Copyright (c) 2014 Ilkka Seppälä
-
-    Permission is hereby granted, free of charge, to any person obtaining a copy
-    of this software and associated documentation files (the "Software"), to deal
-    in the Software without restriction, including without limitation the rights
-    to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
-    copies of the Software, and to permit persons to whom the Software is
-    furnished to do so, subject to the following conditions:
-
-    The above copyright notice and this permission notice shall be included in
-    all copies or substantial portions of the Software.
-
-    THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
-    IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
-    FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
-    AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
-    LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
-    OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
-    THE SOFTWARE.
-====
-


Test patch: