Repository: pinpoint-apm/pinpoint
Issue: change deprecated HTablePool api to HConnection
Labels: enhancement

HTablePool  API is deprecated.

full request : #318 
hbase : https://issues.apache.org/jira/browse/HBASE-6580


Issue comments:
1.0.x backport


Pull request review comments:

Patch that resolved the issue:
diff --git a/docker/pinpoint-collector/hbase.properties b/docker/pinpoint-collector/hbase.properties
index ab80251d5b30..4161185c010c 100644
--- a/docker/pinpoint-collector/hbase.properties
+++ b/docker/pinpoint-collector/hbase.properties
@@ -1,3 +1,22 @@
 hbase.client.host=HBASE_HOST
 hbase.client.port=HBASE_PORT
-hbase.htable.threads.max=4
\ No newline at end of file
+
+# hbase timeout option==================================================================================
+# hbase default:true
+hbase.ipc.client.tcpnodelay=true
+# hbase default:60000
+hbase.rpc.timeout=10000
+# hbase default:Integer.MAX_VALUE
+hbase.client.operation.timeout=10000
+
+# hbase socket read timeout. default: 200000
+hbase.ipc.client.socket.timeout.read=20000
+# socket write timeout. hbase default: 600000
+hbase.ipc.client.socket.timeout.write=60000
+
+# ==================================================================================
+# hbase client thread pool option
+hbase.client.thread.max=128
+hbase.client.threadPool.queueSize=5120
+# prestartAllCoreThreads
+hbase.client.threadPool.prestart=false
\ No newline at end of file
diff --git a/docker/pinpoint-collector/pinpoint-collector.properties b/docker/pinpoint-collector/pinpoint-collector.properties
index 2befb7307b85..8cc0875fb0e3 100644
--- a/docker/pinpoint-collector/pinpoint-collector.properties
+++ b/docker/pinpoint-collector/pinpoint-collector.properties
@@ -1,5 +1,3 @@
-hbase.hTablePoolSize=1024
-
 # tcp listen ip
 collector.tcpListenIp=0.0.0.0
 collector.tcpListenPort=COLLECTOR_TCP_PORT
diff --git a/docker/pinpoint-web/hbase.properties b/docker/pinpoint-web/hbase.properties
index ab80251d5b30..4161185c010c 100644
--- a/docker/pinpoint-web/hbase.properties
+++ b/docker/pinpoint-web/hbase.properties
@@ -1,3 +1,22 @@
 hbase.client.host=HBASE_HOST
 hbase.client.port=HBASE_PORT
-hbase.htable.threads.max=4
\ No newline at end of file
+
+# hbase timeout option==================================================================================
+# hbase default:true
+hbase.ipc.client.tcpnodelay=true
+# hbase default:60000
+hbase.rpc.timeout=10000
+# hbase default:Integer.MAX_VALUE
+hbase.client.operation.timeout=10000
+
+# hbase socket read timeout. default: 200000
+hbase.ipc.client.socket.timeout.read=20000
+# socket write timeout. hbase default: 600000
+hbase.ipc.client.socket.timeout.write=60000
+
+# ==================================================================================
+# hbase client thread pool option
+hbase.client.thread.max=128
+hbase.client.threadPool.queueSize=5120
+# prestartAllCoreThreads
+hbase.client.threadPool.prestart=false
\ No newline at end of file
diff --git a/quickstart/collector/src/main/resources/hbase.properties b/quickstart/collector/src/main/resources/hbase.properties
index 614a0727bdfe..be6e5ea43e88 100644
--- a/quickstart/collector/src/main/resources/hbase.properties
+++ b/quickstart/collector/src/main/resources/hbase.properties
@@ -1,4 +1,23 @@
 # example
 hbase.client.host=localhost
 hbase.client.port=2181
-hbase.htable.threads.max=4
\ No newline at end of file
+
+# hbase timeout option==================================================================================
+# hbase default:true
+hbase.ipc.client.tcpnodelay=true
+# hbase default:60000
+hbase.rpc.timeout=10000
+# hbase default:Integer.MAX_VALUE
+hbase.client.operation.timeout=10000
+
+# hbase socket read timeout. default: 200000
+hbase.ipc.client.socket.timeout.read=20000
+# socket write timeout. hbase default: 600000
+hbase.ipc.client.socket.timeout.write=60000
+
+# ==================================================================================
+# hbase client thread pool option
+hbase.client.thread.max=128
+hbase.client.threadPool.queueSize=5120
+# prestartAllCoreThreads
+hbase.client.threadPool.prestart=false
\ No newline at end of file
diff --git a/quickstart/collector/src/main/resources/pinpoint-collector.properties b/quickstart/collector/src/main/resources/pinpoint-collector.properties
index c43513cf6c75..dcd60c61e29f 100644
--- a/quickstart/collector/src/main/resources/pinpoint-collector.properties
+++ b/quickstart/collector/src/main/resources/pinpoint-collector.properties
@@ -1,5 +1,3 @@
-hbase.hTablePoolSize=1024
-
 # tcp listen ip
 collector.tcpListenIp=0.0.0.0
 collector.tcpListenPort=29994
diff --git a/quickstart/web/src/main/resources/hbase.properties b/quickstart/web/src/main/resources/hbase.properties
index 614a0727bdfe..be6e5ea43e88 100644
--- a/quickstart/web/src/main/resources/hbase.properties
+++ b/quickstart/web/src/main/resources/hbase.properties
@@ -1,4 +1,23 @@
 # example
 hbase.client.host=localhost
 hbase.client.port=2181
-hbase.htable.threads.max=4
\ No newline at end of file
+
+# hbase timeout option==================================================================================
+# hbase default:true
+hbase.ipc.client.tcpnodelay=true
+# hbase default:60000
+hbase.rpc.timeout=10000
+# hbase default:Integer.MAX_VALUE
+hbase.client.operation.timeout=10000
+
+# hbase socket read timeout. default: 200000
+hbase.ipc.client.socket.timeout.read=20000
+# socket write timeout. hbase default: 600000
+hbase.ipc.client.socket.timeout.write=60000
+
+# ==================================================================================
+# hbase client thread pool option
+hbase.client.thread.max=128
+hbase.client.threadPool.queueSize=5120
+# prestartAllCoreThreads
+hbase.client.threadPool.prestart=false
\ No newline at end of file


Test patch: