Repository: bazelbuild/bazel
Issue: Android: support font in XML
Labels: type: feature request
P2

### Description of the problem / feature request / question:

Bazel does not support newly-added Android feature [Fonts in XML](https://developer.android.com/guide/topics/ui/look-and-feel/fonts-in-xml.html)


### Environment info
* Operating System:
macOS 10.13.2

* Bazel version (output of `bazel info release`):
release 0.9.0-homebrew

### Log
```
$ bazel build --verbose_failures :android
ERROR: app/BUILD:11:22: in resource_files attribute of android_binary rule //app:android: 'app/src/main/res/font/heebo_black.ttf' is not in the expected resource directory structure of <resource directory>/{anim,animator,color,drawable,interpolator,layout,menu,mipmap,raw,transition,values,xml}/<file>
ERROR: Analysis of target '//app:android' failed; build aborted: Analysis of target '//app:android' failed; build aborted
INFO: Elapsed time: 0.296s
FAILED: Build did NOT complete successfully (1 packages loaded)
```

Issue comments:
The android_common jars need to be updated for this to work. I'll take a look.
Adding some more info to help repro:

### Bugs: what's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.

Working app on master:
https://github.com/hasadna/hasadna
To run:
bazel build //projects/noloan/app

Non-compiling app, after adding fonts to `res/font`:
https://github.com/hasadna/hasadna/tree/xml_fonts_issue
This branch has just one commit to add the fonts:
https://github.com/hasadna/hasadna/commit/642e82725f0eb868692c5d534b0025fcb878d0df
Same command to run:
bazel build //projects/noloan/app

### What's the output of `bazel info release`?
I've checked this on both versions:
release 0.10.0-2018-03-25 (@b4fcdc3)
development version (based on https://github.com/bazelbuild/bazel/tree/release-0.12.0 from March 29th)

### What's the output of `git remote get-url origin ; git rev-parse master ; git rev-parse HEAD` ?
fatal: not a git repository (or any of the parent directories): .git
fatal: not a git repository (or any of the parent directories): .git
fatal: not a git repository (or any of the parent directories): .git
This is odd, I agree. I can try to clone & rebuild bazel if you want.

###  Have you found anything relevant by searching the web?
Nope.

### Any other information, logs, or outputs that you want to share?
This is the full bazel error:
```
oferb@oferb:~/devel/hasadna$ bazel build //projects/noloan/app
ERROR: /home/oferb/devel/hasadna/projects/noloan/app/BUILD:6:22: in resource_files attribute of android_binary rule //projects/noloan/app:app: 'projects/noloan/app/res/font/heebo_black.ttf' is not in the expected resource directory structure of <resource directory>/{anim,animator,color,drawable,interpolator,layout,menu,mipmap,raw,transition,values,xml}/<file>
ERROR: Analysis of target '//projects/noloan/app:app' failed; build aborted: Analysis of target '//projects/noloan/app:app' failed; build aborted
INFO: Elapsed time: 0.212s
FAILED: Build did NOT complete successfully (0 packages loaded)
```
###  Anything else?
Let me know how best to help you reproduce the problem. I want to make it as easy as possible for you. You can reach me at oferb@ ;)

Bumping to P2.
Update: spent some time upgrading the vendored Android commons dependencies to 26, but that broke a bunch of other stuff and Bazel wouldn't build. Still looking..
Locally I just updated com.android.tools.layoutlib_layoutlib-api to 26 which seems to work.  Not sure what the ramifications are of only updating one lib is.
@asiri-uber how did you do that?
@jin any update so far?
Sorry, I haven't had the chance to work on this since the last time I ran into blockers. I think what @asiri-uber meant was that they switched https://github.com/bazelbuild/bazel/blob/master/third_party/android_common/com.android.tools.layoutlib_layoutlib_25.0.0.jar to 26.0.0 and it worked for them. Do you mind trying that out and seeing if it works for you too?

The corresponding BUILD file entry is here: https://github.com/bazelbuild/bazel/blob/master/third_party/BUILD#L88
That works, although I do want to work out of a Bazel release or head.
So I'll wait for it :)
@oferb https://github.com/bazelbuild/bazel/issues/5287

Pull request review comments:

Patch that resolved the issue:
diff --git a/src/test/shell/bazel/android/testdata/LICENSE.txt b/src/test/shell/bazel/android/testdata/LICENSE.txt
new file mode 100755
index 00000000000000..75b52484ea471f
--- /dev/null
+++ b/src/test/shell/bazel/android/testdata/LICENSE.txt
@@ -0,0 +1,202 @@
+
+                                 Apache License
+                           Version 2.0, January 2004
+                        http://www.apache.org/licenses/
+
+   TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION
+
+   1. Definitions.
+
+      "License" shall mean the terms and conditions for use, reproduction,
+      and distribution as defined by Sections 1 through 9 of this document.
+
+      "Licensor" shall mean the copyright owner or entity authorized by
+      the copyright owner that is granting the License.
+
+      "Legal Entity" shall mean the union of the acting entity and all
+      other entities that control, are controlled by, or are under common
+      control with that entity. For the purposes of this definition,
+      "control" means (i) the power, direct or indirect, to cause the
+      direction or management of such entity, whether by contract or
+      otherwise, or (ii) ownership of fifty percent (50%) or more of the
+      outstanding shares, or (iii) beneficial ownership of such entity.
+
+      "You" (or "Your") shall mean an individual or Legal Entity
+      exercising permissions granted by this License.
+
+      "Source" form shall mean the preferred form for making modifications,
+      including but not limited to software source code, documentation
+      source, and configuration files.
+
+      "Object" form shall mean any form resulting from mechanical
+      transformation or translation of a Source form, including but
+      not limited to compiled object code, generated documentation,
+      and conversions to other media types.
+
+      "Work" shall mean the work of authorship, whether in Source or
+      Object form, made available under the License, as indicated by a
+      copyright notice that is included in or attached to the work
+      (an example is provided in the Appendix below).
+
+      "Derivative Works" shall mean any work, whether in Source or Object
+      form, that is based on (or derived from) the Work and for which the
+      editorial revisions, annotations, elaborations, or other modifications
+      represent, as a whole, an original work of authorship. For the purposes
+      of this License, Derivative Works shall not include works that remain
+      separable from, or merely link (or bind by name) to the interfaces of,
+      the Work and Derivative Works thereof.
+
+      "Contribution" shall mean any work of authorship, including
+      the original version of the Work and any modifications or additions
+      to that Work or Derivative Works thereof, that is intentionally
+      submitted to Licensor for inclusion in the Work by the copyright owner
+      or by an individual or Legal Entity authorized to submit on behalf of
+      the copyright owner. For the purposes of this definition, "submitted"
+      means any form of electronic, verbal, or written communication sent
+      to the Licensor or its representatives, including but not limited to
+      communication on electronic mailing lists, source code control systems,
+      and issue tracking systems that are managed by, or on behalf of, the
+      Licensor for the purpose of discussing and improving the Work, but
+      excluding communication that is conspicuously marked or otherwise
+      designated in writing by the copyright owner as "Not a Contribution."
+
+      "Contributor" shall mean Licensor and any individual or Legal Entity
+      on behalf of whom a Contribution has been received by Licensor and
+      subsequently incorporated within the Work.
+
+   2. Grant of Copyright License. Subject to the terms and conditions of
+      this License, each Contributor hereby grants to You a perpetual,
+      worldwide, non-exclusive, no-charge, royalty-free, irrevocable
+      copyright license to reproduce, prepare Derivative Works of,
+      publicly display, publicly perform, sublicense, and distribute the
+      Work and such Derivative Works in Source or Object form.
+
+   3. Grant of Patent License. Subject to the terms and conditions of
+      this License, each Contributor hereby grants to You a perpetual,
+      worldwide, non-exclusive, no-charge, royalty-free, irrevocable
+      (except as stated in this section) patent license to make, have made,
+      use, offer to sell, sell, import, and otherwise transfer the Work,
+      where such license applies only to those patent claims licensable
+      by such Contributor that are necessarily infringed by their
+      Contribution(s) alone or by combination of their Contribution(s)
+      with the Work to which such Contribution(s) was submitted. If You
+      institute patent litigation against any entity (including a
+      cross-claim or counterclaim in a lawsuit) alleging that the Work
+      or a Contribution incorporated within the Work constitutes direct
+      or contributory patent infringement, then any patent licenses
+      granted to You under this License for that Work shall terminate
+      as of the date such litigation is filed.
+
+   4. Redistribution. You may reproduce and distribute copies of the
+      Work or Derivative Works thereof in any medium, with or without
+      modifications, and in Source or Object form, provided that You
+      meet the following conditions:
+
+      (a) You must give any other recipients of the Work or
+          Derivative Works a copy of this License; and
+
+      (b) You must cause any modified files to carry prominent notices
+          stating that You changed the files; and
+
+      (c) You must retain, in the Source form of any Derivative Works
+          that You distribute, all copyright, patent, trademark, and
+          attribution notices from the Source form of the Work,
+          excluding those notices that do not pertain to any part of
+          the Derivative Works; and
+
+      (d) If the Work includes a "NOTICE" text file as part of its
+          distribution, then any Derivative Works that You distribute must
+          include a readable copy of the attribution notices contained
+          within such NOTICE file, excluding those notices that do not
+          pertain to any part of the Derivative Works, in at least one
+          of the following places: within a NOTICE text file distributed
+          as part of the Derivative Works; within the Source form or
+          documentation, if provided along with the Derivative Works; or,
+          within a display generated by the Derivative Works, if and
+          wherever such third-party notices normally appear. The contents
+          of the NOTICE file are for informational purposes only and
+          do not modify the License. You may add Your own attribution
+          notices within Derivative Works that You distribute, alongside
+          or as an addendum to the NOTICE text from the Work, provided
+          that such additional attribution notices cannot be construed
+          as modifying the License.
+
+      You may add Your own copyright statement to Your modifications and
+      may provide additional or different license terms and conditions
+      for use, reproduction, or distribution of Your modifications, or
+      for any such Derivative Works as a whole, provided Your use,
+      reproduction, and distribution of the Work otherwise complies with
+      the conditions stated in this License.
+
+   5. Submission of Contributions. Unless You explicitly state otherwise,
+      any Contribution intentionally submitted for inclusion in the Work
+      by You to the Licensor shall be under the terms and conditions of
+      this License, without any additional terms or conditions.
+      Notwithstanding the above, nothing herein shall supersede or modify
+      the terms of any separate license agreement you may have executed
+      with Licensor regarding such Contributions.
+
+   6. Trademarks. This License does not grant permission to use the trade
+      names, trademarks, service marks, or product names of the Licensor,
+      except as required for reasonable and customary use in describing the
+      origin of the Work and reproducing the content of the NOTICE file.
+
+   7. Disclaimer of Warranty. Unless required by applicable law or
+      agreed to in writing, Licensor provides the Work (and each
+      Contributor provides its Contributions) on an "AS IS" BASIS,
+      WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
+      implied, including, without limitation, any warranties or conditions
+      of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A
+      PARTICULAR PURPOSE. You are solely responsible for determining the
+      appropriateness of using or redistributing the Work and assume any
+      risks associated with Your exercise of permissions under this License.
+
+   8. Limitation of Liability. In no event and under no legal theory,
+      whether in tort (including negligence), contract, or otherwise,
+      unless required by applicable law (such as deliberate and grossly
+      negligent acts) or agreed to in writing, shall any Contributor be
+      liable to You for damages, including any direct, indirect, special,
+      incidental, or consequential damages of any character arising as a
+      result of this License or out of the use or inability to use the
+      Work (including but not limited to damages for loss of goodwill,
+      work stoppage, computer failure or malfunction, or any and all
+      other commercial damages or losses), even if such Contributor
+      has been advised of the possibility of such damages.
+
+   9. Accepting Warranty or Additional Liability. While redistributing
+      the Work or Derivative Works thereof, You may choose to offer,
+      and charge a fee for, acceptance of support, warranty, indemnity,
+      or other liability obligations and/or rights consistent with this
+      License. However, in accepting such obligations, You may act only
+      on Your own behalf and on Your sole responsibility, not on behalf
+      of any other Contributor, and only if You agree to indemnify,
+      defend, and hold each Contributor harmless for any liability
+      incurred by, or claims asserted against, such Contributor by reason
+      of your accepting any such warranty or additional liability.
+
+   END OF TERMS AND CONDITIONS
+
+   APPENDIX: How to apply the Apache License to your work.
+
+      To apply the Apache License to your work, attach the following
+      boilerplate notice, with the fields enclosed by brackets "[]"
+      replaced with your own identifying information. (Don't include
+      the brackets!)  The text should be enclosed in the appropriate
+      comment syntax for the file format. We also recommend that a
+      file or class name and description of purpose be included on the
+      same "printed page" as the copyright notice for easier
+      identification within third-party archives.
+
+   Copyright [yyyy] [name of copyright owner]
+
+   Licensed under the Apache License, Version 2.0 (the "License");
+   you may not use this file except in compliance with the License.
+   You may obtain a copy of the License at
+
+       http://www.apache.org/licenses/LICENSE-2.0
+
+   Unless required by applicable law or agreed to in writing, software
+   distributed under the License is distributed on an "AS IS" BASIS,
+   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+   See the License for the specific language governing permissions and
+   limitations under the License.


Test patch:
diff --git a/src/test/shell/bazel/android/BUILD b/src/test/shell/bazel/android/BUILD
index 06245c74996150..359d746e4af83c 100644
--- a/src/test/shell/bazel/android/BUILD
+++ b/src/test/shell/bazel/android/BUILD
@@ -117,3 +117,15 @@ sh_test(
     ],
     shard_count = 4,
 )
+
+sh_test(
+    name = "resource_processing_integration_test",
+    size = "medium",
+    srcs = ["resource_processing_integration_test.sh"],
+    data = [
+        ":android_helper",
+        "//external:android_sdk_for_testing",
+        "//src/test/shell/bazel:test-deps",
+        ":testdata/roboto.ttf",
+    ],
+)
diff --git a/src/test/shell/bazel/android/resource_processing_integration_test.sh b/src/test/shell/bazel/android/resource_processing_integration_test.sh
new file mode 100755
index 00000000000000..1362d7ec983bd2
--- /dev/null
+++ b/src/test/shell/bazel/android/resource_processing_integration_test.sh
@@ -0,0 +1,96 @@
+#!/bin/bash
+#
+# Copyright 2017 The Bazel Authors. All rights reserved.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#    http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+# For these tests to run do the following:
+#
+#   1. Install an Android SDK from https://developer.android.com
+#   2. Set the $ANDROID_HOME environment variable
+#   3. Uncomment the line in WORKSPACE containing android_sdk_repository
+#
+# Note that if the environment is not set up as above android_integration_test
+# will silently be ignored and will be shown as passing.
+
+# Load the test setup defined in the parent directory
+CURRENT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+
+source "${CURRENT_DIR}/android_helper.sh" \
+  || { echo "android_helper.sh not found!" >&2; exit 1; }
+fail_if_no_android_sdk
+
+source "${CURRENT_DIR}/../../integration_test_setup.sh" \
+  || { echo "integration_test_setup.sh not found!" >&2; exit 1; }
+
+function setup_font_resources() {
+  rm java/bazel/BUILD
+
+  cat > java/bazel/BUILD <<EOF
+package(default_visibility = ["//visibility:public"])
+aar_import(
+    name = "aar",
+    aar = "sample.aar",
+)
+android_library(
+    name = "lib",
+    srcs = ["Lib.java"],
+    deps = [":aar"],
+)
+android_binary(
+    name = "bin",
+    srcs = ["MainActivity.java"],
+    resource_files = glob(["res/**"]),
+    manifest = "AndroidManifest.xml",
+    deps = [":lib"],
+)
+EOF
+  mkdir -p java/bazel/res/font
+  cp "$TEST_SRCDIR/io_bazel/src/test/shell/bazel/android/testdata/roboto.ttf" \
+    java/bazel/res/font/
+
+  mkdir -p java/bazel/res/values
+  cat > java/bazel/res/values/styles.xml <<EOF
+<?xml version="1.0" encoding="utf-8"?>
+<resources>
+  <style name="AppTheme">
+      <item name="android:fontFamily">@font/roboto</item>
+  </style>
+</resources>
+EOF
+
+  cat > java/bazel/AndroidManifest.xml <<EOF
+<manifest
+    xmlns:android="http://schemas.android.com/apk/res/android"
+    package="bazel.android">
+    <application
+        android:label="Bazel App"
+        android:theme="@style/AppTheme" >
+        <activity
+            android:name="bazel.MainActivity"
+            android:label="Bazel" />
+    </application>
+</manifest>
+EOF
+}
+
+function test_font_support() {
+  create_new_workspace
+  setup_android_sdk_support
+  create_android_binary
+  setup_font_resources
+
+  assert_build //java/bazel:bin
+}
+
+run_suite "Resource processing integration tests"