Repository: pinpoint-apm/pinpoint
Issue: Remove assembly plugin usage from profiler module
Labels: enhancement


Issue comments:

Pull request review comments:

Patch that resolved the issue:
diff --git a/agent/pom.xml b/agent/pom.xml
index 0e44b8803f33..f951ca638a61 100644
--- a/agent/pom.xml
+++ b/agent/pom.xml
@@ -31,7 +31,7 @@
         <dependency>
             <groupId>com.navercorp.pinpoint</groupId>
             <artifactId>pinpoint-plugins</artifactId>
-            <type>zip</type>
+            <type>pom</type>
             <scope>runtime</scope>
         </dependency>
 
diff --git a/agent/src/assembly/distribution.xml b/agent/src/assembly/distribution.xml
index 758cb1490c63..ab1048e79d52 100644
--- a/agent/src/assembly/distribution.xml
+++ b/agent/src/assembly/distribution.xml
@@ -52,8 +52,12 @@
         <includes>
             <include>com.navercorp.pinpoint:pinpoint-plugins</include>
         </includes>
+        <excludes>
+            <exclude>*:pom</exclude>
+        </excludes>
         <outputDirectory>plugin</outputDirectory>
-        <unpack>true</unpack>
+        <useProjectArtifact>false</useProjectArtifact>
+        <useTransitiveFiltering>true</useTransitiveFiltering>
     </dependencySet>
     <dependencySet>
         <includes>
diff --git a/plugins/assembly.xml b/plugins/assembly.xml
deleted file mode 100644
index a4cea45a22e8..000000000000
--- a/plugins/assembly.xml
+++ /dev/null
@@ -1,18 +0,0 @@
-<assembly xmlns="http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.3" 
-  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-  xsi:schemaLocation="http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.3 http://maven.apache.org/xsd/assembly-1.1.3.xsd">
-
-  <id>plugins</id>
-  <formats>
-    <format>zip</format>
-  </formats>
-  <includeBaseDirectory>false</includeBaseDirectory>
-  <dependencySets>
-    <dependencySet>
-      <outputDirectory>/</outputDirectory>
-      <useProjectArtifact>false</useProjectArtifact>
-      <useTransitiveDependencies>false</useTransitiveDependencies>
-      <scope>runtime</scope>
-    </dependencySet>
-  </dependencySets>
-</assembly>
\ No newline at end of file
diff --git a/plugins/pom.xml b/plugins/pom.xml
index bbd90c0b51af..f948bbf1a1f5 100644
--- a/plugins/pom.xml
+++ b/plugins/pom.xml
@@ -203,29 +203,4 @@
         </dependency>
     </dependencies>
 
-    <build>
-        <plugins>
-            <plugin>
-                <groupId>org.apache.maven.plugins</groupId>
-                <artifactId>maven-assembly-plugin</artifactId>
-                <version>2.5.3</version>
-                <configuration>
-                    <descriptors>
-                        <descriptor>assembly.xml</descriptor>
-
-                    </descriptors>
-                    <appendAssemblyId>false</appendAssemblyId>
-                </configuration>
-                <executions>
-                    <execution>
-                        <id>create-zip</id>
-                        <phase>package</phase>
-                        <goals>
-                            <goal>single</goal>
-                        </goals>
-                    </execution>
-                </executions>
-            </plugin>
-        </plugins>
-    </build>
 </project>


Test patch: