Repository: apache/gravitino (Java)

Issue:
[Improvement] Fix handling of SQL exception error codes in PostgreSQLExceptionConverter.java
### What would you like to be improved?

In core/src/main/java/org/apache/gravitino/storage/relational/converters/PostgreSQLExceptionConverter.java, SQL exception codes are treated as a number, which is incorrect. e.g. 28P01 means invalid password

Here are some tests to show that.
```
  @Test
  public void testConvertDuplicatedEntryException() {
    SQLException sqlException = new SQLException("duplicate", "23505");
    PostgreSQLExceptionConverter converter = new PostgreSQLExceptionConverter();
    Assertions.assertThrows(
        EntityAlreadyExistsException.class,
        () -> converter.toGravitinoException(sqlException, Entity.EntityType.METALAKE, "test"),
        String.format("The %s entity: %s already exists.", Entity.EntityType.METALAKE, "test"));
  }

  @Test
  public void testNonNumericSqlStateHandledAsIOException() {
    SQLException sqlException = new SQLException("error", "28P01");
    PostgreSQLExceptionConverter converter = new PostgreSQLExceptionConverter();
    Assertions.assertThrows(
        IOException.class,
        () -> converter.toGravitinoException(sqlException, Entity.EntityType.METALAKE, "test"));
  }
```

### How should we improve?

Treat them as strings. Note currently a java.lang.NumberFormatException will be thrown.


Discussion:
hi~ can I take this issue?
Sure, if you need any help, just ask.



Patch:
diff --git a/core/src/main/java/org/apache/gravitino/storage/relational/converters/PostgreSQLExceptionConverter.java b/core/src/main/java/org/apache/gravitino/storage/relational/converters/PostgreSQLExceptionConverter.java
index 7414760930d..318e3865d9c 100644
--- a/core/src/main/java/org/apache/gravitino/storage/relational/converters/PostgreSQLExceptionConverter.java
+++ b/core/src/main/java/org/apache/gravitino/storage/relational/converters/PostgreSQLExceptionConverter.java
@@ -29,13 +29,13 @@
  * href="https://www.postgresql.org/docs/8.4/errcodes-appendix.html">error code of PostgreSQL</a>
  */
 public class PostgreSQLExceptionConverter implements SQLExceptionConverter {
-  private static final int DUPLICATED_ENTRY_ERROR_CODE = 23505;
+  private static final String DUPLICATED_ENTRY_ERROR_CODE = "23505";
 
   @Override
   @SuppressWarnings("FormatStringAnnotation")
   public void toGravitinoException(SQLException sqlException, Entity.EntityType type, String name)
       throws IOException {
-    int errorCode = Integer.valueOf(sqlException.getSQLState());
+    String errorCode = sqlException.getSQLState();
     switch (errorCode) {
       case DUPLICATED_ENTRY_ERROR_CODE:
         throw new EntityAlreadyExistsException(


Test patch:
diff --git a/core/src/test/java/org/apache/gravitino/storage/relational/converters/TestPostgreSQLExceptionConverter.java b/core/src/test/java/org/apache/gravitino/storage/relational/converters/TestPostgreSQLExceptionConverter.java
new file mode 100644
index 00000000000..9c6d9c4ea27
--- /dev/null
+++ b/core/src/test/java/org/apache/gravitino/storage/relational/converters/TestPostgreSQLExceptionConverter.java
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.gravitino.storage.relational.converters;
+
+import java.io.IOException;
+import java.sql.SQLException;
+import org.apache.gravitino.Entity;
+import org.apache.gravitino.EntityAlreadyExistsException;
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.Test;
+
+public class TestPostgreSQLExceptionConverter {
+
+  @Test
+  public void testConvertDuplicatedEntryException() {
+    SQLException sqlException = new SQLException("duplicate", "23505");
+    PostgreSQLExceptionConverter converter = new PostgreSQLExceptionConverter();
+    Assertions.assertThrows(
+        EntityAlreadyExistsException.class,
+        () -> converter.toGravitinoException(sqlException, Entity.EntityType.METALAKE, "test"),
+        String.format("The %s entity: %s already exists.", Entity.EntityType.METALAKE, "test"));
+  }
+
+  @Test
+  public void testNonNumericSqlStateHandledAsIOException() {
+    SQLException sqlException = new SQLException("error", "28P01");
+    PostgreSQLExceptionConverter converter = new PostgreSQLExceptionConverter();
+    Assertions.assertThrows(
+        IOException.class,
+        () -> converter.toGravitinoException(sqlException, Entity.EntityType.METALAKE, "test"));
+  }
+}