Jinja vulnerable to HTML attribute injection when passing user input as keys to xmlattr filter
Date: 2024-05
Affected: pip/Jinja2
Attack vector: xss
Category: vulnerability-disclosure
Severity: Medium
CVE: CVE-2024-22195
CVE-2024-34064
CWE: CWE-79
CVSS: 5.4 (CVSS:3.1/AV:N/AC:L/PR:N/UI:R/S:U/C:L/I:L/A:N)

The `xmlattr` filter in affected versions of Jinja accepts keys containing non-attribute characters. XML/HTML attributes cannot contain spaces, `/`, `>`, or `=`, as each would then be interpreted as starting a separate attribute. If an application accepts keys (as opposed to only values) as user input, and renders these in pages that other users see as well, an attacker could use this to inject other attributes and perform XSS. The fix for the previous GHSA-h5c8-rqwp-cp95 CVE-2024-22195 only addressed spaces but not other characters. Accepting keys as user input is now explicitly considered an unintended use case of the `xmlattr` filter, and code that does so without otherwise validating the input should be flagged as insecure, regardless of Jinja version. Accepting _values_ as user input continues to be safe.


Mitigations:

Architectural layers (MAESTRO):