Making all attributes on a content-type public without noticing it
Date: 2023-07
Affected: npm/@strapi/database, npm/@strapi/utils, npm/@strapi/strapi
Attack vector: info-disclosure
Category: vulnerability-disclosure
Severity: Medium
CVE: CVE-2023-34093
CWE: CWE-200
CVSS: 4.8 (CVSS:3.1/AV:N/AC:H/PR:H/UI:R/S:U/C:H/I:L/A:N)

### Summary Anyone (Strapi developers, users, plugins) can make every attribute of a Content-Type public without knowing it. ### Details When dealing with content-types inside a Strapi instance, we can extend those using the appropriate container: ```javascript strapi.container.get('content-types').extend(contentTypeUID, (contentType) => newContentType); ``` The vulnerability only affects the handling of content types by Strapi, not the actual content types themselves. Users can use plugins or modify their own content types without realizing that the `privateAttributes` getter is being removed, which can result in any attribute becoming public. This can lead to sensitive information being exposed or the entire system being taken control of by an attacker(having access to password hashes). ### PoC Extend any content type on runtime (like in the bootstrap functions) and do a copy of the content-type object. ```javascript strapi.container.get('content-types').extend(contentTypeUID, (contentType) => { const newCT = { ... contentType, attributes: { ...contentType.attributes, newAttr: {} } }; return newCT; }); ``` This will have as effect to remove the getter and as we rely on it in sanitization, every attributes will be considered as public. ### Impact Everyone can be impacted. Depending on how people are using/extending content-types. If the users are mutating the content-type, they will not be affected.


Mitigations:

Architectural layers (MAESTRO):