Vyper: reversed order of side effects for some operations
Date: 2023-09
Affected: pip/vyper
Attack vector: other
Category: vulnerability-disclosure
Severity: Medium
CVE: CVE-2023-40015
CWE: CWE-670
CVSS: 5.3 (CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:L/A:N)

### Impact For the following (probably non-exhaustive) list of expressions, the compiler evaluates the arguments from right to left instead of left to right. ``` - unsafe_add - unsafe_sub - unsafe_mul - unsafe_div - pow_mod256 - |, &, ^ (bitwise operators) - bitwise_or (deprecated) - bitwise_and (deprecated) - bitwise_xor (deprecated) - raw_call - <, >, <=, >=, ==, != - in, not in (when lhs and rhs are enums) ``` This behaviour becomes a problem when the evaluation of one of the arguments produces side effects that other arguments depend on. The following expressions can produce side-effect: - state modifying external call - state modifying internal call - `raw_call` - `pop()` when used on a Dynamic Array stored in the storage - `create_minimal_proxy_to` - `create_copy_of` - `create_from_blueprint` For example: ```Vyper f:uint256 @internal def side_effect() -> uint256: self.f = 12 return 1 @external def foo() -> uint256: return unsafe_add(self.f,self.side_effect()) # returns 13 instead of 1 ``` ```Vyper a:DynArray[uint256, 12] @external def bar() -> bool: self.a = [1,2,3] return len(self.a) == self.a.pop() # return false instead of true ``` ### Patches not yet patched, will address in a future release. tracking in https://github.com/vyperlang/vyper/issues/3604. ### Workarounds When using expressions from the list above, make sure that the arguments of the expression do not produce side effects or, if one does, that no other argument is depende


Mitigations:

Architectural layers (MAESTRO):