CVE: CVE-2024-41048
Published: 2024-07-29
Description: In the Linux kernel, the following vulnerability has been resolved:

skmsg: Skip zero length skb in sk_msg_recvmsg

When running BPF selftests (./test_progs -t sockmap_basic) on a Loongarch
platform, the following kernel panic occurs:

  [...]
  Oops[#1]:
  CPU: 22 PID: 2824 Comm: test_progs Tainted: G           OE  6.10.0-rc2+ #18
  Hardware name: LOONGSON Dabieshan/Loongson-TC542F0, BIOS Loongson-UDK2018
     ... ...
     ra:[PII_REDACTED]8bf6c0 sk_msg_recvmsg+0x120/0x560
    ERA: [PII_REDACTED] copy_page_to_iter+0x74/0x1c0
   CRMD: 000000b0 (PLV0 -IE -DA +PG DACF=CC DACM=CC -WE)
   PRMD: 0000000c (PPLV0 +PIE +PWE)
   EUEN: 00000007 (+FPE +SXE +ASXE -BTE)
   ECFG: 00071c1d (LIE=0,2-4,10-12 VS=7)
  ESTAT: 00010000 [PIL] (IS= ECode=1 EsubCode=0)
   BADV: [PII_REDACTED]
   PRID: 0014c011 (Loongson-64bit, Loongson-3C5000)
  Modules linked in: bpf_testmod(OE) xt_CHECKSUM xt_MASQUERADE xt_conntrack
  Process test_progs (pid: 2824, threadinfo=[PII_REDACTED]863a31, task=...)
  Stack : ...
  Call Trace:
  [<[PII_REDACTED]>] copy_page_to_iter+0x74/0x1c0
  [<[PII_REDACTED]8bf6c0>] sk_msg_recvmsg+0x120/0x560
  [<[PII_REDACTED]9f2b90>] tcp_bpf_recvmsg_parser+0x170/0x4e0
  [<[PII_REDACTED]9aae34>] inet_recvmsg+0x54/0x100
  [<[PII_REDACTED]81ad5c>] sock_recvmsg+0x7c/0xe0
  [<[PII_REDACTED]81e1a8>] __sys_recvfrom+0x108/0x1c0
  [<[PII_REDACTED]81e27c>] sys_recvfrom+0x1c/0x40
  [<[PII_REDACTED]c076ec>] do_syscall+0x8c/0xc0
  [<[PII_REDACTED]731da4>] handle_syscall+0xc4/0x160
  Code: ...
  ---[ end trace [PII_REDACTED] ]---
  Kernel panic - not syncing: Fatal exception
  Kernel relocated by 0x3510000
   .text @ 0x[PII_REDACTED]710000
   .data @ 0x[PII_REDACTED]d70000
   .bss  @ 0x[PII_REDACTED]469400
  ---[ end Kernel panic - not syncing: Fatal exception ]---
  [...]

This crash happens every time when running sockmap_skb_verdict_shutdown
subtest in sockmap_basic.

This crash is because a NULL pointer is passed to page_address() in the
sk_msg_recvmsg(). Due to the different implementations depending on the
architecture, page_address(NULL) will trigger a panic on Loongarch
platform but not on x86 platform. So this bug was hidden on x86 platform
for a while, but now it is exposed on Loongarch platform. The root cause
is that a zero length skb (skb->len == 0) was put on the queue.

This zero length skb is a TCP FIN packet, which was sent by shutdown(),
invoked in test_sockmap_skb_verdict_shutdown():

	shutdown(p1, SHUT_WR);

In this case, in sk_psock_skb_ingress_enqueue(), num_sge is zero, and no
page is put to this sge (see sg_set_page in sg_set_page), but this empty
sge is queued into ingress_msg list.

And in sk_msg_recvmsg(), this empty sge is used, and a NULL page is got by
sg_page(sge). Pass this NULL page to copy_page_to_iter(), which passes it
to kmap_local_page() and to page_address(), then kernel panics.

To solve this, we should skip this zero length skb. So in sk_msg_recvmsg(),
if copy is zero, that means it's a zero length skb, skip invoking
copy_page_to_iter(). We are using the EFAULT return triggered by
copy_page_to_iter to check for is_fin in tcp_bpf.c.
CVSS Score: 5.5 (MEDIUM)
CWE: CWE-476
References: https://git.kernel.org/stable/c/195b7bcdfc5adc5b2468f279dd9eb7eebd2e7632; https://git.kernel.org/stable/c/b180739b45a38b4caa88fe16bb5273072e6613dc; https://git.kernel.org/stable/c/f0c[PII_REDACTED]ec344a70b6887f7450bf4c826b