GitHub Security Advisory: GHSA-234q-vvw3-mrfq
Package: craftcms/cms (COMPOSER)
Severity: HIGH (CVSS 0.0)
CWE: CWE-287: Improper Authentication, CWE-639: Authorization Bypass Through User-Controlled Key
Vulnerable versions: >= 4.0.0-RC1, < 4.17.0-beta.2
Patched in: 4.17.0-beta.2

Summary: Craft CMS has unauthenticated activation email trigger with potential user enumeration

Details:
The `actionSendActivationEmail()` endpoint is accessible to unauthenticated users and does not require a permission check for pending users. An attacker with no prior access can trigger activation emails for any pending user account by knowing or guessing the user ID. If the attacker controls the target user’s email address, they can activate the account and gain access to the system.

The vulnerability is not that anonymous access exists - there’s a legitimate use case for it. The vulnerability is that the endpoint accepts arbitrary `userId` parameters without verifying ownership.

Craft CMS allows public user registration. When a user registers but doesn’t receive their activation email (spam filter, typo correction, etc.), they need a way to request a resend. This is why `send-activation-email` is in the `allowAnonymous` array - it’s intentional self-service functionality.

### The Security Gap

The endpoint accepts `userId` as the identifier:
```php
$userId = $this->request->getRequiredBodyParam('userId');
```

This allows any visitor to trigger activation emails for any pending user, not just their own registration.

---

## Background

When administrators create new user accounts in Craft CMS, users are created in a “pending” state until they activate their account via an emailed link. The `actionSendActivationEmail()` function sends (or resends) this activation email.

**Expected Behavior:** Anonymous users should only be able to resend activation emails for their own registration.

**Actual Behavior:**
1. The endpoint is listed in `allowAnonymous` - no login required (intentional for self-service)
2. For pending users, there is NO ownership verification
3. Any unauthenticated visitor can trigger activation emails for ANY pending user by ID

---

## Attack Scenarios

### Scenario 1: Targeted Account Takeover

**Prerequisites:** Attacker controls target user’s email (compromised email, shared mailbox, typosquatting, etc.)

```
1. Admin creates a user account for victim@company.com
2. User account is in PENDING state (hasn’t activated yet)
3. Attacker has compromised victim@company.com (or it’s a typo of attacker’s domain)
4. Attacker discovers user ID (brute-force, GraphQL enumeration, or insider knowledge)
5. Attacker (unauthenticated) triggers: POST /actions/users/send-activation-email
6. Activation email sent to victim@company.com (attacker-controlled)
7. Attacker clicks activation link, sets password
8. Attacker gains access as that user with pre-assigned permissions
```

### Scenario 2: User ID Brute-Force Enumeration

```
1. Attacker iterates through user IDs (1, 2, 3, ...)
2. For each ID, the attacker calls send-activation-email
3. Response reveals user state:
   - "Activation email sent." = Pending user exists
   - "User not found" = No user with this ID
   - "Activation emails can only be sent to inactive or pending users" = Active user exists
4. Attacker builds a map of all user IDs and their states
5. For any pending user whose e