CVE: CVE-2024-50031
Published: 2024-10-21
Description: In the Linux kernel, the following vulnerability has been resolved:

drm/v3d: Stop the active perfmon before being destroyed

When running `kmscube` with one or more performance monitors enabled
via `GALLIUM_HUD`, the following kernel panic can occur:

[   55.008324] Unable to handle kernel paging request at virtual address[PII_REDACTED]2004a4
[   55.008368] Mem abort info:
[   55.008377]   ESR = 0x[PII_REDACTED]000005
[   55.008387]   EC = 0x25: DABT (current EL), IL = 32 bits
[   55.008402]   SET = 0, FnV = 0
[   55.008412]   EA = 0, S1PTW = 0
[   55.008421]   FSC = 0x05: level 1 translation fault
[   55.008434] Data abort info:
[   55.008442]   ISV = 0, ISS = 0x00000005, ISS2 = 0x00000000
[   55.008455]   CM = 0, WnR = 0, TnD = 0, TagAccess = 0
[   55.008467]   GCS = 0, Overlay = 0, DirtyBit = 0, Xs = 0
[   55.008481] user pgtable: 4k pages, 39-bit VAs, pgdp=[PII_REDACTED]6c6000
[   55.008497] [[PII_REDACTED]2004a4] pgd=[PII_REDACTED], p4d=[PII_REDACTED], pud=[PII_REDACTED]
[   55.008525] Internal error: Oops: [PII_REDACTED] [#1] PREEMPT SMP
[   55.008542] Modules linked in: rfcomm [...] vc4 v3d snd_soc_hdmi_codec drm_display_helper
gpu_sched drm_shmem_helper cec drm_dma_helper drm_kms_helper i2c_brcmstb
drm drm_panel_orientation_quirks snd_soc_core snd_compress snd_pcm_dmaengine snd_pcm snd_timer snd backlight
[   55.008799] CPU: 2 PID: 166 Comm: v3d_bin Tainted: G         C         6.6.47+rpt-rpi-v8 #1  Debian 1:6.6.47-1+rpt1
[   55.008824] Hardware name: Raspberry Pi 4 Model B Rev 1.5 (DT)
[   55.008838] pstate: 20000005 (nzCv daif -PAN -UAO -TCO -DIT -SSBS BTYPE=--)
[   55.008855] pc : __mutex_lock.constprop.0+0x90/0x608
[   55.008879] lr : __mutex_lock.constprop.0+0x58/0x608
[   55.008895] sp : ffffffc080673cf0
[   55.008904] x29: ffffffc080673cf0 x28: [PII_REDACTED] x27: ffffff8106188a28
[   55.008926] x26: ffffff8101e78040 x25: ffffff8101baa6c0 x24: ffffffd9d989f148
[   55.008947] x23: ffffffda1c2a4008 x22: [PII_REDACTED] x21: ffffffc080673d38
[   55.008968] x20: ffffff[PII_REDACTED] x19: ffffff8104f83188 x18: [PII_REDACTED]
[   55.008988] x17: [PII_REDACTED] x16: ffffffda1bd04d18 x15: 00000055bb08bc90
[   55.009715] x14: [PII_REDACTED] x13: [PII_REDACTED] x12: ffffffda1bd4cbb0
[   55.010433] x11: 00000000fa83b2da x10:[PII_REDACTED]001a40 x9 : ffffffda1bd04d04
[   55.011162] x8 : ffffff8102097b80 x7 : [PII_REDACTED] x6 :[PII_REDACTED]0a5857
[   55.011880] x5 : 00ffffffffffffff x4 : [PII_REDACTED] x3 : [PII_REDACTED]
[   55.012598] x2 : ffffff[PII_REDACTED] x1 : [PII_REDACTED] x0 : [PII_REDACTED]
[   55.013292] Call trace:
[   55.013959]  __mutex_lock.constprop.0+0x90/0x608
[   55.014646]  __mutex_lock_slowpath+0x1c/0x30
[   55.015317]  mutex_lock+0x50/0x68
[   55.015961]  v3d_perfmon_stop+0x40/0xe0 [v3d]
[   55.016627]  v3d_bin_job_run+0x10c/0x2d8 [v3d]
[   55.017282]  drm_sched_main+0x178/0x3f8 [gpu_sched]
[   55.017921]  kthread+0x11c/0x128
[   55.018554]  ret_from_fork+0x10/0x20
[   55.019168] Code: f9400260 f1001c1f 54001ea9 927df000 (b9403401)
[   55.019776] ---[ end trace [PII_REDACTED] ]---
[   55.020411] note: v3d_bin[166] exited with preempt_count 1

This issue arises because, upon closing the file descriptor (which happens
when we interrupt `kmscube`), the active performance monitor is not
stopped. Although all perfmons are destroyed in `v3d_perfmon_close_file()`,
the active performance monitor's pointer (`v3d->active_perfmon`) is still
retained.

If `kmscube` is run again, the driver will attempt to stop the active
performance monitor using the stale pointer in `v3d->active_perfmon`.
However, this pointer is no longer valid because the previous process has
already terminated, and all performance monitors associated with it have
been destroyed and freed.

To fix this, when the active performance monitor belongs to a given
process, explicitly stop it before destroying and freeing it.
CVSS Score: 5.5 (MEDIUM)
References: https://git.kernel.org/stable/c/07c51108d9e278831c16191d1223ee49986e7890; https://git.kernel.org/stable/c/0c9e9a3a[PII_REDACTED]b19300cadc[PII_REDACTED]ef; https://git.kernel.org/stable/c/24ab54a066d2ef671b03eb909ca2114c0c9ac1e7