Project: KICS (Provisioning / Security & Compliance)
File: 4a1e6b34-1008-4e61-a5f2-1f7c276f8d14.md

title: Unrestricted Security Group Ingress hide: toc: true navigation: true <style> .highlight .hll { background-color: #ff171742; } .md-content { max-width: 1100px; margin: 0 auto; } </style> Query id: 4a1e6b34-1008-4e61-a5f2-1f7c276f8d14 Query name: Unrestricted Security Group Ingress Platform: CloudFormation Severity: <span style="color:#bb2124">High</span> Category: Networking and Firewall URL: AWS Security Group Ingress CIDR should not be open to the world<br> ```yaml title="Positive test num. 1 - yaml file" hl_lines="43 13" Resources: InstanceSecurityGroup: Type: AWS::EC2::SecurityGroup Properties: GroupDescription: Allow http to client host VpcId: Ref: myVPC SecurityGroupIngress: IpProtocol: tcp Description: TCP FromPort: 80 ToPort: 80 CidrIp: 0.0.0.0/0 SecurityGroupEgress: IpProtocol: tcp Description: TCP FromPort: 80 ToPort: 80 CidrIp: 0.0.0.0/0 OutboundRule: Type: AWS::EC2::SecurityGroupEgress Properties: Description: TCP IpProtocol: tcp FromPort: 0 ToPort: 65535 CidrIp: 0.0.0.0/0 DestinationSecurityGroupId: Fn::GetAtt: TargetSG GroupId GroupId: Fn::GetAtt: SourceSG GroupId InboundRule: Type: AWS::EC2::SecurityGroupIngress Properties: Description: TCP IpProtocol: tcp FromPort: 0 ToPort: 65535 CidrIpv6: ::/0 SourceSecurityGroupId: Fn::GetAtt: SourceSG GroupId GroupId: Fn::GetAtt: TargetSG GroupId ``` ```json title="Positive test num. 2 - json file" hl_lines="56 30" { "Resources": { "OutboundRule": { "Type": "AWS::EC2::SecurityGroupEgress", "Properties": { "Description": "TCP", "IpProtocol": "tcp", "FromPort": 0, "ToPort": 65535, "CidrIp": "0.0.0.0/0", "DestinationSecurityGroupId": { "Fn::GetAtt": [ "TargetSG", "GroupId" ] }, "GroupId": { "Fn::GetAtt": [ "SourceSG", "GroupId" ] } } }, "InboundRule": { "Type": "AWS::EC2::SecurityGroupIngress", "Properties": { "FromPort": 0, "ToPort": 65535, "CidrIpv6": "::/0", "SourceSecurityGroupId": { "Fn::GetAtt": [ "SourceSG", "GroupId" ] }, "GroupId": { "Fn::GetAtt": [ "TargetSG", "GroupId" ] }, "Description": "TCP", "IpProtocol": "tcp" } }, "InstanceSecurityGroup": { "Type": "AWS::EC2::SecurityGroup", "Properties": { "VpcId": { "Ref": "myVPC" }, "SecurityGroupIngress": [ { "ToPort": 80, "CidrIp": "0.0.0.0/0", "IpProtocol": "tcp", "Description": "TCP", "FromPort": 80 } ], "SecurityGroupEgress": [ { "IpProtocol": "tcp", "Description": "TCP", "FromPort": 80, "ToPort": 80, "CidrIp": "0.0.0.0/0" } ], "GroupDescription": "Allow http to client host" } } } } ``` ```yaml title="Negative test num. 1 - yaml file" Resources: InstanceSecurityGroup: Type: AWS::EC2::SecurityGroup Properties: GroupDescription: Allow http to client host VpcId: Ref: myVPC SecurityGroupIngress: IpProtocol: tcp Description: TCP FromPort: 80 ToPort: 80 CidrIp: 192.0.2.0/24 SecurityGroupEgress: IpProtocol: tcp Description: TCP FromPort: 80 ToPort: 80 CidrIp: 192.0.2.0/24 OutboundRule: Type: AWS::EC2::SecurityGroupEgress Properties: Description: TCP IpProtocol: tcp FromPort: 0 ToPort: 0 CidrIp: 192.0.2.0/24 DestinationSecurityGroupId: Fn::GetAtt: TargetSG GroupId GroupId: Fn::GetAtt: SourceSG GroupId InboundRule: Type: AWS::EC2::SecurityGroupIngress Properties: Description: TCP IpProtocol: tcp FromPort: 0 ToPort: 0 CidrIpv6: 2001:0DB8:1234::/48 SourceSecurityGroupId: Fn::GetAtt: SourceSG GroupId GroupId: Fn::GetAtt: TargetSG GroupId ``` ```json title="Negative test num. 2 - json file" { "Resources": { "InstanceSecurityGroup": { "Type": "AWS::EC2::SecurityGroup", "Properties": { "SecurityGroupEgress": [ { "IpProtocol": "tcp", "Description": "TCP", "FromPort": 80, "ToPort": 80, "CidrIp": "192.0.2.0/24" } ], "GroupDescription": "Allow http to client host", "VpcId": { "Ref": "myVPC" }, "SecurityGroupIngress": [ { "IpProtocol": "tcp", "Description": "TCP", "FromPort": 80, "ToPort": 80, "CidrIp": "192.0.2.0/24" } ] } }, "OutboundRule": { "Type": "AWS::EC2::SecurityGroupEgress", "Properties": { "GroupId": { "Fn::GetAtt": [ "SourceSG", "GroupId" ] }, "Description": "TCP", "IpProtocol": "tcp", "FromPort": 0, "ToPort": 0, "CidrIp": "192.0.2.0/24", "DestinationSecurityGroupId": { "Fn::GetAtt": [ "TargetSG", "GroupId" ] } } }, "InboundRule": { "Type": "AWS::EC2::SecurityGroupIngress", "Properties": { "GroupId": { "Fn::GetAtt": [ "TargetSG", "GroupId" ] }, "Description": "TCP", "IpProtocol": "tcp", "FromPort": 0, "ToPort": 0, "CidrIpv6": "2001:0DB8:1234::/48", "SourceSecurityGroupId": { "Fn::GetAtt": [ "SourceSG", "GroupId" ] } } } } } ```