By far the largest majority of makers feel that smooth chokes are the way to go. With only one exception that I know of, all makers of fixed choke guns make their chokes as smooth as their barrel bores. A quick glance down Rhinos or Teagues will show this. No argument there. It's also very much a perceived quality thing.
Most shooters assume that a rough choke is a sign of poor quality and in most cases they are right.
There is contrary opinion. The theory is that a rough choke very slightly retards the wad and helps the shot and wad separate. This is supposed to produce more reliable patterns because, in theory, it keeps the wad from disrupting the shot cloud. Lujtic trap guns often have a scribed circle or two in the choke to act as a wad grabber. Pattern Master screw chokes have a series of knobs inside their chokes that are meant to aggressively strip the wad.