Repository: island-is/island.is
Pull request #18864: feat(medical-and-rehabilitation-payments):  Prerequisites providers text
Author: login: birkirkristmunds
Created: 2025-04-25T09:41:01Z | Merged: 2025-04-29T10:56:23Z

[TS-1015](https://dit-iceland.atlassian.net/browse/TS-1015)

## What

Specify what you're trying to achieve

## Why

Specify why you need to achieve this

## Screenshots / Gifs

Attach Screenshots / Gifs to help reviewers understand the scope of the pull request

## Checklist:

- [ ] I have performed a self-review of my own code
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] Formatting passes locally with my changes
- [ ] I have rebased against main before asking for a review



Diff:
diff --git a/libs/application/templates/social-insurance-administration/core/src/lib/messages.ts b/libs/application/templates/social-insurance-administration/core/src/lib/messages.ts
index 256d021d1b1e..e870a388964f 100644
--- a/libs/application/templates/social-insurance-administration/core/src/lib/messages.ts
+++ b/libs/application/templates/social-insurance-administration/core/src/lib/messages.ts
@@ -43,9 +43,10 @@ export const socialInsuranceAdministrationMessage: MessageDir = {
     },
     checkboxProvider: {
       id: 'sia.application:prerequisites.checkbox.provider',
-      defaultMessage: 'Ég samþykki gagnaöflun í umsóknarferlinu',
+      defaultMessage:
+        'Ég skil að ofangreindra upplýsinga verður aflað í umsóknarferlinu',
       description:
-        'I agree to the collection of data as a part of the application process',
+        'I understand that the above information will be collected during the application process',
     },
     skraInformationTitle: {
       id: 'sia.application:prerequisites.national.registry.title',
diff --git a/libs/application/templates/social-insurance-administration/medical-and-rehabilitation-payments/src/forms/Prerequisites/externalDataSubSection.ts b/libs/application/templates/social-insurance-administration/medical-and-rehabilitation-payments/src/forms/Prerequisites/externalDataSubSection.ts
index bff21b2399eb..8228a5cee390 100644
--- a/libs/application/templates/social-insurance-administration/medical-and-rehabilitation-payments/src/forms/Prerequisites/externalDataSubSection.ts
+++ b/libs/application/templates/social-insurance-administration/medical-and-rehabilitation-payments/src/forms/Prerequisites/externalDataSubSection.ts
@@ -13,6 +13,7 @@ import {
   NationalRegistryUserApi,
   UserProfileApi,
 } from '@island.is/application/types'
+import { medicalAndRehabilitationPaymentsFormMessage } from '../../lib/messages'
 import { SocialInsuranceAdministrationApplicantApi } from '../../dataProviders'
 
 export const externalDataSubSection = buildSubSection({
@@ -40,15 +41,16 @@ export const externalDataSubSection = buildSubSection({
       }),
       dataProviders: [
         buildDataProviderItem({
-          // TODO: Update text!
           provider: NationalRegistryUserApi,
-          title: socialInsuranceAdministrationMessage.pre.skraInformationTitle,
-          subTitle: '',
+          title:
+            medicalAndRehabilitationPaymentsFormMessage.pre
+              .skraInformationTitle,
+          subTitle:
+            medicalAndRehabilitationPaymentsFormMessage.pre
+              .skraInformationDescription,
         }),
         buildDataProviderItem({
-          // TODO: Update text?
           provider: NationalRegistrySpouseApi,
-          title: '',
         }),
         buildDataProviderItem({
           provider: UserProfileApi,
@@ -66,7 +68,30 @@ export const externalDataSubSection = buildSubSection({
               .socialInsuranceAdministrationDescription,
         }),
         buildDataProviderItem({
-          id: 'sia.data',
+          title:
+            medicalAndRehabilitationPaymentsFormMessage.pre
+              .healthInstitutionTitle,
+          subTitle:
+            medicalAndRehabilitationPaymentsFormMessage.pre
+              .healthInstitutionDescription,
+        }),
+        buildDataProviderItem({
+          title:
+            medicalAndRehabilitationPaymentsFormMessage.pre
+              .unionHealthFundTitle,
+          subTitle:
+            medicalAndRehabilitationPaymentsFormMessage.pre
+              .unionHealthFundDescription,
+        }),
+        buildDataProviderItem({
+          title:
+            medicalAndRehabilitationPaymentsFormMessage.pre
+              .serviceRehabilitationTreatmentProviderTitle,
+          subTitle:
+            medicalAndRehabilitationPaymentsFormMessage.pre
+              .serviceRehabilitationTreatmentProviderDescription,
+        }),
+        buildDataProviderItem({
           title:
             socialInsuranceAdministrationMessage.pre
               .socialInsuranceAdministrationInformationTitle,
@@ -75,7 +100,6 @@ export const externalDataSubSection = buildSubSection({
               .socialInsuranceAdministrationDataDescription,
         }),
         buildDataProviderItem({
-          id: 'sia.privacy',
           title:
             socialInsuranceAdministrationMessage.pre
               .socialInsuranceAdministrationPrivacyTitle,
@@ -92,7 +116,6 @@ export const externalDataSubSection = buildSubSection({
     }),
     buildMultiField({
       id: 'isNotEligible',
-      title: '',
       // condition: (_, externalData) => {
       //   // Show if applicant is not eligible
       //   return !isEligible(externalData)
diff --git a/libs/application/templates/social-insurance-administration/medical-and-rehabilitation-payments/src/lib/messages.ts b/libs/application/templates/social-insurance-administration/medical-and-rehabilitation-payments/src/lib/messages.ts
index d24a51fcd8e6..a2ebbf038065 100644
--- a/libs/application/templates/social-insurance-administration/medical-and-rehabilitation-payments/src/lib/messages.ts
+++ b/libs/application/templates/social-insurance-administration/medical-and-rehabilitation-payments/src/lib/messages.ts
@@ -42,6 +42,55 @@ export const medicalAndRehabilitationPaymentsFormMessage: MessageDir = {
 
   pre: defineMessages({
     // Data collection
+    skraInformationTitle: {
+      id: 'marp.application:pre.skra.information.title',
+      defaultMessage: 'Upplýsingar frá Þjóðskrá, RSK og Útlendingarstofnun',
+      description:
+        'Information from Registers Iceland, RSK and Directorate of Immigration',
+    },
+    skraInformationDescription: {
+      id: 'marp.application:pre.skra.information.description',
+      defaultMessage:
+        'Upplýsingar um þig, maka og börn. Upplýsingar um búsetu.',
+      description:
+        'Information about you, spouse and children. Information about residence.',
+    },
+    healthInstitutionTitle: {
+      id: 'marp.application:pre.health.institution.title',
+      defaultMessage: 'Upplýsingar frá heilbrigðisstofnun',
+      description: 'Information from health institution',
+    },
+    healthInstitutionDescription: {
+      id: 'marp.application:pre.health.institution.description',
+      defaultMessage: 'Upplýsingar um læknisvottorð.',
+      description: 'Information about medical certificate.',
+    },
+    unionHealthFundTitle: {
+      id: 'marp.application:pre.union.health.fund.title',
+      defaultMessage: 'Upplýsingar frá sjúkrasjóði stéttarfélags',
+      description: 'Information from union health fund',
+    },
+    unionHealthFundDescription: {
+      id: 'marp.application:pre.union.health.fund.description',
+      defaultMessage:
+        'Upplýsingar um hvenær þú lýkur/laukst áunnum sjúkrasjóðsrétti.',
+      description:
+        'Information about when you end/ended your acquired health fund rights.',
+    },
+    serviceRehabilitationTreatmentProviderTitle: {
+      id: 'marp.application:pre.service.rehabilitation.treatment.provider.title',
+      defaultMessage:
+        'Upplýsingar frá þjónustuaðila, endurhæfingar- eða meðferðaraðila',
+      description:
+        'Information from service provider, rehabilitation or treatment provider',
+    },
+    serviceRehabilitationTreatmentProviderDescription: {
+      id: 'marp.application:pre.service.rehabilitation.treatment.provider.description',
+      defaultMessage:
+        'Tryggingastofnun sækir endurhæfingaráætlun til þjónustuaðila sem sér um endurhæfingu eða meðferð.',
+      description:
+        'The Social Insurance Administration retrieves the rehabilitation plan from the service provider responsible for rehabilitation or treatment.',
+    },
   }),
 
   generalInformation: defineMessages({


Reviews:
user: login: veronikasif
state: CHANGES_REQUESTED
author_association: MEMBER
submitted_at: 2025-04-28T12:00:12Z
user: login: birkirkristmunds
state: COMMENTED
author_association: MEMBER
submitted_at: 2025-04-28T13:37:57Z
user: login: birkirkristmunds
state: COMMENTED
author_association: MEMBER
submitted_at: 2025-04-28T13:49:22Z
user: login: birkirkristmunds
state: COMMENTED
author_association: MEMBER
submitted_at: 2025-04-28T13:50:43Z
user: login: birkirkristmunds
state: COMMENTED
author_association: MEMBER
submitted_at: 2025-04-28T13:52:23Z
user: login: birkirkristmunds
state: COMMENTED
author_association: MEMBER
submitted_at: 2025-04-28T13:53:12Z
user: login: birkirkristmunds
state: COMMENTED
author_association: MEMBER
submitted_at: 2025-04-28T13:54:02Z
user: login: birkirkristmunds
state: COMMENTED
author_association: MEMBER
submitted_at: 2025-04-28T14:19:19Z
user: login: birkirkristmunds
state: COMMENTED
author_association: MEMBER
submitted_at: 2025-04-28T14:20:17Z
user: login: birkirkristmunds
state: COMMENTED
author_association: MEMBER
submitted_at: 2025-04-28T14:23:22Z
user: login: coderabbitai[bot]
state: APPROVED
author_association: CONTRIBUTOR
submitted_at: 2025-04-29T10:22:55Z
user: login: veronikasif
body: lgtm 👍 
state: APPROVED
author_association: MEMBER
submitted_at: 2025-04-29T10:56:09Z

Review comments:
diff_hunk: @@ -43,9 +43,10 @@ export const socialInsuranceAdministrationMessage: MessageDir = {
     },
     checkboxProvider: {
       id: 'sia.application:prerequisites.checkbox.provider',
-      defaultMessage: 'Ég samþykki gagnaöflun í umsóknarferlinu',
+      defaultMessage:
+        'Ég skil að ofangreindra upplýsinga verður aflað í umsóknarferlinu',
       description:
-        'I agree to the collection of data as a part of the application process',
+        'I understand that the above information will be obtained in the application process',
path: libs/application/templates/social-insurance-administration/core/src/lib/messages.ts
user: login: veronikasif
body: The translation was like this in Contentful before 😇 
<img width="596" alt="image" src="https://github.com/user-attachments/assets/f86f7239-bc93-4575-9b26-7143aef4709a" />

```suggestion
        'I understand that the above information will be collected during the application process',
```
created_at: 2025-04-28T10:28:49Z
author_association: MEMBER
diff_hunk: @@ -42,6 +42,67 @@ export const medicalAndRehabilitationPaymentsFormMessage: MessageDir = {
 
   pre: defineMessages({
     // Data collection
+    skraInformationTitle: {
+      id: 'marp.application:pre.skra.information.title',
+      defaultMessage: 'Upplýsingar frá Þjóðskrá, RSK og Útlendingarstofnun',
+      description:
+        'Information from National Registry, RSK and Directorate of Immigration',
+    },
+    skraInformationDescription: {
+      id: 'marp.application:pre.skra.information.description',
+      defaultMessage:
+        'Upplýsingar um þig, maka og börn. Upplýsingar um búsetu.',
+      description:
+        'Information about you, spouse and children. Information about residence.',
+    },
+    contactInfoTitle: {
+      id: 'marp.application:pre.contact.info.title',
+      defaultMessage: 'Upplýsingar af mínum síðum Ísland.is',
+      description: 'Information from my pages on Ísland.is',
+    },
path: libs/application/templates/social-insurance-administration/medical-and-rehabilitation-payments/src/lib/messages.ts
user: login: veronikasif
body: Remove this, instead use `contactInfoTitle` in core
created_at: 2025-04-28T10:59:27Z
author_association: MEMBER
diff_hunk: @@ -40,39 +40,50 @@ export const externalDataSubSection = buildSubSection({
       }),
       dataProviders: [
         buildDataProviderItem({
-          // TODO: Update text!
           provider: NationalRegistryUserApi,
-          title: socialInsuranceAdministrationMessage.pre.skraInformationTitle,
-          subTitle: '',
+          title:
+            medicalAndRehabilitationPaymentsFormMessage.pre
+              .skraInformationTitle,
+          subTitle:
+            medicalAndRehabilitationPaymentsFormMessage.pre
+              .skraInformationDescription,
         }),
         buildDataProviderItem({
-          // TODO: Update text?
           provider: NationalRegistrySpouseApi,
           title: '',
         }),
         buildDataProviderItem({
           provider: UserProfileApi,
-          title: socialInsuranceAdministrationMessage.pre.contactInfoTitle,
+          title:
+            medicalAndRehabilitationPaymentsFormMessage.pre.contactInfoTitle,
path: libs/application/templates/social-insurance-administration/medical-and-rehabilitation-payments/src/forms/Prerequisites/externalDataSubSection.ts
user: login: veronikasif
body: Use `contactInfoTitle` in core
```suggestion
          title: socialInsuranceAdministrationMessage.pre.contactInfoTitle,
```
created_at: 2025-04-28T11:01:07Z
author_association: MEMBER
diff_hunk: @@ -40,39 +40,50 @@ export const externalDataSubSection = buildSubSection({
       }),
       dataProviders: [
         buildDataProviderItem({
-          // TODO: Update text!
           provider: NationalRegistryUserApi,
-          title: socialInsuranceAdministrationMessage.pre.skraInformationTitle,
-          subTitle: '',
+          title:
+            medicalAndRehabilitationPaymentsFormMessage.pre
+              .skraInformationTitle,
+          subTitle:
+            medicalAndRehabilitationPaymentsFormMessage.pre
+              .skraInformationDescription,
         }),
         buildDataProviderItem({
-          // TODO: Update text?
           provider: NationalRegistrySpouseApi,
           title: '',
path: libs/application/templates/social-insurance-administration/medical-and-rehabilitation-payments/src/forms/Prerequisites/externalDataSubSection.ts
user: login: veronikasif
body: Remove empty string title ([PR-17634](https://github.com/island-is/island.is/pull/17634))
```suggestion
```
created_at: 2025-04-28T11:21:22Z
author_association: MEMBER
diff_hunk: @@ -42,6 +42,67 @@ export const medicalAndRehabilitationPaymentsFormMessage: MessageDir = {
 
   pre: defineMessages({
     // Data collection
+    skraInformationTitle: {
+      id: 'marp.application:pre.skra.information.title',
+      defaultMessage: 'Upplýsingar frá Þjóðskrá, RSK og Útlendingarstofnun',
+      description:
+        'Information from National Registry, RSK and Directorate of Immigration',
path: libs/application/templates/social-insurance-administration/medical-and-rehabilitation-payments/src/lib/messages.ts
user: login: veronikasif
body: Update translation? So it matches core translation?
<img width="349" alt="image" src="https://github.com/user-attachments/assets/ec870280-f468-4cd5-ad52-68b990fdfae4" />

```suggestion
        'Information from Registers Iceland, RSK and Directorate of Immigration',
```
created_at: 2025-04-28T11:32:41Z
author_association: MEMBER
diff_hunk: @@ -42,6 +42,67 @@ export const medicalAndRehabilitationPaymentsFormMessage: MessageDir = {
 
   pre: defineMessages({
     // Data collection
+    skraInformationTitle: {
+      id: 'marp.application:pre.skra.information.title',
+      defaultMessage: 'Upplýsingar frá Þjóðskrá, RSK og Útlendingarstofnun',
+      description:
+        'Information from National Registry, RSK and Directorate of Immigration',
+    },
+    skraInformationDescription: {
+      id: 'marp.application:pre.skra.information.description',
+      defaultMessage:
+        'Upplýsingar um þig, maka og börn. Upplýsingar um búsetu.',
+      description:
+        'Information about you, spouse and children. Information about residence.',
+    },
+    contactInfoTitle: {
+      id: 'marp.application:pre.contact.info.title',
+      defaultMessage: 'Upplýsingar af mínum síðum Ísland.is',
+      description: 'Information from my pages on Ísland.is',
+    },
+    contactInfoDescription: {
+      id: 'marp.application:pre.contact.info.description',
+      defaultMessage:
+        'Upplýsingar um netfang, símanúmer og bankareikning eru sóttar á mínar síður á Ísland.is.',
+      description:
+        'Information about email, phone number and bank account is retrieved from my pages on Ísland.is.',
+    },
path: libs/application/templates/social-insurance-administration/medical-and-rehabilitation-payments/src/lib/messages.ts
user: login: veronikasif
body: Remove this, instead use `contactInfoDescription` in core
created_at: 2025-04-28T11:33:21Z
author_association: MEMBER
diff_hunk: @@ -40,39 +40,50 @@ export const externalDataSubSection = buildSubSection({
       }),
       dataProviders: [
         buildDataProviderItem({
-          // TODO: Update text!
           provider: NationalRegistryUserApi,
-          title: socialInsuranceAdministrationMessage.pre.skraInformationTitle,
-          subTitle: '',
+          title:
+            medicalAndRehabilitationPaymentsFormMessage.pre
+              .skraInformationTitle,
+          subTitle:
+            medicalAndRehabilitationPaymentsFormMessage.pre
+              .skraInformationDescription,
         }),
         buildDataProviderItem({
-          // TODO: Update text?
           provider: NationalRegistrySpouseApi,
           title: '',
         }),
         buildDataProviderItem({
           provider: UserProfileApi,
-          title: socialInsuranceAdministrationMessage.pre.contactInfoTitle,
+          title:
+            medicalAndRehabilitationPaymentsFormMessage.pre.contactInfoTitle,
           subTitle:
-            socialInsuranceAdministrationMessage.pre.contactInfoDescription,
+            medicalAndRehabilitationPaymentsFormMessage.pre
+              .contactInfoDescription,
path: libs/application/templates/social-insurance-administration/medical-and-rehabilitation-payments/src/forms/Prerequisites/externalDataSubSection.ts
user: login: veronikasif
body: Use `contactInfoDescription` in core
```suggestion
            socialInsuranceAdministrationMessage.pre.contactInfoDescription,
```


created_at: 2025-04-28T11:34:03Z
author_association: MEMBER
diff_hunk: @@ -40,39 +40,50 @@ export const externalDataSubSection = buildSubSection({
       }),
       dataProviders: [
         buildDataProviderItem({
-          // TODO: Update text!
           provider: NationalRegistryUserApi,
-          title: socialInsuranceAdministrationMessage.pre.skraInformationTitle,
-          subTitle: '',
+          title:
+            medicalAndRehabilitationPaymentsFormMessage.pre
+              .skraInformationTitle,
+          subTitle:
+            medicalAndRehabilitationPaymentsFormMessage.pre
+              .skraInformationDescription,
         }),
         buildDataProviderItem({
-          // TODO: Update text?
           provider: NationalRegistrySpouseApi,
           title: '',
         }),
         buildDataProviderItem({
           provider: UserProfileApi,
-          title: socialInsuranceAdministrationMessage.pre.contactInfoTitle,
+          title:
+            medicalAndRehabilitationPaymentsFormMessage.pre.contactInfoTitle,
           subTitle:
-            socialInsuranceAdministrationMessage.pre.contactInfoDescription,
+            medicalAndRehabilitationPaymentsFormMessage.pre
+              .contactInfoDescription,
         }),
path: libs/application/templates/social-insurance-administration/medical-and-rehabilitation-payments/src/forms/Prerequisites/externalDataSubSection.ts
user: login: veronikasif
body: Add `SocialInsuranceAdministrationApplicantApi` because we are getting the bank account from TR
![image](https://github.com/user-attachments/assets/27eb959b-b9fa-474c-b436-279677756e4c)

```suggestion
        }),
        buildDataProviderItem({
          provider: SocialInsuranceAdministrationApplicantApi,
          title:
            socialInsuranceAdministrationMessage.pre
              .socialInsuranceAdministrationTitle,
          subTitle:
            socialInsuranceAdministrationMessage.pre
              .socialInsuranceAdministrationDescription,
        }),
```
created_at: 2025-04-28T11:38:48Z
author_association: MEMBER
diff_hunk: @@ -40,39 +40,50 @@ export const externalDataSubSection = buildSubSection({
       }),
       dataProviders: [
         buildDataProviderItem({
-          // TODO: Update text!
           provider: NationalRegistryUserApi,
-          title: socialInsuranceAdministrationMessage.pre.skraInformationTitle,
-          subTitle: '',
+          title:
+            medicalAndRehabilitationPaymentsFormMessage.pre
+              .skraInformationTitle,
+          subTitle:
+            medicalAndRehabilitationPaymentsFormMessage.pre
+              .skraInformationDescription,
         }),
         buildDataProviderItem({
-          // TODO: Update text?
           provider: NationalRegistrySpouseApi,
           title: '',
         }),
         buildDataProviderItem({
           provider: UserProfileApi,
-          title: socialInsuranceAdministrationMessage.pre.contactInfoTitle,
+          title:
+            medicalAndRehabilitationPaymentsFormMessage.pre.contactInfoTitle,
           subTitle:
-            socialInsuranceAdministrationMessage.pre.contactInfoDescription,
+            medicalAndRehabilitationPaymentsFormMessage.pre
+              .contactInfoDescription,
         }),
         buildDataProviderItem({
-          provider: SocialInsuranceAdministrationApplicantApi,
           title:
-            socialInsuranceAdministrationMessage.pre
-              .socialInsuranceAdministrationTitle,
+            medicalAndRehabilitationPaymentsFormMessage.pre
+              .healthInstitutionTitle,
           subTitle:
-            socialInsuranceAdministrationMessage.pre
-              .socialInsuranceAdministrationDescription,
+            medicalAndRehabilitationPaymentsFormMessage.pre
+              .healthInstitutionDescription,
+        }),
+        buildDataProviderItem({
+          title:
+            medicalAndRehabilitationPaymentsFormMessage.pre
+              .unionHealthFundTitle,
+          subTitle:
+            medicalAndRehabilitationPaymentsFormMessage.pre
+              .unionHealthFundDescription,
         }),
         buildDataProviderItem({
           id: 'sia.data',
path: libs/application/templates/social-insurance-administration/medical-and-rehabilitation-payments/src/forms/Prerequisites/externalDataSubSection.ts
user: login: veronikasif
body: Remove `id`? 🤔 We will add `provider` when the endpoints are ready
```suggestion
```
created_at: 2025-04-28T11:43:53Z
author_association: MEMBER
diff_hunk: @@ -40,39 +40,50 @@ export const externalDataSubSection = buildSubSection({
       }),
       dataProviders: [
         buildDataProviderItem({
-          // TODO: Update text!
           provider: NationalRegistryUserApi,
-          title: socialInsuranceAdministrationMessage.pre.skraInformationTitle,
-          subTitle: '',
+          title:
+            medicalAndRehabilitationPaymentsFormMessage.pre
+              .skraInformationTitle,
+          subTitle:
+            medicalAndRehabilitationPaymentsFormMessage.pre
+              .skraInformationDescription,
         }),
         buildDataProviderItem({
-          // TODO: Update text?
           provider: NationalRegistrySpouseApi,
           title: '',
         }),
         buildDataProviderItem({
           provider: UserProfileApi,
-          title: socialInsuranceAdministrationMessage.pre.contactInfoTitle,
+          title:
+            medicalAndRehabilitationPaymentsFormMessage.pre.contactInfoTitle,
           subTitle:
-            socialInsuranceAdministrationMessage.pre.contactInfoDescription,
+            medicalAndRehabilitationPaymentsFormMessage.pre
+              .contactInfoDescription,
         }),
         buildDataProviderItem({
-          provider: SocialInsuranceAdministrationApplicantApi,
           title:
-            socialInsuranceAdministrationMessage.pre
-              .socialInsuranceAdministrationTitle,
+            medicalAndRehabilitationPaymentsFormMessage.pre
+              .healthInstitutionTitle,
           subTitle:
-            socialInsuranceAdministrationMessage.pre
-              .socialInsuranceAdministrationDescription,
+            medicalAndRehabilitationPaymentsFormMessage.pre
+              .healthInstitutionDescription,
+        }),
+        buildDataProviderItem({
+          title:
+            medicalAndRehabilitationPaymentsFormMessage.pre
+              .unionHealthFundTitle,
+          subTitle:
+            medicalAndRehabilitationPaymentsFormMessage.pre
+              .unionHealthFundDescription,
         }),
         buildDataProviderItem({
           id: 'sia.data',
path: libs/application/templates/social-insurance-administration/medical-and-rehabilitation-payments/src/forms/Prerequisites/externalDataSubSection.ts
user: login: birkirkristmunds
body: it was there already and I wasn't looking into this now since I was only working in the texts. But I can remove it. 
created_at: 2025-04-28T13:37:57Z
author_association: MEMBER
diff_hunk: @@ -40,39 +40,50 @@ export const externalDataSubSection = buildSubSection({
       }),
       dataProviders: [
         buildDataProviderItem({
-          // TODO: Update text!
           provider: NationalRegistryUserApi,
-          title: socialInsuranceAdministrationMessage.pre.skraInformationTitle,
-          subTitle: '',
+          title:
+            medicalAndRehabilitationPaymentsFormMessage.pre
+              .skraInformationTitle,
+          subTitle:
+            medicalAndRehabilitationPaymentsFormMessage.pre
+              .skraInformationDescription,
         }),
         buildDataProviderItem({
-          // TODO: Update text?
           provider: NationalRegistrySpouseApi,
           title: '',
         }),
         buildDataProviderItem({
           provider: UserProfileApi,
-          title: socialInsuranceAdministrationMessage.pre.contactInfoTitle,
+          title:
+            medicalAndRehabilitationPaymentsFormMessage.pre.contactInfoTitle,
           subTitle:
-            socialInsuranceAdministrationMessage.pre.contactInfoDescription,
+            medicalAndRehabilitationPaymentsFormMessage.pre
+              .contactInfoDescription,
         }),
path: libs/application/templates/social-insurance-administration/medical-and-rehabilitation-payments/src/forms/Prerequisites/externalDataSubSection.ts
user: login: birkirkristmunds
body: New provider added
created_at: 2025-04-28T13:49:22Z
author_association: MEMBER
diff_hunk: @@ -40,39 +40,50 @@ export const externalDataSubSection = buildSubSection({
       }),
       dataProviders: [
         buildDataProviderItem({
-          // TODO: Update text!
           provider: NationalRegistryUserApi,
-          title: socialInsuranceAdministrationMessage.pre.skraInformationTitle,
-          subTitle: '',
+          title:
+            medicalAndRehabilitationPaymentsFormMessage.pre
+              .skraInformationTitle,
+          subTitle:
+            medicalAndRehabilitationPaymentsFormMessage.pre
+              .skraInformationDescription,
         }),
         buildDataProviderItem({
-          // TODO: Update text?
           provider: NationalRegistrySpouseApi,
           title: '',
         }),
         buildDataProviderItem({
           provider: UserProfileApi,
-          title: socialInsuranceAdministrationMessage.pre.contactInfoTitle,
+          title:
+            medicalAndRehabilitationPaymentsFormMessage.pre.contactInfoTitle,
           subTitle:
-            socialInsuranceAdministrationMessage.pre.contactInfoDescription,
+            medicalAndRehabilitationPaymentsFormMessage.pre
+              .contactInfoDescription,
path: libs/application/templates/social-insurance-administration/medical-and-rehabilitation-payments/src/forms/Prerequisites/externalDataSubSection.ts
user: login: birkirkristmunds
body: changed to core
created_at: 2025-04-28T13:50:43Z
author_association: MEMBER
diff_hunk: @@ -42,6 +42,67 @@ export const medicalAndRehabilitationPaymentsFormMessage: MessageDir = {
 
   pre: defineMessages({
     // Data collection
+    skraInformationTitle: {
+      id: 'marp.application:pre.skra.information.title',
+      defaultMessage: 'Upplýsingar frá Þjóðskrá, RSK og Útlendingarstofnun',
+      description:
+        'Information from National Registry, RSK and Directorate of Immigration',
+    },
+    skraInformationDescription: {
+      id: 'marp.application:pre.skra.information.description',
+      defaultMessage:
+        'Upplýsingar um þig, maka og börn. Upplýsingar um búsetu.',
+      description:
+        'Information about you, spouse and children. Information about residence.',
+    },
+    contactInfoTitle: {
+      id: 'marp.application:pre.contact.info.title',
+      defaultMessage: 'Upplýsingar af mínum síðum Ísland.is',
+      description: 'Information from my pages on Ísland.is',
+    },
+    contactInfoDescription: {
+      id: 'marp.application:pre.contact.info.description',
+      defaultMessage:
+        'Upplýsingar um netfang, símanúmer og bankareikning eru sóttar á mínar síður á Ísland.is.',
+      description:
+        'Information about email, phone number and bank account is retrieved from my pages on Ísland.is.',
+    },
path: libs/application/templates/social-insurance-administration/medical-and-rehabilitation-payments/src/lib/messages.ts
user: login: birkirkristmunds
body: Removed
created_at: 2025-04-28T13:52:23Z
author_association: MEMBER
diff_hunk: @@ -42,6 +42,67 @@ export const medicalAndRehabilitationPaymentsFormMessage: MessageDir = {
 
   pre: defineMessages({
     // Data collection
+    skraInformationTitle: {
+      id: 'marp.application:pre.skra.information.title',
+      defaultMessage: 'Upplýsingar frá Þjóðskrá, RSK og Útlendingarstofnun',
+      description:
+        'Information from National Registry, RSK and Directorate of Immigration',
path: libs/application/templates/social-insurance-administration/medical-and-rehabilitation-payments/src/lib/messages.ts
user: login: birkirkristmunds
body: Description updated
created_at: 2025-04-28T13:53:11Z
author_association: MEMBER
diff_hunk: @@ -40,39 +40,50 @@ export const externalDataSubSection = buildSubSection({
       }),
       dataProviders: [
         buildDataProviderItem({
-          // TODO: Update text!
           provider: NationalRegistryUserApi,
-          title: socialInsuranceAdministrationMessage.pre.skraInformationTitle,
-          subTitle: '',
+          title:
+            medicalAndRehabilitationPaymentsFormMessage.pre
+              .skraInformationTitle,
+          subTitle:
+            medicalAndRehabilitationPaymentsFormMessage.pre
+              .skraInformationDescription,
         }),
         buildDataProviderItem({
-          // TODO: Update text?
           provider: NationalRegistrySpouseApi,
           title: '',
path: libs/application/templates/social-insurance-administration/medical-and-rehabilitation-payments/src/forms/Prerequisites/externalDataSubSection.ts
user: login: birkirkristmunds
body: title removed
created_at: 2025-04-28T13:54:02Z
author_association: MEMBER
diff_hunk: @@ -40,39 +40,50 @@ export const externalDataSubSection = buildSubSection({
       }),
       dataProviders: [
         buildDataProviderItem({
-          // TODO: Update text!
           provider: NationalRegistryUserApi,
-          title: socialInsuranceAdministrationMessage.pre.skraInformationTitle,
-          subTitle: '',
+          title:
+            medicalAndRehabilitationPaymentsFormMessage.pre
+              .skraInformationTitle,
+          subTitle:
+            medicalAndRehabilitationPaymentsFormMessage.pre
+              .skraInformationDescription,
         }),
         buildDataProviderItem({
-          // TODO: Update text?
           provider: NationalRegistrySpouseApi,
           title: '',
         }),
         buildDataProviderItem({
           provider: UserProfileApi,
-          title: socialInsuranceAdministrationMessage.pre.contactInfoTitle,
+          title:
+            medicalAndRehabilitationPaymentsFormMessage.pre.contactInfoTitle,
path: libs/application/templates/social-insurance-administration/medical-and-rehabilitation-payments/src/forms/Prerequisites/externalDataSubSection.ts
user: login: birkirkristmunds
body: Used core msg
created_at: 2025-04-28T14:19:19Z
author_association: MEMBER
diff_hunk: @@ -42,6 +42,67 @@ export const medicalAndRehabilitationPaymentsFormMessage: MessageDir = {
 
   pre: defineMessages({
     // Data collection
+    skraInformationTitle: {
+      id: 'marp.application:pre.skra.information.title',
+      defaultMessage: 'Upplýsingar frá Þjóðskrá, RSK og Útlendingarstofnun',
+      description:
+        'Information from National Registry, RSK and Directorate of Immigration',
+    },
+    skraInformationDescription: {
+      id: 'marp.application:pre.skra.information.description',
+      defaultMessage:
+        'Upplýsingar um þig, maka og börn. Upplýsingar um búsetu.',
+      description:
+        'Information about you, spouse and children. Information about residence.',
+    },
+    contactInfoTitle: {
+      id: 'marp.application:pre.contact.info.title',
+      defaultMessage: 'Upplýsingar af mínum síðum Ísland.is',
+      description: 'Information from my pages on Ísland.is',
+    },
path: libs/application/templates/social-insurance-administration/medical-and-rehabilitation-payments/src/lib/messages.ts
user: login: birkirkristmunds
body: contactInfoTitle removed
created_at: 2025-04-28T14:20:17Z
author_association: MEMBER
diff_hunk: @@ -43,9 +43,10 @@ export const socialInsuranceAdministrationMessage: MessageDir = {
     },
     checkboxProvider: {
       id: 'sia.application:prerequisites.checkbox.provider',
-      defaultMessage: 'Ég samþykki gagnaöflun í umsóknarferlinu',
+      defaultMessage:
+        'Ég skil að ofangreindra upplýsinga verður aflað í umsóknarferlinu',
       description:
-        'I agree to the collection of data as a part of the application process',
+        'I understand that the above information will be obtained in the application process',
path: libs/application/templates/social-insurance-administration/core/src/lib/messages.ts
user: login: birkirkristmunds
body: description changed
created_at: 2025-04-28T14:23:22Z
author_association: MEMBER

PR comments:
user: login: coderabbitai[bot]
created_at: 2025-04-25T09:41:06Z
body: <!-- This is an auto-generated comment: summarize by coderabbit.ai -->
<!-- This is an auto-generated comment: skip review by coderabbit.ai -->

> [!IMPORTANT]
> ## Review skipped
> 
> Auto reviews are disabled on base/target branches other than the default branch.
> 
> <details>
> <summary>🗂️ Base branches to auto review (1)</summary>
> 
> * main
> 
> </details>
> 
> Please check the settings in the CodeRabbit UI or the `.coderabbit.yaml` file in this repository. To trigger a single review, invoke the `@coderabbitai review` command.
> 
> You can disable this status message by setting the `reviews.review_status` to `false` in the CodeRabbit configuration file.

<!-- end of auto-generated comment: skip review by coderabbit.ai -->
<!-- tips_start -->

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

<details>
<summary>❤️ Share</summary>

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai)
- [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai)
- [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai)
- [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

</details>

<details>
<summary>🪧 Tips</summary>

### Chat

There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai?utm_source=oss&utm_medium=github&utm_campaign=island-is/island.is&utm_content=18864):

- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  - `I pushed a fix in commit <commit_id>, please review it.`
  - `Generate unit testing code for this file.`
  - `Open a follow-up GitHub issue for this discussion.`
- Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples:
  - `@coderabbitai generate unit testing code for this file.`
  -	`@coderabbitai modularize this function.`
- PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.`
  - `@coderabbitai read src/utils.ts and generate unit testing code.`
  - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.`
  - `@coderabbitai help me debug CodeRabbit configuration file.`

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

### CodeRabbit Commands (Invoked using PR comments)

- `@coderabbitai pause` to pause the reviews on a PR.
- `@coderabbitai resume` to resume the paused reviews.
- `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
- `@coderabbitai full review` to do a full review from scratch and review all the files again.
- `@coderabbitai summary` to regenerate the summary of the PR.
- `@coderabbitai generate docstrings` to [generate docstrings](https://docs.coderabbit.ai/finishing-touches/docstrings) for this PR.
- `@coderabbitai generate sequence diagram` to generate a sequence diagram of the changes in this PR.
- `@coderabbitai resolve` resolve all the CodeRabbit review comments.
- `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository.
- `@coderabbitai help` to get help.

### Other keywords and placeholders

- Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed.
- Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description.
- Add `@coderabbitai` anywhere in the PR title to generate the title automatically.

### Documentation and Community

- Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit.
- Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback.
- Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

</details>

<!-- tips_end -->
author_association: CONTRIBUTOR
user: login: nx-cloud[bot]
created_at: 2025-04-25T09:43:45Z
body: 
View your [CI Pipeline Execution ↗](https://cloud.nx.app/cipes/6810b13ce0012135d3823a3e?utm_source=pull-request&utm_medium=comment) for commit be5e8b5d7bde53fffc1e063e0c2470dcd0ea5e18.

| Command | Status | Duration | Result |
|---------|--------|----------:|--------|
| `nx run-many --projects application-system-api -...` | ✅ Succeeded | 9m 13s | [View ↗](https://cloud.nx.app/runs/mUQAgBbLbg?utm_source=pull-request&utm_medium=comment) |
| `nx run-many --projects application-system-form,...` | ✅ Succeeded | 7m 1s | [View ↗](https://cloud.nx.app/runs/gwUQYW260r?utm_source=pull-request&utm_medium=comment) |
| `nx run-many --target=build --projects=api --par...` | ✅ Succeeded | 3m 36s | [View ↗](https://cloud.nx.app/runs/KgcFzpymHC?utm_source=pull-request&utm_medium=comment) |
| `nx run-many --target=build --projects=applicati...` | ✅ Succeeded | 2m 26s | [View ↗](https://cloud.nx.app/runs/SxcgZsXVQH?utm_source=pull-request&utm_medium=comment) |
| `nx run-many --target=build --projects=applicati...` | ✅ Succeeded | 1m 42s | [View ↗](https://cloud.nx.app/runs/KGq35L8U75?utm_source=pull-request&utm_medium=comment) |
| `nx run-many -t lint --output-style=static --pro...` | ✅ Succeeded | <1s | [View ↗](https://cloud.nx.app/runs/cwl7dbJYNA?utm_source=pull-request&utm_medium=comment) |
| `nx run-many --projects api,api-domains-applicat...` | ✅ Succeeded | 9s | [View ↗](https://cloud.nx.app/runs/UYNFWhKbVb?utm_source=pull-request&utm_medium=comment) |
| `nx run-many --target=build --projects=system-e2...` | ✅ Succeeded | 5s | [View ↗](https://cloud.nx.app/runs/PTpE2gpX7d?utm_source=pull-request&utm_medium=comment) |
| `Additional runs (3)` | ✅ Succeeded | ... | [View ↗](https://cloud.nx.app/cipes/6810b13ce0012135d3823a3e?utm_source=pull-request&utm_medium=comment) |

---

☁️ [Nx Cloud](https://cloud.nx.app?utm_source=pull-request&utm_medium=comment) last updated this comment at `2025-04-29 11:16:57` UTC

<!-- NX_CLOUD_APP_COMMENT_END -->
author_association: NONE
user: login: datadog-island-is[bot]
created_at: 2025-04-25T09:54:35Z
body: 
# Datadog Report

All test runs `5b91476` [:link:](https://app.datadoghq.eu/ci/test-runs?query=%40git.repository.id_v2%3A%22github.com%2Fisland-is%2Fisland.is%22+%40git.commit.sha%3A5b91476ec34943c602b22513e5c368c65f87d23f+%40git.branch%3A%22feat%2Fmarp-prerequisites-providers-text%22&_user_click_origin_=github)

:white_check_mark: **5 Total Test Services**: 0 Failed, 5 Passed



<details>
<summary>Test Services</summary>

| Service Name | Failed | Known Flaky | New Flaky | Passed | Skipped | Total Time | Test Service View |
| ------------ | ------ | ----------- | --------- | ------ | ------- | --------- | ----------------- |
| [**`api`**](https://app.datadoghq.eu/ci/test-commit/github.com%2Fisland-is%2Fisland.is/api/feat%2Fmarp-prerequisites-providers-text/5b91476ec34943c602b22513e5c368c65f87d23f?env=ci&index=citest&_user_click_origin_=github) | 0 | 0 | 0 | 4 | 0 | 5.25s |  [Link](https://app.datadoghq.eu/ci/test-branch/github.com%2Fisland-is%2Fisland.is/api/feat%2Fmarp-prerequisites-providers-text?env=ci&index=citest&_user_click_origin_=github) |
| [**`application-system-api`**](https://app.datadoghq.eu/ci/test-commit/github.com%2Fisland-is%2Fisland.is/application-system-api/feat%2Fmarp-prerequisites-providers-text/5b91476ec34943c602b22513e5c368c65f87d23f?env=ci&index=citest&_user_click_origin_=github) | 0 | 0 | 0 | 46 | 0 | 12m 57.42s |  [Link](https://app.datadoghq.eu/ci/test-branch/github.com%2Fisland-is%2Fisland.is/application-system-api/feat%2Fmarp-prerequisites-providers-text?env=ci&index=citest&_user_click_origin_=github) |
| [**`application-template-api-modules`**](https://app.datadoghq.eu/ci/test-commit/github.com%2Fisland-is%2Fisland.is/application-template-api-modules/feat%2Fmarp-prerequisites-providers-text/5b91476ec34943c602b22513e5c368c65f87d23f?env=ci&index=citest&_user_click_origin_=github) | 0 | 0 | 0 | 30 | 0 | 5m 28.15s |  [Link](https://app.datadoghq.eu/ci/test-branch/github.com%2Fisland-is%2Fisland.is/application-template-api-modules/feat%2Fmarp-prerequisites-providers-text?env=ci&index=citest&_user_click_origin_=github) |
| [**`application-templates-parental-leave`**](https://app.datadoghq.eu/ci/test-commit/github.com%2Fisland-is%2Fisland.is/application-templates-parental-leave/feat%2Fmarp-prerequisites-providers-text/5b91476ec34943c602b22513e5c368c65f87d23f?env=ci&index=citest&_user_click_origin_=github) | 0 | 0 | 0 | 163 | 0 | 15.96s |  [Link](https://app.datadoghq.eu/ci/test-branch/github.com%2Fisland-is%2Fisland.is/application-templates-parental-leave/feat%2Fmarp-prerequisites-providers-text?env=ci&index=citest&_user_click_origin_=github) |
| [**`application-ui-shell`**](https://app.datadoghq.eu/ci/test-commit/github.com%2Fisland-is%2Fisland.is/application-ui-shell/feat%2Fmarp-prerequisites-providers-text/5b91476ec34943c602b22513e5c368c65f87d23f?env=ci&index=citest&_user_click_origin_=github) | 0 | 0 | 0 | 74 | 0 | 1m 15.66s |  [Link](https://app.datadoghq.eu/ci/test-branch/github.com%2Fisland-is%2Fisland.is/application-ui-shell/feat%2Fmarp-prerequisites-providers-text?env=ci&index=citest&_user_click_origin_=github) |
</details>



author_association: NONE