Repository: apache/airflow
Pull request #48514: Disable slack and aws configure action
Author: login: gopidesupavan
Labels: name: area:dev-tools
Created: 2025-03-28T21:43:04Z | Merged: 2025-03-28T22:44:00Z

```
slackapi/slack-github-action@485a9d42d3a73031f12ec201c457e2162c45d02d and aws-actions/configure-aws-credentials@010d0da01d0b5a38af31e9c3470dbfdabdecca3a are not allowed to be used in apache/airflow. Actions in this workflow must be: within a repository that belongs to your Enterprise account, created by GitHub, or matching the following: */*@[a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9]+, 1Password/load-secrets-action@*, AdoptOpenJDK/install-jdk@*, Ana06/get-changed-files@*, BobAnkh/auto-generate-changelog@v1*, DavidAnson/markdownlint-cli2-action@v16, EnricoMi/publish-unit-test-result-action@*, JamesIves/github-pages-deploy-action@v4.6.8, JustinBeckwith/linkinator-action@v1.10.4, JustinBeckwith/linkinator-action@v1.11.0, Kesin11/actions-timeline@427ee2cf860166e404d0d69b4f2b24012bb7af4f, Madrapps/jacoco-report@fd4800e8a81e21bdf373438e5918b975df041d15, PyO3/maturin-action@*, TobKed/label-when-approved-action@*, VirtusLab/scala-cli-setup@2203916b75d15293db29f4bcbd7ff082a27fe...j
```

We need these two actions to be updated in approved patterns at [ infra-actios repo](https://github.com/apache/infrastructure-actions)

<!--
 Licensed to the Apache Software Foundation (ASF) under one
 or more contributor license agreements.  See the NOTICE file
 distributed with this work for additional information
 regarding copyright ownership.  The ASF licenses this file
 to you under the Apache License, Version 2.0 (the
 "License"); you may not use this file except in compliance
 with the License.  You may obtain a copy of the License at

   http://www.apache.org/licenses/LICENSE-2.0

 Unless required by applicable law or agreed to in writing,
 software distributed under the License is distributed on an
 "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
 KIND, either express or implied.  See the License for the
 specific language governing permissions and limitations
 under the License.
 -->

<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.

Feel free to ping committers for the review!

In case of an existing issue, reference it using one of the following:

closes: #ISSUE
related: #ISSUE

How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->



<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).



Diff:
diff --git a/.github/workflows/ci-image-checks.yml b/.github/workflows/ci-image-checks.yml
index 6da5edc7b5014..7847f59e7f322 100644
--- a/.github/workflows/ci-image-checks.yml
+++ b/.github/workflows/ci-image-checks.yml
@@ -377,14 +377,15 @@ jobs:
           rm /tmp/awscliv2.zip
           sudo /tmp/aws/install --update
           rm -rf /tmp/aws/
-      - name: Configure AWS credentials
-        uses: aws-actions/configure-aws-credentials@010d0da01d0b5a38af31e9c3470dbfdabdecca3a  # v4.0.1
-        with:
-          aws-access-key-id: ${{ secrets.DOCS_AWS_ACCESS_KEY_ID }}
-          aws-secret-access-key: ${{ secrets.DOCS_AWS_SECRET_ACCESS_KEY }}
-          aws-region: eu-central-1
-      - name: "Upload documentation to AWS S3"
-        run: aws s3 sync --delete ./docs/_build s3://apache-airflow-docs
+  # disabled until we have added this to approved actions
+  #      - name: Configure AWS credentials
+  #        uses: aws-actions/configure-aws-credentials@010d0da01d0b5a38af31e9c3470dbfdabdecca3a  # v4.0.1
+  #        with:
+  #          aws-access-key-id: ${{ secrets.DOCS_AWS_ACCESS_KEY_ID }}
+  #          aws-secret-access-key: ${{ secrets.DOCS_AWS_SECRET_ACCESS_KEY }}
+  #          aws-region: eu-central-1
+  #      - name: "Upload documentation to AWS S3"
+  #        run: aws s3 sync --delete ./docs/_build s3://apache-airflow-docs
 
   test-python-api-client:
     timeout-minutes: 60
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 494b47afceef0..254df4b04c116 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -636,35 +636,36 @@ jobs:
       use-uv: ${{ needs.build-info.outputs.use-uv }}
       debug-resources: ${{ needs.build-info.outputs.debug-resources }}
 
-  notify-slack-failure:
-    name: "Notify Slack on Failure"
-    needs:
-      - basic-tests
-      - additional-ci-image-checks
-      - providers
-      - tests-helm
-      - tests-special
-      - tests-with-lowest-direct-resolution
-      - additional-prod-image-tests
-      - tests-kubernetes
-      - tests-task-sdk
-      - finalize-tests
-    if: github.event_name == 'schedule' && failure() && github.run_attempt == 1
-    runs-on: ["ubuntu-22.04"]
-    steps:
-      - name: Notify Slack
-        id: slack
-        uses: slackapi/slack-github-action@485a9d42d3a73031f12ec201c457e2162c45d02d  # v2.0.0
-        with:
-          method: chat.postMessage
-          token: ${{ env.SLACK_BOT_TOKEN }}
-          # yamllint disable rule:line-length
-          payload: |
-            channel: "internal-airflow-ci-cd"
-            text: "🚨🕒 Scheduled CI Failure Alert 🕒🚨\n\n*Details:* <https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}|View the failure log>"
-            blocks:
-              - type: "section"
-                text:
-                  type: "mrkdwn"
-                  text: "🚨🕒 Scheduled CI Failure Alert 🕒🚨\n\n*Details:* <https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}|View the failure log>"
-          # yamllint enable rule:line-length
+# disabled for now until slack action added to approved patterns
+#  notify-slack-failure:
+#    name: "Notify Slack on Failure"
+#    needs:
+#      - basic-tests
+#      - additional-ci-image-checks
+#      - providers
+#      - tests-helm
+#      - tests-special
+#      - tests-with-lowest-direct-resolution
+#      - additional-prod-image-tests
+#      - tests-kubernetes
+#      - tests-task-sdk
+#      - finalize-tests
+#    if: github.event_name == 'schedule' && failure() && github.run_attempt == 1
+#    runs-on: ["ubuntu-22.04"]
+#    steps:
+#      - name: Notify Slack
+#        id: slack
+#        uses: slackapi/slack-github-action@485a9d42d3a73031f12ec201c457e2162c45d02d  # v2.0.0
+#        with:
+#          method: chat.postMessage
+#          token: ${{ env.SLACK_BOT_TOKEN }}
+#          # yamllint disable rule:line-length
+#          payload: |
+#            channel: "internal-airflow-ci-cd"
+#            text: "🚨🕒 Scheduled CI Failure Alert 🕒🚨\n\n*Details:* <https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}|View the failure log>"
+#            blocks:
+#              - type: "section"
+#                text:
+#                  type: "mrkdwn"
+#                  text: "🚨🕒 Scheduled CI Failure Alert 🕒🚨\n\n*Details:* <https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}|View the failure log>"
+#          # yamllint enable rule:line-length


Reviews:
user: login: jedcunningham
state: COMMENTED
author_association: MEMBER
submitted_at: 2025-03-28T22:00:21Z
user: login: gopidesupavan
state: COMMENTED
author_association: MEMBER
submitted_at: 2025-03-28T22:09:08Z
user: login: gopidesupavan
state: COMMENTED
author_association: MEMBER
submitted_at: 2025-03-28T22:11:35Z
user: login: potiuk
state: APPROVED
author_association: MEMBER
submitted_at: 2025-03-28T22:11:56Z

Review comments:
path: .github/workflows/sample.yml
user: login: jedcunningham
body: Did you mean to add this?
created_at: 2025-03-28T22:00:15Z
author_association: MEMBER
path: .github/workflows/sample.yml
user: login: gopidesupavan
body: oops

created_at: 2025-03-28T22:09:08Z
author_association: MEMBER
path: .github/workflows/sample.yml
user: login: gopidesupavan
body: thanks updated :)
created_at: 2025-03-28T22:11:35Z
author_association: MEMBER

PR comments:
user: login: gopidesupavan
created_at: 2025-03-28T21:43:44Z
body: As a temporary to run tests..
author_association: MEMBER
user: login: gopidesupavan
created_at: 2025-03-28T22:43:53Z
body: Going to merge this, will check once the added actions are active.
author_association: MEMBER