Repository: appwrite/console
Pull request #1854: Fix success message in domain verification modals
Author: login: TorstenDittmann
Created: 2025-05-18T20:53:58Z | Merged: 2025-05-18T21:03:29Z

<!--
Thank you for sending the PR! We appreciate you spending the time to work on these changes.

Help us understand your motivation by explaining why you decided to make this change.

You can learn more about contributing to appwrite here: https://github.com/appwrite/appwrite/blob/master/CONTRIBUTING.md

Happy contributing!

-->

## What does this PR do?

(Provide a description of what this PR does.)

## Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)

## Related PRs and Issues

(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)

### Have you read the [Contributing Guidelines on issues](https://github.com/appwrite/appwrite/blob/master/CONTRIBUTING.md)?

(Write your answer here.)


Diff:
diff --git a/src/hooks.client.ts b/src/hooks.client.ts
index 8f67377efa..8802bcaad1 100644
--- a/src/hooks.client.ts
+++ b/src/hooks.client.ts
@@ -1,27 +1,25 @@
-import * as Sentry from '@sentry/sveltekit';
+// import * as Sentry from '@sentry/sveltekit';
+// import { isCloud, isProd } from '$lib/system';
 import { AppwriteException } from '@appwrite.io/console';
 import type { HandleClientError } from '@sveltejs/kit';
-import { isCloud, isProd } from '$lib/system';
 
-Sentry.init({
-    enabled: isCloud && isProd,
-    dsn: 'https://c7ce178bdedd486480317b72f282fd39@o1063647.ingest.us.sentry.io/4504158071422976',
-    tracesSampleRate: 1,
-    replaysSessionSampleRate: 0,
-    replaysOnErrorSampleRate: 0
-});
+// Sentry.init({
+//     enabled: isCloud && isProd,
+//     dsn: 'https://c7ce178bdedd486480317b72f282fd39@o1063647.ingest.us.sentry.io/4504158071422976',
+//     tracesSampleRate: 1,
+//     replaysSessionSampleRate: 0,
+//     replaysOnErrorSampleRate: 0
+// });
 
-export const handleError: HandleClientError = Sentry.handleErrorWithSentry(
-    async ({ error, message, status }) => {
-        console.error(error);
-        if (error instanceof AppwriteException) {
-            status = error.code === 0 ? undefined : error.code;
-            message = error.message;
-        }
-
-        return {
-            message,
-            status
-        };
+export const handleError: HandleClientError = ({ error, message, status }) => {
+    console.error(error);
+    if (error instanceof AppwriteException) {
+        status = error.code === 0 ? undefined : error.code;
+        message = error.message;
     }
-);
+
+    return {
+        message,
+        status
+    };
+};
diff --git a/src/hooks.server.ts b/src/hooks.server.ts
index e54c183dbb..3deb889221 100644
--- a/src/hooks.server.ts
+++ b/src/hooks.server.ts
@@ -1,14 +1,14 @@
-import { sequence } from '@sveltejs/kit/hooks';
-import { handleErrorWithSentry, sentryHandle } from '@sentry/sveltekit';
-import * as Sentry from '@sentry/sveltekit';
-import { isCloud, isProd } from '$lib/system';
+// import { sequence } from '@sveltejs/kit/hooks';
+// import { handleErrorWithSentry, sentryHandle } from '@sentry/sveltekit';
+// import * as Sentry from '@sentry/sveltekit';
+// import { isCloud, isProd } from '$lib/system';
 
-Sentry.init({
-    enabled: isCloud && isProd,
-    dsn: 'https://c7ce178bdedd486480317b72f282fd39@o1063647.ingest.us.sentry.io/4504158071422976',
-    tracesSampleRate: 1.0
-});
+// Sentry.init({
+//     enabled: isCloud && isProd,
+//     dsn: 'https://c7ce178bdedd486480317b72f282fd39@o1063647.ingest.us.sentry.io/4504158071422976',
+//     tracesSampleRate: 1.0
+// });
 
-export const handle = sequence(sentryHandle());
+// export const handle = sequence(sentryHandle());
 
-export const handleError = handleErrorWithSentry();
+// export const handleError = handleErrorWithSentry();
diff --git a/src/lib/components/domains/recordTable.svelte b/src/lib/components/domains/recordTable.svelte
index 385a89cfab..c2254fb016 100644
--- a/src/lib/components/domains/recordTable.svelte
+++ b/src/lib/components/domains/recordTable.svelte
@@ -1,13 +1,11 @@
 <script lang="ts">
     import { Link } from '$lib/elements';
     import { consoleVariables } from '$routes/(console)/store';
-    import { IconInfo } from '@appwrite.io/pink-icons-svelte';
     import {
         Badge,
         Layout,
         Typography,
         Table,
-        Icon,
         InteractiveText,
         Alert
     } from '@appwrite.io/pink-svelte';
@@ -69,7 +67,6 @@
         </Table.Row.Base>
     </Table.Root>
     <Layout.Stack gap="s" direction="row" alignItems="center">
-        <Icon icon={IconInfo} size="s" color="--fgcolor-neutral-secondary" />
         {#if variant === 'cname'}
             <Alert.Inline>
                 If your domain uses CAA records, ensure certainly.com is authorized — otherwise, SSL
diff --git a/src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/recordsCard.svelte b/src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/recordsCard.svelte
index 87d83f1451..9559a74d3a 100644
--- a/src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/recordsCard.svelte
+++ b/src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/recordsCard.svelte
@@ -1,10 +1,18 @@
 <script lang="ts">
-    import { Copy } from '$lib/components';
     import { Link } from '$lib/elements';
     import type { Domain } from '$lib/sdk/domains';
     import { IconInfo } from '@appwrite.io/pink-icons-svelte';
-    import { Badge, Layout, Typography, Table, Fieldset, Icon } from '@appwrite.io/pink-svelte';
+    import {
+        Badge,
+        Layout,
+        Typography,
+        Table,
+        Fieldset,
+        Icon,
+        InteractiveText
+    } from '@appwrite.io/pink-svelte';
     import type { Models } from '@appwrite.io/console';
+    import { consoleVariables } from '$routes/(console)/store';
 
     export let domain: Domain | Models.ProxyRule;
 </script>
@@ -33,8 +41,10 @@
                     <Table.Cell {root}>CNAME</Table.Cell>
                     <Table.Cell {root}>{domain?.domain}</Table.Cell>
                     <Table.Cell {root}>
-                        <Copy value={globalThis?.location?.origin}
-                            >{globalThis?.location?.origin}</Copy>
+                        <InteractiveText
+                            variant="copy"
+                            isVisible
+                            text={$consoleVariables._APP_DOMAIN_TARGET_CNAME} />
                     </Table.Cell>
                 </Table.Row.Base>
             </Table.Root>
diff --git a/src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/retryDomainModal.svelte b/src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/retryDomainModal.svelte
index 42f967ede3..44eab42f47 100644
--- a/src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/retryDomainModal.svelte
+++ b/src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/retryDomainModal.svelte
@@ -24,12 +24,12 @@
             show = false;
             addNotification({
                 type: 'success',
-                message: `${selectedDomain.domain} has been deleted`
+                message: `${selectedDomain.domain} has been verified`
             });
-            trackEvent(Submit.DomainDelete);
+            trackEvent(Submit.DomainUpdateVerification);
         } catch (e) {
             error = e;
-            trackError(e, Submit.DomainDelete);
+            trackError(e, Submit.DomainUpdateVerification);
         }
     }
 
diff --git a/src/routes/(console)/project-[region]-[project]/settings/domains/retryDomainModal.svelte b/src/routes/(console)/project-[region]-[project]/settings/domains/retryDomainModal.svelte
index a97fe7fab9..d0bf3861b5 100644
--- a/src/routes/(console)/project-[region]-[project]/settings/domains/retryDomainModal.svelte
+++ b/src/routes/(console)/project-[region]-[project]/settings/domains/retryDomainModal.svelte
@@ -28,12 +28,12 @@
             show = false;
             addNotification({
                 type: 'success',
-                message: `${selectedDomain.domain} has been deleted`
+                message: `${selectedDomain.domain} has been verified`
             });
-            trackEvent(Submit.DomainDelete);
+            trackEvent(Submit.DomainUpdateVerification);
         } catch (e) {
             error = e;
-            trackError(e, Submit.DomainDelete);
+            trackError(e, Submit.DomainUpdateVerification);
         }
     }
 
diff --git a/src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/retryDomainModal.svelte b/src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/retryDomainModal.svelte
index 36e75c465f..e07402b8ec 100644
--- a/src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/retryDomainModal.svelte
+++ b/src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/retryDomainModal.svelte
@@ -50,12 +50,12 @@
             show = false;
             addNotification({
                 type: 'success',
-                message: `${selectedDomain.domain} has been deleted`
+                message: `${selectedDomain.domain} has been verified`
             });
-            trackEvent(Submit.DomainDelete);
+            trackEvent(Submit.DomainUpdateVerification);
         } catch (e) {
             error = e;
-            trackError(e, Submit.DomainDelete);
+            trackError(e, Submit.DomainUpdateVerification);
         }
     }
 


Reviews:
user: login: christyjacob4
state: COMMENTED
author_association: CONTRIBUTOR
submitted_at: 2025-05-18T20:55:36Z
user: login: christyjacob4
state: COMMENTED
author_association: CONTRIBUTOR
submitted_at: 2025-05-18T20:55:45Z
user: login: christyjacob4
state: COMMENTED
author_association: CONTRIBUTOR
submitted_at: 2025-05-18T20:55:59Z
user: login: christyjacob4
state: APPROVED
author_association: CONTRIBUTOR
submitted_at: 2025-05-18T21:00:49Z

Review comments:
diff_hunk: @@ -24,7 +24,7 @@
             show = false;
             addNotification({
                 type: 'success',
-                message: `${selectedDomain.domain} has been deleted`
+                message: `${selectedDomain.domain} has been verified`
             });
             trackEvent(Submit.DomainDelete);
path: src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/retryDomainModal.svelte
user: login: christyjacob4
body: event is wrong
created_at: 2025-05-18T20:55:36Z
author_association: CONTRIBUTOR
diff_hunk: @@ -28,7 +28,7 @@
             show = false;
             addNotification({
                 type: 'success',
-                message: `${selectedDomain.domain} has been deleted`
+                message: `${selectedDomain.domain} has been verified`
path: src/routes/(console)/project-[region]-[project]/settings/domains/retryDomainModal.svelte
user: login: christyjacob4
body: same here submitted event is wrong

created_at: 2025-05-18T20:55:45Z
author_association: CONTRIBUTOR
diff_hunk: @@ -50,7 +50,7 @@
             show = false;
             addNotification({
                 type: 'success',
-                message: `${selectedDomain.domain} has been deleted`
+                message: `${selectedDomain.domain} has been verified`
             });
             trackEvent(Submit.DomainDelete);
path: src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/retryDomainModal.svelte
user: login: christyjacob4
body: same here
created_at: 2025-05-18T20:55:59Z
author_association: CONTRIBUTOR

PR comments: