Repository: DeltaV-Station/Delta-v
Pull request #3452: New animated techfab sprite layers
Author: login: SubspaceEmber
Labels: name: Changes: YML
description: Changes any yml files
name: S: Needs Review
description: Awaiting review from a Maintainer
name: size/M
description: 64-255 lines
name: Changes: Sprite
description: Changes any png or json in an rsi
Created: 2025-04-14T03:17:57Z | Merged: 2025-04-17T03:19:45Z

<!-- If you are new to the Delta-V repository, please read the [Contributing Guidelines](https://github.com/DeltaV-Station/Delta-v/blob/master/CONTRIBUTING.md) -->

## About the PR
Created new animated sprite layers for the departmental techfabs and edited associated JSON and YML

## Why / Balance
Requested task on the github (also it annoyed me)

## Technical details
Edited JSON files for the techfab in both techfabs.rsi (in _DV and in the root prototypes folder)
Edited lathe.yml, also in both _DV and in prototypes, since the depart lathes are across both (not exactly sure why)
Created unlit-building and building sprites in both .rsi

## Media
![image](https://github.com/user-attachments/assets/62863922-d31e-4e12-97e2-0fc8097d3f85)
![techfab](https://github.com/user-attachments/assets/e9ad95fa-4aa1-4495-8c87-822d3cc9f31b)


## Requirements
<!-- Confirm the following by placing an X in the brackets [X]: -->
- [ X] I have tested all added content and changes.
- [ X] I have added media to this PR or it does not require an ingame showcase.
<!-- You should understand that not following the above may get your PR closed at maintainer’s discretion -->

## Breaking changes
<!-- List any breaking changes, including namespaces, public class/method/field changes, prototype renames; and provide instructions for fixing them. -->

**Changelog**
:cl:
- tweak: Added animated sprites for departmental techfabs


Diff:
diff --git a/Resources/Prototypes/Entities/Structures/Machines/lathe.yml b/Resources/Prototypes/Entities/Structures/Machines/lathe.yml
index a5034fb33324..d4bbc790301b 100644
--- a/Resources/Prototypes/Entities/Structures/Machines/lathe.yml
+++ b/Resources/Prototypes/Entities/Structures/Machines/lathe.yml
@@ -407,6 +407,8 @@
   - type: Lathe
     idleState: icon
     runningState: icon
+    unlitIdleState: unlit # DeltaV - added animation sprite layers
+    unlitRunningState: unlit-building # DeltaV - added animation sprite layers
     staticPacks:
     - SecurityEquipmentStatic
     - SecurityPracticeStatic
@@ -454,6 +456,8 @@
     - type: Lathe
       idleState: icon
       runningState: icon
+      unlitIdleState: unlit # DeltaV - added animation sprite layers
+      unlitRunningState: unlit-building # DeltaV - added animation sprite layers
       staticPacks:
       - SecurityAmmoStatic
     - type: MaterialStorage
@@ -485,6 +489,8 @@
   - type: Lathe
     idleState: icon
     runningState: icon
+    unlitIdleState: unlit # DeltaV - added animation sprite layers
+    unlitRunningState: unlit-building # DeltaV - added animation sprite layers
     staticPacks:
     - TopicalsStatic
     - ChemistryStatic
diff --git a/Resources/Prototypes/_DV/Entities/Structures/Machines/lathe.yml b/Resources/Prototypes/_DV/Entities/Structures/Machines/lathe.yml
index 84129e8af4c5..bd69c7e45f5b 100644
--- a/Resources/Prototypes/_DV/Entities/Structures/Machines/lathe.yml
+++ b/Resources/Prototypes/_DV/Entities/Structures/Machines/lathe.yml
@@ -22,6 +22,8 @@
   - type: Lathe
     idleState: icon
     runningState: icon
+    unlitIdleState: unlit
+    unlitRunningState: unlit-building
   - type: EmagLatheRecipes
     emagStaticPacks:
     - SecurityAmmoStatic
diff --git a/Resources/Textures/Structures/Machines/techfab.rsi/building.png b/Resources/Textures/Structures/Machines/techfab.rsi/building.png
new file mode 100644
index 000000000000..f4771e340e26
Binary files /dev/null and b/Resources/Textures/Structures/Machines/techfab.rsi/building.png differ
diff --git a/Resources/Textures/Structures/Machines/techfab.rsi/meta.json b/Resources/Textures/Structures/Machines/techfab.rsi/meta.json
index 7530b9322a27..4ea22cdac56e 100644
--- a/Resources/Textures/Structures/Machines/techfab.rsi/meta.json
+++ b/Resources/Textures/Structures/Machines/techfab.rsi/meta.json
@@ -1,7 +1,7 @@
 {
   "version": 1,
   "license": "CC-BY-SA-3.0",
-  "copyright": "made by EmoGarbage, ammo state made by AjexRose and modified by Emo garbage",
+  "copyright": "made by EmoGarbage, ammo state made by AjexRose and modified by Emo garbage | Additional building and unlit building animations by SubspaceEmber",
   "size": {
     "x": 32,
     "y": 32
@@ -37,6 +37,48 @@
     {
       "name": "unlit"
     },
+    {
+      "name": "building",
+      "delays": [
+        [
+          0.1,
+          0.1,
+          0.1,
+          0.1,
+          0.1,
+          0.1,
+          0.1,
+          0.1,
+          0.1,
+          0.1,
+          0.1,
+          0.1,
+          0.1,
+          0.1
+        ]
+      ]
+    },
+    {
+      "name": "unlit-building",
+        "delays": [
+         [
+           0.1,
+           0.1,
+           0.1,
+           0.1,
+           0.1,
+           0.1,
+           0.1,
+           0.1,
+           0.1,
+           0.1,
+           0.1,
+           0.1,
+           0.1,
+           0.1
+         ]
+      ]
+    },
     {
       "name": "inserting",
       "delays": [
diff --git a/Resources/Textures/Structures/Machines/techfab.rsi/unlit-building.png b/Resources/Textures/Structures/Machines/techfab.rsi/unlit-building.png
new file mode 100644
index 000000000000..9f72550a7a67
Binary files /dev/null and b/Resources/Textures/Structures/Machines/techfab.rsi/unlit-building.png differ
diff --git a/Resources/Textures/_DV/Structures/Machines/techfab.rsi/building.png b/Resources/Textures/_DV/Structures/Machines/techfab.rsi/building.png
new file mode 100644
index 000000000000..f4771e340e26
Binary files /dev/null and b/Resources/Textures/_DV/Structures/Machines/techfab.rsi/building.png differ
diff --git a/Resources/Textures/_DV/Structures/Machines/techfab.rsi/meta.json b/Resources/Textures/_DV/Structures/Machines/techfab.rsi/meta.json
index 1a93f8858abc..7c71e99435ea 100644
--- a/Resources/Textures/_DV/Structures/Machines/techfab.rsi/meta.json
+++ b/Resources/Textures/_DV/Structures/Machines/techfab.rsi/meta.json
@@ -1,7 +1,7 @@
 {
     "version": 1,
     "license": "CC-BY-SA-3.0",
-    "copyright": "made by EmoGarbage, ammo state made by AjexRose and modified by Emo garbage. Further modified by TJohnson.",
+    "copyright": "made by EmoGarbage, ammo state made by AjexRose and modified by Emo garbage. Further modified by TJohnson. Additional building and unlit building animations by SubspaceEmber",
     "size": {
         "x": 32,
         "y": 32
@@ -22,6 +22,48 @@
         {
             "name": "unlit"
         },
+        {
+            "name": "building",
+            "delays": [
+                [
+                    0.1,
+                    0.1,
+                    0.1,
+                    0.1,
+                    0.1,
+                    0.1,
+                    0.1,
+                    0.1,
+                    0.1,
+                    0.1,
+                    0.1,
+                    0.1,
+                    0.1,
+                    0.1
+                ]
+            ]
+        },
+        {
+            "name": "unlit-building",
+            "delays": [
+                [
+                    0.1,
+                    0.1,
+                    0.1,
+                    0.1,
+                    0.1,
+                    0.1,
+                    0.1,
+                    0.1,
+                    0.1,
+                    0.1,
+                    0.1,
+                    0.1,
+                    0.1,
+                    0.1
+                ]
+            ]
+        },
         {
             "name": "inserting",
             "delays": [
diff --git a/Resources/Textures/_DV/Structures/Machines/techfab.rsi/unlit-building.png b/Resources/Textures/_DV/Structures/Machines/techfab.rsi/unlit-building.png
new file mode 100644
index 000000000000..9f72550a7a67
Binary files /dev/null and b/Resources/Textures/_DV/Structures/Machines/techfab.rsi/unlit-building.png differ


Reviews:
user: login: deltanedas
state: CHANGES_REQUESTED
author_association: CONTRIBUTOR
submitted_at: 2025-04-14T12:21:38Z
user: login: deltanedas
state: CHANGES_REQUESTED
author_association: CONTRIBUTOR
submitted_at: 2025-04-14T22:32:11Z
user: login: SubspaceEmber
state: COMMENTED
author_association: CONTRIBUTOR
submitted_at: 2025-04-14T22:34:28Z
user: login: deltanedas
state: COMMENTED
author_association: CONTRIBUTOR
submitted_at: 2025-04-14T22:45:16Z
user: login: deltanedas
state: APPROVED
author_association: CONTRIBUTOR
submitted_at: 2025-04-14T22:52:03Z
user: login: SolStar2
body: Art Director approved 👍 
state: APPROVED
author_association: CONTRIBUTOR
submitted_at: 2025-04-17T01:09:23Z

Review comments:
diff_hunk: @@ -407,6 +407,8 @@
   - type: Lathe
     idleState: icon
     runningState: icon
+    unlitIdleState: unlit
+    unlitRunningState: unlit-building
path: Resources/Prototypes/Entities/Structures/Machines/lathe.yml
user: login: deltanedas
body: add ` # DeltaV` to the ones not in _DV
created_at: 2025-04-14T12:15:06Z
author_association: CONTRIBUTOR
diff_hunk: @@ -37,6 +37,48 @@
     {
       "name": "unlit"
     },
+    {
+      "name": "building",
path: Resources/Textures/Structures/Machines/techfab.rsi/meta.json
user: login: deltanedas
body: update copyright to explain where these are from
created_at: 2025-04-14T12:21:11Z
author_association: CONTRIBUTOR
diff_hunk: @@ -22,6 +22,48 @@
         {
             "name": "unlit"
         },
+        {
+            "name": "building",
path: Resources/Textures/_DV/Structures/Machines/techfab.rsi/meta.json
user: login: deltanedas
body: .
created_at: 2025-04-14T12:21:30Z
author_association: CONTRIBUTOR
diff_hunk: @@ -407,6 +407,8 @@
   - type: Lathe
     idleState: icon
     runningState: icon
+    unlitIdleState: unlit
+    unlitRunningState: unlit-building
path: Resources/Prototypes/Entities/Structures/Machines/lathe.yml
user: login: deltanedas
body: this one still isnt done
created_at: 2025-04-14T22:31:11Z
author_association: CONTRIBUTOR
diff_hunk: @@ -454,6 +456,8 @@
     - type: Lathe
       idleState: icon
       runningState: icon
+      unlitIdleState: unlit #DeltaV - added animation sprite layers
path: Resources/Prototypes/Entities/Structures/Machines/lathe.yml
user: login: deltanedas
body: add a space after the `#` for these: `unlit # DeltaV - added animation sprite layers`
created_at: 2025-04-14T22:31:26Z
author_association: CONTRIBUTOR
diff_hunk: @@ -1,7 +1,7 @@
 {
   "version": 1,
   "license": "CC-BY-SA-3.0",
-  "copyright": "made by EmoGarbage, ammo state made by AjexRose and modified by Emo garbage",
+  "copyright": "made by EmoGarbage, ammo state made by AjexRose and modified by Emo garbage. Additional building and unlit building animations by SubspaceEmber",
path: Resources/Textures/Structures/Machines/techfab.rsi/meta.json
user: login: deltanedas
body: use ` |` instead of `.` for this one since its an upstream rsi
created_at: 2025-04-14T22:32:01Z
author_association: CONTRIBUTOR
diff_hunk: @@ -1,7 +1,7 @@
 {
   "version": 1,
   "license": "CC-BY-SA-3.0",
-  "copyright": "made by EmoGarbage, ammo state made by AjexRose and modified by Emo garbage",
+  "copyright": "made by EmoGarbage, ammo state made by AjexRose and modified by Emo garbage. Additional building and unlit building animations by SubspaceEmber",
path: Resources/Textures/Structures/Machines/techfab.rsi/meta.json
user: login: SubspaceEmber
body: sorry, still new, first PR, to clarify, just replace the period after original copyright with pipe followed by my addition?

created_at: 2025-04-14T22:34:28Z
author_association: CONTRIBUTOR
diff_hunk: @@ -1,7 +1,7 @@
 {
   "version": 1,
   "license": "CC-BY-SA-3.0",
-  "copyright": "made by EmoGarbage, ammo state made by AjexRose and modified by Emo garbage",
+  "copyright": "made by EmoGarbage, ammo state made by AjexRose and modified by Emo garbage. Additional building and unlit building animations by SubspaceEmber",
path: Resources/Textures/Structures/Machines/techfab.rsi/meta.json
user: login: deltanedas
body: yes
created_at: 2025-04-14T22:45:15Z
author_association: CONTRIBUTOR

PR comments:
user: login: github-actions[bot]
created_at: 2025-04-14T03:18:32Z
body: RSI Diff Bot; head commit a961b59eb88fb6e6c5bda1b3df789cda74ca18b7 merging into 59f842b78a7d298cdd11cd28153f2910f7666447
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

<details><summary>Resources/Textures/Structures/Machines/techfab.rsi</summary>
<p>

| State | Old | New | Status
| --- | --- | --- | --- |
| building | ![]() | ![](https://raw.githubusercontent.com/SubspaceEmber/Delta-v/a961b59eb88fb6e6c5bda1b3df789cda74ca18b7/Resources/Textures/Structures/Machines/techfab.rsi/building.png) | Added
| unlit-building | ![]() | ![](https://raw.githubusercontent.com/SubspaceEmber/Delta-v/a961b59eb88fb6e6c5bda1b3df789cda74ca18b7/Resources/Textures/Structures/Machines/techfab.rsi/unlit-building.png) | Added


</p>
</details><details><summary>Resources/Textures/_DV/Structures/Machines/techfab.rsi</summary>
<p>

| State | Old | New | Status
| --- | --- | --- | --- |
| building | ![]() | ![](https://raw.githubusercontent.com/SubspaceEmber/Delta-v/a961b59eb88fb6e6c5bda1b3df789cda74ca18b7/Resources/Textures/_DV/Structures/Machines/techfab.rsi/building.png) | Added
| unlit-building | ![]() | ![](https://raw.githubusercontent.com/SubspaceEmber/Delta-v/a961b59eb88fb6e6c5bda1b3df789cda74ca18b7/Resources/Textures/_DV/Structures/Machines/techfab.rsi/unlit-building.png) | Added


</p>
</details>
Edit: diff updated after a961b59eb88fb6e6c5bda1b3df789cda74ca18b7
author_association: CONTRIBUTOR
user: login: SolStar2
created_at: 2025-04-16T05:35:27Z
body: Art director reviewing
author_association: CONTRIBUTOR