Repository: oda-hub/dispatcher-plugin-integral-all-sky
Pull request #31: Dummy data
Author: login: burnout87
Created: 2025-03-18T16:34:07Z | Merged: 2025-03-21T18:31:39Z



Diff:
diff --git a/.gitignore b/.gitignore
index 87ab61b..4c8a5e2 100644
--- a/.gitignore
+++ b/.gitignore
@@ -23,3 +23,4 @@ lib64
 *.gpg
 scratch_*
 .vscode
+/venv
\ No newline at end of file
diff --git a/dummy_prods/query_spiacs_lc.txt b/dummy_prods/query_spiacs_lc.txt
new file mode 100644
index 0000000..f53c731
--- /dev/null
+++ b/dummy_prods/query_spiacs_lc.txt
@@ -0,0 +1,103 @@
+# IJD TIME COUNTS
+51544.0 0.0 100
+51545.0 1.0 101
+51546.0 2.0 102
+51547.0 3.0 103
+51548.0 4.0 104
+51549.0 5.0 105
+51550.0 6.0 106
+51551.0 7.0 107
+51552.0 8.0 108
+51553.0 9.0 109
+51554.0 10.0 110
+51555.0 11.0 111
+51556.0 12.0 112
+51557.0 13.0 113
+51558.0 14.0 114
+51559.0 15.0 115
+51560.0 16.0 116
+51561.0 17.0 117
+51562.0 18.0 118
+51563.0 19.0 119
+51564.0 20.0 120
+51565.0 21.0 121
+51566.0 22.0 122
+51567.0 23.0 123
+51568.0 24.0 124
+51569.0 25.0 125
+51570.0 26.0 126
+51571.0 27.0 127
+51572.0 28.0 128
+51573.0 29.0 129
+51574.0 30.0 130
+51575.0 31.0 131
+51576.0 32.0 132
+51577.0 33.0 133
+51578.0 34.0 134
+51579.0 35.0 135
+51580.0 36.0 136
+51581.0 37.0 137
+51582.0 38.0 138
+51583.0 39.0 139
+51584.0 40.0 140
+51585.0 41.0 141
+51586.0 42.0 142
+51587.0 43.0 143
+51588.0 44.0 144
+51589.0 45.0 145
+51590.0 46.0 146
+51591.0 47.0 147
+51592.0 48.0 148
+51593.0 49.0 149
+51594.0 50.0 150
+51595.0 51.0 151
+51596.0 52.0 152
+51597.0 53.0 153
+51598.0 54.0 154
+51599.0 55.0 155
+51600.0 56.0 156
+51601.0 57.0 157
+51602.0 58.0 158
+51603.0 59.0 159
+51604.0 60.0 160
+51605.0 61.0 161
+51606.0 62.0 162
+51607.0 63.0 163
+51608.0 64.0 164
+51609.0 65.0 165
+51610.0 66.0 166
+51611.0 67.0 167
+51612.0 68.0 168
+51613.0 69.0 169
+51614.0 70.0 170
+51615.0 71.0 171
+51616.0 72.0 172
+51617.0 73.0 173
+51618.0 74.0 174
+51619.0 75.0 175
+51620.0 76.0 176
+51621.0 77.0 177
+51622.0 78.0 178
+51623.0 79.0 179
+51624.0 80.0 180
+51625.0 81.0 181
+51626.0 82.0 182
+51627.0 83.0 183
+51628.0 84.0 184
+51629.0 85.0 185
+51630.0 86.0 186
+51631.0 87.0 187
+51632.0 88.0 188
+51633.0 89.0 189
+51634.0 90.0 190
+51635.0 91.0 191
+51636.0 92.0 192
+51637.0 93.0 193
+51638.0 94.0 194
+51639.0 95.0 195
+51640.0 96.0 196
+51641.0 97.0 197
+51642.0 98.0 198
+51643.0 99.0 199
+51644.0 100.0 200
+51645.0 101.0 201
\ No newline at end of file


Reviews:
user: login: dsavchenko
body: Maybe adding it and using as package data is the best option here. Then no need for chart changes (at least regarding SPI-ACS. If other integral plugins need external dummy data, then better to be consistent in a way we deal with it)
state: CHANGES_REQUESTED
author_association: MEMBER
submitted_at: 2025-03-18T17:56:27Z
user: login: volodymyrss
state: CHANGES_REQUESTED
author_association: MEMBER
submitted_at: 2025-03-18T21:44:04Z
user: login: burnout87
state: COMMENTED
author_association: CONTRIBUTOR
submitted_at: 2025-03-19T07:40:38Z
user: login: burnout87
state: COMMENTED
author_association: CONTRIBUTOR
submitted_at: 2025-03-20T08:55:25Z
user: login: volodymyrss
state: COMMENTED
author_association: MEMBER
submitted_at: 2025-03-20T09:12:13Z
user: login: dsavchenko
state: APPROVED
author_association: MEMBER
submitted_at: 2025-03-21T17:35:57Z
user: login: volodymyrss
state: APPROVED
author_association: MEMBER
submitted_at: 2025-03-21T18:00:32Z

Review comments:
diff_hunk: @@ -0,0 +1,103 @@
+# IJD TIME COUNTS
path: dummy_prods/query_spiacs_lc.txt
user: login: volodymyrss
body: since other dummy products will not come from repo, it's better that these ones do not as well
created_at: 2025-03-18T21:43:59Z
author_association: MEMBER
diff_hunk: @@ -0,0 +1,103 @@
+# IJD TIME COUNTS
path: dummy_prods/query_spiacs_lc.txt
user: login: burnout87
body: Do you have already a location we can use?
Or they can be simply added, to the ones for the other integral instruments...?
created_at: 2025-03-19T07:40:38Z
author_association: CONTRIBUTOR
diff_hunk: @@ -0,0 +1,103 @@
+# IJD TIME COUNTS
path: dummy_prods/query_spiacs_lc.txt
user: login: burnout87
body: if they're in the same archive of the other integral instrument, then this PR is not needed, rather just https://github.com/oda-hub/dispatcher-chart/pull/23
created_at: 2025-03-20T08:55:25Z
author_association: CONTRIBUTOR
diff_hunk: @@ -0,0 +1,103 @@
+# IJD TIME COUNTS
path: dummy_prods/query_spiacs_lc.txt
user: login: volodymyrss
body: I am a bit concerned putting full path in the package, it's rather be configurable by a variable or so. But if needed this can be changed later.
created_at: 2025-03-20T09:12:13Z
author_association: MEMBER

PR comments:
user: login: volodymyrss
created_at: 2025-03-18T17:59:48Z
body: I thought about package daya and it is indeed a good choice for spiacs, but for other integral plugin dummy data is too large. So for consistency putting right into dispatcher container seems better.
author_association: MEMBER
user: login: burnout87
created_at: 2025-03-18T18:02:02Z
body: > I thought about package daya and it is indeed a good choice for spiacs, but for other integral plugin dummy data is too large. So for consistency putting right into dispatcher container seems better.

That it is indeed my idea, having it in the container, getting the file directly from the repo.

The only change in the chart serves the purpose of aligning the dummy_cache parameter with the other integral instruments
author_association: CONTRIBUTOR
user: login: volodymyrss
created_at: 2025-03-18T18:40:35Z
body: > > I thought about package daya and it is indeed a good choice for spiacs, but for other integral plugin dummy data is too large. So for consistency putting right into dispatcher container seems better.
> 
> That it is indeed my idea, having it in the container, getting the file directly from the repo.
> 
> The only change in the chart serves the purpose of aligning the dummy_cache parameter with the other integral instruments

Just when the data is big, it's better not to keep it in the repo. It can be fetched on container build, from some static storage.
author_association: MEMBER
user: login: dsavchenko
created_at: 2025-03-18T19:17:14Z
body: Then the way I see it is to put it in a volume on container init (if not already there). To not grow container size. 
author_association: MEMBER
user: login: burnout87
created_at: 2025-03-18T19:36:34Z
body: > Then the way I see it is to put it in a volume on container init (if not already there). To not grow container size.

But the size won't grow significantly. In the end, it's just a small text file
author_association: CONTRIBUTOR
user: login: volodymyrss
created_at: 2025-03-18T20:06:40Z
body: > Then the way I see it is to put it in a volume on container init (if not already there). To not grow container size.

You have to deploy it every time you deploy the container. So why not just include in the container. It can be tens of Mb, so too large for git or package data, but small enough for >500Mb (at best) container.
author_association: MEMBER
user: login: dsavchenko
created_at: 2025-03-18T21:02:27Z
body: > > Then the way I see it is to put it in a volume on container init (if not already there). To not grow container size.
> 
> You have to deploy it every time you deploy the container. So why not just include in the container. It can be tens of Mb, so too large for git or package data, but small enough for >500Mb (at best) container.

Ah, ok. Tens of Mb is not a problem, of course.
author_association: MEMBER
user: login: volodymyrss
created_at: 2025-03-21T11:58:54Z
body: @burnout87 , please  change the container with the dummy prods for spi-acs?
author_association: MEMBER
user: login: burnout87
created_at: 2025-03-21T12:03:44Z
body: > @burnout87 , please change the container with the dummy prods for spi-acs?

if they're added to the same archive of the other integral instruments (https://github.com/oda-hub/dispatcher-container/blob/993e2bbab97f59605063eaaeca139a923226e5f3/Dockerfile#L61-L62), then this PR is not needed, or did you have another approach in mind?
author_association: CONTRIBUTOR
user: login: burnout87
created_at: 2025-03-21T12:04:18Z
body: > > @burnout87 , please change the container with the dummy prods for spi-acs?
> 
> if they're added to the same archive of the other integral instruments, then this PR is not needed, or did you have another approach in mind?

the other option, is to request those from github directly
author_association: CONTRIBUTOR
user: login: volodymyrss
created_at: 2025-03-21T12:39:49Z
body: > > > @burnout87 , please change the container with the dummy prods for spi-acs?
> > 
> > 
> > if they're added to the same archive of the other integral instruments, then this PR is not needed, or did you have another approach in mind?
> 
> the other option, is to request those from github directly

For simplicity, please add this one from github. It's small and is already there.
author_association: MEMBER
user: login: burnout87
created_at: 2025-03-21T13:03:15Z
body: > > > > @burnout87 , please change the container with the dummy prods for spi-acs?
> > > 
> > > 
> > > if they're added to the same archive of the other integral instruments, then this PR is not needed, or did you have another approach in mind?
> > 
> > 
> > the other option, is to request those from github directly
> 
> For simplicity, please add this one from github. It's small and is already there.

ok then let's merge this and I will make the change in the container
author_association: CONTRIBUTOR