Repository: NixOS/nixpkgs
Pull request #357983: mnamer: 2.5.4 -> 2.5.5
Author: login: austinbutler
Labels: name: 10.rebuild-linux: 1-10
description: This PR causes between 1 and 10 packages to rebuild on Linux.
name: 10.rebuild-darwin: 1-10
description: This PR causes between 1 and 10 packages to rebuild on Darwin.
name: 10.rebuild-darwin: 1
description: This PR causes 1 package to rebuild on Darwin.
name: 10.rebuild-linux: 1
description: This PR causes 1 package to rebuild on Linux.
Created: 2024-11-21T20:22:22Z | Merged: 2025-03-10T21:25:33Z

- Updates to latest version
  - [Release notes](https://github.com/jkwill87/mnamer/releases/tag/2.5.5)
  - [Changes](https://github.com/jkwill87/mnamer/compare/2.5.4...2.5.5)
- Fixes runtime crash (https://github.com/jkwill87/mnamer/issues/284)

## Things done

- Built on platform(s)
  - [x] x86_64-linux
  - [ ] aarch64-linux
  - [ ] x86_64-darwin
  - [ ] aarch64-darwin
- For non-Linux: Is sandboxing enabled in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/command-ref/conf-file.html))
  - [ ] `sandbox = relaxed`
  - [ ] `sandbox = true`
- [ ] Tested, as applicable:
  - [NixOS test(s)](https://nixos.org/manual/nixos/unstable/index.html#sec-nixos-tests) (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - and/or [package tests](https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#package-tests)
  - or, for functions and "core" functionality, tests in [lib/tests](https://github.com/NixOS/nixpkgs/blob/master/lib/tests) or [pkgs/test](https://github.com/NixOS/nixpkgs/blob/master/pkgs/test)
  - made sure NixOS tests are [linked](https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#linking-nixos-module-tests-to-a-package) to the relevant packages
- [x] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"`. Note: all changes have to be committed, also see [nixpkgs-review usage](https://github.com/Mic92/nixpkgs-review#usage)
- [x] Tested basic functionality of all binary files (usually in `./result/bin/`)
- [25.05 Release Notes](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2505.section.md) (or backporting [24.11](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2411.section.md) and [25.05](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2505.section.md) Release notes)
  - [ ] (Package updates) Added a release notes entry if the change is major or breaking
  - [ ] (Module updates) Added a release notes entry if the change is significant
  - [ ] (Module addition) Added a release notes entry if adding a new NixOS module
- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).

---

Add a :+1: [reaction] to [pull requests you find important].

[reaction]: https://github.blog/2016-03-10-add-reactions-to-pull-requests-issues-and-comments/
[pull requests you find important]: https://github.com/NixOS/nixpkgs/pulls?q=is%3Aopen+sort%3Areactions-%2B1-desc


Diff:
diff --git a/pkgs/by-name/mn/mnamer/cached_session_error.patch b/pkgs/by-name/mn/mnamer/cached_session_error.patch
new file mode 100644
index 0000000000000..f6a3d9a15f2f0
--- /dev/null
+++ b/pkgs/by-name/mn/mnamer/cached_session_error.patch
@@ -0,0 +1,28 @@
+From 94ea94de526770e783d04d75b981dfa3ac90fd20 Mon Sep 17 00:00:00 2001
+From: o7-machienhum <ryan.cjw@gmail.com>
+Date: Tue, 30 Jan 2024 03:29:09 -0800
+Subject: [PATCH] Fixes crash
+
+---
+ mnamer/utils.py | 3 ---
+ 1 file changed, 3 deletions(-)
+
+diff --git a/mnamer/utils.py b/mnamer/utils.py
+index 84df7870..8eba68f8 100644
+--- a/mnamer/utils.py
++++ b/mnamer/utils.py
+@@ -256,7 +256,6 @@ def request_json(
+         "like Gecko) Chrome/79.0.3945.88 Safari/537.36"
+     )
+ 
+-    initial_cache_state = session._disabled  # yes, i'm a bad person
+     try:
+         session._disabled = not cache
+         response = session.request(
+@@ -272,8 +271,6 @@ def request_json(
+     except:
+         content = None
+         status = 500
+-    finally:
+-        session._disabled = initial_cache_state
+     return status, (content or {})
diff --git a/pkgs/by-name/mn/mnamer/package.nix b/pkgs/by-name/mn/mnamer/package.nix
index 8477f95ab6667..6935fbf5d1de4 100644
--- a/pkgs/by-name/mn/mnamer/package.nix
+++ b/pkgs/by-name/mn/mnamer/package.nix
@@ -1,31 +1,40 @@
-{ python3Packages, fetchFromGitHub, lib }:
+{
+  python3Packages,
+  fetchFromGitHub,
+  lib,
+}:
 
 python3Packages.buildPythonApplication rec {
   pname = "mnamer";
-  version = "2.5.4";
+  version = "2.5.5";
+  format = "pyproject";
 
   src = fetchFromGitHub {
     owner = "jkwill87";
     repo = "mnamer";
-    rev = version;
-    sha256 = "sha256-fONQq/RboWHFuEFU7HP1ThUpSjOIlkg54c2WlMUKwuk=";
+    tag = version;
+    sha256 = "sha256-qQu5V1GOsbrR00HOrot6TTAkc3KRasBPDEU7ZojUBio=";
   };
 
-  propagatedBuildInputs = with python3Packages; [
+  build-system = with python3Packages; [
+    setuptools
+    setuptools-scm
+  ];
+
+  dependencies = with python3Packages; [
+    appdirs
     babelfish
+    guessit
     requests
-    appdirs
-    teletype
     requests-cache
-    guessit
+    teletype
   ];
 
-  patches = [
-    # requires specific old versions of dependencies which have been updated in nixpkgs
-    ./remove_requirements.patch
+  pythonRelaxDeps = true;
 
-    # author reads a private property that changed between versions
-    ./update_hack.patch
+  patches = [
+    # https://github.com/jkwill87/mnamer/pull/291
+    ./cached_session_error.patch
   ];
 
   nativeCheckInputs = [ python3Packages.pytestCheckHook ];
diff --git a/pkgs/by-name/mn/mnamer/remove_requirements.patch b/pkgs/by-name/mn/mnamer/remove_requirements.patch
deleted file mode 100644
index 46fc0571ce5e6..0000000000000
--- a/pkgs/by-name/mn/mnamer/remove_requirements.patch
+++ /dev/null
@@ -1,21 +0,0 @@
-diff --git a/setup.py b/setup.py
-index 245c1dd..fdc17ab 100755
---- a/setup.py
-+++ b/setup.py
-@@ -7,16 +7,12 @@ from mnamer.__version__ import VERSION
- with open("readme.md", "r", encoding="utf8") as fp:
-     LONG_DESCRIPTION = fp.read()
- 
--with open("requirements.txt", "r", encoding="utf8") as fp:
--    REQUIREMENTS = fp.read().splitlines()
--
- setup(
-     author="Jessy Williams",
-     author_email="jessy@jessywilliams.com",
-     description="A media file organiser",
-     entry_points={"console_scripts": ["mnamer=mnamer.__main__:main"]},
-     include_package_data=True,
--    install_requires=REQUIREMENTS,
-     license="MIT",
-     long_description=LONG_DESCRIPTION,
-     long_description_content_type="text/markdown",
diff --git a/pkgs/by-name/mn/mnamer/update_hack.patch b/pkgs/by-name/mn/mnamer/update_hack.patch
deleted file mode 100644
index 56c83a20a9ce3..0000000000000
--- a/pkgs/by-name/mn/mnamer/update_hack.patch
+++ /dev/null
@@ -1,13 +0,0 @@
-diff --git a/mnamer/utils.py b/mnamer/utils.py
-index 636b596..e52bd37 100644
---- a/mnamer/utils.py
-+++ b/mnamer/utils.py
-@@ -280,7 +280,7 @@ def request_json(
-         "like Gecko) Chrome/79.0.3945.88 Safari/537.36"
-     )
- 
--    initial_cache_state = session._is_cache_disabled  # yes, i'm a bad person
-+    initial_cache_state = session._disabled  # yes, i'm a bad person
-     try:
-         session._is_cache_disabled = not cache
-         response = session.request(


Reviews:
user: login: pbsds
state: COMMENTED
author_association: MEMBER
submitted_at: 2025-01-08T18:07:04Z
user: login: FliegendeWurst
state: CHANGES_REQUESTED
author_association: MEMBER
submitted_at: 2025-03-10T15:30:33Z
user: login: austinbutler
state: COMMENTED
author_association: MEMBER
submitted_at: 2025-03-10T19:13:34Z
user: login: austinbutler
state: COMMENTED
author_association: MEMBER
submitted_at: 2025-03-10T19:18:46Z
user: login: FliegendeWurst
state: COMMENTED
author_association: MEMBER
submitted_at: 2025-03-10T19:41:09Z
user: login: austinbutler
state: COMMENTED
author_association: MEMBER
submitted_at: 2025-03-10T19:48:38Z
user: login: austinbutler
state: COMMENTED
author_association: MEMBER
submitted_at: 2025-03-10T19:48:57Z
user: login: austinbutler
state: COMMENTED
author_association: MEMBER
submitted_at: 2025-03-10T19:49:53Z
user: login: FliegendeWurst
state: COMMENTED
author_association: MEMBER
submitted_at: 2025-03-10T20:41:45Z
user: login: FliegendeWurst
state: COMMENTED
author_association: MEMBER
submitted_at: 2025-03-10T20:41:58Z
user: login: FliegendeWurst
state: COMMENTED
author_association: MEMBER
submitted_at: 2025-03-10T20:42:10Z
user: login: austinbutler
state: COMMENTED
author_association: MEMBER
submitted_at: 2025-03-10T20:48:45Z
user: login: FliegendeWurst
state: COMMENTED
author_association: MEMBER
submitted_at: 2025-03-10T21:13:01Z
user: login: FliegendeWurst
state: APPROVED
author_association: MEMBER
submitted_at: 2025-03-10T21:24:45Z

Review comments:
diff_hunk: @@ -1,31 +1,52 @@
-{ python3Packages, fetchFromGitHub, lib }:
+{
+  python3Packages,
+  fetchFromGitHub,
+  fetchpatch,
+  lib,
+}:
 
 python3Packages.buildPythonApplication rec {
   pname = "mnamer";
-  version = "2.5.4";
+  version = "2.5.5";
+  format = "pyproject";
 
   src = fetchFromGitHub {
     owner = "jkwill87";
     repo = "mnamer";
     rev = version;
-    sha256 = "sha256-fONQq/RboWHFuEFU7HP1ThUpSjOIlkg54c2WlMUKwuk=";
+    sha256 = "sha256-qQu5V1GOsbrR00HOrot6TTAkc3KRasBPDEU7ZojUBio=";
   };
 
+  build-system = with python3Packages; [
+    setuptools
+    setuptools-scm
+  ];
+
+  nativeBuildInputs = with python3Packages; [ pythonRelaxDepsHook ];
path: pkgs/by-name/mn/mnamer/package.nix
user: login: pbsds
body: ```suggestion
```
This is not longer needed, as it is added automatically when `pythonRelaxDeps` is used
created_at: 2025-01-08T18:04:48Z
author_association: MEMBER
diff_hunk: @@ -1,31 +1,52 @@
-{ python3Packages, fetchFromGitHub, lib }:
+{
+  python3Packages,
+  fetchFromGitHub,
+  fetchpatch,
+  lib,
+}:
 
 python3Packages.buildPythonApplication rec {
   pname = "mnamer";
-  version = "2.5.4";
+  version = "2.5.5";
+  format = "pyproject";
 
   src = fetchFromGitHub {
     owner = "jkwill87";
     repo = "mnamer";
     rev = version;
-    sha256 = "sha256-fONQq/RboWHFuEFU7HP1ThUpSjOIlkg54c2WlMUKwuk=";
+    sha256 = "sha256-qQu5V1GOsbrR00HOrot6TTAkc3KRasBPDEU7ZojUBio=";
   };
 
+  build-system = with python3Packages; [
+    setuptools
+    setuptools-scm
+  ];
+
+  nativeBuildInputs = with python3Packages; [ pythonRelaxDepsHook ];
+
   propagatedBuildInputs = with python3Packages; [
+    appdirs
     babelfish
+    guessit
     requests
-    appdirs
-    teletype
     requests-cache
-    guessit
+    teletype
   ];
 
-  patches = [
-    # requires specific old versions of dependencies which have been updated in nixpkgs
-    ./remove_requirements.patch
+  pythonRelaxDeps = [
+    "guessit"
+    "requests-cache"
+    "setuptools-scm"
+    "typing-extensions"
+  ];
 
-    # author reads a private property that changed between versions
-    ./update_hack.patch
+  patches = [
+    # https://github.com/jkwill87/mnamer/pull/291
+    (fetchpatch {
+      name = "fix-cached-session-object-error";
+      url = "https://patch-diff.githubusercontent.com/raw/jkwill87/mnamer/pull/291.patch";
+      hash = "sha256-b0mD9lLE0cUy3kk6Y04MjJfBXSj8HDApmo4xoBINAwA=";
+    })
path: pkgs/by-name/mn/mnamer/package.nix
user: login: pbsds
body: I am skeptical of this patch, but I don't know enough about the project to judge whether this is a valid fix or not. Is that initial session state needed?
created_at: 2025-01-08T18:07:01Z
author_association: MEMBER
diff_hunk: @@ -1,31 +1,52 @@
-{ python3Packages, fetchFromGitHub, lib }:
+{
+  python3Packages,
+  fetchFromGitHub,
+  fetchpatch,
+  lib,
+}:
 
 python3Packages.buildPythonApplication rec {
   pname = "mnamer";
-  version = "2.5.4";
+  version = "2.5.5";
+  format = "pyproject";
 
   src = fetchFromGitHub {
     owner = "jkwill87";
     repo = "mnamer";
     rev = version;
-    sha256 = "sha256-fONQq/RboWHFuEFU7HP1ThUpSjOIlkg54c2WlMUKwuk=";
+    sha256 = "sha256-qQu5V1GOsbrR00HOrot6TTAkc3KRasBPDEU7ZojUBio=";
   };
 
+  build-system = with python3Packages; [
+    setuptools
+    setuptools-scm
+  ];
+
+  nativeBuildInputs = with python3Packages; [ pythonRelaxDepsHook ];
+
   propagatedBuildInputs = with python3Packages; [
+    appdirs
     babelfish
+    guessit
     requests
-    appdirs
-    teletype
     requests-cache
-    guessit
+    teletype
   ];
 
-  patches = [
-    # requires specific old versions of dependencies which have been updated in nixpkgs
-    ./remove_requirements.patch
+  pythonRelaxDeps = [
+    "guessit"
+    "requests-cache"
+    "setuptools-scm"
+    "typing-extensions"
+  ];
 
-    # author reads a private property that changed between versions
-    ./update_hack.patch
+  patches = [
+    # https://github.com/jkwill87/mnamer/pull/291
+    (fetchpatch {
+      name = "fix-cached-session-object-error";
+      url = "https://patch-diff.githubusercontent.com/raw/jkwill87/mnamer/pull/291.patch";
path: pkgs/by-name/mn/mnamer/package.nix
user: login: FliegendeWurst
body: Only merged commits are acceptable to fetch as patch. 
created_at: 2025-03-10T15:30:24Z
author_association: MEMBER
diff_hunk: @@ -1,31 +1,52 @@
-{ python3Packages, fetchFromGitHub, lib }:
+{
+  python3Packages,
+  fetchFromGitHub,
+  fetchpatch,
+  lib,
+}:
 
 python3Packages.buildPythonApplication rec {
   pname = "mnamer";
-  version = "2.5.4";
+  version = "2.5.5";
+  format = "pyproject";
 
   src = fetchFromGitHub {
     owner = "jkwill87";
     repo = "mnamer";
     rev = version;
-    sha256 = "sha256-fONQq/RboWHFuEFU7HP1ThUpSjOIlkg54c2WlMUKwuk=";
+    sha256 = "sha256-qQu5V1GOsbrR00HOrot6TTAkc3KRasBPDEU7ZojUBio=";
   };
 
+  build-system = with python3Packages; [
+    setuptools
+    setuptools-scm
+  ];
+
+  nativeBuildInputs = with python3Packages; [ pythonRelaxDepsHook ];
+
   propagatedBuildInputs = with python3Packages; [
+    appdirs
     babelfish
+    guessit
     requests
-    appdirs
-    teletype
     requests-cache
-    guessit
+    teletype
   ];
 
-  patches = [
-    # requires specific old versions of dependencies which have been updated in nixpkgs
-    ./remove_requirements.patch
+  pythonRelaxDeps = [
+    "guessit"
+    "requests-cache"
+    "setuptools-scm"
+    "typing-extensions"
+  ];
 
-    # author reads a private property that changed between versions
-    ./update_hack.patch
+  patches = [
+    # https://github.com/jkwill87/mnamer/pull/291
+    (fetchpatch {
+      name = "fix-cached-session-object-error";
+      url = "https://patch-diff.githubusercontent.com/raw/jkwill87/mnamer/pull/291.patch";
+      hash = "sha256-b0mD9lLE0cUy3kk6Y04MjJfBXSj8HDApmo4xoBINAwA=";
+    })
path: pkgs/by-name/mn/mnamer/package.nix
user: login: austinbutler
body: I haven't looked into it deeply, but I know from actual usage of the program that it doesn't work at all as-is, it works as expected with the patch.
created_at: 2025-03-10T19:13:34Z
author_association: MEMBER
diff_hunk: @@ -1,31 +1,52 @@
-{ python3Packages, fetchFromGitHub, lib }:
+{
+  python3Packages,
+  fetchFromGitHub,
+  fetchpatch,
+  lib,
+}:
 
 python3Packages.buildPythonApplication rec {
   pname = "mnamer";
-  version = "2.5.4";
+  version = "2.5.5";
+  format = "pyproject";
 
   src = fetchFromGitHub {
     owner = "jkwill87";
     repo = "mnamer";
     rev = version;
-    sha256 = "sha256-fONQq/RboWHFuEFU7HP1ThUpSjOIlkg54c2WlMUKwuk=";
+    sha256 = "sha256-qQu5V1GOsbrR00HOrot6TTAkc3KRasBPDEU7ZojUBio=";
   };
 
+  build-system = with python3Packages; [
+    setuptools
+    setuptools-scm
+  ];
+
+  nativeBuildInputs = with python3Packages; [ pythonRelaxDepsHook ];
+
   propagatedBuildInputs = with python3Packages; [
+    appdirs
     babelfish
+    guessit
     requests
-    appdirs
-    teletype
     requests-cache
-    guessit
+    teletype
   ];
 
-  patches = [
-    # requires specific old versions of dependencies which have been updated in nixpkgs
-    ./remove_requirements.patch
+  pythonRelaxDeps = [
+    "guessit"
+    "requests-cache"
+    "setuptools-scm"
+    "typing-extensions"
+  ];
 
-    # author reads a private property that changed between versions
-    ./update_hack.patch
+  patches = [
+    # https://github.com/jkwill87/mnamer/pull/291
+    (fetchpatch {
+      name = "fix-cached-session-object-error";
+      url = "https://patch-diff.githubusercontent.com/raw/jkwill87/mnamer/pull/291.patch";
path: pkgs/by-name/mn/mnamer/package.nix
user: login: austinbutler
body: Oh really? I've never heard this. Is this written somewhere? What's the preferred alternative, checking the patch in to nixpkgs?
created_at: 2025-03-10T19:18:46Z
author_association: MEMBER
diff_hunk: @@ -1,31 +1,52 @@
-{ python3Packages, fetchFromGitHub, lib }:
+{
+  python3Packages,
+  fetchFromGitHub,
+  fetchpatch,
+  lib,
+}:
 
 python3Packages.buildPythonApplication rec {
   pname = "mnamer";
-  version = "2.5.4";
+  version = "2.5.5";
+  format = "pyproject";
 
   src = fetchFromGitHub {
     owner = "jkwill87";
     repo = "mnamer";
     rev = version;
-    sha256 = "sha256-fONQq/RboWHFuEFU7HP1ThUpSjOIlkg54c2WlMUKwuk=";
+    sha256 = "sha256-qQu5V1GOsbrR00HOrot6TTAkc3KRasBPDEU7ZojUBio=";
   };
 
+  build-system = with python3Packages; [
+    setuptools
+    setuptools-scm
+  ];
+
+  nativeBuildInputs = with python3Packages; [ pythonRelaxDepsHook ];
+
   propagatedBuildInputs = with python3Packages; [
+    appdirs
     babelfish
+    guessit
     requests
-    appdirs
-    teletype
     requests-cache
-    guessit
+    teletype
   ];
 
-  patches = [
-    # requires specific old versions of dependencies which have been updated in nixpkgs
-    ./remove_requirements.patch
+  pythonRelaxDeps = [
+    "guessit"
+    "requests-cache"
+    "setuptools-scm"
+    "typing-extensions"
+  ];
 
-    # author reads a private property that changed between versions
-    ./update_hack.patch
+  patches = [
+    # https://github.com/jkwill87/mnamer/pull/291
+    (fetchpatch {
+      name = "fix-cached-session-object-error";
+      url = "https://patch-diff.githubusercontent.com/raw/jkwill87/mnamer/pull/291.patch";
path: pkgs/by-name/mn/mnamer/package.nix
user: login: FliegendeWurst
body: For small patches we store them in nixpkgs, yes.

I'll see if I can find the guidelines. Really we just need a stable URL, which in practice means we only accept merged commits.
created_at: 2025-03-10T19:41:09Z
author_association: MEMBER
diff_hunk: @@ -1,31 +1,40 @@
-{ python3Packages, fetchFromGitHub, lib }:
+{
+  python3Packages,
+  fetchFromGitHub,
+  lib,
+}:
 
 python3Packages.buildPythonApplication rec {
   pname = "mnamer";
-  version = "2.5.4";
+  version = "2.5.5";
+  format = "pyproject";
 
   src = fetchFromGitHub {
     owner = "jkwill87";
     repo = "mnamer";
     rev = version;
-    sha256 = "sha256-fONQq/RboWHFuEFU7HP1ThUpSjOIlkg54c2WlMUKwuk=";
+    sha256 = "sha256-qQu5V1GOsbrR00HOrot6TTAkc3KRasBPDEU7ZojUBio=";
   };
 
+  build-system = with python3Packages; [
+    setuptools
+    setuptools-scm
+  ];
+
   propagatedBuildInputs = with python3Packages; [
+    appdirs
     babelfish
+    guessit
     requests
-    appdirs
-    teletype
     requests-cache
-    guessit
+    teletype
   ];
 
-  patches = [
-    # requires specific old versions of dependencies which have been updated in nixpkgs
-    ./remove_requirements.patch
+  pythonRelaxDeps = true;
path: pkgs/by-name/mn/mnamer/package.nix
user: login: austinbutler
body: I tried specifying the packages that needed this, but even when I specified `requests-cache` and `setuptools-scm` it failed here:

```
Executing pythonRuntimeDepsCheck
Checking runtime dependencies for mnamer-2.5.5-py3-none-any.whl
  - requests-cache~=0.9.7 not satisfied by version 1.2.1
  - setuptools-scm~=7.1.0 not satisfied by version 8.1.0
```
created_at: 2025-03-10T19:48:38Z
author_association: MEMBER
diff_hunk: @@ -1,31 +1,52 @@
-{ python3Packages, fetchFromGitHub, lib }:
+{
+  python3Packages,
+  fetchFromGitHub,
+  fetchpatch,
+  lib,
+}:
 
 python3Packages.buildPythonApplication rec {
   pname = "mnamer";
-  version = "2.5.4";
+  version = "2.5.5";
+  format = "pyproject";
 
   src = fetchFromGitHub {
     owner = "jkwill87";
     repo = "mnamer";
     rev = version;
-    sha256 = "sha256-fONQq/RboWHFuEFU7HP1ThUpSjOIlkg54c2WlMUKwuk=";
+    sha256 = "sha256-qQu5V1GOsbrR00HOrot6TTAkc3KRasBPDEU7ZojUBio=";
   };
 
+  build-system = with python3Packages; [
+    setuptools
+    setuptools-scm
+  ];
+
+  nativeBuildInputs = with python3Packages; [ pythonRelaxDepsHook ];
path: pkgs/by-name/mn/mnamer/package.nix
user: login: austinbutler
body: Thanks, removed.
created_at: 2025-03-10T19:48:56Z
author_association: MEMBER
diff_hunk: @@ -1,31 +1,52 @@
-{ python3Packages, fetchFromGitHub, lib }:
+{
+  python3Packages,
+  fetchFromGitHub,
+  fetchpatch,
+  lib,
+}:
 
 python3Packages.buildPythonApplication rec {
   pname = "mnamer";
-  version = "2.5.4";
+  version = "2.5.5";
+  format = "pyproject";
 
   src = fetchFromGitHub {
     owner = "jkwill87";
     repo = "mnamer";
     rev = version;
-    sha256 = "sha256-fONQq/RboWHFuEFU7HP1ThUpSjOIlkg54c2WlMUKwuk=";
+    sha256 = "sha256-qQu5V1GOsbrR00HOrot6TTAkc3KRasBPDEU7ZojUBio=";
   };
 
+  build-system = with python3Packages; [
+    setuptools
+    setuptools-scm
+  ];
+
+  nativeBuildInputs = with python3Packages; [ pythonRelaxDepsHook ];
+
   propagatedBuildInputs = with python3Packages; [
+    appdirs
     babelfish
+    guessit
     requests
-    appdirs
-    teletype
     requests-cache
-    guessit
+    teletype
   ];
 
-  patches = [
-    # requires specific old versions of dependencies which have been updated in nixpkgs
-    ./remove_requirements.patch
+  pythonRelaxDeps = [
+    "guessit"
+    "requests-cache"
+    "setuptools-scm"
+    "typing-extensions"
+  ];
 
-    # author reads a private property that changed between versions
-    ./update_hack.patch
+  patches = [
+    # https://github.com/jkwill87/mnamer/pull/291
+    (fetchpatch {
+      name = "fix-cached-session-object-error";
+      url = "https://patch-diff.githubusercontent.com/raw/jkwill87/mnamer/pull/291.patch";
path: pkgs/by-name/mn/mnamer/package.nix
user: login: austinbutler
body: Ah I see, thanks. I deleted the other checked in patches and added this as a checked in patch. Hopefully the net removal of patches helps.
created_at: 2025-03-10T19:49:53Z
author_association: MEMBER
diff_hunk: @@ -1,31 +1,40 @@
-{ python3Packages, fetchFromGitHub, lib }:
+{
+  python3Packages,
+  fetchFromGitHub,
+  lib,
+}:
 
 python3Packages.buildPythonApplication rec {
   pname = "mnamer";
-  version = "2.5.4";
+  version = "2.5.5";
+  format = "pyproject";
 
   src = fetchFromGitHub {
     owner = "jkwill87";
     repo = "mnamer";
     rev = version;
-    sha256 = "sha256-fONQq/RboWHFuEFU7HP1ThUpSjOIlkg54c2WlMUKwuk=";
+    sha256 = "sha256-qQu5V1GOsbrR00HOrot6TTAkc3KRasBPDEU7ZojUBio=";
   };
 
+  build-system = with python3Packages; [
+    setuptools
+    setuptools-scm
+  ];
+
   propagatedBuildInputs = with python3Packages; [
+    appdirs
     babelfish
+    guessit
     requests
-    appdirs
-    teletype
     requests-cache
-    guessit
+    teletype
   ];
 
-  patches = [
-    # requires specific old versions of dependencies which have been updated in nixpkgs
-    ./remove_requirements.patch
+  pythonRelaxDeps = true;
path: pkgs/by-name/mn/mnamer/package.nix
user: login: FliegendeWurst
body: Did you specify as `pythonRelaxDeps = [ "requests-cache" "setuptools-scm" ]`, or differently?
created_at: 2025-03-10T20:41:45Z
author_association: MEMBER
diff_hunk: @@ -1,31 +1,40 @@
-{ python3Packages, fetchFromGitHub, lib }:
+{
+  python3Packages,
+  fetchFromGitHub,
+  lib,
+}:
 
 python3Packages.buildPythonApplication rec {
   pname = "mnamer";
-  version = "2.5.4";
+  version = "2.5.5";
+  format = "pyproject";
 
   src = fetchFromGitHub {
     owner = "jkwill87";
     repo = "mnamer";
     rev = version;
-    sha256 = "sha256-fONQq/RboWHFuEFU7HP1ThUpSjOIlkg54c2WlMUKwuk=";
+    sha256 = "sha256-qQu5V1GOsbrR00HOrot6TTAkc3KRasBPDEU7ZojUBio=";
   };
 
+  build-system = with python3Packages; [
+    setuptools
+    setuptools-scm
+  ];
+
   propagatedBuildInputs = with python3Packages; [
path: pkgs/by-name/mn/mnamer/package.nix
user: login: FliegendeWurst
body: ```suggestion
  dependencies = with python3Packages; [
```
created_at: 2025-03-10T20:41:58Z
author_association: MEMBER
diff_hunk: @@ -1,31 +1,40 @@
-{ python3Packages, fetchFromGitHub, lib }:
+{
+  python3Packages,
+  fetchFromGitHub,
+  lib,
+}:
 
 python3Packages.buildPythonApplication rec {
   pname = "mnamer";
-  version = "2.5.4";
+  version = "2.5.5";
+  format = "pyproject";
 
   src = fetchFromGitHub {
     owner = "jkwill87";
     repo = "mnamer";
     rev = version;
path: pkgs/by-name/mn/mnamer/package.nix
user: login: FliegendeWurst
body: ```suggestion
    tag = version;
```
`rev` should only be used for commits
created_at: 2025-03-10T20:42:10Z
author_association: MEMBER
diff_hunk: @@ -1,31 +1,40 @@
-{ python3Packages, fetchFromGitHub, lib }:
+{
+  python3Packages,
+  fetchFromGitHub,
+  lib,
+}:
 
 python3Packages.buildPythonApplication rec {
   pname = "mnamer";
-  version = "2.5.4";
+  version = "2.5.5";
+  format = "pyproject";
 
   src = fetchFromGitHub {
     owner = "jkwill87";
     repo = "mnamer";
     rev = version;
-    sha256 = "sha256-fONQq/RboWHFuEFU7HP1ThUpSjOIlkg54c2WlMUKwuk=";
+    sha256 = "sha256-qQu5V1GOsbrR00HOrot6TTAkc3KRasBPDEU7ZojUBio=";
   };
 
+  build-system = with python3Packages; [
+    setuptools
+    setuptools-scm
+  ];
+
   propagatedBuildInputs = with python3Packages; [
+    appdirs
     babelfish
+    guessit
     requests
-    appdirs
-    teletype
     requests-cache
-    guessit
+    teletype
   ];
 
-  patches = [
-    # requires specific old versions of dependencies which have been updated in nixpkgs
-    ./remove_requirements.patch
+  pythonRelaxDeps = true;
path: pkgs/by-name/mn/mnamer/package.nix
user: login: austinbutler
body: Like that, yes.
created_at: 2025-03-10T20:48:45Z
author_association: MEMBER
diff_hunk: @@ -1,31 +1,40 @@
-{ python3Packages, fetchFromGitHub, lib }:
+{
+  python3Packages,
+  fetchFromGitHub,
+  lib,
+}:
 
 python3Packages.buildPythonApplication rec {
   pname = "mnamer";
-  version = "2.5.4";
+  version = "2.5.5";
+  format = "pyproject";
 
   src = fetchFromGitHub {
     owner = "jkwill87";
     repo = "mnamer";
     rev = version;
-    sha256 = "sha256-fONQq/RboWHFuEFU7HP1ThUpSjOIlkg54c2WlMUKwuk=";
+    sha256 = "sha256-qQu5V1GOsbrR00HOrot6TTAkc3KRasBPDEU7ZojUBio=";
   };
 
+  build-system = with python3Packages; [
+    setuptools
+    setuptools-scm
+  ];
+
   propagatedBuildInputs = with python3Packages; [
+    appdirs
     babelfish
+    guessit
     requests
-    appdirs
-    teletype
     requests-cache
-    guessit
+    teletype
   ];
 
-  patches = [
-    # requires specific old versions of dependencies which have been updated in nixpkgs
-    ./remove_requirements.patch
+  pythonRelaxDeps = true;
path: pkgs/by-name/mn/mnamer/package.nix
user: login: FliegendeWurst
body: That's odd. In that case your solution works
created_at: 2025-03-10T21:13:01Z
author_association: MEMBER

PR comments:
user: login: austinbutler
created_at: 2024-11-21T20:38:45Z
body: ## `nixpkgs-review` result

Generated using [`nixpkgs-review`](https://github.com/Mic92/nixpkgs-review).

Command: `nixpkgs-review pr 357983`

---
### `x86_64-linux`
<details>
  <summary>:white_check_mark: 2 packages built:</summary>
  <ul>
    <li>mnamer</li>
    <li>mnamer.dist</li>
  </ul>
</details>

author_association: MEMBER
user: login: devhell
created_at: 2024-12-22T13:52:05Z
body: Can this be merged so we can at least have a working `mnamer`?
author_association: CONTRIBUTOR
user: login: x6ufeng
created_at: 2024-12-22T13:57:59Z
body: > Can this be merged so we can at least have a working `mnamer`?

Found a temporary solution, https://github.com/christian-blades-cb/mnamer-nix . You can use this for now while we wait for this to be merged.
author_association: NONE
user: login: austinbutler
created_at: 2025-03-10T20:01:31Z
body: ## `nixpkgs-review` result

Generated using [`nixpkgs-review`](https://github.com/Mic92/nixpkgs-review).

Command: `nixpkgs-review pr 357983`

---
### `x86_64-linux`
<details>
  <summary>:white_check_mark: 2 packages built:</summary>
  <ul>
    <li>mnamer</li>
    <li>mnamer.dist</li>
  </ul>
</details>

author_association: MEMBER
user: login: austinbutler
created_at: 2025-03-10T21:24:06Z
body: ## `nixpkgs-review` result

Generated using [`nixpkgs-review`](https://github.com/Mic92/nixpkgs-review).

Command: `nixpkgs-review pr 357983`

---
### `x86_64-linux`
<details>
  <summary>:white_check_mark: 2 packages built:</summary>
  <ul>
    <li>mnamer</li>
    <li>mnamer.dist</li>
  </ul>
</details>

author_association: MEMBER