Repository: NOAA-EMC/NOAA_3drtma
Pull request #41: Minor update: (1) added hrrrdas ensemble file dependencies to the gsi…
Author: login: EdwardColon-NOAA
Created: 2025-04-16T19:08:18Z | Merged: 2025-04-17T13:54:19Z

… step and a series of minor bug fixes in the conus and alaska rhist exscripts.


Diff:
diff --git a/scripts/akrtma3d/exakrtma3d_rhist.ksh b/scripts/akrtma3d/exakrtma3d_rhist.ksh
index fdaca426..ac6e21ba 100755
--- a/scripts/akrtma3d/exakrtma3d_rhist.ksh
+++ b/scripts/akrtma3d/exakrtma3d_rhist.ksh
@@ -79,7 +79,7 @@ ln -sf $COMOUTautoqc_rtma3dm2 $DATA/$PDYm2
 ln -sf $COMOUTautoqc_rtma3dm3 $DATA/$PDYm3
 
 
-ls -1r */* | awk '
+ls -1r */*/* | awk '
 
             /prepbufr/ { print "./"$0 > "perm" ; next }
 
@@ -125,7 +125,7 @@ ls -1r */* | awk '
 
 	   /firstguess.nc/ { print "./"$0 > "perm" ; next }'
 
-ls -1r */* | awk '
+ls -1r */*/* | awk '
 
             /fits/ { print "./"$0 > "2yr" ; next }
 
diff --git a/scripts/rtma3d/exrtma3d_gsianl.ksh b/scripts/rtma3d/exrtma3d_gsianl.ksh
index 71ab1fb1..16a86b9f 100755
--- a/scripts/rtma3d/exrtma3d_gsianl.ksh
+++ b/scripts/rtma3d/exrtma3d_gsianl.ksh
@@ -29,7 +29,14 @@ COMINhrrrdas=${COMINHRRRDAS}
 fi
 #START_TIME=`${DATE} -d "${PDY} ${cyc} ${SUBH_TIME} minutes"`
 START_TIME=`${DATE} -d "${PDY} ${cyc} ${subcyc} minutes"`
-if [ ${HRRRDAS_BEC} -eq 0 ]; then
+START_TIME_HRRRDAS_CUTOFF=`${DATE} -d "${PDY} ${HRRRDAS_CUTOFF} ${subcyc} minutes"`
+if [ "${START_TIME} -le ${START_TIME_HRRRDAS_CUTOFF} ]; then
+HRRRDAS_STATE=${HRRRDAS_BEC}
+else
+HRRRDAS_STATE=0
+fi
+
+if [ ${HRRRDAS_STATE} -eq 0 ]; then
 EnsWgt=0.5
 else
 EnsWgt=0.9
@@ -150,7 +157,7 @@ else
   ${ECHO} "Warning: ${OBS_DIR}: satmar does not exist!"
 fi
 
-if [ "${envir}" = "lsf" ] || [ "${envir}" = "pbspro" ] && [ ${HRRRDAS_BEC} -eq 0 ] ; then #WCOSS
+if [ "${envir}" = "lsf" ] || [ "${envir}" = "pbspro" ] && [ ${HRRRDAS_STATE} -eq 0 ] ; then #WCOSS
   # Set runtime and save directories
   export endianness=Big_Endian
 
@@ -188,8 +195,8 @@ if [ "${envir}" = "lsf" ] || [ "${envir}" = "pbspro" ] && [ ${HRRRDAS_BEC} -eq 0
 fi
 
 
-if [ ${HRRRDAS_BEC} -eq 1 ]; then
-  ${ECHO} "\$HRRRDAS_BEC=${HRRRDAS_BEC}, so HRRRDAS will be used if available"
+if [ ${HRRRDAS_STATE} -eq 1 ]; then
+  ${ECHO} "\$HRRRDAS_BEC=${HRRRDAS_STATE}, so HRRRDAS will be used if available"
   #----------------------------------------------------
   # generate list of HRRRDAS members for ensemble covariances
   # Use 1-hr forecasts from the HRRRDAS cycling
@@ -212,7 +219,7 @@ if [ ${HRRRDAS_BEC} -eq 1 ]; then
    ((c = c + 1))
   done
 else
-  ${ECHO} "\$HRRRDAS_BEC=${HRRRDAS_BEC}, so HRRRDAS will NOT be used"
+  ${ECHO} "\$HRRRDAS_BEC=${HRRRDAS_STATE}, so HRRRDAS will NOT be used"
   ${TOUCH} filelist.hrrrdas #so as to avoid "no such file" error message
 fi
 
@@ -224,7 +231,7 @@ nummem=`more filelist03 | wc -l`
 nummem=$((nummem - 3 ))
 hrrrmem=`more filelist.hrrrdas | wc -l`
 hrrrmem=$((hrrrmem - 3 ))
-if [[ ${hrrrmem} -gt 30 ]] && [[ ${HRRRDAS_BEC} -eq 1  ]]; then #if HRRRDAS BEC is available, use it as first choice
+if [[ ${hrrrmem} -gt 30 ]] && [[ ${HRRRDAS_STATE} -eq 1  ]]; then #if HRRRDAS BEC is available, use it as first choice
   echo "Do hybrid with HRRRDAS BEC"
   nummem=${hrrrmem}
   cpreq filelist.hrrrdas filelist03
diff --git a/scripts/rtma3d/exrtma3d_rhist.ksh b/scripts/rtma3d/exrtma3d_rhist.ksh
index 766392f6..6c64d105 100755
--- a/scripts/rtma3d/exrtma3d_rhist.ksh
+++ b/scripts/rtma3d/exrtma3d_rhist.ksh
@@ -196,7 +196,7 @@ ls -1r */*/* | awk '
            /firstguess.nc/ { print "./"$0 > "perm" ; next }'
 
 
-ls -1r */* | awk '
+ls -1r */*/* | awk '
 
             /fits/ { print "./"$0 > "2yr" ; next }
 
@@ -204,7 +204,7 @@ ls -1r */* | awk '
 
 	    /OUTPUT/ { print "./"$0 > "2yr" ; next }'
 
-ls -1r */* | awk '
+ls -1r */*/* | awk '
 
             /hrrrdas_small/ { print "./"$0 > "perm_hrrrdas" ; next }'
 
diff --git a/workflow/rtma3d_pbspro_conus.xml b/workflow/rtma3d_pbspro_conus.xml
index 36790d51..0d5ed9d5 100644
--- a/workflow/rtma3d_pbspro_conus.xml
+++ b/workflow/rtma3d_pbspro_conus.xml
@@ -19,8 +19,10 @@
 <!--<!ENTITY CAP_RUN_ENVIR	""> -->
 <!ENTITY model		"&RUN;">
 <!ENTITY HRRRDAS_BEC     "1">
+<!ENTITY HRRRDAS_CUTOFF  "32">
 <!ENTITY READIN_LOCALIZATION     "TRUE">
 
+
 <!ENTITY MACHINE	"cray">
 <!ENTITY machine	"&MACHINE;">
 
@@ -710,6 +712,10 @@
       <name>HRRRDAS_BEC</name>
       <value>&HRRRDAS_BEC;</value>
     </envar>
+    <envar>
+      <name>HRRRDAS_CUTOFF</name>
+      <value>&HRRRDAS_CUTOFF;</value>
+    </envar>
     <envar>
       <name>READIN_LOCALIZATION</name>
       <value>&READIN_LOCALIZATION;</value>
@@ -1170,9 +1176,50 @@
     &ENVARS_GSI;
 
     <dependency>
-      <and>
-           <taskdep task="&RUN;_prepfgs_task"/> 
+      <and> 
+	   <taskdep task="&RUN;_prepfgs_task"/> 
            <taskdep task="&RUN;_prepobs_task"/>
+	   <and>      
+	     <datadep age="10"><cyclestr offset="-3600">&COMINHRRRDAS;/hrrrdas_small_d02_@Y@m@d@H00f01_mem0001</cyclestr></datadep>
+             <datadep age="10"><cyclestr offset="-3600">&COMINHRRRDAS;/hrrrdas_small_d02_@Y@m@d@H00f01_mem0002</cyclestr></datadep>
+             <datadep age="10"><cyclestr offset="-3600">&COMINHRRRDAS;/hrrrdas_small_d02_@Y@m@d@H00f01_mem0003</cyclestr></datadep>
+             <datadep age="10"><cyclestr offset="-3600">&COMINHRRRDAS;/hrrrdas_small_d02_@Y@m@d@H00f01_mem0004</cyclestr></datadep>
+             <datadep age="10"><cyclestr offset="-3600">&COMINHRRRDAS;/hrrrdas_small_d02_@Y@m@d@H00f01_mem0005</cyclestr></datadep>
+             <datadep age="10"><cyclestr offset="-3600">&COMINHRRRDAS;/hrrrdas_small_d02_@Y@m@d@H00f01_mem0006</cyclestr></datadep>
+             <datadep age="10"><cyclestr offset="-3600">&COMINHRRRDAS;/hrrrdas_small_d02_@Y@m@d@H00f01_mem0007</cyclestr></datadep>
+             <datadep age="10"><cyclestr offset="-3600">&COMINHRRRDAS;/hrrrdas_small_d02_@Y@m@d@H00f01_mem0008</cyclestr></datadep>
+             <datadep age="10"><cyclestr offset="-3600">&COMINHRRRDAS;/hrrrdas_small_d02_@Y@m@d@H00f01_mem0009</cyclestr></datadep>
+             <datadep age="10"><cyclestr offset="-3600">&COMINHRRRDAS;/hrrrdas_small_d02_@Y@m@d@H00f01_mem0010</cyclestr></datadep>
+             <datadep age="10"><cyclestr offset="-3600">&COMINHRRRDAS;/hrrrdas_small_d02_@Y@m@d@H00f01_mem0011</cyclestr></datadep>
+             <datadep age="10"><cyclestr offset="-3600">&COMINHRRRDAS;/hrrrdas_small_d02_@Y@m@d@H00f01_mem0012</cyclestr></datadep>
+             <datadep age="10"><cyclestr offset="-3600">&COMINHRRRDAS;/hrrrdas_small_d02_@Y@m@d@H00f01_mem0013</cyclestr></datadep>
+             <datadep age="10"><cyclestr offset="-3600">&COMINHRRRDAS;/hrrrdas_small_d02_@Y@m@d@H00f01_mem0014</cyclestr></datadep>
+             <datadep age="10"><cyclestr offset="-3600">&COMINHRRRDAS;/hrrrdas_small_d02_@Y@m@d@H00f01_mem0015</cyclestr></datadep>
+             <datadep age="10"><cyclestr offset="-3600">&COMINHRRRDAS;/hrrrdas_small_d02_@Y@m@d@H00f01_mem0016</cyclestr></datadep>
+             <datadep age="10"><cyclestr offset="-3600">&COMINHRRRDAS;/hrrrdas_small_d02_@Y@m@d@H00f01_mem0017</cyclestr></datadep>
+             <datadep age="10"><cyclestr offset="-3600">&COMINHRRRDAS;/hrrrdas_small_d02_@Y@m@d@H00f01_mem0018</cyclestr></datadep>
+             <datadep age="10"><cyclestr offset="-3600">&COMINHRRRDAS;/hrrrdas_small_d02_@Y@m@d@H00f01_mem0019</cyclestr></datadep>
+             <datadep age="10"><cyclestr offset="-3600">&COMINHRRRDAS;/hrrrdas_small_d02_@Y@m@d@H00f01_mem0020</cyclestr></datadep>
+             <datadep age="10"><cyclestr offset="-3600">&COMINHRRRDAS;/hrrrdas_small_d02_@Y@m@d@H00f01_mem0021</cyclestr></datadep>
+             <datadep age="10"><cyclestr offset="-3600">&COMINHRRRDAS;/hrrrdas_small_d02_@Y@m@d@H00f01_mem0022</cyclestr></datadep>
+             <datadep age="10"><cyclestr offset="-3600">&COMINHRRRDAS;/hrrrdas_small_d02_@Y@m@d@H00f01_mem0023</cyclestr></datadep>
+             <datadep age="10"><cyclestr offset="-3600">&COMINHRRRDAS;/hrrrdas_small_d02_@Y@m@d@H00f01_mem0024</cyclestr></datadep>
+             <datadep age="10"><cyclestr offset="-3600">&COMINHRRRDAS;/hrrrdas_small_d02_@Y@m@d@H00f01_mem0025</cyclestr></datadep>
+             <datadep age="10"><cyclestr offset="-3600">&COMINHRRRDAS;/hrrrdas_small_d02_@Y@m@d@H00f01_mem0026</cyclestr></datadep>
+             <datadep age="10"><cyclestr offset="-3600">&COMINHRRRDAS;/hrrrdas_small_d02_@Y@m@d@H00f01_mem0027</cyclestr></datadep>
+             <datadep age="10"><cyclestr offset="-3600">&COMINHRRRDAS;/hrrrdas_small_d02_@Y@m@d@H00f01_mem0028</cyclestr></datadep>
+             <datadep age="10"><cyclestr offset="-3600">&COMINHRRRDAS;/hrrrdas_small_d02_@Y@m@d@H00f01_mem0029</cyclestr></datadep>
+             <datadep age="10"><cyclestr offset="-3600">&COMINHRRRDAS;/hrrrdas_small_d02_@Y@m@d@H00f01_mem0030</cyclestr></datadep>
+             <datadep age="10"><cyclestr offset="-3600">&COMINHRRRDAS;/hrrrdas_small_d02_@Y@m@d@H00f01_mem0031</cyclestr></datadep>
+             <datadep age="10"><cyclestr offset="-3600">&COMINHRRRDAS;/hrrrdas_small_d02_@Y@m@d@H00f01_mem0032</cyclestr></datadep>
+             <datadep age="10"><cyclestr offset="-3600">&COMINHRRRDAS;/hrrrdas_small_d02_@Y@m@d@H00f01_mem0033</cyclestr></datadep>
+             <datadep age="10"><cyclestr offset="-3600">&COMINHRRRDAS;/hrrrdas_small_d02_@Y@m@d@H00f01_mem0034</cyclestr></datadep>
+             <datadep age="10"><cyclestr offset="-3600">&COMINHRRRDAS;/hrrrdas_small_d02_@Y@m@d@H00f01_mem0035</cyclestr></datadep>
+             <datadep age="10"><cyclestr offset="-3600">&COMINHRRRDAS;/hrrrdas_small_d02_@Y@m@d@H00f01_mem0036</cyclestr></datadep>
+             <or>
+		<timedep><cyclestr offset="&HRRRDAS_CUTOFF;">@Y@m@d@H@M</cyclestr></timedep>
+	     </or>
+	   </and>
       </and>
      </dependency>
   </task>


Reviews:
user: login: MatthewMorris-NOAA
body: Looks good, overall, but there was a typo in the timedep line.
state: CHANGES_REQUESTED
author_association: COLLABORATOR
submitted_at: 2025-04-16T19:56:41Z
user: login: MatthewMorris-NOAA
state: CHANGES_REQUESTED
author_association: COLLABORATOR
submitted_at: 2025-04-16T20:24:52Z
user: login: MatthewMorris-NOAA
body: The way the dependency is written now will force the GSI step to run even if the prepobs and prepfgs steps haven't run.  Is that the intention?

I would have thought that we would require the prepobs and prepfgs steps to run. Then have an either or dependency where either the 36 HRRRDAS members are available or we run at 32 past with GDAS instead.
state: COMMENTED
author_association: COLLABORATOR
submitted_at: 2025-04-17T12:11:35Z
user: login: MatthewMorris-NOAA
state: APPROVED
author_association: COLLABORATOR
submitted_at: 2025-04-17T13:53:02Z

Review comments:
diff_hunk: @@ -1170,9 +1176,48 @@
     &ENVARS_GSI;
 
     <dependency>
-      <and>
-           <taskdep task="&RUN;_prepfgs_task"/> 
+      <and> 
+	   <taskdep task="&RUN;_prepfgs_task"/> 
            <taskdep task="&RUN;_prepobs_task"/>
+	   <datadep age="10"><cyclestr offset="-3600">&COMINHRRRDAS;/hrrrdas_small_d02_@Y@m@d@H00f01_mem0001</cyclestr></datadep>
+           <datadep age="10"><cyclestr offset="-3600">&COMINHRRRDAS;/hrrrdas_small_d02_@Y@m@d@H00f01_mem0002</cyclestr></datadep>
+           <datadep age="10"><cyclestr offset="-3600">&COMINHRRRDAS;/hrrrdas_small_d02_@Y@m@d@H00f01_mem0003</cyclestr></datadep>
+           <datadep age="10"><cyclestr offset="-3600">&COMINHRRRDAS;/hrrrdas_small_d02_@Y@m@d@H00f01_mem0004</cyclestr></datadep>
+           <datadep age="10"><cyclestr offset="-3600">&COMINHRRRDAS;/hrrrdas_small_d02_@Y@m@d@H00f01_mem0005</cyclestr></datadep>
+           <datadep age="10"><cyclestr offset="-3600">&COMINHRRRDAS;/hrrrdas_small_d02_@Y@m@d@H00f01_mem0006</cyclestr></datadep>
+           <datadep age="10"><cyclestr offset="-3600">&COMINHRRRDAS;/hrrrdas_small_d02_@Y@m@d@H00f01_mem0007</cyclestr></datadep>
+           <datadep age="10"><cyclestr offset="-3600">&COMINHRRRDAS;/hrrrdas_small_d02_@Y@m@d@H00f01_mem0008</cyclestr></datadep>
+           <datadep age="10"><cyclestr offset="-3600">&COMINHRRRDAS;/hrrrdas_small_d02_@Y@m@d@H00f01_mem0009</cyclestr></datadep>
+           <datadep age="10"><cyclestr offset="-3600">&COMINHRRRDAS;/hrrrdas_small_d02_@Y@m@d@H00f01_mem0010</cyclestr></datadep>
+           <datadep age="10"><cyclestr offset="-3600">&COMINHRRRDAS;/hrrrdas_small_d02_@Y@m@d@H00f01_mem0011</cyclestr></datadep>
+           <datadep age="10"><cyclestr offset="-3600">&COMINHRRRDAS;/hrrrdas_small_d02_@Y@m@d@H00f01_mem0012</cyclestr></datadep>
+           <datadep age="10"><cyclestr offset="-3600">&COMINHRRRDAS;/hrrrdas_small_d02_@Y@m@d@H00f01_mem0013</cyclestr></datadep>
+           <datadep age="10"><cyclestr offset="-3600">&COMINHRRRDAS;/hrrrdas_small_d02_@Y@m@d@H00f01_mem0014</cyclestr></datadep>
+           <datadep age="10"><cyclestr offset="-3600">&COMINHRRRDAS;/hrrrdas_small_d02_@Y@m@d@H00f01_mem0015</cyclestr></datadep>
+           <datadep age="10"><cyclestr offset="-3600">&COMINHRRRDAS;/hrrrdas_small_d02_@Y@m@d@H00f01_mem0016</cyclestr></datadep>
+           <datadep age="10"><cyclestr offset="-3600">&COMINHRRRDAS;/hrrrdas_small_d02_@Y@m@d@H00f01_mem0017</cyclestr></datadep>
+           <datadep age="10"><cyclestr offset="-3600">&COMINHRRRDAS;/hrrrdas_small_d02_@Y@m@d@H00f01_mem0018</cyclestr></datadep>
+           <datadep age="10"><cyclestr offset="-3600">&COMINHRRRDAS;/hrrrdas_small_d02_@Y@m@d@H00f01_mem0019</cyclestr></datadep>
+           <datadep age="10"><cyclestr offset="-3600">&COMINHRRRDAS;/hrrrdas_small_d02_@Y@m@d@H00f01_mem0020</cyclestr></datadep>
+           <datadep age="10"><cyclestr offset="-3600">&COMINHRRRDAS;/hrrrdas_small_d02_@Y@m@d@H00f01_mem0021</cyclestr></datadep>
+           <datadep age="10"><cyclestr offset="-3600">&COMINHRRRDAS;/hrrrdas_small_d02_@Y@m@d@H00f01_mem0022</cyclestr></datadep>
+           <datadep age="10"><cyclestr offset="-3600">&COMINHRRRDAS;/hrrrdas_small_d02_@Y@m@d@H00f01_mem0023</cyclestr></datadep>
+           <datadep age="10"><cyclestr offset="-3600">&COMINHRRRDAS;/hrrrdas_small_d02_@Y@m@d@H00f01_mem0024</cyclestr></datadep>
+           <datadep age="10"><cyclestr offset="-3600">&COMINHRRRDAS;/hrrrdas_small_d02_@Y@m@d@H00f01_mem0025</cyclestr></datadep>
+           <datadep age="10"><cyclestr offset="-3600">&COMINHRRRDAS;/hrrrdas_small_d02_@Y@m@d@H00f01_mem0026</cyclestr></datadep>
+           <datadep age="10"><cyclestr offset="-3600">&COMINHRRRDAS;/hrrrdas_small_d02_@Y@m@d@H00f01_mem0027</cyclestr></datadep>
+           <datadep age="10"><cyclestr offset="-3600">&COMINHRRRDAS;/hrrrdas_small_d02_@Y@m@d@H00f01_mem0028</cyclestr></datadep>
+           <datadep age="10"><cyclestr offset="-3600">&COMINHRRRDAS;/hrrrdas_small_d02_@Y@m@d@H00f01_mem0029</cyclestr></datadep>
+           <datadep age="10"><cyclestr offset="-3600">&COMINHRRRDAS;/hrrrdas_small_d02_@Y@m@d@H00f01_mem0030</cyclestr></datadep>
+           <datadep age="10"><cyclestr offset="-3600">&COMINHRRRDAS;/hrrrdas_small_d02_@Y@m@d@H00f01_mem0031</cyclestr></datadep>
+           <datadep age="10"><cyclestr offset="-3600">&COMINHRRRDAS;/hrrrdas_small_d02_@Y@m@d@H00f01_mem0032</cyclestr></datadep>
+           <datadep age="10"><cyclestr offset="-3600">&COMINHRRRDAS;/hrrrdas_small_d02_@Y@m@d@H00f01_mem0033</cyclestr></datadep>
+           <datadep age="10"><cyclestr offset="-3600">&COMINHRRRDAS;/hrrrdas_small_d02_@Y@m@d@H00f01_mem0034</cyclestr></datadep>
+           <datadep age="10"><cyclestr offset="-3600">&COMINHRRRDAS;/hrrrdas_small_d02_@Y@m@d@H00f01_mem0035</cyclestr></datadep>
+           <datadep age="10"><cyclestr offset="-3600">&COMINHRRRDAS;/hrrrdas_small_d02_@Y@m@d@H00f01_mem0036</cyclestr></datadep>
+           <or>
+		<timedep><cyclestr @Y@m@d@H&HRRRDAS_CUTOFF;@S</cyclestr></timedep>
path: workflow/rtma3d_pbspro_conus.xml
user: login: MatthewMorris-NOAA
body: There is an error in this timdep line.
created_at: 2025-04-16T19:55:07Z
author_association: COLLABORATOR
diff_hunk: @@ -1216,7 +1216,7 @@
            <datadep age="10"><cyclestr offset="-3600">&COMINHRRRDAS;/hrrrdas_small_d02_@Y@m@d@H00f01_mem0035</cyclestr></datadep>
            <datadep age="10"><cyclestr offset="-3600">&COMINHRRRDAS;/hrrrdas_small_d02_@Y@m@d@H00f01_mem0036</cyclestr></datadep>
            <or>
-		<timedep><cyclestr @Y@m@d@H&HRRRDAS_CUTOFF;@S</cyclestr></timedep>
+		<timedep><cyclestr>@Y@m@d@H&HRRRDAS_CUTOFF;@S</cyclestr></timedep>
path: workflow/rtma3d_pbspro_conus.xml
user: login: MatthewMorris-NOAA
body: There is still the issue of HRRRDAS_CUTOFF being in the middle of the time string.
created_at: 2025-04-16T20:24:47Z
author_association: COLLABORATOR
diff_hunk: @@ -200,7 +202,7 @@
 
 <!ENTITY ACCOUNT         "RTMA-DEV">
 <!ENTITY QUEUE           "dev">
-<!ENTITY QUEUE_DBG       "debug">
+<!ENTITY QUEUE_DBG       "debug">/time_int\
path: workflow/rtma3d_pbspro_conus.xml
user: login: MatthewMorris-NOAA
body: what is the reason for adding time_int to this?
created_at: 2025-04-17T12:06:50Z
author_association: COLLABORATOR

PR comments:
user: login: MatthewMorris-NOAA
created_at: 2025-04-16T19:16:34Z
body: Hi @EdwardColon-NOAA, Is the data dependency age for 10 minutes or 10 seconds? Also, we need a way to run the analysis using GDAS files as back-up in the event the HRRRDAS files are significantly delayed or missing.  Can we add in a hard-wired start time, where the analysis will run at a given time, say 32 minutes, even if the HRRRDAS dependencies are not met?
author_association: COLLABORATOR
user: login: EdwardColon-NOAA
created_at: 2025-04-16T19:24:02Z
body: Hi Matt,

The age dependency is given in seconds assuming that a partially written
file would be completed within that time frame. I'll add an "or" dependency
for time limit that will trigger the use of gdas but let's see if we can
get this added first at a minimum.

-Edward

On Wed, Apr 16, 2025 at 3:17 PM MatthewMorris-NOAA ***@***.***>
wrote:

> Hi @EdwardColon-NOAA <https://github.com/EdwardColon-NOAA>, Is the data
> dependency age for 10 minutes or 10 seconds? Also, we need a way to run the
> analysis using GDAS files as back-up in the event the HRRRDAS files are
> significantly delayed or missing. Can we add in a hard-wired start time,
> where the analysis will run at a given time, say 32 minutes, even if the
> HRRRDAS dependencies are not met?
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/NOAA-EMC/NOAA_3drtma/pull/41#issuecomment-2810524503>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ACFXXQF2NH6QJQWJNPTK6DD2Z2UCPAVCNFSM6AAAAAB3JCCDRKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMJQGUZDINJQGM>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
> *MatthewMorris-NOAA* left a comment (NOAA-EMC/NOAA_3drtma#41)
> <https://github.com/NOAA-EMC/NOAA_3drtma/pull/41#issuecomment-2810524503>
>
> Hi @EdwardColon-NOAA <https://github.com/EdwardColon-NOAA>, Is the data
> dependency age for 10 minutes or 10 seconds? Also, we need a way to run the
> analysis using GDAS files as back-up in the event the HRRRDAS files are
> significantly delayed or missing. Can we add in a hard-wired start time,
> where the analysis will run at a given time, say 32 minutes, even if the
> HRRRDAS dependencies are not met?
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/NOAA-EMC/NOAA_3drtma/pull/41#issuecomment-2810524503>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ACFXXQF2NH6QJQWJNPTK6DD2Z2UCPAVCNFSM6AAAAAB3JCCDRKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMJQGUZDINJQGM>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>


-- 
-------------------------------------------------
Edward Colón
*Lynker* at NOAA/NWS/NCEP/EMC
5830 University Research Ct.
Rm #2025
Riverdale, MD 20737
Office: (301) 683-3815
Cell: (301) 213-3566

author_association: CONTRIBUTOR
user: login: MatthewMorris-NOAA
created_at: 2025-04-16T19:31:40Z
body: Hi Ed, I'd prefer to see the full dependency in place before this PR is merged and used in the official parallels.
author_association: COLLABORATOR
user: login: EdwardColon-NOAA
created_at: 2025-04-16T19:58:40Z
body: Thanks,

I'll fix it and am adding the logic to the gsianl exscript.

-Edward

On Wed, Apr 16, 2025 at 3:57 PM MatthewMorris-NOAA ***@***.***>
wrote:

> ***@***.**** requested changes on this pull request.
>
> Looks good, overall, but there was a typo in the timedep line.
> ------------------------------
>
> In workflow/rtma3d_pbspro_conus.xml
> <https://github.com/NOAA-EMC/NOAA_3drtma/pull/41#discussion_r2047648361>:
>
> > +           <datadep age="10"><cyclestr ***@***.***@***@***.***@H00f01_mem0023</cyclestr></datadep>
> +           <datadep age="10"><cyclestr ***@***.***@***@***.***@H00f01_mem0024</cyclestr></datadep>
> +           <datadep age="10"><cyclestr ***@***.***@***@***.***@H00f01_mem0025</cyclestr></datadep>
> +           <datadep age="10"><cyclestr ***@***.***@***@***.***@H00f01_mem0026</cyclestr></datadep>
> +           <datadep age="10"><cyclestr ***@***.***@***@***.***@H00f01_mem0027</cyclestr></datadep>
> +           <datadep age="10"><cyclestr ***@***.***@***@***.***@H00f01_mem0028</cyclestr></datadep>
> +           <datadep age="10"><cyclestr ***@***.***@***@***.***@H00f01_mem0029</cyclestr></datadep>
> +           <datadep age="10"><cyclestr ***@***.***@***@***.***@H00f01_mem0030</cyclestr></datadep>
> +           <datadep age="10"><cyclestr ***@***.***@***@***.***@H00f01_mem0031</cyclestr></datadep>
> +           <datadep age="10"><cyclestr ***@***.***@***@***.***@H00f01_mem0032</cyclestr></datadep>
> +           <datadep age="10"><cyclestr ***@***.***@***@***.***@H00f01_mem0033</cyclestr></datadep>
> +           <datadep age="10"><cyclestr ***@***.***@***@***.***@H00f01_mem0034</cyclestr></datadep>
> +           <datadep age="10"><cyclestr ***@***.***@***@***.***@H00f01_mem0035</cyclestr></datadep>
> +           <datadep age="10"><cyclestr ***@***.***@***@***.***@H00f01_mem0036</cyclestr></datadep>
> +           <or>
> +		<timedep><cyclestr @***@***.***@***@***.******@***.***</cyclestr></timedep>
>
> There is an error in this timdep line.
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/NOAA-EMC/NOAA_3drtma/pull/41#pullrequestreview-2773686203>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ACFXXQG7KI6PTZFSFWMDNXL2Z2YY5AVCNFSM6AAAAAB3JCCDRKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDONZTGY4DMMRQGM>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>


-- 
-------------------------------------------------
Edward Colón
*Lynker* at NOAA/NWS/NCEP/EMC
5830 University Research Ct.
Rm #2025
Riverdale, MD 20737
Office: (301) 683-3815
Cell: (301) 213-3566

author_association: CONTRIBUTOR