Repository: alyf-de/banking
Pull request #208: chore: move to pyproject.toml (GDE-140)
Author: login: MarcCon
Created: 2025-04-23T11:04:59Z | Merged: 2025-04-23T12:52:30Z

- chore: move to `pyproject.toml`


Diff:
diff --git a/pyproject.toml b/pyproject.toml
new file mode 100644
index 00000000..ab69580b
--- /dev/null
+++ b/pyproject.toml
@@ -0,0 +1,52 @@
+[project]
+name = "banking"
+authors = [
+    { name = "ALYF GmbH", email = "hallo@alyf.de"}
+]
+description = "Banking Integration by ALYF GmbH"
+requires-python = ">=3.10"
+readme = "README.md"
+dynamic = ["version"]
+dependencies = [
+    # frappe -- https://github.com/frappe/frappe is installed via 'bench init'
+    "fintech~=7.6.4"
+]
+
+[build-system]
+requires = ["flit_core >=3.4,<4"]
+build-backend = "flit_core.buildapi"
+
+[tool.bench.frappe-dependencies]
+frappe = ">=15.60.0,<16.0.0"
+erpnext = ">=15.57.0,<16.0.0"
+
+[tool.ruff]
+line-length = 110
+target-version = "py310"
+
+[tool.ruff.lint]
+select = [
+    "F",
+    "E",
+    "W",
+    "I",
+    "UP",
+    "B",
+    "RUF",
+]
+ignore = [
+    "E101", # indentation contains mixed spaces and tabs
+    "E402", # module level import not at top of file
+    "W191", # indentation contains tabs
+]
+typing-modules = ["frappe.types.DF"]
+
+[tool.ruff.format]
+quote-style = "double"
+indent-style = "tab"
+docstring-code-format = true
+
+[project.urls]
+Homepage = "https://www.alyf.de/bank-integration"
+Repository = "https://github.com/alyf-de/banking.git"
+"Bug Reports" = "https://github.com/alyf-de/banking/issues"
\ No newline at end of file
diff --git a/requirements.txt b/requirements.txt
deleted file mode 100644
index b129539c..00000000
--- a/requirements.txt
+++ /dev/null
@@ -1,2 +0,0 @@
-# frappe -- https://github.com/frappe/frappe is installed via 'bench init'
-fintech==7.6.4
diff --git a/setup.py b/setup.py
deleted file mode 100644
index df6d2793..00000000
--- a/setup.py
+++ /dev/null
@@ -1,19 +0,0 @@
-from setuptools import setup, find_packages
-
-with open("requirements.txt") as f:
-	install_requires = f.read().strip().split("\n")
-
-# get version from __version__ variable in banking/__init__.py
-from banking import __version__ as version
-
-setup(
-	name="banking",
-	version=version,
-	description="Banking Integration by ALYF GmbH",
-	author="ALYF GmbH",
-	author_email="hallo@alyf.de",
-	packages=find_packages(),
-	zip_safe=False,
-	include_package_data=True,
-	install_requires=install_requires,
-)


Reviews:
user: login: barredterra
state: CHANGES_REQUESTED
author_association: MEMBER
submitted_at: 2025-04-23T11:49:23Z

Review comments:
diff_hunk: @@ -0,0 +1,51 @@
+[project]
+name = "banking"
+authors = [
+    { name = "ALYF GmbH", email = "hallo@alyf.de"}
+]
+description = "Banking Integration by ALYF GmbH"
+requires-python = ">=3.10"
+readme = "README.md"
+dynamic = ["version"]
+dependencies = [
+    # frappe -- https://github.com/frappe/frappe is installed via 'bench init'
+    "fintech~=7.6.4"
+]
+
+[build-system]
+requires = ["flit_core >=3.4,<4"]
+build-backend = "flit_core.buildapi"
+
+[tool.bench.frappe-dependencies]
+frappe = ">=15.40.4,<16.0.0"
path: pyproject.toml
user: login: barredterra
body: ```suggestion
frappe = ">=15.60.0,<16.0.0"
erpnext = ">=15.57.0,<16.0.0"
```
created_at: 2025-04-23T11:47:37Z
author_association: MEMBER
diff_hunk: @@ -0,0 +1,51 @@
+[project]
+name = "banking"
+authors = [
+    { name = "ALYF GmbH", email = "hallo@alyf.de"}
+]
+description = "Banking Integration by ALYF GmbH"
+requires-python = ">=3.10"
+readme = "README.md"
+dynamic = ["version"]
+dependencies = [
+    # frappe -- https://github.com/frappe/frappe is installed via 'bench init'
+    "fintech~=7.6.4"
+]
+
+[build-system]
+requires = ["flit_core >=3.4,<4"]
+build-backend = "flit_core.buildapi"
+
+[tool.bench.frappe-dependencies]
+frappe = ">=15.40.4,<16.0.0"
+
+[tool.ruff]
+line-length = 110
+target-version = "py310"
+
+[tool.ruff.lint]
+select = [
+    "F",
+    "E",
+    "W",
+    "I",
+    "UP",
+    "B",
+    "RUF",
+]
+ignore = [
+    "E101", # indentation contains mixed spaces and tabs
+    "E402", # module level import not at top of file
+    "W191", # indentation contains tabs
+]
+typing-modules = ["frappe.types.DF"]
+
+[tool.ruff.format]
+quote-style = "double"
+indent-style = "tab"
+docstring-code-format = true
+
+[project.urls]
+Homepage = "https://github.com/alyf-de/banking"
path: pyproject.toml
user: login: barredterra
body: ```suggestion
Homepage = "https://www.alyf.de/bank-integration"
```
created_at: 2025-04-23T11:48:09Z
author_association: MEMBER

PR comments:
user: login: barredterra
created_at: 2025-04-29T18:11:02Z
body: @Mergifyio backport version-14-hotfix
author_association: MEMBER
user: login: mergify[bot]
created_at: 2025-04-29T18:11:09Z
body: > backport version-14-hotfix

#### ✅ Backports have been created

<details>

* [#213 chore: move to pyproject.toml (GDE-140) (backport #208)](https://github.com/alyf-de/banking/pull/213) has been created for branch `version-14-hotfix`

</details>


<!---
DO NOT EDIT
-*- Mergify Payload -*-
{"command": "backport version-14-hotfix", "conclusion": "success", "action_is_running": true}
-*- Mergify Payload End -*-
-->
author_association: CONTRIBUTOR