Repository: red-hat-data-services/ods-ci
Pull request #2395: [model server]Fix test for upgrade
Author: login: mwaykole
Labels: name: lgtm
name: approved
Created: 2025-04-14T15:17:32Z | Merged: 2025-04-14T15:56:09Z



Diff:
diff --git a/ods_ci/tests/Tests/0200__rhoai_upgrade/0201__pre_upgrade.robot b/ods_ci/tests/Tests/0200__rhoai_upgrade/0201__pre_upgrade.robot
index 7aa15cacf..f7606448f 100644
--- a/ods_ci/tests/Tests/0200__rhoai_upgrade/0201__pre_upgrade.robot
+++ b/ods_ci/tests/Tests/0200__rhoai_upgrade/0201__pre_upgrade.robot
@@ -93,40 +93,45 @@ Verify User Can Disable The Runtime
 Verify Model Can Be Deployed For Upgrade
     # robocop: off=too-long-test-case
     # robocop: off=too-many-calls-in-test-case
-    [Documentation]    Verify Model Can Be Deployed Via UI For Upgrade
+    [Documentation]    Verify Model Can Be Deployed Via cli For Upgrade
     [Tags]                  Upgrade    ModelServing    ModelServer
-    Set Suite Variable    ${TEST_NS}    ovmsmodel-upgrade
-    Set Suite Variable    ${KSERVE_MODE}    RawDeployment    # RawDeployment   # Serverless
-    Set Suite Variable    ${MODELS_BUCKET}    ${S3.BUCKET_1}
-    Set Suite Variable    ${INFERENCE_INPUT}    @tests/Resources/Files/modelmesh-mnist-input.json
-    Set Suite Variable    ${EXPECTED_INFERENCE_OUTPUT}    {"model_name": "test-dir","model_version": "1","outputs": [{"name": "Plus214_Output_0","shape": [1, 10],"datatype": "FP32","data": [-8.233053207397461, -7.749703407287598, -3.4236814975738527, 12.363029479980469, -12.079103469848633, 17.2665958404541, -10.570976257324219, 0.7130761742591858, 3.3217151165008547, 1.3621227741241456]}]}  #robocop: disable
-    Setup Test Variables    model_name=test-dir    use_pvc=${TRUE}    use_gpu=${FALSE}
-    ...    kserve_mode=${KSERVE_MODE}
-    Set Project And Runtime    runtime=ovms-runtime     protocol=http     namespace=${TEST_NS}
-    ...    download_in_pvc=${TRUE}    model_name=${model_name}
-    ...    storage_size=100Mi    memory_request=100Mi
-    ${requests}=    Create Dictionary    memory=1Gi
+    ${test_namespace}=         Set Variable    ovmsmodel-upgrade
+    ${inference_input}=        Set Variable    @tests/Resources/Files/modelmesh-mnist-input.json
+    ${exp_inference_output}=   Set Variable    {"model_name":"ovms-model","model_version":"1","outputs":[{"name":"Plus214_Output_0","datatype":"FP32","shape":[1,10],"data":[-8.233053,-7.7497034,-3.4236815,12.3630295,-12.079103,17.266596,-10.570976,0.7130762,3.321715,1.3621228]}]}    # robocop: off=line-too-long
+    ${model_name}=             Set Variable    ovms-model
+    ${MODEL_FORMAT}=           Set Variable    onnx
+    ${PROTOCOL}=               Set Variable    http
+    ${models_names}=           Create List     ${model_name}
+    ${OVMS_S3_DIR}             Set Variable    test-dir
+    ${OVMS_STORAGE_URI} =      Set Variable    s3://${S3.BUCKET_1.NAME}/${OVMS_S3_DIR}/
+    ${OVMS_RUNTIME_NAME}=      Set Variable    ovms-runtime
+    ${INFERENCESERVICE_FILLED_FILEPATH}=   Set Variable        ${INFERENCESERVICE_FILEPATH_NEW}/isvc_filled.yaml
+    ${DEFAULT_BUCKET_SA_NAME}=   Set Variable    models-bucket-sa
+    ${KSERVE_MODE}=             Set Variable     Serverless
+
+
+    Set Project And Runtime    runtime=${OVMS_RUNTIME_NAME}     protocol=${PROTOCOL}     namespace=${test_namespace}
     Compile Inference Service YAML    isvc_name=${model_name}
-    ...    sa_name=${EMPTY}
-    ...    model_storage_uri=pvc://${model_name}-claim/${model_name}
-    ...    model_format=onnx    serving_runtime=ovms-runtime
-    ...    limits_dict=&{EMPTY}    requests_dict=${requests}    kserve_mode=${KSERVE_MODE}
+    ...    sa_name=${DEFAULT_BUCKET_SA_NAME}
+    ...    model_storage_uri=${OVMS_STORAGE_URI}
+    ...    model_format=${MODEL_FORMAT}    serving_runtime=${OVMS_RUNTIME_NAME}
+    ...    kserve_mode=${KSERVE_MODE}
+
     Deploy Model Via CLI    isvc_filepath=${INFERENCESERVICE_FILLED_FILEPATH}
-    ...    namespace=${TEST_NS}
-    # File is not needed anymore after applying
-    Remove File    ${INFERENCESERVICE_FILLED_FILEPATH}
+    ...    namespace=${test_namespace}
+
     Wait For Pods To Be Ready    label_selector=serving.kserve.io/inferenceservice=${model_name}
-    ...    namespace=${TEST_NS}
-    ${pod_name}=  Get Pod Name    namespace=${TEST_NS}
+    ...    namespace=${test_namespace}
+    ${pod_name}=  Get Pod Name    namespace=${test_namespace}
     ...    label_selector=serving.kserve.io/inferenceservice=${model_name}
     ${service_port}=    Extract Service Port    service_name=${model_name}-predictor    protocol=TCP
-    ...    namespace=${TEST_NS}
+    ...    namespace=${test_namespace}
     IF   "${KSERVE_MODE}"=="RawDeployment"
-        Start Port-forwarding    namespace=${TEST_NS}    pod_name=${pod_name}  local_port=${service_port}
+        Start Port-forwarding    namespace=${test_namespace}    pod_name=${pod_name}  local_port=${service_port}
         ...    remote_port=${service_port}    process_alias=ovms-process
     END
-    Verify Model Inference With Retries   model_name=${model_name}    inference_input=${INFERENCE_INPUT}
-    ...    expected_inference_output=${EXPECTED_INFERENCE_OUTPUT}   project_title=${TEST_NS}
+    Verify Model Inference With Retries   model_name=${model_name}    inference_input=${inference_input}
+    ...    expected_inference_output=${exp_inference_output}   project_title=${test_namespace}
     ...    deployment_mode=Cli  kserve_mode=${KSERVE_MODE}    service_port=${service_port}
     ...    end_point=/v2/models/${model_name}/infer  retries=10
 
diff --git a/ods_ci/tests/Tests/0200__rhoai_upgrade/0203__post_upgrade.robot b/ods_ci/tests/Tests/0200__rhoai_upgrade/0203__post_upgrade.robot
index db9592f4b..7da8a639a 100644
--- a/ods_ci/tests/Tests/0200__rhoai_upgrade/0203__post_upgrade.robot
+++ b/ods_ci/tests/Tests/0200__rhoai_upgrade/0203__post_upgrade.robot
@@ -159,13 +159,12 @@ Test Inference Post RHODS Upgrade
     [Documentation]    Test the inference result after having deployed a model
     [Tags]                  Upgrade    ModelServing    ModelServer
     Set Suite Variable    ${TEST_NS}    ovmsmodel-upgrade
-    Set Suite Variable    ${KSERVE_MODE}    RawDeployment    # RawDeployment   # Serverless
+    Set Suite Variable    ${KSERVE_MODE}    Serverless    # RawDeployment   # Serverless
     Set Suite Variable    ${INFERENCE_INPUT}    @tests/Resources/Files/modelmesh-mnist-input.json
-    Set Suite Variable    ${EXPECTED_INFERENCE_OUTPUT}    {"model_name": "test-dir","model_version": "1","outputs": [{"name": "Plus214_Output_0","shape": [1, 10],"datatype": "FP32","data": [-8.233053207397461, -7.749703407287598, -3.4236814975738527, 12.363029479980469, -12.079103469848633, 17.2665958404541, -10.570976257324219, 0.7130761742591858, 3.3217151165008547, 1.3621227741241456]}]}  #robocop: disable
-    Setup Test Variables    model_name=test-dir    use_pvc=${TRUE}    use_gpu=${FALSE}
+    Set Suite Variable    ${EXPECTED_INFERENCE_OUTPUT}    {"model_name":"ovms-model","model_version":"1","outputs":[{"name":"Plus214_Output_0","datatype":"FP32","shape":[1,10],"data":[-8.233053,-7.7497034,-3.4236815,12.3630295,-12.079103,17.266596,-10.570976,0.7130762,3.321715,1.3621228]}]}    # robocop: off=line-too-long
+    Setup Test Variables    model_name=ovms-model    use_gpu=${FALSE}
     ...    kserve_mode=${KSERVE_MODE}
-    Wait For Pods To Be Ready    label_selector=serving.kserve.io/inferenceservice=${model_name}
-    ...    namespace=${TEST_NS}
+
     ${pod_name}=  Get Pod Name    namespace=${TEST_NS}
     ...    label_selector=serving.kserve.io/inferenceservice=${model_name}
     ${service_port}=    Extract Service Port    service_name=${model_name}-predictor    protocol=TCP
@@ -177,7 +176,7 @@ Test Inference Post RHODS Upgrade
     Verify Model Inference With Retries   model_name=${model_name}    inference_input=${INFERENCE_INPUT}
     ...    expected_inference_output=${EXPECTED_INFERENCE_OUTPUT}   project_title=${TEST_NS}
     ...    deployment_mode=Cli  kserve_mode=${KSERVE_MODE}    service_port=${service_port}
-    ...    end_point=/v2/models/${model_name}/infer  retries=10
+    ...    end_point=/v2/models/${model_name}/infer  retries=2
     [Teardown]      Run     oc delete project ${TEST_NS}
 
 Verify Custom Runtime Exists After Upgrade


Reviews:
user: login: github-advanced-security[bot]
state: COMMENTED
author_association: NONE
submitted_at: 2025-04-14T15:18:17Z
user: login: rnetser
state: APPROVED
author_association: CONTRIBUTOR
submitted_at: 2025-04-14T15:51:49Z
user: login: nehachopra27
state: APPROVED
author_association: CONTRIBUTOR
submitted_at: 2025-04-14T15:52:49Z

Review comments:
diff_hunk: @@ -93,40 +93,45 @@
 Verify Model Can Be Deployed For Upgrade
     # robocop: off=too-long-test-case
     # robocop: off=too-many-calls-in-test-case
-    [Documentation]    Verify Model Can Be Deployed Via UI For Upgrade
+    [Documentation]    Verify Model Can Be Deployed Via cli For Upgrade
     [Tags]                  Upgrade    ModelServing    ModelServer
-    Set Suite Variable    ${TEST_NS}    ovmsmodel-upgrade
-    Set Suite Variable    ${KSERVE_MODE}    RawDeployment    # RawDeployment   # Serverless
-    Set Suite Variable    ${MODELS_BUCKET}    ${S3.BUCKET_1}
-    Set Suite Variable    ${INFERENCE_INPUT}    @tests/Resources/Files/modelmesh-mnist-input.json
-    Set Suite Variable    ${EXPECTED_INFERENCE_OUTPUT}    {"model_name": "test-dir","model_version": "1","outputs": [{"name": "Plus214_Output_0","shape": [1, 10],"datatype": "FP32","data": [-8.233053207397461, -7.749703407287598, -3.4236814975738527, 12.363029479980469, -12.079103469848633, 17.2665958404541, -10.570976257324219, 0.7130761742591858, 3.3217151165008547, 1.3621227741241456]}]}  #robocop: disable
-    Setup Test Variables    model_name=test-dir    use_pvc=${TRUE}    use_gpu=${FALSE}
-    ...    kserve_mode=${KSERVE_MODE}
-    Set Project And Runtime    runtime=ovms-runtime     protocol=http     namespace=${TEST_NS}
-    ...    download_in_pvc=${TRUE}    model_name=${model_name}
-    ...    storage_size=100Mi    memory_request=100Mi
-    ${requests}=    Create Dictionary    memory=1Gi
+    ${test_namespace}=         Set Variable    ovmsmodel-upgrade
+    ${inference_input}=        Set Variable    @tests/Resources/Files/modelmesh-mnist-input.json
+    ${exp_inference_output}=   Set Variable    {"model_name":"ovms-model","model_version":"1","outputs":[{"name":"Plus214_Output_0","datatype":"FP32","shape":[1,10],"data":[-8.233053,-7.7497034,-3.4236815,12.3630295,-12.079103,17.266596,-10.570976,0.7130762,3.321715,1.3621228]}]}    # robocop: off=line-too-long
+    ${model_name}=             Set Variable    ovms-model
+    ${MODEL_FORMAT}=           Set Variable    onnx
+    ${PROTOCOL}=               Set Variable    http
+    ${models_names}=           Create List     ${model_name}
path: ods_ci/tests/Tests/0200__rhoai_upgrade/0201__pre_upgrade.robot
user: login: github-advanced-security[bot]
body: ## Variable '{{ name }}' is assigned but not used

Variable '${models_names}' is assigned but not used

[Show more details](https://github.com/red-hat-data-services/ods-ci/security/code-scanning/28947)
created_at: 2025-04-14T15:18:16Z
author_association: NONE
diff_hunk: @@ -93,40 +93,45 @@
 Verify Model Can Be Deployed For Upgrade
     # robocop: off=too-long-test-case
     # robocop: off=too-many-calls-in-test-case
-    [Documentation]    Verify Model Can Be Deployed Via UI For Upgrade
+    [Documentation]    Verify Model Can Be Deployed Via cli For Upgrade
     [Tags]                  Upgrade    ModelServing    ModelServer
-    Set Suite Variable    ${TEST_NS}    ovmsmodel-upgrade
-    Set Suite Variable    ${KSERVE_MODE}    RawDeployment    # RawDeployment   # Serverless
-    Set Suite Variable    ${MODELS_BUCKET}    ${S3.BUCKET_1}
-    Set Suite Variable    ${INFERENCE_INPUT}    @tests/Resources/Files/modelmesh-mnist-input.json
-    Set Suite Variable    ${EXPECTED_INFERENCE_OUTPUT}    {"model_name": "test-dir","model_version": "1","outputs": [{"name": "Plus214_Output_0","shape": [1, 10],"datatype": "FP32","data": [-8.233053207397461, -7.749703407287598, -3.4236814975738527, 12.363029479980469, -12.079103469848633, 17.2665958404541, -10.570976257324219, 0.7130761742591858, 3.3217151165008547, 1.3621227741241456]}]}  #robocop: disable
-    Setup Test Variables    model_name=test-dir    use_pvc=${TRUE}    use_gpu=${FALSE}
-    ...    kserve_mode=${KSERVE_MODE}
-    Set Project And Runtime    runtime=ovms-runtime     protocol=http     namespace=${TEST_NS}
-    ...    download_in_pvc=${TRUE}    model_name=${model_name}
-    ...    storage_size=100Mi    memory_request=100Mi
-    ${requests}=    Create Dictionary    memory=1Gi
+    ${test_namespace}=         Set Variable    ovmsmodel-upgrade
+    ${inference_input}=        Set Variable    @tests/Resources/Files/modelmesh-mnist-input.json
+    ${exp_inference_output}=   Set Variable    {"model_name":"ovms-model","model_version":"1","outputs":[{"name":"Plus214_Output_0","datatype":"FP32","shape":[1,10],"data":[-8.233053,-7.7497034,-3.4236815,12.3630295,-12.079103,17.266596,-10.570976,0.7130762,3.321715,1.3621228]}]}    # robocop: off=line-too-long
+    ${model_name}=             Set Variable    ovms-model
+    ${MODEL_FORMAT}=           Set Variable    onnx
+    ${PROTOCOL}=               Set Variable    http
+    ${models_names}=           Create List     ${model_name}
path: ods_ci/tests/Tests/0200__rhoai_upgrade/0201__pre_upgrade.robot
user: login: github-advanced-security[bot]
body: ## {{ create_keyword }} can be replaced with VAR

Create List can be replaced with VAR

[Show more details](https://github.com/red-hat-data-services/ods-ci/security/code-scanning/28948)
created_at: 2025-04-14T15:18:16Z
author_association: NONE
diff_hunk: @@ -93,40 +93,45 @@
 Verify Model Can Be Deployed For Upgrade
     # robocop: off=too-long-test-case
     # robocop: off=too-many-calls-in-test-case
-    [Documentation]    Verify Model Can Be Deployed Via UI For Upgrade
+    [Documentation]    Verify Model Can Be Deployed Via cli For Upgrade
     [Tags]                  Upgrade    ModelServing    ModelServer
-    Set Suite Variable    ${TEST_NS}    ovmsmodel-upgrade
-    Set Suite Variable    ${KSERVE_MODE}    RawDeployment    # RawDeployment   # Serverless
-    Set Suite Variable    ${MODELS_BUCKET}    ${S3.BUCKET_1}
-    Set Suite Variable    ${INFERENCE_INPUT}    @tests/Resources/Files/modelmesh-mnist-input.json
-    Set Suite Variable    ${EXPECTED_INFERENCE_OUTPUT}    {"model_name": "test-dir","model_version": "1","outputs": [{"name": "Plus214_Output_0","shape": [1, 10],"datatype": "FP32","data": [-8.233053207397461, -7.749703407287598, -3.4236814975738527, 12.363029479980469, -12.079103469848633, 17.2665958404541, -10.570976257324219, 0.7130761742591858, 3.3217151165008547, 1.3621227741241456]}]}  #robocop: disable
-    Setup Test Variables    model_name=test-dir    use_pvc=${TRUE}    use_gpu=${FALSE}
-    ...    kserve_mode=${KSERVE_MODE}
-    Set Project And Runtime    runtime=ovms-runtime     protocol=http     namespace=${TEST_NS}
-    ...    download_in_pvc=${TRUE}    model_name=${model_name}
-    ...    storage_size=100Mi    memory_request=100Mi
-    ${requests}=    Create Dictionary    memory=1Gi
+    ${test_namespace}=         Set Variable    ovmsmodel-upgrade
+    ${inference_input}=        Set Variable    @tests/Resources/Files/modelmesh-mnist-input.json
+    ${exp_inference_output}=   Set Variable    {"model_name":"ovms-model","model_version":"1","outputs":[{"name":"Plus214_Output_0","datatype":"FP32","shape":[1,10],"data":[-8.233053,-7.7497034,-3.4236815,12.3630295,-12.079103,17.266596,-10.570976,0.7130762,3.321715,1.3621228]}]}    # robocop: off=line-too-long
+    ${model_name}=             Set Variable    ovms-model
+    ${MODEL_FORMAT}=           Set Variable    onnx
+    ${PROTOCOL}=               Set Variable    http
+    ${models_names}=           Create List     ${model_name}
+    ${OVMS_S3_DIR}             Set Variable    test-dir
path: ods_ci/tests/Tests/0200__rhoai_upgrade/0201__pre_upgrade.robot
user: login: github-advanced-security[bot]
body: ## The assignment sign is not consistent within the file. Expected '{{ expected_sign }}' but got '{{ actual_sign }}' instead

The assignment sign is not consistent within the file. Expected '=' but got '' instead

[Show more details](https://github.com/red-hat-data-services/ods-ci/security/code-scanning/28949)
created_at: 2025-04-14T15:18:16Z
author_association: NONE
diff_hunk: @@ -93,40 +93,45 @@
 Verify Model Can Be Deployed For Upgrade
     # robocop: off=too-long-test-case
     # robocop: off=too-many-calls-in-test-case
-    [Documentation]    Verify Model Can Be Deployed Via UI For Upgrade
+    [Documentation]    Verify Model Can Be Deployed Via cli For Upgrade
     [Tags]                  Upgrade    ModelServing    ModelServer
-    Set Suite Variable    ${TEST_NS}    ovmsmodel-upgrade
-    Set Suite Variable    ${KSERVE_MODE}    RawDeployment    # RawDeployment   # Serverless
-    Set Suite Variable    ${MODELS_BUCKET}    ${S3.BUCKET_1}
-    Set Suite Variable    ${INFERENCE_INPUT}    @tests/Resources/Files/modelmesh-mnist-input.json
-    Set Suite Variable    ${EXPECTED_INFERENCE_OUTPUT}    {"model_name": "test-dir","model_version": "1","outputs": [{"name": "Plus214_Output_0","shape": [1, 10],"datatype": "FP32","data": [-8.233053207397461, -7.749703407287598, -3.4236814975738527, 12.363029479980469, -12.079103469848633, 17.2665958404541, -10.570976257324219, 0.7130761742591858, 3.3217151165008547, 1.3621227741241456]}]}  #robocop: disable
-    Setup Test Variables    model_name=test-dir    use_pvc=${TRUE}    use_gpu=${FALSE}
-    ...    kserve_mode=${KSERVE_MODE}
-    Set Project And Runtime    runtime=ovms-runtime     protocol=http     namespace=${TEST_NS}
-    ...    download_in_pvc=${TRUE}    model_name=${model_name}
-    ...    storage_size=100Mi    memory_request=100Mi
-    ${requests}=    Create Dictionary    memory=1Gi
+    ${test_namespace}=         Set Variable    ovmsmodel-upgrade
+    ${inference_input}=        Set Variable    @tests/Resources/Files/modelmesh-mnist-input.json
+    ${exp_inference_output}=   Set Variable    {"model_name":"ovms-model","model_version":"1","outputs":[{"name":"Plus214_Output_0","datatype":"FP32","shape":[1,10],"data":[-8.233053,-7.7497034,-3.4236815,12.3630295,-12.079103,17.266596,-10.570976,0.7130762,3.321715,1.3621228]}]}    # robocop: off=line-too-long
+    ${model_name}=             Set Variable    ovms-model
+    ${MODEL_FORMAT}=           Set Variable    onnx
+    ${PROTOCOL}=               Set Variable    http
+    ${models_names}=           Create List     ${model_name}
+    ${OVMS_S3_DIR}             Set Variable    test-dir
+    ${OVMS_STORAGE_URI} =      Set Variable    s3://${S3.BUCKET_1.NAME}/${OVMS_S3_DIR}/
path: ods_ci/tests/Tests/0200__rhoai_upgrade/0201__pre_upgrade.robot
user: login: github-advanced-security[bot]
body: ## The assignment sign is not consistent within the file. Expected '{{ expected_sign }}' but got '{{ actual_sign }}' instead

The assignment sign is not consistent within the file. Expected '=' but got ' =' instead

[Show more details](https://github.com/red-hat-data-services/ods-ci/security/code-scanning/28950)
created_at: 2025-04-14T15:18:16Z
author_association: NONE
diff_hunk: @@ -93,40 +93,45 @@
 Verify Model Can Be Deployed For Upgrade
     # robocop: off=too-long-test-case
     # robocop: off=too-many-calls-in-test-case
-    [Documentation]    Verify Model Can Be Deployed Via UI For Upgrade
+    [Documentation]    Verify Model Can Be Deployed Via cli For Upgrade
     [Tags]                  Upgrade    ModelServing    ModelServer
-    Set Suite Variable    ${TEST_NS}    ovmsmodel-upgrade
-    Set Suite Variable    ${KSERVE_MODE}    RawDeployment    # RawDeployment   # Serverless
-    Set Suite Variable    ${MODELS_BUCKET}    ${S3.BUCKET_1}
-    Set Suite Variable    ${INFERENCE_INPUT}    @tests/Resources/Files/modelmesh-mnist-input.json
-    Set Suite Variable    ${EXPECTED_INFERENCE_OUTPUT}    {"model_name": "test-dir","model_version": "1","outputs": [{"name": "Plus214_Output_0","shape": [1, 10],"datatype": "FP32","data": [-8.233053207397461, -7.749703407287598, -3.4236814975738527, 12.363029479980469, -12.079103469848633, 17.2665958404541, -10.570976257324219, 0.7130761742591858, 3.3217151165008547, 1.3621227741241456]}]}  #robocop: disable
-    Setup Test Variables    model_name=test-dir    use_pvc=${TRUE}    use_gpu=${FALSE}
-    ...    kserve_mode=${KSERVE_MODE}
-    Set Project And Runtime    runtime=ovms-runtime     protocol=http     namespace=${TEST_NS}
-    ...    download_in_pvc=${TRUE}    model_name=${model_name}
-    ...    storage_size=100Mi    memory_request=100Mi
-    ${requests}=    Create Dictionary    memory=1Gi
+    ${test_namespace}=         Set Variable    ovmsmodel-upgrade
+    ${inference_input}=        Set Variable    @tests/Resources/Files/modelmesh-mnist-input.json
+    ${exp_inference_output}=   Set Variable    {"model_name":"ovms-model","model_version":"1","outputs":[{"name":"Plus214_Output_0","datatype":"FP32","shape":[1,10],"data":[-8.233053,-7.7497034,-3.4236815,12.3630295,-12.079103,17.266596,-10.570976,0.7130762,3.321715,1.3621228]}]}    # robocop: off=line-too-long
+    ${model_name}=             Set Variable    ovms-model
+    ${MODEL_FORMAT}=           Set Variable    onnx
+    ${PROTOCOL}=               Set Variable    http
+    ${models_names}=           Create List     ${model_name}
+    ${OVMS_S3_DIR}             Set Variable    test-dir
+    ${OVMS_STORAGE_URI} =      Set Variable    s3://${S3.BUCKET_1.NAME}/${OVMS_S3_DIR}/
+    ${OVMS_RUNTIME_NAME}=      Set Variable    ovms-runtime
+    ${INFERENCESERVICE_FILLED_FILEPATH}=   Set Variable        ${INFERENCESERVICE_FILEPATH_NEW}/isvc_filled.yaml
+    ${DEFAULT_BUCKET_SA_NAME}=   Set Variable    models-bucket-sa
+    ${KSERVE_MODE}=             Set Variable     Serverless
+
+
path: ods_ci/tests/Tests/0200__rhoai_upgrade/0201__pre_upgrade.robot
user: login: github-advanced-security[bot]
body: ## Too many consecutive empty lines ({{ empty_lines }}/{{ allowed_empty_lines }})

Too many consecutive empty lines (2/1)

[Show more details](https://github.com/red-hat-data-services/ods-ci/security/code-scanning/28951)
created_at: 2025-04-14T15:18:16Z
author_association: NONE
diff_hunk: @@ -159,13 +159,12 @@
     [Documentation]    Test the inference result after having deployed a model
     [Tags]                  Upgrade    ModelServing    ModelServer
     Set Suite Variable    ${TEST_NS}    ovmsmodel-upgrade
-    Set Suite Variable    ${KSERVE_MODE}    RawDeployment    # RawDeployment   # Serverless
+    Set Suite Variable    ${KSERVE_MODE}    Serverless    # RawDeployment   # Serverless
path: ods_ci/tests/Tests/0200__rhoai_upgrade/0203__post_upgrade.robot
user: login: github-advanced-security[bot]
body: ## {{ set_variable_keyword }} can be replaced with VAR

Set Suite Variable can be replaced with VAR

[Show more details](https://github.com/red-hat-data-services/ods-ci/security/code-scanning/28945)
created_at: 2025-04-14T15:18:16Z
author_association: NONE
diff_hunk: @@ -159,13 +159,12 @@
     [Documentation]    Test the inference result after having deployed a model
     [Tags]                  Upgrade    ModelServing    ModelServer
     Set Suite Variable    ${TEST_NS}    ovmsmodel-upgrade
-    Set Suite Variable    ${KSERVE_MODE}    RawDeployment    # RawDeployment   # Serverless
+    Set Suite Variable    ${KSERVE_MODE}    Serverless    # RawDeployment   # Serverless
     Set Suite Variable    ${INFERENCE_INPUT}    @tests/Resources/Files/modelmesh-mnist-input.json
-    Set Suite Variable    ${EXPECTED_INFERENCE_OUTPUT}    {"model_name": "test-dir","model_version": "1","outputs": [{"name": "Plus214_Output_0","shape": [1, 10],"datatype": "FP32","data": [-8.233053207397461, -7.749703407287598, -3.4236814975738527, 12.363029479980469, -12.079103469848633, 17.2665958404541, -10.570976257324219, 0.7130761742591858, 3.3217151165008547, 1.3621227741241456]}]}  #robocop: disable
-    Setup Test Variables    model_name=test-dir    use_pvc=${TRUE}    use_gpu=${FALSE}
+    Set Suite Variable    ${EXPECTED_INFERENCE_OUTPUT}    {"model_name":"ovms-model","model_version":"1","outputs":[{"name":"Plus214_Output_0","datatype":"FP32","shape":[1,10],"data":[-8.233053,-7.7497034,-3.4236815,12.3630295,-12.079103,17.266596,-10.570976,0.7130762,3.321715,1.3621228]}]}    # robocop: off=line-too-long
path: ods_ci/tests/Tests/0200__rhoai_upgrade/0203__post_upgrade.robot
user: login: github-advanced-security[bot]
body: ## {{ set_variable_keyword }} can be replaced with VAR

Set Suite Variable can be replaced with VAR

[Show more details](https://github.com/red-hat-data-services/ods-ci/security/code-scanning/28946)
created_at: 2025-04-14T15:18:17Z
author_association: NONE

PR comments:
user: login: sonarqubecloud[bot]
created_at: 2025-04-14T15:17:58Z
body: ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.io/dashboard?id=red-hat-data-services_ods-ci&pullRequest=2395) **Quality Gate passed**  
Issues  
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 New issues](https://sonarcloud.io/project/issues?id=red-hat-data-services_ods-ci&pullRequest=2395&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png '') [0 Accepted issues](https://sonarcloud.io/project/issues?id=red-hat-data-services_ods-ci&pullRequest=2395&issueStatuses=ACCEPTED)

Measures  
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=red-hat-data-services_ods-ci&pullRequest=2395&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=red-hat-data-services_ods-ci&pullRequest=2395&metric=new_coverage&view=list)  
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=red-hat-data-services_ods-ci&pullRequest=2395&metric=new_duplicated_lines_density&view=list)  
  
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=red-hat-data-services_ods-ci&pullRequest=2395)


author_association: NONE
user: login: openshift-ci[bot]
created_at: 2025-04-14T15:52:54Z
body: [APPROVALNOTIFIER] This PR is **APPROVED**

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: *<a href="https://github.com/red-hat-data-services/ods-ci/pull/2395#" title="Author self-approved">mwaykole</a>*, *<a href="https://github.com/red-hat-data-services/ods-ci/pull/2395#pullrequestreview-2764832015" title="Approved">nehachopra27</a>*, *<a href="https://github.com/red-hat-data-services/ods-ci/pull/2395#pullrequestreview-2764829351" title="Approved">rnetser</a>*

The full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=red-hat-data-services%2Fods-ci).

The pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)

<details >
Needs approval from an approver in each of these files:

- **[OWNERS](https://github.com/red-hat-data-services/ods-ci/blob/master/OWNERS)**

Approvers can indicate their approval by writing `/approve` in a comment
Approvers can cancel approval by writing `/approve cancel` in a comment
</details>
<!-- META={"approvers":[]} -->
author_association: NONE