Repository: checkstyle/checkstyle
Pull request #16532: Issue #15456 Defined violation message for MemberNameCheck
Author: login: Mahmoud-Ayman-Saleh
Created: 2025-03-11T21:04:01Z | Merged: 2025-03-14T04:15:57Z

Issue #15456: Defined violation message for MemberNameCheck


Diff:
diff --git a/src/site/xdoc/checks/naming/membername.xml b/src/site/xdoc/checks/naming/membername.xml
index 99fe5c4c1d4a..02e6604ec0dc 100644
--- a/src/site/xdoc/checks/naming/membername.xml
+++ b/src/site/xdoc/checks/naming/membername.xml
@@ -85,13 +85,13 @@ class Example1 {
   static int num5;
   public static final int CONSTANT = 1;
 
-  public int NUM1; // violation
+  public int NUM1; // violation 'Name 'NUM1' must match pattern'
 
-  protected int NUM2; // violation
+  protected int NUM2; // violation 'Name 'NUM2' must match pattern'
 
-  int NUM3; // violation
+  int NUM3; // violation 'Name 'NUM3' must match pattern'
 
-  private int NUM4; // violation
+  private int NUM4; // violation 'Name 'NUM4' must match pattern'
 
 }
 </code></pre></div>
@@ -116,11 +116,11 @@ class Example1 {
         <p id="Example2-code">Code Example:</p>
         <div class="wrapper"><pre class="prettyprint"><code class="language-java">
 class Example2 {
-  public int num1; // violation
+  public int num1; // violation 'Name 'num1' must match pattern'
 
   protected int num2;
   int num3;
-  private int num4; // violation
+  private int num4; // violation 'Name 'num4' must match pattern'
 
 }
 </code></pre></div>
@@ -142,9 +142,9 @@ class Example2 {
         <div class="wrapper"><pre class="prettyprint"><code class="language-java">
 class Example3 {
   public int NUM1;
-  protected int NUM2; // violation
+  protected int NUM2; // violation 'Name 'NUM2' must match pattern'
 
-  int NUM3; // violation
+  int NUM3; // violation 'Name 'NUM3' must match pattern'
 
   private int NUM4;
 }
diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/bdd/InlineConfigParser.java b/src/test/java/com/puppycrawl/tools/checkstyle/bdd/InlineConfigParser.java
index b48084802eb9..731d032c30eb 100644
--- a/src/test/java/com/puppycrawl/tools/checkstyle/bdd/InlineConfigParser.java
+++ b/src/test/java/com/puppycrawl/tools/checkstyle/bdd/InlineConfigParser.java
@@ -272,7 +272,6 @@ public final class InlineConfigParser {
             "com.puppycrawl.tools.checkstyle.checks.naming.InterfaceTypeParameterNameCheck",
             "com.puppycrawl.tools.checkstyle.checks.naming.LocalFinalVariableNameCheck",
             "com.puppycrawl.tools.checkstyle.checks.naming.LocalVariableNameCheck",
-            "com.puppycrawl.tools.checkstyle.checks.naming.MemberNameCheck",
             "com.puppycrawl.tools.checkstyle.checks.naming.MethodNameCheck",
             "com.puppycrawl.tools.checkstyle.checks.naming.MethodTypeParameterNameCheck",
             "com.puppycrawl.tools.checkstyle.checks.naming.PackageNameCheck",
diff --git a/src/test/resources/com/puppycrawl/tools/checkstyle/checks/naming/membername/InputMemberName.java b/src/test/resources/com/puppycrawl/tools/checkstyle/checks/naming/membername/InputMemberName.java
index cc4bb578e0fd..166bd1c327fe 100644
--- a/src/test/resources/com/puppycrawl/tools/checkstyle/checks/naming/membername/InputMemberName.java
+++ b/src/test/resources/com/puppycrawl/tools/checkstyle/checks/naming/membername/InputMemberName.java
@@ -18,8 +18,8 @@ public class InputMemberName
     int mPackage;//comment
     private int mPrivate;
 
-    public int _public; // violation
-    protected int _protected; // violation
-    int _package; // violation
-    private int _private; // violation
+    public int _public; // violation 'Name '_public' must match pattern'
+    protected int _protected; // violation 'Name '_protected' must match pattern'
+    int _package; // violation 'Name '_package' must match pattern'
+    private int _private; // violation 'Name '_private' must match pattern'
 }
diff --git a/src/test/resources/com/puppycrawl/tools/checkstyle/checks/naming/membername/InputMemberName2.java b/src/test/resources/com/puppycrawl/tools/checkstyle/checks/naming/membername/InputMemberName2.java
index 193914fc2693..5c67b558268f 100644
--- a/src/test/resources/com/puppycrawl/tools/checkstyle/checks/naming/membername/InputMemberName2.java
+++ b/src/test/resources/com/puppycrawl/tools/checkstyle/checks/naming/membername/InputMemberName2.java
@@ -13,10 +13,10 @@
 
 public class InputMemberName2
 {
-    public int mPublic; // violation
-    protected int mProtected; // violation
-    int mPackage; // violation
-    private int mPrivate; // violation
+    public int mPublic; // violation 'Name 'mPublic' must match pattern'
+    protected int mProtected; // violation 'Name 'mProtected' must match pattern'
+    int mPackage; // violation 'Name 'mPackage' must match pattern'
+    private int mPrivate; // violation 'Name 'mPrivate' must match pattern'
 
     public int _public;
     protected int _protected;
diff --git a/src/test/resources/com/puppycrawl/tools/checkstyle/checks/naming/membername/InputMemberName3.java b/src/test/resources/com/puppycrawl/tools/checkstyle/checks/naming/membername/InputMemberName3.java
index e7f8f7e1fbeb..0efbd2c05938 100644
--- a/src/test/resources/com/puppycrawl/tools/checkstyle/checks/naming/membername/InputMemberName3.java
+++ b/src/test/resources/com/puppycrawl/tools/checkstyle/checks/naming/membername/InputMemberName3.java
@@ -13,7 +13,7 @@
 
 public class InputMemberName3
 {
-    public int mPublic; // violation
+    public int mPublic; // violation 'Name 'mPublic' must match pattern'
     protected int mProtected;
     int mPackage;//comment
     private int mPrivate;
diff --git a/src/test/resources/com/puppycrawl/tools/checkstyle/checks/naming/membername/InputMemberName4.java b/src/test/resources/com/puppycrawl/tools/checkstyle/checks/naming/membername/InputMemberName4.java
index 42c2890d2268..bcd16554cdbb 100644
--- a/src/test/resources/com/puppycrawl/tools/checkstyle/checks/naming/membername/InputMemberName4.java
+++ b/src/test/resources/com/puppycrawl/tools/checkstyle/checks/naming/membername/InputMemberName4.java
@@ -14,7 +14,7 @@
 public class InputMemberName4
 {
     public int mPublic;
-    protected int mProtected; // violation
+    protected int mProtected; // violation 'Name 'mProtected' must match pattern'
     int mPackage;//comment
     private int mPrivate;
 
diff --git a/src/test/resources/com/puppycrawl/tools/checkstyle/checks/naming/membername/InputMemberName5.java b/src/test/resources/com/puppycrawl/tools/checkstyle/checks/naming/membername/InputMemberName5.java
index 7243b66c4759..9c20246d72f4 100644
--- a/src/test/resources/com/puppycrawl/tools/checkstyle/checks/naming/membername/InputMemberName5.java
+++ b/src/test/resources/com/puppycrawl/tools/checkstyle/checks/naming/membername/InputMemberName5.java
@@ -15,7 +15,7 @@ public class InputMemberName5
 {
     public int mPublic;
     protected int mProtected;
-    int mPackage; // violation
+    int mPackage; // violation 'Name 'mPackage' must match pattern'
     private int mPrivate;
 
     public int _public;
diff --git a/src/test/resources/com/puppycrawl/tools/checkstyle/checks/naming/membername/InputMemberName6.java b/src/test/resources/com/puppycrawl/tools/checkstyle/checks/naming/membername/InputMemberName6.java
index c2a397a85c3b..0585618de8ec 100644
--- a/src/test/resources/com/puppycrawl/tools/checkstyle/checks/naming/membername/InputMemberName6.java
+++ b/src/test/resources/com/puppycrawl/tools/checkstyle/checks/naming/membername/InputMemberName6.java
@@ -16,7 +16,7 @@ public class InputMemberName6
     public int mPublic;
     protected int mProtected;
     int mPackage;//comment
-    private int mPrivate; // violation
+    private int mPrivate; // violation 'Name 'mPrivate' must match pattern'
 
     public int _public;
     protected int _protected;
diff --git a/src/test/resources/com/puppycrawl/tools/checkstyle/checks/naming/membername/InputMemberName7.java b/src/test/resources/com/puppycrawl/tools/checkstyle/checks/naming/membername/InputMemberName7.java
index 23cfd48c8e9b..6d79b1cd3a80 100644
--- a/src/test/resources/com/puppycrawl/tools/checkstyle/checks/naming/membername/InputMemberName7.java
+++ b/src/test/resources/com/puppycrawl/tools/checkstyle/checks/naming/membername/InputMemberName7.java
@@ -18,8 +18,8 @@ public class InputMemberName7
     int mPackage;//comment
     private int mPrivate;
 
-    public int _public; // violation
-    protected int _protected; // violation
-    int _package; // violation
+    public int _public; // violation 'Name '_public' must match pattern'
+    protected int _protected; // violation 'Name '_protected' must match pattern'
+    int _package; // violation 'Name '_package' must match pattern'
     private int _private;
 }
diff --git a/src/test/resources/com/puppycrawl/tools/checkstyle/checks/naming/membername/InputMemberNameExtended.java b/src/test/resources/com/puppycrawl/tools/checkstyle/checks/naming/membername/InputMemberNameExtended.java
index 66ac451ab25d..8683a14fdb08 100644
--- a/src/test/resources/com/puppycrawl/tools/checkstyle/checks/naming/membername/InputMemberNameExtended.java
+++ b/src/test/resources/com/puppycrawl/tools/checkstyle/checks/naming/membername/InputMemberNameExtended.java
@@ -16,38 +16,38 @@
 
 public class InputMemberNameExtended
 {
-    public int mPublic; // violation
-    protected int mProtected; // violation
-    int mPackage; // violation
-    private int mPrivate; // violation
+    public int mPublic; // violation 'Name 'mPublic' must match pattern'
+    protected int mProtected; // violation 'Name 'mProtected' must match pattern'
+    int mPackage; // violation 'Name 'mPackage' must match pattern'
+    private int mPrivate; // violation 'Name 'mPrivate' must match pattern'
 
-    public int _public; // violation
-    protected int _protected; // violation
-    int _package; // violation
-    private int _private; // violation
+    public int _public; // violation 'Name '_public' must match pattern'
+    protected int _protected; // violation 'Name '_protected' must match pattern'
+    int _package; // violation 'Name '_package' must match pattern'
+    private int _private; // violation 'Name '_private' must match pattern'
 
     class Inner {
-        public int mPublic; // violation
-        protected int mProtected; // violation
-        int mPackage; // violation
-        private int mPrivate; // violation
-
-        public int _public; // violation
-        protected int _protected; // violation
-        int _package; // violation
-        private int _private; // violation
+        public int mPublic; // violation 'Name 'mPublic' must match pattern'
+        protected int mProtected; // violation 'Name 'mProtected' must match pattern'
+        int mPackage; // violation 'Name 'mPackage' must match pattern'
+        private int mPrivate; // violation 'Name 'mPrivate' must match pattern'
+
+        public int _public; // violation 'Name '_public' must match pattern'
+        protected int _protected; // violation 'Name '_protected' must match pattern'
+        int _package; // violation 'Name '_package' must match pattern'
+        private int _private; // violation 'Name '_private' must match pattern'
     }
 
     Inner anon = new Inner() {
-        public int mPublic; // violation
-        protected int mProtected; // violation
-        int mPackage; // violation
-        private int mPrivate; // violation
-
-        public int _public; // violation
-        protected int _protected; // violation
-        int _package; // violation
-        private int _private; // violation
+        public int mPublic; // violation 'Name 'mPublic' must match pattern'
+        protected int mProtected; // violation 'Name 'mProtected' must match pattern'
+        int mPackage; // violation 'Name 'mPackage' must match pattern'
+        private int mPrivate; // violation 'Name 'mPrivate' must match pattern'
+
+        public int _public; // violation 'Name '_public' must match pattern'
+        protected int _protected; // violation 'Name '_protected' must match pattern'
+        int _package; // violation 'Name '_package' must match pattern'
+        private int _private; // violation 'Name '_private' must match pattern'
     };
 }
 
@@ -71,15 +71,15 @@ enum Direction {
     EAST(-2),
     WEST(2);
 
-    public int mPublic = 0; // violation
-    int mProtected = 0; // violation
-    int mPackage = 0; // violation
-    int mPrivate = 0; // violation
+    public int mPublic = 0; // violation 'Name 'mPublic' must match pattern'
+    int mProtected = 0; // violation 'Name 'mProtected' must match pattern'
+    int mPackage = 0; // violation 'Name 'mPackage' must match pattern'
+    int mPrivate = 0; // violation 'Name 'mPrivate' must match pattern'
 
-    public int _public = 0; // violation
-    int _protected = 0; // violation
-    int _package = 0; // violation
-    int _private = 0; // violation
+    public int _public = 0; // violation 'Name '_public' must match pattern'
+    int _protected = 0; // violation 'Name '_protected' must match pattern'
+    int _package = 0; // violation 'Name '_package' must match pattern'
+    int _private = 0; // violation 'Name '_private' must match pattern'
 
     Direction(int code){
         this.code=code;
diff --git a/src/test/resources/com/puppycrawl/tools/checkstyle/checks/naming/membername/InputMemberNameInner.java b/src/test/resources/com/puppycrawl/tools/checkstyle/checks/naming/membername/InputMemberNameInner.java
index 5d313b644e72..508869947949 100644
--- a/src/test/resources/com/puppycrawl/tools/checkstyle/checks/naming/membername/InputMemberNameInner.java
+++ b/src/test/resources/com/puppycrawl/tools/checkstyle/checks/naming/membername/InputMemberNameInner.java
@@ -60,7 +60,7 @@ public static void main()
         {
             private static final int CDS = 1;
 
-            private int ABC; // violation
+            private int ABC; // violation 'Name 'ABC' must match pattern'
         };
      }
 
diff --git a/src/test/resources/com/puppycrawl/tools/checkstyle/checks/naming/membername/InputMemberNameSimpleOne.java b/src/test/resources/com/puppycrawl/tools/checkstyle/checks/naming/membername/InputMemberNameSimpleOne.java
index 4fc67410f5cd..11f6b73190f2 100644
--- a/src/test/resources/com/puppycrawl/tools/checkstyle/checks/naming/membername/InputMemberNameSimpleOne.java
+++ b/src/test/resources/com/puppycrawl/tools/checkstyle/checks/naming/membername/InputMemberNameSimpleOne.java
@@ -38,7 +38,7 @@ final class InputMemberNameSimpleOne
     private static int sNumCreated = 0;
 
     /** Invalid format **/
-    private int badMember = 2; // violation
+    private int badMember = 2; // violation 'Name 'badMember' must match pattern'
     /** Valid format **/
     private int mNumCreated1 = 0;
     /** Valid format **/
diff --git a/src/test/resources/com/puppycrawl/tools/checkstyle/checks/naming/membername/InputMemberNameSimpleThree.java b/src/test/resources/com/puppycrawl/tools/checkstyle/checks/naming/membername/InputMemberNameSimpleThree.java
index 9084d4bc30ed..acc3861c3169 100644
--- a/src/test/resources/com/puppycrawl/tools/checkstyle/checks/naming/membername/InputMemberNameSimpleThree.java
+++ b/src/test/resources/com/puppycrawl/tools/checkstyle/checks/naming/membername/InputMemberNameSimpleThree.java
@@ -47,5 +47,5 @@ enum MyEnum1
     XYZ;
 
     /** Should be mSomeMember */
-    private int someMember; // violation
+    private int someMember; // violation 'Name 'someMember' must match pattern'
 }
diff --git a/src/test/resources/com/puppycrawl/tools/checkstyle/grammar/InputGrammar.java b/src/test/resources/com/puppycrawl/tools/checkstyle/grammar/InputGrammar.java
index ff89f047de01..9599834fb658 100644
--- a/src/test/resources/com/puppycrawl/tools/checkstyle/grammar/InputGrammar.java
+++ b/src/test/resources/com/puppycrawl/tools/checkstyle/grammar/InputGrammar.java
@@ -15,5 +15,5 @@
  */
 public class InputGrammar
 {
-    int ÃЯ = 1; // illegal, unless UTF-8 // violation
+    int ÃЯ = 1; // illegal, unless UTF-8 // violation 'Name 'ÃЯ' must match pattern'
 }
diff --git a/src/xdocs-examples/resources/com/puppycrawl/tools/checkstyle/checks/naming/membername/Example1.java b/src/xdocs-examples/resources/com/puppycrawl/tools/checkstyle/checks/naming/membername/Example1.java
index 82cd49ae7f52..574755ffec45 100644
--- a/src/xdocs-examples/resources/com/puppycrawl/tools/checkstyle/checks/naming/membername/Example1.java
+++ b/src/xdocs-examples/resources/com/puppycrawl/tools/checkstyle/checks/naming/membername/Example1.java
@@ -18,13 +18,13 @@ class Example1 {
   static int num5;
   public static final int CONSTANT = 1;
 
-  public int NUM1; // violation
+  public int NUM1; // violation 'Name 'NUM1' must match pattern'
 
-  protected int NUM2; // violation
+  protected int NUM2; // violation 'Name 'NUM2' must match pattern'
 
-  int NUM3; // violation
+  int NUM3; // violation 'Name 'NUM3' must match pattern'
 
-  private int NUM4; // violation
+  private int NUM4; // violation 'Name 'NUM4' must match pattern'
 
 }
 // xdoc section -- end
diff --git a/src/xdocs-examples/resources/com/puppycrawl/tools/checkstyle/checks/naming/membername/Example2.java b/src/xdocs-examples/resources/com/puppycrawl/tools/checkstyle/checks/naming/membername/Example2.java
index fa40d467c0e0..5e55bf7538c9 100644
--- a/src/xdocs-examples/resources/com/puppycrawl/tools/checkstyle/checks/naming/membername/Example2.java
+++ b/src/xdocs-examples/resources/com/puppycrawl/tools/checkstyle/checks/naming/membername/Example2.java
@@ -13,11 +13,11 @@
 
 // xdoc section -- start
 class Example2 {
-  public int num1; // violation
+  public int num1; // violation 'Name 'num1' must match pattern'
 
   protected int num2;
   int num3;
-  private int num4; // violation
+  private int num4; // violation 'Name 'num4' must match pattern'
 
 }
 // xdoc section -- end
diff --git a/src/xdocs-examples/resources/com/puppycrawl/tools/checkstyle/checks/naming/membername/Example3.java b/src/xdocs-examples/resources/com/puppycrawl/tools/checkstyle/checks/naming/membername/Example3.java
index 4e43bfc9f53e..c0f7116b9f88 100644
--- a/src/xdocs-examples/resources/com/puppycrawl/tools/checkstyle/checks/naming/membername/Example3.java
+++ b/src/xdocs-examples/resources/com/puppycrawl/tools/checkstyle/checks/naming/membername/Example3.java
@@ -13,9 +13,9 @@
 // xdoc section -- start
 class Example3 {
   public int NUM1;
-  protected int NUM2; // violation
+  protected int NUM2; // violation 'Name 'NUM2' must match pattern'
 
-  int NUM3; // violation
+  int NUM3; // violation 'Name 'NUM3' must match pattern'
 
   private int NUM4;
 }


Reviews:
user: login: Z4ID-Reaper
state: COMMENTED
author_association: CONTRIBUTOR
submitted_at: 2025-03-12T10:08:43Z
user: login: Z4ID-Reaper
state: COMMENTED
author_association: CONTRIBUTOR
submitted_at: 2025-03-12T10:09:32Z
user: login: Z4ID-Reaper
state: COMMENTED
author_association: CONTRIBUTOR
submitted_at: 2025-03-12T10:13:55Z
user: login: romani
state: COMMENTED
author_association: MEMBER
submitted_at: 2025-03-13T03:57:38Z
user: login: romani
state: COMMENTED
author_association: MEMBER
submitted_at: 2025-03-13T04:01:36Z
user: login: Mahmoud-Ayman-Saleh
state: COMMENTED
author_association: CONTRIBUTOR
submitted_at: 2025-03-13T13:14:36Z
user: login: romani
body: Thanks a lot 
state: APPROVED
author_association: MEMBER
submitted_at: 2025-03-14T04:15:51Z

Review comments:
diff_hunk: @@ -116,11 +116,11 @@ class Example1 {
         <p id="Example2-code">Code Example:</p>
         <div class="wrapper"><pre class="prettyprint"><code class="language-java">
 class Example2 {
-  public int num1; // violation
+  public int num1; // violation 'Name 'num1' must match pattern'
 
   protected int num2;
   int num3;
-  private int num4; // violation
+  private int num4; // violation 'Name 'num2' must match pattern'
path: src/site/xdoc/checks/naming/membername.xml
user: login: Z4ID-Reaper
body: **this is a .xml file** 
i checked your error message in semaphore.ci below is the screenshot of it
![Screenshot 2025-03-12 153246](https://github.com/user-attachments/assets/a272c6da-c993-44b1-84d1-fb7745ce78a6)

try switching it to 'num4' instead of 'num2' 

> ps: i have been stuck with similar error for 1-2 days here is the disscussion for it https://github.com/checkstyle/checkstyle/discussions/16517


created_at: 2025-03-12T10:08:43Z
author_association: CONTRIBUTOR
diff_hunk: @@ -13,11 +13,11 @@
 
 // xdoc section -- start
 class Example2 {
-  public int num1; // violation
+  public int num1; // violation 'Name 'num1' must match pattern'
 
   protected int num2;
   int num3;
-  private int num4; // violation
+  private int num4; // violation 'Name 'num2' must match pattern'
path: src/xdocs-examples/resources/com/puppycrawl/tools/checkstyle/checks/naming/membername/Example2.java
user: login: Z4ID-Reaper
body: switch 'num2'  to 'num4' here
created_at: 2025-03-12T10:09:31Z
author_association: CONTRIBUTOR
diff_hunk: @@ -13,11 +13,11 @@
 
 // xdoc section -- start
 class Example2 {
-  public int num1; // violation
+  public int num1; // violation 'Name 'num1' must match pattern'
 
   protected int num2;
   int num3;
-  private int num4; // violation
+  private int num4; // violation 'Name 'num2' must match pattern'
path: src/xdocs-examples/resources/com/puppycrawl/tools/checkstyle/checks/naming/membername/Example2.java
user: login: Z4ID-Reaper
body: @timurt @romani are community members allowed/permitted to review pull request ?
i am afraid if i might be breaking any rules/guidelines.
created_at: 2025-03-12T10:13:55Z
author_association: CONTRIBUTOR
diff_hunk: @@ -13,11 +13,11 @@
 
 // xdoc section -- start
 class Example2 {
-  public int num1; // violation
+  public int num1; // violation 'Name 'num1' must match pattern'
 
   protected int num2;
   int num3;
-  private int num4; // violation
+  private int num4; // violation 'Name 'num2' must match pattern'
path: src/xdocs-examples/resources/com/puppycrawl/tools/checkstyle/checks/naming/membername/Example2.java
user: login: romani
body: Yes, all are welcome to review 
created_at: 2025-03-13T03:57:38Z
author_association: MEMBER
diff_hunk: @@ -13,11 +13,11 @@
 
 // xdoc section -- start
 class Example2 {
-  public int num1; // violation
+  public int num1; // violation 'Name 'num1' must match pattern'
 
   protected int num2;
   int num3;
-  private int num4; // violation
+  private int num4; // violation 'Name 'num2' must match pattern'
path: src/xdocs-examples/resources/com/puppycrawl/tools/checkstyle/checks/naming/membername/Example2.java
user: login: romani
body: If your review items addressed, please make comment "resolved"
created_at: 2025-03-13T04:01:36Z
author_association: MEMBER
diff_hunk: @@ -13,11 +13,11 @@
 
 // xdoc section -- start
 class Example2 {
-  public int num1; // violation
+  public int num1; // violation 'Name 'num1' must match pattern'
 
   protected int num2;
   int num3;
-  private int num4; // violation
+  private int num4; // violation 'Name 'num2' must match pattern'
path: src/xdocs-examples/resources/com/puppycrawl/tools/checkstyle/checks/naming/membername/Example2.java
user: login: Mahmoud-Ayman-Saleh
body: resolved
created_at: 2025-03-13T13:14:36Z
author_association: CONTRIBUTOR

PR comments:
user: login: L-Lawliet-dn
created_at: 2025-03-12T01:31:01Z
body: You did not put a colon ':' in the commit message. It should be 
Issue #15456: Defined violation message for MemberNameCheck 


author_association: CONTRIBUTOR
user: login: Mahmoud-Ayman-Saleh
created_at: 2025-03-12T03:43:16Z
body: @romani 
Your review is very important. If there's anything critical that I need to fix to pass the remaining tests, please let me know


author_association: CONTRIBUTOR
user: login: Mahmoud-Ayman-Saleh
created_at: 2025-03-12T21:24:54Z
body: @romani 
ci has passed. please merge it.
author_association: CONTRIBUTOR