Repository: sunpy/mpl-animators
Pull request #91: reduce astropy version pin to real one
Author: login: nabobalis
Labels: name: No Changelog Entry Needed
description: Skip all changelog checks.
Created: 2025-05-28T18:46:17Z | Merged: 2025-05-28T21:30:25Z

Fixes https://github.com/sunpy/mpl-animators/issues/90 

Also updated changelog.


Diff:
diff --git a/.circleci/config.yml b/.circleci/config.yml
index ddb78c8..9a377ba 100644
--- a/.circleci/config.yml
+++ b/.circleci/config.yml
@@ -87,7 +87,7 @@ jobs:
 
 all-jobs: &all-jobs
   - "py311-figure"
-  - "py312-figure-devdeps"
+  - "py313-figure-devdeps"
   - "py310-figure-oldestdeps"
 
 main-branch: &main-branch
@@ -109,9 +109,9 @@ workflows:
           image: "cimg/python:3.11"
 
       - figure:
-          name: "py312-figure-devdeps"
-          jobname: "py312-figure-devdeps"
-          image: "cimg/python:3.12"
+          name: "py313-figure-devdeps"
+          jobname: "py313-figure-devdeps"
+          image: "cimg/python:3.13"
 
       - figure:
           name: "py310-figure-oldestdeps"
@@ -126,9 +126,9 @@ workflows:
           filters: *main-branch
 
       - deploy-reference-images:
-          name: "baseline-py312-figure-devdeps"
-          jobname: "py312-figure-devdeps"
-          image: "cimg/python:3.12"
+          name: "baseline-py313-figure-devdeps"
+          jobname: "py313-figure-devdeps"
+          image: "cimg/python:3.13"
           requires: *all-jobs
           filters: *main-branch
 
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 4348c7e..cc42f16 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -35,8 +35,8 @@ jobs:
       coverage: codecov
       toxdeps: tox-pypi-filter
       envs: |
-        - windows: py311
-        - macos: py310
+        - windows: py313
+        - macos: py312
     secrets:
       CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
 
@@ -46,7 +46,7 @@ jobs:
       - uses: actions/checkout@v4
       - uses: actions/setup-python@v5
         with:
-          python-version: '3.12'
+          python-version: '3.13'
       - run: python -m pip install -U --user build
       - run: python -m build . --sdist
       - run: python -m pip install -U --user twine
@@ -56,7 +56,7 @@ jobs:
     needs: [core, sdist_verify]
     uses: OpenAstronomy/github-actions-workflows/.github/workflows/tox.yml@v1
     with:
-      default_python: '3.12'
+      default_python: '3.13'
       submodules: false
       pytest: false
       toxdeps: tox-pypi-filter
@@ -78,7 +78,7 @@ jobs:
     needs: [sdist_verify, docs]
     uses: OpenAstronomy/github-actions-workflows/.github/workflows/publish_pure_python.yml@v1
     with:
-      python-version: '3.12'
+      python-version: '3.13'
       test_extras: 'tests'
       test_command: 'pytest -p no:warnings --doctest-rst --pyargs mpl_animators'
       submodules: false
diff --git a/.gitignore b/.gitignore
index 72e1651..e2b2aa2 100644
--- a/.gitignore
+++ b/.gitignore
@@ -260,6 +260,7 @@ node_modules/
 package-lock.json
 package.json
 .prettierrc
+requirements-min.txt
 
 # Log files generated by 'vagrant up'
 *.log
diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index 5ee0438..25d390a 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -1,8 +1,56 @@
-v1.1.2 - 2024-02-07
+v1.2.2 - 2025-05-28
 ===================
 
-What’s Changed
---------------
+Reverted astropy back to optional "wcs" group and changed the version from from 5.6.0 to 5.3.0 as 5.6 is not a real release of astropy
+
+v1.2.1 - 2025-03-12
+===================
+
+Maintenance release, no changes otherwise
+
+v1.2.0 - 2024-07-23
+===================
+
+Other Changes
+~~~~~~~~~~~~~
+
+- remove old circleci webhook config by @Cadair in
+  https://github.com/sunpy/mpl-animators/pull/36
+- Added Gallery + Update Package template by @nabobalis in
+  https://github.com/sunpy/mpl-animators/pull/37
+- Speed up CI by using different images per build by @Cadair in
+  https://github.com/sunpy/mpl-animators/pull/39
+- More circle jobs and trying to fix py39 upload by @Cadair in
+  https://github.com/sunpy/mpl-animators/pull/40
+- use sh not bash because nixos lol by @Cadair in
+  https://github.com/sunpy/mpl-animators/pull/41
+- Update website by @dstansby in
+  https://github.com/sunpy/mpl-animators/pull/45
+- gallery plus api docs by @nabobalis in
+  https://github.com/sunpy/mpl-animators/pull/47
+- Registers package to sunpy template by @CyclingNinja in
+  https://github.com/sunpy/mpl-animators/pull/48
+- Updates from the package template by @github-actions in
+  https://github.com/sunpy/mpl-animators/pull/51
+- Wrong base python for image upload by @nabobalis in
+  https://github.com/sunpy/mpl-animators/pull/50
+- Updates from the package template by @github-actions in
+  https://github.com/sunpy/mpl-animators/pull/52
+- Updates from the package template by @github-actions in
+  https://github.com/sunpy/mpl-animators/pull/53
+
+New Contributors
+~~~~~~~~~~~~~~~~
+
+- @dstansby made their first contribution in
+  https://github.com/sunpy/mpl-animators/pull/45
+- @CyclingNinja made their first contribution in
+  https://github.com/sunpy/mpl-animators/pull/48
+- @github-actions made their first contribution in
+  https://github.com/sunpy/mpl-animators/pull/51
+
+v1.1.2 - 2024-02-07
+===================
 
 Other Changes
 ~~~~~~~~~~~~~
@@ -13,9 +61,6 @@ Other Changes
 v1.1.1 - 2023-11-17
 ===================
 
-What’s Changed
---------------
-
 Other Changes
 ~~~~~~~~~~~~~
 
@@ -35,9 +80,6 @@ New Contributors
 v1.1.0 - 2022-08-10
 ===================
 
-What’s Changed
---------------
-
 Bug Fixes
 ~~~~~~~~~
 
diff --git a/mpl_animators/tests/figure_hashes_mpl_350_ft_261_astropy_600.json b/mpl_animators/tests/figure_hashes_mpl_350_ft_261_astropy_53.json
similarity index 100%
rename from mpl_animators/tests/figure_hashes_mpl_350_ft_261_astropy_600.json
rename to mpl_animators/tests/figure_hashes_mpl_350_ft_261_astropy_53.json
diff --git a/pyproject.toml b/pyproject.toml
index fea0772..596d985 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -18,11 +18,13 @@ authors = [
 dependencies = [
   "matplotlib>=3.5.0",
   "numpy>=1.23.0",
-  "astropy>=5.6.0",
 ]
 dynamic = ["version"]
 
 [project.optional-dependencies]
+wcs = [
+    "astropy>=5.3.0",
+]
 tests = [
   "pytest",
   "pytest-doctestplus",
@@ -40,6 +42,12 @@ docs = [
   "sunpy",
   "scipy",
 ]
+all = [
+  "mpl_animators[wcs]",
+]
+dev = [
+  "mpl_animators[all,docs,tests]",
+]
 
 [project.urls]
 Homepage = "https://sunpy.org"
@@ -77,9 +85,9 @@ version_file = "mpl_animators/_version.py"
     message = "Click details to see the figure test comparisons for py310-figure-oldestdeps."
     report_on_fail = true
 
-  [ tool.gilesbot.circleci_artifacts.py312-figure-devdeps_report ]
-    url = ".tmp/py311-figure-devdeps/figure_test_images/fig_comparison.html"
-    message = "Click details to see the figure test comparisons for py312-figure-devdeps."
+  [ tool.gilesbot.circleci_artifacts.py313-figure-devdeps_report ]
+    url = ".tmp/py313-figure-devdeps/figure_test_images/fig_comparison.html"
+    message = "Click details to see the figure test comparisons for py313-figure-devdeps."
     report_on_fail = true
 
   [tool.gilesbot.towncrier_changelog]
diff --git a/pytest.ini b/pytest.ini
index df0d11a..8f24823 100644
--- a/pytest.ini
+++ b/pytest.ini
@@ -36,3 +36,5 @@ filterwarnings =
     # A list of warnings to ignore follows. If you add to this list, you MUST
     # add a comment or ideally a link to an issue that explains why the warning
     # is being ignored
+    # Oldestdeps
+    ignore:.*may indicate binary incompatibility:RuntimeWarning
diff --git a/tox.ini b/tox.ini
index cafe0ce..44e43e9 100644
--- a/tox.ini
+++ b/tox.ini
@@ -3,8 +3,8 @@ min_version = 4.0
 requires =
     tox-pypi-filter>=0.14
 envlist =
-    py{310,311,312}-{figure}
-    py312-devdeps
+    py{310,311,312,313}-{figure}
+    py313-devdeps
     py310-oldestdeps
     codestyle
     build_docs
@@ -48,7 +48,7 @@ extras =
     all
     tests
 commands_pre =
-    oldestdeps: minimum_dependencies mpl_animators --filename requirements-min.txt
+    oldestdeps: minimum_dependencies mpl_animators --extras wcs --filename requirements-min.txt
     oldestdeps: pip install -r requirements-min.txt
     pip freeze --all --no-input
 commands =


Reviews:
user: login: nabobalis
state: COMMENTED
author_association: MEMBER
submitted_at: 2025-05-28T20:28:51Z
user: login: Cadair
state: COMMENTED
author_association: MEMBER
submitted_at: 2025-05-28T20:33:29Z
user: login: nabobalis
state: COMMENTED
author_association: MEMBER
submitted_at: 2025-05-28T20:34:22Z
user: login: Cadair
state: APPROVED
author_association: MEMBER
submitted_at: 2025-05-28T21:30:24Z

Review comments:
diff_hunk: @@ -50,6 +50,7 @@ extras =
 commands_pre =
     oldestdeps: minimum_dependencies mpl_animators --filename requirements-min.txt
     oldestdeps: pip install -r requirements-min.txt
+    oldestdeps: pip install "astropy<6.0.0"
path: tox.ini
user: login: nabobalis
body: minimum_dependencies only seems to care about core packages, not optional ones. 
created_at: 2025-05-28T20:28:50Z
author_association: MEMBER
diff_hunk: @@ -50,6 +50,7 @@ extras =
 commands_pre =
     oldestdeps: minimum_dependencies mpl_animators --filename requirements-min.txt
     oldestdeps: pip install -r requirements-min.txt
+    oldestdeps: pip install "astropy<6.0.0"
path: tox.ini
user: login: Cadair
body: You can give it --extras
created_at: 2025-05-28T20:33:29Z
author_association: MEMBER
diff_hunk: @@ -50,6 +50,7 @@ extras =
 commands_pre =
     oldestdeps: minimum_dependencies mpl_animators --filename requirements-min.txt
     oldestdeps: pip install -r requirements-min.txt
+    oldestdeps: pip install "astropy<6.0.0"
path: tox.ini
user: login: nabobalis
body: Thanks, I didn't know
created_at: 2025-05-28T20:34:22Z
author_association: MEMBER

PR comments:
user: login: nabobalis
created_at: 2025-05-28T18:56:12Z
body: pre-commit.ci autofix
author_association: MEMBER
user: login: Cadair
created_at: 2025-05-28T18:56:24Z
body: Actually looks like this got messed up in the package template migration. Astropy should be in an optional extra.

https://github.com/sunpy/mpl-animators/blob/1601e8fb7bc2441c38686efc4905a91135be1bb2/setup.cfg#L25
author_association: MEMBER
user: login: nabobalis
created_at: 2025-05-28T19:02:54Z
body: Fixed
author_association: MEMBER
user: login: nabobalis
created_at: 2025-05-28T19:21:35Z
body: And I broke everything

author_association: MEMBER