av9ash/GitBugs huggingface dataset:
Bug: Account setup wizard fails in 78.1.1 but works in 68.11.0
Status: RESOLVED
Priority: --
Resolution: INVALID
Created: 2020-08-20 00:40:25+00:00
Resolved: 2020-08-21 09:16:39+00:00

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:79.0) Gecko/20100101 Firefox/79.0

Steps to reproduce:

Did new install of Thunderbird 78.1.1 (32 bit) on Windows 10 (64-bit). Had used Thunderbird on 2 Win 7 computers and used same email account for years.


Actual results:

Doing a first install of POP account on the freshly installed version 78.1.1 I could not get past the setup screen whether using automatic setup or manual setup to match a working system. I found that the working system had v 68.11.0 (32 bit). 

The "probing servers" step seemed to go OK. Then when I chose POP and clicked the next button it gave a message that setup or password must be wrong. 

On the new Windows 10 system, I uninstalled v 78.1.1 and installed v 68.11.0 . Then the setup was routine and Thunderbird worked as normal


Expected results:

Should have installed almost automatically, using automatic probing of server. Alternatively it should have worked when I set up the server parameters manually to match a working instance of Thunderbird.
Bug: Components can run in the devtools process when they shouldn't
Status: RESOLVED
Priority: --
Resolution: FIXED
Created: 2020-08-20 08:33:17+00:00
Resolved: 2021-11-02 21:14:50+00:00

I've just discovered that by opening the developer toolbox and doing certain things, I can cause the devtools process to do things it shouldn't be able to do. In my case it was starting up the address book manager, loading all of the address books and attempting to contact the servers of my CardDAV directories. (Four username/password dialogs appeared, when I currently have three such directories set up. This is how I established what was happening, there were four set up when my devtools profile was created, and it still has the prefs from then.) It may also explain why I've been seeing GMail authorisation dialogs.

I *think* I can solve this by setting `ProcessSelector.MAIN_PROCESS_ONLY` in the components.conf file of each component – a step I was planning anyway on the route to e10s.
Bug: TB 78.x: Gap between main input and dropdown list of Outgoing Servers (SMTP) in Account Settings, if list is longer than available vertical window space and pops up on top with scrollbar
Status: RESOLVED
Priority: --
Resolution: WORKSFORME
Created: 2020-08-20 11:24:31+00:00
Resolved: 2022-12-09 19:08:43+00:00

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/84.0.4147.125 Safari/537.36 Edg/84.0.522.61

Steps to reproduce:

Thunderbird 78.1.1
The Send Server field of the account settings


Actual results:

In the Account Settings screen
As the number of fields on the sending server increases, the
There will be a blank space as shown in the image.


Expected results:

Please correct it.
Bug: Default Theme not recognizing App-Theme Setting on Windows
Status: RESOLVED
Priority: --
Resolution: DUPLICATE
Created: 2020-08-20 15:04:22+00:00
Resolved: 2020-09-09 14:16:06+00:00

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/84.0.4147.135 Safari/537.36

Steps to reproduce:

Windows 10 2004 -- Reproduced in Windows Sandbox (VM with default windows profile)

1. Install TB 80.0 beta 4 (fresh profile, fresh everything)
2. Launch TB
3. Observe default theme being light
4. Close TB
5. Change Windows Theme settings to "Dark"
6. Launch TB
7. Observe default theme *still* being light.


Actual results:

The default theme ignored system theme settings and stayed light throughout.


Expected results:

The default theme "follows" the OS theme in regards to light/dark modes.

Confirmed working as expected with 80.0b3; broken with 80.0b4.

I specifically closed TB before changing the OS theme, to ensure I'm not just hitting expected behavior of the changes in bug 1638233, comment 17
Bug: The created mailbox disappears after starting the program
Status: RESOLVED
Priority: --
Resolution: WORKSFORME
Created: 2020-08-20 17:54:19+00:00
Resolved: 2020-12-20 20:03:00+00:00

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Firefox/68.0

Steps to reproduce:

Debian 10:
1. Add new mail account in Thunderbird. All works: it is in the  mailbox tree, mail receiving works etc.
2. Restart Thunderbird.

This is similar to a mail storage processing problem.
I suppose https://bugzilla.mozilla.org/show_bug.cgi?id=1658345 related to the same thing.
This started happening after the latest updates.


Actual results:

The created mailbox disappeared from the mailbox tree. (Account directory presents in the {profile folder}/mail.)


Expected results:

The created mailbox must not disappear from the mailbox tree.
Bug: missing email from inbox while mail is on the server
Status: RESOLVED
Priority: --
Resolution: INCOMPLETE
Created: 2020-08-20 18:36:59+00:00
Resolved: 2021-01-10 18:04:22+00:00

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/84.0.4147.125 Safari/537.36

Steps to reproduce:

Opened email after installing beta version of T'bird (80.0b5) which messed up my profile so I cannot go back to the release version!! When I open the inbox of one of my accounts, it only shows 162 emails. When I use webmail, there are 2186 email in the inbox.


Actual results:

No email is shown prior to 8/5/2020 except for one from 2005.


Expected results:

All of my email should be displayed, all 2186 of them.
Bug: thread summary unreadable in dark Theme with Mac
Status: VERIFIED
Priority: --
Resolution: FIXED
Created: 2020-08-21 04:25:26+00:00
Resolved: 2021-03-08 17:50:34+00:00

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:79.0) Gecko/20100101 Firefox/79.0

Steps to reproduce:

MacOS Catalina 10.15.6, system set to dark theme. TBird set to follow system preference. 


Actual results:

Thread summaries are unreadable - very light grey text on white background. Individual messages are fine, showing black text on white background.

If I set TBird theme to light, then it works fine. Both thread summary and individual messages show with black text on white background.


Expected results:

thread summary should be same as individual messages - dark text on light background (when dark theme is being used).
Bug: v 78.1.1  TBird freezes when composing email
Status: RESOLVED
Priority: --
Resolution: WORKSFORME
Created: 2020-08-21 14:06:22+00:00
Resolved: 2020-10-23 01:26:13+00:00

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:79.0) Gecko/20100101 Firefox/79.0

Steps to reproduce:

tried to compose an email to multiple people.  


Actual results:

TBird freezes after the first 2 or 3 entries.  Program not responding, had to close it.  Repeated 3 or 4 times.

just upgraded to 78.1.1 from 68.  Win10-64, fully updated


Expected results:

continue adding recipients.
Bug: Message filters open with "invisible" and not actionable form
Status: RESOLVED
Priority: --
Resolution: DUPLICATE
Created: 2020-08-22 08:43:04+00:00
Resolved: 2020-09-13 15:56:38+00:00

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/84.0.4147.135 Safari/537.36

Steps to reproduce:

Non riesco a modificare i filtri messaggi


Actual results:

Dopo aver selezionato il filtro da modificare si apre una "maschera" invisibile e non gestibile che per chiuderla devo utilizzare la gestione risorse, con la versione 68 non avevo lo stesso problema.
Il problema lo verifico anche su portatile anche questo con la versione 78.1.1.


Expected results:

Si dovrebbe aprire la maschera dove poter inserire o togliere le varie opzioni
Bug: [PDF integration] Some PDF files are displayed incomplete
Status: RESOLVED
Priority: --
Resolution: INVALID
Created: 2020-08-22 11:21:31+00:00
Resolved: 2023-01-07 20:00:34+00:00

I've tested the new PDF integration in Thunderbird 81. Most PDF files are displayed correctly. There is one, which shows incomplete (compare screenshot). I can't attach the email or the file, because it contains sensitive private data. 
I have tested with Firefox 81 and it looks correct there, so seems to be a Thunderbird issue.

In the source code of this email it says:

--=__Part7A460483.1__=--

--=__Part7A460483.0__=
Content-Type: application/pdf; name="=?UTF-8?Q?L=C3=A4mmle.pdf?="
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="=?UTF-8?Q?L=C3=A4mmle.pdf?="

JVBERi0xLjUNCiW1tbW1DQoxIDAgb2JqDQo8PC9UeX
....
dGFydHhyZWYNCjE0Njc4NQ0KJSVFT0Y=

--=__Part7A460483.0__=--

exiftool tells me about the affected PDF:

ExifTool Version Number         : 11.39
File Name                       : Lämmle.pdf
Directory                       : /Users/polysom/Downloads
File Size                       : 144 kB
File Modification Date/Time     : 2020:08:21 19:52:52+02:00
File Access Date/Time           : 2020:08:22 12:23:21+02:00
File Inode Change Date/Time     : 2020:08:22 12:23:21+02:00
File Permissions                : rw-rw-rw-
File Type                       : PDF
File Type Extension             : pdf
MIME Type                       : application/pdf
PDF Version                     : 1.5
Linearized                      : No
Page Count                      : 2
Language                        : de-DE
Tagged PDF                      : Yes
Producer                        : Microsoft® Word 2010
Creator                         : Microsoft® Word 2010
Create Date                     : 2019:07:17 10:54:58+02:00
Modify Date                     : 2019:07:17 10:54:58+02:00

I cant't generate a similar PDF by my own, because I do not have Microsoft® Word 2010.
Bug: Platform information for Thunderbird 78.1.1 shows 78.1.0
Status: RESOLVED
Priority: --
Resolution: INVALID
Created: 2020-08-22 12:27:52+00:00
Resolved: 2020-08-24 21:29:08+00:00

Looking at platform.ini from Thunderbird 78.1.1, it shows `Milestone=78.1.0`. As a result, `Services.appinfo.platformVersion` returns 78.1.0, which means among other things that add-ons with `strict_min_version` set won't work correctly.

Too late for that release, but if there is some sort of build config thing we need to fix going forward we probably should.
Bug: Thunderbird doesn't remember last folder upon start
Status: RESOLVED
Priority: --
Resolution: DUPLICATE
Created: 2020-08-22 13:46:12+00:00
Resolved: 2020-08-22 19:28:29+00:00

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/84.0.4147.135 Safari/537.36

Steps to reproduce:

- Start Thunderbird
- Select Inbox
- Quit Thunderbird
- Start Thunderbird again


Actual results:

- Inbox is not selected, means Thunderbird doesn't remember which folder was selected in the tree when it was quit before


Expected results:

- In previous versions of Thunderbird, always Inbox was selected upon start of Thunderbird. I'm not sure whether Thunderbird remembered the last selected folder before quit, or if Inbox was the default.
However, now when I start Thunderbird and want to view my Inbox, I have to click "Inbox" first.
Suggestions:
- Thunderbird should remember which folder was selected before it was quit and select this folder when it is started again
or
- Inbox should be selected by default upon startup
or
- An option should be available which allows the user to decide which folder should be selected by default upon startup.
Bug: TB78 first setup shows menu bar (and shouldn't), and not in sync with context menu
Status: RESOLVED
Priority: --
Resolution: WORKSFORME
Created: 2020-08-22 17:54:24+00:00
Resolved: 2022-11-10 20:33:51+00:00

TB78 first setup shows menu bar (and probably shouldn't?), but the `Menu Bar` entry in context menu isn't checked, so out of sync. See screenshot.

New profile. 78.1.1 (64-bit) Win10, downloaded today from tb.net.
Bug: dropdown for main write message button gone (new event/new task/new msg)
Status: RESOLVED
Priority: --
Resolution: INVALID
Created: 2020-08-22 22:26:43+00:00
Resolved: 2020-08-23 18:26:14+00:00

User Agent: Mozilla/5.0 (Windows NT 10.0; rv:77.0) Gecko/20100101 Firefox/77.0

Steps to reproduce:

the dropdown for button-newmsg is gone in 78. It allowed to create events/tasks from the mailview.

That is very handy, because it allows to do new entries without changing tabs.
It also makes sense, because I might want to create an event after reading an email
Bug: I can't get emails from 1 certain sender, Target.com
Status: RESOLVED
Priority: --
Resolution: INCOMPLETE
Created: 2020-08-23 19:49:00+00:00
Resolved: 2020-09-15 13:52:45+00:00

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/84.0.4147.135 Safari/537.36

Steps to reproduce:

Called target. 
Had them send email while I was on phone multiple times.


Actual results:

No emails ever came through in any folders.


Expected results:

I should have gotten emails from Target.
Bug: Thunderbird startup Crash in [@ OOM | small] via mozilla::dom::Document::AddToIdTable
Status: NEW
Priority: --
Created: 2020-08-23 20:03:53+00:00
Resolved: 2024-01-16 04:06:03+00:00

Startup. Not my crash. Don't know whether this is common.

Crash report: https://crash-stats.mozilla.org/report/index/63659a0d-795a-47d7-ad32-2062b0200822

Top 10 frames of crashing thread:
```
0 xul.dll NS_ABORT_OOM xpcom/base/nsDebugImpl.cpp:611
1 xul.dll PLDHashTable::Add xpcom/ds/PLDHashTable.cpp
2 xul.dll mozilla::dom::Document::AddToIdTable dom/base/Document.cpp:3699
3 xul.dll mozilla::dom::Element::BindToTree dom/base/Element.cpp:1620
4 xul.dll nsXULElement::BindToTree dom/xul/nsXULElement.cpp:588
5 xul.dll nsINode::InsertChildBefore dom/base/nsINode.cpp:1520
6 xul.dll mozilla::dom::PrototypeDocumentContentSink::ResumeWalkInternal dom/prototype/PrototypeDocumentContentSink.cpp:492
7 xul.dll mozilla::dom::PrototypeDocumentContentSink::OnScriptCompileComplete dom/prototype/PrototypeDocumentContentSink.cpp:903
8 xul.dll mozilla::dom::PrototypeDocumentContentSink::OnStreamComplete dom/prototype/PrototypeDocumentContentSink.cpp:832
9 xul.dll mozilla::net::nsStreamLoader::OnStopRequest netwerk/base/nsStreamLoader.cpp:88
```
Bug: Thunderbird Crash in [@ OOM | small] via nss3
Status: NEW
Priority: --
Created: 2020-08-23 22:48:18+00:00
Resolved: 2023-03-28 01:38:32+00:00

Approximately half of OOM small crashes I looked at have stack frame with symbols as
nss3.dll 	_PR_NativeRunThread(void*) 	nsprpub/pr/src/threads/combined/pruthr.c:399

Crash report: https://crash-stats.mozilla.org/report/index/c9165ede-471d-4969-bf0b-f869b0200822

Top 10 frames of crashing thread:
```
0 xul.dll xul.dll@0x2ad91e 
1 xul.dll xul.dll@0x2a2c7e 
2 xul.dll xul.dll@0xa70cb9 
3 xul.dll xul.dll@0xa70786 
4 xul.dll xul.dll@0xa70387 
5 xul.dll xul.dll@0xa712d1 
6 xul.dll xul.dll@0x3369f9 
7 xul.dll xul.dll@0x339545 
8 xul.dll xul.dll@0x7bf3f6 
9 xul.dll xul.dll@0x795c0c 
```
Half of them have uptime of 8-10 minutes. Other examples bp-d83bf6a9-bfb0-4769-bbbb-1aac20200822 and bp-63f6954f-4d84-46e1-9163-314720200823

bp-a98ecc51-0025-4c57-b304-1ae440200823 is 5 hours.
Bug: Filtering by |Status is New| fails
Status: VERIFIED
Priority: --
Resolution: DUPLICATE
Created: 2020-08-24 09:24:25+00:00
Resolved: 2020-09-11 11:31:45+00:00

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:79.0) Gecko/20100101 Firefox/79.0

Steps to reproduce:

Tools / Filter : Create filter by "Subject" 
Add condition "Status" is New
Action : Move mail in subfolder if have Subject i set + Status New
Xubuntu 20.04.1 64 bits
Thunderbird 68.10.0


Actual results:

Filter not work, message not move on subfolder
Nothing on journal result


Expected results:

Message move automatically on subfolder when i receive new
Bug: Configuring the buttons is not possible anymore in the mail toolbar
Status: RESOLVED
Priority: --
Resolution: DUPLICATE
Created: 2020-08-24 15:31:16+00:00
Resolved: 2022-08-15 01:46:03+00:00

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/84.0.4147.135 Safari/537.36

Steps to reproduce:

- Start Thunderbird
- Select any mail



Actual results:

The mail content is displayed in the lower pane.
Above the lower pane, there is a mail toolbar, which contains some buttons (see attached screenshot).
In versions prior to version 78, it was possible to remove buttons which are not needed by an individual user. For example, I never use the button "Junk" or "Delete", so I was able to adjust the toolbar in a way that the button was removed. I did this by right-clicking the toolbar and clicking "adjust" in the appearing context menu.


Expected results:

With Thunderbird 78, it is not possible anymore to remove unwanted buttons. When I execute a right mouse click on the mail toolbar, nothing happens.  No context menu appears anymore.
Bug: import enigmail/pgp keys into 78.2.0
Status: RESOLVED
Priority: --
Resolution: INVALID
Created: 2020-08-24 16:26:32+00:00
Resolved: 2020-09-17 05:37:23+00:00

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:69.0) Gecko/20100101 Firefox/69.0

Steps to reproduce:

saved 68 profile. started 78.2.0 and enigmail keys appear to have imported after providing key phrases. Try to sign a new message to myself.

I will do the migration again and look for clues.


Actual results:

Get the attached message about not having confirmed my key. no way to confirm.


Expected results:

1) tell me there was a failure impiort keys from 68/enigmail -> 78
or
2) sign the message
or
3) provide key management to confirm my keys
Bug: Unknown field labels in Edit Contact dialog: __DAV4TBSYNCMSG_abCard.*__
Status: RESOLVED
Priority: --
Resolution: DUPLICATE
Created: 2020-08-24 19:39:24+00:00
Resolved: 2020-08-26 07:44:38+00:00

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/84.0.4147.135 Safari/537.36

Steps to reproduce:

Listed individual in contact list.


Actual results:

Strange fields that are unknown to me appear in the view.


Expected results:

Strange fields should not appear. Attaching screenshot to show results.
Bug: Investigate why various browser display color preferences are access 1000s of times on startup on Windows
Status: RESOLVED
Priority: P2
Resolution: WORKSFORME
Created: 2020-08-24 19:52:55+00:00
Resolved: 2021-11-12 02:39:53+00:00

In bug 1660706 I am adding a test for checking how many times preferences are accessed on startup.

At the moment, we are seeing some prefs accessed a lot on Windows only:

* `browser.display.focus_text_color`, `browser.visited_color`, `browser.active_color`, `browser.display.focus_background_color`
    * All accessed around 3000 times.
* `browser.anchor_color`, `browser.display.foreground_color`, `browser.display.background_color`
    * All accessed around 1000 times.

These appear to be coming from `PreferenceSheet::Prefs::Load`: https://searchfox.org/mozilla-central/rev/19c23d725f27d0989e4a60f36d64004cebb39736/layout/style/PreferenceSheet.cpp#101-103,123-124,127-128

I'm not sure why this would be Windows only, nor why only Thunderbird would see it.
Bug: ExtensionSupport initialisation can be delayed until a window is just about to open
Status: RESOLVED
Priority: --
Resolution: FIXED
Created: 2020-08-24 21:18:51+00:00
Resolved: 2020-10-29 23:59:29+00:00

ExtensionSupport.jsm is currently initialised before profile selection, however it is only really necessary when we're about to start opening windows.

Therefore we can move it to be triggered on `final-ui-startup`, delaying it until we really need it.
Bug: Investigate delaying initialisation of the search service until after the first window is created / during idle
Status: RESOLVED
Priority: --
Resolution: FIXED
Created: 2020-08-24 21:54:58+00:00
Resolved: 2020-11-14 19:47:22+00:00

Currently the search service initialisation is kicked off before first paint. As the search service is only used in preferences and the context menu, that doesn't really need to be started until after Thunderbird has finished starting up.

We can probably do this after the window is displayed, maybe even during idle. Worst case, the user might have to wait briefly to display the context menu.
Bug: Investigate why some core modules are loaded before first paint.
Status: NEW
Priority: --
Created: 2020-08-24 21:59:00+00:00
Resolved: 2020-10-29 23:57:16+00:00

In bug 1660706, I am adding a test to check when various modules are loaded - to ensure they are not loaded earlier than necessary.

At the moment, these core modules are being loaded before first paint:

```
resource://gre/modules/PlacesUtils.jsm
resource://gre/modules/Promise.jsm
resource://gre/modules/Preferences.jsm
resource://gre/modules/Sqlite.jsm
```

They are probably unnecessary, and we should investigate delaying them until necessary (this will likely need to be split up into multiple bugs once the initial investigation is done).
Bug: Disabled filters showing as enabled in the GUI
Status: RESOLVED
Priority: --
Resolution: FIXED
Created: 2020-08-24 23:30:29+00:00
Resolved: 2020-09-03 20:25:28+00:00

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:79.0) Gecko/20100101 Firefox/79.0

Steps to reproduce:

I created email filters, as detailed in my question at https://support.mozilla.org/en-US/questions/1299994

I'm on a Mac.


Actual results:

Some of my email filters did not run. Initially I thought they were running in the wrong order (incorrect). On opening the msgFilterRules.dat to investigate, I found that some had enabled="no" set. In the GUI, all the filters had their checkboxes checked.


Expected results:

In the Message Filters dialog, filters that have enabled="no" should not have their Enabled checkbox checked; all filters with enabled="yes" should have their Enabled checkbox checked.
Bug: due to recent bad update, when I click on write, my personal address book does not come up, which makes thunderbird more tedious; please correct this mistake!
Status: RESOLVED
Priority: --
Resolution: INCOMPLETE
Created: 2020-08-25 00:12:36+00:00
Resolved: 2021-01-04 02:00:21+00:00

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/84.0.4147.135 Safari/537.36

Steps to reproduce:

When I click write, the personal address book just stopped coming up.


Actual results:

When I click write, the personal address book just stopped coming up.


Expected results:

the personal address book should come up, like it did before!
Bug: Address book import no longer changes UI to the imported directory
Status: RESOLVED
Priority: --
Resolution: FIXED
Created: 2020-08-25 00:28:10+00:00
Resolved: 2021-02-02 08:13:14+00:00

Before bug 1650041, importing an address book made the UI change to the new directory (and fail to display the imported contacts, but that's another matter). This doesn't happen any more, but it should, *if* the import was started from the address book UI.
Bug: warning dialog at account setup too narrow
Status: RESOLVED
Priority: --
Resolution: WONTFIX
Created: 2020-08-25 07:46:31+00:00
Resolved: 2021-03-10 18:59:47+00:00

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:79.0) Gecko/20100101 Firefox/79.0

Steps to reproduce:

install new 78RC1, setup account by the dialog window that comes up.
choose manual, insert info for account without security, press fertig (continue?)

a warning panel comes up where I need to confirm that I know the risks without encryption.


Actual results:

OK button is outside the viewport on a 22 in screen with TB installing with its default screen size settings. I see about 2mm of the ok button.

There is a scrollbar, so bug repair  is not high priority, but for new users, it looks bad