av9ash/GitBugs huggingface dataset:
Bug: Critical Omission on Addon's "Permissions" tab when Experimental APIs in Use
Status: RESOLVED
Priority: --
Resolution: DUPLICATE
Created: 2021-01-02 01:26:07+00:00
Resolved: 2024-05-30 17:25:33+00:00

After clicking "Add to Thunderbird" on addons.thunderbird.net to install a new addon*, I received the warning  "It requires your permission to: Have full, unrestricted access to Thunderbird, and your computer".  I clicked "Add" to accept.

Then, wanting to investigate the addon further (the permissions seemed excessive) I opened up the addon in the "Add-ons Manager".  Clicking on the "permissions" tab, the only text shown is "This extension doesn't require any permissions."** Obviously this is completely contradictory.

Further, I confirmed that this isn't merely an incorrect warning message. I installed the Mailbox Alert*** extension (which advertises -- and has -- the ability to run arbitrary system commands) and found the same (lack of) information on the "Permissions" tab. 

I believe this to have a potentially huge impact on system security, especially in corporate settings where information security analysts may have occasion to check such permission listings to identify possible exploit vectors. Normal users too, however, would be lulled into a false sense of security due to the illusion that no special permissions have been given to a given addon. This is while, in reality, every permission imaginable has been granted.

System Information:
I am running Ubuntu 20.04.1 LTS (Focal) on kernel 5.4.0-58-generic.
My thunderbird package is from the official "stable" Mozilla Ubuntu PPA**** and is up to date (version 78.6.0+build1-0ubuntu0.20.04.1~mt1).
I am also attaching the "Troubleshooting Information" output to this ticket.

Cause:
I need to investigate more fully but wanted to provide this information as soon as possible. My best guess at the moment is that this "full, unrestricted access" designation is caused by experimental APIs that are recognized in the alert box but not by the code that generates the permissions list.

* Addon was https://addons.thunderbird.net/en-US/thunderbird/addon/removedupes/, but this is not specific to an individual addon.
** Reproduction video: https://s3.amazonaws.com/media.vasto.la/8c1e0b80-2ec6-0139-53ef-342e9930aa57.mp4?AWSAccessKeyId=AKIAJBORZGBQU6RHVWIQ&Signature=%2FwDHCp3M3n75b367T7tuwMfpI%2B4%3D&Expires=1610155308
  (Note: Link signed for security. Valid until Sat, 09 Jan 2021 01:21:48 UTC) Happy to provide new links as needed (unsure if I will be able to upload).
*** From https://addons.thunderbird.net/en-US/thunderbird/addon/mailbox-alert/
**** https://launchpad.net/~mozillateam/+archive/ubuntu/ppa?field.series_filter=focal
Bug: Open message from command-line using -mail <URL> parameter throws TypeError (getter-only)
Status: RESOLVED
Priority: --
Resolution: FIXED
Created: 2021-01-03 12:41:15+00:00
Resolved: 2021-05-06 11:42:53+00:00

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:84.0) Gecko/20100101 Firefox/84.0

Steps to reproduce:

User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0

Steps to reproduce:

1. Open TB and select a message
2. Open TB error console to get the message URL by entering var hdr = gFolderDisplay.selectedMessage; alert(hdr.folder.getUriForMsg(hdr));
3. Open cmd.exe and run "thunderbird.exe -mail "<URL>"


Actual results:

Thunderbird doesn't open the message specified by the command-line parameter. Instead, the following error message in shown in the error console:

TypeError: setting getter-only property "_messenger": MailNewsCommandLineHandler.jsm:19:62 (get _messenger resource:///modules/MailNewsCommandLineHandler.jsm:19, handle resource:///modules/MailNewsCommandLineHandler.jsm:69)


Expected results:

TB should open the message specified by the comman-line parameter. 

As a workaround, one can adjust the MailNewsCommandLineHandler.jsm by inserting the follwing code after line 22: 

set _messenger(value) {
    return value;
},
Bug: Filelink does not remove accounts on uninstallation of Provider
Status: RESOLVED
Priority: --
Resolution: WORKSFORME
Created: 2021-01-03 20:21:23+00:00
Resolved: 2021-08-13 06:06:17+00:00

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0

Steps to reproduce:

1) Install a Filelink provider
2) Configure an account
3) Remove FileLink Provider -> Account is gone from the acconts list
4) Restart Thunderbird
5) Install the Filelink Provider again


Actual results:

The account re-appears in the accounts list. Obviously it's not removed in step 3.


Expected results:

The account should not re-appear, it should be removed in step 3.
Bug: Use subaddress From when replying to a message that was sent to a subaddress. "+subaddress" is improperly being stripped from the From address.
Status: RESOLVED
Priority: --
Resolution: DUPLICATE
Created: 2021-01-03 20:30:09+00:00
Resolved: 2021-01-06 03:14:51+00:00

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0

Steps to reproduce:

1.  Receive a message with a To subaddress like user+subaddress@domain.tld.
2.  Click reply.


Actual results:

The From address in the Message Compose Window is missing the subaddress.

This behavior breaks most webmail and ticket systems.


Expected results:

The reply From address should be the same as the message To address.

RFC 5233 states "Implementations MUST make sure that the encoding method used for detailed addresses matches that which is used and/or allowed by the encompassing mail system"
Bug: Unable to connect after self-signed certificate change.
Status: RESOLVED
Priority: --
Resolution: INCOMPLETE
Created: 2021-01-03 20:50:58+00:00
Resolved: 2022-08-12 09:20:54+00:00

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0

Steps to reproduce:

1. Add a mail account that uses a self-signed certificate.
2. Click "Get Messages" until certificate prompt appears.
3. Click "Add permanent exception"
4. Click "Get Messages" again and messages arrive.
5. Change the self-signed certificate on the server.


Actual results:

A connection failure occurs and no exception prompt appears so the self-signed exception for the previous certificate must be manually removed in the Certificates preferences.


Expected results:

It should prompt to add an exception again.
Bug: Compose ignores "Do not require encryption by default" account setting and demands PGP key.
Status: RESOLVED
Priority: --
Resolution: DUPLICATE
Created: 2021-01-03 21:00:42+00:00
Resolved: 2021-01-07 21:57:54+00:00

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0

Steps to reproduce:

1. Recieve a PGP encrypted message.
2. Click Reply.
3. Click Send.


Actual results:

The Message Compose Window defaults to "Require Encryption" on PGP encrypted messages when there is no public key for the To address and displays the an error of "Unable to send this message with end-to-end encryption, because there are problems with the keys of the following recipients: bugzilla-daemon@mozilla.org"


Expected results:

"Do Not Encrypt" should be default if there is no public key for the To address.
Bug: Changing an account username freezes the application with "not responding"
Status: RESOLVED
Priority: --
Resolution: DUPLICATE
Created: 2021-01-03 21:09:05+00:00
Resolved: 2021-01-05 17:51:41+00:00

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0

Steps to reproduce:

1. Create a mail account.
2. Receive messages.
3. Change the account username.


Actual results:

If any action is taken other than clicking the X of the Account Settings after changing the username then the window freezes and must be forced closed.


Expected results:

Nothing should happen, the user should be free to change other preferences.
Bug: Message PGP decryption should not flash encrypted contents.
Status: RESOLVED
Priority: --
Resolution: INVALID
Created: 2021-01-04 03:09:31+00:00
Resolved: 2021-01-04 03:12:13+00:00

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0

Steps to reproduce:

View a PGP encrypted message.


Actual results:

The message flashes the encrypted contents before displaying the decrypted contents.


Expected results:

The message contents should be decrypted before being visible.
Bug: Text colors do not show in messages
Status: RESOLVED
Priority: --
Resolution: INCOMPLETE
Created: 2021-01-04 11:18:27+00:00
Resolved: 2021-09-06 00:40:42+00:00

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:84.0) Gecko/20100101 Firefox/84.0

Steps to reproduce:

I didn't do anything special at all. 
I just wrote and read messages with some colored text. 
But the colored text just appears in black, no color!
The only colored items in the messages are the HTML links
This is systematic (not sometimes: absolutely all the time). 
This didn't use to happen; I can't exactly remember how long it has been like that (a few weeks..., probably since an update of Thunderbird)
I have consistently (in fact systematically) reproduced that problem, even with all modules deactivated.


Actual results:

The message renderer seems to ignore colors. 
No colored text appears in color any more.


Expected results:

The text labelled "Blue text" should appear in blue
The text labelled "Red text" should appear in red

I have joined: 
- a screen grab of the compose window
- the HTML of the message (taken via HTMLedit add-on)
- the message, once received, as seen on a WEBmail (round-cube hosted by OVH.com)
- the message, once received, in Thunderbird
Since the interface only allows to upload a single file, I combined the 4 of them into a PDF.
Bug: Clicked links are intermitently opened as feeds instead of launching browser.
Status: RESOLVED
Priority: --
Resolution: DUPLICATE
Created: 2021-01-04 11:46:54+00:00
Resolved: 2021-06-17 20:20:55+00:00

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0

Steps to reproduce:

Receive a message and click any link in the message.


Actual results:

The status bar displays "You already have a subscription for this feed" and no browser is launched.


Expected results:

A browser should be launched and navigated to the link location.
Bug: Thunderbird freeze periodically after Dezember Update 85.0b2
Status: RESOLVED
Priority: --
Resolution: INCOMPLETE
Created: 2021-01-04 17:38:29+00:00
Resolved: 2021-03-11 02:21:26+00:00

User Agent: null

Steps to reproduce:

After i updated my stable thunderbird release in mid Dezember, it now freeze periodacally. 
No respond in main window, calender, mail composer etc.




Actual results:

The window does not turn white and windows os does not say it would not respond, but inside of thunderbird nothing happens. If i wait an undefinied time of minutes it works again until its not work and so on.

If i restart Thunderbird it works right away but freezes after time x.

Upgrade to 85b2 did not resolved the problem.
Hardware acceleration deactivation did not resolved the problem
remove addons did not resolve the problem

CPU is running vom 0.9% to 5% but no high load.
HDD usage on startup goes up to 40mb/s but after that it declines.

Windows 10
no changes in antivirus software.


Expected results:

Thunderbird responds every time.
Bug: Dark mode: black font color on black background in Folder Properties
Status: VERIFIED
Priority: --
Resolution: FIXED
Created: 2021-01-04 20:28:00+00:00
Resolved: 2021-01-25 21:08:45+00:00

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:84.0) Gecko/20100101 Firefox/84.0

Steps to reproduce:

Thunderbird 85.0b2
Activate Dark mode > Right click on any folder > Properties > Retention Policy


Actual results:

The inlined options aren't readable, see screenshot. 


Expected results:

The inlined options should be as readable as the others
Bug: Filterfailure: Infinite loop of messages bouncing between two folders
Status: RESOLVED
Priority: --
Resolution: DUPLICATE
Created: 2021-01-04 23:51:15+00:00
Resolved: 2021-01-12 21:09:52+00:00

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:84.0) Gecko/20100101 Firefox/84.0

Steps to reproduce:

[My System: Thunderbird version 78.6; Windows 10 20H2 (Build 19042.685); IMAP Account via Mail.de]

Create two filters in following order/hirarchy that run automatically on the inbox:

Filter 1: "Match any of the following":
Subject contains keyword;
subject contains keyword;
subject contains keyword
....
--> move to folder Y

Filter 2: "Match any of the following": To contains "xxxx@xxx.xx" --> move to folder Z

Send yourself an e-mail which is eligible for Filter 1, but which is also eligible for Filter 2.

Do NOT add a stop filter condition.


Actual results:

The message lands in the inbox, is moved to the folder Y, then to folder Z, then back to folder Y, then to Z, then Y, then Z, Y, Z, Y, Z; Henceforth bounce between the two folders ad infinity until one of the two message filters is being disabled manually.


Expected results:

The message should move to the folder Y and stay there. Filter 2 should not move the message to anywhere as it never should have been triggered because the message should have been in folder Y before Filter 2 checks the inbox.

To clarify, a STOP FILTER EXECUTION rule is not desired, as it would stop ALL my other filters and there are quite a few. Instead Filters are supposed to run reliably in the order shown in the filter hirarchy.
Bug: Column changes not sticking
Status: RESOLVED
Priority: --
Resolution: INCOMPLETE
Created: 2021-01-05 00:38:05+00:00
Resolved: 2023-01-29 00:24:20+00:00

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:78.0) Gecko/20100101 Firefox/78.0

Steps to reproduce:

MacOS 10.11.6 El Capitan
Change Inbox columns from defaults, i.e. Select FROM; hide Correspondents; hide READ; hide Threads. Moved From to first column on left instead of Subject. 


Actual results:

After checking another mailbox and returning to Inbox, columns revert to default: FROM column disappears; Correspondents is back; Subject is once again first on left; READ has reappeared; Threads has reappeared


Expected results:

Columns should have remained as modified
Bug: scratchpad still available in v 68.10 Thunderbird?
Status: RESOLVED
Priority: --
Resolution: INVALID
Created: 2021-01-05 10:14:58+00:00
Resolved: 2021-01-05 16:41:39+00:00

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:84.0) Gecko/20100101 Firefox/84.0

Steps to reproduce:

Via menu or Shift F4 the Scratchpad is available, yet hitting help in scratchpad takes you to a non existent help page.  A search for scratchpad finds that it is deprecated.   It is referencing Firefox not Thunderbird though.  Is it deprecated in TB and if so shouldn't it be taken off the menu.
Bug: Importing address book from a CSV file always reports an error even if successfully imported
Status: VERIFIED
Priority: --
Resolution: FIXED
Created: 2021-01-05 10:26:47+00:00
Resolved: 2021-02-19 16:32:42+00:00

# Steps to reproduce

1. Download the attached CSV file "example.csv". It was exported from a Thunderbird's address book and it contains just one contact.
2. Start Thunderbird.
3. Click the "Address Book" button in the toolbar.
4. Choose "Tools" => "Import...", then an importer wizard appears.
5. Choose "Address Book" and click the button "Next >".
6. Choose the file type "Text file" and click the button "Next >".
7. Choose the downloaded CSV file "example.csv".
8. Field mapper dialog appears, and click the "OK" button.

# Actual result

The wizard reports an error information: "An error occurred importing addresses from Text file (LDIF, .tab, .csv, .txt)", but all contacts in the CSV file looks to be imported successfully.

# Expected result

The wizard reports no error information, and the CSV file is imported successfully.

# Environment

* Daily 86.0a1 Build ID: 20210104105645 on Windows 10
* Thunderbird 78.6.0 Build ID: 20201211152611 on Windows 10
Bug: Thunderbird always uses Default SMTP
Status: RESOLVED
Priority: --
Resolution: INVALID
Created: 2021-01-05 12:39:38+00:00
Resolved: 2021-01-05 16:04:15+00:00

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:84.0) Gecko/20100101 Firefox/84.0

Steps to reproduce:

1. Created several different email accounts with different providers, eg mail.com, gmail.com, other isp.com etc
2. Assigned relevant SMTP servers for above accounts
3. Selected one SMTP as default
4. Sent email from an email account which was NOT the default SMTP


Actual results:

Mail sent from default SMTP, resulting in bounce or messages, or flagged as spam, or  just vanishing


Expected results:

Thunderbird should always send from the SMTP server associated
Bug: [Exception... "Component returned failure code: 0x80520001 (NS_ERROR_FILE_UNRECOGNIZED_PATH) [nsIXPCComponents_Utils.readUTF8URI]
Status: RESOLVED
Priority: --
Resolution: DUPLICATE
Created: 2021-01-06 02:51:29+00:00
Resolved: 2021-01-06 07:11:21+00:00

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:85.0) Gecko/20100101 Firefox/85.0

Steps to reproduce:

Look at "Error Console"


Actual results:

Found this:
[Exception... "Component returned failure code: 0x80520001 (NS_ERROR_FILE_UNRECOGNIZED_PATH) [nsIXPCComponents_Utils.readUTF8URI]"  nsresult: "0x80520001 (NS_ERROR_FILE_UNRECOGNIZED_PATH)"  location: "JS frame :: resource://gre/modules/L10nRegistry.jsm :: L10nRegistry.loadSync :: line 692"  data: no] L10nRegistry.jsm:692:19
    loadSync resource://gre/modules/L10nRegistry.jsm:692
    fetchFile resource://gre/modules/L10nRegistry.jsm:607
    generateResourceSetSync resource://gre/modules/L10nRegistry.jsm:512
    map self-hosted:221
    generateResourceSetSync resource://gre/modules/L10nRegistry.jsm:507
    generateResourceSetsForLocaleSync resource://gre/modules/L10nRegistry.jsm:449
    next self-hosted:1431
    generateBundlesSync resource://gre/modules/L10nRegistry.jsm:186
    next self-hosted:1431
    touchNext resource://gre/modules/Localization.jsm:167
    generateBundles resource://gre/modules/Localization.jsm:473
    <anonymous> chrome://messenger-smime/content/msgReadSMIMEOverlay.js:31


Expected results:

Not found ^^^
Bug: Uncaught SyntaxError: redeclaration of const THUNDERBIRD_THEME_PREVIEWS (duplicate observer created each time 'About Thunderbird' et alii get shown)
Status: RESOLVED
Priority: --
Resolution: FIXED
Created: 2021-01-06 03:03:48+00:00
Resolved: 2022-09-02 13:59:57+00:00

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:85.0) Gecko/20100101 Firefox/85.0

Steps to reproduce:

Go to "Error Console"


Actual results:

Found this:
Uncaught SyntaxError: redeclaration of const THUNDERBIRD_THEME_PREVIEWS
    <anonymous> chrome://messenger/content/aboutAddonsExtra.js:1
    observe chrome://messenger/content/specialTabs.js:1719
aboutAddonsExtra.js:1:1
    <anonymous> chrome://messenger/content/aboutAddonsExtra.js:1
    observe chrome://messenger/content/specialTabs.js:1719



Expected results:

Not found this: ^^^
Bug: (NS_ERROR_FILE_UNRECOGNIZED_PATH) [nsIXPCComponents_Utils.readUTF8URI]"  nsresult: "0x80520001 (NS_ERROR_FILE_UNRECOGNIZED_PATH)"  location: "JS frame :: resource://gre/modules/L10nRegistry.jsm :: L10nRegistry.loadSync :: line 692
Status: RESOLVED
Priority: --
Resolution: DUPLICATE
Created: 2021-01-06 03:06:35+00:00
Resolved: 2021-01-06 07:10:57+00:00

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:85.0) Gecko/20100101 Firefox/85.0

Steps to reproduce:

Go to "Error Console"


Actual results:

Found this:
[Exception... "Component returned failure code: 0x80520001 (NS_ERROR_FILE_UNRECOGNIZED_PATH) [nsIXPCComponents_Utils.readUTF8URI]"  nsresult: "0x80520001 (NS_ERROR_FILE_UNRECOGNIZED_PATH)"  location: "JS frame :: resource://gre/modules/L10nRegistry.jsm :: L10nRegistry.loadSync :: line 692"  data: no] L10nRegistry.jsm:692:19
    loadSync resource://gre/modules/L10nRegistry.jsm:692
    fetchFile resource://gre/modules/L10nRegistry.jsm:607
    generateResourceSetSync resource://gre/modules/L10nRegistry.jsm:512
    map self-hosted:221
    generateResourceSetSync resource://gre/modules/L10nRegistry.jsm:507
    generateResourceSetsForLocaleSync resource://gre/modules/L10nRegistry.jsm:449
    next self-hosted:1431
    generateBundlesSync resource://gre/modules/L10nRegistry.jsm:186
    next self-hosted:1431
    touchNext resource://gre/modules/Localization.jsm:167
    generateBundles resource://gre/modules/Localization.jsm:473
    <anonymous> resource:///modules/OTRUI.jsm:10
    connectedCallback chrome://messenger/content/chat/chat-conversation-info.js:116
    <anonymous> chrome://global/content/customElements.js:217


Expected results:

Not found this: ^^^
Bug: Thick border caused by the background linear gradient in the tabs toolbar on 4k monitor
Status: RESOLVED
Priority: --
Resolution: FIXED
Created: 2021-01-06 19:06:35+00:00
Resolved: 2021-02-16 15:55:28+00:00

The `#tabs-toolbar` element simulates a bottom border with a linear gradient background image starting with a grey color at 1px.

I have a 32" monitor at 3840x2160 with larger text.
With that resolution, the background gradient shows a thicker border, almost 2px.
Bug: Can't change message priority of received messages: the option is gone
Status: RESOLVED
Priority: --
Resolution: INVALID
Created: 2021-01-06 20:08:20+00:00
Resolved: 2021-01-12 03:29:00+00:00

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 11_0_1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/87.0.4280.88 Safari/537.36

Steps to reproduce:

TB 78.6.0
macOS 11.0.1

Can't change message priority anymore: the option to change priority is gone completely. 

I don't see it nowhere in toolbars, menus, and contextual menus.


Actual results:

No option to change message priority.


Expected results:

Should be able to change message priority.
Bug: Intermittent comm/mail/base/test/performance/browser_preferences_usage.js | gloda.loglevel should not be accessed more than 40 times. - 66 <= 40 - JS frame :: chrome://mochitests/content/browser/comm/mail/base/test/performance/browser_preferences_usage.js
Status: RESOLVED
Priority: P5
Resolution: FIXED
Created: 2021-01-06 22:16:35+00:00
Resolved: 2021-01-11 06:24:32+00:00

**Filed by:** geoff [at] darktrojan.net
**Parsed log:** https://treeherder.mozilla.org/logviewer?job_id=326011538&repo=comm-central
**Full log:** https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/dUSkEljPRmWsUn6_n-mOTA/runs/0/artifacts/public/logs/live_backing.log

---
```
Fixing bug 1683228 has caused this pref to be checked every time gloda logs.```
Bug: Office365 OAuth2 Implementation uses Confidential Client instead of Public Client access
Status: RESOLVED
Priority: P1
Resolution: FIXED
Created: 2021-01-06 22:48:52+00:00
Resolved: 2023-09-14 11:37:22+00:00

Thunderbird using Office365/OAuth2 will not observe Microsoft Azure Conditional Access policies, and therefore survive off-network connections as well as password changes. I spent several months troubleshooting with Microsoft.  What came out of our joint investigations is summarized below:

The Thunderbird Azure App which is used in the implementation of Thunderbirds Office365 OAuth2 authentication uses a confidential client configuration that is designed for protected services/daemons which are usually on protected platforms that can reasonably be expected to protect secrets.  Thunderbird is a desktop application that cannot reasonably be expected to protect secrets, and therefore Microsoft has advised that the Azure App should be reconfigured as a public client, and not use client secrets. 

The current implementation requires Thunderbird to have its Azure App Client Secret hard coded into the source which anyone has access to. A malicious application can impersonate Thunderbird by using this client secret.

I'm recommending an expedient review of this bug for the sake of security.  I'm marking this to keep it hidden so that others will not immediately go perusing the source code looking for the client secret.