Bug: obj-x86_64-pc-solaris2.11/dist/include/mozilla/ProfilerBandwidthCounter.h:8:65: error: expected class-name before ‘{’ token
Status: RESOLVED
Priority: --
Resolution: FIXED
Created: 2024-01-11 08:53:31+00:00
Resolved: 2024-01-12 05:00:26+00:00

Steps to reproduce:

Build Solaris on Solaris fails with:
```
46:54.03 In file included from /builds/psumbera/mozilla-central-build/netwerk/base/nsUDPSocket.cpp:35,
46:54.03                  from Unified_cpp_netwerk_base4.cpp:47:
46:54.03 /builds/psumbera/mozilla-central-build/obj-x86_64-pc-solaris2.11/dist/include/mozilla/ProfilerBandwidthCounter.h:8:65: error: expected class-name before ‘{’ token
46:54.03     8 | class ProfilerBandwidthCounter final : public BaseProfilerCount {
46:54.03       |                                                                 ^
46:54.08 /builds/psumbera/mozilla-central-build/obj-x86_64-pc-solaris2.11/dist/include/mozilla/ProfilerBandwidthCounter.h:32:3: error: ‘ProfilerAtomicSigned’ does not name a type
46:54.08    32 |   ProfilerAtomicSigned mCounter;
46:54.08       |   ^~~~~~~~~~~~~~~~~~~~
46:54.13 /builds/psumbera/mozilla-central-build/obj-x86_64-pc-solaris2.11/dist/include/mozilla/ProfilerBandwidthCounter.h:33:3: error: ‘ProfilerAtomicUnsigned’ does not name a type
46:54.14    33 |   ProfilerAtomicUnsigned mNumber;
46:54.14       |   ^~~~~~~~~~~~~~~~~~~~~~
46:54.14 /builds/psumbera/mozilla-central-build/obj-x86_64-pc-solaris2.11/dist/include/mozilla/ProfilerBandwidthCounter.h: In constructor ‘ProfilerBandwidthCounter::ProfilerBandwidthCounter()’:
46:54.14 /builds/psumbera/mozilla-central-build/obj-x86_64-pc-solaris2.11/dist/include/mozilla/ProfilerBandwidthCounter.h:11:9: error: class ‘ProfilerBandwidthCounter’ does not have any field named ‘BaseProfilerCount’
46:54.14    11 |       : BaseProfilerCount("bandwidth", &mCounter, &mNumber, "Bandwidth",
46:54.14       |         ^~~~~~~~~~~~~~~~~
46:54.18 /builds/psumbera/mozilla-central-build/obj-x86_64-pc-solaris2.11/dist/include/mozilla/ProfilerBandwidthCounter.h:11:41: error: ‘mCounter’ was not declared in this scope
46:54.18    11 |       : BaseProfilerCount("bandwidth", &mCounter, &mNumber, "Bandwidth",
46:54.18       |                                         ^~~~~~~~
46:54.21 /builds/psumbera/mozilla-central-build/obj-x86_64-pc-solaris2.11/dist/include/mozilla/ProfilerBandwidthCounter.h:11:52: error: ‘mNumber’ was not declared in this scope
46:54.21    11 |       : BaseProfilerCount("bandwidth", &mCounter, &mNumber, "Bandwidth",
46:54.21       |                                                    ^~~~~~~
46:54.33 /builds/psumbera/mozilla-central-build/obj-x86_64-pc-solaris2.11/dist/include/mozilla/ProfilerBandwidthCounter.h: In member function ‘void ProfilerBandwidthCounter::Register()’:
46:54.33 /builds/psumbera/mozilla-central-build/obj-x86_64-pc-solaris2.11/dist/include/mozilla/ProfilerBandwidthCounter.h:17:5: error: ‘profiler_add_sampled_counter’ was not declared in this scope
46:54.33    17 |     profiler_add_sampled_counter(this);
46:54.33       |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
46:54.37 /builds/psumbera/mozilla-central-build/obj-x86_64-pc-solaris2.11/dist/include/mozilla/ProfilerBandwidthCounter.h: In member function ‘void ProfilerBandwidthCounter::Add(int64_t)’:
46:54.37 /builds/psumbera/mozilla-central-build/obj-x86_64-pc-solaris2.11/dist/include/mozilla/ProfilerBandwidthCounter.h:28:5: error: ‘mCounter’ was not declared in this scope
46:54.37    28 |     mCounter += aNumber;
46:54.37       |     ^~~~~~~~
46:54.40 /builds/psumbera/mozilla-central-build/obj-x86_64-pc-solaris2.11/dist/include/mozilla/ProfilerBandwidthCounter.h:29:5: error: ‘mNumber’ was not declared in this scope; did you mean ‘aNumber’?
46:54.40    29 |     mNumber++;
46:54.40       |     ^~~~~~~
46:54.40       |     aNumber
```

The first bad revision is:
changeset:   691392:7e8b3b72161f
user:        Florian Quèze <florian@queze.net>
date:        Tue Jan 09 06:41:55 2024 -0800
description:
	Bug 1871545 - add a profiler counter for bandwidth use, r=profiler-reviewers,necko-reviewers,kershaw,canaltinova.

	Differential Revision: https://phabricator.services.mozilla.com/D197148