av9ash/GitBugs huggingface dataset:
Bug: Firefox should not remove passwords when removing history records
Status: RESOLVED
Priority: --
Resolution: WORKSFORME
Created: 2021-09-10 13:39:22+00:00
Resolved: 2021-09-14 17:35:40+00:00

User Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:91.0) Gecko/20100101 Firefox/91.0

Steps to reproduce:

I've opened  history tab and I wanted to 'reduce'  by removing history from for certain web sites.
So I got brilliant idea to remove  web   google.com -  I've selected option for removing whole web.


Actual results:

Well all history records for  google.com  were gone -  perfect.
But to my surprise I've later discovered  all my saved accounts & passwords  were also gone -  catastrophe!!

I managed to 'recover' most of them from my older personal backup of passwords (lesson learned from previous catastrophic logic in ff)


Expected results:

Only web history links should be gone! - I work with HISTORY tab - and I take stored 'passwords'  as completely different entity - unrelated to history.

If you want to remove passwords - there should be at least a prompt - telling me - hey I'm not only removing your history entries - but your #X paswords for this web will also disappear - so I could at least cancel it before making another similar disaster. And if you could enable/disable preserving them for removed network the better ;) I'd see this as 'advanced' way to solve this.
Bug: Privacy leak/broken PDF-setup in private browsing mode
Status: RESOLVED
Priority: --
Resolution: DUPLICATE
Created: 2021-09-10 14:27:10+00:00
Resolved: 2022-03-29 10:35:36+00:00

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Firefox/91.0

Steps to reproduce:

1. Enable permanent private browsing mode
2. Open a PDF from the web for example https://cdn.discordapp.com/attachments/712712343393533999/813101874382504037/arcade.pdf


Actual results:

Firefox asks what to do with the PDF despite opening it in Firefox being the default. Even selecting to open the PDF now with Firefox and enabling the checkbox to make this action the default does still cause asking via this popup what to do with the PDF on the next try again. Additionally the PDF is stored and viewed from the user's temporary folder while there was no initial feedback that this would happen causing a privacy breach.


Expected results:

At least Firefox should give feedback that opening the PDF causes a privacy leak here or to not allow to do this action at all. But since there is no strict technical limitation why Firefox can't handle the PDF in-memory as it already does with most other storage actions this is probably the real longterm-solution - as in the STR the PDF would then simply open without the popup and no privacy leak would occur.
Bug: Prevent Copy button to send information to Cloud Clipboard and Clipboard History on Windows
Status: VERIFIED
Priority: P1
Resolution: FIXED
Created: 2021-09-10 15:33:20+00:00
Resolved: 2022-10-05 01:31:03+00:00

Windows 10 introduced Cloud Clipboard and Clipboard History, when app uses classic clipboard API the information goes to the local clipboard and to the cloud/history as well.

This is typically not clear or known to user, so they might not understand they are copying their sensitive information to the cloud and history.

There is no known way to disable these features for the whole app, but if we add 3 clipboard formats listed here https://docs.microsoft.com/en-us/windows/win32/dataxchg/clipboard-formats#cloud-clipboard-and-clipboard-history-formats we will prevent sensitive data from going to the unexpected places.
Bug: about:preferences#general doesn't display (in or out of Troubleshooting Mode)
Status: VERIFIED
Priority: P1
Resolution: FIXED
Created: 2021-09-10 17:43:44+00:00
Resolved: 2021-10-12 13:33:08+00:00

My about:preferences#general doesn't display in Troubleshooting Mode. I get these messages in the console:
Error initializing preference category paneGeneral: TypeError: can't access property "getAttribute", aElemKey is null preferences.js:287
    gotoPref chrome://browser/content/preferences/preferences.js:287
    AsyncFunctionThrow self-hosted:696
Uncaught (in promise) TypeError: can't access property "getAttribute", aElemKey is null
    prettifyShortcut resource://gre/modules/ShortcutUtils.jsm:55
    init chrome://browser/content/preferences/main.js:443
    init chrome://browser/content/preferences/preferences.js:106
ShortcutUtils.jsm:55:22
Uncaught (in promise) TypeError: can't access property "getAttribute", aElemKey is null
    prettifyShortcut resource://gre/modules/ShortcutUtils.jsm:55
    init chrome://browser/content/preferences/main.js:443
    init chrome://browser/content/preferences/preferences.js:106
    initializeCategories chrome://browser/content/preferences/findInPage.js:96
    init chrome://browser/content/preferences/findInPage.js:52
ShortcutUtils.jsm:55:22
Bug: SuggestURLTemplate isn't working in SearchEngines policy
Status: RESOLVED
Priority: P2
Resolution: FIXED
Created: 2021-09-10 17:46:30+00:00
Resolved: 2021-12-21 14:15:45+00:00

SuggestURLTemplate isn't working on policies

It's a typo:

suggestUrlGetParams: newEngine.SuggestURLTemplate,

should be

suggest_url
Bug: Vertical spacing beetween entries in a bookmark folder dropdown is way too large!
Status: RESOLVED
Priority: --
Resolution: DUPLICATE
Created: 2021-09-10 19:19:25+00:00
Resolved: 2021-11-29 11:38:31+00:00

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:89.0) Gecko/20100101 Firefox/89.0

Steps to reproduce:

Click on a bookmark folder.


Actual results:

The folder contents list dropped down with a vertical spacing between the entries of appx. 9(!) mm!


Expected results:

Vertical spacing between the entries as small as possible.
Bug: User copy/paste gets around restriction on opening non-web protocols (file:, about:, etc)
Status: NEW
Priority: --
Created: 2021-09-10 19:22:15+00:00
Resolved: 2024-05-02 09:29:08+00:00

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/93.0.4577.63 Safari/537.36

Steps to reproduce:

1. Visit https://kirtikumarar.com/mozilla/uri.html
2. Right-click on the image and copy the image URI
3. Open a new tab and enter it



Actual results:

It shouldn't copy the Privileged URI.


Expected results:

It copies privileged URI
Bug: Navigation to Privileged URI from Unprivileged URIs (Data URIs)
Status: RESOLVED
Priority: --
Resolution: DUPLICATE
Created: 2021-09-10 19:30:59+00:00
Resolved: 2024-09-16 05:46:22+00:00

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/93.0.4577.63 Safari/537.36
Firefox for Android

Steps to reproduce:

1. Visit data:text/html,<img src="about:preferences">
2. Right-click copy Image link and open new tab paste it


Actual results:

It copies Privileged URI from Unprivileged pages


Expected results:

It shouldn't copy privileged URIs from Unprivileged Pages
Bug: Pinned tabs showing under down arrow "list all tabs" after last update (v92.0)
Status: RESOLVED
Priority: --
Resolution: DUPLICATE
Created: 2021-09-11 00:42:31+00:00
Resolved: 2021-10-07 17:26:53+00:00

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:92.0) Gecko/20100101 Firefox/92.0

Steps to reproduce:

1. Pin few tabs.
2. Open many new tabs to down arrow "list all tabs" appears.
3. Click down arrow "list all tabs".

Before version 92.0 pinned tabs was not showing under down arrow "list all tabs". I was trying to find switch to disable this thing but there is no option in settings or about:config.


Actual results:

Pinned tabs showing under down arrow "list all tabs" after last update to version 92.0


Expected results:

Before version 92.0 pinned tabs was not showing under down arrow "list all tabs".
Bug: Closing Firefox Attempts to Close All Tabs
Status: RESOLVED
Priority: --
Resolution: WORKSFORME
Created: 2021-09-11 03:13:06+00:00
Resolved: 2021-09-23 17:13:11+00:00

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:94.0) Gecko/20100101 Firefox/94.0

Steps to reproduce:

1. Update and restart using the tool menu option Firefox Nightly to 94.0a1
2. The window reopened with all the saved tabs
3. Attempt to close the window


Actual results:

A warning appears, "Close 2604 tabs?" (I have a lot of tabs open)

Additional information: Checked after the update and the "Open Previous Windows and Tabs" is enabled in Settings -> General -> Startup. Not sure if that was different before the update.


Expected results:

Firefox should have closed with no warning and opening Firefox should then restore the 2604 tabs. This was the functionality before updating.
Bug: Tooltip is shown doubly on hover over the maximize button
Status: VERIFIED
Priority: --
Resolution: FIXED
Created: 2021-09-11 03:30:54+00:00
Resolved: 2021-11-15 00:36:57+00:00

Steps to reproduce:
Hover the mouse cursor over the maximize button.

Actual result:
On Windows 10, two "Maximize" tooltips are shown.
On Windows 11, both tooltip and Snap Layouts menu will be shown.

Expected result:
Only single tooltip or Snap Layouts menu should be shown.

We should stop showing "Maximize" tooltip on our own. The operating system will do it for us.
Bug: Multi-factor Authentication
Status: RESOLVED
Priority: --
Resolution: DUPLICATE
Created: 2021-09-11 11:34:32+00:00
Resolved: 2023-05-23 03:28:37+00:00

Hi team,
I found one issue related to your 2FA system on https://accounts.firefox.com

Access the same account on https://accounts.firefox.com on two devices
On-device 'Firefox' go to https://accounts.firefox.com > complete all steps to activate the 2FA system.
Now the 2FA is activated for this account.
Back to device 'Firefox Developer Edition' reload the page
The session is still active.

Impact
In this scenario when 2FA has activated the other sessions of the account are not invalidated.
2FA is required to log in. I believe the expected and recommended behaviour here is to terminate the other sessions> request a new login> request the 2FA code> so then give the account access again

Reference:
https://hackerone.com/reports/667739

POC:
"1st POC Im using both Firefox and Firefox Developer Edition"
"2nd the time Im Using Firefox and Brave Browser"

I am attaching a video so that it can be understood properly.
Take a look and do the needful,

Thank you
(BOOPATHI S)
Bug: Bookmark selection stepping
Status: RESOLVED
Priority: --
Resolution: DUPLICATE
Created: 2021-09-11 20:18:20+00:00
Resolved: 2021-09-27 21:06:29+00:00

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:92.0) Gecko/20100101 Firefox/92.0

Steps to reproduce:

1. Open browser at https://www.google.com (not site specific)
2. Open bookmarks using Firefox menu 'Bookmarks' item. Approx 100  bookmarks/subfolders in top level.
3. Hover the mouse pointer over a bookmark entry so blue selection highlight appears. 
4. Move mouse pointer to different bookmark entries. 



Actual results:

The selection highlight steps, entry by entry, to the next hover point; at a variable rate but sometimes taking 1-2 seconds. More apparent when subfolders are involved in the step-over. Observed similar behavior in troubleshoot mode.

Profiler shows some mouse moves taking 15-25 ms. No Windows mouse related delay outside of Firefox.
https://share.firefox.dev/3E5ZPeO  (file also attached)


Expected results:

Minimal delay in bookmarks usage.
Bug: Using the system theme and a high contrast theme on the OS gives unexpected results
Status: RESOLVED
Priority: P3
Resolution: INCOMPLETE
Created: 2021-09-11 23:22:35+00:00
Resolved: 2023-06-02 15:22:06+00:00

Steps:
0. Enable a high contrast theme on the Windows settings
1. Go to about:addons in Firefox
2. Click "Themes"
3. Select "System theme"

Actual results:
The theme is not applied correctly and there's an artifact on the top right corner of the window to the right of the _ [] X button.

Expected results:
The theme is applied correctly and there's no artifact on the top right corner of the window to the right of the _ [] X button.
Bug: Findbar can't be closed if the bookmarks sidebar is also active
Status: RESOLVED
Priority: --
Resolution: DUPLICATE
Created: 2021-09-12 10:03:46+00:00
Resolved: 2021-09-12 10:57:21+00:00

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:92.0) Gecko/20100101 Firefox/92.0

Steps to reproduce:

1.) Open the bookmarks sidebar (Ctrl+B)
2.) Open the Findbar (Ctrl+F)



Actual results:

The "X" to close the findbar is buried beneath the bookmarks sidebar and can't be accessed. I cannot close the findbar.


Expected results:

The findbar should be shorter by the width of the bookmarks sidebar, so the X to close the findbar is visible at all times.
Bug: Intermittent browser/components/customizableui/test/browser_panel_keyboard_navigation.js | Uncaught exception received from previously timed out test - ViewShown listener on #appMenu-protonMainView not removed before the end of test
Status: RESOLVED
Priority: P5
Resolution: INCOMPLETE
Created: 2021-09-12 12:49:24+00:00
Resolved: 2021-12-27 06:06:17+00:00

**Filed by:** ccozmuta [at] mozilla.com
**Parsed log:** https://treeherder.mozilla.org/logviewer?job_id=351296705&repo=autoland
**Full log:** https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/KseYLpIrSWCwDjmaOg8BRg/runs/0/artifacts/public/logs/live_backing.log

---
```
task 2021-09-12T11:57:21.277Z] 11:57:21     INFO - TEST-START | browser/components/customizableui/test/browser_panel_keyboard_navigation.js
[task 2021-09-12T11:58:06.348Z] 11:58:06     INFO - TEST-INFO | started process screencapture
[task 2021-09-12T11:58:06.540Z] 11:58:06     INFO - TEST-INFO | screencapture: exit 0
[task 2021-09-12T11:58:06.540Z] 11:58:06     INFO - Buffered messages logged at 11:57:21
[task 2021-09-12T11:58:06.540Z] 11:58:06     INFO - Entering test bound testUpDownKeys
[task 2021-09-12T11:58:06.540Z] 11:58:06     INFO - TEST-PASS | browser/components/customizableui/test/browser_panel_keyboard_navigation.js | The panel is closed to begin with. - "closed" == "closed" - 
[task 2021-09-12T11:58:06.541Z] 11:58:06     INFO - Buffered messages finished
[task 2021-09-12T11:58:06.541Z] 11:58:06     INFO - TEST-UNEXPECTED-FAIL | browser/components/customizableui/test/browser_panel_keyboard_navigation.js | Test timed out - 
[task 2021-09-12T11:58:06.541Z] 11:58:06     INFO - Not taking screenshot here: see the one that was previously logged
[task 2021-09-12T11:58:06.541Z] 11:58:06     INFO - TEST-UNEXPECTED-FAIL | browser/components/customizableui/test/browser_panel_keyboard_navigation.js | Uncaught exception received from previously timed out test - ViewShown listener on #appMenu-protonMainView not removed before the end of test
[task 2021-09-12T11:58:06.541Z] 11:58:06     INFO - GECKO(1516) | MEMORY STAT | vsize 410836MB | residentFast 552MB | heapAllocated 148MB
[task 2021-09-12T11:58:06.541Z] 11:58:06     INFO - TEST-OK | browser/components/customizableui/test/browser_panel_keyboard_navigation.js | took 45074ms
[task 2021-09-12T11:58:06.542Z] 11:58:06     INFO - checking window state
[task 2021-09-12T11:58:06.542Z] 11:58:06     INFO - TEST-START | browser/components/customizableui/test/browser_panel_locationSpecific.js
```
Bug: "Hash not found" with Firefox 91.0, 91.0.1, 91.0.2 and 92.0
Status: RESOLVED
Priority: --
Resolution: INVALID
Created: 2021-09-12 15:27:00+00:00
Resolved: 2021-09-22 16:11:38+00:00

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:90.0) Gecko/20100101 Firefox/90.0

Steps to reproduce:

I just downloaded the installer file for Ffx 92.0, it now being 12 Sep 2021, tried to upload the file to VirusTotal.com, VT couldn't find a or the hash, so I cancelled out of that upload and won't install Ffx 92.0 at all.  This didn't happen for me prior to the series of three releases for Ffx 91.0.x, so this began, for me anyway, with 91.0.  Here's a link to my post submitted on 26 Aug 2021 about the 91.0.x series, providing some additional information, 

https://support.mozilla.org/en-US/questions/1348638

I possibly had this "hash not found" two or maybe three times for installers of different applications downloaded over the Internet, but this hasn't happened for years, until Ffx 91.0.  And I'm presently using a portable/laptop computer, only saying this in case this it is of any importance.


Actual results:

Hash can't be found by VT.


Expected results:

Hash would be found by VT.
Bug: Some downloads fail to save with "There are no more files" message
Status: RESOLVED
Priority: --
Resolution: INCOMPLETE
Created: 2021-09-12 20:51:17+00:00
Resolved: 2023-10-03 12:07:51+00:00

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:92.0) Gecko/20100101 Firefox/92.0

Steps to reproduce:

1 - Clicked a download link
2 - Save dialog opens
3 - Click Save
4 - Get message "There are no more files"


Actual results:

Sometime it works, sometimes it fails.
Sometime it saves a file and then trying to save a second file fails.
When it fails, I can copy the download link, open a different browser and the download proceeds normally.

This has been going on for the last several months.


Expected results:

It should have saved the file
Bug: Book marks are all double spaced and hard to read on FF 92
Status: RESOLVED
Priority: --
Resolution: DUPLICATE
Created: 2021-09-13 04:00:58+00:00
Resolved: 2021-11-29 11:38:35+00:00

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:92.0) Gecko/20100101 Firefox/92.0

Steps to reproduce:

Click on my book marks


Actual results:

all my book marks take over double the screen space, and need to scroll to find entries that were previously easily accessible.
I have tried adjusting font size, but unable to fix.


Expected results:

Nicely formatted drop list without double spacing.
Bug: All cells in a table are exposed as selectable, even without aria-selectable attribute
Status: NEW
Priority: P3
Created: 2021-09-13 09:49:17+00:00
Resolved: 2025-01-20 12:27:35+00:00

User Agent:   Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:92.0) Gecko/20100101 Firefox/100.0

Steps to reproduce:

Inspect accessibility properties of a generic HTML table


Actual results:

All cell and columnheader cells exposed state "selectable" in the accessibility tree.


Expected results:

Only widgets should expose "selectable" that are explicitly selectable by either
a) presence of the aria-selected attribute
b) implicit selection is possible due to focusable cells

In tables, rows maybe selectable instead of cells.
Bug: [MSIX] Firefox not functioning as it should if Import is performed from an .exe installation on latest Windows 11 Pro build
Status: NEW
Priority: P3
Created: 2021-09-13 12:44:45+00:00
Resolved: 2024-07-03 18:54:08+00:00

*Affected versions*
* 93.0b4MSIX 
* 94.0a1MSIX 
* 92.0b9MSIX



*Affected platforms*

* Windows 11 - winver Build 22454.100 (Dev Channel) / Build 22454.rs_prerelease.210903-1516


*Preconditions*
* Have normal Firefox.exe installed 


*Steps to reproduce*
1. Instal Firefox .msix package and open it (we use treehereder builds).
2. Close it and open it again.
3.1. Open Web Console - Ctrl + Shift + K.
3.2. Sign in to Sync.
3.3. Observe about:addons -> Languages




*Expected result*
* 3.1. The console is displayed as expected.
* 3.2. User can sign in to Sync.
* 3.3. All language add-ons are enabled.

*Actual result*
* 3.1. Blank console displayed.
* 3.2. `Cookies and local storage are required` error is displayed: [link](https://drive.google.com/file/d/1Sme8RYL_IV-2OC2dB3ZXb1l60f6YYDfp/view?usp=sharing).
* 3.3. All language addons are disabled. If they are enabled manually and firefox closed and reopened they need to be re-enabled again-> [screenrecording](https://drive.google.com/file/d/1Osr-I1iG2WBJCaVK3s9_aINxusb0BHH9/view?usp=sharing)


*Regression range*
*  I don’t think this is a Firefox regression. This happens with the latest MS Windows update (Build 22454.100) only. On Version 21H2 (OS Build 22000.184) the issues were not reproducible.






*Notes*
* Attached browser console errors.
* MSIX builds were downloaded from treeherder.
* 92.0b9 was installed using `ms-windows-store://pdp/?productid=9P9GJR8PH8TT` link. I can reproduce the above problems as well besides language one. On this build, there are no Language addons installed.
* about:support page is blank as well
* saved logins are not remebered after reopening Firefox
* S2 because this only happens if a normal Firefox is installed before the .msix installation.
Bug: New tab customize checkbox checkmark is hard to see on light theme
Status: VERIFIED
Priority: --
Resolution: FIXED
Created: 2021-09-13 18:09:31+00:00
Resolved: 2022-01-21 17:43:55+00:00

Looks like the checkbox check got switched but not the slider toggle. Unclear if they should be the same as each other?

```
--customize-menu-check-fill: #{$newtab-card-primary-text-color};
 --customize-menu-primary-action-text: #{$white};
```
https://searchfox.org/mozilla-central/rev/5f81c5091d442d829120e19477ba869ae5219709/browser/components/newtab/content-src/styles/_theme.scss#111,119
Bug: White flash before about:home/newtab themed background is rendered
Status: VERIFIED
Priority: P2
Resolution: FIXED
Created: 2021-09-13 18:23:15+00:00
Resolved: 2021-10-20 09:45:13+00:00

Using the prototype monochromatic purple theme from bug 1725468, opening new windows shows the empty browser background color before new tab page renders with the themed color. This is similar to the regression/fix from bug 1693819 and 1706360 needing to get the content color to match.

https://searchfox.org/mozilla-central/rev/5f81c5091d442d829120e19477ba869ae5219709/browser/themes/shared/tabs.inc.css#18-20

In general, I believe this has been happening for 3rd party themes that set the newtab background color. It's not as bad for opening a new tab as that page is preloaded.
Bug: The Customize button in the Firefox Suggest online onboarding dialog should open the Privacy pref pane, not the Search pane
Status: VERIFIED
Priority: P1
Resolution: FIXED
Created: 2021-09-13 19:32:10+00:00
Resolved: 2021-09-21 14:07:41+00:00

Bug 1728430 moved the Firefox Suggest prefs from the Search pane to the Privacy pane, but the Customize button still opens the Search pane. Per spec in the Jira, the Customize button:

> opens Preferences in new tab ->
> highlights Address bar -- Firefox Suggest under Privacy & Security
Bug: Images not rendering after syncing account
Status: RESOLVED
Priority: --
Resolution: INVALID
Created: 2021-09-13 20:27:57+00:00
Resolved: 2021-09-14 01:13:19+00:00

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Firefox/91.0

Steps to reproduce:

1- Open PNG tab of `https://www.svgviewer.dev/svg-to-png` for easy testing
2- Check that the PNG image loads correctly
3- Sync to my Firefox account
4- Check the PNG image


Actual results:

The image doesn't load, it shows a bunch of seemingly random coloured pixels. It sometimes happens with tab icons as well.


Expected results:

Images should load normally.
Bug: Stop recording event telemetry when Firefox Suggest prefs are set on startup to default-enable the offline scenario
Status: RESOLVED
Priority: P1
Resolution: DUPLICATE
Created: 2021-09-13 21:15:13+00:00
Resolved: 2021-09-16 18:42:21+00:00

We fixed bug 1729776 by [setting some prefs](https://searchfox.org/mozilla-central/rev/d3a34b89169363b1f91eb75d4c7bdc397efb2e0c/browser/components/urlbar/UrlbarPrefs.jsm#553) on the default branch on every startup. For two of those prefs, `browser.urlbar.suggest.quicksuggest` and `browser.urlbar.suggest.quicksuggest.sponsored`, we have a listener that [records telemetry events](https://searchfox.org/mozilla-central/rev/d3a34b89169363b1f91eb75d4c7bdc397efb2e0c/browser/components/urlbar/UrlbarProviderQuickSuggest.jsm#319) whenever they're toggled. Unfortunately that means these events are recorded on every startup (for users where offline is enabled by default). Probably not great.

It's not important, but for completeness, one caveat is that if you set those prefs to false, then the pref listener doesn't fire so we don't record events. So the bug here only manifests for users where offline is the default and they haven't opted out of suggestions.