av9ash/GitBugs huggingface dataset:
Bug: `./mach repackage msix` fails when branding isn't specified in mozconfig.
Status: RESOLVED
Priority: P3
Resolution: FIXED
Created: 2023-02-17 21:15:30+00:00
Resolved: 2023-02-19 21:20:46+00:00

`./mach repackage msix --sign` returns the following error when branding is not specified in mozconfig:

```
 0:00.78 Adding files from 'C:/mozilla-source/builds/obj-ff-debug-full\dist\bin'
 0:02.24 AppConstants.sys.mjs display version is '112.0a1' and build ID is '20230217125738': embedded version will be '112.2302.1712.0'
 0:02.24 Read 'MOZ_BRANDING_DIRECTORY' from browser/confvars.sh:
 0:02.24 Checking buildconfig.html for --with-branding build flag.
 0:02.24 No branding set; Using branding from ''.
Error running mach:

    ['repackage', 'msix', '--sign', '-o', 'C:/mozilla-source/builds/ff.msix']

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.
You can invoke |./mach busted| to check if this issue is already on file. If it
isn't, please use |./mach busted file repackage| to report it. If |./mach busted| is
misbehaving, you can also inspect the dependencies of bug 1543241.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

FileNotFoundError: [Errno 2] No such file or directory: 'C:/mozilla-source/mozilla-unified/configure.sh'

  File "C:\mozilla-source\mozilla-unified\python\mozbuild\mozbuild\mach_commands.py", line 2562, in repackage_msix
    output = repackage_msix(
  File "c:\mozilla-source\mozilla-unified\python\mozbuild\mozbuild\repackaging\msix.py", line 505, in repackage_msix
    lines = open(mozpath.join(branding, "configure.sh")).readlines()

Sentry event ID: db0a42d6e6f2476da5a115059c16185e
Sentry is attempting to send 0 pending error messages
Waiting up to 2 seconds
Press Ctrl-Break to quit
```

We suspect this was regressed by Bug 1789178.
Bug: Context menu items stay highlighted after moving cursor away from them
Status: VERIFIED
Priority: --
Resolution: FIXED
Created: 2023-02-17 22:05:54+00:00
Resolved: 2023-10-26 16:38:52+00:00

Steps to reproduce:
1) Right click a webpage
2) Hover context menu items with your cursor
3) Move your cursor away from the context menu 

Actual results:
Menu item stays highlighted 

Expected result:
Menu item is not highlighted
Bug: Some ASRouter tests are unnecessarily repeatedly reloading messages
Status: RESOLVED
Priority: P3
Resolution: FIXED
Created: 2023-02-17 23:22:43+00:00
Resolved: 2023-03-14 01:13:31+00:00

[See here for example](https://searchfox.org/mozilla-central/rev/df2a7bff8fa01ebc6292e68ce7e3c7b7cf8fc33c/browser/components/newtab/test/browser/browser_asrouter_group_frequency.js#45-49):
```js
  await BrowserTestUtils.waitForCondition(async () => {
    await ASRouter._updateMessageProviders();
    await ASRouter.loadMessagesFromAllProviders();
    return ASRouter.state.messages.length > initialMsgCount;
  }, "Should load the extra heartbeat message");
```
`waitForCondition` basically runs the callback on an interval, so it's not just waiting for that last condition, it's calling the two first methods repeatedly, but they only need to be called once. It should probably be separated like this:
```js
  await ASRouter._updateMessageProviders();
  await ASRouter.loadMessagesFromAllProviders();
  await BrowserTestUtils.waitForCondition(
    async () => ASRouter.state.messages.length > initialMsgCount,
    "Should load the extra heartbeat message"
  );
```
Bug: When opening firefox, the browser will sometimes open to a different webpage than what is set as preferred
Status: RESOLVED
Priority: --
Resolution: INCOMPLETE
Created: 2023-02-18 04:00:44+00:00
Resolved: 2023-03-23 21:24:15+00:00

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/110.0

Steps to reproduce:

Opened Firefox to simply use it as a web browser without interference.


Actual results:

The browser opened to a strange page showing some update and pushing me to install suspicious software.


Expected results:

The browser should've opened to the homepage set in my preferences so that I could use the browser without interference.
Bug: Bookmarks toolbar folder, long list, scroll position resets if click on a bookmark
Status: RESOLVED
Priority: --
Resolution: DUPLICATE
Created: 2023-02-18 08:44:43+00:00
Resolved: 2023-02-18 09:53:43+00:00

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:109.0) Gecko/20100101 Firefox/110.0

Steps to reproduce:

Have bookmarks toolbar always show, have a folder on the toolbar, have 100+ bookmarks in the folder.  Scroll down the list.  Click away so the list disappears.  Click the bookmark folder again, the position in the list is where you left it, as it was in 108 and before.  Now click on a bookmark and let that page load.  Now click on the bookmark folder again, ...


Actual results:

The list is all the way back at the top.  You have to scroll down again back to where you were in the list to open the next bookmark in the sequence you were processing.


Expected results:

The same as it's always been through 108, the bookmark folder list should be presented at the same position in the folder list as last seen, when I clicked the bookmark previously.

Note, this position persistence has always been specific to the window.  If I open a new window, the position starts at the top until I've scrolled down into it.  The persistence is still there, but is getting reset if I actually click a bookmark now.
Bug: Some locales - close button of system menu disappears when menubar is enabled and window is shrunk horizontally
Status: RESOLVED
Priority: --
Resolution: DUPLICATE
Created: 2023-02-18 09:39:55+00:00
Resolved: 2023-02-23 17:52:28+00:00

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/110.0

Steps to reproduce:

I shrink Firefox window vertically to limit.


Actual results:

The close button of the firefox system menu (upper right corner) disappears


Expected results:

The Firefox window should have a minimum size that allows the complete system menu (minimize|restore|close) to be visible.
Bug: NULL dereferences on MIME handler failures on OpenBSD
Status: RESOLVED
Priority: --
Resolution: FIXED
Created: 2023-02-18 14:45:49+00:00
Resolved: 2024-09-26 06:41:14+00:00

Steps to reproduce:

Try to download a magnet feed, selecting qbittorrent as handler.


Actual results:

The firefox main process crashed


Expected results:

Firefox should have downloaded the magnet feed and passed it to qbittorrent to handle.
Bug: Download PDF Automatically Saved Even Though Option to "Always Ask Is Checked
Status: RESOLVED
Priority: --
Resolution: INVALID
Created: 2023-02-18 20:26:17+00:00
Resolved: 2023-02-21 14:18:52+00:00

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/110.0

Steps to reproduce:

Verified in settings>General>Files and Applications>"Always ask where to save files" is checked>Applications>Content Type is Foxit PDF>Action is "Always ask" is stated>"Ask whether to open or save files" is checked.  

Regardless of the options, a download always occurs to saved file location.


Actual results:

There was no change even under new profile.  
I always get a window asking "What Firefox should do with the file".  If I choose "Open with" option which is Foxit PDF, the file is always saved anyway to the folder chosen in the "Files and Applications" area.


Expected results:

A window does pop that offers whether to save the file and to where or simply open it.  After selecting "Open with", the PDF should not have been saved to the saved file location, but still does.
Bug: File context menu in Downloads Panel opens for wrong file
Status: VERIFIED
Priority: P2
Resolution: FIXED
Created: 2023-02-19 14:00:51+00:00
Resolved: 2023-03-27 15:13:19+00:00

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/110.0

Steps to reproduce:

- Download several files
- Delete them from the disk (without clearing the menu)
- Start downloading another file
- Right-click on any deleted file (doesn't always work the first time)


Actual results:

Context menu opened for the file currently being downloaded


Expected results:

Context menu must be open for the file that was right-clicked
Bug: Dark mode setting is ignored in FF 102.8.0esr
Status: RESOLVED
Priority: --
Resolution: INCOMPLETE
Created: 2023-02-19 23:04:40+00:00
Resolved: 2025-02-01 00:52:40+00:00

User Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101 Firefox/102.0

Steps to reproduce:

1. Upgraded to Firefox 102.8.0esr on aarch64 device
2. Set the browser theme to Dark.
3. Noticed that websites that were previously dark mode are no longer.
4. Performed test on personal site, which uses @media (prefers-color-scheme: dark) and @media (prefers-color-scheme: light) and found dark scheme is ignored.



Actual results:

Websites' Dark color scheme, specified in CSS, is ignored and therefore newly broken.


Expected results:

Colors from @media (prefers-color-scheme: dark)  should always be used to render the page when the browser is set to Dark mode.
Bug: Pressing tab in location bar selects new result menu
Status: RESOLVED
Priority: --
Resolution: DUPLICATE
Created: 2023-02-20 00:26:19+00:00
Resolved: 2023-02-20 09:52:50+00:00

Pressing "tab" repeatedly in the location bar pop-up now doesn't move one line per press anymore, but selects a new three dot menu (which is apparently called the "result menu") on the way down. This results in many extra key presses and a slightly inconsistent experience, since not all lines have the result menu (e.g. when there's a "Switch to tab" option).

Assuming keyboard navigation to this extra menu is a rather rare action, I suggest to use the arrow keys for it. Arrow down to cycle through results - arrow right to select the three dot menu. The right key is currently unmapped in this context, so a perfect candidate that doesn't break existing behaviour.

Using arrow down as main action for the very common task of cycling through results is an inefficient workaround, as it involves full hand movement (compared to just a tiny stretch).
Bug: "Always ask you where to save files" is not working, the file gets downloaded automatically
Status: RESOLVED
Priority: --
Resolution: INVALID
Created: 2023-02-20 07:23:21+00:00
Resolved: 2023-03-03 10:12:15+00:00

From github: https://github.com/webcompat/web-bugs/issues/118407.

> <!-- @browser: Firefox 110.0 -->
> <!-- @ua_header: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/110.0 -->
> <!-- @reported_with: unknown -->
> <!-- @public_url: https://github.com/webcompat/web-bugs/issues/118407 -->
> 
> **URL**: https://sam.gov/opp/8c35a6cc1692492e94c337ba645ecce5/view
> 
> **Browser / Version**: Firefox 110.0
> **Operating System**: Windows 10
> **Tested Another Browser**: Yes Chrome
> 
> **Problem type**: Something else
> **Description**: Despite "Always ask you where to save files" being enabled, Firefox will automatically save PDFs to the Downloads folder. This defeats the purpose of the feature being ticked on.
> **Steps to Reproduce**:
> In Chrome, I navigated to Settings--> Downloads and enabled option "Ask where to save each file before downloading". I then navigated to the URL provided in this submission, and Chrome correctly prompted me to select a destination download folder.
> <details>
>       <summary>View the screenshot</summary>
>       <img alt="Screenshot" src="https://webcompat.com/uploads/2023/2/c5f673c7-92aa-40d6-8813-79785db8967d.jpeg">
>       </details>
> 
> <details>
> <summary>Browser Configuration</summary>
> <ul>
>   <li>None</li>
> </ul>
> </details>
> 
> _From [webcompat.com](https://webcompat.com/) with ❤️_

Change performed by the [Move to Bugzilla add-on](https://addons.mozilla.org/en-US/firefox/addon/move-to-bugzilla/).
Bug: Intermittent uriloader/exthandler/tests/unit/test_filename_sanitize.js | xpcshell return code: 0
Status: RESOLVED
Priority: P5
Resolution: FIXED
Created: 2023-02-20 09:05:06+00:00
Resolved: 2024-09-23 09:40:15+00:00

**Filed by:** chorotan [at] mozilla.com
**Parsed log:** https://treeherder.mozilla.org/logviewer?job_id=406237464&repo=autoland
**Full log:** https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/aL4Rv_yzSXu78Y7l1S0Gdg/runs/0/artifacts/public/logs/live_backing.log

---
```
task 2023-02-20T08:50:00.224Z] 08:50:00     INFO -  TEST-START | uriloader/exthandler/tests/unit/test_filename_sanitize.js
[task 2023-02-20T08:50:00.342Z] 08:50:00  WARNING -  TEST-UNEXPECTED-FAIL | uriloader/exthandler/tests/unit/test_filename_sanitize.js | xpcshell return code: 0
[task 2023-02-20T08:50:00.342Z] 08:50:00     INFO -  TEST-INFO took 117ms
[task 2023-02-20T08:50:00.342Z] 08:50:00     INFO -  >>>>>>>
[task 2023-02-20T08:50:00.342Z] 08:50:00     INFO -  (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2023-02-20T08:50:00.342Z] 08:50:00     INFO -  (xpcshell/head.js) | test run_next_test 0 pending (2)
[task 2023-02-20T08:50:00.342Z] 08:50:00     INFO -  (xpcshell/head.js) | test MAIN run_test finished (2)
[task 2023-02-20T08:50:00.342Z] 08:50:00     INFO -  running event loop
[task 2023-02-20T08:50:00.342Z] 08:50:00     INFO -  uriloader/exthandler/tests/unit/test_filename_sanitize.js | Starting validate_filename_method
[task 2023-02-20T08:50:00.342Z] 08:50:00     INFO -  (xpcshell/head.js) | test validate_filename_method pending (2)
```
Bug: [win] Open with has empty dropdown option displayed if the zip download type is set to Always ask and Windows doesn't know about application/zip
Status: NEW
Priority: P3
Created: 2023-02-20 10:15:14+00:00
Resolved: 2023-05-25 15:05:46+00:00

**Found in**
* 111.0b3


**Affected versions**
* 112.0a1 (2023–02-19)
* 111.0b2
* 110.0
* 102.8.0esr (affected by )



**Tested platforms**
* Affected platforms: Windows 10x64, Windows 7x64
* Unaffected platforms: Ubuntu 20.04, macOS 12




**Steps to reproduce**
1. Download a random file like http://ipv4.download.thinkbroadband.com/5MB.zip.
2. Open the downloads drop-down and select the `Always open similar files` by r-clicking the downloaded item.
3. Open about:prefrences and scroll down to the downloads sections.
4. Set the `Always ask` action for the zip content type.
5. Download again http://ipv4.download.thinkbroadband.com/5MB.zip and observe the window.

**Expected result**
* The Open with the dropdown menu is autocompleted with `Use Window explorer` (that is what is happening on macOS 12 and Ubuntu 22)

**Actual result**
* Empty drop-down menu.

**Regression range**
* There are two bugs that changed this behavior:
1. Bug 1746052 removed the `Open with` dropdown and placed only a Browse button. 
2. Bug 1689816 added the `Open with` dropdown back but it’s empty.

I will set bug 1746052  as the initial regressor. Feel free to change it if you feel otherwise.

**Additional notes**
* Attached a screenshot.
Bug: Vulnerability in Firefox 'Save As' Dialog Allows Attackers to Steal Environment Variables
Status: VERIFIED
Priority: --
Resolution: FIXED
Created: 2023-02-20 11:19:59+00:00
Resolved: 2024-05-30 18:05:35+00:00

Normally, when a file is saved using the "Save As" dialog in the Firefox browser, the user is protected from different types of attacks by filtering out dangerous extensions or characters.

However, there is a remaining vulnerability where an attacker can place environment variables at the end of the file extension, which allows % signs to pass through without being filtered. An attacker can exploit this vulnerability to steal a victim's stored environment variable, such as various secret keys ( AWS, AZURE, Firebase, etc.),  or other tokens.

Steps to Reproduce:

This vulnerability works when a user has set the "Save As" dialog as the default download option (Settings → Files and Applications → Downloads → “Always ask you where to save files” is checked). Alternatively, an attacker could lure the victim into using the right-click download method, which always opens the "Save As" dialog for downloading a file.

1. Download and open the poc.html file in Firefox.
2. Download the file using one of the methods mentioned above on the poc.html page.
3. Upload the downloaded file to the poc.html page and observe that the secret is extracted (in this case, the username environment variable is used).

this vulnerability is similar to https://bugzilla.mozilla.org/show_bug.cgi?id=1765049 and https://bugs.chromium.org/p/chromium/issues/detail?id=1247389
Bug: Since 111 beta, main window freezes before fully loading UI.
Status: RESOLVED
Priority: --
Resolution: DUPLICATE
Created: 2023-02-20 17:01:19+00:00
Resolved: 2023-03-21 15:40:12+00:00

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/111.0

Steps to reproduce:

Upgraded to Firefox 111 Beta from previous Beta, on Windows 10 22H2, then ran it as usual with my default profile.


Actual results:

Main window opens full screen and shows outlines of tabs and toolbars but then completely freezes (screenshot attached). When clicking into the window, Windows states "Firefox is not responding" and the only option I have is to close it as it never recovers. The hang is reported in the Windows Application event log but does not appear to be caught by Firefox (doesn't show in about:crashes).

When I immediately try to run Firefox again, it will sometimes load normally, but sometimes take several tries to get it to open. Once it does open, it works fine.


Expected results:

Main window should open and previous session should restore, with all tabs.
Bug: When Firefox receives a "Response.ContentType = "text/calendar"" file it ignores the extension of the "Content-Disposition", "attachment;filename" header and downloads it as .ICS
Status: UNCONFIRMED
Priority: P5
Created: 2023-02-20 17:51:00+00:00
Resolved: 2024-09-11 03:48:03+00:00

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/110.0

Steps to reproduce:

I created an .asp to return a file like:

Response.ContentType = "text/calendar"
Response.AddHeader "Content-Disposition", "attachment;filename=Event.GND"


Actual results:

IT downloads it as "Event.ICS"!!!


Expected results:

It should have dowloaded it as "Event.GND"!!!

It works correctly on Chrome and Edge.

Best regards from a firefox lover.

;-)
Bug: inconsistent messaging around security of connections with certificate error overrides
Status: NEW
Priority: --
Created: 2023-02-20 21:42:24+00:00
Resolved: 2023-02-27 09:37:31+00:00

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/110.0

Steps to reproduce:

1. Went to Ubiquity Edge Router X that uses self-signed certificate


Actual results:

Firefox says connection is not secure, when opposite is correct. Probably due to accepted self-signed exception?


Expected results:

Connection is secure correctly stated even for self-signed accepted exceptions.
Bug: Private Browsing pseudo dark theme doesn't apply to some elements in about:privatebrowsing
Status: VERIFIED
Priority: P3
Resolution: FIXED
Created: 2023-02-20 23:08:11+00:00
Resolved: 2023-03-20 14:18:17+00:00

### STR
1. Open a private browsing window in a fresh profile (without dark mode enabled) so that a promo card is displayed in about:privatebrowsing, with a primary colored button (probably will say Pin to taskbar)

### Expected
The button should have dark gray text (#2B2A33) on a cyan background (#00DDFF), see [figma prototype](https://www.figma.com/file/FAZxkK9IRLlCqyhXBqId7e/Auto-Cookie-Banner-Consent-Desktop-%26-Mobile?node-id=2755%3A34246&t=B7x0gp5yQBJoVamb-1)

### Actual
The button has white text on a blue background — the primary button color for light mode.

Switching to dark mode (e.g. with `ui.systemUsesDarkTheme`) changes the button's color to what it should be. But that's not part of the private browsing implementation, it's just the prefers-color-scheme media query in the common styles.

This is the only element I noticed but I was thinking we should just do a general audit of these styles. Or maybe it would be better overall if we override the media query on about:privatebrowsing. This should be pretty easy to do, by [overriding this rule](https://searchfox.org/mozilla-central/rev/3067ba33c2202459aae52b7a0f7218a71fe5f7c3/browser/themes/shared/tabs.css#21-23) for about:privatebrowsing. [contentTheme.js](https://searchfox.org/mozilla-central/rev/3067ba33c2202459aae52b7a0f7218a71fe5f7c3/browser/base/content/contentTheme.js#43-64) (used by other system pages) uses an inline style on the browser element to do this, and I guess we might want to do that just for the sake of being thorough. An alternative would be to specify the styles we want manually, but that will require a lot more maintenance trying to keep up with changes to the common styles, when we could just inherit them by forcing the color scheme. Though I'm not sure if there's an easy place to slot this behavior in specifically for about:privatebrowsing, as it requires JS access to the browser element (the element in the chrome where the content viewer is inserted)
Bug: Bookmarks menu icons on macOS use bright icons if OS theme isn't dark but Fx theme is (incl. private browsing windows in default theme)
Status: ASSIGNED
Priority: P3
Created: 2023-02-20 23:29:32+00:00
Resolved: 2023-05-02 15:57:13+00:00

This means white icons on a light background, so the icons are hard to see. The icons, on macOS with its global menubar, should not depend on the Firefox theme, only on the OS theme.
Bug: UrlbarProviderWeather returns an unknown result type
Status: VERIFIED
Priority: P2
Resolution: FIXED
Created: 2023-02-21 01:56:20+00:00
Resolved: 2023-03-08 09:46:56+00:00

This is a follow-up for bug 1817202.
As commented in https://bugzilla.mozilla.org/show_bug.cgi?id=1817202#c2, as we had not supported UrlbarProviderWeather, the result type will be `unknown`.
To fix it, we will introduce `weather` result type.
Bug: Intermittent toolkit/components/normandy/test/browser/browser_actions_AddonRolloutAction.js | single tracking bug
Status: RESOLVED
Priority: P5
Resolution: INCOMPLETE
Created: 2023-02-21 07:06:44+00:00
Resolved: 2023-04-04 17:00:54+00:00

**Filed by:** chorotan [at] mozilla.com
**Parsed log:** https://treeherder.mozilla.org/logviewer?job_id=406342610&repo=autoland
**Full log:** https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/Vm_ApgVXS-GRs6FjGEAI5Q/runs/0/artifacts/public/logs/live_backing.log

---
```
task 2023-02-21T06:13:06.597Z] 06:13:06     INFO - TEST-PASS | toolkit/components/normandy/test/browser/browser_actions_AddonRolloutAction.js | The add-ons should be same before and after the test - {} deepEqual {} - 
[task 2023-02-21T06:13:06.598Z] 06:13:06     INFO - Console message: [JavaScript Error: "Timeout while waiting for extension child to shutdown: "normandy_fixture_a" (ID: normandydriver-a@example.com, moz-extension://f3596016-b0e8-4912-97fa-c8fd45285971/)" {file: "resource://gre/modules/Extension.jsm" line: 3404}]
[task 2023-02-21T06:13:06.598Z] 06:13:06     INFO - shutdown@resource://gre/modules/Extension.jsm:3404:10
[task 2023-02-21T06:13:06.598Z] 06:13:06     INFO - 
[task 2023-02-21T06:13:06.598Z] 06:13:06     INFO - Leaving test bound enroll_failed_upgrade_required
[task 2023-02-21T06:13:06.598Z] 06:13:06     INFO - Buffered messages finished
[task 2023-02-21T06:13:06.598Z] 06:13:06     INFO - TEST-UNEXPECTED-FAIL | toolkit/components/normandy/test/browser/browser_actions_AddonRolloutAction.js | This test exceeded the timeout threshold. It should be rewritten or split up. If that's not possible, use requestLongerTimeout(N), but only as a last resort. - 
[task 2023-02-21T06:13:06.598Z] 06:13:06     INFO - GECKO(7864) | MEMORY STAT | vsize 402460MB | residentFast 441MB | heapAllocated 154MB
[task 2023-02-21T06:13:06.598Z] 06:13:06     INFO - TEST-OK | toolkit/components/normandy/test/browser/browser_actions_AddonRolloutAction.js | took 56743ms
[task 2023-02-21T06:13:06.598Z] 06:13:06     INFO - checking window state
```