av9ash/GitBugs huggingface dataset:
Bug: Stub Installer Paveover update prompt is not displayed
Status: RESOLVED
Priority: P3
Resolution: INVALID
Created: 2020-02-20 13:33:32+00:00
Resolved: 2020-03-13 15:14:23+00:00

* Follow up from  Bug 1554141

**Affected versions**
* Firefox 73.0.1
* Firefox 74.0b5
* Firefox 75.0a1 (2020-02-20)

**Affected platforms**
* Windows 7x64
* Windwos 8.1x64
* Windows 10x64

**Steps to reproduce**
1. Install an older version of Firefox. 
2. Run Firefox and close it. 
3. Download and install Stub Installer build.

**Expected result**
* "The Firefox is already installed. Let's update it", prompt window is displayed.

**Actual result**
* Firefox is installed as a fresh install and "The Firefox is already installed. Let's update it", prompt window is not displayed.

**Regression range**
I will try to find a regression range asap if possible. 

**Additional notes**
* This issue is also reproducible if step 2 is not performed.
* Since the Update prompt window is not displayed, 'Restore default settings and remove old add-ons for optimal performance.' option is not available.
Bug: Payment Request dialog container styles broken
Status: RESOLVED
Priority: P1
Resolution: FIXED
Created: 2020-02-20 15:12:49+00:00
Resolved: 2020-07-15 02:08:06+00:00

Due to unrelated Firefox front-end changes and the fact we disabled tests while development of web payments was on hold, the PaymentRequest dialog position and size is now incorrect. We should run mozregression with the feature preffed on to see what broke it rather than layering new different CSS on top. The following is what I came up with for `toolkit/components/prompts/content/tabprompts.cs` when I didn't have access to mozregression:

```diff
 /* Tab-Modal Payment Request widget */
 .paymentDialogContainer:not([hidden]) {
   /* Center the .paymentDialogContainerFrame horizontally with flexbox. */
   display: flex;
   flex-direction: column;
   position: absolute;
+  z-index: 1000;
+  width: 100%;
 }
```
Bug: IsRunningAsASnap incorrectly detected when not running from a snap
Status: RESOLVED
Priority: --
Resolution: FIXED
Created: 2020-02-20 15:34:48+00:00
Resolved: 2020-03-05 04:19:57+00:00

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:73.0) Gecko/20100101 Firefox/73.0

Steps to reproduce:

On Ubuntu
- apt install firefox
- snap install emacs --classic
- launch emacs
- from emacs, launch firefox (the deb)



Actual results:

Firefox detects it is in a snap since the SNAP environment variable was exported for the context of emacs.


Expected results:


Firefox should have a stricter check. I have attached a proposal patch.
Bug: Get rid of `uses-unsafe-cpows`
Status: RESOLVED
Priority: P3
Resolution: FIXED
Created: 2020-02-20 16:25:31+00:00
Resolved: 2020-04-13 23:04:38+00:00

There are [7 tests that still use this](https://searchfox.org/mozilla-central/search?q=uses-unsafe-cpows&case=false&regexp=false&path=.ini). I think we can get rid of all of them:
browser/base/content/test/general/ :

- [browser_bug735471.js](https://searchfox.org/mozilla-central/source/browser/base/content/test/general/browser_bug735471.js) - This loads about:preferences and then accesses `content`, but that's in the parent process anyway. Also, this test looks kinda useless to me (we have a lot more actual tests for prefs in browser/components/preferences ) so we could just remove it altogether.
- [browser_clipboard.js](https://searchfox.org/mozilla-central/source/browser/base/content/test/general/browser_clipboard.js) - unclear what the CPOW usage here is, but I'm sure we could just rewrite it if there is any left...
- [browser_blockHPKP.js](https://searchfox.org/mozilla-central/source/browser/base/content/test/general/browser_blockHPKP.js) - fully disabled due to bug 1581884, which is assigned to Prathiksha but hasn't seen activity for 4 months. Unsure if there are really CPOWs left here. Given error page stuff is fission compatible now, and the test uses `SpecialPowers.spawn`, I would be surprised if that were the case?

browser/components/customizableui/test/:
- [browser_934951_zoom_in_toolbar.js](https://searchfox.org/mozilla-central/source/browser/components/customizableui/test/browser_934951_zoom_in_toolbar.js) - I rewrote this and removed CPOW usage in bug 962248

toolkit/components/reader/test/:
- [browser_readerMode_with_anchor.js](https://searchfox.org/mozilla-central/source/toolkit/components/reader/test/browser_readerMode_with_anchor.js) - Mike already removed the CPOW usage here but the annotation didn't get removed.

toolkit/content/tests/browser/:
- [browser_datetime_datepicker.js](https://searchfox.org/mozilla-central/source/toolkit/content/tests/browser/browser_datetime_datepicker.js) - I don't see any CPOW usage here, though I could well be missing something.
- [browser_saveImageURL.js](https://searchfox.org/mozilla-central/source/toolkit/content/tests/browser/browser_saveImageURL.js) - this has an explicit test for a deprecated way of invoking "save image" from the context menu (after flipping `dom.ipc.cpows.forbid-unsafe-from-browser`) that I think we should just remove (including removing support for the CPOW stuff in the context menu etc.)


Relating to that last point, Kris, do you know what (if anything) is stopping us from removing `dom.ipc.cpows.forbid-unsafe-from-browser` and just not allowing them at all?
Bug: Intermittent browser/extensions/doh-rollout/test/browser/browser_doorhangerUserReject.js | Test timed out - | Found a tab after previous test timed out: https://example.com/
Status: RESOLVED
Priority: P5
Resolution: INCOMPLETE
Created: 2020-02-20 17:34:41+00:00
Resolved: 2020-04-28 17:01:21+00:00

**Filed by:** rmaries [at] mozilla.com
**Parsed log:** https://treeherder.mozilla.org/logviewer.html#?job_id=289711598&repo=autoland
**Full log:** https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/R-8c_bXyQZiUndKOCmtheA/runs/0/artifacts/public/logs/live_backing.log

---

task 2020-02-20T16:59:39.883Z] 16:59:39     INFO - TEST-START | browser/extensions/doh-rollout/test/browser/browser_doorhangerUserReject.js
[task 2020-02-20T17:01:09.907Z] 17:01:09     INFO - TEST-INFO | started process screentopng
[task 2020-02-20T17:01:10.205Z] 17:01:10     INFO - TEST-INFO | screentopng: exit 0
[task 2020-02-20T17:01:10.206Z] 17:01:10     INFO - Buffered messages logged at 16:59:39
[task 2020-02-20T17:01:10.206Z] 17:01:10     INFO - Entering test bound setup
[task 2020-02-20T17:01:10.207Z] 17:01:10     INFO - Leaving test bound setup
[task 2020-02-20T17:01:10.207Z] 17:01:10     INFO - Entering test bound testDoorhangerUserReject
[task 2020-02-20T17:01:10.208Z] 17:01:10     INFO - Buffered messages logged at 16:59:40
[task 2020-02-20T17:01:10.208Z] 17:01:10     INFO - TEST-PASS | browser/extensions/doh-rollout/test/browser/browser_doorhangerUserReject.js | Breadcrumb saved. - 
[task 2020-02-20T17:01:10.209Z] 17:01:10     INFO - Buffered messages finished
[task 2020-02-20T17:01:10.209Z] 17:01:10     INFO - TEST-UNEXPECTED-FAIL | browser/extensions/doh-rollout/test/browser/browser_doorhangerUserReject.js | Test timed out - 
[task 2020-02-20T17:01:10.235Z] 17:01:10     INFO - GECKO(3141) | MEMORY STAT | vsize 20975145MB | residentFast 1031MB
[task 2020-02-20T17:01:10.235Z] 17:01:10     INFO - TEST-OK | browser/extensions/doh-rollout/test/browser/browser_doorhangerUserReject.js | took 90350ms
[task 2020-02-20T17:01:10.236Z] 17:01:10     INFO - Not taking screenshot here: see the one that was previously logged
[task 2020-02-20T17:01:10.236Z] 17:01:10     INFO - TEST-UNEXPECTED-FAIL | browser/extensions/doh-rollout/test/browser/browser_doorhangerUserReject.js | Found a tab after previous test timed out: https://example.com/ - 
[task 2020-02-20T17:01:10.331Z] 17:01:10     INFO - checking window state
Bug: Cannot create new bookmarks or folders from places.xhtml
Status: RESOLVED
Priority: --
Resolution: DUPLICATE
Created: 2020-02-20 19:16:34+00:00
Resolved: 2020-02-21 09:35:51+00:00

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:73.0) Gecko/20100101 Firefox/73.0

Steps to reproduce:

- Open `chrome://browser/content/places/places.xhtml` in a tab
- Try to create a new bookmark or folder

This is the only way to have the library open in a tab, as in other browsers, and it used to work as expected with `places.xul`.
Bug: Intermittent TV browser/components/sessionstore/test/browser_aboutSessionRestore.js | leaked 1 window(s) until shutdown [url = chrome://browser/content/browser.xhtml]
Status: RESOLVED
Priority: P5
Resolution: INCOMPLETE
Created: 2020-02-20 21:45:42+00:00
Resolved: 2020-03-17 17:04:34+00:00

**Filed by:** ncsoregi [at] mozilla.com
**Parsed log:** https://treeherder.mozilla.org/logviewer.html#?job_id=289738564&repo=autoland
**Full log:** https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/PQwBjFFfS9e_4Aqzcn7Hug/runs/0/artifacts/public/logs/live_backing.log
**Reftest URL:** https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/PQwBjFFfS9e_4Aqzcn7Hug/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1

---

>[task 2020-02-20T19:34:54.376Z] 19:34:54     INFO - TEST-INFO | Confirming we saw 22 DOCSHELL created and 22 destroyed log strings.
[task 2020-02-20T19:34:54.377Z] 19:34:54     INFO - TEST-INFO | Confirming we saw 61 DOMWINDOW created and 61 destroyed log strings.
[task 2020-02-20T19:34:54.377Z] 19:34:54    ERROR - TEST-UNEXPECTED-FAIL | browser/components/sessionstore/test/browser_aboutSessionRestore.js | leaked 1 window(s) until shutdown [url = chrome://browser/content/browser.xhtml]
[task 2020-02-20T19:34:54.378Z] 19:34:54    ERROR - TEST-UNEXPECTED-FAIL | browser/components/sessionstore/test/browser_aboutSessionRestore.js | leaked 1 window(s) until shutdown [url = about:blank]
[task 2020-02-20T19:34:54.378Z] 19:34:54     INFO - TEST-INFO | browser/components/sessionstore/test/browser_aboutSessionRestore.js | windows(s) leaked: [pid = 1648] [serial = 16], [pid = 1648] [serial = 17]
[task 2020-02-20T19:34:54.379Z] 19:34:54     INFO - TEST-INFO | browser/components/sessionstore/test/browser_aboutSessionRestore.js | This test created 1 hidden window(s)
Bug: The add-on installation doorhanger isn't part of the tab order
Status: RESOLVED
Priority: --
Resolution: WORKSFORME
Created: 2020-02-20 22:03:24+00:00
Resolved: 2020-03-02 19:21:50+00:00

STR:
1. Assume you're a user who cannot use a mouse, and uses tab navigation instead.
2. Go to https://profiler.firefox.com/.
3. Use the tab button to focus the Install add-on button.  Press Enter.
4. The add-on installation doorhanger opens.

Expected result: be able to reach the doorhanger after a few times of pressing tab and be able to press the buttons there.

Actual result: tab navigation skips over the doorhanger dialog.
Bug: Intermittent browser/components/customizableui/test/browser_PanelMultiView_keyboard.js | application terminated with exit code -6
Status: RESOLVED
Priority: P5
Resolution: INCOMPLETE
Created: 2020-02-21 04:37:58+00:00
Resolved: 2020-05-26 17:04:39+00:00

**Filed by:** ncsoregi [at] mozilla.com
**Parsed log:** https://treeherder.mozilla.org/logviewer.html#?job_id=289818821&repo=autoland
**Full log:** https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/VwV6CWkoRdy7Mav0VE_aEQ/runs/0/artifacts/public/logs/live_backing.log

---

>[task 2020-02-21T04:13:34.433Z] 04:13:34     INFO - TEST-PASS | browser/components/customizableui/test/browser_PanelMultiView_keyboard.js | First context menu item active after ArrowDown - 
[task 2020-02-21T04:13:34.433Z] 04:13:34     INFO - TEST-PASS | browser/components/customizableui/test/browser_PanelMultiView_keyboard.js | gMainButton1 still focused after ArrowDown - 
[task 2020-02-21T04:13:34.433Z] 04:13:34     INFO - Leaving test bound testArowsContext
[task 2020-02-21T04:13:34.433Z] 04:13:34     INFO - Buffered messages finished
[task 2020-02-21T04:13:34.433Z] 04:13:34    ERROR - TEST-UNEXPECTED-FAIL | browser/components/customizableui/test/browser_PanelMultiView_keyboard.js | application terminated with exit code -6
[task 2020-02-21T04:13:34.433Z] 04:13:34     INFO - runtests.py | Application ran for: 0:01:19.387822
[task 2020-02-21T04:13:34.433Z] 04:13:34     INFO - zombiecheck | Reading PID log: /tmp/tmpkSDrBSpidlog
[task 2020-02-21T04:13:34.433Z] 04:13:34     INFO - ==> process 2920 launched child process 2935
[task 2020-02-21T04:13:34.433Z] 04:13:34     INFO - ==> process 2920 launched child process 2970
[task 2020-02-21T04:13:34.433Z] 04:13:34     INFO - ==> process 2920 launched child process 2984
Bug: Focused megabar highlight overlaps the bookmarks toolbar and the tab bar
Status: RESOLVED
Priority: --
Resolution: WONTFIX
Created: 2020-02-21 07:00:42+00:00
Resolved: 2020-04-24 17:19:15+00:00

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:74.0) Gecko/20100101 Firefox/74.0

Steps to reproduce:

Firefox 74.0b6 (64bit) on Mac 10.14.6 (with dark mode)

1. open firefox 
2. press cmd+n for a new tab



Actual results:

Observe that the active address bar is overflowing over bookmark bar and tab list. 

At least in osx dark mode the blueish outline for the active address bar is slightly overflowing some of the bookmarks and causing a visual irk. When zooming in the attached screenshot, you can see that the blueish outline is overflowing for maybe a pixel or two.


Expected results:

The active address bar (surrounded by the blueish outline) should not overflow to bookmark bar or tab list when it's active. Personally I don't "mind" the tab bar overflow, but the overflow to bookmark bar causes a visual distraction.
Bug: Trying to bookmark https://danluu.com/discontinuities/ by drag'n'dropping the lock icon next to URL doesn't work
Status: RESOLVED
Priority: --
Resolution: DUPLICATE
Created: 2020-02-21 09:42:01+00:00
Resolved: 2020-02-21 10:38:44+00:00

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:73.0) Gecko/20100101 Firefox/73.0

Steps to reproduce:

0. Run Firefox desktop (I use Windows). Make sure to have Bookmarks Toolbar enabled.
1. Load https://danluu.com/discontinuities/
2. Try to drag the "lock" icon on the left hand side of the URL and drop it onto the bookmarks toolbar, to create a new bookmark


Actual results:

Nothing -- the drag is not initiated.


Expected results:

I should have been able to drag the lock icon onto the bookmark bar.

This is the only URL I reproduced this issue on. No idea what's so special about this URL. On the root of the domain, this doesn't happen.

Repro in 73 stable and nightly.
Bug: When opening a new tab, the TAB key in the address bar doesn't autocomplete suggestions
Status: RESOLVED
Priority: --
Resolution: DUPLICATE
Created: 2020-02-21 09:47:24+00:00
Resolved: 2020-02-24 16:49:03+00:00

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:75.0) Gecko/20100101 Firefox/75.0

Steps to reproduce:

Nightly 75.0a1 (2020-02-19), Windows 10 64 bit.

With other tabs opened.

1 - Opened a new browser tab
2 - Start typing an address you already have in you history so that a suggestions list is given
3 - Press the TAB key on your keyboard to autocomplete the address with the first suggestion


Actual results:

The address bar looses focus (and the focus is given, for example, to the search bar).

This doesn't happen on Firefox 73.0.1, Windows 10 64 bits.


Expected results:

The address bar should have been filled with the first suggestion.

This is what happens on Firefox 73.0.1, Windows 10 64 bits.
Bug: Intermittent TEST-UNEXPECTED-TIMEOUT | browser/extensions/doh-rollout/test/unit/test_localStorageMigration.js | Test timed out
Status: RESOLVED
Priority: P5
Resolution: FIXED
Created: 2020-02-21 12:05:22+00:00
Resolved: 2020-07-12 22:24:57+00:00

**Filed by:** cbrindusan [at] mozilla.com
**Parsed log:** https://treeherder.mozilla.org/logviewer.html#?job_id=289867815&repo=mozilla-central
**Full log:** https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/XeZtyF-GSduBJlNrRiGtwg/runs/0/artifacts/public/logs/live_backing.log

---

[task 2020-02-21T11:22:52.765Z] 11:22:52     INFO -  TEST-START | browser/extensions/doh-rollout/test/unit/test_localStorageMigration.js
[task 2020-02-21T11:27:52.769Z] 11:27:52  WARNING -  TEST-UNEXPECTED-TIMEOUT | browser/extensions/doh-rollout/test/unit/test_localStorageMigration.js | Test timed out
Bug: Search suggestions dropdown from about:newtab search box  is not re-adjusted at browser resize
Status: NEW
Priority: P5
Created: 2020-02-21 13:42:12+00:00
Resolved: 2025-01-09 09:06:24+00:00

**[Affected versions]:**
- Firefox Release 73.0.1 Build ID 20200217142647
- Firefox Beta 74.0b6 Build ID 20200221001238
- Firefox Nightly 75.0a1 Build ID 20200221095110

**[Affected Platforms]:**
- Windows 10
- Mac 10.14
- Linux Ubuntu 16.04

**[Steps to reproduce]:**
1. Open about:newtab page.
2. Resize the window to half size.
3. Type something in the in-content search field.
4. Observe the search suggestions.

**[Expected result]:**
- Search suggestions dropdown is adjusted according to the browser dimensions.

**[Actual result]:**
- Search suggestions dropdown is not re-adjusted after browser resize.

**[Notes]:**
- Issue is not reproducing for Awesome bar search suggestions.
Bug: Full installer header fonts look bad on some OS locales
Status: NEW
Priority: P3
Created: 2020-02-21 15:26:21+00:00
Resolved: 2022-10-11 23:59:09+00:00

When Windows is configured with certain locales (known to include Japanese, but likely others), the header text on all en-US (or presumably any Latin alphabet based) full installer pages uses a default system font that really looks quite rough. See attached screenshot, taken from bug 1515534 comment 14.

It might be tricky to detect this case, because presumably, for builds in the same locale as the system, the chosen font would be the correct one. But this looks so bad that it's worth at least investigating whether we can do anything.
Bug: Investigate ways to improve full installer image scaling
Status: NEW
Priority: P3
Created: 2020-02-21 16:07:27+00:00
Resolved: 2022-10-11 23:59:10+00:00

Bug 1515534 did make some improvement in how our full installer images (the welcome/finish page banner and the wizard page headers) scale up in above-100% DPI configurations, but it still doesn't look very good, especially at fractional scaling factors. We should investigate more ways to improve this, perhaps by using higher resolution assets and scaling them down, or possibly by finding better scaling methods and/or image formats.
Bug: Recent Links in Firefox taskbar menu no longer execute ever since last update. Running version 73.0.1 64bit
Status: RESOLVED
Priority: --
Resolution: INCOMPLETE
Created: 2020-02-21 16:16:09+00:00
Resolved: 2020-03-11 07:57:54+00:00

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:73.0) Gecko/20100101 Firefox/73.0

Steps to reproduce:

Firefox is pinned to my taskbar in windows 10. I used to rely on that to execute many repetitive tasks. When I right click on the Firefox icon the taskbar of recent sessions appears but the links do not execute. I have unpinned Firefox from the Windows Toolbar, rebooted Windows, changed the default browser to Chrome then back to Firefox, repinned it to the toolbar. Nothing so far has fixed the problem.
Bug: Language changed to Swedish in hamburger menu
Status: RESOLVED
Priority: --
Resolution: INVALID
Created: 2020-02-21 17:43:28+00:00
Resolved: 2020-02-22 18:20:41+00:00

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:73.0) Gecko/20100101 Firefox/73.0

Steps to reproduce:

Updated firefox to 73.0.1


Actual results:

The hamburger menu changed to Swedish. I checked the language settings and they were still English. I think the hamburger menu is somehow taking either location data into account or the keyboard layout into account instead of following what the language settings say. In earlier versions of firefox, I had my hamburger menu in English


Expected results:

Language in hamburger menu should not have changed
Bug: TLS override page should not be displayed if the tls min version is locked to 1.2
Status: VERIFIED
Priority: P1
Resolution: FIXED
Created: 2020-02-21 21:19:27+00:00
Resolved: 2021-12-13 01:28:52+00:00

Enterprise policy allows the min version of TLS to be locked to 1.2 (or 1.1).

If it is locked to a particular version, we should not be showing the deprecation page to allow someone to go below that version.
Bug: Possible Breakage in FxA App (Hamburger) Menu Telemetry in Version 73
Status: RESOLVED
Priority: P1
Resolution: FIXED
Created: 2020-02-21 22:12:19+00:00
Resolved: 2020-03-24 15:56:51+00:00

[This chart](https://sql.telemetry.mozilla.org/queries/68484/source#172975) shows that the volume of events related to the FxA hamburger menu menu seem to be in a freefall from around the time 73 went to release. 

A similar thing has NOT happened to the toolbar menu telemetry.

edit, talking about [these](https://searchfox.org/mozilla-central/source/toolkit/components/telemetry/Events.yaml#711) events, they have not expired.
Bug: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIInterfaceRequestor.getInterface]
Status: RESOLVED
Priority: --
Resolution: INCOMPLETE
Created: 2020-02-21 22:27:53+00:00
Resolved: 2020-03-11 07:57:44+00:00

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:73.0) Gecko/20100101 Firefox/73.0

Steps to reproduce:

Received a message on Reddit.com
Push Notifications are ENABLED
No notification is shown


Actual results:

Reddit Notifications not working


Expected results:

Receive a push notification from Reddit.com when a new message is received
Bug: events cannot be saved in Google Calendar
Status: RESOLVED
Priority: --
Resolution: WORKSFORME
Created: 2020-02-21 22:49:36+00:00
Resolved: 2020-02-27 08:02:46+00:00

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:73.0) Gecko/20100101 Firefox/73.0

Steps to reproduce:

Using Firefox 73.0.1

In google calendar, attempted to create event. Could move event around day, and get popup with details. On filling in popup, could not save popup. Could not double-click event to go to detailed event pane.


Actual results:

Could not save calendar event, despite multiple attempts. Had to switch to Google Chrome to save calendar event, where I could duble-click and enter event details as you would expect.

Guess I'm forced to use Chrome from now on.


Expected results:

Should have been able to save calendar event.
Bug: Some top sites have incorrect favicons
Status: VERIFIED
Priority: P3
Resolution: FIXED
Created: 2020-02-22 02:16:43+00:00
Resolved: 2020-04-08 07:08:49+00:00

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:75.0) Gecko/20100101 Firefox/75.0

Steps to reproduce:

the top sites list version of the megabar (sorry for the wording, I don't know how else to describe it) shows the incorrect favicon at least in some cases, such as twitter. See attached screenshot (I put red arrow). But when you actually type in the URL bar, the twitter entry has the correct favicon. (screenshot below)
Bug: Disabling top sites on new tab causes top sites not to be shown in the urlbar after restarting Firefox
Status: RESOLVED
Priority: P1
Resolution: FIXED
Created: 2020-02-22 05:48:54+00:00
Resolved: 2020-07-22 22:16:37+00:00

[Tracking Requested - why for this release]:

If you hide top sites on new tab (set `browser.newtabpage.activity-stream.feeds.topsites` to false) and restart Firefox, focusing the urlbar doesn't show the top sites anymore. That's because `this.activityStream.store.getState().TopSites.rows` is an empty array here: https://searchfox.org/mozilla-central/rev/c1e3d3edd4a9b784971555dc74a5de23d768b2e1/browser/modules/AboutNewTab.jsm#115 Which makes total sense because top sites are disabled.

Ed, how might we fix this? We need to show the top sites in the urlbar view even when they're hidden on new tab. Setting the pref to true, calling `AboutNewTab.getTopSites`, and then resetting it to false actually works, but it's hacky, and it also causes the top sites to flicker on and off if the current tab is new tab.

Requesting tracking because we want to enable top sites in the urlbar on release on 74.