av9ash/GitBugs huggingface dataset:
Bug: Download panel is not auto-opened when downloads are initiated by drag and drop
Status: NEW
Priority: P3
Created: 2022-07-29 10:41:32+00:00
Resolved: 2022-10-10 14:43:00+00:00

**Found in**
- 104.0b3

**Affected versions**
- Firefox 102.0
- Firefox 104.0b3
- Firefox 105.0a1

**Affected platforms**
- Windows 7 & 8.1
- Ubuntu 22.04
- macOS 11.6.8

**Steps to reproduce**
1. Launch Firefox
2. Drag and drop a link, for [example](https://ftp.mozilla.org/pub/firefox/releases/0.10.1/Firefox%201.0PR.zip) from another browser to Firefox

**Expected result**
- The downloads panel auto-opens when a download is initiated

**Actual result**
- The downloads panel auto-opens only once first time, then doesn't open anymore

**Regression range**
- WIll see for a regression if there is one, seems that 102.0 is affected as well.

**Additional notes**
- The issue can be seen in the attachment.
- Windows 10 is not affected by the issue.
- "Show panel when download begins" setting is selected by default.
Bug: Creating a Hebrew annotation with the new PDF editing feature creates broken characters
Status: RESOLVED
Priority: --
Resolution: DUPLICATE
Created: 2022-07-29 15:23:02+00:00
Resolved: 2022-11-23 12:44:26+00:00

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:105.0) Gecko/20100101 Firefox/105.0

Steps to reproduce:

1. Open a PDF file
2. Add a new annotation 
3. Write anything in Hebrew (ex: "שלום")


Actual results:

After you save the document and open it, the characters break


Expected results:

After you save the document and open it, the should not characters break
Bug: Intermittent browser/components/sessionstore/test/browser_pinned_tabs.js waiting for vsync to be disabled (robot.ico animation still running)
Status: RESOLVED
Priority: --
Resolution: FIXED
Created: 2022-07-29 15:27:09+00:00
Resolved: 2022-08-16 17:56:16+00:00

While working on bug 1742842, I noticed that sometimes browser/components/sessionstore/test/browser_pinned_tabs.js keeps vsync enabled at the end of the test. I managed to reproduce locally and got a profile: https://share.firefox.dev/3vNdLYP
This shows that the test_selected_pinned_tab_dataloss task kept the robot.ico image animation running. I don't know how that's possible as all tabs are closed at the end of the task: https://searchfox.org/mozilla-central/rev/4a15041348e08fb0d6f5726015c32861e663fbfe/browser/components/sessionstore/test/browser_pinned_tabs.js#108,122,160

Profile where the test correctly cleaned-up: https://share.firefox.dev/3oFkNLe
Bug: Intermittent TV browser/components/places/tests/browser/browser_click_bookmarks_on_toolbar.js | Test timed out -
Status: RESOLVED
Priority: P5
Resolution: INCOMPLETE
Created: 2022-07-29 16:50:48+00:00
Resolved: 2022-08-30 17:04:23+00:00

**Filed by:** abutkovits [at] mozilla.com
**Parsed log:** https://treeherder.mozilla.org/logviewer?job_id=385821973&repo=autoland
**Full log:** https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/Kj8v_YyQQaOPvYDEEvU8XQ/runs/0/artifacts/public/logs/live_backing.log
**Reftest URL:** https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/Kj8v_YyQQaOPvYDEEvU8XQ/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1

---
```
[task 2022-07-29T16:42:40.371Z] 16:42:40     INFO - TEST-START | browser/components/places/tests/browser/browser_click_bookmarks_on_toolbar.js
[task 2022-07-29T16:43:25.381Z] 16:43:25     INFO - TEST-INFO | started process screenshot
[task 2022-07-29T16:43:25.471Z] 16:43:25     INFO - TEST-INFO | screenshot: exit 0
[task 2022-07-29T16:43:25.478Z] 16:43:25     INFO - Buffered messages logged at 16:42:40
[task 2022-07-29T16:43:25.479Z] 16:43:25     INFO - Entering setup bound 
[task 2022-07-29T16:43:25.479Z] 16:43:25     INFO - Global property added while loading chrome://browser/content/places/browserPlacesViews.js: PlacesViewBase
[task 2022-07-29T16:43:25.479Z] 16:43:25     INFO - Waiting for bookmarks
[task 2022-07-29T16:43:25.480Z] 16:43:25     INFO - Buffered messages finished
[task 2022-07-29T16:43:25.480Z] 16:43:25     INFO - TEST-UNEXPECTED-FAIL | browser/components/places/tests/browser/browser_click_bookmarks_on_toolbar.js | Test timed out - 
[task 2022-07-29T16:43:25.482Z] 16:43:25     INFO - GECKO(3784) | MEMORY STAT | vsize 2104112MB | vsizeMaxContiguous 65684090MB | residentFast 212MB | heapAllocated 78MB
[task 2022-07-29T16:43:25.482Z] 16:43:25     INFO - TEST-OK | browser/components/places/tests/browser/browser_click_bookmarks_on_toolbar.js | took 45032ms
[task 2022-07-29T16:43:25.483Z] 16:43:25     INFO - checking window state
[task 2022-07-29T16:43:25.484Z] 16:43:25     INFO - GECKO(3784) | Completed ShutdownLeaks collections in process 7424
[task 2022-07-29T16:43:25.484Z] 16:43:25     INFO - TEST-START | Shutdown
```
Bug: Quick suggest didn't sync/load suggestions from Remote Settings
Status: RESOLVED
Priority: P1
Resolution: DUPLICATE
Created: 2022-07-29 17:52:06+00:00
Resolved: 2022-08-11 16:30:23+00:00

As Fx 103 rolls out, we've observed a significant drop in impressions & clicks of Firefox Suggest. The preliminary investigation shows that Firefox Suggest couldn't load suggestions from Remote Settings, looks like the RS client `sync` event was never triggered  ([source](https://searchfox.org/mozilla-central/source/browser/components/urlbar/UrlbarQuickSuggest.sys.mjs#417)), though it worked fine in Fx 102 and prior.

:leplatrem, can you help us troubleshoot this, please?
Bug: Intermittent toolkit/components/nimbus/test/browser/browser_experimentstore_load.js | single tracking bug
Status: NEW
Priority: P5
Created: 2022-07-29 18:26:10+00:00
Resolved: 2025-03-03 06:45:36+00:00

**Filed by:** ctuns [at] mozilla.com
**Parsed log:** https://treeherder.mozilla.org/logviewer?job_id=385820563&repo=autoland
**Full log:** https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/MG5yGFWWR2KY2kX0TtYF6Q/runs/0/artifacts/public/logs/live_backing.log

---
```
[task 2022-07-29T17:07:00.918Z] 17:07:00     INFO - TEST-PASS | toolkit/components/nimbus/test/browser/browser_experimentstore_load.js | Should have the same path as previousSession. - "/var/folders/xm/n310zld51c7560_kdxcfv4wr000014/T/tmpz06b4jrb.mozrunner/ExperimentStoreData.json" == "/var/folders/xm/n310zld51c7560_kdxcfv4wr000014/T/tmpz06b4jrb.mozrunner/ExperimentStoreData.json" - 
[task 2022-07-29T17:07:00.918Z] 17:07:00     INFO - Buffered messages finished
[task 2022-07-29T17:07:00.919Z] 17:07:00     INFO - TEST-UNEXPECTED-FAIL | toolkit/components/nimbus/test/browser/browser_experimentstore_load.js | Uncaught exception in test - Stub was called - timed out after 50 tries.
[task 2022-07-29T17:07:00.919Z] 17:07:00     INFO - Leaving test bound test_load_from_disk_event
[task 2022-07-29T17:07:00.920Z] 17:07:00     INFO - GECKO(5807) | MEMORY STAT | vsize 7861MB | residentFast 341MB | heapAllocated 133MB
[task 2022-07-29T17:07:00.920Z] 17:07:00     INFO - TEST-OK | toolkit/components/nimbus/test/browser/browser_experimentstore_load.js | took 8854ms
[task 2022-07-29T17:07:00.921Z] 17:07:00     INFO - GECKO(5807) | [Child 5809: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 10824e400 == 1 [pid = 5809] [id = 2]
[task 2022-07-29T17:07:00.921Z] 17:07:00     INFO - GECKO(5807) | [Child 5809: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 5 (10719bf10) [pid = 5809] [serial = 7] [outer = 0]
[task 2022-07-29T17:07:00.922Z] 17:07:00     INFO - GECKO(5807) | [Child 5809: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 6 (10824e800) [pid = 5809] [serial = 8] [outer = 10719bf10]
[task 2022-07-29T17:07:00.922Z] 17:07:00     INFO - GECKO(5807) | [Child 5811, Main Thread] WARNING: '!CanHandleWith(aPresContext)', file /builds/worker/checkouts/gecko/dom/events/IMEStateManager.cpp:498
[task 2022-07-29T17:07:00.922Z] 17:07:00     INFO - checking window state
[task 2022-07-29T17:07:00.923Z] 17:07:00     INFO - TEST-START | toolkit/components/nimbus/test/browser/browser_experimentstore_load_single_feature.js
```
Bug: Firefox is unusable on Ventura Public Beta 2
Status: RESOLVED
Priority: --
Resolution: WORKSFORME
Created: 2022-07-29 18:59:39+00:00
Resolved: 2022-10-31 17:30:32+00:00

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/16.0 Safari/605.1.15

Steps to reproduce:

Updated Firefox to version 103 and Ventura to Public Beta 2.
Restarted my computer.
Opened Firefox.

This happens on the Nightly and Beta builds as well. Launching in Rosetta 2 did not fix the issue.


Actual results:

Firefox became unresponsive. 
- Nothing loads in a tab
- Creating a new tab works, but I cannot switch to the tab
- I can type in the address bar, but nothing happens


Expected results:

Firefox works normally
Bug: Can't add a new search engine from search bar when only one search engine exists
Status: RESOLVED
Priority: --
Resolution: FIXED
Created: 2022-07-29 21:40:22+00:00
Resolved: 2022-08-24 01:44:33+00:00

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:105.0) Gecko/20100101 Firefox/105.0

Steps to reproduce:

1. Add the search bar in the toolbar
2. Remove all the search engines in about:preferences#search > Search shortcuts
3. Visit a website that you can add a search engine, eg. https://metager.org
4. Try to add the search engine from the toolbar


Actual results:

The icon to add the search engine doesn't show up.


Expected results:

The icon should show up, just like it would when you have more than one search engine in about:preferences#search > Search shortcuts.
Bug: Pocket newtab issue if recent saves is paired with save to Pocket card
Status: RESOLVED
Priority: --
Resolution: FIXED
Created: 2022-07-29 22:34:15+00:00
Resolved: 2022-08-05 09:32:10+00:00

If you pair these two prefs together, you now see a save to pocket button on cards that are recent saves.

It's a bit weird to see a button to save something you have already saved, and super easy for us to move this button for recent save cards.
Bug: Firefox does not present extension HTML identically to how the main observer does.
Status: RESOLVED
Priority: --
Resolution: INVALID
Created: 2022-07-29 23:53:13+00:00
Resolved: 2022-07-29 23:59:21+00:00

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Firefox/102.0

Steps to reproduce:

I recently committed "https://github.com/sarthakjain95/EnableSelect/pull/4". This removed the custom stylization of the HTML-page that was presented when the relevant extension (http://addons.mozilla.org/firefox/addon/enable-select) was invoked. I subsequently configured "browser.display.document_color_use" (of about:config) to be "2".


Actual results:

Because it is consequently dependent upon the browser currently and the browser appears to erroneously treat this text differently to all else, Firefox does not apply the colouration that my theme mandates.


Expected results:

The text was correctly presented when "browser.display.document_color_use" (of about:config) is configued to be "2" previously.
Bug: Firefox iOS's Firefox Accounts `lastAccessDate` is not accurate
Status: RESOLVED
Priority: --
Resolution: FIXED
Created: 2022-07-30 01:00:32+00:00
Resolved: 2023-05-11 16:38:30+00:00

With https://bugzilla.mozilla.org/show_bug.cgi?id=1772415 landed, we now filter the sendtab list to only included device that have been accessed in the last 21 days. However looks like some devices (internal report of an iOS device) are not shown in that list even though they have been accessed recently.

We should also double-check and see which devices are impacted by this if not all. There is a good chance the fix here is server-side.
Bug: There should be a right click menu option for pasting as plain text
Status: VERIFIED
Priority: --
Resolution: DUPLICATE
Created: 2022-07-30 08:50:14+00:00
Resolved: 2022-08-05 16:58:02+00:00

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:103.0) Gecko/20100101 Firefox/103.0

Steps to reproduce:

Highlighted some text
Right clicked on my selection
Clicked on Copy
Left clicked in the compose window in Gmail
Right clicked within the compose window in Gmail
Clicked on Paste
(There should be an option underneath Paste that says Paste as plain text)


Actual results:

Pasted the text with formatting


Expected results:

Pasted the text in plain text when I click on the Paste as plain text right click menu option
Bug: about:preferences headings show text cursor
Status: NEW
Priority: P5
Created: 2022-07-30 11:39:25+00:00
Resolved: 2022-08-01 20:40:05+00:00

This is just a very minor, subtle thing I stumbled on. Most of the text on about:preferences has `cursor: default` [because of this](https://searchfox.org/mozilla-central/rev/39fbb3f218776be3392d056f86cfbf54614767d6/toolkit/themes/shared/global-shared.css#119-124). But some of the headings aren't wrapped in either `description` or `label`, so when mousing over them, you get a text cursor.

For consistency, I think I'd just add `html|h1, html|h2, html|h3 {cursor:default}` to preferences.css. But I'm not sure what to do with the xul headings and the divs with inner text in the "More from Mozilla" section. All of this text is selectable, but `cursor: default` might tend to give users the impression that they can't select text. So users who would otherwise want to copy larger headings or paragraphs in the preferences UI to search for them might be discouraged by the cursor. So maybe those should just be omitted from the rule.

Alternatively, that might be a reasonable justification for overriding the `cursor: default` rule from global-shared.css for at least some elements. At least, we should take a look at each component and see if it makes sense for it to have a text cursor or not. Maybe it's fine for all of them to have a default cursor, but if not, I think we'll need some more precisely tailored rules.
Bug: paramountplus.com page keeps refreshing, after sometime logged in.
Status: RESOLVED
Priority: --
Resolution: WORKSFORME
Created: 2022-07-30 14:48:36+00:00
Resolved: 2023-04-14 16:41:29+00:00

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:105.0) Gecko/20100101 Firefox/105.0

Steps to reproduce:

- Logged on to an account at paramountplus.com
- Wait a few days and/or click on the search button before the page finished loading.


Actual results:

Something triggers the page to keep refreshing itself for no apparent reason.


Expected results:

The website should load adequately and stops and it's done
Bug: paramountplus.com page keeps refreshing, after sometime logged in.
Status: RESOLVED
Priority: --
Resolution: DUPLICATE
Created: 2022-07-30 14:51:04+00:00
Resolved: 2022-07-30 14:56:36+00:00

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:105.0) Gecko/20100101 Firefox/105.0

Steps to reproduce:

- Logged on to an account at paramountplus.com
- Wait a few days and/or click on the search button before the page finished loading.


Actual results:

Something triggers the page to keep refreshing itself for no apparent reason.


Expected results:

The website should load adequately and stops and it's done
Bug: Developer edition will not download files
Status: RESOLVED
Priority: --
Resolution: WORKSFORME
Created: 2022-07-30 14:57:04+00:00
Resolved: 2022-08-10 12:27:12+00:00

Developer 104.0b3 will not download any files. I click download. I have selected FF to ask me where to put them, and that pop-up never appears. Nothing is there when I hit command J.
Bug: I must always force quit firefox.
Status: RESOLVED
Priority: --
Resolution: INCOMPLETE
Created: 2022-07-30 19:15:50+00:00
Resolved: 2022-08-31 09:01:38+00:00

Steps to reproduce:

I must always force quit firefox. If I don't it eventually freezes my computer to a black screen. Even if only gone for an hour, it slows it down to the spinning ball until I can force quit it. this has been happening for years with my mac thru every version. Even when I want to restart or shutdown my computer I have to force quit firefox first.


Actual results:

I must always force quit firefox. 


Expected results:

should terminate on its own.
Bug: Clicking, switching tabs, and clicking again registers as bloth a single-click and a double-click.
Status: NEW
Priority: --
Created: 2022-07-31 09:58:23+00:00
Resolved: 2022-08-31 13:51:24+00:00

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:103.0) Gecko/20100101 Firefox/103.0

Steps to reproduce:

This is evident when using YouTube.

Open a YouTube video, and open another tab. In the other tab click somewhere around where the video would be in the YouTube tab, switch tabs using the keyboard, and click on the video once. This has to be done quickly, in the timespan that a normal double click would take.


Actual results:

A single click is registered in both tabs, but an additional double-click is registered in the second one, even though only one click occurred per tab.

In the case of YouTube, this is evidenced by the video pausing/resuming, and then going to fullscreen mode, as if it had been clicked, and then double-clicked.


Expected results:

Only one click should register in both tabs.
Bug: A 'recommended by Pocket' entry in the about:newtab had animated image
Status: RESOLVED
Priority: --
Resolution: WONTFIX
Created: 2022-07-31 12:06:28+00:00
Resolved: 2022-08-15 14:03:48+00:00

Having an animated image in the new tab page is visually rather annoying. When I saw Pocket recommendation animating, I just had to disable the whole feature.

Could we disable animations on the recommendations?
Bug: Tabs moved to a new window may not be duplicated
Status: RESOLVED
Priority: --
Resolution: WORKSFORME
Created: 2022-07-31 13:32:21+00:00
Resolved: 2024-06-03 18:35:55+00:00

Tabs that have been moved from one window to another often cannot be Duplicated. A workaround is to copy the URL in to a new tab - this tab may be freely duplicated.
"Open Link in New Window" appears not to be affected.

STR:
0. Create a new profile.
1. Open Firefox. Two tabs open on first run, but if not, open two different pages.
2. From the second tab's Context Menu select "Move Tab > Move to a New Window".
3. In the new window, from the moved tab's Context Menu select "Duplicate Tab"

Expected Results:
The tab should be duplicated, loading a new copy of the same URL.

Actual Results:
A New Tab is opened.

mozregression narrowed to here, although I found reproduction gets more sporadic further back. I couldn't reproduce it at all in 102. This range includes two commits for bug1739450 :

INFO: Last good revision: cda3070eb374a8d2ae68ac381e1ff706ba93abda
INFO: First bad revision: 7f523f9cd22dd9dffb5db8a7de2631fd5c759e02
INFO: Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=cda3070eb374a8d2ae68ac381e1ff706ba93abda&tochange=7f523f9cd22dd9dffb5db8a7de2631fd5c759e02
Bug: Downloads are automatically being downloaded into default location even though check for "always ask" is selected
Status: RESOLVED
Priority: --
Resolution: WONTFIX
Created: 2022-07-31 14:25:46+00:00
Resolved: 2022-08-04 09:49:14+00:00

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:103.0) Gecko/20100101 Firefox/103.0

Steps to reproduce:

When i click on links to download a file, where the webpage is designed to open the pdf download file in a new tab, it is being opened in the new tab, but then automatically downloaded to the default folder, even though I have selected the "always ask location" option.  This has only happened since the newest update.  Before then, the new tab with open with the pdf file, but it would not download until I clicked on the download icon -- and that's what should hppen.


Actual results:

see above


Expected results:

see above
Bug: "Send To Device" missing from tab menu
Status: RESOLVED
Priority: --
Resolution: FIXED
Created: 2022-07-31 15:32:47+00:00
Resolved: 2022-08-03 02:38:35+00:00

With Firefox Nightly build 20220731065953, if I right-click on a tab the menu does not include the "Send Tab to Device".  Similarly, if I click on my Firefox Account in the main menu, there is no "Send tab to device" item.  Steps to reproduce:

1. Sign into a Firefox Account with at least one other device.
2. Right-click on a tab.
3. Observe "Send Tab to Device" is missing.

I bisected the regression to Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=9579170250566372526a136c2ea93416b0c83ba0&tochange=094343eb939bf7138098f56b60db9f707206d3d4 suggesting it was regressed by Bug 1772415.

Thanks,
Kevin
Bug: Download panel is not automatically opened when download begins
Status: RESOLVED
Priority: --
Resolution: WONTFIX
Created: 2022-08-01 06:03:20+00:00
Resolved: 2024-03-26 17:22:47+00:00

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:103.0) Gecko/20100101 Firefox/103.0

Steps to reproduce:

Tried to download anything, e.g. picture from main Google site.


Actual results:

Download panel should pop up showing download progress, but it did not.

Note: ... looking into about:config, the settings are:

browser.download.alwaysOpenPanel is set to true
browser.download.improvements_to_download_panel is set to true
browser.download.panel.firstSessionCompleted is set to true (with bold)
browser.download.panel.shown is set to true (with bold)

When changing browser.download.panel.shown to false (it goes off bold), trying to download the picture from main Google site actually shows download panel. However, this setting then changes automatically back to true (with bold).


Expected results:

Download panel should automatically open when download is initiated...
Bug: Device is showing as active 2/3 years ago, when the account is signed in and syncing
Status: NEW
Priority: P3
Created: 2022-08-01 09:17:25+00:00
Resolved: 2022-10-25 10:15:28+00:00

Testing  a local build, I've signed in into my Firefox account, which is already used on a mobile browser (Firefox Nightly).

In Firefox View I have the list of tabs in "Tab Pickup", but below I still have the `Grab tabs from your phone or tablet` promo. Not sure if that's because I'm using nightly and not release.
Bug: The Windows fixup is incorrect for a valid DNS keyword
Status: NEW
Priority: P5
Created: 2022-08-01 10:05:12+00:00
Resolved: 2023-12-04 19:58:26+00:00

**Found in**
* Fx104.0b4

**Affected versions**
* Fx 105.0a1
* Fx 104.0b4
* Fx 91.12.0esr
* Fx 102.1.0esr

**Affected platforms**
* Windows 10

**Preconditions**
browser.fixup.alternate.enabled = true
keyword.enabled = false

Add the following in your OS hosts file:
::1 thisisalocalDNSmatch

**Steps to reproduce**
1. Launch Firefox.
2. Type *thisisalocalDNSmatch* in the address bar and hit enter.
3. Type *thisisNOTalocalDNSmatch* in the address bar and hit enter.

**Expected result**
2. The URL on Windows should be https://thisisalocalDNSmatch and unable to connect page displayed.
3. The URL on Windows should be https://www.thisisNOTalocalDNSmatch.com and the server not found page displayed.

**Actual result**
2. The URL on Windows is https://www.thisisalocalDNSmatch.com and the server not found page displayed.
3. The URL on Windows is https://www.thisisNOTalocalDNSmatch.com and the server not found page displayed.

**Regression range**
* This is not a recent regression. Behavior is present all the way back to Fx 91.

**Additional notes**
* This does not look like something introduced by the turning off of URL manipulation.
* For macOS and Ubuntu, the fixup is not done as on Windows for keyword match, meaning the URL for step 2 is: *https://thisisalocalDNSmatch*
* Please see the screenshot for more details.