av9ash/GitBugs huggingface dataset:
Bug: Unexpected error on calling tabs.update() with {pinned:true} for a discarded tab
Status: RESOLVED
Priority: P1
Resolution: FIXED
Created: 2023-09-09 11:49:42+00:00
Resolved: 2023-10-16 14:54:16+00:00

`browser.tabs.update(tabId, { pinned: true })` fails if the specified tab is discarded (pending).

# Steps to reproduce

1. Install an extension with `tabs` permission.
2. Call `browser.tabs.update(tabId, { discarded: true })` for a tab.
3. Call `browser.tabs.update(tabId, { pinned: true })` for the tab same to the step 2.

# Actual result

An error is reported in the browser console, as:

```
can't access property "isAppTab", aTab.linkedBrowser.browsingContext is null tabbrowser.js:716
    _notifyPinnedStatus chrome://browser/content/tabbrowser.js:716
    pinTab chrome://browser/content/tabbrowser.js:732
    update chrome://browser/content/parent/ext-tabs.js:934
    result resource://gre/modules/ExtensionParent.sys.mjs:1127
    withCallContextData resource://gre/modules/ExtensionParent.sys.mjs:607
    result resource://gre/modules/ExtensionParent.sys.mjs:1126
    withPendingBrowser resource://gre/modules/ExtensionParent.sys.mjs:617
    result resource://gre/modules/ExtensionParent.sys.mjs:1125
    callAndLog resource://gre/modules/ExtensionParent.sys.mjs:1086
    recvAPICall resource://gre/modules/ExtensionParent.sys.mjs:1124
    InterpretGeneratorResume self-hosted:1469
    AsyncFunctionNext self-hosted:852
```

# Expected result

The tab become pinned with discarded state.

# Environment

* Windows 10
* Firefox ESR115
* Nightly 119.0a1 (build ID: 20230908211202)

# Bisection result

The mozregression says that the first bad build is:

```
build_date: 2023-03-14
build_type: nightly
build_url: https://archive.mozilla.org/pub/firefox/nightly/2023/03/2023-03-14-16-14-05-mozilla-central/firefox-113.0a1.en-US.win64.zip
changeset: c47b3b28fb48c01c33585b46650249b182cabe00
pushlog_url: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=a8939ff5236dad956af827235ceed7104e5e92c2&tochange=c47b3b28fb48c01c33585b46650249b182cabe00
repo_name: mozilla-central
repo_url: https://hg.mozilla.org/mozilla-central
```
Bug: When you lose session data, you don't fool around!
Status: RESOLVED
Priority: --
Resolution: INCOMPLETE
Created: 2023-09-09 14:53:21+00:00
Resolved: 2024-04-01 12:23:39+00:00

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/117.0

Steps to reproduce:

Basically, I was in Nexusmods, commenting on the utility of a good Skyrim mod when Firefox froze... HARD. This has happened before after an update, a couple of years ago this same event happened, so I knew what to expect.



Actual results:

As with the last time a couple of years ago, on restarting the computer Firefox was fine and my Recent History was correct but the session, one with multiple tabs over five windows, was supplanted with the session in place the last time this happened. (I should add that back THEN said session had backdated a couple of years, as well!)


Expected results:

IN all honesty, this shows a basic incompatibility cropping up when you update certain processes. What should have happened is that Firefox shouldn't have frozen or lost my session. Also, I have AdChoices and other intrusive, abusive adbots tryinbg to horn in yet again. This is nonsense you keep letting back in for no reason I can see. (So help me God, if you ever regress back to allowing Buzzing Fly...)

Also, this is on my desktop computer, a Dell. Not an app, not a "device", not really that forgivable.
Bug: On Firefox 117 for Mac, clicking a link outside the application results in an empty browser loading. A second click on the link is required for the link to be opened, albeit in a new tab. This appears
Status: RESOLVED
Priority: --
Resolution: DUPLICATE
Created: 2023-09-09 22:17:46+00:00
Resolved: 2023-09-19 14:47:08+00:00

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:109.0) Gecko/20100101 Firefox/117.0

Steps to reproduce:

Clicking a link anywhere outside Firefox when the browser is not already open.


Actual results:

The browser opens, to the landing page. It does not load the link. Clicking a second time opens the link, albeit in a new tab. This appears to be new, and worsened, behavior relative to a long-running issue filed under bug 1600153 (in which links always opened in a second tab).


Expected results:

The browser should have opened and loaded the link in the main tab (without opening a second tab), on the first attempt.
Bug: [win11] setAsDefaultUserChoice fails on some devices
Status: RESOLVED
Priority: P2
Resolution: WONTFIX
Created: 2023-09-09 23:21:25+00:00
Resolved: 2024-05-01 00:40:23+00:00

My patch in bug 1851596 only fixes the fallback behavior. We should investigate why WDBA fails to set default with user choice and fix it if possible.

+++ This bug was initially created as a clone of Bug #1851596 +++

**Found in**
*  118.0b4 

**Affected versions**
* 119.0a1 (2023-09-04)
* 118.0b4
* 117.0
* 115.2esr

**Tested platforms**
* Affected platforms: Windows 11x64
* Unaffected platforms: macOS 13, Ubuntu 22.1,  Windows 10x64

**Preconditions**
* Firefox is not the default browser.

**Steps to reproduce**
1. Open the Preferences page and click on the `Make Default` button.
2. Close the newly opened window.
3. Click on the  `Make Default` button again.

**Expected result** 
* The Default Apps window is opened again.

**Actual result**
* Nothing happens. `Error: WDBA nonzero exit code 2147500037: ErrExeOther ShellService.sys.mjs:567:5` error is displayed in the browser console.

**Regression range**
* Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=3bf5fce9130e653bffa77a8ef6119df92b27f6b7&tochange=e75a7ce5891f5c15e15f201ecfd816aaedf442c6

**Additional notes**
* I have Windows 22H2 (OS Build 22621.2215) Insider Release Preview.
* We tried on two Windows 11 machines with the same version. It seems that only this station is affected for some reason.
Bug: Case management failure on bugzilla
Status: RESOLVED
Priority: --
Resolution: INVALID
Created: 2023-09-10 01:05:40+00:00
Resolved: 2023-09-11 00:11:36+00:00

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/113.0.5666.197 Safari/537.36

Steps to reproduce:

Found a bug. Found a bug report open already. Waited. Waited more. Commented. Got no reply. Made a new case to bring attention to the old case since obviously it has been lost (it's NINE YEARS OLD and hasn't had a single dev comment in all that time). That bug was resolved as a duplicate and I was told not to make duplicates. OK, so: 

How DO we resolve case management failures on bugzilla?


Actual results:

Bugzilla case management failed. 


Expected results:

Case management should not fail. Bugs pointing out case management failures should not be treated as an annoyance or duplicate and resolved when they are not resolved, they should be taken as an indication that case management has failed and that the case management failure should be fixed, so that the original bugs get fixed, too, and THEN the case management bug should be resolved.

This bug should not be resolved until the case management fault has been resolved. This bug isn't about the original failure in firefox, this bug is about the failure in bugzilla to respond to the original bug.
Bug: Notifications silently stopped working in permanent private browsing mode even when explicitly allowed
Status: NEW
Priority: P3
Created: 2023-09-10 13:52:53+00:00
Resolved: 2024-10-16 22:20:22+00:00

STR:
1. Start with `browser.privatebrowsing.autostart = true`.
2. Visit https://www.bennish.net/web-notifications.html.
3. Click "Authorize".

Expected:
Permission popup appears, clicking "Allow" grants authorization.

Actual:
No permission request, authorization denied. Existing permissions to allow notifications are not honored. The permissions list indicates that new requests are not blocked.

The regressing bug is intended to disable notifications in private windows but it is unclear if it is also meant to affect permanent private browsing mode. If this is intended, the permissions panel should indicate that notifications are not allowed in this mode.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=6bf12c86cf7551ca100a0ea0cfdc17feb5bb487c&tochange=5038cbc4c1b3c1f1c9dde076516ae31f0464d0d5

Regressed by Bug 1843046.
Bug: Firefox address bar pop-out has a noticeable delay in Firefox 117
Status: RESOLVED
Priority: P2
Resolution: FIXED
Created: 2023-09-10 15:19:05+00:00
Resolved: 2023-11-21 09:29:16+00:00

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/117.0

Steps to reproduce:

1. Open Firefox 117.
2. Type quickly in the adress bar.


Actual results:

The address bar pop-out (auto-suggestions or dropdown) is delayed, lagging behind the typing speed. This bug is specific to Firefox 117 and does not occur in older versions of Firefox.


Expected results:

The address bar pop-out should keep up with the typing speed of the user.
Bug: Firefox visits wrong URL after quickly typing in a URL
Status: RESOLVED
Priority: P3
Resolution: DUPLICATE
Created: 2023-09-10 17:24:12+00:00
Resolved: 2023-11-21 09:29:16+00:00

I have seen this happen several times now.

Steps to make it happen:

Type in something into the address bar
Press Down once to select a suggestion
Quickly edit the text in the address bar and press Enter (must finish editing before the suggestion list has completed updating)

Rather than loading the page you typed in, it starts loading a suggestion instead.

Does not happen every time.  It's intermittent.

An example of this happening:
Typed in "/r" into the address bar  (reddit history)
Type in "/r" (Reddit suggestions are all in the form of, /r/something)
Press Down
Quickly press Shift+Ctrl+Left to select the last word, type in something, press Enter before the suggestion list has finished updating.
A different subreddit loads instead.

It might be related to that other bug in the address bar where the Enter key is processed differently than other keys, causing a truncated URL to be visited.  Bug #1771610

This one is difficult to reproduce because under normal circumstances, the address bar loads everything too quickly for this to happen.  For bug testing, it might be necessary to add artificial delays to the processing of the URL bar to make the bug more reproducable.
Bug: The `Very satisfied` survey option has no padding above
Status: VERIFIED
Priority: P1
Resolution: FIXED
Created: 2023-09-11 11:32:55+00:00
Resolved: 2023-09-27 11:46:51+00:00

**Found in**
* 119.0a1 (2023-09-10)


**Affected versions**
* 119.0a1 (2023-09-10)






**Tested platforms**
* Affected platforms:macOS 12,  Windows 10x64, Ubuntu 20
* Unaffected platforms: none

**Preconditions**
* browser.shopping.experience2023.enabled: true
* browser.shopping.experience2023.optedIn: 1
* browser.shopping.experience2023.survey.hasSeen:false
* browser.shopping.experience2023.survey.pdpVisits:5

**Steps to reproduce**
1. Restart Firefox after settings the above preferences and open a random Amazon product.
2. Observe the `Helo Improve Firefox` survey.

**Expected result** 
* The message and options are correctly aligned.

**Actual result**
* The `Very satisfied` option is too close to the above message.


**Regression range**
* Not a regression







**Additional notes**
* Attached a screenshot.
Bug: The tab key focus ring is clipped for the first and last options in the survey
Status: VERIFIED
Priority: P1
Resolution: FIXED
Created: 2023-09-11 11:36:07+00:00
Resolved: 2023-09-25 10:30:30+00:00

**Found in**
* 119.0a1 (2023-09-10)


**Affected versions**
* 119.0a1 (2023-09-10)






**Tested platforms**
* Affected platforms:macOS 12,  Windows 10x64, Ubuntu 20
* Unaffected platforms: none

**Preconditions**
* browser.shopping.experience2023.enabled: true
* browser.shopping.experience2023.optedIn: 1
* browser.shopping.experience2023.survey.hasSeen:false
* browser.shopping.experience2023.survey.pdpVisits:5

**Steps to reproduce**
1. Restart Firefox after settings the above preferences and open a random Amazon product.
2. Use the `Tab` and arrow keys to navigate the options on both survey pages.

**Expected result** 
* The focus ring is correctly displayed.

**Actual result**
* The focus ring is clipped for the first and last options.


**Regression range**
* Not a regression







**Additional notes**
* Attached a screen recording.
Bug: ‘Thanks for your feedback’ string missing punctuation( full stop) after dismissing an Add-on suggestion with ‘Show less frequently’ option
Status: RESOLVED
Priority: P3
Resolution: INVALID
Created: 2023-09-11 13:03:36+00:00
Resolved: 2023-09-22 11:29:50+00:00

**Notes**
* Screenshot attached;
* Suggesting S4 severity;

**Found in**
* Beta 118.0b7;

**Affected versions**
* Nightly 119.0a1;
* Beta 118.0b7;

**Tested platforms**
* macOS 12;
* Windows 10;
* Ubuntu 22;


**Affected platforms**
* macOS 12;
* Windows 10;
* Ubuntu 22;



**Unaffected platforms**
* N/A; 

**Preconditions**
* browser.urlbar.quicksuggest.enabled set to true 
* browser.urlbar.addons.featureGate set to true 
* browser.search.region set to US 

**Steps to reproduce**
1. Launch Firefox with the profile from the preconditions.
2. In the Address Bar type a keyword that would trigger an Add-on recommendation, such as ‘tts’ , ‘adblock’ , ‘videos’.
3. Once the Add-on recommendation is shown, click on the ‘Feedback’ button.
4. Click on ‘Show less frequently’.

**Expected result**
* ‘Thanks for your feedback.’ string is shown, with punctuation(full stop). 

**Actual result**
* ‘Thanks for your feedback’ string is shown, without punctuation(full stop).


**Regression range**
* Not a regression, bug exists since the Add-on feature was first implemented.
Bug: Close button missing from review checker survey card
Status: RESOLVED
Priority: --
Resolution: DUPLICATE
Created: 2023-09-11 15:51:32+00:00
Resolved: 2023-10-04 16:30:03+00:00

**Found in**
* Firefox Nightly 119.0a1 (2023-09-10)

**Affected versions**
* Firefox Nightly 119.0a1

**Tested platforms**
* Affected platforms: All

**Preconditions**
* browser.shopping.experience2023.enabled: **true**
* browser.shopping.experience2023.optedIn: **1**
* browser.shopping.experience2023.survey.hasSeen: **false**
* browser.shopping.experience2023.survey.pdpVisits: **5**

**Steps to reproduce**
1. Restart Firefox after setting the prefs from above and open a random product page on Amazon, Walmart or Bestbuy.
2. Observe the review checker survey.

**Expected result** 
* The survey should have a ```x``` close button according to figma specifications. (screenshot)

**Actual result**
* The ```x``` close button is missing.

**Regression range**
* Not a regression, this was implemented just now.
Bug: Chrome panel feature callout color-scheme is always light
Status: RESOLVED
Priority: --
Resolution: FIXED
Created: 2023-09-11 18:07:54+00:00
Resolved: 2023-09-12 04:19:14+00:00

We [set color-scheme to light](https://searchfox.org/mozilla-central/rev/0d51e137a45a3657b39be3c27d4c7271fdb11d59/browser/components/newtab/content-src/styles/_feature-callout.scss#12,21-23) but didn't set it to dark for dark mode. Previously it was only working fine because that rule wasn't actually respected due to a bug. Now that's been fixed, chrome callouts are showing as light even in dark mode. So we should just remove the color-scheme rule, it's unnecessary.
Bug: --newtab variables are no longer accessible from Firefox View with "System theme - auto" on Windows and macOS
Status: VERIFIED
Priority: P2
Resolution: FIXED
Created: 2023-09-11 18:33:27+00:00
Resolved: 2023-10-03 13:30:37+00:00

To reproduce:
Set your browser's theme to "System theme - auto" and set your OS-level theme to Dark.
Notice how the body background color of Firefox View is now falling back to `--in-content-page-background` which is much darker than the expected `--newtab-background-color`.

In Firefox View, we define a CSS variable for the background color [here](https://searchfox.org/mozilla-central/source/browser/components/firefoxview/firefoxview-next.css#10) that's defaulted to use `--newtab-background-color`, but falls back to `--in-content-page-background` if that's not found.
We should ideally work out a way to reuse the variables defined in `activity-stream-[os].css` files such as [here](https://searchfox.org/mozilla-central/source/browser/components/newtab/css/activity-stream-mac.css#41,71) so we aren't redefining the same variable in two different places.

This was a regression caused by bug 1843044.
Bug: Multi select radio buttons are vertically misaligned with their labels in feature callout
Status: RESOLVED
Priority: P2
Resolution: WORKSFORME
Created: 2023-09-11 19:09:33+00:00
Resolved: 2024-04-25 18:20:10+00:00

The label is like 2-3px higher than the radio button. Should be a pretty straightforward fix but requires on-train changes.
Bug: annoying layout shift when loading shopping sidebar
Status: RESOLVED
Priority: --
Resolution: DUPLICATE
Created: 2023-09-11 19:26:41+00:00
Resolved: 2023-09-14 18:31:14+00:00

The shopping sidebar has a very annoying layout shift during the loading progress.

STR:

1. open an amazon.com product page
2. reload the page a few times

Actual:

The content of the sidebar jumps. See https://www.youtube.com/shorts/KVNgwijrzuY. Bug 1846768 regressed the reload case. But the layout shift was already there before this change when you navigated through different products.

Expected:

A stable sidebar without layout shift. Look, for example, at the close button. The button visibly changes its position, and this should not happen at all, neither on a page reload nor when you open another product.
Bug: Open tabs in Recent browsing is not updating correctly
Status: VERIFIED
Priority: P1
Resolution: FIXED
Created: 2023-09-11 20:15:20+00:00
Resolved: 2023-10-10 13:11:49+00:00

When you are browsing through tabs on multiple windows the Open tabs list in Recent browsing does not update as expected. 

Each window appears to take a specific row number to update instead of moving to the top of the Open tabs section. 

Window 1 seems to always update the first row
Window 2 updates the second row
Current window updates the 3rd row

See attached video. 

Expected:
For the last active tab to move to the first position in the open tabs list

Also, I noticed a tab isn't moved to the top of the Open tabs card when the user selects the tab and scrolls the page. Only after a new page navigation or reload does it become active and move to the top of the list. Is it possible to consider selecting a tab/scrolling the contents as an interaction with a tab?

Let me know if you have any questions. Thanks
Bug: Low contrast on the Updates available triangle icon when using dark theme
Status: RESOLVED
Priority: --
Resolution: DUPLICATE
Created: 2023-09-12 06:09:33+00:00
Resolved: 2023-10-04 16:29:46+00:00

Filled on request per [1849697#c11](https://bugzilla.mozilla.org/show_bug.cgi?id=1849697#c11)

**Found in**
* 119.0a1 (2023-09-11) 


**Affected versions**
* 119.0a1 (2023-09-11) 






**Tested platforms**
* Affected platforms:macOS 12,  Windows 10x64, Ubuntu 20

* Unaffected platforms: none

**Preconditions**
* dark theme enabled
* browser.shopping.experience2023.enabled: true
* browser.shopping.experience2023.optedIn: 1

**Steps to reproduce**
1. Open an amazon product that needs to be reanalyzed.
2. Observe the yellow-triangle icon.

**Expected result** 
* The icon is visible.

**Actual result**
* The icon is not so visible.


**Regression range**
* Not a regression.







**Additional notes**
* Attached a screenshot.
Bug: Firefox Setup 115.2.0esr.exe claims firefox is already running, so can't install
Status: RESOLVED
Priority: P3
Resolution: INCOMPLETE
Created: 2023-09-12 13:14:23+00:00
Resolved: 2024-02-07 20:54:24+00:00

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:91.0) Gecko/20100101 Firefox/91.0 SeaMonkey/2.53.16

Steps to reproduce:

Running Windows 7 Pro SP1 X64, but 32-bit Firefox.
Firefox Setup 115.2.0esr.exe Size: 56841840 bytes (54 MiB), 7-Zip CRC32: 2C19CA3E
User Agent upon final success: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:109.0) Gecko/20100101 Firefox/115.0
------
I quit the previous version of Firefox ESR (v115.1.0)
Other browsers running were Seamonkey and Palemoon.
Downloaded Firefox Setup 115.2.0esr.exe and ran it.
Selected Custom Install, deselected creating any icons, deselected setting ff as my default browser, clicked "Upgrade".



Actual results:

A short distance into the installation, a window popped up stating that firefox was already running, so it could not continue. I checked Task Manager and Services. No fox or vixen.
I quit Seamonkey and tried again. Same error.
Later, I tried the same installer on a 32-bit Windows 7 notebook that had no other browsers running. It succeeded.
On the x64 desktop again, started firefox v115.1 again and tried the upgrade via the Help>About window. It succeeded.
Previous upgrades of firefox using a full offline installer have always succeeded, including while Seamonkey and/or Palemoon have been running.


Expected results:

Installer should have continued to a screen with a "run Firefox now" checkbox.
Bug: [intermitent] Review checker infinite loading after restoring session
Status: VERIFIED
Priority: P3
Resolution: FIXED
Created: 2023-09-12 13:43:23+00:00
Resolved: 2023-09-15 16:40:21+00:00

**Found in**
* 119.0a1 (2023-09-12)


**Affected versions**
* 119.0a1 (2023-09-12)






**Tested platforms**
* Affected platforms: Windows 10x64 (only with attached profile), Ubuntu 20
* Unaffected platforms: none


**Steps to reproduce**
* Unfortunately I don’t have some clear steps to reproduce this. I could only reproduce this initially on Ubuntu 20.04 from which I could take a profile and then reproduce this on Windows 10x64 as well. Basically, I was restoring multiple windows containing Amazon products on Ubuntu 20.04 by using the `Restore previous session` button and some of the windows had the `Review checker` displayed in infinite loading.

Steps from the attached profile:
1. Open the attached profile and restore the session from the second window.
2. Observe all windows.

**Expected result** 
* No infinite loading on the review checker.

**Actual result**
* One of the windows has infinite loading on the review checker.








**Additional notes**
* Profile: [link](https://drive.google.com/file/d/1khpWckkHK3VtJba5-m3DE5K5E6CZwvjk/view?usp=sharing)
* Attached a screen recording: [link](https://drive.google.com/file/d/163fByTGdw08bxVU120usbdT3NPfOzTXT/view?usp=drive_link)
* It seems that the issue is reproducing constantly with the attached profile only on the Ubuntu 20.04 station and my Windows 10x64 station. We tried on another Windows 10x64 and macOS 12 station but I could only reproduce the issue with this profile two times on Windows 10x64.
* Originally I could only intermittently reproduce this issue on Ubuntu 20.04. I could only reproduce the issue on Windows 10x64 after I transferred the profile from Ubunut 20.04.
* Note this profile has the http set to stage
`toolkit.shopping.ohttpConfigURL: "https://stage.ohttp-gateway.nonprod.webservices.mozgcp.net/ohttp-configs"`
`toolkit.shopping.ohttpRelayURL to "https://mozilla-ohttp-dev.fastly-edge.com/"`. This reproduced with default prefs as well but using the same attached profile.