Bug: firefox nightly fails to build with: ../toolkit/components/remote/nsXRemoteServer.cpp:124:46: error: cannot convert 'char*' to 'mozilla::Span<const char>'
Status: RESOLVED
Priority: --
Resolution: FIXED
Created: 2024-09-13 09:16:33+00:00
Resolved: 2024-09-17 13:01:40+00:00

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/115.0

Steps to reproduce:

hi, I downloaded latest git snapshot from today and compiled it for armv7a on linux. 


Actual results:

the build fails to compile: 

38:27.79 /usr/bin/armv7a-unknown-linux-gnueabihf-g++ --sysroot /usr/armv7a-unknown-linux-gnueabihf -o nsXRemoteServer.o -c  -I/var/tmp/portage/portage/www-client/firefox-132.0/work/firefox_build/dist/stl_wrappers -I/var/tmp/portage/portage/www-client/firefox-132.0/work/firefox_build/dist/system_wrappers -include /var/tmp/portage/portage/www-client/firefox-132.0/work/firefox-132.0/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -DNDEBUG=1 -DTRIMMED=1 -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DMOZ_SUPPORT_LEAKCHECKING -DSTATIC_EXPORTABLE_JS_API -I/var/tmp/portage/portage/www-client/firefox-132.0/work/firefox-132.0/toolkit/components/remote -I/var/tmp/portage/portage/www-client/firefox-132.0/work/firefox_build/toolkit/components/remote -I/var/tmp/portage/portage/www-client/firefox-132.0/work/firefox-132.0/toolkit/profile -I/var/tmp/portage/portage/www-client/firefox-132.0/work/firefox-132.0/toolkit/xre -I/var/tmp/portage/portage/www-client/firefox-132.0/work/firefox_build/dist/include -I/usr/armv7a-unknown-linux-gnueabihf/usr/include/nspr -I/usr/armv7a-unknown-linux-gnueabihf/usr/include/nss -I/usr/armv7a-unknown-linux-gnueabihf/usr/include/nspr -I/var/tmp/portage/portage/www-client/firefox-132.0/work/firefox_build/dist/include/nss -I/usr/armv7a-unknown-linux-gnueabihf/usr/include/libpng16 -I/usr/armv7a-unknown-linux-gnueabihf/usr/include/pixman-1 -DMOZILLA_CLIENT -include /var/tmp/portage/portage/www-client/firefox-132.0/work/firefox_build/mozilla-config.h -mthumb -mfpu=neon -mfloat-abi=hard -mno-thumb-interwork -fno-rtti -pthread -fno-sized-deallocation -fno-aligned-new -ffunction-sections -fdata-sections -fno-math-errno -fno-exceptions -pipe -fPIC -pipe -fomit-frame-pointer -O2 -fno-omit-frame-pointer -funwind-tables -Wall -Wempty-body -Wignored-qualifiers -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wno-invalid-offsetof -Wcomma-subscript -Wvolatile -Wno-deprecated-enum-enum-conversion -Wduplicated-cond -Wimplicit-fallthrough -Wlogical-op -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=coverage-mismatch -Wno-error=free-nonheap-object -Wno-multistatement-macros -Wno-error=class-memaccess -Wformat -Wformat-security -Wformat-overflow=2 -Wno-psabi -Wno-error=builtin-macro-redefined -I/usr/armv7a-unknown-linux-gnueabihf/usr/include/gtk-3.0/unix-print -I/usr/armv7a-unknown-linux-gnueabihf/usr/include/gtk-3.0 -I/usr/armv7a-unknown-linux-gnueabihf/usr/include/pango-1.0 -I/usr/armv7a-unknown-linux-gnueabihf/usr/include/at-spi2-atk/2.0 -I/usr/armv7a-unknown-linux-gnueabihf/usr/include/at-spi-2.0 -I/usr/armv7a-unknown-linux-gnueabihf/usr/include/dbus-1.0 -I/usr/armv7a-unknown-linux-gnueabihf/usr/lib/dbus-1.0/include -I/usr/armv7a-unknown-linux-gnueabihf/usr/include/fribidi -I/usr/armv7a-unknown-linux-gnueabihf/usr/include/harfbuzz -I/usr/armv7a-unknown-linux-gnueabihf/usr/include/atk-1.0 -I/usr/armv7a-unknown-linux-gnueabihf/usr/include/cairo -I/usr/armv7a-unknown-linux-gnueabihf/usr/include/freetype2 -I/usr/armv7a-unknown-linux-gnueabihf/usr/include/pixman-1 -I/usr/armv7a-unknown-linux-gnueabihf/usr/include/gdk-pixbuf-2.0 -I/usr/armv7a-unknown-linux-gnueabihf/usr/include/libpng16 -I/usr/armv7a-unknown-linux-gnueabihf/usr/include/gio-unix-2.0 -I/usr/armv7a-unknown-linux-gnueabihf/usr/lib/libffi/include -pthread -I/usr/armv7a-unknown-linux-gnueabihf/usr/include/glib-2.0 -I/usr/armv7a-unknown-linux-gnueabihf/usr/lib/glib-2.0/include -I/usr/armv7a-unknown-linux-gnueabihf/usr/include/libmount -I/usr/armv7a-unknown-linux-gnueabihf/usr/include/blkid -fno-strict-aliasing -ffp-contract=off  -MD -MP -MF .deps/nsXRemoteServer.o.pp  -fdiagnostics-color  /var/tmp/portage/portage/www-client/firefox-132.0/work/firefox-132.0/toolkit/components/remote/nsXRemoteServer.cpp
38:27.79 /var/tmp/portage/portage/www-client/firefox-132.0/work/firefox-132.0/toolkit/components/remote/nsXRemoteServer.cpp: In member function 'bool nsXRemoteServer::HandleNewProperty(XID, Display*, Time, Atom)':
38:27.80 /var/tmp/portage/portage/www-client/firefox-132.0/work/firefox-132.0/toolkit/components/remote/nsXRemoteServer.cpp:124:46: error: cannot convert 'char*' to 'mozilla::Span<const char>'
38:27.80   124 |     const char* response = HandleCommandLine(data, aEventTime);
38:27.80       |                                              ^~~~



Expected results:

I believe this was triggered by latest plumbing in #1917515

the full and compressed build log is attached