Bug: browser/components/newtab/test/browser/browser_aboutwelcome_rtamo.js fails against MSIX packages
Status: RESOLVED
Priority: P2
Resolution: FIXED
Created: 2022-12-09 14:05:51+00:00
Resolved: 2022-12-16 00:00:15+00:00

[task 2022-12-09T00:11:51.538Z] 00:11:51     INFO - TEST-UNEXPECTED-FAIL | browser/components/newtab/test/browser/browser_aboutwelcome_rtamo.js | Uncaught exception in test - at resource://testing-common/sinon-7.2.7.js:3605 - TypeError: Attempted to wrap getAddonsByIDs which is already wrapped
[task 2022-12-09T00:11:51.538Z] 00:11:51     INFO - Stack trace:
[task 2022-12-09T00:11:51.538Z] 00:11:51     INFO - checkWrappedMethod@resource://testing-common/sinon-7.2.7.js:3605:21
[task 2022-12-09T00:11:51.538Z] 00:11:51     INFO - wrapMethod@resource://testing-common/sinon-7.2.7.js:3653:31
[task 2022-12-09T00:11:51.538Z] 00:11:51     INFO - stub@resource://testing-common/sinon-7.2.7.js:3002:44
[task 2022-12-09T00:11:51.538Z] 00:11:51     INFO - stub@resource://testing-common/sinon-7.2.7.js:2099:33
[task 2022-12-09T00:11:51.539Z] 00:11:51     INFO - test_rtamo_aboutwelcome@chrome://mochitests/content/browser/browser/components/newtab/test/browser/browser_aboutwelcome_rtamo.js:126:11
[task 2022-12-09T00:11:51.539Z] 00:11:51     INFO - handleTask@chrome://mochikit/content/browser-test.js:1037:26
[task 2022-12-09T00:11:51.539Z] 00:11:51     INFO - _runTaskBasedTest@chrome://mochikit/content/browser-test.js:1109:18
[task 2022-12-09T00:11:51.539Z] 00:11:51     INFO - Tester_execTest@chrome://mochikit/content/browser-test.js:1244:14
[task 2022-12-09T00:11:51.539Z] 00:11:51     INFO - nextTest/<@chrome://mochikit/content/browser-test.js:1026:14
[task 2022-12-09T00:11:51.539Z] 00:11:51     INFO - SimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1036:13
[task 2022-12-09T00:11:51.540Z] 00:11:51     INFO - 
[task 2022-12-09T00:11:51.540Z] 00:11:51     INFO - --------------
[task 2022-12-09T00:11:51.540Z] 00:11:51     INFO - wrapMethod@resource://testing-common/sinon-7.2.7.js:3679:26
[task 2022-12-09T00:11:51.540Z] 00:11:51     INFO - stub@resource://testing-common/sinon-7.2.7.js:3002:44
[task 2022-12-09T00:11:51.540Z] 00:11:51     INFO - stub@resource://testing-common/sinon-7.2.7.js:2099:33
[task 2022-12-09T00:11:51.540Z] 00:11:51     INFO - openRTAMOWithAttribution@chrome://mochitests/content/browser/browser/components/newtab/test/browser/browser_aboutwelcome_attribution.js:68:11
[task 2022-12-09T00:11:51.540Z] 00:11:51     INFO - test_rtamo_attribution@chrome://mochitests/content/browser/browser/components/newtab/test/browser/browser_aboutwelcome_attribution.js:129:23
[task 2022-12-09T00:11:51.540Z] 00:11:51     INFO - handleTask@chrome://mochikit/content/browser-test.js:1037:26
[task 2022-12-09T00:11:51.540Z] 00:11:51     INFO - _runTaskBasedTest@chrome://mochikit/content/browser-test.js:1109:18
[task 2022-12-09T00:11:51.540Z] 00:11:51     INFO - Tester_execTest@chrome://mochikit/content/browser-test.js:1244:14
[task 2022-12-09T00:11:51.540Z] 00:11:51     INFO - nextTest/<@chrome://mochikit/content/browser-test.js:1026:14
[task 2022-12-09T00:11:51.540Z] 00:11:51     INFO - SimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1036:13
[task 2022-12-09T00:11:51.541Z] 00:11:51     INFO - Leaving test bound test_rtamo_aboutwelcome
[task 2022-12-09T00:11:51.542Z] 00:11:51     INFO - Entering test bound test_rtamo_over_experiments
[task 2022-12-09T00:11:51.542Z] 00:11:51     INFO - Not taking screenshot here: see the one that was previously logged

The right thing to do here might just be disabling the test, since the RTAMO flow isn't supported for MSIX packages. The error should probably be investigated first though - it's possible there's a real underlying issues that we ought to fix.