av9ash/GitBugs huggingface dataset:
Bug: aboutPrivateBrowsing.js does confusing things with fluent
Status: RESOLVED
Priority: P2
Resolution: FIXED
Created: 2023-03-27 18:21:38+00:00
Resolved: 2023-04-20 01:30:23+00:00

I was auditing fluent translateElements usage and came across the code in [aboutPrivateBrowsing.js](https://searchfox.org/mozilla-central/rev/736eb58cd30da3afc0310b58232a1e4d0dcc86a4/browser/components/privatebrowsing/content/aboutPrivateBrowsing.js#7-31).

This isn't technically calling `document.l10n.translateElements` - it's a helper with the same name, but it calls `translateFragment`, so I poked a little bit.

I think this code is a little confused.

For one, it blocks on `document.l10n.ready`, which AIUI resolves when the document's initial l10n pass completes. I don't see why it needs to wait for that to ask fluent to translate other elements.

For another, it is async, but it doesn't return (pass along) the return value of the `translateFragment` call, so in other words, it doesn't actually resolve when the translation is complete.

Finally, the callsite in `renderInfo` blocks doing a bunch of other work on the translation completing. That seems odd - the click handlers and other behavioural bits could run immediately without waiting for the translation (and do, because of the previous issues around `translateFragment`).

Fundamentally I wonder if this code needs to call `translateFragment` (and be async) at all, or if it could just be a bunch of calls to `document.l10n.setAttributes`. I'm a little nervous because [callers](https://searchfox.org/mozilla-central/rev/736eb58cd30da3afc0310b58232a1e4d0dcc86a4/browser/components/privatebrowsing/content/aboutPrivateBrowsing.js#262) seem to then do things like recording impressions, so we'd want to be quite careful about any changes we make here.

I don't know if the changes in bug 1819664 would also block onload for about:privatebrowsing. It would depend on what criteria the code there uses for what constitutes a "chrome document".

Barret, are you the right person to take a look at this?
Bug: Verify the translations engine support detection is working correctly
Status: RESOLVED
Priority: P2
Resolution: FIXED
Created: 2023-03-27 20:35:38+00:00
Resolved: 2023-04-05 16:03:33+00:00

In Bug 1820229 - Sören Hentzschel said:

> @Greg: Is it expected that the translations engine is not supported on a MacBoook with M1 Pro? The extension worked on this device. But this implementation logs the following message:
>
> The translations engine is not supported on this device.
>
> The detection was implemented in the second patch of this bug.

I may have gotten this wrong, checking for intgemm support. I'll have to double check the approach.

I'm marking this as a defect, but it's not user-visible yet since all of this is behind a pref.
Bug: Firefox 111.0.1 installed via Ubuntu PPA reports Windows user agent
Status: RESOLVED
Priority: --
Resolution: INVALID
Created: 2023-03-27 20:52:19+00:00
Resolved: 2023-03-27 21:21:17+00:00

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:111.0) Gecko/20100101 Firefox/111.0

Steps to reproduce:

*Running Ubuntu 22.10, install Firefox via Mozillateam PPA (https://ppa.launchpadcontent.net/mozillateam/ppa/ubuntu/ kinetic main)
* Open web developer tools
* Navigate to any site as normal


Actual results:

In developer tools as well as any site designed to display user agent strings (such as ipchicken.com) user agent is reported as "Mozilla/5.0 (Windows NT 10.0; rv:111.0) Gecko/20100101 Firefox/111.0"


Expected results:

Compared to version 111 installed via snap, expected user agent string is "Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/111.0"
Bug: 1.43 - 1.36% Base Content JS / Base Content JS + 2 more (Linux, OSX, Windows) regression on Fri March 24 2023
Status: RESOLVED
Priority: P2
Resolution: FIXED
Created: 2023-03-28 06:01:26+00:00
Resolved: 2023-04-14 19:42:54+00:00

Perfherder has detected a awsy performance regression from push [61b5bdae971a0fad048aa9039567c3a8f87c2743](https://hg.mozilla.org/integration/autoland/pushloghtml?changeset=61b5bdae971a0fad048aa9039567c3a8f87c2743). As author of one of the patches included in that push, we need your help to address this regression.

### Regressions:

| **Ratio** | **Test** | **Platform** | **Options** | **Absolute values (old vs new)** |  
|--|--|--|--|--| 
| [1%](https://treeherder.mozilla.org/perfherder/graphs?timerange=1209600&series=autoland,4663317,1,4)  | [Base Content JS](https://firefox-source-docs.mozilla.org/testing/perfdocs/awsy.html#base-content-js)  | windows11-64-2009-shippable-qr | fission | 1,638,357.33 -> 1,661,832.00 | 
| [1%](https://treeherder.mozilla.org/perfherder/graphs?timerange=1209600&series=autoland,3807462,1,4)  | [Base Content JS](https://firefox-source-docs.mozilla.org/testing/perfdocs/awsy.html#base-content-js)  | macosx1015-64-shippable-qr | fission | 1,636,629.33 -> 1,659,822.00 | 
| [1%](https://treeherder.mozilla.org/perfherder/graphs?timerange=1209600&series=autoland,3807462,1,4)  | [Base Content JS](https://firefox-source-docs.mozilla.org/testing/perfdocs/awsy.html#base-content-js)  | macosx1015-64-shippable-qr | fission | 1,636,745.33 -> 1,659,705.33 | 
| [1%](https://treeherder.mozilla.org/perfherder/graphs?timerange=1209600&series=autoland,3806445,1,4)  | [Base Content JS](https://firefox-source-docs.mozilla.org/testing/perfdocs/awsy.html#base-content-js)  | linux1804-64-shippable-qr | fission | 1,636,904.67 -> 1,659,192.00 | 


Details of the alert can be found in the [alert summary](https://treeherder.mozilla.org/perfherder/alerts?id=37774), including links to graphs and comparisons for each of the affected tests. Please follow our [guide to handling regression bugs](https://wiki.mozilla.org/TestEngineering/Performance/Handling_regression_bugs) and **let us know your plans within 3 business days, or the offending patch(es) may be backed out** in accordance with our [regression policy](https://www.mozilla.org/en-US/about/governance/policies/regressions/).

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

For more information on performance sheriffing please see our [FAQ](https://wiki.mozilla.org/TestEngineering/Performance/FAQ).
Bug: Outlook email zooms in when scrolling when changing tabs
Status: UNCONFIRMED
Priority: --
Created: 2023-03-28 07:05:46+00:00
Resolved: 2023-04-14 12:07:11+00:00

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/113.0

Steps to reproduce:

In Outlook, scroll on the preview pane of an email as you change tabs. When tabbing back to outlook, the email will have changed zoom levels.
Bug: Tab URL is permanently replaced with about:newtab in certain cases after quitting Firefox before the TLS connection is established
Status: NEW
Priority: P3
Created: 2023-03-28 09:32:38+00:00
Resolved: 2024-12-05 16:23:36+00:00

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:109.0) Gecko/20100101 Firefox/111.0

Steps to reproduce:

1. Ensure the "Startup -> open previous windows and tabs" setting is enabled in Preferences. Ensure the "Home -> New tabs" setting is set to "Blank page";
2. Open an URL that resolves to an offline/inaccessible host in a new tab (e.g. the hostname points to an IP address of an offline machine so the TCP connection times out eventually); switch to this tab if it's not the current foreground tab;
3. Close and restart Firefox before Firefox reports a connection error to the user;
4. Firefox should be attempting to reload the original URL and reconnect to the host at this point; close and restart Firefox again before the connection error is reported.


Actual results:

After step 3, the original URL is not displayed in the URL bar while Firefox is attempting to connect to the host. This also happens after step 2 if the new tab is spawned by clicking a link.
After step 4, the original URL is permanently lost, the tab URL is replaced with about:newtab.


Expected results:

After step 2, if the tab has been spawned by the user clicking a link, the URL bar should display the link URL even before the connection to the host is established.
Similarly, after step 3 the link URL should be restored and visible in the URL bar even before the connection to the host is established.
After step 4, the URL for the tab in question should still be the original URL and not about:newtab.
Bug: Drag and drop bug in downloads
Status: RESOLVED
Priority: --
Resolution: DUPLICATE
Created: 2023-03-28 10:48:19+00:00
Resolved: 2023-03-29 15:43:11+00:00

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:109.0) Gecko/20100101 Firefox/111.0

Steps to reproduce:

Since upgrading to Firefox 111.0.1 I cannot drag downloaded files to the desktop.  Instead I have to "show in finder" and then drag the file to the desktop. This worked fine in most previous versions, so I guess it's a bug not a "feature".
Bug: [Bookmarks sidebar] CTRL+Space{bar} no longer works on FF 111.0.1
Status: RESOLVED
Priority: --
Resolution: WORKSFORME
Created: 2023-03-28 11:18:30+00:00
Resolved: 2023-04-12 16:05:31+00:00

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:109.0) Gecko/20100101 Firefox/111.0

Steps to reproduce:

Just wanna select multiple (CTRL+Space) saved bookmarks from the left BM sidebar, in order to re-arrange/move them in a BM folder.


Actual results:

CTRL+Space won't select anything, as expected. Only SHIFT+Up/Down arrows do the trick (but not for intermittent BM list).


Expected results:

CTRL+Space should select/highlight the exact bookmark (one at a time)...
Bug: PDF form field displayed as number instead of text
Status: RESOLVED
Priority: P3
Resolution: FIXED
Created: 2023-03-28 13:42:30+00:00
Resolved: 2023-05-20 14:07:38+00:00

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/111.0.0.0 Safari/537.36

Steps to reproduce:

Open a pdf form with a pre-filled out text field value of "165.000,00 €" (European separators)


Actual results:

FF PDF viewer shows "165,00", therefore seems to wrongly interpret the text as a number.


Expected results:

FF PDF viewer should show "165.000,00 €", since it is a text field and no auto-conversion into number should take place.

The field properties have been extracted as follows:
FieldType: Text
FieldName: JU_eur
FieldFlags: 8388609 (decimal)
FieldValue: 165.000,00 &#8364;
FieldJustification: Right
Bug: Ensure that Variant 2's "Select All" checkbox only checks items that are visible.
Status: RESOLVED
Priority: --
Resolution: FIXED
Created: 2023-03-28 14:16:04+00:00
Resolved: 2023-03-29 03:13:22+00:00

Right now it's checking both hidden and visible checkboxes: https://searchfox.org/mozilla-central/rev/82828dba9e290914eddd294a0871533875b3a0b5/browser/components/migration/content/migration-wizard.mjs#695-697

It should only check the visible ones. That way, we don't accidentally confuse the parent process with a request to migrate things for which there are no resources.

At the same time, we should also make the MigrationWizardParent more resilient to this, where it will choose to ignore any attempts to migrate resources that it doesn't support.
Bug: Unchecking any resource item in Variant 2 should also uncheck the "Select All" checkbox.
Status: RESOLVED
Priority: --
Resolution: FIXED
Created: 2023-03-28 15:00:25+00:00
Resolved: 2023-04-12 09:13:23+00:00

STR:

1. Make sure browser.migrate.content-modal.enabled is true and browser.migrate.content-modal.import-all.enabled is true
2. Create a new boolean pref, `browser.migrate.internal-testing.enabled` set to `true`.
2. Open the Migration Wizard (about:preferences, choose "Import Data" from the General section)
3. Choose the "Internal Testing Migrator" from the browser selection list
4. Expand the list of resources, and uncheck "Bookmarks"

ER:

The "Select All" checkbox should be unchecked after "Bookmarks" is unchecked.

AR:

The "Select All" checkbox stays checked.
Bug: page info > media scales without respecting css rule object-fit: contain;
Status: NEW
Priority: P5
Created: 2023-03-28 15:36:18+00:00
Resolved: 2024-05-16 10:50:54+00:00

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/113.0

Steps to reproduce:

Opened https://open.spotify.com/artist/53Y5WpBd3r0mBD4VNp5vEi?si=tkVqgel7RDWNv58R7qwItQ&nd=1
Opened Page Info > Media to download images from the caroussel at the bottom of the page (when you click on the image under "Information")


Actual results:

The images from the caroussel are all listed as graphics and get scaled to the "wrong" aspect ratio.
The first image is also listed a second time as background image, the background image entry is scaled correctly.

All images are 427px × 640px but they get scaled to 768px × 432px which is the accurate size of the img element on the page but the element has a css rule "object-fit: contain;" so Firefox actually zooms it smaller to fit the image in the correct aspect ratio (on the webpage).

Second bug on the same page, I only just noticed:
Using the save button results in a wrong file extension ".htm" instead of ".jpg"
I'm on Windows 10 64bit Education Edition with Nightly 113.0a1 (2023-03-26) (64-Bit).
If necessary I could open a second bug but it also affects the same spotify page and the same part of Firefox and the same image, so I better have this solved/looked at by the same person.


Expected results:

I don't understand why images are scaled here at all when it's just listing the media files present on a page. Especially since the save button preserves the image with the correct aspect ratio and the original scaling.

There's another image on the page that's actually 160px × 160px (but scaled to 24px × 24px)
I can barely decipher post stamp size, you? ^^
Bug: Some Spotify background images saved with incorrect extension by page info
Status: REOPENED
Priority: P3
Created: 2023-03-28 15:55:26+00:00
Resolved: 2024-05-16 11:11:04+00:00

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/113.0

Steps to reproduce:

Open https://open.spotify.com/artist/53Y5WpBd3r0mBD4VNp5vEi?si=nHNlf1UST6Wn-ZA9WwQiww

Open https://www.instagram.com/p/CoVAv_ysCeR/?img_index=1


Actual results:

Both pages have images, that when saved via "page info > media" are saved with the wrong file extension
For Spotify it's ".htm" for jpeg images
For Instagram it's ".webp" for jpeg images


Expected results:

Firefox should save images with a fitting file extension.
It already displays the correct file container format on the page info page after all.
Bug: Image preview aspect ratio is changed when narrow dialog size.
Status: RESOLVED
Priority: --
Resolution: FIXED
Created: 2023-03-28 16:33:40+00:00
Resolved: 2023-04-04 16:44:06+00:00

Steps To reproduce:
1. Open Web page with large size image
   e.g, https://support.mozilla.org/ja/
2. Open Page Info > Media 
3. Select a big image
4. Narrow the dialog width

Actual Results:
Image preview aspect ratio is changed when narrow dialog size.
Screencast: https://youtu.be/z-s7MVr4Ai8

Expected Results:
The aspect ratio should not change.
A horizontal scrollbar should be provided if the width of the image is greater than the width of the box.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=a9fc5126c3add45d0ee4c21a1b46b4d871662ae4&tochange=99aa47505e15ba5c4c63c666fd7560ca948b5e82
Bug: Left side of preview image is truncated when narrow dialog size
Status: RESOLVED
Priority: --
Resolution: DUPLICATE
Created: 2023-03-28 17:03:33+00:00
Resolved: 2023-04-04 16:44:06+00:00

When I test Bug 1825050, I found a bug in Firefox112.0b7.

Steps to reproduce:
1. Open Web page with large size image
   e.g, https://support.mozilla.org/ja/
2. Open Page Info > Media
3. Select a big image
4. Narrow the dialog width

Actual Results:
The left side of the preview image is truncated.

Expected Results:
The left side of the preview image should be visible if scroll to left.

#1Regression window(Vertical and horizontal scroll bar are missing):
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=6d37ee664b922e926a686feba165b20a628626e3&tochange=62fd688e335958ef1e95328d7bab329be8ad3a0f


#2 Regression window(Scroll bar are shown, but the left side is truncated):
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=425fd934f38510050f3cc721708511a3aef5a9fc&tochange=dc16834bdd96e0fc1c355848d5c79a02d9424943
Bug: Workaround bug 1823489 to make the Migration Wizard panel / panel-list the exact width as the selector
Status: RESOLVED
Priority: P3
Resolution: FIXED
Created: 2023-03-28 17:51:19+00:00
Resolved: 2023-04-06 09:24:24+00:00

Bug 1823489 makes it awkward for us to style the <xul:panel> / <panel-list> in the new Migration Wizard, because migration-wizard.css has limited capability of styling slotted elements.

While we try to figure out bug 1823489, we can try to just apply some CSS in the two places where the dropdown might be seen in our product - in about:preferences and (less likely) in the migration-dialog-window.html window.
Bug: Dragging a URL next to a Multi-Account Container tab opens in that Container
Status: NEW
Priority: --
Created: 2023-03-28 17:55:40+00:00
Resolved: 2024-10-13 10:47:47+00:00

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/111.0

Steps to reproduce:

1. Have at least two windows open.
2. In one window open a tab that uses a specific Multi-Account Container.
3. Drag a URL, which should open in 'No Container', from the other window next to this Multi-Account Container tab.  Specifically the target has to be to the right of the existing tab.


Actual results:

The newly created tab for the dragged-in URL is using the same Container as the existing Multi-Account Container.


Expected results:

It should have used the default container ('No Container').

In testing, if the dragged-in URL is for a site with its own configured container it *does* correctly open in that container.  It's only URLs for sites with no specific container configured that show this issue.
Bug: The update section of Preferences looks off (two line text, blank space)
Status: VERIFIED
Priority: --
Resolution: FIXED
Created: 2023-03-29 04:21:44+00:00
Resolved: 2023-03-30 14:07:23+00:00

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/113.0

Steps to reproduce:

Open about:preferences#general and scroll to the update section.


Actual results:

Some text is split in two lines and there is a lot of unnecessary blank space at the bottom. See the screenshot.


Expected results:

This is a regression caused by Bug 1822578.
Bug: [Linux] Could not find a migrator class for key opera-gx error when opening the migration window
Status: VERIFIED
Priority: --
Resolution: FIXED
Created: 2023-03-29 08:25:56+00:00
Resolved: 2023-04-06 11:55:01+00:00

**Found in**
* 113.0a1 (2023-03-27)
* 112.0b8
* 111.0.1


**Affected versions**






**Tested platforms**
* Affected platforms: Ubuntu 20.04, Ubuntu 22.04
* Unaffected platforms: macOS12, Windows 10x64





**Steps to reproduce**
1. Open Firefox > Library and Import data from another browser. 
2. Observe the browser console.

**Expected result**
* No errors are displayed.

**Actual result**
* `Could not find a migrator class for key opera-gx` error is displayed

**Regression range**
* Last good revision: 99fd417fe2e1cea8b45e9922fe456d
6ff3693097
First bad revision: d6dfa1eadc9aec2f262ede283fca325e1d183b30
 Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=99fd417fe2e1cea8b45e9922fe456d6ff3693097&tochange=d6dfa1eadc9aec2f262ede283fca325e1d183b30
Unfortunately, I don’t know which one is the regressor.



**Additional notes**
* Attached a screenshot.
* I am not aware of any functionality problems for this error.
Bug: Importing bookmarks from another browsers is slower on low end computers
Status: NEW
Priority: P3
Created: 2023-03-29 10:53:25+00:00
Resolved: 2023-04-07 15:38:00+00:00

**Found in**
* 113.0a1 (2023-03-28)


**Affected versions**
* 113.0a1 (2023-03-28)





**Tested platforms**
* Affected platforms: Ubuntu 20.04, Ubuntu 22.04, Ubuntu 18.04, Windows 10x64 (installed on HDD)
* Unaffected platforms: macOS12, Windows 10x64 (installed on SSD)





**Steps to reproduce**
1. Open Vivaldi/Chrome/Opera Browser and bookmark a decent number of random pages.
2. Import the bookmarks into Firefox.

**Expected result**
* Bookmarks importing is performed almost instantly.

**Actual result**
* Bookmark importing takes more time than before.

**Regression range**
* Last good revision: 9ac7d5436b18ff56fa6fcd27d2e7d8
6eecaaa4f7
First bad revision: 3b3f7d4d4578f6fbfbbebfd324479cc6ee0d61ff
Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=9ac7d5436b18ff56fa6fcd27d2e7d86eecaaa4f7&tochange=3b3f7d4d4578f6fbfbbebfd324479cc6ee0d61ff



**Additional notes**
* Attached a screen recording.
* The waiting time depends on the number of imported bookmarks.
* This may be hardware related because on Ubuntu 20.04 and Ubuntu 22.04 importing a large number of bookmarks can take up to ~30 seconds. On Ubuntu 18.04 it takes a maximum of ~10 seconds for the same number of bookmarks. Interestingly enough on another station that has an Ubuntu 20.04 VM installation, the importing happens in ~5 seconds for the same number of bookmarks.
* S3 because the importing is performed as expected
Bug: error: cannot convert between vector type 'xsimd::types::simd_register<float, xsimd::avx>::register_type' and vector type 'xsimd::types::simd_register<float, xsimd::sse2>::register_type'
Status: RESOLVED
Priority: --
Resolution: FIXED
Created: 2023-03-29 13:24:08+00:00
Resolved: 2023-03-30 03:25:05+00:00

Seeing the below trying to build m-c tip today. Possibly relevant, I have `ac_add_options --enable-optimize="-O2 -arch:AVX2"` included in my mozconfig.
```
In file included from third_party/gemmology/kernels/GemmologyEngineSSE2.cpp:6:
third_party/gemmology\gemmology.h(971,26): error: cannot convert between vector type 'xsimd::types::simd_register<float, xsimd::avx>::register_type' (aka '__m256') and vector type 'xsimd::types::simd_register<float, xsimd::sse2>::register_type' (aka '__m128') as implicit conversion would cause truncation
      std::get<0>(total) + xsimd::load_aligned(bias_addr + col_idx + 0),
                         ^
third_party/gemmology\gemmology.h(1022,21): note: in instantiation of function template specialization 'gemmology::callbacks::AddBias::operator()<xsimd::sse2>' requested here
  auto bias_added = add_bias(unquantized, row_idx, col_idx, col_size);
                    ^
third_party/gemmology\gemmology.h(1261,7): note: in instantiation of function template specialization 'gemmology::callbacks::UnquantizeAndAddBiasAndWrite::operator()<std::tuple<xsimd::batch<int, xsimd::sse2>, xsimd::batch<int, xsimd::sse2>>>' requested here
      callback(total, A_rowidx, B0_colidx, B_cols);
      ^
third_party/gemmology/kernels/GemmologyEngineSSE2.cpp(13,43): note: in instantiation of function template specialization 'gemmology::Engine<xsimd::sse2>::Shift::Multiply<gemmology::callbacks::UnquantizeAndAddBiasAndWrite>' requested here
template void Engine<xsimd::sse2>::Shift::Multiply(
                                          ^
1 error generated.
```
Bug: pdf.js display black squares instead of spaces
Status: RESOLVED
Priority: --
Resolution: FIXED
Created: 2023-03-29 13:46:22+00:00
Resolved: 2023-05-04 09:39:33+00:00

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/111.0

Steps to reproduce:

Open a pdf file in Firefox.



Actual results:

The pdf file is displayed with black squares instead of spaces.


Expected results:

No black square.