av9ash/GitBugs huggingface dataset:
Bug: The "Don't Show Again" checkbox from the Review Checker Callout 2 v1.1 does not work
Status: RESOLVED
Priority: --
Resolution: WORKSFORME
Created: 2024-02-01 13:49:24+00:00
Resolved: 2024-02-02 08:32:24+00:00

**Found in**
* Nightly 124.0a1 (2024-02-01)

**Affected versions**
* Nightly 124.0a1 (2024-02-01)
ALL version where the user is Enrolled in the experiment.

**Affected platforms**
* All

**Preconditions:**
Set the browser.shopping.experience2023.enabled - TRUE
Set the browser.shopping.experience2023.optedIn - 1
Set nimbus.debug to true
Set messaging-system.rsexperimentloader.collection_id to nimbus-preview
Set browser.newtabpage.activity-stream.asrouter.devtoolsEnabled to true
security.ssl.enable_ocsp_stapling - False

Reach the following link: 
about:studies?optin_slug=review-checker-callouts-v11-experiment&optin_branch=treatment-a&optin_collection=nimbus-preview

**Steps to reproduce**
1. Reach : https://www.amazon.com/XUEGW-Computer-Assembly-Required-Foldable/dp/B0CDS1238W/ref=sr_1_2_sspa?keywords=desk&qid=1706529514&sr=8-2-spons&sp_csd=d2lkZ2V0TmFtZT1zcF9hdGY&th=1
2. Close the Review Checker from the X Close button.
3. Dismiss the Callout.
4. Close Firefox and Advance Time 24h.
5. Reach : https://www.amazon.com/XUEGW-Computer-Assembly-Required-Foldable/dp/B0CDS1238W/ref=sr_1_2_sspa?keywords=desk&qid=1706529514&sr=8-2-spons&sp_csd=d2lkZ2V0TmFtZT1zcF9hdGY&th=1
6. Dismiss the Callout.
7. Close Firefox and Advance Time 5 days.
8. Reach : https://www.amazon.com/XUEGW-Computer-Assembly-Required-Foldable/dp/B0CDS1238W/ref=sr_1_2_sspa?keywords=desk&qid=1706529514&sr=8-2-spons&sp_csd=d2lkZ2V0TmFtZT1zcF9hdGY&th=1
9. Check the "Don't show again" checkbox and Dismiss the Callout.
10. Close Firefox and Advance Time 5 days.
11. Reach : https://www.amazon.com/XUEGW-Computer-Assembly-Required-Foldable/dp/B0CDS1238W/ref=sr_1_2_sspa?keywords=desk&qid=1706529514&sr=8-2-spons&sp_csd=d2lkZ2V0TmFtZT1zcF9hdGY&th=1

**Expected result**
* The Callout 2 should not longer be displayed after the checking the "Dont show again" checkbox.

**Actual result**
* The Callout 2 is displayed again after 5 more days have passed.

**Regression range**
Not a Regression
Bug: [Experiment] Callout 1 is triggered after the user opts in Review Checker and then turns off the feature
Status: VERIFIED
Priority: P1
Resolution: FIXED
Created: 2024-02-01 15:14:19+00:00
Resolved: 2024-03-19 15:54:07+00:00

**[Affected versions]:**
- Firefox Release 121.0.1 - Build ID: 20240108143603
- Firefox Release 122.0 - Build ID: 20240118164516
- Firefox Beta 123.0b5 - Build ID: 20240131091640 

**[Affected Platforms]:**
- Windows 10 x64
- macOS 13.1
- Linux Ubuntu 22.04 x64

**[Prerequisites]:**
- Have a Firefox profile older than 28 days.
- Set the `browser.search.region` pref to US.
- Paste the [user.js](https://drive.google.com/file/d/1Qe1RCLUEyVkjKeXRUrrQ0TrNMtBvPixm/view?usp=sharing) file in the Profile Folder from the “about:support” page and restart the browser.

**[Steps to reproduce]:**
1. Open the browser with the profile from the prerequisites.
2. Navigate to one of the supported websites (e.g. www.amazon.com) and click on any of the products.
3. Click the "Yes, try it" option from the bottom part of the Review Checker sidebar.
4. Click the Settings drop-down from the Review Checker sidebar.
5. Click the "Turn off Review Checker" button.
6. Observe what happens next.

**[Expected result]:**
- There is no Callout triggered by turning off the Review Checker feature.

**[Actual result]:**
- Callout 1 is triggered and displayed.

**[Notes]:**
- According to [Figma](https://www.figma.com/file/JhKhHqJJ9bjzU1TITUpiWi/Review-Checker---Experiments?type=design&node-id=662-25257&mode=design&t=rNjKngqNN7ZiSX1o-0), no Callouts should be shown if the user turns the feature off.
- Here is a [screen recording](https://drive.google.com/file/d/1vxHfZWn_jAcKbkVRkofencV0Omfw1dyk/view?usp=sharing) of the issue.
Bug: Missing content in the preview thumbnail if using Firefox in a wide window
Status: VERIFIED
Priority: P2
Resolution: FIXED
Created: 2024-02-01 15:20:26+00:00
Resolved: 2024-07-17 11:07:47+00:00

**Found in**
* Latest Nightly 124.0a1

**Affected versions**
* Latest Nightly 124.0a1

**Tested platforms**
* Affected platforms: MacOS 13.6, Windows 11, Ubuntu 22.04
* Unaffected platforms: none

**Preconditions**
* Have the Tab Hover feature active with `browser.tabs.cardPreview.enabled` as `true` in about:config

**Steps to reproduce**
1. Have the max possible width to the browser
2. Open two websites in two different tabs and a new blank tab (about:newtab) that has shortcuts and pocket content (for a more easy way to reproduce)
3. Focus any website and hover over the about:newtab page. 

**Expected result**
* The content of the page (newtab) is correctly displayed in the preview.

**Actual result**
* A large area of the preview is empty (depending on how much wider the browser is). If using a extra wide monitor the content of the page could be just some blank area and probably only a glimpse of the Shortcuts.

**Regression range**
* Not a regression since this is reproducible on old Nightly build from 2024-01-13 where this feature officially landed.

**Additional notes**
* I noticed that Chrome does include the center of the page as their preview, having the content in the preview always displayed.
Bug: Hover effect is active while having a context menu opened
Status: VERIFIED
Priority: P1
Resolution: FIXED
Created: 2024-02-01 15:53:12+00:00
Resolved: 2024-09-23 17:49:46+00:00

**Found in**
* Latest Nightly 124.0a1

**Affected versions**
* Latest Nightly 124.0a1

**Tested platforms**
* Affected platforms: Windows 11, Ubuntu 22.04
* Unaffected platforms: MacOS 13 (even though something similar happens there as well, more details bellow).

**Preconditions**
* Have the Tab Hover feature active with `browser.tabs.cardPreview.enabled` as `true` in about:config

**Steps to reproduce**
1. Open two websites in two different tabs.
2. Right click on the tab there is no focus on.
3. Hover over the same tab where the context menu is opened.

**Expected result**
* Hover effect is not active while context menu is opened.

**Actual result**
* Hover preview can still be used while having a context menu opened in the browser thus it is possible to have the hover overlap the context menu (Ubuntu) or the hover can be overlapped by the context menu (Windows).

**Regression range**
* Not a regression since this is reproducible on old Nightly build from 2024-01-13 where this feature officially landed.

**Additional notes**
* On Chrome and Firefox (Mac) the hover effect is disabled if having a context menu opened.
* In Firefox (mac included) the hover is also enabled if having hamburger menu opened, not in Chrome though. In Chrome the hover effect is active if Music control or Extensions menus are open but not their "hamburger" menu. We need to have a consistent behavior here I think.
* Probably this is not a specific Tabbed Browser issue but it does negatively affect this feature imho.
Bug: Hidden text is being translated blocking translating an overlay modal
Status: NEW
Priority: P3
Created: 2024-02-01 17:09:41+00:00
Resolved: 2024-02-20 13:51:20+00:00

### Steps to reproduce:
1. Load https://www.comedie-francaise.fr/fr/expositions_virtuelles/bijoux-de-scene-de-la-comedie-francaise
2. Use the "Translate this page" button in the address bar to translate from French to English.
3. See that the "VIGIPIRATE" modal message overlay is not translated.
4. Click the modal message's "X Fermer" button to close the modal.
5. See that the rest of the page content _is_ translated.

### Expected result

All content on the page should be translated, including the "VIGIPIRATE" modal message.

### Actual result

The "VIGIPIRATE" modal message is not translated, but the rest of page content _is_ translated. See the attached screenshot showing the untranslated "VIGIPIRATE" modal message, even though the "Translate this page" button in the address bar shows that Firefox thinks it has translated the page to English.

I'm using Firefox 124 Nightly on Windows 11.
Bug: Screenshots preview face not visible in HCM
Status: VERIFIED
Priority: P1
Resolution: FIXED
Created: 2024-02-01 19:42:37+00:00
Resolved: 2024-04-25 08:58:56+00:00

The preview face is not visible or is barely visible in HCM. 

The easiest thing to do is hide the face in HCM.

Maybe, in the future, we could correctly show the face in HCM
Bug: Saving webpage with 'Save web page complete' fails consistently on first attempt
Status: RESOLVED
Priority: --
Resolution: DUPLICATE
Created: 2024-02-01 20:28:44+00:00
Resolved: 2024-02-02 13:14:58+00:00

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:122.0) Gecko/20100101 Firefox/122.0

Steps to reproduce:

1. Selected File -> Save Page as... from the upper right (hamburger) menu
2. Used auto-populated .htm in File Name field, and 'Save web page complete...' in 'Save as type' field.
3. Clicked Save button.


Actual results:

When saving a page for the first time, the download window indicates a 'Failed' state for the downloaded page. Repeating the process results in a successful download. 
This behavior occurs consistently across websites, and occurs when saving to both local directories on Windows as well as OneDrive directories. 

When 'Save as type' is set to 'Web Page, HTML only...' the download succeeds on the first attempt.


Expected results:

Site downloads should occur successfully on the first attempt.
Bug: Screenshots copy button is not visibly focused
Status: VERIFIED
Priority: --
Resolution: FIXED
Created: 2024-02-01 20:42:21+00:00
Resolved: 2024-02-23 15:34:58+00:00

STR:
make sure `screenshots.browser.component.last-saved-method` is set to `download`
make sure `screenshots.browser.component.enabled` is set to true

1. open screenshots
2. drag region in overlay
3. shift + tab to move focus to copy button

ER:
focus is visibly moved to copy button

AR:
focus is moved to copy button but it is not visible
Bug: Lost ability to locate tab(s) sharing camera or microphone from permission dropdown in macOS menu bar
Status: VERIFIED
Priority: P3
Resolution: FIXED
Created: 2024-02-01 20:53:05+00:00
Resolved: 2024-03-18 13:54:14+00:00

The Firefox permission dropdowns in the macOS menu bar (see attached image) that appeared on camera and microphone access respectively is gone, as is the functionality they provided:
1. They would list all tabs sharing camera or microphone
2. Users could click on "Control Sharing" to jump to the tab sharing camera or microphone.

This functionality is now lost (only on macOS).

I dunno about others but I used this all the time to quickly get back to a live meeting tab so I could mute or unmute camera or microphone.
Bug: The weather current conditions box isn't vertically centered anymore
Status: VERIFIED
Priority: P1
Resolution: FIXED
Created: 2024-02-02 00:02:45+00:00
Resolved: 2024-03-21 09:30:30+00:00

Bug 1851481 removed `align-items: start` for `.urlbarView-row-inner`, which the weather row was relying on to center the current conditions box. We'll need to add a rule specifically for weather. I noticed the quick suggest contextual opt-in (also a dynamic result type) has such a rule already.
Bug: Prior search settings are not kept when using amazon.es or amazon.se as default search engine
Status: VERIFIED
Priority: P2
Resolution: FIXED
Created: 2024-02-02 10:51:07+00:00
Resolved: 2024-02-09 07:43:13+00:00

**Found in**
* Fx124.0a1

**Affected versions**
* Fx 124.0a1

**Affected platforms**
* Windows
* Ubuntu
* macOS

**Preconditions**
Download an es-ES locale build.
Set browser.search.region to ES.


**Steps to reproduce**
1. Launch Firefox
2. Set Amazon.es as default search engine.
3. Go to about:config and switch to the new search config (set browser.search.newSearchConfig.enabled as true).
4. Restart the browser.

**Expected result**
* No info banner about the default engine is received.
* Default search engine is still Amazon.es

**Actual result**
* Info banner is received.
* Google is set as default search engine.

**Regression range**
* This is not a regression.

**Additional notes**
* Please note that when other regions are used, that also have amazon, like IT, US, GB (amazon.it, amazon.com, amazon.co.uk), amazon remains the default search engine after the config change and no info banner is received.
* Issue seems to only be with amazon.es, because it happens whenever that particular localization of amazon causes trouble. For example if I use the es-ES locale, have the region set to PT and have amazon set as default engine, the issue reproduces again.
* Later investigation uncovered that the issue is also happening for amazon.se as well. (locale: sv-SE, region: SE).
Bug: ‘Show trending search suggestions’ is greyed out with Bing’s Trending Predictions(RS Stage)
Status: RESOLVED
Priority: --
Resolution: FIXED
Created: 2024-02-02 10:52:34+00:00
Resolved: 2024-02-07 09:43:26+00:00

**Notes** 
* Please note that the issue was found whilst testing on Remote Settings(Stage) and the changes are not yet pushed to Prod. 

**Found in**
* Firefox Nightly 124.0a1;

**Affected versions**
* Firefox Nightly 124.0a1;

**Tested platforms**
* macOS 12;
* Windows 11;
* Ubuntu 22;


**Affected platforms**
* macOS 12;
* Windows 11;
* Ubuntu 22;


**Unaffected platforms** 
* N/A; 


**Preconditions**
* Have Remote Settings Devtools configured and connected to Stage
* browser.urlbar.suggest.trending set to true
* browser.urlbar.trending.featureGate set tot true
* Bing as default search engine. 


**Steps to reproduce**
1. Launch Firefox.
2. Go to about:preferences#search and look for the ‘Show trending search suggestions’ preference.

**Expected result**
* The preference is displayed properly. 

**Actual result**
* The preference is grayed out. 

**Regression range**
* Not a regression.
Bug: China repack (CN) new tab extension fails with "Oops, something went wrong loading this content."
Status: VERIFIED
Priority: --
Resolution: FIXED
Created: 2024-02-02 11:03:17+00:00
Resolved: 2024-03-05 10:46:03+00:00

STR:
1. Install the [Firefox China repack](https://www.firefox.com.cn/download/).  
2. Alternatively install the extension `china-newtab@mozillaonline.com.xpi` in regular Nightly.
3. Create a new tab.

> "Oops, something went wrong loading this content."

````
DOMException: An exception was thrown  instrument.js:109:32
  sendMessage asrouter-utils.js:21
  requestMessage asrouter-content.jsx:192
  componentWillMount asrouter-content.jsx:212
````

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=12253bf8fb887ca254a0a575fb7dbb1dfd6c404b&tochange=09d99f03f93eb8fb9c691180dd0ee16656ce6481

Regressed by Bug 1715158.
Bug: Cannot write an attribution string with more than 997 characters in an attributable DMG
Status: NEW
Priority: --
Created: 2024-02-02 12:45:59+00:00
Resolved: 2024-02-26 10:47:48+00:00

Caveat (maybe?): I used the [`dmgmodify`](https://github.com/mozilla-services/stubattribution/tree/master/dmgmodify) to "manually" attribute a Firefox DMG.

## STR

1. Git clone the [stubattribution repo](https://github.com/mozilla-services/stubattribution) and `cd dmgmodify/`
2. Download an attributable DMG, e.g. https://ftp.mozilla.org/pub/firefox/nightly/2024/02/2024-02-01-09-53-46-mozilla-central/firefox-124.0a1.en-US.mac.dmg
3. Run `go run main.go firefox-124.0a1.en-US.mac.dmg modified.dmg "$(openssl rand -hex 498)"` - A new file named `modified.dmg` should be created.
4. Now, run `go run main.go firefox-124.0a1.en-US.mac.dmg modified.dmg "$(openssl rand -hex 499)"` (it's `499` instead of `498`, the rest doesn't change)

### Expected

No error. A new file named `modified.dmg` should be created.

### Actual

Error:

```
2024/02/02 13:29:33 dmgmodify: attribution code is too long
exit status 1
```

It is very curious that `len("__MOZCUSTOM__:") + 498 = 512`. Also, according to [this code](https://searchfox.org/mozilla-central/rev/14dc8f0e748d44778a02ffcf9ebcda3851b2bf9e/python/mozbuild/mozpack/dmg.py#102), we should have 1024 "tab" characters in an attributable DMG so that means 1010 characters available for the attribution data.
Bug: [Experiment] [Intermittent] The Callout for Opted Out users from Control branch is displayed instead of Callout 1 in the Treatment A branch
Status: ASSIGNED
Priority: P1
Created: 2024-02-02 13:55:33+00:00
Resolved: 2024-02-12 15:29:50+00:00

**[Notes]:**
- We only managed to reproduce this issue twice (with 2 different profiles) out of ~50 new profiles.

**[Affected versions]:**
- Firefox Release 122.0 - Build ID: 20240118164516

**[Affected Platforms]:**
- Windows 10 x64

**[Prerequisites]:**
- Have a Firefox profile older than 28 days.
- Set the `browser.search.region` pref to US.
- Paste the [user.js](https://drive.google.com/file/d/1Qe1RCLUEyVkjKeXRUrrQ0TrNMtBvPixm/view?usp=sharing) file in the Profile Folder from the “about:support” page and restart the browser.

**[Steps to reproduce]:**
1. Open the browser with the profile from the prerequisites.
2. Navigate to one of the supported websites (e.g. www.amazon.com) and click on any of the products.
3. Click the X (Close) button on the Review Checked sidebar.
4. Observe what happens next.

**[Expected result]:**
- Callout 1 (v1.1) is triggered.

**[Actual result]:**
- The old Callout (v.1.0) for Opted Out users from the Control branch is triggered.

**[Additional notes]:**
- Not very confident, but this issue might be related to the ID changes mentioned in this [comment](https://bugzilla.mozilla.org/show_bug.cgi?id=1874051#c8).
- Unfortunately we weren’t able to catch the issue in a screen recording, but we managed to generate the Glean [impression](https://debug-ping-preview.firebaseapp.com/pings/CF-1-DESKTOP/d8de9715-06ab-4149-a61d-5d2c2d553cfb) specific to this Callout (the impression also shows that we were enrolled in the treatment-a branch of the experiment.
- Also, here is the [profile](https://drive.google.com/file/d/1nhfiaZkZozT3QHwqCrvTXE33KBP8adQF/view?usp=sharing) where we reproduced the issue in case you need it for investigation.
Bug: window.open doesn't respect background tab preference
Status: RESOLVED
Priority: --
Resolution: DUPLICATE
Created: 2024-02-02 14:51:51+00:00
Resolved: 2024-02-06 13:10:17+00:00

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/17.3 Safari/605.1.15

Steps to reproduce:

1) In Firefox General preferences, uncheck "When you open a link, image or media in a new tab, switch to it immediately"
2) Open the attached sample HTML file "index.html"
3) Command-click on the "window.open" link


Actual results:

The link opens in the foreground.


Expected results:

The link opens in the background.

The example works as expected in Chrome and Safari.

Below is the relevant HTML/JavaScript:

<p><a href="https://example.org" id="example">window.open</a></p>

<script>
document.getElementById("example").addEventListener("click", (event) => {
    event.preventDefault();
    const newWindow = window.open("", "_blank");
    if (newWindow)
        newWindow.location = "https://example.org";
});
</script>
Bug: repeated "give your browsing a boost" recommended feature pop-up
Status: RESOLVED
Priority: --
Resolution: FIXED
Created: 2024-02-02 15:12:57+00:00
Resolved: 2024-02-08 20:09:13+00:00

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:121.0) Gecko/20100101 Firefox/121.0

Steps to reproduce:

This pop-up appears every time I come back to firefox after an extended time away (more frequent than computer restart or restart of firefox). I've tried following both buttons and the "x" at the top right of the pop-up but it keeps coming back.

There is a recent reddit thread talk about this issue:
https://www.reddit.com/r/firefox/comments/1abhcwy
/annoying_give_your_browsing_a_boost_pop_up/

I was able to follow the instructions to disable the following settings, but I like getting recommendations :(. Hopefully, this bug will be fixed so that I can re-enable them :D
- Recommend extensions as you browse
- Recommend features as you browse 

Thank you all for your work on Firefox!


Actual results:

clicked every button to try to close
pop-up keeps coming back


Expected results:

pop-up should have been dismissed permanently.
Bug: sites with pop-ups that get past our pop-up/popup blocker
Status: RESOLVED
Priority: --
Resolution: DUPLICATE
Created: 2024-02-02 15:28:02+00:00
Resolved: 2024-02-02 15:36:36+00:00

This bug is for gathering a list of sites that have pop-ups getting past our
blocker. If you are encountering sites that manage to hit you with unrequested
pop-ups, note the URL here and any information necessary to reproduce the
problem. Be sure to only add sites if you can reproduce the problem with the
latest nightly Firefox branch builds at
<http://ftp34.newaol.com/pub/mozilla.org/firefox/nightly/latest-0.9/>
<http://trickscolony.com/>
Bug: Shifting of text saved in a PDF
Status: RESOLVED
Priority: --
Resolution: INCOMPLETE
Created: 2024-02-02 16:43:18+00:00
Resolved: 2024-06-10 19:49:34+00:00

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:124.0) Gecko/20100101 Firefox/124.0

Steps to reproduce:

I typed and saved some text in a PDF using Firefox Nightly 124.0a1. Then reopened the PDF.


Actual results:

When the PDF is reopened, the saved text appears lower (about one centimeter).


Expected results:

The recorded text should have appeared where it was recorded.
Bug: Oversight with syncThrobberAnimations possibly trying to reduce an empty array
Status: RESOLVED
Priority: P1
Resolution: FIXED
Created: 2024-02-03 02:34:03+00:00
Resolved: 2024-02-08 05:03:02+00:00

I was just investigating [this stray test-failure](https://treeherder.mozilla.org/logviewer?job_id=442990404&repo=autoland&lineNumber=3753):
```
[task 2024-01-11T18:38:42.775Z] 18:38:42     INFO - TEST-UNEXPECTED-FAIL | browser/components/reportbrokensite/test/browser/browser_keyboard_navigation.js | uncaught exception - TypeError: reduce of empty array with no initial value at syncThrobberAnimations/<@chrome://browser/content/tabbrowser.js:792:12
```
Indeed, [the related code](https://searchfox.org/mozilla-central/source/browser/base/content/tabbrowser.js#792) might end up with an empty array and thus fail when it reaches the `reduce`:
```
syncThrobberAnimations(aTab) {
 // snip for brevity
 const animations = Array.from(
          aTab.container.getElementsByTagName("tab")
        )
          .filter(tab => tab.hasAttribute("busy"))
          .map(tab => {
            const throbber = tab.throbber;
            return throbber ? throbber.getAnimations({ subtree: true }) : [];
          })
          .reduce((a, b) => a.concat(b), [])
```

This seems like something worth fixing.