av9ash/GitBugs huggingface dataset:
Bug: [foxfooding] The "Re-analyze reviews" UI changes to say "Analysis coming soon" even though no analysis is actually being done (if you don't click the second button on the fakespot landing page)
Status: RESOLVED
Priority: --
Resolution: DUPLICATE
Created: 2023-09-05 20:12:53+00:00
Resolved: 2024-05-29 15:52:09+00:00

STR:
1. Activate the pref for the "Review quality check" shopping experience, and activate it by visiting some product page that triggers the UI, and clicking "Try it"
2. Find a product page that makes our sidebar show the yellow "Re-analyze the reviews" box.
3. Click the link in the sidebar to re-analyze the reviews.
4. This opens a Fakespot tab with another button that you could click (but don't click it!!!) labeled "reanalyze."
5. Switch back to the tab that had the product and the shopping sidebar.

ACTUAL RESULTS:
- As far as I can tell, no analysis is done until/unless I click the button **on the fakespot site**.
- Despite that, our sidebar UI changes to say:
```
Analysis coming soon
When it’s done, we’ll automatically show the updated info here.
```
This analysis never completes (because in fact it never started). This inaccurate UI remains in-place if I reload the page, too. (But it resets to the yellow "re-analyze the reviews" UI if I duplicate the tab, in the sidebar-within-the-new-duplicate-of-the-tab.)

EXPECTED RESULTS:
- The single click should be enough to kick off the analysis.
- Our UI shouldn't change to say "Analysis coming soon" until/unless we're sure that analysis is actually in progress.
Bug: [foxfooding] Inconsistent hyphenation of "Re-analyze" vs. "Reanalyze" in Firefox UI vs. Fakespot site
Status: RESOLVED
Priority: --
Resolution: FIXED
Created: 2023-09-05 20:18:33+00:00
Resolved: 2024-05-29 15:52:09+00:00

STR, similar to bug 1851680:
1. Activate the pref for the "Review quality check" shopping experience, and activate it by visiting some product page that triggers the UI, and clicking "Try it"
2. Find a product page that makes our sidebar show the yellow "Re-analyze the reviews" box.
3. Click the link in the sidebar to re-analyze the reviews.
4. This opens a Fakespot tab with another button labeled "Reanalyze."

ACTUAL RESULTS:
We've got a hyphen in "Re-analyze" in the Firefox UI, vs. no hyphen on the fakespot landing page (the button there is called "Reanalyze" with a label saying "Please reanalyze.")

EXPECTED RESULTS:
Consistent hyphenation/spelling throughout the user flow.
Bug: MozLitElement leaks render roots for subclasses that are added and removed to the DOM
Status: RESOLVED
Priority: --
Resolution: FIXED
Created: 2023-09-05 20:36:19+00:00
Resolved: 2023-09-15 18:09:26+00:00

I think this is the cause for the leak that jsudiaman is running into in bug 1849124.

Most of our LitElements inherit from MozLitElement, which is defined here: https://searchfox.org/mozilla-central/rev/b6cd901cf074c5e75e3902d660bafa3cf3967c40/toolkit/content/widgets/lit-utils.mjs#84-126

one of the things that MozLitElement does is provide Fluent support for subclasses. It does this by connecting the render root in the override for `connectedCallback`: https://searchfox.org/mozilla-central/rev/b6cd901cf074c5e75e3902d660bafa3cf3967c40/toolkit/content/widgets/lit-utils.mjs#110

It looks like when one connects a render root, [it's added to a hashmap and a mutation observer is attached to it](https://searchfox.org/mozilla-central/rev/b6cd901cf074c5e75e3902d660bafa3cf3967c40/dom/l10n/DOMLocalization.cpp#123,125). The hashmap [appears to hold a strong reference to the render root](https://searchfox.org/mozilla-central/rev/b6cd901cf074c5e75e3902d660bafa3cf3967c40/dom/l10n/DOMLocalization.h#132).

I believe this means that if many MozLitElement's are added and removed from the DOM, they'll be considered "orphaned", and kept alive off of the DOMLocalization window object.

I can observe this by hacking history.mjs to create many thousand card-container elements, and then switching back and forth between History and Recent Browsing in Firefox View. Then I go to about:memory, minimize memory usage, and take a memory snapshot. I see many megabytes of orphan nodes reported after these STR.

There's a `disconnectRoot` that I believe we're supposed to call if an item translated with Fluent is removed from the DOM: https://searchfox.org/mozilla-central/rev/b6cd901cf074c5e75e3902d660bafa3cf3967c40/dom/webidl/DOMLocalization.webidl#54-58

We do this in places like this: https://searchfox.org/mozilla-central/rev/b6cd901cf074c5e75e3902d660bafa3cf3967c40/toolkit/mozapps/extensions/content/aboutaddons.js#968-970

I suspect we should do the same thing here for MozLitElement. This also means that all subclasses of MozLitElement should make sure to call `super.disconnectedCallback()`.
Bug: [foxfooding] Two shopping cart icons in URL bar, if you use "shopping tab" (from Firefox Containers extension) together with Review quality check
Status: RESOLVED
Priority: --
Resolution: DUPLICATE
Created: 2023-09-05 20:51:24+00:00
Resolved: 2024-05-29 15:52:09+00:00

STR:
1. Enable the Review Quality Check feature.
2. Install [Firefox Multi-Account Containers](https://addons.mozilla.org/en-US/firefox/addon/multi-account-containers/)
3. Open a new "Shopping" tab (File | New Container Tab | Shopping)
4. Visit some product page at e.g. Best Buy or Amazon in that Shopping Tab.

ACTUAL RESULTS:
Two identically-shaped shopping-cart icons (one pink, one orange) show up side by side in the URL bar, with a "Shopping" badge from Container tabs.

EXPECTED RESULTS:
Better integration between these features; no duplicative/confusable UI buttons (particularly side-by-side).
Bug: Menus from menubar have inappropriately rounded corners and poor highlight behavior
Status: RESOLVED
Priority: P3
Resolution: FIXED
Created: 2023-09-05 21:03:34+00:00
Resolved: 2023-10-09 12:38:08+00:00

When a menu is opened from the Firefox menu bar (_e.g._, by pressing `Alt + F`), it's styled inappropriately: the menu dropdown will have rounded corners, and the highlight on the top and bottom item leaves an odd corner-radius-sized gap between the menu's vertical edge and the highlight's vertical edge.

The rounded corners are unlike the usual styling on Windows 10, where menus are entirely rectangular. They're also not quite consistent with the styling of Windows 11 menus, as menu corners are typically rounded there iff menubar _items_ are also rounded.

This can also be seen on right-click context menus: rounded corners are probably reasonable there, but the highlight gap is still present.

----

Note that this doesn't apply to the app menu (a product decision, described in bug 1697910):
* The app menu does have rounded corners; but the app-menu button itself also has rounded corners (visible when the app-menu is open), so there is no local inconsistency.
* The app menu's item-highlights are themselves rounded and offset from the edges; the extra space at the top and bottom does exist, but is much less glaring.
Bug: Zooming is broken
Status: RESOLVED
Priority: --
Resolution: DUPLICATE
Created: 2023-09-05 21:11:55+00:00
Resolved: 2023-09-07 03:50:23+00:00

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/113.0.5666.197 Safari/537.36

Steps to reproduce:

https://bugzilla.mozilla.org/show_bug.cgi?id=1138704


Actual results:

Nothing at all. For almost a decade.


Expected results:

This should have been fixed. Just make ctrl+scrollup call the same function as ctrl+plus, and likewise for ctrl+scrolldown and ctrl+minus. It's been NINE YEARS to copypaste two lines of code, I guess this 'fell through the cracks' and got forgotten somehow but I'm here to bring attention back to it.
Bug: The chevron button in shopping-details summary is not labeled
Status: VERIFIED
Priority: P1
Resolution: FIXED
Created: 2023-09-06 01:14:01+00:00
Resolved: 2023-09-28 14:54:09+00:00

### Preconditions:
- Set the `browser.shopping.experience2023.enabled` - `TRUE`
- Set the `browser.shopping.experience2023.optedIn` - `1`
- Enable a screen reader, i.e. NVDA on Windows

### STR:
1. Reach the following links https://www.amazon.com/dp/B07V6ZSHF4?th=1
2. Hover the mouse cursor over either `How we determine review quality` chevron button or `Settings` chevron button
3. Navigate to the  `How we determine review quality` collapsed button (i.e. by using `Tab`), then press `DownArrow` to hear the announcement for the chevron button. Repeat for `Settings` chevron button

### Expected:
- The label (adjacent text) should be read out loud by NVDA alongside the role of the button
- Either the chevron button is not announced by a screen reader (because the label, role, and state are already announced by the focusable `<summary>` element) or the button provides a meaningful label

### Actual:
- The button is not announced by a screen reader.
- When navigated to in browsing mode, an extra control is announced as `button, collapsed, button`
Bug: The search bar, bookmarks bar, and Tab bar are all white, even in dark mode.
Status: RESOLVED
Priority: --
Resolution: WORKSFORME
Created: 2023-09-06 03:36:20+00:00
Resolved: 2023-11-08 19:30:26+00:00

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/117.0

Steps to reproduce:

 I signed in on a macbook, and changed my password. This required me to log back in on my desktop (windows10).


Actual results:

The bars were white, even in dark mode.


Expected results:

They should also be dark
Bug: Some permissions not prompting user in Private Browsing
Status: RESOLVED
Priority: P2
Resolution: DUPLICATE
Created: 2023-09-06 10:59:35+00:00
Resolved: 2023-10-25 15:51:05+00:00

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/117.0

Steps to reproduce:

Trying a website that prompts for a user permission such as Notifications, for example on https://permission.site does not ask to prompt the user when in Private Browsing, it declines the permission all the time.
It correctly asks me to allow or block notifications on normal (Non-Private Browsing) mode.


Actual results:

Automatically denies the permission request for the site.


Expected results:

Prompts the user to allow or block the permission.
Bug: Incorrect message appears after importing an invalid credit card number
Status: NEW
Priority: P3
Created: 2023-09-06 11:48:45+00:00
Resolved: 2023-09-11 15:20:12+00:00

*Found in*

118.0b5

*Affected versions*

118.0b5

*Tested platforms*

Affected platforms: macOS 13
Unaffected platforms:

*Preconditions*

1 valid credit card and 1 invalid credit card saved in Chrome

*Steps to reproduce*

1. Open Fx 
2. Click on  Import data button from about:preferences

*Expected result*
Only 1 credit card(the valid one) is imported, so after the import is done the message should appear for 1 credit card not two.

*Actual result*
After the import is done the message should appear for 1 credit card not two.

*Regression range*

Not a regression. Reproducible with bug 1826149 after Payment methods were implemented.
Additional notes

Attached browser console errors.
Bug: Incorrect message appears after importing an invalid credit card number
Status: RESOLVED
Priority: --
Resolution: DUPLICATE
Created: 2023-09-06 11:49:01+00:00
Resolved: 2023-09-06 15:24:19+00:00

*Found in*

118.0b5

*Affected versions*

118.0b5

*Tested platforms*

Affected platforms: macOS 13
Unaffected platforms:

*Preconditions*

1 valid credit card and 1 invalid credit card saved in Chrome

*Steps to reproduce*

1. Open Fx 
2. Click on  Import data button from about:preferences

*Expected result*
Only 1 credit card(the valid one) is imported, so after the import is done the message should appear for 1 credit card not two.

*Actual result*
After the import is done the message should appear for 1 credit card not two.

*Regression range*

Not a regression. Reproducible with bug 1826149 after Payment methods were implemented.
Additional notes

Attached browser console errors.
Bug: Incorrect confirmation message appears after importing an invalid credit card number
Status: NEW
Priority: P3
Created: 2023-09-06 11:49:03+00:00
Resolved: 2023-09-14 16:00:57+00:00

*Found in*

118.0b5

*Affected versions*

118.0b5
117.0
119.0a1(2023-09-06)

*Tested platforms*

Affected platforms: macOS 13
Unaffected platforms:

*Preconditions*

1 valid credit card number and 1 invalid credit card number saved in Chrome

*Steps to reproduce*

1. Open Fx 
2. Open the migration window from about:preferences and import Payment data.

*Expected result*
Only 1 Payment methods(the valid credit card number) is imported, so after the import is done the confirmation message should appear for 1 Payment methods instead of two.

*Actual result*
After the import is done the confirmation message is displayed for 2 Payment methods(for both valid and invalid credit cards number) imported.

*Regression range*

Not a regression. 

*Additional notes*

Attached browser console errors.
Bug: [Experiment] The MicroSurvey options from the treatment B branch of the experiment are displayed in an incorrect order
Status: VERIFIED
Priority: --
Resolution: FIXED
Created: 2023-09-06 12:22:51+00:00
Resolved: 2023-10-23 12:36:29+00:00

**[Affected versions]:**
- Firefox Release 117.0 - Build ID: 20230824132758

**[Affected Platforms]:**
- Windows 10 x64
- macOS 13.4.1
- Linux Mint 21.1 

**[Prerequisites]:**
- Have `nimbus.debug` pref set to `true` in the “about:config” page

**[Steps to reproduce]:**
1. Open the browser using the profile from prerequisites.
2. Navigate to the following link: “about:studies?optin_slug=newtab-pocket-topics-microsurvey&optin_branch=treatment-b&optin_collection=nimbus-preview”.
3. Open a new tab.
4. Observe the order of MicroSurvey options.

**[Expected result]:**
- The correct order of the radio button options is as follows:
  - Topics I choose
  - All available topics
  - No preference / I don’t know

**[Actual result]:**
- The current order for the radio button options is the following one:
  - No preference / I don’t know
  - Topics I choose
  - All available topics

**[Notes]:**
- According to the received “Documentation”, the correct order for the radio button options is: “Topics I choose”, “All available topics”, “No preference / I don’t know”.
- Attached is a screenshot of the issue:
Bug: Every few minutes, all tabs on all windows refresh and it slows down everything
Status: RESOLVED
Priority: --
Resolution: INVALID
Created: 2023-09-06 13:26:02+00:00
Resolved: 2023-09-07 07:49:54+00:00

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:109.0) Gecko/20100101 Firefox/117.0

Steps to reproduce:

Nothing, I am simply browsing as I always do.


Actual results:

Every few minutes, all tabs on all windows refresh and it slows down everything. It is not as a reaction to a button I press because sometimes it happens when I'm afk.


Expected results:

It should not refresh every few minutes
Bug: Most recent folder used for downloading not used as expected
Status: RESOLVED
Priority: --
Resolution: INCOMPLETE
Created: 2023-09-06 13:43:23+00:00
Resolved: 2023-12-11 12:10:15+00:00

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/117.0

Steps to reproduce:

ファイルをダウンロードする
Download the file


Actual results:

ダウンロードするファイルの拡張子や種類によって、直前に保存したフォルダではなく、その前に保存したフォルダが表示されてしまう。
Depending on the extension and type of the file being downloaded, the previously saved folder may be displayed instead of the most recently saved folder.


Expected results:

直前にダウンロードしたフォルダを表示するべき
should show the folder you just downloaded
Bug: Use chrome font sizes instead of in-content sizes
Status: RESOLVED
Priority: P2
Resolution: FIXED
Created: 2023-09-06 14:55:42+00:00
Resolved: 2023-10-16 18:58:51+00:00

This may be tricky because the sidebar with is a fixed number of pixels, but the chrome font size varies across platforms (11px on Mac, 12px on Windows, some huge number on Ubuntu).

As part of this discussion, we might want to switch the sidebar width to a value relative to the size of the font (subject to some max-width, presumably?).
Bug: Adjust card borders and shadows
Status: RESOLVED
Priority: P1
Resolution: FIXED
Created: 2023-09-06 14:55:55+00:00
Resolved: 2023-09-08 03:50:14+00:00

The UX folks would like for the border and shadow around the sidebar cards to look, essentially, like the cards in firefox view, which seem to apply these styles: https://searchfox.org/mozilla-central/source/browser/components/firefoxview/card-container.css
Bug: Unanalyzed product card is always displayed for Amazon 404 pages
Status: NEW
Priority: P3
Created: 2023-09-06 15:51:58+00:00
Resolved: 2023-10-25 14:33:02+00:00

Copying some observations I made of the 404 Amazon pages from Slack.

Sample link of a product that I think _used to be available_ on amazon.com: https://www.amazon.com/SAMSUNG-Smartwatch-Personalized-Advanced-Coaching/dp/B0CCQP6MGF?th=1&psc=1

Link of a _non-existant_ product on amazon.com (available in amazon.de): https://www.amazon.com/dp/B013JJLDC2

Observations:
Using the link of the non-existant product, the unanalyzed product card + run analysis link is displayed on the sidebar since this product technically hasn’t been analyzed before. On the other hand, since the product doesn’t exist, we can’t actually analyze it. The in-progress card ends up running for 5 mins due to our current implementation of polling, and then the unanalyzed product card + analysis link appears again.

Maybe UX will be better once we update the analysis flow via an `isAnalysisInProgress` type attribute passed by the API?

Also, the [product not available](https://www.figma.com/file/Wu4kaHSfKSQnzkym7qek3R/Review-Checker-Spec?node-id=2530%3A87538&mode=dev) message does _not_ appear because that message relies on the boolean attribute `deleted_product` passed by the API. It seems that we only get null data (`rating`, `product_id`, `grade`) except for `needs_analysis: true` , which is the configuration we use to identify a yet-to-be analyzed product (hence showing the unanalyzed product card).

I haven't tested the sidebar with the first link (product used to be available), but I assume that it would behave similarly.
Bug: Sidebar icons are not centred
Status: VERIFIED
Priority: P3
Resolution: FIXED
Created: 2023-09-06 17:06:48+00:00
Resolved: 2023-10-04 07:37:15+00:00

The icons that are shown in the sidebar are in a 20x20 bounding box, but the icons are aligned to the top-left instead of the centre of the bounding box. This makes it so the icons that don't go outside of the bounds are too far to the top-left of the icon area, rather than being centred.

The .svg icons themselves need to be updated to centre the icon within its bounding box, either by making some 16x16 and some 20x20 (and updating the CSS to handle that), or by shifting the 16x16 ones to be centred in the icon (likely need a designer for this)
Bug: Re-enable test_settings_toggle_ad_and_multiple_tabs test post-119
Status: RESOLVED
Priority: P1
Resolution: FIXED
Created: 2023-09-06 19:19:52+00:00
Resolved: 2023-10-11 21:23:13+00:00

The test_settings_toggle_ad_and_multiple_tabs test in the `browser_shopping_settings.js` test is broken, and since it's exercising ads-related behavior, I'm disabling it temporarily. We'll want to re-enable when we plan to turn ads back on.
Bug: Fix annoying error logs from tests: "Resolver error: Unknown variable: $retailer"
Status: RESOLVED
Priority: --
Resolution: WONTFIX
Created: 2023-09-06 19:24:26+00:00
Resolved: 2023-09-06 23:08:41+00:00

Bug 1847307 made the retailer name dynamic in the explainer component, but the mock data hasn't been updated to make this work; the tests throw a lot of errors of the form

```
JavaScript error: , line 0: InvalidStateError: [fluent][resolver] errors in en-US/shopping-analysis-explainer-highlights-description: Resolver error: Unknown variable: $retailer
```

however, these errors don't cause the tests to fail, and the component renders correctly. This bug tracks deferred cleanup until after 119 ships.
Bug: [Experiment] The offline translation feature does not work for profiles that never translated any language online at least once
Status: NEW
Priority: --
Created: 2023-09-07 09:21:46+00:00
Resolved: 2023-09-07 09:21:46+00:00

**[Affected platforms]:**
- Windows 10 x64
- macOS 13.4.1
- Linux Mint 21.2

**[Prerequisites]:**
- Create a new profile or use an old one that has never used the translation feature online(while having an active internet connection).
- Be enrolled in the experiment by setting “nimbus.debug” to “true” in about:config then copy>pasting this link in the address bar: about:studies?optin_slug=fullpage-translations&optin_branch=treatment-a&optin_collection=nimbus-preview

**[Steps to reproduce]:**
1. Open the browser.
2. Navigate to Settings > Language and Appearance > Translations.
3. Download any available offline translation module.
4. Open any page that is in the language of the module downloaded at step 3.
5. Lose internet connection on the testing device in any way (such as unplugging the ethernet cable or turning off WiFi).
6. Click the translate icon from the address bar and translate the page with the autodetected languages.
7. Observe the behavior.

**[Expected result]:**
- The page is properly translated offline, since the corresponding language module for offline translation was downloaded beforehand.

**[Actual result]:**
- The page is not translated. “There was a problem translating. Please try again” error is displayed.

**[Notes]:**
- The issue no longer reproduces if the user uses the translate feature at least once while being online (having active internet connection): if after step 4 the user goes to any page (even if it’s in a different language than what was selected at step 3) and translates the page, the issue no longer reproduces and offline translation works as expected;
- Due to the nature of the steps to reproduce, this issue is likely to be encountered only by users with (new or old) profiles that never used the translation feature online and try to use the feature in offline mode first.
Bug: [Caret browsing] Caret is misaligned on checkboxes in about:preferences
Status: VERIFIED
Priority: --
Resolution: FIXED
Created: 2023-09-07 12:39:49+00:00
Resolved: 2023-12-19 16:37:41+00:00

So I thought the custom checkbox styling messed with the caret positioning when caret browsing is enabled in about:preferences. But from what I've seen, removing the custom styling doesn't fix the caret, so there seems to be something broken on a more fundamental level.

(Anecdotally, caret browsing mode is something that users end up enabling unintentionally, which is a separate problem that we should probably look into at some point.)
Bug: Firefox Translation deletes code blocks
Status: RESOLVED
Priority: --
Resolution: FIXED
Created: 2023-09-07 13:13:51+00:00
Resolved: 2023-12-13 13:44:06+00:00

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/119.0

Steps to reproduce:

* open https://forums.archlinux.fr/viewtopic.php?p=176719#p176719
* translate it from French to English


Actual results:

The code in code blocks disappears (except the last block).


Expected results:

Code remains there.
Bug: Exceptions list in dialog has no minimum height and can appear empty in small windows
Status: VERIFIED
Priority: P3
Resolution: FIXED
Created: 2023-09-07 15:34:13+00:00
Resolved: 2023-10-17 10:23:41+00:00

STR:
1. Open `about:preferences#privacy`.
2. Reduce the height of the window to less than 450px.
3. Click any of the Exceptions buttons.

Expected:
Exceptions list has enough height to be visible and scrollable.

Actual:
Exceptions list has no height and appears empty.

#permissionsBox richlistbox has 0px height.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=c3037ba20d8b6200b240e4025a86855b74741a52&tochange=b68ba468c8215e516b1a0f00509bd70c857fd518

Regressed by Bug 1822453.