av9ash/GitBugs huggingface dataset:
Bug: Top Site URL validation is broken
Status: NEW
Priority: --
Created: 2023-07-30 21:20:45+00:00
Resolved: 2023-08-14 12:13:21+00:00

I was reviewing the Top Sites change in bug 1838646 (RFE to add `file:` support) and found that the existing code was already a broken foundation to begin with. There appears to have been a real concern about getting schemeless urls and fixing them up by adding "http://". But most of the checks are done on strings and, as usually happens when you do that, gets things really muddled by having a simplistic view of URLs.

Do we really need to worry about schemeless URLs? What happens if you don't call cleanURL() everywhere? Or even anywhere? Won't those URLs simply break and users will then fix them? It looks like the top sites are mostly coming from history—shouldn't they be well-formed already? (some might have protocols we want to exclude, sure) If we only have to worry about the user-edited ones then stop babysitting them: return an error until they enter a valid URL with one of the protocols we accept (currently http: and https:, which seems perfectly reasonable and safe to me).

More details in my [comment](https://phabricator.services.mozilla.com/D184802#6112744) in D184802, but visible brokenness can be seen when you try to edit a Top Site to replace its URL:
* Doesn't add http: when it "should": `localhost:8080/path/file.html` is interpreted as having the protocol "localhost:" and rejected before the "add `http://`" cleanUrl() is called.
* Adds http: when it shouldn't: `https;//foo.com/path/file` doesn't appear to have a protocol because of the typo semi-colon,  but instead of calling it an invalid URL we run it through cleanUrl() and get the no-less-broken `http://https;//foo.com/path/file`

We shouldn't be trying fix-up here. Unlike fix-up in the URL-bar, the user doesn't immediately see the result and the source of the wrongness might not be apparent to them. If we're going to do fix-up we cannot do simplistic string operations as this code tries to do. Instead we should do the same fix-up the URL-bar does so future bug fixes or new protocol handling don't diverge. That could be problematic, though, because it looks like this code is not privileged.
Bug: XSS attack vector about:logo
Status: RESOLVED
Priority: --
Resolution: INVALID
Created: 2023-07-30 22:03:46+00:00
Resolved: 2023-07-31 19:23:41+00:00

Steps to reproduce:

Go to https://flemingink.com/1992.html


Actual results:

Internal Firefox logo is rendered using
<IMG SRC="about:logo"><BR>


Expected results:

Internal images should be blocked to prevent XSS vector attacks
Bug: Only allow supported image types when selecting an image in the stamp annotation
Status: RESOLVED
Priority: P1
Resolution: FIXED
Created: 2023-07-31 08:41:00+00:00
Resolved: 2023-08-02 13:53:42+00:00

We must only support the image types supported by Firefox:
https://developer.mozilla.org/en-US/docs/Web/Media/Formats/Image_types
For example it doesn't make sense to have tiff files when Firefox isn't able to display them.
Bug: https://beyondpesticides.org/dailynewsblog/category/chemicals/pendimethlin/
Status: RESOLVED
Priority: --
Resolution: INVALID
Created: 2023-07-31 09:09:45+00:00
Resolved: 2023-08-02 03:24:10+00:00

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/115.0

Steps to reproduce:

Go to 

https://beyondpesticides.org/dailynewsblog/category/chemicals/pendimethlin/




Actual results:

Page is immediately unusable on the latest Firefox. The "Resources" tab at the top of the page

https://www.beyondpesticides.org/resources/beyond-pesticides-resources

immediately hangs down with the entire list all over the page,  rendering the page unusable. Attempt to scroll down ends up having the menu follow you down the page. Nothing gets rid of it. Also fails in Opera and Chrome. 

WORKS ONLY IN INTERNET EXPLODER! 

Also I have found other pages with this exact same issue. They also only work in Internet Exploiter and fail in Firefox, Opera, and Chrome.

Culprit appears to be a failing Javascript, but what do I know?


Expected results:

The menu should not drop down unless I click on it and if I click away from it, it should go away.
Bug: Malicious website, using the debugger keyword to prevent viewing html elements
Status: RESOLVED
Priority: --
Resolution: DUPLICATE
Created: 2023-07-31 09:34:54+00:00
Resolved: 2023-07-31 23:41:57+00:00

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/115.0

Steps to reproduce:

1. open the  web developer tools
2. access this site for example:  https://www.dianyingim.com/
3. you will find harder to render or check the html element.


Actual results:

You will find this site is using random rendering js with  debugger keyword to block rendering html elements to block you to see the html elements.


Expected results:

I didn't find anywhere that I can block Debugger tabs or disable debugger keywords functions that I can use. 

I try multi ways like  using about:config to block all the debugger views or similar things.

Cloud we add some features that block website doing such things.
Bug: Open Tabs should not be affected when a user changes privacy setting to "Never remember history"
Status: VERIFIED
Priority: P1
Resolution: FIXED
Created: 2023-07-31 10:47:46+00:00
Resolved: 2023-10-05 08:04:40+00:00

**Affected versions**
* Nightly 117.0a1

**Affected platforms**
* Windows 10x64, macOS 13 and Ubuntu

**Steps to reproduce**
1. Go to about:config and  flip browser.tabs.firefox-view-next to true
2. Go to about:preferences#privacy and set History to "Never remeber" or Use custom settings with Always use private browsing mode checked
3. Open Firefox View Next tab with Recent Browsing page focused
4. Observe the Open tabs 

**Expected result**
* Open Tabs has View All link when setting history to "Never remember history"/"Use custom" with Always use private browsing


**Actual result**
* Open Tabs View All links shouldn't be displayed when user sets history to "Never remember history"/"Use custom" with Always use private browsing


**Regression range**
* New feature

**Additional notes**
* See attached screenshot
Bug: Closing multiple tabs does not reflect in the Open tabs Window card, Show more/Show less button is still displayed
Status: RESOLVED
Priority: --
Resolution: WORKSFORME
Created: 2023-07-31 11:20:05+00:00
Resolved: 2023-08-03 09:52:29+00:00

**Affected versions**
* Firefox Nightly 117.0a1

**Affected platforms**
* Windows 10x64


**Steps to reproduce**
1. Launch Firefox with browser.tabs.firefox-view-next set to true
2. Open a few new windows with various websites opened in tabs
3. Focus Firefox View Next Open tabs page
4. Select a few tabs and close them
5. Return to Open Tabs page and click on the "Show more" link for the window for which tabs were closed

**Expected result**
* "Show more" link should not be still displayed for the Open tabs window card if no other tabs are open

**Actual result**
* Closing multiple tabs does not reflect in the Open tabs Window card, Show more/Show less button is still displayed

**Regression range**
* New Feature

**Additional notes**
* See attached gif
Bug: Tab key navigation does not work for Show more button Open tabs
Status: VERIFIED
Priority: --
Resolution: FIXED
Created: 2023-07-31 12:12:26+00:00
Resolved: 2023-10-06 10:12:17+00:00

**Affected versions**
* Nightly 117.0a1

**Affected platforms**
* Windows 10x64, Ubuntu 18.4, macOS 13

**Steps to reproduce**
1. Launch Firefox and focus the Open tabs page in Firefox View Next
2. Open a few new windows with different websites loaded in tabs
3. Using the Tab key navigate the Open tabs page to reach the View more link at the bottom of the window card

**Expected result**
* Tab key navigation to Show more link should be possible

**Actual result**
* Tab key navigation does not work for Show more button Open tabs

**Regression range**
* New implementation
Bug: Editing autocompleted domains in URL bar is broken
Status: VERIFIED
Priority: P2
Resolution: FIXED
Created: 2023-07-31 13:16:03+00:00
Resolved: 2023-08-11 07:39:48+00:00

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/117.0

Steps to reproduce:

Suppose that you want to go to "amazonaws.com" and take advantage of the autocompletion "amazon.com".

1. Begin typing a domain in the URL bar: "ama"
2. Verify that the domain is autocompleted to "amazon.com/"
3. Press right arrow to accept the autocompletion, then press the left arrow until the cursor is right at the end of the word "amazon"
4. Type "aws"


Actual results:

The autocompletion, as well as the first letter "a", disappears: I see "ama". If I continue typing, characters after the first will be appended. The final result is "amaws".


Expected results:

The final result is "amazonaws.com/"
Bug: The “Thanks for your feedback” message is not aligned with the Address Bar results
Status: VERIFIED
Priority: P1
Resolution: FIXED
Created: 2023-07-31 16:11:20+00:00
Resolved: 2024-02-19 17:14:15+00:00

**[Affected versions]:**
- Firefox Nightly 117.0a1 - Build ID: 20230730210800

**[Affected Platforms]:**
- Windows 10 x64
- Linux Ubuntu 20.04 x64
- macOS 12.6.1

**[Prerequisites]:**
- Set `browser.urlbar.pocket.featureGate` to “true”.
- Set `browser.urlbar.bestMatch.enabled` to “true”.
- Set `browser.search.region` to “US”.

**[Steps to reproduce]:**
1. Open the browser with the profile from the prerequisites.
2. Type “breakfast” in the Address Bar.
3. Click the “Feedback” button from the Pocket suggestion.
4. Click the “Show less frequently” option.
4. Observe the message that appears under the Pocket suggestion.

**[Expected result]:**
- The Firefox logo and text of the message are correctly aligned with the rest of the favicons and results.

**[Actual result]:**
- The Firefox logo and text of the message are not aligned with the rest of the favicons and results.

**[Notes]:**
- The issue is not reproducible on Firefox Beta 116 (Build ID: 20230724170120)
- Attached is a screenshot of the issue.
Bug: There is a size inconsistency between history/bookmarked/switch to tab and suggestion results favicons
Status: VERIFIED
Priority: P1
Resolution: FIXED
Created: 2023-07-31 16:11:23+00:00
Resolved: 2023-08-11 11:25:22+00:00

**[Affected versions]:**
- Firefox Nightly 117.0a1 - Build ID: 20230730210800
- Firefox RC 116 - Build ID: 20230724170120

**[Affected Platforms]:**
- Windows 10 x64
- Linux Ubuntu 20.04 x64
- macOS 12.6.1

**[Prerequisites]:**
- Set `browser.urlbar.pocket.featureGate` to “true”.
- Set `browser.urlbar.bestMatch.enabled` to “true”.
- Set `browser.search.region` to “US”.

**[Steps to reproduce]:**
1. Open the browser with the profile from the prerequisites.
2. Type “breakfast” in the Address Bar.
3. Click the “Cat Cora” Pocket suggestion.
4. Open a new tab and type “breakfast” in the Address Bar.
4. Observe the favicons of the results displayed in the Firefox Suggest section.

**[Expected result]:**
- Both Pocket favicons are the same size.

**[Actual result]:**
- The Pocket favicon of the “Switch to tab” result is bigger than the Pocket suggestion’s favicon.

**[Notes]:**
- Attached is a screenshot of the issue.
Bug: PDF does not render image on title page correctly
Status: RESOLVED
Priority: --
Resolution: FIXED
Created: 2023-07-31 17:47:42+00:00
Resolved: 2023-12-07 08:57:35+00:00

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/115.0

Steps to reproduce:

1. Acquire "Programming Rust" first edition pdf (from previous humble bundle)
2. Open pdf in firefox



Actual results:

Document opens, but cover page is missing the Montagu’s crab on the front cover; instead only a couple lines of the image show up.


Expected results:

Cover should render image of Montagu's crab correctly.
Bug: Tab syncing broken on Nightlies
Status: VERIFIED
Priority: --
Resolution: FIXED
Created: 2023-07-31 20:23:42+00:00
Resolved: 2023-08-10 16:12:04+00:00

No tabs will be uploaded from Nightlies since bug 1840044 landed. That bug is only indirectly responsible though - it's the new application-services which caused the regression. The fix will be another update to app-services.
Bug: In redesigned Firefox View, "Show all history" is adjacent to bottom of the viewport and hard to read/click as a result
Status: RESOLVED
Priority: --
Resolution: DUPLICATE
Created: 2023-08-01 00:08:33+00:00
Resolved: 2023-08-07 19:34:06+00:00

STR:
1. If you're using a fresh profile: start out by adding 20+ history entries (enough so that you can scroll in the next steps).  E.g.  just visit https://en.wikipedia.org/wiki/Main_Page and ctrl-click every link that you see.
2. Visit `about:firefoxview-next`
3. Click "History" on the left sidebar.
4. Scroll all the way to the bottom.

ACTUAL RESULTS:
"Show all history" link is hiding at the very bottom, with its underline flush with the bottom of my viewport.

EXPECTED RESULTS:
A little bit of blank padding below the link, so that i can actually see the link a little better (and for consistency with what happens for the other sections, e.g. "open tabs", when I scroll to the bottom).
Bug: Update states for light, dark and HCM in side navigation
Status: RESOLVED
Priority: P3
Resolution: FIXED
Created: 2023-08-01 00:16:06+00:00
Resolved: 2023-09-02 09:40:54+00:00

STR:
1. Visit `about:firefoxview-next`
2. Click between the sections in the left sidebar.
3. Compare the look and feel to e.g. `about:preferences` in another window.

ACTUAL RESULTS:
The left sidebar looks quite similar between the "new" Firefox View vs. Preferences, with one notable difference: the selected section gets a link underline for some reason.

This makes the currently-selected section look like it's asking-to-be-clicked (it makes it look more like a link), which is kind of silly, since clicking that title for the currently-selected section has no effect.

EXPECTED RESULTS:
Probably no underline for the currently-selected section, for consistency with our other UI like Preferences and Add-ons, and to avoid inviting ineffective clicks from the user.
Bug: Migration UI is busted (overflowing text, menu dropdown button pushed off of the button) if your Chrome user profile has a very long name
Status: NEW
Priority: P3
Created: 2023-08-01 00:26:58+00:00
Resolved: 2023-08-03 17:00:48+00:00

STR:
1. In Google Chrome, visit `chrome://settings/manageProfile` and give your Chrome profile an extremely long name.  Even better, give it a name with an extremely long word.  I'm using the following:
> This is a suuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuper long name for a profile.
2. Quit out of Chrome (this is necessary for the above name to be "committed" in a way that shows up in Firefox).
3. In Firefox Preferences, search for "Import" and click "Import data".
4. Try to interact with Firefox's import flow.

ACTUAL RESULTS:
- The dropdown menu is broken. It's got a limited width, and the text runs off the right side of it, which pushes its `v` dropdown arrow way off of the button itself.
- The text that's shown in the button seems to be center-aligned inside of a block that is sized to content and left-aligned, which means most of text isn't visible (it's pushed way off to the right side).  See screencast to make this clearer.
- If you click the menu to open it, the menu-popup is also super wide (it's got the really wide string).  It may overflow and have a scrollbar if it's wider than your browser window.

EXPECTED RESULTS:
- It should probably be truncated at some upper limit (either in terms of characters or width), and ellipsized. At a minimum, we should ensure that the "v" icon shows up over the background of the dropdown button (whether that means we make the button wider or truncate the string).
- We may want to allow for the popup to be wider to accomodate long profile names.  This is partly an issue because that popup itself seems to have a fixed size which is quite small (which is usually fine but not if the profile name is long).
Bug: YouTube thumbnails not showing in Firefox 102.13.0esr (64-bit)
Status: RESOLVED
Priority: --
Resolution: INCOMPLETE
Created: 2023-08-01 01:37:13+00:00
Resolved: 2023-08-28 13:12:15+00:00

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Firefox/102.0

Steps to reproduce:

1. Open Firefox
2. Goto https://www.youtube.com


Actual results:

Youtube page loads but video thumbnails fail to show.


Expected results:

Youtube.com should show video thumbnails.
Bug: 4.62 - 4.3% Images / Images (Windows) regression on Wed July 26 2023
Status: RESOLVED
Priority: --
Resolution: FIXED
Created: 2023-08-01 08:57:14+00:00
Resolved: 2023-08-08 16:10:42+00:00

Perfherder has detected a awsy performance regression from push [1316e023af4411c289e2fe2c7d2d73d9b1ac3fb0](https://hg.mozilla.org/integration/autoland/pushloghtml?changeset=1316e023af4411c289e2fe2c7d2d73d9b1ac3fb0). As author of one of the patches included in that push, we need your help to address this regression.

### Regressions:

| **Ratio** | **Test** | **Platform** | **Options** | **Absolute values (old vs new)** |  
|--|--|--|--|--| 
| [5%](https://treeherder.mozilla.org/perfherder/graphs?timerange=1209600&series=autoland,4663361,1,4)  | [Images](https://firefox-source-docs.mozilla.org/testing/perfdocs/awsy.html#images)  | windows11-64-2009-shippable-qr | fission tp6 | 5,231,362.86 -> 5,472,953.02 | 
| [4%](https://treeherder.mozilla.org/perfherder/graphs?timerange=1209600&series=autoland,4663361,1,4)  | [Images](https://firefox-source-docs.mozilla.org/testing/perfdocs/awsy.html#images)  | windows11-64-2009-shippable-qr | fission tp6 | 5,242,739.71 -> 5,468,357.42 | 


Details of the alert can be found in the [alert summary](https://treeherder.mozilla.org/perfherder/alerts?id=39182), including links to graphs and comparisons for each of the affected tests. Please follow our [guide to handling regression bugs](https://wiki.mozilla.org/TestEngineering/Performance/Handling_regression_bugs) and **let us know your plans within 3 business days, or the offending patch(es) may be backed out** in accordance with our [regression policy](https://www.mozilla.org/en-US/about/governance/policies/regressions/).

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

For more information on performance sheriffing please see our [FAQ](https://wiki.mozilla.org/TestEngineering/Performance/FAQ).
Bug: 7zip produces checksum error for Windows .exe setup files available on archive.mozilla.org since version 113
Status: NEW
Priority: P5
Created: 2023-08-01 10:54:49+00:00
Resolved: 2023-08-30 18:22:58+00:00

STR:
1. Download the Windows installer .exe from https://archive.mozilla.org/pub/firefox/releases/.
2. Test integrity with `7z t "./Firefox Setup 115.0.3.exe"`.
````
    WARNINGS:
    Checksum error
````

7zip extracts files successfully despite the checksum error and the sha256sum/sha512sum is valid but the error is confusing to users:

https://support.mozilla.org/en-US/questions/1419439
https://support.mozilla.org/en-US/questions/1413203

Regression window:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=a8939ff5236dad956af827235ceed7104e5e92c2&tochange=7ea8042eaf1d0c5f78ccce2e79e3e13f73526c64

Regressed by Bug 1814727.
Bug: Error UI for un-analyzable products
Status: VERIFIED
Priority: P1
Resolution: FIXED
Created: 2023-08-01 13:19:03+00:00
Resolved: 2023-09-12 16:00:48+00:00

From a Slack thread this morning, it turns out some Amazon digital products cannot be analyzed, for instance https://www.amazon.com/dp/B002YK183C/.

We'll need to clarify with the fakespot team whether this is something that (a) can be supported for MVP, (b) if not, whether we can get a specific error response from the API so we can message the situation to users, and if we can get an error message, we'll need to follow up with UX on what can be done.

I've filed a corresponding bug on the fakespot Jira to see what can be done: https://mozilla-hub.atlassian.net/browse/FAK-201
Bug: Having a lastUsed value of 0 in a tab causes synced tabs not to display
Status: RESOLVED
Priority: --
Resolution: DUPLICATE
Created: 2023-08-01 13:37:50+00:00
Resolved: 2023-08-01 15:23:15+00:00

Eric wasn't seeing synced tabs so we debugged and for some reason, some of his tabs have a lastUsed value of 0 (which really shouldn't happen)

So when we convert these to time stamps, it fails.

We should test this and add a check just in case this happens.
Bug: PDF download fails to some network locations
Status: RESOLVED
Priority: --
Resolution: INCOMPLETE
Created: 2023-08-01 14:23:58+00:00
Resolved: 2024-02-05 12:20:17+00:00

Steps to reproduce:

Open a PDF file from website (internet). While it is shown in PDF-Viewer in Firefox I klick on the save-Button. I choose a NTFS network drive and try to save the PDF.


Actual results:

On a special drive the download fails. On other obviously same configurated drives the saving-process succeeded. When I try to re-save the file with the button on the right above it saves the pdf without problems.


Expected results:

Successful saving the pdf at first try.
Bug: Window closed due to all its tab(s) moving to another window should not end up in the "Reopen Closed ..." stack
Status: ASSIGNED
Priority: P3
Created: 2023-08-01 15:35:36+00:00
Resolved: 2023-08-08 12:48:01+00:00

Steps to reproduce:

1. Open Firefox
2. Open any two new pages - I control-clicked two random Pocket Stories on the new tab page 
3. detach any of the tabs opened in step 2 into a new window (drag out the tab)
4. drag the tab you detached back into the window you initially dragged it from
5. do "control-shift-t" 

What happens:

The reattached tab (from step 4) is detached again, AND we have the reattached tab in the window that I initially opened when opening Firefox. The tab has been duplicated. 

Expected result:

reopen closed tab does nothing.

mozregression:

```
 4:49.97 INFO: Narrowed integration regression window from [f1fb2652, 15a57a8c] (3 builds) to [f1fb2652, a44656c2] (2 builds) (~1 steps left)
 4:49.97 INFO: No more integration revisions, bisection finished.
 4:49.97 INFO: Last good revision: f1fb26526a2e8e7d9539b3f975817b0578e1bc0c
 4:49.97 INFO: First bad revision: a44656c2ad83d278286aa51507864e53a3911df3
 4:49.97 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=f1fb26526a2e8e7d9539b3f975817b0578e1bc0c&tochange=a44656c2ad83d278286aa51507864e53a3911df3
```
Bug: Page keeps reloading
Status: RESOLVED
Priority: --
Resolution: INCOMPLETE
Created: 2023-08-01 15:43:04+00:00
Resolved: 2023-10-29 17:44:30+00:00

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/115.0

Steps to reproduce:

I accessed https://forums.digitalspy.com/discussion/2408130/bauer-introduces-ad-free-spin-offs-of-its-stations/p2

I disabled Adblock Plus, refershed the page (which was refreshing anyway) and the issue remained.


Actual results:

The page kept reloading rapidly.


Expected results:

On Edge I can visit the page, manage cookies and visit the page as normal.
Bug: Website comments do not get translated
Status: RESOLVED
Priority: P3
Resolution: DUPLICATE
Created: 2023-08-01 15:55:58+00:00
Resolved: 2023-10-14 11:28:53+00:00

1) Load https://pctuning.cz/article/test-msi-geforce-rtx-4060-ventus-2x-black-oc-nove-technologie-za-nizsi-cenu-2?chapter=16#article-header
2) Translate to English
3) Scroll down to the comment section

The page gets translated, but the comments do not.
Bug: Why is the Russian text incomprehensible when translated into Russian?
Status: RESOLVED
Priority: --
Resolution: INVALID
Created: 2023-08-01 17:03:49+00:00
Resolved: 2023-08-30 10:19:44+00:00

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/116.0