av9ash/GitBugs huggingface dataset:
Bug: `warnOnTabsClosing` should be `async`
Status: NEW
Priority: --
Created: 2023-08-09 18:20:22+00:00
Resolved: 2023-10-12 21:11:48+00:00

Currently, `warnOnTabsClosing()`, when it needs to warn, uses the synchronous interface provided by `nsIPromptService`. Unfortunately, this enters a nested modal loop (using  `SpinEventLoopUntil`), which can lead to hangs. (See bug 1842170 for a concrete example.)

Fortunately, as of bug 1271842, `nsIPromptService` now also has an async interface which avoids creating a nested modal loop. Reworking `warnOnTabsClosing()` (and its callers and siblings) to be async would prevent this class of hangs.
Bug: HCM Improvements for the Shopping Sidebar
Status: RESOLVED
Priority: P3
Resolution: FIXED
Created: 2023-08-09 20:39:26+00:00
Resolved: 2023-12-06 21:52:46+00:00

activate a High Contrast Mode ([Instructions](https://firefox-source-docs.mozilla.org/accessible/ColorsAndHighContrastMode.html#operating-system-high-contrast-mode-os-hcm)), i.e. Night Sky theme on Windows 11

1. Sidebar left border needs to be `CanvasText` to separate it from the page content
    1. To compare with the screenshot attached, in the Windows 11 Night Sky theme the border of the sidebar on the left should appear white.
1. `Not Now` button keeps `ButtonText` color for the border when hovered, while it is expected to be `SelectedItemText` (otherwise it looks like it's in an active state). (refer to the [Acorns > Buttons > States > (HCM), State = Hover](https://acorn.firefox.com/latest/components/button/overview-udQAPeGf#search-445e4a50-8710-11ed-a82e-d98b0c93ddfd) examples).
    1. To compare with the screenshot attached, in the Windows 11 Night Sky theme the border should appear dark gray instead of yellow.
1. All Buttons (i.e. `X`, `V`, toggle, `Turn off...`) use `Canvas` for their backgrounds instead of `ButtonFace`
    1. To compare with the screenshot attached below, in the Windows 11 Night Sky theme the background should appear dark gray instead of black.
1. Focus indication for the `Analyze Reviews` and other hyperlinks (i.e. `How Fakespot determines review quality`) has focus outline that uses `ButtonText` instead of `CanvasText`
    1. To compare with the screenshot attached below, the border _color_ should appear white instead of yellow.
1. Focus indication for `Settings V` and other disclosures (`How we determine... V` incl.) is not as expected - both the placement of the outline and the color:
    1. it's `ButtonText` and outlines the whole row, while it's expected to add `CanvasText` outline to the chevron only since this is the element styled as a control in HCM - refer to the [Acorns > Buttons > States > (HCM), State = Focus](https://acorn.firefox.com/latest/components/button/overview-udQAPeGf#search-445e4a50-8710-11ed-a82e-d98b0c93ddfd) examples
    1. Or the entire `Settings V` control could be made look like a dropdown button - refer to the [HCM Components reference in Figma (NDA'ed link)](https://www.figma.com/file/VHRA9hZ54oJqKKJwPd6FWa/HCM-Components?type=design&node-id=51-3384&mode=design&t=dLBD9xZL3StV2alR-4) for an example.
    1. To compare with the screenshot attached below, the border _color_ should appear white instead of yellow.
1. Focused Checked toggle for `Show products` settings item is using `ButtonText` while `CanvasText` is expected for the outline color
    1. To compare with the screenshot attached below, the outline color should appear white instead of yellow.
Bug: Sidebar includes hidden focusable element after `X` button
Status: RESOLVED
Priority: P3
Resolution: FIXED
Created: 2023-08-09 20:50:27+00:00
Resolved: 2023-09-12 04:17:16+00:00

Something is focusable with the keyboard between `X` and the main body of the sidebar:
* press `Tab` to navigate to it
* it reads the contents of the entire sidebar of focused while a screen reader is running
Bug: Headings on the sidebar are only styled to look like headings
Status: RESOLVED
Priority: P3
Resolution: FIXED
Created: 2023-08-09 20:54:33+00:00
Resolved: 2023-09-02 09:40:58+00:00

1. Main heading `Review quality check` is an _implicit_ heading instead of being programmatically a heading too (instead of using either `<H1>` or `<H2>`)
1. Other implicit headings are in the `<summary>` like `How we determine review quality` and `Settings` - those are expected to be programmatic headings of the next level after the main heading (i.e. if the main heading is `<h2>`, they should use `<h3>`)
Bug: Nested description lists are not working properly
Status: NEW
Priority: P3
Created: 2023-08-09 21:02:39+00:00
Resolved: 2023-08-11 15:01:04+00:00

the nesting of description list `<dl>` elements for highlights within the separate component are not working well - each term `<dt>` would announce that it is a `list` by NVDA (for example), but would lack a number of items and a position within the set (since they'll think it's only one item in this description list)

Expected is something like `In list, 3 items` (for category name) > `Price, 1 of 3` > `In list, 3 items` (for the `<ul>` of highlights) > `They taste amazing... , 1 of 3` > ... > `Quality, 2 of 3` etc.

This may be caused by the screen reader's support of description lists in general. 

The issue here is that any list (description or unordered) is expected to communicate to a user of a screen reader how long the list is and which is the position of this item within this list so they could easily navigate and plan how many items they want to hear.
Bug: Fix TranslationsPanel view element visibility defects
Status: RESOLVED
Priority: P2
Resolution: FIXED
Created: 2023-08-10 05:32:52+00:00
Resolved: 2023-08-23 19:44:14+00:00

## Description

This bug aims to fix two defects that are somewhat related.

A) The TranslationsPanel intro message should be shown while the user is on the same URI where the panel was first shown. Once they navigate away, it should no longer be shown. 

B) On browser restart, when auto-translate is enabled for a language, the error box appears in the TranslationsPanel revisit view when it should not be present. 

 ---

## (A) Steps to reproduce

**A1)** Ensure the `browser.translations.panelShown` pref is set to `false`.

**A2)** Open a web page for which translation is supported and allow the panel translations panel to open.

**A3)** Close the panel and reopen it.

---

**(A) Expected Results**
- `[✔]` The translations panel displays the intro message on the first open.
- `[✔]` The translations panel displays the intro message on the second open.

**(A) Actual Results**
- `[✔]` The translations panel displays the intro message on the first open.
- `[✔]` The translations panel displays the intro message on the second open.language.

---

**A4)** Navigate to a different web page for which translation is supported and allow the panel translations panel to open.

---

**(A) Expected Results**
- `[✔]` The translations panel does not display the intro message on this new page.

**(A) Actual Results**
- `[✔]` The translations panel does not display the intro message on this new page.

---

**A5)** Navigate back to the original page from step **(A2)** and open the translations panel.

---

**(A) Expected Results**
- `[✔]` The translations panel does not display the intro message on the original page.

**(A) Actual Results**
- `[x]` The translations panel **displays the intro message on the original page**.

---

## (B) Steps to reproduce

**(B1)** Navigate to a page for which translations is supported and open the translations panel. 

**(B2)** Open the translations panel settings menu and check "Always translate <language>" for this language.

**(B3)** Restart the browser and open to a new session.

**(B4)** Navigate to a page in the language for which you enabled always-translate in step **(B2)**

**(B5)** Open the translations panel.

---

**(B) Expected Results**
- `[✔]` The translations panel opens the revisit view and no error box is displayed.

**(B) Actual Results**
- `[x]` The translations panel opens the revisit view and **a blank error box is displayed with no error message.**

---
Bug: Add a button to explicitly add a new image in the pdf
Status: VERIFIED
Priority: P1
Resolution: FIXED
Created: 2023-08-10 10:49:53+00:00
Resolved: 2023-09-15 09:12:57+00:00

Right now, the user needs to click on the button and the click somewhere on a page in order to add an image: nothing was obviously indicating this second step.
So UX recommended to add a button "+ Add image" in the panel associated to the button to add an image and Content recommended "Add or edit images" for labelling the current button to switch to "image mode".
Once the user clicks on this button, the file dialog popup is opened in order to select an image and then the image is added in the center of the visible part of a page and the user can move it, resize it, ...
When the users clicks outside of an image then the current selected one must be unselected.
Bug: New Tab button press and hold opens two tabs
Status: RESOLVED
Priority: --
Resolution: DUPLICATE
Created: 2023-08-10 12:26:21+00:00
Resolved: 2023-08-11 13:59:54+00:00

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/117.0

Steps to reproduce:

1. Press and hold the "+" new tab button in the tab bar
2. Click on any of the new tab options, including "No Container", or a container name to open a new tab in a selected container


Actual results:

Firefox opens two tabs. If a container is selected, the first tab is a tab with no container, and the second tab is with the selected container. 


Expected results:

Open a single tab, or a new tab in the selected container.
Bug: [Experiment] The "Embedded Import" Onboarding screen from the "Treatment A" branch of the "Embedded Import Wizard Experiment in Fx116" experiment has the same UI as the one from the "Treatment B" branch
Status: VERIFIED
Priority: --
Resolution: FIXED
Created: 2023-08-10 12:29:31+00:00
Resolved: 2023-08-11 08:44:55+00:00

**[Affected versions]:**
- Firefox Release 116.0.2 - Build ID: 20230805021307 

**[Affected Platforms]:**
- Windows 10 x64

**[Prerequisites]:**
- Have a new Firefox profile with the `nimbus.debug` pref set to `true` in the "about:config" page.
- Firefox is pinned to the taskbar.

**[Steps to reproduce]:**
1. Open the browser with the profile from the prerequisites.
2. Navigate to "about:studies?optin_slug=embedded-import-wizard-fx116&optin_branch=treatment-a&optin_collection=nimbus-preview".
3. Navigate to the "about:welcome" page and go to the "Embedded Import" screen.
4. Observe the screen's UI.

**[Expected result]:**
- Variant 1 of the "Embedded Import" screen is displayed for the "Treatment A" branch.
    
**[Actual result]:**
- Variant 2 (show all) of the "Embedded Import" screen is displayed instead.

**[Additional Notes]:**
- The "Embedded Import" Onboarding screen from the "Treatment B" branch has the correct UI.
- Attached is a screen recording of the issue:
Bug: file upload button drag and drop fails (Developer Edition only)
Status: RESOLVED
Priority: --
Resolution: DUPLICATE
Created: 2023-08-10 15:20:56+00:00
Resolved: 2023-08-10 16:06:41+00:00

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/117.0

Steps to reproduce:

Have file upload button on a web page:
     <input id="chooseFile" type="file" name="chooseFile">
Visit web page with Firefox Developer Edition
Drag a jpg file on top of the button.


Actual results:

Drag jpg file onto that button and drop it
a) with Firefox Developer Edition, the web page is replaced with the image dropped
b) with regular Firefox, Chrome, Brave or Edge, the button captures the filename.
(I'm reporting this in Dev Edn and this happens with the Browse... button below on this Enter A Bug page)
I'm using Firefox Developer 117.0b5 (64-bit), Windows 10
Standard Firefox 116.0.2 (64-bit)
I think this happened with the latest update as within the last day or two it was not a problem.
If I click on the button, however, the usual dialogue to get the jpg file location and name appears and the upload works with both editions of Firefox.


Expected results:

With Firefox Developer Edition the button should capture the filename as it does with Standard edition and other browsers.
Bug: Undo close tab doesn't restore window from previous session
Status: UNCONFIRMED
Priority: --
Created: 2023-08-10 17:07:46+00:00
Resolved: 2023-08-22 21:21:55+00:00

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/116.0

Steps to reproduce:

While testing https://bugzilla.mozilla.org/show_bug.cgi?id=1847551, I noticed a strange behavior in the new "undo close tab" behavior (tested in Firefox 117.0b5)

From 116 release notes:
> The keyboard shortcut to reopen closed tabs (command + shift + t) now reopens last closed tab or last closed window, in the order items were closed. If there aren't any tabs or windows to reopen, this command restores the previous session. This change is in anticipation of upcoming changes to recently closed tabs.

Expected behavior is that ctrl + shift + t now behaves as ctrl + shift + n if the last closed item was in a different window. I observe one exception:

1. Open a Firefox window
2. Open a second Firefox window (ctrl + n)
3. Close the second window (alt + f4)
4. Close Firefox (ctrl + q)
5. Open Firefox
6. Undo close tab (ctrl + shift + t)



Actual results:

Nothing happened, (or a tab in the same window is restored, even though it's not the last tab that was closed - the last one belonged to a different window)


Expected results:

The last closed window should have opened. Indeed, pressing ctrl + shift + n does restore the window. 

If we do the same thing but without steps 4 and 5 (i.e. without closing and re-opening firefox), then ctrl + shift + t does indeed restore the recently closed window. 

Seems weird for "undo close tab" to behave differently when Firefox is freshly opened vs not, since in both cases we're working with the same session (albeit one was freshly restored)
Bug: Flatpak of Firefox is missing the Speech Dispatcher library
Status: RESOLVED
Priority: --
Resolution: DUPLICATE
Created: 2023-08-10 18:38:28+00:00
Resolved: 2023-08-23 07:31:03+00:00

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/116.0

Steps to reproduce:

I 'bought' the following game from free from the Epic Store: 
https://store.epicgames.com/en-US/p/orwell-keeping-an-eye-on-you
It's only free for this week, but I presume the same issue will happen any of the 2 games that Epic is giving away in whatever week you are reading this.  Or for any other non-free purchase you make.

So: 1. Login using an account (register for free if don't have one). 2. On a current 'free game' page click on the "GET" button.  3. I confirmed my purchase (can't remember the exact button but it's very obvious).  4.  I got an error message at the top of the page.


Actual results:

Just above the top of the page (seemingly at the bottom of the UI bar) I got this message:
"You can’t use speech synthesis because the Speech Dispatcher library is missing."

Clicking the "Learn More" link after that message took me to this page:
https://support.mozilla.org/en-US/kb/speechd-setup?as=u&utm_source=inproduct

That page advises me that "Installing speech dispatcher should help.", but I presume the Flatpak should already come with it (and I presume that installing the libraries on Linux would not help since Flatpaks are self-contained as far as libraries go).


Expected results:

I presume there would have been no error message, and instead I'd have heard some kind of voice message.
Bug: Quick actions buttons have unbalanced padding on their left & right sides
Status: NEW
Priority: P3
Created: 2023-08-10 18:49:08+00:00
Resolved: 2023-08-14 15:26:46+00:00

STR:
1. In Firefox Nightly, type "manage" into your URL bar.
2. Look at the Quick Actions buttons that appear in the dropdown.

ACTUAL RESULTS:
The padding looks un-balanced. In particular:
- The left edge of each button has an icon with a lot of padding on either side of it.
- The right edge of each button has very little padding between the text and the edge of the button.
- This makes things feel lopsided.

EXPECTED RESULTS:
Consistent visual padding at the far left and right edge of each button (and between the button-and-the-text, too, maybe).
Bug: With full screen video on primary monitor, and Firefox window maximized on secondary monitor, pressing minimize on secondary monitor causes "Exit Full Screen" message to appear and persist until full screen video is exited
Status: RESOLVED
Priority: --
Resolution: DUPLICATE
Created: 2023-08-10 19:07:31+00:00
Resolved: 2023-08-14 15:54:29+00:00

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/116.0

Steps to reproduce:

1. Open Firefox windows (maximized) on primary and secondary monitors.
2. Open video (eg. YouTube) on primary monitor in Full Screen
3. press "minimize" button in window in secondary monitor


Actual results:

"<website> is now full screen [Exit Full Screen (Esc)]" message appears at top of full screen video on primary monitor, and stays at the top of the video until you exit full screen.


Expected results:

The "Exit Full Screen" message should not appear on the primary monitor when minimizing a window on the secondary monitor.
Bug: Firefox ignoring "Always ask you where to save files" checkbox
Status: RESOLVED
Priority: --
Resolution: INCOMPLETE
Created: 2023-08-10 21:03:51+00:00
Resolved: 2023-08-31 15:34:01+00:00

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/117.0

Steps to reproduce:

Firefox 117.0b4 Developer, Windows 10

"Always ask you where to save files" IS checked.
Folder for download is "Downloads" folder


Actual results:

Firefox DID NOT, and DOES NOT, ask where to download the file(s)

Instead of asking, immediately downloads into Downloads folder.


Expected results:

Firefox SHOULD HAVE ASKED me where which folder to download file(s) into.
Bug: Bookmark won't be added if you close the window without explicitly saving before doing so
Status: NEW
Priority: P3
Created: 2023-08-11 02:37:22+00:00
Resolved: 2023-09-11 15:10:42+00:00

Steps to reproduce:

Open a Firefox window
Navigate to a tab that you can bookmark
Press Ctrl+D or the bookmark star to bookmark the page, but don't press save 
Close Firefox in some way- either by closing your current tab when the window only has one open, or just pressing the application close.


Actual results:

The window will be closed, and the bookmark won't be added


Expected results:

It should have behaved like what happens when you do the same steps but instead use Ctrl+W to close the tab. It should have saved the bookmark without me needing to explicitly press save before hand.
Bug: Editing suggested URL is broken
Status: VERIFIED
Priority: P2
Resolution: FIXED
Created: 2023-08-11 04:44:22+00:00
Resolved: 2023-08-17 12:51:01+00:00

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/117.0

Steps to reproduce:

1. Launch Firefox with a new profile.
2. Go to https://developer.mozilla.org/en-US/
3. Open a new tab and close other tabs.
4. Type `d` in the address bar.
5. Press arrow key to select https://developer.mozilla.org/en-US/
6. Select `en-US` in the address bar and type `ja`.



Actual results:

* The text in the address bar turns into `h` when I type `j`.



Expected results:

* The result should be https://developer.mozilla.org/ja/

This was introduced by Bug 1416881.
This is not fixed by Bug 1846261 (I have tested on Firefox 117.0b6 and Nightly Build ID 20230810155203).
Bug: Zoom default with ctrl. + 0 / strg. + 0 not working in my firefox
Status: RESOLVED
Priority: --
Resolution: INVALID
Created: 2023-08-11 08:26:38+00:00
Resolved: 2023-08-14 07:59:38+00:00

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/117.0

Steps to reproduce:

Want to reset zoom


Actual results:

nothing


Expected results:

zoom to 1.0
Bug: Pressing Ctrl + Tab to cycle between tabs crashes firefox
Status: RESOLVED
Priority: --
Resolution: WORKSFORME
Created: 2023-08-11 10:06:39+00:00
Resolved: 2024-03-11 16:08:42+00:00

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:109.0) Gecko/20100101 Firefox/116.0

Steps to reproduce:

Open more than 2 tabs, and upon using ctrl + tab to cycle between tabs, Firefox crashes.


Actual results:

Firefox crashes with a small window asking to report this crash with report details.


Expected results:

Should have cycled between tabs.
Bug: Remove the empty imageeditor when adding a new image
Status: VERIFIED
Priority: P1
Resolution: FIXED
Created: 2023-08-11 10:56:29+00:00
Resolved: 2023-09-08 12:43:11+00:00

When adding a new image, an empty rectangle with a spinning icon is displayed until the image is displayed: it can be disturbing for the user.
UX recommended to remove it and just use a hourglass cursor
Bug: Screenshot overlay is broken on projectpro.io
Status: NEW
Priority: P3
Created: 2023-08-11 13:00:20+00:00
Resolved: 2023-08-17 16:29:57+00:00

**Environment:**
Operating system: Windows 10 / Windows 11
Firefox version: Firefox Nightly 118.0a1 (2023-08-10)

**Steps to reproduce:**
1. Go to https://www.projectpro.io/article/machine-learning-projects-on-github/465
2. Right click on blank area on the page.
3. Click on "Take Screenshot".
4. Observe the layout.

**Expected Behaviour:**
The layout for taking screenshots is displayed correctly, screenshots of the page can be taken.

**Actual Behaviour:**
The layout for taking screenshots is not displayed correctly, unable to take screenshots of the page.

**Notes:**
1. Screen rec provided
2. Reproducible on Firefox Release as well
Bug: Dialogs from the Preferences page are cut off if they are expanded manually and then the window shrinks.
Status: NEW
Priority: P5
Created: 2023-08-11 13:23:40+00:00
Resolved: 2023-08-15 15:52:25+00:00

**Found in**
* 118.0a1 (2023-08-11)



**Affected versions**
* 118.0a1 (2023-08-11)
* 117.0b6	
* 116.0.2
* 115.1.0esr

















**Tested platforms**
* Affected platforms: Ubuntu 22, Windows 10x64, macOS 13 ARM
* Unaffected platforms: none



**Steps to reproduce**
1. Open Firefox and enter fullscreen.
2. Load about:preferences#privacy and click the Manage Exceptions button.
3. Expand the panel and exit full screen.



**Expected result** 
* The Panel changes dimensions according to the Firefox window.

**Actual result**
* The panel is cut off.

**Regression range**
* Mozregression points this pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=b95ae2249c9b0a3a0340b2b799675c6b10821910&tochange=fd57a3ea2b88fd2969fc1cf7e2c41cffff0d084d 
Possible regressor: bug 1790307

**Additional notes**
* Attached a screen recording.
* This can also be reproduced without fullscreen by dragging the panel to increase its size to the browser edge.
Bug: Screenshots tool doesn't initiate download file dialog for specific webpage
Status: RESOLVED
Priority: P3
Resolution: WORKSFORME
Created: 2023-08-11 15:22:00+00:00
Resolved: 2024-05-09 20:07:38+00:00

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/116.0

Steps to reproduce:

1. Go to https://www.hellasdigital.gr/networking-el/switch-el/unmanaged/tp-link-tl-sg108-8-port-metal-gigabit-switch/?sl=en
2. Hit Control + Shift + S to start Screenshots tool
3. Click Save full page or Save visible
4. Click Download


Actual results:

Nothing happens. No download file dialog is shown.


Expected results:

A download file dialog should have appeared.
Copy works though.
Bug: If the search service fails to initialise properly, allow topsites on new tab page to work properly
Status: RESOLVED
Priority: P3
Resolution: FIXED
Created: 2023-08-11 16:16:38+00:00
Resolved: 2023-08-29 18:40:56+00:00

If the search service fails to initialise, we should still allow Firefox to be used.

At the moment, the new tab page doesn't finish starting properly.

Although this should be an extremely rare scenario, that's hopefully only limited to test builds, I think it is worth making sure that at least some of the browser is usable, so that users can still try and find information without needing to resort to switching browsers.

The problem on address bar side was fixed in Bug 1648188