av9ash/GitBugs huggingface dataset:
Bug: Search mode transfers to other tabs while cycling tabs when persisted search enabled
Status: VERIFIED
Priority: P2
Resolution: FIXED
Created: 2024-10-25 12:22:01+00:00
Resolved: 2024-11-15 11:19:52+00:00

**Found in**
* 133.0a1 (2024-10-25)

**Affected versions**
* 133.0a1 (2024-10-25)
* presist search enabled on Nightly/Early beta

**Tested platforms**
* Affected platforms: Windows 11, Mac 14, Ubuntu 24


**Preconditions**
* browser.urlbar.showSearchTerms.featureGate set to TRUE (default in Nightly)

**Steps to reproduce**
1. Open Tab 1 - execute random search with default engine
2. Open Tab2- enter search mode with any engine
2. Cycle tabs back to tab1 - either click or Ctrl+Pgup/Down.

**Expected result**
* Tab1, Tab2 content doesn't change

**Actual result**
* The search mode from tab2 applies to tab1

**Regression range**
* TBD

**Additional Notes**
* Reproduces with browser.urlbar.scotchBonnet.enableOverride as well.
Bug: Min size firefox window truncates menubar on localized builds
Status: NEW
Priority: --
Created: 2024-10-25 12:41:06+00:00
Resolved: 2024-10-25 12:42:12+00:00

**Found in**
* 133.0a1 (2024-10-25)

**Affected versions**
* 133.0a1 (2024-10-25)
* 128.3.1esr 
* 115.17.0esr

**Tested platforms**
* Affected platforms: Windows 11, Ubuntu 24(enabling from customize)
* Not affected platforms: Mac 14

**Steps to reproduce**
1. Install a localized build (e.g fr, es-ES)
2. Enable Menu Bar.
3. Resize window to min lateral size.

**Expected result**
* All Menu Bar buttons are visible and accesible, even when minsized.

**Actual result**
* Close button is truncated

**Regression range**
* Not a recent regression.
Bug: Blocked dialog displayed after canceling paste of warning text in Google Docs/OneDrive
Status: VERIFIED
Priority: --
Resolution: FIXED
Created: 2024-10-25 12:56:42+00:00
Resolved: 2024-12-11 03:40:34+00:00

**Found in**
* 133.0a1 (2024-10-24)

**Affected versions**
* 133.0a1

**Preconditions**
* Download the DLP test assets from https://drive.google.com/file/d/1yjqVRuxdKV3WnO7D2wzMgDXBuYBxUgVw/view 
* Create a distribution folder inside the Firefox folder and paste the policies-1.json to it and then rename it to policies.json
* Run the DLP agent in CMD using: .\content_analysis_sdk_agent.exe --user --toblock=.\d{3}-?\d{2}-?\d{4}. --towarn=.warn. --delays=10

**Tested platforms**
* Affected platforms: Windows 10/11
* Unaffected platforms: macOS, Ubuntu 

**Steps to reproduce**
1. Go to https://drive.google.com/drive/home and open a Google Doc
2. Open up a document in an external program (for example Notepad) and type “warning text” into it and copy it 
3. Paste the copied text from step 2 into the Google Doc
4. Press the “Cancel” button from the “This content may be unsafe” dialog and observe the behavior

**Expected result**
* “You’re not permitted to pasted this content” dialog is not displayed

**Actual result**
* “You’re not permitted to pasted this content” dialog is displayed

**Regression range**
* Mozzregression points to bug 1915351

**Additional notes**
* See the attached video
* Also reproducing for One Drive Documents
* Not reproducing for the drag and drop operation
Bug: Blocked dialog displayed in Google Docs / OneDrive docs after canceling an ongoing scan
Status: VERIFIED
Priority: --
Resolution: FIXED
Created: 2024-10-25 12:59:01+00:00
Resolved: 2024-12-10 10:00:10+00:00

**Found in**
* 133.0a1 (2024-10-24)

**Affected versions**
* 133.0a1

**Preconditions**
* Download the DLP test assets from https://drive.google.com/file/d/1yjqVRuxdKV3WnO7D2wzMgDXBuYBxUgVw/view 
* Create a distribution folder inside the Firefox folder and paste the policies-1.json to it and then rename it to policies.json
* Run the DLP agent in CMD using: .\content_analysis_sdk_agent.exe --user --toblock=.\d{3}-?\d{2}-?\d{4}. --towarn=.warn. --delays=10

**Tested platforms**
* Affected platforms: Windows 10/11
* Unaffected platforms: macOS, Ubuntu 

**Steps to reproduce**
1. Go to https://drive.google.com/drive/home and open a Google Doc
2. Copy any random text and paste it inside the gdoc
3. Press the “Cancel” button from the “Scan in progress” dialog and observe the behavior

**Expected result**
* The scan is canceled and no other dialogs are displayed

**Actual result**
* “You’re not permitted to pasted this content” dialog is displayed

**Regression range**
* Mozzregression points to bug 1915351

**Additional notes**
* See the attached video
* Also reproducing for One Drive Documents
Bug: Toolbar button "checked" state is out of sync for "Show and hide sidebar"
Status: RESOLVED
Priority: P2
Resolution: WORKSFORME
Created: 2024-10-25 14:00:50+00:00
Resolved: 2025-01-29 21:35:25+00:00

Steps to Reproduce:
1. Enable the revamped sidebar from Firefox Labs.
2. Click the gear icon, opening the "Customize sidebar" panel.
3. Under "Sidebar button", enable "Show and hide sidebar".
4. Close the customize panel.
5. Click the toolbar button to hide the sidebar.
6. Click the toolbar button again to show (and expand) the sidebar.
7. Click the toolbar button repeatedly.

Expected Results:
Step 5 - Toolbar button should not be checked (no shading).
Step 6 - Toolbar button should be checked.
Step 7 - When sidebar is expanded, toolbar button should be checked.

Actual Results:
Step 5 - Toolbar button is checked, even though the sidebar is hidden.
Step 6 - Toolbar button is unchecked, even though the sidebar is expanded.
Step 7 - Toolbar button is never checked.

Spec for reference: https://www.figma.com/design/ZFavpnAJee39j2mFf8U3D0/Sidebar-UX-Spec?node-id=14743-103263&t=xRyYjxsL5ZoqLL3j-1
Bug: Hover previews should hide extension UUIDs like we do in the address bar
Status: NEW
Priority: P3
Created: 2024-10-25 16:09:26+00:00
Resolved: 2024-10-29 15:47:15+00:00

Steps to reproduce:

* Install [Group Speed Dial](https://addons.mozilla.org/addon/groupspeeddial/)
* Open a new tab with it
* Hover that tab


Actual results:

Firefox shows the UUID assigned to that extension. Users are confused by this.


Expected results:

The UUID should be replaced with the extension name or a blank space.
Bug: Find in PDF doesn't work for multiple words on specific file
Status: NEW
Priority: P3
Created: 2024-10-25 16:36:36+00:00
Resolved: 2024-10-27 13:42:20+00:00

**Found in**
* Firefox 133.0a1

**Affected versions**
* Firefox 133.0a1
* Firefox 132RC

**Tested & Affected platforms**
* Win 11 x64
* Ubuntu 22 

**Steps to reproduce**
1. Access a PDF form with search option activated in the PDF bar (see https://web.archive.org/web/20060818161558/http://archive.dovebid.com/brochure/bro1514.pdf).
2. Press Ctrl(Cmd)+F to open the find toolbar.
3. Enter the following search-term: "work benches".

**Expected result**
* The phrase is successfully searched for and the matches are highlighted on the page correctly.

**Actual result**
* Text is found in the upper search toolbar, but not in the Find toolbar.

**Regression range**
* This is not a recent regression, I could reproduce back to 124.0a1 2024-01-22.

**Notes**
Ctrl+F first opens the bottom Find toolbar, then the upper one.
Bug: Save to pocket using "save in Pocket" fails
Status: RESOLVED
Priority: --
Resolution: INCOMPLETE
Created: 2024-10-25 16:40:53+00:00
Resolved: 2024-12-27 13:40:32+00:00

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:131.0) Gecko/20100101 Firefox/131.0

Steps to reproduce:

I read a page in lecture mode, and press save to pocket (from the left button bar).


Actual results:

Pocket asks to be activated (it was) in a pop-up.
Pushing "activate", a getpocket page which redirects to accounts.firefox.com asking for id and password (as I was already connected !).
login then sends to https://getpocket.com/fr/saves
but nothing has been saved.

Even after all this, clicking again on the original page in lecture mode, the very same chain of events follows.

I can save to pocket using the "in My Pocket" extension, but not from lecture mode.


Expected results:

Click on "Save to Pocket" (esp in lecture mode) ... saves to pocket without asking.
Bug: Theme colour processing happens once per window instead of once per theme
Status: NEW
Priority: P3
Created: 2024-10-25 16:42:10+00:00
Resolved: 2024-11-10 05:02:32+00:00

LightWeightThemeConsumer's `_setProperties` function [processes colours from the manifest values to the "real" CSS values](https://searchfox.org/mozilla-central/rev/4ac5b1f6cc9d8c186986f52369a2d9a537d10474/toolkit/modules/LightweightThemeConsumer.sys.mjs#661,680-694). However, this gets invoked once for each window. That's not very efficient because the values are going to be the same each time - it would make more sense to gather a set of variables in one go and then dispatch that to all windows.
Bug: Microsoft Store app opens without permission
Status: RESOLVED
Priority: --
Resolution: DUPLICATE
Created: 2024-10-25 18:17:03+00:00
Resolved: 2025-01-17 13:17:09+00:00

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:131.0) Gecko/20100101 Firefox/131.0

Steps to reproduce:

1. Don't have Microsoft Store listed on about:preferences > Applications (so you can't set "Always ask" to links to this app).

2. Open this LinkedIn article https://www.linkedin.com/pulse/designing-gen-z-expectations-ux-guidelines-vitaly-friedman-v6fge

3. Click on the "Get the app" button on the top nav bar (the link is: ms-windows-store://pdp/?ProductId=9WZDNCRFJ4Q7&mode=mini&cid=guest_nav_upsell&trk=article-ssr-frontend-pulse_guest_nav_menu_windows)


Actual results:

The Microsoft Store app is opened without user permission.


Expected results:

User must have the option to have a choice to "always ask".
Bug: Tab preview not working with Sideberry extension on about:preferences / about:addons
Status: NEW
Priority: P3
Created: 2024-10-25 19:08:30+00:00
Resolved: 2024-10-29 15:44:17+00:00

Tab preview is not working when on about:preferences, using the Sideberry extension.
STR
1. Open about:preferences
2. Hover over another tab

See screen recording attached.
Bug: The secondary buttons (Sign in, Skip this step) don't use the correct button background color for HCM
Status: RESOLVED
Priority: --
Resolution: WORKSFORME
Created: 2024-10-25 19:44:20+00:00
Resolved: 2024-10-25 20:39:18+00:00

## Prerequisites:

Found in Nightly 133.0a1 (2024-10-25)(64-bit)
Turn on Night Sky High Contrast mode on your device ([steps to do so here](https://firefox-source-docs.mozilla.org/accessible/ColorsAndHighContrastMode.html#operating-system-high-contrast-mode-os-hcm))

## STR:

1. Open `about:welcome` from the URL bar
2. Locate the 'Sign in' and 'Skip this step' buttons
3. Compare secondary button styles in Nightly to the styles established in the [High Contrast Mode Figma](https://www.figma.com/design/VHRA9hZ54oJqKKJwPd6FWa/High-Contrast-Mode?node-id=438-580&node-type=canvas&t=5OCcX39WNSggP17e-0)

## Expected:

The secondary buttons should follow the styles established in the High Contrast Mode Figma (gray HCM Button Background, yellow HCM Button text for text and outline)

## Actual:

The button is missing the gray HCM Button Background
Bug: The import browser data button menu doesn't conform to HCM standards
Status: NEW
Priority: P1
Created: 2024-10-25 20:20:07+00:00
Resolved: 2025-03-03 18:05:32+00:00

## Prerequisites:

Found in Nightly 133.0a1 (2024-10-25)(64-bit)
Turn on Night Sky High Contrast mode on your device ([steps to do so here](https://firefox-source-docs.mozilla.org/accessible/ColorsAndHighContrastMode.html#operating-system-high-contrast-mode-os-hcm))

## STR:

1. Open `about:welcome` from the URL bar
2. Click the 'Save and Continue' button to go to the next screen
3. Compare menu button styles in Nightly to the styles established in the [High Contrast Mode Figma](https://www.figma.com/design/VHRA9hZ54oJqKKJwPd6FWa/High-Contrast-Mode?node-id=51-2248&node-type=canvas&t=Jb0a2jzI2gZ9jrwz-0)

## Expected/Actual:

The menu buttons should follow the styles established in the [High Contrast Mode Figma](https://www.figma.com/design/VHRA9hZ54oJqKKJwPd6FWa/High-Contrast-Mode?node-id=51-2248&node-type=canvas&t=Jb0a2jzI2gZ9jrwz-0).
Bug: Mozilla Account Automatically Disconnects
Status: RESOLVED
Priority: --
Resolution: INCOMPLETE
Created: 2024-10-25 21:50:08+00:00
Resolved: 2024-11-13 10:25:26+00:00

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:131.0) Gecko/20100101 Firefox/131.0

Steps to reproduce:

I logged into my Mozilla account.


Actual results:

Upon login the account disconnects and prompts me to sign in with an authorization code every time.


Expected results:

Upon inputting the authorization code, I would expect the account to stay logged in.
Bug: No gap between tabs and new tab button for non-overflowing tabstrip
Status: VERIFIED
Priority: P2
Resolution: FIXED
Created: 2024-10-25 22:56:31+00:00
Resolved: 2024-11-01 11:41:12+00:00

See image.

The gap is almost non-existent now, but the gaps between pinned tabs and between "normal" tabs are still a reasonable size.

I mozregressioned this down to bug 1922036.
Bug: Ctrl+Shift+L Shortcut opens AI sidebar (and opts into AI sidebar lab experiment)
Status: RESOLVED
Priority: --
Resolution: FIXED
Created: 2024-10-26 23:16:17+00:00
Resolved: 2024-10-28 13:08:25+00:00

From https://mastodon.social/@Stanisable/113375594791628630

>Hum, a recent #FirefoxNightly upgrade breaks a #Bitwarden extension's keyboard shortcut (ctrl + shift + L) to show AI chats in the sidebar. Even when "Chatbot AI" is disabled in preferences. Are you aware of that @FirefoxNightly ?

Steps to reproduce:

1. Press Control-shift-L

What happens:

I am opted into the AI chatbot experiment and a sidebar with a chatbot selection UI opens.

Expected result:

As before 1905027. I am not opted into the experiment, so the keyboard shortcut should work as previously (and like the user on Mastodon reported, allow existing user-configured extension shortcuts).
Bug: Private window purple mask icon in titlebar has disappeared for vertical tabs
Status: VERIFIED
Priority: P1
Resolution: FIXED
Created: 2024-10-27 13:40:58+00:00
Resolved: 2024-10-31 10:20:06+00:00

STR:
1. Start with `sidebar.verticalTabs = true`.
2. Open a private window.

Expected:
Purple mask icon in titlebar next to window controls.

Actual:
No purple mask icon in titlebar.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=810a76d6befb8ab7770a1abd0f078c4fef01efcb&tochange=87fbfe70fe7a63e68b052b0aa8b84484575b6a19

Regressed by Bug 1922307.
Bug: New hover previews hide image resolutions when their filenames are too long
Status: NEW
Priority: P5
Created: 2024-10-27 14:07:05+00:00
Resolved: 2024-10-29 15:42:12+00:00

Steps to reproduce:

* Open an image with a very long filename in a tab
* Hover that tab


Actual results:

The new default hover preview doesn't show the image resolution.




Expected results:

The old tooltips (`browser.tabs.hoverPreview.enabled` = `false`) show image resolutions regardless of the size of their filenames.
Bug: Intermittent browser/components/translations/tests/browser/browser_translations_full_page_telemetry_basics.js | single tracking bug
Status: RESOLVED
Priority: P5
Resolution: INCOMPLETE
Created: 2024-10-27 19:59:15+00:00
Resolved: 2024-11-18 12:07:20+00:00

**Filed by:** smolnar [at] mozilla.com
**Parsed log:** https://treeherder.mozilla.org/logviewer?job_id=479986193&repo=autoland
**Full log:** https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/MNaT4Xy4R02QQIEN6tNaKA/runs/0/artifacts/public/logs/live_backing.log

---
```
TEST-PASS | browser/components/translations/tests/browser/browser_translations_full_page_telemetry_basics.js | The translations button is visible. - 
[task 2024-10-27T19:45:08.576Z] 19:45:08     INFO - Opening the popup
[task 2024-10-27T19:45:08.577Z] 19:45:08     INFO - Waiting for the full-page-translations-panel popupshown event
[task 2024-10-27T19:45:08.577Z] 19:45:08     INFO - Buffered messages finished
[task 2024-10-27T19:45:08.577Z] 19:45:08     INFO - TEST-UNEXPECTED-FAIL | browser/components/translations/tests/browser/browser_translations_full_page_telemetry_basics.js | Test timed out - 
[task 2024-10-27T19:45:08.578Z] 19:45:08     INFO - GECKO(3046) | Completed ShutdownLeaks collections in process 3046
[task 2024-10-27T19:45:08.578Z] 19:45:08     INFO - TEST-START | Shutdown
```
Bug: Mouse-over on tab tooltip causes toolbar to hide in full-screen mode
Status: RESOLVED
Priority: --
Resolution: DUPLICATE
Created: 2024-10-28 02:17:06+00:00
Resolved: 2024-11-05 11:00:50+00:00

Steps to reproduce:

1. Visit any website.
2. Press F11 to enter full-screen mode.
3. Move the mouse cursor to the top to make the toolbar appear.
4. Hover the mouse over the tab of any open website till the tooltip appears.
5. Move the mouse cursor down to the tooltip but still within the boundaries of the toolbar. (red rectangle in screenshot)

SteamOS 3.6.19 (6.5.0-valve22-1-neptune-65-g9a338ed8a75e #1 SMP PREEMPT_DYNAMIC Mon, 21 Oct 2024 19:06:57 +0000 x86_64 GNU/Linux)
Firefox 131.0.3 (official flatpak), Mozilla/5.0 (X11; Linux x86_64; rv:131.0) Gecko/20100101 Firefox/131.0, vanilla: no addons or extensions, 
same behavior observed in LibreWolf 131.0.3-1, Mozilla/5.0 (Windows NT 10.0; rv:131.0) Gecko/20100101 Firefox/131.0, heavily modified: lots of addons, extensions and tweaks


Actual results:

The toolbar hides.
This behavior appeared since the introduction of the new tab preview feature.


Expected results:

The toolbar stays visible as the mouse is still within its boundaries.
Bug: about:preferences prompts to launch a ms-settings link
Status: NEW
Priority: P3
Created: 2024-10-28 04:16:44+00:00
Resolved: 2024-11-08 13:56:55+00:00

STR:
1. Open about:preferences
2. Select "Privacy & Security" tab.
3. Scroll down to the "Passwords" section and click "Manage passkeys in system settings"

Expected: Windows Settings app opens

Actual: a cryptic popup appears that says "Open ms-settings link with Settings?"

This is privileged content.  It's OK if it skips these prompts.
Bug: opening a new window or a new private window from the windows task bar menu does not focus the address bar
Status: RESOLVED
Priority: --
Resolution: INCOMPLETE
Created: 2024-10-28 09:49:09+00:00
Resolved: 2024-11-22 14:34:28+00:00

current:
when opening a new window from firefox menu -> focus on search box
when opening a new window from task bar -> no focus
when opening a new PRIVATE window from firefox menu -> focus address bar
when opening a new PRIVATE window from task bar -> no focus

expected:
when opening a new window from task bar -> focus address bar
when opening a new PRIVATE window from task bar -> focus address bar
Bug: Desktop briefly revealed during sidebar animation expansion when double-clicking sidebar toggle button on Linux
Status: NEW
Priority: P3
Created: 2024-10-28 09:52:01+00:00
Resolved: 2024-10-30 15:06:31+00:00

STR:
1. Change `sidebar.revamp = true` on Ubuntu 24.10.
2. Collapse the sidebar if it is already expanded.
3. Double-click the sidebar toggle.

Desktop briefly shows through during expansion animation.

Does not happen when sidebar already expanded or on Windows 11 (opaque window).

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=aa6305a65fb5e7e7a9a1c0b572cdb0e2d4dac4fc&tochange=05fe9b71651f981ada58733864135b940f9c27b0

Regressed by Bug 1915230.
Bug: Cannot have not synced themes/ addons on separate machines
Status: RESOLVED
Priority: --
Resolution: INCOMPLETE
Created: 2024-10-28 09:56:45+00:00
Resolved: 2024-12-03 18:06:03+00:00

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:131.0) Gecko/20100101 Firefox/131.0

Steps to reproduce:

I go to about:config, past the warning and search for "theme" related settings. I wanted to have different themes on my machines, despite being logged in with the same mozilla account. I disabled the settings which contained the term "themeID", and "sync".


Actual results:

The setting(s) keep resetting after a while, and the themes are removed from both machines.


Expected results:

The setting(s) should've been kept the same and the themes remain unchanged between machines.
Bug: Policy set default engine (capitalized name) is retained when policy is removed
Status: RESOLVED
Priority: P5
Resolution: FIXED
Created: 2024-10-28 10:26:56+00:00
Resolved: 2024-12-19 09:43:10+00:00

**Found in**
* 133.0a1 (2024-10-27)

**Affected versions**
* 133.0a1 (2024-10-25)
* 128.3.1esr 
* 115.17.0esr

**Tested platforms**
* Affected platforms: Windows 11, Mac 13
* Not tested platforms: Ubuntu

**Steps to reproduce**
1. Browser is closed. 
2. Set a default engine policy firefox/distribution/policy.json containing BING as parameter
3. Start Firefox. 
4. Close Firefox, delete/rename policies.json/distribution folder
5. Start Firefox. 

**Expected result**
* Default engine is Bing (3.)
* Default engine is Google (5.)

**Actual result**
* Default engine is Bing (3.)
* Default engine is Bing (5.)

**Regression range**
* Not a recent regression.

**Notes**
* Even though default engine is set correctly according to the policy, on step 3, Browser console log states: 
* * Policies: Search engine lookup failed when attempting to set the default engine. Requested engine was "BING". Error: No engine by that name could be found Policies.sys.mjs:2322 * *
Bug: Sidebar tools are not clickable from the bottom edge of the screen (Fitts' Law) when in expanded state (horizontal) except for the last settings button
Status: NEW
Priority: P3
Created: 2024-10-28 10:33:12+00:00
Resolved: 2024-10-28 12:56:44+00:00

STR:
1. Start with `sidebar.verticalTabs = true` and `sidebar.revamp = true`.
2. Make sure there are at least six tool items in the sidebar (`browser.ml.chat.enabled = true`, `browser.shopping.experience2023.integratedSidebar = true`).
3. Expand the sidebar so that the tools appear horizontal across the bottom instead of vertical.
4. Maximize the window.
5. Try to click the sidebar tools from the bottom edge of the screen (requires no taskbar at the bottom). 

Expected:
All sidebar tools buttons can be clicked from the bottom edge of the screen in accordance with Fitts' Law.

Actual:
Only the last button ("Customize sidebar") can be clicked from the bottom edge of the screen.
Bug: [Linux] Tab text and close button (X) is misaligned in expanded vertical tabs
Status: RESOLVED
Priority: P1
Resolution: FIXED
Created: 2024-10-28 10:55:21+00:00
Resolved: 2024-10-31 23:39:35+00:00

## STR:

* Using latest NIghtly on Ubuntu (in my case this is 24.04, note this doesn't seem to repro on Mac or Windows)
* With sidebar.revamp and sidebar.verticalTabs true 
* Look at the text position in a tab when tabs are expanded.

###  What happens

* The text is positioned too low in the tab.

### What should happen

The text display should match Mac and Windows.

### Other notes:

~Running Mozregression found this which will hopefully help pin down where the fix needs to be~

~Bug 1922343 - Hide scrollbar gutter on macOS in vertical tabs r=sidebar-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,emilio,mconley
Differential Revision: https://phabricator.services.mozilla.com/D224363~

The regression found doesn't seem to be right as this patch just involved colors. To be sure reverting it locally didn't change anything.