av9ash/GitBugs huggingface dataset:
Bug: Add a check to clear security.enterprise_roots.enabled when it was auto enabled and security.certerrors.mitm.auto_enable_enterprise_roots is false
Status: RESOLVED
Priority: --
Resolution: WONTFIX
Created: 2022-05-11 15:34:41+00:00
Resolved: 2022-05-31 21:44:33+00:00

In Tor Browser we have a patch that checks at Firefox startup whether `security.certerrors.mitm.auto_enable_enterprise_roots` is `false` but `security.enterprise_roots.auto-enabled` is `true`.

In that case, we clear both `security.enterprise_roots.auto-enabled` and `security.enterprise_roots.enabled`.

We think that all Firefox users could benefit from it, so we would like to have this patch upstreamed.

I am attaching our patch originally developed by Alex Catarineu.

Thank you!
Bug: Dragging a download from the Downloads Panel always gives me the latest download
Status: RESOLVED
Priority: --
Resolution: DUPLICATE
Created: 2022-05-11 16:15:29+00:00
Resolved: 2022-05-13 13:52:26+00:00

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:99.0) Gecko/20100101 Firefox/99.0

Steps to reproduce:

1. Download more than one file.
2. Open the Downloads panel.
3. Drag any file but the latest to a suitable drop location (e.g. local file explorer or upload drop zone of a website)


Actual results:

Firefox always gives you the latest download.

If the latest download was deleted, you can't drag any download.


Expected results:

Firefox should give you the download you were dragging.
Bug: PersonalityProviderWorkerClass.jsm does a lot of disk I/O
Status: RESOLVED
Priority: --
Resolution: FIXED
Created: 2022-05-11 16:45:02+00:00
Resolved: 2022-05-15 03:02:14+00:00

Every 5 minutes, 8 I/O operations are done for each of the 25 files in the `<user profile>/personality-provider` folder.

Here's a profile showing the I/O: https://share.firefox.dev/3yuxaQd
Zooming out, the same pattern is repeated every 5 minutes: https://share.firefox.dev/3Md3taA

There's obvious room for optimization here:
- we don't need to repeatedly attempt to create the `personality-provider` folder. It could be created by the `onSync` method before the loop rather than by the `maybeDownloadAttachment` method. But actually, it would be more efficient to not attempt to create it at all, and let the other I/O functions fail (and catch the error with a try/catch). I think the right place to create the folder would be in a `catch` block after `await IOUtils.write` in `_downloadAttachment`. That should ensure we only attempt to create the folder once. (The `IOUtils.makeDirectory` call in the `deleteAttachment` method could also be similarly removed.)
- there's an IOUtils.exists call followed by an IOUtils.stat call. Both do a stat under the hood. The `exists` call should be removed, and replaced with a try/catch around the `IOUtils.stat` call.
- I haven't found why in the code, but we read all files twice. I assume the first read is from the `_getFileHash` function. The second read, I don't know.

Questions:
- Do we really need to sync all these files every 5 minutes? Could it be every hour instead?
- It looks like the first time we read the files to check the size and hash, we should cache this information instead of computing it again 5 minutes later. Is there a reason not to do so?
- Could these files be merged into one to reduce the amount of I/O operations we need to do on them?
- Doing all these calls to `maybeDownloadAttachment` in parallel (ie. without awaiting them) is interesting; it ensures the BgIOThreadPool thread remains busy and never sleeps. That probably saves a few thread wake-ups... but I wonder if it's intentional that IOUtils uses a single thread, rather than sending its I/O tasks to various threads of a thread pool. Probably off topic for this bug though.
Bug: Tab and bookmark titles doesn't change on youtube.com
Status: RESOLVED
Priority: --
Resolution: WORKSFORME
Created: 2022-05-11 19:56:04+00:00
Resolved: 2022-05-13 07:05:38+00:00

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:100.0) Gecko/20100101 Firefox/100.0

Steps to reproduce:

I open the video on YouTube, add it to the bookmarks (press the star icon button on the url bar), then I open another video from the list on the right, add it to the bookmarks


Actual results:

I have two bookmarks with same title. The title of the tab also does not change


Expected results:

The title of the tab should change when I move to another video. The name of the bookmarks should be different and correct
Bug: Firefox freezes for several seconds while saving session
Status: RESOLVED
Priority: --
Resolution: INCOMPLETE
Created: 2022-05-11 20:30:13+00:00
Resolved: 2023-10-09 13:30:03+00:00

User Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:100.0) Gecko/20100101 Firefox/100.0

Steps to reproduce:

Just have desktop Firefox (100.0 x86_64 from Linux Fedora repos) with a lot of tabs opened (>6k)


Actual results:

Firefox freezes entirely for several seconds (~5) while writing sessionstore files.
However, it's for Ryzen 3300X, slower PC will suffer more.



Expected results:

Expected no freezes. It might help to use separate thread for session saving with low CPU & IO priority, but I don't know the current implementation.
Bug: Bookmark Merge fails on desktop deleting mobile bookmark with blank title
Status: RESOLVED
Priority: --
Resolution: DUPLICATE
Created: 2022-05-11 21:40:06+00:00
Resolved: 2022-05-11 22:58:13+00:00

Sync on desktop was failing to show bookmarks added on mobile in the past 30 days.

Sync Log shows: 

1652304200037	Sync.ErrorHandler	DEBUG	bookmarks failed: MergeError: Failed to execute statement with code 19 (NOT NULL constraint failed: itemsRemoved.title)(resource://gre/modules/SyncedBookmarksMirror.jsm:1397:5) JS Stack trace: MergeError@SyncedBookmarksMirror.jsm:1397:5
handleError@SyncedBookmarksMirror.jsm:764:22

On desktop, after installing About:Sync, I determined that the server was indicating a deleted item by GUID. 

After exporting a JSON backup, I determined that the GUID in question belonged to this bookmark:

Name: [blank]
URL: https://www.rtd-denver.com/app/plan/trip?at=2022-04-10T05%3A15%3A41.078Z&from=stop_33700&minimize=TIME&to=stop_33727&using=mode_transit&when=depart

Adding a name (any name) on desktop allows the other bookmarks to appear, but blocks the deletion.

I have a lot of these kinds of bookmarks on mobile for some reason (seems travel related). It would be nice if this failure could be avoided so that I don't have to worry about deleting them.
Bug: Inactive tab text no longer visible in Firefox 100.0
Status: RESOLVED
Priority: --
Resolution: DUPLICATE
Created: 2022-05-12 00:16:08+00:00
Resolved: 2022-05-23 15:19:30+00:00

User Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:99.0) Gecko/20100101 Firefox/99.0

Steps to reproduce:

I updated from Firefox version 99.0.1 to 100.0, restarted the browser, and opened two tabs. No other steps were performed.


Actual results:

Using the default system theme, the text on the inactive tabs became black, rendering them unreadable. The active tab remained unchanged, and therefore is still fine. The image provided shows what version 100.0 looks like (top) and 99.0.1 looks like (bottom).


Expected results:

There should have been no difference for the tabs between version 99.0.1 & previous and version 100.0 and kept the inactive tab's text visible when on a dark system color.
Bug: dowloadable files are not stored in the address bar history
Status: NEW
Priority: P5
Created: 2022-05-12 06:51:24+00:00
Resolved: 2022-06-14 02:27:03+00:00

Steps to reproduce:

Type http://database.clamav.net/bytecode.cvd in the address bar, press enter, select save location. After the file is saved, type 'bytecode' into the address bar



Actual results:

There is no 'http://database.clamav.net/bytecode.cvd' in suggested list


Expected results:

'http://database.clamav.net/bytecode.cvd' should've been in the suggested list. 

http://database.clamav.net/main.cvd from the same site is added to the address bar suggested list without issues - file size matters? Both are added to ^H history.
Bug: Opening Firefox with pinned tabs in a split-screen mode on Ubuntu shows ghost tabs
Status: RESOLVED
Priority: --
Resolution: INVALID
Created: 2022-05-12 08:13:48+00:00
Resolved: 2022-05-26 15:43:29+00:00

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:100.0) Gecko/20100101 Firefox/100.0

Steps to reproduce:

- Open Firefox and pin some tabs (I currently have 5 tabs pinned).
- Move the window to the side of the screen, so that it take up half the screen width (split-screen mode on Ubuntu)
- Close Firefox, ensuring that you don't lose the pinned tabs
- Open Firefox again (it should open in that split-screen mode again)


Actual results:

Looking at the Tabs, there appears to be a "ghost" tab at the start of the pinned tabs. It basically looks like there is a pinned tab icon missing, when there isn't.

This can be remedied by full-screening Firefox, and then returning it to the split-screen mode.


Expected results:

The tabs should be left-aligned like they are normally from the start.
Bug: Firefox-update re-adds google as search engine, sets it as default + deletes previous default search engine
Status: RESOLVED
Priority: --
Resolution: INCOMPLETE
Created: 2022-05-12 12:01:53+00:00
Resolved: 2024-05-06 21:42:04+00:00

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:100.0) Gecko/20100101 Firefox/100.0

Steps to reproduce:

I use Firefox under Ubuntu 20.04 LTS on a desktop pc.
I (precisely the package manager) updated Firefox.


Actual results:

The previously deleted google search engine was added again AND was set to default AND my previous default search engine has been removed.


Expected results:

The google search engine should not be re-added as seach engine.
The default search engine should not be altered.
The default search engine should not be removed.
Bug: Using the luminosity globalCompositeOperation in combination with other globalCompositeOperations causes rendering errors
Status: RESOLVED
Priority: --
Resolution: DUPLICATE
Created: 2022-05-12 15:36:19+00:00
Resolved: 2022-05-12 15:49:43+00:00

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:101.0) Gecko/20100101 Firefox/101.0

Steps to reproduce:

I can reproduce by following these steps:
1. create a canvas element and insert an image with drawImage
2. set globalCompositeOperation to "saturation" and fill the canvas with #000
3. set globalCompositeOperation to "luminosity" and globalAlpha to 0.5 and fill the canvas with #fff

Where the desaturation layer and luminosity layer overlap, a rendering error occurs

This codepen contains a recreatable example https://codepen.io/GBro/pen/gOvwGod?editors=0010


Actual results:

On the Windows version of Firefox, it was rendered correctly.

On the Mac OSX version of Firefox (user agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:100.0) Gecko/20100101 Firefox/100.0), the resultant image has a speckling effect, with black and white spots dotted around the image where the two globalCompositerOperation effects overlap.


Expected results:

The canvas should display a desaturated and brightened version of the original image
Bug: Fix PBM tests to handle opening Spotlight
Status: RESOLVED
Priority: P1
Resolution: FIXED
Created: 2022-05-12 16:02:54+00:00
Resolved: 2022-06-09 22:02:10+00:00

Fix of Bug 1765907 , tried to invoke Spotlight flow from test file 'browser_privatebrowsing_about_nimbus_messaging.js' using Sinon causing two backout of the patch due to intermittents.

https://phabricator.services.mozilla.com/D144871

Scope of this bug is to investigate intermittent failure seen with patch and refactor test to handle opening spotlight from tests in PBM mode.

Gist below shows the stub usage in  test
https://gist.github.com/punamdahiya/8c9922a4acea3ace1c753dc44fb85199

With this Stub usage in 'browser_privatebrowsing_about_nimbus_messaging.js, intermittent failure was seen in browser_privatebrowsing_focus_promo.js  due to not able to show promo

https://treeherder.mozilla.org/jobs?repo=try&author=pdahiya%40mozilla.com&selectedTaskRun=abpWjvG5TlWQI2NdJIOEDg.0&searchStr=Linux%2C18.04%2Cx64%2CWebRender%2Casan%2Copt%2CMochitests%2Cwith%2Csoftware%2Cwebrender%2Cwith%2Cfission%2Cenabled%2Ctest-linux1804-64-asan-qr%2Fopt-mochitest-browser-chrome-swr-fis-e10s%2Cbc2



If stub calls are changed to spy , intermittent failure below is seen for different tests on linux in private browsing browser_privatebrowsing_localStorage.js , browser_privatebrowsing_noSessionRestoreMenuOption.js, browser_privatebrowsing_protocolhandler.js

A promise chain failed to handle a rejection: Could not get children of file(/tmp/tmp9c8f4krj.mozrunner/settings/main/ms-images) because it does not exist - stack: (No stack available.)


https://treeherder.mozilla.org/logviewer?job_id=377220226&repo=autoland&lineNumber=19988

https://mozilla.slack.com/archives/G90HG2UQH/p1652141301328679?thread_ts=1652119806.446959&cid=G90HG2UQH
Bug: Certificate Policies OID not Displayed in certviewer
Status: NEW
Priority: P3
Created: 2022-05-12 20:58:11+00:00
Resolved: 2024-05-15 19:23:11+00:00

For some end entity and intermediate CA certificates, the Certificate Policies OID is not displayed in the certificate viewer.  The policy OIDs should be displayed by the viewer. For instance, the "anyPolicy" OID is not displayed even when it is contained in an intermediate CA certificate.
Bug: Restore tabs at startup broken giving useless query
Status: NEW
Priority: --
Created: 2022-05-12 21:25:43+00:00
Resolved: 2022-09-15 21:13:23+00:00

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:99.0) Gecko/20100101 Firefox/99.0

Steps to reproduce:

Set to Open Previous windows and tabs.  


Actual results:

Upon closing Firefox gives message "OK to close tabs".   


Expected results:

Previously did not query since the tabs will be restored.   This message is a) unclear, confusing and worrying since you are given the impression that your tabs will be lost  b) not needed, i.e. you have to answer a query before you can close FF.
Bug: onde salvar arquivos --> NÃO FUNCIONA
Status: RESOLVED
Priority: --
Resolution: INCOMPLETE
Created: 2022-05-13 01:29:22+00:00
Resolved: 2022-05-27 13:23:41+00:00

em Configurações
 Geral
  Arquivos e Aplicações
   Downloads:
- Não funciona marcar: Sempre perguntar onde salvar arquivos.
Está gravando sempre na pasta padrão do sistema: Downloads.
Bug: Dragging the address bar created an illegal file.
Status: RESOLVED
Priority: --
Resolution: INVALID
Created: 2022-05-13 05:57:22+00:00
Resolved: 2022-05-28 01:07:20+00:00

Steps to reproduce:

Windows10.
I drag the address bar to desktop to make bookmark (URL shortcut).


Actual results:

0KB file, not .url file was created.
and I can't delete it, I can't rename it.

I try chkdisk but not fix. no error.

I edit and overwrite this file, but it saved another file (same name).



Expected results:

file creation process was aborted? windows sees it still processing?
Bug: Opacity of last letters in firefox search url dropdown list
Status: RESOLVED
Priority: P3
Resolution: DUPLICATE
Created: 2022-05-13 07:25:13+00:00
Resolved: 2023-02-06 16:35:10+00:00

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:100.0) Gecko/20100101 Firefox/100.0

Steps to reproduce:

Try fix this with css


Actual results:

Opacity of last letters in url dropdown list


Expected results:

All letters must be without opacity
Bug: Highlighted search terms are not subsequently highlighted inside "Delete cookies and site" / Manage Exceptions
Status: RESOLVED
Priority: --
Resolution: DUPLICATE
Created: 2022-05-13 07:48:57+00:00
Resolved: 2022-05-31 19:51:38+00:00

**Affected versions**
      
      * ESR 91.9.0esr
      * Release 100.0
      * Nightly/Beta 101.0b6
      * Nightly 102.0a1 (2022-05-12)

**Affected platforms**
     
      * Windows
      * Ubuntu 20.04
      * Mac 11


**Steps to reproduce**
1. Open Firefox.
2. Access about:preferences
3. Input a search string that matches content from Cookies and Site Data / Manage Execptions.
4. Open "Manage Exceptions"  when highlighted as containing the search string.

**Expected result**
The "Manage Exceptions" displays label indicating that it contains the search string and the search string is highlighted inside the modal.

**Actual result**
The "Manage Exceptions" displays label indicating that it contains the search string but the search string is not highlighted inside the modal.

**Regression range**
* Doesn't seem like a recent regression.

**Note**
As an example: "Address" works as expected, but most of the search strings: block, allow, manage, don't  work for this section.
Bug: Experiments with the `no-feature-firefox-desktop` feature configuration return a `did not validate` error message in the browser console
Status: VERIFIED
Priority: --
Resolution: FIXED
Created: 2022-05-13 08:24:17+00:00
Resolved: 2022-06-14 12:41:18+00:00

*[Affected versions]:*
- Firefox Nightly 102.0a1 en-US (Build ID -20220512094957)
- Firefox 100.0 (Build ID - 20220428192727)

**[Prerequisites]:**
- Have a new Nimbus experiment in the LIVE state on the Stage server.
- Have the “Browser Console” opened. 
 
**[Steps to reproduce]:**
Enroll in the experiment from the prerequisites.
Observe the “Browser Console” messages.
 
**[Expected result]:**
- In the about:studies page the new experiment should appear as Active.
- No error message is displayed in the “Browser Console”.
 
**[Actual result]:**
- This experiment is not shown in the about:studies.
-  The `RSLoader: only_for_a_test did not validate` error message is displayed in the “Browser Console”. 
 
**[Notes]:**
- The issue is also reproducible on Firefox 100.0 builds (20220428192727).
- Attached is a screenshot of the issue.
Bug: Menu hover/active background color is incorrect in Menubar
Status: RESOLVED
Priority: --
Resolution: DUPLICATE
Created: 2022-05-13 08:27:34+00:00
Resolved: 2022-05-13 16:06:11+00:00

Steps to reproduce:
1. Make sure windows OS theme is `Light` and Firefox theme is `System theme`
2. Enable Menubar
3. Mouse hover menu and click

Actual results:
Dark blue background color and black font color.

Expected results
Light gray background color and black font color.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=4cb7108079fd542e3cfb1c8a8992fe837b917b72&tochange=a4358621eab8b77c9cb63f707288beecb20ca551
Bug: Downloading an "Open with Firefox" file (PDF, WEBP, …) via Gmail opens it instead
Status: RESOLVED
Priority: --
Resolution: DUPLICATE
Created: 2022-05-13 08:41:55+00:00
Resolved: 2022-06-10 13:40:43+00:00

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:100.0) Gecko/20100101 Firefox/100.0

Steps to reproduce:

1. Create a new Firefox profile on macOS.
2. (Optional) Set Firefox to "Always ask you where to save files" (Preferences/Options -> General -> Files and Applications -> Downloads).
3. Open Gmail and choose a mail with an attachment that Firefox is set to "Open with Firefox" (e.g. a PDF of WEBP, as can be seen in Preferences/Options -> General -> Files and Applications -> Applications).
4. Click on the "Download" button.


Actual results:

The file was downloaded to a default location and opened in a new tab.


Expected results:

The file should have just been been saved (to the default save location or to one chosen via a save dialogue) and not have been opened in the browser: it should have been handled the same way that other attachments are, including those which the browser natively displays such as PNG, JPEG or HTML files.
Bug: Data is not synced between devices
Status: RESOLVED
Priority: --
Resolution: WORKSFORME
Created: 2022-05-13 08:55:25+00:00
Resolved: 2022-05-16 01:32:40+00:00

Affected versions:
100.0 (Stage)

Affected platforms:
Windows 10
Android 12
iOS 15.4

Preconditions:
All the sync preferences are selected.
The user is logged in to Sync with the same FxA account on a desktop and a mobile device.
The user has some browsing data (history, bookmarks, etc) already created on desktop.

Steps to reproduce:
1. On desktop click the Account icon in the toolbar and Sync now.
2. Go to your Android device, tap on the 3 dots menu and then on Settings.
3. Tap on your account/ email address and Sync now.
4. Observe the last synced date.
4. On Android go to bookmarks/ history and look for the data from desktop.

Actual result:
The data is not synced. The data from desktop is not available on Android.

Expected result:
The data is synced between devices.
Bug: Check whether the addon is really present before trying to enable/disabling it
Status: RESOLVED
Priority: P2
Resolution: FIXED
Created: 2022-05-13 13:29:18+00:00
Resolved: 2022-05-20 09:34:39+00:00

Hi! Bug 1488971 introduced some checks to see whether the addon is enabled, but doesn't check whether the addon was found in the first place.

In Tor Browser, for example, we remove it. Other forks may do the same.

Therefore, we would like to ask if you could add a check to return immediately from `_checkScreenshotsPref` (in `browser/components/BrowserGlue.jsm`) when `addon` is null.
Actually, also the `async` callback in `_monitorWebcompatReporterPref` in the same file would need a similar modification, in our opinion.

I am attaching the patch we use for Tor Browser (based on Firefox 91.9.0 ESR), please let me know if you think that it is okay and you want me to create a Phabricator patch, instead.

Thanks!
Bug: avif and webp files with content-disposition: attachment get saved to disk before being shown, if set to "open in firefox" (the default)
Status: NEW
Priority: P3
Created: 2022-05-13 16:46:05+00:00
Resolved: 2022-06-13 21:41:26+00:00

Download folder is contaminated by unwanted files when open such url.

Steps To Reproduce:
1. Open the url ( https://static-chunichi-co-jp.cdn.ampproject.org/ii/w820/s/static.chunichi.co.jp/image/article/size1/8/2/3/7/82378f0f6e46369c7a6b5bb36713c7a6_1.jpg )

Actual Results:
An image is shown in tab as expected. However, unintended files are saved in the default download folder and are not removed when the browser is closed.
Download folder is contaminated by unwanted files.

Expected Results:
An image is shown in tab as expected. 
And the temporarily downloaded file should be removed when the browser is closed.

Setting browser.download.improvements_to_download_panel to false fixes the issue.
Bug: Replace timer in browser_library_row_is_visible.js with an event
Status: RESOLVED
Priority: P3
Resolution: INVALID
Created: 2022-05-13 20:12:07+00:00
Resolved: 2022-08-30 14:12:29+00:00

When using the Bookmark Library and selecting an element, the details panel will expand. One example where this happens is if the selection is on a folder and then the user selects a bookmark.

When a bookmark is selected, `ensureRowIsVisible` is called which scrolls the list down to the appropriate row if it is not visible. Unfortunately, neither `MozMousePixelScroll` nor `DOMMouseScroll` are triggered when `ensureRowIsVisible` scrolls the list. This makes it tricky to determine when to check the row for visibility. 

For now, I'm using a timer to pass the tests in `browser_library_row_is_visible.js`, but it should be replace with an event to be more durable.