av9ash/GitBugs huggingface dataset:
Bug: Backup regeneration is triggered by batch cookie deletion due to expiry / hitting size limits
Status: RESOLVED
Priority: P3
Resolution: FIXED
Created: 2024-10-07 14:34:09+00:00
Resolved: 2024-10-09 21:50:05+00:00

In bug 1890427, I added some routines that regenerate backups when certain resources are manually deleted by users.

I've noticed more regeneration occurring in my local profile, and doing some debugging, I think this has to do with regeneration triggered by batch cookie deletion. What we _want_ to do is regenerate backups if a cookie is deleted _manually by the user_. What we don't want to do is regenerate backups if a cookie naturally expires or if the cookie table purged of cookies because of size limits on the table.
Bug: In Firefox Nightly, the shortcuts of the "Personal Bar" can be seen on top of the suggestions panel
Status: RESOLVED
Priority: --
Resolution: DUPLICATE
Created: 2024-10-07 14:40:34+00:00
Resolved: 2024-10-07 14:46:37+00:00

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:133.0) Gecko/20100101 Firefox/133.0

Steps to reproduce:

1 : Launch the application. (Firefox Nightly)
2 : Enable the sidebar and vertical tabs in the Firefox Labs settings.
3 : Put the "Personal Bar" in "Always show" mode. (For ease of reproduction)
4 : Add a few shortcuts to the "Personal Bar". (Until they are directly below the search bar) 
4 : Open a new tab.
5 : Focus the search bar.
6 : Notice that the shortcuts are visible over the suggestion dropdown.


Actual results:

The shortcuts in the "Personal Bar" are shown on top of the suggestion dropdown when vertical tabs are enabled.


Expected results:

The shortcuts in the "Personal Bar" are displayed behind the suggestion dropdown when vertical tabs are enabled.

Notes : 
- This issue does not occur when vertical tabs are disabled.
- This issue occurs on Firefox Nightly 133.0a1 (2024-10-07) (64 bits).
Bug: Translation changes selected value when using jQuery chosen plugin
Status: RESOLVED
Priority: --
Resolution: WORKSFORME
Created: 2024-10-07 15:27:26+00:00
Resolved: 2025-01-10 11:16:59+00:00

Steps to reproduce:

I'm a developer using jQuery with chosen plugin.
A simple html page with complete JS is included.
It only contains a simple form with a html select tag - it is marked as english (<html lang="en">) despite much text is in german.

On a larger site, all select boxes are changed


Actual results:

1. Call the site, don't change anything
2. Open translation window from URL line
3. Hit Submit button
Request will contain value "3" for the select field despite default should be "1" and the frontend did not change


Expected results:

1. Call the site, don't change anything
2. Open translation window from URL line
3. Hit Submit 
Request shoud contain value "1"
Bug: [Feature][Desktop] The “Need to Know” contextual content section from the New Tab page is not displayed for users on en-GB locale and region
Status: VERIFIED
Priority: --
Resolution: FIXED
Created: 2024-10-07 15:42:17+00:00
Resolved: 2024-10-08 12:25:20+00:00

[Affected versions]:
- Firefox Beta 132.0b3, en-GB locale, BUILD ID: 20241004091740.

[Affected Platforms]:
- Windows 10, Windows 11.
- macOS.
- Linux.

[Prerequisites]:
- Have a new profile with the “browser.search.region” parameter from the “about:config” page set to “GB”.
- In the same profile, have the “browser.newtabpage.activity-stream.discoverystream.contextualContent.enabled” parameter from “about:config” page set to “true”.

[Steps to reproduce]:
1. Restart the browser with the profile from the prerequisites.
2. Open a new tab and observe the behavior.

[Expected result]:
- The “Need to Know” section is displayed on the right side of the screen for en-GB region.

[Actual result]:
- The “Need to Know” section is not displayed for en-GB region. The normal feed is displayed.

[Additional Notes]:
- The issue is not reproducible when using en-US or de-DE locales and regions.
- The issue seems to have been fixed in the latest Firefox Nightly 133.0a1, en-GB locale, BUILD ID: 20241007093651.
Bug: MacOS Window buttons misplaced in the middle of the toolbar
Status: RESOLVED
Priority: --
Resolution: INVALID
Created: 2024-10-07 16:35:15+00:00
Resolved: 2024-10-08 09:48:31+00:00

Tested on: MacOS Sonoma 14.6.1, Firefox Nightly (133.0a1). 

With [Sidebery addon](https://addons.mozilla.org/en-GB/firefox/addon/sidebery/) installed, the Window Buttons (Red Yellow Green buttons) are placed in the middle of the window toolbar instead of the left corner, as shown on the screenshot attached.
Hiding the Sidebery sidebar doesn't change anything.

When opening an other profile with no addon installed, the bug is not reproducible.
Bug: Bookmarks Toolbar
Status: RESOLVED
Priority: --
Resolution: DUPLICATE
Created: 2024-10-07 20:37:02+00:00
Resolved: 2024-10-08 06:47:52+00:00

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:132.0) Gecko/20100101 Firefox/132.0

Steps to reproduce:

1. Open Firefox Developer Edition (132.0b4) Mac OS Ventura (13.6.9)
2. All Bookmarks in Toolbar are missing
3. Right clicking on toolbar > Bookmarks Toolbar > Always Show, is checked
4. This began for me when updating to 132.0b2
5. I see reports this issue has been fixed, however it is not fixed in the Developer Edition


Actual results:

Blank Toolbar.  All bookmarks are still there under Bookmarks > Bookmarks Toolbar


Expected results:

Bookmarks should be in toolbar
Bug: Firefox only restored half of my windows after restart
Status: RESOLVED
Priority: --
Resolution: DUPLICATE
Created: 2024-10-07 23:13:47+00:00
Resolved: 2024-10-08 17:54:41+00:00

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:131.0) Gecko/20100101 Firefox/131.0

Steps to reproduce:

I had approximately 10 windows open (I have one window per project). I have Firefox configured to restore my windows after restart. I shut down firefox by right-clicking on the Windows 11 taskbar icon and selecting "Close all windows". Then I launched Firefox by clicking on the taskbar icon (I have Firefox pinned). 


Actual results:

Only five of my windows were restored. 


Expected results:

All 10 windows should have been restored.
Bug: [Unified Ads API Integr] change endpoint hit for unified ads DELETE request
Status: VERIFIED
Priority: --
Resolution: FIXED
Created: 2024-10-07 23:57:38+00:00
Resolved: 2024-10-14 12:34:20+00:00

Right now we are hitting "v1/ads" with a DELETE request, and it should be a DELETE request to "v1/delete_user"
Bug: [Unified Ads API Integr] Tiles request is no longer properly handling tiles cache timeout
Status: VERIFIED
Priority: --
Resolution: FIXED
Created: 2024-10-08 00:01:51+00:00
Resolved: 2024-10-14 13:10:06+00:00

We set the duration for tiles cache based on a response from the server, but we should have a fallback or some other mechanism. It doesn't strictly have to be a value from the server.
Bug: Toolbar buttons overlap in small windows with vertical tabs
Status: RESOLVED
Priority: P1
Resolution: DUPLICATE
Created: 2024-10-08 10:31:17+00:00
Resolved: 2024-10-08 19:01:58+00:00

STR:
1. Start with `sidebar.verticalTabs = true` and `sidebar.revamp = true`.
2. Shrink the window width.

Expected:
Toolbar buttons don't overlap.

Actual:
Overflow button, hamburger button and window controls overlap Extensions button and the address bar.

Does not happen with the system titlebar (`browser.tabs.inTitlebar = 0`).

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=b17f4d3142eeb0488513b984c8f5113e80101b96&tochange=82dacb5e3821fc0081deed13bd932839d65867e0

Regressed by Bug 1899598.
Bug: Unfocused address bar no longer has contrasting background color since becoming part of the titlebar with vertical tabs
Status: VERIFIED
Priority: P2
Resolution: FIXED
Created: 2024-10-08 10:56:18+00:00
Resolved: 2024-12-20 16:07:19+00:00

STR:
1. Start with `sidebar.verticalTabs = true` and `sidebar.revamp = true`.
2. Enable the Light theme.
3. Unfocus the address bar.

Expected:
Address bar has a different background color to the titlebar when unfocused.

Actual:
Address bar blends into titlebar.

Affects Windows 11 System/Light/Dark themes and Ubuntu 24.04 Light/Dark themes but not System theme.


Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=b17f4d3142eeb0488513b984c8f5113e80101b96&tochange=82dacb5e3821fc0081deed13bd932839d65867e0

Regressed by Bug 1899598.
Bug: Registering a new search engine without an extension has become impossible
Status: RESOLVED
Priority: --
Resolution: INVALID
Created: 2024-10-08 11:13:14+00:00
Resolved: 2024-10-08 15:37:05+00:00

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:133.0) Gecko/20100101 Firefox/133.0

Steps to reproduce:

I wanted to register a new search engine: "spot.murena.io".
I tried via the "added" menu in Settings/search, but this button no longer exists in new versions of Firefox.
I tried via the "+ add search engine" button in the address bar.


Actual results:

“Nightly was unable to download the search plugin from: https://spot.murena.io/opensearch.xml”


Expected results:

The engine should have been registered or failing that, I should have been able to register it manually by URL.
Bug: Impression and Dismiss events for cards from the “Need to Know” contextual content section are incomplete
Status: VERIFIED
Priority: --
Resolution: FIXED
Created: 2024-10-08 11:39:59+00:00
Resolved: 2024-10-15 12:40:13+00:00

[Affected versions]:
- Firefox Beta 132.0b4, BUILD ID: 20241007091632.
- Firefox Nightly 133.0a1, BUILD ID: 20241007210631.

[Affected Platforms]:
- Windows 10, Windows 11.
- macOS 15.0.1.
- Ubuntu 22.04.

[Prerequisites]:
- Have a new profile with the “browser.search.region” pref from the “about:config” page set to any of the supported regions (“US”, “GB”, “DE”).
- In the same profile, have the “browser.newtabpage.activity-stream.discoverystream.contextualContent.enabled” pref from “about:config” page set to “true” (preffed off by default).

[Steps to reproduce]:
1. Open the browser with the profile from the prerequisites.
2. Navigate to the “about:glean” page, input any tag name, select “newtab”, and click the “Apply settings and submit ping” button.
3. Open a new tab and close it.
4. Navigate to the https://debug-ping-preview.firebaseapp.com/pings/tag_name_here page and verify the generated pings.

[Expected result]:
- All telemetry events originating from cards from the “Need to Know” section contain the “is_list_card” property.

[Actual result]:
- The “[impression](https://debug-ping-preview.firebaseapp.com/pings/abejenaru/6ff03457-edc3-44fd-9916-be98beffd0c2#L258-L302)” events from the “newtab” ping do not contain the “is_list_card” property, making it hard to determine their source.

[Additional Notes]:
- This issue is also reproducible with the "[dismiss](https://debug-ping-preview.firebaseapp.com/pings/abejenaru/6dee6cb3-ccc1-4605-ada1-916060976457#L427-L440)" events of the “Need to Know” section.
- Navigating to the “about:telemetry#events-tab”, it seems that the value of the events is registered as “CARDGRID”, which is the same as any other card from the main Pocket feed.
Bug: “Show popular search suggestions” is checked by default and uncheckable.
Status: RESOLVED
Priority: --
Resolution: DUPLICATE
Created: 2024-10-08 11:41:17+00:00
Resolved: 2024-10-08 11:50:29+00:00

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:133.0) Gecko/20100101 Firefox/133.0

Steps to reproduce:

J'ai voulu décocher “Show popular search suggestions”.




Actual results:

La fonction était grisée et donc indécochable.


Expected results:

...
Bug: Clicking on any card from the “Need to Know” contextual content section does not generate a “click” telemetry event
Status: VERIFIED
Priority: --
Resolution: FIXED
Created: 2024-10-08 11:44:14+00:00
Resolved: 2024-10-15 13:02:21+00:00

[Affected versions]:
- Firefox Beta 132.0b4, BUILD ID: 20241007091632.
- Firefox Nightly 133.0a1, BUILD ID: 20241007210631.

[Affected Platforms]:
- Windows 10, Windows 11.
- macOS 15.0.1.
- Ubuntu 22.04.

[Prerequisites]:
- Have a new profile with the “browser.search.region” pref from the “about:config” page set to any of the supported regions (“US”, “GB”, “DE”).
- In the same profile, have the “browser.newtabpage.activity-stream.discoverystream.contextualContent.enabled” pref from “about:config” page set to “true” (preffed off by default).

[Steps to reproduce]:
1. Open the browser with the profile from the prerequisites.
2. Navigate to the “about:glean” page, input any tag name, select “newtab”, and click the “Apply settings and submit ping” button.
3. Open a new tab and click any card from the “Need to Know” section.
4. Navigate to the “https://debug-ping-preview.firebaseapp.com/pings/tag_name_here” page and verify the generated pings.

[Expected result]:
- A “pocket.click” event is found in the `newtab` ping generated when clicking cards from the “Need to Know” section.

[Actual result]:
- No “pocket.click” event is found in the `newtab` ping generated for clicking cards from the “Need to Know” section.

[Additional Notes]:
- The issue is not reproducible when clicking cards from the normal feed area of the new tab page.
- A “CLICK” event is not registered on the “about:telemetry#events-tab” page either.
Bug: Pages don't Load
Status: RESOLVED
Priority: --
Resolution: INCOMPLETE
Created: 2024-10-08 12:05:04+00:00
Resolved: 2024-10-26 05:32:02+00:00

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/17.4.1 Safari/605.1.15

Steps to reproduce:

1. My Firefox Browser auto-updated to version 131.0 (aarch 64)
2. I am running it on a 2022 MacBook Pro, Sonoma 14.4.1
3. I got the mozilla information that from now on cookies will be contained separately



Actual results:

1. Since this Firefox update last week, there are massive problems.
2. Pages and images don't load, especially "Yahoo", but also other sites, stores, checkout processes.
3. Images are not shown
4. I get blank white pages, when clicking on articles and links
5. The problems progressed. Every day, Firefox was glitching more.


Expected results:

1. Firefox should have worked properly like it did before
2. I want to keep Firefox as my browser - I love it.

Thank you
Bug: TypeError: can't access property "toggleAttribute", this.toolbarButton is null
Status: RESOLVED
Priority: --
Resolution: FIXED
Created: 2024-10-08 12:11:14+00:00
Resolved: 2025-01-01 09:47:12+00:00

Seeing this on startup on yesterday's nightly (from https://hg.mozilla.org/mozilla-central/rev/e5eef47a4db1acee5e17f5b4ea6219301d995c63 ).

Full stack:

```
TypeError: can't access property "toggleAttribute", this.toolbarButton is null
    updateToolbarButton chrome://browser/content/sidebar/browser-sidebar.js:1006
    onCreated resource:///modules/CustomizableWidgets.sys.mjs:301
    aEventName resource:///modules/CustomizableUI.sys.mjs:3401
    buildWidget resource:///modules/CustomizableUI.sys.mjs:2162
    getWidgetNode resource:///modules/CustomizableUI.sys.mjs:1457
    buildArea resource:///modules/CustomizableUI.sys.mjs:1251
    registerToolbarNode resource:///modules/CustomizableUI.sys.mjs:1162
    registerToolbarNode resource:///modules/CustomizableUI.sys.mjs:4505
    onDOMContentLoaded chrome://browser/content/browser-init.js:171
```

Looks like that should use the method argument instead of hardcoding `this.toolbarButton`, as it [gets passed through](https://searchfox.org/mozilla-central/rev/b784b4ed27d0fc41a9bbce7d666e1cfcac4778be/browser/components/customizableui/CustomizableWidgets.sys.mjs#301) and will not be in the DOM at this point.
Bug: Keyboard shortcuts aren't localized in the pdf.js viewer
Status: NEW
Priority: P3
Created: 2024-10-08 14:32:44+00:00
Resolved: 2024-10-08 14:32:44+00:00

While looking at the bug https://github.com/mozilla/pdf.js/issues/18856, I was wondering if shortcuts must be "translated" and after few queries on searchfox, I found:
 - https://searchfox.org/mozilla-central/source/toolkit/locales/en-US/toolkit/global/textActions.ftl
 - https://searchfox.org/mozilla-central/source/browser/locales/en-US/browser/browserSets.ftl

So we must do the same in the pdf.js viewer.
Bug: "List all tabs" button fails to open from overflow menu with large numbers of tabs
Status: VERIFIED
Priority: P2
Resolution: FIXED
Created: 2024-10-08 14:36:15+00:00
Resolved: 2024-11-18 09:41:04+00:00

STR:
1. Start with `sidebar.verticalTabs = true` and `sidebar.revamp = true`.
2. Create several thousand tabs (Ctrl+T).
3. Shrink the window width until the "List all tabs" button goes into the overflow.
4. Click the overflow button and then click "List all tabs".

Expected:
"List all tabs" button does not go into overflow menu (like the Extensions button) or it opens reliably in the overflow menu.

Actual:
"List all tabs" button goes into overflow menu and fails to open with large numbers of tabs. The tab list is not just slow to open, it never opens even after waiting for some time (Windows 11 and Ubuntu 24.04).

The button cannot be manually moved into the overflow menu in Customize mode but still goes there when overflowing.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=b17f4d3142eeb0488513b984c8f5113e80101b96&tochange=82dacb5e3821fc0081deed13bd932839d65867e0

Regressed by Bug 1899598.
Bug: new toolbar widgets relocate "new tab +" from end of tab bar to front of tab bar
Status: RESOLVED
Priority: --
Resolution: INCOMPLETE
Created: 2024-10-08 17:33:35+00:00
Resolved: 2024-11-11 16:16:42+00:00

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:132.0) Gecko/20100101 Firefox/132.0

Steps to reproduce:

click right side tab bar + customize -> drag "new tab +" control to right hand side of tab bar, control is properly place  useragentID = c35f9c92041a405ab76a222b3e1e78ae


Actual results:

open a new browser -> "new tab +" control moves to front of tab bar (far left hand side)  useless location, bad UX.


Expected results:

new browser instance should preserve the control location at end of tab line or where ever the user places it.
Bug: PDF.js "test/pdfs/pattern_text_embedded_font.pdf" incorrectly Flagged As Malware
Status: RESOLVED
Priority: --
Resolution: WONTFIX
Created: 2024-10-08 18:25:40+00:00
Resolved: 2024-10-09 17:25:11+00:00

Steps to reproduce:

There wasn't an "Other" category specifically for [PDF.js](https://github.com/mozilla/pdf.js) but this isn't really Firefox-specific either...

I checked out the aforementioned PDF.js source, and my Avast Antivirus flagged the file:

- `test/pdfs/pattern_text_embedded_font.pdf`

as **PDF:ExploitX-gen [Expl]** (Which isn't terribly helpful; Google didn't help)

```
Avast Security
Version 15.8.0 (f6eae069d8bb)
Virus definitions: 24100804
```

See: https://github.com/mozilla/pdf.js/pull/9090

Since that PR has been around since November 2017, it could certainly be a false positive; there wasn't anything in the PDF itself that *\*looked\** particularly malicious:

- A cursory inspection of the `PAXEKO+SourceSansPro-Bold` embedded font using "cfftot1 | t1disasm" looked like any other embedded font...

- I thought maybe it didn't like the `/OpenAction [3 0 R /Fit]`, but others in that directory have that, and seem to open just fine...

- I don't know much about Patterns, but the "/P1" pattern in `7 0 obj` looks pretty benign...

- Which I guess leads me to the "/P2" pattern in `8 0 obj`, but even that looks similar to other Patterns in other test PDFs in that directory...

So, like I say, it's *PROBABLY* a false positive, but I don't trust my knowledge and understanding of PDF formats well enough to say that with any authority — which is also why, out of an over-abundance of precaution, I went ahead and clicked the "Keep It Hidden From The Public" — even though the only people who would possibly be affected are developers who explicitly check-out the source code...  «grin»


Actual results:

Avast Antivirus flagged the file:

- `test/pdfs/pattern_text_embedded_font.pdf`

as **PDF:ExploitX-gen [Expl]** and moved it to Quarantine


Expected results:

Obviously one would expect all files "should" pass AV checks, hehe...
Bug: MacOS browser (nightly). When using the address bar the suggestions background contains text from the bookmarks bar.
Status: RESOLVED
Priority: --
Resolution: DUPLICATE
Created: 2024-10-08 19:09:27+00:00
Resolved: 2024-10-08 21:49:35+00:00

User Agent: Mozilla/5.0 (iPhone; CPU iPhone OS 18_0 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) FxiOS/131.0  Mobile/15E148 Safari/605.1.15

Steps to reproduce:

Latest browser (nightly) on MacOS. Enable bookmarks bar always on. Go to the address bar and ensure there are enough bookmarks in bar and enough suggestions in dropdown to collide.

User agent: 
Mozilla/5.0 (Macintosh; Intel Mac OS X; tv:133.0) Gecko/20100101 Firefox/133.0

I really like the new change removing the top space on the web browser btw, excellent adjustment. 🙌


Actual results:

The bookmarks bar text is laid under the suggestion text from the address bar.


Expected results:

The address bar drop down should be opaque over the entire view not just the actual browser content.
Bug: Vertical tabs' X Close buttons are flush with the right edge of the tab. No padding or spacing.
Status: VERIFIED
Priority: --
Resolution: FIXED
Created: 2024-10-08 21:33:15+00:00
Resolved: 2024-11-21 06:41:53+00:00

I bisected this bug to this autoland pushlog for bug 1919403 and bug 1910358, so I don't know which changeset caused this bug:

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=53cefe94a9f5cd1c032f7168cb373585cbc73a24&tochange=35e7e206ededcb1f8e4a0fec4a5d5eb60e6f48ba

@ tgiles: do you think this bug could have been caused by your fix for vertical space bug 1910358?

@ mstriemer: do you think this bug could have been caused by your fix to unify sidebar sizes in bug 1910358?