av9ash/GitBugs huggingface dataset:
Bug: irc and ircs actions in about:preferences do not appear correctly when browser.download.improvements_to_download_panel is true
Status: VERIFIED
Priority: --
Resolution: FIXED
Created: 2021-10-12 20:28:06+00:00
Resolved: 2021-11-02 14:38:36+00:00

[Reproduction steps]
1. Enable `browser.download.improvements_to_download_panel` in `about:config`
2. Go to `about:preferences`
3. See that "Always ask" does not appear for content types `irc` and `ircs`

Happens when starting a new profile, but can also happen with existing profiles. Switching pref back to false and refreshing `about:preferences` will show "Always ask" again as expected.

This issue can technically be easily resolved by manually setting a preferred action for either content type, but it may be worth looking into so that the actions appear as expected for new profiles/new users.
Bug: Intermittent browser/components/search/test/browser/browser_contentSearchUI.js | Uncaught exception - Waiting for suggestions - timed out after 50 tries.
Status: RESOLVED
Priority: P5
Resolution: INCOMPLETE
Created: 2021-10-12 20:34:11+00:00
Resolved: 2022-03-15 17:02:27+00:00

**Filed by:** malexandru [at] mozilla.com
**Parsed log:** https://treeherder.mozilla.org/logviewer?job_id=354533908&repo=autoland
**Full log:** https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/T2diMjrTQ8upAy37D3m8VQ/runs/0/artifacts/public/logs/live_backing.log

---
```
[task 2021-10-12T19:17:25.234Z] 19:17:25     INFO - TEST-PASS | browser/components/search/test/browser/browser_contentSearchUI.js | Search event data - 
[task 2021-10-12T19:17:25.234Z] 19:17:25     INFO - Buffered messages logged at 19:17:19
[task 2021-10-12T19:17:25.234Z] 19:17:25     INFO - Console message: [JavaScript Warning: "telemetry.state_file_read_errors - Unknown scalar."]
[task 2021-10-12T19:17:25.235Z] 19:17:25     INFO - Console message: [JavaScript Warning: "telemetry.generated_new_client_id - Unknown scalar."]
[task 2021-10-12T19:17:25.235Z] 19:17:25     INFO - Buffered messages finished
[task 2021-10-12T19:17:25.236Z] 19:17:25     INFO - TEST-UNEXPECTED-FAIL | browser/components/search/test/browser/browser_contentSearchUI.js | Uncaught exception - Waiting for suggestions - timed out after 50 tries.
[task 2021-10-12T19:17:25.236Z] 19:17:25     INFO - Leaving test bound search
[task 2021-10-12T19:17:25.236Z] 19:17:25     INFO - Entering test bound settings
[task 2021-10-12T19:17:30.227Z] 19:17:30     INFO - Leaving test bound settings
[task 2021-10-12T19:17:30.227Z] 19:17:30     INFO - Entering test bound cleanup
[task 2021-10-12T19:17:30.240Z] 19:17:30     INFO - Leaving test bound cleanup
[task 2021-10-12T19:17:30.612Z] 19:17:30     INFO - GECKO(1228) | MEMORY STAT | vsize 19406153MB | vsizeMaxContiguous 65179834MB | residentFast 973MB
[task 2021-10-12T19:17:30.622Z] 19:17:30     INFO - TEST-OK | browser/components/search/test/browser/browser_contentSearchUI.js | took 30784ms
[task 2021-10-12T19:17:30.655Z] 19:17:30     INFO - checking window state
[task 2021-10-12T19:17:30.670Z] 19:17:30     INFO - TEST-START | browser/components/search/test/browser/browser_contentSearchUI_default.js
```
Bug: Leaking all bookmarks when a user tries to view a malicious bookmark URL from the exported bookmarks HTML file
Status: VERIFIED
Priority: P2
Resolution: FIXED
Created: 2021-10-13 04:16:40+00:00
Resolved: 2024-05-30 17:49:41+00:00

An attacker can steal all the user's bookmarks if the steps described below are done at any point in time by the victim.

The core of the issue is that bookmark URLs can be javascript URIs that will execute javascript when accessed from the exported bookmarks HTML file.

Note that although the attack takes a few steps to work, they are normal actions that don't need to occur at the same time and that they can happen organically.

1. The user adds a malicious URL to their bookmarks.
2. Later on, the user exports their bookmarks through the "Export Bookmarks to HTML" functionality (the exported file is an HTML).
3. The user opens the exported bookmarks HTML file and clicks on the malicious URL.
4. The URL is a malicious javascript URI that will execute in the context of the local file and will be able to steal all the user's bookmarks.

A simple fix would be to add a Content Security Policy using a <meta> tag to the <head> of the exported bookmarks HTML file.

Here's an unlisted video simulating the attack:
https://youtu.be/_6zUg-FtHe0

VERSION
Version: 93.0 (64-bit)
Operating System: Windows 10

REPRODUCTION CASE
1. Access https://lbherrera.github.io/lab/firefox/bookmarks-7633458/index.html
2. Drag the link to the bookmarks bar (or add it to your bookmarks some other way).
3. Access the "Manage bookmarks" menu.
4. Click on "Import and Backup" and then in the "Export Bookmarks to HTML..." option.
5. Save the HTML file and open it.
6. Click on the "Add me to your bookmarks" link that was previously added.
7. A malicious javascript will run in the context of the local bookmarks HTML file and would be able to leak all the victim's bookmarked URLs.

I have also attached the file used in the PoC - if you prefer, you can reproduce it by downloading and hosting index.html on a web server.

CREDIT INFORMATION
Reporter credit: Luan Herrera (@lbherrera_)
Bug: Upgrade spotlight: Theme variation radio buttons all have "Use this colorway" as a11y label
Status: VERIFIED
Priority: P1
Resolution: FIXED
Created: 2021-10-13 05:00:17+00:00
Resolved: 2023-06-02 15:22:25+00:00

STR (with a screen reader):

1. Open the browser console and enter:
    `Cc["@mozilla.org/browser/browserglue;1"].getService().wrappedJSObject._showUpgradeDialog()`
2. Press the Explore colorways button.
3. Choose to explore abstract colorways.
4. Tab to the "Soft" radio button.
    - Expected: The screen reader reports "Soft" as the label of the radio button.
    - Actual: The screen reader reports "Use this colorway".

The labels "Soft", "Balanced" and "Bold" are set as the textContent of the radio inputs. This is non-standard and is thus not exposed to accessibility.

The correct fix is either to move the text outside of the input or to set aria-label. Both of these would require changes to l10n strings, which probably isn't feasible at this point.

We can get the correct string at runtime. However, we can't set the aria-label attribute because Fluent clobbers it.

I'll attach a patch which creates a hidden label node and references it with aria-labelledby. It's really ugly, but I honestly don't think there's a better option at this point without messing with strings.
Bug: about:welcome: Theme radio buttons have no text in NVDA browse mode
Status: VERIFIED
Priority: P2
Resolution: FIXED
Created: 2021-10-13 05:10:42+00:00
Resolved: 2023-06-02 15:22:26+00:00

STR (with the NVDA screen reader):

1. Go to about:welcome
2. Press "Get started", then skip import with "Not now".
3. Press control+home to move to the top of the document.
4. Press down arrow three times.
    - Expected: NVDA should say "radio button checked  Explore default themes."
    - Actual: NVDA says just "radio button checked"

The issue here is that the radio button is being labelled by its parent `<label>` element, but that label element has no text; it only has a title attribute. NVDA sees that the `<label>` is visible, so it doesn't report the label of the radio button itself to avoid duplication and instead relies on the text of the label itself... but there's no text!

The correct fix is probably to put aria-label in the l10n strings. That's probably not feasible at this point.

I'm trying to figure out a fix that doesn't involve messing with l10n strings. We can't set aria-label at runtime because Fluent will clobber it. Hackily creating a hidden label element containing the label as its text content and referencing it with aria-labelledby might work. I'm not sure whether that's possible with React, though.
Bug: about:welcome: aria-description on colorways variation radio buttons isn't useful and is confusing in NVDA browse mode
Status: RESOLVED
Priority: P2
Resolution: WONTFIX
Created: 2021-10-13 05:22:01+00:00
Resolved: 2023-06-02 15:22:26+00:00

STR (with the NVDA screen reader):

1. Go to about:welcome
2. Press "Get started", then skip import with "Not now".
3. Press control+home to move to the top of the document.
4. Press down arrow 4 times to move to the radio button to explore abstract colorways.
5. Press space to select it.
6. Press down arrow until NVDA says "Abstract".
7. Press down arrow again.
    - Expected: NVDA should say "radio button checked". (The label is on the next line because its text is visible.)
    - Actual: NVDA says "radio button checked  Use this colorway"

First, I don't think the "Use this colorway" text really offers anything useful to the user, yet it gets repeated for each option.

Second, the label is visible, so NVDA doesn't report the label on the radio button itself in favour of the text of the actual label. That means that the aria-description ("Use this colorway") gets reported first.

I think the correct fix here is to remove aria-description from the l10n strings. That's probably not feasible at this point. However, we can probably just remove the data-l10n-attrs attribute, since I guess aria-description isn't in the builtin list of attributes to be localised (yet).
Bug: Firefox home empty and pinned tabs gone after resteart
Status: RESOLVED
Priority: --
Resolution: WORKSFORME
Created: 2021-10-13 06:13:17+00:00
Resolved: 2024-08-02 05:46:57+00:00

User Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:93.0) Gecko/20100101 Firefox/93.0

Steps to reproduce:

Start Firefox after a computer restart. It hadn't crashed in the last session, I had just closed it with ctrl+Q, closing several windows at the same time.


Actual results:

The Firefox home is empty, it shows a blank screen on every new tab or window. Settings still show that the Firefox Home is set for homepage/new windows and new tabs.

Besides, my pinned tabs are gone.

This problem persists across browser restarts, and it seems somehow associated to the profile. If I create a new profile, it works again as expected, until the new profile gets somehow corrupted and the same error starts happening there.


Expected results:

The Firefox home shows as usual, my pinned tabs from the previous session are still there.
Bug: Firefox 93.0 (64-bit) in Macbook Pro Keeps crashing when using Keyboard Shortcut to switch tabs
Status: UNCONFIRMED
Priority: --
Created: 2021-10-13 07:38:51+00:00
Resolved: 2021-10-27 12:11:13+00:00

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:93.0) Gecko/20100101 Firefox/93.0

Steps to reproduce:

Switch tabs using keyboard shortcut -> Command + Tab


Actual results:

Firefox crashed and closed


Expected results:

Switch tabs
Bug: bookmarks suddenly load very slowly
Status: RESOLVED
Priority: --
Resolution: DUPLICATE
Created: 2021-10-13 08:05:00+00:00
Resolved: 2021-10-13 13:52:06+00:00

User Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:93.0) Gecko/20100101 Firefox/93.0

Steps to reproduce:

Use my bookmarks from the bookmark menu (drop down)


Actual results:

The bookmarks in the bookmark menu (drop down) take very long to load since the last update (FF93). Or, more precisely, they load (drop down) quickly but it takes a long time before you can select and click on one. I have hundreds of bookmarks but I need them all. 


Expected results:

Quickly load and select bookmarks, as in previous versions. It seems to me FF93 is too economical in using resources. See also issue 89996.
Bug: cannot turn off "did you mean to go to..." web search result
Status: VERIFIED
Priority: P3
Resolution: FIXED
Created: 2021-10-13 13:01:42+00:00
Resolved: 2022-08-16 13:36:15+00:00

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:93.0) Gecko/20100101 Firefox/93.0

Steps to reproduce:

Do a simple firefox search for a single word like "snl"


Actual results:

At the top of the result page there is a on line dialog box saying something like "Did you mean to go to http://snl/" with a "yes take me too..." button to its right.


Expected results:

Normal search results without this extra dialog box.  This has not appeared in firefox until the last several weeks.  There is no apparent way to turn it off.  Web searches turn up lots of long suggestions about fiddling with dns settings or resetting modems or other nonsense (and I do know what dns is - the point is that there is no apparent way to revert to the previous behavior where this did _not_ appear, and that is the fix that is needed.)  Please disable this by default or at least provide a simple, transparent way to disable it.  It is not acceptable as-is, and descriptions of how to fiddle with internet or dns configurations are not appropriate either.
Bug: Firefox has overwritten all my Adobe PDF files with Firefox HTML files and will not allow me to change this
Status: RESOLVED
Priority: --
Resolution: WORKSFORME
Created: 2021-10-13 15:26:09+00:00
Resolved: 2021-10-15 13:33:37+00:00

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:93.0) Gecko/20100101 Firefox/93.0

Steps to reproduce:

Nothing, but when Firefox was last updated all my Adobe PDF files on my hard drive were changed to Firefox HTML files.


Actual results:

all my Adobe PDF files on my hard drive were changed to Firefox HTML files


Expected results:

Nothing the update did not ask me if i wanted to use Firefox to open PDF files and now it will not allow me to save PDF files as Adobe files.  Over five hundred files have been affected.
Bug: "Show all downloads" button in the downloads arrowpanel has a visible border
Status: RESOLVED
Priority: --
Resolution: FIXED
Created: 2021-10-13 18:25:44+00:00
Resolved: 2021-10-15 09:54:37+00:00

This button [1] should be a `toolbarbutton`, but changing that makes the expectFocusOnF6 test fail, I think here:
https://searchfox.org/mozilla-central/rev/b822a27de3947d3f4898defac6164e52caf1451b/browser/base/content/test/general/browser_documentnavigation.js#286

[1] https://searchfox.org/mozilla-central/rev/b822a27de3947d3f4898defac6164e52caf1451b/browser/components/downloads/content/downloadsPanel.inc.xhtml#151
Bug: SubDialog.jsm incorrectly gets scrollbars when contained content has borders
Status: RESOLVED
Priority: P1
Resolution: DUPLICATE
Created: 2021-10-13 19:03:15+00:00
Resolved: 2021-10-15 16:37:41+00:00

When SubDialog.jsm resizes the dialog frame to contain the content, if the content has a border, it doesn't correctly include those, and the dialog ends up with scrollbars.

Patch forthcoming.

Just put this in Messaging System for now as a way of tracking my current work.
It can be moved to Toolkit/Alerts & Notifications later.
Bug: Send Link has <a> tag hyperlink with encoded href attribute
Status: RESOLVED
Priority: --
Resolution: DUPLICATE
Created: 2021-10-13 19:52:01+00:00
Resolved: 2021-12-04 22:53:07+00:00

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:92.0) Gecko/20100101 Firefox/92.0

Steps to reproduce:

1. With Firefox 93.X on macOS, access and load a URL that includes a query string (Such as: http://domain.local/object?v=9999)
2. Share URL from Step 1 with Firefox via File > Share > Mail (Apple Mail)
3. Compose and send the email created by Firefox in Step 2 to yourself via Apple Mail
4. Check your Apple Mail's Inbox and open the email sent in Step 3
5. In the body of the email sent by Step 3, click on the hyperlink of the URL from Step 1 shared by Firefox from Step 2
6. Firefox opens incorrect URL with invalid query string
7. Repeat steps 1 through 5 with Firefox v92.0.1
8. Firefox opens correct URL with valid query string

See attached screen grab showing hyperlink with encoded query string using FFv93.X


Actual results:

The <a> tag hyperlink in the href attribute for the URL in the body of email has an "encoded" query string of http://domain.local/object?v%3D9999 and thus doesn't pass the query string to the host.


Expected results:

The <a> tag hyperlink in the href attribute for the URL in the body of email 
should be sent "decoded" as http://domain.local/object?v=9999 and pass the proper query string to the host
Bug: Firefox icon suddenly missing in taskbar on Windows 10
Status: RESOLVED
Priority: --
Resolution: INCOMPLETE
Created: 2021-10-13 20:37:11+00:00
Resolved: 2021-11-15 09:16:50+00:00

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:95.0) Gecko/20100101 Firefox/95.0

Steps to reproduce:

Unsure how this happened.


Actual results:

I have been using Firefox Nightly for the past 3 years with no issues. On Saturday, I turned my computer and the Firefox icon was missing from the taskbar (a dead image). The Windows notification said the destination was moved or missing. I figured there must have been an update that changed the folder name, but when I went into Programs, Firefox Nightly was completely gone. I checked Program Files, Programs Files (x86), the Recycle Bin, etc... but everything Firefox, Mozilla Firefox, Nightly, etc. was completely gone. I ran two virus scans on my computer, and both came out clean. I assumed it was a bug from some kind of update, so I reinstalled Nightly and it worked for a few days.
Today, I turned my computer on and the same thing happened: Firefox Nightly was completely gone and there was no trace of it on my desktop except for a folder called "Old Firefox Data".

I don't know how this happened. I have not downloaded any major updates nor installs on my computer lately (I've only been using my computer for work and social media), so I can't figure out what is causing this to keep happening.
Bug: Clear button in Library Search fields is missing
Status: RESOLVED
Priority: --
Resolution: DUPLICATE
Created: 2021-10-14 01:32:57+00:00
Resolved: 2021-10-14 03:54:22+00:00

Search for something in the Library window or sidebar. Since FF 93 no clear button is shown after entering text in these search fields. (On Linux x86_64 Ubuntu 20.04)

Is this a regression or an intended change?
Please restore the clear buttons. It is inconvenient to clear the search text with backspace to return to the normal unfiltered view.
Bug: Quickly clicking "explore colorways" then "keep previous" twice makes upgrade spotlight stuck
Status: VERIFIED
Priority: P1
Resolution: FIXED
Created: 2021-10-14 01:37:53+00:00
Resolved: 2021-10-29 08:01:58+00:00

Bug 1728853 introduced reverting to previous theme on secondary button of second screen. This waits for the `AddonManager.getAddonsByTypes` promise to resolve before continuing to the next screen. This allows additional clicks to be handled concurrently and that breaks things.

https://searchfox.org/mozilla-central/rev/0998b61022a1ece43afe3c750077e5804c6c6392/browser/base/content/upgradeDialog.js#324-326
Bug: Find in page doesn't bring the right text in view
Status: NEW
Priority: P3
Created: 2021-10-14 07:42:25+00:00
Resolved: 2022-02-04 17:06:10+00:00

STR:
1) Open https://bug1716758.bmoattachments.org/attachment.cgi?id=9240560
2) Press Ctrl+F
3) Write "Old Age"
4) Press ENTER or click on the down arrow in the find bar

"Old Age" text is highlighted, but Firefox doesn't scroll it into view, it scrolls to a spot in the page which is higher than where the "Old Age" text is.
Bug: Links in some xfa don't work
Status: VERIFIED
Priority: P3
Resolution: FIXED
Created: 2021-10-14 08:21:18+00:00
Resolved: 2022-01-10 12:40:29+00:00

For example the link on the top of the first page in:
https://bugzilla.mozilla.org/attachment.cgi?id=9227382
doesn't work.
Bug: mouse cursor hit point is misaligned
Status: RESOLVED
Priority: --
Resolution: WORKSFORME
Created: 2021-10-14 09:35:15+00:00
Resolved: 2021-10-15 14:10:49+00:00

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:93.0) Gecko/20100101 Firefox/93.0

Steps to reproduce:

I am not really sure, it just started happening.

I do not think this is a firefox bug, as it only happens in one of my profiles and it works fine on the other profile on the same computer. I just need pointers and guidance to help me troubleshoot and fix the issue.

I don't think it is a problem with an extension, as it happens on the firefox' native "Settings" page, as can be seen in the attached partial screenshot.


Actual results:

The mouse cursor hit point is misaligned from the actual cursor when using my work firefox profile. Strangely enough, in the same computer, the issue does not happen when using my private profile. 

I have attached a partial screenshot to demonstrate the issue. According to the mouse cursor position, the "Advanced" button should be highlighted, but the "Colours" button below is highlighted instead.

The effect is even worse when with a text caret cursor as the hit point seems to be 5 pixels below (outside) the actual cursor.


Expected results:

The hit point of the mouse cursor should be placed in the tip of the arrow cursor and at the middle of the caret cursor.

Thank you.
Bug: Sponsored topsites tile image gets refreshed when refreshing the NTP
Status: NEW
Priority: --
Created: 2021-10-14 10:24:18+00:00
Resolved: 2021-10-14 10:25:30+00:00

##### [Description:]
Sponsored topsites image flicker as being refreshed or refetched when refreshing the NTP.

##### [Environments:]
* Windows 10 
* Mac 11

with

* 93
* 94.0b5
* 95.0a1 2021-10-13



##### [Steps:]
1. Profile with set region to sponsored available (e.g.: US) with vpn to match it.
2. Open new tab page.
3. Refresh the NTP.


##### [Actual Result:]
In the e.g. case: US region: the amazon and ebay are the sponsored tiles and their tile images flicker as being refreshed, although there shouldn't be any reason for doing so.

##### [Expected Result:]
The sponsored tiles should behave as the normal tiles, NTP refresh should not trigger tile refresh/refetch.