av9ash/GitBugs huggingface dataset:
Bug: Add a virtual table to list snapshots
Status: Resolved
Priority: Normal
Resolution: Fixed
Created: 08/Dec/22 01:06
Resolved: 22/Mar/23 13:24

It should be possible to query a node's snapshots via virtual tables.

The table should expose the same fields/columns as the [TableSnapshot|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/service/snapshot/TableSnapshot.java] class.

Something along these lines:
{noformat}
cqlsh> SELECT * FROM system_views.snapshots;
 
tag | keyspace_name | table_name |  table_id | is_ephemeral | created_at | expires_at | directories
----+---------------+------------+-----------+--------------+-----------+------------+------------
1670460346841 | system | compaction_info | 123e4567-e89b-12d3-a456-426614174000 | false | 2022-12-08T00:45:47.108Z | null | {'/var/lib/cassandra/data/system/compaction_history-b4dbb7b4dc493fb5b3bfce6e434832ca/snapshots/1670460346841'}
{noformat}
Bug: Several CQLSH Completions are incomplete
Status: Resolved
Priority: Normal
Resolution: Duplicate
Created: 02/Nov/22 13:27
Resolved: 15/Nov/22 13:32

The following are missing IF EXISTS / NOT EXISTS syntax for completions:
 * createUserType/dropRoleStatement
 * createRoleStatement/dropRoleStatement

In addition:
 * Capture has a misplaced parenthesis
 * Paging should use <wholenumber> instead of a custom RegEx

Note, there are no existing unit tests for the above commands, but they'll be added as part of rounding out the completion unit test in CASSANDRA-16640.
Bug: CircleCI: j11_utests_fqltool fails to build
Status: Resolved
Priority: Normal
Resolution: Fixed
Created: 07/Nov/22 15:21
Resolved: 07/Nov/22 17:35

The new {{j11_utests_fqltool}} job introduced by CASSANDRA-17987 fails to build.

That seems due to using the wrong executor [here|https://github.com/apache/cassandra/blob/trunk/.circleci/config-2_1.yml#L1452-L1453].
Bug: Race condition on repair snapshots
Status: Resolved
Priority: Normal
Resolution: Fixed
Created: 10/Oct/22 00:39
Resolved: 27/Oct/22 14:52

If an endpoint is convicted and that endpoint is a coordinator then ActiveRepairService::removeParentRepairSession is called.

The issue is that this occurs on clearSnapshotExecutor and can happen while RepairMessageVerbHandler is in process of taking a snapshot. So then you get a race condition and clearSnapshot will throw a java.nio.file.DirectoryNotEmptyException

 
{code:java}
public static void deleteRecursiveWithThrottle(File dir, RateLimiter rateLimiter)
{
    if (dir.isDirectory())
    {
        String[] children = dir.list();
        for (String child : children)
            deleteRecursiveWithThrottle(new File(dir, child), rateLimiter);
    }

    // The directory is now empty so now it can be smoked
    deleteWithConfirmWithThrottle(dir, rateLimiter);
} {code}
Due to the directory not being empty when it goes to remove the directory at the end.
Bug: Upgrade back Mockito to 4.7.0 after CASSANDRA-17750
Status: Resolved
Priority: Normal
Resolution: Fixed
Created: 03/Oct/22 20:32
Resolved: 03/Oct/22 23:39

Update of ASM(9.1 to 9.3), Mockito(3.2.4 to 4.7.0) and ByteBuddy(1.10.10 to 1.12.13) happened in CASSANDRA-17835

It seems during rebase in the next commit some changes were discarded:

Mockito was downgraded back to 3.2.4.

We need to fix this. The other two dependencies are at the right version.

CC [~aratnofsky] , [~dcapwell] and [~mck]
Bug: Cqlshlib tests are j11 greedy
Status: Resolved
Priority: Normal
Resolution: Fixed
Created: 14/Nov/22 09:11
Resolved: 15/Nov/22 08:38

[~e.dimitrova] found out cqlshlib test runs are j11 greedy. Despite j8 being specified if a JAVA11_HOME is present it will compile with j8 but ccm will effectively run them with j11.
Bug: When generate.sh fails its rc=0
Status: Resolved
Priority: Normal
Resolution: Fixed
Created: 10/Nov/22 17:45
Resolved: 16/Jan/23 06:15

{code}
$ ./generate.sh -a
Generating new config.yml file with low resources and LOWRES/MIDRES/HIGHRES templates from config-2_1.yml
./generate.sh: line 171: circleci: command not found
patching file ./config-2_1.yml
Hunk #4 succeeded at 1511 (offset 9 lines).
Hunk #5 succeeded at 1525 (offset 9 lines).
Hunk #6 succeeded at 1540 (offset 9 lines).
Hunk #7 succeeded at 1554 (offset 9 lines).
Hunk #8 succeeded at 1569 (offset 9 lines).
Hunk #9 succeeded at 1583 (offset 9 lines).
Hunk #10 succeeded at 1598 (offset 9 lines).
Hunk #11 succeeded at 1616 (offset 9 lines).
Hunk #12 succeeded at 1631 (offset 9 lines).
Hunk #13 succeeded at 1649 (offset 9 lines).
Hunk #14 succeeded at 1664 (offset 9 lines).
Hunk #15 succeeded at 1682 (offset 9 lines).
Hunk #16 succeeded at 1697 (offset 9 lines).
./generate.sh: line 177: circleci: command not found
patching file ./config-2_1.yml
./generate.sh: line 183: circleci: command not found
{code}
Bug: pylib cqlsh tests fail on cython
Status: Resolved
Priority: Normal
Resolution: Fixed
Created: 10/Nov/22 10:52
Resolved: 10/Nov/22 13:49

Currently pylib/cqlsh tests _with_ cython where not being ran in [jenkins|https://ci-cassandra.apache.org/job/Cassandra-4.1-cqlsh-tests/181/]. Notice how cython yes and no run the same.

[~mck] managed to find where the flag was being dropped https://github.com/apache/cassandra-builds/pull/83

But cython compile failures arise where an updated is [suggested|https://github.com/cython/cython/issues/1943]
Bug: Mutation Serialization Caching
Status: Resolved
Priority: Normal
Resolution: Fixed
Created: 26/Oct/22 21:11
Resolved: 19/Dec/22 21:24

A performance change that adds mutation serialization caching to avoid re-serializing the mutation for commitlog and nodes twice. 
 * Cached serialization for storage proxy and local commitlog
 * Cached deserialization for messaging service and local commitlog

This yields a non trivial perf gain (~7-10%) and latency drop (median)

[https://tjake.github.io/other/cached-mutations-report.html]

 

The cached buffer is stored by MessagingService version to avoid being used by differing nodes during upgrades.

Also, It avoids caching mutations larger than a threshold to avoid GC issues. 

 

GH PR: https://github.com/apache/cassandra/pull/1954
Bug: Implement a guardrail for not having zero default ttl on tables with TWCS
Status: Resolved
Priority: Normal
Resolution: Fixed
Created: 14/Nov/22 11:18
Resolved: 02/Dec/22 11:31

A user was surprised that his data have not started to expire after 90 days on his TWCS, he noticed that default_time_to_live on the table was set to 0 (by accident from his side) and inserts were using TTL = 0 too.

It is questionable why it it possible to create a table with TWCS and enable a user to specify default_time_to_live to be zero.

On the other hand, I would argue that having default_time_to_live set to 0 on TWCS does not necessarily mean that such combination is illegal. It is about people just using that with advantage very often so tables are compacted away nicely. However, that does not have to mean that they could not use it with 0. But I yet have to see a use-case where TWCS was used and default ttl was set to 0 on purpose. Merely looking into Cassandra codebase, there are only cases when this parameter is not 0.

There are three approaches:

1) just reject such statements (for CreateTable and AlterTable statements) where default_time_to_live = 0
2) Implement a guardrail for 1) so it can be enabled / disabled on demand
3) Leave possibility to set default_time_to_live to 0 on a table but make a guardrail for UpdateStatement so it might reject queries for tables with default_time_to_live is zero and for which its TTL (on that update statement) is set to 0 too.

I would be careful about making the current configuration illegal because of backward compatibility. For that reason 2) makes the most sense to me.

Maybe implementing 3) would make sense as well. There might be a table which has default ttl set to 0 as it expects a user to supply TTL every time. However, as it is not currently enforced anywhere, a client might still insert TTLs to be set to 0 even by accident.

POC for 2) is here https://github.com/instaclustr/cassandra/commit/0b4dcc3d3deeffa393c02a3b80e27482007f9579
Bug: CircleCI: Skip checkstyle in the Ant-based repeated tests
Status: Resolved
Priority: Normal
Resolution: Fixed
Created: 27/Oct/22 15:48
Resolved: 04/Nov/22 16:32

The CircleCI jobs for repeating Ant-based tests include the {{checkstyle}} and {{checkstyle-test}} targets. Those targets are skipped for Java 11 but not for Java 8.

Including those targets on every test iteration produces a significant difference in the run times of repeated test jobs for j8 and j11:
 * [https://app.circleci.com/pipelines/github/adelapena/cassandra/2328/workflows/122d58b9-b454-4a99-8c46-f7777b7ef225/jobs/23225]
 * [https://app.circleci.com/pipelines/github/adelapena/cassandra/2328/workflows/50f33d9b-c7c6-4aa9-bac9-22ac78ad6b8c/jobs/23224]

We should use the {{no-checkstyle}} flag in the iterations done by those jobs. That should significantly speed up the jobs and save resources.

 

Thanks to [~bereng] , who detected the difference in the running times between j8 and j11.
Bug: SSTableIdGenerationTest.testRestartWithUUIDDisabled fails on trunk after CASSANDRA-17948
Status: Resolved
Priority: Normal
Resolution: Fixed
Created: 19/Oct/22 16:56
Resolved: 20/Oct/22 10:59

The test is failing consistently on trunk after CASSANDRA-17948

CC [~stefan.miklosovic] and [~brandon.williams] 

[https://butler.cassandra.apache.org/#/ci/upstream/compare/Cassandra-trunk/trunk]
{code:java}
junit.framework.AssertionFailedError: Forked Java VM exited abnormally. Please note the time in the report does not reflect the time until the VM exit. at java.util.Vector.forEach(Vector.java:1277) at java.util.Vector.forEach(Vector.java:1277) at java.util.Vector.forEach(Vector.java:1277) at org.apache.cassandra.anttasks.TestHelper.execute(TestHelper.java:53) at java.util.Vector.forEach(Vector.java:1277)
{code}
Bug: Remove -l / -m / -h designation and have two options: free or paid tier circle config
Status: Resolved
Priority: Normal
Resolution: Fixed
Created: 02/Nov/22 20:02
Resolved: 10/Mar/23 12:01

Currently the -h designation is wasteful and should not be used, and the -f designation won't actually successfully run to completion.

We should default to a "free tier" config (probably print a warning that it's generating config w/subset of full tests that should not be used to validate commits in big warning letters) that runs a subset of the test suites for users working on patches to validate their work (unit test only? unit + in-jvm dtest? TBD), and add a flag to generate a config using larger containers + parallelization for the "paid" tier for folks w/paid circleci accounts.,

It looks like -p is available right now fwiw.
Bug: Make CommitLogReplayer replay all tables in a keyspace when only keyspace is specified in cassandra.replayList property
Status: Resolved
Priority: Normal
Resolution: Fixed
Created: 14/Nov/22 15:46
Resolved: 24/Nov/22 18:24

CommitLogReplayer reacts on a property "cassandra.replayList" (1) which replays only some tables if needed upon commit log replay.

However, imagine you have a keyspace of 50 tables and other keyspace of 20 tables and you want to replay only all tables of the first keyspace.

Currently, an operator has to enumerate all 50 tables which is not desirable and it is error prone.

I suggest to change the logic in such a way that if there is only keyspace listed, we would retrieve all its tables dynamically in runtime and replayed only these.

The solution would be receptive to both keyspace.table as well as only "keyspace" format.

Valid examples of such property:

ks1,ks2,ks3.tb1 // it will retrieve all tables of ks1 and ks2 and appends ks3.tb1
ks1.tb1,ks2.tb2
ks1,ks2,ks3 // it will retrieve tables of all these keyspaces

[https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/commitlog/CommitLogReplayer.java#L379-L387]
Bug: Flaky test org.apache.cassandra.tools.TopPartitionsTest#testStartAndStopScheduledSampling
Status: Resolved
Priority: Normal
Resolution: Fixed
Created: 22/Nov/22 13:08
Resolved: 28/Aug/23 11:16

The test {{org.apache.cassandra.tools.TopPartitionsTest#testStartAndStopScheduledSampling}} is fails intermittently on trunk with CircleCI:
* https://app.circleci.com/pipelines/github/adelapena/cassandra/2508/workflows/92f054d7-9386-498f-9ba4-330181cd4782/jobs/24692
* https://app.circleci.com/pipelines/github/adelapena/cassandra/2511/workflows/7aba8baa-0a6d-404a-b08b-c6a8078caca3/jobs/24706/tests

The failure looks like:
{code}
junit.framework.AssertionFailedError: Scheduled sampled tasks should be removed expected:<[]> but was:<[*.*]>
	at org.apache.cassandra.tools.TopPartitionsTest.testStartAndStopScheduledSampling(TopPartitionsTest.java:116)
{code}
I haven't seen this failure on Butler/Jenkins yet, but it can be reproduced with the CircleCI multiplexer:
{code}
.circleci/generate.sh -m \
  -e REPEATED_UTESTS_COUNT=2000 \
  -e REPEATED_UTESTS=org.apache.cassandra.tools.TopPartitionsTest
{code}
It seems to fail 11 times on 2000 runs.
Bug: Add to the IntelliJ Git Window issue navigation links to Cassandra's Jira
Status: Resolved
Priority: Normal
Resolution: Fixed
Created: 19/Dec/22 23:21
Resolved: 10/Jan/23 08:30

It is possible to navigate from the IntelliJ IDEA Git window to a corresponding Cassandra issue, the Apache Jira if mentioned in the git message. The example in the attachments shows how _CASSANDRA-*_ letters are turned on in the commit message to an appropriate Cassandra Jira link.

We should update the IntelliJ IDEA configuration and make this behaviour a default for the {{ant generate-idea-files}} process.

To achieve this manually you can update your {{.idea/vcs.xml}} file in the Cassandra project with the following:
{code:java}
<?xml version="1.0" encoding="UTF-8"?>
<project version="4">
<component name="VcsDirectoryMappings">
<mapping directory="$PROJECT_DIR$" vcs="Git" />
</component>
<component name="IssueNavigationConfiguration">
<option name="links">
<list>
<IssueNavigationLink>
<option name="issueRegexp" value="CASSANDRA-(\d+)" />
<option name="linkRegexp"value="https://issues.apache.org/jira/browse/CASSANDRA-$1"/>
</IssueNavigationLink>
</list>
</option>
</component>
</project>
{code}
Bug: remove deprecated DateTieredCompactionStrategy
Status: Resolved
Priority: Normal
Resolution: Fixed
Created: 14/Nov/22 12:31
Resolved: 16/Mar/23 08:48

DTCS was marked as deprecated in CASSANDRA-9666 which was released in 3.0.8 and 3.8. If I get our deprecation policies right, we wait one major release (4.0) and we can remove it in the next one (5.0). Having 4.1 about to be released soon and 4.2 will be 5.0, I think nothing blocks us from removing this strategy in trunk.

This also makes CASSANDRA-18042 easier as it would most probably have to cover this strategy as well.
Bug: fqltool dump results NPE when null value inserted using prepared query
Status: Resolved
Priority: Normal
Resolution: Fixed
Created: 13/Dec/22 18:54
Resolved: 01/Feb/23 14:57

Enable fullquerylog, prepare insert statement and bind it with a null value and execute it. Executing fqltool dump after insert will result into NullPointerException.
 
Stept to reproduce:
    * Create cluster using ccm
    * Create  a table something like:
{code:java}
    CREATE TABLE ks1.t2 (
        id int PRIMARY KEY,
        value text
    ) ;
 {code}
    * Execute below code
{code:java}
    try (CqlSession cqlSession = CqlSession.builder().build()) {
        PreparedStatement preparedStatement = cqlSession.prepare("INSERT INTO ks1.t2 (id, value) VALUES (?, ?)");
        cqlSession.execute(preparedStatement.bind(6, null));
    }
{code}
    * Now running fqltool dump. It will run into NPE
 
 
Stack trace:
{code:java}
error: null
-- StackTrace --
java.lang.NullPointerException
    at net.openhft.chronicle.bytes.BytesStore.wrap(BytesStore.java:76)
    at net.openhft.chronicle.bytes.Bytes.wrapForRead(Bytes.java:179)
    at org.apache.cassandra.fqltool.commands.Dump.appendValuesToStringBuilder(Dump.java:222)
    at org.apache.cassandra.fqltool.commands.Dump.dumpQuery(Dump.java:179)
    at org.apache.cassandra.fqltool.commands.Dump.lambda$dump$0(Dump.java:123)
    at net.openhft.chronicle.queue.impl.single.StoreTailer.readDocument(StoreTailer.java:111)
    at org.apache.cassandra.fqltool.commands.Dump.dump(Dump.java:148)
    at org.apache.cassandra.fqltool.commands.Dump.run(Dump.java:68)
    at org.apache.cassandra.fqltool.FullQueryLogTool.main(FullQueryLogTool.java:65)
{code}
Bug: Use snake case for the names of CQL native functions
Status: Resolved
Priority: Normal
Resolution: Fixed
Created: 11/Nov/22 14:35
Resolved: 04/Apr/23 14:14

Most native functions are named all lower case, without underscore nor hyphen to separate words. That's the case, for example, of "intasblob" or "blobasint".

We also have some functions using camel case, as in "castAsInt" or "castAsTimestamp". Note that the came cased names require quoting due to CQL's case insensitivity.

Differently to CQL native functions, system keyspaces, tables and columns consistently use snake case. For example, we have "system_schema", "dropped_columns", "default_time_to_live".

As discussed in [this thread|https://lists.apache.org/thread/k9ml1k4fg6o7mfby1nr3y0mnq9r90dym], we should adopt snake_case for CQL native function names. Also we should provide aliases for the current function names, so we don't break compatibility.
Bug: fix flaky o.a.c.distributed.test.PaxosRepair2Test.paxosRepairHistoryIsntUpdatedInForcedRepair
Status: Resolved
Priority: Normal
Resolution: Fixed
Created: 14/Nov/22 22:45
Resolved: 03/May/23 20:58

This test was introduced by CASSANDRA-18029

 
{code:java}
junit.framework.AssertionFailedError: Repair failed with errors: [Repair session 864c53d0-61fe-11ed-935f-5103a8e332f7 for range [(-3074457345618258603,3074457345618258601], (9223372036854775805,-3074457345618258603], (3074457345618258601,9223372036854775805]] failed with error UNKNOWN failure response from /127.0.0.3:7012, Repair command #1 finished with error] at org.apache.cassandra.distributed.test.PaxosRepair2Test.lambda$repair$54f7d7c2$1(PaxosRepair2Test.java:186) at org.apache.cassandra.concurrent.FutureTask$1.call(FutureTask.java:96) at org.apache.cassandra.concurrent.FutureTask.call(FutureTask.java:61) at org.apache.cassandra.concurrent.FutureTask.run(FutureTask.java:71) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) at java.lang.Thread.run(Thread.java:748)
{code}
different error:
{code:java}
junit.framework.AssertionFailedError: Repair failed with errors: [Endpoint not alive: /127.0.0.3:7012, Repair command #1 finished with error]
	at org.apache.cassandra.distributed.test.PaxosRepair2Test.lambda$repair$54f7d7c2$1(PaxosRepair2Test.java:186)
	at org.apache.cassandra.concurrent.FutureTask$1.call(FutureTask.java:96)
	at org.apache.cassandra.concurrent.FutureTask.call(FutureTask.java:61)
	at org.apache.cassandra.concurrent.FutureTask.run(FutureTask.java:71)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
	at java.lang.Thread.run(Thread.java:748)
{code}
Bug: Circle repeated jobs shouldn't appear on default config files
Status: Resolved
Priority: Normal
Resolution: Fixed
Created: 08/Nov/22 09:52
Resolved: 08/Nov/22 17:57

It seems that when pushing a PR, the auto multiplexing of new tests triggers all multiplexing jobs, even if there are no tests present for that job.

That is wasteful as it means spinning up many nodes etc for nothing.
Bug: Change trunk 4.2 to 5.0
Status: Resolved
Priority: Normal
Resolution: Fixed
Created: 19/Oct/22 06:48
Resolved: 07/Mar/23 11:58

1. Bump trunk's version 
{code}
git switch trunk
# increment version to 5.0
edit build.xml debian/changelog CHANGES.txt NEWS.txt README.asc
{code}

2. Update jvm-dtest supported upgrade paths
 - https://github.com/apache/cassandra/blob/trunk/test/distributed/org/apache/cassandra/distributed/upgrade/UpgradeTestBase.java#L85-L96 

3. Update `4.2` to jira versions
Change `4.2` to `5.0`
Change `4.x` to `5.x`

4. Update docker images to include cassandra-5.0
(Docker images also need to be deployed)

5. Add pipeline to ci-cassandra
https://github.com/apache/cassandra-builds/blob/trunk/jenkins-dsl/cassandra_job_dsl_seed.groovy#L51

6. Add dtest version and upgrade paths
 - https://github.com/apache/cassandra-dtest/blob/trunk/upgrade_tests/upgrade_manifest.py
 - https://github.com/apache/cassandra/blob/trunk/.circleci/config.yml#L2374
 - https://github.com/apache/cassandra-builds/blob/trunk/build-scripts/cassandra-test.sh#L41

7. Update how_to_commit documentation
https://github.com/apache/cassandra-website/blob/trunk/site-content/source/modules/ROOT/pages/development/how_to_commit.adoc
Bug: Fix flaky test:org.apache.cassandra.net.HandshakeTest.testOutboundConnectionfFallbackDuringUpgrades
Status: Resolved
Priority: Normal
Resolution: Fixed
Created: 20/Oct/22 10:49
Resolved: 14/Feb/23 22:07

https://ci-cassandra.apache.org/job/Cassandra-trunk/1339/testReport/org.apache.cassandra.net/HandshakeTest/testOutboundConnectionfFallbackDuringUpgrades_cdc/

https://ci-cassandra.apache.org/job/Cassandra-trunk/1336/testReport/org.apache.cassandra.net/HandshakeTest/testOutboundConnectionfFallbackDuringUpgrades_compression/

https://app.circleci.com/pipelines/github/instaclustr/cassandra/1466/workflows/ffb52616-92d7-4089-a0c9-a9ebf28333c0/jobs/6296/tests

{noformat}
junit.framework.AssertionFailedError
	at org.apache.cassandra.net.HandshakeTest.testOutboundFallbackOnSSLHandshakeFailure(HandshakeTest.java:384)
	at org.apache.cassandra.net.HandshakeTest.testOutboundConnectionfFallbackDuringUpgrades(HandshakeTest.java:243)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
{noformat}
Bug: Improve git branch handling for CircleCI generate.sh
Status: Resolved
Priority: Normal
Resolution: Fixed
Created: 26/Oct/22 18:22
Resolved: 07/Jun/23 10:17

The generate.sh script assumes a base git branch that is local and named after the official repo branch (e.g. `cassandra-3.11`). This may not be a local branch if the developer has recently cloned the repo and is creating a work branch, and will lead to the git commands in generate.sh failing:

 

```

fatal: ambiguous argument 'cassandra-3.11...HEAD': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'

```

We should be able to make some sanity checks to better guide or warn the developer if things aren't set up properly to check against git.
Bug: Some tests are never executed due to naming violation - fix it and add checkstyle where applicable
Status: Resolved
Priority: Normal
Resolution: Fixed
Created: 17/Oct/22 09:10
Resolved: 28/Jan/23 22:30

[BatchTests|https://github.com/apache/cassandra/blob/trunk/test/unit/org/apache/cassandra/cql3/BatchTests.java] doesn't follow naming convention to be run as unit tests and, thus, is never run.
The rule in build expects names as `*Test`.
Bug: CircleCI: generate.sh without options modifies config
Status: Resolved
Priority: Normal
Resolution: Fixed
Created: 26/Oct/22 11:20
Resolved: 28/Oct/22 13:01

Calling {{.circleci/generate.sh}} without any options should print the help and exit without editing the {{config.yml}} file. However, after CASSANDRA-17939 it wrongly enters into the automatic detection of new or modified tests.