Source:
private boolean refreshIsoDomain(Guid storageDomainId, List<RepoFileMetaData> problematicRepoFileList, FileTypeExtension fileTypeExt) { boolean refreshSucceeded = false; List<RepoFileMetaData> tempProblematicRepoFileList = new ArrayList<RepoFileMetaData>(); List<StoragePoolIsoMap> isoMapList = DbFacade.getInstance() .getStoragePoolIsoMapDao() .getAllForStorage(storageDomainId); log.debugFormat("Fetched {0} storage pools for {1} file type, in Iso domain {2}.", isoMapList.size(), fileTypeExt, storageDomainId); Iterator<StoragePoolIsoMap> iter = isoMapList.iterator(); while (iter.hasNext() && !refreshSucceeded) { StoragePoolIsoMap storagePoolIsoMap = iter.next(); Guid storagePoolId = storagePoolIsoMap.getstorage_pool_id().getValue(); if ((storagePoolIsoMap.getstatus() != null) && (storagePoolIsoMap.getstatus() == StorageDomainStatus.Active)) { refreshSucceeded = refreshIsoDomainFileForStoragePool(storageDomainId, storagePoolId, fileTypeExt); } else { log.debugFormat("Storage domain id {0}, is not active, and there for could not be refreshed for {1} file type (Iso domain status is {2}).", storageDomainId, fileTypeExt, storagePoolIsoMap.getstatus()); } if (!refreshSucceeded) { log.debugFormat("Failed refreshing Storage domain id {0}, for {1} file type in storage pool id {2}.", storageDomainId, fileTypeExt, storagePoolId); if(storagePoolIsoMap.getstatus()!= StorageDomainStatus.Maintenance) { RepoFileMetaData repoFileMetaData = new RepoFileMetaData(); repoFileMetaData.setStoragePoolId(storagePoolId); repoFileMetaData.setRepoDomainId(storageDomainId); repoFileMetaData.setFileType(fileTypeExt); tempProblematicRepoFileList.add(repoFileMetaData); } } } if (!refreshSucceeded) { problematicRepoFileList.addAll(tempProblematicRepoFileList); } return refreshSucceeded; }

Target:
private boolean refreshIsoDomain(Guid storageDomainId, List<RepoFileMetaData> problematicRepoFileList, FileTypeExtension fileTypeExt) { boolean refreshSucceeded = false; List<RepoFileMetaData> tempProblematicRepoFileList = new ArrayList<RepoFileMetaData>(); List<StoragePoolIsoMap> isoMapList = DbFacade.getInstance() .getStoragePoolIsoMapDao() .getAllForStorage(storageDomainId); log.debugFormat("Fetched {0} storage pools for {1} file type, in Iso domain {2}.", isoMapList.size(), fileTypeExt, storageDomainId); Iterator<StoragePoolIsoMap> iter = isoMapList.iterator(); while (iter.hasNext() && !refreshSucceeded) { StoragePoolIsoMap storagePoolIsoMap = iter.next(); Guid storagePoolId = storagePoolIsoMap.getstorage_pool_id().getValue(); StorageDomainStatus status = storagePoolIsoMap.getstatus(); if (status != StorageDomainStatus.Active) { log.debugFormat("Storage domain id {0}, is not active, and therefore could not be refreshed for {1} file type (Iso domain status is {2}).", storageDomainId, fileTypeExt, status); } else { refreshSucceeded = refreshIsoDomainFileForStoragePool(storageDomainId, storagePoolId, fileTypeExt); if (!refreshSucceeded) { log.debugFormat("Failed refreshing Storage domain id {0}, for {1} file type in storage pool id {2}.", storageDomainId, fileTypeExt, storagePoolId); RepoFileMetaData repoFileMetaData = new RepoFileMetaData(); repoFileMetaData.setStoragePoolId(storagePoolId); repoFileMetaData.setRepoDomainId(storageDomainId); repoFileMetaData.setFileType(fileTypeExt); tempProblematicRepoFileList.add(repoFileMetaData); } } } if (!refreshSucceeded) { problematicRepoFileList.addAll(tempProblematicRepoFileList); } return refreshSucceeded; }