Source:
<code>private boolean loadSigningPolicy( GlobusResource policyResource, Map<String, SigningPolicy> policyMapToLoad, Map<URI, ResourceSigningPolicy> currentPolicyFileMap, long currentMillis) { String filename = policyResource.getFilename(); long now = currentMillis; boolean loaded = false; Long invalidCacheTime = invalidPoliciesCache.get(filename); if ((invalidCacheTime != null) && (now - invalidCacheTime < 10 * CACHE_TIME_MILLIS)) { <START> return loaded; <END> } try { URI uri; if (!policyResource.isReadable()) { throw new SigningPolicyStoreException("file is not readable"); } try { uri = policyResource.getURI(); } catch (IOException e) { throw new SigningPolicyStoreException(e); } ResourceSigningPolicy filePolicy = this.signingPolicyFileMap.get(uri); if (filePolicy == null) { try { filePolicy = new ResourceSigningPolicy(policyResource); } catch (ResourceStoreException e) { throw new SigningPolicyStoreException(e); } } Collection<SigningPolicy> policies = filePolicy.getSigningPolicies(); currentPolicyFileMap.put(uri, filePolicy); if (policies != null) { for (SigningPolicy policy : policies) { X500Principal caPrincipal = policy.getCASubjectDN(); policyMapToLoad.put(caPrincipal.getName(), policy); validPoliciesCache.put(caPrincipal.getName(), now); } } loaded = true; } catch (SigningPolicyStoreException e) { if ((invalidCacheTime == null) || (now - invalidCacheTime >= 10 * CACHE_TIME_MILLIS)) { logger.warn("Failed to load signing policy: " + filename + " : " + e.getMessage()); logger.debug("Failed to load signing policy: " + filename, e); invalidPoliciesCache.put(filename, now); } } return loaded; }</code><technical_language>Suggest returning explicit 'false'</technical_language>

Target:
private boolean loadSigningPolicy( GlobusResource policyResource, Map<String, SigningPolicy> policyMapToLoad, Map<URI, ResourceSigningPolicy> currentPolicyFileMap, long currentMillis) { String filename = policyResource.getFilename(); long now = currentMillis; boolean loaded = false; Long invalidCacheTime = invalidPoliciesCache.get(filename); if ((invalidCacheTime != null) && (now - invalidCacheTime < 10 * CACHE_TIME_MILLIS)) { return false; } try { URI uri; if (!policyResource.isReadable()) { throw new SigningPolicyStoreException("file is not readable"); } try { uri = policyResource.getURI(); } catch (IOException e) { throw new SigningPolicyStoreException(e); } ResourceSigningPolicy filePolicy = this.signingPolicyFileMap.get(uri); if (filePolicy == null) { try { filePolicy = new ResourceSigningPolicy(policyResource); } catch (ResourceStoreException e) { throw new SigningPolicyStoreException(e); } } Collection<SigningPolicy> policies = filePolicy.getSigningPolicies(); currentPolicyFileMap.put(uri, filePolicy); if (policies != null) { for (SigningPolicy policy : policies) { X500Principal caPrincipal = policy.getCASubjectDN(); policyMapToLoad.put(caPrincipal.getName(), policy); validPoliciesCache.put(caPrincipal.getName(), now); } } loaded = true; } catch (SigningPolicyStoreException e) { if ((invalidCacheTime == null) || (now - invalidCacheTime >= 10 * CACHE_TIME_MILLIS)) { logger.warn("Failed to load signing policy: " + filename + " : " + e.getMessage()); logger.debug("Failed to load signing policy: " + filename, e); invalidPoliciesCache.put(filename, now); } } return loaded; }