auphong2707/dl4se-code-review-dataset huggingface dataset:
Source:
<code>public void forEach(BiConsumer<Long, EntryLogMetadata> action) throws EntryLogMetadataMapException { CloseableIterator<Entry<byte[], byte[]>> iterator = metadataMapDB.iterator(); try { while (iterator.hasNext()) { if (isClosed.get()) { break; } Entry<byte[], byte[]> entry = iterator.next(); long entryLogId = ArrayUtil.getLong(entry.getKey(), 0); ByteArrayInputStream localBais = bais.get(); DataInputStream localDatais = datais.get(); if (localBais.available() < entry.getValue().length) { localBais.close(); localDatais.close(); ByteArrayInputStream newBais = new ByteArrayInputStream(entry.getValue()); bais.set(newBais); datais.set(new DataInputStream(newBais)); } else { localBais.read(entry.getValue(), 0, entry.getValue().length); } localBais.reset(); localDatais.reset(); <START> action.accept(entryLogId, EntryLogMetadata.deserialize(datais.get())); <END> } } catch (IOException e) { LOG.error("Failed to iterate over entry-log metadata map {}", e.getMessage(), e); throw new EntryLogMetadataMapException(e); } finally { try { iterator.close(); } catch (IOException e) { LOG.error("Failed to close entry-log metadata-map rocksDB iterator {}", e.getMessage(), e); } } }</code><technical_language>this 'forEach' call is expensive jvm gc call. create EntryLogMetadata object for entrylog file. consider optimizing it</technical_language>

Target:
public void forEach(BiConsumer<Long, EntryLogMetadata> action) throws EntryLogMetadataMapException { CloseableIterator<Entry<byte[], byte[]>> iterator = metadataMapDB.iterator(); try { while (iterator.hasNext()) { if (isClosed.get()) { break; } Entry<byte[], byte[]> entry = iterator.next(); long entryLogId = ArrayUtil.getLong(entry.getKey(), 0); ByteArrayInputStream localBais = bais.get(); DataInputStream localDatais = datais.get(); if (localBais.available() < entry.getValue().length) { localBais.close(); localDatais.close(); ByteArrayInputStream newBais = new ByteArrayInputStream(entry.getValue()); bais.set(newBais); datais.set(new DataInputStream(newBais)); } else { localBais.read(entry.getValue(), 0, entry.getValue().length); } localBais.reset(); localDatais.reset(); EntryLogMetadataRecyclable metadata = EntryLogMetadata.deserialize(datais.get()); try { action.accept(entryLogId, metadata); } finally { metadata.recycle(); } } } catch (IOException e) { LOG.error("Failed to iterate over entry-log metadata map {}", e.getMessage(), e); throw new EntryLogMetadataMapException(e); } finally { try { iterator.close(); } catch (IOException e) { LOG.error("Failed to close entry-log metadata-map rocksDB iterator {}", e.getMessage(), e); } } }
Source:
<code>static INode.BlocksMapUpdateInfo deleteSnapshot( FSDirectory fsd, FSPermissionChecker pc, SnapshotManager snapshotManager, String snapshotRoot, String snapshotName, boolean logRetryCache) throws IOException { final INodesInPath iip = fsd.resolvePath(pc, snapshotRoot, DirOp.WRITE); if (fsd.isPermissionEnabled()) { fsd.checkOwner(pc, iip); } final long now = Time.now(); if (fsd.isSnapshotDeletionOrdered()) { final INodeDirectory srcRoot = snapshotManager.getSnapshottableRoot(iip); final DirectorySnapshottableFeature snapshottable = srcRoot.getDirectorySnapshottableFeature(); final Snapshot snapshot = snapshottable.getSnapshotByName( srcRoot, snapshotName); final int earliest = snapshottable.getDiffs().iterator().next() .getSnapshotId(); if (snapshot.getId() != earliest) { final XAttr snapshotXAttr = buildXAttr(snapshotName); final List<XAttr> xattrs = Lists.newArrayListWithCapacity(1); xattrs.add(snapshotXAttr); FSDirXAttrOp.unprotectedSetXAttrs(fsd, iip, xattrs, EnumSet.of(XAttrSetFlag.CREATE, XAttrSetFlag.REPLACE)); <START> return null; <END> } } final INode.BlocksMapUpdateInfo collectedBlocks = deleteSnapshot( fsd, snapshotManager, iip, snapshotName, now); fsd.getEditLog().logDeleteSnapshot(snapshotRoot, snapshotName, logRetryCache, now); return collectedBlocks; }</code><technical_language>return null skip fsd.getEditLog().logDeleteSnapshot(..)</technical_language>

Target:
static INode.BlocksMapUpdateInfo deleteSnapshot( FSDirectory fsd, FSPermissionChecker pc, SnapshotManager snapshotManager, String snapshotRoot, String snapshotName, boolean logRetryCache) throws IOException { final INodesInPath iip = fsd.resolvePath(pc, snapshotRoot, DirOp.WRITE); if (fsd.isPermissionEnabled()) { fsd.checkOwner(pc, iip); } final long now = Time.now(); final INode.BlocksMapUpdateInfo collectedBlocks = deleteSnapshot( fsd, snapshotManager, iip, snapshotName, now); fsd.getEditLog().logDeleteSnapshot(snapshotRoot, snapshotName, logRetryCache, now); return collectedBlocks; }
Source:
<code>public void send(DatastreamProducerRecord record, String source, int sourcePartition, T sourceCheckpoint) { SourcePartition sp = new SourcePartition(source, sourcePartition); CallbackStatus status = _callbackStatusMap.computeIfAbsent(sp, d -> new CallbackStatus()); status.register(sourceCheckpoint); _eventProducer.send(record, ((metadata, exception) -> { if (exception != null) { LOG.error("Failed to send datastream record: " + metadata, exception); } status.ack(sourceCheckpoint); <START> })); <END> }</code><technical_language>@misanc mentioning in doc Kafka call callbacks. get confirmation kafka folks callbacks skipped for reason</technical_language>

Target:
public void send(DatastreamProducerRecord record, String source, int sourcePartition, T sourceCheckpoint) { SourcePartition sp = new SourcePartition(source, sourcePartition); CallbackStatus status = _callbackStatusMap.computeIfAbsent(sp, d -> new CallbackStatus()); status.register(sourceCheckpoint); _eventProducer.send(record, ((metadata, exception) -> { if (exception != null) { LOG.error("Failed to send datastream record: " + metadata, exception); } else { status.ack(sourceCheckpoint); } })); }
Source:
<code>private void handleLightMeasurementDeviceEvents(final Device device, final List<Event> lightMeasurementDeviceEvents) { if (lightMeasurementDeviceEvents.isEmpty()) { <START> LOGGER.info("List of events is empty for device: {}, not able to process events.", <END> device.getDeviceIdentification()); return; } try { final String deviceIdentification = device.getDeviceIdentification(); final String correlationUid = this.correlationIdProviderTimestampService.getCorrelationId( this.netmanagementOrganisation, deviceIdentification); final EventMessageDataContainer dataContainer = new EventMessageDataContainer(lightMeasurementDeviceEvents); final RequestMessage requestMessage = new RequestMessage(correlationUid, this.netmanagementOrganisation, deviceIdentification, dataContainer); final String key = "PUBLIC_LIGHTING-1.0"; final JmsTemplate jmsTemplate = this.domainRequestMessageJmsTemplateFactory.getJmsTemplate(key); jmsTemplate.send(new MessageCreator() { @Override public Message createMessage(final Session session) throws JMSException { final ObjectMessage objectMessage = session.createObjectMessage(requestMessage); objectMessage.setJMSType(DeviceFunction.SET_TRANSITION.name()); return objectMessage; } }); } catch (final Exception e) { LOGGER.error("Unexpected exception while handling events for light measurement device: {}", device.getDeviceIdentification()); } }</code><technical_language>able => needed</technical_language>

Target:
private void handleLightMeasurementDeviceEvents(final Device device, final List<Event> lightMeasurementDeviceEvents) { if (lightMeasurementDeviceEvents.isEmpty()) { LOGGER.info("List of events is empty for device: {}, not needed to process events.", device.getDeviceIdentification()); return; } try { final String deviceIdentification = device.getDeviceIdentification(); final String correlationUid = this.correlationIdProviderTimestampService.getCorrelationId( this.netmanagementOrganisation, deviceIdentification); final EventMessageDataContainer dataContainer = new EventMessageDataContainer(lightMeasurementDeviceEvents); final RequestMessage requestMessage = new RequestMessage(correlationUid, this.netmanagementOrganisation, deviceIdentification, dataContainer); final String key = "PUBLIC_LIGHTING-1.0"; final JmsTemplate jmsTemplate = this.domainRequestMessageJmsTemplateFactory.getJmsTemplate(key); jmsTemplate.send(new MessageCreator() { @Override public Message createMessage(final Session session) throws JMSException { final ObjectMessage objectMessage = session.createObjectMessage(requestMessage); objectMessage.setJMSType(DeviceFunction.SET_TRANSITION.name()); return objectMessage; } }); } catch (final Exception e) { LOGGER.error( String.format("Unexpected exception while handling events for light measurement device: %s", device.getDeviceIdentification()), e); } }
Source:
<code>private void saveSanStorage() { StorageModel storageModel = (StorageModel) getWindow(); final SanStorageModel sanStorageModel = (SanStorageModel) storageModel.getCurrentStorageItem(); List<String> unkownStatusLuns = new ArrayList<>(); List<LUNs> usedStatusLuns = new ArrayList<>(); <START> for (LunModel lunModel : sanStorageModel.getAddedLuns()) { <END> if (lunModel.getStatus() == LunStatus.Used) { usedStatusLuns.add((LUNs) lunModel.getEntity()); } else if (lunModel.getStatus() == LunStatus.Unknown) { unkownStatusLuns.add(lunModel.getLunId()); } } if (!unkownStatusLuns.isEmpty()) { Guid hostId = sanStorageModel.getContainer().getHost().getSelectedItem().getId(); Model target = getWidgetModel() != null ? getWidgetModel() : sanStorageModel.getContainer(); Frontend.getInstance() .runQuery(VdcQueryType.GetDeviceList, new GetDeviceListQueryParameters(hostId, sanStorageModel.getType(), true, unkownStatusLuns), new AsyncQuery(target, new INewAsyncCallback() { @Override public void onSuccess(Object target, Object returnValue) { VdcQueryReturnValue response = (VdcQueryReturnValue) returnValue; if (response.getSucceeded()) { List<LUNs> checkedLuns = (ArrayList<LUNs>) response.getReturnValue(); postGetLunsMessages(sanStorageModel.getUsedLunsMessages(checkedLuns)); } else { sanStorageModel.setGetLUNsFailure( ConstantsManager.getInstance() .getConstants() .couldNotRetrieveLUNsLunsFailure()); } } }, true)); } else { postGetLunsMessages(sanStorageModel.getUsedLunsMessages(usedStatusLuns)); } }</code><technical_language>consider extracting a separate method switch instead</technical_language>

Target:
private void saveSanStorage() { StorageModel storageModel = (StorageModel) getWindow(); final SanStorageModel sanStorageModel = (SanStorageModel) storageModel.getCurrentStorageItem(); Map<LunStatus, List<LUNs>> lunsMapByStatus = getLunsMapByStatus(sanStorageModel.getAddedLuns()); if (!lunsMapByStatus.get(LunStatus.Unknown).isEmpty()) { Guid hostId = sanStorageModel.getContainer().getHost().getSelectedItem().getId(); Model target = getWidgetModel() != null ? getWidgetModel() : sanStorageModel.getContainer(); List<String> unkownStatusLuns = new ArrayList<>(); for (LUNs lun : lunsMapByStatus.get(LunStatus.Unknown)) { unkownStatusLuns.add(lun.getLUN_id()); } Frontend.getInstance() .runQuery(VdcQueryType.GetDeviceList, new GetDeviceListQueryParameters(hostId, sanStorageModel.getType(), true, unkownStatusLuns), new AsyncQuery(target, new INewAsyncCallback() { @Override public void onSuccess(Object target, Object returnValue) { VdcQueryReturnValue response = (VdcQueryReturnValue) returnValue; if (response.getSucceeded()) { List<LUNs> checkedLuns = (ArrayList<LUNs>) response.getReturnValue(); postGetLunsMessages(sanStorageModel.getUsedLunsMessages(checkedLuns)); } else { sanStorageModel.setGetLUNsFailure( ConstantsManager.getInstance() .getConstants() .couldNotRetrieveLUNsLunsFailure()); } } }, true)); } else { postGetLunsMessages(sanStorageModel.getUsedLunsMessages(lunsMapByStatus.get(LunStatus.Used))); } }
Source:
<code>public BuyClient build() { if (BuildConfig.DEBUG) { if (TextUtils.isEmpty(shopDomain) || shopDomain.contains(":") || shopDomain.contains("/")) { throw new IllegalArgumentException("shopDomain is not set or invalid. shopDomain must be a valid URL and cannot start with 'http://'"); } } else { if (TextUtils.isEmpty(shopDomain) || shopDomain.contains(":") || shopDomain.contains("/") || !shopDomain.contains(".myshopify.com")) { throw new IllegalArgumentException("shopDomain is not set or invalid. shopDomain must be of the form 'shopname.myshopify.com' and cannot start with 'http://'"); } } <START> if (TextUtils.isEmpty(this.apiKey)) { <END> throw new IllegalArgumentException("apiKey is not set or invalid. apiKey must be provided, and cannot be empty"); } if (TextUtils.isEmpty(appId)) { throw new IllegalArgumentException("appId is not set or invalid. appId must be provided, and cannot be empty"); } if (TextUtils.isEmpty(applicationName)) { throw new IllegalArgumentException("applicationName is not set or invalid. applicationName must be provided, and cannot be empty"); } return new BuyClientImpl( this.apiKey, this.appId, this.applicationName, this.shopDomain, this.completeCheckoutWebReturnUrl, this.completeCheckoutWebReturnLabel, this.customerToken, this.callbackScheduler, this.productPageSize, this.interceptors ); }</code><technical_language>need "this"</technical_language>

Target:
public BuyClient build() { if (BuildConfig.DEBUG) { if (TextUtils.isEmpty(shopDomain) || shopDomain.contains(":") || shopDomain.contains("/")) { throw new IllegalArgumentException("shopDomain is not set or invalid. shopDomain must be a valid URL and cannot start with 'http://'"); } } else { if (TextUtils.isEmpty(shopDomain) || shopDomain.contains(":") || shopDomain.contains("/") || !shopDomain.contains(".myshopify.com")) { throw new IllegalArgumentException("shopDomain is not set or invalid. shopDomain must be of the form 'shopname.myshopify.com' and cannot start with 'http://'"); } } if (TextUtils.isEmpty(apiKey)) { throw new IllegalArgumentException("apiKey is not set or invalid. apiKey must be provided, and cannot be empty"); } if (TextUtils.isEmpty(appId)) { throw new IllegalArgumentException("appId is not set or invalid. appId must be provided, and cannot be empty"); } if (TextUtils.isEmpty(applicationName)) { throw new IllegalArgumentException("applicationName is not set or invalid. applicationName must be provided, and cannot be empty"); } return new BuyClientDefault( apiKey, appId, applicationName, shopDomain, completeCheckoutWebReturnUrl, completeCheckoutWebReturnLabel, customerToken, callbackScheduler, productPageSize, networkRequestRetryMaxCount, networkRequestRetryDelayMs, networkRequestRetryBackoffMultiplier, interceptors ); }
Source:
<code><START> public void writeTo(final Object data, Class<?> dataClass, Type arg2, Annotation[] annotation, MediaType mediaType, MultivaluedMap<String, Object> map, OutputStream outputStream) throws IOException, WebApplicationException { <END> try { new FOPMessageBodyWriter(); Source source = new JAXBSource(jaxbContext, data); String xslName = "/" + dataClass.getSimpleName() + "AsPdf.xsl"; InputStream templateStream = dataClass.getResourceAsStream(xslName); StreamSource transformSource = new StreamSource(templateStream); FopFactory fopFactory = FopFactory.newInstance(); FOUserAgent foUserAgent = fopFactory.newFOUserAgent(); TransformerFactory transfact = TransformerFactory.newInstance(); final ByteArrayOutputStream pdfoutStream = new ByteArrayOutputStream(); Transformer xslfoTransformer = transfact.newTransformer(transformSource); Fop fop = fopFactory.newFop(MimeConstants.MIME_PDF, foUserAgent, pdfoutStream); Result res = new SAXResult(fop.getDefaultHandler()); xslfoTransformer.transform(source, res); StreamingOutput stream = new StreamingOutput() { public void write(OutputStream output) throws IOException, WebApplicationException { output.write(pdfoutStream.toByteArray()); } }; Response.ok(stream).type("application/pdf").header("content-disposition", "attachment; filename=\"stats.pdf\"").build(); } catch(Exception e) { log.error(e.toString()); } }</code><technical_language>Name parameters in definition of interface: writeTo(Object data, Class<?> type, Type genericType, Annotation[] annotations, MediaType mediaType, MultivaluedMap<String, Object> httpHeaders, OutputStream entityStream)</technical_language>

Target:
public void writeTo(final Object data, Class<?> dataClass, Type arg2, Annotation[] annotation, MediaType mediaType, MultivaluedMap<String, Object> map, OutputStream outputStream) throws IOException, WebApplicationException { try { String xslName = "/" + dataClass.getSimpleName() + "AsPdf.xsl"; InputStream templateStream = dataClass.getResourceAsStream(xslName); QName qName = new QName("volume_profile_details"); StreamSource transformSource = new StreamSource(templateStream); ObjectFactory objectFactory = new ObjectFactory(); Method factoryMethod = null; for (Method currentMethod : objectFactory.getClass().getDeclaredMethods()) { Class<?>[] parameterTypes = currentMethod.getParameterTypes(); if (parameterTypes.length == 1 && parameterTypes[0] == arg2) { factoryMethod = currentMethod; break; } } JAXBElement<?> element = (JAXBElement<?>) factoryMethod.invoke(objectFactory, data); Source source = new JAXBSource(jaxbContext, element); FopFactory fopFactory = FopFactory.newInstance(); FOUserAgent foUserAgent = fopFactory.newFOUserAgent(); TransformerFactory transfact = TransformerFactory.newInstance(); Transformer xslfoTransformer = transfact.newTransformer(transformSource); Fop fop = fopFactory.newFop(MimeConstants.MIME_PDF, foUserAgent, outputStream); Result res = new SAXResult(fop.getDefaultHandler()); xslfoTransformer.transform(source, res); } catch(Exception e) { log.error("Error while generating PDF.", e); } }
Source:
<code>protected Position handlePosition(Position position) { Position last = getLastPosition(position.getDeviceId()); if (last != null && last.getLatitude() != 0 && last.getLongitude() != 0) { double distance = DistanceCalculator.distance( position.getLatitude(), position.getLongitude(), last.getLatitude(), last.getLongitude()); if (coordinatesMinError != 0 && distance < coordinatesMinError <START> || coordinatesMaxError != 0 && distance > coordinatesMaxError && !position.getValid()) { <END> position.setLatitude(last.getLatitude()); position.setLongitude(last.getLongitude()); } } return position; }</code><technical_language>I split expression put min max conditions variables. this: java boolean satisfiesMin = coordinatesMinError == 0 || distance > coordinatesMinError; Also, I sense position.getValid() apply min max</technical_language>

Target:
protected Position handlePosition(Position position) { Position last = getLastPosition(position.getDeviceId()); if (last != null && last.getValid() && last.getLatitude() != 0 && last.getLongitude() != 0) { double distance = DistanceCalculator.distance( position.getLatitude(), position.getLongitude(), last.getLatitude(), last.getLongitude()); boolean satisfiesMin = coordinatesMinError == 0 || distance > coordinatesMinError; boolean satisfiesMax = coordinatesMaxError == 0 || distance < coordinatesMaxError || position.getValid(); if (!satisfiesMin || !satisfiesMax) { position.setLatitude(last.getLatitude()); position.setLongitude(last.getLongitude()); } } return position; }
Source:
<code>public InputStream inputStream() throws IOException { <START> return Files.newInputStream(filePath); <END> }</code><technical_language>Hm, I it... (My head full of IResource stuff...)</technical_language>

Target:
public InputStream inputStream() throws IOException { Charset charset = getCharset(); if (charset == null) { charset = StandardCharsets.UTF_8; } try (TextFileContext context = new TextFileContext(file)) { return new ByteArrayInputStream(contents().getBytes(charset)); } catch (CoreException e) { throw new IOException("error while streaming file: " + file.getFullPath(), e); } }
Source:
<code>public MenuPresenterWidget(EventBus eventBus, MenuPresenterWidget.ViewDef view, Provider<ConfigurePopupPresenterWidget> configurePopupProvider) { super(eventBus, view); this.configurePopupProvider = configurePopupProvider; <START> for (int i = 0; i < PrimaryMenuContainerType.values().length; i++) { <END> menuContainers.add(PrimaryMenuContainerType.values()[i].getId()); } menuContainers.add(null); }</code><technical_language>Personally I prefer for (PrimaryMenuContainerType type : PrimaryMenuContainerType.values()) { menuContainers.add(type.getId()); } OK existing loop, a big deal</technical_language>

Target:
public MenuPresenterWidget(EventBus eventBus, MenuPresenterWidget.ViewDef view, Provider<ConfigurePopupPresenterWidget> configurePopupProvider) { super(eventBus, view); this.configurePopupProvider = configurePopupProvider; for (PrimaryMenuContainerType type: PrimaryMenuContainerType.values()) { menuContainers.add(type.getId()); } menuContainers.add(null); }
Source:
<code>private void addSignatureHeader(final URL url, final String httpMethod, final Map<String, String> httpHeaders) { String pathAndQuery = url.getPath(); if (url.getQuery() != null) { pathAndQuery += '?' + url.getQuery(); } final String signed = Arrays.stream(SIGNED_HEADERS) .map(httpHeaders::get) .collect(Collectors.joining(";")); String stringToSign = httpMethod.toUpperCase(Locale.US) + "\n" + pathAndQuery + "\n" + signed; final String signature = Base64.getEncoder().encodeToString(sha256HMAC.doFinal(stringToSign.getBytes(StandardCharsets.UTF_8))); <START> httpHeaders.put(AUTHORIZATION_HEADER, String.format("HMAC-SHA256 Credential=%s, SignedHeaders=%s, " <END> + "Signature=%s", credentials.id(), signedHeadersValue, signature)); }</code><technical_language>nit: put String.format(...) inline for view</technical_language>

Target:
private void addSignatureHeader(final URL url, final String httpMethod, final Map<String, String> httpHeaders) { String pathAndQuery = url.getPath(); if (url.getQuery() != null) { pathAndQuery += '?' + url.getQuery(); } final String signed = Arrays.stream(SIGNED_HEADERS) .map(httpHeaders::get) .collect(Collectors.joining(";")); String stringToSign = httpMethod.toUpperCase(Locale.US) + "\n" + pathAndQuery + "\n" + signed; final String signature = Base64.getEncoder().encodeToString(sha256HMAC.doFinal(stringToSign.getBytes(StandardCharsets.UTF_8))); httpHeaders.put(AUTHORIZATION_HEADER, String.format(HMAC_SHA256, credentials.id(), signedHeadersValue, signature)); }
Source:
<code>public Collection<BeanDefinition> parse(Element element, ParserContext parserContext) { String idAttribute = element.getAttribute("id"); BeanDefinitionBuilder stateBuilder = BeanDefinitionBuilder .genericBeanDefinition("org.springframework.batch.core.job.flow.support.state.SplitState"); List<Element> flowElements = DomUtils.getChildElementsByTagName(element, "flow"); if (flowElements.size() < 2) { parserContext.getReaderContext().error("A <split/> must contain at least two 'flow' elements.", element); } Collection<Object> flows = new ManagedList<Object>(); int i = 0; <START> String prefix = idAttribute; <END> for (Element nextElement : flowElements) { FlowParser flowParser = new FlowParser(prefix + "." + i, jobFactoryRef); flows.add(flowParser.parse(nextElement, parserContext)); i++; } stateBuilder.addConstructorArgValue(flows); stateBuilder.addConstructorArgValue(prefix); return FlowParser.getNextElements(parserContext, null, stateBuilder.getBeanDefinition(), element); }</code><technical_language>idAttribute variable creating another local</technical_language>

Target:
public Collection<BeanDefinition> parse(Element element, ParserContext parserContext) { String idAttribute = element.getAttribute("id"); BeanDefinitionBuilder stateBuilder = BeanDefinitionBuilder .genericBeanDefinition("org.springframework.batch.core.job.flow.support.state.SplitState"); List<Element> flowElements = DomUtils.getChildElementsByTagName(element, "flow"); if (flowElements.size() < 2) { parserContext.getReaderContext().error("A <split/> must contain at least two 'flow' elements.", element); } Collection<Object> flows = new ManagedList<Object>(); int i = 0; for (Element nextElement : flowElements) { FlowParser flowParser = new FlowParser(idAttribute + "." + i, jobFactoryRef); flows.add(flowParser.parse(nextElement, parserContext)); i++; } stateBuilder.addConstructorArgValue(flows); stateBuilder.addConstructorArgValue(idAttribute); return FlowParser.getNextElements(parserContext, null, stateBuilder.getBeanDefinition(), element); }
Source:
<code>private void initNavBar() { previousButton = (Button) findViewById(R.id.button_previous); nextButton = (Button) findViewById(R.id.button_next); indexTextView = (TextView) findViewById(R.id.textview_index); Typeface typeface = Typeface.createFromAsset(getAssets(), "icomoon.ttf"); previousButton.setTypeface(typeface); <START> nextButton.setTypeface(typeface); <END> previousButton.setOnClickListener(new OnClickListener() { @Override public void onClick(View arg0) { loadWordAndShow(serverIDs[--currentIndex]); updateNavBar(); } }); nextButton.setOnClickListener(new OnClickListener() { @Override public void onClick(View arg0) { loadWordAndShow(serverIDs[++currentIndex]); updateNavBar(); } }); updateNavBar(); }</code><technical_language>Ok. I it. icomoon.ttf here</technical_language>

Target:
private void initNavBar() { previousButton = (Button) findViewById(R.id.button_previous); nextButton = (Button) findViewById(R.id.button_next); indexTextView = (TextView) findViewById(R.id.textview_index); previousButton.setTypeface(Settings.iconFont); nextButton.setTypeface(Settings.iconFont); previousButton.setOnClickListener(new OnClickListener() { @Override public void onClick(View arg0) { loadWordAndShow(serverIDs[--currentIndex]); updateNavBar(); } }); nextButton.setOnClickListener(new OnClickListener() { @Override public void onClick(View arg0) { loadWordAndShow(serverIDs[++currentIndex]); updateNavBar(); } }); updateNavBar(); }
Source:
<code>public static String formatDateTimeForComments(Date date) { if (date == null) { return ""; } SimpleDateFormat sdf = null; Calendar c = Calendar.getInstance(); c.setTime(date); if (c.get(Calendar.HOUR_OF_DAY) == 12) { sdf = new SimpleDateFormat("EEE, dd MMM yyyy, hh:mm"); sdf.setTimeZone(TimeZone.getTimeZone("UTC")); return sdf.format(date) + " NOON UTC"; } if (c.get(Calendar.HOUR_OF_DAY) == 0) { sdf = new SimpleDateFormat("EEE, dd MMM yyyy, KK:mm"); sdf.setTimeZone(TimeZone.getTimeZone("UTC")); <START> return sdf.format(date) + " MIDNIGHT UTC"; <END> } sdf = new SimpleDateFormat("EEE, dd MMM yyyy, hh:mm a zzz"); sdf.setTimeZone(TimeZone.getTimeZone("UTC")); return sdf.format(date); }</code><technical_language>discussing this @kanghj decide Midnight omitted. NOON is enough. time confused is 12.00 PM. change 12.00 PM 12 NOON. other times need changing. For example 12.30 PM need changing</technical_language>

Target:
public static String formatDateTimeForComments(Date date) { if (date == null) { return ""; } SimpleDateFormat sdf = null; Calendar c = Calendar.getInstance(); c.setTime(date); if (c.get(Calendar.HOUR_OF_DAY) == 12 && c.get(Calendar.MINUTE) == 0) { sdf = new SimpleDateFormat("EEE, dd MMM yyyy, hh:mm"); sdf.setTimeZone(TimeZone.getTimeZone("UTC")); return sdf.format(date) + " NOON UTC"; } sdf = new SimpleDateFormat("EEE, dd MMM yyyy, hh:mm a zzz"); sdf.setTimeZone(TimeZone.getTimeZone("UTC")); return sdf.format(date); }
Source:
<code><START> public String getDisplayName() <END> { return this.getFluid().getAttributes().getDisplayName(this); }</code><technical_language>more sense this ITextComponent Item#getDisplayName(ItemStack stack) is</technical_language>

Target:
public ITextComponent getDisplayName() { return this.getFluid().getAttributes().getDisplayName(this); }
Source:
<code>public void createCardPaymentWithMetadata() { publicAuthMock.mapBearerTokenToAccountId(API_KEY, GATEWAY_ACCOUNT_ID, CARD); CreateChargeRequestParams createChargeRequestParams = aCreateChargeRequestParams() .withAmount(100) .withDescription(DESCRIPTION) .withReference(REFERENCE) .withReturnUrl(RETURN_URL) <START> .withMetadata(Map.of("foo", "foo you", "fuh", "fuh you")) <END> .build(); connectorMock.respondOk_whenCreateCharge(GATEWAY_ACCOUNT_ID, createChargeRequestParams); postPaymentResponse(API_KEY, paymentPayload(createChargeRequestParams)) .statusCode(201) .contentType(JSON).log().body() .body("metadata.foo", is("foo you")) .body("metadata.fuh", is("fuh you")); connectorMock.verifyCreateChargeConnectorRequest(GATEWAY_ACCOUNT_ID, createChargeRequestParams); }</code><technical_language>I agreed honour JSON type in response e.g. String, Boolean Number in ITest written include types assert returned in response (e.g. making a String). useful too? E.g. ExternalMetadata externalMetadata = new ExternalMetadata( Map.of("key1", true, "key2", 123, "key3", "string1")); then... .body("results[0].metadata.key1", is(true)) .body("results[0].metadata.key2", is(123)) .body("results[0].metadata.key3", is("string1"));</technical_language>

Target:
public void createCardPaymentWithMetadata() { publicAuthMock.mapBearerTokenToAccountId(API_KEY, GATEWAY_ACCOUNT_ID, CARD); CreateChargeRequestParams createChargeRequestParams = aCreateChargeRequestParams() .withAmount(100) .withDescription(DESCRIPTION) .withReference(REFERENCE) .withReturnUrl(RETURN_URL) .withMetadata(Map.of("reconciled", true, "ledger_code", 123, "fuh", "fuh you")) .build(); connectorMock.respondOk_whenCreateCharge(GATEWAY_ACCOUNT_ID, createChargeRequestParams); postPaymentResponse(API_KEY, paymentPayload(createChargeRequestParams)) .statusCode(201) .contentType(JSON) .body("metadata.reconciled", is(true)) .body("metadata.ledger_code", is(123)) .body("metadata.fuh", is("fuh you")); connectorMock.verifyCreateChargeConnectorRequest(GATEWAY_ACCOUNT_ID, createChargeRequestParams); }
Source:
<code>public long getEstimatedKeyCount() throws IOException { if (rawTable instanceof RDBTable) { return rawTable.getEstimatedKeyCount(); } throw new IllegalArgumentException( "Unsupported operation getEstimatedKeyCount() on table type " + <START> rawTable.getClass().getCanonicalName()); <END> }</code><technical_language>I need a check here, underlying table for TypedTable is rocksdbTable. in future, if TypedTable new db for rawTable support getEstimatedKeyCount, if implements Table</technical_language>

Target:
public long getEstimatedKeyCount() throws IOException { return rawTable.getEstimatedKeyCount(); }
Source:
<code><START> public TaskScheduler resolveTaskScheduler() { <END> return resolveSchedulerBean(TaskScheduler.class); }</code><technical_language>this package private instead</technical_language>

Target:
TaskScheduler resolveTaskScheduler() { return resolveSchedulerBean(TaskScheduler.class); }
Source:
<code>public void sendNotification(final String organisationIdentification, final String deviceIdentification, final String result, final String correlationUid, final String message, final Object notificationType) { final String notifyUrl = this.notificationUrl(correlationUid); <START> if (notifyUrl != null && !notifyUrl.isEmpty() && !"\"\"".equals(notifyUrl)) { <END> final SendNotificationRequest notificationRequest = this.notificationRequest(organisationIdentification, deviceIdentification, result, correlationUid, message, notificationType); this.doSendNotification(this.webServiceTemplateFactory, organisationIdentification, this.notificationUsername, notifyUrl, notificationRequest); } }</code><technical_language>checks necessary. Method notificationUrl is care of things</technical_language>

Target:
public void sendNotification(final String organisationIdentification, final String deviceIdentification, final String result, final String correlationUid, final String message, final Object notificationType) { final String notifyUrl = this.notificationUrl(correlationUid); final SendNotificationRequest notificationRequest = this.notificationRequest(organisationIdentification, deviceIdentification, result, correlationUid, message, notificationType); this.doSendNotification(this.webServiceTemplateFactory, organisationIdentification, this.notificationUsername, notifyUrl, notificationRequest); }
Source:
<code>public void refreshServicedUnitList() { <START> UUID uuid = null; if (null != getSelectedServicedUnit()) { uuid = getSelectedServicedUnit().getId(); } <END> ignoreUnitTable = true; servicedUnitModel.setData(getCampaign().getServiceableUnits()); ignoreUnitTable = false; if (!focusOnUnit(uuid)) { refreshTaskList(); txtServicedUnitView.setText(""); } refreshPartsAcquisition(); }</code><technical_language>suggestion UUID uuid = (getSelectedServicedUnit() != null) ? getSelectedServicedUnit().getId() : null;</technical_language>

Target:
public void refreshServicedUnitList() { UUID uuid = (getSelectedServicedUnit() != null) ? getSelectedServicedUnit().getId() : null; ignoreUnitTable = true; servicedUnitModel.setData(getCampaign().getServiceableUnits()); ignoreUnitTable = false; if (!focusOnUnit(uuid)) { refreshTaskList(); txtServicedUnitView.setText(""); } refreshPartsAcquisition(); }
Source:
<code>static void validateReplicationOptions(Map<String, Object> replicationOptions) { if (replicationOptions != null && !replicationOptions.containsKey("class")) { throw new IllegalArgumentException("Replication Strategy 'class' should be provided"); } if (replicationOptions != null && !(replicationOptions.get("class") instanceof String)) { <START> throw new IllegalArgumentException("Replication Strategy should be a type of String"); <END> } }</code><technical_language>Small suggestion: ...should of type String</technical_language>

Target:
static void validateReplicationOptions(Map<String, Object> replicationOptions) { if (replicationOptions != null && !replicationOptions.containsKey("class")) { throw new IllegalArgumentException("Replication Strategy 'class' should be provided"); } if (replicationOptions != null && !(replicationOptions.get("class") instanceof String)) { throw new IllegalArgumentException("Replication Strategy should be of type String"); } }
Source:
<code>protected boolean isPreviewDataAvailable() { <START> return showPreview; <END> }</code><technical_language>this change? I guess not. I remember purpose super-class's side. need check something</technical_language>

Target:
protected boolean isPreviewDataAvailable() { return true; }
Source:
<code>public void testUpdatingOffHeap() { ResourcePools existing = mock(ResourcePools.class); ResourcePools toBeUpdated = mock(ResourcePools.class); Set<ResourceType> existingSet = new HashSet<ResourceType>(); Set<ResourceType> toBeUpdatedSet = new HashSet<ResourceType>(); existingSet.add(ResourceType.Core.HEAP); existingSet.add(ResourceType.Core.OFFHEAP); toBeUpdatedSet.add(ResourceType.Core.OFFHEAP); when(existing.getResourceTypeSet()).thenReturn(existingSet); when(toBeUpdated.getResourceTypeSet()).thenReturn(toBeUpdatedSet); ResourcePoolMerger merger = new ResourcePoolMerger(); try { merger.validateAndMerge(existing, toBeUpdated); } catch (Exception e) { <START> assertThat(e instanceof UnsupportedOperationException, is(true)); <END> } }</code><technical_language>Catch proper exception type assert errors relates heap</technical_language>

Target:
public void testUpdatingOffHeap() { ResourcePools existing = ResourcePoolsBuilder.newResourcePoolsBuilder().offheap(10L, MemoryUnit.MB).build(); ResourcePools toBeUpdated = ResourcePoolsBuilder.newResourcePoolsBuilder().offheap(50L, MemoryUnit.MB).build(); ResourcePoolMerger merger = new ResourcePoolMerger(); try { merger.validateAndMerge(existing, toBeUpdated); } catch (UnsupportedOperationException uoe) { assertThat(uoe.getMessage(), is("Updating OFFHEAP resource is not supported")); } }
Source:
<code>private void handleBatch(ModelRun modelRun, DiseaseGroup diseaseGroup) { DateTime batchEndDate = modelRun.getBatchEndDate(); if (batchEndDate != null) { DateTime batchEndDateWithMaximumTime = getBatchEndDateWithMaximumTime(batchEndDate); List<Integer> occurrenceIDs = diseaseService.getDiseaseOccurrenceIDsForBatching(diseaseGroup.getId(), batchEndDateWithMaximumTime); LOGGER.info(String.format(VALIDATION_LOG_MESSAGE, modelRun.getId(), occurrenceIDs.size(), <START> diseaseGroup.getId(), diseaseGroup.getName(), batchEndDateWithMaximumTime.toString("dd MMM yyyy"))); <END> setValidationParametersForOccurrencesBatch(occurrenceIDs); diseaseOccurrenceHandlerHelper.setBatchingParameters(modelRun, occurrenceIDs.size()); LOGGER.info(String.format(VALIDATION_COMPLETED_LOG_MESSAGE, modelRun.getId())); } }</code><technical_language>Date format constant</technical_language>

Target:
private void handleBatch(ModelRun modelRun, DiseaseGroup diseaseGroup) { DateTime batchEndDate = modelRun.getBatchEndDate(); if (batchEndDate != null) { DateTime batchEndDateWithMaximumTime = getBatchEndDateWithMaximumTime(batchEndDate); List<Integer> occurrenceIDs = diseaseService.getDiseaseOccurrenceIDsForBatching(diseaseGroup.getId(), batchEndDateWithMaximumTime); LOGGER.info(String.format(VALIDATION_LOG_MESSAGE, modelRun.getId(), occurrenceIDs.size(), diseaseGroup.getId(), diseaseGroup.getName(), batchEndDateWithMaximumTime.toString(LOG_DATE_FORMAT))); setValidationParametersForOccurrencesBatch(occurrenceIDs); diseaseOccurrenceHandlerHelper.setBatchingParameters(modelRun, occurrenceIDs.size()); LOGGER.info(String.format(VALIDATION_COMPLETED_LOG_MESSAGE, modelRun.getId())); } }
Source:
<code>public void shutdown() { try { DefaultMonitorRegistry.getInstance().unregister(Monitors.newObjectMonitor(this)); } catch (Throwable t) { logger.error("Cannot shutdown monitor registry", t); } try { if (peerEurekaNodes != null) { <START> for (PeerEurekaNode node : this.peerEurekaNodes.getPeerEurekaNodes()) { <END> node.shutDown(); } } } catch (Throwable t) { logger.error("Cannot shutdown ReplicaAwareInstanceRegistry", t); } super.shutdown(); }</code><technical_language>PeerEurekaNodes shutdown method</technical_language>

Target:
public void shutdown() { try { DefaultMonitorRegistry.getInstance().unregister(Monitors.newObjectMonitor(this)); } catch (Throwable t) { logger.error("Cannot shutdown monitor registry", t); } try { peerEurekaNodes.shutdown(); } catch (Throwable t) { logger.error("Cannot shutdown ReplicaAwareInstanceRegistry", t); } super.shutdown(); }
Source:
<code><START> default <K, V> Map<K, V> toMap(Function<? super T, ? extends Map.Entry<? extends K, ? extends V>> f) { <END> Objects.requireNonNull(f, "f is null"); return Map.<K, V> ofAll(toList().map(f::apply)); }</code><technical_language>I thought of toHashMap add toTreeMap. I start see, in mind. Alternatively provide a toMap toSortedMap, is great, too. other hand is good specific possible. do think</technical_language>

Target:
default <K, V> Map<K, V> toMap(Function<? super T, ? extends Map.Entry<? extends K, ? extends V>> f) { Objects.requireNonNull(f, "f is null"); return HashMap.<K, V> ofAll(toList().map(f::apply)); }
Source:
<code>public int hashCode() { <START> return HashUtil.combineHashCodes(Objects.hashCode(getClass().getName()), <END> Objects.hashCode(general), Objects.hashCode(backgroundSet), Objects.hashCode(fontSet), Objects.hashCode(dimensionsSet), Objects.hashCode(labels)); }</code><technical_language>getClass() instead of getClass().getName()? Applies for bellow..</technical_language>

Target:
public int hashCode() { return HashUtil.combineHashCodes(Objects.hashCode(getClass()), Objects.hashCode(general), Objects.hashCode(backgroundSet), Objects.hashCode(fontSet), Objects.hashCode(dimensionsSet), Objects.hashCode(labels)); }
Source:
<code>public void getVisitsByPatient_shouldReturnEmptyListGivenPatientWithNullPatientIdAndTrue() { Patient p = new Patient(); p.setPatientId(null); <START> assertThat(visitService.getVisitsByPatient(p, true, true), is(empty())); <END> }</code><technical_language>pass null instead of p</technical_language>

Target:
public void getVisitsByPatient_shouldReturnEmptyListGivenPatientWithNullPatientIdAndTrue() { Patient p = new Patient(); p.setPatientId(null); assertThat(visitService.getVisitsByPatient(null, true, true), is(empty())); }
Source:
<code>private Map<Address, List<LuceneWork>> partitionWorkByAddress(List<LuceneWork> works) { <START> return works.stream().collect(Collectors.toMap(this::getLocation, Arrays::asList, (w1, w2) -> { <END> w1.addAll(w2); return w1; })); }</code><technical_language>Hrmm this work properly if key collisions? added</technical_language>

Target:
private Map<Address, List<LuceneWork>> partitionWorkByAddress(List<LuceneWork> works) { return works.stream().collect(Collectors.toMap(this::getLocation, this::newList, (w1, w2) -> { w1.addAll(w2); return w1; })); }
Source:
<code>public StructuredRecord transform(GenericRecord genericRecord) throws IOException { org.apache.avro.Schema genericRecordSchema = genericRecord.getSchema(); int hashCode = genericRecordSchema.hashCode(); <START> co.cask.cdap.api.data.schema.Schema structuredSchema; <END> if (schemaCache.containsKey(hashCode)) { structuredSchema = schemaCache.get(hashCode); } else { structuredSchema = co.cask.cdap.api.data.schema.Schema.parseJson(genericRecordSchema.toString()); schemaCache.put(hashCode, structuredSchema); } StructuredRecord.Builder builder = StructuredRecord.builder(structuredSchema); for (Schema.Field field : structuredSchema.getFields()) { String fieldName = field.getName(); builder.set(fieldName, convertField(genericRecord.get(fieldName), field.getSchema())); } return builder.build(); }</code><technical_language>this changed Schema</technical_language>

Target:
public StructuredRecord transform(GenericRecord genericRecord) throws IOException { org.apache.avro.Schema genericRecordSchema = genericRecord.getSchema(); int hashCode = genericRecordSchema.hashCode(); Schema structuredSchema; if (schemaCache.containsKey(hashCode)) { structuredSchema = schemaCache.get(hashCode); } else { structuredSchema = Schema.parseJson(genericRecordSchema.toString()); schemaCache.put(hashCode, structuredSchema); } StructuredRecord.Builder builder = StructuredRecord.builder(structuredSchema); for (Schema.Field field : structuredSchema.getFields()) { String fieldName = field.getName(); builder.set(fieldName, convertField(genericRecord.get(fieldName), field.getSchema())); } return builder.build(); }
Source:
<code>private RulesObjectMapper() { this.mapper = new ObjectMapper(); SimpleFilterProvider filterProvider = new SimpleFilterProvider(); filterProvider.setFailOnUnknownId(false); filterProvider = filterProvider.addFilter("PoolAttributeFilter", SimpleBeanPropertyFilter.serializeAllExcept("created", "updated", "id")); filterProvider = filterProvider.addFilter("ProductPoolAttributeFilter", SimpleBeanPropertyFilter.serializeAllExcept("created", "updated", "productId", "id")); filterProvider = filterProvider.addFilter("ProvidedProductFilter", SimpleBeanPropertyFilter.serializeAllExcept("created", "updated")); filterProvider = filterProvider.addFilter("ConsumerFilter", <START> SimpleBeanPropertyFilter.serializeAllExcept("idCert", "hypervisorId")); <END> filterProvider = filterProvider.addFilter("EntitlementFilter", SimpleBeanPropertyFilter.serializeAllExcept("certificates", "consumer")); filterProvider = filterProvider.addFilter("OwnerFilter", SimpleBeanPropertyFilter.serializeAllExcept("parentOwner", "consumers", "activationKeys", "environments", "pools")); this.mapper.setFilters(filterProvider); this.mapper.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false); AnnotationIntrospector primary = new JacksonAnnotationIntrospector(); AnnotationIntrospector secondary = new JaxbAnnotationIntrospector( mapper.getTypeFactory()); AnnotationIntrospector pair = new AnnotationIntrospectorPair(primary, secondary); this.mapper.setAnnotationIntrospector(pair); }</code><technical_language>do exclude hypervisor ID rules</technical_language>

Target:
private RulesObjectMapper() { this.mapper = new ObjectMapper(); SimpleFilterProvider filterProvider = new SimpleFilterProvider(); filterProvider.setFailOnUnknownId(false); filterProvider = filterProvider.addFilter("PoolAttributeFilter", SimpleBeanPropertyFilter.serializeAllExcept("created", "updated", "id")); filterProvider = filterProvider.addFilter("ProductPoolAttributeFilter", SimpleBeanPropertyFilter.serializeAllExcept("created", "updated", "productId", "id")); filterProvider = filterProvider.addFilter("ProvidedProductFilter", SimpleBeanPropertyFilter.serializeAllExcept("created", "updated")); filterProvider = filterProvider.addFilter("ConsumerFilter", SimpleBeanPropertyFilter.serializeAllExcept("idCert")); filterProvider = filterProvider.addFilter("EntitlementFilter", SimpleBeanPropertyFilter.serializeAllExcept("certificates", "consumer")); filterProvider = filterProvider.addFilter("OwnerFilter", SimpleBeanPropertyFilter.serializeAllExcept("parentOwner", "consumers", "activationKeys", "environments", "pools")); this.mapper.setFilters(filterProvider); this.mapper.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false); AnnotationIntrospector primary = new JacksonAnnotationIntrospector(); AnnotationIntrospector secondary = new JaxbAnnotationIntrospector( mapper.getTypeFactory()); AnnotationIntrospector pair = new AnnotationIntrospectorPair(primary, secondary); this.mapper.setAnnotationIntrospector(pair); }
Source:
<code><START> public void with(String fieldName, Object value) { <END> if (fieldName.startsWith("version")) { version = value instanceof Number ? ((Number) value).longValue() : Long.parseLong((String) value); } else if (fieldName.startsWith("apps")) { appsHashCode = (String) value; } }</code><technical_language>do need do null check for here</technical_language>

Target:
public void with(String fieldName, Object value) { if (fieldName == null || value == null) { return; } if (fieldName.startsWith("version")) { try { version = value instanceof Number ? ((Number) value).longValue() : Long.parseLong((String) value); } catch (Exception e) { version = -1; logger.warn("Cannot parse version number {}; setting it to default == -1", value); } } else if (fieldName.startsWith("apps")) { if (value instanceof String) { appsHashCode = (String) value; } else { logger.warn("appsHashCode field is not a string, but {}", value.getClass()); } } }
Source:
<code>@Override protected void onCreate(Bundle savedInstanceState) { super.onCreate(savedInstanceState); TextView tv = new TextView(this); tv.setText("Check logcat!"); setContentView(tv); printArgs("The", "Quick", "Brown", "Fox"); Log.i("Fibonacci", "fibonacci's 4th number is " + fibonacci(4)); Greeter greeter = new Greeter("Jake"); Log.d("Greeting", greeter.sayHello()); startSleepyThread(); <START> synchronized (Boolean.TRUE){} <END> }</code><technical_language>remove this? I realize for I in example</technical_language>

Target:
@Override protected void onCreate(Bundle savedInstanceState) { super.onCreate(savedInstanceState); TextView tv = new TextView(this); tv.setText("Check logcat!"); setContentView(tv); printArgs("The", "Quick", "Brown", "Fox"); Log.i("Fibonacci", "fibonacci's 4th number is " + fibonacci(4)); Greeter greeter = new Greeter("Jake"); Log.d("Greeting", greeter.sayHello()); startSleepyThread(); }
Source:
<code>public void stop() throws LifecycleException { stopContainer(); try { Files.delete(addonDir, true); } catch (IOException e) { <START> throw new LifecycleException(e.getMessage()); <END> } }</code><technical_language>log exception instead of rethrowing</technical_language>

Target:
public void stop() throws LifecycleException { stopContainer(); try { Files.delete(addonDir, true); } catch (IOException e) { logger.fine(e.getMessage()); } }