auphong2707/dl4se-code-review-dataset huggingface dataset:
Source:
<code>private boolean selectBySelection(ConcreteMarker marker) { if (onResource == ON_ANY || marker == null) { return true; } if (focusResource == null) { return true; } IResource resource = marker.getResource(); if (onResource == ON_WORKING_SET) { if (resource != null) { return isEnclosed(resource); } } else if (onResource == ON_ANY_IN_SAME_CONTAINER) { IProject project = resource.getProject(); if (project == null) { return false; } <START> for (IResource focusResource : focusResource) { <END> IProject selectedProject = focusResource.getProject(); if (selectedProject == null) { continue; } if (project.equals(selectedProject)) { return true; } } } else if (onResource == ON_SELECTED_ONLY) { for (IResource focusResource : focusResource) { if (resource.equals(focusResource)) { return true; } } } else if (onResource == ON_SELECTED_AND_CHILDREN) { for (IResource focusResource : focusResource) { IResource parentResource = resource; while (parentResource != null) { if (parentResource.equals(focusResource)) { return true; } parentResource = parentResource.getParent(); } } } return false; }</code><technical_language>this is confusing, rename IResource 'currentFocusResource' rename field 'focusResources'. I prefer latter</technical_language>

Target:
private boolean selectBySelection(ConcreteMarker marker) { if (onResource == ON_ANY || marker == null) { return true; } if (focusResources == null) { return true; } IResource resource = marker.getResource(); if (onResource == ON_WORKING_SET) { if (resource != null) { return isEnclosed(resource); } } else if (onResource == ON_ANY_IN_SAME_CONTAINER) { IProject project = resource.getProject(); if (project == null) { return false; } for (IResource focusResource : focusResources) { IProject selectedProject = focusResource.getProject(); if (selectedProject == null) { continue; } if (project.equals(selectedProject)) { return true; } } } else if (onResource == ON_SELECTED_ONLY) { for (IResource focusResource : focusResources) { if (resource.equals(focusResource)) { return true; } } } else if (onResource == ON_SELECTED_AND_CHILDREN) { for (IResource focusResource : focusResources) { IResource parentResource = resource; while (parentResource != null) { if (parentResource.equals(focusResource)) { return true; } parentResource = parentResource.getParent(); } } } return false; }
Source:
<code><START> protected static boolean hasComposition(final PasswordData passwordData) <END> { final List<Rule> rules = new ArrayList<>(); rules.add(COMPOSITION_RULE); final PasswordValidator compositionValidator = new PasswordValidator(rules); return compositionValidator.validate(passwordData).isValid(); }</code><technical_language>Changes accessibility typically sound a warning bell. this change</technical_language>

Target:
private static boolean hasComposition(final PasswordData passwordData) { final List<Rule> rules = new ArrayList<>(); rules.add(COMPOSITION_RULE); final PasswordValidator compositionValidator = new PasswordValidator(rules); return compositionValidator.validate(passwordData).isValid(); }
Source:
<code><START> private static TaskContext deserializeContext(String pathToFile) throws IOException, <END> ClassNotFoundException, InterruptedException { File f = new File(pathToFile); if (!f.exists()) { throw new IllegalStateException(CONTEXT_FILE + f + " does not exist"); } if (!f.canRead()) { throw new IllegalStateException(CONTEXT_FILE + f + " exists but cannot be read"); } if (!f.canWrite()) { throw new IllegalStateException(CONTEXT_FILE + f + " exists but cannot be written"); } try (ObjectInputStream inputStream = new ObjectInputStream(new FileInputStream(f))) { return (TaskContext) inputStream.readObject(); } finally { deleteContextFile(f); } }</code><technical_language>check if is remove static private methods a simple test for this class</technical_language>

Target:
private TaskContext deserializeContext(String pathToFile) throws IOException, ClassNotFoundException, InterruptedException { File f = new File(pathToFile); if (!f.exists()) { throw new IllegalStateException(CONTEXT_FILE + f + " does not exist"); } if (!f.canRead()) { throw new IllegalStateException(CONTEXT_FILE + f + " exists but cannot be read"); } if (!f.canWrite()) { throw new IllegalStateException(CONTEXT_FILE + f + " exists but cannot be written"); } try (ObjectInputStream inputStream = new ObjectInputStream(new FileInputStream(f))) { return (TaskContext) inputStream.readObject(); } finally { deleteContextFile(f); } }
Source:
<code>private List<String> putLocalDirectory(Message<?> requestMessage, File file, String subDirectory) { File[] files = file.listFiles(); List<File> filteredFiles = this.filterMputFiles(files); List<String> replies = new ArrayList<String>(); <START> for (File fyle : filteredFiles) { <END> if (!fyle.isDirectory()) { String path = this.doPut(MessageBuilder.withPayload(fyle) .copyHeaders(requestMessage.getHeaders()) .build(), subDirectory); if (path == null) { if (logger.isDebugEnabled()) { logger.debug("File " + fyle.getAbsolutePath() + " removed before transfer; ignoring"); } } else { replies.add(path); } } else if (this.options.contains(Option.RECURSIVE)){ String newSubDirectory = (StringUtils.hasText(subDirectory) ? subDirectory + this.remoteFileSeparator : "") + fyle.getName(); replies.addAll(this.putLocalDirectory(requestMessage, fyle, newSubDirectory)); } } return replies; }</code><technical_language>rename fyle filteredFile fileToPut</technical_language>

Target:
private List<String> putLocalDirectory(Message<?> requestMessage, File file, String subDirectory) { File[] files = file.listFiles(); List<File> filteredFiles = this.filterMputFiles(files); List<String> replies = new ArrayList<String>(); for (File filteredFile : filteredFiles) { if (!filteredFile.isDirectory()) { String path = this.doPut(MessageBuilder.withPayload(filteredFile) .copyHeaders(requestMessage.getHeaders()) .build(), subDirectory); if (path == null) { if (logger.isDebugEnabled()) { logger.debug("File " + filteredFile.getAbsolutePath() + " removed before transfer; ignoring"); } } else { replies.add(path); } } else if (this.options.contains(Option.RECURSIVE)){ String newSubDirectory = (StringUtils.hasText(subDirectory) ? subDirectory + this.remoteFileTemplate.getRemoteFileSeparator() : "") + filteredFile.getName(); replies.addAll(this.putLocalDirectory(requestMessage, filteredFile, newSubDirectory)); } } return replies; }
Source:
<code>public void write(Path pom, InternalNIOCompilationRequest request) { try { Model model = reader.read(new ByteArrayInputStream(Files.readAllBytes(pom))); if (model == null) { logger.error("Model null from pom file:", pom.toString()); return; } PomPlaceHolder pomPH = new PomPlaceHolder(pom.toAbsolutePath().toString(), model.getArtifactId(), model.getGroupId(), model.getVersion(), model.getPackaging(), Files.readAllBytes(Paths.get(pom.toAbsolutePath().toString()))); if (!history.contains(pomPH)) { PluginPresents plugs = updatePom(model); request.getInfo().lateAdditionKiePluginPresent(plugs.isKiePluginPresent()); if (plugs.isKiePluginPresent()) { String args[] = addCreateClasspathMavenArgs(request.getKieCliRequest().getArgs()); request.getKieCliRequest().setArgs(args); } if (plugs.pomOverwriteRequired()) { ByteArrayOutputStream baos = new ByteArrayOutputStream(); writer.write(baos, model); if (logger.isDebugEnabled()) { logger.debug("Pom changed:{}", new String(baos.toByteArray(), StandardCharsets.UTF_8)); } <START> Files.delete(Paths.get(pom.getParent().toAbsolutePath().toString(), <END> POM_NAME)); Files.write(Paths.get(pom.getParent().toAbsolutePath().toString(), POM_NAME), baos.toByteArray(), StandardOpenOption.CREATE_NEW); } history.add(pomPH); } } catch (Exception e) { logger.error(e.getMessage()); } }</code><technical_language>Please extract Paths.get(pom.getParent().toAbsolutePath().toString(), POM_NAME) variable reuse</technical_language>

Target:
public void write(Path pom, InternalNIOCompilationRequest request) { try { Model model = reader.read(new ByteArrayInputStream(Files.readAllBytes(pom))); if (model == null) { logger.error("Model null from pom file:", pom.toString()); return; } PomPlaceHolder pomPH = new PomPlaceHolder(pom.toAbsolutePath().toString(), model.getArtifactId(), model.getGroupId(), model.getVersion(), model.getPackaging(), Files.readAllBytes(Paths.get(pom.toAbsolutePath().toString()))); if (!history.contains(pomPH)) { PluginPresents plugs = updatePom(model); request.getInfo().lateAdditionKiePluginPresent(plugs.isKiePluginPresent()); if (plugs.isKiePluginPresent()) { String args[] = addCreateClasspathMavenArgs(request.getKieCliRequest().getArgs()); request.getKieCliRequest().setArgs(args); } if (plugs.pomOverwriteRequired()) { ByteArrayOutputStream baos = new ByteArrayOutputStream(); writer.write(baos, model); if (logger.isDebugEnabled()) { logger.debug("Pom changed:{}", new String(baos.toByteArray(), StandardCharsets.UTF_8)); } Path pomParent = Paths.get(pom.getParent().toAbsolutePath().toString(), POM_NAME); Files.delete(pomParent); Files.write(pomParent, baos.toByteArray(), StandardOpenOption.CREATE_NEW); } history.add(pomPH); } } catch (Exception e) { logger.error(e.getMessage()); } }
Source:
<code>public void checkPreviewUpdatedAfterDestroyRecreate() { waitFor(mActivityRule.getActivity().mPreviewIdlingResource); pressBackButton(); resetPreviewIdlingResource(); mIntent.setFlags(Intent.FLAG_ACTIVITY_REORDER_TO_FRONT | Intent.FLAG_ACTIVITY_NEW_TASK); mActivityRule.launchActivity(mIntent); <START> waitFor(mActivityRule.getActivity().mPreviewIdlingResource); <END> }</code><technical_language>I set a timeout individually for tests, if preview is shown expect detected</technical_language>

Target:
public void checkPreviewUpdatedAfterDestroyRecreate() { IdlingRegistry.getInstance().register(mActivityRule.getActivity().getViewIdlingResource()); pressBackButton(); mIntent.setFlags(Intent.FLAG_ACTIVITY_REORDER_TO_FRONT | Intent.FLAG_ACTIVITY_NEW_TASK); mActivityRule.getActivity().startActivity(mIntent); onView(withId(R.id.textureView)).check(matches(isDisplayed())); IdlingRegistry.getInstance().unregister( mActivityRule.getActivity().getViewIdlingResource()); }
Source:
<code>public void updated(Dictionary<String, ?> properties) throws ConfigurationException { if(properties == null) return; if(properties.get("provider") != null) { providerName = (String) properties.get("provider"); } if(properties.get("defaultHeight") != null) { defaultHeight = Integer.parseInt((String)properties.get("defaultHeight")); } if(properties.get("defaultWidth") != null) { defaultWidth = Integer.parseInt((String)properties.get("defaultWidth")); } if(properties.get("scale") != null) { scale = Double.parseDouble((String)properties.get("scale")); if(scale < 0.1) <START> scale = 1.0; <END> } }</code><technical_language>more expected set 0.1, it</technical_language>

Target:
public void updated(Dictionary<String, ?> properties) throws ConfigurationException { if(properties == null) return; if(properties.get("provider") != null) { providerName = (String) properties.get("provider"); } if(properties.get("defaultHeight") != null) { defaultHeight = Integer.parseInt((String)properties.get("defaultHeight")); } if(properties.get("defaultWidth") != null) { defaultWidth = Integer.parseInt((String)properties.get("defaultWidth")); } if(properties.get("scale") != null) { scale = Double.parseDouble((String)properties.get("scale")); if(scale < 0.1) { scale = 1.0; } } }
Source:
<code><START> private static void handleSQLRecoverableException(AutoCloseable dbObject, SQLRecoverableException ex, boolean retry){ <END> log.error("SQLRecoverable exception encountered. Attempting recovery.", ex); try{ dbObject.close(); }catch (SQLRecoverableException recException){ if(retry) { try (Connection connection = getDBConnection(dataSource)){ handleSQLRecoverableException(connection, recException, false); } catch (SQLException | NullPointerException nullOrSqlException){ if(dataSource == null) log.error("Null encountered during recovery", nullOrSqlException); else log.error("Recovery failed for SQLRecoverableError - exiting recovery.", nullOrSqlException); } }else{ dbObject = null; log.error("Recovery failed for SQLRecoverableError - exiting recovery.", recException); } }catch (SQLException sqlEx){ log.error("Error occurred during close operation - continuing with errors" + sqlEx.getMessage(), sqlEx); } catch (Exception e) { log.error("Generic error occurred during close operation" + e.getMessage(), e); } }</code><technical_language>Great stuff. refactor line 72 in closeDatabasePoolConnection() this DataSource in JDBC 7 is AutoCloseable object</technical_language>

Target:
private static void handleSQLRecoverableException(AutoCloseable dbObject, SQLRecoverableException ex, boolean retry){ log.error("SQLRecoverable exception encountered. Attempting recovery.", ex); try{ dbObject.close(); }catch (SQLRecoverableException recException){ if(retry) { try (Connection connection = getDBConnection(dataSource)){ handleSQLRecoverableException(connection, recException, false); } catch (SQLException | NullPointerException nullOrSqlException){ if(dataSource == null) log.error("Null encountered during sqlrecoverable error recovery", nullOrSqlException); else log.error("Recovery failed for SQLRecoverableError - exiting recovery.", nullOrSqlException); } }else{ dbObject = null; log.error("Recovery failed for SQLRecoverableError - exiting recovery.", recException); } }catch (SQLException sqlEx){ log.error("Error occurred during close operation - continuing with errors" + sqlEx.getMessage(), sqlEx); } catch (Exception e) { log.error("Generic error occurred during close operation" + e.getMessage(), e); } }
Source:
<code>public void destroySession(String sessionName, IProgressMonitor monitor) throws ExecutionException { List<String> command = createCommand(LTTngControlServiceConstants.COMMAND_DESTROY_SESSION, sessionName); ICommandResult result = executeCommand(command, monitor, false); String[] errorOutput = result.getErrorOutput(); boolean isError = isError(result); if (isError && <START> (errorOutput.length > <END> 0)) { if (ignoredPattern(result.getErrorOutput(), LTTngControlServiceConstants.SESSION_NOT_FOUND_ERROR_PATTERN)) { isError = false; } } if (isError) { throw new ExecutionException(Messages.TraceControl_CommandError + " " + toCommandString(command) + "\n" + result.toString()); } }</code><technical_language>necessary</technical_language>

Target:
public void destroySession(String sessionName, IProgressMonitor monitor) throws ExecutionException { List<String> command = createCommand(LTTngControlServiceConstants.COMMAND_DESTROY_SESSION, sessionName); ICommandResult result = executeCommand(command, monitor, false); boolean isError = isError(result); if (isError && !ignoredPattern(result.getErrorOutput(), LTTngControlServiceConstants.SESSION_NOT_FOUND_ERROR_PATTERN)) { throw new ExecutionException(Messages.TraceControl_CommandError + " " + toCommandString(command) + "\n" + result.toString()); } }
Source:
<code>private static void checkAppSuccessFromYarnRMOnce( HttpClient httpClient, Job job, AtomicBoolean succeeded ) throws IOException, InterruptedException, ExecutionException, TimeoutException { log.info("Attempting to retrieve app status from YARN RM."); String appId = StringUtils.replace(job.getJobID().toString(), "job", "application"); String yarnRM = job.getConfiguration().get("yarn.resourcemanager.webapp.address"); <START> log.info("YARN RM address: " + yarnRM); <END> String yarnEndpoint = StringUtils.format("http://%s/ws/v1/cluster/apps/%s", yarnRM, appId); ContentResponse res = httpClient.GET(yarnEndpoint); log.info("App status response from YARN RM: " + res.getContentAsString()); Map<String, Object> respMap = HadoopDruidIndexerConfig.JSON_MAPPER.readValue( res.getContentAsString(), new TypeReference<Map<String, Object>>() { } ); Map<String, Object> appMap = (Map<String, Object>) respMap.get("app"); String state = (String) appMap.get("state"); String finalStatus = (String) appMap.get("finalStatus"); if ("FINISHED".equals(state) && "SUCCEEDED".equals(finalStatus)) { succeeded.set(true); } }</code><technical_language>combine log 194 197 single message formatter? suggestion log.info("Attempting retrieve app status YARN RM [%s].", yarnRM);</technical_language>

Target:
private static void checkAppSuccessFromYarnRMOnce( HttpClient httpClient, Job job, AtomicBoolean succeeded ) throws IOException, InterruptedException, ExecutionException, TimeoutException { String appId = StringUtils.replace(job.getJobID().toString(), "job", "application"); String yarnRM = job.getConfiguration().get("yarn.resourcemanager.webapp.address"); String yarnEndpoint = StringUtils.format("http://%s/ws/v1/cluster/apps/%s", yarnRM, appId); log.info("Attempting to retrieve app status from YARN ResourceManager at [%s].", yarnEndpoint); ContentResponse res = httpClient.GET(yarnEndpoint); log.info("App status response from YARN RM: " + res.getContentAsString()); Map<String, Object> respMap = HadoopDruidIndexerConfig.JSON_MAPPER.readValue( res.getContentAsString(), new TypeReference<Map<String, Object>>() { } ); Map<String, Object> appMap = (Map<String, Object>) respMap.get("app"); String state = (String) appMap.get("state"); String finalStatus = (String) appMap.get("finalStatus"); if ("FINISHED".equals(state) && "SUCCEEDED".equals(finalStatus)) { succeeded.set(true); } }
Source:
<code>public void testCFRetainCount() { DoubleByReference pi = new DoubleByReference(Math.PI); DoubleByReference e = new DoubleByReference(Math.E); CFNumberRef cfE = CF.CFNumberCreate(null, CFNumberType.kCFNumberDoubleType.typeIndex(), e); CFNumberRef cfPi = CF.CFNumberCreate(null, CFNumberType.kCFNumberDoubleType.typeIndex(), pi); assertEquals(1, CF.CFGetRetainCount(cfE).intValue()); assertEquals(1, CF.CFGetRetainCount(cfPi).intValue()); cfE.retain(); cfPi.retain(); cfPi.retain(); assertEquals(2, CF.CFGetRetainCount(cfE).intValue()); assertEquals(3, CF.CFGetRetainCount(cfPi).intValue()); <START> List<CFTypeRef> irrationalReferences = new ArrayList<>(); <END> irrationalReferences.add(cfE); irrationalReferences.add(cfPi); for (CFTypeRef value : irrationalReferences) { value.release(); } assertEquals(1, CF.CFGetRetainCount(cfE).intValue()); assertEquals(2, CF.CFGetRetainCount(cfPi).intValue()); cfPi.release(); assertEquals(1, CF.CFGetRetainCount(cfPi).intValue()); cfE.release(); cfPi.release(); }</code><technical_language>Please source 1.6 compatible (Diamond needs replace ArrayList<CFTypeRef>. easier: java List<? extends CFTypeRef> irrationalReferences = Arrays.asList(cfE, cfPi);</technical_language>

Target:
public void testCFRetainCount() { DoubleByReference pi = new DoubleByReference(Math.PI); DoubleByReference e = new DoubleByReference(Math.E); CFNumberRef cfE = CF.CFNumberCreate(null, CFNumberType.kCFNumberDoubleType.typeIndex(), e); CFNumberRef cfPi = CF.CFNumberCreate(null, CFNumberType.kCFNumberDoubleType.typeIndex(), pi); assertEquals(1, CF.CFGetRetainCount(cfE).intValue()); assertEquals(1, CF.CFGetRetainCount(cfPi).intValue()); cfE.retain(); cfPi.retain(); cfPi.retain(); assertEquals(2, CF.CFGetRetainCount(cfE).intValue()); assertEquals(3, CF.CFGetRetainCount(cfPi).intValue()); List<? extends CFTypeRef> irrationalReferences = Arrays.asList(cfE, cfPi); for (CFTypeRef value : irrationalReferences) { value.release(); } assertEquals(1, CF.CFGetRetainCount(cfE).intValue()); assertEquals(2, CF.CFGetRetainCount(cfPi).intValue()); cfPi.release(); assertEquals(1, CF.CFGetRetainCount(cfPi).intValue()); cfE.release(); cfPi.release(); }
Source:
<code>public boolean remove(Object o) { if (getExtension() != null) { BootstrapLogger.LOG.typeModifiedInAfterTypeDiscovery(getExtension(), o, REMOVE_OPERATION, getViewType()); } <START> return getDelegate().remove(createSource((Class<?>) o, 0)); <END> }</code><technical_language>objectToItemIfNeeded() here</technical_language>

Target:
public boolean remove(Object o) { if (getExtension() != null) { BootstrapLogger.LOG.typeModifiedInAfterTypeDiscovery(getExtension(), o, REMOVE_OPERATION, getViewType()); } return getDelegate().remove(objectToItemIfNeeded(o)); }
Source:
<code>public ChangeScreen2(Change.Id changeId, String base, String revision, boolean openReplyBox) { this.changeId = changeId; this.base = <START> base; <END> this.revision = revision != null && !revision.isEmpty() ? revision : null; this.openReplyBox = openReplyBox; add(uiBinder.createAndBindUi(this)); }</code><technical_language>do base != null && !base.isEmpty() ? base : null do line for revision</technical_language>

Target:
public ChangeScreen2(Change.Id changeId, String base, String revision, boolean openReplyBox) { this.changeId = changeId; this.base = normalize(base); this.revision = normalize(revision); this.openReplyBox = openReplyBox; add(uiBinder.createAndBindUi(this)); }
Source:
<code>public void runScanTest(boolean populateKeys) throws Exception { logger.info("SCAN TEST -- begin"); if (populateKeys) { for (int i=0; i<500; i++) { logger.info("Writing 500 keys to " ); client.set("DynoClientTest_key-"+i, "value-"+i); } } CursorBasedResult<String> cbi = null; do { <START> cbi = client.dyno_scan(cbi, 100, "DynoClientTest_key-*"); <END> List<String> results = cbi.getStringResult(); for (String res: results) { logger.info(res); } } while (!cbi.isComplete()); logger.info("SCAN TEST -- done"); }</code><technical_language>500 keys written above, count in 100. Is this correct</technical_language>

Target:
public void runScanTest(boolean populateKeys) throws Exception { logger.info("SCAN TEST -- begin"); if (populateKeys) { logger.info("Writing 500 keys to " ); for (int i=0; i<500; i++) { client.set("DynoClientTest_key-"+i, "value-"+i); } } CursorBasedResult<String> cbi = null; do { cbi = client.dyno_scan(cbi, 100, "DynoClientTest_key-*"); List<String> results = cbi.getStringResult(); for (String res: results) { logger.info(res); } } while (!cbi.isComplete()); logger.info("SCAN TEST -- done"); }
Source:
<code>public <T> T getReference(Class<T> entityViewClass, Object id) { Constructor<T> constructor = (Constructor<T>) referenceConstructorCache.get(entityViewClass); try { ViewTypeImpl<T> managedViewType = metamodel.view(entityViewClass); if (constructor == null) { Class<? extends T> proxyClass = proxyFactory.getProxy(this, managedViewType); constructor = (Constructor<T>) proxyClass.getConstructor(managedViewType.getIdAttribute().getConvertedJavaType()); referenceConstructorCache.put(entityViewClass, constructor); } if (!managedViewType.getIdAttribute().getJavaType().isInstance(id)) { id = getUpdater(managedViewType, null, null, null).getFullGraphNode().createViewIdByEntityId(id); } return constructor.newInstance(id); } catch (Exception e) { <START> e.printStackTrace(); <END> throw new IllegalArgumentException("Couldn't instantiate entity view object for type: " + entityViewClass.getName() + "\nDid you forget to add a no-args constructor to the view? Consider adding a no-args constructor annotated with @ViewConstructor(\"reference\").", e); } }</code><technical_language>Remove suggestion</technical_language>

Target:
public <T> T getReference(Class<T> entityViewClass, Object id) { Constructor<T> constructor = (Constructor<T>) referenceConstructorCache.get(entityViewClass); try { ViewTypeImpl<T> managedViewType = metamodel.view(entityViewClass); if (constructor == null) { Class<? extends T> proxyClass = proxyFactory.getProxy(this, managedViewType); constructor = (Constructor<T>) proxyClass.getConstructor(managedViewType.getIdAttribute().getConvertedJavaType()); referenceConstructorCache.put(entityViewClass, constructor); } if (!managedViewType.getIdAttribute().getJavaType().isInstance(id)) { id = getUpdater(managedViewType, null, null, null).getFullGraphNode().createViewIdByEntityId(id); } return constructor.newInstance(id); } catch (Exception e) { throw new IllegalArgumentException("Couldn't instantiate entity view object for type: " + entityViewClass.getName() + "\nDid you forget to add a no-args constructor to the view? Consider adding a no-args constructor annotated with @ViewConstructor(\"reference\").", e); } }
Source:
<code>public ValueRange(Object from, Object to) { if (!(from instanceof Comparable)) { <START> throw new IllegalArgumentException("'from' must be an instance of java.lang.Comparable"); <END> } if (!(to instanceof Comparable)) { throw new IllegalArgumentException("'to' must be an instance of java.lang.Comparable"); } this.from = from; this.to = to; }</code><technical_language>Log</technical_language>

Target:
public ValueRange(Object from, Object to) { if (!(from instanceof Comparable)) { throw log.argumentMustBeComparable("from"); } if (!(to instanceof Comparable)) { throw log.argumentMustBeComparable("to"); } this.from = from; this.to = to; }
Source:
<code>public void addPilotOrSoldier(Person p) { <START> addPilotOrSoldier(Objects.requireNonNull(p), false); <END> }</code><technical_language>this duplicate nonNull check</technical_language>

Target:
public void addPilotOrSoldier(Person p) { addPilotOrSoldier(p, false); }
Source:
<code>private void email() { if (message == null) { return; } final PatchSetInfo patchSetInfo; try { <START> patchSetInfo = patchSetInfoFactory.get(db, patchSetId); <END> } catch (PatchSetInfoNotAvailableException e) { log.error("Failed to obtain PatchSetInfo for patch set " + patchSetId, e); return; } workQueue.getDefaultQueue() .submit(requestScopePropagator.wrap(new Runnable() { @Override public void run() { try { final CommentSender cm = commentSenderFactory.create(change); cm.setFrom(user.getAccountId()); cm.setPatchSet(patchSet, patchSetInfo); cm.setChangeMessage(message); cm.setPatchLineComments(drafts); cm.send(); } catch (EmailException e) { log.error( "Cannot send comments by email for patch set " + patchSetId, e); } } @Override public String toString() { return "send email for patch set comments"; } })); }</code><technical_language>move this background? performs git object decompression parsing, slower if hot in cache</technical_language>

Target:
private void email() { if (message == null) { return; } workQueue.getDefaultQueue() .submit(requestScopePropagator.wrap(new Runnable() { @Override public void run() { PatchSetInfo patchSetInfo; try { ReviewDb reviewDb = schemaFactory.open(); try { patchSetInfo = patchSetInfoFactory.get(reviewDb, patchSetId); } finally { reviewDb.close(); } } catch (PatchSetInfoNotAvailableException e) { log.error( "Failed to obtain PatchSetInfo for patch set " + patchSetId, e); return; } catch (OrmException e) { log.error( "Cannot send comments by email for patch set " + patchSetId, e); return; } try { final CommentSender cm = commentSenderFactory.create(change); cm.setFrom(user.getAccountId()); cm.setPatchSet(patchSet, patchSetInfo); cm.setChangeMessage(message); cm.setPatchLineComments(drafts); cm.send(); } catch (EmailException e) { log.error( "Cannot send comments by email for patch set " + patchSetId, e); } } @Override public String toString() { return "send email for patch set comments"; } })); }
Source:
<code>public void assignSplits(SplitsAssignment<SplitT> assignment) { <START> if (!Thread.currentThread().getName().equals(coordinatorThreadName)) { <END> try { coordinatorExecutor.submit(() -> assignSplits(assignment)).get(); return; } catch (InterruptedException | ExecutionException e) { throw new FlinkRuntimeException("Failed to assign splits due to", e); } } for (Integer subtaskId : assignment.assignment().keySet()) { if (!registeredReaders.containsKey(subtaskId)) { throw new IllegalArgumentException(String.format( "Cannot assign splits %s to subtask %d because the subtask is not registered.", registeredReaders.get(subtaskId), subtaskId)); } } assignmentTracker.recordSplitAssignment(assignment); assignment.assignment().forEach( (id, splits) -> { try { operatorCoordinatorContext.sendEvent(new AddSplitEvent<>(splits), id); } catch (TaskNotRunningException e) { throw new FlinkRuntimeException(String.format( "Failed to assign splits %s to reader %d.", splits, id), e); } }); }</code><technical_language>thread name is fragile. reference equality of Thread objects</technical_language>

Target:
public void assignSplits(SplitsAssignment<SplitT> assignment) { if (!coordinatorThreadFactory.isCurrentThreadCoordinatorThread()) { try { coordinatorExecutor.submit(() -> assignSplits(assignment)).get(); return; } catch (InterruptedException | ExecutionException e) { throw new FlinkRuntimeException("Failed to assign splits due to", e); } } for (Integer subtaskId : assignment.assignment().keySet()) { if (!registeredReaders.containsKey(subtaskId)) { throw new IllegalArgumentException(String.format( "Cannot assign splits %s to subtask %d because the subtask is not registered.", registeredReaders.get(subtaskId), subtaskId)); } } assignmentTracker.recordSplitAssignment(assignment); assignment.assignment().forEach( (id, splits) -> { try { operatorCoordinatorContext.sendEvent(new AddSplitEvent<>(splits), id); } catch (TaskNotRunningException e) { throw new FlinkRuntimeException(String.format( "Failed to assign splits %s to reader %d.", splits, id), e); } }); }
Source:
<code>private IsWidget getWidget(LimitedEntryCol limitedEntryCol) { if (editingCol() instanceof LimitedEntryActionSetFieldCol52) { return factory().getWidget(editingPattern(), (LimitedEntryActionSetFieldCol52) limitedEntryCol, limitedEntryCol.getValue()); } else if (editingCol() instanceof LimitedEntryConditionCol52) { return factory().getWidget(editingPattern(), (LimitedEntryConditionCol52) limitedEntryCol, limitedEntryCol.getValue()); } else if (editingCol() instanceof LimitedEntryActionInsertFactCol52) { return factory().getWidget((LimitedEntryActionInsertFactCol52) limitedEntryCol, limitedEntryCol.getValue()); } <START> return null; <END> }</code><technical_language>of Optional is nicer</technical_language>

Target:
private IsWidget getWidget(LimitedEntryCol limitedEntryCol) { if (editingCol() instanceof LimitedEntryActionSetFieldCol52) { return factory().getWidget(editingPattern(), (LimitedEntryActionSetFieldCol52) limitedEntryCol, limitedEntryCol.getValue()); } else if (editingCol() instanceof LimitedEntryConditionCol52) { return factory().getWidget(editingPattern(), (LimitedEntryConditionCol52) limitedEntryCol, limitedEntryCol.getValue()); } else if (editingCol() instanceof LimitedEntryActionInsertFactCol52) { return factory().getWidget((LimitedEntryActionInsertFactCol52) limitedEntryCol, limitedEntryCol.getValue()); } throw new UnsupportedOperationException("The column type is not supported by the 'LimitedWidget'"); }
Source:
<code>public String call() throws Exception { final Ds3ClientHelpers.ObjectTransferrer getter; if (checksum) { <START> throw new java.lang.RuntimeException("Checksumming is currently not implemented."); END> } else { getter = new FileObjectGetter(this.outputPath); } if (this.prefix == null) { Logging.log("Getting all objects from " + this.bucketName); return restoreAll(getter); } else { Logging.log("Getting only those objects that start with " + this.prefix); return restoreSome(getter); } }</code><technical_language>This need fully qualified</technical_language>

Target:
public String call() throws Exception { final Ds3ClientHelpers.ObjectTransferrer getter; if (checksum) { throw new RuntimeException("Checksumming is currently not implemented."); } else { getter = new FileObjectGetter(this.outputPath); } if (this.prefix == null) { Logging.log("Getting all objects from " + this.bucketName); return restoreAll(getter); } else { Logging.log("Getting only those objects that start with " + this.prefix); return restoreSome(getter); } }
Source:
<code>public void testGenerator() throws Exception { ClassDefinition classDefinition = new ClassDefinition( <START> (PUBLIC, FINAL), <END> "test/Example", type(Object.class)); Parameter argA = arg("a", int.class); Parameter argB = arg("b", int.class); MethodDefinition method = classDefinition.declareMethod( a(PUBLIC, STATIC), "add", type(int.class), ImmutableList.of(argA, argB)); method.getBody() .append(add(argA, argB)) .retInt(); Path tempDir = createTempDirectory("test"); try { StringWriter writer = new StringWriter(); Class<?> clazz = classGenerator(getClass().getClassLoader()) .fakeLineNumbers(true) .runAsmVerifier(true) .dumpRawBytecode(true) .outputTo(writer) .dumpClassFilesTo(tempDir) .defineClass(classDefinition, Object.class); Method add = clazz.getMethod("add", int.class, int.class); assertEquals(add.invoke(null, 13, 42), 55); assertThat(writer.toString()) .contains("00002 I I : I I : IADD") .contains("public final class test/Example {") .contains(" .contains("LINENUMBER 2002 L1"); assertThat(tempDir.resolve("test/Example.class")).isRegularFile(); } finally { deleteRecursively(tempDir, ALLOW_INSECURE); } }</code><technical_language>a typo</technical_language>

Target:
public void testGenerator() throws Exception { ClassDefinition classDefinition = new ClassDefinition( a(PUBLIC, FINAL), "test/Example", type(Object.class)); Parameter argA = arg("a", int.class); Parameter argB = arg("b", int.class); MethodDefinition method = classDefinition.declareMethod( a(PUBLIC, STATIC), "add", type(int.class), ImmutableList.of(argA, argB)); method.getBody() .append(add(argA, argB)) .retInt(); Path tempDir = createTempDirectory("test"); try { StringWriter writer = new StringWriter(); Class<?> clazz = classGenerator(getClass().getClassLoader()) .fakeLineNumbers(true) .runAsmVerifier(true) .dumpRawBytecode(true) .outputTo(writer) .dumpClassFilesTo(tempDir) .defineClass(classDefinition, Object.class); Method add = clazz.getMethod("add", int.class, int.class); assertEquals(add.invoke(null, 13, 42), 55); assertThat(writer.toString()) .contains("00002 I I : I I : IADD") .contains("public final class test/Example {") .contains(" .contains("LINENUMBER 2002 L1"); assertThat(tempDir.resolve("test/Example.class")).isRegularFile(); } finally { deleteRecursively(tempDir, ALLOW_INSECURE); } }
Source:
<code>public <START> @UiConstructor EntityModelRadioButtonEditor(String <END> group) { this(group, new VisibilityRenderer.SimpleVisibilityRenderer()); }</code><technical_language>Nit-pick: put @UiConstructor method declaration, is commonly form</technical_language>

Target:
public EntityModelRadioButtonEditor(String group) { this(group, new VisibilityRenderer.SimpleVisibilityRenderer()); }
Source:
<code>private static boolean writeValue(Socket client, String value) { boolean result; BufferedSink out = null; try { <START> out = Okio.buffer(Okio.sink(client.getOutputStream())); <END> out.writeUtf8(value); out.writeUtf8CodePoint('\n'); out.flush(); result = true; } catch (Exception e) { result = false; } finally { if (out != null) { try { out.close(); } catch (IOException e) { result = false; } } } return result; }</code><technical_language>need call getOutputStream(). Okio.sink overload for Socket</technical_language>

Target:
private static boolean writeValue(Socket client, String value) { boolean result; BufferedSink out = null; try { out = Okio.buffer(Okio.sink(client)); out.writeUtf8(value); out.writeUtf8CodePoint('\n'); out.flush(); result = true; } catch (Exception e) { result = false; } finally { if (out != null) { try { out.close(); } catch (IOException e) { result = false; } } } return result; }
Source:
<code>public String getJsonData() throws IOException { long position = writer.getPosition(); try { writer.checkSize(); if (writer.getPosition() != position) { position = writer.getPosition(); } URI id = writeResponse(); <START> writeRequest(id); <END> writeMetadata(id); } catch (IOException e) { throw e; } catch (ParseException e) { LOG.error("Can't get a valid date from: " + url); } return null; }</code><technical_language>add a config decide handle requests</technical_language>

Target:
public String getJsonData() throws IOException { long position = writer.getPosition(); try { writer.checkSize(); if (writer.getPosition() != position) { position = writer.getPosition(); } URI id = writeResponse(); if (StringUtils.isNotBlank(metadata.get("_request_"))) { writeRequest(id); } } catch (IOException e) { throw e; } catch (ParseException e) { LOG.error("Can't get a valid date from: {}", url); } return null; }
Source:
<code>public synchronized void updateCapacity(Map<String, Integer> capacity) { if (_capacityMetricsMap.keySet().equals(capacity.keySet())) { for (Map.Entry<String, Integer> entry : capacity.entrySet()) { _capacityMetricsMap.get(entry.getKey()).updateValue((long) entry.getValue()); } } else { _capacityMetricsMap.keySet().retainAll(capacity.keySet()); for (Map.Entry<String, Integer> entry : capacity.entrySet()) { String capacityName = entry.getKey(); _capacityMetricsMap.computeIfAbsent(capacityName, <START> metric -> new SimpleDynamicMetric<>(capacityName + "Gauge", 0L)) <END> .updateValue((long) entry.getValue()); } List<DynamicMetric<?, ?>> attributeList = Lists.newArrayList( _totalMessagedReceivedCounter, _disabledPartitionsGauge, _enabledStatusGauge, _onlineStatusGauge, _maxCapacityUsageGauge ); attributeList.addAll(_capacityMetricsMap.values()); updateAttributesInfo(attributeList, "Instance monitor for instance: " + getInstanceName()); } }</code><technical_language>nit, 0L -> (long) entry.getValue()</technical_language>

Target:
public void updateCapacity(Map<String, Integer> capacity) { synchronized (_dynamicCapacityMetricsMap) { if (_dynamicCapacityMetricsMap.keySet().equals(capacity.keySet())) { for (Map.Entry<String, Integer> entry : capacity.entrySet()) { _dynamicCapacityMetricsMap.get(entry.getKey()).updateValue((long) entry.getValue()); } return; } _dynamicCapacityMetricsMap.keySet().retainAll(capacity.keySet()); for (Map.Entry<String, Integer> entry : capacity.entrySet()) { String capacityName = entry.getKey(); if (_dynamicCapacityMetricsMap.containsKey(capacityName)) { _dynamicCapacityMetricsMap.get(capacityName).updateValue((long) entry.getValue()); } else { _dynamicCapacityMetricsMap.put(capacityName, new SimpleDynamicMetric<>(capacityName + "Gauge", (long) entry.getValue())); } } } updateAttributesInfo(buildAttributeList(), "Instance monitor for instance: " + getInstanceName()); }
Source:
<code><START> private <C extends Credentials, U extends UserProfile> Promise<U> getProfile(WebContext webContext, Client<C, U> client) throws RequiresHttpAction { <END> C credentials = client.getCredentials(webContext); return Promise.value(client.getUserProfile(credentials, webContext)); }</code><technical_language>I body of this method needs wrapped in Blocking.get()</technical_language>

Target:
private <C extends Credentials, U extends UserProfile> Promise<U> getProfile(WebContext webContext, Client<C, U> client) throws RequiresHttpAction { return Blocking.get(() -> { C credentials = client.getCredentials(webContext); return client.getUserProfile(credentials, webContext); }); }
Source:
<code>public void trimOrdersByPrice(double price, String symbol) { ArrayList<Order> newSellOrders = new ArrayList<Order>(); ArrayList<Order> newBuyOrders = new ArrayList<Order>(); for (Order <START> o : <END> this.sellOrders.get(symbol)) { if (o.getPrice() > price && !o.isMarketOrder) { newBuyOrders.add(o); } } for (Order o : this.buyOrders.get(symbol)) { if (o.getPrice() < price && !o.isMarketOrder) { newSellOrders.add(o); } } this.buyOrders.remove(symbol); this.buyOrders.put(symbol, newBuyOrders); this.sellOrders.remove(symbol); this.sellOrders.put(symbol, newSellOrders); }</code><technical_language>bad naming, change order</technical_language>

Target:
public void trimOrdersByPrice(double price, String symbol) { ArrayList<Order> newSellOrders = new ArrayList<Order>(); ArrayList<Order> newBuyOrders = new ArrayList<Order>(); for (Order order : this.sellOrders.get(symbol)) { if (order.getPrice() > price && !order.isMarketOrder) { newBuyOrders.add(order); } } for (Order order : this.buyOrders.get(symbol)) { if (order.getPrice() < price && !order.isMarketOrder) { newSellOrders.add(order); } } this.buyOrders.remove(symbol); this.buyOrders.put(symbol, newBuyOrders); this.sellOrders.remove(symbol); this.sellOrders.put(symbol, newSellOrders); }
Source:
<code>protected void destroyVm() { if (getVm().getStatus() == VMStatus.MigratingFrom && getVm().getMigratingToVds() != null) { Backend.getInstance() .getResourceManager() .RunVdsCommand( VDSCommandType.DestroyVm, new DestroyVmVDSCommandParameters(new Guid(getVm().getMigratingToVds().toString()), getVmId(), true, false, 0)); } <START> if (getVm().getStatus() == VMStatus.Paused) { <END> VmStatic vmStatic = getVm().getStaticData(); decreasePendingVms(getVm().getRunOnVds(), vmStatic.getNumOfCpus(), vmStatic.getMinAllocatedMem(), vmStatic.getName()); } setActionReturnValue(Backend .getInstance() .getResourceManager() .RunVdsCommand(VDSCommandType.DestroyVm, new DestroyVmVDSCommandParameters(getVdsId(), getVmId(), false, false, 0)).getReturnValue()); }</code><technical_language>check pause-status (VmDynamic#getPauseStatus) if VM is paused due some error, decrease pending mem/cpu stops. pending resources decreased if pause-status is NOERR (which means VM started in pause mode pending resources decreased yet)</technical_language>

Target:
protected void destroyVm() { if (getVm().getStatus() == VMStatus.MigratingFrom && getVm().getMigratingToVds() != null) { Backend.getInstance() .getResourceManager() .RunVdsCommand( VDSCommandType.DestroyVm, new DestroyVmVDSCommandParameters(new Guid(getVm().getMigratingToVds().toString()), getVmId(), true, false, 0)); } if (getVm().getStatus() == VMStatus.Paused && getVm().getVmPauseStatus() == VmPauseStatus.NOERR) { VmStatic vmStatic = getVm().getStaticData(); VmHandler.decreasePendingVms(getVm().getRunOnVds(), vmStatic.getNumOfCpus(), vmStatic.getMinAllocatedMem(), vmStatic.getName()); } setActionReturnValue(Backend .getInstance() .getResourceManager() .RunVdsCommand(VDSCommandType.DestroyVm, new DestroyVmVDSCommandParameters(getVdsId(), getVmId(), false, false, 0)).getReturnValue()); }
Source:
<code>public UserRole getRole(long role) { Session session = null; Transaction tx = null; UserRole result = null; try { session = this.sessionFactory.openSession(); <START> tx = session.beginTransaction(); <END> result = (UserRole) session.createCriteria(UserRole.class).add(Restrictions.eq("roleId", role)).uniqueResult(); }catch(HibernateException e){ LOG.error(e, e); }finally { closeSession(session, false); } return result; }</code><technical_language>Transaction is begun ended. Is this intentional, a commit a rollback in catch, do need transaction for read-only access</technical_language>

Target:
public UserRole getRole(long role) { Session session = null; UserRole result = null; try { session = this.sessionFactory.openSession(); result = (UserRole) session.createCriteria(UserRole.class).add(Restrictions.eq("roleId", role)).uniqueResult(); }catch(HibernateException e){ LOG.error(e, e); }finally { closeSession(session, false); } return result; }
Source:
<code>public void newLimitedEntryConditionColumn() { final ConditionCol52 column = new LimitedEntryConditionCol52(); final ConditionPopup popup = new ConditionPopup( model, oracle, presenter, new ConditionColumnCommand() { public void execute( final Pattern52 pattern, final ConditionCol52 column ) { presenter.appendColumn( pattern, column ); } }, column, true, !access.isEditable() ); popup.show(); <START> } <END></code><technical_language>methods for line...perhaps reuse code instead</technical_language>

Target:
public void newLimitedEntryConditionColumn() { final ConditionCol52 column = new LimitedEntryConditionCol52(); doNewConditionColumn( column ); }
Source:
<code>public void shouldRefundToAnExistingPaymentSuccessfully() throws Exception { AuthorisationGatewayRequest request = getCardAuthorisationRequest(chargeEntity); PaymentProvider smartpay = getSmartpayPaymentProvider(); GatewayResponse<SmartpayAuthorisationResponse> authoriseResponse = smartpay.authorise(request); assertTrue(authoriseResponse.isSuccessful()); chargeEntity.setGatewayTransactionId(authoriseResponse.getBaseResponse().get().getPspReference()); GatewayResponse<WorldpayCaptureResponse> captureGatewayResponse = smartpay.capture(CaptureGatewayRequest.valueOf(chargeEntity)); assertTrue(captureGatewayResponse.isSuccessful()); <START> RefundEntity refundEntity = new RefundEntity(chargeEntity, 1L, null); <END> RefundGatewayRequest refundRequest = RefundGatewayRequest.valueOf(refundEntity); GatewayResponse refundResponse = smartpay.refund(refundRequest); assertThat(refundResponse.isSuccessful(), is(true)); }</code><technical_language>Again, want pass actual</technical_language>

Target:
public void shouldRefundToAnExistingPaymentSuccessfully() throws Exception { AuthorisationGatewayRequest request = getCardAuthorisationRequest(chargeEntity); PaymentProvider smartpay = getSmartpayPaymentProvider(); GatewayResponse<SmartpayAuthorisationResponse> authoriseResponse = smartpay.authorise(request); assertTrue(authoriseResponse.isSuccessful()); chargeEntity.setGatewayTransactionId(authoriseResponse.getBaseResponse().get().getPspReference()); GatewayResponse<WorldpayCaptureResponse> captureGatewayResponse = smartpay.capture(CaptureGatewayRequest.valueOf(chargeEntity)); assertTrue(captureGatewayResponse.isSuccessful()); RefundEntity refundEntity = new RefundEntity(chargeEntity, 1L, userExternalId); RefundGatewayRequest refundRequest = RefundGatewayRequest.valueOf(refundEntity); GatewayResponse refundResponse = smartpay.refund(refundRequest); assertThat(refundResponse.isSuccessful(), is(true)); }
Source:
<code>public String getDisplayName() { <START> return "Create a label on TFS"; <END> }</code><technical_language>return "Create a label TFS"; a instances of "on TFS" in code; I "in TFS" is more accurate</technical_language>

Target:
public String getDisplayName() { return "Create a label in TFS"; }
Source:
<code>private void setCoursePagination(List<String> coursePaginationList) { String previousPageLink = retrievePreviousPageLink(coursePaginationList); String nextPageLink = retrieveNextPageLink(coursePaginationList); String activeCourse = ""; for (String courseId : coursePaginationList) { if (courseId.equals(this.courseId)) { activeCourse = courseId; } <START> } <END> String userCommentsLink = getStudentCommentsLink(false); coursePagination = new CoursePagination(previousPageLink, nextPageLink, coursePaginationList, activeCourse, userCommentsLink); }</code><technical_language>String activeCourse = courseId? courseId directly? if want ensure courseId is pagination list: if (coursePaginationList.contains(courseId)) { activeCourse = courseId; }</technical_language>

Target:
private void setCoursePagination(List<String> coursePaginationList) { String previousPageLink = retrievePreviousPageLink(coursePaginationList); String nextPageLink = retrieveNextPageLink(coursePaginationList); String activeCourse = coursePaginationList.contains(courseId) ? courseId : ""; String userCommentsLink = getStudentCommentsLink(false); coursePagination = new CoursePagination(previousPageLink, nextPageLink, coursePaginationList, activeCourse, userCommentsLink); }
Source:
<code>public void onNewConnection() { if (commands_.interruptR().isEnabled()) { showError( "The R session is currently busy. Wait for completion or " + "interrupt the current session and retry."); return; } if (!installersUpdated_) { installersUpdated_ = true; server_.updateOdbcInstallers( new DelayedProgressRequestCallback<ConnectionUpdateResult>( "Checking for Updates...") { @Override public void onSuccess(ConnectionUpdateResult result) { installersWarning_ = result.getWarning(); showWizard(); } @Override public void onError(ServerError error) { <START> Debug.logError(error); <END> } } ); } else { showWizard(); } }</code><technical_language>show user this error (otherwise New Connection do anything)</technical_language>

Target:
public void onNewConnection() { if (commands_.interruptR().isEnabled()) { showError( "The R session is currently busy. Wait for completion or " + "interrupt the current session and retry."); return; } if (!installersUpdated_) { installersUpdated_ = true; server_.updateOdbcInstallers( new DelayedProgressRequestCallback<ConnectionUpdateResult>( "Checking for Updates...") { @Override public void onSuccess(ConnectionUpdateResult result) { installersWarning_ = result.getWarning(); showWizard(); } @Override public void onError(ServerError error) { Debug.logError(error); globalDisplay_.showErrorMessage("Failed to check for updates", error.getMessage()); } } ); } else { showWizard(); } }