auphong2707/dl4se-code-review-dataset huggingface dataset:
Source:
<code>private String resolveEnvVars(String str) throws SAXException { Matcher m = Pattern.compile("\\$\\{(.*?)\\}").matcher(str); if (m.find()) { String var = m.group(1); String val = System.getenv(var); if (val != null) { return resolveEnvVars(m.replaceFirst(val)); } else { String msg = "The variable is not defined in the system environment: " + var; <START> throw new SAXException(msg); <END> } } else { return str; } }</code><technical_language>is this a SAX error? wrong throw this exception if appropriate, is some specific reason catch this exception do SAX-specific</technical_language>

Target:
private String resolveEnvVars(String str) { Matcher m = Pattern.compile("\\$\\{(.*?)\\}").matcher(str); if (m.find()) { String var = m.group(1); String val = System.getenv(var); if (val != null) { return resolveEnvVars(m.replaceFirst(val)); } else { String msg = "The variable is not defined in the system environment: " + var; GlobalSettings.kem.registerCriticalError(msg); return null; } } else { return str; } }
Source:
<code>protected void fillOptions(Map<Enum, String> options) { options.put(EnumModel.VAL1, <START> EnumModel.VAL1.toString()); <END> options.put(EnumModel.VAL2, EnumModel.VAL2.toString()); options.put(EnumModel.VAL3, EnumModel.VAL3.toString()); options.put(EnumModel.VAL4, EnumModel.VAL4.toString()); }</code><technical_language>if sense, instead of putting toString() values, I Enum's name() method, toString() is overridden..</technical_language>

Target:
protected void fillOptions(Map<Enum, String> options) { options.put(EnumModel.VAL1, EnumModel.VAL1.name()); options.put(EnumModel.VAL2, EnumModel.VAL2.name()); options.put(EnumModel.VAL3, EnumModel.VAL3.name()); options.put(EnumModel.VAL4, EnumModel.VAL4.name()); }
Source:
<code>private VisibilityControl getVisibility(final ChangeResource rsrc) { <START> VisibilityControl visibilityControl; <END> if (rsrc.getControl().getRefControl().isVisibleByRegisteredUsers()) { visibilityControl = new VisibilityControl() { @Override public boolean isVisibleTo(Account account) throws OrmException { return true; } }; } else { visibilityControl = new VisibilityControl() { @Override public boolean isVisibleTo(Account account) throws OrmException { IdentifiedUser who = identifiedUserFactory.create(dbProvider, account.getId()); return rsrc.getControl().forUser(who).isRefVisible(); } }; } return visibilityControl; }</code><technical_language>Unnecessary local variable; return created object</technical_language>

Target:
private VisibilityControl getVisibility(final ChangeResource rsrc) { if (rsrc.getControl().getRefControl().isVisibleByRegisteredUsers()) { return new VisibilityControl() { @Override public boolean isVisibleTo(Account account) throws OrmException { return true; } }; } else { return new VisibilityControl() { @Override public boolean isVisibleTo(Account account) throws OrmException { IdentifiedUser who = identifiedUserFactory.create(dbProvider, account.getId()); return rsrc.getControl().forUser(who).isRefVisible(); } }; } }
Source:
<code>public final void setTaskContext(TaskContext taskContext) { this.cacheManager = taskContext.getCacheManager(); Map<String, byte[]> rawParams = (Map<String, byte[]>) taskContext.getParameters().get(); parameters = new HashMap<>(rawParams.size()); <START> rawParams.entrySet().stream().forEach(entry -> { <END> parameters.put(entry.getKey(), new String(entry.getValue(), CharsetUtil.UTF_8)); }); String sFlags = parameters.remove("flags"); flags = AdminFlag.fromString(sFlags); }</code><technical_language>collect well. <LINK_0></technical_language>

Target:
public final void setTaskContext(TaskContext taskContext) { this.cacheManager = taskContext.getCacheManager(); Map<String, byte[]> rawParams = (Map<String, byte[]>) taskContext.getParameters().get(); parameters = rawParams.entrySet().stream().collect(Collectors.toMap(Map.Entry::getKey, entry -> new String(entry.getValue(), CharsetUtil.UTF_8))); String sFlags = this.parameters.remove("flags"); flags = AdminFlag.fromString(sFlags); }
Source:
<code>public void setSize(Dimension d) { if (d.width <= 0 || d.height <= 0) { <START> d = new Dimension(600, 600); <END> } float ewidth = d.width / 1.5f; float eheight = d.height / 1.5f; lensShape.setFrame(d.width / 2 - ewidth / 2, d.height / 2 - eheight / 2, ewidth, eheight); }</code><technical_language>hardwiring this size? more sense throw IllegalArgumentException (via Precondition) if dimension passed in is invalid</technical_language>

Target:
public void setSize(Dimension d) { Preconditions.checkNotNull(d); Preconditions.checkArgument(d.width > 0, "width must be > 0"); Preconditions.checkArgument(d.height > 0, "height must be > 0"); float width = d.width / 1.5f; float height = d.height / 1.5f; lensShape.setFrame((d.width - width) / 2, (d.height - height) / 2, width, height); }
Source:
<code>private ComponentKeySource(Properties allKeys, String keyName, boolean isEncrypt) { this.availableKeys = allKeys; this.keyName = keyName; this.isEncrypt = isEncrypt; <START> this.keyForEncrypt = this.availableKeys.stringPropertyNames().stream().max(Comparator.comparing(e -> getVersion(e))) <END> .get(); }</code><technical_language>I need a separate property for encryption. Instead like: if (isEncrypt) { this.keyName = this.availableKeys.... } else { this.KeyName = keyName; }</technical_language>

Target:
private ComponentKeySource(Properties allKeys, String keyName, boolean isEncrypt) { this.availableKeys = allKeys; this.keyName = keyName; this.isEncrypt = isEncrypt; if (this.isEncrypt) { this.keyName = this.availableKeys.stringPropertyNames().stream().max(Comparator.comparing(e -> getVersion(e))).get(); } }
Source:
<code>public void clearAllDismissedEvents() { ClearDismissedAuditLogsBySeverityParameters params = new ClearDismissedAuditLogsBySeverityParameters( <START> Arrays.asList( <END> AuditLogSeverity.ERROR, AuditLogSeverity.WARNING, AuditLogSeverity.NORMAL )); Frontend.getInstance().runAction(VdcActionType.ClearDismissedAuditLogsBySeverity, params, new IFrontendActionAsyncCallback() { @Override public void executed(FrontendActionAsyncResult result) { EventListModel.this.refresh(); } }); }</code><technical_language>IIUC, AuditLogSeverity groups logical entities - events with: * NORMAL * WARNING * ERROR alerts with: * ALERT introduce some method differentiate logical entities? For example: public enum AuditLogSeverity implements Identifiable { ... public boolean isAlert() { ... }; ... } If that, avoid hard-coding enum members (like below)</technical_language>

Target:
public void clearAllDismissedEvents() { Frontend.getInstance().runAction(VdcActionType.ClearDismissedAuditLogEvents, new VdcActionParametersBase(), new IFrontendActionAsyncCallback() { @Override public void executed(FrontendActionAsyncResult result) { EventListModel.this.refresh(); } }); }
Source:
<code>public static UserProfile buildProfile(final String typedId, final Map<String, Object> attributes) { if (CommonHelper.isBlank(typedId)) { return null; } logger.info("Building user profile based on typedId {}", typedId); try { if (!typedId.contains("#")) { <START> final String completeName = determineProfileClassByName("HttpProfile"); <END> return buildUserProfileByClassCompleteName(typedId, attributes, completeName); } final String[] values = typedId.split("#"); final String className = values[0]; final String completeName = determineProfileClassByName(className); return buildUserProfileByClassCompleteName(typedId, attributes, completeName); } catch (final Exception e) { logger.error("Cannot build instance", e); } return null; }</code><technical_language>I code handling # in JwtAuthenticator</technical_language>

Target:
public static UserProfile buildProfile(final String typedId, final Map<String, Object> attributes) { if (CommonHelper.isBlank(typedId)) { return null; } logger.info("Building user profile based on typedId {}", typedId); try { final String[] values = typedId.split(UserProfile.SEPARATOR); if (values.length >= 1) { final String className = values[0]; final String completeName = determineProfileClassByName(className); return buildUserProfileByClassCompleteName(typedId, attributes, completeName); } } catch (final Exception e) { logger.error("Cannot build instance", e); } return null; }
Source:
<code>synchronized void resetTo() { <START> for(int i = 0; i < checkpoints.length; i++){ <END> checkpoints[i] = null; } c = 0; s = -1L; lag = new long[lagLen]; }</code><technical_language>Arrays.fill()</technical_language>

Target:
synchronized void resetTo() { Arrays.fill(checkpoints, null); c = 0; s = -1L; lag = new long[lagLen]; }
Source:
<code>public ClusteringServiceConfigurationBuilder readOperationTimeout(long duration, TimeUnit unit) { <START> Duration readTimeout = Duration.of(duration, toChronoUnit(unit)); <END> return timeouts(Timeouts.builder().setReadOperationTimeout(readTimeout).build()); }</code><technical_language>This throw, case before. I hide simply largest java.time.Duration in case is passed in is large, in end, a difference</technical_language>

Target:
public ClusteringServiceConfigurationBuilder readOperationTimeout(long duration, TimeUnit unit) { Duration readTimeout = Duration.of(duration, toChronoUnit(unit)); return timeouts(TimeoutsBuilder.timeouts().read(readTimeout).build()); }
Source:
<code>public static String getToken(final HttpServletRequest req) { String token = req.getPathInfo(); <START> if (token == null || token.isEmpty()) { token = '#' + PageLinks.MINE; } else { token = Url.decode(token.substring(1)); } <END> return token; }</code><technical_language>this inconsistent? In case token starts '#', in case. start '#'</technical_language>

Target:
public static String getToken(final HttpServletRequest req) { String token; String encodedToken = req.getPathInfo(); if (encodedToken == null || encodedToken.isEmpty()) { token = DEFAULT_TOKEN; } else { if (encodedToken.startsWith("/")) { encodedToken = encodedToken.substring(1); } token = Url.decode(encodedToken); } return token; }
Source:
<code>public void testBytesRowsForSelectWithLimitIgnored() throws Exception { String sql = "SELECT * FROM " + tableA + " where (c1.a > c2.b) limit 1"; List<Object> binds = Lists.newArrayList(); try (Connection conn = DriverManager.getConnection(getUrl())) { Estimate info = getByteRowEstimates(conn, sql, binds); <START> assertEquals((Long) 979L, info.estimatedBytes); <END> assertEquals((Long) 10L, info.estimatedRows); assertTrue(info.estimateInfoTs > 0); } }</code><technical_language>nit: a constant, especially reused</technical_language>

Target:
public void testBytesRowsForSelectWithLimitIgnored() throws Exception { String sql = "SELECT * FROM " + tableA + " where (c1.a > c2.b) limit 1"; List<Object> binds = Lists.newArrayList(); try (Connection conn = DriverManager.getConnection(getUrl())) { ResultSet rs = conn.createStatement().executeQuery(sql); assertFalse(rs.next()); Estimate info = getByteRowEstimates(conn, sql, binds); assertEquals((Long) 390L, info.estimatedBytes); assertEquals((Long) 10L, info.estimatedRows); assertTrue(info.estimateInfoTs > 0); } }
Source:
<code>public JobResource toResource(JobDto job) { JobResource jobResource = instantiateResource(job); addSelfLink(jobResource); <START> addEditLink(jobResource); <END> return jobResource; }</code><technical_language>This is true. is DELETE PATCH UPDATE a job (only a job group)</technical_language>

Target:
public JobResource toResource(JobDto job) { JobResource jobResource = instantiateResource(job); addSelfLink(jobResource); return jobResource; }
Source:
<code>public SchemaRepository<Schema> provide() { <START> return new SchemaRepository<>(schemaSourceProvider, Executors.newFixedThreadPool(2), source -> new Schema.Parser().parse(source.value())); <END> }</code><technical_language>thread pool size configurable threads named</technical_language>

Target:
public SchemaRepository<Schema> provide() { return new SchemaRepository<>(configFactory, schemaSourceProvider, createSchemaReloadExecutorService(configFactory, "avro"), source -> new Schema.Parser().parse(source.value())); }
Source:
<code>public GdbEventsTable(Composite parent, int cacheSize) { super(parent, cacheSize, GDB_COLUMNS); fTable.getColumns()[2].setData(Key.FIELD_ID, ITmfEvent.EVENT_FIELD_REFERENCE); <START> fTable.getColumns()[3].setData(Key.FIELD_ID, ITmfEvent.EVENT_FIELD_CONTENT); <END> addSelectionChangedListener(new ISelectionChangedListener() { @Override public void selectionChanged(SelectionChangedEvent e) { TableItem[] selection = fTable.getSelection(); if (selection.length > 0) { TableItem selectedTableItem = selection[0]; if (selectedTableItem != null) { Object data = selectedTableItem.getData(); if (data instanceof GdbTraceEvent) { GdbTraceEvent event = (GdbTraceEvent) data; GdbTrace gdbTrace = (GdbTrace) event.getTrace(); GdbTraceEventContent content = event.getContent(); selectFrame(gdbTrace, content.getFrameNumber()); return; } } } fSelectedTrace = null; } }); }</code><technical_language>alignment set manually here</technical_language>

Target:
public GdbEventsTable(Composite parent, int cacheSize) { super(parent, cacheSize, GDB_COLUMNS); fTable.getColumns()[0].setAlignment(SWT.RIGHT); fTable.getColumns()[1].setAlignment(SWT.RIGHT); addSelectionChangedListener(new ISelectionChangedListener() { @Override public void selectionChanged(SelectionChangedEvent e) { TableItem[] selection = fTable.getSelection(); if (selection.length > 0) { TableItem selectedTableItem = selection[0]; if (selectedTableItem != null) { Object data = selectedTableItem.getData(); if (data instanceof GdbTraceEvent) { GdbTraceEvent event = (GdbTraceEvent) data; GdbTrace gdbTrace = (GdbTrace) event.getTrace(); GdbTraceEventContent content = event.getContent(); selectFrame(gdbTrace, content.getFrameNumber()); return; } } } fSelectedTrace = null; } }); }
Source:
<code>public void applyFix(@NotNull Project project, @NotNull ProblemDescriptor descriptor) { PsiElement element = descriptor.getPsiElement(); if (!(element instanceof GoConditionalExpr)) { return; } GoConditionalExpr expr = (GoConditionalExpr)element; if (expr.getEq() == null) { return; } GoExpression left = expr.getLeft(); GoExpression right = expr.getRight(); if (left instanceof GoIndexOrSliceExpr && right instanceof GoStringLiteral) { GoStringLiteral literal = (GoStringLiteral)right; if (!isSingleCharLiteral(literal)) { return; } expr.replace(createComparison(project, left.getText() + " == " + extractSingleCharFromText(literal))); } else if (left instanceof GoStringLiteral && right instanceof GoIndexOrSliceExpr) { GoStringLiteral literal = (GoStringLiteral)left; if (!isSingleCharLiteral(literal)) { return; } <START> expr.replace(createComparison(project, extractSingleCharFromText(literal) + " == " + right.getText())); <END> } }</code><technical_language>replace string literal: literal.replace(createStringLiteral()) is bad replace expression simple statement.You GoElementFactory#createExpression</technical_language>

Target:
public void applyFix(@NotNull Project project, @NotNull ProblemDescriptor descriptor) { PsiElement element = descriptor.getPsiElement(); if (!(element instanceof GoConditionalExpr)) { return; } GoConditionalExpr expr = (GoConditionalExpr)element; GoStringLiteral literal = getFirstElementOfType(GoStringLiteral.class, expr.getLeft(), expr.getRight()); if (literal == null || !isSingleCharLiteral(literal)) { return; } literal.replace(createExpression(project, extractSingleCharFromText(literal))); }
Source:
<code>public void addPartitions(String databaseName, String tableName, List<CatalogProtos.PartitionDescProto> partitions , boolean ifNotExists) { HiveCatalogStoreClientPool.HiveCatalogStoreClient client = null; List<Partition> addPartitions = TUtil.newList(); CatalogProtos.PartitionDescProto existingPartition = null; try { client = clientPool.getClient(); for (CatalogProtos.PartitionDescProto partitionDescProto : partitions) { existingPartition = getPartition(databaseName, tableName, partitionDescProto.getPartitionName()); <START> if (existingPartition != null) { <END> Partition partition = new Partition(); partition.setDbName(databaseName); partition.setTableName(tableName); List<String> values = Lists.newArrayList(); for(CatalogProtos.PartitionKeyProto keyProto : partitionDescProto.getPartitionKeysList()) { values.add(keyProto.getPartitionValue()); } partition.setValues(values); Table table = client.getHiveClient().getTable(databaseName, tableName); StorageDescriptor sd = table.getSd(); sd.setLocation(partitionDescProto.getPath()); partition.setSd(sd); addPartitions.add(partition); } } if (addPartitions.size() > 0) { client.getHiveClient().add_partitions(addPartitions, true, true); } } catch (Exception e) { throw new TajoInternalError(e); } finally { if (client != null) { client.release(); } } }</code><technical_language>This change is wrong</technical_language>

Target:
public void addPartitions(String databaseName, String tableName, List<CatalogProtos.PartitionDescProto> partitions , boolean ifNotExists) { HiveCatalogStoreClientPool.HiveCatalogStoreClient client = null; List<Partition> addPartitions = TUtil.newList(); CatalogProtos.PartitionDescProto existingPartition = null; try { client = clientPool.getClient(); for (CatalogProtos.PartitionDescProto partitionDescProto : partitions) { existingPartition = getPartition(databaseName, tableName, partitionDescProto.getPartitionName()); if (existingPartition == null) { Partition partition = new Partition(); partition.setDbName(databaseName); partition.setTableName(tableName); List<String> values = Lists.newArrayList(); for(CatalogProtos.PartitionKeyProto keyProto : partitionDescProto.getPartitionKeysList()) { values.add(keyProto.getPartitionValue()); } partition.setValues(values); Table table = client.getHiveClient().getTable(databaseName, tableName); StorageDescriptor sd = table.getSd(); sd.setLocation(partitionDescProto.getPath()); partition.setSd(sd); addPartitions.add(partition); } } if (addPartitions.size() > 0) { client.getHiveClient().add_partitions(addPartitions, true, true); } } catch (Exception e) { throw new TajoInternalError(e); } finally { if (client != null) { client.release(); } } }
Source:
<code>public void addFavourite(@PathVariable WorkflowName workflowName) throws IOException { User user = securityManager.getUserById((long) 1); Set<WorkflowName> favouriteWorkflows = user.getFavouriteWorkflows(); favouriteWorkflows.add(workflowName); <START> user.setFavouriteWorkflows(favouriteWorkflows); <END> securityManager.saveUser(user); }</code><technical_language>This set (and line 103 unnecessary. collection is in object</technical_language>

Target:
public void addFavourite(@PathVariable WorkflowName workflowName) throws IOException { User user = authorizationManager.getCurrentUser(); Set<WorkflowName> favouriteWorkflows = user.getFavouriteWorkflows(); favouriteWorkflows.add(workflowName); securityManager.saveUser(user); }
Source:
<code>public void start(ConnectionFactoryConfiguration config, ClassLoader classLoader) throws PersistenceException { PooledConnectionFactoryConfiguration poolConfig; if (config instanceof PooledConnectionFactoryConfiguration) { poolConfig = (PooledConnectionFactoryConfiguration) config; } else { throw new PersistenceException("ConnectionFactoryConfiguration passed in must be an instance of " + "PooledConnectionFactoryConfiguration"); } try { String propsFile = poolConfig.propertyFile(); if (propsFile != null) { dataSource = AgroalDataSource.from(new AgroalPropertiesReader(PROPERTIES_PREFIX).readProperties(propsFile)); } else { String password = poolConfig.password() != null ? poolConfig.password() : ""; AgroalDataSourceConfigurationSupplier configuration = new AgroalDataSourceConfigurationSupplier() .connectionPoolConfiguration(cp -> cp <START> .minSize(10) END> .maxSize(10) .acquisitionTimeout(Duration.ofSeconds(30)) .connectionFactoryConfiguration(cf -> cf .jdbcUrl(poolConfig.connectionUrl()) .connectionProviderClassName(poolConfig.driverClass()) .jdbcTransactionIsolation(AgroalConnectionFactoryConfiguration.TransactionIsolation.UNDEFINED) .principal(new NamePrincipal(poolConfig.username())) .credential(new SimplePassword(password)) )); dataSource = AgroalDataSource.from(configuration); } } catch (Exception e) { throw new PersistenceException("Failed to create a AgroalDataSource", e); } }</code><technical_language>I this is unnecessarily aggressive. If user wants tuning props file</technical_language>

Target:
public void start(ConnectionFactoryConfiguration config, ClassLoader classLoader) throws PersistenceException { PooledConnectionFactoryConfiguration poolConfig; if (config instanceof PooledConnectionFactoryConfiguration) { poolConfig = (PooledConnectionFactoryConfiguration) config; } else { throw new PersistenceException("ConnectionFactoryConfiguration passed in must be an instance of " + "PooledConnectionFactoryConfiguration"); } try { String propsFile = poolConfig.propertyFile(); if (propsFile != null) { dataSource = AgroalDataSource.from(new AgroalPropertiesReader(PROPERTIES_PREFIX).readProperties(propsFile)); } else { String password = poolConfig.password() != null ? poolConfig.password() : ""; AgroalDataSourceConfigurationSupplier configuration = new AgroalDataSourceConfigurationSupplier() .connectionPoolConfiguration(cp -> cp .maxSize(10) .acquisitionTimeout(Duration.ofSeconds(30)) .connectionFactoryConfiguration(cf -> cf .jdbcUrl(poolConfig.connectionUrl()) .connectionProviderClassName(poolConfig.driverClass()) .jdbcTransactionIsolation(AgroalConnectionFactoryConfiguration.TransactionIsolation.UNDEFINED) .principal(new NamePrincipal(poolConfig.username())) .credential(new SimplePassword(password)) )); dataSource = AgroalDataSource.from(configuration); } } catch (Exception e) { throw new PersistenceException("Failed to create a AgroalDataSource", e); } }
Source:
<code>private void setupComboBox() { comboBox.setFocusTraversable(false); comboBox.setEditable(true); comboBox.valueProperty().addListener((observable, old, newVal) -> { if (newVal == null) { return; } String repoId = Utility.removeAllWhiteSpaces(newVal); if (!repoId.equals(newVal)) { comboBox.setValue(repoId); return; } if (Utility.isWellFormedRepoId(repoId) && !changesDisabled) { onValueChangeCallback.accept(repoId); } }); comboBox.addEventFilter(KeyEvent.KEY_RELEASED, event -> { event.consume(); if (event.getCode() == KeyboardShortcuts.REMOVE_FOCUS) { <START> if (ui.isTestMode()) { <END> ui.triggerEvent(new UIComponentFocusEvent(UIComponentFocusEvent.EventType.REPO_SELECTOR)); } getParent().requestFocus(); } }); }</code><technical_language>hmm yeah i it, check if repo selector focus instead of checking for event</technical_language>

Target:
private void setupComboBox() { comboBox.setFocusTraversable(false); comboBox.setEditable(true); comboBox.valueProperty().addListener((observable, old, newVal) -> { if (newVal == null) { return; } String repoId = Utility.removeAllWhiteSpaces(newVal); if (!repoId.equals(newVal)) { comboBox.setValue(repoId); return; } if (Utility.isWellFormedRepoId(repoId) && !changesDisabled) { onValueChangeCallback.accept(repoId); } }); comboBox.addEventFilter(KeyEvent.KEY_RELEASED, event -> { event.consume(); if (event.getCode() == KeyboardShortcuts.REMOVE_FOCUS) { getParent().requestFocus(); } }); }
Source:
<code>public FormRecognizerClientBuilder credential(TokenCredential tokenCredential) { Objects.requireNonNull(tokenCredential, "'tokenCredential' cannot be null."); <START> this.tokenCredential = tokenCredential; <END> return this; }</code><technical_language>this.tokenCredential = Objects.requireNonNull(tokenCredential, "'tokenCredential' null.");</technical_language>

Target:
public FormRecognizerClientBuilder credential(TokenCredential tokenCredential) { this.tokenCredential = Objects.requireNonNull(tokenCredential, "'tokenCredential' cannot be null."); return this; }
Source:
<code>public void setScanner(DirectoryScanner scanner) { Assert.notNull(scanner, "scanner must not be null"); <START> this.fileSource.setScanner(scanner); <END> this.scannerExplicitlySet = true; }</code><technical_language>this.fileSource.setScanner(scanner); takes care assert. need this extra</technical_language>

Target:
public void setScanner(DirectoryScanner scanner) { this.fileSource.setScanner(scanner); this.scannerExplicitlySet = true; }
Source:
<code>public synchronized void notifyDisconnect(Channel channel) { logger.debug("Peer {}: notifies about disconnect", channel); <START> channel.onDisconnect(); <END> syncPool.onDisconnect(channel); activePeers.values().remove(channel); newPeers.remove(channel); }</code><technical_language>here. is need call notify methods lock. potentially deadlock side effects</technical_language>

Target:
public void notifyDisconnect(Channel channel) { logger.debug("Peer {}: notifies about disconnect", channel); channel.onDisconnect(); syncPool.onDisconnect(channel); synchronized(this) { activePeers.values().remove(channel); newPeers.remove(channel); } }
Source:
<code>protected LanguageFilteringGraph(Graph g, List<String> preferredLanguages) { super(g); this.langs = preferredLanguages; <START> this.toString = "LanguageFilteringGraph[wrapping " <END> + ToString.graphToString(g) + "]"; }</code><technical_language>Is correct assume state of graph, g, change time? If so, capturing state of g point of construction produce a misleading result calling toString() in future... opposed moving this line:37 body of toString() method</technical_language>

Target:
protected LanguageFilteringGraph(Graph g, List<String> preferredLanguages) { super(g); this.langs = preferredLanguages; }
Source:
<code>private LifecycleException stopInstances( List<LifecycleInstance> instances ) { LifecycleException ex = null; for ( int i = instances.size() - 1; i >= 0; i-- ) { LifecycleInstance lifecycleInstance = instances.get( i ); try { lifecycleInstance.stop(); } catch ( LifecycleException e ) { <START> if ( ex != null ) <END> { ex.addSuppressed( e ); } else { ex = e; } } } return ex; }</code><technical_language>org.neo4j.helpers.Exceptions#chain here</technical_language>

Target:
private LifecycleException stopInstances( List<LifecycleInstance> instances ) { LifecycleException ex = null; for ( int i = instances.size() - 1; i >= 0; i-- ) { LifecycleInstance lifecycleInstance = instances.get( i ); try { lifecycleInstance.stop(); } catch ( LifecycleException e ) { ex = Exceptions.chain( ex, e ); } } return ex; }
Source:
<code>public EventResource findById(@PathVariable long eventId) { Optional<ProcessEngineEventEntity> findResult = eventsRepository.findById(eventId); if (!findResult.isPresent()) { <START> throw new ActivitiException("Unable to find events for the given id:'" + eventId + "'"); <END> } return eventResourceAssembler.toResource(findResult.get()); }</code><technical_language>in singular</technical_language>

Target:
public EventResource findById(@PathVariable long eventId) { Optional<ProcessEngineEventEntity> findResult = eventsRepository.findById(eventId); if (!findResult.isPresent()) { throw new ActivitiException("Unable to find event for the given id:'" + eventId + "'"); } return eventResourceAssembler.toResource(findResult.get()); }
Source:
<code><START> private AbstractPack200 getPack200() { <END> StringTokenizer st = new StringTokenizer(System.getProperty("java.version"), "."); int major = st.hasMoreTokens() ? Integer.parseInt(st.nextToken()) : -1; int minor = st.hasMoreElements() ? Integer.parseInt(st.nextToken()) : -1; if (major <= 1 && minor <= 6) { return new ForkedPack200(); } return new InprocessPack200(); }</code><technical_language>add reference JDK bug</technical_language>

Target:
private Pack200Wrapper getPack200() { try { Class.forName("java.nio.file.FileSystem"); return new Pack200Wrapper(); } catch (ClassNotFoundException mustBeJava6orEarlier) { return new ForkedPack200Wrapper(); } }
Source:
<code>public int[] findMatchingLines() { int[] index = new int[report.size()]; int dbLine = database.size(); int reportLine = report.size(); try { PathNode node = MyersDiff.buildPath(database.toArray(), report.toArray()); while (node.prev != null) { PathNode prevNode = node.prev; if (!node.isSnake()) { reportLine -= (node.j - prevNode.j); dbLine -= (node.i - prevNode.i); } else { for (int i = node.i; i > prevNode.i; i--) { index[reportLine - 1] = dbLine; reportLine--; dbLine--; } } node = prevNode; } <START> } catch (Exception e) { <END> return index; } return index; }</code><technical_language>catch(DifferentiationFailedException) more exact. logged ERROR</technical_language>

Target:
public int[] findMatchingLines() { int[] index = new int[right.size()]; int dbLine = left.size(); int reportLine = right.size(); try { PathNode node = MyersDiff.buildPath(left.toArray(), right.toArray()); while (node.prev != null) { PathNode prevNode = node.prev; if (!node.isSnake()) { reportLine -= (node.j - prevNode.j); dbLine -= (node.i - prevNode.i); } else { for (int i = node.i; i > prevNode.i; i--) { index[reportLine - 1] = dbLine; reportLine--; dbLine--; } } node = prevNode; } } catch (DifferentiationFailedException e) { LOG.error("Error finding matching lines", e); return index; } return index; }
Source:
<code>private String formatDate(Date date) { if (date == null) return null; else <START> return DATE_TIME_FORMATTER.format(Instant.ofEpochMilli(date.getTime())); <END> }</code><technical_language>fyi date.toInstant() method (implemented it)</technical_language>

Target:
private String formatDate(Date date) { if (date == null) return null; else return DATE_TIME_FORMATTER.format(date.toInstant()); }
Source:
<code>public NotImplementedError() { <START> super("an implementation is missing"); <END> }</code><technical_language>start message upper case char? in [java.text.DateFormatSymbols#getInstance(Locale)](<LINK_0></technical_language>

Target:
public NotImplementedError() { super("An implementation is missing."); }
Source:
<code>protected Optional<TokenRingDiagnosticGenerator> createForSimpleStrategy( KeyspaceMetadata keyspace, ConsistencyLevel consistencyLevel) { ConsistencyLevel filteredConsistencyLevel = ConsistencyLevels.filterForSimpleStrategy(consistencyLevel); if (filteredConsistencyLevel != consistencyLevel) { LOG.warn( String.format( "Consistency level %s is not compatible with the SimpleStrategy replication configured for keyspace %s." + "Token ring health reports will assume %s instead.", <START> consistencyLevel, keyspace.getName().asCql(true), filteredConsistencyLevel)); <END> } ReplicationFactor replicationFactor = ReplicationFactor.fromString(keyspace.getReplication().get("replication_factor")); DefaultTokenRingDiagnosticGenerator generator = new DefaultTokenRingDiagnosticGenerator( metadata, keyspace, filteredConsistencyLevel, replicationFactor); return Optional.of(generator); }</code><technical_language>fail here, user pass applicable CL</technical_language>

Target:
protected TokenRingDiagnosticGenerator createForSimpleStrategy( KeyspaceMetadata keyspace, ConsistencyLevel consistencyLevel) { if (consistencyLevel.isDcLocal() || consistencyLevel == ConsistencyLevel.EACH_QUORUM) { throw new IllegalArgumentException( String.format( "Consistency level %s is not compatible with the SimpleStrategy replication configured for keyspace %s", consistencyLevel, keyspace.getName().asCql(true))); } ReplicationFactor replicationFactor = ReplicationFactor.fromString(keyspace.getReplication().get("replication_factor")); return new DefaultTokenRingDiagnosticGenerator( metadata, keyspace, consistencyLevel, replicationFactor); }
Source:
<code>public static List<Object> map(EntityType entityType) { <START> List<Object> row = Lists.newArrayList(); <END> for (Entry<String, String> entry : ENTITIES_ATTRS.entrySet()) { switch (entry.getKey()) { case EMX_ENTITIES_TAGS: row.add(getTags(entityType)); break; case EMX_ENTITIES_EXTENDS: row.add(entityType.getExtends() != null ? entityType.getExtends().getId() : ""); break; case EMX_ENTITIES_PACKAGE: row.add(getPackageId(entityType)); break; case EMX_ENTITIES_NAME: row.add(getName(entityType)); break; default: Object value = entityType.get(entry.getValue()); row.add(value != null ? value.toString() : ""); break; } } return row; }</code><technical_language>suggestion List<Object> row = new ArrayList<>(ENTITIES_ATTRS.size());</technical_language>

Target:
public static List<Object> map(EntityType entityType) { List<Object> row = new ArrayList<>(ENTITIES_ATTRS.size()); for (Entry<String, String> entry : ENTITIES_ATTRS.entrySet()) { switch (entry.getKey()) { case EMX_ENTITIES_TAGS: row.add(getTags(entityType)); break; case EMX_ENTITIES_EXTENDS: row.add(entityType.getExtends() != null ? entityType.getExtends().getId() : ""); break; case EMX_ENTITIES_PACKAGE: row.add(getPackageId(entityType)); break; case EMX_ENTITIES_NAME: row.add(getName(entityType)); break; default: Object value = entityType.get(entry.getValue()); row.add(value != null ? value.toString() : ""); break; } } return row; }
Source:
<code>private Response doGetAllSchemaVersionForBranch(String schemaName, String branchName) { try { LOG.info("Get all versions for schema : {}", schemaName); <START> List<Byte> states = Collections.singletonList(SchemaVersionLifecycleStates.ENABLED.getId()); <END> Collection<SchemaVersionInfo> schemaVersionInfos = schemaRegistryClient.getAllVersions(effectiveBranchName(branchName), schemaName, states); Collection<String> schemaVersions = new ArrayList<>(); if (schemaVersionInfos != null && !schemaVersionInfos.isEmpty()) { LOG.debug("Received schema versions from schema registry: {}", schemaVersionInfos); schemaVersions = schemaVersionInfos.stream().map(x -> x.getVersion().toString()).collect(Collectors.toList()); return WSUtils.respondEntities(schemaVersions, OK); } else { LOG.debug("Received null response for schema versions from schema registry for schema: {}", schemaName); return WSUtils.respondEntity(schemaVersions, NOT_FOUND); } } catch (SchemaNotFoundException e) { LOG.error("Schema not found: [{}]", schemaName, e); throw EntityNotFoundException.byName(schemaName); } catch (Exception e) { throw new RuntimeException(e); } }</code><technical_language>@satishd other question i refreshing SR branching feature is allow a schema branch version in a "in review" other custom state producer/consumer. Here, returning ENABLED schemas. Is a reason for allowing schema versions in states</technical_language>

Target:
private Response doGetAllSchemaVersionForBranch(String schemaName, String branchName) { try { LOG.info("Get all versions for schema : {}", schemaName); Collection<SchemaVersionInfo> schemaVersionInfos = schemaRegistryClient.getAllVersions(effectiveBranchName(branchName), schemaName); LOG.debug("Received schema versions from schema registry for schema: {}", schemaVersionInfos, schemaName); if (schemaVersionInfos != null && !schemaVersionInfos.isEmpty()) { List<String> schemaVersions = schemaVersionInfos.stream().map(x -> x.getVersion().toString()).collect(Collectors.toList()); return WSUtils.respondEntities(schemaVersions, OK); } else { return WSUtils.respondEntity(Collections.EMPTY_LIST, NOT_FOUND); } } catch (SchemaNotFoundException e) { LOG.error("Schema not found: [{}]", schemaName, e); throw EntityNotFoundException.byName(schemaName); } catch (Exception e) { throw new RuntimeException(e); } }
Source:
<code>private IBranchNameProvider getBranchNameProvider() { IExtensionRegistry registry = Platform.getExtensionRegistry(); IConfigurationElement[] config = registry .getConfigurationElementsFor(BRANCH_NAME_PROVIDER_ID); if (config.length > 0) { Object provider; try { provider = config[0].createExecutableExtension("class"); if (provider instanceof IBranchNameProvider) return (IBranchNameProvider) provider; } catch (Throwable e) { <START> Activator.logError("Failed to create branch name provider", e); END> } } return null; }</code><technical_language>I consistent i18n here, I guess this slip too, or? (I do hope translates EGit Swedish...)</technical_language>

Target:
private IBranchNameProvider getBranchNameProvider() { IExtensionRegistry registry = Platform.getExtensionRegistry(); IConfigurationElement[] config = registry .getConfigurationElementsFor(BRANCH_NAME_PROVIDER_ID); if (config.length > 0) { Object provider; try { provider = config[0].createExecutableExtension("class"); if (provider instanceof IBranchNameProvider) return (IBranchNameProvider) provider; } catch (Throwable e) { Activator.logError( UIText.CreateBranchPage_CreateBranchNameProviderFailed, e); } } return null; }
Source:
<code>private void testFormulaEditorInput(int phiroLedColorEditText, int phiroLedColorTextView) { solo.clickOnView(solo.getView(phiroLedColorEditText)); solo.clickOnView(solo.getView(phiroLedColorTextView)); <START> insertDoubleIntoEditText(solo, 100.0); <END> solo.clickOnView(solo.getView(R.id.formula_editor_keyboard_ok)); solo.waitForView(phiroLedColorEditText); TextView textView = ((TextView) solo.getView(phiroLedColorEditText)); assertEquals("Text not updated", 100.0, Double.parseDouble(textView.getText().toString().replace(',', '.'))); }</code><technical_language>Hmm, pmd complain this? If I undo changes here, I get pmd warnings. If this pmd complains, please undo :smirk_cat:</technical_language>

Target:
private void testFormulaEditorInput(int phiroLedColorEditText, int phiroLedColorTextView) { solo.clickOnView(solo.getView(phiroLedColorEditText)); solo.clickOnView(solo.getView(phiroLedColorTextView)); UiTestUtils.insertDoubleIntoEditText(solo, 100.0); solo.clickOnView(solo.getView(R.id.formula_editor_keyboard_ok)); solo.waitForView(phiroLedColorEditText); TextView textView = ((TextView) solo.getView(phiroLedColorEditText)); assertEquals("Text not updated", 100.0, Double.parseDouble(textView.getText().toString().replace(',', '.'))); }
Source:
<code>public void writeTo(StreamOutput out) throws IOException { writeNullable(bucket, out); writeNullable(records, out); writeNullable(influencers, out); writeNullable(quantiles, out); writeNullable(modelSnapshot, out); writeNullable(modelSizeStats, out); writeNullable(modelPlot, out); <START> if (out.getVersion().onOrAfter(Version.V_7_9_0)) { <END> writeNullable(annotation, out); } writeNullable(categoryDefinition, out); writeNullable(flushAcknowledgement, out); writeNullable(forecast, out); writeNullable(forecastRequestStats, out); }</code><technical_language>above, save work delete this line now</technical_language>

Target:
public void writeTo(StreamOutput out) throws IOException { writeNullable(bucket, out); writeNullable(records, out); writeNullable(influencers, out); writeNullable(quantiles, out); writeNullable(modelSnapshot, out); writeNullable(modelSizeStats, out); writeNullable(modelPlot, out); writeNullable(annotation, out); writeNullable(categoryDefinition, out); writeNullable(flushAcknowledgement, out); writeNullable(forecast, out); writeNullable(forecastRequestStats, out); }
Source:
<code>public ASBSound parseSound(String text, String key){ String[] split = text.split(";"); Sound sound; float pitch; float volume; if(Sound.valueOf(split[0]) != null) sound = Sound.valueOf(split[0]); else { <START> plugin.getLogger().warning("Could not parse \"" + text + "\" in \"" + key + "\" : Sound does not exist."); <END> return null; } try{ pitch = Float.valueOf(split[1]); if(pitch <= 0){ plugin.getLogger().warning("Could not parse \"" + text + "\" in \"" + key + "\" : Pitch must be higher than 0. Setting it to 1."); pitch = 1.0F; } } catch(NumberFormatException e) { plugin.getLogger().warning("Could not parse \"" + text + "\" in \"" + key + "\" : Pitch invalid."); return null; } try{ volume = Float.valueOf(split[2]); if(volume <= 0){ plugin.getLogger().warning("Could not parse \"" + text + "\" in \"" + key + "\" : Volume must be higher than 0. Setting it to 1."); volume = 1.0F; } } catch(NumberFormatException e) { plugin.getLogger().warning("Could not parse \"" + text + "\" in \"" + key + "\" : Volume invalid."); return null; } return new ASBSound(sound, pitch, volume); }</code><technical_language>good a list of sounds provided if error</technical_language>

Target:
public ASBSound parseSound(String text, String key){ text = text.toUpperCase(); String[] split = text.split(";"); if(split.length != 3){ plugin.getLogger().warning("Could not parse \"" + text + "\" in \"" + key + "\" : Invalid format. Must be \"SOUND_ID;PITCH;VOLUME\""); return null; } Sound sound; float pitch; float volume; if(plugin.getServer().getVersion().contains("(MC: 1.8")){ text = text.replace("BLOCK_", "").replace("ENTITY_", ""); } if(Sound.valueOf(split[0]) != null) sound = Sound.valueOf(split[0]); else { plugin.getLogger().warning("Could not parse \"" + text + "\" in \"" + key + "\" : Sound does not exist."); plugin.getLogger().info("Here is a list of available sounds:"); for(Sound s : Sound.values()) System.out.print(s + ", "); return null; } try{ pitch = Float.valueOf(split[1]); if(pitch <= 0){ plugin.getLogger().warning("Error while parsing \"" + text + "\" in \"" + key + "\" : Pitch must be higher than 0. Setting it to 1."); pitch = 1.0F; } } catch(NumberFormatException e) { plugin.getLogger().warning("Could not parse \"" + text + "\" in \"" + key + "\" : Invalid pitch."); return null; } try{ volume = Float.valueOf(split[2]); if(volume <= 0){ plugin.getLogger().warning("Error while parsing \"" + text + "\" in \"" + key + "\" : Volume must be higher than 0. Setting it to 1."); volume = 1.0F; } } catch(NumberFormatException e) { plugin.getLogger().warning("Could not parse \"" + text + "\" in \"" + key + "\" : Invalid volume."); return null; } return new ASBSound(sound, pitch, volume); }
Source:
<code>public void testUpdateAndGetPageStructure() throws Exception { <START> List<UUID> ids = pageStructureService.selectAllPageStructureIds(); <END> UUID page = ids.get(0); Response updatePageStructureResponse = translationResource.updatePageStructure("en", "kgp", page ,"draft-access", null); Assert.assertEquals(updatePageStructureResponse.getStatus(), 201); Response getPageStructureResponse = translationResource.getPageStructure("en", "kgp", page, "draft-access", null); Assert.assertEquals(getPageStructureResponse.getStatus(), 200); }</code><technical_language>This is okay, I hard coding a UUID instead of fetching first. Also, is need pass some XML update method</technical_language>

Target:
public void testUpdateAndGetPageStructure() throws Exception { List<UUID> ids = pageStructureService.selectAllPageStructureIds(); UUID page = ids.get(0); Document testDoc = createXMLDocument(); Response updatePageStructureResponse = translationResource.updatePageStructure(testDoc, "en", "kgp", page ,"draft-access", null); Assert.assertEquals(updatePageStructureResponse.getStatus(), 204); Response getPageStructureResponse = translationResource.getPageStructure("en", "kgp", page, "draft-access", null); Assert.assertEquals(getPageStructureResponse.getStatus(), 200); }
Source:
<code>public void start() { logger.info("Starting river {}", riverName.getName()); Status status = MongoDBRiverHelper.getRiverStatus(esClient, riverName.getName()); if (status == Status.IMPORT_FAILED || status == Status.INITIAL_IMPORT_FAILED || status == Status.SCRIPT_IMPORT_FAILED || status == Status.START_FAILED) { logger.error("Cannot start river {}. Current status is {}", riverName.getName(), status); return; } logger.info("{} - {}", DESCRIPTION, MongoDBHelper.getRiverVersion()); logger.info( "starting mongodb stream. options: secondaryreadpreference [{}], drop_collection [{}], include_collection [{}], throttlesize [{}], gridfs [{}], filter [{}], db [{}], collection [{}], script [{}], indexing to [{}]/[{}]", definition.isMongoSecondaryReadPreference(), definition.isDropCollection(), definition.getIncludeCollection(), definition.getThrottleSize(), definition.isMongoGridFS(), definition.getMongoOplogFilter(), definition.getMongoDb(), definition.getMongoCollection(), definition.getScript(), definition.getIndexName(), definition.getTypeName()); for (ServerAddress server : definition.getMongoServers()) { logger.debug("Using mongodb server(s): host [{}], port [{}]", server.getHost(), server.getPort()); } if (status == Status.STOPPED) { context.setStatus(Status.STOPPED); <START> logger.info("River is currently disabled", riverName.getName()); <END> } else { context.setStatus(Status.STARTING); MongoDBRiverHelper.setRiverStatus(esClient, riverName.getName(), Status.RUNNING); } statusThread = EsExecutors.daemonThreadFactory(settings.globalSettings(), "mongodb_river_status:" + definition.getIndexName()).newThread( new StatusChecker(this, definition, context)); statusThread.start(); }</code><technical_language>change to: River is currently disabled started</technical_language>

Target:
public void start() { logger.info("{} - {}", DESCRIPTION, MongoDBHelper.getRiverVersion()); Status status = MongoDBRiverHelper.getRiverStatus(esClient, riverName.getName()); if (status == Status.IMPORT_FAILED || status == Status.INITIAL_IMPORT_FAILED || status == Status.SCRIPT_IMPORT_FAILED || status == Status.START_FAILED) { logger.error("Cannot start river {}. Current status is {}", riverName.getName(), status); return; } if (status == Status.STOPPED) { context.setStatus(Status.STOPPED); logger.info("River is currently disabled and will not be started", riverName.getName()); } else { context.setStatus(Status.START_PENDING); MongoDBRiverHelper.setRiverStatus(esClient, riverName.getName(), Status.RUNNING); logger.info("River startup pending", riverName.getName()); } statusThread = EsExecutors.daemonThreadFactory(settings.globalSettings(), "mongodb_river_status:" + definition.getIndexName()).newThread( new StatusChecker(this, definition, context)); statusThread.start(); }
Source:
<code>public RecyclerView.ViewHolder onCreateViewHolder(final ViewGroup parent, int viewType) { switch (viewType) { case VIEWTYPE_MESSAGE_HEADER: MessageHeaderParent.MessageHeaderHolder holder = new MessageHeaderParent.MessageHeaderHolder(LayoutInflater.from(parent.getContext()).inflate(R.layout.message_header, parent, false)); holder.streamTV.setText(privateHuddleText); holder.streamTV.setTextColor(Color.WHITE); return holder; case VIEWTYPE_MESSAGE: View messageView = LayoutInflater.from(parent.getContext()).inflate(R.layout.message_tile, parent, false); MessageHolder messageHolder = new MessageHolder(messageView); return messageHolder; case VIEWTYPE_FOOTER: footerView = LayoutInflater.from(parent.getContext()).inflate(R.layout.list_loading, parent, false); return new LoadingHolder(footerView); case VIEWTYPE_HEADER: headerView = LayoutInflater.from(parent.getContext()).inflate(R.layout.list_loading, parent, false); LoadingHolder headerLoadingHolder = new LoadingHolder(headerView); isHeaderShowing(false); <START> return headerLoadingHolder; <END> } return null; }</code><technical_language>is default case</technical_language>

Target:
public RecyclerView.ViewHolder onCreateViewHolder(final ViewGroup parent, int viewType) { switch (viewType) { case VIEWTYPE_MESSAGE_HEADER: MessageHeaderParent.MessageHeaderHolder holder = new MessageHeaderParent.MessageHeaderHolder(LayoutInflater.from(parent.getContext()).inflate(R.layout.message_header, parent, false)); holder.streamTextView.setText(privateHuddleText); holder.streamTextView.setTextColor(Color.WHITE); holder.setOnItemClickListener(onItemClickListener); return holder; case VIEWTYPE_MESSAGE: View messageView = LayoutInflater.from(parent.getContext()).inflate(R.layout.message_tile, parent, false); MessageHolder messageHolder = new MessageHolder(messageView); messageHolder.setItemClickListener(onItemClickListener); return messageHolder; case VIEWTYPE_FOOTER: footerView = LayoutInflater.from(parent.getContext()).inflate(R.layout.list_loading, parent, false); return new LoadingHolder(footerView); case VIEWTYPE_HEADER: headerView = LayoutInflater.from(parent.getContext()).inflate(R.layout.list_loading, parent, false); LoadingHolder headerLoadingHolder = new LoadingHolder(headerView); setHeaderShowing(false); return headerLoadingHolder; } return null; }
Source:
<code>public ContextMenuItem createItem() { return new ContextMenuItem(mTitleId, mTitle, mIcon, mColorRes, mSecondaryIcon, mSelected, mProgress, mLayout, mLoading, mIsCategory, mIsClickable, mSkipPaintingWithoutColor, <START> mPosition, mOrder, mDescription, mItemClickListener, mIntegerListener, mProgressListener, mItemDeleteAction, <END> mHideDivider, mHideCompoundButton, mMinHeight, mTag, mId); }</code><technical_language>mPosition</technical_language>

Target:
public ContextMenuItem createItem() { return new ContextMenuItem(mTitleId, mTitle, mIcon, mColorRes, mSecondaryIcon, mSelected, mProgress, mLayout, mLoading, mIsCategory, mIsClickable, mSkipPaintingWithoutColor, mOrder, mDescription, mItemClickListener, mIntegerListener, mProgressListener, mItemDeleteAction, mHideDivider, mHideCompoundButton, mMinHeight, mTag, mId); }