auphong2707/dl4se-code-review-dataset huggingface dataset:
Source:
<code><START> public Tag tagCreate(TagCreateRequest request) throws ApiException { <END> GitConnection gitConnection = getGitConnection(); try { TagCreateParams params = TagCreateParams.create(request.getName()) .withCommit(request.getCommit()) .withMessage(request.getMessage()) .withForce(request.isForce()); return gitConnection.tagCreate(params); } finally { gitConnection.close(); } }</code><technical_language>In other services name methods in another way. WorkspaceService#createMachine, WorkspaceService#createSnapshot. Mb rename this method createTag. WDYT</technical_language>

Target:
public Tag tagCreate(TagCreateRequest request) throws ApiException { GitConnection gitConnection = getGitConnection(); try { return gitConnection.tagCreate(TagCreateParams.create(request.getName()) .withCommit(request.getCommit()) .withMessage(request.getMessage()) .withForce(request.isForce())); } finally { gitConnection.close(); } }
Source:
<code>private void updateForwardedStatsFromNetd() { final TetherStatsParcel[] tetherStatsList; try { tetherStatsList = mNetd.tetherOffloadGetStats(); } catch (RemoteException | ServiceSpecificException e) { throw new IllegalStateException("problem parsing tethering stats: ", e); } for (TetherStatsParcel tetherStats : tetherStatsList) { try { final Integer ifIndex = tetherStats.ifIndex; final ForwardedStats curr = new ForwardedStats(tetherStats); final ForwardedStats base = mOffloadTetherStats.get(ifIndex); final ForwardedStats diff = (base != null) ? curr.subtract(base) : curr; mOffloadTetherStats.put(ifIndex, curr); <START> accumulateDiffToStatsProvider(ifIndex, <END> diff); } catch (ArrayIndexOutOfBoundsException e) { throw new IllegalStateException("invalid tethering stats " + e); } } }</code><technical_language>IIUC this is place calls accumulateDiffToStatsProvider. 1 null check 1 function call. If is inline here. strong opinion if this is needed for testing</technical_language>

Target:
private void updateForwardedStatsFromNetd() { final TetherStatsParcel[] tetherStatsList; try { tetherStatsList = mNetd.tetherOffloadGetStats(); } catch (RemoteException | ServiceSpecificException e) { throw new IllegalStateException("problem parsing tethering stats: ", e); } for (TetherStatsParcel tetherStats : tetherStatsList) { try { final Integer ifIndex = tetherStats.ifIndex; final ForwardedStats curr = new ForwardedStats(tetherStats); final ForwardedStats base = mOffloadTetherStats.get(ifIndex); final ForwardedStats diff = (base != null) ? curr.subtract(base) : curr; mOffloadTetherStats.put(ifIndex, curr); if (mStatsProvider != null) { mStatsProvider.accumulateDiff( buildNetworkStats(StatsType.STATS_PER_IFACE, ifIndex, diff), buildNetworkStats(StatsType.STATS_PER_UID, ifIndex, diff)); } } catch (ArrayIndexOutOfBoundsException e) { throw new IllegalStateException("invalid tethering stats " + e); } } }
Source:
<code><START> public String toString() { <END> return "TaskResultData{" + "id=" + id + ", serializedValue=" + Arrays.toString(serializedValue) + '}'; }</code><technical_language>need include metadata in toString, no</technical_language>

Target:
public String toString() { return "TaskResultData{" + "id=" + id + ", serializedValue=" + Arrays.toString(serializedValue) + ", metadata=" + metadata + '}'; }
Source:
<code>public static void setup() { raising.setFalseWhen(BooleanMixing.onPress(topLimitSwitch)); <START> lowering.setFalseWhen(BooleanMixing.onPress(bottomLimitSwitch)); <END> raising.toggleWhen(raisingInput); raising.setFalseWhen(loweringInput); lowering.toggleWhen(loweringInput); lowering.setFalseWhen(raisingInput); FloatMixing.pumpWhen(QuasarHelios.globalControl, Mixing.quadSelect(raising, lowering, 0.0f, -1.0f, 1.0f, 0.0f), winch); Cluck.publish(QuasarHelios.testPrefix + "Elevator Motor Speed", winch); Cluck.publish(QuasarHelios.testPrefix + "Elevator Limit Top", topLimitSwitch); Cluck.publish(QuasarHelios.testPrefix + "Elevator Limit Bottom", bottomLimitSwitch); }</code><technical_language>No. This means stops pressed - bug of pressing top</technical_language>

Target:
public static void setup() { raising.setFalseWhen(EventMixing.filterEvent(topLimitSwitch, true, Igneous.globalPeriodic)); lowering.setFalseWhen(EventMixing.filterEvent(bottomLimitSwitch, true, Igneous.globalPeriodic)); raising.toggleWhen(raisingInput); raising.setFalseWhen(loweringInput); lowering.toggleWhen(loweringInput); lowering.setFalseWhen(raisingInput); FloatMixing.pumpWhen(QuasarHelios.globalControl, Mixing.quadSelect(raising, lowering, 0.0f, -1.0f, 1.0f, 0.0f), winch); Cluck.publish(QuasarHelios.testPrefix + "Elevator Motor Speed", winch); Cluck.publish(QuasarHelios.testPrefix + "Elevator Limit Top", topLimitSwitch); Cluck.publish(QuasarHelios.testPrefix + "Elevator Limit Bottom", bottomLimitSwitch); }
Source:
<code><START> public List<User> call(ApiCaller ac, Deserializer parms) throws PerunException { <END> return ac.getSecurityTeamsManager().getDirectAdmins(ac.getSession(), ac.getSecurityTeamById(parms.readInt("securityTeam"))); }</code><technical_language>This is deprecated remove it. getAdmins parameter "onlyDirectAdmins" instead</technical_language>

Target:
public List<SecurityTeam> call(ApiCaller ac, Deserializer parms) throws PerunException { return ac.getSecurityTeamsManager().getSecurityTeams(ac.getSession()); }
Source:
<code>private CompletionStage<RestResponse> serveStaticResource(RestRequest request, String resource) throws ServerInternalException { NettyRestResponse.Builder responseBuilder = new NettyRestResponse.Builder(); try { URL staticResource = SplashResource.class.getClassLoader().getResource(resource); <START> return CompletableFuture.completedFuture(responseBuilder.entity(loadFile(staticResource)) <END> .contentType(getMediaType(resource)) .status(HttpResponseStatus.OK) .build()); } catch (Exception e) { throw new ServerInternalException(e); } }</code><technical_language>move response building a separate statement too</technical_language>

Target:
private CompletionStage<RestResponse> serveStaticResource(RestRequest request, String resource) throws ServerInternalException { NettyRestResponse.Builder responseBuilder = new NettyRestResponse.Builder(); try { URL staticResource = SplashResource.class.getClassLoader().getResource(resource); NettyRestResponse response = responseBuilder.entity(loadFile(staticResource)) .contentType(getMediaType(resource)) .status(HttpResponseStatus.OK) .build(); return CompletableFuture.completedFuture(response); } catch (Exception e) { throw new ServerInternalException(e); } }
Source:
<code>void write(final Collection<SinkRecord> records) throws SQLException { final Connection connection = cachedConnectionProvider.getConnection(); final Map<TableId, BufferedRecords> bufferByTable = new HashMap<>(); for (SinkRecord record : records) { final TableId tableId = destinationTable(record.topic()); BufferedRecords buffer = bufferByTable.get(tableId); if (buffer == null) { buffer = new BufferedRecords(config, tableId, dbDialect, dbStructure, connection); bufferByTable.put(tableId, buffer); } buffer.add(record); } for (TableId tableId : bufferByTable.keySet()) { <START> BufferedRecords buffer = bufferByTable.get(tableId); <END> log.debug("Flushing records in JDBC Writer for table ID: {}", tableId); buffer.flush(); buffer.close(); } connection.commit(); }</code><technical_language>Minor: If keys values, iterate entries: for (Map.Entry<TableId, BufferRecords> entry : bufferByTable.entrySet()) { TableId tableId = entry.getKey(); BufferedRecords buffer = entry.getValue(); Thoughts</technical_language>

Target:
void write(final Collection<SinkRecord> records) throws SQLException { final Connection connection = cachedConnectionProvider.getConnection(); final Map<TableId, BufferedRecords> bufferByTable = new HashMap<>(); for (SinkRecord record : records) { final TableId tableId = destinationTable(record.topic()); BufferedRecords buffer = bufferByTable.get(tableId); if (buffer == null) { buffer = new BufferedRecords(config, tableId, dbDialect, dbStructure, connection); bufferByTable.put(tableId, buffer); } buffer.add(record); } for (Map.Entry<TableId, BufferedRecords> entry : bufferByTable.entrySet()) { TableId tableId = entry.getKey(); BufferedRecords buffer = entry.getValue(); log.debug("Flushing records in JDBC Writer for table ID: {}", tableId); buffer.flush(); buffer.close(); } connection.commit(); }
Source:
<code>private AsyncCallback.ChildrenCallback constructChildRetrievalCallback() { if (shutdown || m_drainedSources.get() == m_numSources) { return null; } return new AsyncCallback.ChildrenCallback() { @Override public void processResult(final int rc, final String path, Object ctx, final List<String> children) { m_childUpdatingThread.submit(new Runnable() { @Override public void run() { try { if (shutdown) return; KeeperException.Code code = KeeperException.Code.get(rc); if (code == KeeperException.Code.NONODE) { <START> exportLog.info("Path not found generation drain most likely finished on other node: " + path); <END> } else if (code != KeeperException.Code.OK) { throw KeeperException.create(code); } final String split[] = path.split("/"); final int partition = Integer.valueOf(split[split.length - 1]); ImmutableList.Builder<Long> mailboxes = ImmutableList.builder(); for (String child : children) { if (child.equals(Long.toString(m_mbox.getHSId()))) continue; mailboxes.add(Long.valueOf(child)); } ImmutableList<Long> mailboxHsids = mailboxes.build(); for( ExportDataSource eds: m_dataSourcesByPartition.get( partition).values()) { eds.updateAckMailboxes(Pair.of(m_mbox, mailboxHsids)); } } catch (Throwable t) { VoltDB.crashLocalVoltDB("Error in export ack handling", true, t); } } }); } }; }</code><technical_language>This noisy. Is informative user this? If not, I debug</technical_language>

Target:
private AsyncCallback.ChildrenCallback constructChildRetrievalCallback() { if (shutdown || m_drainedSources.get() == m_numSources) { return null; } return new AsyncCallback.ChildrenCallback() { @Override public void processResult(final int rc, final String path, Object ctx, final List<String> children) { m_childUpdatingThread.submit(new Runnable() { @Override public void run() { try { if (shutdown) return; KeeperException.Code code = KeeperException.Code.get(rc); if (code == KeeperException.Code.NONODE) { if (exportLog.isDebugEnabled()) { exportLog.debug("Path not found generation drain most likely finished on other node: " + path); } } else if (code != KeeperException.Code.OK) { throw KeeperException.create(code); } final String split[] = path.split("/"); final int partition = Integer.valueOf(split[split.length - 1]); ImmutableList.Builder<Long> mailboxes = ImmutableList.builder(); for (String child : children) { if (child.equals(Long.toString(m_mbox.getHSId()))) continue; mailboxes.add(Long.valueOf(child)); } ImmutableList<Long> mailboxHsids = mailboxes.build(); for( ExportDataSource eds: m_dataSourcesByPartition.get( partition).values()) { eds.updateAckMailboxes(Pair.of(m_mbox, mailboxHsids)); } } catch (Throwable t) { VoltDB.crashLocalVoltDB("Error in export ack handling", true, t); } } }); } }; }
Source:
<code>public void setup(TestContext testContext) throws Exception { this.testContext = testContext; targetInstance = testContext.getTargetInstance(); keyCounter = targetInstance.getAtomicLong("keyCounter"); MapConfig mapConfig = targetInstance.getConfig().getMapConfig(basename); <START> maxMapSize = mapConfig.getMaxSizeConfig().getSize(); <END> MapStoreConfig mapStoreConfig = mapConfig.getMapStoreConfig(); mapStoreConfig.setWriteCoalescing(true); }</code><technical_language>relying fact that, basename = "MapEvictAndStore" . this map is configured in xml. public properties of test commonly set properties file, in case a mas size configured</technical_language>

Target:
public void setup(TestContext testContext) throws Exception { this.testContext = testContext; targetInstance = testContext.getTargetInstance(); keyCounter = targetInstance.getAtomicLong("MapEvictAndStoreTest.keyCounter"); MapConfig mapConfig = targetInstance.getConfig().getMapConfig(basename); mapConfig.setTimeToLiveSeconds(timeToLiveSeconds); mapConfig.getMaxSizeConfig() .setMaxSizePolicy(MaxSizeConfig.MaxSizePolicy.PER_NODE) .setSize(maxMapSize); MapStoreConfig mapStoreConfig = new MapStoreConfig(); mapStoreConfig.setEnabled(true) .setClassName(MAPSTORECLASS) .setWriteDelaySeconds(writeDelaySeconds); mapConfig.setMapStoreConfig(mapStoreConfig); mapStoreConfig.setWriteCoalescing(true); }
Source:
<code>public void testJMSMessagesFromOozieForNonFalconWF() throws Exception { sendMessages(TOPIC_NAME, WorkflowExecutionContext.Type.WORKFLOW_JOB, false ); final BrokerView adminView = broker.getAdminView(); <START> Assert.assertEquals(adminView.getTotalDequeueCount(), 0); <END> Assert.assertEquals(adminView.getTotalEnqueueCount(), 10); Assert.assertEquals(adminView.getTotalConsumerCount(), 2); Assert.assertEquals(adminView.getTotalMessageCount(), 0); Thread.sleep(100); Mockito.verify(jobEndService, Mockito.never()).notifyStart(Mockito.any(WorkflowExecutionContext.class)); Mockito.verify(jobEndService, Mockito.never()).notifySuccess(Mockito.any(WorkflowExecutionContext.class)); Mockito.verify(jobEndService, Mockito.never()).notifySuspend(Mockito.any(WorkflowExecutionContext.class)); Mockito.verify(jobEndService, Mockito.never()).notifyWait(Mockito.any(WorkflowExecutionContext.class)); Mockito.verify(jobEndService, Mockito.never()).notifyFailure(Mockito.any(WorkflowExecutionContext.class)); }</code><technical_language>remove consistent test fail later</technical_language>

Target:
public void testJMSMessagesFromOozieForNonFalconWF() throws Exception { sendMessages(TOPIC_NAME, WorkflowExecutionContext.Type.WORKFLOW_JOB, false ); final BrokerView adminView = broker.getAdminView(); Assert.assertEquals(adminView.getTotalConsumerCount(), 2); Thread.sleep(100); Mockito.verify(jobEndService, Mockito.never()).notifyStart(Mockito.any(WorkflowExecutionContext.class)); Mockito.verify(jobEndService, Mockito.never()).notifySuccess(Mockito.any(WorkflowExecutionContext.class)); Mockito.verify(jobEndService, Mockito.never()).notifySuspend(Mockito.any(WorkflowExecutionContext.class)); Mockito.verify(jobEndService, Mockito.never()).notifyWait(Mockito.any(WorkflowExecutionContext.class)); Mockito.verify(jobEndService, Mockito.never()).notifyFailure(Mockito.any(WorkflowExecutionContext.class)); }
Source:
<code>public void testReadPDBFile() throws Exception { assertEquals("pdb code not set!","5PTI",structure.getPDBCode()); Chain c = structure.getChain(0); assertEquals("did not find the expected 58 amino acids!",58,c.getAtomGroups(GroupType.AMINOACID).size()); assertEquals(0 , c.getAtomGroups(GroupType.HETATM).size()); Chain c2 = structure.getChain(1); assertEquals(64, c2.getAtomGroups(GroupType.HETATM).size()); assertEquals(0, c2.getAtomGroups(GroupType.NUCLEOTIDE).size()); <START> List<EntityInfo> compounds= structure.getEntityInformation(); <END> assertEquals(2, compounds.size()); EntityInfo mol = compounds.get(0); assertTrue(mol.getDescription().startsWith("TRYPSIN INHIBITOR")); }</code><technical_language>this structure.getEntityInfos() ? getter setter methods names classes, easier work Reflection</technical_language>

Target:
public void testReadPDBFile() throws Exception { assertEquals("pdb code not set!","5PTI",structure.getPDBCode()); Chain c = structure.getChain(0); assertEquals("did not find the expected 58 amino acids!",58,c.getAtomGroups(GroupType.AMINOACID).size()); assertEquals(0 , c.getAtomGroups(GroupType.HETATM).size()); Chain c2 = structure.getChain(1); assertEquals(64, c2.getAtomGroups(GroupType.HETATM).size()); assertEquals(0, c2.getAtomGroups(GroupType.NUCLEOTIDE).size()); List<EntityInfo> compounds= structure.getEntityInfos(); assertEquals(2, compounds.size()); EntityInfo mol = compounds.get(0); assertTrue(mol.getDescription().startsWith("TRYPSIN INHIBITOR")); }
Source:
<code>private PoolingHttpClientConnectionManager getConnectionManager(Builder builder) { <START> return new PoolingHttpClientConnectionManager(getSchemeRegistry(builder)); <END> }</code><technical_language>call shutdown this done</technical_language>

Target:
private PoolingHttpClientConnectionManager getConnectionManager(Builder builder) { final PoolingHttpClientConnectionManager cm = new PoolingHttpClientConnectionManager(getSchemeRegistry(builder)); cm.setMaxTotal(builder.connectionPoolSize); cm.setDefaultMaxPerRoute(cm.getMaxTotal()); return cm; }
Source:
<code>public final MesosSchedulerClient<Send, Receive> build() { return new MesosSchedulerClient<>( <START> mesosUri, <END> checkNotNull(applicationUserAgentEntry), checkNotNull(sendCodec), checkNotNull(receiveCodec), checkNotNull(subscribe), checkNotNull(streamProcessor) ); }</code><technical_language>Check this for null too</technical_language>

Target:
public final MesosSchedulerClient<Send, Receive> build() { return new MesosSchedulerClient<>( checkNotNull(mesosUri), checkNotNull(applicationUserAgentEntry), checkNotNull(sendCodec), checkNotNull(receiveCodec), checkNotNull(subscribe), checkNotNull(streamProcessor) ); }
Source:
<code>public IEventDeclaration getEventType(long streamId, long id) { <START> return getEvents(streamId).get((int) id); <END> }</code><technical_language>a int instead? If of "muh API"... check casting</technical_language>

Target:
public IEventDeclaration getEventType(long streamId, long id) { return getEventDeclarations(streamId).get((int) id); }
Source:
<code>private String[] getPathArray(String field) { if <START> (field.equals(fPathAsString)) <END> { return fPathAsArray; } StringBuilder sb = new StringBuilder(); List<String> list = new ArrayList<>(); for (int i = 1; i < field.length(); i++) { char charAt = field.charAt(i); if (charAt == SLASH) { list.add(sb.toString()); sb = new StringBuilder(); } else if (charAt == BACKSLASH) { if (i != field.length() - 1) { char nextChar = field.charAt(++i); if (nextChar == SLASH) { sb.append(SLASH); } else { sb.append(BACKSLASH); i--; } } else { sb.append(BACKSLASH); } } else { sb.append(charAt); } } list.add(sb.toString()); String[] array = new String[list.size()]; list.toArray(array); fPathAsString = field; fPathAsArray = array; return array; }</code><technical_language>This constantly recompute array EQUALS FIELD filter comparing subfields. of solution. store conversions node</technical_language>

Target:
private String[] getPathArray(String field) { if (field.equals(fPathAsString)) { return fPathAsArray; } StringBuilder sb = new StringBuilder(); List<String> list = new ArrayList<>(); for (int i = 1; i < field.length(); i++) { char charAt = field.charAt(i); if (charAt == SLASH) { list.add(sb.toString()); sb = new StringBuilder(); } else if (charAt == BACKSLASH && i < field.length() - 1 && field.charAt(i + 1) == SLASH) { sb.append(SLASH); i++; } else { sb.append(charAt); } } list.add(sb.toString()); String[] array = new String[list.size()]; list.toArray(array); fPathAsArray = array; fPathAsString = field; return array; }
Source:
<code>public ComplexMetricExtractor getExtractor() { <START> return new ComplexMetricExtractor() <END> { @Override public Class<?> extractedClass() { return Object.class; } @Override public Object extractValue(final InputRow inputRow, final String metricName) { return inputRow.getRaw(metricName); } }; }</code><technical_language>extractors in project identical this, please extract a static utility</technical_language>

Target:
public ComplexMetricExtractor getExtractor() { return RawInputValueExtractor.getInstance(); }
Source:
<code><START> public static ZipOutputStream pack(Path sourcePath, Path destPath) throws IOException { <END> if (Files.exists(destPath)) { Files.delete(destPath); } Files.createFile(destPath); ZipOutputStream zipOutputStream = new ZipOutputStream(Files.newOutputStream(destPath)); try { Files.walk(sourcePath) .filter(path -> !Files.isDirectory(path)) .forEach(path -> { ZipEntry zipEntry = new ZipEntry(sourcePath.relativize(path).toString()); try { zipOutputStream.putNextEntry(zipEntry); Files.copy(path, zipOutputStream); zipOutputStream.closeEntry(); } catch (IOException e) { System.err.println(e); } }); } catch (IOException e){ throw new IOException(); } return zipOutputStream; }</code><technical_language>a non-obvious edge-case is destPath.beginsWith(sourcePath), in, destPath is part of tree walked Files.walk. In case code deadlock error messge</technical_language>

Target:
public static void pack(Path sourcePath, Path destPath) { Compress.zip(sourcePath,destPath); }
Source:
<code>private ValidatingSchemaQuery(Timer timer, StressSettings settings, PartitionGenerator generator, SeedManager seedManager, ValidatingStatement[] statements, ConsistencyLevel cl, ConsistencyLevel serialCl, int clusteringComponents) { super(timer, settings, new DataSpec(generator, seedManager, new DistributionFixed(1), settings.insert.rowPopulationRatio.get(), 1)); this.statements = statements; this.cl = cl; argumentIndex = new int[statements[0].statement.getVariables().size()]; bindBuffer = new Object[argumentIndex.length]; int i = 0; for (ColumnDefinitions.Definition definition : statements[0].statement.getVariables()) argumentIndex[i++] = spec.partitionGenerator.indexOf(definition.getName()); com.datastax.driver.core.ConsistencyLevel tmpCl = JavaDriverClient.from(cl); <START> com.datastax.driver.core.ConsistencyLevel tmpSerialCl = JavaDriverClient.from(serialCl); <END> for (ValidatingStatement statement : statements) { if(statement.statement.getConsistencyLevel() == null) statement.statement.setConsistencyLevel(tmpCl); if(statement.statement.getSerialConsistencyLevel() == null) statement.statement.setSerialConsistencyLevel(tmpSerialCl); } this.clusteringComponents = clusteringComponents; }</code><technical_language>Please import types. need for tmp prefix</technical_language>

Target:
private ValidatingSchemaQuery(Timer timer, StressSettings settings, PartitionGenerator generator, SeedManager seedManager, ValidatingStatement[] statements, ConsistencyLevel cl, ConsistencyLevel serialCl, int clusteringComponents) { super(timer, settings, new DataSpec(generator, seedManager, new DistributionFixed(1), settings.insert.rowPopulationRatio.get(), 1)); this.statements = statements; this.cl = cl; argumentIndex = new int[statements[0].statement.getVariables().size()]; bindBuffer = new Object[argumentIndex.length]; int i = 0; for (ColumnDefinitions.Definition definition : statements[0].statement.getVariables()) argumentIndex[i++] = spec.partitionGenerator.indexOf(definition.getName()); com.datastax.driver.core.ConsistencyLevel consistencyLevel = JavaDriverClient.from(cl); com.datastax.driver.core.ConsistencyLevel serialConsistencyLevel = JavaDriverClient.from(serialCl); for (ValidatingStatement statement : statements) { if (statement.statement.getConsistencyLevel() == null) statement.statement.setConsistencyLevel(consistencyLevel); if (statement.statement.getSerialConsistencyLevel() == null) statement.statement.setSerialConsistencyLevel(serialConsistencyLevel); } this.clusteringComponents = clusteringComponents; }
Source:
<code>private static void validateFormSelectionMarkData(List<SelectionMark> expectedMarks, List<FormSelectionMark> actualMarks, int pageNumber) { for (int i = 0; i < actualMarks.size(); i++) { final SelectionMark expectedMark = expectedMarks.get(i); final FormSelectionMark actualMark = actualMarks.get(i); <START> assertTrue(expectedMark.getState().toString().equalsIgnoreCase(actualMark.getState().toString())); <END> validateBoundingBoxData(expectedMark.getBoundingBox(), actualMark.getBoundingBox()); assertNull(actualMark.getText()); assertEquals(pageNumber, actualMark.getPageNumber()); } }</code><technical_language>do need ignore case, casing</technical_language>

Target:
private static void validateFormSelectionMarkData(List<SelectionMark> expectedMarks, List<FormSelectionMark> actualMarks, int pageNumber) { for (int i = 0; i < actualMarks.size(); i++) { final SelectionMark expectedMark = expectedMarks.get(i); final FormSelectionMark actualMark = actualMarks.get(i); assertEquals(expectedMark.getState().toString(), actualMark.getState().toString()); validateBoundingBoxData(expectedMark.getBoundingBox(), actualMark.getBoundingBox()); assertNull(actualMark.getText()); assertEquals(pageNumber, actualMark.getPageNumber()); } }
Source:
<code>private void writeMapToJSON(String jsonMapName, LinkedHashMap<String, Object> data, MaxwellOutputConfig outputConfig) throws IOException { JsonGenerator generator = jsonGeneratorThreadLocal.get(); <START> if(outputConfig.encryptData && !outputConfig.encryptAll){ <END> ByteArrayOutputStream outputStream = new ByteArrayOutputStream(); JsonGenerator obj = jsonFactory.createGenerator(outputStream); obj.writeStartObject(); for (String key : data.keySet()) { Object value = data.get(key); if (value == null && !outputConfig.includesNulls) continue; if ( value instanceof List ) { List stringList = (List) value; obj.writeArrayFieldStart(key); for ( Object s : stringList ) { obj.writeObject(s); } obj.writeEndArray(); } else if (value instanceof RawJSONString) { obj.writeFieldName(key); obj.writeRawValue(((RawJSONString) value).json); } else { obj.writeObjectField(key, value); } } obj.writeEndObject(); obj.close(); outputStream.close(); generator.writeStringField(jsonMapName, RowEncrypt.encrypt(outputStream.toString(), outputConfig.encryption_key, outputConfig.secret_key)); } else { generator.writeObjectFieldStart(jsonMapName); for (String key : data.keySet()) { Object value = data.get(key); if (value == null && !outputConfig.includesNulls) continue; if (value instanceof List) { List stringList = (List) value; generator.writeArrayFieldStart(key); for (Object s : stringList) { generator.writeObject(s); } generator.writeEndArray(); } else if (value instanceof RawJSONString) { generator.writeFieldName(key); generator.writeRawValue(((RawJSONString) value).json); } else { generator.writeObjectField(key, value); } } generator.writeEndObject(); } }</code><technical_language>nit: space ()</technical_language>

Target:
private void writeMapToJSON(String jsonMapName, LinkedHashMap<String, Object> data, MaxwellOutputConfig outputConfig) throws IOException, NoSuchAlgorithmException { DataJsonGenerator dataGenerator = dataJsonGenerator(outputConfig); if(jsonMapName != "old") { dataGenerator.set(outputConfig.secret_key); } dataGenerator.begin(jsonMapName, byteArrayThreadLocal.get()); for (String key : data.keySet()) { Object value = data.get(key); if (value == null && !outputConfig.includesNulls) continue; if (value instanceof List) { List stringList = (List) value; dataGenerator.writeArrayFieldStart(key); for (Object s : stringList) { dataGenerator.writeObject(s); } dataGenerator.writeEndArray(); } else if (value instanceof RawJSONString) { dataGenerator.writeFieldName(key); dataGenerator.writeRawValue(((RawJSONString) value).json); } else { dataGenerator.writeObjectField(key, value); } } dataGenerator.end(); }
Source:
<code>public Object execute(ExecutionEvent event) throws ExecutionException { IStructuredSelection selection = getSelection(event); if (selection.isEmpty()) return null; RevCommit commit = (RevCommit) selection.getFirstElement(); Object input = getPage(event).getInputInternal().getSingleFile(); IWorkbenchPage workbenchPage = HandlerUtil .getActiveWorkbenchWindowChecked(event).getActivePage(); if (input instanceof IFile) { IFile file = (IFile) input; final RepositoryMapping mapping = RepositoryMapping .getMapping(file); if (mapping != null) { final String gitPath = mapping.getRepoRelativePath(file); final String commitPath = getRenamedPath(gitPath, commit); ITypedElement right = CompareUtils.getFileRevisionTypedElement( commitPath, commit, mapping.getRepository()); CompareEditorInput in = new GitCompareFileRevisionEditorInput( SaveableCompareEditorInput.createFileElement(file), right, null); CompareUtils.openInCompare(workbenchPage, in); } } else if (input instanceof File) { File file = (File) input; Repository repo = getRepository(event); <START> if (repo != null) { <END> final String leftCommitPath = getRepoRelativePath(repo, file); final String rightCommitPath = getRenamedPath(leftCommitPath, commit); final ITypedElement right = CompareUtils .getFileRevisionTypedElement(rightCommitPath, commit, repo); CompareEditorInput in = new GitCompareFileRevisionEditorInput( new LocalNonWorkspaceTypedElement(repo, new Path(file.getAbsolutePath())), right, null); CompareUtils.openInCompare(workbenchPage, in); } } return null; }</code><technical_language>check for null-ness return early in case, this reduces nesting level</technical_language>

Target:
public Object execute(ExecutionEvent event) throws ExecutionException { IStructuredSelection selection = getSelection(event); if (selection.isEmpty()) return null; RevCommit commit = (RevCommit) selection.getFirstElement(); Object input = getPage(event).getInputInternal().getSingleFile(); IWorkbenchPage workbenchPage = HandlerUtil .getActiveWorkbenchWindowChecked(event).getActivePage(); if (input instanceof IFile) { IFile file = (IFile) input; final RepositoryMapping mapping = RepositoryMapping .getMapping(file); if (mapping != null) { final String gitPath = mapping.getRepoRelativePath(file); final String commitPath = getRenamedPath(gitPath, commit); ITypedElement right = CompareUtils.getFileRevisionTypedElement( commitPath, commit, mapping.getRepository()); CompareEditorInput in = new GitCompareFileRevisionEditorInput( SaveableCompareEditorInput.createFileElement(file), right, null); CompareUtils.openInCompare(workbenchPage, in); } } else if (input instanceof File) { File file = (File) input; Repository repo = getRepository(event); if (repo != null) { final String leftCommitPath = getRepoRelativePath(repo, file); final String rightCommitPath = getRenamedPath(leftCommitPath, commit); ITypedElement right = CompareUtils.getFileRevisionTypedElement( rightCommitPath, commit, repo); CompareEditorInput in = new GitCompareFileRevisionEditorInput( new LocalNonWorkspaceTypedElement(repo, new Path(file.getAbsolutePath())), right, null); CompareUtils.openInCompare(workbenchPage, in); } } return null; }
Source:
<code>protected void reportInternal(Span span) { Integer maxSpanDelay = dropSpansDelayedMinutes.get(); if (maxSpanDelay != null && <START> span.getStartMillis() + span.getDuration() < Clock.now() - maxSpanDelay * 60 * 1000) { <END> this.reject(span, "span is older than acceptable delay of " + maxSpanDelay + " minutes"); return; } validateSpan(span, validationConfig); final String strSpan = serializer.apply(span); getTask().add(strSpan); getReceivedCounter().inc(); if (validItemsLogger != null) validItemsLogger.info(strSpan); }</code><technical_language>TimeUnit.MINUTES.toMillis(maxSpanDelay)</technical_language>

Target:
protected void reportInternal(Span span) { Integer maxSpanDelay = dropSpansDelayedMinutes.get(); if (maxSpanDelay != null && span.getStartMillis() + span.getDuration() < Clock.now() - TimeUnit.MINUTES.toMillis(maxSpanDelay)) { this.reject(span, "span is older than acceptable delay of " + maxSpanDelay + " minutes"); return; } validateSpan(span, validationConfig); final String strSpan = serializer.apply(span); getTask().add(strSpan); getReceivedCounter().inc(); if (validItemsLogger != null) validItemsLogger.info(strSpan); }
Source:
<code><START> public com.alive_n_clickin.waft.application.IManager getManager() { <END> return this.manager; }</code><technical_language>Full name</technical_language>

Target:
public IManager getManager() { return this.manager; }
Source:
<code>protected boolean isAsync() { if (QueryHelper.hasMatrixParam(getUriInfo(), ASYNC_CONSTRAINT)) { <START> String value = QueryHelper.getMatrixConstraint(getUriInfo(), ASYNC_CONSTRAINT); <END> if (value.equalsIgnoreCase(TRUE) || value.isEmpty()) { return true; } else if (value.equalsIgnoreCase(FALSE)) { return false; } else { throw new UrlParamException(this, null, "Illegal value '" + value + "' for matrix param: 'async'. Acceptable values are 'true' or 'false'"); } } return false; }</code><technical_language>fetch of ASYNC_CONSTRAINT compare != NULL</technical_language>

Target:
protected boolean isAsync() { String value = QueryHelper.getMatrixConstraint(getUriInfo(), ASYNC_CONSTRAINT); if (value == null) { return false; } else { if (value.equalsIgnoreCase(TRUE) || value.isEmpty()) { return true; } else if (value.equalsIgnoreCase(FALSE)) { return false; } else { throw new UrlParamException(this, null, "Illegal value '" + value + "' for matrix param: 'async'. Acceptable values are 'true' or 'false'"); } } }
Source:
<code>List<UsagePriceOverride> getUsagePriceOverrides(PlanPhase curPhase, CatalogOverridePhaseDefinitionModelDao overriddenPhase, final InternalTenantContext context) { final List<UsagePriceOverride> usagePriceOverrides = new ArrayList<UsagePriceOverride>(); for(int i = 0; i < curPhase.getUsages().length; i++){ final Usage curUsage = curPhase.getUsages()[i]; final List<CatalogOverrideUsageDefinitionModelDao> usageDefs = overrideDao.getOverriddenPhaseUsages(overriddenPhase.getRecordId(), context); final CatalogOverrideUsageDefinitionModelDao overriddenUsage = Iterables.tryFind(usageDefs, new Predicate<CatalogOverrideUsageDefinitionModelDao>() { @Override public boolean apply(final CatalogOverrideUsageDefinitionModelDao input) { return input.getParentUsageName().equals(curUsage.getName()); } }).orNull(); if(overriddenUsage != null) { List<TierPriceOverride> tierPriceOverrides = getTierPriceOverrides(curUsage, overriddenUsage, context); usagePriceOverrides.add(new DefaultUsagePriceOverride(overriddenUsage.getParentUsageName(), curUsage.getUsageType(),tierPriceOverrides)); } else <START> usagePriceOverrides.add(null); <END> } return usagePriceOverrides; }</code><technical_language>Adding null elements in list is a bit weird. do need that</technical_language>

Target:
List<UsagePriceOverride> getUsagePriceOverrides(PlanPhase curPhase, CatalogOverridePhaseDefinitionModelDao overriddenPhase, final InternalTenantContext context) { final List<UsagePriceOverride> usagePriceOverrides = new ArrayList<UsagePriceOverride>(); final List<CatalogOverrideUsageDefinitionModelDao> usageDefs = overrideDao.getOverriddenPhaseUsages(overriddenPhase.getRecordId(), context); for(int i = 0; i < curPhase.getUsages().length; i++){ final Usage curUsage = curPhase.getUsages()[i]; final CatalogOverrideUsageDefinitionModelDao overriddenUsage = Iterables.tryFind(usageDefs, new Predicate<CatalogOverrideUsageDefinitionModelDao>() { @Override public boolean apply(final CatalogOverrideUsageDefinitionModelDao input) { return input.getParentUsageName().equals(curUsage.getName()); } }).orNull(); if(overriddenUsage != null) { List<TierPriceOverride> tierPriceOverrides = getTierPriceOverrides(curUsage, overriddenUsage, context); usagePriceOverrides.add(new DefaultUsagePriceOverride(overriddenUsage.getParentUsageName(), curUsage.getUsageType(),tierPriceOverrides)); } } return usagePriceOverrides; }
Source:
<code>private GHRepository getRepository(String repositoryId) { GHRepository repository; try { repository = github.getRepository(repositoryId); } catch (IOException e) { <START> LOG.info(gitUsername + ": Cannot retrieve the workflow from GitHub", e); <END> throw new CustomWebApplicationException("Could not reach GitHub, please try again later", HttpStatus.SC_SERVICE_UNAVAILABLE); } return repository; }</code><technical_language>Suggest LOG.error</technical_language>

Target:
private GHRepository getRepository(String repositoryId) { GHRepository repository; try { repository = github.getRepository(repositoryId); } catch (IOException e) { LOG.error(gitUsername + ": Cannot retrieve the workflow from GitHub", e); throw new CustomWebApplicationException("Could not reach GitHub, please try again later", HttpStatus.SC_SERVICE_UNAVAILABLE); } return repository; }
Source:
<code>public static SSLContext getTrustContext(TrustManager trustManager) { try { if (contextAlreadyCreated.getAndSet(true)) { return sslContext; } TrustManager[] trustManagers = new TrustManager[] { trustManager }; sslContext = SSLContext.getInstance("SSL"); sslContext.init(null, trustManagers, null); }catch(NoSuchAlgorithmException e) { throw new RemoteException("Unable to find suitable algorithm while attempting to communicate with remote server.", e); } catch(KeyManagementException e) { throw new RemoteException("An error occurred initializing SSL context due to a problem with key management.", e); } finally { <START> return sslContext; <END> } }</code><technical_language>I dont this a return here.. This run throw wont it</technical_language>

Target:
public static SSLContext getTrustContext(TrustManager trustManager) throws RemoteException { try { if (contextAlreadyCreated.getAndSet(true)) { return sslContext; } TrustManager[] trustManagers = new TrustManager[] { trustManager }; sslContext = SSLContext.getInstance("TLS"); sslContext.init(null, trustManagers, null); }catch(NoSuchAlgorithmException e) { throw new RemoteException("Unable to find suitable algorithm while attempting to communicate with remote server.", e); } catch(KeyManagementException e) { throw new RemoteException("An error occurred initializing SSL context due to a problem with key management.", e); } return sslContext; }
Source:
<code>public void testProcessWithReadonlyVariable() throws Exception { KieBase kbase = createKnowledgeBase("variable-tags/approval-with-readonly-variable-tags.bpmn2"); KieSession ksession = createKnowledgeSession(kbase); TestWorkItemHandler workItemHandler = new TestWorkItemHandler(); ksession.getWorkItemManager().registerWorkItemHandler("Human Task", workItemHandler); Map<String, Object> parameters = new HashMap<>(); parameters.put("approver", "john"); ProcessInstance processInstance = ksession.startProcess("approvals", parameters); assertTrue(processInstance.getState() == ProcessInstance.STATE_ACTIVE); WorkItem workItem = workItemHandler.getWorkItem(); assertNotNull(workItem); assertThatExceptionOfType(VariableViolationException.class).isThrownBy(() -> ksession.getWorkItemManager().completeWorkItem(workItem.getId(), Collections.singletonMap("ActorId", "john"))); ksession.abortProcessInstance(processInstance.getId()); assertProcessInstanceFinished(processInstance, ksession); <START> ksession.dispose(); <END> }</code><technical_language>needed</technical_language>

Target:
public void testProcessWithReadonlyVariable() throws Exception { ksession = createSessionAndRegisterWorkItemHandler("variable-tags/approval-with-readonly-variable-tags.bpmn2"); Map<String, Object> parameters = new HashMap<>(); parameters.put("approver", "john"); ProcessInstance processInstance = ksession.startProcess("approvals", parameters); assertTrue(processInstance.getState() == ProcessInstance.STATE_ACTIVE); WorkItem workItem = workItemHandler.getWorkItem(); assertNotNull(workItem); assertThatExceptionOfType(VariableViolationException.class).isThrownBy(() -> ksession.getWorkItemManager().completeWorkItem(workItem.getId(), Collections.singletonMap("ActorId", "john"))); ksession.abortProcessInstance(processInstance.getId()); assertProcessInstanceFinished(processInstance, ksession); }
Source:
<code><START> static Transition getTransitionByName(@Nonnull Iterable<Transition> transitions, String name) { <END> for (Transition transition : transitions) { if (transition.getName().equals(name)) { return transition; } } return null; }</code><technical_language>CheckForNull please</technical_language>

Target:
static Transition getTransitionByName(@Nonnull Iterable<Transition> transitions, String name) { for (Transition transition : transitions) { if (transition.getName().equalsIgnoreCase(name)) { return transition; } } return null; }
Source:
<code>public static Pair<BigDecimal, String> getNumberAndUnitFromString(String attributeValue) { String numberString = null; String unit = null; if (attributeValue != null) { Matcher numberMatcher = numberPattern.matcher(attributeValue); Matcher letterMatcher = letterPattern.matcher(attributeValue); numberMatcher.find(); letterMatcher.find(); try { numberString = attributeValue.substring(numberMatcher.start(), numberMatcher.end()); } catch (IllegalStateException ex) { numberString = null; } try { unit = attributeValue.substring(letterMatcher.start(), letterMatcher.end()); } catch (IllegalStateException ex) { unit = "G"; } } BigDecimal number; if(numberString != null) number = new BigDecimal(numberString.replace(',', '.')); <START> else number = new BigDecimal("0"); <END> return new Pair<>(number, unit); }</code><technical_language>I change this logic. If set default values String numberString = "0"; String unit = "G"; change values if attribute is parse-able log debug IllegalState exceptions. need test null values get correct combination. do think? reason is, state number=0, unit=null allowed here</technical_language>

Target:
public static Pair<BigDecimal, String> getNumberAndUnitFromString(String attributeValue) { String numberString = "0"; String unit = "G"; if (attributeValue != null) { Matcher numberMatcher = numberPattern.matcher(attributeValue); Matcher letterMatcher = letterPattern.matcher(attributeValue); numberMatcher.find(); letterMatcher.find(); try { numberString = attributeValue.substring(numberMatcher.start(), numberMatcher.end()); } catch (IllegalStateException ex) { log.debug("No number could be parsed from given string.", ex); } try { unit = attributeValue.substring(letterMatcher.start(), letterMatcher.end()); } catch (IllegalStateException ex) { log.debug("No unit could be parsed from given string.", ex); } } BigDecimal number = new BigDecimal(numberString.replace(',', '.')); return new Pair<>(number, unit); }
Source:
<code>private boolean userEnteredCommmitMessage() { if (commitMessageComponent.getRepository() == null) return false; <START> String message = commitMessageComponent.getCommitMessage().replace(UIText.StagingView_headCommitChanged, ""); END> if (message == null || message.trim().length() == 0) return false; if(commitMessageComponent.getCreateChangeId() && message.trim().equals("Change-Id: I" + ObjectId.zeroId().name())) return false; return true; }</code><technical_language>delimiters added in line 1100 removed</technical_language>

Target:
private boolean userEnteredCommmitMessage() { if (commitMessageComponent.getRepository() == null) return false; String message = commitMessageComponent.getCommitMessage().replace( UIText.StagingView_headCommitChanged, ""); if (message == null || message.trim().length() == 0) return false; String chIdLine = "Change-Id: I" + ObjectId.zeroId().name(); if (currentRepository.getConfig().getBoolean( ConfigConstants.CONFIG_GERRIT_SECTION, ConfigConstants.CONFIG_KEY_CREATECHANGEID, false) && commitMessageComponent.getCreateChangeId()) { if (message.trim().equals(chIdLine)) return false; message = message.replace(chIdLine, ""); } if (org.eclipse.egit.ui.Activator.getDefault().getPreferenceStore() .getBoolean(UIPreferences.COMMIT_DIALOG_SIGNED_OFF_BY) && commitMessageComponent.isSignedOff() && message.trim().equals( Constants.SIGNED_OFF_BY_TAG + commitMessageComponent.getCommitter())) return false; return true; }
Source:
<code>private MergeQuantileDigestFunction() { <START> super(NAME, QDIGEST, StatisticalDigestStateFactory.createQuantileDigestFactory()); <END> }</code><technical_language>nits: static import</technical_language>

Target:
private MergeQuantileDigestFunction() { super(NAME, QDIGEST, createQuantileDigestFactory(), false); }
Source:
<code>public String prepareBulkLoad(final byte[] family, final String srcPath, boolean copyFile) throws IOException { Path p = new Path(srcPath); Path stageP = new Path(stagingDir, new Path(Bytes.toString(family), p.getName())); if (p.equals(stageP)) { LOG.debug(p.getName() + " is already available in staging directory. Skipping copy or rename."); return stageP.toString(); } if (srcFs == null) { srcFs = FileSystem.newInstance(p.toUri(), conf); } if(!isFile(p)) { throw new IOException("Path does not reference a file: " + p); } <START> try { <END> if (!FSUtils.isSameHdfs(conf, srcFs, fs)) { LOG.debug("Bulk-load file " + srcPath + " is on different filesystem than " + "the destination filesystem. Copying file over to destination staging dir."); FileUtil.copy(srcFs, p, fs, stageP, false, conf); } else if (copyFile) { LOG.debug("Bulk-load file " + srcPath + " is copied to destination staging dir."); FileUtil.copy(srcFs, p, fs, stageP, false, conf); } else { LOG.debug("Moving " + p + " to " + stageP); FileStatus origFileStatus = fs.getFileStatus(p); origPermissions.put(srcPath, origFileStatus.getPermission()); if(!fs.rename(p, stageP)) { throw new IOException("Failed to move HFile: " + p + " to " + stageP); } } }catch (Throwable t){ throw new IOException("Failed to prepare bulk load for path " + srcPath, t); } fs.setPermission(stageP, PERM_ALL_ACCESS); return stageP.toString(); }</code><technical_language>throw IOE here, wont get retried client end? check code in detail</technical_language>

Target:
public String prepareBulkLoad(final byte[] family, final String srcPath, boolean copyFile) throws IOException { Path p = new Path(srcPath); Path stageP = new Path(stagingDir, new Path(Bytes.toString(family), p.getName())); if (p.equals(stageP)) { LOG.debug(p.getName() + " is already available in staging directory. Skipping copy or rename."); return stageP.toString(); } if (srcFs == null) { srcFs = FileSystem.newInstance(p.toUri(), conf); } if(!isFile(p)) { throw new IOException("Path does not reference a file: " + p); } if (!FSUtils.isSameHdfs(conf, srcFs, fs)) { LOG.debug("Bulk-load file " + srcPath + " is on different filesystem than " + "the destination filesystem. Copying file over to destination staging dir."); FileUtil.copy(srcFs, p, fs, stageP, false, conf); } else if (copyFile) { LOG.debug("Bulk-load file " + srcPath + " is copied to destination staging dir."); FileUtil.copy(srcFs, p, fs, stageP, false, conf); } else { LOG.debug("Moving " + p + " to " + stageP); FileStatus origFileStatus = fs.getFileStatus(p); origPermissions.put(srcPath, origFileStatus.getPermission()); if(!fs.rename(p, stageP)) { throw new IOException("Failed to move HFile: " + p + " to " + stageP); } } fs.setPermission(stageP, PERM_ALL_ACCESS); return stageP.toString(); }
Source:
<code><START> private File getExistingItunesDirectory(File[] files) { <END> File existingDir = null; for (File file : files) { if (file.isDirectory() && file.getName().startsWith("itunes") && file.getName().matches("itunes\\d{8}")) { existingDir = file; } } return existingDir; }</code><technical_language>If legitimately expecting this return file return Optional<File> instead of null</technical_language>

Target:
private Optional<File> getExistingItunesDirectory(File[] files) { File existingDir = null; for (File file : files) { if (file.isDirectory() && file.getName().startsWith("itunes") && file.getName().matches("itunes\\d{8}")) { existingDir = file; } } return Optional.ofNullable(existingDir); }
Source:
<code>private void matchNestedFile(Path file, List<Path> texFiles, List<Path> referencedFiles, String line) { Matcher includeMatch = Pattern.compile(INCLUDE_REGEX).matcher(line); while (includeMatch.find()) { String include = includeMatch.group("file"); if (!include.endsWith(".tex")) { <START> include += ".tex"; <END> } Path folder = file.getParent(); Path inputFile = (folder != null) ? folder.resolve(include) : Paths.get(include); if (!texFiles.contains(inputFile)) { referencedFiles.add(inputFile); } } }</code><technical_language>please move ".tex" a constant "file" easier identify modify</technical_language>

Target:
private void matchNestedFile(Path file, List<Path> texFiles, List<Path> referencedFiles, String line) { Matcher includeMatch = INCLUDE_PATTERN.matcher(line); StringBuilder include; while (includeMatch.find()) { include = new StringBuilder(includeMatch.group(INCLUDE_GROUP)); if (!include.toString().endsWith(TEX_EXT)) { include.append(TEX_EXT); } Path folder = file.getParent(); Path inputFile = (folder == null) ? Paths.get(include.toString()) : folder.resolve(include.toString()); if (!texFiles.contains(inputFile)) { referencedFiles.add(inputFile); } } }
Source:
<code><START> public Map<String, String[]> getFullParameters() { <END> if (fullParameters == null) { return Collections.emptyMap(); } return fullParameters; }</code><technical_language>API break here, in terms returned type semantics. However, right do, name confusing. add new getters, getRequestParameters, getFilteringParameters deprecate method instead</technical_language>

Target:
public Map<String, String> getFullParameters() { return getFilteringParameters(); }