auphong2707/dl4se-code-review-dataset huggingface dataset:
Source:
<code>public static void listenBucketNotification_test1() throws Exception { String methodName = "listenBucketNotification(ListenBucketNotificationArgs args)"; if (!mintEnv) { System.out.println("Test: " + methodName); } long startTime = System.currentTimeMillis(); String file = createFile1Kb(); String bucketName = getRandomName(); CloseableIterator<Result<NotificationRecords>> ci = null; try { client.makeBucket(MakeBucketArgs.builder().bucket(bucketName).region(region).build()); String[] events = {"s3:ObjectCreated:*", "s3:ObjectAccessed:*"}; ci = client.listenBucketNotification( ListenBucketNotificationArgs.builder() .bucket(bucketName) .prefix("prefix") .suffix("suffix") .events(events) .build()); client.putObject(bucketName, "prefix-random-suffix", file, new PutObjectOptions(1 * KB, -1)); while (ci.hasNext()) { NotificationRecords records = ci.next().get(); if (records.events().size() == 0) { continue; } boolean found = false; for (Event event : records.events()) { if (event.objectName().equals("prefix-random-suffix")) { found = true; break; } } if (found) { break; } } <START> mintSuccessLog(methodName, null, startTime); <END> } catch (Exception e) { handleException(methodName, null, startTime, e); } finally { if (ci != null) { ci.close(); } Files.delete(Paths.get(file)); client.removeObject( RemoveObjectArgs.builder().bucket(bucketName).object("prefix-random-suffix").build()); client.removeBucket(RemoveBucketArgs.builder().bucket(bucketName).build()); } }</code><technical_language>prefix, suffix events logged args</technical_language>

Target:
public static void listenBucketNotification_test1() throws Exception { String methodName = "listenBucketNotification(ListenBucketNotificationArgs args)"; if (!mintEnv) { System.out.println("Test: " + methodName); } long startTime = System.currentTimeMillis(); String file = createFile1Kb(); String bucketName = getRandomName(); CloseableIterator<Result<NotificationRecords>> ci = null; String mintArgs = "prefix=prefix, suffix=suffix, events={\"s3:ObjectCreated:*\", \"s3:ObjectAccessed:*\"}"; try { client.makeBucket(MakeBucketArgs.builder().bucket(bucketName).region(region).build()); String[] events = {"s3:ObjectCreated:*", "s3:ObjectAccessed:*"}; ci = client.listenBucketNotification( ListenBucketNotificationArgs.builder() .bucket(bucketName) .prefix("prefix") .suffix("suffix") .events(events) .build()); client.putObject(bucketName, "prefix-random-suffix", file, new PutObjectOptions(1 * KB, -1)); while (ci.hasNext()) { NotificationRecords records = ci.next().get(); if (records.events().size() == 0) { continue; } boolean found = false; for (Event event : records.events()) { if (event.objectName().equals("prefix-random-suffix")) { found = true; break; } } if (found) { break; } } mintSuccessLog(methodName, mintArgs, startTime); } catch (Exception e) { handleException(methodName, mintArgs, startTime, e); } finally { if (ci != null) { ci.close(); } Files.delete(Paths.get(file)); client.removeObject( RemoveObjectArgs.builder().bucket(bucketName).object("prefix-random-suffix").build()); client.removeBucket(RemoveBucketArgs.builder().bucket(bucketName).build()); } }
Source:
<code>protected void fillRtTestInfos() { <START> rtTestInfos.add(TEST001); <END> }</code><technical_language>Remove</technical_language>

Target:
protected void fillRtTestInfos()
Source:
<code>public void expire(String version) { String barrierStatePath = keyBuilder.getBarrierStatePath(version); <START> State barrierState = State.valueOf(zkUtils.getZkClient().readData(barrierStatePath)); <END> if (Objects.equals(barrierState, State.NEW)) { LOG.info(String.format("Expiring the barrier version: %s. Marking the barrier state: %s as %s.", version, barrierStatePath, State.TIMED_OUT)); zkUtils.writeData(keyBuilder.getBarrierStatePath(version), State.TIMED_OUT.getValue()); } else { LOG.debug(String.format("Barrier version: %s is at: %s state. Not marking barrier as %s.", version, barrierState, State.TIMED_OUT)); } }</code><technical_language>compatibility concerns? eg: data written serde format is read string serializer? issue if do a write do a read. Either-ways, good understand behavior wrt. rolling upgrades</technical_language>

Target:
public void expire(String version) { String barrierStatePath = keyBuilder.getBarrierStatePath(version); State barrierState = State.valueOf(zkUtils.getZkClient().readData(barrierStatePath)); if (Objects.equals(barrierState, State.NEW)) { LOG.info(String.format("Expiring the barrier version: %s. Marking the barrier state: %s as %s.", version, barrierStatePath, State.TIMED_OUT)); zkUtils.writeData(keyBuilder.getBarrierStatePath(version), State.TIMED_OUT.toString()); } else { LOG.debug(String.format("Barrier version: %s is at: %s state. Not marking barrier as %s.", version, barrierState, State.TIMED_OUT)); } }
Source:
<code>private void matchSinglelineComment(boolean includeNewline) { int c = getChar(); <START> while (c != '\n' && c != EOFCHAR && (includeNewline || (c != '\r'))) { <END> c = getChar(); } if (c == EOFCHAR || !includeNewline) { ungetChar(c); } }</code><technical_language>This logic is correct stop '\r' in "// blah \r blah \r\n"</technical_language>

Target:
private void matchSinglelineComment(boolean includeNewline) { int c = getChar(); while (c != '\n' && c != EOFCHAR) { int next = getChar(); if (c == '\r' && next == '\n' && !includeNewline) { ungetChar(next); break; } c = next; } if (c == EOFCHAR || !includeNewline) { ungetChar(c); } }
Source:
<code>public TaskWrapper getNextTask() { TaskWrapper nextScheduledTask = scheduleQueue.peekFirst(); TaskWrapper nextExecuteTask = executeQueue.peek(); if (nextExecuteTask != null) { if (nextScheduledTask != null) { long scheduleDelay; long executeDelay; ClockWrapper.stopForcingUpdate(); try { scheduleDelay = nextScheduledTask.getDelay(TimeUnit.MILLISECONDS); executeDelay = nextExecuteTask.getDelay(TimeUnit.MILLISECONDS); } finally { ClockWrapper.resumeForcingUpdate(); } if (scheduleDelay < executeDelay) { return nextScheduledTask; } else { <START> return nextExecuteTask; <END> } } else { return nextExecuteTask; } } else if (nextScheduledTask != null) { return nextScheduledTask; } else { return null; } }</code><technical_language>favor execute tasks? a problem interesting</technical_language>

Target:
public TaskWrapper getNextTask() { TaskWrapper scheduledTask = scheduleQueue.peekFirst(); TaskWrapper executeTask = executeQueue.peek(); if (executeTask != null) { if (scheduledTask != null) { if (scheduledTask.getDelayInMs(0) < executeTask.getDelayInMs(0)) { return scheduledTask; } else { return executeTask; } } else { return executeTask; } } else { return scheduledTask; } }
Source:
<code><START> public final Mono<TransactionalBatchResponse> executeAsync() { <END> List<ItemBatchOperation<?>> operations = BridgeInternal.getOperationsFromTransactionalBatch(this.transactionalBatch); checkArgument(operations.size() > 0, "Number of operations should be more than 0."); final SinglePartitionKeyServerBatchRequest request = SinglePartitionKeyServerBatchRequest.createBatchRequest( BridgeInternal.getPartitionKeyFromTransactionalBatch(this.transactionalBatch), operations); request.setAtomicBatch(true); request.setShouldContinueOnError(false); return CosmosBridgeInternal.getAsyncDocumentClient(container.getDatabase()) .executeBatchRequest(BridgeInternal.getLink(container), request, BridgeInternal.toRequestOptions(options), false); }</code><technical_language>Please user call executeAsync multiple time if 429 other transient failure is returned</technical_language>

Target:
public final Mono<TransactionalBatchResponse> executeAsync() { List<CosmosItemOperation> operations = this.transactionalBatch.getOperations(); checkArgument(operations.size() > 0, "Number of operations should be more than 0."); final SinglePartitionKeyServerBatchRequest request = SinglePartitionKeyServerBatchRequest.createBatchRequest( this.transactionalBatch.getPartitionKeyValue(), operations); request.setAtomicBatch(true); request.setShouldContinueOnError(false); return CosmosBridgeInternal.getAsyncDocumentClient(container.getDatabase()) .executeBatchRequest(BridgeInternal.getLink(container), request, BridgeInternal.toRequestOptions(options), false); }
Source:
<code>public void testNoEndCallToneInSilence() { when(mAudioManagerAdapter.isVolumeOverZero()).thenReturn(false); InCallTonePlayer player = mFactory.createPlayer(InCallTonePlayer.TONE_CALL_ENDED); player.startTone(); verify(mCallAudioManager, never()).setIsTonePlaying(eq(true)); verify(mMediaPlayerFactory, never()).get(anyInt(), any()); <START> player.cleanup(); <END> }</code><technical_language>put in teardown</technical_language>

Target:
public void testNoEndCallToneInSilence() { when(mAudioManagerAdapter.isVolumeOverZero()).thenReturn(false); InCallTonePlayer player = mFactory.createPlayer(InCallTonePlayer.TONE_CALL_ENDED); assertFalse(player.startTone()); verify(mCallAudioManager, never()).setIsTonePlaying(eq(true)); verify(mMediaPlayerFactory, never()).get(anyInt(), any()); player.cleanup(); }
Source:
<code>private void closeDruidStatement(final DruidStatement statement) { final DruidStatement druidStatement2; synchronized (connections) { final DruidConnection connection = getDruidConnection(statement.getConnectionId()); druidStatement2 = connection.statements().remove(statement.getStatementId()); } <START> if (statement == druidStatement2) { <END> log.debug("Connection[%s] closed statement[%s].", statement.getConnectionId(), statement.getStatementId()); statement.close(); } }</code><technical_language>in case equal</technical_language>

Target:
private void closeDruidStatement(final DruidStatement statement) { synchronized (connections) { final DruidConnection connection = getDruidConnection(statement.getConnectionId()); if (connection.statements().get(statement.getStatementId()) == statement) { connection.statements().remove(statement.getStatementId()); } else { throw new ISE("Statement[%s] not open", statement.getStatementId()); } } log.debug("Connection[%s] closed statement[%s].", statement.getConnectionId(), statement.getStatementId()); statement.close(); }
Source:
<code>public void execute(Database database) throws CustomChangeException { JdbcConnection connection = (JdbcConnection) database.getConnection(); Statement stmt = null; PreparedStatement pStmt = null; try { stmt = connection.createStatement(); ResultSet rs = stmt <START> .executeQuery("SELECT @i:=0"); <END> if (rs.next()) { pStmt = connection .prepareStatement("UPDATE cohort_member SET cohort_member_id = @i:=@i+1"); pStmt.addBatch(); pStmt.executeBatch(); } } catch (DatabaseException | SQLException e) { log.warn("Error generated", e); } finally { if (stmt != null) { try { stmt.close(); } catch (SQLException e) { log.warn("Failed to close the statement object"); } } if (pStmt != null) { try { pStmt.close(); } catch (SQLException e) { log.warn("Failed to close the prepared statement object"); } } } }</code><technical_language>I do this work PostgreSQL. If simple this, i a need for a custom java changeset. a liquibase sql tag. thinking loop records in java while assigning incrementing id. a database specific sql. sense? :)</technical_language>

Target:
public void execute(Database database) throws CustomChangeException { JdbcConnection connection = (JdbcConnection) database.getConnection(); Statement stmt = null; PreparedStatement pStmt = null; try { stmt = connection.createStatement(); ResultSet rs = stmt.executeQuery("SELECT * FROM cohort_member"); pStmt = connection .prepareStatement("UPDATE cohort_member SET cohort_member_id = ?" + " WHERE cohort_id = ? AND patient_id = ?"); int i = 0; while (rs.next()) { int cohortId = rs.getInt("cohort_id"); int patientId = rs.getInt("patient_id"); pStmt.setInt(1, ++i); pStmt.setInt(2, cohortId); pStmt.setInt(3, patientId); pStmt.addBatch(); } pStmt.executeBatch(); } catch (DatabaseException | SQLException e) { log.warn("Error generated", e); } finally { if (stmt != null) { try { stmt.close(); } catch (SQLException e) { log.warn("Failed to close the statement object"); } } if (pStmt != null) { try { pStmt.close(); } catch (SQLException e) { log.warn("Failed to close the prepared statement object"); } } } }
Source:
<code>public Config getConfigByName(String name) { <START> return name == null ? configs.getDefault() : configs.getByName(name); <END> }</code><technical_language>StringUtils.isEmpty</technical_language>

Target:
public Config getConfigByName(String name) { return StringUtils.isEmpty(name) ? configs.getDefault() : configs.getByName(name); }
Source:
<code>private void showSwitchFrame(final JSONObject json) { FrameLayout frameLayout = (FrameLayout) getView().findViewById(R.id.action_interface); frameLayout.removeAllViews(); getActivity().getLayoutInflater().inflate(R.layout.fragment_battle_action_switch, frameLayout); TextView[] textViews = new TextView[6]; textViews[0] = (TextView) getView().findViewById(R.id.switch_pokemon1_name); textViews[1] = (TextView) getView().findViewById(R.id.switch_pokemon2_name); textViews[2] = (TextView) getView().findViewById(R.id.switch_pokemon3_name); textViews[3] = (TextView) getView().findViewById(R.id.switch_pokemon4_name); textViews[4] = (TextView) getView().findViewById(R.id.switch_pokemon5_name); textViews[5] = (TextView) getView().findViewById(R.id.switch_pokemon6_name); for (int i = 0; i < getPlayer1Team().size(); i++) { final int idx = i + 1; <START> textViews[i].setText(getPlayer1Team().get(i).getName()); <END> textViews[i].setOnClickListener(new View.OnClickListener() { @Override public void onClick(View view) { if(!isTeamPreview()) { addCommand("switch " + idx); } else { addCommand("team " + idx); } clearActionFrame(); mCurrentActivePokemon++; if (mCurrentActivePokemon < mTotalActivePokemon) { showAttackOrSwitchFrame(json); } else { sendCommands(); } } }); } }</code><technical_language>Icon</technical_language>

Target:
private void showSwitchFrame(final JSONObject json) { FrameLayout frameLayout = (FrameLayout) getView().findViewById(R.id.action_interface); frameLayout.removeAllViews(); getActivity().getLayoutInflater().inflate(R.layout.fragment_battle_action_switch, frameLayout); TextView[] textViews = new TextView[6]; textViews[0] = (TextView) getView().findViewById(R.id.switch_pokemon1_name); textViews[1] = (TextView) getView().findViewById(R.id.switch_pokemon2_name); textViews[2] = (TextView) getView().findViewById(R.id.switch_pokemon3_name); textViews[3] = (TextView) getView().findViewById(R.id.switch_pokemon4_name); textViews[4] = (TextView) getView().findViewById(R.id.switch_pokemon5_name); textViews[5] = (TextView) getView().findViewById(R.id.switch_pokemon6_name); for (int i = 0; i < getPlayer1Team().size(); i++) { final int idx = i + 1; textViews[i].setText(getPlayer1Team().get(i).getName()); textViews[i].setCompoundDrawablesWithIntrinsicBounds(getPlayer1Team().get(i).getIcon(getActivity()),0,0,0); textViews[i].setOnClickListener(new View.OnClickListener() { @Override public void onClick(View view) { if(!isTeamPreview()) { addCommand("switch " + idx); } else { addCommand("team " + idx); } clearActionFrame(); mCurrentActivePokemon++; if (mCurrentActivePokemon < mTotalActivePokemon) { showAttackOrSwitchFrame(json); } else { sendCommands(); } } }); } }
Source:
<code>static CompletableFuture<?> and(CompletableFuture<?> first, CompletableFuture<?> second) { <START> if (first == AVAILABLE) { if (second == AVAILABLE) { <END> return AVAILABLE; } else { return second; } } else { if (second == AVAILABLE) { return first; } else { return CompletableFuture.allOf(first, second); } } }</code><technical_language>I if nesting more readabile: if (first == && == AVAILABLE) return AVAILABLE; else if (first == AVAILABLE) return second; else if (second == AVAILABLE) return first; else return allOf(first, second);</technical_language>

Target:
static CompletableFuture<?> and(CompletableFuture<?> first, CompletableFuture<?> second) { if (first == AVAILABLE && second == AVAILABLE) { return AVAILABLE; } else if (first == AVAILABLE) { return second; } else if (second == AVAILABLE) { return first; } else { return CompletableFuture.allOf(first, second); } }
Source:
<code>public void createXWidgetLayoutData(XWidgetRendererItem layoutData, XWidget xWidget, FormToolkit toolkit, Artifact art, XModifiedListener xModListener, boolean isEditable) { if (!Strings.isValid(xWidget.getToolTip())) { String description = ""; if (layoutData.getXWidgetName().equals(XCommitManager.WIDGET_NAME)) { description = XCommitManager.DESCRIPTION; } if (AttributeTypeManager.typeExists(layoutData.getStoreName())) { try { AttributeTypeToken type = null; if (layoutData.getStoreId() > 0) { type = AttributeTypeManager.getTypeById(layoutData.getStoreId()); } else { type = AttributeTypeManager.getType(layoutData.getStoreName()); } if (type != null && Strings.isValid(type.getDescription())) { description = type.getDescription(); } if (Strings.isValid(description)) { xWidget.setToolTip(description); layoutData.setToolTip(description); } } <START> catch (Exception ex) { } <END> } } if (xWidget.getControl() != null) { xWidget.getControl().setData(layoutData); } }</code><technical_language>want Exception is expected caught if 1 type put a print statement in</technical_language>

Target:
public void createXWidgetLayoutData(XWidgetRendererItem layoutData, XWidget xWidget, FormToolkit toolkit, Artifact art, XModifiedListener xModListener, boolean isEditable) { if (!Strings.isValid(xWidget.getToolTip())) { String description = ""; if (layoutData.getXWidgetName().equals(XCommitManager.WIDGET_NAME)) { description = XCommitManager.DESCRIPTION; } if (AttributeTypeManager.typeExists(layoutData.getStoreName())) { try { AttributeTypeToken type = null; if (layoutData.getStoreId() > 0) { type = AtsAttributeTypes.getTypeById(layoutData.getStoreId()); } else { type = AtsAttributeTypes.getTypeByName(layoutData.getStoreName()); } if (type == null) { if (layoutData.getStoreId() > 0) { type = AttributeTypeManager.getTypeById(layoutData.getStoreId()); } else { type = AttributeTypeManager.getType(layoutData.getStoreName()); } } if (type != null && Strings.isValid(type.getDescription())) { description = type.getDescription(); } if (Strings.isValid(description)) { xWidget.setToolTip(description); layoutData.setToolTip(description); } } catch (Exception ex) { String msg = String.format("Error setting tooltip for widget [%s]. Error %s (see log for details)", xWidget.getLabel(), ex.getLocalizedMessage()); OseeLog.log(Activator.class, Level.SEVERE, msg, ex); } } } if (xWidget.getControl() != null) { xWidget.getControl().setData(layoutData); } }
Source:
<code>private void createServerSocket() throws UnknownHostException, IOException { serverSocket = new ServerSocket(0, 1, InetAddress.getByName("127.0.0.1")); <START> int a = serverSocket.getLocalPort(); <END> }</code><technical_language>Is a anywhere</technical_language>

Target:
private void createServerSocket() throws UnknownHostException, IOException { serverSocket = new ServerSocket(0, 1, InetAddress.getByName("127.0.0.1")); }
Source:
<code>public void testJsonResponseType() { <START> Assertions.assertAll("Assert equal JSON response type.", <END> () -> Assertions.assertEquals(ResponseType.JSON, ResponseType.fromString("json")), () -> Assertions.assertEquals("json", ResponseType.JSON.toString())); }</code><technical_language>Love new assertAll()</technical_language>

Target:
public void testJsonResponseType() { assertAll("Assert equal JSON response type.", () -> assertEquals(ResponseType.JSON, ResponseType.fromString("json")), () -> assertEquals("json", ResponseType.JSON.toString())); }
Source:
<code>private void setServiceDays() { Calendar c = Calendar.getInstance(); c.setTime(new Date(opt.getSecondsSinceEpoch() * 1000)); c.setTimeZone(graph.getTimeZone()); final ServiceDate serviceDate = new ServiceDate(c); this.serviceDays = new ArrayList<ServiceDay>(3); if (calendarService == null && graph.getCalendarService() != null && (opt.modes == null || opt.modes.contains(TraverseMode.TRANSIT))) { LOG.warn("RoutingContext has no CalendarService. Transit will never be boarded."); return; } for (String feedId : graph.getFeedIds()) { for (Agency agency : graph.getAgencies(feedId)) { addIfNotExists(this.serviceDays, new ServiceDay(graph, serviceDate.previous(), calendarService, agency.getId())); addIfNotExists(this.serviceDays, new ServiceDay(graph, serviceDate, calendarService, agency.getId())); addIfNotExists(this.serviceDays, new ServiceDay(graph, serviceDate.next(), calendarService, agency.getId())); if (opt.serviceDayLookout > 0) { ServiceDate sd = serviceDate; <START> for (int i = 0; i < opt.serviceDayLookout; i++) { <END> sd = opt.arriveBy ? sd.previous() : sd.next(); addIfNotExists(this.serviceDays, new ServiceDay(graph, sd, calendarService, agency.getId())); } } } } }</code><technical_language>This is copying original ServiceDate incrementing/decrementing adding it. this double-add day immediately original ServiceDate (since added line 385 383 above). duplicate logic handle default "one day side" case asymmetric "long lookout side of start date" case, more sense if serviceDayLookout parameter defaulted 1 default (existing) behavior treated a minimum case of service day lookout</technical_language>

Target:
private void setServiceDays() { Calendar c = Calendar.getInstance(); c.setTime(new Date(opt.getSecondsSinceEpoch() * 1000)); c.setTimeZone(graph.getTimeZone()); final ServiceDate serviceDate = new ServiceDate(c); this.serviceDays = new ArrayList<ServiceDay>(3); if (calendarService == null && graph.getCalendarService() != null && (opt.modes == null || opt.modes.contains(TraverseMode.TRANSIT))) { LOG.warn("RoutingContext has no CalendarService. Transit will never be boarded."); return; } for (TimeZone timeZone : graph.getAllTimeZones()) { addIfNotExists(this.serviceDays, new ServiceDay(graph, serviceDate, calendarService, timeZone)); addIfNotExists(this.serviceDays, new ServiceDay(graph, opt.arriveBy ? serviceDate.next() : serviceDate.previous(), calendarService, timeZone)); ServiceDate sd = serviceDate; int lookout = Math.max(1, opt.serviceDayLookout); for (int i = 0; i < lookout; i++) { sd = opt.arriveBy ? sd.previous() : sd.next(); addIfNotExists(this.serviceDays, new ServiceDay(graph, sd, calendarService, timeZone)); } } serviceDays.sort(Comparator.comparing(ServiceDay::getServiceDate)); }
Source:
<code>protected PMML4Result evaluate(KiePMMLModel model, PMMLContext context) { logger.debug("evaluate {}", model, context); addMissingValuesReplacements(model, context); Optional<PMMLModelExecutor> pmmlModelExecutor = getFromPMMLModelType(model.getPmmlMODEL()); <START> return pmmlModelExecutor.isPresent() ? pmmlModelExecutor.get().evaluate(knowledgeBase, model, context) : new PMML4Result(); <END> }</code><technical_language>I prefer raise exception if model executor is available. Wdyt</technical_language>

Target:
protected PMML4Result evaluate(KiePMMLModel model, PMMLContext context) { if (logger.isDebugEnabled()) { logger.debug("evaluate {}", model, context); } addMissingValuesReplacements(model, context); PMMLModelExecutor executor = getFromPMMLModelType(model.getPmmlMODEL()) .orElseThrow(() -> new KiePMMLException(String.format("PMMLModelExecutor not found for model %s", model.getPmmlMODEL()))); return executor.evaluate(knowledgeBase, model, context); }
Source:
<code>public void createWithCorrectUrl() throws Exception { MatcherAssert.assertThat( "Hook json returned wrong url", this.hook.json().getString("url"), new IsEqual<String>( <START> this.xml.xpath("url/text()").get(0) <END> ) ); }</code><technical_language>@llorllale Again, test if returning string set before, a searched xml</technical_language>

Target:
public void createWithCorrectUrl() throws Exception { final String url = "<LINK_0>"; final int number = 5; final Coordinates coords = new Coordinates.Simple("user/repo"); final MkStorage storage = new MkStorage.InFile(); storage.apply( this.hookDirs(number, coords) .add("url").set(url).up() ); MatcherAssert.assertThat( "Hook json returned wrong url", new MkHook( storage, "login", coords, number ).json().getString("url"), new IsEqual<String>(url) ); }
Source:
<code>private void setBandDetails(List<String> inListe) throws MetadataTypeNotAllowedException { DocStruct ds = this.logicalTopstruct.getAllChildren().get(0); <START> for (String bandDetial : inListe) { <END> String meineDetailNr = bandDetial.substring(0, 3); if (meineDetailNr.equals("060")) { addMetadata(ds, "RUSPublisher", bandDetial); } if (meineDetailNr.equals("070")) { addMetadata(ds, "RUSPlaceOfPublication", bandDetial); } } }</code><technical_language>Typo in bandDetial -> bandDetail</technical_language>

Target:
private void setBandDetails(List<String> inListe) throws MetadataTypeNotAllowedException { DocStruct ds = this.logicalTopstruct.getAllChildren().get(0); for (String bandDetail : inListe) { String meineDetailNr = bandDetail.substring(0, 3); if (meineDetailNr.equals("060")) { addMetadata(ds, "RUSPublisher", bandDetail); } if (meineDetailNr.equals("070")) { addMetadata(ds, "RUSPlaceOfPublication", bandDetail); } } }
Source:
<code>public Method getSearchMethod(String searchMethodName, DSpaceRestRepository repository) { Method searchMethod = null; <START> Method[] methods = org.springframework.util.ClassUtils.getUserClass(repository.getClass()).getMethods(); <END> for (Method method : methods) { SearchRestMethod ann = AnnotationUtils.findAnnotation(method, SearchRestMethod.class); if (ann != null) { String name = ann.name(); if (name.isEmpty()) { name = method.getName(); } if (StringUtils.equals(name, searchMethodName)) { searchMethod = method; break; } } } return searchMethod; }</code><technical_language>import ClassUtils please simplify line</technical_language>

Target:
public Method getSearchMethod(String searchMethodName, DSpaceRestRepository repository) { Method searchMethod = null; Method[] methods = ClassUtils.getUserClass(repository.getClass()).getMethods(); for (Method method : methods) { SearchRestMethod ann = AnnotationUtils.findAnnotation(method, SearchRestMethod.class); if (ann != null) { String name = ann.name(); if (name.isEmpty()) { name = method.getName(); } if (StringUtils.equals(name, searchMethodName)) { searchMethod = method; break; } } } return searchMethod; }
Source:
<code>public void scheduleJobsForHosts() { <START> vdsManagersDict.values().stream().forEach(VdsManager::scheduleJobs); <END> }</code><technical_language>omitted</technical_language>

Target:
public void scheduleJobsForHosts() { vdsManagersDict.values().forEach(VdsManager::scheduleJobs); }
Source:
<code>protected void populateAdditions(BasicBrooklynCatalog catalog) { if (Strings.isNonBlank(additionsUri)) { if (disallowLocal) { if (!hasRunAdditions) { log.warn("CLI additions supplied but not supported in disallow-local mode; ignoring."); } <START> return; <END> } if (!hasRunAdditions) { log.debug("Adding to catalog from CLI: "+additionsUri+" (force: "+force+")"); } Iterable<? extends CatalogItem<?, ?>> items = catalog.addItems( new ResourceUtils(this).getResourceAsString(additionsUri), force); if (!hasRunAdditions) log.debug("Added to catalog from CLI: "+items); else log.debug("Added to catalog from CLI: count "+Iterables.size(items)); hasRunAdditions = true; } }</code><technical_language>if user explicitly --catalogAdd command line, precedence deprecated configuration fail a descriptive message</technical_language>

Target:
protected void populateAdditions(BasicBrooklynCatalog catalog) { if (Strings.isNonBlank(additionsUri)) { if (disallowLocal) { if (!hasRunAdditions) { log.warn("CLI additions supplied but not supported when catalog load mode disallows local loads; ignoring."); } return; } if (!hasRunAdditions) { log.debug("Adding to catalog from CLI: "+additionsUri+" (force: "+force+")"); } Iterable<? extends CatalogItem<?, ?>> items = catalog.addItems( new ResourceUtils(this).getResourceAsString(additionsUri), force); if (!hasRunAdditions) log.debug("Added to catalog from CLI: "+items); else log.debug("Added to catalog from CLI: count "+Iterables.size(items)); hasRunAdditions = true; } }
Source:
<code>public void delete(String id) { File file = getFingerprintFile(id); <START> file.delete(); <END> File inner = new File(Jenkins.get().getRootDir(), "fingerprints/"+id.substring(0,2)+"/"+id.substring(2,4)); String[] inner_files = inner.list(); if (inner_files!=null && inner_files.length==0) inner.delete(); File outer = new File(Jenkins.get().getRootDir(), "fingerprints/"+id.substring(0,2)); String[] outer_files = outer.list(); if (outer_files!=null && outer_files.length==0) outer.delete(); }</code><technical_language>Do need valid delete successful</technical_language>

Target:
public void delete(String id) throws IOException { File file = getFingerprintFile(id); if (!file.exists()) { return; } if (!file.delete()) { throw new IOException("Error occurred in deleting Fingerprint " + id); } File inner = new File(Jenkins.get().getRootDir(), "fingerprints/" + id.substring(0,2) + "/" + id.substring(2,4)); String[] inner_files = inner.list(); if (inner_files != null && inner_files.length == 0) { if (!inner.delete()){ throw new IOException("Error occurred in deleting inner directory of Fingerprint " + id); } } File outer = new File(Jenkins.get().getRootDir(), "fingerprints/" + id.substring(0,2)); String[] outer_files = outer.list(); if (outer_files != null && outer_files.length == 0) { if (!outer.delete()){ throw new IOException("Error occurred in deleting outer directory of Fingerprint " + id); } } }
Source:
<code>private void setMem(ITmfEvent event, Long ptr, Long size) { long ts = event.getTimestamp().getValue(); Long tid = getVtid(event); Long memoryDiff = size; if (ZERO.equals(size)) { Long memSize = fMemory.remove(ptr); if (memSize == null) { return; } <START> memoryDiff = MINUS_ONE * memSize; <END> } else { fMemory.put(ptr, size); } try { int tidQuark = ss.getQuarkAbsoluteAndAdd(String.valueOf(tid)); int tidMemQuark = ss.getQuarkRelativeAndAdd(tidQuark, UstMemoryStrings.UST_MEMORY_MEMORY_ATTRIBUTE); ITmfStateValue prevMem = ss.queryOngoingState(tidMemQuark); if (prevMem.isNull()) { int procNameQuark = ss.getQuarkRelativeAndAdd(tidQuark, UstMemoryStrings.UST_MEMORY_PROCNAME_ATTRIBUTE); String procName = getProcname(event); if (MINUS_ONE.equals(tid)) { procName = UstMemoryStrings.OTHERS; } ss.modifyAttribute(ts, TmfStateValue.newValueString(procName), procNameQuark); prevMem = TmfStateValue.newValueLong(0); } long prevMemValue = prevMem.unboxLong(); prevMemValue += memoryDiff.longValue(); ss.modifyAttribute(ts, TmfStateValue.newValueLong(prevMemValue), tidMemQuark); } catch (AttributeNotFoundException | TimeRangeException | StateValueTypeException e) { throw new IllegalStateException(e); } }</code><technical_language>memSize</technical_language>

Target:
private void setMem(ITmfEvent event, Long ptr, Long size) { long ts = event.getTimestamp().getValue(); Long tid = getVtid(event); Long memoryDiff = size; if (ZERO.equals(size)) { Long memSize = fMemory.remove(ptr); if (memSize == null) { return; } memoryDiff = -memSize; } else { fMemory.put(ptr, size); } try { int tidQuark = ss.getQuarkAbsoluteAndAdd(tid.toString()); int tidMemQuark = ss.getQuarkRelativeAndAdd(tidQuark, UstMemoryStrings.UST_MEMORY_MEMORY_ATTRIBUTE); ITmfStateValue prevMem = ss.queryOngoingState(tidMemQuark); if (prevMem.isNull()) { int procNameQuark = ss.getQuarkRelativeAndAdd(tidQuark, UstMemoryStrings.UST_MEMORY_PROCNAME_ATTRIBUTE); String procName = getProcname(event); if (tid.equals(MINUS_ONE)) { procName = UstMemoryStrings.OTHERS; } ss.modifyAttribute(ts, TmfStateValue.newValueString(procName), procNameQuark); prevMem = TmfStateValue.newValueLong(0); } long prevMemValue = prevMem.unboxLong(); prevMemValue += memoryDiff.longValue(); ss.modifyAttribute(ts, TmfStateValue.newValueLong(prevMemValue), tidMemQuark); } catch (AttributeNotFoundException | TimeRangeException | StateValueTypeException e) { throw new IllegalStateException(e); } }
Source:
<code>public static void openEditorForReblog( Activity activity, @Nullable SiteModel site, @Nullable ReaderPost post, PagePostCreationSourcesDetail reblogSource ) { if (post == null) { ToastUtils.showToast(activity, R.string.post_not_found, ToastUtils.Duration.SHORT); return; } if (site == null) { ToastUtils.showToast(activity, R.string.blog_not_found, ToastUtils.Duration.SHORT); return; } Map<String, Object> properties = new HashMap<>(); properties.put("source_post_id", post.postId); properties.put("source_blog_id", post.blogId); <START> properties.put("target_blog_id", site.getSiteId()); <END> AnalyticsTracker.track( reblogSource == PagePostCreationSourcesDetail.POST_FROM_REBLOG ? READER_ARTICLE_REBLOGGED : READER_ARTICLE_DETAIL_REBLOGGED, properties ); Intent editorIntent = new Intent(activity, EditPostActivity.class); editorIntent.putExtra(EditPostActivity.EXTRA_REBLOG_POST_TITLE, post.getTitle()); editorIntent.putExtra(EditPostActivity.EXTRA_REBLOG_POST_QUOTE, post.getExcerpt()); editorIntent.putExtra(EditPostActivity.EXTRA_REBLOG_POST_IMAGE, post.getFeaturedImage()); editorIntent.putExtra(EditPostActivity.EXTRA_REBLOG_POST_CITATION, post.getUrl()); editorIntent.setAction(EditPostActivity.ACTION_REBLOG); addNewPostForResult(editorIntent, activity, site, false, reblogSource); }</code><technical_language>AnalyticsUtils class some of fields here. Do sense create a utility method reuse some of properties? consider extracting constants instead of strings</technical_language>

Target:
public static void openEditorForReblog( Activity activity, @Nullable SiteModel site, @Nullable ReaderPost post, PagePostCreationSourcesDetail reblogSource ) { if (post == null) { ToastUtils.showToast(activity, R.string.post_not_found, ToastUtils.Duration.SHORT); return; } if (site == null) { ToastUtils.showToast(activity, R.string.blog_not_found, ToastUtils.Duration.SHORT); return; } AnalyticsUtils.trackWithReblogDetails( reblogSource == PagePostCreationSourcesDetail.POST_FROM_REBLOG ? READER_ARTICLE_REBLOGGED : READER_ARTICLE_DETAIL_REBLOGGED, post.blogId, post.postId, site.getSiteId() ); Intent editorIntent = new Intent(activity, EditPostActivity.class); editorIntent.putExtra(EditPostActivity.EXTRA_REBLOG_POST_TITLE, post.getTitle()); editorIntent.putExtra(EditPostActivity.EXTRA_REBLOG_POST_QUOTE, post.getExcerpt()); editorIntent.putExtra(EditPostActivity.EXTRA_REBLOG_POST_IMAGE, post.getFeaturedImage()); editorIntent.putExtra(EditPostActivity.EXTRA_REBLOG_POST_CITATION, post.getUrl()); editorIntent.setAction(EditPostActivity.ACTION_REBLOG); addNewPostForResult(editorIntent, activity, site, false, reblogSource); }
Source:
<code>private boolean isLiquid(Block block) { <START> BlockData data = block.getBlockData(); <END> if (data instanceof Levelled) { return ((Levelled) data).getLevel == 0; } return false; }</code><technical_language>This a bit performance-intense, a prior Material check adequate here</technical_language>

Target:
private boolean isLiquid(Block block) { if (!block.isLiquid()) return false; BlockData data = block.getBlockData(); if (data instanceof Levelled) { return ((Levelled) data).getLevel() == 0; } return false; }
Source:
<code>public void start() { <START> processorListener.beforeStart(); <END> synchronized (lock) { if (state == State.NEW) { state = State.STARTED; jobCoordinator.start(); } else { LOGGER.info("Start is no-op, since the current state is and not {}.", state, State.NEW); } } }</code><technical_language>this in block guarantee this is called once</technical_language>

Target:
public void start() { synchronized (lock) { if (state == State.NEW) { processorListener.beforeStart(); state = State.STARTED; jobCoordinator.start(); } else { LOGGER.info("Start is no-op, since the current state is and not {}.", state, State.NEW); } } }
Source:
<code>private ListenableFuture<Response> sendRequestToAsyncHandler( final AsyncRequestHandler asyncHandler, final Request request) { final Span span = Tracing.startInboundSpan(request, <START> topChannel.getTracer(), topChannel.getTracingContext()); <END> final SettableFuture<Response> responseFuture = SettableFuture.create(); ListenableFuture<Response> handlerResponseFuture = (ListenableFuture<Response>) asyncHandler.handleAsync(request); Futures.addCallback(handlerResponseFuture, new FutureCallback<Response>() { @Override public void onSuccess(Response response) { doRequestEndProcessing(); responseFuture.set(response); } @Override public void onFailure(Throwable e) { span.log("exception", e); doRequestEndProcessing(); responseFuture.setException(e); } private void doRequestEndProcessing() { span.finish(); request.release(); topChannel.getTracingContext().clear(); } }); return responseFuture; }</code><technical_language>Tracer TracingContext present channel is created them, check Tracer is null fallback previous behavior</technical_language>

Target:
private ListenableFuture<Response> sendRequestToAsyncHandler( final AsyncRequestHandler asyncHandler, final Request request) { final Span span; if (topChannel.getTracer() != null) { span = Tracing.startInboundSpan(request, topChannel.getTracer(), topChannel.getTracingContext()); } else { span = null; } final SettableFuture<Response> responseFuture = SettableFuture.create(); ListenableFuture<Response> handlerResponseFuture = (ListenableFuture<Response>) asyncHandler.handleAsync(request); Futures.addCallback(handlerResponseFuture, new FutureCallback<Response>() { @Override public void onSuccess(Response response) { doRequestEndProcessing(); responseFuture.set(response); } @Override public void onFailure(Throwable e) { if (span != null) { span.log("exception", e); } doRequestEndProcessing(); responseFuture.setException(e); } private void doRequestEndProcessing() { if (span != null) { span.finish(); } request.release(); topChannel.getTracingContext().clear(); } }); return responseFuture; }
Source:
<code>private static String formatErrorMessageBefore(WindupRuleProvider provider, WindupRuleProvider otherProvider) { <START> return "Rule \"" + provider.getID() + "\" from phase \"" + provider.getPhase() + "\" is to set to execute before\n" <END> + "rule \"" + otherProvider.getID() + "\"" + " from earlier phase \"" + otherProvider.getPhase() + "\".\nPossible solution is to specify phase " + otherProvider.getPhase() + " or earlier for the first rule."; }</code><technical_language>Replace "Rule" ---- WindupRuleProvider.class.getSimpleName() + " [" + provider.getID() + "] ..</technical_language>

Target:
private static String formatErrorMessageBefore(WindupRuleProvider provider, WindupRuleProvider otherProvider) { return WindupRuleProvider.class.getSimpleName() + '[' + provider.getID() + "] from phase " + provider.getPhase() + " is to set to execute before\n" + WindupRuleProvider.class.getSimpleName() + '[' + otherProvider.getID() + "] from earlier phase " + otherProvider.getPhase() + ".\nPossible solution is to specify phase " + otherProvider.getPhase() + " or earlier for the former."; }
Source:
<code>public void testStandardClientsUseTextDelegateEncoder() { assertThat(service.getString("string"), is("string")); <START> } <END></code><technical_language>cover a null response content type text/plain get right Optional behavior</technical_language>

Target:
public void testStandardClientsUseTextDelegateEncoder() { assertThat(service.getString("string"), is("string")); assertThat(service.getString(null), is((String) null)); }
Source:
<code>public String getNamespace() { return namespaceName; <START> } <END></code><technical_language>nice standardise 'namespace' 'namespaceName', is interchangeably in a files reviewed far. I suspect referred 'namespace'</technical_language>

Target:
public String getNamespace() { return namespace; }
Source:
<code>public IStatus validate(IProject project, String path) { File file = new File(path); if (!file.exists()) { return new Status(IStatus.ERROR, Activator.PLUGIN_ID, "File not found: " + path); } if (!file.isFile()) { return new Status(IStatus.ERROR, Activator.PLUGIN_ID, "Not a file. It's a directory: " + path); } int confidence = 0; try { if (!TmfTraceUtils.isText(file)) { return new TraceValidationStatus(confidence, Activator.PLUGIN_ID); } } catch (IOException e) { Activator.getInstance().logError("Error validating file: " + path, e); return new Status(IStatus.ERROR, Activator.PLUGIN_ID, "IOException validating file: " + path, e); } try (BufferedRandomAccessFile rafile = new BufferedRandomAccessFile(path, "r")) { goToCorrectStart(rafile); int lineCount = 0; int matches = 0; String line = readNextEventString(() -> rafile.read()); while ((line != null) && (lineCount++ < MAX_LINES)) { try { OpenTracingField field = OpenTracingField.parseJson(line, <START> ""); END> if (field != null) { matches++; } } catch (RuntimeException e) { confidence = Integer.MIN_VALUE; } confidence = MAX_CONFIDENCE * matches / lineCount; line = readNextEventString(() -> rafile.read()); } if (matches == 0) { return new Status(IStatus.ERROR, Activator.PLUGIN_ID, "Most assuredly NOT a Open-Tracing trace"); } } catch (IOException e) { Activator.getInstance().logError("Error validating file: " + path, e); return new Status(IStatus.ERROR, Activator.PLUGIN_ID, "IOException validating file: " + path, e); } return new TraceValidationStatus(confidence, Activator.PLUGIN_ID); }</code><technical_language>pass null</technical_language>

Target:
public IStatus validate(IProject project, String path) { File file = new File(path); if (!file.exists()) { return new Status(IStatus.ERROR, Activator.PLUGIN_ID, "File not found: " + path); } if (!file.isFile()) { return new Status(IStatus.ERROR, Activator.PLUGIN_ID, "Not a file. It's a directory: " + path); } int confidence = 0; try { if (!TmfTraceUtils.isText(file)) { return new TraceValidationStatus(confidence, Activator.PLUGIN_ID); } } catch (IOException e) { Activator.getInstance().logError("Error validating file: " + path, e); return new Status(IStatus.ERROR, Activator.PLUGIN_ID, "IOException validating file: " + path, e); } try (BufferedRandomAccessFile rafile = new BufferedRandomAccessFile(path, "r")) { goToCorrectStart(rafile); int lineCount = 0; int matches = 0; String line = readNextEventString(() -> rafile.read()); while ((line != null) && (lineCount++ < MAX_LINES)) { try { OpenTracingField field = OpenTracingField.parseJson(line, null); if (field != null) { matches++; } } catch (RuntimeException e) { confidence = Integer.MIN_VALUE; } confidence = MAX_CONFIDENCE * matches / lineCount; line = readNextEventString(() -> rafile.read()); } if (matches == 0) { return new Status(IStatus.ERROR, Activator.PLUGIN_ID, "Most assuredly NOT a Open-Tracing trace"); } } catch (IOException e) { Activator.getInstance().logError("Error validating file: " + path, e); return new Status(IStatus.ERROR, Activator.PLUGIN_ID, "IOException validating file: " + path, e); } return new TraceValidationStatus(confidence, Activator.PLUGIN_ID); }
Source:
<code>public void noPropertiesThrowsMeaningfulException() { try { AnnotationConfigApplicationContext context = new AnnotationConfigApplicationContext(); context.register(Conf.class); context.refresh(); fail("should throw exception"); <START> context.close(); <END> } catch (Exception e) { assertThat(e.getCause(), instanceOf(BindException.class)); BindException bindException = (BindException) e.getCause(); FieldError fieldError = (FieldError) bindException.getAllErrors().get(0); assertThat(fieldError.getArguments()[0].toString(), containsString("username")); assertThat(fieldError.getDefaultMessage(), equalTo("may not be empty")); } }</code><technical_language>Is this reachable? in case exception is thrown here. close in finally clause</technical_language>

Target:
public void noPropertiesThrowsMeaningfulException() { AnnotationConfigApplicationContext context = new AnnotationConfigApplicationContext(); try { context.register(Conf.class); context.refresh(); fail("exception expected"); } catch (Exception e) { assertThat(e.getCause(), instanceOf(BindException.class)); BindException bindException = (BindException) e.getCause(); FieldError fieldError = (FieldError) bindException.getAllErrors().get(0); assertThat(fieldError.getArguments()[0].toString(), containsString("username")); assertThat(fieldError.getDefaultMessage(), equalTo("may not be empty")); } finally { context.close(); } }
Source:
<code>public boolean isPaused() { synchronized (fSynchObject) { <START> return fIsPaused; <END> } }</code><technical_language>Accesses volatile primitives guaranteed atomic (as long depend current itself). synchronized block is redundant here. Good reference volatile keyword: <LINK_0></technical_language>

Target:
public boolean isPaused() { return fIsPaused; }
Source:
<code>private static Slice internalDoubleToLongDecimal(double value, long precision, long scale) { <START> if (Double.isInfinite(value) || Double.isNaN(value)) { <END> throw new PrestoException(INVALID_CAST_ARGUMENT, format("Cannot cast DOUBLE '%s' to DECIMAL(%s, %s)", value, precision, scale)); } try { BigDecimal bigDecimal = BigDecimal.valueOf(value).setScale((int) scale, BigDecimal.ROUND_HALF_UP); Slice decimal = Decimals.encodeScaledValue(bigDecimal); if (overflows(decimal, intScale(precision))) { throw new PrestoException(INVALID_CAST_ARGUMENT, format("Cannot cast DOUBLE '%s' to DECIMAL(%s, %s)", value, precision, scale)); } return decimal; } catch (ArithmeticException e) { throw new PrestoException(INVALID_CAST_ARGUMENT, format("Cannot cast DOUBLE '%s' to DECIMAL(%s, %s)", value, precision, scale)); } }</code><technical_language>cmt msg > double/real->decimal cast compatible cast varchar ... s/discourage/&d s/as s/as s s/change/&, s/naturally prints out/is printed s/out/as s/when/and &</technical_language>

Target:
private static Slice internalDoubleToLongDecimal(double value, long precision, long scale) { if (Double.isInfinite(value) || Double.isNaN(value)) { throw new PrestoException(INVALID_CAST_ARGUMENT, format("Cannot cast DOUBLE '%s' to DECIMAL(%s, %s)", value, precision, scale)); } try { BigDecimal bigDecimal = BigDecimal.valueOf(value).setScale(intScale(scale), HALF_UP); Slice decimal = Decimals.encodeScaledValue(bigDecimal); if (overflows(decimal, intScale(precision))) { throw new PrestoException(INVALID_CAST_ARGUMENT, format("Cannot cast DOUBLE '%s' to DECIMAL(%s, %s)", value, precision, scale)); } return decimal; } catch (ArithmeticException e) { throw new PrestoException(INVALID_CAST_ARGUMENT, format("Cannot cast DOUBLE '%s' to DECIMAL(%s, %s)", value, precision, scale)); } }
Source:
<code>public CloseableExecutorService(ExecutorService executorService, boolean shutdownOnClose) { <START> this.executorService = Preconditions.checkNotNull(executorService); <END> this.shutdownOnClose = shutdownOnClose; }</code><technical_language>Add a message checkNotNull. helps in debugging. canonical form is: java foo = Preconditions.checkNotNull(foo, "foo null");</technical_language>

Target:
public CloseableExecutorService(ExecutorService executorService, boolean shutdownOnClose) { this.executorService = Preconditions.checkNotNull(executorService, "executorService cannot be null"); this.shutdownOnClose = shutdownOnClose; }
Source:
<code>public Future<Void> truncateTableAsync(TableName tableName, boolean preserveSplits) throws IOException { if (!preserveSplits) { LOG.info("truncate will preserveSplits. The passed in variable is ignored."); } return FutureUtils.toCompletableFuture( tableAdminClientWrapper <START> .dropRowRangeAsync(tableName.getNameAsString(), ByteString.EMPTY.toStringUtf8())) <END> .thenApply(r -> null); }</code><technical_language>I "" fine</technical_language>

Target:
public Future<Void> truncateTableAsync(TableName tableName, boolean preserveSplits) throws IOException { if (!preserveSplits) { LOG.info("truncate will preserveSplits. The passed in variable is ignored."); } return FutureUtils.toCompletableFuture( tableAdminClientWrapper .dropRowRangeAsync(tableName.getNameAsString(), "")) .thenApply(r -> null); }