auphong2707/dl4se-code-review-dataset huggingface dataset:
Source:
<code>public void setValue(String value, boolean fireEvents) { clearSelections(); <START> for (String valueInProcess : Arrays.asList(value.split(","))) { END> int selectedIndex = getIndexFromDate(valueInProcess); if (clickedList.get(selectedIndex) != null) { clickedList.set(selectedIndex, true); onSelectedItemsChange(selectedIndex + 1, true); } } if (fireEvents) { ValueChangeEvent.fire(this, value); } }</code><technical_language>this: clearSelections(); if (value != null && !value.isEmpty()) { for (String valueInProcess: Arrays.asList(value.split(","))) { //$NON-NLS-1$ int selectedIndex = getIndexFromDate(valueInProcess); if (clickedList.get(selectedIndex) != null) { clickedList.set(selectedIndex, true); onSelectedItemsChange(selectedIndex + 1, true); } } if (fireEvents) { ValueChangeEvent.fire(this, value); } }</technical_language>

Target:
public void setValue(String value, boolean fireEvents) { clearSelections(); if (value != null && !value.isEmpty()) { for (String valueInProcess : Arrays.asList(value.split(","))) { int selectedIndex = getIndexFromDate(valueInProcess); if (clickedList.get(selectedIndex) != null) { clickedList.set(selectedIndex, true); onSelectedItemsChange(selectedIndex + 1, true); } } if (fireEvents) { ValueChangeEvent.fire(this, value); } } }
Source:
<code>public void setActive(boolean isActive) { <START> this.isActive = isActive; <END> }</code><technical_language>helpful for debugging purpose log out a statement this method is called. This way, easily log</technical_language>

Target:
public void setActive(boolean isActive) { this.isActive = isActive; logger.info("QueueProcessorThread active turned " + this.isActive); }
Source:
<code>public void obtain_date_from_year_month_day_values() { final int year = 1976; final int month = 3; final int day = 1; final LocalDate birthday = LocalDates.of(1976, MonthOfYear.APRIL, 1); final Calendar calendar = Calendar.getInstance(); calendar.set(year, month, day); assertEquals(calendar.get(Calendar.YEAR), birthday.getYear()); <START> assertEquals(calendar.get(Calendar.MONTH) + 1, birthday.getMonthValue()); <END> assertEquals(calendar.get(Calendar.DAY_OF_MONTH), birthday.getDay()); }</code><technical_language>again, getMonth(calendar), embeds knowledge of +1 difference in body. DRY</technical_language>

Target:
public void obtain_date_from_year_month_day_values() { final LocalDate localDate = LocalDates.of(year, month, day); assertTrue(year == localDate.getYear()); assertTrue(month == localDate.getMonth()); assertTrue(day == localDate.getDay()); }
Source:
<code>protected Event doExecute(final RequestContext requestContext) { val uid = WebUtils.getAuthentication(requestContext).getPrincipal().getId(); val credential = WebUtils.getCredential(requestContext, OneTimeTokenCredential.class); if (!StringUtils.isNumeric(credential.getToken())) { LOGGER.error("Non-numeric OTP token provided: [{}]", credential.getToken()); return error(); } val token = Integer.parseInt(credential.getToken()); val account = requestContext.getFlowScope().get("key", OneTimeTokenAccount.class); LOGGER.debug("Attempting to validate OTP token with [{}]", token, account); val isCodeValid = this.googleAuthenticatorInstance.authorize(account.getSecretKey(), token); if (!isCodeValid && account.getScratchCodes().contains(token)) { LOGGER.warn("User attempted to use scratch code during OTP registration; this is likely a mistake.", uid); return error(); } if (isCodeValid) { <START> LOGGER.debug("Validated OTP token to register user [{}]", token, uid); <END> repository.save(uid, account.getSecretKey(), account.getValidationCode(), account.getScratchCodes()); return success(); } LOGGER.warn("Failed to validate token to register user [{}]", token, uid); return error(); }</code><technical_language>simpler swap conditionals avoid a isCodeValid check. java if (isCodeValid) { // ... return success(); } // code is invalid if (account.getScratchCodes().contains(token)) { LOGGER.warn("User attempted scratch code OTP registration; this is a mistake.", uid); } else { LOGGER.warn("Failed validate token register user [{}]", token, uid); } return error();</technical_language>

Target:
protected Event doExecute(final RequestContext requestContext) { val account = requestContext.getFlowScope() .get(OneTimeTokenAccountCheckRegistrationAction.FLOW_SCOPE_ATTR_ACCOUNT, OneTimeTokenAccount.class); val uid = WebUtils.getAuthentication(requestContext).getPrincipal().getId(); val credential = WebUtils.getCredential(requestContext, OneTimeTokenCredential.class); val token = tokenValidator.parseToken(credential); LOGGER.debug("Attempting to validate OTP token with [{}]", token, account); val isCodeValid = tokenValidator.isValid(account, token); if (isCodeValid) { LOGGER.debug("Validated OTP token to register user [{}]", token, uid); repository.save(uid, account.getSecretKey(), account.getValidationCode(), account.getScratchCodes()); return success(); } if (account.getScratchCodes().contains(token)) { LOGGER.warn("User attempted to use scratch code during OTP registration; this is likely a mistake.", uid); return register(); } LOGGER.warn("Failed to validate token to register user [{}]", token, uid); return register(); }
Source:
<code>public MongoDBSession(MongoDBDirectory directory) { super(directory, MongoDBReference.class); MongoDBConnectionService mongoService = Framework.getService(MongoDBConnectionService.class); <START> database = mongoService.getDatabase("directory/" + directory.getDescriptor().name); <END> countersCollectionName = directory.getCountersCollectionName(); }</code><technical_language>a constant of "directory/" prefix</technical_language>

Target:
public MongoDBSession(MongoDBDirectory directory) { super(directory, MongoDBReference.class); MongoDBConnectionService mongoService = Framework.getService(MongoDBConnectionService.class); database = mongoService.getDatabase(DIRECTORY_CONNECTION_PREFIX + directory.getDescriptor().name); countersCollectionName = directory.getCountersCollectionName(); }
Source:
<code>private TDigest(double compression) { checkArgument(!isNaN(compression)); checkArgument(compression <= MAX_COMPRESSION_FACTOR, "Compression factor cannot exceed %s", MAX_COMPRESSION_FACTOR); this.publicCompression = max(compression, 10); this.compression = 2 * publicCompression; maxBufferSize = 5 * (int) ceil(this.publicCompression + sizeFudge); maxCentroidCount = (int) ceil(this.compression + sizeFudge); <START> weight = new double[4]; <END> mean = new double[4]; tempWeight = new double[8]; tempMean = new double[8]; order = new int[8]; activeCentroids = 0; }</code><technical_language>rational numbers? give a high level description of this change</technical_language>

Target:
private TDigest(double compression) { checkArgument(compression <= MAX_COMPRESSION_FACTOR, "Compression factor cannot exceed %s", MAX_COMPRESSION_FACTOR); this.publicCompression = max(compression, 10); this.compression = 2 * publicCompression; int bufferSize = 5 * (int) ceil(this.publicCompression + sizeFudge); int size = (int) ceil(this.compression + sizeFudge); weight = new double[size]; mean = new double[size]; tempWeight = new double[bufferSize]; tempMean = new double[bufferSize]; order = new int[bufferSize]; activeCentroids = 0; }
Source:
<code>public void testUpdate() throws IOException, OmiseException { Request<Customer> request = new Customer.UpdateRequestBuilder(CUSTOMER_ID) .email("john.doe.the.second@example.com") .build(); Customer customer = getTestRequester().sendRequest(request); assertRequested("PATCH", "/customers/" + CUSTOMER_ID, 200); <START> assertEquals("cust_test_4yq6txdpfadhbaqnwp3", customer.getId()); <END> assertEquals("john.doe.the.second@example.com", customer.getEmail()); }</code><technical_language>Is this cust_test_4yq6txdpfadhbaqnwp3 CUSTOMER_ID</technical_language>

Target:
public void testUpdate() throws IOException, OmiseException { Request<Customer> request = new Customer.UpdateRequestBuilder(CUSTOMER_ID) .email("john.doe.the.second@example.com") .build(); Customer customer = getTestRequester().sendRequest(request); assertRequested("PATCH", "/customers/" + CUSTOMER_ID, 200); assertEquals(CUSTOMER_ID, customer.getId()); assertEquals("john.doe.the.second@example.com", customer.getEmail()); }
Source:
<code>public void deleteCandidateGroups(CandidateGroupsPayload candidateGroupsPayload) { Task task; try { task = task(candidateGroupsPayload.getTaskId()); } catch (IllegalStateException ex) { throw new IllegalStateException("The authenticated user cannot update the task" + candidateGroupsPayload.getTaskId() + " due it is not the current assignee"); <START> } <END> if (candidateGroupsPayload.getCandidateGroups() != null && !candidateGroupsPayload.getCandidateGroups().isEmpty()) { for (String g : candidateGroupsPayload.getCandidateGroups()) { taskService.deleteCandidateGroup(task.getId(), g); } } }</code><technical_language>@CTI777 this is ok.. is private.. expose IdentityLinks in APIs, action needed.. for</technical_language>

Target:
public void deleteCandidateGroups(CandidateGroupsPayload candidateGroupsPayload) { if (candidateGroupsPayload.getCandidateGroups() != null && !candidateGroupsPayload.getCandidateGroups().isEmpty()) { for (String g : candidateGroupsPayload.getCandidateGroups()) { taskService.deleteCandidateGroup(candidateGroupsPayload.getTaskId(), g); } } }
Source:
<code>public PluginContainer getPlugin() { <START> return parent.getPlugin(); <END> }</code><technical_language>this</technical_language>

Target:
public PluginContainer getPlugin() { return this.parent.getPlugin(); }
Source:
<code>public @ResponseBody String getAppointmentByApplicantId(@PathVariable String applicantId) { <START> return jsonUtil.toJson(appointmentService.getAppointmentByApplicantId(applicantId)); <END> }</code><technical_language>Hope refacto in future, return valid Object instead of string allow Spring do work marshalling json for</technical_language>

Target:
public Appointment getAppointmentByApplicantId(@PathVariable String applicantId) { return appointmentService.getAppointmentByApplicantId(applicantId); }
Source:
<code>public Statement apply(Statement base, Description description) { try { SplunkServer splunkServer = new SplunkServer(); splunkServer.setPassword("admin"); splunkServer.setUsername("admin"); SplunkServiceFactory splunkServiceFactory = new SplunkServiceFactory(splunkServer); splunkServiceFactory.getService().open(splunkServer.getPort()); <START> } catch (Exception e) { <END> logger.warn("Not executing tests because basic connectivity test failed"); Assume.assumeNoException(e); } return super.apply(base, description); }</code><technical_language>catch new line. Minor, of course, is write code: <LINK_0></technical_language>

Target:
public Statement apply(Statement base, Description description) { try { SplunkServer splunkServer = new SplunkServer(); splunkServer.setPassword("admin"); splunkServer.setUsername("admin"); SplunkServiceFactory splunkServiceFactory = new SplunkServiceFactory( splunkServer); splunkServiceFactory.getService().open(port); } catch (Exception e) { logger.warn( "Not executing tests because basic connectivity test failed"); Assume.assumeNoException(e); } return super.apply(base, description); }
Source:
<code>public static boolean promptChangeVersion(AbstractWorkflowArtifact sma, VersionReleaseType versionReleaseType, VersionLockedType versionLockType) { if (AtsClientService.get().getUserService().isAtsAdmin() && !sma.isTeamWorkflow()) { AWorkbench.popup("ERROR ", "Cannot set version for: \n\n" + sma.getName()); return false; } if (promptChangeVersion(Arrays.asList((TeamWorkFlowArtifact) sma), versionReleaseType, versionLockType)) { IAtsChangeSet changes = AtsClientService.get().createChangeSet("ATS Prompt Change Version"); AtsClientService.get().getVersionService().setTargetedVersion((TeamWorkFlowArtifact) sma, getSelectedVersion(), <START> changes); <END> changes.execute(); ArtifactQuery.reloadArtifacts(Arrays.asList((TeamWorkFlowArtifact) sma)); return true; } return false; }</code><technical_language>changes.executeIfNecessary()</technical_language>

Target:
public static boolean promptChangeVersion(AbstractWorkflowArtifact sma, VersionReleaseType versionReleaseType, VersionLockedType versionLockType) { if (AtsClientService.get().getUserService().isAtsAdmin() && !sma.isTeamWorkflow()) { AWorkbench.popup("ERROR ", "Cannot set version for: \n\n" + sma.getName()); return false; } if (promptChangeVersion(Arrays.asList((TeamWorkFlowArtifact) sma), versionReleaseType, versionLockType)) { IAtsChangeSet changes = AtsClientService.get().createChangeSet("ATS Prompt Change Version"); AtsClientService.get().getVersionService().setTargetedVersion((TeamWorkFlowArtifact) sma, getSelectedVersion(), changes); changes.executeIfNeeded(); ArtifactQuery.reloadArtifacts(Arrays.asList((TeamWorkFlowArtifact) sma)); return true; } return false; }
Source:
<code>public void launch() { AbstractMongoDBServer server = getServer(); String host = server.getAttribute(AbstractMongoDBServer.HOSTNAME); Integer port = server.getAttribute(AbstractMongoDBServer.PORT); <START> for (String scriptName : entity.getConfig(MongoDBClient.DEFAULT_SCRIPTS)) { <END> runScript("", scriptName, host, port); } isRunning = true; }</code><technical_language>assume DEFAULT_SCRIPTS contained in SCRIPTS. clear config keys</technical_language>

Target:
public void launch() { AbstractMongoDBServer server = getServer(); String host = server.getAttribute(AbstractMongoDBServer.HOSTNAME); Integer port = server.getAttribute(AbstractMongoDBServer.PORT); for (String scriptName : entity.getConfig(MongoDBClient.STARTUP_JS_SCRIPTS)) { runScript("", scriptName, host, port); } isRunning = true; }
Source:
<code>private void createShowFirstParentOnlyAction() { showFirstParentOnlyAction = new ShowFirstParentOnlyPrefAction(); <START> showFirstParentOnlyAction .setImageDescriptor(UIIcons.FIRST_PARENT_ONLY); showFirstParentOnlyAction .setToolTipText(UIText.GitHistoryPage_showFirstParentOnly); <END> actionsToDispose.add(showFirstParentOnlyAction); }</code><technical_language>in constructor of action class</technical_language>

Target:
private void createShowFirstParentOnlyAction() { showFirstParentOnlyAction = new ShowFirstParentOnlyPrefAction(); actionsToDispose.add(showFirstParentOnlyAction); }
Source:
<code>public void testDataProviderswithDP(@NoInjection final Method method, final Class clazz) throws IllegalAccessException, InstantiationException { Object instance = clazz.newInstance(); <START> Set<Method> methodSet = Sets.newHashSet(); <END> methodSet.addAll(Arrays.asList(clazz.getDeclaredMethods())); methodSet.addAll(Arrays.asList(clazz.getMethods())); for (final Method otherMethod : methodSet) { if (otherMethod.isAnnotationPresent(BeforeSuite.class)) { try { otherMethod.setAccessible(true); otherMethod.invoke(instance); } catch (IllegalAccessException | InvocationTargetException e) { throw new IllegalStateException(String.format("@BeforeClass threw an exception (%s::%s). Dependent tests will be skipped. Please fix.", clazz.getName(), method.getName()), e); } } if (otherMethod.isAnnotationPresent(BeforeClass.class)) { try { otherMethod.setAccessible(true); otherMethod.invoke(instance); } catch (IllegalAccessException | InvocationTargetException e) { throw new IllegalStateException(String.format("@BeforeSuite threw an exception (%s::%s). Dependent tests will be skipped. Please fix.", clazz.getName(), method.getName()), e); } } } try { method.setAccessible(true); method.invoke(instance); } catch (IllegalAccessException | InvocationTargetException e) { throw new IllegalStateException(String.format("@DataProvider threw an exception (%s::%s). Dependent tests will be skipped. Please fix.", clazz.getName(), method.getName()), e); } }</code><technical_language>This unnecessary of Sets call new HashSet<>()</technical_language>

Target:
public void testDataProviderswithDP(@NoInjection final Method method, final Class clazz) throws IllegalAccessException, InstantiationException { Object instance = clazz.newInstance(); Set<Method> methodSet = new HashSet<>(); methodSet.addAll(Arrays.asList(clazz.getDeclaredMethods())); methodSet.addAll(Arrays.asList(clazz.getMethods())); if (methodSet.stream().anyMatch(m->m.isAnnotationPresent(BeforeSuite.class))) return; for (final Method otherMethod : methodSet) { if (otherMethod.isAnnotationPresent(BeforeClass.class)) { try { otherMethod.setAccessible(true); otherMethod.invoke(instance); } catch (IllegalAccessException | InvocationTargetException e) { throw new IllegalStateException(String.format("@BeforeClass threw an exception (%s::%s). Dependent tests will be skipped. Please fix.", clazz.getName(), method.getName()), e); } } } try { method.setAccessible(true); method.invoke(instance); } catch (IllegalAccessException | InvocationTargetException e) { throw new IllegalStateException(String.format("@DataProvider threw an exception (%s::%s). Dependent tests will be skipped. Please fix.", clazz.getName(), method.getName()), e); } }
Source:
<code>private <C extends DataWriteCommand & MetadataAwareCommand> Object handleDataWriteCommand(InvocationContext ctx, C command) { EntryVersion version; if (command.isReturnValueExpected()) { if (!(responseValue instanceof MetadataImmortalCacheValue)) { throw new CacheException("Expected MetadataImmortalCacheValue as response but it is " + responseValue); } MetadataImmortalCacheValue micv = (MetadataImmortalCacheValue) responseValue; version = micv.getMetadata().version(); returnValue = micv.getValue(); } else { if (!(responseValue instanceof EntryVersion)) { <START> throw new CacheException("Expected NumericVersion as response but it is " + responseValue); <END> } version = (EntryVersion) responseValue; returnValue = null; } Metadata metadata = addVersion(command.getMetadata(), version); entryFactory.wrapExternalEntry(ctx, command.getKey(), null, false, true); cacheEntry = ctx.lookupEntry(command.getKey()); cacheEntry.setMetadata(metadata); command.setValueMatcher(ValueMatcher.MATCH_ALWAYS); return invokeNextThenApply(ctx, command, this); }</code><technical_language>"Expected EntryVersion"</technical_language>

Target:
private <C extends DataWriteCommand & MetadataAwareCommand> Object handleDataWriteCommand(InvocationContext ctx, C command) { EntryVersion version; if (command.isReturnValueExpected()) { if (!(responseValue instanceof MetadataImmortalCacheValue)) { throw new CacheException("Expected MetadataImmortalCacheValue as response but it is " + responseValue); } MetadataImmortalCacheValue micv = (MetadataImmortalCacheValue) responseValue; version = micv.getMetadata().version(); returnValue = micv.getValue(); } else { if (!(responseValue instanceof EntryVersion)) { throw new CacheException("Expected EntryVersion as response but it is " + responseValue); } version = (EntryVersion) responseValue; returnValue = null; } Metadata metadata = addVersion(command.getMetadata(), version); entryFactory.wrapExternalEntry(ctx, command.getKey(), null, false, true); cacheEntry = ctx.lookupEntry(command.getKey()); cacheEntry.setMetadata(metadata); command.setValueMatcher(ValueMatcher.MATCH_ALWAYS); return invokeNextThenApply(ctx, command, this); }
Source:
<code>private InterpreterResult reLoginFromKeytab(String propertyKey, String sql, InterpreterContext interpreterContext, InterpreterResult interpreterResult) { String user = interpreterContext.getAuthenticationInfo().getUser(); try { closeDBPool(user, propertyKey); } catch (SQLException e) { } UserGroupInformation.AuthenticationMethod authType = JDBCSecurityImpl.getAuthtype(property); if (authType.equals(KERBEROS)) { try { if (UserGroupInformation.isLoginKeytabBased()) { UserGroupInformation.getLoginUser().reloginFromKeytab(); } else if (UserGroupInformation.isLoginTicketBased()) { UserGroupInformation.getLoginUser().reloginFromTicketCache(); } } catch (IOException e) { logger.error("Cannot reloginFromKeytab " + sql, e); ByteArrayOutputStream baos = new ByteArrayOutputStream(); PrintStream ps = new PrintStream(baos); e.printStackTrace(ps); String errorMsg = new String(baos.toByteArray(), StandardCharsets.UTF_8); <START> interpreterResult.add(errorMsg); <END> return new InterpreterResult(Code.ERROR, interpreterResult.message()); } } return executeSql(propertyKey, sql, interpreterContext); }</code><technical_language>do want full exception + call stack show in interpret result - a bit much</technical_language>

Target:
private InterpreterResult reLoginFromKeytab(String propertyKey, String sql, InterpreterContext interpreterContext, InterpreterResult interpreterResult) { String user = interpreterContext.getAuthenticationInfo().getUser(); try { closeDBPool(user, propertyKey); } catch (SQLException e) { logger.error("Error, could not close DB pool in reLoginFromKeytab ", e); } UserGroupInformation.AuthenticationMethod authType = JDBCSecurityImpl.getAuthtype(property); if (authType.equals(KERBEROS)) { try { if (UserGroupInformation.isLoginKeytabBased()) { UserGroupInformation.getLoginUser().reloginFromKeytab(); } else if (UserGroupInformation.isLoginTicketBased()) { UserGroupInformation.getLoginUser().reloginFromTicketCache(); } } catch (IOException e) { logger.error("Cannot reloginFromKeytab " + sql, e); interpreterResult.add(e.getMessage()); return new InterpreterResult(Code.ERROR, interpreterResult.message()); } } return executeSql(propertyKey, sql, interpreterContext); }
Source:
<code><START> public synchronized void update() { <END> int n = getMembers().size(); for (int i = 0; i < n; i++) { log.info("Update cassandra cluster member of {}", i, n); CassandraServer server = (CassandraServer) Iterables.get(getMembers(), i); BigInteger token = BigInteger.valueOf(2L).pow(127).divide(BigInteger.valueOf(n)).multiply(BigInteger.valueOf(i)); server.setToken(token.toString()); } }</code><technical_language>synchronize this. deadlocks in DynamicGroup [1]. I suspect this deadlock getMembers() addMember(), synchronize a private final object instead. [1] <LINK_0></technical_language>

Target:
public void update() { }
Source:
<code>public void testBuiltMessageRedisplayLimit() throws JSONException { OSTestInAppMessage message = InAppMessagingHelpers.buildTestMessageWitRedisplay( LIMIT, DELAY ); for (int i = 0; i < LIMIT; i++) { <START> assertTrue( message.shouldDisplayAgain()); <END> message.incrementDisplayQuantity(); } }</code><technical_language>nit, remove space (</technical_language>

Target:
public void testBuiltMessageRedisplayLimit() throws JSONException { OSTestInAppMessage message = InAppMessagingHelpers.buildTestMessageWitRedisplay( LIMIT, DELAY ); for (int i = 0; i < LIMIT; i++) { assertTrue(message.getDisplayStats().shouldDisplayAgain()); message.getDisplayStats().incrementDisplayQuantity(); } message.getDisplayStats().incrementDisplayQuantity(); assertFalse(message.getDisplayStats().shouldDisplayAgain()); }
Source:
<code>private void parseSuite(String suitePath) { if (LOGGER.isDebugEnabled()) { LOGGER.debug("suiteXmlPath: \"" + suitePath + "\""); } try { Collection<XmlSuite> allSuites = Parser.parse(suitePath, getProcessor()); for (XmlSuite s : allSuites) { if (this.m_parallelMode != null) { s.setParallel(this.m_parallelMode); <START> } <END> if (this.m_threadCount > 0) { s.setThreadCount(this.m_threadCount); } if (m_testNames != null) { m_suites.add(XmlSuiteUtils.cloneIfContainsTestsWithNamesMatchingAny(s, m_testNames)); } else { m_suites.add(s); } } } catch (IOException e) { e.printStackTrace(System.out); } catch (Exception ex) { Throwable t = ex; while (t.getCause() != null) { t = t.getCause(); } if (t instanceof TestNGException) { throw (TestNGException) t; } throw new TestNGException(t); } }</code><technical_language>m_parallelMode m_threadCount supposed valid values (default values if set). prefer sanitize values set. Do is possible</technical_language>

Target:
private void parseSuite(String suitePath) { if (LOGGER.isDebugEnabled()) { LOGGER.debug("suiteXmlPath: \"" + suitePath + "\""); } try { Collection<XmlSuite> allSuites = Parser.parse(suitePath, getProcessor()); for (XmlSuite s : allSuites) { if (this.m_parallelMode != null) { s.setParallel(this.m_parallelMode); } if (this.m_threadCount > 0) { s.setThreadCount(this.m_threadCount); } if (m_testNames == null) { m_suites.add(s); continue; } TestNamesMatcher testNamesMatcher = new TestNamesMatcher(s, m_testNames); List<String> missMatchedTestname = testNamesMatcher.getMissMatchedTestNames(); if (!missMatchedTestname.isEmpty()) { throw new TestNGException("The test(s) <" + missMatchedTestname + "> cannot be found."); } m_suites.addAll(testNamesMatcher.getSuitesMatchingTestNames()); } } catch (IOException e) { e.printStackTrace(System.out); } catch (Exception ex) { Throwable t = ex; while (t.getCause() != null) { t = t.getCause(); } if (t instanceof TestNGException) { throw (TestNGException) t; } throw new TestNGException(t); } }
Source:
<code>public static void serializeMetadataContentRecord(ByteBuffer outputBuffer, List<StoreKey> keys) { int keySize = keys.get(0).sizeInBytes(); for (StoreKey storeKey : keys) { if (storeKey.sizeInBytes() != keySize) { throw new IllegalArgumentException("Keys are not of same size"); } } outputBuffer.putShort(Metadata_Content_Version_V1); <START> outputBuffer.putInt(keys.size()); <END> for (StoreKey storeKey : keys) { outputBuffer.put(storeKey.toBytes()); } }</code><technical_language>If understanding is correct, supposed putting keySize keys.size()? If this is true, tests succeeding? full coverage</technical_language>

Target:
public static void serializeMetadataContentRecord(ByteBuffer outputBuffer, List<StoreKey> keys) { int keySize = keys.get(0).sizeInBytes(); outputBuffer.putShort(Metadata_Content_Version_V1); outputBuffer.putInt(keys.size()); for (StoreKey storeKey : keys) { if (storeKey.sizeInBytes() != keySize) { throw new IllegalArgumentException("Keys are not of same size"); } outputBuffer.put(storeKey.toBytes()); } }
Source:
<code>private Set<String> getSenseBlackList() { final Jedis jedis = jedisPool.getResource(); try { return jedis.smembers(BlackListDevicesConfiguration.SENSE_BLACK_LIST_KEY); } catch (Exception e) { <START> return new HashSet(Arrays.asList()); <END> } finally { jedisPool.returnResource(jedis); } }</code><technical_language>Arrays.asList()</technical_language>

Target:
private Set<String> getSenseBlackList() { if (lastBlackListFetchDateTime.plusMinutes(REFRESH_PERIOD_MINUTES).isBeforeNow() || blackListUpdateCount == 0){ lastBlackListFetchDateTime = DateTime.now(DateTimeZone.UTC); Jedis jedis = null; try { jedis = jedisPool.getResource(); senseBlackList = jedis.smembers(BlackListDevicesConfiguration.SENSE_BLACK_LIST_KEY); LOGGER.info("Refreshed sense black list"); } catch (JedisDataException e) { LOGGER.error("Failed to get data from redis - {}", e.getMessage()); if (jedis != null) { jedisPool.returnBrokenResource(jedis); } } catch (Exception e) { LOGGER.error("Failed to refresh sense black list because {}", e.getMessage()); if (jedis != null) { jedisPool.returnBrokenResource(jedis); } } finally { if (jedis != null) { jedisPool.returnResource(jedis); } } } blackListUpdateCount += 1; return senseBlackList; }
Source:
<code>public String validate(String parameterValue, ModelValidatorContext context) throws ValidationException { if (context == null || context.getScheduler() == null) { logger.warn(String.format("Can't check the validity of the variable value, because missing the access to the scheduler third-party credentials", parameterValue)); return parameterValue; } try { Set<String> credentialKeys = context.getScheduler().thirdPartyCredentialsKeySet(); if (!credentialKeys.contains(parameterValue)) { <START> throw new ValidationException("Expected value should exist in the third-party credentials."); <END> } } catch (NotConnectedException | PermissionException e) { throw new ValidationException("Exception during getting the third-party credentials.", e); } return parameterValue; }</code><technical_language>please output credential key in error message. This give user ability read error message studio, copy missing key, create missing credential (the original credential key stored in variable references other variables, making handy for copy/paste. server error message show, other hand, final value, references resolved)</technical_language>

Target:
public String validate(String parameterValue, ModelValidatorContext context) throws ValidationException { if (context == null || context.getScheduler() == null) { logger.debug(String.format("Can't check the validity of the variable value, because missing the access to the scheduler third-party credentials", parameterValue)); return parameterValue; } try { Set<String> credentialKeys = context.getScheduler().thirdPartyCredentialsKeySet(); if (!credentialKeys.contains(parameterValue)) { throw new ValidationException(String.format("Could not find the key named [%s] in the third-party credentials. Please add it into the scheduler third-party credentials or change the variable value to a valid key.", parameterValue)); } } catch (NotConnectedException | PermissionException e) { throw new ValidationException("Could not read third party-credentials from the scheduler, make sure you are connected and you have permission rights to read third-party credentials.", e); } return parameterValue; }
Source:
<code><START> public boolean accept(TreeWalkerAuditEvent event) { <END> return fileNameAndModuleAndCheckNameMismatches(event) || isXpathQueryMatching(event); }</code><technical_language>So, if xpath query matches event this method return true, right? event propagated TreeWalker. This java if (!filter.accept(event)) { evaluated false message removed set. Thus, is sense of suppression? do filter? testMatching. user writes query /CLASS_DEF[@text='InputSuppressByXpath'] in order suppress violation, filter deny event, filter accept it</technical_language>

Target:
public boolean accept(TreeWalkerAuditEvent event) { return !isFileNameAndModuleAndCheckNameMatching(event) || !isXpathQueryMatching(event); }
Source:
<code>public Boolean isRebalancerEnabled() { <START> return Optional.of(rebalancerEnabled).or(DEFAULT_REBALANCER_ENABLED); <END> }</code><technical_language>I want Optional.fromNullable Optional.of, for difference check out <LINK_0> In fact, method: public static <T> Optional<T> of(T reference) { return new Present<T>(checkNotNull(reference)); } checkNotNull is a guava precondition exception</technical_language>

Target:
public Boolean isRebalancerEnabled() { return Optional.fromNullable(rebalancer).or(DEFAULT_REBALANCER_ENABLED); }
Source:
<code>public ResponseEntity<HalResource> addAttachmentToComponent(@PathVariable("componentId") String componentId, OAuth2Authentication oAuth2Authentication, @RequestPart("file") MultipartFile file, @RequestPart("attachment") Attachment newAttachment) throws TException { <START> final User sw360User = restControllerHelper.getSw360UserFromAuthentication(oAuth2Authentication); <END> Attachment attachment; try { attachment = attachmentService.uploadAttachment(file, newAttachment, sw360User); } catch (IOException e) { log.error(e.getMessage()); throw new RuntimeException(e); } final Component component = componentService.getComponentForUserById(componentId, sw360User); component.addToAttachments(attachment); componentService.updateComponent(component, sw360User); final HalResource halRelease = createHalComponent(component, sw360User); return new ResponseEntity<>(halRelease, HttpStatus.OK); }</code><technical_language>describe error in a short text in addition exception message</technical_language>

Target:
public ResponseEntity<HalResource> addAttachmentToComponent(@PathVariable("componentId") String componentId, OAuth2Authentication oAuth2Authentication, @RequestPart("file") MultipartFile file, @RequestPart("attachment") Attachment newAttachment) throws TException { final User sw360User = restControllerHelper.getSw360UserFromAuthentication(oAuth2Authentication); Attachment attachment; try { attachment = attachmentService.uploadAttachment(file, newAttachment, sw360User); } catch (IOException e) { log.error("failed to upload attachment", e); throw new RuntimeException("failed to upload attachment", e); } final Component component = componentService.getComponentForUserById(componentId, sw360User); component.addToAttachments(attachment); componentService.updateComponent(component, sw360User); final HalResource halRelease = createHalComponent(component, sw360User); return new ResponseEntity<>(halRelease, HttpStatus.OK); }
Source:
<code>private void performSingleNodeSolrBackup() throws URISyntaxException { verifySingleNodeBackupInput(); <START> httpBuilder = new org.codice.solr.factory.impl.HttpClientBuilder(encryptionService); <END> String url = AccessController.doPrivileged( (PrivilegedAction<String>) () -> System.getProperty("solr.http.url")); String backupUrl = String.format("%s/%s/%s", url, coreName, "replication"); URIBuilder uriBuilder = new URIBuilder(backupUrl); uriBuilder.addParameter("command", "backup"); if (StringUtils.isNotBlank(backupLocation)) { uriBuilder.addParameter("location", backupLocation); } if (numberToKeep > 0) { uriBuilder.addParameter("numberToKeep", Integer.toString(numberToKeep)); } URI backupUri = uriBuilder.build(); processResponse(sendGetRequest(backupUri)); }</code><technical_language>question: reason full package name here</technical_language>

Target:
private void performSingleNodeSolrBackup() throws URISyntaxException { verifySingleNodeBackupInput(); httpBuilder = new org.codice.solr.factory.impl.HttpClientBuilder(encryptionService); String url = AccessController.doPrivileged( (PrivilegedAction<String>) () -> System.getProperty("solr.http.url")); String backupUrl = String.format("%s/%s/replication", url, coreName); URIBuilder uriBuilder = new URIBuilder(backupUrl); uriBuilder.addParameter("command", "backup"); if (StringUtils.isNotBlank(backupLocation)) { uriBuilder.addParameter("location", backupLocation); } if (numberToKeep > 0) { uriBuilder.addParameter("numberToKeep", Integer.toString(numberToKeep)); } URI backupUri = uriBuilder.build(); processResponse(sendGetRequest(backupUri)); }
Source:
<code>public void testSimpleRename() throws IOException { SimpleFeatureSource fs = store.getFeatureSource(BUILDINGS.getLocalPart()); SimpleFeatureTypeBuilder tb = new SimpleFeatureTypeBuilder(); tb.init(fs.getSchema()); tb.setName("houses"); SimpleFeatureType target = tb.buildFeatureType(); SimpleFeatureSource retyped = RetypingFeatureSource.getRetypingSource(fs, target); <START> assertEquals(target, retyped.getSchema()); <END> assertEquals(target, ((DataStore) retyped.getDataStore()).getSchema("houses")); assertEquals(target, retyped.getFeatures().getSchema()); SimpleFeatureIterator it = retyped.getFeatures().features(); SimpleFeature f = it.next(); it.close(); assertEquals(target, f.getType()); }</code><technical_language>This a regression! Confirmed, need update ContentDataStore</technical_language>

Target:
public void testSimpleRename() throws IOException { SimpleFeatureSource fs = store.getFeatureSource(BUILDINGS.getLocalPart()); SimpleFeatureTypeBuilder tb = new SimpleFeatureTypeBuilder(); tb.init(fs.getSchema()); tb.setName("houses"); SimpleFeatureType target = tb.buildFeatureType(); SimpleFeatureSource retyped = RetypingFeatureSource.getRetypingSource(fs, target); assertTrue(retyped instanceof SimpleFeatureLocking); assertEquals(target, retyped.getSchema()); assertEquals(target, ((DataStore) retyped.getDataStore()).getSchema("houses")); assertEquals(target, retyped.getFeatures().getSchema()); SimpleFeatureIterator it = retyped.getFeatures().features(); SimpleFeature f = it.next(); it.close(); assertEquals(target, f.getType()); }
Source:
<code>public void testUserTask() throws Exception { Long processInstanceId = startProcessInstance(PROCESS_ID); UserTransaction ut = InitialContext.doLookup(USER_TRANSACTION_NAME); ut.begin(); List<TaskSummary> taskSummaries = null; try { processService.signalProcessInstance(processInstanceId, "start", "usertask"); taskSummaries = runtimeDataService.getTasksAssignedAsPotentialOwner("john", new QueryFilter()); Assertions.assertThat(taskSummaries).isNotNull().hasSize(1); userTaskService.start(taskSummaries.get(0).getId(), "john"); userTaskService.complete(taskSummaries.get(0).getId(), "john", new HashMap<String, Object>()); Assertions.assertThat(hasNodeLeft(processInstanceId, "User Task")).isTrue(); } catch (Exception e) { ut.rollback(); throw e; } ut.rollback(); ut = InitialContext.doLookup(USER_TRANSACTION_NAME); ut.begin(); <START> try { <END> processService.signalProcessInstance(processInstanceId, "start", "usertask"); taskSummaries = runtimeDataService.getTasksAssignedAsPotentialOwner("john", new QueryFilter()); Assertions.assertThat(taskSummaries).isNotNull().hasSize(1); userTaskService.start(taskSummaries.get(0).getId(), "john"); userTaskService.complete(taskSummaries.get(0).getId(), "john", new HashMap<String, Object>()); } catch (Exception e) { ut.rollback(); throw e; } ut.commit(); Assertions.assertThat(hasNodeLeft(processInstanceId, "User Task")).isTrue(); Assertions.assertThat(hasTaskCompleted(taskSummaries.get(0).getId())); Assertions.assertThat(hasProcessInstanceCompleted(processInstanceId)).isFalse(); }</code><technical_language>This try-catch block refactored a standalone method</technical_language>

Target:
public void testUserTask() throws Exception { Long processInstanceId = startProcessInstance(PROCESS_ID); UserTransaction ut = InitialContext.doLookup(USER_TRANSACTION_NAME); ut.begin(); List<TaskSummary> taskSummaries = null; try { processService.signalProcessInstance(processInstanceId, "start", "usertask"); taskSummaries = startAndCompleteHumanTask(processInstanceId); } catch (Exception e) { ut.rollback(); throw e; } ut.rollback(); Assertions.assertThat(runtimeDataService.getTaskById(taskSummaries.get(0).getId())).isNull(); ut = InitialContext.doLookup(USER_TRANSACTION_NAME); ut.begin(); try { processService.signalProcessInstance(processInstanceId, "start", "usertask"); taskSummaries = startAndCompleteHumanTask(processInstanceId); } catch (Exception e) { ut.rollback(); throw e; } ut.commit(); Assertions.assertThat(hasNodeLeft(processInstanceId, "User Task")).isTrue(); Assertions.assertThat(hasTaskCompleted(taskSummaries.get(0).getId())); Assertions.assertThat(hasProcessInstanceCompleted(processInstanceId)).isFalse(); }
Source:
<code><START> public void clearCandidates() { <END> fTraceTypes.clear(); fTraceFiles.clear(); }</code><technical_language>add missing java-doc</technical_language>

Target:
public synchronized void clearCandidates() { fTraceTypes.clear(); fTraceFiles.clear(); }
Source:
<code>public void testChild() { final Object child = new ParseTreeTablePModel(null).getChild(tree, 0); Assert.assertTrue(child instanceof DetailAST); <START> Assert.assertSame(((DetailAST) child).getType(), TokenTypes.MODIFIERS); <END> }</code><technical_language>TeamCity(TC) is failing build point Object usage. Please update getChild signature in ParseTreeTablePModel return type. Please resolve other TC failures</technical_language>

Target:
public void testChild() { final Object child = new ParseTreeTablePModel(null).getChild(tree, 1); Assert.assertTrue(child instanceof DetailAST); Assert.assertEquals(TokenTypes.BLOCK_COMMENT_BEGIN, ((AST) child).getType()); }
Source:
<code>public boolean isValid(T value, ConstraintValidatorContext context) { if ( value == null ) { return true; } <START> long result = this.getCurrentAge( value ) - this.referenceAge; <END> return isValid( result ); }</code><technical_language>slightly change this isValid method need write similar code right in Calendar validator for Date one. instants support add/subtract operations units > days need do similar is in AgeMinValidatorForCalendar. like: java public boolean isValid(T value, ConstraintValidatorContext context) { // null values valid if ( == null ) { return true; } // Instant support operation ChronoUnits greater DAYS need convert LocalDateTime // first, supports operations. long result = LocalDateTime.ofInstant( getInstant( ), ZoneOffset.ofHours( 0 ) ).plus( referenceAge, unit ).compareTo( LocalDateTime.now( referenceClock ) ); return isValid( result ); } change need change isValid method to: java @Override protected boolean isValid(long result) { return this.inclusive ? result <= 0 : result < 0; } for Date need convert instant</technical_language>

Target:
public boolean isValid(T value, ConstraintValidatorContext context) { if ( value == null ) { return true; } int result = getInstant( value ).atZone( ZoneOffset.ofHours( 0 ) ).toLocalDate() .compareTo( LocalDate.now( referenceClock ).minus( referenceAge, unit ) ); return isValid( result ); }
Source:
<code>public void executeCallback(final String callbackId) { if (callbackId.equals("callback-dom-loaded")) { mWebView.post(new Runnable() { public void run() { String htmlFile = ""; try { htmlFile = getStringFromAsset("example-content.html"); htmlFile = htmlFile.replace("\\", "\\\\"); htmlFile = htmlFile.replace("\"", "\\\""); htmlFile = htmlFile.replace("'", "\\'"); htmlFile = htmlFile.replace("\r", "\\r"); <START> htmlFile = htmlFile.replace("\n", "\\n"); <END> } catch (IOException e) { AppLog.e(T.EDITOR, e.getMessage()); } mWebView.loadUrl("JavaScript:ZSSEditor.getField('zss_field_title').setHTML('" + "I\\'m editing a post!" + "');"); mWebView.loadUrl("JavaScript:ZSSEditor.getField('zss_field_content').setHTML('" + htmlFile + "');"); } }); } }</code><technical_language>refactor a lot of this a stand-alone utility method</technical_language>

Target:
public void executeCallback(final String callbackId) { if (callbackId.equals("callback-dom-loaded")) { mWebView.post(new Runnable() { public void run() { String title = "I'm editing a post!"; String contentHtml = getHtmlFromFile("example-content.html"); mWebView.loadUrl("javascript:ZSSEditor.getField('zss_field_title').setHTML('" + Utils.escapeHtml(title) + "');"); mWebView.loadUrl("javascript:ZSSEditor.getField('zss_field_content').setHTML('" + Utils.escapeHtml(contentHtml) + "');"); } }); } }
Source:
<code>public void run() { while (true) { try { NativeObjectReference reference = (NativeObjectReference) referenceQueue.remove(); reference.cleanup(); } catch (InterruptedException e) { <START> Thread.currentThread().interrupt(); <END> } } }</code><technical_language>is purpose of catching this exception. If this thread is interrupted sounds more IllegalState somehow</technical_language>

Target:
public void run() { while (true) { try { NativeObjectReference reference = (NativeObjectReference) referenceQueue.remove(); reference.cleanup(); } catch (InterruptedException e) { Thread.currentThread().interrupt(); RealmLog.fatal("The FinalizerRunnable thread has been interrupted." + " Native resources cannot be freed anymore"); break; } } }
Source:
<code>public TidalControl(UUID ownerId, CardSetInfo setInfo) { super(ownerId, setInfo, new CardType[]{CardType.ENCHANTMENT}, "{1}{U}{U}"); this.addAbility(new CumulativeUpkeepAbility(new ManaCostsImpl("{2}"))); SimpleActivatedAbility ability = new SimpleActivatedAbility(Zone.BATTLEFIELD, new CounterTargetEffect(), new PayLifeCost(2)); ability.addTarget(new TargetSpell(filter)); ability.setMayActivate(TargetController.ANY); ability.addEffect(new InfoEffect("Any player may activate this ability")); this.addAbility(ability); ability = new SimpleActivatedAbility(Zone.BATTLEFIELD, new CounterTargetEffect(), new ManaCostsImpl("{2}")); ability.addTarget(new TargetSpell(filter)); ability.setMayActivate(TargetController.ANY); ability.addEffect(new InfoEffect("Any player may activate this ability")); this.addAbility(ability); <START> } <END></code><technical_language>OrCost instead of making separate abilities</technical_language>

Target:
public TidalControl(UUID ownerId, CardSetInfo setInfo) { super(ownerId, setInfo, new CardType[]{CardType.ENCHANTMENT}, "{1}{U}{U}"); this.addAbility(new CumulativeUpkeepAbility(new ManaCostsImpl("{2}"))); SimpleActivatedAbility ability = new SimpleActivatedAbility(Zone.BATTLEFIELD, new CounterTargetEffect(), new OrCost(new PayLifeCost(2), new ManaCostsImpl("{2}"), "pay 2 life or pay {2}")); ability.addTarget(new TargetSpell(filter)); ability.setMayActivate(TargetController.ANY); ability.addEffect(new InfoEffect("Any player may activate this ability")); this.addAbility(ability); }
Source:
<code>long retrieveStore( StoreFileStreams storeFileStreams, StoreId expectedStoreId ) throws StoreCopyFailedException { long latestTxNumber = storeCopyClient.copyStoreFiles( fromAddress, expectedStoreId, storeFileStreams ); try { storeFileStreams.close(); } catch ( Exception e ) { <START> throw new RuntimeException( e ); <END> } return latestTxNumber; }</code><technical_language>Exceptions.launderedException instead? This wrap RuntimeExceptions more time</technical_language>

Target:
long retrieveStore( StoreFileStreams storeFileStreams, StoreId expectedStoreId ) throws StoreCopyFailedException { long latestTxNumber = storeCopyClient.copyStoreFiles( fromAddress, expectedStoreId, storeFileStreams ); try { storeFileStreams.close(); } catch ( Exception e ) { throw Exceptions.launderedException(e); } return latestTxNumber; }
Source:
<code><START> static <R, T> KeyValue<R, T> create(R k, T v) { <END> return new KeyValue<R, T>(k, v); }</code><technical_language>Need public</technical_language>

Target:
public static <R, T> KeyValue<R, T> create(R k, T v) { return new KeyValue<R, T>(k, v); }
Source:
<code>private void checkFailedCoordinatorNode(SegmentationPolicy segPlc) throws Exception { try { this.segPlc = segPlc; IgniteEx coord = (IgniteEx)startGridsMultiThreaded(3); UUID coordId = coord.localNode().id(); IgniteEx ignite1 = grid(1); AtomicBoolean coordSegmented = new AtomicBoolean(); coord.events().localListen(evt -> { assertEquals(EVT_NODE_SEGMENTED, evt.type()); UUID nodeId = ((DiscoveryEvent)evt).eventNode().id(); if (coordId.equals(nodeId)) coordSegmented.set(true); return true; }, EVT_NODE_SEGMENTED); CountDownLatch failedLatch = new CountDownLatch(2); IgnitePredicate<Event> failLsnr = evt -> { assertEquals(EVT_NODE_FAILED, evt.type()); UUID nodeId = ((DiscoveryEvent)evt).eventNode().id(); if (coordId.equals(nodeId)) failedLatch.countDown(); return true; }; ignite1.events().localListen(failLsnr, EVT_NODE_FAILED); grid(2).events().localListen(failLsnr, EVT_NODE_FAILED); ignite1.configuration().getDiscoverySpi().failNode(coordId, null); <START> assertTrue(failedLatch.await(ignite1.configuration().getFailureDetectionTimeout() + 50, MILLISECONDS)); <END> assertTrue(coordSegmented.get()); if (segPlc == SegmentationPolicy.STOP) { assertTrue(coord.context().isStopping()); waitNodeStop(coord.name()); } else assertFalse(coord.context().isStopping()); assertEquals(2, ignite1.context().discovery().allNodes().size()); } finally { stopAllGrids(); } }</code><technical_language>magic number</technical_language>

Target:
private void checkFailedCoordinatorNode(SegmentationPolicy segPlc) throws Exception { try { this.segPlc = segPlc; IgniteEx coord = (IgniteEx)startGridsMultiThreaded(3); UUID coordId = coord.localNode().id(); IgniteEx ignite1 = grid(1); AtomicBoolean coordSegmented = new AtomicBoolean(); coord.events().localListen(evt -> { assertEquals(EVT_NODE_SEGMENTED, evt.type()); UUID nodeId = ((DiscoveryEvent)evt).eventNode().id(); if (coordId.equals(nodeId)) coordSegmented.set(true); return true; }, EVT_NODE_SEGMENTED); CountDownLatch failedLatch = new CountDownLatch(2); IgnitePredicate<Event> failLsnr = evt -> { assertEquals(EVT_NODE_FAILED, evt.type()); UUID nodeId = ((DiscoveryEvent)evt).eventNode().id(); if (coordId.equals(nodeId)) failedLatch.countDown(); return true; }; ignite1.events().localListen(failLsnr, EVT_NODE_FAILED); grid(2).events().localListen(failLsnr, EVT_NODE_FAILED); ignite1.configuration().getDiscoverySpi().failNode(coordId, null); assertTrue(failedLatch.await(2000, MILLISECONDS)); assertTrue(coordSegmented.get()); if (segPlc == SegmentationPolicy.STOP) { assertTrue(coord.context().isStopping()); waitNodeStop(coord.name()); } else assertFalse(coord.context().isStopping()); assertEquals(2, ignite1.context().discovery().allNodes().size()); } finally { stopAllGrids(); } }
Source:
<code>public JMSSettingsModifyEvent(SettingsInfo source, List<String> propertyNames, List<Object> oldValues, List<Object> newValues, JMSEventType eventType) { super(source, propertyNames, oldValues, newValues); <START> this.eventType = eventType; <END> }</code><technical_language>sense this for a class states "modified"</technical_language>

Target:
public JMSSettingsModifyEvent(SettingsInfo source, List<String> propertyNames, List<Object> oldValues, List<Object> newValues, JMSEventType eventType) { super(source, propertyNames, oldValues, newValues, eventType); }