auphong2707/dl4se-code-review-dataset huggingface dataset:
Source:
<code>private List<Tuple2<Integer, PrestoSparkRow>> doExecute(SubPlan root) { PlanFragment rootFragment = root.getFragment(); if (rootFragment.getPartitioning().equals(COORDINATOR_DISTRIBUTION)) { checkArgument(root.getChildren().size() == 1, "exactly one children fragment is expected"); PrestoSparkTaskDescriptor taskDescriptor = new PrestoSparkTaskDescriptor( session.toSessionRepresentation(), session.getIdentity().getExtraCredentials(), rootFragment, ImmutableList.of(), tableWriteInfo); SerializedPrestoSparkTaskDescriptor serializedTaskDescriptor = new SerializedPrestoSparkTaskDescriptor(sparkTaskDescriptorJsonCodec.toJsonBytes(taskDescriptor)); <START> SubPlan child = getOnlyElement(root.getChildren()); <END> JavaPairRDD<Integer, PrestoSparkRow> rdd = createRdd(child); List<Tuple2<Integer, PrestoSparkRow>> sparkDriverInput = rdd.collect(); return ImmutableList.copyOf(executorFactoryProvider.get().create( 0, 0, serializedTaskDescriptor, new PrestoSparkTaskInputs(ImmutableMap.of(child.getFragment().getId().toString(), sparkDriverInput.iterator())), taskStatsCollector)); } return createRdd(root).collect(); }</code><technical_language>root multiple children in some cases? -- e.g. push table write union: TableCommit | RemoteSource / \ Fragment1. Fragment2 TableWrite TableWrite need fix this in this PR. in mind :)</technical_language>

Target:
private List<Tuple2<Integer, PrestoSparkRow>> doExecute(SubPlan root) { List<Broadcast<?>> broadcastsToDestroy = new ArrayList<>(); PlanFragment rootFragment = root.getFragment(); if (rootFragment.getPartitioning().equals(COORDINATOR_DISTRIBUTION)) { PrestoSparkTaskDescriptor taskDescriptor = new PrestoSparkTaskDescriptor( session.toSessionRepresentation(), session.getIdentity().getExtraCredentials(), rootFragment, ImmutableList.of(), tableWriteInfo); SerializedPrestoSparkTaskDescriptor serializedTaskDescriptor = new SerializedPrestoSparkTaskDescriptor(sparkTaskDescriptorJsonCodec.toJsonBytes(taskDescriptor)); Map<PlanFragmentId, JavaPairRDD<Integer, PrestoSparkRow>> inputRdds = root.getChildren().stream() .collect(toImmutableMap(child -> child.getFragment().getId(), child -> createRdd(child, broadcastsToDestroy))); Map<String, Iterator<Tuple2<Integer, PrestoSparkRow>>> inputs = inputRdds.entrySet().stream() .collect(toImmutableMap(entry -> entry.getKey().toString(), entry -> entry.getValue().collect().iterator())); broadcastsToDestroy.forEach(Broadcast::destroy); return ImmutableList.copyOf(executorFactoryProvider.get().create( 0, 0, serializedTaskDescriptor, new PrestoSparkTaskInputs(inputs, ImmutableMap.of()), taskStatsCollector)); } List<Tuple2<Integer, PrestoSparkRow>> result = createRdd(root, broadcastsToDestroy).collect(); broadcastsToDestroy.forEach(Broadcast::destroy); return result; }
Source:
<code>private String timeToString(int time) { <START> String result = ""; <END> int days = time / 86400; if (days != 0) { time -= days * 3600; result += days; } int hours = time / 3600; if (days != 0 || hours != 0) { time -= hours * 3600; result += " " + hours; } int minutes = time / 60; if (days != 0 || hours != 0 || minutes != 0) { time -= minutes * 60; result += ":" + minutes; } int seconds = time; result += ":" + seconds; return result.trim(); }</code><technical_language>DateTimeFormatter do job well? this more straight instead of writing formatter</technical_language>

Target:
private String timeToString(int time) { String result = ""; int days = time / 86400; if (days != 0) { time -= days * 86400; result += days; } int hours = time / 3600; if (days != 0 || hours != 0) { time -= hours * 3600; result += String.format(" %02d", hours); } int minutes = time / 60; if (days != 0 || hours != 0 || minutes != 0) { time -= minutes * 60; result += String.format(":%02d", minutes); } int seconds = time; result += String.format(":%02d", seconds); return result.trim(); }
Source:
<code>protected void onCreate(Bundle savedInstanceState) { <START> if (savedInstanceState == null) { <END> selectedAddonId = savedInstanceState.getString(ADDONID, null); selectedAddonTitle = savedInstanceState.getString(ADDONTITLE, null); } super.onCreate(savedInstanceState); }</code><technical_language>oops !=</technical_language>

Target:
protected void onCreate(Bundle savedInstanceState) { if (savedInstanceState != null) { selectedAddonId = savedInstanceState.getString(ADDONID, null); selectedAddonTitle = savedInstanceState.getString(ADDONTITLE, null); } super.onCreate(savedInstanceState); }
Source:
<code>public void addFilter(ITmfFilterTreeNode filter) { ITmfFilterTreeNode root = fViewer.getInput(); <START> for (int i = 0; i < root.getChildrenCount(); i++) { <END> if (root.getChild(i).equals(filter)) { return; } } root.addChild(filter); fViewer.setInput(root); }</code><technical_language>iterate for-each (int i = 0, i < limit, i++). case here, a collection a faster implementation for Iterable get(i) (think of a LinkedList for instance)</technical_language>

Target:
public void addFilter(ITmfFilterTreeNode filter) { ITmfFilterTreeNode root = fViewer.getInput(); for (ITmfFilterTreeNode node : root.getChildren()) { if (node.equals(filter)) { return; } } root.addChild(filter); fViewer.setInput(root); }
Source:
<code><START> public static Object fromTaskClassConfig(Config config) { <END> String taskClassName = new TaskConfig(config).getTaskClass().getOrElse( new AbstractFunction0<String>() { @Override public String apply() { throw new ConfigException("There is no task class defined in the configuration. Failed to create a valid TaskFactory"); } }); log.info("Got task class name: {}", taskClassName); boolean isAsyncTaskClass; try { isAsyncTaskClass = AsyncStreamTask.class.isAssignableFrom(Class.forName(taskClassName)); } catch (Throwable t) { throw new ConfigException(String.format("Invalid configuration for AsyncStreamTask class: %s", taskClassName), t); } if (isAsyncTaskClass) { return new AsyncStreamTaskFactory() { @Override public AsyncStreamTask createInstance() { try { return (AsyncStreamTask) Class.forName(taskClassName).newInstance(); } catch (Throwable t) { log.error("Error loading AsyncStreamTask class: {}. error: {}", taskClassName, t); throw new SamzaException(String.format("Error loading AsyncStreamTask class: %s", taskClassName), t); } } }; } return new StreamTaskFactory() { @Override public StreamTask createInstance() { try { return (StreamTask) Class.forName(taskClassName).newInstance(); } catch (Throwable t) { log.error("Error loading StreamTask class: {}. error: {}", taskClassName, t); throw new SamzaException(String.format("Error loading StreamTask class: %s", taskClassName), t); } } }; }</code><technical_language>Wondering this needs a public method. Is createTaskFactory consistently</technical_language>

Target:
private static Object fromTaskClassConfig(Config config) { String taskClassName = new TaskConfig(config).getTaskClass().getOrElse( new AbstractFunction0<String>() { @Override public String apply() { throw new ConfigException("There is no task class defined in the configuration. Failed to create a valid TaskFactory"); } }); log.info("Got task class name: {}", taskClassName); boolean isAsyncTaskClass; try { isAsyncTaskClass = AsyncStreamTask.class.isAssignableFrom(Class.forName(taskClassName)); } catch (Throwable t) { throw new ConfigException(String.format("Invalid configuration for AsyncStreamTask class: %s", taskClassName), t); } if (isAsyncTaskClass) { return new AsyncStreamTaskFactory() { @Override public AsyncStreamTask createInstance() { try { return (AsyncStreamTask) Class.forName(taskClassName).newInstance(); } catch (Throwable t) { log.error("Error loading AsyncStreamTask class: {}. error: {}", taskClassName, t); throw new SamzaException(String.format("Error loading AsyncStreamTask class: %s", taskClassName), t); } } }; } return new StreamTaskFactory() { @Override public StreamTask createInstance() { try { return (StreamTask) Class.forName(taskClassName).newInstance(); } catch (Throwable t) { log.error("Error loading StreamTask class: {}. error: {}", taskClassName, t); throw new SamzaException(String.format("Error loading StreamTask class: %s", taskClassName), t); } } }; }
Source:
<code>private void presentShowcaseSequence() { ShowcaseConfig config = new ShowcaseConfig(); config.setDelay(4000); MaterialShowcaseSequence sequence = new MaterialShowcaseSequence(this, SHOWCASE_ID); sequence.setOnItemShownListener(new MaterialShowcaseSequence.OnSequenceItemShownListener() { @Override public void onShow(MaterialShowcaseView itemView, int position) { } }); sequence.setConfig(config); sequence.addSequenceItem(nav_home, getResources().getString(R.string.home_button), getResources().getString(R.string.ok_button)); sequence.addSequenceItem( new MaterialShowcaseView.Builder(this) .setTarget(nav_cam) .setDismissText(getResources().getString(R.string.ok_button)) .setContentText(getResources().getString(R.string.camera_button)) <START> .hideOnTouchOutside() <END> .build() ); sequence.addSequenceItem( new MaterialShowcaseView.Builder(this) .setTarget(nav_acc) .setDismissText(getResources().getString(R.string.ok_button)) .setContentText(getResources().getString(R.string.accounts_button)) .hideOnTouchOutside() .build() ); sequence.start(); }</code><technical_language>Try .setDismissOnTouch(true) instead</technical_language>

Target:
private void presentShowcaseSequence() { ShowcaseConfig config = new ShowcaseConfig(); config.setDelay(4000); MaterialShowcaseSequence sequence = new MaterialShowcaseSequence(this, SHOWCASE_ID); sequence.setOnItemShownListener(new MaterialShowcaseSequence.OnSequenceItemShownListener() { @Override public void onShow(MaterialShowcaseView itemView, int position) { } }); sequence.setConfig(config); sequence.addSequenceItem(nav_home, getResources().getString(R.string.home_button), getResources().getString(R.string.ok_button)); sequence.addSequenceItem( new MaterialShowcaseView.Builder(this) .setTarget(nav_cam) .setDismissText(getResources().getString(R.string.ok_button)) .setContentText(getResources().getString(R.string.camera_button)) .setDismissOnTouch(true) .build() ); sequence.addSequenceItem( new MaterialShowcaseView.Builder(this) .setTarget(nav_acc) .setDismissText(getResources().getString(R.string.ok_button)) .setContentText(getResources().getString(R.string.accounts_button)) .setDismissOnTouch(true) .build() ); sequence.start(); }
Source:
<code>public void testSingleRequestException() throws InterruptedException { TmfTrace trace = setupTrace(TEST_TRACE.getFullPath()); TmfEventRequest requestFail = new TmfEventRequestStub(ITmfEvent.class, TmfTimeRange.ETERNITY, 2, 0, ExecutionType.BACKGROUND, 0) { @Override public void handleData(@NonNull ITmfEvent data) { throw new IllegalArgumentException(); } }; trace.sendRequest(requestFail); requestFail.waitForCompletion(); assertTrue(requestFail.isCompleted()); assertFalse(requestFail.isCancelled()); assertTrue(requestFail.isFailed()); <START> trace.dispose(); <END> }</code><technical_language>in test cases trace is equals fTrace. need a new instance for test case</technical_language>

Target:
public void testSingleRequestException() throws InterruptedException { TmfTrace trace = fTrace; TmfEventRequest requestFail = new TmfEventRequestStub(ITmfEvent.class, TmfTimeRange.ETERNITY, 2, 0, ExecutionType.BACKGROUND, 0) { @Override public void handleData(@NonNull ITmfEvent data) { throw new IllegalArgumentException(); } }; trace.sendRequest(requestFail); requestFail.waitForCompletion(); assertTrue(requestFail.isCompleted()); assertFalse(requestFail.isCancelled()); assertTrue(requestFail.isFailed()); }
Source:
<code>public void notifyValueTransferFinished() { for (int i = 0; i < numSegments; ++i) { do { SegmentState state = segmentStates.get(i); switch (state) { case BLOCKED: case KEY_TRANSFER: blockedFutures.get(i).completeExceptionally(new CacheException("Failed to request versions")); log.warnf("Stopped applying state for segment %d in topology %d but the segment is in state %s", i, topologyId, state); case VALUE_TRANSFER: if (!segmentStates.compareAndSet(i, state, SegmentState.OWNED)) { <START> continue; END> } } } while (false); } synchronized (valuesLock) { valuesTopology = Math.max(topologyId, valuesTopology); transferingValues = false; valuesFuture.complete(null); valuesFuture = new CompletableFuture<>(); } log.debugf("Node %s received values for all segments in topology %d", rpcManager.getAddress(), topologyId); }</code><technical_language>achieve here</technical_language>

Target:
public void notifyValueTransferFinished() { for (int i = 0; i < numSegments; ++i) { LOOP: for (;;) { SegmentState state = segmentStates.get(i); switch (state) { case NOT_OWNED: case OWNED: break LOOP; case BLOCKED: case KEY_TRANSFER: blockedFutures.get(i).completeExceptionally(new CacheException("Failed to request versions")); log.warnf("Stopped applying state for segment %d in topology %d but the segment is in state %s", i, topologyId, state); case VALUE_TRANSFER: if (segmentStates.compareAndSet(i, state, SegmentState.OWNED)) { break LOOP; } } } } synchronized (valuesLock) { valuesTopology = Math.max(topologyId, valuesTopology); transferringValues = false; valuesFuture.complete(null); valuesFuture = new CompletableFuture<>(); } log.debugf("Node %s received values for all segments in topology %d", rpcManager.getAddress(), topologyId); }
Source:
<code>protected Promise<Expression> eval(BranchContext context, final TermFilter termFilter) { final String term = termFilter.getTerm(); return SnomedRequests.prepareSearchDescription() .all() <START> .filterByTerm(term) <END> .build(context.id(), context.branchPath()) .execute(context.service(IEventBus.class)) .then(descriptions -> { Set<String> ids = descriptions.stream() .map(SnomedDescription::getConceptId) .collect(Collectors.toSet()); return Expressions.builder().filter(SnomedConceptDocument.Expressions.ids(ids)).build(); }); }</code><technical_language>Add active filter return ID CONCEPT_ID fields</technical_language>

Target:
protected Promise<Expression> eval(BranchContext context, final TermFilter termFilter) { final String term = termFilter.getTerm(); return SnomedRequests.prepareSearchDescription() .all() .filterByActive(true) .filterByTerm(term) .setFields(SnomedDescriptionIndexEntry.Fields.ID, SnomedDescriptionIndexEntry.Fields.CONCEPT_ID) .build(context.id(), context.branchPath()) .execute(context.service(IEventBus.class)) .then(descriptions -> { Set<String> ids = descriptions.stream() .map(SnomedDescription::getConceptId) .collect(Collectors.toSet()); return Expressions.builder().filter(SnomedConceptDocument.Expressions.ids(ids)).build(); }); }
Source:
<code>public void testIndividualRead(byte[][] writtenBytes, byte[] expectedBytes) throws IOException { AppendableByteArrayInputStream in = new AppendableByteArrayInputStream(); for (byte[] writtenByte : writtenBytes) { in.add(writtenByte); } for (int i = 0; i < expectedBytes.length; i++) { final int readByte = in.read(); if (expectedBytes[i] != (byte) readByte) { <START> Assert.assertEquals(StringUtils.format("%s[%d", Arrays.toString(expectedBytes), i), expectedBytes[i], readByte); <END> } } }</code><technical_language>Missing ]</technical_language>

Target:
public void testIndividualRead(byte[][] writtenBytes, byte[] expectedBytes) throws IOException { AppendableByteArrayInputStream in = new AppendableByteArrayInputStream(); for (byte[] writtenByte : writtenBytes) { in.add(writtenByte); } for (int i = 0; i < expectedBytes.length; i++) { final int readByte = in.read(); if (expectedBytes[i] != (byte) readByte) { Assert.assertEquals(StringUtils.format("%s[%d]", Arrays.toString(expectedBytes), i), expectedBytes[i], readByte); } } }
Source:
<code><START> public void clearErrors() { <END> this.errors = Collections.emptyList(); }</code><technical_language>errors final, instead of attribute emptyList here, call List.clear() method</technical_language>

Target:
public void clearErrors() { this.errors.clear(); }
Source:
<code>public static <TYPE> Collection<ScanResult<TYPE>> scan(IOService ioService, Path rootPath, Collection<String> extensions, Function<InputStream, TYPE> converter) { <START> return scan(ioService, rootPath, extensions, converter, resouce -> true); <END> }</code><technical_language>Typo, resource -> true (you resouce)</technical_language>

Target:
public static <TYPE> Collection<ScanResult<TYPE>> scan(IOService ioService, Path rootPath, Collection<String> extensions, Function<InputStream, TYPE> converter) { return scan(ioService, rootPath, extensions, converter, resource -> true); }
Source:
<code>private void changeSelectedServerInJobs(String oldName) { for (Job job : PluginImpl.getConfiguredJobs_(oldName)) { if (!(job instanceof AbstractProject)) { <START> return; <END> } AbstractProject project = (AbstractProject)job; GerritTrigger trigger = (GerritTrigger)project.getTrigger(GerritTrigger.class); if (trigger != null) { try { trigger.setServerName(name); trigger.start(job, false); project.addTrigger(trigger); project.save(); } catch (IOException e) { logger.error("Error saving Gerrit Trigger configurations for job [" + job.getName() + "] after Gerrit server has been renamed from [" + oldName + "] to [" + name + "]"); } } } }</code><technical_language>happen if instance of WorkflowJob</technical_language>

Target:
private void changeSelectedServerInJobs(String oldName) { for (Job job : PluginImpl.getConfiguredJobs_(oldName)) { if (!(job instanceof AbstractProject)) { logger.warn("Unable to modify Gerrit Trigger configurations for job [" + job.getName() + "] after Gerrit server has been renamed from [" + oldName + "] to [" + name + "]." + " This feature is only supported for AbstractProject types e.g. Freestyle Jobs."); return; } AbstractProject project = (AbstractProject)job; GerritTrigger trigger = (GerritTrigger)project.getTrigger(GerritTrigger.class); if (trigger != null) { try { trigger.setServerName(name); trigger.start(job, false); project.addTrigger(trigger); project.save(); } catch (IOException e) { logger.error("Error saving Gerrit Trigger configurations for job [" + job.getName() + "] after Gerrit server has been renamed from [" + oldName + "] to [" + name + "]"); } } } }
Source:
<code>private Observable<Event> createEvents(final Controller controller) { final Observable<Event> events = Observable.create(subscriber -> { final EventQueue eventQueue = controller.getEventQueue(); while (!subscriber.isUnsubscribed()) { if (!controller.poll()) { subscriber.unsubscribe(); joystickSink.onNext(connect()); return; } final Event event = new Event(); if (!eventQueue.getNextEvent(event)) { continue; } subscriber.onNext(event); } }); <START> return events.subscribeOn(Schedulers.io()).share(); <END> }</code><technical_language>scheduler provided initializer of this object</technical_language>

Target:
private Observable<Event> createEvents(final Controller controller) { final Observable<Event> events = Observable.create(subscriber -> { final EventQueue eventQueue = controller.getEventQueue(); subscriber.add(Observable.interval(0, TimeUnit.MILLISECONDS, scheduler).subscribe(tick -> { if (controller.poll()) { final Event event = new Event(); if (eventQueue.getNextEvent(event)) { subscriber.onNext(event); } } else { subscriber.unsubscribe(); } })); }); return events.subscribeOn(scheduler).share(); }
Source:
<code>static LegacyLabelTypes getLegacyTypes(ReviewDb db) throws SQLException { List<LegacyLabelType> types = Lists.newArrayListWithCapacity(2); Statement catStmt = ((JdbcSchema) db).getConnection().createStatement(); try { ResultSet catRs = catStmt.executeQuery( "SELECT category_id, name, <START> abbreviated_name, function_name, <END> " + " copy_min_score" + " FROM approval_categories" + " ORDER BY position, name"); PreparedStatement valStmt = ((JdbcSchema) db).getConnection().prepareStatement( "SELECT value, name" + " FROM approval_category_values" + " WHERE category_id = ?"); try { while (catRs.next()) { String id = catRs.getString("category_id"); valStmt.setString(1, id); List<LabelValue> values = Lists.newArrayListWithCapacity(5); ResultSet valRs = valStmt.executeQuery(); while (valRs.next()) { values.add(new LabelValue( valRs.getShort("value"), valRs.getString("name"))); } LegacyLabelType type = new LegacyLabelType(getLabelName(catRs.getString("name")), values); type.setId(id); type.setFunctionName(catRs.getString("function_name")); type.setCopyMinScore("Y".equals(catRs.getString("copy_min_score"))); types.add(type); } } finally { valStmt.close(); } } finally { catStmt.close(); } return new LegacyLabelTypes(types); }</code><technical_language>This is unused</technical_language>

Target:
static LegacyLabelTypes getLegacyTypes(ReviewDb db) throws SQLException { List<LegacyLabelType> types = Lists.newArrayListWithCapacity(2); Statement catStmt = ((JdbcSchema) db).getConnection().createStatement(); try { ResultSet catRs = catStmt.executeQuery( "SELECT category_id, name, function_name, copy_min_score" + " FROM approval_categories" + " ORDER BY position, name"); PreparedStatement valStmt = ((JdbcSchema) db).getConnection().prepareStatement( "SELECT value, name" + " FROM approval_category_values" + " WHERE category_id = ?"); try { while (catRs.next()) { String id = catRs.getString("category_id"); valStmt.setString(1, id); List<LabelValue> values = Lists.newArrayListWithCapacity(5); ResultSet valRs = valStmt.executeQuery(); while (valRs.next()) { values.add(new LabelValue( valRs.getShort("value"), valRs.getString("name"))); } LegacyLabelType type = new LegacyLabelType(getLabelName(catRs.getString("name")), values); type.setId(id); type.setFunctionName(catRs.getString("function_name")); type.setCopyMinScore("Y".equals(catRs.getString("copy_min_score"))); types.add(type); } } finally { valStmt.close(); } } finally { catStmt.close(); } return new LegacyLabelTypes(types); }
Source:
<code>public List<ObserverConfiguration> getObserverConfiguration() { String[] observers = getRequiredProperty("observers").split(","); List<ObserverConfiguration> observersConfiguration = new ArrayList<ObserverConfiguration>(observers.length); for (String observer : observers) { String pipe = getRequiredProperty("observers." + observer + ".pipe"); Properties newProperties = new Properties(); newProperties.putAll(getProperties()); <START> newProperties.put("pipes." + pipe + ".source.work_dir", getWorkDir() + observer); <END> newProperties.put("pipes." + pipe + ".source.read_rotated_files", "false"); observersConfiguration.add(new ObserverConfigurationImpl(observer, new PipeConfigurationImpl(newProperties, pipe))); } return observersConfiguration; }</code><technical_language>needs some doc , need this</technical_language>

Target:
public List<ObserverConfiguration> getObserverConfiguration() { String[] observers = getRequiredProperty("observers").split(","); List<ObserverConfiguration> observersConfiguration = new ArrayList<ObserverConfiguration>(observers.length); for (String observer : observers) { String pipe = getRequiredProperty("observers." + observer + ".pipe"); Properties newProperties = new Properties(); newProperties.putAll(getProperties()); String daemonDir = newProperties.getProperty("daemon_dir"); if (daemonDir == null || daemonDir.equals("")) { newProperties.put("daemon_dir", "/var/run/file-drop-zone/state_dir"); } String authClientPath = newProperties.getProperty("pipes." + pipe + ".sink.auth_client_properties"); if (authClientPath == null || authClientPath.equals("")) { newProperties.put("pipes." + pipe + ".sink.auth_client_properties", "/etc/file-drop-zone/conf/auth-client.properties"); } newProperties.put("pipes." + pipe + ".source.work_dir", getWorkDir() + observer); newProperties.put("pipes." + pipe + ".source.read_rotated_files", "false"); observersConfiguration.add(new ObserverConfigurationImpl(observer, newProperties, pipe)); } return observersConfiguration; }
Source:
<code>public CliCommand init(final Arguments args) throws Exception { this.userId = args.getId(); if (this.userId == null) { throw new MissingOptionException("The alter policy command requires '-i' to be set with the username or Id"); } <START> this.metadata = args.getMetadata(); <END> if ((this.metadata == null) || (this.metadata.isEmpty())) { throw new MissingOptionException("The alter policy command requires '--metatdata' to be set with at least one key:value default_data_policy_id:a85aa599-7a58-4141-adbe-79bfd1d42e48,key2:value2"); } return this; }</code><technical_language>This --metadata parameter is for object metadata. a parameter like, --datapolicy-id that</technical_language>

Target:
public CliCommand init(final Arguments args) throws Exception { this.userId = args.getId(); if (Guard.isStringNullOrEmpty(this.userId)) { throw new MissingOptionException("The modify_user command requires '-i' to be set with the username or Id"); } this.modifyParams = args.getModifyParams(); if (Guard.isMapNullOrEmpty(this.modifyParams)) { throw new MissingOptionException("The modify_user command requires '--modify-params' to be set with at least one key:value default_data_policy_id:a85aa599-7a58-4141-adbe-79bfd1d42e48,key2:value2"); } return this; }
Source:
<code>public static String toAvroIdentifier(String candidate) { <START> char[] data = candidate.toCharArray(); <END> int stringIndex = 0; for (char c:data) { if (Character.isLetterOrDigit(c) || c == '_') { data[stringIndex++] = c; } } char initial = data[0]; if (Character.isLetter(initial) || initial == '_') { return new String(data, 0, stringIndex); } else { return "AVRO_".concat(new String(data, 0, stringIndex)); } }</code><technical_language>suggest create a private function replaceWhitespace move code logic there. String formattedCandidate = replaceWhitespace(candidate); string data a valid length, data[0] is valid</technical_language>

Target:
public static String toAvroIdentifier(String candidate) { char[] data = candidate.toCharArray(); boolean skip = false; int stringIndex = 0; for (char c:data) { if (Character.isLetterOrDigit(c) || c == '_') { data[stringIndex++] = c; skip = false; } else if(!skip) { data[stringIndex++] = '_'; skip = true; } } char initial = data[0]; if (Character.isLetter(initial) || initial == '_') { return new String(data, 0, stringIndex); } else { return "AVRO_".concat(new String(data, 0, stringIndex)); } }
Source:
<code>public void stop() { if (queuedRequestSender instanceof Stoppable) { ((Stoppable) queuedRequestSender).stop(); <START> } <END> }</code><technical_language>stop defaultRequestSender (if this is instance of Stoppable)</technical_language>

Target:
public void stop() { if (queuedRequestSender instanceof Stoppable) { ((Stoppable) queuedRequestSender).stop(); } if (defaultRequestSender instanceof Stoppable) { ((Stoppable) defaultRequestSender).stop(); } }
Source:
<code>public void pmHealthCheck() { if (!inWork) { synchronized (instance) { <START> List<VDS> hosts = DbFacade.getInstance().getVdsDao().getAll(); <END> for (VDS host : hosts) { if (host.getpm_enabled()) { boolean hasSecondary = (host.getPmSecondaryIp() != null && !host.getPmSecondaryIp().isEmpty()); boolean isConcurrent = host.isPmSecondaryConcurrent(); FenceExecutor executor = new FenceExecutor(host, FenceActionType.Status); if (executor.findProxyHost() && executor.fence(FenceAgentOrder.Primary).getSucceeded()) { removeAlarm(host.getId(), isConcurrent, AuditLogType.VDS_ALERT_PM_HEALTH_CHECK_FAILED_FOR_CON_PRIMARY_AGENT, AuditLogType.VDS_ALERT_PM_HEALTH_CHECK_FAILED_FOR_SEQ_PRIMARY_AGENT); if (hasSecondary) { if (executor.findProxyHost() && executor.fence(FenceAgentOrder.Secondary).getSucceeded()) { removeAlarm(host.getId(), isConcurrent, AuditLogType.VDS_ALERT_PM_HEALTH_CHECK_FAILED_FOR_CON_SECONDARY_AGENT, AuditLogType.VDS_ALERT_PM_HEALTH_CHECK_FAILED_FOR_SEQ_SECONDARY_AGENT); } else{ addAlarm(host.getId(), isConcurrent, AuditLogType.VDS_ALERT_PM_HEALTH_CHECK_FAILED_FOR_CON_SECONDARY_AGENT, AuditLogType.VDS_ALERT_PM_HEALTH_CHECK_FAILED_FOR_SEQ_SECONDARY_AGENT); } } } else { addAlarm(host.getId(), isConcurrent, AuditLogType.VDS_ALERT_PM_HEALTH_CHECK_FAILED_FOR_CON_PRIMARY_AGENT, AuditLogType.VDS_ALERT_PM_HEALTH_CHECK_FAILED_FOR_SEQ_PRIMARY_AGENT); } } } inWork=false; } } }</code><technical_language>"inWork=true" place here? Btw, Quartz mechanism overlap job execution: StatefullJob instead of Job achieve this</technical_language>

Target:
public void pmHealthCheck() { if (!inWork) { synchronized (instance) { log.info("Power Management Health Check started."); List<VDS> hosts = DbFacade.getInstance().getVdsDao().getAll(); for (VDS host : hosts) { if (host.getpm_enabled()) { boolean hasSecondary = (host.getPmSecondaryIp() != null && !host.getPmSecondaryIp().isEmpty()); boolean isConcurrent = host.isPmSecondaryConcurrent(); FenceExecutor executor = new FenceExecutor(host, FenceActionType.Status); if (executor.findProxyHost() && executor.fence(FenceAgentOrder.Primary).getSucceeded()) { removeAlarm(host.getId(), isConcurrent, AuditLogType.VDS_ALERT_PM_HEALTH_CHECK_FAILED_FOR_CON_PRIMARY_AGENT, AuditLogType.VDS_ALERT_PM_HEALTH_CHECK_FAILED_FOR_SEQ_PRIMARY_AGENT); if (hasSecondary) { if (executor.findProxyHost() && executor.fence(FenceAgentOrder.Secondary).getSucceeded()) { removeAlarm(host.getId(), isConcurrent, AuditLogType.VDS_ALERT_PM_HEALTH_CHECK_FAILED_FOR_CON_SECONDARY_AGENT, AuditLogType.VDS_ALERT_PM_HEALTH_CHECK_FAILED_FOR_SEQ_SECONDARY_AGENT); } else{ addAlarm(host.getId(), isConcurrent, AuditLogType.VDS_ALERT_PM_HEALTH_CHECK_FAILED_FOR_CON_SECONDARY_AGENT, AuditLogType.VDS_ALERT_PM_HEALTH_CHECK_FAILED_FOR_SEQ_SECONDARY_AGENT); } } } else { addAlarm(host.getId(), isConcurrent, AuditLogType.VDS_ALERT_PM_HEALTH_CHECK_FAILED_FOR_CON_PRIMARY_AGENT, AuditLogType.VDS_ALERT_PM_HEALTH_CHECK_FAILED_FOR_SEQ_PRIMARY_AGENT); } } } log.info("Power Management Health Check completed."); inWork=false; } } }
Source:
<code>public void updatePipeline(PipelineConfig pipelineConfig, LocalizedOperationResult result, Username currentUser, PipelineConfigService.SaveCommand saveCommand) { synchronized (goConfigWriteLock.mutex()) { <START> if (saveCommand.hasWritePermissions()) { <END> try { cachedConfigService.writePipelineWithLock(pipelineConfig, saveCommand, currentUser); } catch (ConfigUpdateCheckFailedException e) { result.unprocessableEntity(LocalizedMessage.string("PIPELINE_CONFIG_VALIDATION_FAILED", pipelineConfig.name())); } } } }</code><technical_language>aside, this if clause else? add some logging, in updateConfig. wait get this lock. Again, related this issue, I know</technical_language>

Target:
public void updatePipeline(PipelineConfig pipelineConfig, LocalizedOperationResult result, Username currentUser, PipelineConfigService.SaveCommand saveCommand) { synchronized (GoConfigWriteLock.class) { if (saveCommand.hasWritePermissions()) { try { cachedConfigService.writePipelineWithLock(pipelineConfig, saveCommand, currentUser); } catch (ConfigUpdateCheckFailedException e) { result.unprocessableEntity(LocalizedMessage.string("PIPELINE_CONFIG_VALIDATION_FAILED", pipelineConfig.name())); } } } }
Source:
<code>public Block split(@TypeParameter("map<varchar,varchar>") Type mapType, @SqlType(StandardTypes.VARCHAR) Slice string, @SqlType(StandardTypes.VARCHAR) Slice entryDelimiter, @SqlType(StandardTypes.VARCHAR) Slice keyValueDelimiter) { <START> return splitToMap(pageBuilder, mapType, string, entryDelimiter, keyValueDelimiter, null); <END> }</code><technical_language>Optional instead of null here</technical_language>

Target:
public Block split( @TypeParameter("map<varchar,varchar>") Type mapType, @SqlType(StandardTypes.VARCHAR) Slice string, @SqlType(StandardTypes.VARCHAR) Slice entryDelimiter, @SqlType(StandardTypes.VARCHAR) Slice keyValueDelimiter) { return splitToMap(pageBuilder, mapType, string, entryDelimiter, keyValueDelimiter, Optional.empty()); }
Source:
<code><START> public CompletableFuture<AsyncConnection> createAsyncConnection() throws IOException { <END> Configuration clientConfig = HBaseConfiguration.create(); String[] keys = new String[]{ "hbase.zookeeper.quorum", "hbase.zookeeper.property.clientPort" }; for (String key : keys) { clientConfig.set(key, helper.getConfiguration().get(key)); } return ConnectionFactory.createAsyncConnection(clientConfig); }</code><technical_language>return AsyncConnection here</technical_language>

Target:
public AsyncConnection createAsyncConnection() throws Exception { Configuration clientConfig = HBaseConfiguration.create(); String[] keys = new String[]{ "hbase.zookeeper.quorum", "hbase.zookeeper.property.clientPort" }; for (String key : keys) { clientConfig.set(key, helper.getConfiguration().get(key)); } return ConnectionFactory.createAsyncConnection(clientConfig).get(); }
Source:
<code>@Override public void expand(EnvVars env) throws IOException, InterruptedException { for (Map.Entry<String,Secret> override : overrides.entrySet()) { <START> String keyOverride = override.getKey(); env.override(keyOverride, override.getValue().getPlainText()); sensitiveVariables.add(keyOverride); <END> } }</code><technical_language>suggestion env.override(override.getKey(), override.getValue().getPlainText());</technical_language>

Target:
@Override public void expand(EnvVars env) throws IOException, InterruptedException { for (Map.Entry<String,Secret> override : overrides.entrySet()) { env.override(override.getKey(), override.getValue().getPlainText()); } }
Source:
<code>private void updateBackup() { <START> if (getCurrentStorageItem() != null && getAvailableStorageTypeItems().getSelectedItem() != null) { boolean isStorageDomainUnattached = getDataCenter().getSelectedItem().getId().equals(Guid.Empty); if (isStorageDomainUnattached) { getBackup().setIsAvailable(false); getBackup().setEntity(false); return; } if (getCurrentStorageItem().getRole() == StorageDomainType.ISO || getCurrentStorageItem().getRole() == StorageDomainType.ImportExport) { getBackup().setIsAvailable(false); getBackup().setEntity(false); return; } else { boolean backupSupported = (Boolean) AsyncDataProvider.getInstance().getConfigValuePreConverted( ConfigValues.BackupSupported, getDataCenter().getSelectedItem().getCompatibilityVersion().toString()); getBackup().setIsAvailable(backupSupported); getBackup().setEntity(isNewStorage() ? false : getStorage().isBackup()); return; } } getBackup().setIsAvailable(false); getBackup().setEntity(false); <END> return; }</code><technical_language>If option enabled a DC, check 'none' DC is supported (StorageModel -> UnassignedDataCenterId)</technical_language>

Target:
private void updateBackup() { if (getCurrentStorageItem() != null && getAvailableStorageTypeItems().getSelectedItem() != null) { boolean isStorageDomainUnattached = getDataCenter().getSelectedItem().getId().equals(UnassignedDataCenterId); if (isStorageDomainUnattached) { if (getCurrentStorageItem().getRole().isDataDomain()) { getBackup().setIsAvailable(true); getBackup().setEntity(isNewStorage() ? false : getStorage().isBackup()); return; } else { getBackup().setIsAvailable(false); getBackup().setEntity(false); return; } } if (getCurrentStorageItem().getRole() == StorageDomainType.ISO || getCurrentStorageItem().getRole() == StorageDomainType.ImportExport) { getBackup().setIsAvailable(false); getBackup().setEntity(false); return; } else { boolean backupSupported = (Boolean) AsyncDataProvider.getInstance().getConfigValuePreConverted( ConfigValues.BackupSupported, getDataCenter().getSelectedItem().getCompatibilityVersion().toString()); getBackup().setIsAvailable(backupSupported); getBackup().setEntity(isNewStorage() ? false : getStorage().isBackup()); return; } } getBackup().setIsAvailable(false); getBackup().setEntity(false); return; }
Source:
<code>public boolean isSkipWorkTree() { <START> return (getExtendedFlags() & SKIP_WORKTREE) == SKIP_WORKTREE; <END> }</code><technical_language>bit is set not, != 0 is a faster test here</technical_language>

Target:
public boolean isSkipWorkTree() { return (getExtendedFlags() & SKIP_WORKTREE) != 0; }
Source:
<code>public static MergePolicy fromConfiguration(EntryMergePolicy policy) { if (policy == null) return NONE; for (MergePolicy mp : MergePolicy.values()) <START> if (mp.impl != null && Objects.equals(mp.impl.getClass(), policy.getClass())) <END> return mp; return CUSTOM; }</code><technical_language>If enum implemented EntryMergePolicy directly, find configured mp == policy</technical_language>

Target:
public static MergePolicy fromConfiguration(EntryMergePolicy policy) { if (policy == null) return NONE; for (MergePolicy mp : MergePolicy.values()) if (mp == policy) return mp; return CUSTOM; }
Source:
<code>private <T> Mono<CosmosAsyncItemResponse<T>> createItemInternal(T item, CosmosItemRequestOptions options, Context context) { <START> String spanName = "createItem." + this.getId(); <END> Mono<CosmosAsyncItemResponse<T>> responseMono = createItemInternal(item, options); return database.getClient().getTracerProvider().traceEnabledCosmosItemResponsePublisher(responseMono, context , spanName, database.getId(), database.getClient().getServiceEndpoint()); }</code><technical_language>id is id of container. means in scope of this container "createItem." + this.getId() pre-computed for container, re-computing time. pre-compute this in container level</technical_language>

Target:
private <T> Mono<CosmosItemResponse<T>> createItemInternal(T item, CosmosItemRequestOptions options, Context context) { Mono<CosmosItemResponse<T>> responseMono = createItemInternal(item, options); return database.getClient().getTracerProvider().traceEnabledCosmosItemResponsePublisher(responseMono, context, this.createItemSpanName, database.getId(), database.getClient().getServiceEndpoint()); }
Source:
<code>public void testParseIntMinM1() throws EvaluationException { PARSE_INTEGER.evaluate(s(Long.toString((long) Integer.MIN_VALUE - 1))); <START> fail("parse_Integer(Long.toString((long) Integer.MIN_VALUE - 1)) did not throw"); <END> }</code><technical_language>fail required anymore</technical_language>

Target:
public void testParseIntMinM1() throws EvaluationException { PARSE_INTEGER.evaluate(s(Long.toString((long) Integer.MIN_VALUE - 1))); }
Source:
<code>private List<DiskImage> getDisksList() { if (selectedDisks == null) { selectedDisks = new ArrayList<DiskImage>(); <START> List<DiskImage> vmDisksNotShared = new ArrayList<DiskImage>(); <END> List<DiskImage> allVmDisks = DbFacade.getInstance().getDiskImageDAO().getAllForVm(getVmId()); for (DiskImage vmDisk : allVmDisks) { if (!vmDisk.isShareable()) { if (getParameters().getDisksList().contains(Integer.toString(vmDisk.getInternalDriveMapping()))) { selectedDisks.add(vmDisk); } vmDisksNotShared.add(vmDisk); } } selectedDisks = (selectedDisks.size() > 0) ? selectedDisks : vmDisksNotShared; } return selectedDisks; }</code><technical_language>shareable</technical_language>

Target:
private List<DiskImage> getDisksList() { if (selectedDisks == null) { selectedDisks = new ArrayList<DiskImage>(); List<DiskImage> vmDisksNotShareable = new ArrayList<DiskImage>(); List<DiskImage> allVmDisks = DbFacade.getInstance().getDiskImageDAO().getAllForVm(getVmId()); for (DiskImage vmDisk : allVmDisks) { if (!vmDisk.isShareable()) { if (getParameters().getDisksList().contains(Integer.toString(vmDisk.getInternalDriveMapping()))) { selectedDisks.add(vmDisk); } vmDisksNotShareable.add(vmDisk); } } selectedDisks = (selectedDisks.size() > 0) ? selectedDisks : vmDisksNotShareable; } return selectedDisks; }
Source:
<code>private static ManifestElement[] getGenericRequires(Dictionary<String, String> manifest, String[][] genericAliases) throws BundleException { ManifestElement[] genericRequires = ManifestElement.parseHeader(GENERIC_REQUIRE, manifest.get(GENERIC_REQUIRE)); List<ManifestElement> aliasList = null; if (genericAliases.length > 0) { aliasList = new ArrayList<>(genericRequires == null ? 0 : genericRequires.length); for (String[] <START> genericAliase : <END> genericAliases) { ManifestElement[] aliasReqs = ManifestElement.parseHeader(genericAliase[1], manifest.get(genericAliase[1])); if (aliasReqs == null) continue; for (ManifestElement aliasReq : aliasReqs) { StringBuffer strBuf = new StringBuffer(); strBuf.append(aliasReq.getValue()).append(':').append(genericAliase[2]); String filter = aliasReq.getAttribute(Constants.SELECTION_FILTER_ATTRIBUTE); if (filter != null) strBuf.append("; ").append(Constants.SELECTION_FILTER_ATTRIBUTE).append(filter).append("=\"").append(filter).append("\""); ManifestElement[] withType = ManifestElement.parseHeader(genericAliase[1], strBuf.toString()); aliasList.add(withType[0]); } } } if (aliasList == null || aliasList.size() == 0) return genericRequires; if (genericRequires != null) for (ManifestElement genericRequire : genericRequires) { aliasList.add(genericRequire); } return aliasList.toArray(new ManifestElement[aliasList.size()]); }</code><technical_language>name genericAlias</technical_language>

Target:
private static ManifestElement[] getGenericRequires(Dictionary<String, String> manifest, String[][] genericAliases) throws BundleException { ManifestElement[] genericRequires = ManifestElement.parseHeader(GENERIC_REQUIRE, manifest.get(GENERIC_REQUIRE)); List<ManifestElement> aliasList = null; if (genericAliases.length > 0) { aliasList = new ArrayList<>(genericRequires == null ? 0 : genericRequires.length); for (String[] genericAlias : genericAliases) { ManifestElement[] aliasReqs = ManifestElement.parseHeader(genericAlias[1], manifest.get(genericAlias[1])); if (aliasReqs == null) continue; for (ManifestElement aliasReq : aliasReqs) { StringBuffer strBuf = new StringBuffer(); strBuf.append(aliasReq.getValue()).append(':').append(genericAlias[2]); String filter = aliasReq.getAttribute(Constants.SELECTION_FILTER_ATTRIBUTE); if (filter != null) strBuf.append("; ").append(Constants.SELECTION_FILTER_ATTRIBUTE).append(filter).append("=\"").append(filter).append("\""); ManifestElement[] withType = ManifestElement.parseHeader(genericAlias[1], strBuf.toString()); aliasList.add(withType[0]); } } } if (aliasList == null || aliasList.size() == 0) return genericRequires; if (genericRequires != null) for (ManifestElement genericRequire : genericRequires) { aliasList.add(genericRequire); } return aliasList.toArray(new ManifestElement[aliasList.size()]); }
Source:
<code>public void testSelectDistinct() throws Exception { String selectStatement = db.createQuery() .from(User.TBL) .select(User.TBL.getAllColumns()) .getQueryStatement(); String selectDistinctStatement = db.createQuery() .from(User.TBL) <START> .selectDistinct(User.TBL.getAllColumns()) <END> .getQueryStatement(); assertFalse(selectStatement.contains("SELECT DISTINCT")); assertTrue(selectDistinctStatement.contains("SELECT DISTINCT")); }</code><technical_language>current syntax support multiple select method calls. new method, is write code: java .select(col1, col2) .selectDistinct(col3) This is if col1 col2 non-distinct, while col3 is distinct, is kind of confusing. a plain selectDistinct method takes argument? this method is called, flips this.selectDistinct variable: java .select(col1, col2) .select(col3) .selectDistinct()</technical_language>

Target:
public void testSelectDistinct() throws Exception { String selectStatement = db.createQuery() .from(User.TBL) .select(User.TBL.getAllColumns()) .getQueryStatement(); String selectDistinctStatement = db.createQuery() .from(User.TBL) .select(User.TBL.getAllColumns()).distinct() .getQueryStatement(); assertFalse(selectStatement.contains("SELECT DISTINCT")); assertTrue(selectDistinctStatement.contains("SELECT DISTINCT")); }
Source:
<code><START> static <T> Future<T> ofCallable(ExecutorService executorService, Callable<? extends T> computation) { <END> return of(executorService, computation::call); }</code><technical_language>Please add a java Objects.requireNonNull(computation, "computation is null");</technical_language>

Target:
static <T> Future<T> ofCallable(ExecutorService executorService, Callable<? extends T> computation) { Objects.requireNonNull(computation, "computation is null"); return of(executorService, computation::call); }
Source:
<code>public CodeWriter indent() { <START> for (int i = 0; i < indentationFactor; i++) indent += ' '; <END> return this; }</code><technical_language>missing braces of for statement</technical_language>

Target:
public CodeWriter indent() { for (int i = 0; i < indentationFactor; i++) { indent += ' '; } return this; }
Source:
<code><START> public void supportsPreciseLocation() { <END> assertThat(launcher.hasPreciseIssueLocation("5.2.9")).isFalse(); assertThat(launcher.hasPreciseIssueLocation("5.2")).isFalse(); assertThat(launcher.hasPreciseIssueLocation("5.")).isFalse(); assertThat(launcher.hasPreciseIssueLocation(null)).isFalse(); assertThat(launcher.hasPreciseIssueLocation("4.5")).isFalse(); assertThat(launcher.hasPreciseIssueLocation("6")).isFalse(); assertThat(launcher.hasPreciseIssueLocation("e6.0")).isFalse(); assertThat(launcher.hasPreciseIssueLocation("5.3")).isTrue(); assertThat(launcher.hasPreciseIssueLocation("5.10.1")).isTrue(); assertThat(launcher.hasPreciseIssueLocation("5.3.1")).isTrue(); assertThat(launcher.hasPreciseIssueLocation("6.0")).isTrue(); assertThat(launcher.hasPreciseIssueLocation("5.3")).isTrue(); }</code><technical_language>works versions 5.3-SNAPSHOT 5.3-RC1</technical_language>

Target:
public void supportsPreciseLocation() { assertThat(launcher.hasPreciseIssueLocation("5.2.9")).isFalse(); assertThat(launcher.hasPreciseIssueLocation("5.2")).isFalse(); assertThat(launcher.hasPreciseIssueLocation("5.")).isFalse(); assertThat(launcher.hasPreciseIssueLocation(null)).isFalse(); assertThat(launcher.hasPreciseIssueLocation("4.5")).isFalse(); assertThat(launcher.hasPreciseIssueLocation("4.5-SNAPSHOT")).isFalse(); assertThat(launcher.hasPreciseIssueLocation("4-RC1")).isFalse(); assertThat(launcher.hasPreciseIssueLocation("6")).isFalse(); assertThat(launcher.hasPreciseIssueLocation("e6.0")).isFalse(); assertThat(launcher.hasPreciseIssueLocation("5.3")).isTrue(); assertThat(launcher.hasPreciseIssueLocation("5.10.1")).isTrue(); assertThat(launcher.hasPreciseIssueLocation("5.3.1")).isTrue(); assertThat(launcher.hasPreciseIssueLocation("6.0")).isTrue(); assertThat(launcher.hasPreciseIssueLocation("5.3-SNAPSHOT")).isTrue(); assertThat(launcher.hasPreciseIssueLocation("5.3-RC1")).isTrue(); }
Source:
<code>private boolean processRemoteNotification(Bundle msg) { if (isSwrveRemoteNotification(msg)) { Iterator<SwrveQAUser> iter = SwrveQAUser.getBindedListeners().iterator(); while (iter.hasNext()) { SwrveQAUser sdkListener = iter.next(); sdkListener.pushNotification(msg); } swrveGcmService.processNotification(msg); } <START> } <END></code><technical_language>Is this WIP? a return type.....</technical_language>

Target:
private boolean processRemoteNotification(Bundle msg) { if (isSwrveRemoteNotification(msg)) { Iterator<SwrveQAUser> iter = SwrveQAUser.getBindedListeners().iterator(); while (iter.hasNext()) { SwrveQAUser sdkListener = iter.next(); sdkListener.pushNotification(msg); } swrveGcmService.processNotification(msg); return true; } return false; }