auphong2707/dl4se-code-review-dataset huggingface dataset:
Source:
<code>public AbstractSegmentStoreDensityViewer(Composite parent) { super(parent); fListeners = new ArrayList<>(); fChart = new Chart(parent, SWT.NONE); fChart.getLegend().setVisible(false); fChart.getTitle().setVisible(false); fChart.getAxisSet().getXAxis(0).getTitle().setText(nullToEmptyString(Messages.AbstractSegmentStoreDensityViewer_TimeAxisLabel)); fChart.getAxisSet().getYAxis(0).getTitle().setText(nullToEmptyString(Messages.AbstractSegmentStoreDensityViewer_CountAxisLabel)); fChart.getAxisSet().getXAxis(0).getGrid().setStyle(LineStyle.DOT); fChart.getAxisSet().getYAxis(0).getGrid().setStyle(LineStyle.DOT); fDragZoomProvider = new MouseDragZoomProvider(this); fDragZoomProvider.register(); fDragProvider = new MouseSelectionProvider(this); fDragProvider.register(); fTooltipProvider = new SimpleTooltipProvider(this); fTooltipProvider.register(); <START> fChart.addDisposeListener(new DisposeListener() { <END> @Override public void widgetDisposed(@Nullable DisposeEvent e) { internalDispose(); } }); }</code><technical_language>lambda</technical_language>

Target:
public AbstractSegmentStoreDensityViewer(Composite parent) { super(parent); fListeners = new ArrayList<>(); fChart = new Chart(parent, SWT.NONE); fChart.getLegend().setVisible(false); fChart.getTitle().setVisible(false); fChart.getAxisSet().getXAxis(0).getTitle().setText(nullToEmptyString(Messages.AbstractSegmentStoreDensityViewer_TimeAxisLabel)); fChart.getAxisSet().getYAxis(0).getTitle().setText(nullToEmptyString(Messages.AbstractSegmentStoreDensityViewer_CountAxisLabel)); fChart.getAxisSet().getXAxis(0).getGrid().setStyle(LineStyle.DOT); fChart.getAxisSet().getYAxis(0).getGrid().setStyle(LineStyle.DOT); fDragZoomProvider = new MouseDragZoomProvider(this); fDragZoomProvider.register(); fDragProvider = new MouseSelectionProvider(this); fDragProvider.register(); fTooltipProvider = new SimpleTooltipProvider(this); fTooltipProvider.register(); fChart.addDisposeListener((e) -> { internalDispose(); }); }
Source:
<code>public RecordWriter getRecordWriter(TaskAttemptContext taskAttemptContext) throws IOException, InterruptedException { Configuration conf = taskAttemptContext.getConfiguration(); try { return new FileCopyRecordWriter(conf); <START> } catch (Exception e) { <END> throw new IOException(e.getMessage()); } }</code><technical_language>need this try catch if FileCopyRecordWriter throws IOException</technical_language>

Target:
public RecordWriter getRecordWriter(TaskAttemptContext taskAttemptContext) throws IOException, InterruptedException { Configuration conf = taskAttemptContext.getConfiguration(); return new FileCopyRecordWriter(conf); }
Source:
<code>public static boolean hasOverlap(ReaderPostList posts, ReaderTag tag) { for (ReaderPost post : posts) { <START> if (ReaderPostTable.postExistsForReaderTag(post.blogId, post.postId, tag)) { <END> return true; } } return false; }</code><technical_language>suggestion if (postExistsForReaderTag(post.blogId, post.postId, tag)) { remove ReaderPostTable. prefix for this method call. If prefer for clarity, know</technical_language>

Target:
public static boolean hasOverlap(ReaderPostList posts, ReaderTag tag) { for (ReaderPost post : posts) { if (postExistsForReaderTag(post.blogId, post.postId, tag)) { return true; } } return false; }
Source:
<code>public static String submitPlan(HttpClient client, URI baseUri, String plan) { <START> URI uri = URI.create(Urls.mergePaths(baseUri.toString(), "/v1/applications")); <END> HttpToolResponse result = null; byte[] content; try { result = HttpTool.httpPost(client, uri, MutableMap.of(com.google.common.net.HttpHeaders.CONTENT_TYPE, "application/yaml"), plan.getBytes()); content = result.getContent(); } catch (Exception e) { Exceptions.propagateIfFatal(e); throw new IllegalStateException("Invalid response invoking "+uri+": "+e, e); } Tasks.addTagDynamically(BrooklynTaskTags.tagForStream("http_response", Streams.byteArray(content))); if (!isStatusCodeHealthy(result.getResponseCode())) { log.warn("Invalid response invoking "+uri+": response code "+result.getResponseCode()+"\n"+result+": "+new String(content)); throw new IllegalStateException("Invalid response invoking "+uri+": response code "+result.getResponseCode() ); } return (String)new Gson().fromJson(new String(content), Map.class).get("entityId"); }</code><technical_language>Longer term... I if BrooklynNode moved module, instead of software/base. depend brooklyn-rest-client directly. Longer term, I expect add more more of rest calls this entity. entity get involved in managing high-availability of management-nodes in a management-plane</technical_language>

Target:
public static String submitPlan(HttpClient client, URI baseUri, String plan) { URI uri = URI.create(Urls.mergePaths(baseUri.toString(), "/v1/applications")); HttpToolResponse result = null; byte[] content; try { result = HttpTool.httpPost(client, uri, MutableMap.of(com.google.common.net.HttpHeaders.CONTENT_TYPE, "application/yaml"), plan.getBytes()); content = result.getContent(); } catch (Exception e) { Exceptions.propagateIfFatal(e); throw new IllegalStateException("Invalid response invoking "+uri+": "+e, e); } Tasks.addTagDynamically(BrooklynTaskTags.tagForStream("http_response", Streams.byteArray(content))); if (!HttpTool.isStatusCodeHealthy(result.getResponseCode())) { log.warn("Invalid response invoking "+uri+": response code "+result.getResponseCode()+"\n"+result+": "+new String(content)); throw new IllegalStateException("Invalid response invoking "+uri+": response code "+result.getResponseCode()); } return (String)new Gson().fromJson(new String(content), Map.class).get("entityId"); }
Source:
<code>public static void createTable(SQLiteDatabase db) { if (db != null) { db.execSQL(SiteSettingsModel.CREATE_SETTINGS_TABLE_SQL); <START> db.execSQL(JetpackSettingsModel.CREATE_JP_SETTINGS_TABLE_SQL); <END> db.execSQL(CREATE_CATEGORIES_TABLE_SQL); } }</code><technical_language>specific reason handling 2 tables in a single file? This throw some people. Also, if making separation, do in FluxC? I thought this much, I asking suggesting :)</technical_language>

Target:
public static void createTable(SQLiteDatabase db) { if (db != null) { db.execSQL(SiteSettingsModel.CREATE_SETTINGS_TABLE_SQL); db.execSQL(CREATE_JP_SETTINGS_TABLE_SQL); db.execSQL(CREATE_CATEGORIES_TABLE_SQL); } }
Source:
<code>public AbstractRepeatingRunnable(long initialDelay, long period, @NonNull TimeUnit unit, boolean startImmediately) { if(!startImmediately) { <START> throw new UnsupportedOperationException("RepeatingRunnables are immediatly excecuted!"); <END> } ScheduledExecutorService threadExcecutor = Executors.newScheduledThreadPool(0); handle = threadExcecutor.scheduleAtFixedRate(this, initialDelay, period, unit); }</code><technical_language>typo for immediately</technical_language>

Target:
public AbstractRepeatingRunnable(long initialDelay, long period, @NonNull TimeUnit unit, boolean startImmediately) { if(!startImmediately) { throw new UnsupportedOperationException("RepeatingRunnables are immediately executed!"); } ScheduledExecutorService threadExcecutor = Executors.newScheduledThreadPool(0); handle = threadExcecutor.scheduleAtFixedRate(this, initialDelay, period, unit); }
Source:
<code>private Channel acquireUploadChannel() throws InterruptedException { Promise<Channel> channelReady = eventLoop.next().newPromise(); channelPool .acquire() .addListener( (Future<Channel> channelAcquired) -> { if (!channelAcquired.isSuccess()) { channelReady.setFailure(channelAcquired.cause()); return; } try { Channel ch = channelAcquired.getNow(); ChannelPipeline p = ch.pipeline(); if (!isChannelPipelineEmpty(p)) { channelReady.setFailure( new IllegalStateException("Channel pipeline is not empty.")); return; } p.addLast(new HttpResponseDecoder()); p.addLast(new HttpObjectAggregator(10 * 1024)); p.addLast(new HttpRequestEncoder()); p.addLast(new ChunkedWriteHandler()); <START> p.addFirst("read-timeout-handler", new ReadTimeoutHandler(timeoutSeconds)); <END> p.addFirst("write-timeout-handler", new WriteTimeoutHandler(timeoutSeconds)); synchronized (credentialsLock) { p.addLast(new HttpUploadHandler(creds)); } if (!ch.eventLoop().inEventLoop()) { ch.eventLoop().execute(() -> channelReady.setSuccess(ch)); } else { channelReady.setSuccess(ch); } } catch (Throwable t) { channelReady.setFailure(t); } }); try { return channelReady.get(); } catch (ExecutionException e) { PlatformDependent.throwException(e.getCause()); return null; } }</code><technical_language>semantics of ReadTimeoutHandler puts a total limit of timeoutSeconds upload trigger received data for timeoutSeconds. I this is want here, do want timeouts progressive (i.e. timeout if bytes written for N seconds.)</technical_language>

Target:
private Channel acquireUploadChannel() throws InterruptedException { Promise<Channel> channelReady = eventLoop.next().newPromise(); channelPool .acquire() .addListener( (Future<Channel> channelAcquired) -> { if (!channelAcquired.isSuccess()) { channelReady.setFailure(channelAcquired.cause()); return; } try { Channel ch = channelAcquired.getNow(); ChannelPipeline p = ch.pipeline(); if (!isChannelPipelineEmpty(p)) { channelReady.setFailure( new IllegalStateException("Channel pipeline is not empty.")); return; } p.addFirst( "timeout-handler", new IdleTimeoutHandler(timeoutSeconds, WriteTimeoutException.INSTANCE)); p.addLast(new HttpResponseDecoder()); p.addLast(new HttpObjectAggregator(10 * 1024)); p.addLast(new HttpRequestEncoder()); p.addLast(new ChunkedWriteHandler()); synchronized (credentialsLock) { p.addLast(new HttpUploadHandler(creds)); } if (!ch.eventLoop().inEventLoop()) { ch.eventLoop().execute(() -> channelReady.setSuccess(ch)); } else { channelReady.setSuccess(ch); } } catch (Throwable t) { channelReady.setFailure(t); } }); try { return channelReady.get(); } catch (ExecutionException e) { PlatformDependent.throwException(e.getCause()); return null; } }
Source:
<code>public void close() { <START> directReader.close(); <END> dictionaryReader.close(); }</code><technical_language>Currently close throw, code future proof guava Closer readers get closed</technical_language>

Target:
public void close() { try (Closer closer = Closer.create()) { closer.register(() -> directReader.close()); closer.register(() -> dictionaryReader.close()); } catch (IOException e) { throw new UncheckedIOException(e); } }
Source:
<code>public void verifyGettingLatencyRecordsIsCheapWhenDisabled() throws Exception { final double maxLatencyWhenDisabledMs = 1; final double minLatencyWhenDisabledMs = 0; final long numTasks = 1000; long aggregateLatency = 0; AbfsPerfTracker abfsPerfTracker = new AbfsPerfTracker(accountName, filesystemName, false); List<Callable<Long>> tasks = new ArrayList<>(); <START> for (int i=0; i < numTasks; i++) { <END> tasks.add(() -> { Instant startGet = Instant.now(); abfsPerfTracker.getClientLatency(); long latencyGet = Duration.between(startGet, Instant.now()).toMillis(); LOG.debug("Spent ms in retrieving latency record.", latencyGet); return latencyGet; }); } for (Future<Long> fr: executorService.invokeAll(tasks)) { aggregateLatency += fr.get(); } double averageRecordLatency = aggregateLatency/numTasks; assertThat(averageRecordLatency).describedAs("Average time for getting latency records should be bounded") .isBetween(minLatencyWhenDisabledMs, maxLatencyWhenDisabledMs); }</code><technical_language>minor nit, put spaces = here</technical_language>

Target:
public void verifyGettingLatencyRecordsIsCheapWhenDisabled() throws Exception { final double maxLatencyWhenDisabledMs = 1000; final double minLatencyWhenDisabledMs = 0; final long numTasks = 1000; long aggregateLatency = 0; AbfsPerfTracker abfsPerfTracker = new AbfsPerfTracker(accountName, filesystemName, false); List<Callable<Long>> tasks = new ArrayList<>(); for (int i = 0; i < numTasks; i++) { tasks.add(() -> { Instant startGet = Instant.now(); abfsPerfTracker.getClientLatency(); long latencyGet = Duration.between(startGet, Instant.now()).toMillis(); LOG.debug("Spent ms in retrieving latency record.", latencyGet); return latencyGet; }); } for (Future<Long> fr: executorService.invokeAll(tasks)) { aggregateLatency += fr.get(); } double averageRecordLatency = aggregateLatency / numTasks; assertThat(averageRecordLatency).describedAs("Average time for getting latency records should be bounded") .isBetween(minLatencyWhenDisabledMs, maxLatencyWhenDisabledMs); }
Source:
<code>public ActionResult<ItemStack> onItemRightClick(World worldIn, PlayerEntity playerIn, Hand handIn) { ItemStack stack = playerIn.getHeldItem(handIn); if(worldIn.isRemote) { boolean canEdit = playerIn.getHeldItem(handIn == Hand.MAIN_HAND ? Hand.OFF_HAND : Hand.MAIN_HAND).isItemEqual(new ItemStack(MSItems.CARVING_TOOL)); String text = hasText(stack) ? stack.getTag().getString("text") : ""; <START> Minecraft.getInstance().displayGuiScreen(new StoneTabletScreen(playerIn, handIn, text, canEdit)); <END> } return new ActionResult<>(ActionResultType.SUCCESS, stack); }</code><technical_language>This problems dedicated servers refer a screen class minecraft class here. tested this dedicated servers? If a problem, consider moving gui display MSScreenFactories</technical_language>

Target:
public ActionResult<ItemStack> onItemRightClick(World worldIn, PlayerEntity playerIn, Hand handIn) { ItemStack stack = playerIn.getHeldItem(handIn); if(worldIn.isRemote) { boolean canEdit = playerIn.getHeldItem(handIn == Hand.MAIN_HAND ? Hand.OFF_HAND : Hand.MAIN_HAND).isItemEqual(new ItemStack(MSItems.CARVING_TOOL)); String text = hasText(stack) ? stack.getTag().getString("text") : ""; MSScreenFactories.displayStoneTabletScreen(playerIn, handIn, text, canEdit); } return new ActionResult<>(ActionResultType.SUCCESS, stack); }
Source:
<code>public static BigtableTableUtilsFactory from(HBaseImportOptions options) throws IOException { BigtableConnection connection = new BigtableConnection( new CloudBigtableConfiguration.Builder() .withProjectId(options.getBigtableProjectId()) .withClusterId(options.getBigtableClusterId()) .withZoneId(options.getBigtableZoneId()) .withConfiguration( "hbase.client.connection.impl", <START> "com.google.cloud.bigtable.hbase1_0.BigtableConnection") <END> .build() .toHBaseConfig()); return new BigtableTableUtilsFactory(connection); }</code><technical_language>hardcode this</technical_language>

Target:
public static BigtableTableUtilsFactory from(HBaseImportOptions options) throws IOException { return new BigtableTableUtilsFactory(BigtableConfiguration.connect( options.getBigtableProjectId(), options.getBigtableZoneId(), options.getBigtableClusterId())); }
Source:
<code>private void createNewBloomFilter() { <START> bloomFilter = BloomFilter.create(Funnels.stringFunnel(), BLOOM_FILTER_CAPACITY, BLOOM_FILTER_ERROR_RATE); <END> this.lastBloomFilterCreated = DateTime.now(); }</code><technical_language>nit: this. for assignments here, for of them. Consistency is good :)</technical_language>

Target:
private void createNewBloomFilter() { this.bloomFilter = BloomFilter.create(Funnels.stringFunnel(), BLOOM_FILTER_CAPACITY, BLOOM_FILTER_ERROR_RATE); this.lastBloomFilterCreated = DateTime.now(DateTimeZone.UTC); }
Source:
<code>public void visitNode(Tree tree) { if (!hasSemantic()) { return; } MethodTree methodTree = (MethodTree) tree; BlockTree block = methodTree.block(); if (block != null) { CloseableVisitor closeableVisitor = new CloseableVisitor(methodTree.parameters()); block.accept(closeableVisitor); <START> for (Tree ref : closeableVisitor.executionState.getUnclosedClosables()) { <END> insertIssue(ref); } } }</code><technical_language>this encapsulated avoid leaking executionState class in check class</technical_language>

Target:
public void visitNode(Tree tree) { if (!hasSemantic()) { return; } MethodTree methodTree = (MethodTree) tree; BlockTree block = methodTree.block(); if (block != null) { CloseableVisitor visitor = new CloseableVisitor(methodTree.parameters(), this); block.accept(visitor); visitor.executionState.insertIssues(); } }
Source:
<code>void canExecuteAsyncJavascript() { long value = (Long) Selenide.executeAsyncJavaScript( <START> "var callback = arguments[0]; setTimeout(function() { callback(10); }, 50);" <END> ); assertThat(value).isEqualTo(10); }</code><technical_language>proper is arguments[arguments.length - 1] instead of arguments[0]</technical_language>

Target:
void canExecuteAsyncJavascript() { long value = (Long) Selenide.executeAsyncJavaScript( "var callback = arguments[arguments.length - 1]; setTimeout(function() { callback(10); }, 50);" ); assertThat(value).isEqualTo(10); }
Source:
<code>public List<?> predict(int tenantId, String userName, long modelId, List<String[]> data) throws MLModelHandlerException { if (!isValidModelId(tenantId, userName, modelId)) { String msg = String.format("Failed to build the model. Invalid model id: %s for tenant: %s and user: %s", modelId, tenantId, userName); throw new MLModelHandlerException(msg); } MLModel builtModel = retrieveModel(modelId); if (builtModel.getFeatures().size() != data.get(0).length) { String msg = String.format("Failed to predict from model. ML model with model id: %s has %s features " + "but predict dataset has %s features. Incompatible number of features.", modelId, <START> builtModel.getFeatures().size(), data.get(0).length); <END> throw new MLModelHandlerException(msg); } Predictor predictor = new Predictor(modelId, builtModel, data); List<?> predictions = predictor.predict(); log.info(String.format("Prediction from model [id] %s was successful.", modelId)); return predictions; }</code><technical_language>change message like; Prediction failed model [id] x number of features of model [4] match number of features in input data [3]. Wdyt</technical_language>

Target:
public List<?> predict(int tenantId, String userName, long modelId, List<String[]> data) throws MLModelHandlerException { if (!isValidModelId(tenantId, userName, modelId)) { String msg = String.format("Failed to build the model. Invalid model id: %s for tenant: %s and user: %s", modelId, tenantId, userName); throw new MLModelHandlerException(msg); } MLModel builtModel = retrieveModel(modelId); if (builtModel.getFeatures().size() != data.get(0).length) { String msg = String.format("Prediction failed from model [id] %s since the number of features of model" + " [%s] doesn't match the number of features in the input data [%s]", modelId, builtModel.getFeatures().size(), data.get(0).length); throw new MLModelHandlerException(msg); } Predictor predictor = new Predictor(modelId, builtModel, data); List<?> predictions = predictor.predict(); log.info(String.format("Prediction from model [id] %s was successful.", modelId)); return predictions; }
Source:
<code>public static String convertArtifactToPath(Artifact artifact) { <START> final Gav gav = new Gav(artifact.getGroupId(), <END> StringUtils.defaultString(artifact.getArtifactId()), StringUtils.defaultString(artifact.getVersion()), artifact.getClassifier(), artifact.getType(), null, null, null, false, null, false, null); return M2_GAV_CALCULATOR.gavToPath(gav).substring(1); }</code><technical_language>another MavenArtifactUtils method for this</technical_language>

Target:
public static String convertArtifactToPath(Artifact artifact) { final Gav gav = convertArtifactToGav(artifact); return M2_GAV_CALCULATOR.gavToPath(gav).substring(1); }
Source:
<code>private void failUnpublished(final List<BatchItem> batch, final String reason) { batch.stream() <START> .filter(item -> !(item.getResponse().getPublishingStatus().equals(EventPublishingStatus.SUBMITTED))) <END> .forEach(item -> item.updateStatusAndDetail(EventPublishingStatus.FAILED, reason)); }</code><technical_language>I cleaner: item.getResponse().getPublishingStatus() != EventPublishingStatus.SUBMITTED</technical_language>

Target:
private void failUnpublished(final List<BatchItem> batch, final String reason) { batch.stream() .filter(item -> item.getResponse().getPublishingStatus() != EventPublishingStatus.SUBMITTED) .forEach(item -> item.updateStatusAndDetail(EventPublishingStatus.FAILED, reason)); }
Source:
<code>private void animateProgress(int milliPosition, int milliDuration) { if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.HONEYCOMB) { ProgressBar progressBar = (ProgressBar)findViewById(R.id.circular_progress_bar); <START> animation = ObjectAnimator.ofInt(progressBar, "progress", 0, 500); <END> animation.setDuration(milliDuration); animation.setCurrentPlayTime(milliPosition); animation.setInterpolator(new DecelerateInterpolator()); animation.start(); } }</code><technical_language>hard-coded 0 500 values for</technical_language>

Target:
private void animateProgress(int milliPosition, int milliDuration) { if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.HONEYCOMB) { ProgressBar progressBar = (ProgressBar)findViewById(R.id.circular_progress_bar); int startPosition = 0; int progressDuration = 500; animation = ObjectAnimator.ofInt(progressBar, "progress", startPosition, progressDuration); animation.setDuration(milliDuration); animation.setCurrentPlayTime(milliPosition); animation.setInterpolator(new DecelerateInterpolator()); animation.start(); } }
Source:
<code>public void channelLinked(ChannelUID channelUID) { switch (channelUID.getId()) { case CHANNEL_SWITCH: if (channels.size() > 0) { channels.get(0).addListener(channelUID, this, ListenerType.ONOFF); } break; case CHANNEL_BRIGHTNESS: if (channels.size() > 0) { channels.get(0).addListener(channelUID, this, ListenerType.VALUE); } break; case CHANNEL_COLOR: if (channels.size() > 2) { channels.get(0).addListener(channelUID, this, ListenerType.VALUE); channels.get(1).addListener(channelUID, this, ListenerType.VALUE); channels.get(2).addListener(channelUID, this, ListenerType.VALUE); } else { <START> logger.warn("cannot link color channel with less than three DMX channels in thing {}", <END> this.thing.getUID()); } break; default: logger.warn("channel not supported in thing {}", channelUID.getId(), this.thing.getUID()); } }</code><technical_language>This sounds a conceptional problem me: If enough DMX channels, ESH Color channel (and get in a situation a color channel linked). idea remove color channel dimmer type XML add this channel dynamically a if enough DMX channels assigned it</technical_language>

Target:
public void channelLinked(ChannelUID channelUID) { logger.trace("trying to add listeners for (Thing [})", channelUID, this.thing.getUID()); switch (channelUID.getId()) { case CHANNEL_SWITCH: if (channels.size() > 0) { channels.get(0).addListener(channelUID, this, ListenerType.ONOFF); } break; case CHANNEL_BRIGHTNESS: if (channels.size() > 0) { channels.get(0).addListener(channelUID, this, ListenerType.VALUE); } break; case CHANNEL_COLOR: if (channels.size() > 3) { channels.get(0).addListener(channelUID, this, ListenerType.VALUE); channels.get(1).addListener(channelUID, this, ListenerType.VALUE); channels.get(2).addListener(channelUID, this, ListenerType.VALUE); break; } default: logger.warn("channel not supported in thing {}", channelUID.getId(), this.thing.getUID()); } }
Source:
<code>public void onItemClick(AdapterView<?> parent, View view, int position, long id) { final Intent intent = new Intent(this, videoList[position].activity); intent.putExtra("embedcode", videoList[position].embedCode); <START> intent.putExtra("embedcode2", videoList[position].embedCode2); <END> intent.putExtra("pcode", videoList[position].pcode); intent.putExtra("domain", videoList[position].domain); startActivity(intent); }</code><technical_language>embedcode2 - please name purpose of usage</technical_language>

Target:
public void onItemClick(AdapterView<?> parent, View view, int position, long id) { final Intent intent = new Intent(this, videoList[position].activity); intent.putExtra("embedcode", videoList[position].embedCode); intent.putExtra("secondEmbedCode", videoList[position].secondEmbedCode); intent.putExtra("pcode", videoList[position].pcode); intent.putExtra("domain", videoList[position].domain); startActivity(intent); }
Source:
<code>DataEntity entity() throws EntityNotFoundException; StructuredData data(RelativePath dataPath); <START> StructuredData bareData(RelativePath dataPath); <END> @Override default boolean exists() { try { bareData(RelativePath.empty().get()); return true; } catch (EntityNotFoundException | RelationNotFoundException ignored) { return false; } }</code><technical_language>This is of performance reasons, right? flatData() more descriptive name here. EDIT: If I understand well, deep relative path, wont fetch data recursively point deeper, is correct? java ...bareData(RelativePath.to().structuredData().key("foo").index(2).get()); ...data(same_param) returns flat (primitive values) position (?)</technical_language>

Target:
DataEntity entity() throws EntityNotFoundException; StructuredData data(RelativePath dataPath); StructuredData flatData(RelativePath dataPath); @Override default boolean exists() { try { flatData(RelativePath.empty().get()); return true; } catch (EntityNotFoundException | RelationNotFoundException ignored) { return false; } }
Source:
<code>public UIScreenLayer pushScreen(UIElement element) { if (element != null && element.getRootWidget() instanceof CoreScreenLayer) { CoreScreenLayer result = (CoreScreenLayer) element.getRootWidget(); <START> if (!result.equals(screens.peek())) { <END> result.setId(element.getURI().toNormalisedSimpleString()); pushScreen(result, element.getURI()); } return result; } return null; }</code><technical_language>Possibly check entire screen stack</technical_language>

Target:
public UIScreenLayer pushScreen(UIElement element) { if (element != null && element.getRootWidget() instanceof CoreScreenLayer) { CoreScreenLayer result = (CoreScreenLayer) element.getRootWidget(); if (!screens.contains(result)) { result.setId(element.getURI().toNormalisedSimpleString()); pushScreen(result, element.getURI()); } return result; } return null; }
Source:
<code>private void onProjectUpdated(ProjectUpdatedEvent event) { ExecuteCommandParams params = new ExecuteCommandParams( GET_PROJECT_SOURCE_LOCATIONS_COMMAND, singletonList(prefixURI(event.getProjectPath()))); <START> languageServer <END> .getWorkspaceService() .executeCommand(params) .thenAccept( result -> { if (result == null) { return; } Type type = new TypeToken<ArrayList<String>>() {}.getType(); List<String> paths = gson.fromJson(gson.toJson(result), type); paths.stream().forEach(f -> matcher.accept(Paths.get(removeUriScheme(prefixURI(f))))); }); }</code><technical_language>me, if this effect</technical_language>

Target:
private void onProjectUpdated(ProjectUpdatedEvent event) { ExecuteCommandParams params = new ExecuteCommandParams( GET_PROJECT_SOURCE_LOCATIONS_COMMAND, singletonList(prefixURI(event.getProjectPath()))); ExtendedLanguageServer languageServer = lsRegistry.byId(JavaModule.LS_ID); if (languageServer == null) { return; } languageServer .getServer() .getWorkspaceService() .executeCommand(params) .thenAccept( result -> { if (result == null) { return; } Type type = new TypeToken<ArrayList<String>>() {}.getType(); List<String> paths = gson.fromJson(gson.toJson(result), type); paths.stream().forEach(f -> matcher.accept(Paths.get(removeUriScheme(prefixURI(f))))); }); }
Source:
<code>public void findOneByDefault() throws Exception { List<AnnotationMetadataMongo> annotationMetadataMongoList = repository.findByDefaultVersionIsTrue(); assertEquals(1, annotationMetadataMongoList.size()); AnnotationMetadataMongo annotationMetadataMongo = annotationMetadataMongoList.get(0); <START> assertEquals(true, annotationMetadataMongo.isDefault()); <END> }</code><technical_language>assertTrue(annotationMetadataMongo.isDefault());</technical_language>

Target:
public void findOneByDefault() throws Exception { List<AnnotationMetadataMongo> annotationMetadataMongoList = repository.findByDefaultVersionTrue(); assertEquals(1, annotationMetadataMongoList.size()); AnnotationMetadataMongo annotationMetadataMongo = annotationMetadataMongoList.get(0); assertTrue(annotationMetadataMongo.isDefaultVersion()); }
Source:
<code>public static String getEncodedPathInfo(HttpServletRequest req) { String servletPath = req.getServletPath(); <START> int servletPathLength = servletPath.length(); <END> String requestUri = req.getRequestURI(); String pathInfo = requestUri.substring(req.getContextPath().length()) .replaceAll("[/]{2,}", "/"); if (pathInfo.startsWith(servletPath)) { pathInfo = pathInfo.substring(servletPathLength); if (pathInfo.isEmpty() && servletPathLength > 0) { pathInfo = null; } } else { pathInfo = null; } return pathInfo; }</code><technical_language>Defer computing this required condition below</technical_language>

Target:
public static String getEncodedPathInfo(HttpServletRequest req) { return getEncodedPathInfo(req.getServletPath(), req.getRequestURI(), req.getContextPath()); }
Source:
<code>public ValidationResult validateThereIsEnoughOfFreeMacs(List<? extends VmNic> vmNics, MacPool macPool) { Stream<? extends VmNic> nicsWithoutMacAddress = <START> vmNics.stream().filter(vmNic -> !doesNicHaveMacAddress(vmNic)); <END> long requiredMacs = nicsWithoutMacAddress.count(); boolean notEnoughOfMacs = requiredMacs > 0 && macPool.getAvailableMacsCount() < requiredMacs; return ValidationResult.failWith(EngineMessage.MAC_POOL_NOT_ENOUGH_MAC_ADDRESSES) .when(notEnoughOfMacs); }</code><technical_language>if nicHasNoMacAddress existed, this could've replaced method reference: this::nicHasNoMacAddress</technical_language>

Target:
public ValidationResult validateThereIsEnoughOfFreeMacs(List<? extends VmNic> vmNics, MacPool macPool) { Stream<? extends VmNic> nicsWithoutMacAddress = vmNics.stream().filter(this::nicWithoutMacAddress); long requiredMacs = nicsWithoutMacAddress.count(); boolean notEnoughOfMacs = requiredMacs > 0 && macPool.getAvailableMacsCount() < requiredMacs; return ValidationResult.failWith(EngineMessage.MAC_POOL_NOT_ENOUGH_MAC_ADDRESSES) .when(notEnoughOfMacs); }
Source:
<code>public NameRevCommand add(Iterable<ObjectId> ids) throws MissingObjectException, JGitInternalException { <START> for (ObjectId id : ids) { <END> add(id); } return this; }</code><technical_language>curly braces</technical_language>

Target:
public NameRevCommand add(Iterable<ObjectId> ids) throws MissingObjectException, JGitInternalException { for (ObjectId id : ids) add(id); return this; }
Source:
<code>public Boolean checkNextPageButtonIsEnabled() { <START> WaitUtils.sleepQuietly(1); <END> return seleniumWebDriver.findElement(By.id(Locators.NEXT_BUTTON)).isEnabled(); }</code><technical_language>If is avoid WaitUtils.sleepQuietly(1);</technical_language>

Target:
public Boolean checkNextPageButtonIsEnabled() { return seleniumWebDriver.findElement(By.id(Locators.NEXT_BUTTON)).isEnabled(); }
Source:
<code>public void testCustomModelCount() { final KieServices ks = KieServices.Factory.get(); final KieFileSystem kfs = ks.newKieFileSystem(); final KieModuleModel kmm = ks.newKieModuleModel(); kmm.setConfigurationProperty("org.kie.dmn.profiles.CustomModelCountDMNProfile", CustomModelCountDMNProfile.class.getCanonicalName()); kfs.writeKModuleXML(kmm.toXML()); kfs.write(ks.getResources().newClassPathResource("customModelCount.dmn", this.getClass())); final KieBuilder kieBuilder = ks.newKieBuilder(kfs).buildAll(); final Results results = kieBuilder.getResults(); assertThat(results.getMessages().toString(), results.hasMessages(org.kie.api.builder.Message.Level.ERROR), is(false)); final KieContainer kieContainer = ks.newKieContainer(ks.getRepository().getDefaultReleaseId()); final DMNRuntime runtime = kieContainer.newKieSession().getKieRuntime(DMNRuntime.class); final DMNModel dmnModel = runtime.getModel("<LINK_0>", "Drawing 1"); assertThat(dmnModel, notNullValue()); assertThat(DMNRuntimeUtil.formatMessages(dmnModel.getMessages()), dmnModel.hasErrors(), is(false)); final DMNContext context = DMNFactory.newContext(); final DMNResult dmnResult = runtime.evaluateAll(dmnModel, context); <START> System.out.println(dmnResult); <END> assertThat(DMNRuntimeUtil.formatMessages(dmnResult.getMessages()), dmnResult.hasErrors(), is(false)); final DMNContext result = dmnResult.getContext(); assertThat(result.get("main decision"), is(new BigDecimal(1))); }</code><technical_language>Is necessary write dmn result console? I suggest remove this debugging output</technical_language>

Target:
public void testCustomModelCount() { final KieServices ks = KieServices.Factory.get(); final KieFileSystem kfs = ks.newKieFileSystem(); final KieModuleModel kmm = ks.newKieModuleModel(); kmm.setConfigurationProperty("org.kie.dmn.profiles.CustomModelCountDMNProfile", CustomModelCountDMNProfile.class.getCanonicalName()); kfs.writeKModuleXML(kmm.toXML()); kfs.write(ks.getResources().newClassPathResource("customModelCount.dmn", this.getClass())); final KieBuilder kieBuilder = ks.newKieBuilder(kfs).buildAll(); final Results results = kieBuilder.getResults(); assertThat(results.getMessages().toString(), results.hasMessages(org.kie.api.builder.Message.Level.ERROR), is(false)); final KieContainer kieContainer = ks.newKieContainer(ks.getRepository().getDefaultReleaseId()); final DMNRuntime runtime = kieContainer.newKieSession().getKieRuntime(DMNRuntime.class); final DMNModel dmnModel = runtime.getModel("<LINK_0>", "Drawing 1"); assertThat(dmnModel, notNullValue()); assertThat(DMNRuntimeUtil.formatMessages(dmnModel.getMessages()), dmnModel.hasErrors(), is(false)); final DMNContext context = DMNFactory.newContext(); final DMNResult dmnResult = runtime.evaluateAll(dmnModel, context); LOG.debug("{}", dmnResult); assertThat(DMNRuntimeUtil.formatMessages(dmnResult.getMessages()), dmnResult.hasErrors(), is(false)); final DMNContext result = dmnResult.getContext(); assertThat(result.get("main decision"), is(new BigDecimal(1))); }
Source:
<code>private TaskData doInBackgroundAnswerCard(TaskData... params) { Collection col = CollectionHelper.getInstance().getCol(mContext); AbstractSched sched = col.getSched(); Card oldCard = params[0].getCard(); int ease = params[0].getInt(); Card newCard = null; Timber.i(oldCard != null ? "Answering card" : "Obtaining card"); try { DB db = col.getDb(); db.getDatabase().beginTransaction(); try { if (oldCard != null) { Timber.i("Answering card %d", oldCard.getId()); sched.answerCard(oldCard, ease); } <START> newCard = getCard(sched); <END> if (newCard != null) { newCard._getQA(true); } publishProgress(new TaskData(newCard)); db.getDatabase().setTransactionSuccessful(); } finally { db.getDatabase().endTransaction(); } } catch (RuntimeException e) { Timber.e(e, "doInBackgroundAnswerCard - RuntimeException on answering card"); AnkiDroidApp.sendExceptionReport(e, "doInBackgroundAnswerCard"); return new TaskData(false); } return new TaskData(true); }</code><technical_language>agreed, merge immediately</technical_language>

Target:
private TaskData doInBackgroundAnswerCard(TaskData... params) { Collection col = CollectionHelper.getInstance().getCol(mContext); AbstractSched sched = col.getSched(); Card oldCard = params[0].getCard(); int ease = params[0].getInt(); Card newCard = null; Timber.i(oldCard != null ? "Answering card" : "Obtaining card"); try { DB db = col.getDb(); db.getDatabase().beginTransaction(); try { if (oldCard != null) { Timber.i("Answering card %d", oldCard.getId()); sched.answerCard(oldCard, ease); } newCard = sched.getCard(); if (newCard != null) { newCard._getQA(true); } publishProgress(new TaskData(newCard)); db.getDatabase().setTransactionSuccessful(); } finally { db.getDatabase().endTransaction(); } } catch (RuntimeException e) { Timber.e(e, "doInBackgroundAnswerCard - RuntimeException on answering card"); AnkiDroidApp.sendExceptionReport(e, "doInBackgroundAnswerCard"); return new TaskData(false); } return new TaskData(true); }
Source:
<code>public String getType(final Optional<String> operatorFromCell) throws ValueResolveException { try { Logger.add("Getting type from utils"); if (operatorFromCell.isPresent()) { return conditionColumn.getFieldType(); } final String type = utils.getType(conditionColumn, columnIndex); <START> Logger.add("Resolver type from utils: " + type); <END> return type; } catch (final Exception e) { throw new ValueResolveException("Failed to get type for " + ToString.toString(conditionColumn) + " columnIndex: " + columnIndex, e); } }</code><technical_language>Do want logging in this class. Asking do log type resolved if operator in cell</technical_language>

Target:
public String getType(final Optional<String> operatorFromCell) throws ValueResolveException { try { if (operatorFromCell.isPresent()) { return conditionColumn.getFieldType(); } final String type = utils.getType(conditionColumn, columnIndex); return type; } catch (final Exception e) { throw new ValueResolveException("Failed to get type for " + ToString.toString(conditionColumn) + " columnIndex: " + columnIndex, e); } }
Source:
<code>public WikibaseUris(String host) { root = "http://" + host; <START> String rootHttps = "https://" + host; <END> entityData = root + "/wiki/Special:EntityData/"; entityDataHttps = rootHttps + "/wiki/Special:EntityData/"; entity = root + "/entity/"; statement = entity + "statement/"; value = root + "/value/"; reference = root + "/reference/"; prop = root + "/prop/"; }</code><technical_language>a big fan of this. If root property, rootHttps similar. weird, if technical differs</technical_language>

Target:
public WikibaseUris(String host) { root = "http://" + host; rootHttps = "https://" + host; entityData = root + "/wiki/Special:EntityData/"; entityDataHttps = rootHttps + "/wiki/Special:EntityData/"; entity = root + "/entity/"; statement = entity + "statement/"; value = root + "/value/"; reference = root + "/reference/"; prop = root + "/prop/"; }
Source:
<code>public Optional<ColumnMapper<?>> findColumnMapperFor(Type type, StatementContext ctx) { ColumnMapper<?> mapper = columnCache.get(type); if (mapper != null) { return Optional.of(mapper); } mapper = columnFactories.stream() .flatMap(factory -> toStream(factory.build(type, ctx))) .findFirst() .orElse(null); if (mapper != null) { columnCache.put(type, mapper); <START> return Optional.of(mapper); <END> } return Optional.empty(); }</code><technical_language>potentially avoid unboxing Optional findFirst reusing</technical_language>

Target:
public Optional<ColumnMapper<?>> findColumnMapperFor(Type type, StatementContext ctx) { ColumnMapper<?> cached = columnCache.get(type); if (cached != null) { return Optional.of(cached); } Optional<ColumnMapper<?>> mapper = columnFactories.stream() .flatMap(factory -> toStream(factory.build(type, ctx))) .findFirst(); mapper.ifPresent(m -> columnCache.put(type, m)); return mapper; }
Source:
<code>public void prepareConfigForTestClass(Class<?> testClass, Method testMethod) { <START> for(Class<?> parentClass : ClassUtils.getAllSuperclasses(testClass)) { <END> classLevelOverrides.setProperties(testPropertyOverrideAnnotationReader.getPropertiesForAnnotation(parentClass.getAnnotation(TestPropertyOverride.class))); } classLevelOverrides.setProperties(testPropertyOverrideAnnotationReader.getPropertiesForAnnotation(testClass.getAnnotation(TestPropertyOverride.class))); methodLevelOverrides.setProperties(testPropertyOverrideAnnotationReader.getPropertiesForAnnotation(testMethod.getAnnotation(TestPropertyOverride.class))); }</code><technical_language>iterate superclasses in reverse order, properties senior parent overlaid of more junior parent</technical_language>

Target:
public void prepareConfigForTestClass(Class<?> testClass, Method testMethod) { for(Class<?> parentClass : getAllSuperClassesInReverseOrder(testClass)) { classLevelOverrides.setProperties(testPropertyOverrideAnnotationReader.getPropertiesForAnnotation(parentClass.getAnnotation(TestPropertyOverride.class))); } classLevelOverrides.setProperties(testPropertyOverrideAnnotationReader.getPropertiesForAnnotation(testClass.getAnnotation(TestPropertyOverride.class))); methodLevelOverrides.setProperties(testPropertyOverrideAnnotationReader.getPropertiesForAnnotation(testMethod.getAnnotation(TestPropertyOverride.class))); }
Source:
<code>private void updatePartitionStateIfChanged(Partition partition) { for (Map.Entry<String, HelixAdmin> entry : adminForDc.entrySet()) { String dcName = entry.getKey(); HelixAdmin dcAdmin = entry.getValue(); String partitionName = Long.toString(partition.getId()); boolean isSealed = partition.getPartitionState().equals(PartitionState.READ_ONLY); List<ReplicaId> replicaList = getReplicasInDc(partition, dcName); for (ReplicaId replicaId : replicaList) { DataNodeId node = replicaId.getDataNodeId(); String instanceName = node.getHostname() + "_" + node.getPort(); InstanceConfig instanceConfig = dcAdmin.getInstanceConfig(clusterName, instanceName); List<String> currentSealedPartitions = instanceConfig.getRecord().getListField("SEALED"); if (isSealed && !currentSealedPartitions.contains(partitionName)) { <START> List<String> newSealedPartitionsList = new ArrayList<>(currentSealedPartitions); <END> newSealedPartitionsList.add(partitionName); instanceConfig.getRecord().setListField("SEALED", newSealedPartitionsList); dcAdmin.setInstanceConfig(clusterName, instanceName, instanceConfig); } else if (!isSealed && currentSealedPartitions.contains(partitionName)) { List<String> newSealedPartitionsList = new ArrayList<>(currentSealedPartitions); newSealedPartitionsList.remove(partitionName); instanceConfig.getRecord().setListField("SEALED", newSealedPartitionsList); dcAdmin.setInstanceConfig(clusterName, instanceName, instanceConfig); } } } }</code><technical_language>liens 363 366 is repeated in more 1 place. do a private method</technical_language>

Target:
private void updatePartitionStateIfChanged(Partition partition) { for (Map.Entry<String, HelixAdmin> entry : adminForDc.entrySet()) { String dcName = entry.getKey(); HelixAdmin dcAdmin = entry.getValue(); String partitionName = Long.toString(partition.getId()); boolean isSealed = partition.getPartitionState().equals(PartitionState.READ_ONLY); List<ReplicaId> replicaList = getReplicasInDc(partition, dcName); for (ReplicaId replicaId : replicaList) { DataNodeId node = replicaId.getDataNodeId(); String instanceName = getInstanceName(node); InstanceConfig instanceConfig = dcAdmin.getInstanceConfig(clusterName, instanceName); List<String> currentSealedPartitions = instanceConfig.getRecord().getListField(SEALED_STR); List<String> newSealedPartitionsList = new ArrayList<>(currentSealedPartitions); if (isSealed && !currentSealedPartitions.contains(partitionName)) { newSealedPartitionsList.add(partitionName); } else if (!isSealed && currentSealedPartitions.contains(partitionName)) { newSealedPartitionsList.remove(partitionName); } instanceConfig.getRecord().setListField(SEALED_STR, newSealedPartitionsList); } } }
Source:
<code>private void checkOverwriteDjangoHashers(AstNode expressionStatement) { AstNode lhsExpression = getLHSExpression(expressionStatement); if (lhsExpression == null) { return; } AstNode attributeRef = lhsExpression.getFirstDescendant(PythonGrammar.ATTRIBUTE_REF); if (attributeRef != null) { AstNode atom = attributeRef.getFirstChild(PythonGrammar.ATOM); if (atom != null && getQualifiedName(atom).equals("django.conf.settings") && attributeRef.getLastChild(PythonGrammar.NAME).getTokenValue().equals("PASSWORD_HASHERS")) { <START> addIssue(expressionStatement, MESSAGE); <END> } } if (getContext().pythonFile().fileName().equals("global_settings.py") && lhsExpression.getTokenValue().equals("PASSWORD_HASHERS")) { addIssue(expressionStatement, MESSAGE); } }</code><technical_language>want explicitly return here? sounds strange raise 2 issues in run (by reaching line 128 135), if OK, fine</technical_language>

Target:
private void checkOverwriteDjangoHashers(AstNode expressionStatement) { List<AstNode> lhsExpressions = getLHSExpressions(expressionStatement); if (lhsExpressions == null) { return; } if (isOverwritingDjangoHashers(lhsExpressions)) { addIssue(expressionStatement, MESSAGE); return; } if (getContext().pythonFile().fileName().equals("global_settings.py") && lhsExpressions.stream().anyMatch(expression -> expression.getTokenValue().equals("PASSWORD_HASHERS"))) { addIssue(expressionStatement, MESSAGE); } }
Source:
<code>public PlanNode visitTableScan(TableScanNode tableScan, Void context) { if (!isPushdownFilterSupported(session, tableScan.getTable())) { return tableScan; } HiveMetadata hiveMetadata = getMetadata(tableScan.getTable()); ConnectorPushdownFilterResult pushdownFilterResult = pushdownFilter( session, hiveMetadata, tableScan.getTable().getConnectorHandle(), TRUE_CONSTANT, tableScan.getTable().getLayout()); if (pushdownFilterResult.getLayout().getPredicate().isNone()) { return new ValuesNode(idAllocator.getNextId(), tableScan.getOutputVariables(), ImmutableList.of()); } <START> TableHandle handle = tableScan.getTable(); <END> return new TableScanNode( tableScan.getId(), new TableHandle(handle.getConnectorId(), handle.getConnectorHandle(), handle.getTransaction(), Optional.of(pushdownFilterResult.getLayout().getHandle())), tableScan.getOutputVariables(), tableScan.getAssignments(), pushdownFilterResult.getLayout().getPredicate(), TupleDomain.all()); }</code><technical_language>Please, move this variable reuse in places: HiveMetadata hiveMetadata = getMetadata(tableScan.getTable()); ...tableScan.getTable().getConnectorHandle()</technical_language>

Target:
public PlanNode visitTableScan(TableScanNode tableScan, Void context) { if (!isPushdownFilterSupported(session, tableScan.getTable())) { return tableScan; } TableHandle handle = tableScan.getTable(); HiveMetadata hiveMetadata = getMetadata(handle); ConnectorPushdownFilterResult pushdownFilterResult = pushdownFilter( session, hiveMetadata, handle.getConnectorHandle(), TRUE_CONSTANT, handle.getLayout()); if (pushdownFilterResult.getLayout().getPredicate().isNone()) { return new ValuesNode(idAllocator.getNextId(), tableScan.getOutputVariables(), ImmutableList.of()); } return new TableScanNode( tableScan.getId(), new TableHandle(handle.getConnectorId(), handle.getConnectorHandle(), handle.getTransaction(), Optional.of(pushdownFilterResult.getLayout().getHandle())), tableScan.getOutputVariables(), tableScan.getAssignments(), pushdownFilterResult.getLayout().getPredicate(), TupleDomain.all()); }
Source:
<code><START> default boolean setTransformSafely(Transform<World> transform) { <END> checkNotNull(transform, "The transform cannot be null!"); return Sponge.getGame().getTeleportHelper() .getSafeLocation(transform.getLocation()) .map(safe -> this.setTransform(transform.setLocation(safe))) .orElse(false); }</code><technical_language>Sure, this works, return setLocationAndRotationSafely(transform.getLocation(), transform.getRotation()) instead? place change if change teleport helper, means create extra Transform object</technical_language>

Target:
default boolean setTransformSafely(Transform<World> transform) { checkNotNull(transform, "The transform cannot be null!"); return setLocationAndRotationSafely(transform.getLocation(), transform.getRotation()); }
Source:
<code><START> private String getACSUrlWithTenantPartitioning(String acsUrl, String tenantDomain) { <END> return acsUrl; }</code><technical_language>check this</technical_language>

Target:
private String getACSUrlWithTenantPartitioning(String acsUrl, String tenantDomain) { String acsUrlWithTenantDomain = acsUrl; if (tenantDomain != null && "true".equals(IdentityUtil.getProperty( IdentityConstants.ServerConfig.SSO_TENANT_PARTITIONING_ENABLED))) { acsUrlWithTenantDomain = acsUrlWithTenantDomain + "?" + MultitenantConstants.TENANT_DOMAIN + "=" + tenantDomain; } return acsUrlWithTenantDomain; }