auphong2707/dl4se-code-review-dataset huggingface dataset:
Source:
<code>public SqlTaskExecution create(Session session, QueryContext queryContext, TaskStateMachine taskStateMachine, OutputBuffer outputBuffer, PlanFragment fragment, List<TaskSource> sources) { boolean verboseStats = getVerboseStats(session); TaskContext taskContext = queryContext.addTaskContext( taskStateMachine, session, verboseStats, cpuTimerEnabled); LocalExecutionPlan localExecutionPlan; try (SetThreadName ignored = new SetThreadName("Task-%s", taskStateMachine.getTaskId())) { try { localExecutionPlan = planner.plan( taskContext, fragment.getRoot(), fragment.getSymbols(), fragment.getPartitioningScheme(), fragment.getPartitionedSources(), outputBuffer); } catch (Throwable e) { taskStateMachine.failed(e); <START> throw Throwables.propagate(e); <END> } } return createSqlTaskExecution( taskStateMachine, taskContext, outputBuffer, sources, localExecutionPlan, taskExecutor, taskNotificationExecutor, queryMonitor); }</code><technical_language>I this in original code, fix this</technical_language>

Target:
public SqlTaskExecution create(Session session, QueryContext queryContext, TaskStateMachine taskStateMachine, OutputBuffer outputBuffer, PlanFragment fragment, List<TaskSource> sources) { boolean verboseStats = getVerboseStats(session); TaskContext taskContext = queryContext.addTaskContext( taskStateMachine, session, verboseStats, cpuTimerEnabled); LocalExecutionPlan localExecutionPlan; try (SetThreadName ignored = new SetThreadName("Task-%s", taskStateMachine.getTaskId())) { try { localExecutionPlan = planner.plan( taskContext, fragment.getRoot(), fragment.getSymbols(), fragment.getPartitioningScheme(), fragment.getPipelineExecutionStrategy() == GROUPED_EXECUTION, fragment.getPartitionedSources(), outputBuffer); for (DriverFactory driverFactory : localExecutionPlan.getDriverFactories()) { Optional<PlanNodeId> sourceId = driverFactory.getSourceId(); if (sourceId.isPresent() && fragment.isPartitionedSources(sourceId.get())) { checkArgument(fragment.getPipelineExecutionStrategy() == driverFactory.getPipelineExecutionStrategy(), "Partitioned pipelines are expected to have the same execution strategy as the fragment"); } else { checkArgument(fragment.getPipelineExecutionStrategy() != UNGROUPED_EXECUTION || driverFactory.getPipelineExecutionStrategy() == UNGROUPED_EXECUTION, "When fragment execution strategy is ungrouped, all pipelines should have ungrouped execution strategy"); } } } catch (Throwable e) { taskStateMachine.failed(e); throwIfUnchecked(e); throw new RuntimeException(e); } } return createSqlTaskExecution( taskStateMachine, taskContext, outputBuffer, sources, localExecutionPlan, taskExecutor, taskNotificationExecutor, queryMonitor); }
Source:
<code>public void cleanupArtifacts() throws Exception { <START> restAPIPublisher.deleteAPI(apiId); <END> }</code><technical_language>Lets cleanUp() end a practice</technical_language>

Target:
public void cleanupArtifacts() throws Exception { restAPIPublisher.deleteAPI(apiId); super.cleanUp(); }
Source:
<code>protected MetaData getNonGeneratedContentMetaData(String parameterName) { MetaData metaData = new MetaData(); Type contentType; if (this.contentDescriptor != null) { contentType = this.contentDescriptor.getType(); } else { <START> contentType = DefaultContentDescriptor.DEFAULT_CONTENT_TYPE; <END> } String converted = this.converterManager.convert(String.class, contentType); metaData.addMetaData(MetaData.NON_GENERATED_CONTENT, converted); metaData.addMetaData(MetaData.PARAMETER_NAME, parameterName); return metaData; }</code><technical_language>This is part I like: control type for macro parameters for macro content. type macro parameter descriptor? Parameters a type there</technical_language>

Target:
protected MetaData getNonGeneratedContentMetaData(String parameterName) { MetaData metaData = new MetaData(); Type contentType; if (this.macroDescriptor != null && this.macroDescriptor.getParameterDescriptorMap() != null && this.macroDescriptor.getParameterDescriptorMap().containsKey(parameterName)) { contentType = this.macroDescriptor.getParameterDescriptorMap().get(parameterName).getDisplayType(); } else { contentType = DefaultParameterDescriptor.DEFAULT_PARAMETER_TYPE; } String converted = this.converterManager.convert(String.class, contentType); metaData.addMetaData(MetaData.NON_GENERATED_CONTENT, converted); metaData.addMetaData(MetaData.PARAMETER_NAME, parameterName); return metaData; }
Source:
<code>protected void updateResourceType(Node node, String resourceType) throws RepositoryException { <START> String currentResourceType = node.getProperty(SLING_RESOURCE_TYPE).getString(); <END> if (!resourceType.equals(currentResourceType)) { logger.info("Updating node at to resource type: {}", node.getPath(), resourceType); node.setProperty(SLING_RESOURCE_TYPE, resourceType); } else { logger.info("Node at is already resource type: {}", node.getPath(), resourceType); } }</code><technical_language>this do a hasProperty() check if else calls this (thats searchAndUpdateResourceType())</technical_language>

Target:
protected void updateResourceType(Node node, String resourceType) throws RepositoryException { boolean hasResourceType = node.hasProperty(SLING_RESOURCE_TYPE); if (!hasResourceType || !resourceType.equals(node.getProperty(SLING_RESOURCE_TYPE).getString())) { logger.info("Updating node at to resource type: {}", node.getPath(), resourceType); node.setProperty(SLING_RESOURCE_TYPE, resourceType); } else { logger.info("Node at is already resource type: {}", node.getPath(), resourceType); } }
Source:
<code>private void toggleFollowStatus(final View followButton) { if (!NetworkUtils.checkConnection(getContext())) { return; } final boolean isAskingToFollow; if (mIsFeed) { isAskingToFollow = !ReaderBlogTable.isFollowedFeed(mFeedId); } else { isAskingToFollow = !ReaderBlogTable.isFollowedBlog(mBlogId); } if (mFollowListener != null) { <START> if (isAskingToFollow && !mIsFeed) { <END> mFollowListener.onFollowTapped( followButton, mBlogInfo.getName(), mBlogInfo.blogId); } else { mFollowListener.onFollowingTapped(); } } ReaderActions.ActionListener listener = new ReaderActions.ActionListener() { @Override public void onActionResult(boolean succeeded) { if (getContext() == null) { return; } mFollowButton.setEnabled(true); if (!succeeded) { int errResId = isAskingToFollow ? R.string.reader_toast_err_follow_blog : R.string.reader_toast_err_unfollow_blog; ToastUtils.showToast(getContext(), errResId); mFollowButton.setIsFollowed(!isAskingToFollow); } } }; mFollowButton.setEnabled(false); boolean result; if (mIsFeed) { result = ReaderBlogActions.followFeedById(mFeedId, isAskingToFollow, listener); } else { result = ReaderBlogActions.followBlogById(mBlogId, isAskingToFollow, listener); } if (result) { mFollowButton.setIsFollowed(isAskingToFollow); } }</code><technical_language>please elaborate this condition - a bit suspicious -> perform "unfollow" action user clicks follow a feed</technical_language>

Target:
private void toggleFollowStatus(final View followButton) { if (!NetworkUtils.checkConnection(getContext())) { return; } final boolean isAskingToFollow; if (mIsFeed) { isAskingToFollow = !ReaderBlogTable.isFollowedFeed(mFeedId); } else { isAskingToFollow = !ReaderBlogTable.isFollowedBlog(mBlogId); } if (mFollowListener != null) { if (isAskingToFollow) { mFollowListener.onFollowTapped( followButton, mBlogInfo.getName(), mIsFeed ? 0 : mBlogInfo.blogId); } else { mFollowListener.onFollowingTapped(); } } ReaderActions.ActionListener listener = new ReaderActions.ActionListener() { @Override public void onActionResult(boolean succeeded) { if (getContext() == null) { return; } mFollowButton.setEnabled(true); if (!succeeded) { int errResId = isAskingToFollow ? R.string.reader_toast_err_follow_blog : R.string.reader_toast_err_unfollow_blog; ToastUtils.showToast(getContext(), errResId); mFollowButton.setIsFollowed(!isAskingToFollow); } } }; mFollowButton.setEnabled(false); boolean result; if (mIsFeed) { result = ReaderBlogActions.followFeedById(mFeedId, isAskingToFollow, listener); } else { result = ReaderBlogActions.followBlogById(mBlogId, isAskingToFollow, listener); } if (result) { mFollowButton.setIsFollowed(isAskingToFollow); } }
Source:
<code>protected String computeRedirectionToServer(final HttpServletRequest request) { final String relayStateValue = CommonUtils.safeGetParameter(request, this.relayStateParameterName); if (StringUtils.isNotBlank(relayStateValue)) { <START> final StringBuffer buffer = new StringBuffer(); <END> buffer.append(casServerUrlPrefix); if (!this.casServerUrlPrefix.endsWith("/")) { buffer.append("/"); } buffer.append("logout?_eventId=next&"); buffer.append(this.relayStateParameterName); buffer.append("="); buffer.append(CommonUtils.urlEncode(relayStateValue)); final String redirectUrl = buffer.toString(); logger.debug("Redirection url to the CAS server: {}", redirectUrl); return redirectUrl; } return null; }</code><technical_language>is a reason for StringBuffer instead of StringBuilder</technical_language>

Target:
private String computeRedirectionToServer(final HttpServletRequest request) { final String relayStateValue = CommonUtils.safeGetParameter(request, this.relayStateParameterName); if (StringUtils.isNotBlank(relayStateValue)) { final StringBuilder buffer = new StringBuilder(); buffer.append(casServerUrlPrefix); if (!this.casServerUrlPrefix.endsWith("/")) { buffer.append("/"); } buffer.append("logout?_eventId=next&"); buffer.append(this.relayStateParameterName); buffer.append("="); buffer.append(CommonUtils.urlEncode(relayStateValue)); final String redirectUrl = buffer.toString(); logger.debug("Redirection url to the CAS server: {}", redirectUrl); return redirectUrl; } return null; }
Source:
<code>protected ProxyGrantingTicket produceTicketWithAdequateExpirationPolicy( final RegisteredServiceProxyGrantingTicketExpirationPolicy servicePgtPolicy, final ServiceTicket serviceTicket, final Authentication authentication, final String pgtId) { if (servicePgtPolicy != null) { <START> LOGGER.debug("Overriding PGT policy with the specific policy: {}", servicePgtPolicy); <END> return serviceTicket.grantProxyGrantingTicket(pgtId, authentication, new HardTimeoutExpirationPolicy(servicePgtPolicy.getMaxTimeToLiveInSeconds())); } else { LOGGER.debug("Using default TGT policy for PGT"); return serviceTicket.grantProxyGrantingTicket(pgtId, authentication, this.ticketGrantingTicketExpirationPolicy.buildTicketExpirationPolicy()); } }</code><technical_language>suggestion LOGGER.trace("Overriding proxy-granting ticket policy specific policy: [{}]", servicePgtPolicy);</technical_language>

Target:
protected ProxyGrantingTicket produceTicketWithAdequateExpirationPolicy( final RegisteredServiceProxyGrantingTicketExpirationPolicy servicePgtPolicy, final ServiceTicket serviceTicket, final Authentication authentication, final String pgtId) { if (servicePgtPolicy != null) { LOGGER.trace("Overriding proxy-granting ticket policy with the specific policy: [{}]", servicePgtPolicy); return serviceTicket.grantProxyGrantingTicket(pgtId, authentication, new HardTimeoutExpirationPolicy(servicePgtPolicy.getMaxTimeToLiveInSeconds())); } LOGGER.trace("Using default ticket-granting ticket policy for proxy-granting ticket"); return serviceTicket.grantProxyGrantingTicket(pgtId, authentication, this.ticketGrantingTicketExpirationPolicy.buildTicketExpirationPolicy()); }
Source:
<code><START> public boolean shouldJetify(String group, String name, String packaging) { <END> if (aarOnly && packaging.equals(ExternalDependency.JAR)) { return false; } return enableJetifier && getExcludePatterns() .stream() .noneMatch(pattern -> pattern.matcher(group + ":" + name).matches()); }</code><technical_language>want check enableJetifier else</technical_language>

Target:
public boolean shouldJetify(String group, String name, String packaging) { if (!enableJetifier) { return false; } if (aarOnly && packaging.equals(ExternalDependency.JAR)) { return false; } return getExcludePatterns() .stream() .noneMatch(pattern -> pattern.matcher(group + ":" + name).matches()); }
Source:
<code>public void passThrough_ProxyProtocolEnabled_nonProxyBytes() { EmbeddedChannel channel = new EmbeddedChannel(); channel.pipeline().addLast(ElbProxyProtocolChannelHandler.NAME, new ElbProxyProtocolChannelHandler( true)); ByteBuf buf = Unpooled.wrappedBuffer( "TCP4 192.168.0.1 124.123.111.111 10008 443\r\n".getBytes(StandardCharsets.US_ASCII)); channel.writeInbound(buf); Object dropped = channel.readInbound(); assertEquals(dropped, buf); assertNull(channel.pipeline().context(ElbProxyProtocolChannelHandler.NAME)); assertNull(channel.pipeline().context("HAProxyMessageChannelHandler")); assertNull(channel.attr(HAProxyMessageChannelHandler.ATTR_HAPROXY_VERSION).get()); assertNull(channel.attr(HAProxyMessageChannelHandler.ATTR_HAPROXY_MESSAGE).get()); assertNull(channel.attr(SourceAddressChannelHandler.ATTR_LOCAL_ADDRESS).get()); assertNull(channel.attr(SourceAddressChannelHandler.ATTR_LOCAL_ADDR).get()); <START> assertNull(channel.attr(SourceAddressChannelHandler.ATTR_LOCAL_PORT).get()); <END> assertNull(channel.attr(SourceAddressChannelHandler.ATTR_SOURCE_ADDRESS).get()); assertNull(channel.attr(SourceAddressChannelHandler.ATTR_SOURCE_PORT).get()); assertNull(channel.attr(SourceAddressChannelHandler.ATTR_REMOTE_ADDR).get()); }</code><technical_language>I dont understand this test, bytes nonProxyBytes contrary name</technical_language>

Target:
public void passThrough_ProxyProtocolEnabled_nonProxyBytes() { EmbeddedChannel channel = new EmbeddedChannel(); channel.pipeline().addLast(ElbProxyProtocolChannelHandler.NAME, new ElbProxyProtocolChannelHandler(true)); ByteBuf buf = Unpooled.wrappedBuffer( "TCP4 192.168.0.1 124.123.111.111 10008 443\r\n".getBytes(StandardCharsets.US_ASCII)); channel.writeInbound(buf); Object dropped = channel.readInbound(); assertEquals(dropped, buf); buf.release(); assertNull(channel.pipeline().context(ElbProxyProtocolChannelHandler.NAME)); assertNull(channel.pipeline().context("HAProxyMessageChannelHandler")); assertNull(channel.attr(HAProxyMessageChannelHandler.ATTR_HAPROXY_VERSION).get()); assertNull(channel.attr(HAProxyMessageChannelHandler.ATTR_HAPROXY_MESSAGE).get()); assertNull(channel.attr(SourceAddressChannelHandler.ATTR_LOCAL_ADDRESS).get()); assertNull(channel.attr(SourceAddressChannelHandler.ATTR_LOCAL_ADDR).get()); assertNull(channel.attr(SourceAddressChannelHandler.ATTR_LOCAL_PORT).get()); assertNull(channel.attr(SourceAddressChannelHandler.ATTR_SOURCE_ADDRESS).get()); assertNull(channel.attr(SourceAddressChannelHandler.ATTR_SOURCE_PORT).get()); assertNull(channel.attr(SourceAddressChannelHandler.ATTR_REMOTE_ADDR).get()); }
Source:
<code>private boolean authenticate() throws HttpAuthenticationException { List<HttpServerAuthenticationMechanism> authenticationMechanisms = mechanismSupplier.get(); responders = new ArrayList<>(authenticationMechanisms.size()); try { for (HttpServerAuthenticationMechanism nextMechanism : authenticationMechanisms) { currentMechanism = nextMechanism; nextMechanism.evaluateRequest(this); if (isAuthenticated()) { if (successResponder != null) { statusCodeAllowed = true; successResponder.sendResponse(this); if (statusCode > 0) { httpExchangeSpi.setStatusCode(statusCode); return false; } } return true; } } currentMechanism = null; if (required || (authenticationAttempted && ignoreOptionalFailures == false)) { statusCodeAllowed = true; if (responders.size() > 0) { boolean statusSet = false; for (HttpServerMechanismsResponder responder : responders) { responder.sendResponse(this); if (statusSet == false && statusCode > 0 && statusCode != OK) { httpExchangeSpi.setStatusCode(statusCode); statusSet = true; } } if (statusSet == false) { httpExchangeSpi.setStatusCode(OK); } } else { httpExchangeSpi.setStatusCode(FORBIDDEN); } return false; } return true; } finally { authenticationMechanisms.forEach(m -> { m.dispose(); <START> }); <END> } }</code><technical_language>This is a formatting change; original code fine</technical_language>

Target:
private boolean authenticate() throws HttpAuthenticationException { List<HttpServerAuthenticationMechanism> authenticationMechanisms = mechanismSupplier.get(); responders = new ArrayList<>(authenticationMechanisms.size()); try { for (HttpServerAuthenticationMechanism nextMechanism : authenticationMechanisms) { currentMechanism = nextMechanism; nextMechanism.evaluateRequest(this); if (isAuthenticated()) { if (successResponder != null) { statusCodeAllowed = true; successResponder.sendResponse(this); if (statusCode > 0) { httpExchangeSpi.setStatusCode(statusCode); return false; } } return true; } } currentMechanism = null; if (required || (authenticationAttempted && ignoreOptionalFailures == false)) { statusCodeAllowed = true; if (responders.size() > 0) { boolean statusSet = false; for (HttpServerMechanismsResponder responder : responders) { responder.sendResponse(this); if (statusSet == false && statusCode > 0 && statusCode != OK) { httpExchangeSpi.setStatusCode(statusCode); statusSet = true; } } if (statusSet == false) { httpExchangeSpi.setStatusCode(OK); } } else { httpExchangeSpi.setStatusCode(FORBIDDEN); } return false; } return true; } finally { authenticationMechanisms.forEach(m -> m.dispose()); } }
Source:
<code>public AuditLogType getAuditLogTypeValue() { if(getSucceeded()) { return (VMStatus) getActionReturnValue() == VMStatus.Up ? AuditLogType.VM_MIGRATION_DONE : AuditLogType.VM_MIGRATION_START; <START> } else { <END> if(_isRerun) { return AuditLogType.VM_MIGRATION_TRYING_RERUN; } else { return getVds().getstatus() == VDSStatus.PreparingForMaintenance ? AuditLogType.VM_MIGRATION_FAILED_DURING_MOVE_TO_MAINTANANCE : AuditLogType.VM_MIGRATION_FAILED; } } }</code><technical_language>Excellent!!! question, if return in block, do need else? Simply remove out internal condition: if (xxx) { return yyy } if (xxx2) { ... } else { ... } clearer</technical_language>

Target:
public AuditLogType getAuditLogTypeValue() { if (getSucceeded()) { return (VMStatus) getActionReturnValue() == VMStatus.Up ? AuditLogType.VM_MIGRATION_DONE : AuditLogType.VM_MIGRATION_START; } if (getActionReturnValue() == VMStatus.MigratingFrom) { return AuditLogType.VM_MIGRATION_START; } if (_isRerun) { return AuditLogType.VM_MIGRATION_TRYING_RERUN; } return getVds().getstatus() == VDSStatus.PreparingForMaintenance ? AuditLogType.VM_MIGRATION_FAILED_DURING_MOVE_TO_MAINTANANCE : AuditLogType.VM_MIGRATION_FAILED; }
Source:
<code>public Collection<E> makeConfirmedCollection() { <START> final ArrayList<E> list = new ArrayList<>(); <END> return list; }</code><technical_language>local var is useless, remove it</technical_language>

Target:
public Collection<E> makeConfirmedCollection() { return new ArrayList<>(); }
Source:
<code><START> public EntityBuilder newBuilder(String prefabName) { <END> if (prefabName != null && !prefabName.isEmpty()) { Prefab prefab = entityManager.getPrefabManager().getPrefab(prefabName); if (prefab == null) { logger.warn("Unable to instantiate unknown prefab: \"{}\"", prefabName); return new EntityBuilder(this); } return newBuilder(prefab); } return newBuilder(); }</code><technical_language>is cost of a builder? Do reduce code duplication, sense implement create(prefab) in terms of builder? Java public EntityRef create(String prefabName) { newBuilder(prefabName).build() }</technical_language>

Target:
public EntityBuilder newBuilder(String prefabName) { EntityBuilder builder = newBuilder(); if (!builder.addPrefab(prefabName)) { logger.warn("Unable to instantiate unknown prefab: \"{}\"", prefabName); } return builder; }
Source:
<code>private InsertType updateDropInteraction(int dropAction, @Nullable Transferable transferable) { DragDropInteraction interaction = <START> (DragDropInteraction)myCurrentInteraction; <END> assert interaction != null; if (transferable == null) { return null; } DnDTransferItem item = NlModel.getTransferItem(transferable, false ); if (item == null) { return null; } ScreenView screenView = mySurface.getScreenView(myLastMouseX, myLastMouseY); if (screenView == null) { return null; } NlModel model = screenView.getModel(); DragType dragType = dropAction == DnDConstants.ACTION_COPY ? DragType.COPY : DragType.MOVE; InsertType insertType = model.determineInsertType(dragType, item, false ); interaction.setType(dragType); interaction.setTransferItem(item); List<NlComponent> dragged = interaction.getDraggedComponents(); List<NlComponent> components; if (insertType.isMove()) { components = model.getSelectionModel().getSelection(); } else { components = model.createComponents(screenView, item, insertType); if (components == null) { return null; } } if (dragged.size() != components.size()) { return null; } for (int index=0; index < dragged.size(); index++) { components.get(index).x = dragged.get(index).x; components.get(index).y = dragged.get(index).y; } dragged.clear(); dragged.addAll(components); return insertType; }</code><technical_language>Space cast</technical_language>

Target:
private InsertType updateDropInteraction(int dropAction, @Nullable Transferable transferable) { DragDropInteraction interaction = (DragDropInteraction)myCurrentInteraction; assert interaction != null; if (transferable == null) { return null; } DnDTransferItem item = NlModel.getTransferItem(transferable, false ); if (item == null) { return null; } ScreenView screenView = mySurface.getScreenView(myLastMouseX, myLastMouseY); if (screenView == null) { return null; } NlModel model = screenView.getModel(); DragType dragType = dropAction == DnDConstants.ACTION_COPY ? DragType.COPY : DragType.MOVE; InsertType insertType = model.determineInsertType(dragType, item, false ); interaction.setType(dragType); interaction.setTransferItem(item); List<NlComponent> dragged = interaction.getDraggedComponents(); List<NlComponent> components; if (insertType.isMove()) { components = model.getSelectionModel().getSelection(); } else { components = model.createComponents(screenView, item, insertType); if (components == null) { return null; } } if (dragged.size() != components.size()) { throw new AssertionError("Problem with drop: dragged.size != components.size"); } for (int index = 0; index < dragged.size(); index++) { components.get(index).x = dragged.get(index).x; components.get(index).y = dragged.get(index).y; } dragged.clear(); dragged.addAll(components); return insertType; }
Source:
<code>public MergeableInfo apply(RevisionResource resource) throws AuthException, ResourceConflictException, BadRequestException, OrmException, IOException { Change change = resource.getChange(); <START> change.getProject(); <END> PatchSet ps = resource.getPatchSet(); MergeableInfo result = new MergeableInfo(); if (!change.getStatus().isOpen()) { throw new ResourceConflictException("change is " + Submit.status(change)); } else if (!ps.getId().equals(change.currentPatchSetId())) { return result; } result.submitType = submitType.apply(resource); result.mergeable = change.isMergeable(); Repository git = gitManager.openRepository(change.getProject()); try { Map<String, Ref> refs = git.getRefDatabase().getRefs(RefDatabase.ALL); Ref ref = refs.get(change.getDest().get()); if (force || isStale(change, ref)) { result.mergeable = refresh(change, ps, result.submitType, git, refs, ref); } if (otherBranches) { result.mergeableInto = new ArrayList<>(); ProjectConfig cfg = projectCache.get(change.getProject()).getConfig(); BranchOrderSection branchOrder = cfg.getBranchOrderSection(); int prefixLen = Constants.R_HEADS.length(); for (String n : branchOrder.getMoreStable(ref.getName())) { Ref other = git.getRef(n); if (isMergeable(change, ps, SubmitType.CHERRY_PICK, git, refs, other)) { result.mergeableInto.add(other.getName().substring(prefixLen)); } } } } finally { git.close(); } return result; }</code><technical_language>dead code, this line useful side effect</technical_language>

Target:
public MergeableInfo apply(RevisionResource resource) throws AuthException, ResourceConflictException, BadRequestException, OrmException, IOException { Change change = resource.getChange(); PatchSet ps = resource.getPatchSet(); MergeableInfo result = new MergeableInfo(); if (!change.getStatus().isOpen()) { throw new ResourceConflictException("change is " + Submit.status(change)); } else if (!ps.getId().equals(change.currentPatchSetId())) { return result; } result.submitType = submitType.apply(resource); result.mergeable = change.isMergeable(); Repository git = gitManager.openRepository(change.getProject()); try { Map<String, Ref> refs = git.getRefDatabase().getRefs(RefDatabase.ALL); Ref ref = refs.get(change.getDest().get()); if (force || isStale(change, ref)) { result.mergeable = refresh(change, ps, result.submitType, git, refs, ref); } if (otherBranches) { result.mergeableInto = new ArrayList<>(); BranchOrderSection branchOrder = projectCache.get(change.getProject()).getBranchOrderSection(); if (branchOrder != null) { int prefixLen = Constants.R_HEADS.length(); for (String n : branchOrder.getMoreStable(ref.getName())) { Ref other = refs.get(n); if (other == null) { continue; } if (isMergeable(change, ps, SubmitType.CHERRY_PICK, git, refs, other)) { result.mergeableInto.add(other.getName().substring(prefixLen)); } } } } } finally { git.close(); } return result; }
Source:
<code>private void createBranchesArea(Composite parent, FormToolkit toolkit, int span) { branchSection = createSection(parent, toolkit, span); branchSection.setText(UIText.CommitEditorPage_SectionBranchesEmpty); Composite branchesArea = createSectionClient(branchSection, toolkit); branchViewer = new TableViewer(toolkit.createTable(branchesArea, SWT.V_SCROLL | SWT.H_SCROLL)); Control control = branchViewer.getControl(); <START> if (control != null) { <END> control.setData(FormToolkit.KEY_DRAW_BORDER, FormToolkit.TREE_BORDER); GridDataFactory.fillDefaults().grab(true, true) .hint(SWT.DEFAULT, 50).applyTo(control); addToFocusTracking(control); } branchViewer.setSorter(new ViewerSorter()); branchViewer.setLabelProvider(new GitLabelProvider() { @Override public String getText(Object element) { return Repository.shortenRefName(super.getText(element)); } }); branchViewer.setContentProvider(ArrayContentProvider.getInstance()); updateSectionClient(branchSection, branchesArea, toolkit); }</code><technical_language>This null check is unnecessary, control is != null</technical_language>

Target:
private void createBranchesArea(Composite parent, FormToolkit toolkit, int span) { branchSection = createSection(parent, toolkit, span); branchSection.setText(UIText.CommitEditorPage_SectionBranchesEmpty); Composite branchesArea = createSectionClient(branchSection, toolkit); branchViewer = new TableViewer(toolkit.createTable(branchesArea, SWT.V_SCROLL | SWT.H_SCROLL)); Control control = branchViewer.getControl(); control.setData(FormToolkit.KEY_DRAW_BORDER, FormToolkit.TREE_BORDER); GridDataFactory.fillDefaults().grab(true, true).hint(SWT.DEFAULT, 50) .applyTo(control); addToFocusTracking(control); branchViewer.setSorter(new ViewerSorter()); branchViewer.setLabelProvider(new GitLabelProvider() { @Override public String getText(Object element) { return Repository.shortenRefName(super.getText(element)); } }); branchViewer.setContentProvider(ArrayContentProvider.getInstance()); updateSectionClient(branchSection, branchesArea, toolkit); }
Source:
<code>public Builder maxEntries(int maxEntries) { <START> if (maxEntries == 0) throw new NullPointerException("maxEntries == 0"); <END> this.maxEntries = maxEntries; return this; }</code><technical_language>more sense IllegalArgumentException instead of NullPointerException</technical_language>

Target:
public Builder maxEntries(int maxEntries) { if (maxEntries <= 0) throw new IllegalArgumentException("maxEntries <= 0"); this.maxEntries = maxEntries; return this; }
Source:
<code>TotpAuthenticator(BukkitService bukkitService) { <START> this(new GoogleAuthenticator(), bukkitService); <END> }</code><technical_language>This creates Base32 keys SHA1 default. SHA1 is broken stronger do relevant in this case</technical_language>

Target:
TotpAuthenticator(BukkitService bukkitService) { this.authenticator = createGoogleAuthenticator(); this.bukkitService = bukkitService; }
Source:
<code>long getsurePressReleaseProc (long gesture, int n_press, double x, double y, long user_data) { <START> long event = GTK.gtk_get_current_event(); <END> long result = 0; switch ((int) user_data) { case GESTURE_PRESSED: result = gtk_gesture_press_event(gesture, n_press, x, y); break; case GESTURE_RELEASED: result = gtk_gesture_release_event(gesture, n_press, x, y); break; } gdk_event_free(event); return result; }</code><technical_language>If feeding GdkEvent callback methods remove this line -- fetching event freeing for reason. :)</technical_language>

Target:
long getsurePressReleaseProc (long gesture, int n_press, double x, double y, long user_data) { long event = GTK.gtk_get_current_event(); long result = 0; switch ((int) user_data) { case GESTURE_PRESSED: result = gtk_gesture_press_event(gesture, n_press, x, y, event); break; case GESTURE_RELEASED: result = gtk_gesture_release_event(gesture, n_press, x, y, event); break; } gdk_event_free(event); return result; }
Source:
<code>void receiveTwoMessagesAndComplete(MessagingEntityType entityType, boolean isSessionEnabled) { setSenderAndReceiver(entityType, isSessionEnabled); int maxMessages = 2; final String messageId = UUID.randomUUID().toString(); final ServiceBusMessage message = getMessage(messageId, isSessionEnabled); sendMessage(message); sendMessage(message); IterableStream<ServiceBusReceivedMessage> messages = receiver.receive(maxMessages, TIMEOUT); final List<ServiceBusReceivedMessage> asList = messages.stream().collect(Collectors.toList()); assertEquals(maxMessages, asList.size()); <START> for (ServiceBusReceivedMessage receivedMessage : asList) { <END> assertMessageEquals(receivedMessage, messageId, isSessionEnabled); receiver.complete(receivedMessage); messagesPending.decrementAndGet(); } }</code><technical_language>A is count number of time loop assert end creating list eagerly. java int count = 0; for (Message m : messages) { count++; } assertEquals(2, count);</technical_language>

Target:
void receiveTwoMessagesAndComplete(MessagingEntityType entityType, boolean isSessionEnabled) { setSenderAndReceiver(entityType, isSessionEnabled); int maxMessages = 2; final String messageId = UUID.randomUUID().toString(); final ServiceBusMessage message = getMessage(messageId, isSessionEnabled); sendMessage(message); sendMessage(message); IterableStream<ServiceBusReceivedMessage> messages = receiver.receive(maxMessages, TIMEOUT); int receivedMessageCount = 0; for (ServiceBusReceivedMessage receivedMessage : messages) { assertMessageEquals(receivedMessage, messageId, isSessionEnabled); receiver.complete(receivedMessage); messagesPending.decrementAndGet(); ++receivedMessageCount; } assertEquals(maxMessages, receivedMessageCount); }
Source:
<code>public List<RpslObject> handleAutNumQuery(final Query query, final HttpServletRequest request) { final int contextId = System.identityHashCode(Thread.currentThread()); final InetAddress remoteAddress = InetAddresses.forString(request.getRemoteAddr()); final List<RpslObject> resultAutNum = Lists.newArrayList(); final List<RpslObject> resultAsBlock = Lists.newArrayList(); try { queryHandler.streamResults(query, remoteAddress, contextId, new ApiResponseHandler() { @Override public void handle(final ResponseObject responseObject) { if (responseObject instanceof RpslObject && ((RpslObject) responseObject).getType() == AUT_NUM) { resultAutNum.add((RpslObject) responseObject); <START> } else if(responseObject instanceof RpslObject && ((RpslObject) responseObject).getType() == AS_BLOCK) { <END> resultAsBlock.add((RpslObject) responseObject); } } }); return resultAutNum.isEmpty() ? resultAsBlock : resultAutNum; } catch (final QueryException e) { if (e.getCompletionInfo() == QueryCompletionInfo.BLOCKED) { throw tooManyRequests(); } else { LOGGER.error(e.getMessage(), e); throw new IllegalStateException("query error"); } } }</code><technical_language>Fix formatting - put else block - easier read, error-prone. if () { } else { if () { } }</technical_language>

Target:
public List<RpslObject> handleAutNumQuery(final Query query, final HttpServletRequest request) { final InetAddress remoteAddress = InetAddresses.forString(request.getRemoteAddr()); final List<RpslObject> resultAutNum = Lists.newArrayList(); final List<RpslObject> resultAsBlock = Lists.newArrayList(); try { queryHandler.streamResults(query, remoteAddress, 0, new ApiResponseHandler() { @Override public void handle(final ResponseObject responseObject) { if (responseObject instanceof RpslObject) { ObjectType objectType = ((RpslObject) responseObject).getType(); switch (objectType) { case AUT_NUM: { resultAutNum.add((RpslObject) responseObject); break; } case AS_BLOCK: { resultAsBlock.add((RpslObject) responseObject); break; } default: { throw new UnexpectedException("Expected AUT_NUM or AS_Block but found " + objectType); } } } } }); return resultAutNum.isEmpty() ? resultAsBlock : resultAutNum; } catch (final QueryException e) { if (e.getCompletionInfo() == QueryCompletionInfo.BLOCKED) { throw tooManyRequests(); } else { LOGGER.error(e.getMessage(), e); throw new IllegalStateException("query error"); } } }
Source:
<code>public void shouldExistEnumHashToValueMapping() throws Exception { for (Map.Entry<Locator, List<IMetric>> entry : locatorToMetrics.entrySet()) { Locator locator = entry.getKey(); List<IMetric> metrics = entry.getValue(); for (IMetric metric : metrics) { datastaxEnumIO.putAsync(locator, metric.getCollectionTime(), (BluefloodEnumRollup) metric.getMetricValue(), Granularity.FULL); } } AstyanaxReader reader = AstyanaxReader.getInstance(); final List<Locator> locators = new ArrayList<Locator>() {{ addAll(locatorToMetrics.keySet()); }}; Map<Locator, List<String>> mapping = reader.getEnumStringMappings(locators); <START> org.junit.Assert.assertEquals("locator -> enum string mapping size", locatorToMetrics.size(), mapping.size()); <END> for (Map.Entry<Locator, List<String>> entry : mapping.entrySet()) { List<String> enumValues = entry.getValue(); assertTrue(String.format("metrics size for locator %s is not bigger than possible enum values defined for these tests", entry.getKey()), enumValues.size() <= enumValueList.size()); } }</code><technical_language>minor, do want remove org.junit.Assert. prefix</technical_language>

Target:
public void shouldExistEnumHashToValueMapping() throws Exception { for (Map.Entry<Locator, List<IMetric>> entry : locatorToMetrics.entrySet()) { Locator locator = entry.getKey(); List<IMetric> metrics = entry.getValue(); for (IMetric metric : metrics) { ResultSetFuture future = datastaxEnumIO.putAsync(locator, metric.getCollectionTime(), (BluefloodEnumRollup) metric.getMetricValue(), Granularity.FULL); future.get().all(); } } AstyanaxReader reader = AstyanaxReader.getInstance(); final List<Locator> locators = new ArrayList<Locator>() {{ addAll(locatorToMetrics.keySet()); }}; Map<Locator, List<String>> mapping = reader.getEnumStringMappings(locators); assertEquals("locator -> enum string mapping size", locatorToMetrics.size(), mapping.size()); for (Map.Entry<Locator, List<String>> entry : mapping.entrySet()) { List<String> enumValues = entry.getValue(); assertTrue(String.format("metrics size for locator %s is not bigger than possible enum values defined for these tests", entry.getKey()), enumValues.size() <= enumValueList.size()); } }
Source:
<code>public void testConcat() throws Exception { FileSystem mockFs = Mockito.mock(FileSystem.class); Mockito.doAnswer(invocation -> { Object[] args = invocation.getArguments(); Path target = (Path)args[0]; Path[] src = (Path[]) args[1]; mockConcat(target, src); return null; }).when(mockFs).concat(any(Path.class), any(Path[].class)); Concat.setTstFs(mockFs); shellRun(0, "-concat", dstPath.toString(), testRootDir+"/file-*"); <START> assertTrue(lfs.exists(dstPath)); <END> assertEquals(1, lfs.listStatus(testRootDir).length); }</code><technical_language>relevant ContractTestUtils assertion here, for error reporting</technical_language>

Target:
public void testConcat() throws Exception { ByteArrayOutputStream out = new ByteArrayOutputStream(); for (int i = 0; i < 10; i++) { try (InputStream in = lfs .open(new Path(testRootDir, String.format("file-%02d", i)))) { IOUtils.copyBytes(in, out, 1024); } } byte[] expectContent = out.toByteArray(); FileSystem mockFs = Mockito.mock(FileSystem.class); Mockito.doAnswer(invocation -> { Object[] args = invocation.getArguments(); Path target = (Path)args[0]; Path[] src = (Path[]) args[1]; mockConcat(target, src); return null; }).when(mockFs).concat(any(Path.class), any(Path[].class)); Concat.setTestFs(mockFs); shellRun(0, "-concat", dstPath.toString(), testRootDir+"/file-*"); ContractTestUtils .assertPathExists(lfs, "The target file doesn't exist.", dstPath); Assertions.assertThat(lfs.listStatus(testRootDir).length).isEqualTo(1); assertEquals(expectContent.length, lfs.getFileStatus(dstPath).getLen()); out = new ByteArrayOutputStream(); try (InputStream in = lfs.open(dstPath)) { IOUtils.copyBytes(in, out, 1024); } byte[] concatedContent = out.toByteArray(); assertEquals(expectContent.length, concatedContent.length); ContractTestUtils.compareByteArrays(expectContent, concatedContent, expectContent.length); }
Source:
<code>public void parseArguments(List<String> argsList) throws Exception { args = new ParametersParser( <START> Util.loadProperties(getClass(), "arguments.properties") <END> ).parse(argsList); }</code><technical_language>util is a bad name for in cli parser, flat namespace nature import enable rename conflict. I suggest this loadProperties static method ParametersParser, constructor receives resource load properties</technical_language>

Target:
public void parseArguments(List<String> argsList) throws Exception { args = new ParametersParser( getClass().getResourceAsStream("arguments.properties") ).parse(argsList); }
Source:
<code>public CaseModelQuerySetMatcher(String modelId, Map<Integer, Integer> multiplicityMap) { caseDbRoot = <START> XPathReference.getPathExpr("instance('" + modelId + "')/casedb/case").getReference(); <END> caseDbRoot.setMultiplicity(0, 0); this.multiplicityMap = multiplicityMap; membershipIndexes = new Vector<>(); membershipIndexes.add(CaseInstanceTreeElement.CASE_ID_EXPR); membershipIndexes.add(CaseInstanceTreeElement.CASE_ID_EXPR_TWO); querySetTransforms.add(new CaseIdentityQuerySetTransform()); }</code><technical_language>ugly - modelId 'casedb'? current code path</technical_language>

Target:
private CaseModelQuerySetMatcher(String modelId, Map<Integer, Integer> multiplicityMap) { caseDbRoot = XPathReference.getPathExpr("instance('" + modelId + "')/casedb/case").getReference(); caseDbRoot.setMultiplicity(0, 0); this.multiplicityMap = multiplicityMap; membershipIndexes = new Vector<>(); membershipIndexes.add(CaseInstanceTreeElement.CASE_ID_EXPR); membershipIndexes.add(CaseInstanceTreeElement.CASE_ID_EXPR_TWO); addQuerySetTransform(new CaseIdentityQuerySetTransform()); }
Source:
<code>protected void configure() { <START> System.out.println("JunitGuiceModule binder"); <END> newSetBinder(binder(), TestRunner.class).addBinding().to(JUnitTestRunner.class); }</code><technical_language>remove</technical_language>

Target:
protected void configure() { newSetBinder(binder(), TestRunner.class).addBinding().to(JUnitTestRunner.class); }
Source:
<code>public void shouldReturnExpectedAccessibilityServiceList() throws Exception { List<ServiceInfo> expected = new ArrayList<>(Arrays.asList(new ServiceInfo())); shadowAccessibilityManager.setAccessibilityServiceList(expected); assertThat(getAccessibilityManager().getAccessibilityServiceList()).isEqualTo(expected); <START> } <END></code><technical_language>Hmm right, a great do this. you, feel free do a couple suggestions a. A quick google search revealed: @FixMethodOrder(MethodSorters.NAME_ASCENDING) b. a variant example @test public void testResetA() { checkOrSetInstance(); } @test public void testResetB() { checkOrSetInstance(); } public void checkOrSetInstance(() { if (sShadow != null) { sShadow = getAccessibilityManagerInstance(); } else { assertNotEquals(sShadow, getAccessibilityManagerInstance()); } }</technical_language>

Target:
public void shouldReturnExpectedAccessibilityServiceList() { List<ServiceInfo> expected = new ArrayList<>(Arrays.asList(new ServiceInfo())); shadowAccessibilityManager.setAccessibilityServiceList(expected); assertThat(accessibilityManager.getAccessibilityServiceList()).isEqualTo(expected); }
Source:
<code>protected void onReveal() { super.onReveal(); <START> commonModelProvider.get().setUiPluginTabSelected(this.getProxy().getNameToken()); <END> }</code><technical_language>Please getTargetHistoryToken() is defined TabContentProxy interface. (It's in onSetDynamicTabContentUrl method above.)</technical_language>

Target:
protected void onReveal() { super.onReveal(); commonModelProvider.get().setPluginTabSelected(getProxy().getTargetHistoryToken()); }
Source:
<code>public static void loadToStore(KeyStore keyStore, char[] keyStorePassword, String keyStorePath) throws KeyStoreGenerationException { FileInputStream fileInputStream = null; try { if (keyStorePath != null) { fileInputStream = new FileInputStream(keyStorePath); keyStore.load(fileInputStream, keyStorePassword); } } catch (NoSuchAlgorithmException e) { <START> String msg = "Requested cryptographic algorithm is not available in the environment."; <END> logger.error(msg, e); throw new KeyStoreGenerationException(msg, e); } catch (CertificateException e) { String msg = "Error working with certificate related to, " + keyStorePath; logger.error(msg, e); throw new KeyStoreGenerationException(msg, e); } catch (IOException e) { String msg = "File error while working with file, " + keyStorePath; logger.error(msg, e); throw new KeyStoreGenerationException(msg, e); } finally { try { if (fileInputStream != null) { fileInputStream.close(); } } catch (IOException e) { String msg = "File error while closing the file, " + keyStorePath; logger.error(msg, e); throw new KeyStoreGenerationException(msg,e); } } }</code><technical_language>Log throw is generally considered anti-pattern. throw exception logging in instances similar this</technical_language>

Target:
public static void loadToStore(KeyStore keyStore, char[] keyStorePassword, String keyStorePath) throws KeyStoreGenerationException { FileInputStream fileInputStream = null; try { if (keyStorePath != null) { fileInputStream = new FileInputStream(keyStorePath); keyStore.load(fileInputStream, keyStorePassword); } } catch (NoSuchAlgorithmException e) { throw new KeyStoreGenerationException( "Requested cryptographic algorithm is not available in the environment.", e); } catch (CertificateException e) { throw new KeyStoreGenerationException("Error working with certificate related to, " + keyStorePath, e); } catch (IOException e) { throw new KeyStoreGenerationException("File error while working with file, " + keyStorePath, e); } finally { try { if (fileInputStream != null) { fileInputStream.close(); } } catch (IOException e) { throw new KeyStoreGenerationException("File error while closing the file, " + keyStorePath,e); } } }
Source:
<code>public int bruteForceSite(SiteNode siteNode, File payloadFile) { ScanTarget scanTarget = createScanTarget(siteNode); BruteForce bf = this.startScan(scanTarget, null, payloadFile, false); return bf.getScanId(); <START> } <END></code><technical_language>validate siteNode is null fail (and break panel)</technical_language>

Target:
public int bruteForceSite(SiteNode siteNode, File payloadFile) { if (siteNode == null) { throw new IllegalArgumentException("Null site node supplied"); } ScanTarget scanTarget = createScanTarget(siteNode); BruteForce bf = this.startScan(scanTarget, null, payloadFile, false); return bf.getScanId(); }
Source:
<code>ReferencedEnvelope initTileRequest(ReferencedEnvelope bbox, int width, int height, String time) throws IOException { ReferencedEnvelope gridEnvelope = bbox; String requestSrs = srsName; try { String code = null; Integer epsgCode = CRS.lookupEpsgCode(bbox.getCoordinateReferenceSystem(), false); if (epsgCode != null) { code = "EPSG:" + epsgCode; } else { code = CRS.lookupIdentifier(bbox.getCoordinateReferenceSystem(), false); } if (code != null && validSRS.contains(code)) { requestSrs = code; } else { gridEnvelope = bbox.transform(getCoordinateReferenceSystem(), true); if (gridEnvelope.getWidth() < gridEnvelope.getHeight()) { height = (int) Math .round(width * gridEnvelope.getHeight() / gridEnvelope.getWidth()); } else { width = (int) Math .round(height * gridEnvelope.getWidth() / gridEnvelope.getHeight()); } } } catch (Exception e) { throw new IOException("Could not reproject the request envelope", e); } GetTileRequest tileRequest = wmts.createGetTileRequest(); setTileRequest(tileRequest); tileRequest.setCRS(gridEnvelope.getCoordinateReferenceSystem()); tileRequest.setLayer(layer); tileRequest.setRequestedHeight(height); tileRequest.setRequestedWidth(width); tileRequest.setRequestedBBox(gridEnvelope); tileRequest.setRequestedTime(time); try { this.requestCRS = CRS.decode(requestSrs); } catch (Exception e) { throw new IOException("Could not decode request SRS " + requestSrs); } <START> ReferencedEnvelope requestEnvelope = gridEnvelope; <END> this.width = width; this.height = height; return gridEnvelope; }</code><technical_language>Unused variable</technical_language>

Target:
ReferencedEnvelope initTileRequest(ReferencedEnvelope bbox, int width, int height, String time) throws IOException { ReferencedEnvelope gridEnvelope = bbox; String requestSrs = srsName; try { String code = null; Integer epsgCode = CRS.lookupEpsgCode(bbox.getCoordinateReferenceSystem(), false); if (epsgCode != null) { code = "EPSG:" + epsgCode; } else { code = CRS.lookupIdentifier(bbox.getCoordinateReferenceSystem(), false); } if (code != null && validSRS.contains(code)) { requestSrs = code; } else { gridEnvelope = bbox.transform(getCoordinateReferenceSystem(), true); if (gridEnvelope.getWidth() < gridEnvelope.getHeight()) { height = (int) Math .round(width * gridEnvelope.getHeight() / gridEnvelope.getWidth()); } else { width = (int) Math .round(height * gridEnvelope.getWidth() / gridEnvelope.getHeight()); } } } catch (Exception e) { throw new IOException("Could not reproject the request envelope", e); } GetTileRequest tileRequest = wmts.createGetTileRequest(); setTileRequest(tileRequest); tileRequest.setCRS(gridEnvelope.getCoordinateReferenceSystem()); tileRequest.setLayer(layer); tileRequest.setRequestedHeight(height); tileRequest.setRequestedWidth(width); tileRequest.setRequestedBBox(gridEnvelope); tileRequest.setRequestedTime(time); try { this.requestCRS = CRS.decode(requestSrs); } catch (Exception e) { throw new IOException("Could not decode request SRS " + requestSrs); } this.width = width; this.height = height; return gridEnvelope; }
Source:
<code>protected boolean validateInputManagementNetwork() { if (!findInputManagementNetwork()) return false; final NetworkClusterValidatorBase networkClusterValidator = createNetworkClusterValidator(); <START> return validate(networkClusterValidator.networkBelongsToClusterDataCenter(getCluster(), managementNetwork)) <END> && validate(networkClusterValidator.managementNetworkRequired(managementNetwork)) && validate(networkClusterValidator.managementNetworkNotExternal(managementNetwork)); }</code><technical_language>sense validation in update case well</technical_language>

Target:
protected boolean validateInputManagementNetwork() { if (!findInputManagementNetwork()) { return false; } final NetworkClusterValidatorBase networkClusterValidator = createNetworkClusterValidator(); return validate(networkClusterValidator.networkBelongsToClusterDataCenter(getCluster(), managementNetwork)) && validate(networkClusterValidator.managementNetworkRequired(managementNetwork)) && validate(networkClusterValidator.managementNetworkNotExternal(managementNetwork)); }