auphong2707/dl4se-code-review-dataset huggingface dataset:
Source:
<code>Response readResponse(HttpURLConnection connection) throws IOException { int status = connection.getResponseCode(); String reason = connection.getResponseMessage(); List<Header> headers = new ArrayList<Header>(); for (Map.Entry<String, List<String>> field : connection.getHeaderFields().entrySet()) { String name = field.getKey(); for (String value : field.getValue()) { headers.add(new Header(name, value)); } } String mimeType = connection.getContentType(); int length = connection.getContentLength(); InputStream stream; if (status == 200) { stream = connection.getInputStream(); } else { stream = connection.getErrorStream(); } <START> stream = new BufferedInputStream(stream); <END> TypedInput responseBody = new TypedInputStream(mimeType, length, stream); return new Response(status, reason, headers, responseBody); }</code><technical_language>curious: buffer</technical_language>

Target:
Response readResponse(HttpURLConnection connection) throws IOException { int status = connection.getResponseCode(); String reason = connection.getResponseMessage(); List<Header> headers = new ArrayList<Header>(); for (Map.Entry<String, List<String>> field : connection.getHeaderFields().entrySet()) { String name = field.getKey(); for (String value : field.getValue()) { headers.add(new Header(name, value)); } } String mimeType = connection.getContentType(); int length = connection.getContentLength(); InputStream stream; if (status == 200) { stream = connection.getInputStream(); } else { stream = connection.getErrorStream(); } TypedInput responseBody = new TypedInputStream(mimeType, length, stream); return new Response(status, reason, headers, responseBody); }
Source:
<code>public ScanRuntimeProvider getScanRuntimeProvider(ScanContext scanContext) { Optional<BulkDecodingFormat<RowData>> bulkDecodingFormat = discoverBulkDecodingFormat(); if (!partitionKeys.isEmpty() && getOrFetchPartitions().isEmpty()) { return InputFormatProvider.of(new CollectionInputFormat<>(new ArrayList<>(), null)); } else if (bulkDecodingFormat.isPresent()) { return SourceProvider.of(createBulkFormatSource(bulkDecodingFormat.get(), scanContext)); } return new DataStreamScanProvider() { @Override <START> public DataStream<RowData> produceDataStream(StreamExecutionEnvironment execEnv) { <END> TypeInformation<RowData> typeInfo = InternalTypeInfo.of( getProducedDataType().getLogicalType()); return execEnv.addSource( new InputFormatSourceFunction<>(getInputFormat(), typeInfo), String.format("Filesystem(%s)", tableIdentifier), typeInfo); } @Override public boolean isBounded() { return true; } }; }</code><technical_language>avoid ContinuousFileMonitoringFunction here? return SourceFunctionProvider of InputFormatSourceFunction directly</technical_language>

Target:
public ScanRuntimeProvider getScanRuntimeProvider(ScanContext scanContext) { if (!partitionKeys.isEmpty() && getOrFetchPartitions().isEmpty()) { return InputFormatProvider.of(new CollectionInputFormat<>(new ArrayList<>(), null)); } else if (bulkReaderFormat != null) { return sourceProvider(bulkReaderFormat, scanContext); } else if (formatFactory != null) { return SourceFunctionProvider.of( new InputFormatSourceFunction<>( getInputFormat(), InternalTypeInfo.of(getProducedDataType().getLogicalType())), true); } else if (deserializationFormat != null) { throw new UnsupportedOperationException("The deserializationFormat is under developing."); } else { throw new TableException("Can not find format factory."); } }
Source:
<code>public void appendConstraints(AllocationAttempt attempt, AllocationLog log, List<Constraint> constraints) { for (Instance instance : attempt.getInstances()) { List<Volume> volumes = InstanceHelpers.extractVolumesFromMounts(instance, objectManager); for (Volume v : volumes) { if (VolumeConstants.ACCESS_MODE_SINGLE_HOST_RW.equals(v.getAccessMode())) { Long hostID = DataAccessor.fieldLong(v, VolumeConstants.FIELD_LAST_ALLOCATED_HOST_ID); <START> if (hostID != null ) { <END> Set<Long> hostIds = allocatorDao.findHostsWithVolumeInUse(v.getId()); boolean hardConstraint = false; if (hostIds.size() == 0) { hardConstraint = false; } else if (hostIds.size() == 1) { hardConstraint = true; for(Long id: hostIds) { hostID = id; } } else { throw new FailedToAllocate("SingleHostRW volume is used by mutiple hosts"); } constraints.add(new VolumeAccessModeSingleHostConstraint(hostID, v.getId(), hardConstraint)); } } else if (VolumeConstants.ACCESS_MODE_SINGLE_INSTANCE_RW.equals(v.getAccessMode())) { List<Long> currentlyUsedBy = allocatorDao.getInstancesWithVolumeMounted(v.getId(), instance.getId()); if (currentlyUsedBy.size() > 0) { constraints.add(new VolumeAccessModeSingleInstanceConstraint(v.getId(), v.getAccessMode(), currentlyUsedBy)); } } } } }</code><technical_language>Remove this check, right? want add this constraint if hostID == null. solely based of hostIds returned findHostsWithVolumeInUse Though, v.hostId a fallback if mounts if mounts v.hostId is null, dont add constraint all</technical_language>

Target:
public void appendConstraints(AllocationAttempt attempt, AllocationLog log, List<Constraint> constraints) { for (Instance instance : attempt.getInstances()) { List<Volume> volumes = InstanceHelpers.extractVolumesFromMounts(instance, objectManager); for (Volume v : volumes) { if (VolumeConstants.ACCESS_MODE_SINGLE_HOST_RW.equals(v.getAccessMode())) { Long hostID = null; Object hostIdObject = DataAccessor.fromDataFieldOf(v).withKey(VolumeConstants.FIELD_LAST_ALLOCATED_HOST_ID).get(); if ( hostIdObject != null) { hostID = Long.parseLong(hostIdObject.toString()); } Set<Long> hostIds = allocatorDao.findHostsWithVolumeInUse(v.getId()); boolean hardConstraint = false; if (hostIds.size() == 0) { hardConstraint = false; } else if (hostIds.size() == 1) { hardConstraint = true; for(Long id: hostIds) { hostID = id; } } else { throw new FailedToAllocate("SingleHostRW volume is used by mutiple hosts"); } if (hostID != null) { constraints.add(new VolumeAccessModeSingleHostConstraint(hostID, v.getId(), hardConstraint)); } } else if (VolumeConstants.ACCESS_MODE_SINGLE_INSTANCE_RW.equals(v.getAccessMode())) { List<Long> currentlyUsedBy = allocatorDao.getInstancesWithVolumeMounted(v.getId(), instance.getId()); if (currentlyUsedBy.size() > 0) { constraints.add(new VolumeAccessModeSingleInstanceConstraint(v.getId(), v.getAccessMode(), currentlyUsedBy)); } } } } }
Source:
<code>public final Response intercept(Chain chain) throws IOException { Request request = chain.request(); Exception lastException = null; List<String> failoverUris = uris; <START> if (randomize) { <END> failoverUris = new ArrayList<>(uris); Collections.shuffle(failoverUris); } for (String uri : failoverUris) { request = redirectRequest(request, uri); try { return chain.proceed(request); } catch (SocketTimeoutException | UnknownHostException | HttpRetryException | MalformedURLException | SocketException | UnknownServiceException e) { lastException = e; logger.warn("Failed to send request to " + request.url(), e); } catch (IOException e) { throw e; } } throw new IllegalStateException( "Could not connect to any node. Please check that the URIs are valid and servers are up.", lastException); }</code><technical_language>this randomization happen in constructor</technical_language>

Target:
public Response intercept(Chain chain) throws IOException { Request request = chain.request(); Exception lastException = null; String lastUri = null; for (String uri : uris) { if (lastUri != null) { logger.warn("Redirecting request from to {}", lastUri, uri); } request = redirectRequest(request, uri); try { return chain.proceed(request); } catch (SocketTimeoutException | UnknownHostException | HttpRetryException | MalformedURLException | SocketException | UnknownServiceException e) { lastException = e; lastUri = uri; logger.warn("Failed to send request to " + request.url(), e); } } throw new IllegalStateException("Could not connect to any of the following servers: " + uris + ". " + "Please check that the URIs are correct and servers are accessible.", lastException); }
Source:
<code>private Long getRequestTimeout(SamzaResourceRequest request) { <START> Optional<Long> controlActionRequestExpirytimeout = containerManager.getActionExpiryTimeout(request.getProcessorId()); <END> Long changedRequestExpiryTimeout = controlActionRequestExpirytimeout.isPresent() ? controlActionRequestExpirytimeout.get() : new Long(requestExpiryTimeout); return changedRequestExpiryTimeout; }</code><technical_language>Do need this override-able timeout? is a nice thought of? suggest keeping this out for configured value</technical_language>

Target:
private Duration getRequestTimeout(SamzaResourceRequest request) { Optional<Duration> controlActionRequestExpiryTimeout = containerManager.getActionExpiryTimeout(request); return controlActionRequestExpiryTimeout.orElse(Duration.ofMillis(configuredRequestExpiryTimeout)); }
Source:
<code>public void contextDestroyed( ServletContextEvent servletContextEvent ) { Repository jcrRepository = PentahoSystem.get( Repository.class, "jcrRepository", null ); if ( jcrRepository == null ) { <START> System.err.println( "Cannot obtain JCR repository. Exiting" ); <END> return; } if ( !( jcrRepository instanceof JackrabbitRepository ) ) { System.err.println( String.format( "Expected RepositoryImpl, but got: [%s]. Exiting", jcrRepository.getClass().getName() ) ); return; } ( (JackrabbitRepository) jcrRepository ).shutdown(); }</code><technical_language>I this sooner - class a Logger - please log.error here</technical_language>

Target:
public void contextDestroyed( ServletContextEvent servletContextEvent ) { Repository jcrRepository = PentahoSystem.get( Repository.class, "jcrRepository", null ); if ( jcrRepository == null ) { Logger.error( PentahoSystemReadyListener.class.getName(), "Cannot obtain JCR repository. Exiting" ); return; } if ( !( jcrRepository instanceof JackrabbitRepository ) ) { Logger.error( PentahoSystemReadyListener.class.getName(), String.format( "Expected RepositoryImpl, but got: [%s]. Exiting", jcrRepository.getClass().getName() ) ); return; } ( (JackrabbitRepository) jcrRepository ).shutdown(); }
Source:
<code>public PageContainerForm deserialize(final JsonParser jsonParser, final DeserializationContext deserializationContext) throws IOException { final JsonNode jsonNode = jsonParser.readValueAsTree(); <START> final List<ContainerEntry> entries = new ArrayList<>(); <END> for (JsonNode jsonElement : jsonNode) { final String containerId = jsonElement.get(CONTAINER_ID_ATTRIBUTE_NAME).asText(); final String containerUUID = jsonElement.get(CONTAINER_UUID_ATTRIBUTE_NAME).asText(); final ContainerEntry containerEntry = new ContainerEntry(containerId, containerUUID); final JsonNode containerNode = jsonElement.get(CONTAINER_CONTENTLETSID_ATTRIBUTE_NAME); containerNode.forEach(contentId -> containerEntry.addContentId(contentId.textValue())); entries.add(containerEntry); } return new PageContainerForm(entries, jsonNode.toString()); }</code><technical_language>ImmutableList</technical_language>

Target:
public PageContainerForm deserialize(final JsonParser jsonParser, final DeserializationContext deserializationContext) throws IOException { final JsonNode jsonNode = jsonParser.readValueAsTree(); final List<ContainerEntry> entries = new ArrayList<>(); for (final JsonNode jsonElement : jsonNode) { final String containerId = jsonElement.get(CONTAINER_ID_ATTRIBUTE_NAME).asText(); final String containerUUID = jsonElement.get(CONTAINER_UUID_ATTRIBUTE_NAME).asText(); final ContainerEntry containerEntry = new ContainerEntry(containerId, containerUUID); final JsonNode containerNode = jsonElement.get(CONTAINER_CONTENTLETSID_ATTRIBUTE_NAME); containerNode.forEach((JsonNode contentId) -> containerEntry.addContentId(contentId.textValue())); entries.add(containerEntry); } return new PageContainerForm(entries, jsonNode.toString()); }
Source:
<code>void addRequiredFieldsToCacheTableDefinition(TableDefinition cacheTableDefinition, boolean cacheExpiryEnabled) { <START> cacheTableDefinition.attribute(CACHE_TABLE_TIMESTAMP_ADDED, Attribute.Type.LONG); <END> }</code><technical_language>Calculate attribute position store in CacheTableFIFO. needed. data.length - 1 in line 49</technical_language>

Target:
void addRequiredFieldsToCacheTableDefinition(TableDefinition cacheTableDefinition, boolean cacheExpiryEnabled) { cacheTableDefinition.attribute(CACHE_TABLE_TIMESTAMP_ADDED, Attribute.Type.LONG); cachePolicyAttributePosition = cacheTableDefinition.getAttributeList().size() - 1; numColumns = cachePolicyAttributePosition + 1; }
Source:
<code>public void initFromTensorFlow(NodeDef nodeDef, SameDiff initWith, Map<String, AttrValue> attributesForNode, GraphDef graph) { super.initFromTensorFlow(nodeDef, initWith, attributesForNode, graph); <START> if (nodeDef.containsAttr("frame_name")) { <END> val attr = nodeDef.getAttrOrThrow("frame_name"); this.frame_name = attr.getS().toStringUtf8(); } }</code><technical_language>TFGraphMapper 1 liner map properties here</technical_language>

Target:
public void initFromTensorFlow(NodeDef nodeDef, SameDiff initWith, Map<String, AttrValue> attributesForNode, GraphDef graph) { super.initFromTensorFlow(nodeDef, initWith, attributesForNode, graph); }
Source:
<code>public void metadataReceived(final String filename, final Metadata metadata) { if (metadata.keys().contains("ds3-last-modified")) { try { final long lastModifiedMs = Long.parseLong(metadata.get("ds3-last-modified").get(0)); final Path path = outputPath.resolve(filename); final FileTime lastModified = FileTime.from(lastModifiedMs, TimeUnit.MILLISECONDS); Files.setLastModifiedTime(path, lastModified); } catch (final Throwable t) { LOG.error("Failed to restore the last modified date for object: " + filename, t); } } else { <START> LOG.info("Object ("+ filename + ") does not contain a last modified field"); <END> } }</code><technical_language>this a .warn info</technical_language>

Target:
public void metadataReceived(final String filename, final Metadata metadata) { final Path path = outputPath.resolve(filename); Utils.restoreLastModified(filename, metadata, path); }
Source:
<code>public static boolean shouldOpenSampleBoard() { <START> return !TestController.isTestMode() || TestController.shouldTestStartupBoard(); <END> }</code><technical_language>longer need reference TestController here</technical_language>

Target:
public static boolean shouldOpenSampleBoard() { return !isTestMode() || shouldTestStartupBoard(); }
Source:
<code><START> public void setEvaluation(EvaluatedQualityGate g) { <END> requireNonNull(g); checkState(evaluation == null, "QualityGateHolder evaluation can be initialized only once"); this.evaluation = Optional.of(g); }</code><technical_language>![MAJOR](<LINK_0> 'Severity: MAJOR') Remove this null-check of "Optional". [![rule](<LINK_1>](<LINK_2></technical_language>

Target:
public void setEvaluation(EvaluatedQualityGate g) { requireNonNull(g); checkState(evaluation == null, "QualityGateHolder evaluation can be initialized only once"); this.evaluation = g; }
Source:
<code>private void updateDiff() throws EDBException { List<String> keyList = loadKeyList(); for (String key : keyList) { <START> if (key.equals("id") || key.equals("@prevTimestamp") || key.equals("@timestamp")) { <END> continue; } Object first = startState.get(key); Object last = endState.get(key); if (last != null && first != null && first.equals(last)) { continue; } diff.put(key, new Entry(first, last)); differences++; } }</code><technical_language>@</technical_language>

Target:
private void updateDiff() throws EDBException { List<String> keyList = loadKeyList(); for (String key : keyList) { if (key.equals("id") || key.equals("prevTimestamp") || key.equals("timestamp")) { continue; } Object first = startState.get(key); Object last = endState.get(key); if (last != null && first != null && first.equals(last)) { continue; } diff.put(key, new Entry(first, last)); differences++; } }
Source:
<code>public HtsgetResponse getResponse() { final URI reqURI = this.toURI(); try { final HttpURLConnection conn = (HttpURLConnection) reqURI.toURL().openConnection(); conn.setRequestMethod("GET"); conn.connect(); final InputStream is = conn.getInputStream(); final int statusCode = conn.getResponseCode(); final BufferedReader reader = new BufferedReader(new InputStreamReader(is)); final StringBuilder out = new StringBuilder(); String line; while ((line = reader.readLine()) != null) { out.append(line); } final String json = out.toString(); if (400 <= statusCode && statusCode < 500) { final HtsgetErrorResponse err = HtsgetErrorResponse.parse(json); throw new IllegalArgumentException( "Invalid request, received error code: " + statusCode + ", error type: " + err.getError() + ", message: " + err.getMessage()); } else if (statusCode == 200) { return HtsgetResponse.parse(json); } else { <START> throw new IllegalArgumentException("Unrecognized status code: " + statusCode); <END> } } catch (final IOException e) { throw new RuntimeIOException("IOException while attempting htsget download, request: " + reqURI, e); } }</code><technical_language>This IllegalStateException instead</technical_language>

Target:
public HtsgetResponse getResponse() { final URI reqURI = this.toURI(); try { final HttpURLConnection conn = (HttpURLConnection) reqURI.toURL().openConnection(); conn.setRequestMethod("GET"); conn.setRequestProperty("Accept", HtsgetRequest.ACCEPT_TYPE); conn.connect(); final InputStream is = conn.getInputStream(); final int statusCode = conn.getResponseCode(); final String respContentType = conn.getContentType(); if (respContentType != null && !respContentType.isEmpty() && !respContentType.contains(HtsgetRequest.PROTOCOL_VERSION)) { log.warn("Supported htsget protocol version: " + HtsgetRequest.PROTOCOL_VERSION + "may not be compatible with received content type: " + respContentType); } final BufferedReader reader = new BufferedReader(new InputStreamReader(is)); final StringBuilder out = new StringBuilder(); String line; while ((line = reader.readLine()) != null) { out.append(line); } final String json = out.toString(); if (400 <= statusCode && statusCode < 500) { final HtsgetErrorResponse err = HtsgetErrorResponse.parse(json); throw new IllegalArgumentException( "Invalid request, received error code: " + statusCode + ", error type: " + err.getError() + ", message: " + err.getMessage()); } else if (statusCode == 200) { return HtsgetResponse.parse(json); } else { throw new IllegalStateException("Unrecognized status code: " + statusCode); } } catch (final IOException e) { throw new RuntimeIOException("IOException while attempting htsget download, request: " + reqURI, e); } }
Source:
<code>protected boolean canDoAction() { boolean returnValue = isVmExist(); VM vm = getVm(); if (returnValue && (vm != null && vm.getstatus() != VMStatus.Down)) { returnValue = false; addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_VM_IS_NOT_DOWN); } else { returnValue = returnValue && (vm == null || isDiskCanBeAddedToVm(getParameters().getDiskInfo())); if (returnValue && DiskStorageType.IMAGE == getParameters().getDiskInfo().getDiskStorageType()) { returnValue = checkIfImageDiskCanBeAdded(vm); } if (returnValue && getParameters().getDiskInfo().isShareable() && getParameters().getDiskInfo().isBoot()) { returnValue = false; addCanDoActionMessage(VdcBllMessages.SHAREABLE_DISK_IS_NOT_SUPPORTED_FOR_DISK); } <START> ImagesHandler.setDiskAlias(getParameters().getDiskInfo(), getVm()); <END> setAllowSnapshotForDisk(); } return returnValue; }</code><technical_language>If returnValue == false, need run code? question diskAlis, u inserted</technical_language>

Target:
protected boolean canDoAction() { boolean returnValue = isVmExist(); VM vm = getVm(); if (returnValue && (vm != null && vm.getstatus() != VMStatus.Down)) { returnValue = false; addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_VM_IS_NOT_DOWN); } else { returnValue = returnValue && (vm == null || isDiskCanBeAddedToVm(getParameters().getDiskInfo())); if (returnValue && DiskStorageType.IMAGE == getParameters().getDiskInfo().getDiskStorageType()) { returnValue = checkIfImageDiskCanBeAdded(vm); } if (returnValue && getParameters().getDiskInfo().isShareable() && getParameters().getDiskInfo().isBoot()) { returnValue = false; addCanDoActionMessage(VdcBllMessages.SHAREABLE_DISK_IS_NOT_SUPPORTED_FOR_DISK); } ImagesHandler.setDiskAlias(getParameters().getDiskInfo(), getVm()); if (returnValue) { setAllowSnapshotForDisk(); } } return returnValue; }
Source:
<code>public void testInject(final Parameter[] parameters, final Object[] args) { System.out.println("In: " + Arrays.asList(parameters)); System.out.println("args: " + Arrays.asList(args)); try { final Object[] injectedArgs = ReflectionRecipes.inject( parameters, InjectableParameter.Assistant.ALL_INJECTS, args, null, null, null ); System.out.println("injectedArgs: " + Arrays.asList(injectedArgs)); Assert.assertEquals(injectedArgs.length, parameters.length); } catch (final Throwable throwable) { <START> throwable.printStackTrace(); <END> } }</code><technical_language>I Assert.fail() is missing here. Otherwise, test fail in case of exception</technical_language>

Target:
public void testInject(final Parameter[] parameters, final Object[] args) { System.out.println("In: " + Arrays.asList(parameters)); System.out.println("args: " + Arrays.asList(args)); final Object[] injectedArgs = ReflectionRecipes.inject( parameters, InjectableParameter.Assistant.ALL_INJECTS, args, null, null, null ); System.out.println("injectedArgs: " + Arrays.asList(injectedArgs)); Assert.assertEquals(injectedArgs.length, parameters.length); }
Source:
<code>private void applyForEachAddress(BiConsumer<Long, ILogData> logDataProcessor) { summonNecromancer(); nextRead = logHead; while (nextRead <= logTail) { try { final long start = nextRead; <START> final long stopIncluded = Math.min(start + batchReadSize - 1, logTail); <END> nextRead = stopIncluded + 1; final Map<Long, ILogData> range = getLogData(runtime, start, stopIncluded); for (Map.Entry<Long, ILogData> entry : range.entrySet()) { long address = entry.getKey(); ILogData logData = entry.getValue(); if (address != addressProcessed + 1) { throw new IllegalStateException("We missed an entry. It can lead to correctness issues."); } addressProcessed++; if (logData.getType() == DataType.TRIMMED) { throw new IllegalStateException("Unexpected TRIMMED data"); } if (address % STATUS_UPDATE_PACE == 0) { log.info("applyForEachAddress: read up to {}", address); } } invokeNecromancer(range, logDataProcessor); } catch (TrimmedException ex) { log.warn("Error loading data", ex); handleRetry(); } } killNecromancer(); }</code><technical_language>interval terminology here, LeftEndpoint RightEndpoint</technical_language>

Target:
private void applyForEachAddress(BiConsumer<Long, ILogData> logDataProcessor) { summonNecromancer(); nextRead = logHead; while (nextRead <= logTail) { try { final long lower = nextRead; final long upper = Math.min(lower + batchReadSize - 1, logTail); nextRead = upper + 1; Map<Long, ILogData> range = runtime.getAddressSpaceView().fetchAll(ContiguousSet.create( Range.closed(lower, upper), DiscreteDomain.longs()), true); for (Map.Entry<Long, ILogData> entry : range.entrySet()) { long address = entry.getKey(); ILogData logData = entry.getValue(); if (address != addressProcessed + 1) { throw new IllegalStateException("We missed an entry. It can lead to correctness issues."); } addressProcessed++; if (logData.getType() == DataType.TRIMMED) { throw new IllegalStateException("Unexpected TRIMMED data"); } if (address % STATUS_UPDATE_PACE == 0) { log.info("applyForEachAddress: read up to {}", address); } } invokeNecromancer(range, logDataProcessor); } catch (TrimmedException ex) { log.warn("Error loading data", ex); handleRetry(); } } killNecromancer(); }
Source:
<code>public static Map<SystemStream, Integer> calculateUpstreamTaskCounts(Multimap<SystemStream, String> inputToTasks, IOGraph ioGraph) { Map<SystemStream, Integer> outputTaskCount = new HashMap<>(); ioGraph.getNodes().forEach(node -> { <START> int count = node.getInputs().stream().flatMap(spec -> inputToTasks.get(spec.toSystemStream()).stream()) <END> .collect(Collectors.toSet()).size(); outputTaskCount.put(node.getOutput().toSystemStream(), count); }); return outputTaskCount; }</code><technical_language>Also, in case inputs a job w/o number of partitions GroupByPartition, do reconcile propagate EoS marker</technical_language>

Target:
static Map<SystemStream, Integer> calculateUpstreamTaskCounts(Multimap<SystemStream, String> inputToTasks, IOGraph ioGraph) { if (ioGraph == null) { return Collections.EMPTY_MAP; } Map<SystemStream, Integer> outputTaskCount = new HashMap<>(); ioGraph.getNodes().forEach(node -> { int count = node.getInputs().stream().flatMap(spec -> inputToTasks.get(spec.toSystemStream()).stream()) .collect(Collectors.toSet()).size(); outputTaskCount.put(node.getOutput().toSystemStream(), count); }); return outputTaskCount; }
Source:
<code>private List<FreeIpaVersions> filterVersions(ImageCatalog catalog, List<Image> filterImages) { List<String> filteredUuids = filterImages.stream().map(Image::getUuid).collect(Collectors.toList()); return catalog.getVersions().getFreeIpaVersions().stream() <START> .map(versions -> { List<String> defaults = versions.getDefaults().stream().filter(filteredUuids::contains).collect(Collectors.toList()); List<String> imageIds = versions.getImageIds().stream().filter(filteredUuids::contains).collect(Collectors.toList()); LOGGER.debug("Filtered versions: [versions: {}, defaults: {}, images: {}]", versions.getVersions(), defaults, imageIds); return new FreeIpaVersions(versions.getVersions(), defaults, imageIds); }).collect(Collectors.toList()); <END> }</code><technical_language>refactor this a method please. I part versions -></technical_language>

Target:
private List<FreeIpaVersions> filterVersions(ImageCatalog catalog, List<Image> filterImages) { List<String> filteredUuids = filterImages.stream().map(Image::getUuid).collect(Collectors.toList()); LOGGER.debug("The following uuids will be removed from defaults and image ids fields: [{}]", filteredUuids); return catalog.getVersions().getFreeIpaVersions().stream() .map(versions -> filterDefaultsAndImageIds(filteredUuids, versions)).collect(Collectors.toList()); }
Source:
<code>public boolean isCheckResponseSize() { <START> return isEnsureResposneSizeNotTooLarge() || isWarnResponseSizeLarge(); <END> }</code><technical_language>typo in isEnsureResposneSizeNotTooLarge (isEnsure<em>Response</em>...), this called isErrorResponseSizeLarge symmetry isWarnResponseSizeLarge</technical_language>

Target:
public boolean isCheckResponseSize() { return isErrorOnResponseSizeTooLarge() || isWarnOnResponseSizeLarge(); }
Source:
<code>public final void parseVersion( String version ) { this.value = version; items = new ListItem(); version = version.toLowerCase( Locale.ENGLISH ); ListItem list = items; <START> LinkedList<Item> stack = new LinkedList<>(); <END> stack.push( list ); boolean isDigit = false; int startIndex = 0; for ( int i = 0; i < version.length(); i++ ) { char c = version.charAt( i ); if ( c == '.' ) { if ( i == startIndex ) { list.add( IntItem.ZERO ); } else { list.add( parseItem( isDigit, version.substring( startIndex, i ) ) ); } startIndex = i + 1; } else if ( c == '-' ) { if ( i == startIndex ) { list.add( IntItem.ZERO ); } else { list.add( parseItem( isDigit, version.substring( startIndex, i ) ) ); } startIndex = i + 1; list.add( list = new ListItem() ); stack.push( list ); } else if ( Character.isDigit( c ) ) { if ( !isDigit && i > startIndex ) { list.add( new StringItem( version.substring( startIndex, i ), true ) ); startIndex = i; list.add( list = new ListItem() ); stack.push( list ); } isDigit = true; } else { if ( isDigit && i > startIndex ) { list.add( parseItem( true, version.substring( startIndex, i ) ) ); startIndex = i; list.add( list = new ListItem() ); stack.push( list ); } isDigit = false; } } if ( version.length() > startIndex ) { list.add( parseItem( isDigit, version.substring( startIndex ) ) ); } while ( !stack.isEmpty() ) { list = (ListItem) stack.pop(); list.normalize(); } canonical = items.toString(); }</code><technical_language>I agree LinkedList is Stack, Deque+ArrayDeque is better</technical_language>

Target:
public final void parseVersion( String version ) { this.value = version; items = new ListItem(); version = version.toLowerCase( Locale.ENGLISH ); ListItem list = items; Deque<Item> stack = new ArrayDeque<>(); stack.push( list ); boolean isDigit = false; int startIndex = 0; for ( int i = 0; i < version.length(); i++ ) { char c = version.charAt( i ); if ( c == '.' ) { if ( i == startIndex ) { list.add( IntItem.ZERO ); } else { list.add( parseItem( isDigit, version.substring( startIndex, i ) ) ); } startIndex = i + 1; } else if ( c == '-' ) { if ( i == startIndex ) { list.add( IntItem.ZERO ); } else { list.add( parseItem( isDigit, version.substring( startIndex, i ) ) ); } startIndex = i + 1; list.add( list = new ListItem() ); stack.push( list ); } else if ( Character.isDigit( c ) ) { if ( !isDigit && i > startIndex ) { list.add( new StringItem( version.substring( startIndex, i ), true ) ); startIndex = i; list.add( list = new ListItem() ); stack.push( list ); } isDigit = true; } else { if ( isDigit && i > startIndex ) { list.add( parseItem( true, version.substring( startIndex, i ) ) ); startIndex = i; list.add( list = new ListItem() ); stack.push( list ); } isDigit = false; } } if ( version.length() > startIndex ) { list.add( parseItem( isDigit, version.substring( startIndex ) ) ); } while ( !stack.isEmpty() ) { list = (ListItem) stack.pop(); list.normalize(); } canonical = items.toString(); }
Source:
<code>ObjectHolderRef(Field field, ResourceLocation injectedObject, boolean extractFromExistingValues) { Class<?> type = field.getType(); while (IForgeRegistryEntry.class.isAssignableFrom(type) && registry == null) { registry = PersistentRegistryManager.findRegistryByType((Class<IForgeRegistryEntry>)type); <START> type = type.getSuperclass(); <END> } this.field = field; this.isValid = registry != null; if (extractFromExistingValues) { try { Object existing = field.get(null); if (existing == null || existing == GameData.getBlockRegistry().getDefaultValue()) { this.injectedObject = null; this.field = null; this.isValid = false; return; } else { ResourceLocation tmp = null; if (registry != null) { tmp = registry.getKey((IForgeRegistryEntry) existing); } this.injectedObject = tmp; } } catch (Exception e) { throw Throwables.propagate(e); } } else { this.injectedObject = injectedObject; } if (this.injectedObject == null || !isValid()) { throw new IllegalStateException(String.format("The ObjectHolder annotation cannot apply to a field that is not an Item or Block (found : %s at %s.%s)", field.getType().getName(), field.getClass().getName(), field.getName())); } try { FinalFieldHelper.makeWritable(field); } catch (Exception e) { throw Throwables.propagate(e); } }</code><technical_language>Forge registry system allow for registry types of interfaces? If this need move a more stack type search class adds superclass interfaces class</technical_language>

Target:
ObjectHolderRef(Field field, ResourceLocation injectedObject, boolean extractFromExistingValues) { registry = getRegistryForType(field); this.field = field; this.isValid = registry != null; if (extractFromExistingValues) { try { Object existing = field.get(null); if (existing == null || existing == GameData.getBlockRegistry().getDefaultValue()) { this.injectedObject = null; this.field = null; this.isValid = false; return; } else { ResourceLocation tmp = null; if (registry != null) { tmp = registry.getKey((IForgeRegistryEntry) existing); } this.injectedObject = tmp; } } catch (Exception e) { throw Throwables.propagate(e); } } else { this.injectedObject = injectedObject; } if (this.injectedObject == null || !isValid()) { throw new IllegalStateException(String.format("The ObjectHolder annotation cannot apply to a field that does not map to a registry. Ensure the registry was created during the RegistryEvent.NewRegistry event. (found : %s at %s.%s)", field.getType().getName(), field.getClass().getName(), field.getName())); } try { FinalFieldHelper.makeWritable(field); } catch (Exception e) { throw Throwables.propagate(e); } }
Source:
<code>public RuleMatch[] match(AnalyzedSentence sentence) throws IOException { List<RuleMatch> ruleMatches = new ArrayList<>(); AnalyzedTokenReadings[] tokens = sentence.getTokensWithoutWhitespace(); for(int i = 1; i < tokens.length; i++) { String token = tokens[i].getToken(); if(getSubjects().contains(token)) { final String[] context = getContext(tokens, i); final float[] y = classifier.getScores(context); final Suggestion suggestion = getSuggestion(y); if(!suggestion.matches(token)) { if (!suggestion.isUnsure()) { ruleMatches.add(createRuleMatch(tokens[i], suggestion, y)); } else { <START> System.out.println("unsure: " + getMessage(suggestion, y) + Arrays.toString(context)); <END> } } } } return toRuleMatchArray(ruleMatches); }</code><technical_language>print STDOUT..</technical_language>

Target:
public RuleMatch[] match(AnalyzedSentence sentence) throws IOException { List<RuleMatch> ruleMatches = new ArrayList<>(); AnalyzedTokenReadings[] tokens = sentence.getTokensWithoutWhitespace(); for(int i = 1; i < tokens.length; i++) { String token = tokens[i].getToken(); if(getSubjects().contains(token)) { final String[] context = getContext(tokens, i); final float[] y = classifier.getScores(context); final Suggestion suggestion = getSuggestion(y); if(!suggestion.matches(token)) { if (!suggestion.isUnsure()) { ruleMatches.add(createRuleMatch(tokens[i], suggestion, y)); } else { if(DEBUG) { System.out.println("unsure: " + getMessage(suggestion, y) + Arrays.toString(context)); } } } } } return toRuleMatchArray(ruleMatches); }
Source:
<code>protected void addStorageDomainInDb() { TransactionSupport.executeInNewTransaction(new TransactionMethod<Void>() { @Override public Void runInTransaction() { StorageDomainStatic storageStaticData = getStorageDomain().getStorageStaticData(); DbFacade.getInstance().getStorageDomainStaticDao().save(storageStaticData); if (storageStaticData.getStorageDomainType() == StorageDomainType.Master <START> || storageStaticData.getStorageDomainType() == StorageDomainType.Data) { <END> getDiskProfileDao().save(DiskProfileHelper.createDiskProfile(storageStaticData.getId(), storageStaticData.getStorageName())); } getCompensationContext().snapshotNewEntity(storageStaticData); StorageDomainDynamic newStorageDynamic = new StorageDomainDynamic(null, getStorageDomain().getId(), null); getReturnValue().setActionReturnValue(getStorageDomain().getId()); DbFacade.getInstance().getStorageDomainDynamicDao().save(newStorageDynamic); getCompensationContext().snapshotNewEntity(newStorageDynamic); getCompensationContext().stateChanged(); return null; } }); }</code><technical_language>please replace condition storageStaticData.getStorageDomainType().isDataDomain() - import storage domain scenario? - attach storage domain scenario</technical_language>

Target:
protected void addStorageDomainInDb() { TransactionSupport.executeInNewTransaction(new TransactionMethod<Void>() { @Override public Void runInTransaction() { StorageDomainStatic storageStaticData = getStorageDomain().getStorageStaticData(); DbFacade.getInstance().getStorageDomainStaticDao().save(storageStaticData); if (storageStaticData.getStorageDomainType().isDataDomain()) { getDiskProfileDao().save(DiskProfileHelper.createDiskProfile(storageStaticData.getId(), storageStaticData.getStorageName())); } getCompensationContext().snapshotNewEntity(storageStaticData); StorageDomainDynamic newStorageDynamic = new StorageDomainDynamic(null, getStorageDomain().getId(), null); getReturnValue().setActionReturnValue(getStorageDomain().getId()); DbFacade.getInstance().getStorageDomainDynamicDao().save(newStorageDynamic); getCompensationContext().snapshotNewEntity(newStorageDynamic); getCompensationContext().stateChanged(); return null; } }); }
Source:
<code><START> public boolean equals(Object o) { <END> if (this == o) return true; if (o == null || getClass() != o.getClass()) return false; RateHistory that = (RateHistory) o; return Objects.equals(rates, that.rates); }</code><technical_language>again, equals/hashcode - sense? please revisit in types created</technical_language>

Target:
public boolean equals(Object o) { if (this == o) { return true; } if (o == null || getClass() != o.getClass()) { return false; } RateHistory that = (RateHistory) o; return Objects.equals(rates, that.rates); }
Source:
<code>public static Binary fromReusedByteArray(final byte[] value, final int offset, final int length) { <START> return fromByteArray(value, offset, length, false); <END> }</code><technical_language>is a fromByteArray method? call constructor directly</technical_language>

Target:
public static Binary fromReusedByteArray(final byte[] value, final int offset, final int length) { return new ByteArraySliceBackedBinary(value, offset, length, true); }
Source:
<code>public View getView(int i, View view, ViewGroup viewGroup) { if (view == null){ view = LayoutInflater.from(Utils.getContext()).inflate(R.layout.item_content, null); } <START> if (view == null){ <END> return null; } IndexedItem item = getItem(i); if (!mAnimCheck.contains(item)) { mAnimCheck.add(item); Utils.fadein(view, i * 20); fadeIn(view); } mViewToPositions.put(view, i); mItemToView.put(item, view); if (item instanceof IndexedFolder) { styleFolderView((IndexedFolder) item, view); } else { styleFileView((IndexedFile) item, view); } handleSelection(view); return view; }</code><technical_language>This is confusing, move check first</technical_language>

Target:
public View getView(int i, View view, ViewGroup viewGroup) { if (view == null) { view = LayoutInflater.from(Utils.getContext()).inflate(R.layout.item_content, null); if (view == null) { return null; } } IndexedItem item = getItem(i); if (!mAnimCheck.contains(item)) { mAnimCheck.add(item); Utils.fadein(view, i * 20); fadeIn(view); } mViewToPositions.put(view, i); mItemToView.put(item, view); if (item instanceof IndexedFolder) { styleFolderView((IndexedFolder) item, view); } else { styleFileView((IndexedFile) item, view); } handleSelection(view); return view; }
Source:
<code>public SubscribeRule(@JsonProperty("type") final Type type, @JsonProperty("all") final Boolean all, @JsonProperty("publisher") final String publisher, @JsonProperty("track") final String track, @JsonProperty("kind") final Kind kind, @JsonProperty("priority") final Priority priority) { this.type = type; this.all = all; this.kind = kind; this.priority = priority; <START> this.publisher = publisher; <END> this.track = track; }</code><technical_language>nit: ordering is different</technical_language>

Target:
public SubscribeRule(@JsonProperty("type") final Type type, @JsonProperty("all") final Boolean all, @JsonProperty("publisher") final String publisher, @JsonProperty("track") final String track, @JsonProperty("kind") final Kind kind, @JsonProperty("priority") final Priority priority) { this.type = type; this.all = all; this.publisher = publisher; this.track = track; this.kind = kind; this.priority = priority; }
Source:
<code>private void installCoreConverter() { if (coreClass.equals(String.class)) { converter = e -> ((JsonString) e).getString(); } else if (coreClass.equals(Set.class)) { converter = e -> convertToSet(e); } else if (coreClass.equals(Long.class)) { converter = e -> ((JsonNumber) e).longValue(); } else if (coreClass.equals(Boolean.class)) { <START> converter = e -> convertToBoolean(e); <END> } else if (coreClass.equals(JsonArray.class)) { converter = e -> e instanceof JsonArray ? e : createArrayBuilder().add(e).build(); } else { converter = e -> e; } }</code><technical_language>I file Class comparison equals. is reasonable equal instances of a Class in fact identical I generally suggest shy == != operators working Classes</technical_language>

Target:
private void installCoreConverter() { if (coreClass == String.class) { converter = e -> ((JsonString) e).getString(); } else if (coreClass == Set.class) { converter = e -> convertToSet(e); } else if (coreClass == Long.class) { converter = e -> ((JsonNumber) e).longValue(); } else if (coreClass == Boolean.class) { converter = e -> convertToBoolean(e); } else if (coreClass == JsonArray.class) { converter = e -> e instanceof JsonArray ? e : createArrayBuilder().add(e).build(); } else { converter = e -> e; } }
Source:
<code>public void json_example() { userSessionRule .logIn("obiwan.kenobi") .addPermission(SCAN, db.getDefaultOrganization()) .addPermission(ADMINISTER_QUALITY_PROFILES, db.getDefaultOrganization()); UserDto obiwan = db.users().insertUser(user -> user .setLogin("obiwan.kenobi") .setName("Obiwan Kenobi") .setEmail("obiwan.kenobi@starwars.com") .setLocal(true) .setExternalIdentity("obiwan.kenobi") .setExternalIdentityProvider("sonarqube") .setScmAccounts(newArrayList("obiwan:github", "obiwan:bitbucket")) <START> .setOnboarded(true) <END> .setHomepageType("MY_PROJECTS")); db.users().insertMember(db.users().insertGroup(newGroupDto().setName("Jedi")), obiwan); db.users().insertMember(db.users().insertGroup(newGroupDto().setName("Rebel")), obiwan); String response = ws.newRequest().execute().getInput(); assertJson(response).isSimilarTo(getClass().getResource("current-example.json")); }</code><technical_language>set value</technical_language>

Target:
public void json_example() { userSessionRule .logIn("obiwan.kenobi") .addPermission(SCAN, db.getDefaultOrganization()) .addPermission(ADMINISTER_QUALITY_PROFILES, db.getDefaultOrganization()); UserDto obiwan = db.users().insertUser(user -> user .setLogin("obiwan.kenobi") .setName("Obiwan Kenobi") .setEmail("obiwan.kenobi@starwars.com") .setLocal(true) .setExternalIdentity("obiwan.kenobi") .setExternalIdentityProvider("sonarqube") .setScmAccounts(newArrayList("obiwan:github", "obiwan:bitbucket")) .setOnboarded(true) .setHomepageType("PROJECT") .setHomepageValue("UUID-of-the-death-star")); db.users().insertMember(db.users().insertGroup(newGroupDto().setName("Jedi")), obiwan); db.users().insertMember(db.users().insertGroup(newGroupDto().setName("Rebel")), obiwan); db.components().insertPublicProject(u->u.setUuid("UUID-of-the-death-star"), u->u.setDbKey("death-star-key")); String response = ws.newRequest().execute().getInput(); assertJson(response).isSimilarTo(getClass().getResource("current-example.json")); }
Source:
<code>public void onlyTheFirstWSConsumerCreatesANewRequestBodyForTheSameOperation() throws InitialisationException, WSDLException { String echoOperation = "echo"; WSConsumerConfig spyConfig = spy(new WSConsumerConfig()); WSConsumer wsConsumer1 = createConsumer(spyConfig, echoOperation); WSConsumer wsConsumer2 = createConsumer(spyConfig, echoOperation); WSConsumer wsConsumer3 = createConsumer(spyConfig, echoOperation); wsConsumer1.initialise(); wsConsumer2.initialise(); wsConsumer3.initialise(); <START> verify(spyConfig, times(1)).createRequestBody(Mockito.any(Definition.class), Mockito.any(BindingOperation.class)); <END> verify(spyConfig, times(2)).getRequestBodyFromCache(Mockito.any(String.class)); }</code><technical_language>static imports</technical_language>

Target:
public void onlyTheFirstWSConsumerCreatesANewRequestBodyForTheSameOperation() throws InitialisationException, WSDLException { String echoOperation = "echo"; WSConsumerConfig spyConfig = spy(new WSConsumerConfig()); WSConsumer wsConsumer1 = createConsumer(spyConfig, echoOperation); WSConsumer wsConsumer2 = createConsumer(spyConfig, echoOperation); WSConsumer wsConsumer3 = createConsumer(spyConfig, echoOperation); wsConsumer1.initialise(); wsConsumer2.initialise(); wsConsumer3.initialise(); verify(spyConfig, times(1)).createRequestBody(any(Definition.class), any(BindingOperation.class)); verify(spyConfig, times(2)).getRequestBodyFromCache(any(String.class)); }
Source:
<code>public void example1() throws IOException { considerExample("Example1_original"); <START> cu.getClassByName("A").get().getFieldByName("a").get().addModifier(STATIC); <END> assertTransformed("Example1", cu); }</code><technical_language>add semantically set I assume in this case this matter</technical_language>

Target:
public void example1() throws IOException { considerExample("Example1_original"); cu.getClassByName("A").get().getFieldByName("a").get().setModifiers(STATIC); assertTransformed("Example1", cu); }
Source:
<code>public SnapshotInfo listSnapshots() { return null; <START> } <END></code><technical_language>This return [NULL_SNAPSHOT_INFO](<LINK_0> contract states null returned</technical_language>

Target:
public SnapshotInfo listSnapshots() { return ConfigurationPersister.NULL_SNAPSHOT_INFO; }
Source:
<code>public void visitNode(Tree tree) { if (!hasSemantic()) { return; } if (tree.is(IF_STATEMENT)) { visitIfStatement((IfStatementTree) tree); } if (tree.is(SYNCHRONIZED_STATEMENT)) { <START> synchronizedStmtStack.add(tree); <END> } }</code><technical_language>push/pop methods ? bit clearer IMO</technical_language>

Target:
public void visitNode(Tree tree) { if (!hasSemantic()) { return; } if (isIfFieldEqNullTree(tree)) { IfStatementTree ifTree = (IfStatementTree) tree; ifConditionSymbolStack.push(new CheckedLocking(ifTree)); visitIfStatement(ifTree); } if (tree.is(SYNCHRONIZED_STATEMENT)) { synchronizedStmtStack.push(tree); } }
Source:
<code>public static void setUp() throws CommandFailedException, InterruptedException, TimeoutException, IOException { operations.add(C_HANDLER_ADDRESS); <START> administration.reloadIfRequired(); <END> operations.add(C_HANDLER_TB_REMOVED_ADDRESS); administration.reloadIfRequired(); }</code><technical_language>consecutive reloads necessary reload end sufficient</technical_language>

Target:
public static void setUp() throws CommandFailedException, InterruptedException, TimeoutException, IOException { List<OnlineCommand> addConsoleHandlers = new LinkedList<>(); addConsoleHandlers.add(Logging.handler().console().add(CONSOLE_HANDLER).build()); addConsoleHandlers.add(Logging.handler().console().add(CONSOLE_HANDLER_TB_REMOVED).build()); client.apply(addConsoleHandlers); administration.reloadIfRequired(); }
Source:
<code>private void showTocOnboarding() { <START> FloatingActionButton tocButton = (FloatingActionButton) parentActivity.findViewById(R.id.floating_toc_button); <END> ToolTipUtil.showToolTip(parentActivity, tocButton, R.layout.inflate_tool_tip_toc_button, Color.BLACK, ToolTip.Position.CENTER); WikipediaApp.getInstance().getOnboardingStateMachine().setTocTutorial(); }</code><technical_language>I this needs cast. This "View tocButton"</technical_language>

Target:
private void showTocOnboarding() { View tocButton = parentActivity.findViewById(R.id.floating_toc_button); ToolTipUtil.showToolTip(parentActivity, tocButton, R.layout.inflate_tool_tip_toc_button, parentActivity.getResources().getColor(R.color.tool_tip_default), ToolTip.Position.CENTER); WikipediaApp.getInstance().getOnboardingStateMachine().setTocFloatingButtonTutorial(); }
Source:
<code>public static IndicatorQueryMutationEffect findHighestMutationEffectByEvidence(Set<Evidence> evidences) { Integer index = 100; IndicatorQueryMutationEffect indicatorQueryMutationEffect = new IndicatorQueryMutationEffect(); for (Evidence evidence : evidences) { MutationEffect mutationEffect = MutationEffect.getByName(evidence.getKnownEffect()); <START> if (PRIORITIZED_MUTATION_EFFECTS.indexOf(mutationEffect) < index) { <END> indicatorQueryMutationEffect.setMutationEffect(mutationEffect); indicatorQueryMutationEffect.setMutationEffectEvidence(evidence); } } return indicatorQueryMutationEffect; }</code><technical_language>update "index" comparison valid? In this case, is alway 100</technical_language>

Target:
public static IndicatorQueryMutationEffect findHighestMutationEffectByEvidence(Set<Evidence> evidences) { int index = 100; IndicatorQueryMutationEffect indicatorQueryMutationEffect = new IndicatorQueryMutationEffect(); for (Evidence evidence : evidences) { MutationEffect mutationEffect = MutationEffect.getByName(evidence.getKnownEffect()); int _index = PRIORITIZED_MUTATION_EFFECTS.indexOf(mutationEffect); if (_index < index) { indicatorQueryMutationEffect.setMutationEffect(mutationEffect); indicatorQueryMutationEffect.setMutationEffectEvidence(evidence); index = _index; } } return indicatorQueryMutationEffect; }