auphong2707/dl4se-code-review-dataset huggingface dataset:
Source:
<code>public String getColumnText(Object element, int columnIndex) { TaskReview reviewContainer = (TaskReview) element; switch (columnIndex) { <START> case 0: <END> return reviewContainer.getSummary(); case 3: return reviewContainer.getIncomingChanges(); default: return ""; } }</code><technical_language>More magic numbers, replace column labels</technical_language>

Target:
public String getColumnText(Object element, int columnIndex) { TaskReview reviewContainer = (TaskReview) element; switch (columnIndex) { case DESCRIPTION_COLUMN: return reviewContainer.getSummary(); case INCOMING_CHANGES_COLUMN: return reviewContainer.getIncomingChanges(); default: return ""; } }
Source:
<code>public Promise<List<Change>> format(final int offset, final int length, final String content) { return newPromise(new AsyncPromiseHelper.RequestCall<List<Change>>() { @Override public void makeCall(AsyncCallback<List<Change>> callback) { <START> String url = appContext.getDevMachine().getWsAgentBaseUrl() + "/java/code-formatting/format?offset=" + offset + "&length=" + length; <END> asyncRequestFactory.createPostRequest(url, null) .header(CONTENT_TYPE, MimeType.TEXT_PLAIN) .data(content) .send(newCallback(callback, unmarshallerFactory.newListUnmarshaller(Change.class))); } }).then(new Function<List<Change>, List<Change>>() { @Override public List<Change> apply(List<Change> arg) throws FunctionException { final List<Change> changes = new ArrayList<>(); for (Change change : arg) { changes.add(change); } return changes; } }); }</code><technical_language>a constant prefix for paths of this class ? constant "/java/code-formatting/" avoid miss some endpoint in a future</technical_language>

Target:
public Promise<List<Change>> format(final int offset, final int length, final String content) { return newPromise(new AsyncPromiseHelper.RequestCall<List<Change>>() { @Override public void makeCall(AsyncCallback<List<Change>> callback) { String url = appContext.getDevMachine().getWsAgentBaseUrl() + CODE_ASSIST_URL_PREFIX + "/format?offset=" + offset + "&length=" + length; asyncRequestFactory.createPostRequest(url, null) .header(CONTENT_TYPE, MimeType.TEXT_PLAIN) .data(content) .send(newCallback(callback, unmarshallerFactory.newListUnmarshaller(Change.class))); } }).then(new Function<List<Change>, List<Change>>() { @Override public List<Change> apply(List<Change> arg) throws FunctionException { final List<Change> changes = new ArrayList<>(); for (Change change : arg) { changes.add(change); } return changes; } }); }
Source:
<code>public void onChangeVelocity(ChangeVelocityEvent event, EntityRef entity) { <START> if (event.getAngularVelocity().length() > 0) { <END> physics.getRigidBody(entity).setAngularVelocity(event.getAngularVelocity()); } if (event.getLinearVelocity().length() > 0) { physics.getRigidBody(entity).setLinearVelocity(event.getLinearVelocity()); } }</code><technical_language>If I want set velocity zero</technical_language>

Target:
public void onChangeVelocity(ChangeVelocityEvent event, EntityRef entity) { if (event.getAngularVelocity() != null) { physics.getRigidBody(entity).setAngularVelocity(event.getAngularVelocity()); } if (event.getLinearVelocity() != null) { physics.getRigidBody(entity).setLinearVelocity(event.getLinearVelocity()); } }
Source:
<code>public void run() { long backlog = 0; MetricInfo metricInfo = null; synchronized (metrics) { long currentTime = System.currentTimeMillis(); Iterator iter = metrics.iterator(); while (iter.hasNext()) { try { metricInfo = (MetricInfo) iter.next(); long time = DATE_FORMAT.get().parse(metricInfo.getNominalTime()).getTime(); <START> backlog += (currentTime - time); <END> } catch (ParseException e) { LOG.error("Unable to parse nominal time" + metricInfo.getNominalTime()); } } } org.apache.falcon.entity.v0.process.Process process = (Process) entityObj; String metricName = METRIC_PREFIX + METRIC_SEPARATOR + metricInfo.getCluster() + METRIC_SEPARATOR + process.getPipelines() + METRIC_SEPARATOR + LifeCycle.EXECUTION.name() + METRIC_SEPARATOR + entityObj.getName() + METRIC_SEPARATOR + "backlogInMins"; backlog = backlog / (60 * 1000); metricNotificationService.publish(metricName, backlog); }</code><technical_language>Backlog calculation cluster. In this loop, differentiating clusters. Theoretically, Falcon Server manage multiple clusters</technical_language>

Target:
public void run() { MetricInfo metricInfo = null; HashMap<String, Long> backLogsCluster = new HashMap<>(); synchronized (metrics) { long currentTime = System.currentTimeMillis(); Iterator iter = metrics.iterator(); while (iter.hasNext()) { try { metricInfo = (MetricInfo) iter.next(); long time = DATE_FORMAT.get().parse(metricInfo.getNominalTime()).getTime(); long backlog = backLogsCluster.containsKey(metricInfo.getCluster()) ? backLogsCluster.get(metricInfo.getCluster()) : 0; backlog += (currentTime - time); backLogsCluster.put(metricInfo.getCluster(), backlog); } catch (ParseException e) { LOG.error("Unable to parse nominal time" + metricInfo.getNominalTime()); } } } org.apache.falcon.entity.v0.process.Process process = (Process) entityObj; if (backLogsCluster != null && !backLogsCluster.isEmpty()) { for (Map.Entry<String, Long> entry : backLogsCluster.entrySet()) { String clusterName = entry.getKey(); String pipelinesStr = process.getPipelines(); String metricName; Long backlog = entry.getValue() / (60 * 1000L); if (pipelinesStr != null && !pipelinesStr.isEmpty()) { String[] pipelines = pipelinesStr.split(","); for (String pipeline : pipelines) { metricName = METRIC_PREFIX + METRIC_SEPARATOR + clusterName + METRIC_SEPARATOR + pipeline + METRIC_SEPARATOR + LifeCycle.EXECUTION.name() + METRIC_SEPARATOR + entityObj.getName() + METRIC_SEPARATOR + "backlogInMins"; metricNotificationService.publish(metricName, backlog); } } else { metricName = METRIC_PREFIX + METRIC_SEPARATOR + clusterName + METRIC_SEPARATOR + DEFAULT_PIPELINE + METRIC_SEPARATOR + LifeCycle.EXECUTION.name() + METRIC_SEPARATOR + entityObj.getName() + METRIC_SEPARATOR + "backlogInMins"; metricNotificationService.publish(metricName, backlog); } } } }
Source:
<code>private void setSequenceNumbersOnNewAccountDetails(SubAccountGlobal subAccountGlobal, int newItemsStartIndex) { List<SubAccountGlobalNewAccountDetail> newAccountDetails = subAccountGlobal.getSubAccountGlobalNewAccountDetails(); if (newItemsStartIndex >= newAccountDetails.size()) { return; } long nextSequenceNumber = subAccountGlobal.getNextNewAccountDetailSequenceNumber().longValue(); for (int i = newItemsStartIndex; i < newAccountDetails.size(); i++) { SubAccountGlobalNewAccountDetail newAccountDetail = newAccountDetails.get(i); newAccountDetail.setSequenceNumber(Long.valueOf(nextSequenceNumber)); nextSequenceNumber++; } <START> subAccountGlobal.setNextNewAccountDetailSequenceNumber(Long.valueOf(nextSequenceNumber)); <END> }</code><technical_language>some paradigms in KFS get next sequence number function increcements sequence number in question. cleaner. leave if changed</technical_language>

Target:
private void setSequenceNumbersOnNewAccountDetails(SubAccountGlobal subAccountGlobal, int newItemsStartIndex) { List<SubAccountGlobalNewAccountDetail> newAccountDetails = subAccountGlobal.getSubAccountGlobalNewAccountDetails(); if (newItemsStartIndex >= newAccountDetails.size()) { return; } for (int i = newItemsStartIndex; i < newAccountDetails.size(); i++) { SubAccountGlobalNewAccountDetail newAccountDetail = newAccountDetails.get(i); newAccountDetail.setSequenceNumber(subAccountGlobal.getAndIncrementNextNewAccountDetailSequenceNumber()); } }
Source:
<code>public boolean containContext(String jarName, List ctxs) { if (ctxs == null || ctxs.isEmpty()) { <START> return false; <END> } for (Object ct : ctxs) { if (ContextParameterUtils.isContextParamOfContextType((ContextType) ct, jarName)) { return true; } } return false; }</code><technical_language>check function ContextParameterUtils.isContainContextParam(jarName) ? work for project setting</technical_language>

Target:
public boolean containContext(String jarName, List ctxs) { if (ctxs == null) { return ContextParameterUtils.isContainContextParam(jarName); } for (Object ct : ctxs) { if (ContextParameterUtils.isContextParamOfContextType((ContextType) ct, jarName)) { return true; } } return false; }
Source:
<code>public List<ITmfStateInterval> queryHistoryRange(int attributeQuark, long t1, long t2, long resolution, IProgressMonitor monitor) throws TimeRangeException, AttributeNotFoundException, StateSystemDisposedException { if (isDisposed) { throw new StateSystemDisposedException(); } List<ITmfStateInterval> intervals; ITmfStateInterval currentInterval; long ts, tEnd; IProgressMonitor mon = monitor; if (mon == null) { mon = new NullProgressMonitor(); } if (t2 < t1 || resolution <= 0) { throw new TimeRangeException(); } if (t2 > this.getCurrentEndTime()) { tEnd = this.getCurrentEndTime(); } else { tEnd = t2; } intervals = new ArrayList<>(); <START> for (ts = t1; ts < tEnd; ts += ((currentInterval.getEndTime() - ts) / resolution + 1) * resolution) { <END> if (mon.isCanceled()) { return intervals; } currentInterval = querySingleState(ts, attributeQuark); intervals.add(currentInterval); } return intervals; }</code><technical_language>Hmm, this is hard understand :/ Maintanable > performant imo. Current code faster time (Moore's Law), is law code clearer. ;) keeping check same, and...</technical_language>

Target:
public List<ITmfStateInterval> queryHistoryRange(int attributeQuark, long t1, long t2, long resolution, IProgressMonitor monitor) throws TimeRangeException, AttributeNotFoundException, StateSystemDisposedException { if (isDisposed) { throw new StateSystemDisposedException(); } List<ITmfStateInterval> intervals; ITmfStateInterval currentInterval; long ts, tEnd; IProgressMonitor mon = monitor; if (mon == null) { mon = new NullProgressMonitor(); } if (t2 < t1 || resolution <= 0) { throw new TimeRangeException(); } if (t2 > this.getCurrentEndTime()) { tEnd = this.getCurrentEndTime(); } else { tEnd = t2; } intervals = new ArrayList<>(); currentInterval = querySingleState(t1, attributeQuark); intervals.add(currentInterval); for (ts = t1; ts < tEnd; ts += ((currentInterval.getEndTime() - ts) / resolution + 1) * resolution) { if (mon.isCanceled()) { return intervals; } currentInterval = querySingleState(ts, attributeQuark); intervals.add(currentInterval); } if (currentInterval.getEndTime() < tEnd) { currentInterval = querySingleState(tEnd, attributeQuark); intervals.add(currentInterval); } return intervals; }
Source:
<code>private void openBackgroundPlayer(final boolean append) { <START> AudioStream audioStream = getDefaultAudioStream(); <END> boolean useExternalAudioPlayer = PreferenceManager.getDefaultSharedPreferences(activity) .getBoolean(activity.getString(R.string.use_external_audio_player_key), false); if (!useExternalAudioPlayer && android.os.Build.VERSION.SDK_INT >= 16) { openNormalBackgroundPlayer(append); } else { startOnExternalPlayer(activity, currentInfo, audioStream); } }</code><technical_language>This 2 lines final</technical_language>

Target:
private void openBackgroundPlayer(final boolean append) { final AudioStream audioStream = getDefaultAudioStream(); final boolean useExternalAudioPlayer = PreferenceManager .getDefaultSharedPreferences(activity) .getBoolean(activity.getString(R.string.use_external_audio_player_key), false); if (!useExternalAudioPlayer && android.os.Build.VERSION.SDK_INT >= 16) { openNormalBackgroundPlayer(append); } else { startOnExternalPlayer(activity, currentInfo, audioStream); } }
Source:
<code>private Optional<IASTNode> getNodiscardFunction(IASTExpression expr) { if (expr instanceof IASTFunctionCallExpression) { IASTFunctionCallExpression func = (IASTFunctionCallExpression) expr; IASTExpression functionNameExpression = func.getFunctionNameExpression(); IASTName name; if (functionNameExpression instanceof IASTIdExpression) { name = ((IASTIdExpression) functionNameExpression).getName(); } else if (functionNameExpression instanceof IASTFieldReference) { name = ((IASTFieldReference) functionNameExpression).getFieldName(); } else { return Optional.empty(); } <START> IBinding binding = name.resolveBinding(); <END> if (binding instanceof ICPPFunction && (((IFunction) binding).isNoDiscard() || checkEvaluation((ICPPASTExpression) expr))) { return Optional.of(name); } else if (binding instanceof IFunction && ((IFunction) binding).isNoDiscard()) { return Optional.of(name); } else if ((binding instanceof ICPPClassType || binding instanceof ICPPVariable) && expr instanceof ICPPASTExpression && checkEvaluation((ICPPASTExpression) expr)) { return Optional.of(name); } return Optional.empty(); } else if (expr instanceof ICPPASTCastExpression) { ICPPASTCastExpression cast = (ICPPASTCastExpression) expr; if (cast.getOperator() != ICPPASTCastExpression.op_static_cast) { return Optional.empty(); } if (checkEvaluation(cast)) { return Optional.of(cast.getTypeId()); } return Optional.empty(); } else return Optional.empty(); }</code><technical_language>Suggestion for organizing this a bit better: // compute "name" // For C++, checkEvaluation() handle if (expr instanceof ICPPASTExpression) { if (checkEvaluation((ICPPASTExpression) expr) { return Optional.of(name); } return Optional.empty(); } // For C, need check if IFunction IBinding binding = name.resolveBinding(); if (binding instanceof IFunction && ((IFunction) binding).isNoDiscard()) { return Optional.of(name); }</technical_language>

Target:
private Optional<IASTNode> getNodiscardFunction(IASTExpression expr) { if (expr instanceof IASTFunctionCallExpression) { IASTFunctionCallExpression func = (IASTFunctionCallExpression) expr; IASTExpression functionNameExpression = func.getFunctionNameExpression(); IASTName name; if (functionNameExpression instanceof IASTIdExpression) { name = ((IASTIdExpression) functionNameExpression).getName(); } else if (functionNameExpression instanceof IASTFieldReference) { name = ((IASTFieldReference) functionNameExpression).getFieldName(); } else { return Optional.empty(); } if (expr instanceof ICPPASTExpression) { if (checkEvaluation((ICPPASTExpression) expr)) { return Optional.of(name); } return Optional.empty(); } IBinding binding = name.resolveBinding(); if (binding instanceof IFunction && ((IFunction) binding).isNoDiscard()) { return Optional.of(name); } return Optional.empty(); } else if (expr instanceof ICPPASTCastExpression) { ICPPASTCastExpression cast = (ICPPASTCastExpression) expr; if (cast.getOperator() != ICPPASTCastExpression.op_static_cast) { return Optional.empty(); } if (checkEvaluation(cast)) { return Optional.of(cast.getTypeId()); } return Optional.empty(); } else return Optional.empty(); }
Source:
<code>public RiakConnection getConnection(byte[] clientId) throws IOException { <START> RiakConnection c = getConnection(3); <END> if (clientId != null && !Arrays.equals(clientId, c.getClientId())) { setClientIdOnConnection(c, clientId); } return c; }</code><technical_language>If 3 is default number of attempts, consider defining a default connection attempts constant here</technical_language>

Target:
public RiakConnection getConnection(byte[] clientId) throws IOException { RiakConnection c = getConnection(CONNECTION_ACQUIRE_ATTEMPS); if (clientId != null && !Arrays.equals(clientId, c.getClientId())) { setClientIdOnConnection(c, clientId); } return c; }
Source:
<code>public Box getByBarcode(String barcode) throws IOException { Box o = boxStore.getByBarcode(barcode); <START> if (authorizationManager.readCheck(o)) return o; <END> else throw new IOException("User " + authorizationManager.getCurrentUser().getFullName() + " cannot read Box " + barcode); }</code><technical_language>authorizationManager.throwIfNotReadable</technical_language>

Target:
public Box getByBarcode(String barcode) throws IOException { Box o = boxStore.getByBarcode(barcode); authorizationManager.throwIfNotReadable(o); return o; }
Source:
<code>private static String cleanUri(String uri) { if (uri.charAt(0) == '<') return uri.substring(1, uri.length() - 1).toLowerCase(); else return uri; <START> } <END></code><technical_language>enclose if else { } if a single line</technical_language>

Target:
private static String cleanUri(String uri) { if (uri.charAt(0) == '<' && uri.charAt(uri.length()-1) == '>') { return uri.substring(1, uri.length()-1).toLowerCase(); } return uri; }
Source:
<code>public FunctionKindRowColumn(final Supplier<FunctionDefinition> functionSupplier, final CellEditorControlsView.Presenter cellEditorControls, final KindPopoverView.Presenter editor, final Optional<String> editorTitle, final FunctionGrid gridWidget) { super(Collections.singletonList(new FunctionKindRowColumnHeaderMetaData(functionSupplier, cellEditorControls, editor, editorTitle, gridWidget))); <START> setMovable(false); <END> }</code><technical_language>Please call setResizable(false) too</technical_language>

Target:
public FunctionKindRowColumn(final Supplier<FunctionDefinition> functionSupplier, final CellEditorControlsView.Presenter cellEditorControls, final KindPopoverView.Presenter editor, final Optional<String> editorTitle, final FunctionGrid gridWidget) { super(Collections.singletonList(new FunctionKindRowColumnHeaderMetaData(functionSupplier, cellEditorControls, editor, editorTitle, gridWidget))); setMovable(false); setResizable(false); }
Source:
<code>public void getLedgerShouldReturnTheRequest() throws Exception { final AtomicReference<Request> bodyRef = new AtomicReference<>(); final CountDownLatch latch = new CountDownLatch(1); final RestAdapter adapter = new RestAdapter.Builder().setEndpoint(MOCK_URL).setRequestInterceptor(BitreserveRestAdapter.getRequestInterceptor(null)).setClient(new Client() { @Override public Response execute(Request request) throws IOException { bodyRef.set(request); latch.countDown(); <START> return null; <END> } }).build(); final ReserveService reserveService = adapter.create(ReserveService.class); reserveService.getLedger("foobar", new RetrofitPromise<List<Deposit>>()); latch.await(); Assert.assertEquals(bodyRef.get().getUrl(), String.format("%s/v0/reserve/ledger", MOCK_URL)); Assert.assertTrue(bodyRef.get().getHeaders().contains(new Header("Range", "foobar"))); Assert.assertEquals(bodyRef.get().getMethod(), "GET"); }</code><technical_language>Add newline return</technical_language>

Target:
public void getLedgerShouldReturnTheRequest() throws Exception { final AtomicReference<Request> bodyRef = new AtomicReference<>(); final CountDownLatch latch = new CountDownLatch(1); final RestAdapter adapter = new RestAdapter.Builder().setEndpoint(MOCK_URL).setClient(new Client() { @Override public Response execute(Request request) throws IOException { bodyRef.set(request); latch.countDown(); return null; } }).build(); final ReserveService reserveService = adapter.create(ReserveService.class); reserveService.getLedger("foobar", new RetrofitPromise<List<Deposit>>()); latch.await(); Assert.assertEquals(bodyRef.get().getMethod(), "GET"); Assert.assertEquals(bodyRef.get().getUrl(), String.format("%s/v0/reserve/ledger", MOCK_URL)); Assert.assertTrue(bodyRef.get().getHeaders().contains(new Header("Range", "foobar"))); }
Source:
<code>public void purgeObject() { createBucket(bucketName, CREATION_DATE_TIME); Response response = target("/objects").request(MediaType.APPLICATION_JSON_TYPE) .post(Entity.entity(new FormDataMultiPart() .field("bucketName", bucketName).field("create", "new") .field("key", "object1").field("contentType", "text/plain") .field("timestamp", "2012-09-08 11:00:00") .field("tag", "DRAFT") .field("file", testData1, MediaType.TEXT_PLAIN_TYPE), MediaType.MULTIPART_FORM_DATA )); <START> System.out.print("Response " + response); <END> JsonObject responseObj = gson.fromJson(response.readEntity(String.class), JsonElement.class).getAsJsonObject(); TestCase.assertNotNull(responseObj); String versionChecksum = responseObj.get("versionChecksum").getAsString(); Response purgeResponse = target("/objects/" + bucketName) .queryParam("key", "object1") .queryParam("purge", true) .queryParam("versionChecksum", versionChecksum) .request() .accept(MediaType.APPLICATION_JSON_TYPE) .delete(); assertNotNull(purgeResponse); assertEquals( Response.Status.OK.getStatusCode(), purgeResponse.getStatus()); assertRepoError(target("/objects/meta/" + bucketName).queryParam("key", "object1").request().accept(MediaType.APPLICATION_JSON_TYPE).get(), Response.Status.NOT_FOUND, RepoException.Type.ObjectNotFound); assertRepoError(target("/objects/" + bucketName).queryParam("key", "object1").queryParam("fetchMetadata", "false").request().accept(MediaType.APPLICATION_JSON_TYPE).get(), Response.Status.NOT_FOUND, RepoException.Type.ObjectNotFound); }</code><technical_language>Debug code? Remove this</technical_language>

Target:
public void purgeObject() { createBucket(bucketName, CREATION_DATE_TIME); Response response = target("/objects").request(MediaType.APPLICATION_JSON_TYPE) .post(Entity.entity(new FormDataMultiPart() .field("bucketName", bucketName).field("create", "new") .field("key", "object1").field("contentType", "text/plain") .field("timestamp", "2012-09-08 11:00:00") .field("tag", "DRAFT") .field("file", testData1, MediaType.TEXT_PLAIN_TYPE), MediaType.MULTIPART_FORM_DATA )); JsonObject responseObj = gson.fromJson(response.readEntity(String.class), JsonElement.class).getAsJsonObject(); TestCase.assertNotNull(responseObj); String versionChecksum = responseObj.get("versionChecksum").getAsString(); Response purgeResponse = target("/objects/" + bucketName) .queryParam("key", "object1") .queryParam("purge", true) .queryParam("versionChecksum", versionChecksum) .request() .accept(MediaType.APPLICATION_JSON_TYPE) .delete(); assertNotNull(purgeResponse); assertEquals( Response.Status.OK.getStatusCode(), purgeResponse.getStatus()); assertRepoError(target("/objects/meta/" + bucketName).queryParam("key", "object1").request().accept(MediaType.APPLICATION_JSON_TYPE).get(), Response.Status.NOT_FOUND, RepoException.Type.ObjectNotFound); assertRepoError(target("/objects/" + bucketName).queryParam("key", "object1").queryParam("fetchMetadata", "false").request().accept(MediaType.APPLICATION_JSON_TYPE).get(), Response.Status.NOT_FOUND, RepoException.Type.ObjectNotFound); }
Source:
<code>public void setUp() { <START> setting = new SettingImpl<>(Integer.class, SETTING_ID, <END> 50, new RangedNumberValidator<>(0, 100, false, false)); eventResult = -1; setting.subscribe(propertyChangeEvent -> eventResult = (int) propertyChangeEvent.getNewValue()); }</code><technical_language>@eviltak, mentioned removing need for class parameter checking type of default value? please do that</technical_language>

Target:
public void setUp() { setting = new SettingImpl<>(SETTING_ID, 50, new RangedNumberValidator<>(0, 100, false, false)); eventResult = -1; setting.subscribe(propertyChangeEvent -> eventResult = (int) propertyChangeEvent.getNewValue()); }
Source:
<code>public Optional<MethodSpec> generate() { MethodSpec.Builder selectStartBuilder = MethodSpec.methodBuilder("selectStart") .addAnnotation(Override.class) .addModifiers(Modifier.PUBLIC) .returns(Select.class) .addStatement("$T keyspaceId = context.getKeyspaceId()", CqlIdentifier.class) .addStatement("$T tableId = context.getTableId()", CqlIdentifier.class) .beginControlFlow("if (tableId == null)") .addStatement("tableId = defaultTableId") .endControlFlow() .addStatement( "$1T selectFrom = (keyspaceId == null)\n" + "? $2T.selectFrom(tableId)\n" + ": $2T.selectFrom(keyspaceId, tableId)", SelectFrom.class, QueryBuilder.class) .addCode("$[return selectFrom"); for (PropertyDefinition property : entityDefinition.getAllValues()) { <START> if (property.getSelector().equals(property.getCqlName())) { <END> selectStartBuilder.addCode("\n.column($L)", property.getSelector()); } else { selectStartBuilder.addCode( "\n.raw($L).as($L)", property.getSelector(), property.getCqlName()); } } selectStartBuilder.addCode("$];\n"); return Optional.of(selectStartBuilder.build()); }</code><technical_language>Nit: this distinguish computed values. introduce PropertyDefinition.isComputed(), iterate getAllColumns getComputedValues separately</technical_language>

Target:
public Optional<MethodSpec> generate() { MethodSpec.Builder selectStartBuilder = MethodSpec.methodBuilder("selectStart") .addAnnotation(Override.class) .addModifiers(Modifier.PUBLIC) .returns(Select.class) .addStatement("$T keyspaceId = context.getKeyspaceId()", CqlIdentifier.class) .addStatement("$T tableId = context.getTableId()", CqlIdentifier.class) .beginControlFlow("if (tableId == null)") .addStatement("tableId = defaultTableId") .endControlFlow() .addStatement( "$1T selectFrom = (keyspaceId == null)\n" + "? $2T.selectFrom(tableId)\n" + ": $2T.selectFrom(keyspaceId, tableId)", SelectFrom.class, QueryBuilder.class) .addCode("$[return selectFrom"); for (PropertyDefinition property : entityDefinition.getAllColumns()) { selectStartBuilder.addCode("\n.column($L)", property.getSelector()); } for (PropertyDefinition property : entityDefinition.getComputedValues()) { selectStartBuilder.addCode( "\n.raw($L).as($L)", property.getSelector(), property.getCqlName()); } selectStartBuilder.addCode("$];\n"); return Optional.of(selectStartBuilder.build()); }
Source:
<code>public BidirectionalActions<A> apply(Problem<A, S> originalProblem, Problem<A, S> reverseProblem) { Node<A, S> node = newRootNode(originalProblem.initialState(), 0); if (originalProblem.isGoalState(node.state())) { this.previousMeetingOfTwoFrontiers = node; this.nextNodeToBeEvaluated = null; return bidirectionalActions; } Node<A, S> revNode = newRootNode(reverseProblem.initialState(), 0); Queue<Node<A, S>> front = newFIFOQueue(node); Queue<Node<A, S>> back = newFIFOQueue(revNode); HashMap<S, Node<A, S>> exploredFront = newExploredMap(); <START> HashMap<S, Node<A, S>> exploredBack = newExploredMap(); <END> exploredFront.put(node.state(), null); exploredBack.put(revNode.state(), null); Node<A, S> solutionNode; while (!front.isEmpty() || !back.isEmpty()) { if (front.isEmpty() || back.isEmpty()) { this.previousMeetingOfTwoFrontiers = null; return bidirectionalActions; } solutionNode = pathExistsBidirectional(front, exploredFront, exploredBack, originalProblem); if (solutionNode != null) { this.meetingOfTwoFrontiers = solutionNode; this.fromFront = true; return bidirectionalActions; } solutionNode = pathExistsBidirectional(back, exploredBack, exploredFront, originalProblem); if (solutionNode != null) { this.meetingOfTwoFrontiers = solutionNode; this.fromFront = false; return bidirectionalActions; } } this.previousMeetingOfTwoFrontiers = null; return bidirectionalActions; }</code><technical_language>'Map<..>' 'HashMap<...>' - i.e. avoid restricting a specific implementation</technical_language>

Target:
public BidirectionalActions<A> apply(Problem<A, S> originalProblem, Problem<A, S> reverseProblem) { Node<A, S> node = newRootNode(originalProblem.initialState(), 0); if (originalProblem.isGoalState(node.state())) { this.previousMeetingOfTwoFrontiers = node; this.nextNodeToBeEvaluated = null; bidirectionalActions = new BasicBidirectionalActions<>(fromInitialStatePart(), fromGoalStatePart()); return bidirectionalActions; } Node<A, S> revNode = newRootNode(reverseProblem.initialState(), 0); Queue<Node<A, S>> front = newFIFOQueue(node); Queue<Node<A, S>> back = newFIFOQueue(revNode); Map<S, Node<A, S>> exploredFront = newExploredMap(node.state()); Map<S, Node<A, S>> exploredBack = newExploredMap(revNode.state()); while (!front.isEmpty() || !back.isEmpty()) { if (front.isEmpty() || back.isEmpty()) { this.previousMeetingOfTwoFrontiers = null; bidirectionalActions = new BasicBidirectionalActions<>(fromInitialStatePart(), fromGoalStatePart()); return bidirectionalActions; } if (isSolution(pathExistsBidirectional(front, exploredFront, exploredBack, originalProblem), true)) { bidirectionalActions = new BasicBidirectionalActions<>(fromInitialStatePart(), fromGoalStatePart()); return bidirectionalActions; } if (isSolution(pathExistsBidirectional(back, exploredBack, exploredFront, originalProblem), false)) { bidirectionalActions = new BasicBidirectionalActions<>(fromInitialStatePart(), fromGoalStatePart()); return bidirectionalActions; } } this.previousMeetingOfTwoFrontiers = null; bidirectionalActions = new BasicBidirectionalActions<>(fromInitialStatePart(), fromGoalStatePart()); return bidirectionalActions; }
Source:
<code>public Mono<CosmosAsyncContainerResponse> read(CosmosContainerRequestOptions options) { if (options == null) { options = new CosmosContainerRequestOptions(); } final CosmosContainerRequestOptions requestOptions = options; if(!database.getClient().getTracerProvider().isEnabled()){ return readInternal(options); } <START> return withContext(context -> read(requestOptions, context)).subscriberContext(TracerProvider.callDepthAttributeFunc); <END> }</code><technical_language>this additional cost if tracer enabled. i in code withContext is Map creation etc. short circuit this if tracer is enabled</technical_language>

Target:
public Mono<CosmosContainerResponse> read(CosmosContainerRequestOptions options) { if (options == null) { options = new CosmosContainerRequestOptions(); } final CosmosContainerRequestOptions requestOptions = options; if(!database.getClient().getTracerProvider().isEnabled()){ return readInternal(options); } return withContext(context -> read(requestOptions, context)); }
Source:
<code>public Deferred<Object> initialize(final TSDB tsdb, final String id) { this.id = Strings.isNullOrEmpty(id) ? TYPE : id; this.tsdb = tsdb; if (!tsdb.getConfig().hasProperty(getConfigKey(MAX_CARD_KEY))) { tsdb.getConfig().register(getConfigKey(MAX_CARD_KEY), 4096, true, "The maximum number of entries to allow for multi-get queries."); } if (!tsdb.getConfig().hasProperty(getConfigKey(FALLBACK_ON_NO_DATA_KEY))) { tsdb.getConfig() .register( getConfigKey(FALLBACK_ON_NO_DATA_KEY), false, true, "Whether or not to fall back to scans when the meta " + "query returns an empty data set."); } if (!tsdb.getConfig().hasProperty(getConfigKey(FALLBACK_ON_EX_KEY))) { tsdb.getConfig() .register( getConfigKey(FALLBACK_ON_EX_KEY), true, true, "Whether or not to fall back to scans when the meta " + "query returns an exception."); } if (!tsdb.getConfig().hasProperty(getConfigKey(CLIENT_ID))) { tsdb.getConfig().register(getConfigKey(CLIENT_ID), null, false, "Meta client id."); } <START> String skip_meta_namespaces = tsdb.getConfig().getString(SKIP_META_NAMESPACES); <END> skip_meta = new ArrayList<>(); String[] namespaces = skip_meta_namespaces.split(","); for (String namespace : namespaces) { skip_meta.add(namespace.trim()); } String clientID = tsdb.getConfig().getString(getConfigKey(CLIENT_ID)); client = tsdb.getRegistry().getPlugin(MetaClient.class, clientID); if (client == null) { throw new IllegalStateException("No client found with id: " + clientID); } return Deferred.fromResult(null); }</code><technical_language>Register this a YAML map keys namespace values retention lets dynamic tweak config fly</technical_language>

Target:
public Deferred<Object> initialize(final TSDB tsdb, final String id) { this.id = Strings.isNullOrEmpty(id) ? TYPE : id; this.tsdb = tsdb; if (!tsdb.getConfig().hasProperty(getConfigKey(MAX_CARD_KEY))) { tsdb.getConfig().register(getConfigKey(MAX_CARD_KEY), 4096, true, "The maximum number of entries to allow for multi-get queries."); } if (!tsdb.getConfig().hasProperty(getConfigKey(FALLBACK_ON_NO_DATA_KEY))) { tsdb.getConfig() .register( getConfigKey(FALLBACK_ON_NO_DATA_KEY), false, true, "Whether or not to fall back to scans when the meta " + "query returns an empty data set."); } if (!tsdb.getConfig().hasProperty(getConfigKey(FALLBACK_ON_EX_KEY))) { tsdb.getConfig() .register( getConfigKey(FALLBACK_ON_EX_KEY), true, true, "Whether or not to fall back to scans when the meta " + "query returns an exception."); } if (!tsdb.getConfig().hasProperty(getConfigKey(CLIENT_ID))) { tsdb.getConfig().register(getConfigKey(CLIENT_ID), null, false, "Meta client id."); } if (tsdb.getConfig().hasProperty(getConfigKey(SKIP_META))) { tsdb.getConfig().register(ConfigurationEntrySchema.newBuilder() .setKey(SKIP_META) .setDefaultValue(Maps.newHashMap()) .setDescription("TODO") .setType(NAMESPACE_FILTERS) .setSource(this.getClass().toString()) .isDynamic() .build()); } String clientID = tsdb.getConfig().getString(getConfigKey(CLIENT_ID)); client = tsdb.getRegistry().getPlugin(MetaClient.class, clientID); if (client == null) { throw new IllegalStateException("No client found with id: " + clientID); } return Deferred.fromResult(null); }
Source:
<code>public void handleNotifications(Event event) { EventContext ctx = event.getContext(); DocumentEventContext docCtx = (DocumentEventContext) ctx; if (docCtx.getSourceDocument().getType().equals("Post") || docCtx.getSourceDocument().getType().equals(AnnotationConstants.ANNOTATION_DOC_TYPE) || docCtx.getSourceDocument().getType().equals(CommentsConstants.COMMENT_DOC_TYPE)) { <START> Object[] args = { docCtx.getProperty(CommentConstants.TOP_LEVEL_DOCUMENT) }; docCtx.setArgs(args); <END> } }</code><technical_language>need (the null one) in array? required previously in class constructor</technical_language>

Target:
public void handleNotifications(Event event) { EventContext ctx = event.getContext(); DocumentEventContext docCtx = (DocumentEventContext) ctx; if (docCtx.getSourceDocument().getType().equals("Post") || docCtx.getSourceDocument().getType().equals(AnnotationConstants.ANNOTATION_DOC_TYPE) || docCtx.getSourceDocument().getType().equals(CommentsConstants.COMMENT_DOC_TYPE)) { Object[] args = { docCtx.getProperty(CommentConstants.TOP_LEVEL_DOCUMENT), null }; docCtx.setArgs(args); } }
Source:
<code>private boolean createLockedTableWithStatusRow(UUID queryId) { String sql = String.format(ENGLISH, "CREATE TABLE IF NOT EXISTS %s" + " (query_id, created_at, completed_at)" + " AS SELECT '%s'::text, CURRENT_TIMESTAMP::timestamptz, NULL::timestamptz", escapeIdent(statusTableName(queryId)), queryId.toString()); try { execute(sql); return true; } catch (SQLException ex) { <START> if (isConflictException(ex)) { <END> abortTransaction(); return false; } else { String desc = "Failed to create a status table." + ".\nhint: if you don't have permission to create tables, " + "please add \"strict_transaction: false\" option to disable " + "exactly-once transaction control that depends on this table.\n" + "Or please ask system administrator to let this user create tables\n" + "in this schema."; throw new DatabaseException(desc, ex); } } }</code><technical_language>is this table locked? Also, CREATE TABLE IF EXISTS throws SQLException 23505 error code</technical_language>

Target:
private boolean createLockedTableWithStatusRow(UUID queryId) { String sql = String.format(ENGLISH, "CREATE TABLE %s" + " (query_id, created_at, completed_at)" + " AS SELECT '%s'::text, CURRENT_TIMESTAMP::timestamptz, NULL::timestamptz", escapeIdent(statusTableName(queryId)), queryId.toString()); try { execute(sql); return true; } catch (SQLException ex) { if (isConflictException(ex)) { abortTransaction(); return false; } else { String desc = "Failed to create a status table." + ".\nhint: if you don't have permission to create tables, " + "please add \"strict_transaction: false\" option to disable " + "exactly-once transaction control that depends on this table.\n" + "Or please ask system administrator to let this user create tables\n" + "in this schema."; throw new DatabaseException(desc, ex); } } }
Source:
<code>public void beforeStart(@NotNull UsersWorkspace workspace, @Nullable String accountId) throws NotFoundException, ForbiddenException, ServerException { User currentUser = EnvironmentContext.getCurrent().getUser(); if (accountId == null) { if (!accountDao.isWorkspaceRegistered(workspace.getId())) { List<Account> ownedAccounts = accountDao.getByOwner(currentUser.getId()); if (ownedAccounts.size() != 1) { throw new ForbiddenException(format("Workspace start rejected. Impossible to determine account for workspace '%s', " + "user '%s' is owner of several accounts. Specify account identifier!", workspace.getId(), workspace.getOwner())); } Account account = ownedAccounts.get(0); account.getWorkspaces().add(workspace); <START> accountDao.update(account); <END> } } else { try { Account account = accountDao.getByWorkspace(workspace.getId()); if (!account.getId().equals(accountId)) { throw new ForbiddenException(format("Workspace start rejected. Workspace is already added to account '%s' " + "which is different from specified one '%s'", account.getId(), accountId)); } } catch (NotFoundException ignored) { if (accountDao.getMembers(accountId) .stream() .noneMatch(member -> currentUser.getId().equals(member.getUserId()) && member.getRoles().contains("account/owner"))) { throw new ForbiddenException(format("Workspace start rejected. User '%s' doesn't own account '%s'", currentUser.getId(), accountId)); } Account account = accountDao.getById(accountId); account.getWorkspaces().add(workspace); accountDao.update(account); } } }</code><technical_language>This is implicit side effect. I</technical_language>

Target:
public void beforeStart(@NotNull UsersWorkspace workspace, @Nullable String accountId) throws NotFoundException, ForbiddenException, ServerException { User currentUser = EnvironmentContext.getCurrent().getUser(); if (accountId == null) { if (!accountDao.isWorkspaceRegistered(workspace.getId())) { List<Account> ownedAccounts = accountDao.getByOwner(currentUser.getId()); if (ownedAccounts.size() != 1) { throw new ForbiddenException(format("Workspace start rejected. Impossible to determine account for workspace '%s', " + "user '%s' is owner of zero or several accounts. Specify account identifier!", workspace.getId(), workspace.getOwner())); } Account account = ownedAccounts.get(0); account.getWorkspaces().add(workspace); accountDao.update(account); } } else { try { Account account = accountDao.getByWorkspace(workspace.getId()); if (!account.getId().equals(accountId)) { throw new ForbiddenException(format("Workspace start rejected. Workspace is already added to account '%s' " + "which is different from specified one '%s'", account.getId(), accountId)); } } catch (NotFoundException ignored) { if (accountDao.getMembers(accountId) .stream() .noneMatch(member -> currentUser.getId().equals(member.getUserId()) && member.getRoles().contains("account/owner"))) { throw new ForbiddenException(format("Workspace start rejected. User '%s' doesn't own account '%s'", currentUser.getId(), accountId)); } Account account = accountDao.getById(accountId); account.getWorkspaces().add(workspace); accountDao.update(account); } } }
Source:
<code>public void initialize(final AppStateManager stateManager, final Application app) { super.initialize(stateManager, app); this.app = (Main) app; rootNode = this.app.getRootNode(); assetManager = this.app.getAssetManager(); this.stateManager = stateManager; inputManager = this.app.getInputManager(); viewPort = this.app.getViewPort(); inputManager.setCursorVisible(false); setupTitleScreen(); loadingThread = new LoadingThread(this.name); <START> loadingThread.start(); <END> }</code><technical_language>problem this.... While is ugly create a new thread create this, loading start immediately. instead loading is governed framerate. Well, big of issue. if load app minimized alt tab away. Loading basically starts waits for screen draw</technical_language>

Target:
public void initialize(final AppStateManager stateManager, final Application app) { super.initialize(stateManager, app); this.app = (Main) app; rootNode = this.app.getRootNode(); assetManager = this.app.getAssetManager(); this.stateManager = stateManager; inputManager = this.app.getInputManager(); viewPort = this.app.getViewPort(); inputManager.setCursorVisible(false); setupTitleScreen(); }
Source:
<code>public RegistrationScreenInteractor observeRegistrationScreen() { final MainApplication app = MainApplication.instance(); try { registrationFields = app.getInjector().getInstance(EdxEnvironment.class).getServiceManager().getRegistrationDescription(); } catch (Exception e) { <START> e.printStackTrace(); <END> } final CharSequence title = ResourceUtil.getFormattedString(app.getResources(), R.string.register_title, "platform_name", app.getInjector().getInstance(Config.class).getPlatformName()); onView(withId(R.id.activity_title)).check(matches(withText(title.toString()))); onEmailView().check(matches(isCompletelyDisplayed())); onNameView().check(matches(isCompletelyDisplayed())); onUsernameView().check(matches(isCompletelyDisplayed())); onPasswordView().check(matches(isCompletelyDisplayed())); onCountryView().check(matches(isCompletelyDisplayed())); onCreateAccountButton().check(matches(isCompletelyDisplayed())); return this; }</code><technical_language>this is a test, a test failure here</technical_language>

Target:
public RegistrationScreenInteractor observeRegistrationScreen() { final MainApplication app = MainApplication.instance(); final CharSequence title = ResourceUtil.getFormattedString(app.getResources(), R.string.register_title, "platform_name", app.getInjector().getInstance(Config.class).getPlatformName()); onView(withId(R.id.activity_title)).check(matches(withText(title.toString()))); return this; }
Source:
<code>public void changeDefaultLimitSerializationClassesValueToTrueIn7x() { String codeLocStr = DeploymentDescriptor.class.getProtectionDomain().getCodeSource().getLocation().toString(); Assume.assumeTrue("Test will not succeed in an IDE", codeLocStr.endsWith(".jar")); Matcher matcher = jarLocRegex.matcher(codeLocStr); assertTrue( "Fix regular expression: " + jarLocRegexStr, matcher.matches() ); double jarVersion = Double.parseDouble(matcher.group(1)); DeploymentDescriptorImpl depDesc = new DeploymentDescriptorImpl(); assertTrue( "The default value of 'limitSerializationClasses is FALSE in 6.x and TRUE in 7.x", jarVersion < 7.0d && ! depDesc.getLimitSerializationClasses() <START> || jarVersion >= 7.0d && depDesc.getLimitSerializationClasses() ); <END> }</code><technical_language>is logic changes based version of jBPM code base</technical_language>

Target:
public void changeDefaultLimitSerializationClassesValueToTrueIn7x() throws Exception { Properties props = new Properties(); String testPropsFileName = "test.properties"; InputStream testPropsStream = this.getClass().getResourceAsStream("/" + testPropsFileName); assertNotNull("Unable to find or open " + testPropsFileName, testPropsFileName); props.load(testPropsStream); String projectVersionStr = (String) props.get("project.version"); Matcher matcher = jarLocRegex.matcher(projectVersionStr); assertTrue( "Fix regular expression: " + jarLocRegexStr, matcher.matches() ); double jarVersion = Double.parseDouble(matcher.group(1)); DeploymentDescriptorImpl depDesc = new DeploymentDescriptorImpl(); assertTrue( "The default value of 'limitSerializationClasses is FALSE in 6.x and TRUE in 7.x", jarVersion < 7.0d && ! depDesc.getLimitSerializationClasses() || jarVersion >= 7.0d && depDesc.getLimitSerializationClasses() ); }
Source:
<code>private ValidationResult validateVolumeIdAndUpdatePath(StorageServerConnections connection) { if (connection.getGlusterVolumeId() != null) { GlusterVolumeEntity glusterVolume = glusterVolumeDao.getById(connection.getGlusterVolumeId()); if (glusterVolume == null || glusterVolume.getBricks().isEmpty()) { return new ValidationResult(EngineMessage.VALIDATION_STORAGE_CONNECTION_INVALID_GLUSTER_VOLUME); } Set<String> addressSet = new LinkedHashSet<>(); glusterVolume.getBricks().forEach( brick -> addressSet.add(brick.getNetworkId() != null && !brick.getNetworkAddress().isEmpty() ? brick.getNetworkAddress() : brick.getServerName())); String firstHost = (String) addressSet.toArray()[0]; addressSet.remove(firstHost); connection.setConnection(firstHost + StorageConstants.GLUSTER_VOL_SEPARATOR + glusterVolume.getName()); <START> String mountOptions=""; if (!addressSet.isEmpty()) { mountOptions += StorageConstants.GLUSTER_BACKUP_SERVERS_MNT_OPTION + KEY_VALUE_SEPARATOR + StringUtils.join(addressSet.toArray(), ':'); } <END> if (StringUtils.isBlank(connection.getMountOptions())) { connection.setMountOptions(mountOptions); } else if (!connection.getMountOptions().contains(StorageConstants.GLUSTER_BACKUP_SERVERS_MNT_OPTION)) { mountOptions = connection.getMountOptions().concat("," + mountOptions); connection.setMountOptions(mountOptions); } } return ValidationResult.VALID; }</code><technical_language>JDK's facilities for this: String mountOptions = addressSet.stream().collect(Collectors.joining(":", GLUSTER_BACKUP_SERVERS_MNT_OPTION + KEY_VALUE_SEPARATOR, "")); If else, save ugly check of empty mount options</technical_language>

Target:
private ValidationResult validateVolumeIdAndUpdatePath(StorageServerConnections connection) { if (connection.getGlusterVolumeId() != null) { GlusterVolumeEntity glusterVolume = glusterVolumeDao.getById(connection.getGlusterVolumeId()); if (glusterVolume == null || glusterVolume.getBricks().isEmpty()) { return new ValidationResult(EngineMessage.VALIDATION_STORAGE_CONNECTION_INVALID_GLUSTER_VOLUME); } Set<String> addressSet = new LinkedHashSet<>(); glusterVolume.getBricks().forEach( brick -> addressSet.add(brick.getNetworkId() != null && !brick.getNetworkAddress().isEmpty() ? brick.getNetworkAddress() : brick.getServerName())); String firstHost = (String) addressSet.toArray()[0]; addressSet.remove(firstHost); connection.setConnection(firstHost + StorageConstants.GLUSTER_VOL_SEPARATOR + glusterVolume.getName()); String mountOptions = addressSet.stream().collect(Collectors.joining(":", StorageConstants.GLUSTER_BACKUP_SERVERS_MNT_OPTION + KEY_VALUE_SEPARATOR, "")); if (StringUtils.isBlank(connection.getMountOptions())) { connection.setMountOptions(mountOptions); } else if (!connection.getMountOptions().contains(StorageConstants.GLUSTER_BACKUP_SERVERS_MNT_OPTION)) { mountOptions = connection.getMountOptions().concat("," + mountOptions); connection.setMountOptions(mountOptions); } } return ValidationResult.VALID; }
Source:
<code>private void addResetCurrentPerspectiveShortcut(Composite parent) { ResetLayoutButtonViewModel model = new ResetLayoutButtonViewModel(); model.addPropertyChangeListener("triggerReset", new PropertyChangeListener() { @Override public void propertyChange(PropertyChangeEvent evt) { maximise(); } }); buttonModels.add(model); <START> new ResetLayoutButton(parent, perspectivesProvider, model); <END> }</code><technical_language>add a listener this button model need pass resetTrigger event around</technical_language>

Target:
private void addResetCurrentPerspectiveShortcut(Composite parent) { ResetLayoutButtonViewModel model = new ResetLayoutButtonViewModel(); buttonModels.add(model); ResetLayoutButton button = new ResetLayoutButton(parent, perspectivesProvider, model); button.addMouseListener(new MouseAdapter() { @Override public void mouseDown(MouseEvent e) { maximise(); } }); }
Source:
<code><START> public static String getTextClassifierPath() { <END> return getUserDirectory().getAbsolutePath() + File.separator + TEXT_CLASSIFIERS_SUBDIRECTORY; }</code><technical_language>need public in non-public class</technical_language>

Target:
static String getTextClassifierPath() { return getUserDirectory().getAbsolutePath() + File.separator + TEXT_CLASSIFIERS_SUBDIRECTORY; }
Source:
<code>protected IonSequence newEmptySequence() { <START> return SYSTEM.newDatagram(); <END> }</code><technical_language>I expect instance returned in IonList type hierarchy here. if a datagram I push this method BaseIonSequenceLiteTest in place instead of 2 places</technical_language>

Target:
protected IonSequence newEmptySequence() { return SYSTEM.newEmptyList(); }