auphong2707/dl4se-code-review-dataset huggingface dataset:
Source:
<code>private void refreshTargetForm(TargetBean data) { String value = _targetType.getValue(); if (value != null && !value.equals("")) { TargetType type = TargetType.value(value); _panel.clear(); if (type != null) { switch (type) { case MAVEN: _targetPanel = this._addMavenForm.get(); break; case RHQ: _targetPanel = this._addRhqForm.get(); break; case CLI: _targetPanel = this._addCliForm.get(); break; case COPY: _targetPanel = this._addCopyForm.get(); break; } if (_targetPanel != null) { if (data != null) { _targetPanel.initialize(data); } _panel.add(_targetPanel); } <START> } else { <END> _panel.clear(); } } }</code><technical_language>need for this 'else' block - clear() method called above</technical_language>

Target:
private void refreshTargetForm(TargetBean data) { String value = _targetType.getValue(); if (value != null && !value.equals("")) { TargetType type = TargetType.value(value); _panel.clear(); if (type != null) { switch (type) { case MAVEN: _targetPanel = this._addMavenForm.get(); break; case RHQ: _targetPanel = this._addRhqForm.get(); break; case CLI: _targetPanel = this._addCliForm.get(); break; case COPY: _targetPanel = this._addCopyForm.get(); break; } if (_targetPanel != null) { if (data != null) { _targetPanel.initialize(data); } _panel.add(_targetPanel); } } } }
Source:
<code>public void onFailure(Throwable t) { log.error("Unable to RefreshCapabilities: {}", ExceptionUtils.getRootCauseMessage(t)); log.debug("Exception", t); <START> postProcessRefresh(false, releaseLock.getAndSet(false)); <END> }</code><technical_language>This change lock released in some cases. this change, in case of a failure VdsManager is responsible for releasing lock. VdsManager releases lock in case catches exception. In case of a time-out other SetupNetworks vdsm failure, lock unlocked</technical_language>

Target:
public void onFailure(Throwable t) { log.error("Unable to RefreshCapabilities: {}", ExceptionUtils.getRootCauseMessage(t)); log.debug("Exception", t); postProcessRefresh(false); }
Source:
<code>public void getProductsByAllergen(final String allergen, final int page, final OnAllergensCallback onAllergensCallback) { apiService.getProductsByAllergen(allergen, page).enqueue(new Callback<Search>() { @Override public void onResponse(Call<Search> call, Response<Search> response) { if (!response.isSuccessful()) { onAllergensCallback.onAllergensResponse(false, null); return; } if (Integer.valueOf(response.body().getCount()) == 0) { onAllergensCallback.onAllergensResponse(false, null); } else { onAllergensCallback.onAllergensResponse(true, response.body()); } } @Override public void onFailure(Call<Search> call, Throwable t) { <START> <END> } }); }</code><technical_language>add a log here</technical_language>

Target:
public void getProductsByAllergen(final String allergen, final int page, final OnAllergensCallback onAllergensCallback) { apiService.getProductsByAllergen(allergen, page).enqueue(new Callback<Search>() { @Override public void onResponse(Call<Search> call, Response<Search> response) { if (!response.isSuccessful()) { onAllergensCallback.onAllergensResponse(false, null); return; } if (Integer.valueOf(response.body().getCount()) == 0) { onAllergensCallback.onAllergensResponse(false, null); } else { onAllergensCallback.onAllergensResponse(true, response.body()); } } @Override public void onFailure(Call<Search> call, Throwable t) { onAllergensCallback.onAllergensResponse(false, null); } }); }
Source:
<code>private Collection<Resource> collectTopLevelSemanticResources() { Collection<Resource> semanticResources = new LinkedHashSet<Resource>(); for (DAnalysis analysis : session.allAnalyses()) { for (ResourceDescriptor resourceDesc : analysis.getSemanticResources()) { try { Resource resource = session.getTransactionalEditingDomain().getResourceSet().getResource(resourceDesc.getResourceURI(), <START> true); <END> if (resource != null) { semanticResources.add(resource); } } catch (IllegalStateException e) { if (SiriusPlugin.getDefault().isDebugging()) { SiriusPlugin.getDefault().getLog().log(new Status(IStatus.WARNING, SiriusPlugin.ID, e.getMessage(), e)); } } } } semanticResources.removeAll(session.getControlledResources()); return semanticResources; }</code><technical_language>Call getResource() false for parameter loadOnDemand instead of true lazy</technical_language>

Target:
private Collection<Resource> collectTopLevelSemanticResources() { Collection<Resource> semanticResources = new LinkedHashSet<Resource>(); for (DAnalysis analysis : session.allAnalyses()) { for (ResourceDescriptor resourceDesc : analysis.getSemanticResources()) { try { Resource resource = session.getTransactionalEditingDomain().getResourceSet().getResource(resourceDesc.getResourceURI(), true); if (resource != null) { semanticResources.add(resource); } } catch (WrappedException e) { if (SiriusPlugin.getDefault().isDebugging()) { SiriusPlugin.getDefault().getLog().log(new Status(IStatus.WARNING, SiriusPlugin.ID, e.getMessage(), e)); } } } } semanticResources.removeAll(session.getControlledResources()); return semanticResources; }
Source:
<code>private void migrateBGAlerts() { AlertType.CreateStaticAlerts(); if(prefs.getBoolean("bg_notifications", true)){ double highMark = Double.parseDouble(prefs.getString("highValue", "170")); double lowMark = Double.parseDouble(prefs.getString("lowValue", "70")); boolean doMgdl = (prefs.getString("units", "mgdl").compareTo("mgdl") == 0); if(!doMgdl) { highMark = highMark * Constants.MMOLL_TO_MGDL; lowMark = lowMark * Constants.MMOLL_TO_MGDL; } boolean bg_sound_in_silent = prefs.getBoolean("bg_sound_in_silent", false); String bg_notification_sound = prefs.getString("bg_notification_sound", "content://settings/system/notification_sound"); <START> AlertType.add_alert(null, "High Alert", true, highMark, true, 1, bg_notification_sound, 0, 0, bg_sound_in_silent, SnoozeActivity.getDefaultSnooze(true)); <END> AlertType.add_alert(null, "Low Alert", false, lowMark, true, 1, bg_notification_sound, 0, 0, bg_sound_in_silent, SnoozeActivity.getDefaultSnooze(false)); prefs.edit().putBoolean("bg_notifications", false).apply(); } }</code><technical_language>Im kind of this change, if previously set snooze (with style alerts) I value. Is reason for this change otherwise</technical_language>

Target:
private void migrateBGAlerts() { AlertType.CreateStaticAlerts(); if(prefs.getBoolean("bg_notifications", true)){ double highMark = Double.parseDouble(prefs.getString("highValue", "170")); double lowMark = Double.parseDouble(prefs.getString("lowValue", "70")); boolean doMgdl = (prefs.getString("units", "mgdl").compareTo("mgdl") == 0); if(!doMgdl) { highMark = highMark * Constants.MMOLL_TO_MGDL; lowMark = lowMark * Constants.MMOLL_TO_MGDL; } boolean bg_sound_in_silent = prefs.getBoolean("bg_sound_in_silent", false); String bg_notification_sound = prefs.getString("bg_notification_sound", "content://settings/system/notification_sound"); int bg_high_snooze = Integer.parseInt(prefs.getString("bg_snooze", Integer.toString(SnoozeActivity.getDefaultSnooze(true)))); int bg_low_snooze = Integer.parseInt(prefs.getString("bg_snooze", Integer.toString(SnoozeActivity.getDefaultSnooze(false)))); AlertType.add_alert(null, "High Alert", true, highMark, true, 1, bg_notification_sound, 0, 0, bg_sound_in_silent, bg_high_snooze); AlertType.add_alert(null, "Low Alert", false, lowMark, true, 1, bg_notification_sound, 0, 0, bg_sound_in_silent, bg_low_snooze); prefs.edit().putBoolean("bg_notifications", false).apply(); } }
Source:
<code>public boolean select(Viewer viewer, Object parentElement, Object element) { if (!fEnabled || !(element instanceof ControlFlowEntry)) { return true; } ControlFlowEntry cfe = (ControlFlowEntry) element; if (fCpuRangesBasedFiltering && fCachedOnCpusThreadForTimeRange.contains(cfe.getThreadId())) { return true; } else if (fCachedActiveThreadForTimeRange.contains(cfe.getThreadId())) { return true; } for <START> (@NonNull TimeGraphEntry <END> child : cfe.getChildren()) { if (select(viewer, cfe, child)) { return true; } } return false; }</code><technical_language>if this is ctrl Maj F behaves, convention is @NonNull inline all</technical_language>

Target:
public boolean select(Viewer viewer, Object parentElement, Object element) { if (!fEnabled || !(element instanceof ControlFlowEntry)) { return true; } ControlFlowEntry cfe = (ControlFlowEntry) element; if (fCpuRangesBasedFiltering && fCachedOnCpusThreadForTimeRange.contains(cfe.getThreadId())) { return true; } else if (fCachedActiveThreadForTimeRange.contains(cfe.getThreadId())) { return true; } for (TimeGraphEntry child : cfe.getChildren()) { if (select(viewer, cfe, child)) { return true; } } return false; }
Source:
<code>public Dollars balance() { try { return Dollars.valueOf( <START> new JdkRequest(UriBuilder.fromUri(this.home).build()) <END> .header(HttpHeaders.ACCEPT, MediaType.APPLICATION_XML) .header(HttpHeaders.AUTHORIZATION, this.token) .method(Request.GET) .fetch() .as(RestResponse.class) .assertStatus(HttpURLConnection.HTTP_OK) .as(XmlResponse.class) .xml() .xpath("/page/balance/text()") .get(0) ); } catch (IOException ex) { throw new IllegalStateException(ex); } }</code><technical_language>need do this, this.home is enough</technical_language>

Target:
public Dollars balance() { try { return Dollars.valueOf( new JdkRequest(this.home) .header(HttpHeaders.ACCEPT, MediaType.APPLICATION_XML) .header(HttpHeaders.AUTHORIZATION, this.token) .fetch() .as(RestResponse.class) .assertStatus(HttpURLConnection.HTTP_OK) .as(XmlResponse.class) .xml() .xpath("/page/balance/text()") .get(0) ); } catch (IOException ex) { throw new IllegalStateException(ex); } }
Source:
<code>public void sortShowInPartIds(ArrayList<?> partIds) { Collections.sort(partIds, new Comparator<Object>() { @Override public int <START> compare(Object <END> ob1, Object ob2) { if (mruPartIds.contains(ob1) && !mruPartIds.contains(ob2)) return -1; if (!mruPartIds.contains(ob1) && mruPartIds.contains(ob2)) return 1; return mruPartIds.indexOf(ob1) - mruPartIds.indexOf(ob2); } }); }</code><technical_language>This method more efficient assigning mruPartIds.indexOf(ob1) mruPartIds.indexOf(ob2) variables operating values of variables</technical_language>

Target:
public void sortShowInPartIds(ArrayList<?> partIds) { Collections.sort(partIds, new Comparator<Object>() { @Override public int compare(Object ob1, Object ob2) { int index1 = mruPartIds.indexOf(ob1); int index2 = mruPartIds.indexOf(ob2); if (index1 != -1 && index2 == -1) return -1; if (index1 == -1 && index2 != -1) return 1; return index1 - index2; } }); }
Source:
<code><START> public List<BlockedItem> getBlockedItems() { <END> return new ArrayList<BlockedItem>(snapshot.blockedProjects); }</code><technical_language>@olivergondza noted in commit this public is for testing</technical_language>

Target:
protected List<BlockedItem> getBlockedItems() { return new ArrayList<BlockedItem>(snapshot.blockedProjects); }
Source:
<code><START> public Long poisonStoreAndGetLastAllocatedTimestamp(Connection connection, Limits limits, <END> TableStatus tableStatus) throws SQLException { long lastAllocated; if (tableStatus == TableStatus.NO_DATA) { lastAllocated = AtlasDbFactory.NO_OP_FAST_FORWARD_TIMESTAMP; } else { lastAllocated = limits.upperLimit().get().value(); } poisonTable(connection); return lastAllocated; }</code><technical_language>nit: this need public? missed feels a private thing</technical_language>

Target:
private Long poisonStoreAndGetLastAllocatedTimestamp(Connection connection, Limits limits, TableStatus tableStatus) throws SQLException { long lastAllocated; if (tableStatus == TableStatus.NO_DATA) { lastAllocated = AtlasDbFactory.NO_OP_FAST_FORWARD_TIMESTAMP; } else { lastAllocated = limits.upperLimit().get().value(); } poisonTable(connection); return lastAllocated; }
Source:
<code>private static String[] provideCorrectFormats() { <START> String[] data = new String[] {"", "Knuth", "Donald E. Knuth and Kurt Cobain and A. Einstein"}; <END> return data; }</code><technical_language>a single String string is required test, please code: suggestion return Stream.of("", "Knuth", "Donald E. Knuth Kurt Cobain A. Einstein"); This is more readble String[]. return type Stream<String></technical_language>

Target:
private static Stream<String> provideCorrectFormats() { return Stream.of("", "Knuth", "Donald E. Knuth and Kurt Cobain and A. Einstein"); }
Source:
<code>public boolean isApplicable(String requestPath) { <START> return requestPath.startsWith("druid/coordinator/v1/rules/"); <END> }</code><technical_language>if path is druid/coordinator/v1/rules/ filter fail index out of bounds</technical_language>

Target:
public boolean isApplicable(String requestPath) { List<String> applicablePaths = ImmutableList.of("druid/coordinator/v1/rules/"); for (String path : applicablePaths) { if(requestPath.startsWith(path) && !requestPath.equals(path)) { return true; } } return false; }
Source:
<code><START> public void verifyFollowedBlog(String userName, String blogTitle){ <END> boolean isPresent = false; for (WebElement elem:blogList) { String title = elem.getAttribute("title"); if (title.contains(userName) && title.contains(blogTitle)){ isPresent = true; } } Assertion.assertTrue(isPresent, "blog "+blogTitle+" is not present on the following list"); PageObjectLogging.log("verifyFollowedArticle", userName + " blog is visible on followed list", true); }</code><technical_language>space "{"</technical_language>

Target:
public void verifyFollowedBlog(String userName, String blogTitle) { boolean isPresent = false; for (WebElement elem:blogList) { String title = elem.getAttribute("title"); if (title.contains(userName) && title.contains(blogTitle)) { isPresent = true; } } Assertion.assertTrue(isPresent, "blog " + blogTitle + " is not present on the following list"); PageObjectLogging.log("verifyFollowedBlog", userName + " blog is visible on followed list", true); }
Source:
<code>private boolean generateAdaptorInterface(EObject self, String targetFolder) { try { File folder = new File(targetFolder); List<String> arguments = new <START> ArrayList<String>(); <END> Generate generator = new Generate(self, folder, arguments); generator.doGenerate(new BasicMonitor()); } catch (IOException e) { IStatus status = new Status(IStatus.ERROR, Activator.PLUGIN_ID, e.getMessage(), e); Activator.getDefault().getLog().log(status); DialogInputServices dialogInputServices = new DialogInputServices(); dialogInputServices.showMessage(self, "Exception!", "an Exception occurred during the generation process. Please see the error log."); return false; } return true; }</code><technical_language>JDK compiler infer this type here</technical_language>

Target:
private boolean generateAdaptorInterface(EObject self, String targetFolder) { try { File folder = new File(targetFolder); List<String> arguments = new ArrayList<String>(); Generate generator = new Generate(self, folder, arguments); generator.doGenerate(new BasicMonitor()); } catch (IOException e) { IStatus status = new Status(IStatus.ERROR, Activator.PLUGIN_ID, e.getMessage(), e); logger.log(status); DialogInputServices dialogInputServices = new DialogInputServices(); dialogInputServices.showMessage(self, "Exception!", "an Exception occurred during the generation process. Please see the error log."); return false; } return true; }
Source:
<code>public String getHoverInfo(ITextViewer textViewer, IRegion hoverRegion) { String documentation = null; try { String keyword = textViewer.getDocument().get(hoverRegion.getOffset(), hoverRegion.getLength()); documentation = TapsetLibrary.getDocumentationNoCache("function::" + keyword); if (documentation != null){ return documentation; } documentation = TapsetLibrary.getDocumentationNoCache("probe::" + keyword); if (documentation != null){ return documentation; } documentation = TapsetLibrary.getDocumentationNoCache("tapset::" + keyword); if (documentation != null){ return documentation; } documentation = TapsetLibrary.getDocumentationNoCache("tapset::" + keyword); if (documentation != null){ return documentation; <START> } <END> if (keyword.indexOf('.') > 0){ keyword = keyword.split("\\.")[0]; documentation = TapsetLibrary.getDocumentationNoCache("tapset::" + keyword); } } catch (BadLocationException e) { } return documentation; }</code><technical_language>This condition is a duplicate of previous one</technical_language>

Target:
public String getHoverInfo(ITextViewer textViewer, IRegion hoverRegion) { String documentation = null; try { String keyword = textViewer.getDocument().get(hoverRegion.getOffset(), hoverRegion.getLength()); documentation = TapsetLibrary.getDocumentationNoCache("function::" + keyword); if (documentation != null){ return documentation; } documentation = TapsetLibrary.getDocumentationNoCache("probe::" + keyword); if (documentation != null){ return documentation; } documentation = TapsetLibrary.getDocumentationNoCache("tapset::" + keyword); if (documentation != null){ return documentation; } if (keyword.indexOf('.') > 0){ keyword = keyword.split("\\.")[0]; documentation = TapsetLibrary.getDocumentationNoCache("tapset::" + keyword); } } catch (BadLocationException e) { } return documentation; }
Source:
<code>public void putBulkObjectWithSync() throws Exception { assumeThat(Util.getBlackPearlVersion(client), greaterThan(3.0)); <START> <END> final String bucketName = "test_put_bulk_object"; try { Util.createBucket(client, bucketName); final Arguments args = new Arguments(new String[]{"--http", "-c", "put_bulk", "-b", bucketName, "-d", Util.RESOURCE_BASE_NAME, "--sync"}); CommandResponse response = Util.command(client, args); assertThat(response.getMessage(), is(String.format("SUCCESS: Wrote all the files in %s to bucket %s", ".\\src\\test\\resources\\books", bucketName))); response = Util.command(client, args); assertThat(response.getMessage(), is("SUCCESS: All files are up to date")); } finally { Util.deleteBucket(client, bucketName); } }</code><technical_language>question</technical_language>

Target:
public void putBulkObjectWithSync() throws Exception { assumeThat(Util.getBlackPearlVersion(client), greaterThan(1.2)); final String bucketName = "test_put_bulk_object"; try { Util.createBucket(client, bucketName); final Arguments args = new Arguments(new String[]{"--http", "-c", "put_bulk", "-b", bucketName, "-d", Util.RESOURCE_BASE_NAME, "--sync"}); CommandResponse response = Util.command(client, args); assertThat(response.getMessage(), is(String.format("SUCCESS: Wrote all the files in %s to bucket %s", ".\\src\\test\\resources\\books", bucketName))); response = Util.command(client, args); assertThat(response.getMessage(), is("SUCCESS: All files are up to date")); } finally { Util.deleteBucket(client, bucketName); } }
Source:
<code>protected abstract Object[] readObject(ObjectInputStream ois) throws ClassNotFoundException, IOException; <START> protected abstract boolean resolveAnalysisSegments(ISegmentStore<ISegment> segments, IProgressMonitor monitor) throws TmfAnalysisException; <END> @Override public @Nullable ISegmentStore<ISegment> getSegmentStore() { return fSegmentStore; }</code><technical_language>method name though. "build" in state system analysis? "buildAnalysisSegments" for more clarity. all, is called if previously saved disk</technical_language>

Target:
protected abstract Object[] readObject(ObjectInputStream ois) throws ClassNotFoundException, IOException; protected abstract boolean buildAnalysisSegments(ISegmentStore<ISegment> segments, IProgressMonitor monitor) throws TmfAnalysisException; @Override public @Nullable ISegmentStore<ISegment> getSegmentStore() { return fSegmentStore; }
Source:
<code>public static InputStream getContactPhotoStream(ContentResolver contentResolver, Uri uri) { if (Build.VERSION.SDK_INT < Build.VERSION_CODES.ICE_CREAM_SANDWICH) { final Uri contactUri = uri.toString().startsWith( ContactsContract.Contacts.CONTENT_LOOKUP_URI.toString()) ? ContactsContract.Contacts.lookupContact(contentResolver, uri) <START> : uri; <END> return openContactPhotoInputStream(contentResolver, contactUri); } else { return ContactPhotoStreamIcs.get(contentResolver, uri); } }</code><technical_language>I this like: java if (uri.toString().startsWith(Contacts.CONTENT_LOOKUP_URI.toString()) { uri = Contacts.lookupContact(contentResolver, uri); } avoid unnecessary assignment Uri match</technical_language>

Target:
public static InputStream getContactPhotoStream(ContentResolver contentResolver, Uri uri) { if (Build.VERSION.SDK_INT < Build.VERSION_CODES.ICE_CREAM_SANDWICH) { if (uri.toString().startsWith(ContactsContract.Contacts.CONTENT_LOOKUP_URI.toString())) uri = ContactsContract.Contacts.lookupContact(contentResolver, uri); return openContactPhotoInputStream(contentResolver, uri); } else { return ContactPhotoStreamIcs.get(contentResolver, uri); } }
Source:
<code>protected void validate() throws AxonConfigurationException { assertNonNull(retryExecutor, "The ScheduledExecutorService is a hard requirement and should be provided"); <START> assertStrictPositive(maxRetryCount, "The maxRetryCount is a hard requirement and should be provided"); <END> }</code><technical_language>message in assertStrictPositive incorrect me. state lines of maxRetryCount is a strictly positive number</technical_language>

Target:
protected void validate() throws AxonConfigurationException { assertNonNull(retryExecutor, "The ScheduledExecutorService is a hard requirement and should be provided"); assertStrictPositive(maxRetryCount, "The maxRetryCount is a hard requirement and must be at least 1"); }
Source:
<code>public void testAwsV4Failure() throws Exception { BasicAWSCredentials awsCreds = new BasicAWSCredentials(s3Identity, s3Credential); AmazonS3 client = new AmazonS3Client(awsCreds); client.setEndpoint(s3Endpoint.toString()); try { <START> client.getObject(containerName, "foo"); <END> } catch (AmazonS3Exception e) { assertThat(e.getErrorCode()).isEqualToIgnoringCase( "InvalidArgument"); assertThat(e.getStatusCode()).isEqualTo(400); } }</code><technical_language>need call fail() call ensure S3Proxy throws expected exception</technical_language>

Target:
public void testAwsV4Failure() throws Exception { BasicAWSCredentials awsCreds = new BasicAWSCredentials(s3Identity, s3Credential); AmazonS3 client = new AmazonS3Client(awsCreds); client.setEndpoint(s3Endpoint.toString()); thrown.expect(AmazonS3Exception.class); thrown.expectMessage("Status Code: 400; Error Code: InvalidArgument"); client.getObject(containerName, "foo"); }
Source:
<code>public <T> Collection<ValidationMessage> validateForSave( final Path path, final T content ) { <START> return (Collection<ValidationMessage>) saveValidators.stream().filter( v -> v.accept( path ) ).flatMap( c -> c.validate( path, <END> content ).stream().filter( r -> r != null ) ).collect( Collectors.toList() ); }</code><technical_language>null ValidationMessage? (it filter list validation for nulls)</technical_language>

Target:
public <T> Collection<ValidationMessage> validateForSave( final Path path, final T content ) { return (Collection<ValidationMessage>) saveValidators.stream().filter( v -> v.accept( path ) ).flatMap( c -> c.validate( path, content ).stream() ).collect( Collectors.toList() ); }
Source:
<code>public void verifyPageUnfollowed() { <START> waitForTextToBePresentInElementByElement(followButton, "Follow"); <END> }</code><technical_language>add log</technical_language>

Target:
public void verifyPageUnfollowed() { waitForTextToBePresentInElementByElement(followButton, "Follow"); PageObjectLogging.log("verifyPageUnfollowed", "page is not followed", true); }
Source:
<code><START> private String escapeValue(String value) { <END> if (value.contains("'")) { value = value.replace("'", "''"); } if (value.contains(COMMA)) { value = SINGLE_QUOTE + value + SINGLE_QUOTE; } return value; }</code><technical_language>This static</technical_language>

Target:
private static String escapeValue(String value) { if (value.contains("'")) { value = value.replace("'", "''"); } if (value.contains(COMMA)) { value = SINGLE_QUOTE + value + SINGLE_QUOTE; } return value; }
Source:
<code>public List<FileChunk> get() throws IOException { <START> return pullServerService != null ? getDirect() : getFromFetchURI(); <END> }</code><technical_language>local fetcher connect remote server</technical_language>

Target:
public List<FileChunk> get() throws IOException { this.startTime = System.currentTimeMillis(); return pullServerService != null ? getWithInternalPullServer() : getWithExternalPullServer(); }
Source:
<code>public void handle(CacheRpcCommand command, Reply reply, DeliverOrder order) { if (order == DeliverOrder.TOTAL) { unexpectedDeliverMode(command, order); } try { final int commandTopologyId = extractCommandTopologyId(command); if (isCommandSentBeforeFirstTopology(commandTopologyId)) { reply.reply(CacheNotFoundResponse.INSTANCE); return; } final boolean waitTransactionalData = command.getCommandId() != StateRequestCommand.COMMAND_ID; final boolean onExecutorService = executeOnExecutorService(order, command); switch (command.getCommandId()) { case PrepareCommand.COMMAND_ID: case VersionedPrepareCommand.COMMAND_ID: case TotalOrderNonVersionedPrepareCommand.COMMAND_ID: case TotalOrderVersionedPrepareCommand.COMMAND_ID: case CommitCommand.COMMAND_ID: case VersionedCommitCommand.COMMAND_ID: case TotalOrderCommitCommand.COMMAND_ID: case TotalOrderVersionedCommitCommand.COMMAND_ID: case RollbackCommand.COMMAND_ID: case TotalOrderRollbackCommand.COMMAND_ID: case LockControlCommand.COMMAND_ID: <START> throw new IllegalArgumentException("Illegal Command ID: " + command.getCommandId() + ". Transactional commands are not allowed."); <END> } handleRunnable(createDefaultRunnable(command, reply, commandTopologyId, waitTransactionalData, onExecutorService), onExecutorService); } catch (Throwable throwable) { reply.reply(exceptionHandlingCommand(command, throwable)); } }</code><technical_language>simpler check for SingleRpcCommand MultipleRpcCommand instead</technical_language>

Target:
public void handle(CacheRpcCommand command, Reply reply, DeliverOrder order) { if (order == DeliverOrder.TOTAL) { unexpectedDeliverMode(command, order); } try { final int commandTopologyId = extractCommandTopologyId(command); final boolean waitTransactionalData = command.getCommandId() != StateRequestCommand.COMMAND_ID; final boolean onExecutorService = executeOnExecutorService(order, command); handleRunnable(createDefaultRunnable(command, reply, commandTopologyId, waitTransactionalData, onExecutorService), onExecutorService); } catch (Throwable throwable) { reply.reply(exceptionHandlingCommand(command, throwable)); } }
Source:
<code>public Object execute(ExecutionEvent event) throws ExecutionException { Repository repository = getRepository(event); <START> if (repository == null) { <END> return null; } PushToGerritWizard wiz = new PushToGerritWizard(repository); WizardDialog dlg = new WizardDialog(HandlerUtil .getActiveShellChecked(event), wiz); dlg.setHelpAvailable(false); dlg.open(); return null; }</code><technical_language>style nit: braces single line blocks</technical_language>

Target:
public Object execute(ExecutionEvent event) throws ExecutionException { Repository repository = getRepository(event); if (repository == null) return null; PushToGerritWizard wiz = new PushToGerritWizard(repository); WizardDialog dlg = new WizardDialog(HandlerUtil .getActiveShellChecked(event), wiz); dlg.setHelpAvailable(false); dlg.open(); return null; }
Source:
<code>public MSPTest() { <START> super(); <END> getAttributes().setType("MSPTest"); }</code><technical_language>Nitpicking suggestion super();</technical_language>

Target:
public MSPTest() { getAttributes().setType("MSPTest"); }
Source:
<code>public void visitNode(Tree tree) { if (!hasSemantic()) { return; } CompilationUnitTree cut = (CompilationUnitTree) tree; cut.types().stream().filter(NOT_EMPTY_STATEMENT).map(t -> ((ClassTree) t).symbol()).forEach(this::checkSymbol); List<ImportTree> imports = cut.imports().stream().filter(NOT_EMPTY_STATEMENT).map(t -> (ImportTree) t).collect(Collectors.toList()); <START> boolean fileContainsStarImport = false; <END> for (ImportTree importTree : imports) { if (importTree.qualifiedIdentifier().is(Kind.MEMBER_SELECT)) { IdentifierTree identifier = ((MemberSelectExpressionTree) importTree.qualifiedIdentifier()).identifier(); if ("*".equals(identifier.name())) { fileContainsStarImport = true; break; } } } if(!fileContainsStarImport) { checkImports(imports); } }</code><technical_language>Is a reason streams? I prefer style other, mixing</technical_language>

Target:
public void visitNode(Tree tree) { if (!hasSemantic()) { return; } CompilationUnitTree cut = (CompilationUnitTree) tree; cut.types().stream().filter(NOT_EMPTY_STATEMENT).map(t -> ((ClassTree) t).symbol()).forEach(this::checkSymbol); List<ImportTree> imports = cut.imports().stream().filter(NOT_EMPTY_STATEMENT).map(t -> (ImportTree) t).collect(Collectors.toList()); boolean fileContainsStarImport = imports.stream() .filter(it -> it.qualifiedIdentifier().is(Kind.MEMBER_SELECT)) .map(it -> ((MemberSelectExpressionTree) it.qualifiedIdentifier()).identifier()) .anyMatch(i -> "*".equals(i.name())); if(!fileContainsStarImport) { checkImports(imports); } }
Source:
<code>private HashUtil() { <START> throw new UnsupportedOperationException(); <END> }</code><technical_language>need for this exception. This class instantiated anyway</technical_language>

Target:
private HashUtil() { }
Source:
<code>public AssociationLnListTypeBuilder withEmptyLists() { <START> return this; <END> }</code><technical_language>method name correct if withEmptyLists called a call withNonEmptyLists? method says, expected conditions, set this.associationLnListElement = new ArrayList<>(); returning this</technical_language>

Target:
public AssociationLnListTypeBuilder withEmptyLists() { this.associationLnListElement = new ArrayList<>(); return this; }
Source:
<code>public void addSubmitRecords(ChangeAttribute ca, List<SubmitRecord> submitRecords) { ca.submitRecords = new ArrayList<SubmitRecordAttribute>(); for (SubmitRecord submitRecord : submitRecords) { SubmitRecordAttribute sa = new SubmitRecordAttribute(); switch (submitRecord.status) { case OK: sa.status = "OK"; break; case NOT_READY: sa.status = "NOT_READY"; if (!submitRecord.labels.isEmpty()) { sa.labels = new ArrayList<SubmitLabelAttribute>(); for (SubmitRecord.Label lbl : submitRecord.labels) { SubmitLabelAttribute la = new SubmitLabelAttribute(); la.label = lbl.label; switch (lbl.status) { case OK: la.status = "OK"; break; case REJECT: la.status = "REJECT"; break; case NEED: la.status = "NEED"; break; case IMPOSSIBLE: la.status = "IMPOSSIBLE"; break; <START> <END> default: throw new IllegalArgumentException( "Unsupported SubmitRecord.Label.status (" + lbl.status + ")"); } sa.labels.add(la); } } break; case CLOSED: sa.status = "CLOSED"; break; case RULE_ERROR: sa.status = "RULE_ERROR"; break; default: throw new IllegalStateException( "Unsupported SubmitRecord.status + (" + submitRecord.status + ")"); } ca.submitRecords.add(sa); } if (ca.submitRecords.isEmpty()) { ca.submitRecords = null; } }</code><technical_language>I need well. (Introduced recently)</technical_language>

Target:
public void addSubmitRecords(ChangeAttribute ca, List<SubmitRecord> submitRecords) { ca.submitRecords = new ArrayList<SubmitRecordAttribute>(); for (SubmitRecord submitRecord : submitRecords) { SubmitRecordAttribute sa = new SubmitRecordAttribute(); switch (submitRecord.status) { case OK: sa.status = "OK"; break; case NOT_READY: sa.status = "NOT_READY"; if (!submitRecord.labels.isEmpty()) { sa.labels = new ArrayList<SubmitLabelAttribute>(); for (SubmitRecord.Label lbl : submitRecord.labels) { SubmitLabelAttribute la = new SubmitLabelAttribute(); la.label = lbl.label; switch (lbl.status) { case OK: la.status = "OK"; break; case REJECT: la.status = "REJECT"; break; case NEED: la.status = "NEED"; break; case MAY: la.status = "MAY"; break; case IMPOSSIBLE: la.status = "IMPOSSIBLE"; break; default: throw new IllegalArgumentException( "Unsupported SubmitRecord.Label.status (" + lbl.status + ")"); } sa.labels.add(la); } } break; case CLOSED: sa.status = "CLOSED"; break; case RULE_ERROR: sa.status = "RULE_ERROR"; break; default: throw new IllegalStateException( "Unsupported SubmitRecord.status + (" + submitRecord.status + ")"); } ca.submitRecords.add(sa); } if (ca.submitRecords.isEmpty()) { ca.submitRecords = null; } }
Source:
<code>public String serialize(Protocol protocol) { <START> return "key=value"; <END> }</code><technical_language>This is absolute BS, fix this tomorrow</technical_language>

Target:
public String serialize(Protocol protocol) { return ""; }
Source:
<code>protected Container(String name, long objectCount, long bytesUsed, Optional<Boolean> anybodyRead, Map<String, String> metadata, Multimap<String, String> headers) { this.name = checkNotNull(name, "name"); this.objectCount = objectCount; this.bytesUsed = bytesUsed; this.anybodyRead = anybodyRead == null ? Optional.<Boolean> absent() : anybodyRead; this.metadata = metadata == null ? ImmutableMap.<String, String> of() : metadata; <START> this.headers = headers == null ? ImmutableMultimap.<String, String> of() : checkNotNull(headers, "headers"); <END> }</code><technical_language>need checkNotNull here</technical_language>

Target:
protected Container(String name, long objectCount, long bytesUsed, Optional<Boolean> anybodyRead, Map<String, String> metadata, Multimap<String, String> headers) { this.name = checkNotNull(name, "name"); this.objectCount = objectCount; this.bytesUsed = bytesUsed; this.anybodyRead = anybodyRead == null ? Optional.<Boolean> absent() : anybodyRead; this.metadata = metadata == null ? ImmutableMap.<String, String> of() : metadata; this.headers = headers == null ? ImmutableMultimap.<String, String> of() : headers; }
Source:
<code>public void testExecutorEvents() throws Exception { if (!isTestSetup()) { return; } ExecutorLoader loader = createLoader(); int skip = 1; User user = new User("testUser"); Executor executor = new Executor(1, "localhost", 12345); String message = "My message "; EventType[] events = { EventType.CREATED, EventType.HOST_UPDATE, EventType.INACTIVATION }; for (EventType event : events) { loader.postEvent(executor, event, user.getUserId(), message + event.getNumVal()); } List<ExecutorLogEvent> eventLogs = loader.getExecutorEvents(executor, 10, skip); Assert.assertTrue(eventLogs.size() == 2); for (int index = 0; index < eventLogs.size(); ++index) { ExecutorLogEvent eventLog = eventLogs.get(index); Assert.assertEquals(eventLog.getExecutorId(), executor.getId()); Assert.assertEquals(eventLog.getUser(), user.getUserId()); Assert.assertEquals(eventLog.getType(), events[index + skip]); Assert.assertEquals(eventLog.getMessage(), message + events[index + skip].getNumVal()); } <START> clearDB(); <END> }</code><technical_language>performing clearDB() in a general test cleanup method test remember do this</technical_language>

Target:
public void testExecutorEvents() throws Exception { if (!isTestSetup()) { return; } ExecutorLoader loader = createLoader(); int skip = 1; User user = new User("testUser"); Executor executor = new Executor(1, "localhost", 12345, true); String message = "My message "; EventType[] events = { EventType.CREATED, EventType.HOST_UPDATE, EventType.INACTIVATION }; for (EventType event : events) { loader.postExecutorEvent(executor, event, user.getUserId(), message + event.getNumVal()); } List<ExecutorLogEvent> eventLogs = loader.getExecutorEvents(executor, 10, skip); Assert.assertTrue(eventLogs.size() == 2); for (int index = 0; index < eventLogs.size(); ++index) { ExecutorLogEvent eventLog = eventLogs.get(index); Assert.assertEquals(eventLog.getExecutorId(), executor.getId()); Assert.assertEquals(eventLog.getUser(), user.getUserId()); Assert.assertEquals(eventLog.getType(), events[index + skip]); Assert.assertEquals(eventLog.getMessage(), message + events[index + skip].getNumVal()); } }
Source:
<code>private IjSourceFolder createSourceFolder( IjFolder folder, Path moduleLocationBasePath, @Nullable String packagePrefix) { Path relativeOutputPath = null; ResourceFolderType resourceFolderType = ResourceFolderType.JAVA_RESOURCE; <START> if (folder instanceof JavaResourceFolder) { <END> relativeOutputPath = ((JavaResourceFolder) folder).getRelativeOutputPath().orElse(null); resourceFolderType = ResourceFolderType.JAVA_RESOURCE; } else if (folder instanceof JavaTestResourceFolder) { relativeOutputPath = ((JavaTestResourceFolder) folder).getRelativeOutputPath().orElse(null); resourceFolderType = ResourceFolderType.JAVA_TEST_RESOURCE; } return IjSourceFolder.builder() .setType(folder.getIjName()) .setUrl( IjProjectPaths.toModuleDirRelativeString(folder.getPath(), moduleLocationBasePath)) .setPath(folder.getPath()) .setIsTestSource(folder instanceof TestFolder) .setIsResourceFolder( (folder instanceof AndroidResourceFolder) || (folder instanceof JavaResourceFolder) || (folder instanceof JavaTestResourceFolder)) .setResourceFolderType(resourceFolderType) .setRelativeOutputPath(relativeOutputPath) .setPackagePrefix(packagePrefix) .build(); }</code><technical_language>replace this this: if (folder instanceof ResourceFolder) { ResourceFolder resourceFolder = (ResourceFolder) folder; relativeOutputPath = resourceFolder.getRelativeOutputPath().orElse(null); resourceFolderType = resourceFolder.getResourceFolderType(); } need add missing methods ResourceFolder though</technical_language>

Target:
private IjSourceFolder createSourceFolder( IjFolder folder, Path moduleLocationBasePath, @Nullable String packagePrefix) { Path relativeOutputPath = null; IjResourceFolderType ijResourceFolderType = IjResourceFolderType.JAVA_RESOURCE; if (folder instanceof ResourceFolder) { ResourceFolder resourceFolder = (ResourceFolder) folder; relativeOutputPath = resourceFolder.getRelativeOutputPath(); ijResourceFolderType = resourceFolder.getResourceFolderType(); } return IjSourceFolder.builder() .setType(folder.getIjName()) .setUrl( IjProjectPaths.toModuleDirRelativeString(folder.getPath(), moduleLocationBasePath)) .setPath(folder.getPath()) .setIsTestSource(folder instanceof TestFolder) .setIsResourceFolder(folder.isResourceFolder()) .setIjResourceFolderType(ijResourceFolderType) .setRelativeOutputPath(relativeOutputPath) .setPackagePrefix(packagePrefix) .build(); }
Source:
<code>if (PlatformDependent.javaVersion() >= 11) { final Object maybeException = AccessController.doPrivileged(new PrivilegedAction<Object>() { @Override public Object run() { try { return Inflater.class.getDeclaredMethod("setInput", ByteBuffer.class); } catch (NoSuchMethodException e) { return e; } catch (SecurityException e) { return e; } } }); if (maybeException instanceof Method) { inflaterSetInput = (Method) maybeException; logger.debug("Inflater.setInput(ByteBuffer): available"); } else { <START> logger.debug("Inflater.setInput(ByteBuffer): available"); <END> } }</code><technical_language>@fabienrenaud this is correct... include exception</technical_language>

Target:
if (PlatformDependent.javaVersion() >= 11) { final Object maybeException = AccessController.doPrivileged(new PrivilegedAction<Object>() { @Override public Object run() { try { return Inflater.class.getDeclaredMethod("setInput", ByteBuffer.class); } catch (NoSuchMethodException e) { return e; } catch (SecurityException e) { return e; } } }); if (maybeException instanceof Method) { inflaterSetInput = (Method) maybeException; logger.debug("Inflater.setInput(ByteBuffer): available"); } else { logger.debug("Inflater.setInput(ByteBuffer): unavailable", maybeException); } }
Source:
<code>public Map<String, Object> initializeLookups(String filePath) throws Exception { String url = StringUtils.format("%slookups/config", getCoordinatorURL()); StatusResponseHolder response = httpClient.go( new Request(HttpMethod.POST, new URL(url)).setContent( "application/json", jsonMapper.writeValueAsBytes(ImmutableMap.of()) ), responseHandler ).get(); if (!response.getStatus().equals(HttpResponseStatus.ACCEPTED)) { throw new ISE( "Error while querying[%s] status[%s] content[%s]", url, response.getStatus(), response.getContent() ); } <START> @SuppressWarnings("unused") END> Map<String, Object> results = jsonMapper.readValue( response.getContent(), new TypeReference<Map<String, Object>>(){} ); StatusResponseHolder response2 = httpClient.go( new Request(HttpMethod.POST, new URL(url)).setContent( "application/json", jsonMapper.writeValueAsBytes(jsonMapper.readValue(CoordinatorResourceTestClient.class.getResourceAsStream(filePath), new TypeReference<Map<Object, Object>>(){})) ), responseHandler ).get(); if (!response2.getStatus().equals(HttpResponseStatus.ACCEPTED)) { throw new ISE( "Error while querying[%s] status[%s] content[%s]", url, response2.getStatus(), response2.getContent() ); } Map<String, Object> results2 = jsonMapper.readValue( response.getContent(), new TypeReference<Map<String, Object>>() { } ); return results2; }</code><technical_language>I meaningful side effects. response.getContent() is a string read, trigger reading a stream that. fine remove</technical_language>

Target:
public Map<String, Object> initializeLookups(String filePath) throws Exception { String url = StringUtils.format("%slookups/config", getCoordinatorURL()); StatusResponseHolder response = httpClient.go( new Request(HttpMethod.POST, new URL(url)).setContent( "application/json", jsonMapper.writeValueAsBytes(ImmutableMap.of()) ), responseHandler ).get(); if (!response.getStatus().equals(HttpResponseStatus.ACCEPTED)) { throw new ISE( "Error while querying[%s] status[%s] content[%s]", url, response.getStatus(), response.getContent() ); } StatusResponseHolder response2 = httpClient.go( new Request(HttpMethod.POST, new URL(url)).setContent( "application/json", jsonMapper.writeValueAsBytes(jsonMapper.readValue(CoordinatorResourceTestClient.class.getResourceAsStream(filePath), new TypeReference<Map<Object, Object>>(){})) ), responseHandler ).get(); if (!response2.getStatus().equals(HttpResponseStatus.ACCEPTED)) { throw new ISE( "Error while querying[%s] status[%s] content[%s]", url, response2.getStatus(), response2.getContent() ); } Map<String, Object> results2 = jsonMapper.readValue( response.getContent(), new TypeReference<Map<String, Object>>() { } ); return results2; }
Source:
<code><START> private void <END> addRepeatedAnnotationHandlers( Builder<String, AnnotationHandler> builder, String annotationName, String containerAnnotationName, AnnotationHandler handler) { builder.put(annotationName, handler); builder.put(containerAnnotationName, new RepeatedAnnotationHandler(annotationName, handler)); }</code><technical_language>static</technical_language>

Target:
private static Builder<String, AnnotationHandler> addRepeatedAnnotationHandlers( Builder<String, AnnotationHandler> builder, String annotationName, String containerAnnotationName, AnnotationHandler handler) { builder.put(annotationName, handler); builder.put(containerAnnotationName, new RepeatedAnnotationHandler(annotationName, handler)); return builder; }
Source:
<code>public HttpLogOptions() { logLevel = HttpLogDetailLevel.NONE; <START> allowedHeaderNames = new HashSet<>(Arrays.asList( <END> "x-ms-client-request-id", "x-ms-return-client-request-id", "traceparent", "Accept", "Cache-Control", "Connection", "Content-Length", "Content-Type", "Date", "ETag", "Expires", "If-Match", "If-Modified-Since", "If-None-Match", "If-Unmodified-Since", "Last-Modified", "Pragma", "Request-Id", "Retry-After", "Server", "Transfer-Encoding", "User-Agent" )); allowedQueryParamNames = new HashSet<>(); }</code><technical_language>Extract Arrays.asList() a static field reuse. create a list a hashset time instance of HttpLogOptions is created</technical_language>

Target:
public HttpLogOptions() { logLevel = HttpLogDetailLevel.NONE; allowedHeaderNames = new HashSet<>(); allowedQueryParamNames = new HashSet<>(DEFAULT_HEADERS_WHITELIST); }
Source:
<code>public static boolean launchIEMIDlet(String midletSuiteVendor, String midletName, int midletNumber, String startupNoteText, String args) { System.out.println("midletSuiteVendor: " + midletSuiteVendor); System.out.println("midletName: " + midletName); System.out.println("midletNumber: " + midletNumber); System.out.println("startupNoteText: " + startupNoteText); <START> System.out.println("args: " + args); <END> BGUtils.launchMIDletCalled = true; BGUtils.waitUserInteraction(); try { BGUtils.addSystemProperties(args); MIDletSuiteUtils.execute(midletNumber, BGUtils.getFGMIDletClass(), null); } catch (Exception e) { System.out.println("Unexpected exception: " + e); e.printStackTrace(); } return true; }</code><technical_language>Added for debugging</technical_language>

Target:
public static boolean launchIEMIDlet(String midletSuiteVendor, String midletName, int midletNumber, String startupNoteText, String args) { BGUtils.launchMIDletCalled = true; BGUtils.waitUserInteraction(); try { BGUtils.addSystemProperties(args); MIDletSuiteUtils.execute(midletNumber, BGUtils.getFGMIDletClass(), null); } catch (Exception e) { System.out.println("Unexpected exception: " + e); e.printStackTrace(); } return true; }
Source:
<code><START> public boolean onLongClick(View v) { <END> EditorTools newTool = EditorTools.NONE; switch(v.getId()) { case R.id.editor_tools_marker: newTool = EditorTools.MARKER; break; case R.id.editor_tools_draw: newTool = EditorTools.DRAW; break; case R.id.editor_tools_poly: newTool = EditorTools.POLY; break; case R.id.editor_tools_trash: newTool = EditorTools.TRASH; break; } if(newTool != EditorTools.NONE) { listner.editorToolLongClicked(newTool); } return false; }</code><technical_language>This block indented more time. a more places in this pull request indents off, check well</technical_language>

Target:
public boolean onLongClick(View v) { EditorTools newTool = EditorTools.NONE; switch (v.getId()) { case R.id.editor_tools_marker: newTool = EditorTools.MARKER; break; case R.id.editor_tools_draw: newTool = EditorTools.DRAW; break; case R.id.editor_tools_poly: newTool = EditorTools.POLY; break; case R.id.editor_tools_trash: newTool = EditorTools.TRASH; break; } if(newTool != EditorTools.NONE) { listener.editorToolLongClicked(newTool); } return false; }
Source:
<code>private void applyDiff(SetDiff<? extends E> diff, Set<E> set) { for (E <START> name : <END> diff.getRemovals()) { set.remove(name); } for (E name : diff.getAdditions()) { set.add(name); } }</code><technical_language>rename removal</technical_language>

Target:
private void applyDiff(SetDiff<? extends E> diff, Set<E> set) { for (E removal : diff.getRemovals()) { set.remove(removal); } for (E addition : diff.getAdditions()) { set.add(addition); } }
Source:
<code>public static OwnCloudVersion getServerVersion(Account account) { OwnCloudVersion serverVersion = null; if (account != null) { <START> FileDataStorageManager fds = new FileDataStorageManager( <END> account, MainApp.getAppContext().getContentResolver() ); OCCapability capability = fds.getCapability(account.name); if (capability != null) { serverVersion = new OwnCloudVersion(capability.getVersionString()); } else { AccountManager accountMgr = AccountManager.get(MainApp.getAppContext()); String serverVersionStr = accountMgr.getUserData(account, Constants.KEY_OC_VERSION); if (serverVersionStr != null) { serverVersion = new OwnCloudVersion(serverVersionStr); } } } return serverVersion; }</code><technical_language>I rename **fds** variable name a more specific **fileDataStorageManager**. In this part of code, is, if in other part below, it</technical_language>

Target:
public static OwnCloudVersion getServerVersion(Account account) { OwnCloudVersion serverVersion = null; if (account != null) { FileDataStorageManager fileDataStorageManager = new FileDataStorageManager( account, MainApp.getAppContext().getContentResolver() ); OCCapability capability = fileDataStorageManager.getCapability(account.name); if (capability != null) { serverVersion = new OwnCloudVersion(capability.getVersionString()); } else { AccountManager accountMgr = AccountManager.get(MainApp.getAppContext()); String serverVersionStr = accountMgr.getUserData(account, Constants.KEY_OC_VERSION); if (serverVersionStr != null) { serverVersion = new OwnCloudVersion(serverVersionStr); } } } return serverVersion; }