auphong2707/dl4se-code-review-dataset huggingface dataset:
Source:
<code><START> private void createAttributeEditors(FormToolkit toolkit, Composite peopleComposite) { <END> Collection<TaskAttribute> attributes = getAttributes(); for (TaskAttribute attribute : attributes) { addAttribute(peopleComposite, toolkit, attribute); } }</code><technical_language>leave this protected avoid breaking people</technical_language>

Target:
protected void createAttributeEditors(FormToolkit toolkit, Composite peopleComposite) { Collection<TaskAttribute> attributes = getAttributes(); for (TaskAttribute attribute : attributes) { addAttribute(peopleComposite, toolkit, attribute); } }
Source:
<code>private void validateNewCommits(RefControl ctl, ReceiveCommand cmd) { final RevWalk walk = rp.getRevWalk(); walk.reset(); walk.sort(RevSort.NONE); ObjectInserter inserter = null; try { walk.markStart(walk.parseCommit(cmd.getNewId())); for (ObjectId id : existingObjects()) { try { walk.markUninteresting(walk.parseCommit(id)); } catch (IOException e) { continue; } } RevCommit c; boolean forReview = MagicBranch.isMagicBranch(cmd.getRefName()) || NEW_PATCHSET.matcher(cmd.getRefName()).matches(); while ((c = walk.next()) != null) { if (!validCommit(ctl, cmd, c)) { break; } if (!forReview) { if (inserter == null) { inserter = repo.newObjectInserter(); bypassReviewCommitMsg = new StringBuilder("Update notes for bypassed code-review\n\n"); } bypassReviewNotes.set(c, noReviewNoteContent(c, ctl.getRefName()), inserter); bypassReviewCommitMsg.append("* ").append(c.getShortMessage()) .append("\n"); } <START> } <END> } catch (IOException err) { cmd.setResult(Result.REJECTED_MISSING_OBJECT); log.error("Invalid pack upload; one or more objects weren't sent", err); } finally { if (inserter != null) { inserter.release(); } } }</code><technical_language>I missing this for success case: if (inserter != null) { inserter.flush(); } JGit inserter API requires a flush objects visible for readers. Inserters free throw data if released a flush. DFS backend servers behaves this way</technical_language>

Target:
private void validateNewCommits(RefControl ctl, ReceiveCommand cmd) { final RevWalk walk = rp.getRevWalk(); walk.reset(); walk.sort(RevSort.NONE); ObjectInserter inserter = null; try { walk.markStart(walk.parseCommit(cmd.getNewId())); for (ObjectId id : existingObjects()) { try { walk.markUninteresting(walk.parseCommit(id)); } catch (IOException e) { continue; } } RevCommit c; boolean forReview = MagicBranch.isMagicBranch(cmd.getRefName()) || NEW_PATCHSET.matcher(cmd.getRefName()).matches(); while ((c = walk.next()) != null) { if (!validCommit(ctl, cmd, c)) { break; } if (!forReview) { if (inserter == null) { inserter = repo.newObjectInserter(); bypassReviewCommitMsg = new StringBuilder("Update notes for bypassed code-review\n\n"); } bypassReviewNotes.set(c, noReviewNoteContent(c, ctl.getRefName()), inserter); bypassReviewCommitMsg.append("* ").append(c.getShortMessage()) .append("\n"); } } if (inserter != null) { inserter.flush(); } } catch (IOException err) { cmd.setResult(REJECTED_MISSING_OBJECT); log.error("Invalid pack upload; one or more objects weren't sent", err); } finally { if (inserter != null) { inserter.release(); } } }
Source:
<code>public void copyToAndFromRealm() { AllJavaTypes unmanagedChild = new AllJavaTypes(1); assertNull(unmanagedChild.getObjectParents()); realm.beginTransaction(); AllJavaTypes parent = realm.createObject(AllJavaTypes.class, 2); AllJavaTypes child = realm.copyToRealm(unmanagedChild); parent.setFieldObject(child); realm.commitTransaction(); RealmResults<AllJavaTypes> parents = child.getObjectParents(); assertNotNull(parents); assertEquals(1, parents.size()); assertEquals(parent, parents.first()); unmanagedChild = realm.copyFromRealm(child); assertEquals(unmanagedChild.getFieldId(), 1); assertNull(unmanagedChild.getObjectParents()); <START> RealmResults<AllJavaTypes> queryResults = realm.where(AllJavaTypes.class).equalTo("fieldId", 1).findAll(); <END> assertEquals(1, queryResults.size()); child = queryResults.first(); parents = child.getObjectParents(); assertNotNull(parents); assertEquals(1, parents.size()); assertEquals(parent, parents.first()); }</code><technical_language>I unclear is a good idea change semantics of tests. change semantics of backlinks??</technical_language>

Target:
public void copyToAndFromRealm() { AllJavaTypes unmanagedChild = new AllJavaTypes(1); assertNull(unmanagedChild.getObjectParents()); realm.beginTransaction(); AllJavaTypes parent = realm.createObject(AllJavaTypes.class, 2); AllJavaTypes child = realm.copyToRealm(unmanagedChild); parent.setFieldObject(child); realm.commitTransaction(); RealmResults<AllJavaTypes> parents = child.getObjectParents(); assertNotNull(parents); assertEquals(1, parents.size()); assertEquals(parent, parents.first()); unmanagedChild = realm.copyFromRealm(child); assertEquals(unmanagedChild.getFieldId(), 1); assertEquals(new AllJavaTypes().getObjectParents(), unmanagedChild.getObjectParents()); RealmResults<AllJavaTypes> queryResults = realm.where(AllJavaTypes.class).equalTo("fieldId", 1).findAll(); assertEquals(1, queryResults.size()); child = queryResults.first(); parents = child.getObjectParents(); assertNotNull(parents); assertEquals(1, parents.size()); assertEquals(parent, parents.first()); }
Source:
<code>private Semaphore getSemaphore(int maxSize) { <START> if (maxSize < 0) { <END> return new LimitlessSemaphore(); } return new Semaphore(maxSize, true); }</code><technical_language>this maxSize <= 0</technical_language>

Target:
private Semaphore getSemaphore(int maxSize) { if (maxSize <= LIMITLESS) { return new LimitlessSemaphore(); } return new Semaphore(maxSize, true); }
Source:
<code>private boolean hasInvalidAnswers(boolean markCompleted, boolean fireTriggerables) { FormIndex i = FormEntryActivity.mFormController.getFormIndex(); FormEntryActivity.mFormController.jumpToIndex(FormIndex.createBeginningOfFormIndex()); int event; if (!fireTriggerables) { Logger.log(AndroidLogger.TYPE_FORM_ENTRY, "Saving form without firing triggers."); } while ((event = FormEntryActivity.mFormController.stepToNextEvent(FormController.STEP_INTO_GROUP)) != FormEntryController.EVENT_END_OF_FORM) { if (event == FormEntryController.EVENT_QUESTION) { int saveStatus; if (fireTriggerables) { saveStatus = FormEntryActivity.mFormController .answerQuestion(FormEntryActivity.mFormController.getQuestionPrompt() .getAnswerValue()); } else { saveStatus = FormEntryActivity.mFormController.checkCurrentQuestionConstraint(); } if (markCompleted && <START> saveStatus != FormEntryController.ANSWER_OK && END> (saveStatus == FormEntryController.ANSWER_REQUIRED_BUT_EMPTY || saveStatus == FormEntryController.ANSWER_CONSTRAINT_VIOLATED)) { return true; } } } FormEntryActivity.mFormController.jumpToIndex(i); return false; }</code><technical_language>noted this, leave this line in</technical_language>

Target:
private boolean hasInvalidAnswers(boolean markCompleted, boolean fireTriggerables) { FormIndex i = FormEntryActivity.mFormController.getFormIndex(); FormEntryActivity.mFormController.jumpToIndex(FormIndex.createBeginningOfFormIndex()); int event; if (!fireTriggerables) { Logger.log(AndroidLogger.TYPE_FORM_ENTRY, "Saving form without firing triggers."); } while ((event = FormEntryActivity.mFormController.stepToNextEvent(FormController.STEP_INTO_GROUP)) != FormEntryController.EVENT_END_OF_FORM) { if (event == FormEntryController.EVENT_QUESTION) { int saveStatus; if (fireTriggerables) { saveStatus = FormEntryActivity.mFormController .answerQuestion(FormEntryActivity.mFormController.getQuestionPrompt() .getAnswerValue()); } else { saveStatus = FormEntryActivity.mFormController.checkCurrentQuestionConstraint(); } if (markCompleted && (saveStatus == FormEntryController.ANSWER_REQUIRED_BUT_EMPTY || saveStatus == FormEntryController.ANSWER_CONSTRAINT_VIOLATED)) { return true; } } } FormEntryActivity.mFormController.jumpToIndex(i); return false; }
Source:
<code>public Slice next() throws IOException { do { if (inputStream == null) { inputStream = getInputStream(currentPointer); } <START> if (inputStream != null && !fileContext.util().exists(currentOpenPath)) { <END> close(); inputStream = getInputStream(currentPointer); } if (inputStream != null && currentPointer.offset < fileContext.getFileStatus(currentOpenPath).getLen()) { int len = inputStream.readInt(); Preconditions.checkState(len >= 0, "negative length"); byte[] data = new byte[len]; inputStream.readFully(data); currentPointer.offset += data.length + 4; return new Slice(data); } } while (nextSegment()); return null; }</code><technical_language>This is expensive. invalidate reader file rename occurs</technical_language>

Target:
public Slice next() throws IOException { do { if (inputStream == null) { inputStream = getInputStream(currentPointer); } if (inputStream != null && isOpenPathTmp && !fileSystemWAL.tempPartFiles.containsKey(currentPointer.partNum)) { close(); inputStream = getInputStream(currentPointer); } if (inputStream != null && currentPointer.offset < fileContext.getFileStatus(currentOpenPath).getLen()) { int len = inputStream.readInt(); Preconditions.checkState(len >= 0, "negative length"); byte[] data = new byte[len]; inputStream.readFully(data); currentPointer.offset += data.length + 4; return new Slice(data); } } while (nextSegment()); close(); return null; }
Source:
<code>public Contact getContact(ObjectNode node, String location, ParseResult result) { if (node == null) return null; Contact contact = new Contact(); String value = getString("name", node, false, location + ".name", result); <START> contact.setName(value); <END> value = getString("url", node, false, location + ".url", result); contact.setUrl(value); value = getString("email", node, false, location + ".email", result); contact.setEmail(value); contact.setExtensions(new LinkedHashMap<>()); Set<String> keys = getKeys(node); for(String key : keys) { if(key.startsWith("x-")) { contact.getExtensions().put(key, Json.mapper().convertValue(node.get(key), Object.class)); } else if (!CONTACT_KEYS.contains(key)) { result.extra(location + ".contact", key, node.get(key)); } } return contact; }</code><technical_language>do a StringUtils.isNotBlank(...) check setting</technical_language>

Target:
public Contact getContact(ObjectNode node, String location, ParseResult result) { if (node == null) return null; Contact contact = new Contact(); String value = getString("name", node, false, location + ".name", result); if(StringUtils.isNotBlank(value)) { contact.setName(value); } value = getString("url", node, false, location + ".url", result); if(StringUtils.isNotBlank(value)) { contact.setUrl(value); } value = getString("email", node, false, location + ".email", result); if(StringUtils.isNotBlank(value)) { contact.setEmail(value); } Map <String,Object> extensions = getExtensions(node,location,result); if(extensions != null && extensions.size() > 0) { contact.setExtensions(extensions); } return contact; }
Source:
<code>public void init() { service = new TransformationEngineService(); EKBModelGraph graph = EKBModelGraph.getInstance(); <START> ModelRegistryService registry = ModelRegistryService.getInstance(null); <END> registry.setEkbClassLoader(new EKBTestClassLoader()); registry.setGraphDb(graph); service.setModelRegistry(registry); service.setGraphDb(graph); graph.addModel(getModelADescription()); graph.addModel(getModelBDescription()); graph.addModel(getModelCDescription()); }</code><technical_language>for thos changes</technical_language>

Target:
public void init() { service = new TransformationEngineService(); EKBModelGraph graph = EKBModelGraph.getInstance(); ModelRegistryService registry = ModelRegistryService.getInstance(context); registry.setEkbClassLoader(new EKBTestClassLoader()); registry.setGraphDb(graph); service.setModelRegistry(registry); service.setGraphDb(graph); graph.addModel(getModelADescription()); graph.addModel(getModelBDescription()); graph.addModel(getModelCDescription()); }
Source:
<code>public MapExpressionMethods() { <START> context = new StandardEvaluationContext(); <END> context.addMethodResolver(new PartitionKeyMethodResolver()); context.addPropertyAccessor(new MapPartitionKeyPropertyAccessor()); }</code><technical_language>I need get reference evaluation context other functions/methods registered - in XD context #jsonPath is registered in SI default now. I wanting base a directory name based returned jsonPath. needs overloaded ctor in XD context, contribute 'standard/shared' evaluation context</technical_language>

Target:
public MapExpressionMethods() { this(null); }
Source:
<code>protected void executeVmCommand() { super.executeVmCommand(); if (getReturnValue().getSucceeded() && getParameters().isEdited()) { editedVM.setId(getVmId()); <START> editedVM.setStoragePoolId(getParameters().getStorageDomainId()); <END> editedVM.setVmCreationDate(getVm().getVmCreationDate()); editedVM.setCreatedByUserId(getVm().getCreatedByUserId()); getParameters().setVm(editedVM); getParameters().setVmId(editedVM.getId()); ActionReturnValue returnValue = runInternalAction( ActionType.UpdateVm, getParameters()); returnValue.setActionReturnValue(getReturnValue().getActionReturnValue()); setReturnValue(returnValue); } }</code><technical_language>Storage pool storage domain entities. Storage pool is Datacenter. storage pool id in VM is needed for UpdateVmCommand. command initializes storage pool id cluster in init() method</technical_language>

Target:
protected void executeVmCommand() { super.executeVmCommand(); if (getReturnValue().getSucceeded() && getParameters().isEdited()) { editedVM.setId(getVmId()); editedVM.setVmCreationDate(getVm().getVmCreationDate()); editedVM.setCreatedByUserId(getVm().getCreatedByUserId()); getParameters().setVm(editedVM); getParameters().setVmId(editedVM.getId()); ActionReturnValue returnValue = runInternalAction( ActionType.UpdateVm, getParameters()); returnValue.setActionReturnValue(getReturnValue().getActionReturnValue()); setReturnValue(returnValue); } }
Source:
<code>public void serialize(CassandraStreamHeader header, DataOutputPlus out, int version) throws IOException { out.writeUTF(header.version.toString()); out.writeUTF(header.format.name); out.writeLong(header.estimatedKeys); out.writeInt(header.sections.size()); for (SSTableReader.PartitionPositionBounds section : header.sections) { out.writeLong(section.lowerPosition); out.writeLong(section.upperPosition); } header.calculateCompressionInfo(); CompressionInfo.serializer.serialize(header.compressionInfo, out, version); out.writeInt(header.sstableLevel); SerializationHeader.serializer.serialize(header.version, header.header, out); header.tableId.serialize(out); out.writeBoolean(header.fullStream); if (header.fullStream) { out.writeInt(header.components.size()); for (ComponentInfo info : header.components) ComponentInfo.serializer.serialize(info, out, version); <START> ByteBufferUtil.writeWithShortLength(header.firstKey.getKey(), out); <END> } }</code><technical_language>fine I forgot keys hashes fixed size small</technical_language>

Target:
public void serialize(CassandraStreamHeader header, DataOutputPlus out, int version) throws IOException { out.writeUTF(header.version.toString()); out.writeUTF(header.format.name); out.writeLong(header.estimatedKeys); out.writeInt(header.sections.size()); for (SSTableReader.PartitionPositionBounds section : header.sections) { out.writeLong(section.lowerPosition); out.writeLong(section.upperPosition); } header.calculateCompressionInfo(); CompressionInfo.serializer.serialize(header.compressionInfo, out, version); out.writeInt(header.sstableLevel); SerializationHeader.serializer.serialize(header.version, header.serializationHeader, out); header.tableId.serialize(out); out.writeBoolean(header.isEntireSSTable); if (header.isEntireSSTable) { ComponentManifest.serializer.serialize(header.componentManifest, out, version); ByteBufferUtil.writeWithVIntLength(header.firstKey.getKey(), out); } }
Source:
<code>public void testGetRequiredResources() { DefaultResourceTracker tracker = new DefaultResourceTracker(); <START> JobID jobId1 = JobID.generate(); JobID jobId2 = JobID.generate(); <END> ResourceRequirement requirement1 = ResourceRequirement.create(ResourceProfile.ANY, 1); ResourceRequirement requirement2 = ResourceRequirement.create(ResourceProfile.ANY, 2); tracker.notifyResourceRequirements(jobId1, Collections.singletonList(requirement1)); tracker.notifyResourceRequirements(jobId2, Collections.singletonList(requirement2)); Map<JobID, Collection<ResourceRequirement>> requiredResources = tracker.getRequiredResources(); assertThat(requiredResources, IsMapContaining.hasEntry(is(jobId1), contains(requirement1))); assertThat(requiredResources, IsMapContaining.hasEntry(is(jobId2), contains(requirement2))); }</code><technical_language>sense this a fields of DefaultResourceTrackerTest? create values multiple times</technical_language>

Target:
public void testGetRequiredResources() { DefaultResourceTracker tracker = new DefaultResourceTracker(); ResourceRequirement requirement1 = ResourceRequirement.create(ResourceProfile.ANY, 1); ResourceRequirement requirement2 = ResourceRequirement.create(ResourceProfile.ANY, 2); tracker.notifyResourceRequirements(JOB_ID_1, Collections.singletonList(requirement1)); tracker.notifyResourceRequirements(JOB_ID_2, Collections.singletonList(requirement2)); Map<JobID, Collection<ResourceRequirement>> requiredResources = tracker.getMissingResources(); assertThat(requiredResources, IsMapContaining.hasEntry(is(JOB_ID_1), contains(requirement1))); assertThat(requiredResources, IsMapContaining.hasEntry(is(JOB_ID_2), contains(requirement2))); }
Source:
<code>private static Glide initGlide(Context context) { Context applicationContext = context.getApplicationContext(); <START> List<GlideModule> manifestModules = new ManifestParser(applicationContext).parse(); <END> if (Log.isLoggable(TAG, Log.DEBUG)) { for (GlideModule glideModule : manifestModules) { Log.d(TAG, "Discovered GlideModule from manifest: " + glideModule.getClass()); } } RootGlideModule annotationGeneratedModule = getAnnotationGeneratedGlideModules(); if (annotationGeneratedModule != null) { if (Log.isLoggable(TAG, Log.DEBUG)) { for (Class<? extends GlideModule> glideModuleClazz : annotationGeneratedModule.getAnnotatedGlideModuleClasses()) { Log.d(TAG, "Discovered GlideModule from annotation: " + glideModuleClazz); } } validateGlideModulesRegisteredOnce(annotationGeneratedModule, manifestModules); manifestModules.add(annotationGeneratedModule); } GlideBuilder builder = new GlideBuilder(applicationContext); for (GlideModule module : manifestModules) { module.applyOptions(applicationContext, builder); } Glide glide = builder.createGlide(); for (GlideModule module : manifestModules) { module.registerComponents(applicationContext, glide.registry); } return glide; }</code><technical_language>a reminder ensure is a totally disable manifest parsing in keeping #1754 Thanks</technical_language>

Target:
private static Glide initGlide(Context context) { Context applicationContext = context.getApplicationContext(); GeneratedRootGlideModule annotationGeneratedModule = getAnnotationGeneratedGlideModules(); List<GlideModule> manifestModules = Collections.emptyList(); if (annotationGeneratedModule == null || annotationGeneratedModule.isManifestParsingEnabled()) { manifestModules = new ManifestParser(applicationContext).parse(); } if (annotationGeneratedModule != null && !annotationGeneratedModule.getExcludedModuleClasses().isEmpty()) { Set<Class<?>> excludedModuleClasses = annotationGeneratedModule.getExcludedModuleClasses(); for (Iterator<GlideModule> iterator = manifestModules.iterator(); iterator.hasNext();) { GlideModule current = iterator.next(); if (!excludedModuleClasses.contains(current.getClass())) { continue; } if (Log.isLoggable(TAG, Log.DEBUG)) { Log.d(TAG, "RootGlideModule excludes manifest GlideModule: " + current); } iterator.remove(); } } if (Log.isLoggable(TAG, Log.DEBUG)) { for (GlideModule glideModule : manifestModules) { Log.d(TAG, "Discovered GlideModule from manifest: " + glideModule.getClass()); } } GlideBuilder builder = new GlideBuilder(); for (GlideModule module : manifestModules) { module.applyOptions(applicationContext, builder); } if (annotationGeneratedModule != null) { annotationGeneratedModule.applyOptions(applicationContext, builder); } Glide glide = builder.createGlide(applicationContext); for (GlideModule module : manifestModules) { module.registerComponents(applicationContext, glide.registry); } if (annotationGeneratedModule != null) { annotationGeneratedModule.registerComponents(applicationContext, glide.registry); } return glide; }
Source:
<code>public String getActingUserName() { try { <START> return Objects.requireNonNull(Crn.fromString(new String(Base64.getDecoder().decode(getActingUserAccessKey())))).getUserId(); <END> } catch (Exception e) { if (Crn.isCrn(getActingUser().getCrn())) { return Objects.requireNonNull(Crn.fromString(getActingUser().getCrn())).getUserId(); } if (!testParameter.get(CloudbreakTest.USER_NAME).isEmpty() || testParameter.get(CloudbreakTest.USER_NAME) != null) { return testParameter.get(CloudbreakTest.USER_NAME); } LOGGER.error("Cannot find acting user: '{}' - Name, because of: '{}'", getActingUserAccessKey(), e.getMessage(), e); throw new TestFailException(String.format("Cannot find acting user: '%s' - Name, because of: '%s'", getActingUserAccessKey(), e.getMessage()), e); } }</code><technical_language>applies before</technical_language>

Target:
public String getActingUserName() { return getMockUserName() .or(this::getRealUMSUserName) .or(this::getUserParameterName) .orElseThrow(() -> new TestFailException(String.format("Cannot find acting user: '%s' - Name", getActingUserAccessKey()))); }
Source:
<code>public void setupMainPanel() { preferences = BasePanelPreferences.from(Globals.prefs); splitPane = new SplitPane(); splitPane.setOrientation(Orientation.VERTICAL); adjustSplitter(); createMainTable(); ScrollPane pane = mainTable.getPane(); pane.setFitToHeight(true); pane.setFitToWidth(true); splitPane.getItems().add(pane); <START> executorService.execute(() -> { <END> instantiateSearchAutoCompleter(); this.getDatabase().registerListener(new SearchAutoCompleteListener()); setupAutoCompletion(); }); dividerPositionSubscription = EasyBind.monadic(Bindings.valueAt(splitPane.getDividers(), 0)) .flatMap(SplitPane.Divider::positionProperty) .subscribe((observable, oldValue, newValue) -> saveDividerLocation(newValue)); Optional<Path> file = bibDatabaseContext.getDatabasePath(); if (file.isPresent()) { resetChangeMonitorAndChangePane(); } else { if (bibDatabaseContext.getDatabase().hasEntries()) { this.baseChanged = true; } changePane = null; getChildren().add(splitPane); } }</code><technical_language>I leave registerListener call current thread (just listeners interact multithreading in detail - this is expensive operation)</technical_language>

Target:
public void setupMainPanel() { preferences = BasePanelPreferences.from(Globals.prefs); splitPane = new SplitPane(); splitPane.setOrientation(Orientation.VERTICAL); adjustSplitter(); createMainTable(); ScrollPane pane = mainTable.getPane(); pane.setFitToHeight(true); pane.setFitToWidth(true); splitPane.getItems().add(pane); executorService.execute(() -> { instantiateSearchAutoCompleter(); setupAutoCompletion(); }); this.getDatabase().registerListener(new SearchAutoCompleteListener()); dividerPositionSubscription = EasyBind.monadic(Bindings.valueAt(splitPane.getDividers(), 0)) .flatMap(SplitPane.Divider::positionProperty) .subscribe((observable, oldValue, newValue) -> saveDividerLocation(newValue)); Optional<Path> file = bibDatabaseContext.getDatabasePath(); if (file.isPresent()) { resetChangeMonitorAndChangePane(); } else { if (bibDatabaseContext.getDatabase().hasEntries()) { this.baseChanged = true; } changePane = null; getChildren().add(splitPane); } }
Source:
<code>public ConventionTableDefinitionDescriptor(Path ddlFile) { checkArgument(exists(ddlFile) && isRegularFile(ddlFile), "Invalid file: %s", ddlFile); this.name = getFilenameWithoutExtension(ddlFile); this.ddlFile = ddlFile; Path dataFile = changeExtension(ddlFile, "data"); Path dataGeneratorFile = changeExtension(ddlFile, "data-generator"); if (exists(dataGeneratorFile)) { checkArgument(!exists(dataFile), "Expected no data file when data-generator file is present"); <START> makeExecutable(dataGeneratorFile); <END> ProcessUtils.execute(process -> copy(dataFile, process), dataGeneratorFile.toString()); } if (exists(dataFile) && isRegularFile(dataFile)) { Path revisionFile = changeExtension(ddlFile, "data-revision"); checkArgument(exists(revisionFile) && isRegularFile(revisionFile), "No revision file found: %s", revisionFile); this.dataFile = Optional.of(dataFile); this.revisionFile = Optional.of(revisionFile); } else { this.dataFile = Optional.empty(); this.revisionFile = Optional.empty(); } }</code><technical_language>ouch. This read-only</technical_language>

Target:
public ConventionTableDefinitionDescriptor(Path ddlFile) { checkArgument(exists(ddlFile) && isRegularFile(ddlFile), "Invalid file: %s", ddlFile); this.name = getFilenameWithoutExtension(ddlFile); this.ddlFile = ddlFile; Path dataFile = changeExtension(ddlFile, "data"); Path dataGeneratorFile = changeExtension(ddlFile, "data-generator"); if (exists(dataGeneratorFile)) { checkArgument(!exists(dataFile), "Expected no data file when data-generator file is present"); makeExecutable(dataGeneratorFile); ProcessUtils.execute(process -> feed(dataFile, process), dataGeneratorFile.toString()); } if (exists(dataFile) && isRegularFile(dataFile)) { Path revisionFile = changeExtension(ddlFile, "data-revision"); checkArgument(exists(revisionFile) && isRegularFile(revisionFile), "No revision file found: %s", revisionFile); this.dataFile = Optional.of(dataFile); this.revisionFile = Optional.of(revisionFile); } else { this.dataFile = Optional.empty(); this.revisionFile = Optional.empty(); } }
Source:
<code><START> private void deleteRoutingDataPath() throws Exception { <END> TestHelper.verify(() -> { _zkList.forEach(zk -> ZK_SERVER_MAP.get(zk).getZkClient() .deleteRecursively(MetadataStoreRoutingConstants.ROUTING_DATA_PATH)); for (String zk : _zkList) { if (ZK_SERVER_MAP.get(zk).getZkClient() .exists(MetadataStoreRoutingConstants.ROUTING_DATA_PATH)) { return false; } } return true; }, TestHelper.WAIT_DURATION); }</code><technical_language>do Assert.assertTrue return of verify()</technical_language>

Target:
private void deleteRoutingDataPath() throws Exception { Assert.assertTrue(TestHelper.verify(() -> { _zkList.forEach(zk -> ZK_SERVER_MAP.get(zk).getZkClient() .deleteRecursively(MetadataStoreRoutingConstants.ROUTING_DATA_PATH)); for (String zk : _zkList) { if (ZK_SERVER_MAP.get(zk).getZkClient() .exists(MetadataStoreRoutingConstants.ROUTING_DATA_PATH)) { return false; } } return true; }, TestHelper.WAIT_DURATION), "Routing data path should be deleted after the tests."); }
Source:
<code>private void initVisibilities() { errorMsg.setVisible(false); <START> actionConfirmationMessage.setVisible(false); <END> geoRepForceHelpIcon.setVisible(false); }</code><technical_language>this needs hidden</technical_language>

Target:
private void initVisibilities() { errorMsg.setVisible(false); geoRepForceHelpIcon.setVisible(false); }
Source:
<code>private void setupActivityFromState(final Bundle state) { if (state != null) { <START> if (!shouldShowDualPane) { <END> toggleNavigationDrawer(state.getBoolean(STATE_DRAWER_OPENED, false)); } } }</code><technical_language>Single if</technical_language>

Target:
private void setupActivityFromState(final Bundle state) { if (state != null && !shouldShowDualPane) { toggleNavigationDrawer(state.getBoolean(STATE_DRAWER_OPENED, false)); } }
Source:
<code>public boolean accept( Method<?, ?> method ) { <START> return !method.isConstructor() && method.getAnnotation( Generated.class ) != null; <END> }</code><technical_language>@mcimbora , I worth provide a more fine grained filtering here. method is a constructor, @Generated annotation, "is of generated" planner stuff. inspecting some additional planner generated annotation for method (I I remember wrong for this planner generated method added a planner annotation parameters?) eventually exploring return type, some other trick. This prevent loading other methods @Generated annotation manage. Specially java source is updated, accepted methods deleted</technical_language>

Target:
public boolean accept( Method<?, ?> method ) { return !method.isConstructor() && method.getAnnotation( Generated.class ) != null && ( isGetScoreMethod( method ) || isSetScoreMethod( method ) || isCompareMethod( method ) ); }
Source:
<code>private EntityView(Context context, Detail d, String[] columnTitles, boolean hasCalloutResponseData) { super(context); DetailField calloutResponseDetailField = null; <START> if (hasCalloutResponseData && d.getCallout() != null) { <END> calloutResponseDetailField = d.getCallout().getResponseDetail(); String[] headerTextWithCalloutResponse = new String[columnTitles.length + 1]; System.arraycopy(columnTitles, 0, headerTextWithCalloutResponse, 0, columnTitles.length); columnTitles = headerTextWithCalloutResponse; columnTitles[columnTitles.length - 1] = calloutResponseDetailField.getHeader().evaluate(); } int columnCount = columnTitles.length; this.views = new ArrayList<>(columnCount); this.mHints = new ArrayList<>(columnCount); String[] headerForms = new String[columnCount]; int i = 0; for (DetailField field : d.getFields()) { mHints.add(field.getHeaderWidthHint()); headerForms[i] = field.getHeaderForm(); i++; } if (calloutResponseDetailField != null) { mHints.add(calloutResponseDetailField.getHeaderWidthHint()); headerForms[columnCount-1] = calloutResponseDetailField.getHeaderForm(); } int[] colors = AndroidUtil.getThemeColorIDs(getContext(), new int[]{R.attr.entity_view_header_background_color, R.attr.entity_view_header_text_color}); if (colors[0] != -1) { this.setBackgroundColor(colors[0]); } for (int col = 0; col < columnCount; ++col) { views.add(addCell(col, columnTitles[col], headerForms[col], mHints.get(col), null, colors[1], false)); } }</code><technical_language>contents of this if statement broken out a helper method</technical_language>

Target:
private EntityView(Context context, Detail d, String[] columnTitles, boolean hasCalloutResponseData) { super(context); DetailField calloutResponseDetailField = null; if (hasCalloutResponseData && d.getCallout() != null) { calloutResponseDetailField = d.getCallout().getResponseDetailField(); columnTitles = addColumnTitleForCalloutData(columnTitles, calloutResponseDetailField); } int columnCount = columnTitles.length; this.views = new ArrayList<>(columnCount); this.mHints = new ArrayList<>(columnCount); String[] headerForms = new String[columnCount]; int i = 0; for (DetailField field : d.getFields()) { mHints.add(field.getHeaderWidthHint()); headerForms[i] = field.getHeaderForm(); i++; } if (calloutResponseDetailField != null) { mHints.add(calloutResponseDetailField.getHeaderWidthHint()); headerForms[columnCount-1] = calloutResponseDetailField.getHeaderForm(); } int[] colors = AndroidUtil.getThemeColorIDs(getContext(), new int[]{R.attr.entity_view_header_background_color, R.attr.entity_view_header_text_color}); if (colors[0] != -1) { this.setBackgroundColor(colors[0]); } for (int col = 0; col < columnCount; ++col) { views.add(addCell(col, columnTitles[col], headerForms[col], mHints.get(col), null, colors[1], false)); } }
Source:
<code>public final void execute(BlockingRunnable runnable) { if (shutdown) { throw new RejectedExecutionException("Executor Service is already shutdown"); } <START> blockedTasks.offer(runnable); <END> controllerThread.checkForReadyTask(); if (log.isTraceEnabled()) { log.tracef("Added a new task: %s task(s) are waiting", blockedTasks.size()); } }</code><technical_language>this longer "overflow" OOB thread pool</technical_language>

Target:
public final void execute(BlockingRunnable runnable) { if (shutdown) { throw new RejectedExecutionException("Executor Service is already shutdown"); } if (runnable.isReady()) { doExecute(runnable); if (log.isTraceEnabled()) { log.tracef("Added a new task directly: %s task(s) are waiting", blockedTasks.size()); } } else { blockedTasks.offer(runnable); controllerThread.checkForReadyTask(); if (log.isTraceEnabled()) { log.tracef("Added a new task to the queue: %s task(s) are waiting", blockedTasks.size()); } } }
Source:
<code>public boolean isAmphibious() { return hasWorkingMisc(MiscType.F_FULLY_AMPHIBIOUS) || hasWorkingMisc(MiscType.F_AMPHIBIOUS) || <START> hasWorkingMisc(MiscType.F_FULLY_AMPHIBIOUS); <END> }</code><technical_language>of F_LIMITED_AMPHIBIOUS</technical_language>

Target:
public boolean isAmphibious() { return hasWorkingMisc(MiscType.F_FULLY_AMPHIBIOUS) || hasWorkingMisc(MiscType.F_AMPHIBIOUS) || hasWorkingMisc(MiscType.F_LIMITED_AMPHIBIOUS); }
Source:
<code>private static HttpLoggingInterceptor getLoggingInterceptor() { final HttpLoggingInterceptor httpLoggingInterceptor = new HttpLoggingInterceptor() <START> .setLevel(Level.BODY); <END> httpLoggingInterceptor.redactHeader("Authorization"); httpLoggingInterceptor.redactHeader("Cookie"); return httpLoggingInterceptor; }</code><technical_language>Do want this in master</technical_language>

Target:
private static HttpLoggingInterceptor getLoggingInterceptor() { final HttpLoggingInterceptor httpLoggingInterceptor = new HttpLoggingInterceptor() .setLevel(Level.BASIC); httpLoggingInterceptor.redactHeader("Authorization"); httpLoggingInterceptor.redactHeader("Cookie"); return httpLoggingInterceptor; }
Source:
<code>private JGitFileSystemLock createFSLock(Git git) { return new JGitFileSystemLock(git, <START> 30000l); <END> }</code><technical_language>this numeric literal end 1 l? recommended L end of long numeric literals avoid this kind of ambiguity. java 7 [underscores in numeric literals](<LINK_0> for readability. -> 30_000L</technical_language>

Target:
private JGitFileSystemLock createFSLock(Git git) { return new JGitFileSystemLock(git, TimeUnit.MILLISECONDS, 30_000L); }
Source:
<code>private List<Tag> getRevTags() { Collection<Ref> revTags = repo.getTags().values(); List<Tag> tags = new ArrayList<Tag>(); for (Ref ref : revTags) { try { Tag tag = repo.mapTag(ref.getName()); tags.add(tag); } catch (IOException e) { <START> MessageDialog.openError(getShell(), <END> UIText.TagAction_errorDuringTagging, NLS.bind( UIText.TagAction_errorWhileMappingRevTag, ref .getName())); } } return tags; }</code><technical_language>underlying error is displayed logged</technical_language>

Target:
private List<Tag> getRevTags() { Collection<Ref> revTags = repo.getTags().values(); List<Tag> tags = new ArrayList<Tag>(); for (Ref ref : revTags) { try { Tag tag = repo.mapTag(ref.getName()); tags.add(tag); } catch (IOException e) { ErrorDialog.openError(getShell(), UIText.TagAction_errorDuringTagging, NLS.bind( UIText.TagAction_errorWhileMappingRevTag, ref .getName()), new Status(IStatus.ERROR, Activator.getPluginId(), e.getMessage(), e)); } } return tags; }
Source:
<code>private void closeTailAndOffer(PBDSegment newSegment) throws IOException { PBDSegment last = peekLastSegment(); if (last != null) { if (!last.isBeingPolled()) { last.close(); <START> } <END> else { last.sync(); } last.setFinal(true); if (m_usageSpecificLog.isDebugEnabled()) { m_usageSpecificLog.debug("Segment " + last.file() + " (final: " + last.isFinal() + "), has been closed by offer to PBD"); } } m_segments.put(newSegment.segmentId(), newSegment); }</code><technical_language>Minor code style issue too</technical_language>

Target:
private void closeTailAndOffer(PBDSegment newSegment) throws IOException { PBDSegment last = peekLastSegment(); if (last != null) { if (!last.isBeingPolled()) { last.close(); } else { last.sync(); } last.setFinal(true); if (m_usageSpecificLog.isDebugEnabled()) { m_usageSpecificLog.debug("Segment " + last.file() + " (final: " + last.isFinal() + "), has been closed by offer to PBD"); } } m_segments.put(newSegment.segmentIndex(), newSegment); }
Source:
<code>public void testGetIdentificationString() { AdminEmailAttributes adminEmail = createValidAdminEmailAttributesObject(); <START> assertEquals(this.sendDate + "/" + this.subject, adminEmail.getIdentificationString()); <END> }</code><technical_language>is need for this.</technical_language>

Target:
public void testGetIdentificationString() { assertEquals(date + "/" + subject, adminEmailAttributes.getIdentificationString()); }
Source:
<code>public EmailBuilder enableEmailLinkSignIn() { <START> super.mProviderId = EMAIL_LINK_PROVIDER; <END> return this; }</code><technical_language>super.mFoo is code smell. Add a protected setter for providerId super class instead</technical_language>

Target:
public EmailBuilder enableEmailLinkSignIn() { setProviderId(EMAIL_LINK_PROVIDER); return this; }
Source:
<code><START> public void updateZkNode() { <END> synchronized(status) { if (status == TrackerStatus.BUSY) { updateZkNode(getOldestActiveTimestamp()); } else if (status == TrackerStatus.IDLE) { closeZkNode(); } } }</code><technical_language>if test is in package, visibility default</technical_language>

Target:
synchronized void updateZkNode() { if (status == TrackerStatus.BUSY) { updateZkNode(getOldestActiveTimestamp()); } else if (status == TrackerStatus.IDLE) { closeZkNode(); } }
Source:
<code>private Set<String> validateTools(Devfile devfile) throws DevfileFormatException { Set<String> existingNames = new HashSet<>(); Tool editorTool = null; for (Tool tool : devfile.getTools()) { if (!existingNames.add(tool.getName())) { throw new DevfileFormatException(format("Duplicate tool name found:'%s'", tool.getName())); } switch (tool.getType()) { <START> case "cheEditor": <END> if (editorTool != null) { throw new DevfileFormatException( format( "Multiple editor tools found: '%s', '%s'", editorTool.getName(), tool.getName())); } editorTool = tool; break; case "chePlugin": break; default: throw new DevfileFormatException( format("Unsupported tool '%s' type provided:'%s'", tool.getName(), tool.getType())); } } return existingNames; }</code><technical_language>Is a constant for cheEditor tool type</technical_language>

Target:
private Set<String> validateTools(Devfile devfile) throws DevfileFormatException { Set<String> existingNames = new HashSet<>(); Tool editorTool = null; for (Tool tool : devfile.getTools()) { if (!existingNames.add(tool.getName())) { throw new DevfileFormatException(format("Duplicate tool name found:'%s'", tool.getName())); } switch (tool.getType()) { case EDITOR_TOOL_TYPE: if (editorTool != null) { throw new DevfileFormatException( format( "Multiple editor tools found: '%s', '%s'", editorTool.getName(), tool.getName())); } editorTool = tool; break; case PLUGIN_TOOL_TYPE: break; default: throw new DevfileFormatException( format("Unsupported tool '%s' type provided:'%s'", tool.getName(), tool.getType())); } } return existingNames; }
Source:
<code>public FieldVisitor visitField(int flags, String name, String desc, @Nullable String signature, @Nullable Object value) { Preconditions.checkNotNull(name); Preconditions.checkNotNull(desc); if (isNotSynthetic(flags)) { int filteredFlags = Flags.filterAccessBytecodeFlags(flags); JavaType type = convertAsmType(Type.getType(desc)); <START> JavaSymbol.VariableJavaSymbol symbol = new JavaSymbol.VariableJavaSymbol(filteredFlags, name, type, classSymbol); <END> if (Flags.isFlagged(flags, Flags.STATIC) && Flags.isFlagged(flags, Flags.FINAL)) { symbol = new JavaSymbol.ConstantJavaSymbol(filteredFlags, name, type, classSymbol, value); } classSymbol.members.enter(symbol); if (signature != null) { ReadType typeReader = new ReadType(); new SignatureReader(signature).accept(typeReader); symbol.type = typeReader.typeRead; } return new BytecodeFieldVisitor(symbol, this); } return null; }</code><technical_language>dropped GC anyway, I avoid creating a variable if is of use</technical_language>

Target:
public FieldVisitor visitField(int flags, String name, String desc, @Nullable String signature, @Nullable Object value) { Preconditions.checkNotNull(name); Preconditions.checkNotNull(desc); if (isNotSynthetic(flags)) { int filteredFlags = Flags.filterAccessBytecodeFlags(flags); JavaType type = convertAsmType(Type.getType(desc)); JavaSymbol.VariableJavaSymbol symbol = new JavaSymbol.VariableJavaSymbol(filteredFlags, name, type, classSymbol, value); classSymbol.members.enter(symbol); if (signature != null) { ReadType typeReader = new ReadType(); new SignatureReader(signature).accept(typeReader); symbol.type = typeReader.typeRead; } return new BytecodeFieldVisitor(symbol, this); } return null; }
Source:
<code>OnheapIncrementalIndex( IncrementalIndexSchema incrementalIndexSchema, boolean deserializeComplexMetrics, boolean reportParseExceptions, boolean concurrentEventAdd, boolean sortFacts, int maxRowCount, long maxBytesInMemory ) { super(incrementalIndexSchema, deserializeComplexMetrics, reportParseExceptions, concurrentEventAdd); this.maxRowCount = maxRowCount; <START> this.maxBytesInMemory = maxBytesInMemory == 0 ? Runtime.getRuntime().maxMemory() / 6 : maxBytesInMemory; <END> this.facts = incrementalIndexSchema.isRollup() ? new RollupFactsHolder(sortFacts, dimsComparator(), getDimensions()) : new PlainFactsHolder(sortFacts); maxBytesPerRowForAggregators = getMaxBytesPerRowForAggregators(incrementalIndexSchema); }</code><technical_language>IMO, correct for this -1. expect maxBytesInMemory passed in IncrementalIndex set internally. A good sign of is access TuningConfig here</technical_language>

Target:
OnheapIncrementalIndex( IncrementalIndexSchema incrementalIndexSchema, boolean deserializeComplexMetrics, boolean reportParseExceptions, boolean concurrentEventAdd, boolean sortFacts, int maxRowCount, long maxBytesInMemory ) { super(incrementalIndexSchema, deserializeComplexMetrics, reportParseExceptions, concurrentEventAdd); this.maxRowCount = maxRowCount; this.maxBytesInMemory = maxBytesInMemory == 0 ? Long.MAX_VALUE : maxBytesInMemory; this.facts = incrementalIndexSchema.isRollup() ? new RollupFactsHolder(sortFacts, dimsComparator(), getDimensions()) : new PlainFactsHolder(sortFacts); maxBytesPerRowForAggregators = getMaxBytesPerRowForAggregators(incrementalIndexSchema); }
Source:
<code>private void initialize() { Set<Class<?>> annotatedClasses = ClassScanner.getAnnotatedClasses(Arrays.asList(Include.class, SecurityCheck.class)); annotatedClasses.forEach(cls -> { if (cls.getAnnotation(Include.class) != null) { <START> dictionary.bindEntity(getType(cls)); <END> staticModelDetails.add(dictionary, cls); } else { dictionary.addSecurityCheck(cls); } }); }</code><technical_language>necessary call getType here</technical_language>

Target:
private void initialize() { Set<Class<?>> annotatedClasses = ClassScanner.getAnnotatedClasses(Arrays.asList(Include.class, SecurityCheck.class)); annotatedClasses.forEach(cls -> { if (cls.getAnnotation(Include.class) != null) { dictionary.bindEntity(cls); staticModelDetails.add(dictionary, getClassType(cls)); } else { dictionary.addSecurityCheck(cls); } }); }
Source:
<code>public Integer getNfsVersion(long storeId) throws NumberFormatException { Integer nfsVersion; if (imageStoreDetailsDao.getDetails(storeId) != null){ <START> Map<String, String> storeDetails = imageStoreDetailsDao.getDetails(storeId); <END> if (storeDetails.containsKey(CapacityManager.ImageStoreNFSVersion.key())){ String val = storeDetails.get(CapacityManager.ImageStoreNFSVersion.key()); nfsVersion = (val != null ? Integer.valueOf(val) : null); } else { nfsVersion = getGlobalDefaultNfsVersion(); } } else { nfsVersion = getGlobalDefaultNfsVersion(); } return nfsVersion; }</code><technical_language>I recognize this code predates this patch, is a double API call. Consider refactoring: public Integer getNfsVersion(long storeId) throws NumberFormatException { final Map<String, String> storeDetails = imageStoreDetailsDao.getDetails(storeId); if (storeDetails != null && storeDetails.containsKey(CapacityManager.ImageStoreNFSVersion.key())) { final String version = storeDetails.get(CapacityManager.ImageStoreNFSVersion.key()); return (val != null ? Integer.valueOf(val) : null); } return getGlobalDefaultNfsVersion(); }</technical_language>

Target:
public Integer getNfsVersion(long storeId) throws NumberFormatException { final Map<String, String> storeDetails = imageStoreDetailsDao.getDetails(storeId); if (storeDetails != null && storeDetails.containsKey(CapacityManager.ImageStoreNFSVersion.key())) { final String version = storeDetails.get(CapacityManager.ImageStoreNFSVersion.key()); return (version != null ? Integer.valueOf(version) : null); } return getGlobalDefaultNfsVersion(); }
Source:
<code>private DocumentModel createDocumentModelFromTypeName(String typeName, Map<String, Serializable> options) { SchemaManager schemaManager = Framework.getService(SchemaManager.class); DocumentType docType = schemaManager.getDocumentType(typeName); if (docType == null) { throw new IllegalArgumentException(typeName + " is not a registered core type"); } DocumentModel docModel = DocumentModelFactory.createDocumentModel(getSessionId(), docType); if (options == null) { options = new HashMap<>(); <START> } else if (options.containsKey(CoreEventConstants.DESTINATION_NAME)) { docModel.setPathInfo((String) options.get(CoreEventConstants.PARENT_PATH), (String) options.get(CoreEventConstants.DESTINATION_NAME)); <END> } notifyEvent(DocumentEventTypes.EMPTY_DOCUMENTMODEL_CREATED, docModel, options, null, null, false, true); return docModel; }</code><technical_language>this be: } else if (options.containsKey(CoreEventConstants.PARENT_PATH) && options.containsKey(CoreEventConstants.DESTINATION_NAME)) { docModel.setPathInfo((String) options.get(CoreEventConstants.PARENT_PATH), (String) options.get(CoreEventConstants.DESTINATION_NAME));</technical_language>

Target:
private DocumentModel createDocumentModelFromTypeName(String typeName, Map<String, Serializable> options) { SchemaManager schemaManager = Framework.getService(SchemaManager.class); DocumentType docType = schemaManager.getDocumentType(typeName); if (docType == null) { throw new IllegalArgumentException(typeName + " is not a registered core type"); } DocumentModel docModel = DocumentModelFactory.createDocumentModel(getSessionId(), docType); if (options == null) { options = new HashMap<>(); } else if (options.containsKey(CoreEventConstants.PARENT_PATH) && options.containsKey(CoreEventConstants.DESTINATION_NAME)) { docModel.setPathInfo((String) options.get(CoreEventConstants.PARENT_PATH), (String) options.get(CoreEventConstants.DESTINATION_NAME)); } notifyEvent(DocumentEventTypes.EMPTY_DOCUMENTMODEL_CREATED, docModel, options, null, null, false, true); return docModel; }
Source:
<code>public QueryObserver startTrace() { QueryObserver queryObserver = null; if (this.traceOn && this.cache != null) { QueryObserver qo = QueryObserverHolder.getInstance(); if (qo instanceof IndexTrackingQueryObserver) { queryObserver = qo; } else if (!QueryObserverHolder.hasObserver()) { queryObserver = new IndexTrackingQueryObserver(); QueryObserverHolder.setInstance(queryObserver); } else { queryObserver = qo; } <START> this.cache.getLogger().info("Starting query: " + this.queryString); <END> } return queryObserver; }</code><technical_language>Logger defined <LINK_0></technical_language>

Target:
public QueryObserver startTrace() { QueryObserver queryObserver = null; if (this.traceOn && this.cache != null) { QueryObserver qo = QueryObserverHolder.getInstance(); if (qo instanceof IndexTrackingQueryObserver) { queryObserver = qo; } else if (!QueryObserverHolder.hasObserver()) { queryObserver = new IndexTrackingQueryObserver(); QueryObserverHolder.setInstance(queryObserver); } else { queryObserver = qo; } logger.info("Starting query: " + this.queryString); } return queryObserver; }
Source:
<code>public void redraw() { composite.pack(true); Composite parent = composite.getParent(); if (parent != null) <START> parent.layout(); <END> }</code><technical_language>Do work requestLayout() is asynchronous layout call</technical_language>

Target:
public void redraw() { composite.pack(true); Composite parent = composite.getParent(); if (parent != null) parent.requestLayout(); }