auphong2707/dl4se-code-review-dataset huggingface dataset:
Source:
<code>private NewTableConfiguration setLocalityForNewTable(CommandLine cl, NewTableConfiguration ntc) { HashMap<String,Set<Text>> localityGroupMap = new HashMap<>(); String[] options = cl.getOptionValues(createTableOptLocalityProps.getOpt()); for (String localityInfo : options) { final String parts[] = localityInfo.split("=", 2); if (parts.length < 2) throw new IllegalArgumentException("Missing '=' or there are spaces between entries"); final String groupName = parts[0]; final HashSet<Text> colFams = new HashSet<>(); for (String family : parts[1].split(",")) colFams.add(new Text(family.getBytes(Shell.CHARSET))); <START> localityGroupMap.put(groupName, colFams); <END> } ntc.setLocalityGroups(localityGroupMap); return ntc; }</code><technical_language>A sanity check if if group name exist in map nice</technical_language>

Target:
private NewTableConfiguration setLocalityForNewTable(CommandLine cl, NewTableConfiguration ntc) { HashMap<String,Set<Text>> localityGroupMap = new HashMap<>(); String[] options = cl.getOptionValues(createTableOptLocalityProps.getOpt()); for (String localityInfo : options) { final String parts[] = localityInfo.split("=", 2); if (parts.length < 2) throw new IllegalArgumentException("Missing '=' or there are spaces between entries"); final String groupName = parts[0]; final HashSet<Text> colFams = new HashSet<>(); for (String family : parts[1].split(",")) colFams.add(new Text(family.getBytes(Shell.CHARSET))); if (localityGroupMap.put(groupName, colFams) != null) throw new IllegalArgumentException("Duplicate locality group name found. Group names must be unique"); } ntc.setLocalityGroups(localityGroupMap); return ntc; }
Source:
<code>public final <R> Observable<R> concatMapEager(Func1<? super T, ? extends Observable<? extends R>> mapper, int capacityHint, int maxConcurrent) { if (capacityHint < 1) { throw new IllegalArgumentException("capacityHint > 0 required but it was " + capacityHint); } <START> return lift(new OperatorEagerConcatMap<T, R>(mapper, capacityHint, maxConcurrent)); <END> }</code><technical_language>Please validate maxConcurrent well</technical_language>

Target:
public final <R> Observable<R> concatMapEager(Func1<? super T, ? extends Observable<? extends R>> mapper, int capacityHint, int maxConcurrent) { if (capacityHint < 1) { throw new IllegalArgumentException("capacityHint > 0 required but it was " + capacityHint); } if (maxConcurrent < 1) { throw new IllegalArgumentException("maxConcurrent > 0 required but it was " + capacityHint); } return lift(new OperatorEagerConcatMap<T, R>(mapper, capacityHint, maxConcurrent)); }
Source:
<code>public boolean apply(Collection<Command> cmdList) { try { DirCacheEditor ed = contents.editor(); for (Command cmd : cmdList) { apply(ed, cmd); } ed.finish(); return true; } catch (DirCacheNameConflictException e) { String r1 = refName(e.getPath1()); String r2 = refName(e.getPath2()); for (Command <START> c <END> : cmdList) { if (r1.equals(c.getRefName()) || r2.equals(c.getRefName())) { c.setResult(LOCK_FAILURE); break; } } return abort(cmdList); } catch (LockFailureException e) { return abort(cmdList); } }</code><technical_language>s/c/cmd/ for consistency</technical_language>

Target:
public boolean apply(Collection<Command> cmdList) { try { DirCacheEditor ed = contents.editor(); for (Command cmd : cmdList) { apply(ed, cmd); } ed.finish(); return true; } catch (DirCacheNameConflictException e) { String r1 = refName(e.getPath1()); String r2 = refName(e.getPath2()); for (Command cmd : cmdList) { if (r1.equals(cmd.getRefName()) || r2.equals(cmd.getRefName())) { cmd.setResult(LOCK_FAILURE); break; } } return abort(cmdList); } catch (LockFailureException e) { return abort(cmdList); } }
Source:
<code>public IReviewRemoteFactoryProvider getFactoryProvider() { <START> if ((ReviewsConnector) getConnector() != null) { <END> ReviewsClient client = ((ReviewsConnector) getConnector()).getReviewClient(getTaskRepository()); if (client != null) { return (IReviewRemoteFactoryProvider) client.getFactoryProvider(); } } return null; }</code><technical_language>need this cast</technical_language>

Target:
public IReviewRemoteFactoryProvider getFactoryProvider() { return (IReviewRemoteFactoryProvider) ((ReviewsConnector) getConnector()).getReviewClient(getTaskRepository()) .getFactoryProvider(); }
Source:
<code>public boolean updatePostContentNewEditor(boolean isAutoSave, String title, String content) { if (mPost == null) { return false; } if (!isAutoSave) { } boolean titleChanged = PostUtils.updatePostTitleIfDifferent(mPost, title); boolean contentChanged; if (compareCurrentMediaMarkedUploadingToOriginal(content)) { contentChanged = true; <START> } else if (mEditorFragment instanceof AztecEditorFragment <END> && ((AztecEditorFragment) mEditorFragment).isHistoryEnabled()) { contentChanged = ((AztecEditorFragment) mEditorFragment).hasHistory() || mMediaInsertedOnCreation; mMediaInsertedOnCreation = false; } else { contentChanged = mPost.getContent().compareTo(content) != 0; } if (contentChanged) { mPost.setContent(content); } if (!mPost.isLocalDraft() && (titleChanged || contentChanged)) { mPost.setIsLocallyChanged(true); mPost.setDateLocallyChanged(DateTimeUtils.iso8601FromTimestamp(System.currentTimeMillis() / 1000)); } return titleChanged || contentChanged; }</code><technical_language>checking mMediaInsertedOnCreation separately, this? if (mMediaInsertedOnCreation) { mMediaInsertedOnCreation = false; contentChanged = true; } else if (compareCurrentMediaMarkedUploadingToOriginal(content)) { contentChanged = true; } else if (mEditorFragment instanceof AztecEditorFragment && ((AztecEditorFragment) mEditorFragment).isHistoryEnabled()) { contentChanged = ((AztecEditorFragment) mEditorFragment).hasHistory(); } else { contentChanged = mPost.getContent().compareTo(content) != 0; }</technical_language>

Target:
public boolean updatePostContentNewEditor(boolean isAutoSave, String title, String content) { if (mPost == null) { return false; } if (!isAutoSave) { } boolean titleChanged = PostUtils.updatePostTitleIfDifferent(mPost, title); boolean contentChanged; if (mMediaInsertedOnCreation) { mMediaInsertedOnCreation = false; contentChanged = true; } else if (compareCurrentMediaMarkedUploadingToOriginal(content)) { contentChanged = true; } else if (mEditorFragment instanceof AztecEditorFragment && ((AztecEditorFragment) mEditorFragment).isHistoryEnabled()) { contentChanged = ((AztecEditorFragment) mEditorFragment).hasHistory(); } else { contentChanged = mPost.getContent().compareTo(content) != 0; } if (contentChanged) { mPost.setContent(content); } if (!mPost.isLocalDraft() && (titleChanged || contentChanged)) { mPost.setIsLocallyChanged(true); mPost.setDateLocallyChanged(DateTimeUtils.iso8601FromTimestamp(System.currentTimeMillis() / 1000)); } return titleChanged || contentChanged; }
Source:
<code>public NodeInfo getNodeInfo() { <START> return this.getProperty(GenericProperties.NODE_INFO); <END> }</code><technical_language>need distinguish computed/enriched static properties. return null enrichedProperties.getProperty(ComputedProperties.NODE_INFO)</technical_language>

Target:
public NodeInfo getNodeInfo() { return null; }
Source:
<code>public void testConnectorAbortsHandshakeOnUnknownPskIdentity() throws Exception { final CountDownLatch latch = new CountDownLatch(1); clientConfig = new DtlsConnectorConfig.Builder(clientEndpoint) .setPskStore(new StaticPskStore("unknownIdentity", CLIENT_IDENTITY_SECRET.getBytes())) .build(); client = new DTLSConnector(clientConfig); client.setErrorHandler(new ErrorHandler() { @Override public void onError(InetSocketAddress peerAddress, AlertLevel level, AlertDescription description) { latch.countDown(); assertThat(level, is(AlertLevel.FATAL)); assertThat(peerAddress, is(serverEndpoint)); } }); client.start(); SimpleMessageCallback callback = new SimpleMessageCallback(); RawData data = RawData.outbound("Hello".getBytes(), serverEndpoint, null, callback, false); client.send(data); assertTrue(latch.await(MAX_TIME_TO_WAIT_SECS, TimeUnit.SECONDS)); <START> assertThat("Error callback missing", callback.getError(MAX_TIME_TO_WAIT_SECS), is(notNullValue())); <END> }</code><technical_language>wait timeout in getError() is in ms parameter in s</technical_language>

Target:
public void testConnectorAbortsHandshakeOnUnknownPskIdentity() throws Exception { final CountDownLatch latch = new CountDownLatch(1); clientConfig = new DtlsConnectorConfig.Builder() .setAddress(clientEndpoint) .setPskStore(new StaticPskStore("unknownIdentity", CLIENT_IDENTITY_SECRET.getBytes())) .build(); client = new DTLSConnector(clientConfig); client.setErrorHandler(new ErrorHandler() { @Override public void onError(InetSocketAddress peerAddress, AlertLevel level, AlertDescription description) { latch.countDown(); assertThat(level, is(AlertLevel.FATAL)); assertThat(peerAddress, is(serverEndpoint)); } }); client.start(); SimpleMessageCallback callback = new SimpleMessageCallback(); RawData data = RawData.outbound("Hello".getBytes(), serverEndpoint, null, callback, false); client.send(data); assertTrue(latch.await(MAX_TIME_TO_WAIT_SECS, TimeUnit.SECONDS)); assertThat("Error callback missing", callback.getError(TimeUnit.SECONDS.toMillis(MAX_TIME_TO_WAIT_SECS)), is(notNullValue())); }
Source:
<code>public void prepare(Map<String, Object> conf) throws IOException { this.conf = conf; this.rootDir = DaemonConfig.getCgroupRootDir(this.conf); if (this.rootDir == null) { throw new RuntimeException("Check configuration file. The storm.supervisor.cgroup.rootdir is missing."); } File file = new File(DaemonConfig.getCgroupStormHierarchyDir(conf), rootDir); if (!file.exists()) { LOG.error("{} does not exist", file.getPath()); throw new RuntimeException( "Check if cgconfig service starts or /etc/cgconfig.conf is consistent with configuration file."); } this.center = CgroupCenter.getInstance(); if (this.center == null) { throw new RuntimeException("Cgroup error, please check /proc/cgroups"); } this.prepareSubSystem(this.conf); validatedNumaMap = Utils.getNumaMap(conf); workerToNumaId = new ConcurrentHashMap(); <START> validatedNumaMap = new ConcurrentHashMap(); <END> }</code><technical_language>L112 L114 conflict. validatedNumaMap</technical_language>

Target:
public void prepare(Map<String, Object> conf) throws IOException { this.conf = conf; this.rootDir = DaemonConfig.getCgroupRootDir(this.conf); if (this.rootDir == null) { throw new RuntimeException("Check configuration file. The storm.supervisor.cgroup.rootdir is missing."); } File file = new File(DaemonConfig.getCgroupStormHierarchyDir(conf), rootDir); if (!file.exists()) { LOG.error("{} does not exist", file.getPath()); throw new RuntimeException( "Check if cgconfig service starts or /etc/cgconfig.conf is consistent with configuration file."); } this.center = CgroupCenter.getInstance(); if (this.center == null) { throw new RuntimeException("Cgroup error, please check /proc/cgroups"); } this.prepareSubSystem(this.conf); workerToNumaId = new ConcurrentHashMap(); }
Source:
<code>public void visitLambda(PyLambdaExpressionTree pyLambdaExpressionTree) { createScope(pyLambdaExpressionTree, currentScope()); enterScope(pyLambdaExpressionTree); createParameters(pyLambdaExpressionTree.parameters()); super.visitLambda(pyLambdaExpressionTree); <START> super.scopeRootTrees.pop(); <END> }</code><technical_language>a leaveScope method</technical_language>

Target:
public void visitLambda(PyLambdaExpressionTree pyLambdaExpressionTree) { createScope(pyLambdaExpressionTree, currentScope()); enterScope(pyLambdaExpressionTree); createParameters(pyLambdaExpressionTree.parameters()); super.visitLambda(pyLambdaExpressionTree); leaveScope(); }
Source:
<code>public static <T> Collection<Collection<T>> batch( Collection<T> collection, int batchSize ) { <START> Collection<Collection<T>> batches = new ArrayList<>(); <END> Collection<T> batch = new ArrayList<>( batchSize ); int count = 0; for ( T t : collection ) { ( (ArrayList<T>) batch ).add( t ); count++; if ( count >= batchSize ) { ( (ArrayList<Collection<T>>) batches ).add( batch ); batch = new ArrayList<>( batchSize ); count = 0; } } if ( batch != null && !batch.isEmpty() ) { ( (ArrayList<Collection<T>>) batches ).add( batch ); } return batches; }</code><technical_language>declare batches ArrayList<Collection<T>>, need do casting again. batch</technical_language>

Target:
public static <T> Collection<Collection<T>> batch( Collection<T> collection, int batchSize ) { Collection<Collection<T>> batches = new ArrayList<>(); List<T> batch = new ArrayList<>( batchSize ); int count = 0; for ( T t : collection ) { batch.add( t ); count++; if ( count >= batchSize ) { batches.add( batch ); batch = new ArrayList<>( batchSize ); count = 0; } } if ( !batch.isEmpty() ) { batches.add( batch ); } return batches; }
Source:
<code>public void onDeadEvent(DeadEvent deadEvent) { Object unhandledEvent = deadEvent.getEvent(); log.warning("No event handler registered for event of type " + <START> unhandledEvent.getClass().getSimpleName() + ": " + unhandledEvent); <END> }</code><technical_language>Cool, DeadEvent. switch slf4j, playerholders instead of string concatenation follow [logging format guidelines](<LINK_0></technical_language>

Target:
public void onDeadEvent(DeadEvent deadEvent) { Object unhandledEvent = deadEvent.getEvent(); log.warn("No event handler registered for event of type '{}'", unhandledEvent.getClass().getSimpleName()); }
Source:
<code>public boolean canPrincipalConfigure( IAuthorizationPrincipal principal, String portletDefinitionId) throws AuthorizationException { String owner = IPermission.PORTAL_PUBLISH; String ownerSubscribe = IPermission.PORTAL_SUBSCRIBE; String target = IPermission.PORTLET_PREFIX + portletDefinitionId; IPortletDefinition portlet = this.portletDefinitionRegistry.getPortletDefinition(portletDefinitionId); if (portlet == null) { throw new AuthorizationException("Unable to locate portlet " + portletDefinitionId); } final String activity = IPermission.PORTLET_MODE_CONFIG; final String activitySubscribe = IPermission.PORTLET_CONFIGURE_ACTIVITY; boolean byAdmin = doesPrincipalHavePermission(principal, owner, activity, target); boolean byPrincipal = doesPrincipalHavePermission(principal, ownerSubscribe, activitySubscribe, target); <START> log.info("BEACH TEST: Checking portlet configure abilities. ByAdmin?=["+byAdmin+"], ByPrincipal?=["+byPrincipal+"]" ); <END> return byAdmin || byPrincipal; }</code><technical_language>warning: Left test log</technical_language>

Target:
public boolean canPrincipalConfigure( IAuthorizationPrincipal principal, String portletDefinitionId) throws AuthorizationException { String owner = IPermission.PORTAL_PUBLISH; String target = IPermission.PORTLET_PREFIX + portletDefinitionId; IPortletDefinition portlet = this.portletDefinitionRegistry.getPortletDefinition(portletDefinitionId); if (portlet == null) { throw new AuthorizationException("Unable to locate portlet " + portletDefinitionId); } final String activity = IPermission.PORTLET_MODE_CONFIG; boolean isAllowed = doesPrincipalHavePermission(principal, owner, activity, target); if (this.log.isTraceEnabled()) { log.trace( String.format( "In canPrincipalConfigure() - principal.key=[%s], is allowed?=[%s]", principal.getKey(), isAllowed)); } return isAllowed; }
Source:
<code>public CompletableFuture<Object> invokeAsync() { <START> long accessTime = this.accessTime == -1 ? timeService.wallClockTime() : this.accessTime; <END> boolean touched = internalDataContainer.touch(segment, key, accessTime); if (distributionManager != null && topologyId != -1) { LocalizedCacheTopology lct = distributionManager.getCacheTopology(); int currentTopologyId = lct.getTopologyId(); if (currentTopologyId != topologyId) { return CompletableFutures.completedExceptionFuture(OutdatedTopologyException.RETRY_NEXT_TOPOLOGY); } DistributionInfo di = lct.getSegmentDistribution(segment); if (di.isWriteOwner() && !di.isReadOwner()) { return CompletableFuture.completedFuture(Boolean.TRUE); } } return CompletableFuture.completedFuture(touched); }</code><technical_language>local node need call invokeAsync(), add a new method takes access time a parameter. invokeAsync() call new method timeService.wallClockTime(), need a field</technical_language>

Target:
public CompletableFuture<Object> invokeAsync() { return invokeAsync(timeService.wallClockTime()); }
Source:
<code>private boolean isAllowedURL(String url) { boolean isAllowed = false; if (url != null) { <START> if (url.contains("?")) { <END> url = url.substring(0, url.indexOf('?')); } if (url.contains("/login/") || url.contains("/registration/") || url.contains("/user/add")) { isAllowed = true; } } return isAllowed; }</code><technical_language>do do substring if contains</technical_language>

Target:
private boolean isAllowedURL(String url) { boolean isAllowed = false; if (url != null) { if (url.contains("?")) { url = url.substring(0, url.indexOf('?')); } if (url.contains("/login") || url.contains("/registration/") || url.contains("/user/add")) { isAllowed = true; } } return isAllowed; }
Source:
<code>public boolean hasCapability(Capability<?> capability, EnumFacing facing) { <START> if (super.hasCapability(capability, facing)) { return true; } <END> return MultipartCapabilityHelper.hasCapability(container, capability, facing); }</code><technical_language>Typically this is other around. specific handler, super, super contains handlers added events other mods</technical_language>

Target:
public boolean hasCapability(Capability<?> capability, EnumFacing facing) { if (capability == CapabilityMultipartContainer.MULTIPART_CONTAINER_CAPABILITY || capability == CapabilityMicroblockContainerTile.MICROBLOCK_CONTAINER_CAPABILITY || capability == CapabilitySlottedCapProvider.SLOTTED_CAP_PROVIDER_CAPABILITY) { return true; } if (MultipartCapabilityHelper.hasCapability(container, capability, facing)) { return true; } return super.hasCapability(capability, facing); }
Source:
<code>public void testGetObjectDecimal() throws Throwable { assumeCallableStatementsSupported(); try { Statement stmt = con.createStatement(); stmt.execute( "create temp table decimal_tab ( max_val numeric(30,15), min_val numeric(30,15), nul_val numeric(30,15) )"); stmt.execute( "insert into decimal_tab values (999999999999999.000000000000000,0.000000000000001,null)"); boolean ret = stmt.execute("create or replace function " + "decimal_proc( OUT pmax numeric, OUT pmin numeric, OUT nval numeric) as " + "'begin " + "select max_val into pmax from decimal_tab;" + "select min_val into pmin from decimal_tab;" + "select nul_val into nval from decimal_tab;" + " end;' " + "language plpgsql;"); } catch (Exception ex) { fail(ex.getMessage()); throw ex; } try { CallableStatement cstmt = con.prepareCall("{ call decimal_proc(?,?,?) }"); cstmt.registerOutParameter(1, Types.DECIMAL); cstmt.registerOutParameter(2, Types.DECIMAL); cstmt.registerOutParameter(3, Types.DECIMAL); cstmt.executeUpdate(); BigDecimal val = (BigDecimal) cstmt.getObject(1); <START> assertEquals(new BigDecimal("999999999999999.000000000000000"), val); <END> val = (BigDecimal) cstmt.getObject(2); assertEquals(new BigDecimal("0.000000000000001"), val); val = (BigDecimal) cstmt.getObject(3); assertNull(val); } catch (Exception ex) { fail(ex.getMessage()); } finally { try { Statement dstmt = con.createStatement(); dstmt.execute("drop function decimal_proc()"); } catch (Exception ex) { } } }</code><technical_language>Do a difference BigDecimal#equals BigDecimal#compareTo==0? treats 2.0 equal 2.00 while compareTo treats equal. intention here, this suspicious change</technical_language>

Target:
public void testGetObjectDecimal() throws Throwable { assumeCallableStatementsSupported(); try { Statement stmt = con.createStatement(); stmt.execute( "create temp table decimal_tab ( max_val numeric(30,15), min_val numeric(30,15), nul_val numeric(30,15) )"); stmt.execute( "insert into decimal_tab values (999999999999999.000000000000000,0.000000000000001,null)"); boolean ret = stmt.execute("create or replace function " + "decimal_proc( OUT pmax numeric, OUT pmin numeric, OUT nval numeric) as " + "'begin " + "select max_val into pmax from decimal_tab;" + "select min_val into pmin from decimal_tab;" + "select nul_val into nval from decimal_tab;" + " end;' " + "language plpgsql;"); } catch (Exception ex) { fail(ex.getMessage()); throw ex; } try { CallableStatement cstmt = con.prepareCall("{ call decimal_proc(?,?,?) }"); cstmt.registerOutParameter(1, Types.DECIMAL); cstmt.registerOutParameter(2, Types.DECIMAL); cstmt.registerOutParameter(3, Types.DECIMAL); cstmt.executeUpdate(); BigDecimal val = (BigDecimal) cstmt.getObject(1); assertEquals(0, val.compareTo(new BigDecimal("999999999999999.000000000000000"))); val = (BigDecimal) cstmt.getObject(2); assertEquals(0, val.compareTo(new BigDecimal("0.000000000000001"))); val = (BigDecimal) cstmt.getObject(3); assertNull(val); } catch (Exception ex) { fail(ex.getMessage()); } finally { try { Statement dstmt = con.createStatement(); dstmt.execute("drop function decimal_proc()"); } catch (Exception ex) { } } }
Source:
<code>public void receive(Message message) { org.jgroups.Address src = message.src(); short flags = message.getFlags(); byte[] buffer = message.rawBuffer(); int offset = message.offset(); int length = message.length(); RequestCorrelator.Header header = message.getHeader(HEADER_ID); byte type; long requestId; if (header != null) { type = header.type; requestId = header.requestId(); } else { type = SINGLE_MESSAGE; requestId = Request.NO_REQUEST_ID; } Address sender = fromJGroupsAddress(src); if (address == null) { if (trace) log.tracef("Ignoring message received before initial view"); if (type == REQUEST) { <START> sendResponse(fromJGroupsAddress(message.src()), CacheNotFoundResponse.INSTANCE, requestId, null); <END> } return; } switch (type) { case SINGLE_MESSAGE: processSingleMessage(src, flags, buffer, offset, length, requestId, sender); break; case REQUEST: processRequest(src, flags, buffer, offset, length, requestId, sender); break; case RESPONSE: processResponse(src, buffer, offset, length, requestId, sender); break; default: log.error("Invalid message type: " + type + " from " + src); } }</code><technical_language>org.infinispan.remoting.transport.Address computed sender. is need compute again. But, sendResponse() needs org.jgroups.Address org.infinispan.remoting.transport.Address</technical_language>

Target:
public void receive(Message message) { processMessage(message); }
Source:
<code>@Test public void byteAdapter() throws Exception { Moshi moshi = new Moshi.Builder().build(); JsonAdapter<Byte> adapter = moshi.adapter(byte.class).lenient(); assertThat(adapter.fromJson("1")).isEqualTo((byte) 1); assertThat(adapter.toJson((byte) 2)).isEqualTo("2"); try { adapter.fromJson("200"); fail(); } catch (NumberFormatException expected) { assertThat(expected.getMessage()).isEqualTo("Expected a byte but was 200 at path $"); } try { adapter.fromJson("null"); fail(); } catch (IllegalStateException expected) { <START> assertThat(expected.getMessage()).isEqualTo("Expected an int but was NULL at path $"); <END> } try { moshi.adapter(int.class).toJson(null); fail(); } catch (NullPointerException expected) { } }</code><technical_language>I "Expected a number" . . . LHS values JSON types (number/string/boolean) Java types (int/double/float/short/byte)</technical_language>

Target:
@Test public void byteAdapter() throws Exception { Moshi moshi = new Moshi.Builder().build(); JsonAdapter<Byte> adapter = moshi.adapter(byte.class).lenient(); assertThat(adapter.fromJson("1")).isEqualTo((byte) 1); assertThat(adapter.toJson((byte) -2)).isEqualTo("254"); assertThat(adapter.fromJson("-128")).isEqualTo((byte) -128); assertThat(adapter.fromJson("128")).isEqualTo((byte) -128); assertThat(adapter.toJson((byte) -128)).isEqualTo("128"); assertThat(adapter.fromJson("255")).isEqualTo((byte) -1); assertThat(adapter.toJson((byte) -1)).isEqualTo("255"); assertThat(adapter.fromJson("127")).isEqualTo((byte) 127); assertThat(adapter.toJson((byte) 127)).isEqualTo("127"); try { adapter.fromJson("256"); fail(); } catch (NumberFormatException expected) { assertThat(expected.getMessage()).isEqualTo("Expected a byte but was 256 at path $"); } try { adapter.fromJson("-129"); fail(); } catch (NumberFormatException expected) { assertThat(expected.getMessage()).isEqualTo("Expected a byte but was -129 at path $"); } try { adapter.fromJson("null"); fail(); } catch (IllegalStateException expected) { assertThat(expected.getMessage()).isEqualTo("Expected an int but was NULL at path $"); } try { adapter.toJson(null); fail(); } catch (NullPointerException expected) { } }
Source:
<code>static void assertConfigurationEquals(ConfigurationSetting expected, ConfigurationSetting actual) { if (expected != null && actual != null) { actual = cleanResponse(expected, actual); } else if (expected == actual) { return; } else if (expected == null || actual == null) { <START> assertTrue(false); <END> } assertEquals(expected.getKey(), actual.getKey()); assertEquals(expected.getLabel(), actual.getLabel()); assertEquals(expected.getValue(), actual.getValue()); assertEquals(expected.getETag(), actual.getETag()); assertEquals(expected.getLastModified(), actual.getLastModified()); assertEquals(expected.getContentType(), actual.getContentType()); final Map<String, String> expectedTags = expected.getTags(); final Map<String, String> actualTags = actual.getTags(); boolean expectedIsNullOrEmpty = ImplUtils.isNullOrEmpty(expectedTags); boolean actualIsNullOrEmpty = ImplUtils.isNullOrEmpty(actualTags); if (expectedIsNullOrEmpty) { assertTrue(actualIsNullOrEmpty); } else { assertEquals(expectedTags, actualTags); assertTrue(true); } }</code><technical_language>do assert fail instead a message</technical_language>

Target:
static void assertConfigurationEquals(ConfigurationSetting expected, ConfigurationSetting actual) { if (expected != null && actual != null) { actual = cleanResponse(expected, actual); } else if (expected == actual) { return; } else if (expected == null || actual == null) { assertFalse("One of input settings is null", true); } equals(expected, actual); }
Source:
<code>private void setValues( Object... values ) { removeAllValueFields(); for ( int i = 0; i < values.length; i++ ) { ValueEncoding encoding = ValueEncoding.forValue( values[i] ); Field reusableField = getFieldWithValue( i, "composite", encoding, values[i] ); document.add( reusableField ); } <START> } <END></code><technical_language>Keeping existing indexes working</technical_language>

Target:
private void setValues( Object... values ) { removeAllValueFields(); for ( int i = 0; i < values.length; i++ ) { ValueEncoding encoding = ValueEncoding.forValue( values[i] ); Field reusableField = getFieldWithValue( i, encoding, values[i] ); document.add( reusableField ); } }
Source:
<code>@Nullable @Override public View onCreateView(@NonNull LayoutInflater inflater, @Nullable ViewGroup container, @Nullable Bundle savedInstanceState) { super.onCreateView(inflater, container, savedInstanceState); View view = inflater.inflate(R.layout.fragment_main, container, false); unbinder = ButterKnife.bind(this, view); disposables.add(WikipediaApp.getInstance().getBus().subscribe(new EventBusConsumer())); viewPager.setUserInputEnabled(false); viewPager.setAdapter(new NavTabFragmentPagerAdapter(this)); viewPager.registerOnPageChangeCallback(pageChangeCallback); FeedbackUtil.setButtonLongPressToast(moreContainer); tabLayout.setOnNavigationItemSelectedListener(item -> { if (getCurrentFragment() instanceof FeedFragment && item.getOrder() == 0) { ((FeedFragment) getCurrentFragment()).scrollToTop(); } viewPager.setCurrentItem(item.getOrder(), false); return true; }); <START> if (!(getCurrentFragment() instanceof SuggestedEditsTasksFragment)) { maybeShowEditsTooltip(); } <END> if (savedInstanceState == null) { handleIntent(requireActivity().getIntent()); } return view; }</code><technical_language>if move this logic mabyShowEditsTooltip() method</technical_language>

Target:
@Nullable @Override public View onCreateView(@NonNull LayoutInflater inflater, @Nullable ViewGroup container, @Nullable Bundle savedInstanceState) { super.onCreateView(inflater, container, savedInstanceState); View view = inflater.inflate(R.layout.fragment_main, container, false); unbinder = ButterKnife.bind(this, view); disposables.add(WikipediaApp.getInstance().getBus().subscribe(new EventBusConsumer())); viewPager.setUserInputEnabled(false); viewPager.setAdapter(new NavTabFragmentPagerAdapter(this)); viewPager.registerOnPageChangeCallback(pageChangeCallback); FeedbackUtil.setButtonLongPressToast(moreContainer); tabLayout.setOnNavigationItemSelectedListener(item -> { if (getCurrentFragment() instanceof FeedFragment && item.getOrder() == 0) { ((FeedFragment) getCurrentFragment()).scrollToTop(); } if (getCurrentFragment() instanceof HistoryFragment && item.getOrder() == NavTab.SEARCH.code()) { openSearchActivity(NAV_MENU, null); return true; } viewPager.setCurrentItem(item.getOrder(), false); return true; }); maybeShowEditsTooltip(); if (savedInstanceState == null) { handleIntent(requireActivity().getIntent()); } return view; }
Source:
<code>public void run() { try { logger.trace("Processing document"); process(doc); } catch (Exception e) { <START> exception = e; <END> } finally { completed = true; } }</code><technical_language>logging here? dangerous depend user of ProcessThread correctly check call getException</technical_language>

Target:
public void run() { try { logger.trace("Processing document"); process(doc); } catch (Exception e) { logger.trace("Caught exception during processing", e); exception = e; } finally { running = false; } }
Source:
<code>public List<DeviceModelFirmware> findAllDeviceModelFirmwares(final String organisationIdentification, final String manufacturer, final String modelCode) throws FunctionalException { final Organisation organisation = this.domainHelperService.findOrganisation(organisationIdentification); this.domainHelperService.isAllowed(organisation, PlatformFunction.GET_DEVICE_MODEL_FIRMWARE); final Manufacturer databaseManufacturer = this.manufacturerRepository.findByManufacturerId(manufacturer); final DeviceModel databaseDeviceModel = this.deviceModelRepository.findByManufacturerIdAndModelCode(databaseManufacturer, modelCode); final List<DeviceModelFirmware> deviceModelFirmwares = this.deviceModelFirmwareRepository.findByDeviceModel(databaseDeviceModel); for (final DeviceModelFirmware deviceModelFirmware : deviceModelFirmwares) { if (deviceModelFirmware.getFile() != null) { <START> deviceModelFirmware.setFile(null); <END> } } return deviceModelFirmwares; }</code><technical_language>a variable is defined volatile is shared threads, setting variable null is faster checking setting</technical_language>

Target:
public List<DeviceModelFirmware> findAllDeviceModelFirmwares(final String organisationIdentification, final String manufacturer, final String modelCode) throws FunctionalException { final Organisation organisation = this.domainHelperService.findOrganisation(organisationIdentification); this.domainHelperService.isAllowed(organisation, PlatformFunction.GET_DEVICE_MODEL_FIRMWARE); final Manufacturer databaseManufacturer = this.manufacturerRepository.findByManufacturerId(manufacturer); final DeviceModel databaseDeviceModel = this.deviceModelRepository.findByManufacturerIdAndModelCode(databaseManufacturer, modelCode); final List<DeviceModelFirmware> deviceModelFirmwares = this.deviceModelFirmwareRepository.findByDeviceModel(databaseDeviceModel); for (final DeviceModelFirmware deviceModelFirmware : deviceModelFirmwares) { deviceModelFirmware.setFile(null); } return deviceModelFirmwares; }
Source:
<code>public Binding<MessageChannel> bindProducer(String name, MessageChannel outboundBindTarget, ProducerProperties properties) { SubscribableChannel functionOutputChannel = BinderFunctionSupport.andThenFunctionDefinition( this.integrationFlowFunctionSupport, outboundBindTarget); <START> final BlockingQueue<Message<?>> queue = messageCollector.register(outboundBindTarget, <END> properties.isUseNativeEncoding()); (functionOutputChannel).subscribe(message -> queue.add(message)); this.messageChannels.put(name, outboundBindTarget); return new TestBinding(outboundBindTarget, messageCollector); }</code><technical_language>do this register a functionOutputChannel avoid manual subscribe() below</technical_language>

Target:
public Binding<MessageChannel> bindProducer(String name, MessageChannel outboundBindTarget, ProducerProperties properties) { final BlockingQueue<Message<?>> queue = messageCollector.register(outboundBindTarget, properties.isUseNativeEncoding()); ((SubscribableChannel) outboundBindTarget).subscribe(new MessageHandler() { @Override public void handleMessage(Message<?> message) throws MessagingException { queue.add(message); } }); this.messageChannels.put(name, outboundBindTarget); return new TestBinding(outboundBindTarget, messageCollector); }
Source:
<code>private void addHash(long hash) { instance.insertHash(hash); if (instance instanceof SparseHll && instance.estimatedInMemorySize() > DenseHll.estimatedInMemorySize(instance.getIndexBitLength())) { <START> instance = ((SparseHll) instance).toDense(); <END> } }</code><technical_language>cast is needed</technical_language>

Target:
private void addHash(long hash) { instance.insertHash(hash); if (instance instanceof SparseHll) { instance = makeDenseIfNecessary((SparseHll) instance); } }
Source:
<code>public long getStartTimeAsLong() { <START> return startTime.atZone(ZoneId.systemDefault()).toEpochSecond(); <END> }</code><technical_language>Please do check null for getters. I previously returned null in case, object a Date, return primitive long object. return Long serialized null long value</technical_language>

Target:
public Long getStartTimeAsLong() { return (startTime == null) ? null : startTime.atZone(ZoneId.systemDefault()).toInstant().toEpochMilli(); }
Source:
<code>public void onCreate(Bundle savedInstanceState) { super.onCreate(savedInstanceState); setContentView(R.layout.list_content_simple); String timeFormat; if (android.text.format.DateFormat.is24HourFormat(this)) { timeFormat = "EEEE HH:mm"; } else { timeFormat = "EEEE hh:mm a"; } mTimeAndDayFormatter = new SimpleDateFormat(timeFormat, Locale.getDefault()); <START> mTimeFormatter = android.text.format.DateFormat.getTimeFormat(this); <END> mRes = getResources(); getListView().setFastScrollEnabled(true); getListView().setItemsCanFocus(false); getListView().setChoiceMode(ListView.CHOICE_MODE_NONE); Intent intent = getIntent(); String accountUuid = intent.getStringExtra(ChooseFolder.EXTRA_ACCOUNT); mAccount = Preferences.getPreferences(this).getAccount(accountUuid); mMessageReference = intent.getParcelableExtra(ChooseFolder.EXTRA_MESSAGE); mAdapter = new ArrayAdapter<>(this, android.R.layout.simple_list_item_1); mAdapter.addAll(getTimes()); setListAdapter(mAdapter); getListView().setOnItemClickListener(new AdapterView.OnItemClickListener() { @Override public void onItemClick(AdapterView<?> parent, View view, int position, long id) { SnoozeTime time = mAdapter.getItem(position); if (time.timestamp <= 0) { showDateTimePicker(new OnDateTimePickedListener() { @Override public void onDateTimePicked(long timestamp) { finishWithResult(timestamp); } }); return; } finishWithResult(time.timestamp); } }); }</code><technical_language>This block wants extracting a separate function</technical_language>

Target:
public void onCreate(Bundle savedInstanceState) { super.onCreate(savedInstanceState); setContentView(R.layout.list_content_simple); initFormatters(); mRes = getResources(); getListView().setFastScrollEnabled(true); getListView().setItemsCanFocus(false); getListView().setChoiceMode(ListView.CHOICE_MODE_NONE); Intent intent = getIntent(); String accountUuid = intent.getStringExtra(ChooseFolder.EXTRA_ACCOUNT); mAccount = Preferences.getPreferences(this).getAccount(accountUuid); mMessageReference = intent.getParcelableExtra(ChooseFolder.EXTRA_MESSAGE); mAdapter = new ArrayAdapter<>(this, android.R.layout.simple_list_item_1); mAdapter.addAll(getTimes()); setListAdapter(mAdapter); getListView().setOnItemClickListener(new AdapterView.OnItemClickListener() { @Override public void onItemClick(AdapterView<?> parent, View view, int position, long id) { SnoozeTime time = mAdapter.getItem(position); if (time.timestamp == SNOOZE_TIMESTAMP_CHOOSE_CUSTOM_TIME) { chooseCustomTimeFromPicker(); return; } finishWithResult(time.timestamp); } }); }
Source:
<code>private Guid createDisk(DiskImage image, boolean isBoot) { image.setDiskAlias(renameDiskAlias(getVm().getOrigin(), image.getDiskAlias())); <START> image.setVolumeFormat(VolumeFormat.COW); <END> AddDiskParameters diskParameters = new AddDiskParameters(new DiskVmElement(null, getVmId()), image); diskParameters.setStorageDomainId(getStorageDomainId()); diskParameters.setParentCommand(getActionType()); diskParameters.setParentParameters(getParameters()); diskParameters.setShouldRemainIllegalOnFailedExecution(true); diskParameters.setStorageDomainId(getParameters().getDestDomainId()); DiskVmElement dve = new DiskVmElement(image.getId(), getVmId()); dve.setDiskInterface(DiskInterface.VirtIO); dve.setBoot(isBoot); diskParameters.setDiskVmElement(dve); VdcReturnValueBase vdcReturnValueBase = runInternalActionWithTasksContext(VdcActionType.AddDisk, diskParameters); if (!vdcReturnValueBase.getSucceeded()) { throw new EngineException(vdcReturnValueBase.getFault().getError(), "Failed to create disk!"); } getTaskIdList().addAll(vdcReturnValueBase.getInternalVdsmTaskIdList()); return vdcReturnValueBase.getActionReturnValue(); }</code><technical_language>Please remove</technical_language>

Target:
private Guid createDisk(DiskImage image, boolean isBoot) { image.setDiskAlias(renameDiskAlias(getVm().getOrigin(), image.getDiskAlias())); AddDiskParameters diskParameters = new AddDiskParameters(new DiskVmElement(null, getVmId()), image); diskParameters.setStorageDomainId(getStorageDomainId()); diskParameters.setParentCommand(getActionType()); diskParameters.setParentParameters(getParameters()); diskParameters.setShouldRemainIllegalOnFailedExecution(true); diskParameters.setStorageDomainId(getParameters().getDestDomainId()); DiskVmElement dve = new DiskVmElement(image.getId(), getVmId()); dve.setDiskInterface(DiskInterface.VirtIO); dve.setBoot(isBoot); diskParameters.setDiskVmElement(dve); VdcReturnValueBase vdcReturnValueBase = runInternalActionWithTasksContext(VdcActionType.AddDisk, diskParameters); if (!vdcReturnValueBase.getSucceeded()) { throw new EngineException(vdcReturnValueBase.getFault().getError(), "Failed to create disk!"); } getTaskIdList().addAll(vdcReturnValueBase.getInternalVdsmTaskIdList()); return vdcReturnValueBase.getActionReturnValue(); }
Source:
<code><START> protected boolean allowPausedModeWork(boolean internalCall, boolean adminConnection) { <END> return (VoltDB.instance().getMode() != OperationMode.PAUSED || internalCall || adminConnection); }</code><technical_language>static others? function makeQuickResponse</technical_language>

Target:
static protected boolean allowPausedModeWork(boolean internalCall, boolean adminConnection) { return (VoltDB.instance().getMode() != OperationMode.PAUSED || internalCall || adminConnection); }
Source:
<code>public IonValue[] toArray() { checkForParentModification(); if (size < 1) return EMPTY_VALUE_ARRAY; IonValue[] array = new IonValue[size]; if(parent instanceof IonSequenceLite) { System.arraycopy(IonSequenceLite.this._children, fromIndex, array, 0, size); } else { <START> for(int i = 0; i < size; i++) { <END> array[i] = get(i); } } return array; }</code><technical_language>"for(" --> "for (" other instances of this,</technical_language>

Target:
public IonValue[] toArray() { checkForParentModification(); if (size < 1) { return EMPTY_VALUE_ARRAY; } return toArray(new IonValue[size]); }
Source:
<code>public int compareTo(Address o) { <START> return 0; <END> }</code><technical_language>Hrmm, this return 0 if o == this? o.compareTo(this) ensure symmetry</technical_language>

Target:
public int compareTo(Address o) { return o == this ? 0 : -1; }
Source:
<code><START> public void testDeactivatingTaskAndSavingAllWithOnlyOneDirtyFile() throws Exception { <END> IEditorPart dirtyFile = activateTaskAndOpenOneFile(); doReturn(0).when(listener).openTaskDeactivationDialog(anyList()); assertTrue(listener.shouldDeactivateTask(task1)); assertFalse(dirtyFile.isDirty()); }</code><technical_language>test case file is dirty is not, instead</technical_language>

Target:
public void testDeactivatingTaskAndSavingAllWithOnlyOneDirtyFile() throws Exception { IEditorPart dirtyFile = activateTaskAndOnlyEditOneFile(); List<IEditorPart> dirtyParts = new ArrayList<IEditorPart>(); dirtyParts.add(dirtyFile); doReturn(0).when(listener).openTaskDeactivationDialog(anyList()); assertTrue(listener.shouldDeactivateTask(task1)); assertFalse(dirtyFile.isDirty()); verify(listener).openTaskDeactivationDialog( Matchers.argThat(new CompareListOfReferencesWithoutOrder(makeDirtyReferencesFromParts(dirtyParts)))); }
Source:
<code>public static boolean setState(Block block, boolean state, Block source) { if (block.getTypeId() != BlockID.LEVER && block.getTypeId() != BlockID.REDSTONE_TORCH_OFF && block.getTypeId() != BlockID.REDSTONE_TORCH_ON) return false; boolean wasOn; if (block.getTypeId() != BlockID.LEVER) { wasOn = block.getTypeId() == BlockID.REDSTONE_TORCH_ON; if (wasOn == state) { block.setTypeIdAndData( (wasOn ? BlockID.REDSTONE_TORCH_OFF : BlockID.REDSTONE_TORCH_ON), block.getData(), true ); return true; } return false; } Lever lever = (Lever) block.getState().getData(); <START> if (!block.getRelative(lever.getAttachedFace()).equals(source)) { <END> return false; } wasOn = (block.getData() & 0x8) > 0; byte data = block.getData(); int newData; if (!state) { newData = data & 0x7; } else { newData = data | 0x8; } if (wasOn != state) { net.minecraft.server.World w = ((CraftWorld)block.getWorld()).getHandle(); w.setData(block.getX(), block.getY(), block.getZ(), newData); w.b(block.getX(), block.getY(), block.getZ()); w.applyPhysics(block.getX(), block.getY(), block.getZ(), 0); w.applyPhysics(source.getX(), source.getY(), source.getZ(), 0); return true; } return false; }</code><technical_language>This needs changed levers ground need able triggered</technical_language>

Target:
public static boolean setState(Block block, boolean state, Block source) { if (block.getTypeId() != BlockID.LEVER) return false; Lever lever = (Lever) block.getState().getData(); if (!block.getRelative(lever.getAttachedFace()).equals(source)) { return false; } boolean wasOn = (block.getData() & 0x8) > 0; byte data = block.getData(); int newData; if (!state) { newData = data & 0x7; } else { newData = data | 0x8; } if (wasOn != state) { block.setData((byte) newData, true); net.minecraft.server.World w = ((CraftWorld)block.getWorld()).getHandle(); w.applyPhysics(source.getX(), source.getY(), source.getZ(), 0); return true; } return false; }
Source:
<code>public UserPrincipalManager(AuthorizationServerEndpoints authorizationServerEndpoints, AADAuthenticationProperties aadAuthenticationProperties, ResourceRetriever resourceRetriever, boolean explicitAudienceCheck) { this.aadAuthenticationProperties = aadAuthenticationProperties; this.explicitAudienceCheck = explicitAudienceCheck; if (explicitAudienceCheck) { this.validAudiences.add(this.aadAuthenticationProperties.getClientId()); this.validAudiences.add(this.aadAuthenticationProperties.getAppIdUri()); } try { <START> String aadKeyDiscoveryUri = <END> authorizationServerEndpoints.jwkSetEndpoint(this.aadAuthenticationProperties.getTenantId()); keySource = new RemoteJWKSet<>(new URL(aadKeyDiscoveryUri), resourceRetriever); } catch (MalformedURLException e) { LOGGER.error("Failed to parse active directory key discovery uri.", e); throw new IllegalArgumentException("Failed to parse active directory key discovery uri.", e); } }</code><technical_language>Rename aadKeyDiscoveryUri jwkSetEndpoint</technical_language>

Target:
public UserPrincipalManager(AuthorizationServerEndpoints authorizationServerEndpoints, AADAuthenticationProperties aadAuthenticationProperties, ResourceRetriever resourceRetriever, boolean explicitAudienceCheck) { this.aadAuthenticationProperties = aadAuthenticationProperties; this.explicitAudienceCheck = explicitAudienceCheck; if (explicitAudienceCheck) { this.validAudiences.add(this.aadAuthenticationProperties.getClientId()); this.validAudiences.add(this.aadAuthenticationProperties.getAppIdUri()); } try { String jwkSetEndpoint = authorizationServerEndpoints.jwkSetEndpoint(this.aadAuthenticationProperties.getTenantId()); keySource = new RemoteJWKSet<>(new URL(jwkSetEndpoint), resourceRetriever); } catch (MalformedURLException e) { LOGGER.error("Failed to parse active directory key discovery uri.", e); throw new IllegalArgumentException("Failed to parse active directory key discovery uri.", e); } }
Source:
<code><START> private String findRequiresCheckoutOptionsColumn() { <END> if (DbConnectionFactory.isMySql()) { return MYSQL_FIND_REQUIRES_CHECKOUT_OPTION_COLUMN; } else if (DbConnectionFactory.isPostgres()) { return POSTGRES_FIND_REQUIRES_CHECKOUT_OPTION_COLUMN; } else if (DbConnectionFactory.isMsSql()) { return MSSQL_FIND_REQUIRES_CHECKOUT_OPTION_COLUMN; } else if (DbConnectionFactory.isOracle()) { return ORACLE_FIND_REQUIRES_CHECKOUT_OPTION_COLUMN; } else { return null; } }</code><technical_language>![MAJOR](<LINK_0> 'Severity: MAJOR') Reduce number of returns of this method 5, maximum allowed 3. [![rule](<LINK_1>](<LINK_2></technical_language>

Target:
private String findRequiresCheckoutOptionsColumn() { String sql = null; if (DbConnectionFactory.isMySql()) { sql = MYSQL_FIND_REQUIRES_CHECKOUT_OPTION_COLUMN; } else if (DbConnectionFactory.isPostgres()) { sql = POSTGRES_FIND_REQUIRES_CHECKOUT_OPTION_COLUMN; } else if (DbConnectionFactory.isMsSql()) { sql = MSSQL_FIND_REQUIRES_CHECKOUT_OPTION_COLUMN; } else if (DbConnectionFactory.isOracle()) { sql = ORACLE_FIND_REQUIRES_CHECKOUT_OPTION_COLUMN; } return sql; }
Source:
<code>protected void updateUsbNativeMessageVisibility(final UnitVmModel object) { VDSGroup vdsGroup = (VDSGroup) object.getCluster().getSelectedItem(); nativeUsbWarningMessage.setVisible(object.getUsbPolicy().getSelectedItem() == UsbPolicy.ENABLED_NATIVE && vdsGroup != null && vdsGroup.getcompatibility_version() != null <START> && !AppConfig.INSTANCE.getBoolean(ConfigurationValues.MigrationSupportForNativeUsb, <END> vdsGroup.getcompatibility_version().getValue())); }</code><technical_language>This class is a gin managed part of app - able inject AppConfig. Well, inject, inject view pass constructor of this - rest of configuration of this class is done (e.g.CommonApplicationConstants, CommonApplicationResources etc)</technical_language>

Target:
protected void updateUsbNativeMessageVisibility(final UnitVmModel object) { VDSGroup vdsGroup = (VDSGroup) object.getCluster().getSelectedItem(); nativeUsbWarningMessage.setVisible(object.getUsbPolicy().getSelectedItem() == UsbPolicy.ENABLED_NATIVE && vdsGroup != null && vdsGroup.getcompatibility_version() != null && !(Boolean) AsyncDataProvider.GetConfigValuePreConverted(ConfigurationValues.MigrationSupportForNativeUsb, vdsGroup.getcompatibility_version().getValue())); }