auphong2707/dl4se-code-review-dataset huggingface dataset:
Source:
<code>private static void logNoMatchClasses(Collection<IClassCoverage> noMatchClasses) { <START> if (!noMatchClasses.isEmpty()) { <END> LOG.warn("The following class(es) did not match with execution data:"); for (IClassCoverage iClassCoverage : noMatchClasses) { LOG.warn(String.format("> '%s'", iClassCoverage.getName())); } LOG.warn("In order to have accurate coverage measures, the same class files must be used as at runtime for report generation."); } }</code><technical_language>@m-g-sonar early return improve readability</technical_language>

Target:
private static void logNoMatchClasses(Collection<IClassCoverage> noMatchClasses) { if (noMatchClasses.isEmpty()) { return; } LOG.warn("The following class(es) did not match with execution data:"); for (IClassCoverage iClassCoverage : noMatchClasses) { LOG.warn(String.format("> '%s'", iClassCoverage.getName())); } LOG.warn("In order to have accurate coverage measures, the same class files must be used as at runtime for report generation."); }
Source:
<code>public static ObjectFactory loadObjectFactory(ClassFinder classFinder) { ObjectFactory objectFactory; try { Reflections reflections = new Reflections(classFinder); objectFactory = reflections.instantiateExactlyOneSubclass(ObjectFactory.class, "cucumber.runtime", new Class[0], new Object[0]); } catch (CucumberException ce) { <START> logger.warn(getMultipleObjectFactoryLogMessage()); <END> objectFactory = new DefaultJavaObjectFactory(); } return objectFactory; }</code><technical_language>I verified, get _no_ DI containers classpath? a common situation people want/need DI, message added incorrect in case</technical_language>

Target:
public static ObjectFactory loadObjectFactory(ClassFinder classFinder) { ObjectFactory objectFactory; try { Reflections reflections = new Reflections(classFinder); objectFactory = reflections.instantiateExactlyOneSubclass(ObjectFactory.class, "cucumber.runtime", new Class[0], new Object[0]); } catch (TooManyInstancesException e) { System.out.println(getMultipleObjectFactoryLogMessage()); objectFactory = new DefaultJavaObjectFactory(); } catch (NoInstancesException e) { objectFactory = new DefaultJavaObjectFactory(); } return objectFactory; }
Source:
<code>protected void scanAndAggregate( final PooledTopNParams params, final int[] positions, final BufferAggregator[] theAggregators, final int numProcessed ) { final Cursor cursor = params.getCursor(); if (theAggregators.length == 1) { BufferAggregator aggregator = theAggregators[0]; if (cursor instanceof HistoricalCursor && aggregator instanceof SimpleDoubleBufferAggregator) { <START> if (specializeHistoricalSingleValueDimSelector1SimpleDoubleAggPooledTopN && <END> params.getDimSelector() instanceof SingleValueHistoricalDimensionSelector && ((SimpleDoubleBufferAggregator) aggregator).getSelector() instanceof HistoricalFloatColumnSelector) { scanAndAggregateHistorical1SimpleDoubleAgg( params, positions, (SimpleDoubleBufferAggregator) aggregator, cursor, defaultHistoricalSingleValueDimSelector1SimpleDoubleAggScanner ); BaseQuery.checkInterrupted(); return; } if (specializeHistorical1SimpleDoubleAggPooledTopN && params.getDimSelector() instanceof HistoricalDimensionSelector && ((SimpleDoubleBufferAggregator) aggregator).getSelector() instanceof HistoricalFloatColumnSelector) { scanAndAggregateHistorical1SimpleDoubleAgg( params, positions, (SimpleDoubleBufferAggregator) aggregator, cursor, defaultHistorical1SimpleDoubleAggScanner ); BaseQuery.checkInterrupted(); return; } } if (specializeGeneric1AggPooledTopN) { scanAndAggregateGeneric1Agg(params, positions, aggregator, cursor); BaseQuery.checkInterrupted(); return; } } if (specializeGeneric2AggPooledTopN && theAggregators.length == 2) { scanAndAggregateGeneric2Agg(params, positions, theAggregators, cursor); BaseQuery.checkInterrupted(); return; } scanAndAggregateDefault(params, positions, theAggregators); BaseQuery.checkInterrupted(); }</code><technical_language>code generation worth handle optimizations similar cases. Do plan</technical_language>

Target:
protected void scanAndAggregate( final PooledTopNParams params, final int[] positions, final BufferAggregator[] theAggregators, final int numProcessed ) { for (ScanAndAggregate specializedScanAndAggregate : specializedScanAndAggregateImplementations) { if (specializedScanAndAggregate.scanAndAggregate(params, positions, theAggregators)) { BaseQuery.checkInterrupted(); return; } } scanAndAggregateDefault(params, positions, theAggregators); BaseQuery.checkInterrupted(); }
Source:
<code>public void testFunction() { tableEnv.executeSql(String.format("create function my_abs as '%s'", GenericUDFAbs.class.getName())); <START> List<Row> functions = Lists.newArrayList(tableEnv.executeSql("show functions").collect()); <END> assertTrue(functions.toString().contains("my_abs")); tableEnv.executeSql("drop function my_abs"); assertFalse(hiveCatalog.functionExists(new ObjectPath("default", "my_abs"))); tableEnv.executeSql("drop function if exists foo"); }</code><technical_language>do test verify this created function work</technical_language>

Target:
public void testFunction() throws Exception { tableEnv.executeSql(String.format("create function my_abs as '%s'", GenericUDFAbs.class.getName())); List<Row> functions = Lists.newArrayList(tableEnv.executeSql("show functions").collect()); assertTrue(functions.toString().contains("my_abs")); tableEnv.executeSql("create table src(x int)"); waitForJobFinish(tableEnv.executeSql("insert into src values (1),(-1)")); assertEquals("[1, 1]", queryResult(tableEnv.sqlQuery("select my_abs(x) from src")).toString()); tableEnv.executeSql("drop function my_abs"); assertFalse(hiveCatalog.functionExists(new ObjectPath("default", "my_abs"))); tableEnv.executeSql("drop function if exists foo"); }
Source:
<code>private Set<PersistentResource> upsertObjects(Environment context) { if(context.ids.isPresent()) { throw new BadRequestException("UPSERT must not include ids"); } if(!context.data.isPresent()) { throw new BadRequestException("UPSERT must include data argument"); } Class<?> entityClass; EntityDictionary dictionary = context.requestScope.getDictionary(); if(context.isRoot()) { entityClass = dictionary.getEntityClass(context.field.getName()); } else { entityClass = dictionary.getParameterizedType(context.parentResource.getResourceClass(), context.field.getName()); } Set<PersistentResource> upsertedObjects = new HashSet(); for(Map<String, Object> input : context.data.get()) { upsertedObjects.addAll(graphWalker(input, this::upsertObject, entityClass, context.requestScope)); } for(Map<String, Object> input : context.data.get()) { graphWalker(input, this::updateRelationship, entityClass, context.requestScope); } if(!context.isRoot()) { for(PersistentResource obj : upsertedObjects) { context.parentResource.addRelation(context.field.getName(), obj); } <START> } <END> return upsertedObjects; }</code><technical_language>return entities.stream.map(Entity::toPersistentResource)</technical_language>

Target:
private Set<PersistentResource> upsertObjects(Environment context) { if(context.ids.isPresent()) { throw new BadRequestException("UPSERT must not include ids"); } if(!context.data.isPresent()) { throw new BadRequestException("UPSERT must include data argument"); } Class<?> entityClass; EntityDictionary dictionary = context.requestScope.getDictionary(); if(context.isRoot()) { entityClass = dictionary.getEntityClass(context.field.getName()); } else { entityClass = dictionary.getParameterizedType(context.parentResource.getResourceClass(), context.field.getName()); } Optional<Entity> parentEntity; if(!context.isRoot()) { parentEntity = Optional.of(new Entity(Optional.empty(), null, context.parentResource.getResourceClass(), context.requestScope)); } else { parentEntity = Optional.empty(); } Set<Entity> entitySet = new HashSet<>(); for(Map<String, Object> input : context.data.get()) { entitySet.add(new Entity(parentEntity, input, entityClass, context.requestScope)); } for(Entity entity : entitySet) { graphWalker(entity, this::upsertObject); } for(Entity entity : entitySet) { graphWalker(entity, this::updateRelationship); if (!context.isRoot()) { context.parentResource.addRelation(context.field.getName(), entity.toPersistentResource()); } } return entitySet.stream().map(Entity::toPersistentResource).collect(Collectors.toSet()); }
Source:
<code>public void onMapClick(LatLng latLng) { Log.d(TAG, "Map clicked"); if (mMarkerData.getFocus() != null) { mMarkerData.removeFocus(); } <START> Location location = LocationUtil.makeLocation(latLng.latitude, latLng.longitude); <END> mOnFocusChangedListener.onFocusChanged(null, null, location); }</code><technical_language>This changed Location location = MapHelpV2.makeLocation(latLng);</technical_language>

Target:
public void onMapClick(LatLng latLng) { Log.d(TAG, "Map clicked"); if (mMarkerData.getFocus() != null) { mMarkerData.removeFocus(); } Location location = MapHelpV2.makeLocation(latLng); mOnFocusChangedListener.onFocusChanged(null, null, location); }
Source:
<code>private boolean isTenantSpecificTable() { <START> return (getType() == USER || getType() == SYSTEM) && getParentTableName() != null; <END> }</code><technical_language>reusing parent table name concept for multi-tenant tables? I approach, a member variable for base table name. want tenant-specific indexes, I run issues then</technical_language>

Target:
public boolean isTenantSpecificTable() { return getType() == USER && getBaseTableName() != null; }
Source:
<code><START> public void testBatchRunOnNonExistentSpecificPractitioner() { <END> assertLinkCount(2); myEmpiProviderR4.clearEmpiLinks(null); try { myEmpiProviderR4.empiBatchPractitionerInstance(new IdType("Practitioner/999"), null); fail(); } catch (ResourceNotFoundException e){} }</code><technical_language>nice tests! measure coverage</technical_language>

Target:
public void testBatchRunOnNonExistentSpecificPractitioner() { myEmpiProviderR4.clearEmpiLinks(null); try { myEmpiProviderR4.empiBatchPractitionerInstance(new IdType("Practitioner/999"), null); fail(); } catch (ResourceNotFoundException e){} }
Source:
<code>public void acceptsNoContentLengthOnClosedConnection() throws Exception { final String text = "Close Test"; final Socket socket = Mockito.mock(Socket.class); Mockito.when(socket.getInputStream()).thenReturn( <START> new ByteArrayInputStream(Joiner.on("\r\n").join( <END> "POST / HTTP/1.1", "Host: localhost", "Connection: Close", "", "hi" ).getBytes() ) ); Mockito.when(socket.getLocalAddress()).thenReturn( InetAddress.getLocalHost() ); Mockito.when(socket.getLocalPort()).thenReturn(0); Mockito.when(socket.getInetAddress()).thenReturn( InetAddress.getLocalHost() ); Mockito.when(socket.getPort()).thenReturn(0); final ByteArrayOutputStream baos = new ByteArrayOutputStream(); Mockito.when(socket.getOutputStream()).thenReturn(baos); new BkReuse(new BkBasic(new TkText(text))).accept(socket); MatcherAssert.assertThat( baos.toString(), Matchers.containsString(text) ); }</code><technical_language>@prondzyn put Joiner in next line</technical_language>

Target:
public void acceptsNoContentLengthOnClosedConnection() throws Exception { final String text = "Close Test"; final Socket socket = Mockito.mock(Socket.class); Mockito.when(socket.getInputStream()).thenReturn( new ByteArrayInputStream( Joiner.on("\r\n").join( "POST / HTTP/1.1", "Host: localhost", "Connection: Close", "", "hi" ).getBytes("UTF-8") ) ); Mockito.when(socket.getLocalAddress()).thenReturn( InetAddress.getLocalHost() ); Mockito.when(socket.getLocalPort()).thenReturn(0); Mockito.when(socket.getInetAddress()).thenReturn( InetAddress.getLocalHost() ); Mockito.when(socket.getPort()).thenReturn(0); final ByteArrayOutputStream baos = new ByteArrayOutputStream(); Mockito.when(socket.getOutputStream()).thenReturn(baos); new BkReuse(new BkBasic(new TkText(text))).accept(socket); MatcherAssert.assertThat( baos.toString(), Matchers.containsString(text) ); }
Source:
<code>public void init(Composite parent, String viewerName, ITmfTrace trace) { super.init(parent, viewerName); fCountInstance++; fInstanceNb = fCountInstance; fTrace = trace; fProcessAll = (trace instanceof TmfExperiment); initContent(parent); initInput(); <START> fSash.addDisposeListener(new DisposeListener() { <END> @Override public void widgetDisposed(DisposeEvent e) { internalDispose(); } }); }</code><technical_language>lambda</technical_language>

Target:
public void init(Composite parent, String viewerName, ITmfTrace trace) { super.init(parent, viewerName); fCountInstance++; fInstanceNb = fCountInstance; fTrace = trace; fProcessAll = (trace instanceof TmfExperiment); initContent(parent); initInput(); fSash.addDisposeListener((e) -> { internalDispose(); }); }
Source:
<code>protected void initializeModelHandlers(final TagListModel model) { super.initializeModelHandlers(model); model.getResetRequestedEvent().addListener(new IEventListener<EventArgs>() { @Override public void eventRaised(Event<? extends EventArgs> ev, Object sender, EventArgs args) { if (model.getItems() == null) { return; } Iterator<TagModel> iterator = model.getItems().iterator(); if (iterator.hasNext()) { TagModel root = model.cloneTagModel(iterator.next()); updateDataProvider(Arrays.asList(root)); } } }); <START> model.getPropertyChangedEvent().addListener(new <END> IEventListener<PropertyChangedEventArgs>() { @Override public void eventRaised(Event<? extends PropertyChangedEventArgs> ev, Object sender, PropertyChangedEventArgs args) { if ("SelectedItems".equals(args.propertyName)) { if (getSelectionModel().getSelectedObject() != null) { TagActivationChangeEvent.fire(TagModelProvider.this, findRootNode(getSelectionModel().getSelectedObject())); } } } private TagModel findRootNode(TagModel tagModel) { if (tagModel.getParent() != null) { return findRootNode(tagModel.getParent()); } return tagModel; } }); }</code><technical_language>model.getSelectedItemsChangedEvent()</technical_language>

Target:
protected void initializeModelHandlers(final TagListModel model) { super.initializeModelHandlers(model); model.getResetRequestedEvent().addListener(new IEventListener<EventArgs>() { @Override public void eventRaised(Event<? extends EventArgs> ev, Object sender, EventArgs args) { if (model.getItems() == null) { return; } Iterator<TagModel> iterator = model.getItems().iterator(); if (iterator.hasNext()) { TagModel root = model.cloneTagModel(iterator.next()); updateDataProvider(Arrays.asList(root)); } } }); model.getPropertyChangedEvent().addListener(new IEventListener<PropertyChangedEventArgs>() { @Override public void eventRaised(Event<? extends PropertyChangedEventArgs> ev, Object sender, PropertyChangedEventArgs args) { if ("SelectedItems".equals(args.propertyName)) { if (getSelectionModel().getSelectedObject() != null) { TagActivationChangeEvent.fire(TagModelProvider.this, activeTagList( findRootNode(getSelectionModel().getSelectedObject()))); } } } private TagModel findRootNode(TagModel tagModel) { if (tagModel.getParent() != null) { return findRootNode(tagModel.getParent()); } return tagModel; } private List<TagModel> activeTagList(TagModel model) { List<TagModel> result = new ArrayList<>(); if (model.getSelection()) { result.add(model); } for (TagModel child : model.getChildren()) { result.addAll(activeTagList(child)); } return result; } }); }
Source:
<code>public void validateValue(Reference target, Object providedValue, boolean validate) { if (providedValue == null) { return; } <START> Input<?> input = toInject.get(target); <END> if (input != null) { if (validate && target instanceof GeneratedReference) { validateValue(target, input.value(), providedValue); } toInject.remove(target); } if (ObjectType.ID == target.valueType().id()) { List<Reference> nestedGeneratedReferences = nestedReferenceByTopLevelColumnName.get(target.column().name()); if (nestedGeneratedReferences != null) { @SuppressWarnings("unchecked") Map<String, Object> objectMap = (Map<String, Object>) providedValue; for (var generatedColumn : nestedGeneratedReferences) { ColumnIdent generatedColumnIdent = generatedColumn.column(); assert (generatedColumnIdent.isTopLevel() == false) : "We should be checking only nested columns at this point"; Object byPathValue = Maps.getByPath(objectMap, generatedColumnIdent.path()); validateValue(generatedColumn, byPathValue, true); } } } }</code><technical_language>suggestion Input<?> input = toInject.remove(target); If I read diff correctly currently toInject.remove is called if key is present. is semantically same. add a short note is removed</technical_language>

Target:
public void validateValue(Reference target, Object providedValue, boolean validate) { if (providedValue == null) { return; } Input<?> input = toInject.remove(target); if (input != null) { if (validate && target instanceof GeneratedReference) { validateValue(target, input.value(), providedValue); } } if (ObjectType.ID == target.valueType().id()) { List<Reference> nestedGeneratedReferences = nestedReferenceByTopLevelColumnName.get(target.column().name()); if (nestedGeneratedReferences != null) { @SuppressWarnings("unchecked") Map<String, Object> objectMap = (Map<String, Object>) providedValue; for (var generatedColumn : nestedGeneratedReferences) { ColumnIdent generatedColumnIdent = generatedColumn.column(); assert (generatedColumnIdent.isTopLevel() == false) : "We should be checking only nested columns at this point"; Object byPathValue = Maps.getByPath(objectMap, generatedColumnIdent.path()); validateValue(generatedColumn, byPathValue, true); } } } }
Source:
<code>private ReplicaSet getReplicaSetByLabel(String labelKey, String labelValue) throws IOException { ReplicaSetList rs = openShiftClient .extensions().replicaSets() .inNamespace(this.cheOpenShiftProjectName) .withLabel(labelKey, labelValue) .list(); if (rs.getItems().size() == 0) { <START> LOG.warn("No ReplicaSet with label " + labelKey + "=" + labelValue + " could be found"); <END> throw new IOException("No ReplicaSet with label " + labelKey + "=" + labelValue + " could be found"); } if (rs.getItems().size() > 1) { LOG.warn("Found more than one ReplicaSet with label " + labelKey + "=" + labelValue); throw new IOException("Found more than one ReplicaSet with label " + labelValue + "=" + labelValue); } return rs.getItems().get(0); }</code><technical_language>{} parameters instead of string concatenation</technical_language>

Target:
private ReplicaSet getReplicaSetByLabel(String labelKey, String labelValue) throws IOException { ReplicaSetList replicaSetList = openShiftClient .extensions().replicaSets() .inNamespace(this.openShiftCheProjectName) .withLabel(labelKey, labelValue) .list(); List<ReplicaSet> items = replicaSetList.getItems(); if (items.isEmpty()) { LOG.warn("No ReplicaSet with label {}={} could be found", labelKey, labelValue); throw new IOException("No ReplicaSet with label " + labelKey + "=" + labelValue + " could be found"); } if (items.size() > 1) { LOG.warn("Found more than one ReplicaSet with label {}={}", labelKey, labelValue); throw new IOException("Found more than one ReplicaSet with label " + labelValue + "=" + labelValue); } return items.get(0); }
Source:
<code>public void run() { try { service.executeOutOfBandManagementPowerOperation(host, powerOperation, null); <START> } catch (Exception ignored) { <END> } }</code><technical_language>Log exception WARN indication of a emerging systematic failure</technical_language>

Target:
public void run() { try { service.executeOutOfBandManagementPowerOperation(host, powerOperation, null); } catch (Exception e) { LOG.warn(String.format("Out-of-band management background task operation=%s for host id=%d failed with: %s", powerOperation.name(), host.getId(), e.getMessage())); } }
Source:
<code>public IRadioButton<T> getButtonFor(T value) { for (IRadioButton<T> b : getButtons()) { <START> T radioValue = TypeCastUtility.castValue(b.getRadioValue(), getHolderType()); <END> if (CompareUtility.equals(radioValue, value)) { return b; } } return null; }</code><technical_language>need for casting</technical_language>

Target:
public IRadioButton<T> getButtonFor(T value) { for (IRadioButton<T> b : getButtons()) { T radioValue = b.getRadioValue(); if (CompareUtility.equals(radioValue, value)) { return b; } } return null; }
Source:
<code>protected void abortOldUploads() throws IOException { <START> long oneDay = 1000L * 60 * 60 * 24; <END> try { Date oneDayAgo = new Date(System.currentTimeMillis() - oneDay); transferManager.abortMultipartUploads(bucketName, oneDayAgo); } catch (AmazonServiceException e) { if (e.getStatusCode() == 400 || e.getStatusCode() == 404) { log.warn("Aborting old uploads is not supported by this provider"); return; } throw new IOException("Failed to abort old uploads", e); } }</code><technical_language>following? (I find easier read/understand) suggestion long oneDay = Duration.ofDays(1).toMillis();</technical_language>

Target:
protected void abortOldUploads() throws IOException { long oneDay = Duration.ofDays(1).toMillis(); try { Date oneDayAgo = new Date(System.currentTimeMillis() - oneDay); transferManager.abortMultipartUploads(bucketName, oneDayAgo); } catch (AmazonServiceException e) { if (e.getStatusCode() == 400 || e.getStatusCode() == 404) { log.warn("Aborting old uploads is not supported by this provider"); return; } throw new IOException("Failed to abort old uploads", e); } }
Source:
<code>public void testConcurrentSRems() throws InterruptedException { int ENTRIES = 1000; List<String> masterSet = new ArrayList<>(); for (int i = 0; i < ENTRIES; i++) { masterSet.add("master-" + i); } jedis.sadd("master", masterSet.toArray(new String[] {})); AtomicLong sremmed1 = new AtomicLong(0); Runnable runnable1 = () -> { for (int i = 0; i < ENTRIES; i++) { sremmed1.addAndGet(jedis.srem("master", masterSet.get(i))); Thread.yield(); } }; AtomicLong sremmed2 = new AtomicLong(0); Runnable runnable2 = () -> { <START> for (int i = ENTRIES; i < ENTRIES; i++) { <END> sremmed2.addAndGet(jedis2.srem("master", masterSet.get(i))); Thread.yield(); } }; Thread thread1 = new Thread(runnable1); Thread thread2 = new Thread(runnable2); thread1.start(); thread2.start(); thread1.join(); thread2.join(); assertThat(jedis.smembers("master")).isEmpty(); assertThat(sremmed1.get() + sremmed2.get()).isEqualTo(ENTRIES); }</code><technical_language>This is inadvertent change</technical_language>

Target:
public void testConcurrentSRems() throws InterruptedException { int ENTRIES = 1000; List<String> masterSet = new ArrayList<>(); for (int i = 0; i < ENTRIES; i++) { masterSet.add("master-" + i); } jedis.sadd("master", masterSet.toArray(new String[] {})); AtomicLong sremmed1 = new AtomicLong(0); Runnable runnable1 = () -> { for (int i = 0; i < ENTRIES; i++) { sremmed1.addAndGet(jedis.srem("master", masterSet.get(i))); Thread.yield(); } }; AtomicLong sremmed2 = new AtomicLong(0); Runnable runnable2 = () -> { for (int i = 0; i < ENTRIES; i++) { sremmed2.addAndGet(jedis2.srem("master", masterSet.get(i))); Thread.yield(); } }; Thread thread1 = new Thread(runnable1); Thread thread2 = new Thread(runnable2); thread1.start(); thread2.start(); thread1.join(); thread2.join(); assertThat(jedis.smembers("master")).isEmpty(); assertThat(sremmed1.get() + sremmed2.get()).isEqualTo(ENTRIES); }
Source:
<code><START> public UUID getIncarnationId() { <END> return incarnationId; }</code><technical_language>doc</technical_language>

Target:
UUID getIncarnationId() { return incarnationId; }
Source:
<code>protected List<File> copyBundlesToDeploy(ReloadContext context) throws BundleException { List<File> bundlesToDeploy = new ArrayList<>(); Path homePath = Framework.getRuntime().getHome().toPath(); Path destinationPath = homePath.resolve(context.bundlesDestination); <START> destinationPath.toFile().mkdirs(); <END> try { for (File bundle : context.bundlesToDeploy) { Path bundlePath = bundle.toPath(); if (!bundlePath.startsWith(destinationPath)) { if (bundle.isDirectory()) { bundlePath = ZipUtils.zipDirectory(bundlePath, destinationPath.resolve("hotreload-bundle-" + System.currentTimeMillis() + ".jar"), StandardCopyOption.REPLACE_EXISTING); } else { bundlePath = Files.copy(bundlePath, destinationPath.resolve(bundle.getName()), StandardCopyOption.REPLACE_EXISTING); } } bundlesToDeploy.add(bundlePath.toFile()); } return bundlesToDeploy; } catch (IOException e) { throw new BundleException("Unable to copy bundles to " + destinationPath, e); } }</code><technical_language>Files.createDirectories(destinationPath)</technical_language>

Target:
protected List<File> copyBundlesToDeploy(ReloadContext context) throws BundleException { List<File> bundlesToDeploy = new ArrayList<>(); Path homePath = Framework.getRuntime().getHome().toPath(); Path destinationPath = homePath.resolve(context.bundlesDestination); try { Files.createDirectories(destinationPath); for (File bundle : context.bundlesToDeploy) { Path bundlePath = bundle.toPath(); if (!bundlePath.startsWith(destinationPath)) { if (Files.isDirectory(bundlePath)) { bundlePath = ZipUtils.zipDirectory(bundlePath, destinationPath.resolve("hotreload-bundle-" + System.currentTimeMillis() + ".jar"), StandardCopyOption.REPLACE_EXISTING); } else { bundlePath = Files.copy(bundlePath, destinationPath.resolve(bundle.getName()), StandardCopyOption.REPLACE_EXISTING); } } bundlesToDeploy.add(bundlePath.toFile()); } return bundlesToDeploy; } catch (IOException e) { throw new BundleException("Unable to copy bundles to " + destinationPath, e); } }
Source:
<code>private static void loadExtensions(ModuleService moduleService, Map<String, Object> argMap) { ExtensionsManager extensionsManager = new ExtensionsManager(); Map<String, ExtensionProxy> proxies = moduleService.getContext().get(ModuleService.EXTENSIONS_MAP); List<File> files = (List<File>)argMap.get("extension-file"); if(files == null) { files = listFiles((String)argMap.get("extensions-dir"), "properties"); } for(File f : files) { proxies.put(extensionsManager.load(f), null); } for(String proxy : proxies.keySet()) { extensionsManager.initialize(proxy); <START> proxies.put(proxy, extensionsManager.getExtensionByName(proxy)); <END> } }</code><technical_language>entrySet() setValue()</technical_language>

Target:
private static void loadExtensions(ModuleService moduleService, Map<String, Object> argMap) { ExtensionsManager extensionsManager = new ExtensionsManager(); Map<String, ExtensionProxy> proxies = moduleService.getContext().get(ModuleService.EXTENSIONS_MAP); List<File> files = (List<File>)argMap.get("extension-file"); if(files == null) { files = listFiles((String)argMap.get("extensions-dir"), "properties"); } for(File f : files) { proxies.put(extensionsManager.load(f), null); } for(Map.Entry<String, ExtensionProxy> entry : proxies.entrySet()) { extensionsManager.initialize(entry.getKey()); entry.setValue(extensionsManager.getExtensionByName(entry.getKey())); } }
Source:
<code>public Optional<FieldSortExpectations<Double>> getFieldSortExpectations() { return Optional.of( new FieldSortExpectations<>( 1.01, 3.2, 5.1, <START> Double.MIN_VALUE, 2.0, 4.00001, Double.MAX_VALUE <END> ) ); }</code><technical_language>Remember Double.MIN_VALUE is smallest 0, positive. want slip negative values in there. -Double.MAX_VALUE instead of Double.MIN_VALUE</technical_language>

Target:
public Optional<FieldSortExpectations<Double>> getFieldSortExpectations() { return Optional.of( new FieldSortExpectations<>( 1.01, 3.2, 5.1, -Double.MIN_VALUE, 2.0, 4.00001, Double.MAX_VALUE ) ); }
Source:
<code>public DatasourceService() { <START> metadataDomainRepositoryReal = PentahoSystem.get( IMetadataDomainRepository.class, PentahoSessionHolder.getSession() ); <END> metadataDomainRepository = new PentahoMetadataDomainRepository( getRepository() ); mondrianCatalogService = PentahoSystem.get( IMondrianCatalogService.class, PentahoSessionHolder.getSession() ); repositoryFileAclAdapter = new RepositoryFileAclAdapter(); }</code><technical_language>rarely, never, construct Implementation this. if OEM MetadataDomainRepository needs used? A solution is query for "real" "plain" beans metadataDomainRepositoryReal = PentahoSystem.get( IMetadataDomainRepository.class, "IMetadataDomainRepositoryImpl", PentahoSessionHolder.getSession() ); metadataDomainRepository = PentahoSystem.get( IMetadataDomainRepository.class, "IMetadataDomainRepository", PentahoSessionHolder.getSession() );</technical_language>

Target:
public DatasourceService() { metadataDomainRepository = PentahoSystem.get( IMetadataDomainRepository.class, PentahoSessionHolder.getSession() ); mondrianCatalogService = PentahoSystem.get( IMondrianCatalogService.class, PentahoSessionHolder.getSession() ); repositoryFileAclAdapter = new RepositoryFileAclAdapter(); }
Source:
<code>private String getCurrentHost() { if (Server.isProductionServer()) { <START> if ("".equals(appengineHost.get())) { <END> String applicationVersionId = SystemProperty.applicationVersion.get(); String applicationId = SystemProperty.applicationId.get(); return applicationVersionId + "." + applicationId + ".appspot.com"; } else { return appengineHost.get(); } } else { return "localhost:8888"; } }</code><technical_language>I this return a not-null value, isEmpty() instead of checking equality ""</technical_language>

Target:
private String getCurrentHost() { if (Server.isProductionServer()) { if (StringUtils.isNullOrEmpty(appengineHost.get())) { String applicationVersionId = SystemProperty.applicationVersion.get(); String applicationId = SystemProperty.applicationId.get(); return applicationVersionId + "." + applicationId + ".appspot.com"; } else { return appengineHost.get(); } } else { return "localhost:8888"; } }
Source:
<code>public boolean accept(InputFile inputFile) { if (!Php.KEY.equals(inputFile.language())) { return true; } String property = PhpPlugin.PHP_EXCLUSIONS_KEY; <START> String[] excludedPatterns = this.configuration.getStringArray(property); <END> String relativePath = inputFile.uri().toString(); if (WildcardPattern.match(WildcardPattern.create(excludedPatterns), relativePath)) { LOG.debug("File [" + inputFile.uri() + "] is excluded by '" + property + "' property and will not be analyzed"); return false; } return true; }</code><technical_language>I this stored in a field called for input file. if(excludedPatterns == null) { excludedPatterns = WildcardPattern.create(configuration.getStringArray(property)) } in mind I constant inlined is intermediary variable "property"</technical_language>

Target:
public boolean accept(InputFile inputFile) { if (!Php.KEY.equals(inputFile.language())) { return true; } String relativePath = inputFile.uri().toString(); if (WildcardPattern.match(WildcardPattern.create(excludedPatterns), relativePath)) { LOG.debug("File [" + inputFile.uri() + "] is excluded by '" + PhpPlugin.PHP_EXCLUSIONS_KEY + "' property and will not be analyzed"); return false; } return true; }
Source:
<code>public Project getRootProject() { if (currentResource == null || currentResources == null) { EditorAgent editorAgent = editorAgentProvider.get(); if (editorAgent == null) { return null; } final EditorPartPresenter editor = editorAgent.getActiveEditor(); if (editor == null) { return null; } final VirtualFile file = editor.getEditorInput().getFile(); if (file instanceof SyntheticNode) { final Path projectPath = ((SyntheticNode)file).getProject(); for (Project project : projects) { if (project.getLocation().equals(projectPath)) { return project; } } } } <START> if (currentResources[0] == null) { <END> return null; } Project root = null; for (Project project : projects) { if (project.getLocation().isPrefixOf(currentResources[0].getLocation())) { root = project; } } if (root == null) { return null; } for (int i = 1; i < currentResources.length; i++) { if (!root.getLocation().isPrefixOf(currentResources[i].getLocation())) { return null; } } return root; }</code><technical_language>mean</technical_language>

Target:
public Project getRootProject() { if (currentResource == null || currentResources == null) { EditorAgent editorAgent = editorAgentProvider.get(); if (editorAgent == null) { return null; } final EditorPartPresenter editor = editorAgent.getActiveEditor(); if (editor == null) { return null; } final VirtualFile file = editor.getEditorInput().getFile(); if (file instanceof SyntheticNode) { final Path projectPath = ((SyntheticNode)file).getProject(); for (Project project : projects) { if (project.getLocation().equals(projectPath)) { return project; } } } } if (currentResource == null) { return null; } Project root = null; for (Project project : projects) { if (project.getLocation().isPrefixOf(currentResource.getLocation())) { root = project; } } if (root == null) { return null; } for (int i = 1; i < currentResources.length; i++) { if (!root.getLocation().isPrefixOf(currentResources[i].getLocation())) { return null; } } return root; }
Source:
<code>public void setRefiningChanges(Diff extension, DifferenceKind extensionKind, Diff refiningDiff) { if (extensionKind == DifferenceKind.CHANGE) { extension.getRefinedBy().addAll( Collections2.filter(getAllDifferencesForChange(refiningDiff), <START> EMFComparePredicates .fromSide(extension.getSource()))); <END> } }</code><technical_language>is a static import for EMFComparePredicates.fromSide in this class use</technical_language>

Target:
public void setRefiningChanges(Diff extension, DifferenceKind extensionKind, Diff refiningDiff) { if (extensionKind == DifferenceKind.CHANGE) { extension.getRefinedBy().addAll( Collections2.filter(getAllDifferencesForChange(refiningDiff), fromSide(extension .getSource()))); } }
Source:
<code>protected void addValue(Object value) { if (!_stack.isEmpty()) { DataComplex currItem = _stack.peek(); int currItemSize = -1; if (_isCurrList) { CheckedUtil.addWithoutChecking((DataList) currItem, value); currItemSize = ((DataList) currItem).size(); } else { if (currItem instanceof DataMapBuilder) { DataMapBuilder dataMapBuilder = (DataMapBuilder) currItem; if (dataMapBuilder.smallHashMapThresholdReached()) { _stack.pop(); DataMap dataMap = dataMapBuilder.convertToDataMap(); _stack.push(dataMap); CheckedUtil.putWithoutChecking(dataMap, _currField, value); } else { dataMapBuilder.addKVPair(_currField, value); } } else { CheckedUtil.putWithoutChecking((DataMap) currItem, _currField, value); currItemSize = ((DataMap) currItem).size(); } _currField = null; } <START> if (_currObjSize != -1 && currItemSize != -1 && _currObjSize == currItemSize) { pop(); } <END> else { updateExpected(); } } else { _result = (T) value; _expectedTokens = NONE; } }</code><technical_language>This odd, popping based currObjSize? pop() called END_* tokens processed</technical_language>

Target:
protected void addValue(Object value) { if (!_stack.isEmpty()) { DataComplex currItem = _stack.peek(); if (_isCurrList) { CheckedUtil.addWithoutChecking((DataList) currItem, value); } else { addEntryToDataObject(currItem, _currField, value); _currField = null; } updateExpected(); } }
Source:
<code>public void testUseRowMapperUpdate() throws Exception { dbRule.getJdbi().useHandle(handle -> { <START> handle.execute("drop table something"); <END> handle.execute("create table something (id serial, name varchar(50), created_on timestamp default now())"); UseRowMapperDao dao = handle.attach(UseRowMapperDao.class); IdCreateTime result = dao.insert("foo"); assertThat(result.id).isEqualTo(1); assertThat(result.createdOn).isNotNull(); }); }</code><technical_language>move code for recreating table setUp block avoid duplication</technical_language>

Target:
public void testUseRowMapperUpdate() throws Exception { dbRule.getJdbi().useExtension(UseRowMapperDao.class, dao -> { dao.createTable(); IdCreateTime result = dao.insert("foo"); assertThat(result.id).isEqualTo(1); assertThat(result.createdOn).isNotNull(); }); }
Source:
<code>public void init() { view.init(this); view.initWidgets(queryTarget.view, serverTemplateId.view, dataSource.view, dbSQL.view); queryTarget.setSelectHint(KieServerClientConstants.INSTANCE.remote_query_target_hint()); <START> List<DropDownEditor.Entry> entries = Stream.of("CUSTOM", <END> "PROCESS", "TASK", "BA_TASK", "PO_TASK", "JOBS", "FILTERED_PROCESS", "FILTERED_BA_TASK", "FILTERED_PO_TASK") .map(s -> queryTarget.newEntry(s, s)).collect(Collectors.toList()); queryTarget.setEntries(entries); queryTarget.addHelpContent(KieServerClientConstants.INSTANCE.remote_query_target(), KieServerClientConstants.INSTANCE.remote_query_target_description(), Placement.RIGHT); serverTemplateId.setSelectHint(KieServerClientConstants.INSTANCE.remote_server_template_hint()); kieServerConnectionInfoProvider.call((List<String> serverTemplates) -> onServerTemplateLoad(serverTemplates)).serverTemplates(); serverTemplateId.addHelpContent(KieServerClientConstants.INSTANCE.remote_server_template(), KieServerClientConstants.INSTANCE.remote_server_template_description(), Placement.RIGHT); dataSource.addHelpContent(KieServerClientConstants.INSTANCE.remote_data_set_editor(), KieServerClientConstants.INSTANCE.remote_datasource_description(), Placement.BOTTOM); dbSQL.addHelpContent(KieServerClientConstants.INSTANCE.remote_data_set_editor(), KieServerClientConstants.INSTANCE.remote_datasource_description(), Placement.BOTTOM); }</code><technical_language>strings require i18n</technical_language>

Target:
public void init() { view.init(this); view.initWidgets(queryTarget.view, serverTemplateId.view, dataSource.view, dbSQL.view); queryTarget.setSelectHint(KieServerClientConstants.INSTANCE.remoteQueryTargetHint()); List<DropDownEditor.Entry> entries = Stream.of("CUSTOM", "PROCESS", "TASK", "BA_TASK", "PO_TASK", "JOBS", "FILTERED_PROCESS", "FILTERED_BA_TASK", "FILTERED_PO_TASK") .map(s -> queryTarget.newEntry(s, s)).collect(Collectors.toList()); queryTarget.setEntries(entries); queryTarget.addHelpContent(KieServerClientConstants.INSTANCE.remoteQueryTarget(), KieServerClientConstants.INSTANCE.remoteQueryTargetDescription(), Placement.RIGHT); serverTemplateId.setSelectHint(KieServerClientConstants.INSTANCE.remoteServerTemplateHint()); kieServerConnectionInfoProvider.call((List<String> serverTemplates) -> onServerTemplateLoad(serverTemplates)).serverTemplates(); serverTemplateId.addHelpContent(KieServerClientConstants.INSTANCE.remoteServerTemplate(), KieServerClientConstants.INSTANCE.remoteServerTemplateDescription(), Placement.RIGHT); dataSource.addHelpContent(KieServerClientConstants.INSTANCE.remoteDataSetEditor(), KieServerClientConstants.INSTANCE.remoteDatasourceDescription(), Placement.BOTTOM); dbSQL.addHelpContent(KieServerClientConstants.INSTANCE.remoteDataSetEditor(), KieServerClientConstants.INSTANCE.remoteDatasourceDescription(), Placement.BOTTOM); }
Source:
<code>public void stop() { synchronized (startStopLock) { running = false; taskStatusChecker.shutdownNow(); if (numRunningTasks > 0) { final Iterator<MonitorEntry> iterator = runningTasks.values().iterator(); while (iterator.hasNext()) { final MonitorEntry entry = iterator.next(); iterator.remove(); final String taskId = entry.runningTask.getId(); <START> log.info("Request to kill subtask[%s]", taskId); <END> indexingServiceClient.cancelTask(taskId); numRunningTasks--; numKilledTasks++; } if (numRunningTasks > 0) { log.warn( "Inconsistent state: numRunningTasks[%d] is still not zero after trying to kill all running tasks.", numRunningTasks ); } } log.info("Stopped taskMonitor"); } }</code><technical_language>rename log line cancel task instead of kill</technical_language>

Target:
public void stop() { synchronized (startStopLock) { if (running) { running = false; taskStatusChecker.shutdownNow(); synchronized (taskCountLock) { if (numRunningTasks > 0) { final Iterator<MonitorEntry> iterator = runningTasks.values().iterator(); while (iterator.hasNext()) { final MonitorEntry entry = iterator.next(); iterator.remove(); final String taskId = entry.runningTask.getId(); log.info("Request to cancel subtask[%s]", taskId); indexingServiceClient.cancelTask(taskId); numRunningTasks--; numCanceledTasks++; } if (numRunningTasks > 0) { log.warn( "Inconsistent state: numRunningTasks[%d] is still not zero after trying to cancel all running tasks.", numRunningTasks ); } } } log.info("Stopped taskMonitor"); } } }
Source:
<code>ChangeAndCommit(@Nullable Change change, @Nullable PatchSet ps, RevCommit c) { if (change != null) { changeId = change.getKey().get(); _changeNumber = change.getChangeId(); _revisionNumber = ps != null ? ps.getPatchSetId() : null; PatchSet.Id curr = change.currentPatchSetId(); _currentRevisionNumber = curr != null ? curr.get() : null; } commit = new CommitInfo(); commit.commit = c.name(); commit.parents = Lists.newArrayListWithCapacity(c.getParentCount()); for (int i = 0; i < c.getParentCount(); i++) { CommitInfo p = new CommitInfo(); p.commit = c.getParent(i).name(); commit.parents.add(p); } commit.author = toGitPerson(c.getAuthorIdent()); commit.subject = c.getShortMessage(); IncludedInDetail detail = new IncludedInDetail(); try { <START> detail = resolveBranches(c); <END> } catch (Exception e) { e.printStackTrace(); } branches = detail.getBranches(); }</code><technical_language>This is unnecessarily slow change != null branch name change object</technical_language>

Target:
ChangeAndCommit(@Nullable Change change, @Nullable PatchSet ps, RevCommit c) throws RepositoryNotFoundException, IOException, OrmException { if (change != null) { changeId = change.getKey().get(); _changeNumber = change.getChangeId(); _revisionNumber = ps != null ? ps.getPatchSetId() : null; PatchSet.Id curr = change.currentPatchSetId(); _currentRevisionNumber = curr != null ? curr.get() : null; } commit = new CommitInfo(); commit.commit = c.name(); commit.parents = Lists.newArrayListWithCapacity(c.getParentCount()); for (int i = 0; i < c.getParentCount(); i++) { CommitInfo p = new CommitInfo(); p.commit = c.getParent(i).name(); commit.parents.add(p); } commit.author = toGitPerson(c.getAuthorIdent()); commit.subject = c.getShortMessage(); IncludedInDetail detail = new IncludedInDetail(); detail = resolveBranches(c); branches = detail.getBranches().size() != 0 ? detail.getBranches() : null; }
Source:
<code>protected void onCreate(Bundle savedInstanceState) { super.onCreate(savedInstanceState); setContentView(R.layout.activity_main); ButterKnife.bind(this); preferencesManager = new PreferencesManager(this); newListInput.setHint(R.string.add_list_hint); noContent.setText(R.string.no_lists_message); plus.setImageDrawable(new IconDrawable(this, IoniconsIcons.ion_android_add).colorRes(R.color.white)); importFile.setImageDrawable(new IconDrawable( this, IoniconsIcons.ion_android_upload).colorRes(R.color.white)); <START> nameListsAdapter = new NameListsAdapter(this,this, noContent); <END> recyclerView.setAdapter(nameListsAdapter); if (preferencesManager.getFirstTimeUser()) { preferencesManager.setFirstTimeUser(false); new MaterialDialog.Builder(this) .title(R.string.view_tutorial) .content(R.string.tutorial_prompt) .positiveText(R.string.accept_tutorial) .negativeText(R.string.no_im_good) .onPositive((dialog, which) -> showTutorial(true)) .show(); } if (preferencesManager.rememberAppOpen() == 5) { showPleaseRateDialog(); } }</code><technical_language>nit: end changing this leaving a reminder space this get here. suggestion nameListsAdapter = new NameListsAdapter(this, this, noContent);</technical_language>

Target:
protected void onCreate(Bundle savedInstanceState) { super.onCreate(savedInstanceState); setContentView(R.layout.activity_main); ButterKnife.bind(this); preferencesManager = new PreferencesManager(this); plus.setImageDrawable(new IconDrawable(this, IoniconsIcons.ion_android_add).colorRes(R.color.white)); importFile.setImageDrawable(new IconDrawable( this, IoniconsIcons.ion_android_upload).colorRes(R.color.white)); nameListsAdapter = new NameListsAdapter(this, this, noContent); recyclerView.setAdapter(nameListsAdapter); if (preferencesManager.getFirstTimeUser()) { preferencesManager.setFirstTimeUser(false); new MaterialDialog.Builder(this) .title(R.string.view_tutorial) .content(R.string.tutorial_prompt) .positiveText(R.string.accept_tutorial) .negativeText(R.string.no_im_good) .onPositive((dialog, which) -> showTutorial(true)) .show(); } if (preferencesManager.rememberAppOpen() == 5) { showPleaseRateDialog(); } }
Source:
<code>public void shouldMapListToCollection() { Source source = new Source(); <START> source.setIntegerList( Arrays.asList( 1, 2 ).stream() ); <END> Target target = SourceTargetMapper.INSTANCE.sourceToTarget( source ); assertThat( target ).isNotNull(); assertThat( target.getIntegerCollection() ).containsOnly( 1, 2 ); }</code><technical_language>setIntegerList=setIntegerStream</technical_language>

Target:
public void shouldMapListToCollection() { Source source = new Source(); source.setIntegerStream( Arrays.asList( 1, 2 ).stream() ); Target target = SourceTargetMapper.INSTANCE.sourceToTarget( source ); assertThat( target ).isNotNull(); assertThat( target.getIntegerCollection() ).containsOnly( 1, 2 ); }
Source:
<code>public void registerContribution(Object contribution, String extensionPoint, ComponentInstance contributor) { <START> if (extensionPoint.equals(CODEC_XP)) { <END> CodecDescriptor descriptor = (CodecDescriptor) contribution; configs.put(descriptor.getName(), descriptor); log.debug(String.format("Register Codec contribution: %s", descriptor)); codecs.put(descriptor.getName(), descriptor.getInstance()); } }</code><technical_language>I propose in PR a more dynamic check extensionPoint, do ? I fact if do change in descriptor this code automatically follow</technical_language>

Target:
public void registerContribution(Object contribution, String extensionPoint, ComponentInstance contributor) { if (extensionPoint.equals(CODEC_XP)) { CodecDescriptor descriptor = (CodecDescriptor) contribution; configs.put(descriptor.getName(), descriptor); log.debug(String.format("Register Codec contribution: %s", descriptor)); codecFactories.put(descriptor.getName(), descriptor.getInstance()); } }
Source:
<code>protected void initialize(final IResource resource, final String path, final Class<? extends ITmfEvent> type) throws TmfTraceException { if (path == null) { throw new TmfTraceException("Invalid trace path"); } fPath = path; fResource = resource; String traceName = getName(); if (traceName.isEmpty()) { traceName = (resource != null) ? resource.getName() : new Path(path).lastSegment(); } if (fParser == null) { if (this instanceof ITmfEventParser) { fParser = (ITmfEventParser) this; } else { throw new TmfTraceException("Invalid trace parser"); } } super.init(traceName, type); @SuppressWarnings("null") @NonNull Class<? extends TmfTrace> className = this.getClass(); Map<String, IAnalysisModuleHelper> modules = TmfAnalysisManager.getAnalysisModules(className); for (IAnalysisModuleHelper helper : modules.values()) { try { <START> IAnalysisModule module = helper.newModule(this); <END> fAnalysisModules.put(module.getId(), module); } catch (TmfAnalysisException e) { Activator.logWarning("Could not initialize analysis module " + e.getMessage()); } } TmfSignalManager.registerVIP(this); if (fIndexer != null) { fIndexer.dispose(); } fIndexer = createIndexer(fCacheSize); }</code><technical_language>this slow</technical_language>

Target:
protected void initialize(final IResource resource, final String path, final Class<? extends ITmfEvent> type) throws TmfTraceException { if (path == null) { throw new TmfTraceException("Invalid trace path"); } fPath = path; fResource = resource; String traceName = getName(); if (traceName.isEmpty()) { traceName = (resource != null) ? resource.getName() : new Path(path).lastSegment(); } if (fParser == null) { if (this instanceof ITmfEventParser) { fParser = (ITmfEventParser) this; } else { throw new TmfTraceException("Invalid trace parser"); } } super.init(traceName, type); Class<? extends TmfTrace> className = checkNotNull(this.getClass()); Map<String, IAnalysisModuleHelper> modules = TmfAnalysisManager.getAnalysisModules(className); for (IAnalysisModuleHelper helper : modules.values()) { try { IAnalysisModule module = helper.newModule(this); fAnalysisModules.put(module.getId(), module); } catch (TmfAnalysisException e) { Activator.logWarning("Could not initialize analysis module " + e.getMessage()); } } TmfSignalManager.registerVIP(this); if (fIndexer != null) { fIndexer.dispose(); } fIndexer = createIndexer(fCacheSize); }