auphong2707/dl4se-code-review-dataset huggingface dataset:
Source:
<code>private void initCommentVisibilityStrategy(Button expandAll, Button collapseAll) { CommentVisibilityStrategy commentVisibilityStrategy = CommentVisibilityStrategy.EXPAND_RECENT; if (Gerrit.isSignedIn()) { commentVisibilityStrategy = Gerrit.getUserAccount() .getGeneralPreferences().getCommentVisibilityStrategy(); } <START> long AGE = 7 * 24 * 60 * 60 * 1000L; <END> Timestamp aged = new Timestamp(System.currentTimeMillis() - AGE); int n = getWidgetCount(); for (int i = 0; i < n; i++) { Message msg = (Message) getWidget(i); boolean isRecent; if (i == n - 1) { isRecent = true; } else { isRecent = msg.getMessageInfo().date().after(aged); } boolean isOpen = false; switch (commentVisibilityStrategy) { case COLLAPSE_ALL: break; case EXPAND_ALL: isOpen = true; break; case EXPAND_MOST_RECENT: isOpen = i == n - 1; break; case EXPAND_RECENT: default: isOpen = isRecent; break; } msg.setOpen(isOpen); } if (commentVisibilityStrategy == COLLAPSE_ALL) { expandAll.setVisible(true); collapseAll.setVisible(false); } else if (commentVisibilityStrategy == EXPAND_ALL) { expandAll.setVisible(false); collapseAll.setVisible(true); } }</code><technical_language>I java supports some constants for this</technical_language>

Target:
private void initCommentVisibilityStrategy(Button expandAll, Button collapseAll) { CommentVisibilityStrategy commentVisibilityStrategy = CommentVisibilityStrategy.EXPAND_RECENT; if (Gerrit.isSignedIn()) { commentVisibilityStrategy = Gerrit.getUserAccount() .getGeneralPreferences().getCommentVisibilityStrategy(); } Timestamp aged = new Timestamp(System.currentTimeMillis() - AGE); int n = getWidgetCount(); for (int i = 0; i < n; i++) { Message msg = (Message) getWidget(i); boolean isRecent = (i == n - 1) ? true : msg.getMessageInfo().date().after(aged); boolean isOpen = false; switch (commentVisibilityStrategy) { case COLLAPSE_ALL: break; case EXPAND_ALL: isOpen = true; break; case EXPAND_MOST_RECENT: isOpen = i == n - 1; break; case EXPAND_RECENT: default: isOpen = isRecent; break; } msg.setOpen(isOpen); } if (commentVisibilityStrategy == COLLAPSE_ALL) { expandAll.setVisible(true); collapseAll.setVisible(false); } else if (commentVisibilityStrategy == EXPAND_ALL) { expandAll.setVisible(false); collapseAll.setVisible(true); } }
Source:
<code>@Override public Object evaluate(DeferredObject[] arguments) throws HiveException { <START> assert (arguments.length == 2); <END> if (arguments[0].get() == null || arguments[1].get() == null) { return null; } Text s = (Text) converters[0].convert(arguments[0].get()); ArrayList<Text> result = new ArrayList<Text>(); int index = 0; Map<Integer, String> privs = privsMap.getPrivilegeMap(); if (constPattern == null) { Text regex = (Text) converters[1].convert(arguments[1].get()); for (String str : s.toString().split(regex.toString(), -1)) { if ("1".equals(str)) { result.add(new Text(privs.get(index))); } index++; } } else { for (String str : constPattern.split(s.toString(), -1)) { if ("1".equals(str)) { result.add(new Text(privs.get(index))); } index++; } } return result; }</code><technical_language>if a constant ..then user give arguemnt</technical_language>

Target:
@Override public Object evaluate(DeferredObject[] arguments) throws HiveException { assert (arguments.length == 1); if (arguments[0].get() == null) { return null; } Text s = (Text) converters[0].convert(arguments[0].get()); ArrayList<Text> result = new ArrayList<Text>(); int index = 0; Map<Integer, String> privs = privsMap.getPrivilegeMap(); for (String str : s.toString().split(" ", -1)) { if ("1".equals(str)) { result.add(new Text(privs.get(index))); } index++; } return result; }
Source:
<code>public ServerResponse preProcess(HttpRequest request, ResourceMethod method) throws Failure, WebApplicationException { HttpSession httpSession = null; ServerResponse response = null; boolean successful = false; HttpHeaders headers = request.getHttpHeaders(); boolean preferPersistentAuth = checkPersistentAuthentication(headers); boolean hasAuthorizationHeader = checkAuthorizationHeader(headers); Integer customHttpSessionTtl = getCustomHttpSessionTtl(headers); httpSession = getCurrentSession(false); <START> if (validator != null && httpSession != null && !httpSession.isNew() && !hasAuthorizationHeader) { <END> successful = executeSessionValidation(httpSession, preferPersistentAuth); } else { if (validator != null && httpSession != null && !httpSession.isNew()) { httpSession.invalidate(); httpSession = getCurrentSession(true); } String engineSessionId = SessionUtils.generateEngineSessionId(); successful = executeBasicAuthentication(headers, engineSessionId, preferPersistentAuth); if (successful && httpSession == null) { httpSession = getCurrentSession(true); } if (httpSession != null) { SessionUtils.setEngineSessionId(httpSession, engineSessionId); } if (successful && preferPersistentAuth) { if (httpSession != null && customHttpSessionTtl != null) { httpSession.setMaxInactiveInterval( customHttpSessionTtl.intValue() * SECONDS_IN_MINUTE); } } } if (!successful) { response = challenge(); if (httpSession != null) { httpSession.invalidate(); } } return response; }</code><technical_language>I httpSession.isNew removed, session new, pass "false" getCurrentSession. correct</technical_language>

Target:
public ServerResponse preProcess(HttpRequest request, ResourceMethod method) throws Failure, WebApplicationException { HttpSession httpSession = null; ServerResponse response = null; boolean successful = false; HttpHeaders headers = request.getHttpHeaders(); boolean preferPersistentAuth = checkPersistentAuthentication(headers); boolean hasAuthorizationHeader = checkAuthorizationHeader(headers); Integer customHttpSessionTtl = getCustomHttpSessionTtl(headers); httpSession = getCurrentSession(false); if (validator != null && httpSession != null && !hasAuthorizationHeader) { successful = executeSessionValidation(httpSession, preferPersistentAuth); } else { if (validator != null && httpSession != null) { httpSession.invalidate(); httpSession = getCurrentSession(true); } String engineSessionId = SessionUtils.generateEngineSessionId(); successful = executeBasicAuthentication(headers, engineSessionId, preferPersistentAuth); if (successful && preferPersistentAuth) { if (httpSession == null) { httpSession = getCurrentSession(true); } if (httpSession != null && customHttpSessionTtl != null) { httpSession.setMaxInactiveInterval( customHttpSessionTtl.intValue() * SECONDS_IN_MINUTE); } } if (successful && httpSession != null) { SessionUtils.setEngineSessionId(httpSession, engineSessionId); } } if (!successful) { response = challenge(); if (httpSession != null) { httpSession.invalidate(); } } return response; }
Source:
<code>public @ResponseBody CertifiedProductSearchDetails getCertifiedProductByChplProductNumberBasic( @PathVariable("year") final String year, @PathVariable("testingLab") final String testingLab, @PathVariable("certBody") final String certBody, @PathVariable("vendorCode") final String vendorCode, @PathVariable("productCode") final String productCode, @PathVariable("versionCode") final String versionCode, @PathVariable("icsCode") final String icsCode, @PathVariable("addlSoftwareCode") final String addlSoftwareCode, @PathVariable("certDateCode") final String certDateCode) throws EntityRetrievalException { String chplProductNumber = chplProductNumberUtil.getChplProductNumber(year, testingLab, certBody, vendorCode, productCode, versionCode, icsCode, addlSoftwareCode, certDateCode); CertifiedProductSearchDetails certifiedProduct = cpdManager.getCertifiedProductDetailsBasicByChplProductNumber(chplProductNumber); <START> certifiedProduct = validateCertifiedProduct(certifiedProduct); <END> removeNonBasicCertifiedProductSearchDetails(certifiedProduct); return certifiedProduct; }</code><technical_language>validate this product next line removes warning/error messages</technical_language>

Target:
CertifiedProductSearchBasicDetails getCertifiedProductByChplProductNumberBasic( @PathVariable("year") final String year, @PathVariable("testingLab") final String testingLab, @PathVariable("certBody") final String certBody, @PathVariable("vendorCode") final String vendorCode, @PathVariable("productCode") final String productCode, @PathVariable("versionCode") final String versionCode, @PathVariable("icsCode") final String icsCode, @PathVariable("addlSoftwareCode") final String addlSoftwareCode, @PathVariable("certDateCode") final String certDateCode) throws EntityRetrievalException { String chplProductNumber = chplProductNumberUtil.getChplProductNumber(year, testingLab, certBody, vendorCode, productCode, versionCode, icsCode, addlSoftwareCode, certDateCode); CertifiedProductSearchDetails certifiedProduct = cpdManager.getCertifiedProductDetailsBasicByChplProductNumber(chplProductNumber); return mapCertifiedProductDetailsToBasic.apply(certifiedProduct); }
Source:
<code>synchronized LocalHub getLocalServerComponent() { if (instance == null) { instance = new LocalHub(); instance.setHost(new NetworkUtils().getIpOfLoopBackIp4()); int configHubPort = Integer.parseInt(Config.getConfigProperty(ConfigProperty.SELENIUM_PORT)); int hubPort = PortProber.pollPort(configHubPort) ? configHubPort : PortProber.findFreePort(); <START> instance.setPort(hubPort); <END> LauncherOptions launcherOptions = new LauncherOptionsImpl() .setFileDownloadCheckTimeStampOnInvocation(false).setFileDownloadCleanupOnInvocation(false); instance.setLauncher(new ThreadedLauncher(new String[] { "-role", "hub", "-port", String.valueOf(instance.getPort()), "-host", instance.getHost() }, launcherOptions)); } return instance; }</code><technical_language>update of property SELENIUM_PORT if 4444</technical_language>

Target:
synchronized LocalHub getLocalServerComponent() { if (instance == null) { instance = new LocalHub(); instance.setHost(new NetworkUtils().getIpOfLoopBackIp4()); int hubPort = PortProber.findFreePort(); instance.setPort(hubPort); Config.setConfigProperty(ConfigProperty.SELENIUM_PORT, Integer.toString(hubPort)); LauncherOptions launcherOptions = new LauncherOptionsImpl() .setFileDownloadCheckTimeStampOnInvocation(false).setFileDownloadCleanupOnInvocation(false); instance.setLauncher(new ThreadedLauncher(new String[] { "-role", "hub", "-port", String.valueOf(instance.getPort()), "-host", instance.getHost() }, launcherOptions)); } return instance; }
Source:
<code>private Datum generateDatum(final State state, final Integer position, final Random rdn) { final double[] logEmissionProbs = new double[State.values().length]; for (int i = 0; i < logEmissionProbs.length; i++) { logEmissionProbs[i] = logEmissionProbability(Datum.values()[i], state, position); } final double total = Math.exp(MathUtils.approximateLogSumLog(logEmissionProbs)); final double uniform = rdn.nextDouble() * total; double accumulate = 0; for (int i = 0; i < Datum.values().length; i++) { accumulate += Math.exp(logEmissionProbs[i]); if (uniform < accumulate) { return Datum.values()[i]; } } <START> throw new IllegalStateException("may be some of the emission probs is negative?"); <END> }</code><technical_language>negative</technical_language>

Target:
private Datum generateDatum(final State state, final Integer position, final Random rdn) { final double[] logEmissionProbs = new double[State.values().length]; for (int i = 0; i < logEmissionProbs.length; i++) { logEmissionProbs[i] = logEmissionProbability(Datum.values()[i], state, position); } final double total = Math.exp(MathUtils.approximateLogSumLog(logEmissionProbs)); final double uniform = rdn.nextDouble() * total; double accumulate = 0; for (int i = 0; i < Datum.values().length; i++) { accumulate += Math.exp(logEmissionProbs[i]); if (uniform < accumulate) { return Datum.values()[i]; } } throw new IllegalStateException("may be some of the emission probs are negative?"); }
Source:
<code>private boolean isDescendantOf(Change.Id child, RevId ancestor) throws OrmException { ReviewDb db = dbProvider.get(); ArrayList<RevId> parents = new <START> ArrayList<RevId>(); <END> parents.add(ancestor); while (!parents.isEmpty()) { RevId parent = parents.remove(0); for (PatchSetAncestor desc : db.patchSetAncestors().descendantsOf(parent)) { PatchSet descPatchSet = db.patchSets().get(desc.getPatchSet()); Change.Id descChangeId = descPatchSet.getId().getParentKey(); if (child.equals(descChangeId)) { PatchSet.Id descCurrentPatchSetId = db.changes().get(descChangeId).currentPatchSetId(); return descPatchSet.getId().equals(descCurrentPatchSetId); } else { parents.add(descPatchSet.getRevision()); } } } return false; }</code><technical_language>In Java 7 this is necessary a "redundant specification of type argument" warning</technical_language>

Target:
private boolean isDescendantOf(Change.Id child, RevId ancestor) throws OrmException { ReviewDb db = dbProvider.get(); ArrayList<RevId> parents = new ArrayList<>(); parents.add(ancestor); while (!parents.isEmpty()) { RevId parent = parents.remove(0); for (PatchSetAncestor desc : db.patchSetAncestors().descendantsOf(parent)) { PatchSet descPatchSet = db.patchSets().get(desc.getPatchSet()); Change.Id descChangeId = descPatchSet.getId().getParentKey(); if (child.equals(descChangeId)) { PatchSet.Id descCurrentPatchSetId = db.changes().get(descChangeId).currentPatchSetId(); return descPatchSet.getId().equals(descCurrentPatchSetId); } else { parents.add(descPatchSet.getRevision()); } } } return false; }
Source:
<code>private void checkThreadLocalField(Symbol field) { if (field.usages().stream().noneMatch(ThreadLocalCleanupCheck::usageIsRemove)) { <START> reportIssue(((VariableTree) field.declaration()).simpleName(), "Call the \"remove()\" on \"" + field.name() + "\" in a \"finally\" block."); <END> } }</code><technical_language>Call "remove()" ... ? This sound English me. of these: * Call "remove()" ... * Call method "remove()" on... * Call "remove()" method on..</technical_language>

Target:
private void checkThreadLocalField(Symbol field) { if (field.usages().stream().noneMatch(ThreadLocalCleanupCheck::usageIsRemove)) { reportIssue(((VariableTree) field.declaration()).simpleName(), "Call \"remove()\" on \"" + field.name() + "\"."); } }
Source:
<code>public boolean replace(Chain expected, Chain replacement) { if (expected.isEmpty()) { if (replacement.isEmpty()) { return true; } else { <START> insertHeader(replacement); <END> return true; } } else if (replacement.isEmpty()) { return removeHeader(expected); } else { return replaceHeader(expected, replacement); } }</code><technical_language>Feels wrong high level data structure discussion replace perform prepend</technical_language>

Target:
public boolean replace(Chain expected, Chain replacement) { if (expected.isEmpty()) { throw new IllegalArgumentException("Empty expected sequence"); } else if (replacement.isEmpty()) { return removeHeader(expected); } else { return replaceHeader(expected, replacement); } }
Source:
<code>protected static ServiceTypeResolver findService(BrooklynClassLoadingContext context, String type) { <START> String prefix = Splitter.on(":").splitToList(type).get(0); <END> ServiceLoader<ServiceTypeResolver> loader = ServiceLoader.load(ServiceTypeResolver.class, context.getManagementContext().getCatalog().getRootClassLoader()); for (ServiceTypeResolver resolver : loader) { if (prefix.equalsIgnoreCase(resolver.getTypePrefix())) return resolver; } return null; }</code><technical_language>do if (type.indexOf(':')==-1) return null; ? in case type matches a prefix is :</technical_language>

Target:
protected static ServiceTypeResolver findService(BrooklynClassLoadingContext context, String type) { if (type.indexOf(':') != -1) { String prefix = Splitter.on(":").splitToList(type).get(0); ServiceLoader<ServiceTypeResolver> loader = ServiceLoader.load(ServiceTypeResolver.class, context.getManagementContext().getCatalog().getRootClassLoader()); for (ServiceTypeResolver resolver : loader) { if (prefix.equals(resolver.getTypePrefix())) { return resolver; } } } return null; }
Source:
<code>private List<Object> extractHits(ProjectionHitMapper<?, ?> projectionHitMapper, IndexSearcher indexSearcher, TopDocs topDocs, SearchProjectionExtractContext projectionExecutionContext) throws IOException { if ( topDocs == null ) { return Collections.emptyList(); <START> } <END> List<Object> extractedData = new ArrayList<>( topDocs.scoreDocs.length ); Map<Integer, Set<Integer>> nestedDocs = fetchNestedDocs( indexSearcher, topDocs.scoreDocs ); for ( ScoreDoc hit : topDocs.scoreDocs ) { indexSearcher.doc( hit.doc, storedFieldVisitor ); Set<Integer> children = nestedDocs.get( hit.doc ); if ( children != null ) { for ( Integer child : children ) { indexSearcher.doc( child, storedFieldVisitor ); } } Document document = storedFieldVisitor.getDocumentAndReset(); LuceneResult luceneResult = new LuceneResult( document, hit.doc, hit.score ); extractedData.add( rootProjection.extract( projectionHitMapper, luceneResult, projectionExecutionContext ) ); } return extractedData; }</code><technical_language>Good idea</technical_language>

Target:
private List<Object> extractHits(ProjectionHitMapper<?, ?> projectionHitMapper, IndexSearcher indexSearcher, TopDocs topDocs, SearchProjectionExtractContext projectionExecutionContext) throws IOException { if ( topDocs == null ) { return Collections.emptyList(); } List<Object> extractedData = new ArrayList<>( topDocs.scoreDocs.length ); Map<Integer, Set<Integer>> nestedDocs = fetchNestedDocs( indexSearcher, topDocs.scoreDocs, projectionExecutionContext ); for ( ScoreDoc hit : topDocs.scoreDocs ) { indexSearcher.doc( hit.doc, storedFieldVisitor ); if ( nestedDocs.containsKey( hit.doc ) ) { for ( Integer child : nestedDocs.get( hit.doc ) ) { indexSearcher.doc( child, storedFieldVisitor ); } } Document document = storedFieldVisitor.getDocumentAndReset(); LuceneResult luceneResult = new LuceneResult( document, hit.doc, hit.score ); extractedData.add( rootProjection.extract( projectionHitMapper, luceneResult, projectionExecutionContext ) ); } return extractedData; }
Source:
<code>private static void setIfNotNullOrEmpty( MongoProperties.Builder builder, MongoProp prop, String value ) { if ( value != null && value.trim().length() > 0 ) { boolean isPassword = MongoProp.PASSWORD.equals( prop ); <START> boolean isEncrypted = value.startsWith( Encr.PASSWORD_ENCRYPTED_PREFIX ); <END> if ( isPassword && isEncrypted ) { value = Encr.decryptPasswordOptionallyEncrypted( value ); } builder.set( prop, value ); } }</code><technical_language>do this line - handled ...Optionally... bit in Encr class. <LINK_0></technical_language>

Target:
private static void setIfNotNullOrEmpty( MongoProperties.Builder builder, MongoProp prop, String value ) { if ( value != null && value.trim().length() > 0 ) { boolean isPassword = MongoProp.PASSWORD.equals( prop ); if ( isPassword ) { value = Encr.decryptPasswordOptionallyEncrypted( value ); } builder.set( prop, value ); } }
Source:
<code><START> public Set<PyKeyValuePairTree> elements() { <END> return elements; }</code><technical_language>A set a good choice in terms of API : order is guaranteed for API user in case of AST order of elements matters</technical_language>

Target:
public List<PyKeyValuePairTree> elements() { return elements; }
Source:
<code><START> String encode(String plainMessage, int keyA, int keyB) { <END> return splitIntoFiveLetterWords( translate(plainMessage, keyA, keyB, 0)); }</code><technical_language>I put methods package private Generally I put more accessible methods opening file</technical_language>

Target:
String encode(String plainMessage, int keyA, int keyB) { return splitIntoFiveLetterWords( translate(plainMessage, keyA, keyB, Mode.ENCODE)); }
Source:
<code>private void changeUIStateToListening() { voiceIcon.setText(R.string.voice_icon_recognizer_white); voiceIcon.setBackgroundResource(R.drawable.recognizable_voice_blue); message.setText(R.string.list_name_input_speech_message); <START> tryAgain.setVisibility(View.INVISIBLE); <END> }</code><technical_language>set this View.GONE instead? avoid INVISIBLE if view takes space puts out a click hitbox, lead weird experiences</technical_language>

Target:
private void changeUIStateToListening() { voiceIcon.setText(R.string.voice_icon_recognizer_white); voiceIcon.setBackgroundResource(R.drawable.recognizable_voice_blue); message.setText(R.string.list_name_input_speech_message); tryAgain.setVisibility(View.GONE); }
Source:
<code>public Map<String, String> getDomainAsMap() { String domain = getDomainAsString(); Map<String, String> domainAsMap = new HashMap<>(); if (domain == null || domain.isEmpty()) { return domainAsMap; } String[] pathPairs = domain.trim().split(","); for (String pair : pathPairs) { String[] values = pair.trim().split("="); if (values.length != 2 || values[0].isEmpty() || values[1].isEmpty()) { throw new IllegalArgumentException( String.format("Domain-Value pair %s is not valid.", pair)); } <START> domainAsMap.put(values[0], values[1]); <END> } return domainAsMap; }</code><technical_language>trim final values level layers. do think</technical_language>

Target:
public Map<String, String> getDomainAsMap() { String domain = getDomainAsString(); Map<String, String> domainAsMap = new HashMap<>(); if (domain == null || domain.isEmpty()) { return domainAsMap; } String[] pathPairs = domain.trim().split(","); for (String pair : pathPairs) { String[] values = pair.split("="); if (values.length != 2 || values[0].isEmpty() || values[1].isEmpty()) { throw new IllegalArgumentException( String.format("Domain-Value pair %s is not valid.", pair)); } domainAsMap.put(values[0].trim(), values[1].trim()); } return domainAsMap; }
Source:
<code>protected MongoTranslation findOrCreateTranslation(@Nonnull Mapping field, String lang, String text) { if (!isValidLanguage(lang, field.getName())) { <START> return null; <END> } Optional<MongoTranslation> translation = fetchTranslation(field, lang); if (translation.isPresent()) { return translation.get(); } else { MongoTranslation mongoTranslation = new MongoTranslation(); mongoTranslation.getTranslationData().setOwner(owner.getUniqueName()); mongoTranslation.getTranslationData().setField(field.getName()); mongoTranslation.getTranslationData().setLang(lang); return mongoTranslation; } }</code><technical_language>s.a</technical_language>

Target:
protected MongoTranslation findOrCreateTranslation(@Nonnull Mapping field, String lang, String text) { assertValidLanguage(lang, field.getName()); Optional<MongoTranslation> translation = fetchTranslation(field, lang); if (translation.isPresent()) { return translation.get(); } else { MongoTranslation mongoTranslation = new MongoTranslation(); mongoTranslation.getTranslationData().setOwner(owner.getUniqueName()); mongoTranslation.getTranslationData().setField(field.getName()); mongoTranslation.getTranslationData().setLang(lang); return mongoTranslation; } }
Source:
<code>public void removeGlobalPropertyListener_shouldNotFailOnNullListener() { GlobalPropertyListener globalPropertyListener = null; <START> assertNull(globalPropertyListener); <END> adminService.removeGlobalPropertyListener(globalPropertyListener); }</code><technical_language>need assert null, set null line above. simply inline this temp variable java adminService.removeGlobalPropertyListener(null)</technical_language>

Target:
public void removeGlobalPropertyListener_shouldNotFailOnNullListener() { adminService.removeGlobalPropertyListener(null); }
Source:
<code>void shouldReturnScmNameIfAny(String body) { Request request = newRequestWithAuthorizationHeader("repo:push", "", body); BitBucketCloudPushRequest bitBucketCloudPushRequest = new BitBucketCloudPushRequest(request); QueryParamsMap map = mock(QueryParamsMap.class); when(request.queryMap()).thenReturn(map); when(map.hasKey(KEY_SCM_NAME)).thenReturn(false); assertThat(bitBucketCloudPushRequest.getScmNames()).isEmpty(); when(request.queryMap()).thenReturn(map); when(map.hasKey(KEY_SCM_NAME)).thenReturn(true); QueryParamsMap value = mock(QueryParamsMap.class); when(map.get(KEY_SCM_NAME)).thenReturn(value); <START> when(value.values()).thenReturn(singletonList("scm1").toArray(new String[]{})); <END> assertThat(bitBucketCloudPushRequest.getScmNames()).containsExactly("scm1"); }</code><technical_language>This wrong, this more simply new String[]{"scm1"}</technical_language>

Target:
void shouldReturnScmNameIfAny(String body) { Request request = newRequestWithAuthorizationHeader("repo:push", "", body); BitBucketCloudPushRequest bitBucketCloudPushRequest = new BitBucketCloudPushRequest(request); QueryParamsMap map = mock(QueryParamsMap.class); when(request.queryMap()).thenReturn(map); when(map.hasKey(KEY_SCM_NAME)).thenReturn(false); assertThat(bitBucketCloudPushRequest.getScmNames()).isEmpty(); when(request.queryMap()).thenReturn(map); when(map.hasKey(KEY_SCM_NAME)).thenReturn(true); QueryParamsMap value = mock(QueryParamsMap.class); when(map.get(KEY_SCM_NAME)).thenReturn(value); when(value.values()).thenReturn(new String[]{"scm1"}); assertThat(bitBucketCloudPushRequest.getScmNames()).containsExactly("scm1"); }
Source:
<code>public static Object [][] filesToCompress(){ <START> return new Object[][]{ <END> {TEST_VARIANT_DIR.resolve("test1.vcf"),".gz",7}, {TEST_VARIANT_DIR.resolve("test1.vcf"),".bfq",7}, {TEST_DATA_DIR.resolve("words_longs.txt"),".gz",8}, {TEST_DATA_DIR.resolve("words_longs.txt"),".bfq",8} }; }</code><technical_language>IntelliJ a "Reformat Code" option clean a lot of stylistic issues I list here: - empty lines - space ']' '(' - space ',' - space ')' '{' - newline ')' '{' - space operators - space if/while/for '(' - space method-name '(' - if/else brackets else line '} else {' -make final variable (method arguments included)</technical_language>

Target:
public static Object[][] filesToCompress() { return new Object[][]{ {WORDS_LONG, ".gz", 8}, {WORDS_LONG, ".bfq", 8}, {TEST_VARIANT_DIR.resolve("test1.vcf"), ".gz", 7}, {TEST_VARIANT_DIR.resolve("test1.vcf"), ".bfq", 7} }; }
Source:
<code>private static List<String> geoCellValues(String value) { String[] geoParts = value.split("\\|"); List<String> cells = new ArrayList<>(); int count = 0; <START> for (count = 0; count < Math.min(geoParts.length,3); count++) { END> cells.add(geoParts[count]); } for (int j = count; j < 3; j++) { cells.add(""); } return cells; }</code><technical_language>suggest changes here: - Extract function Math.min() a variable loop - Instead of 3 a constant describe 3 means</technical_language>

Target:
private static List<String> geoCellValues(String value) { String[] geoParts = value.split("\\|"); List<String> cells = new ArrayList<>(); int count = 0; int partsToCopy = Math.min(geoParts.length, GEO_COLUMN_COUNT); for (count = 0; count < partsToCopy; count++) { cells.add(geoParts[count]); } for (int j = count; j < GEO_COLUMN_COUNT; j++) { cells.add(""); } return cells; }
Source:
<code>public InputStream handleException(Request request, Exception exception) <START> throws RuntimeException <END> { throw new RuntimeException("Request to worker failed", exception); }</code><technical_language>throws necessary for unchecked exception</technical_language>

Target:
public InputStream handleException(Request request, Exception exception) { throw new RuntimeException("Request to worker failed", exception); }
Source:
<code>protected Pair<String, Map<String, List<Object>>> convertPersonAttributesToPrincipal(final String extractedPrincipalId, final Map<String, List<Object>> attributes) { val convertedAttributes = new LinkedHashMap<String, List<Object>>(); attributes.forEach((key, attrValue) -> { val values = CollectionUtils.toCollection(attrValue, ArrayList.class); LOGGER.debug("Found attribute with value(s) [{}]", key, values); <START> convertedAttributes.put(key, values); <END> }); var principalId = extractedPrincipalId; if (StringUtils.isNotBlank(this.principalAttributeNames)) { val attrNames = org.springframework.util.StringUtils.commaDelimitedListToSet(this.principalAttributeNames); val result = attrNames.stream() .map(String::trim) .filter(attributes::containsKey) .map(attributes::get) .findFirst(); if (result.isPresent()) { val values = result.get(); if (!values.isEmpty()) { principalId = CollectionUtils.firstElement(values).get().toString(); LOGGER.debug("Found principal id attribute value and removed it from the collection of attributes", principalId); } } else { LOGGER.warn("Principal resolution is set to resolve the authenticated principal via attribute(s) [{}], and yet " + "the collection of attributes retrieved do not contain any of those attributes. This is likely due to misconfiguration " + "and CAS will switch to use as the final principal id", this.principalAttributeNames, attributes.keySet(), principalId); } } return Pair.of(principalId, convertedAttributes); }</code><technical_language>This right; a solution simply weed out null values while keeping rest</technical_language>

Target:
protected Pair<String, Map<String, List<Object>>> convertPersonAttributesToPrincipal(final String extractedPrincipalId, final Map<String, List<Object>> attributes) { val convertedAttributes = new LinkedHashMap<String, List<Object>>(); attributes.forEach((key, attrValue) -> { val values = ((List<Object>) CollectionUtils.toCollection(attrValue, ArrayList.class)) .stream() .filter(Objects::nonNull) .collect(toList()); LOGGER.debug("Found attribute with value(s) [{}]", key, values); convertedAttributes.put(key, values); }); var principalId = extractedPrincipalId; if (StringUtils.isNotBlank(this.principalAttributeNames)) { val attrNames = org.springframework.util.StringUtils.commaDelimitedListToSet(this.principalAttributeNames); val result = attrNames.stream() .map(String::trim) .filter(attributes::containsKey) .map(attributes::get) .findFirst(); if (result.isPresent()) { val values = result.get(); if (!values.isEmpty()) { principalId = CollectionUtils.firstElement(values).get().toString(); LOGGER.debug("Found principal id attribute value and removed it from the collection of attributes", principalId); } } else { LOGGER.warn("Principal resolution is set to resolve the authenticated principal via attribute(s) [{}], and yet " + "the collection of attributes retrieved do not contain any of those attributes. This is likely due to misconfiguration " + "and CAS will switch to use as the final principal id", this.principalAttributeNames, attributes.keySet(), principalId); } } return Pair.of(principalId, convertedAttributes); }
Source:
<code>private static EventIdentificationType createEventIdentification(String actionCode, Integer eventOutcome, CodedValueType eventId) { EventIdentificationType eventIdentification = new EventIdentificationType(); eventIdentification.setEventActionCode(actionCode); try { java.util.GregorianCalendar today = new java.util.GregorianCalendar(TimeZone.getTimeZone("GMT")); javax.xml.datatype.DatatypeFactory factory = javax.xml.datatype.DatatypeFactory.newInstance(); <START> javax.xml.datatype.XMLGregorianCalendar calendar = factory.newXMLGregorianCalendar( <END> today.get(java.util.GregorianCalendar.YEAR), today.get(java.util.GregorianCalendar.MONTH) + 1, today.get(java.util.GregorianCalendar.DAY_OF_MONTH), today.get(java.util.GregorianCalendar.HOUR_OF_DAY), today.get(java.util.GregorianCalendar.MINUTE), today.get(java.util.GregorianCalendar.SECOND), today.get(java.util.GregorianCalendar.MILLISECOND), 0); eventIdentification.setEventDateTime(calendar); } catch (DatatypeConfigurationException e) { LOG.error("DatatypeConfigurationException when creating XMLGregorian Date"); LOG.error(" message: " + e.getMessage()); } catch (ArrayIndexOutOfBoundsException e) { LOG.error("ArrayIndexOutOfBoundsException when creating XMLGregorian Date"); LOG.error(" message: " + e.getMessage()); } BigInteger eventOutcomeBig = BigInteger.ZERO; if (eventOutcome != null) { eventOutcomeBig = new BigInteger(eventOutcome.toString()); } eventIdentification.setEventOutcomeIndicator(eventOutcomeBig); eventIdentification.setEventID(eventId); return eventIdentification; }</code><technical_language>fully-qualified types for previous lines</technical_language>

Target:
private static EventIdentificationType createEventIdentification(String actionCode, Integer eventOutcome, CodedValueType eventId) { EventIdentificationType eventIdentification = new EventIdentificationType(); eventIdentification.setEventActionCode(actionCode); try { GregorianCalendar today = new java.util.GregorianCalendar(TimeZone.getTimeZone("GMT")); DatatypeFactory factory = javax.xml.datatype.DatatypeFactory.newInstance(); XMLGregorianCalendar calendar = factory.newXMLGregorianCalendar( today.get(java.util.GregorianCalendar.YEAR), today.get(java.util.GregorianCalendar.MONTH) + 1, today.get(java.util.GregorianCalendar.DAY_OF_MONTH), today.get(java.util.GregorianCalendar.HOUR_OF_DAY), today.get(java.util.GregorianCalendar.MINUTE), today.get(java.util.GregorianCalendar.SECOND), today.get(java.util.GregorianCalendar.MILLISECOND), 0); eventIdentification.setEventDateTime(calendar); } catch (DatatypeConfigurationException e) { LOG.error("DatatypeConfigurationException when creating XMLGregorian Date"); LOG.error(" message: " + e.getLocalizedMessage(), e); } catch (ArrayIndexOutOfBoundsException e) { LOG.error("ArrayIndexOutOfBoundsException when creating XMLGregorian Date"); LOG.error(" message: " + e.getLocalizedMessage(), e); } BigInteger eventOutcomeBig = BigInteger.ZERO; if (eventOutcome != null) { eventOutcomeBig = new BigInteger(eventOutcome.toString()); } eventIdentification.setEventOutcomeIndicator(eventOutcomeBig); eventIdentification.setEventID(eventId); return eventIdentification; }
Source:
<code>private static ExpressionTree findBoxedBoolean(ExpressionTree tree) { if (isBooleanIdentifier(tree)) { return tree; } if (tree instanceof BinaryExpressionTree) { <START> BinaryExpressionTree expression = (BinaryExpressionTree) tree; <END> if (!isNullCheck(expression) && !isNullCheck(expression.leftOperand())) { if (isBooleanIdentifier(expression.leftOperand())) { return expression.leftOperand(); } if (isBooleanIdentifier(expression.rightOperand())) { return expression.rightOperand(); } } } return null; }</code><technical_language>In case of binary expression check lhs rhs is java.lang.Boolean boolean respectively, need check for null checks</technical_language>

Target:
private static ExpressionTree findBoxedBoolean(ExpressionTree tree) { if (tree.symbolType().is(BOOLEAN) && !isOptionalInvocation(tree)) { return tree; } if (tree.is(Kind.LOGICAL_COMPLEMENT)) { return findBoxedBoolean(((UnaryExpressionTree) tree).expression()); } if (tree instanceof BinaryExpressionTree) { BinaryExpressionTree expr = (BinaryExpressionTree) tree; if (findBoxedBoolean(expr.leftOperand()) != null && expr.rightOperand().symbolType().isPrimitive(Primitives.BOOLEAN)) { return expr.leftOperand(); } if (findBoxedBoolean(expr.rightOperand()) != null && expr.leftOperand().symbolType().isPrimitive(Primitives.BOOLEAN) && !isNullCheck(expr.leftOperand())) { return expr.rightOperand(); } } return null; }
Source:
<code>public static void populateStockIdInGermplasmListData(final List<GermplasmListData> data , InventoryDataManager inventoryDataManager) { final List<Integer> gids = new ArrayList<>(); if (data != null && !data.isEmpty()) { for (final GermplasmListData germplasmListData : data) { gids.add(germplasmListData.getGid()); } } Map<Integer, String> stockIds = inventoryDataManager.retrieveStockIds(gids); if (data != null && !data.isEmpty()) { for (final GermplasmListData ListData : data) { String stockIdValue = ""; if (stockIds != null) { for (final Integer gid : stockIds.keySet()) { if (ListData.getGid().equals(gid)) { stockIdValue = stockIds.get(gid); break; } } } <START> ListData.setStockIDs(stockIdValue); <END> } } }</code><technical_language>Again, local variable ListData renamed listData local variable naming conventions</technical_language>

Target:
public static void populateStockIdInGermplasmListData(final List<GermplasmListData> data , InventoryDataManager inventoryDataManager) { final List<Integer> gids = new ArrayList<>(); if (data != null && !data.isEmpty()) { for (final GermplasmListData germplasmListData : data) { gids.add(germplasmListData.getGid()); } } Map<Integer, String> stockIds = inventoryDataManager.retrieveStockIds(gids); if (data != null && !data.isEmpty()) { for (final GermplasmListData listData : data) { String stockIdValue = ""; if (stockIds != null) { for (final Integer gid : stockIds.keySet()) { if (listData.getGid().equals(gid)) { stockIdValue = stockIds.get(gid); break; } } } listData.setStockIDs(stockIdValue); } } }
Source:
<code>void doesNotOverwriteConfigSourceProviderIfNotProvidedInConstructor() throws Exception { DropwizardTestSupport<TestConfiguration> support = new DropwizardTestSupport<>( TestApplication.class, "test-config.yaml"); try { support.before(); assertThat(TEST_CONFIG_SOURCE_PROVIDER.openCalled).isTrue(); } catch (Exception e) { <START> Assert.fail(); <END> } finally { support.after(); } }</code><technical_language>This catch statement needed, no</technical_language>

Target:
void doesNotOverwriteConfigSourceProviderIfNotProvidedInConstructor() throws Exception { DropwizardTestSupport<TestConfiguration> support = new DropwizardTestSupport<>( TestApplication.class, "test-config.yaml"); try { support.before(); assertThat(TEST_CONFIG_SOURCE_PROVIDER.openCalled).isTrue(); } finally { support.after(); } }
Source:
<code>public Connector create(String catalogName, Map<String, String> config, ConnectorContext context) { <START> requireNonNull(catalogName, "connectorId is null"); <END> requireNonNull(config, "config is null"); try { Bootstrap app = new Bootstrap( new JsonModule(), new KafkaConnectorModule(), binder -> { binder.bind(KafkaConnectorId.class).toInstance(new KafkaConnectorId(catalogName)); binder.bind(TypeManager.class).toInstance(context.getTypeManager()); binder.bind(NodeManager.class).toInstance(context.getNodeManager()); if (tableDescriptionSupplier.isPresent()) { binder.bind(new TypeLiteral<Supplier<Map<SchemaTableName, KafkaTopicDescription>>>() {}).toInstance(tableDescriptionSupplier.get()); } else { binder.bind(new TypeLiteral<Supplier<Map<SchemaTableName, KafkaTopicDescription>>>() {}).to(KafkaTableDescriptionSupplier.class).in(Scopes.SINGLETON); } }); Injector injector = app.strictConfig() .doNotInitializeLogging() .setRequiredConfigurationProperties(config) .initialize(); return injector.getInstance(KafkaConnector.class); } catch (Exception e) { throwIfUnchecked(e); throw new RuntimeException(e); } }</code><technical_language>msg</technical_language>

Target:
public Connector create(String catalogName, Map<String, String> config, ConnectorContext context) { requireNonNull(catalogName, "catalogName is null"); requireNonNull(config, "config is null"); try { Bootstrap app = new Bootstrap( new JsonModule(), new KafkaConnectorModule(), binder -> { binder.bind(KafkaConnectorId.class).toInstance(new KafkaConnectorId(catalogName)); binder.bind(TypeManager.class).toInstance(context.getTypeManager()); binder.bind(NodeManager.class).toInstance(context.getNodeManager()); if (tableDescriptionSupplier.isPresent()) { binder.bind(new TypeLiteral<Supplier<Map<SchemaTableName, KafkaTopicDescription>>>() {}).toInstance(tableDescriptionSupplier.get()); } else { binder.bind(new TypeLiteral<Supplier<Map<SchemaTableName, KafkaTopicDescription>>>() {}).to(KafkaTableDescriptionSupplier.class).in(Scopes.SINGLETON); } }); Injector injector = app.strictConfig() .doNotInitializeLogging() .setRequiredConfigurationProperties(config) .initialize(); return injector.getInstance(KafkaConnector.class); } catch (Exception e) { throwIfUnchecked(e); throw new RuntimeException(e); } }
Source:
<code>ScopePassingSpanSubscriber(Subscriber<? super T> subscriber, Context ctx, Tracing tracing) { this.subscriber = subscriber; this.tracing = tracing; this.currentTraceContext = this.tracing.currentTraceContext(); <START> TraceContext root = ctx != null ? ctx.getOrDefault(TraceContext.class, this.currentTraceContext.get()) : null; <END> this.root = root; this.context = ctx != null && root != null ? ctx.put(TraceContext.class, root) : ctx != null ? ctx : Context.empty(); if (log.isTraceEnabled()) { log.trace("Root traceContext [" + root + "], context [" + this.context + "]"); } }</code><technical_language>I if this is a inefficient. currentTraceContext.get() called if is a TraceContext there.. is a pass a method reference instead? otherwise, get if is null</technical_language>

Target:
ScopePassingSpanSubscriber(Subscriber<? super T> subscriber, Context ctx, Tracing tracing) { this.subscriber = subscriber; this.tracer = tracing.tracer(); this.currentTraceContext = tracing.currentTraceContext(); Span root = ctx != null ? ctx.hasKey(Span.class) ? ctx.get(Span.class) : this.tracer.currentSpan() : null; this.traceContext = root == null ? null : root.context(); this.context = ctx != null && root != null ? ctx.put(Span.class, root) : ctx != null ? ctx : Context.empty(); if (log.isTraceEnabled()) { log.trace("Root span [" + root + "], context [" + this.context + "]"); } }
Source:
<code>private void preserve() { List<BreakpointDto> breakpoints2save = new LinkedList<>(); for (Breakpoint breakpoint : breakpoints) { breakpoints2save.add(dtoFactory.createDto(BreakpointDto.class) .withLocation(dtoFactory.createDto(LocationDto.class) .withTarget(breakpoint.getPath()) .withLineNumber(breakpoint.getLineNumber()))); } <START> String storageKey = LOCAL_STORAGE_BREAKPOINTS_KEY + appContext.getWorkspaceId(); <END> storage.setItem(storageKey, dtoFactory.toJson(breakpoints2save)); }</code><technical_language>define a class field called STORAGE_KEY LOCAL_STORAGE_BREAKPOINTS_KEY + appContext.getWorkspaceId(), construct in this class</technical_language>

Target:
private void preserve() { if (storage == null) { return; } List<BreakpointDto> breakpoints2save = new LinkedList<>(); for (Breakpoint breakpoint : breakpoints) { breakpoints2save.add(dtoFactory.createDto(BreakpointDto.class) .withLocation(dtoFactory.createDto(LocationDto.class) .withTarget(breakpoint.getPath()) .withLineNumber(breakpoint.getLineNumber()))); } storage.setItem(storageKey, dtoFactory.toJson(breakpoints2save)); }
Source:
<code>public void setSidebarPosition(boolean fixed) { <START> String userPageSideBarStyle = "userPageSideBarFixed"; <END> String userPageFaveListStyle = "userPageFaveList"; if (fixed) { userPageSideBar.addStyleName(userPageSideBarStyle); userPageFaveList.addStyleName(userPageFaveListStyle); } else { userPageSideBar.removeStyleName(userPageSideBarStyle); userPageFaveList.removeStyleName(userPageFaveListStyle); } }</code><technical_language>final, static strings edit: better; export Style UIBinder refer a css class name. This need mark class external duplicate strings</technical_language>

Target:
public void setSidebarPosition(boolean fixed) { if (fixed) { userPageSideBar.addStyleName(USER_PAGE_SIDE_BAR_FIXED_STYLE); userPageFaveList.addStyleName(USER_PAGE_FAVE_LIST_STYLE); } else { userPageSideBar.removeStyleName(USER_PAGE_SIDE_BAR_FIXED_STYLE); userPageFaveList.removeStyleName(USER_PAGE_FAVE_LIST_STYLE); } }
Source:
<code>public void testConcurrencyExecutorShutdown() throws Exception { ModelNode content = new ModelNode(); content.get("archive").set(true); content.get("path").set(new File(tmpDir, "archives/" + ARCHIVE_FILE_NAME).getAbsolutePath()); ModelNode deploymentOpMain = createDeploymentOperation(content, MAIN_SERVER_GROUP_DEPLOYMENT_ADDRESS); <START> executeOnMaster(deploymentOpMain); <END> this.stopServer(FIRST_SERVER_NAME); }</code><technical_language>executeForResult(deploymentOpMain, masterClient); instead of executeOnMaster(deploymentOpMain);. check operation correctly executed, benefits. If do so, remove completely executeOnMaster method test, currently, is here</technical_language>

Target:
public void testConcurrencyExecutorShutdown() throws Exception { ModelNode content = new ModelNode(); content.get("archive").set(true); content.get("path").set(new File(tmpDir, "archives/" + ARCHIVE_FILE_NAME).getAbsolutePath()); ModelNode deploymentOpMain = createDeploymentOperation(content, MAIN_SERVER_GROUP_DEPLOYMENT_ADDRESS); executeForResult(deploymentOpMain, masterClient); this.stopServer(FIRST_SERVER_NAME); }
Source:
<code>private void initializeFromLocalSearch(LocalSearch search) { this.search = search; singleFolderMode = false; if (search.searchAllAccounts()) { account = null; } else { String[] accountUuids = search.getAccountUuids(); <START> if (accountUuids.length == 1) { <END> account = preferences.getAccount(accountUuids[0]); List<String> folderServerIds = search.getFolderServerIds(); singleFolderMode = folderServerIds.size() == 1; } } configureDrawer(); actionBarSubTitle.setVisibility((!singleFolderMode) ? View.GONE : View.VISIBLE); }</code><technical_language>This set account null in case condition met</technical_language>

Target:
private void initializeFromLocalSearch(LocalSearch search) { this.search = search; singleFolderMode = false; if (search.searchAllAccounts()) { account = null; } else { String[] accountUuids = search.getAccountUuids(); if (accountUuids.length == 1) { account = preferences.getAccount(accountUuids[0]); List<String> folderServerIds = search.getFolderServerIds(); singleFolderMode = folderServerIds.size() == 1; } else { account = null; } } configureDrawer(); actionBarSubTitle.setVisibility((!singleFolderMode) ? View.GONE : View.VISIBLE); }
Source:
<code>public void testSetDateExpiresToNull() throws Exception, UpdateException { ArrayList<Coordinate> coordinates = new ArrayList<>(); Coordinate coordinate = new Coordinate(0, 3); coordinates.add(coordinate); table52.getData() .get(0) .get(3) .setDateValue(null); updateManager.update(table52, coordinates); <START> verify(analyzer).update(anySet()); <END> }</code><technical_language>I this test is effective if do check content of set passed method update</technical_language>

Target:
public void testSetDateExpiresToNull() throws Exception { ArrayList<Coordinate> coordinates = new ArrayList<>(); Coordinate coordinate = new Coordinate(0, 3); coordinates.add(coordinate); table52.getData() .get(0) .get(3) .setDateValue(null); updateManager.update(table52, coordinates); verify(analyzer).update(setArgumentCaptor.capture()); Set value = setArgumentCaptor.getValue(); assertEquals(1, value.size()); assertEquals(0, value.iterator().next()); }
Source:
<code>public M fromBytes(byte[] messageBuffer, int offset, int len) throws InvalidProtocolBufferException, UninitializedMessageException { try { if (defaultInstance == null) { defaultInstance = Protobufs.getMessageBuilder(typeRef.getRawClass()) .getDefaultInstanceForType(); } return (M) defaultInstance.newBuilderForType() .mergeFrom(messageBuffer, offset, len) .build(); <START> } catch (InvalidProtocolBufferException e) { <END> logWarning("Invalid Protobuf exception while building " + typeRef.getRawClass().getName(), e); throw e; } catch(UninitializedMessageException ume) { logWarning("Uninitialized Message Exception while building " + typeRef.getRawClass().getName(), ume); throw ume; } }</code><technical_language>remove this exception logging exception is percolated up</technical_language>

Target:
public M fromBytes(byte[] messageBuffer, int offset, int len) throws InvalidProtocolBufferException, UninitializedMessageException { if (defaultInstance == null) { defaultInstance = Protobufs.getMessageBuilder(typeRef.getRawClass()) .getDefaultInstanceForType(); } return (M) defaultInstance.newBuilderForType() .mergeFrom(messageBuffer, offset, len) .build(); }
Source:
<code>public boolean shouldCreateEndpoint(Method method, List<Annotation> annotations) { <START> String inputChannel = MessagingAnnotationUtils.resolveAttribute(annotations, "inputChannel", String.class); <END> return StringUtils.hasText(inputChannel); }</code><technical_language>INPUT_CHANNEL_ATTRIBUTE here; fix merge</technical_language>

Target:
public boolean shouldCreateEndpoint(Method method, List<Annotation> annotations) { String inputChannel = MessagingAnnotationUtils.resolveAttribute(annotations, getInputChannelAttribute(), String.class); return StringUtils.hasText(inputChannel); }