auphong2707/dl4se-code-review-dataset huggingface dataset:
Source:
<code>public void refreshLayout(Form form) { super.refreshLayout(form); if (form.getName().equals(Form.MAIN) && connection != null) { for (Form childForm : connection.getForms()) { connection.refreshLayout(childForm); } if (!isPlainOutputConnectionMode()) { updateDocIdColumnPossibleValues(); } form.getWidget(criteria).setVisible(isPlainOutputConnectionMode()); form.getWidget(docIdColumn).setHidden(isPlainOutputConnectionMode()); } if (form.getName().equals(Form.ADVANCED)) { if (isPlainOutputConnectionMode()) { <START> form.getWidget(pageSize).setVisible(); <END> form.getWidget(maxRetrieve).setVisible(); form.getWidget(useQueryOption).setVisible(); form.getWidget(queryLiteralType).setVisible(useQueryOption); form.getWidget(queryOptionName).setVisible(useQueryOption); form.getWidget(queryOptionLiterals).setVisible(useQueryOption); } else { form.getWidget(pageSize).setHidden(); form.getWidget(maxRetrieve).setHidden(); form.getWidget(useQueryOption).setHidden(); form.getWidget(queryLiteralType).setHidden(); form.getWidget(queryOptionName).setHidden(); form.getWidget(queryOptionLiterals).setHidden(); } } }</code><technical_language>write shorter version of this code. Put condition in **setVisible()** method</technical_language>

Target:
public void refreshLayout(Form form) { super.refreshLayout(form); if (form.getName().equals(Form.MAIN) && connection != null) { for (Form childForm : connection.getForms()) { connection.refreshLayout(childForm); } if (!isPlainOutputConnectionMode()) { updateDocIdColumnPossibleValues(); } form.getWidget(criteria).setVisible(isPlainOutputConnectionMode()); form.getWidget(docIdColumn).setHidden(isPlainOutputConnectionMode()); } if (form.getName().equals(Form.ADVANCED)) { boolean isCriteriaModeUsed = isPlainOutputConnectionMode(); form.getWidget(pageSize).setVisible(isCriteriaModeUsed); form.getWidget(maxRetrieve).setVisible(isCriteriaModeUsed); form.getWidget(useQueryOption).setVisible(isCriteriaModeUsed); form.getWidget(queryLiteralType).setVisible(isCriteriaModeUsed && useQueryOption.getValue()); form.getWidget(queryOptionName).setVisible(isCriteriaModeUsed && useQueryOption.getValue()); form.getWidget(queryOptionLiterals).setVisible(isCriteriaModeUsed && useQueryOption.getValue()); } }
Source:
<code>protected void AddVmTemplateToDb() { getVmTemplate().setvds_group_id(getParameters().getVdsGroupId()); getVmTemplate().setstatus(VmTemplateStatus.Locked); DbFacade.getInstance().getVmTemplateDAO().save(getVmTemplate()); getCompensationContext().snapshotNewEntity(getVmTemplate()); for (DiskImage image : getParameters().getImages()) { DbFacade.getInstance().getDiskImageDAO().save(image); getCompensationContext().snapshotNewEntity(image); if (!DbFacade.getInstance().getDiskDao().exists(image.getimage_group_id())) { Disk disk = image.getDisk(); <START> image_vm_map imageVmMap = new image_vm_map(image.getactive(),image.getId(),image.getvm_guid()); <END> getCompensationContext().snapshotNewEntity(imageVmMap); DbFacade.getInstance().getImageVmMapDAO().save(imageVmMap); DbFacade.getInstance().getDiskDao().save(disk); getCompensationContext().snapshotNewEntity(disk); } DiskImageDynamic diskDynamic = new DiskImageDynamic(); diskDynamic.setId(image.getId()); diskDynamic.setactual_size(image.getactual_size()); DbFacade.getInstance().getDiskImageDynamicDAO().save(diskDynamic); getCompensationContext().snapshotNewEntity(diskDynamic); } }</code><technical_language>Please format this line</technical_language>

Target:
protected void AddVmTemplateToDb() { getVmTemplate().setvds_group_id(getParameters().getVdsGroupId()); getVmTemplate().setstatus(VmTemplateStatus.Locked); DbFacade.getInstance().getVmTemplateDAO().save(getVmTemplate()); getCompensationContext().snapshotNewEntity(getVmTemplate()); for (DiskImage image : getParameters().getImages()) { DbFacade.getInstance().getDiskImageDAO().save(image); getCompensationContext().snapshotNewEntity(image); if (!DbFacade.getInstance().getDiskDao().exists(image.getimage_group_id())) { Disk disk = image.getDisk(); VmDeviceUtils.addManagedDevice(getCompensationContext(),new VmDeviceId((Guid) image.getId(), image.getvm_guid()), VmDeviceType.DISK, VmDeviceType.DISK, "", true, false); DbFacade.getInstance().getDiskDao().save(disk); getCompensationContext().snapshotNewEntity(disk); image_vm_map imageVmMap = new image_vm_map(true,image.getId(),image.getvm_guid()); DbFacade.getInstance().getImageVmMapDAO().save(imageVmMap); getCompensationContext().snapshotNewEntity(imageVmMap); } DiskImageDynamic diskDynamic = new DiskImageDynamic(); diskDynamic.setId(image.getId()); diskDynamic.setactual_size(image.getactual_size()); DbFacade.getInstance().getDiskImageDynamicDAO().save(diskDynamic); getCompensationContext().snapshotNewEntity(diskDynamic); } }
Source:
<code>public void revertTasks(CommandBase<?> command) { if (command.getParameters().getVdsmTaskIds() != null) { <START> ArrayList<Guid> <END> taskIdAsList = new ArrayList<>(); for (Guid taskId : command.getParameters().getVdsmTaskIds()) { taskIdAsList.add(taskId); List<AsyncTaskStatus> tasksStatuses = getAsyncTaskManager().pollTasks( taskIdAsList); if (tasksStatuses.get(0).getTaskEndedSuccessfully()) { getBackend().getResourceManager().RunVdsCommand( VDSCommandType.SPMRevertTask, new SPMTaskGuidBaseVDSCommandParameters( command.getStoragePool().getId(), taskId)); } taskIdAsList.clear(); } } }</code><technical_language>well, changed signature [1] support it. [1] <LINK_0></technical_language>

Target:
public void revertTasks(CommandBase<?> command) { if (command.getParameters().getVdsmTaskIds() != null) { List<Guid> taskIdAsList = new ArrayList<>(); for (Guid taskId : command.getParameters().getVdsmTaskIds()) { taskIdAsList.add(taskId); List<AsyncTaskStatus> tasksStatuses = getAsyncTaskManager().pollTasks( taskIdAsList); if (tasksStatuses.get(0).getTaskEndedSuccessfully()) { getBackend().getResourceManager().RunVdsCommand( VDSCommandType.SPMRevertTask, new SPMTaskGuidBaseVDSCommandParameters( command.getStoragePool().getId(), taskId)); } taskIdAsList.clear(); } } }
Source:
<code>default T verify(Duration timeout) throws IOException { <START> return verify(timeout.toMillis()); <END> }</code><technical_language>In other locations code interprets null *forever* - maintain this convention (or fix other code - ClientChannel#waitFor) java default T verify(Duration timeout) throws IOException { return (duration == null) ? verify() : verify(timeout.toMillis()); }</technical_language>

Target:
default T verify(Duration timeout) throws IOException { return timeout != null ? verify(timeout.toMillis()) : verify(); }
Source:
<code>public boolean addAll(@NonNull Disposable... disposables) { <START> ObjectHelper.requireNonNull(disposables, "Disposables are null"); <END> if (!disposed) { synchronized (this) { if (!disposed) { OpenHashSet<Disposable> set = resources; if (set == null) { set = new OpenHashSet<Disposable>(disposables.length + 1); resources = set; } for (Disposable d : disposables) { ObjectHelper.requireNonNull(d, "Disposable item in Disposables is null"); set.add(d); } return true; } } } for (Disposable d : disposables) { d.dispose(); } return false; }</code><technical_language>disposables is null</technical_language>

Target:
public boolean addAll(@NonNull Disposable... disposables) { ObjectHelper.requireNonNull(disposables, "disposables is null"); if (!disposed) { synchronized (this) { if (!disposed) { OpenHashSet<Disposable> set = resources; if (set == null) { set = new OpenHashSet<Disposable>(disposables.length + 1); resources = set; } for (Disposable d : disposables) { ObjectHelper.requireNonNull(d, "A Disposable in the disposables array is null"); set.add(d); } return true; } } } for (Disposable d : disposables) { d.dispose(); } return false; }
Source:
<code>protected <C extends VisitableCommand & FlagAffectedCommand & TopologyAffectedCommand, K> Object handleTxWriteManyCommand( InvocationContext ctx, C command, Collection<K> keys, BiFunction<C, List<K>, C> copyCommand) { boolean ignorePreviousValue = command.hasAnyFlag(SKIP_REMOTE_FLAGS) || command.loadType() == VisitableCommand.LoadType.DONT_LOAD; List<K> filtered = new ArrayList<>(keys.size()); <START> List<Object> remoteKeys = new ArrayList<>(); <END> LocalizedCacheTopology cacheTopology = checkTopologyId(command); for (K key : keys) { if (ctx.isOriginLocal() || cacheTopology.isWriteOwner(key)) { if (ctx.lookupEntry(key) == null) { if (ignorePreviousValue) { entryFactory.wrapExternalEntry(ctx, key, null, false, true); } else { remoteKeys.add(key); } } filtered.add(key); } } CompletionStage<?> remoteGetMany = remoteGetMany(ctx, command, keys); return asyncInvokeNext(ctx, copyCommand.apply(command, filtered), remoteGetMany); }</code><technical_language>allocate lazily</technical_language>

Target:
protected <C extends VisitableCommand & FlagAffectedCommand & TopologyAffectedCommand, K> Object handleTxWriteManyCommand( InvocationContext ctx, C command, Collection<K> keys, BiFunction<C, List<K>, C> copyCommand) { boolean ignorePreviousValue = command.hasAnyFlag(SKIP_REMOTE_FLAGS) || command.loadType() == VisitableCommand.LoadType.DONT_LOAD; List<K> filtered = new ArrayList<>(keys.size()); List<Object> remoteKeys = null; LocalizedCacheTopology cacheTopology = checkTopologyId(command); for (K key : keys) { if (ctx.isOriginLocal() || cacheTopology.isWriteOwner(key)) { if (ctx.lookupEntry(key) == null) { if (ignorePreviousValue) { entryFactory.wrapExternalEntry(ctx, key, null, false, true); } else { if (remoteKeys == null) { remoteKeys = new ArrayList<>(); } remoteKeys.add(key); } } filtered.add(key); } } CompletionStage<?> remoteGetMany = remoteKeys != null ? remoteGetMany(ctx, command, remoteKeys) : CompletableFutures.completedNull(); return asyncInvokeNext(ctx, copyCommand.apply(command, filtered), remoteGetMany); }
Source:
<code>private InputPoint createInputPointWithAllSinks( HttpMessage originalMsg, String originalValue, HttpMessage referenceMsg, String referenceValue, String paramName) { InputPoint inputPoint = new InputPoint(); inputPoint.addSinkPoint( new ReflectedSinkPoint(originalMsg, originalValue, referenceMsg, referenceValue)); <START> Set<Integer> sinks = PersistentXSSUtils.getSinksIdsForSource(originalMsg, paramName); <END> if (sinks != null) { for (int sinkMsgId : sinks) { HttpMessage sinkMsg = PersistentXSSUtils.getMessage(sinkMsgId); if (sinkMsg == null) { continue; } inputPoint.addSinkPoint(new StoredSinkPoint(sinkMsg, originalValue)); } } return inputPoint; }</code><technical_language>leveraging PersistentXSSUtils (and other classes? I noticed far... oops) this is subject this problem: <LINK_0></technical_language>

Target:
private InputPoint createInputPointWithAllSinks( HttpMessage originalMsg, String originalValue, HttpMessage referenceMsg, String referenceValue, String paramName) { InputPoint inputPoint = new InputPoint(); inputPoint.addSinkPoint( new ReflectedSinkPoint(originalMsg, originalValue, referenceMsg, referenceValue)); Set<Integer> sinks = PersistentXssUtils.getSinksIdsForSource(originalMsg, paramName); if (sinks != null) { for (int sinkMsgId : sinks) { HttpMessage sinkMsg = PersistentXssUtils.getMessage(sinkMsgId); if (sinkMsg == null) { continue; } inputPoint.addSinkPoint(new StoredSinkPoint(sinkMsg, originalValue)); } } return inputPoint; }
Source:
<code>public Source<byte[], ProgramPrecompile> precompileSource() { StateSource source = stateSource(); return new SourceCodec<byte[], ProgramPrecompile, byte[], byte[]>(source, new Serializer<byte[], byte[]>() { public byte[] serialize(byte[] object) { DataWord ret = new DataWord(object); <START> DataWord addResult = ret.add(new DataWord(1)); <END> return addResult.getLast20Bytes(); } public byte[] deserialize(byte[] stream) { throw new RuntimeException("Shouldn't be called"); } }, new Serializer<ProgramPrecompile, byte[]>() { public byte[] serialize(ProgramPrecompile object) { return object == null ? null : object.serialize(); } public ProgramPrecompile deserialize(byte[] stream) { return stream == null ? null : ProgramPrecompile.deserialize(stream); } }); }</code><technical_language>add DataWord.ONE predefined</technical_language>

Target:
public Source<byte[], ProgramPrecompile> precompileSource() { StateSource source = stateSource(); return new SourceCodec<byte[], ProgramPrecompile, byte[], byte[]>(source, new Serializer<byte[], byte[]>() { public byte[] serialize(byte[] object) { DataWord ret = DataWord.of(object); DataWord addResult = ret.add(DataWord.ONE); return addResult.getLast20Bytes(); } public byte[] deserialize(byte[] stream) { throw new RuntimeException("Shouldn't be called"); } }, new Serializer<ProgramPrecompile, byte[]>() { public byte[] serialize(ProgramPrecompile object) { return object == null ? null : object.serialize(); } public ProgramPrecompile deserialize(byte[] stream) { return stream == null ? null : ProgramPrecompile.deserialize(stream); } }); }
Source:
<code><START> protected String getGDBCommandLine() { <END> StringBuffer gdbCommandLine = new StringBuffer(getGDBPath().toOSString()); gdbCommandLine.append(" --interpreter"); gdbCommandLine.append(" mi2"); gdbCommandLine.append(" --nx"); return gdbCommandLine.toString(); }</code><technical_language>I suggest calling new getGDBCommandLineArray making a string out of it. more future-proof. like: String cmdArray[] = getGDBCommandArray(); StringBuffer gdbCommandLine = new StringBuffer(); for (String cmd : cmdArray) { gdbCommandLine.append(cmd).append(' '); } return gdbCommandLine.deleteCharAt(gdbCommandLine.length()-1).toString();</technical_language>

Target:
protected String getGDBCommandLine() { String cmdArray[] = getGDBCommandLineArray(); return StringUtil.join(cmdArray, " "); }
Source:
<code>protected void initChannel(SocketChannel ch) throws Exception { ch.config() .setSendBufferSize(http2ClientConfig.nettySendBufferSize) .setReceiveBufferSize(http2ClientConfig.nettyReceiveBufferSize) .setWriteBufferWaterMark(new WriteBufferWaterMark(http2ClientConfig.http2InitialWindowSize, 2 * http2ClientConfig.http2InitialWindowSize)); ChannelPipeline pipeline = ch.pipeline(); pipeline.addLast("connectionStatsHandler", connectionStatsHandler); InetSocketAddress peerAddress = ch.remoteAddress(); String peerHost = peerAddress.getHostName(); int peerPort = peerAddress.getPort(); SslHandler sslHandler = new SslHandler(sslFactory.createSSLEngine(peerHost, peerPort, SSLFactory.Mode.SERVER)); pipeline.addLast("SslHandler", sslHandler); <START> pipeline.addLast("securityChecker", this.serverSecurityChecker); <END> pipeline.addLast(Http2FrameCodecBuilder.forServer() .initialSettings(Http2Settings.defaultSettings() .maxFrameSize(http2ClientConfig.http2FrameMaxSize) .initialWindowSize(http2ClientConfig.http2InitialWindowSize)) .frameLogger(new Http2FrameLogger(LogLevel.DEBUG, "server")) .build()) .addLast("Http2MultiplexHandler", new Http2MultiplexHandler( new Http2StreamHandler(nettyMetrics, nettyConfig, performanceConfig, http2ClientConfig, requestHandler))); }</code><technical_language>this is needed here. Align other</technical_language>

Target:
protected void initChannel(SocketChannel ch) throws Exception { ch.config() .setSendBufferSize(http2ClientConfig.nettySendBufferSize) .setReceiveBufferSize(http2ClientConfig.nettyReceiveBufferSize) .setWriteBufferWaterMark(new WriteBufferWaterMark(http2ClientConfig.http2InitialWindowSize, 2 * http2ClientConfig.http2InitialWindowSize)); ChannelPipeline pipeline = ch.pipeline(); pipeline.addLast("connectionStatsHandler", connectionStatsHandler); InetSocketAddress peerAddress = ch.remoteAddress(); String peerHost = peerAddress.getHostName(); int peerPort = peerAddress.getPort(); SslHandler sslHandler = new SslHandler(sslFactory.createSSLEngine(peerHost, peerPort, SSLFactory.Mode.SERVER)); pipeline.addLast("SslHandler", sslHandler); pipeline.addLast("securityChecker", serverSecurityHandler); pipeline.addLast(Http2FrameCodecBuilder.forServer() .initialSettings(Http2Settings.defaultSettings() .maxFrameSize(http2ClientConfig.http2FrameMaxSize) .initialWindowSize(http2ClientConfig.http2InitialWindowSize)) .frameLogger(new Http2FrameLogger(LogLevel.DEBUG, "server")) .build()) .addLast("Http2MultiplexHandler", new Http2MultiplexHandler( new Http2StreamHandler(nettyMetrics, nettyConfig, performanceConfig, http2ClientConfig, requestHandler))); }
Source:
<code>public StubbingListener getStubbingListener() { if (this.stubbingListener == null) { <START> return new StubbingListener() { <END> public void newStubbing(Invocation stubbing) public void usedStubbing(Invocation stubbing, Invocation actual) }; } return this.stubbingListener; }</code><technical_language>I set this in constructor of this class, prevent needless if checks if listeners (which is majority of cases)</technical_language>

Target:
public StubbingListener getStubbingListener() { if (this.stubbingListener == null) { return NoOpStubbingListener.INSTANCE; } return this.stubbingListener; }
Source:
<code>public boolean enableApplicationToken(String applicationToken, String sessionToken) { try { String response = transport.execute( SimpleRequestBuilder.buildNewRequest(InterfaceKeys.JSON).addRequestClass(ClassKeys.SYSTEM) .addFunction(FunctionKeys.ENABLE_APPLICATION_TOKEN) .addParameter(ParameterKeys.TOKEN, sessionToken) .addParameter(ParameterKeys.APPLICATION_TOKEN, applicationToken).buildRequestString(), <START> 60000, 60000); <END> return JSONResponseHandler.checkResponse(JSONResponseHandler.toJsonObject(response)); } catch (Exception e) { logger.debug("An exception occurred", e); } return false; }</code><technical_language>magic numbers? Please create constants for them</technical_language>

Target:
public boolean enableApplicationToken(String applicationToken, String sessionToken) { String response = transport.execute(SimpleRequestBuilder.buildNewJsonRequest(ClassKeys.SYSTEM) .addFunction(FunctionKeys.ENABLE_APPLICATION_TOKEN).addParameter(ParameterKeys.TOKEN, sessionToken) .addParameter(ParameterKeys.APPLICATION_TOKEN, applicationToken).buildRequestString(), Config.HIGH_CONNECTION_TIMEOUT, Config.HIGH_READ_TIMEOUT); return JSONResponseHandler.checkResponse(JSONResponseHandler.toJsonObject(response)); }
Source:
<code>public void accept(Event<T> structuredEvent) { try { T data = structuredEvent.getData(); OperationDetails operation = data.getOperation(); var extractor = eventDataExtractorMap.get(operation.getEventType().name().toLowerCase() + "EventDataExtractor"); AuditEvent event = AuditEvent.builder() .withAccountId(operation.getTenant()) .withActor(ActorCrn.builder().withActorCrn(operation.getUserCrn()).build()) .withEventData(extractor.eventData(data)) .withEventName(extractor.eventName(data)) .withEventSource(extractor.eventSource(data)) .withSourceIp(extractor.sourceIp(data)) .build(); auditClient.createAuditEvent(event); } catch (UnsupportedOperationException e) { LOGGER.debug("Audit log is unnecessary: {}", e.getMessage()); } catch (Exception e) { LOGGER.error("Cannot perform auditing: {}", e.getMessage(), e); <START> } <END> }</code><technical_language>followup story</technical_language>

Target:
public void accept(Event<T> structuredEvent) { try { T data = structuredEvent.getData(); OperationDetails operation = data.getOperation(); EventDataExtractor<T> extractor = eventDataExtractorMap.get(operation.getEventType().name().toLowerCase() + "EventDataExtractor"); LOGGER.info("Extract audit event as {}", extractor); AuditEvent event = AuditEvent.builder() .withAccountId(operation.getTenant()) .withActor(ActorCrn.builder().withActorCrn(operation.getUserCrn()).build()) .withEventData(extractor.eventData(data)) .withEventName(extractor.eventName(data)) .withEventSource(extractor.eventSource(data)) .withSourceIp(extractor.sourceIp(data)) .build(); auditClient.createAuditEvent(event); } catch (UnsupportedOperationException e) { LOGGER.debug("Audit log is unnecessary: {}", e.getMessage()); } catch (Exception e) { LOGGER.error("Cannot perform auditing: {}", e.getMessage(), e); } }
Source:
<code>private static byte[] toBytes(UUID uuid) { byte[] out = new byte[16]; long msb = uuid.getMostSignificantBits(); for (int i = 0; i < 8; i++) { <START> out[i] = (byte) ((msb >> ((7 - i) * 8)) & 0xff); <END> } long lsb = uuid.getLeastSignificantBits(); for (int i = 8; i < 16; i++) { out[i] = (byte) ((lsb >> ((15 - i) * 8)) & 0xff); } return out; }</code><technical_language>Nit: I mask is unnecessary, cast byte higher-order bytes discarded. suggestion out[i] = (byte) (msb >> ((7 - i) * 8));</technical_language>

Target:
private static byte[] toBytes(UUID uuid) { byte[] out = new byte[16]; long msb = uuid.getMostSignificantBits(); for (int i = 0; i < 8; i++) { out[i] = (byte) (msb >> (7 - i) * 8); } long lsb = uuid.getLeastSignificantBits(); for (int i = 8; i < 16; i++) { out[i] = (byte) (lsb >> (15 - i) * 8); } return out; }
Source:
<code>void handleRevocation(final Collection<TopicPartition> revokedPartitions) { <START> if (activeTaskIds().isEmpty()) { <END> log.debug("Consumer revoked partitions with no active tasks currently owned, will need to rejoin the group."); return; } final Set<TaskId> revokedTasks = new HashSet<>(); final Set<TopicPartition> remainingPartitions = new HashSet<>(revokedPartitions); for (final Task task : tasks.values()) { if (remainingPartitions.containsAll(task.inputPartitions())) { revokedTasks.add(task.id()); } remainingPartitions.removeAll(task.inputPartitions()); } if (!remainingPartitions.isEmpty()) { throw new IllegalStateException("Some revoked partitions that do not belong " + "to any tasks remain: " + remainingPartitions); } for (final TaskId taskId : revokedTasks) { final Task task = tasks.get(taskId); task.suspend(); } }</code><technical_language>discussed this @abbccdda discussing another PR: <LINK_0> turns out in handleRevocation throw IllegalStateException all, KIP-429 handleAssignment triggered streams-assignor close tasks handleRevocation is triggered tasks suspended, remove throw statement replaced a info log only</technical_language>

Target:
void handleRevocation(final Collection<TopicPartition> revokedPartitions) { final Set<TopicPartition> remainingPartitions = new HashSet<>(revokedPartitions); for (final Task task : tasks.values()) { if (remainingPartitions.containsAll(task.inputPartitions())) { task.suspend(); } remainingPartitions.removeAll(task.inputPartitions()); } if (!remainingPartitions.isEmpty()) { log.warn("The following partitions are missing from the task partitions. It could potentially " + "due to race condition of consumer detecting the heartbeat failure, or the tasks " + "have been cleaned up by the handleAssignment callback.", remainingPartitions); } }
Source:
<code>public static SrlBankProblem mongoGetBankProblem(final Authenticator authenticator, final DB dbs, final String authId, final String problemBankId) throws AuthenticationException, DatabaseAccessException { <START> final DBCollection collection = dbs.getCollection(getCollectionFromType(School.ItemType.BANK_PROBLEM)); <END> final DBObject mongoBankProblem = collection.findOne(convertStringToObjectId(problemBankId)); if (mongoBankProblem == null) { throw new DatabaseAccessException("bank problem can not be found with id: " + problemBankId); } final Authentication.AuthType authType = Authentication.AuthType.newBuilder() .setCheckAccess(true) .setCheckingAdmin(true) .build(); final AuthenticationResponder responder = authenticator .checkAuthentication(School.ItemType.BANK_PROBLEM, problemBankId, authId, 0, authType); if (!responder.hasStudentPermission() && responder.isRegistrationRequired()) { throw new AuthenticationException(AuthenticationException.INVALID_PERMISSION); } return extractBankProblem(mongoBankProblem, problemBankId, responder.hasTeacherPermission()); }</code><technical_language>please change name problemBank problemBankCollection problemCollection</technical_language>

Target:
public static SrlBankProblem mongoGetBankProblem(final Authenticator authenticator, final DB dbs, final String authId, final String problemBankId) throws AuthenticationException, DatabaseAccessException { final DBCollection bankProblemCollection = dbs.getCollection(getCollectionFromType(School.ItemType.BANK_PROBLEM)); final DBObject mongoBankProblem = bankProblemCollection.findOne(convertStringToObjectId(problemBankId)); if (mongoBankProblem == null) { throw new DatabaseAccessException("bank problem can not be found with id: " + problemBankId); } final Authentication.AuthType authType = Authentication.AuthType.newBuilder() .setCheckAccess(true) .setCheckingAdmin(true) .build(); final AuthenticationResponder responder = authenticator .checkAuthentication(School.ItemType.BANK_PROBLEM, problemBankId, authId, 0, authType); if (!responder.hasStudentPermission() && responder.isRegistrationRequired()) { throw new AuthenticationException(AuthenticationException.INVALID_PERMISSION); } return extractBankProblem(mongoBankProblem, problemBankId, responder.hasTeacherPermission()); }
Source:
<code>protected void handleTabKey() { AbstractPane[] panes = fRendering.getRenderingPanes(); <START> AbstractPane nextPane = null; <END> if (this instanceof AddressPane) { nextPane = panes[1]; tabAddress = this.fCaretAddress; } else if (this instanceof DataPane) { nextPane = panes[2]; tabAddress = this.fCaretAddress; } else { nextPane = panes[0]; tabAddress = this.fCaretAddress; } nextPane.setCaretAddress(tabAddress); nextPane.fOldSubCellCaretPosition = 0; nextPane.fSubCellCaretPosition = 0; nextPane.updateCaret(); nextPane.ensureCaretWithinViewport(); nextPane.setFocus(); }</code><technical_language>Instead of instanceof in if statement (nearly repeated below), I suggest defining nextPane prevPane methods in Rendering. cleaner more flexible</technical_language>

Target:
protected void handleTabKey() { AbstractPane nextPane = fRendering.nextPane(this); switchTo(nextPane); }
Source:
<code>public void removePostShouldSetModificationDateToLastPostInTheTopic(){ Post post1 = new Post(); post1.setCreationDate(new DateTime()); Post post2 = new Post(); post2.setCreationDate(new DateTime()); Topic topic = new Topic(new JCUser(), "title"); topic.addPost(post1); topic.addPost(post2); Post post3 = new Post(); post3.setCreationDate(new DateTime()); topic.addPost(post3); <START> assertEquals(topic.getModificationDate(), post3.getCreationDate()); <END> topic.removePost(post3); assertEquals(topic.getModificationDate(), post2.getCreationDate()); }</code><technical_language>This is case another method. test case in test method</technical_language>

Target:
public void removePostShouldSetModificationDateToLastPostInTheTopic(){ Post post1 = new Post(); post1.setCreationDate(new DateTime()); Post post2 = new Post(); post2.setCreationDate(new DateTime()); Topic topic = new Topic(new JCUser(), "title"); topic.addPost(post1); topic.addPost(post2); Post post3 = new Post(); post3.setCreationDate(new DateTime()); topic.addPost(post3); topic.removePost(post3); assertEquals(topic.getModificationDate(), post2.getCreationDate()); }
Source:
<code>private void runAsync() { CompletableFuture<Response> beforeFuture = beforeInvoke(); if (beforeFuture == null) { invoke(); } else { beforeFuture.whenComplete((rsp, throwable) -> { if (rsp != null) { response = rsp; reply.reply(rsp); onFinally(); } else if (throwable != null) { <START> afterCommandException(unwrap(throwable)); <END> } else { invoke(); } }); } }</code><technical_language>onFinally() called well</technical_language>

Target:
private void runAsync() { CompletableFuture<Response> beforeFuture = beforeInvoke(); if (beforeFuture == null) { invoke(); } else { beforeFuture.whenComplete((rsp, throwable) -> { if (rsp != null) { response = rsp; reply.reply(rsp); onFinally(); } else if (throwable != null) { afterCommandException(unwrap(throwable)); reply.reply(response); onFinally(); } else { invoke(); } }); } }
Source:
<code>public CommandExecutor lookupKieSession(String kieSessionId, KieContainerInstance containerInstance, KieServerRegistry registry) { CommandExecutor ks = null; if( kieSessionId != null ) { KieSessionModel ksm = containerInstance.getKieContainer().getKieSessionModel(kieSessionId); if( ksm != null ) { switch (ksm.getType() ) { case STATEFUL: ks = ((KieContainerImpl)containerInstance.getKieContainer()).getKieSession(kieSessionId); break; case STATELESS: ks = ((KieContainerImpl)containerInstance.getKieContainer()).getStatelessKieSession(kieSessionId); break; } } PrometheusKieServerExtension extension = (PrometheusKieServerExtension)registry.getServerExtension(PrometheusKieServerExtension.EXTENSION_NAME); if (extension != null && ks != null) { RuleRuntimeEventManager eventManager = (RuleRuntimeEventManager)ks; <START> extension.getDroolsListeners(kieSessionId, containerInstance).forEach(l -> eventManager.addEventListener(l)); <END> } return ks; } return null; }</code><technical_language>@vblagoje check if default listener isnt added listeners collection</technical_language>

Target:
public CommandExecutor lookupKieSession(String kieSessionId, KieContainerInstance containerInstance, KieServerRegistry registry) { CommandExecutor ks = null; if( kieSessionId != null ) { KieSessionModel ksm = containerInstance.getKieContainer().getKieSessionModel(kieSessionId); if( ksm != null ) { switch (ksm.getType() ) { case STATEFUL: ks = ((KieContainerImpl)containerInstance.getKieContainer()).getKieSession(kieSessionId); break; case STATELESS: ks = ((KieContainerImpl)containerInstance.getKieContainer()).getStatelessKieSession(kieSessionId); break; } } PrometheusKieServerExtension extension = (PrometheusKieServerExtension)registry.getServerExtension(PrometheusKieServerExtension.EXTENSION_NAME); if (extension != null && ks != null) { RuleRuntimeEventManager eventManager = (RuleRuntimeEventManager) ks; PrometheusMetricsDroolsListener listener = new PrometheusMetricsDroolsListener(PrometheusKieServerExtension.getMetrics(), kieSessionId, containerInstance); eventManager.addEventListener(listener); List<AgendaEventListener> droolsListeners = extension.getDroolsListeners(kieSessionId, containerInstance); droolsListeners.forEach(l -> { if (!eventManager.getAgendaEventListeners().contains(l)) { eventManager.addEventListener(l); } }); } return ks; } return null; }
Source:
<code>private static TaskEditor getMockEditor() { TaskEditor editor = mock(TaskEditor.class); <START> TaskEditorInput input = mock(TaskEditorInput.class); <END> when(editor.getTaskEditorInput()).thenReturn(input); when(input.getTask()).thenReturn(linkedTask); return editor; }</code><technical_language>TaskEditorInput created - need a mock</technical_language>

Target:
private static TaskEditor getMockEditor() { TaskEditor editor = mock(TaskEditor.class); when(editor.getTaskEditorInput()).thenReturn(taskEditorInput); return editor; }
Source:
<code>public void testSerDeser() throws IOException { ObjectMapper mapper = new DefaultObjectMapper(); Assert.assertEquals(loadingCache, mapper.readerFor(LoadingCache.class).readValue(mapper.writeValueAsString(loadingCache))); <START> Assert.assertTrue(loadingCache.hashCode() == mapper.readerFor(LoadingCache.class).readValue(mapper.writeValueAsString(loadingCache)).hashCode()); <END> }</code><technical_language>assertEquals</technical_language>

Target:
public void testSerDeser() throws IOException { ObjectMapper mapper = new DefaultObjectMapper(); Assert.assertEquals(loadingCache, mapper.readerFor(LoadingCache.class).readValue(mapper.writeValueAsString(loadingCache))); Assert.assertEquals(loadingCache.hashCode(), mapper.readerFor(LoadingCache.class).readValue(mapper.writeValueAsString(loadingCache)).hashCode()); }
Source:
<code>public XYTimeQueryFilter(long start, long end, int n, Collection<Long> entryIds) { super(start, end, n); <START> fEntryIds = Collections.unmodifiableCollection(entryIds); <END> }</code><technical_language>This is good, is a true defensive copy. If I give entryIDs change values, in a world of annoying debug</technical_language>

Target:
public XYTimeQueryFilter(long start, long end, int n, Collection<Long> entryIds) { super(start, end, n); fEntryIds = ImmutableList.copyOf(entryIds); }
Source:
<code>String getSuiteUid(ITestContext iTestContext) { String uid; String suite = getCurrentSuiteName(iTestContext); if (suiteUid.containsKey(suite)){ <START> uid=suiteUid.get(suite); <END> } else { uid=UUID.randomUUID().toString(); suiteUid.put(suite, uid); } return uid; }</code><technical_language>same, add indent please</technical_language>

Target:
String getSuiteUid(ITestContext iTestContext) { String uid; String suite = getCurrentSuiteTitle(iTestContext); if (suiteUid.containsKey(suite)){ uid = suiteUid.get(suite); } else { uid = UUID.randomUUID().toString(); suiteUid.put(suite, uid); } return uid; }
Source:
<code>public SpongeDyeableData(DyeColor dyeColor) { <START> super(DyeableData.class, dyeColor, Keys.DYE_COLOR, ImmutableDyeableData.class); <END> }</code><technical_language>remove this</technical_language>

Target:
public SpongeDyeableData(DyeColor dyeColor) { super(DyeableData.class, checkNotNull(dyeColor), Keys.DYE_COLOR, ImmutableDyeableData.class); }
Source:
<code>void flushStoredSessions() { if (flushingRequest.tryAcquire(1)) { try { List<File> storedFiles; storedFiles = sessionStore.findStoredFiles(); if (!storedFiles.isEmpty()) { SessionTrackingPayload payload = new SessionTrackingPayload(storedFiles, client.appData); try { configuration.getDelivery().deliver(payload, configuration); sessionStore.deleteStoredFiles(storedFiles); } catch (NetworkException exception) { sessionStore.cancelQueuedFiles(storedFiles); <START> Logger.info("Failed to post stored session payload"); <END> } catch (BadResponseException exception) { Logger.warn("Invalid session tracking payload", exception); sessionStore.deleteStoredFiles(storedFiles); } } } finally { flushingRequest.release(1); } } }</code><technical_language>exception logged</technical_language>

Target:
void flushStoredSessions() { if (flushingRequest.tryAcquire(1)) { try { List<File> storedFiles; storedFiles = sessionStore.findStoredFiles(); if (!storedFiles.isEmpty()) { SessionTrackingPayload payload = new SessionTrackingPayload(storedFiles, client.appData); try { configuration.getDelivery().deliver(payload, configuration); sessionStore.deleteStoredFiles(storedFiles); } catch (DeliveryFailureException exception) { sessionStore.cancelQueuedFiles(storedFiles); Logger.warn("Leaving session payload for future delivery", exception); } catch (Exception exception) { Logger.warn("Deleting invalid session tracking payload", exception); sessionStore.deleteStoredFiles(storedFiles); } } } finally { flushingRequest.release(1); } } }
Source:
<code>public SubordinateAtomicAction (int timeout) { super(); <START> dynamic1PC = false; <END> start(); if (timeout > AtomicAction.NO_TIMEOUT) TransactionReaper.transactionReaper().insert(this, timeout); }</code><technical_language>do disable optimisation for subordinates for ServerTransaction</technical_language>

Target:
public SubordinateAtomicAction (int timeout) { super(); subordinate = true; start(); if (timeout > AtomicAction.NO_TIMEOUT) TransactionReaper.transactionReaper().insert(this, timeout); }
Source:
<code>public static void closeSecondaryShells(SWTWorkbenchBot bot) { SWTBotShell[] shells = bot.shells(); SWTBotShell mainShell = getMainShell(shells); if (mainShell == null) { return; } for (SWTBotShell shell : shells) { boolean visible = shell.isVisible(); <START> if (shell != mainShell && visible) { <END> shell.close(); } } }</code><technical_language>a test spawn a separate shell is visible (a new window?). close shells mainShell</technical_language>

Target:
public static void closeSecondaryShells(SWTWorkbenchBot bot) { SWTBotShell[] shells = bot.shells(); SWTBotShell mainShell = getMainShell(shells); if (mainShell == null) { return; } Arrays.stream(shells) .filter(shell -> shell != mainShell) .filter(SWTBotShell::isVisible) .forEach(SWTBotShell::close); }
Source:
<code>private IndexMetaData getIndexMetaData(String indexAlias) throws DotDataException { String indexName = null; boolean defaultIndex = false; long recordCount = 0; if (UtilMethods.isSet(indexAlias)) { indexAlias = indexAlias.split("\\s+")[0]; final List<String> indices = siteSearchAPI.listIndices(); final Map<String, String> aliasMap = esIndexAPI.getAliasToIndexMap(indices); indexName = aliasMap.get(indexAlias); if (UtilMethods.isSet(indexName)) { if (siteSearchAPI.isDefaultIndex(indexAlias)) { Logger.info(this, "Index is current Site-Search DEFAULT."); defaultIndex = true; } } else { if(indices.contains(indexAlias)){ indexName = indexAlias; <START> indexAlias = null; <END> } } if(UtilMethods.isSet(indexName)){ final SiteSearchResults search = siteSearchAPI.search(indexName, "*",0, 10); recordCount = search.getTotalResults(); } } return new IndexMetaData(indexName, defaultIndex, indexAlias, recordCount == 0); }</code><technical_language>![Codacy](<LINK_0> Issue found: [Assigning Object null is a code smell. Consider refactoring.](<LINK_1></technical_language>

Target:
private IndexMetaData getIndexMetaData(String indexAlias) throws DotDataException { String indexName = null; boolean defaultIndex = false; long recordCount = 0; if (UtilMethods.isSet(indexAlias)) { indexAlias = indexAlias.split("\\s+")[0]; final List<String> indices = siteSearchAPI.listIndices(); final Map<String, String> aliasMap = esIndexAPI.getAliasToIndexMap(indices); indexName = aliasMap.get(indexAlias); if (UtilMethods.isSet(indexName)) { if (siteSearchAPI.isDefaultIndex(indexAlias)) { Logger.info(SiteSearchJobImpl.class, String.format("Index `%s` is currently Site-Search DEFAULT.",indexAlias)); defaultIndex = true; } } else { if(indices.contains(indexAlias)){ indexName = indexAlias; indexAlias = null; } } if(UtilMethods.isSet(indexName)){ final SiteSearchResults search = siteSearchAPI.search(indexName, "*",0, 10); recordCount = search.getTotalResults(); } } return new IndexMetaData(indexName, defaultIndex, indexAlias, recordCount == 0); }
Source:
<code>public ArgumentListBuilder toWindowsCommand(boolean escapeVars) { <START> ArgumentListBuilder windowsCommand = new ArgumentListBuilder().add("cmd.exe", "/C"); <END> boolean quoted, percent; for (int i = 0; i < args.size(); i++) { StringBuilder quotedArgs = new StringBuilder(); String arg = args.get(i); quoted = percent = false; for (int j = 0; j < arg.length(); j++) { char c = arg.charAt(j); if (!quoted && (c == ' ' || c == '*' || c == '?' || c == ',' || c == ';')) { quoted = startQuoting(quotedArgs, arg, j); } else if (c == '^' || c == '&' || c == '<' || c == '>' || c == '|') { if (!quoted) quoted = startQuoting(quotedArgs, arg, j); } else if (c == '"') { if (!quoted) quoted = startQuoting(quotedArgs, arg, j); quotedArgs.append('"'); } else if (percent && escapeVars && ((c >= 'A' && c <= 'Z') || (c >= 'a' && c <= 'z'))) { if (!quoted) quoted = startQuoting(quotedArgs, arg, j); quotedArgs.append('"').append(c); c = '"'; } percent = (c == '%'); if (quoted) quotedArgs.append(c); } if(i == 0) quotedArgs.append('"'); if (quoted) quotedArgs.append('"'); else quotedArgs.append(arg); windowsCommand.add(quotedArgs, mask.get(i)); } windowsCommand.add("&&").add("exit").add("%%ERRORLEVEL%%\""); return windowsCommand; }</code><technical_language>NIT: tabulation issue</technical_language>

Target:
public ArgumentListBuilder toWindowsCommand(boolean escapeVars) { ArgumentListBuilder windowsCommand = new ArgumentListBuilder().add("cmd.exe", "/C"); boolean quoted, percent; for (int i = 0; i < args.size(); i++) { StringBuilder quotedArgs = new StringBuilder(); String arg = args.get(i); quoted = percent = false; for (int j = 0; j < arg.length(); j++) { char c = arg.charAt(j); if (!quoted && (c == ' ' || c == '*' || c == '?' || c == ',' || c == ';')) { quoted = startQuoting(quotedArgs, arg, j); } else if (c == '^' || c == '&' || c == '<' || c == '>' || c == '|') { if (!quoted) quoted = startQuoting(quotedArgs, arg, j); } else if (c == '"') { if (!quoted) quoted = startQuoting(quotedArgs, arg, j); quotedArgs.append('"'); } else if (percent && escapeVars && ((c >= 'A' && c <= 'Z') || (c >= 'a' && c <= 'z'))) { if (!quoted) quoted = startQuoting(quotedArgs, arg, j); quotedArgs.append('"').append(c); c = '"'; } percent = (c == '%'); if (quoted) quotedArgs.append(c); } if(i == 0 && quoted) quotedArgs.insert(0, '"'); else if (i == 0 && !quoted) quotedArgs.append('"'); if (quoted) quotedArgs.append('"'); else quotedArgs.append(arg); windowsCommand.add(quotedArgs, mask.get(i)); } windowsCommand.add("&&").add("exit").add("%%ERRORLEVEL%%\""); return windowsCommand; }
Source:
<code>private String getGlobalProperty(String globalPropertyName, boolean required) { String globalProperty = administrationService.getGlobalProperty(globalPropertyName); <START> if (required && StringUtils.isEmpty(globalProperty)) { <END> throw new IllegalStateException("Configuration required: " + globalPropertyName); } return globalProperty; }</code><technical_language>@bgeVam please isBlank</technical_language>

Target:
private String getGlobalProperty(String globalPropertyName, boolean required) { final String result = administrationService.getGlobalProperty(globalPropertyName); if (required && StringUtils.isBlank(result)) { throw new IllegalStateException("Configuration required: " + globalPropertyName); } return result; }
Source:
<code>public void beforeEach(ExtensionContext extensionContext) throws Exception { Optional<ExtensionContext> currentContext = Optional.of(extensionContext); while (currentContext.isPresent()) { ExtensionContext context = currentContext.get(); <START> Object testInstance = context.getStore(ASSERTJ_CORE).remove(TEST_INSTANCE); <END> if (testInstance != null) { List<Field> softlyFields = AnnotationSupport.findAnnotatedFields(testInstance.getClass(), Softly.class); if (!softlyFields.isEmpty()) { if (softlyFields.size() > 1) { throw failures.failure("Only one field of type " + SoftAssertions.class.getName() + " can have the annotation @Softly"); } Field softlyField = softlyFields.get(0); if (softlyField.getType() != SoftAssertions.class) { throw failures.failure("@Softly field must be of the type " + SoftAssertions.class.getName()); } softlyField.setAccessible(true); softlyField.set(testInstance, new SoftAssertions()); this.softlies.add((SoftAssertions) softlyField.get(testInstance)); } } currentContext = context.getParent(); } if (this.softlies.isEmpty()) { LOGGER.log(Level.WARNING, "\n======================================" + "\nNo instance of soft assertions detected" + "\n======================================"); } }</code><technical_language>removing instead of simply it? is some concurrency issue seeing</technical_language>

Target:
public void beforeEach(ExtensionContext extensionContext) throws Exception { Optional<ExtensionContext> currentContext = Optional.of(extensionContext); while (currentContext.isPresent()) { ExtensionContext context = currentContext.get(); Object testInstance = context.getStore(ASSERTJ_CORE).remove(TEST_INSTANCE); if (testInstance != null) { List<Field> softlyFields = AnnotationSupport.findAnnotatedFields(testInstance.getClass(), Softly.class); if (!softlyFields.isEmpty()) { if (softlyFields.size() > 1) { throw failures.failure("Only one field of type " + SoftAssertions.class.getName() + " can have the annotation @Softly"); } if (context.getTestInstanceLifecycle().isPresent() && context.getTestInstanceLifecycle().get() == PER_CLASS) { throw failures.failure("@Softly annotation not permitted in test class with life cycle PER_CLASS"); } Field softlyField = softlyFields.get(0); if (softlyField.getType() != SoftAssertions.class) { throw failures.failure("@Softly field must be of the type " + SoftAssertions.class.getName()); } softlyField.setAccessible(true); softlyField.set(testInstance, new SoftAssertions()); this.softlies.add((SoftAssertions) softlyField.get(testInstance)); } } currentContext = context.getParent(); } if (this.softlies.isEmpty()) { LOGGER.log(Level.WARNING, "\n======================================" + "\nNo instance of soft assertions detected" + "\n======================================"); } }
Source:
<code><START> public void setup() throws InterruptedException, KeeperException.NoNodeException { <END> System.setProperty(authProvider, superDigest); QuorumPeerConfig.setReconfigEnabled(false); qu = new QuorumUtil(1); qu.disableJMXTest = true; try { qu.startAll(); } catch (IOException e) { Assert.fail("Fail to start quorum servers."); } resetZKAdmin(); }</code><technical_language>throw NoNodeException anymore</technical_language>

Target:
public void setup() throws InterruptedException { System.setProperty(authProvider, superDigest); QuorumPeerConfig.setReconfigEnabled(false); qu = new QuorumUtil(1); qu.disableJMXTest = true; try { qu.startAll(); } catch (IOException e) { Assert.fail("Fail to start quorum servers."); } resetZKAdmin(); }
Source:
<code>protected int <START> getSideFromRectangle(Point <END> pt) { while (includedRect.contains(pt)) { includedRect.shrink(1, 1); } int side = includedRect.getPosition(pt); return side; }</code><technical_language>missing @since</technical_language>

Target:
protected int getSideFromRectangle(Point pt) { while (getIncludedRect().contains(pt)) { getIncludedRect().shrink(1, 1); } int side = getIncludedRect().getPosition(pt); return side; }
Source:
<code>public <T, P extends PartitionLocation<T>> File fetchSegmentFile( File partitionDir, String supervisorTaskId, P location ) throws IOException { <START> final byte[] buffer = new byte[BUFFER_SIZE]; <END> final File zippedFile = new File(partitionDir, StringUtils.format("temp_%s", location.getSubTaskId())); final URI uri = location.toIntermediaryDataServerURI(supervisorTaskId); FileUtils.copyLarge( uri, u -> { try { return httpClient.go(new Request(HttpMethod.GET, u.toURL()), new InputStreamResponseHandler()) .get(); } catch (InterruptedException | ExecutionException e) { throw new RuntimeException(e); } }, zippedFile, buffer, t -> t instanceof IOException, NUM_FETCH_RETRIES, StringUtils.format("Failed to fetch file[%s]", uri) ); return zippedFile; }</code><technical_language>This previously a class member variable, allocated once. Is a reason changed here</technical_language>

Target:
public <T, P extends PartitionLocation<T>> File fetchSegmentFile( File partitionDir, String supervisorTaskId, P location ) throws IOException { final byte[] buffer = new byte[BUFFER_SIZE]; final File zippedFile = new File(partitionDir, StringUtils.format("temp_%s", location.getSubTaskId())); final URI uri = location.toIntermediaryDataServerURI(supervisorTaskId); FileUtils.copyLarge( uri, u -> { try { return httpClient.go(new Request(HttpMethod.GET, u.toURL()), new InputStreamResponseHandler()) .get(); } catch (InterruptedException | ExecutionException e) { throw new IOException(e); } }, zippedFile, buffer, t -> t instanceof IOException, NUM_FETCH_RETRIES, StringUtils.format("Failed to fetch file[%s]", uri) ); return zippedFile; }