auphong2707/dl4se-code-review-dataset huggingface dataset:
Source:
<code>public static Identity extractIdentity(EndpointContext context) { InetSocketAddress peerAddress = context.getPeerAddress(); if (context.get(OSCoreEndpointContextInfo.OSCORE_SENDER_ID) != null) { String oscoreIdentity = "sid=" + context.get(OSCoreEndpointContextInfo.OSCORE_SENDER_ID) + ",rid=" + context.get(OSCoreEndpointContextInfo.OSCORE_RECIPIENT_ID); return Identity.oscoreOnly(peerAddress, oscoreIdentity.toLowerCase()); <START> } <END> Principal senderIdentity = context.getPeerIdentity(); if (senderIdentity != null) { if (senderIdentity instanceof PreSharedKeyIdentity) { return Identity.psk(peerAddress, ((PreSharedKeyIdentity) senderIdentity).getIdentity()); } else if (senderIdentity instanceof RawPublicKeyIdentity) { PublicKey publicKey = ((RawPublicKeyIdentity) senderIdentity).getKey(); return Identity.rpk(peerAddress, publicKey); } else if (senderIdentity instanceof X500Principal || senderIdentity instanceof X509CertPath) { String x509CommonName = extractCN(senderIdentity.getName()); return Identity.x509(peerAddress, x509CommonName); } throw new IllegalStateException("Unable to extract sender identity : unexpected type of Principal"); } return Identity.unsecure(peerAddress); }</code><technical_language>This done in else block of code above. (senderIdentity == null)</technical_language>

Target:
public static Identity extractIdentity(EndpointContext context) { InetSocketAddress peerAddress = context.getPeerAddress(); Principal senderIdentity = context.getPeerIdentity(); if (senderIdentity != null) { if (senderIdentity instanceof PreSharedKeyIdentity) { return Identity.psk(peerAddress, ((PreSharedKeyIdentity) senderIdentity).getIdentity()); } else if (senderIdentity instanceof RawPublicKeyIdentity) { PublicKey publicKey = ((RawPublicKeyIdentity) senderIdentity).getKey(); return Identity.rpk(peerAddress, publicKey); } else if (senderIdentity instanceof X500Principal || senderIdentity instanceof X509CertPath) { String x509CommonName = extractCN(senderIdentity.getName()); return Identity.x509(peerAddress, x509CommonName); } throw new IllegalStateException("Unable to extract sender identity : unexpected type of Principal"); } else { if (context.get(OSCoreEndpointContextInfo.OSCORE_SENDER_ID) != null) { String oscoreIdentity = "sid=" + context.get(OSCoreEndpointContextInfo.OSCORE_SENDER_ID) + ",rid=" + context.get(OSCoreEndpointContextInfo.OSCORE_RECIPIENT_ID); return Identity.oscoreOnly(peerAddress, oscoreIdentity.toLowerCase()); } } return Identity.unsecure(peerAddress); }
Source:
<code>public boolean[] read(TProtocol protocol) throws Exception { <START> Preconditions.checkNotNull(protocol, "protocol is null"); <END> return new TProtocolReader(protocol).readBoolArray(); }</code><technical_language>Static import</technical_language>

Target:
public boolean[] read(TProtocol protocol) throws Exception { checkNotNull(protocol, "protocol is null"); return new TProtocolReader(protocol).readBoolArray(); }
Source:
<code>protected Cache decorateCache(Cache cache) { <START> return this.cacheDecorator != null ? this.cacheDecorator.decorateCache(cache) : cache; <END> }</code><technical_language>Moving bits allowing user change decorator a public setter means completely shadow AbstractTransactionSupportingCacheManager du public API. Also, if CacheDecorator is a first-class concept, expect more decorator apply a time. This wrapping responsibility of caller</technical_language>

Target:
protected Cache decorateCache(Cache cache) { for (CacheDecorator cacheDecorator : cacheDecorators) { cache = cacheDecorator.decorateCache(cache); } return cache; }
Source:
<code><START> public void generateProjectRepositoriesMap() throws IOException { <END> repository_map.clear(); for (RepositoryInfo r : getRepositories()) { Project proj; String repoPath; try { repoPath = PathUtils.getPathRelativeToSourceRoot( new File(r.getDirectoryName()), 0); } catch (ForbiddenSymlinkException e) { LOGGER.log(Level.FINER, e.getMessage()); continue; } if ((proj = Project.getProject(repoPath)) != null) { List<RepositoryInfo> values = repository_map.computeIfAbsent(proj, k -> new ArrayList<>()); values.add(r); } } }</code><technical_language>this need public ? (esp. repository_map locking is removed)</technical_language>

Target:
private void generateProjectRepositoriesMap() throws IOException { repository_map.clear(); for (RepositoryInfo r : getRepositories()) { Project proj; String repoPath; try { repoPath = PathUtils.getPathRelativeToSourceRoot( new File(r.getDirectoryName()), 0); } catch (ForbiddenSymlinkException e) { LOGGER.log(Level.FINER, e.getMessage()); continue; } if ((proj = Project.getProject(repoPath)) != null) { List<RepositoryInfo> values = repository_map.computeIfAbsent(proj, k -> new ArrayList<>()); values.add(r); } } }
Source:
<code>private IncrementalProjectBuilder getBuilder(IBuildConfiguration buildConfiguration, ICommand command, int buildSpecIndex, MultiStatus status) throws CoreException { BuildCommand buildCommand = (BuildCommand) command; InternalBuilder result = buildCommand.getBuilder(buildConfiguration); String builderName = command.getBuilderName(); IProject project = buildConfiguration.getProject(); if (result == null) { BuilderPersistentInfo info = null; synchronized (builderInitializationLock) { BuilderPersistentInfo builderInitInProgress = getBuilderInitInProgress(project, builderName); if (builderInitInProgress != null) { info = builderInitInProgress; } else { info = removePersistentBuilderInfo(builderName, buildConfiguration, buildSpecIndex); setBuilderInitInProgress(project, builderName, info); } } result = initializeBuilder(builderName, buildConfiguration, info, status); result.setCommand(command); result.setBuildConfig(buildConfiguration); result.startupOnInitialize(); buildCommand.addBuilder(buildConfiguration, (IncrementalProjectBuilder) result); result = buildCommand.getBuilder(buildConfiguration); <START> setBuilderInitInProgress(project, builderName, null); <END> } if (result == null) { return null; } result.setBuildConfig(buildConfiguration); if (!validateNature(result, builderName)) { result.setLastBuiltTree(null); return null; } return (IncrementalProjectBuilder) result; }</code><technical_language>builder is set line 631, check line 622 *could* give a builder, do *must*</technical_language>

Target:
private IncrementalProjectBuilder getBuilder(IBuildConfiguration buildConfiguration, ICommand command, int buildSpecIndex, MultiStatus status) throws CoreException { BuildCommand buildCommand = (BuildCommand) command; InternalBuilder result = buildCommand.getBuilder(buildConfiguration); String builderName = command.getBuilderName(); IProject project = buildConfiguration.getProject(); if (result == null) { BuilderPersistentInfo info = null; synchronized (builderInitializationLock) { BuilderPersistentInfo builderInitInProgress = getBuilderInitInfo(project, builderName); if (builderInitInProgress != null) { info = builderInitInProgress; } else { info = removePersistentBuilderInfo(builderName, buildConfiguration, buildSpecIndex); setBuilderInitInfo(project, builderName, info); } } result = buildCommand.getBuilder(buildConfiguration); if (result == null) { result = initializeBuilder(command, builderName, buildConfiguration, info, status); } synchronized (builderInitializationLock) { InternalBuilder other = buildCommand.getBuilder(buildConfiguration); if (other == null) { buildCommand.addBuilder(buildConfiguration, (IncrementalProjectBuilder) result); } else { result = other; } setBuilderInitInfo(project, builderName, null); } } if (result == null) { return null; } result.setBuildConfig(buildConfiguration); if (!validateNature(result, builderName)) { result.setLastBuiltTree(null); return null; } return (IncrementalProjectBuilder) result; }
Source:
<code>public void createPartControl(Composite parent) { <START> fTreeViewer = new TreeViewer(parent, SWT.MULTI | SWT.V_SCROLL | SWT.H_SCROLL | SWT.VIRTUAL); <END> fTreeViewer.setUseHashlookup(true); fDrillDownAdapter = new DrillDownAdapter(fTreeViewer); fTreeViewer.setContentProvider(new PluginsContentProvider(this)); fTreeViewer.setLabelProvider(new PluginsLabelProvider()); fTreeViewer.setComparator(new ListUtil.PluginComparator() { @Override public int compare(Viewer viewer, Object e1, Object e2) { if (e1 instanceof PendingUpdateAdapter) return -1; else if (e2 instanceof PendingUpdateAdapter) return 1; return super.compare(viewer, e1, e2); } }); initDragAndDrop(); makeActions(); initFilters(); IActionBars actionBars = getViewSite().getActionBars(); contributeToActionBars(actionBars); registerGlobalActions(actionBars); hookContextMenu(); hookDoubleClickAction(); fTreeViewer.addSelectionChangedListener(e -> handleSelectionChanged(e.getSelection())); PDECore.getDefault().getSearchablePluginsManager().addPluginModelListener(this); fTreeViewer.setInput(fRoot = getDeferredTreeRoot()); PDECore.getDefault().getModelManager().addPluginModelListener(this); PDEPlugin.getDefault().getPreferenceStore().addPropertyChangeListener(fPropertyListener); getViewSite().setSelectionProvider(fTreeViewer); PlatformUI.getWorkbench().getHelpSystem().setHelp(fTreeViewer.getControl(), IHelpContextIds.PLUGINS_VIEW); }</code><technical_language>I remove VIRTUAL bit here. content provider is lazy a virtual view work anyway, sorted filtered. Disabling pointless virtual handling in Tree performance</technical_language>

Target:
public void createPartControl(Composite parent) { fTreeViewer = new TreeViewer(parent, SWT.MULTI | SWT.V_SCROLL | SWT.H_SCROLL); fTreeViewer.setUseHashlookup(true); fDrillDownAdapter = new DrillDownAdapter(fTreeViewer); fTreeViewer.setContentProvider(new PluginsContentProvider(this)); fTreeViewer.setLabelProvider(new PluginsLabelProvider()); fTreeViewer.setComparator(new ListUtil.PluginComparator() { @Override public int compare(Viewer viewer, Object e1, Object e2) { if (e1 instanceof PendingUpdateAdapter) return -1; else if (e2 instanceof PendingUpdateAdapter) return 1; return super.compare(viewer, e1, e2); } }); initDragAndDrop(); makeActions(); initFilters(); IActionBars actionBars = getViewSite().getActionBars(); contributeToActionBars(actionBars); registerGlobalActions(actionBars); hookContextMenu(); hookDoubleClickAction(); fTreeViewer.addSelectionChangedListener(e -> handleSelectionChanged(e.getSelection())); PDECore.getDefault().getSearchablePluginsManager().addPluginModelListener(this); fTreeViewer.setInput(fRoot = getDeferredTreeRoot()); PDECore.getDefault().getModelManager().addPluginModelListener(this); PDEPlugin.getDefault().getPreferenceStore().addPropertyChangeListener(fPropertyListener); getViewSite().setSelectionProvider(fTreeViewer); PlatformUI.getWorkbench().getHelpSystem().setHelp(fTreeViewer.getControl(), IHelpContextIds.PLUGINS_VIEW); }
Source:
<code>public void onBackPressed(){ <START> if (mEtSubject.getText().length() > 0 || mEtMessage.formattedToText().length() > 0) { <END> long draftId = saveDraft(); Intent resultIntent = new Intent(); resultIntent.putExtra(HomeActivity.SAVED_ID, draftId); setResult(HomeActivity.RESULT_SAVE_DRAFT, resultIntent); finish(); } else { super.onBackPressed(); } }</code><technical_language>!isEmpty() instead of length() > 0</technical_language>

Target:
public void onBackPressed(){ if (!mEtSubject.getText().toString().isEmpty() || !mEtMessage.formattedToText().isEmpty()) { long draftId = saveDraft(); Intent resultIntent = new Intent(); resultIntent.putExtra(HomeActivity.SAVED_ID, draftId); setResult(HomeActivity.RESULT_SAVE_DRAFT, resultIntent); finish(); } else { super.onBackPressed(); } }
Source:
<code>protected String doPost(String apiUrl, Map<String,String> data) throws Exception { String fullUrl = BASE_URL + apiUrl; OkHttpClient okHttpClient = new OkHttpClient(); FormBody.Builder formBodyBuilder = new FormBody.Builder(); <START> if (data!=null) { <END> if (data.size() > 0) { for (Map.Entry<String,String> entry : data.entrySet()) { formBodyBuilder.add(entry.getKey(), entry.getValue()); } } } if (_clientId != null) { formBodyBuilder.add("clientUUID", _clientId); } System.out.println("Full Url is :"+ fullUrl); RequestBody body = formBodyBuilder.build(); Request.Builder formBody = new Request.Builder() .url(fullUrl) .post(body) .addHeader("Content-Type", "application/json; charset=utf-8"); Request request = formBody.build(); Response response = okHttpClient.newCall(request).execute(); return response.body().string().trim(); }</code><technical_language>remove unneeded nesting do data != null || !data.isEmpty()</technical_language>

Target:
protected String doPost(String apiUrl, Map<String,String> data) throws Exception { String fullUrl = BASE_URL + apiUrl; FormBody.Builder formBodyBuilder = new FormBody.Builder(); if ((data != null) && !data.isEmpty()) { for (Map.Entry<String,String> entry : data.entrySet()) { formBodyBuilder.add(entry.getKey(), entry.getValue()); } } if (_clientId != null) { formBodyBuilder.add("clientUUID", _clientId); } RequestBody body = formBodyBuilder.build(); Request.Builder formBody = new Request.Builder() .url(fullUrl) .post(body) .addHeader("Content-Type", "application/json; charset=utf-8"); Request request = formBody.build(); Response response = okHttpClient.newCall(request).execute(); return response.body().string().trim(); }
Source:
<code>private StreamPartitionCountMonitor getPartitionCountMonitor(Config config, SystemAdmins systemAdmins) { StreamMetadataCache streamMetadata = new StreamMetadataCache(systemAdmins, 0, SystemClock.instance()); Set<SystemStream> inputStreamsToMonitor = new TaskConfigJava(config).getAllInputStreams(); if (inputStreamsToMonitor.isEmpty()) { throw new SamzaException("Input streams to a job can not be empty."); } Map<String, Pattern> inputRegexesToMonitor = inputStreamsToMonitor.stream() <START> .collect(Collectors.toMap(x -> x.getSystem(), x -> new JobConfig(config).getRegexToMonitor(x.getSystem()))) <END> .entrySet() .stream() .filter(x -> x.getValue().isDefined()) .collect(Collectors.toMap(Map.Entry::getKey, x -> Pattern.compile(x.getValue().get()))); return new StreamPartitionCountMonitor(inputStreamsToMonitor, inputRegexesToMonitor, streamMetadata, metrics, new JobConfig(config).getMonitorPartitionChangeFrequency(), new JobConfig(config).getMonitorInputRegexFrequency(), new StreamPartitionCountMonitor.Callback() { @Override public void onSystemStreamPartitionChange(Set<SystemStream> streamsChanged) { if (hasDurableStores) { log.error("Input topic partition count changed in a job with durable state. Failing the job."); state.status = SamzaApplicationState.SamzaAppStatus.FAILED; } coordinatorException = new PartitionChangeException("Input topic partition count changes detected."); } @Override public void onNewInputStreamsDiscovered(Set<SystemStream> newStreams) { log.error("New input system-streams discovered. Failing the job. New input streams: {}", newStreams, " Existing input streams:", inputStreamsToMonitor); state.status = SamzaApplicationState.SamzaAppStatus.FAILED; coordinatorException = new InputStreamsDiscoveredException("New input streams added: " + newStreams); } }); }</code><technical_language>prefer add a new config this auto-inferred input regexes.. In other words, if a Regex-rewriter defined, monitoring is enabled, instantiate this class</technical_language>

Target:
private Optional<StreamPartitionCountMonitor> getPartitionCountMonitor(Config config, SystemAdmins systemAdmins) { StreamMetadataCache streamMetadata = new StreamMetadataCache(systemAdmins, 0, SystemClock.instance()); Set<SystemStream> inputStreamsToMonitor = new TaskConfigJava(config).getAllInputStreams(); if (inputStreamsToMonitor.isEmpty()) { throw new SamzaException("Input streams to a job can not be empty."); } return Optional.of(new StreamPartitionCountMonitor(inputStreamsToMonitor, streamMetadata, metrics, new JobConfig(config).getMonitorPartitionChangeFrequency(), streamsChanged -> { if (hasDurableStores) { log.error("Input topic partition count changed in a job with durable state. Failing the job."); state.status = SamzaApplicationState.SamzaAppStatus.FAILED; } coordinatorException = new PartitionChangeException("Input topic partition count changes detected."); })); }
Source:
<code>private static OperatingSystem mapOperatingSystem(VDS entity) { final OperatingSystem model = new OperatingSystem(); if (StringUtils.isNotBlank(entity.getHostOs())) { OS hostOs = OS.fromPackageVersionString(entity.getHostOs()); Version version = new Version(); <START> version.setMajor(hostOs.getVersion().getMajor()); <END> if (hostOs.getVersion().getMinor() != org.ovirt.engine.core.compat.Version.VERSION_NOT_SET) { version.setMinor(hostOs.getVersion().getMinor()); } if (hostOs.getVersion().getBuild() != org.ovirt.engine.core.compat.Version.VERSION_NOT_SET) { version.setBuild(hostOs.getVersion().getBuild()); } version.setFullVersion(hostOs.getFullVersion()); model.setVersion(version); model.setType(hostOs.getName()); } model.setCustomKernelCmdline(Objects.toString(entity.getCurrentKernelCmdline(), "")); model.setReportedKernelCmdline(entity.getKernelArgs()); return model; }</code><technical_language>if major is -1</technical_language>

Target:
private static OperatingSystem mapOperatingSystem(VDS entity) { final OperatingSystem model = new OperatingSystem(); if (StringUtils.isNotBlank(entity.getHostOs())) { OS hostOs = OS.fromPackageVersionString(entity.getHostOs()); Version version = new Version(); if (hostOs.getVersion().getMajor() != org.ovirt.engine.core.compat.Version.VERSION_NOT_SET) { version.setMajor(hostOs.getVersion().getMajor()); } if (hostOs.getVersion().getMinor() != org.ovirt.engine.core.compat.Version.VERSION_NOT_SET) { version.setMinor(hostOs.getVersion().getMinor()); } if (hostOs.getVersion().getBuild() != org.ovirt.engine.core.compat.Version.VERSION_NOT_SET) { version.setBuild(hostOs.getVersion().getBuild()); } version.setFullVersion(hostOs.getFullVersion()); model.setVersion(version); model.setType(hostOs.getName()); } model.setCustomKernelCmdline(Objects.toString(entity.getCurrentKernelCmdline(), "")); model.setReportedKernelCmdline(entity.getKernelArgs()); return model; }
Source:
<code>public List<CcJudgmentKeyword> findAllByPhrasePart(String phrasePart) { Query query = entityManager.createQuery("select keyword from " + CcJudgmentKeyword.class.getName() + " keyword where lower(keyword.phrase) like :phrasePart"); query.setParameter("phrasePart", phrasePart.toLowerCase() + "%"); List<CcJudgmentKeyword> keywords = query.getResultList(); return keywords; <START> } <END></code><technical_language>Format code pliz, I proper indentions. general rule is sort result of search get result in consecutive executions if parameters change. (We talk a it. I if sorted result phrase, need this KeywordSearchService thing, I for it.)</technical_language>

Target:
public List<CcJudgmentKeyword> findAllByPhrasePart(String phrasePart) { Query query = entityManager.createQuery("select keyword from " + CcJudgmentKeyword.class.getName() + " keyword where lower(keyword.phrase) like :phrasePart order by keyword.phrase asc"); query.setParameter("phrasePart", phrasePart.toLowerCase() + "%"); List<CcJudgmentKeyword> keywords = query.getResultList(); return keywords; }
Source:
<code>public void getEngineTimeStamp(AsyncQuery aQuery) { <START> aQuery.setHandleFailure(true); <END> Frontend.getInstance().runQuery(VdcQueryType.GetEngineTimestamp, new VdcQueryParametersBase(), aQuery); }</code><technical_language>1. if ok error failure get engine time stamp. 2. Failure touch base engine essentially subsequent commands fail of asking for user intervention of nature attempting proceed normal flow of snapshot creation. 3. 1 2 I feel handling failure manually in code is atleast in order close other previous window(ex: snapshot create window) opine</technical_language>

Target:
public void getEngineTimeStamp(AsyncQuery aQuery) { Frontend.getInstance().runQuery(VdcQueryType.GetEngineTimestamp, new VdcQueryParametersBase(), aQuery); }
Source:
<code>public void waitProjectExplorer(int timeout) { try { seleniumWebDriverHelper.waitVisibility(By.id(PROJECT_EXPLORER_TREE_ITEMS), timeout); } catch (TimeoutException ex) { if (seleniumWebDriverHelper.isVisible(By.id("ide-loader-progress-bar"))) { fail("Known issue <LINK_0>", ex); } <START> } <END> }</code><technical_language>In this case re-throw exception ex for sake of hiding timeout exception</technical_language>

Target:
public void waitProjectExplorer(int timeout) { try { seleniumWebDriverHelper.waitVisibility(By.id(PROJECT_EXPLORER_TREE_ITEMS), timeout); } catch (TimeoutException ex) { if (seleniumWebDriverHelper.isVisible(By.id("ide-loader-progress-bar"))) { fail("Known issue <LINK_0>", ex); } throw ex; } }
Source:
<code>private boolean skipSla(IScheduledTask task, long numActive) { <START> if (slaAwareKillNonProd || task.getAssignedTask().getTask().isProduction()) { <END> return numActive < minRequiredInstances; } return true; }</code><technical_language>production flag is deprecated need isRevocable isPreemptible here. able enable SLA option for everything, new variable</technical_language>

Target:
private boolean skipSla(IScheduledTask task, long numActive) { if (slaAwareKillNonProd || tierManager.getTier(task.getAssignedTask().getTask()).isProduction()) { return numActive < minRequiredInstances; } return true; }
Source:
<code>public StyledString getStyledText(Object element) { if(element instanceof IFile){ StyledString sb = new StyledString(); sb.append(((IFile)element).getName(), FILE_NAME_STYLER).append(" - "); sb.append(((IFile)element).getParent().getFullPath().toString(), PATH_STYLER); return sb; }else if(element instanceof NodePathTextSourceReference){ StyledString sb = new StyledString(); sb.append(getNodePath((NodePathTextSourceReference)element)); <START> return sb; <END> } return null; }</code><technical_language>return getNodePath((NodePathTextSourceReference)element);</technical_language>

Target:
public StyledString getStyledText(Object element) { if(element instanceof IFile){ StyledString sb = new StyledString(); sb.append(((IFile)element).getName(), FILE_NAME_STYLER).append(" - "); sb.append(((IFile)element).getParent().getFullPath().toString(), PATH_STYLER); return sb; }else if(element instanceof NodePathTextSourceReference){ return getNodePath((NodePathTextSourceReference)element); } return null; }
Source:
<code>public void onListItemClick(ListView listView, View view, int i, long l) { final Weapon weapon = ((WeaponStatsAdapter) listView.getAdapter()).getItem(i); final Bundle dataToPass = getArgumentsBundle(); dataToPass.putSerializable(WeaponDetailsFragment.INTENT_WEAPON, weapon); <START> if (isSw720dp() || isSw600dp()) { <END> final FragmentManager fragmentManager = getFragmentManager(); DialogFragment fragment = (DialogFragment) fragmentManager.findFragmentByTag(WeaponDetailsFragment.TAG); if (fragment == null) { fragment = (DialogFragment) FragmentFactory.get(FragmentFactory.Type.WEAPON_STATS_DETAILS, dataToPass); } fragment.show(fragmentManager, WeaponDetailsFragment.TAG); } else { final Intent intent = new Intent(getActivity(), SingleFragmentActivity.class); intent.putExtra(SingleFragmentActivity.INTENT_FRAGMENT_TYPE, FragmentFactory.Type.WEAPON_STATS_DETAILS.ordinal()); intent.putExtra(SingleFragmentActivity.INTENT_FRAGMENT_DATA, dataToPass); startActivity(intent); } }</code><technical_language>Content of this if/else base fragment. do need this ugly logic in fragments handling details</technical_language>

Target:
public void onListItemClick(ListView listView, View view, int i, long l) { final Weapon weapon = ((WeaponStatsAdapter) listView.getAdapter()).getItem(i); final Bundle dataToPass = getArgumentsBundle(); dataToPass.putSerializable(WeaponDetailsFragment.INTENT_WEAPON, weapon); openDetailFragment(FragmentFactory.Type.WEAPON_STATS_DETAILS, dataToPass, WeaponDetailsFragment.TAG); }
Source:
<code>public boolean equals(Object obj) { if (this == obj) return true; if (obj == null) return false; if (obj instanceof LinkdHopCriteria) { LinkdHopCriteria ref = (LinkdHopCriteria) obj; <START> return ref.m_nodeId.equals(m_nodeId) && ref.getNamespace().equals(getNamespace()); <END> } return false; }</code><technical_language>Please Objects.equals(m_nodeId, ref.m_nodeId) && Objects.equals(m_namespace, ref.m_namespace) instead</technical_language>

Target:
public boolean equals(Object obj) { if (this == obj) return true; if (obj == null) return false; if (obj instanceof LinkdHopCriteria) { LinkdHopCriteria ref = (LinkdHopCriteria) obj; return Objects.equals(m_nodeId, ref.m_nodeId) && Objects.equals(m_namespace, ref.m_namespace); } return false; }
Source:
<code>public void testViewFSOverloadSchemeWithoutAnyMountLinks() throws Exception { try (FileSystem fs = FileSystem.get(TEST_DIR.toPath().toUri(), conf)) { ViewFileSystemOverloadScheme vfs = (ViewFileSystemOverloadScheme) fs; Assert.assertEquals(0, vfs.getMountPoints().length); Path testFallBack = new Path("test", FILE_NAME); Assert.assertTrue(vfs.mkdirs(testFallBack)); FileStatus[] status = vfs.listStatus(testFallBack.getParent()); Assert.assertEquals(FILE_NAME, status[0].getPath().getName()); <START> Assert.assertEquals(testFallBack.getName(), <END> vfs.getFileLinkStatus(testFallBack).getPath().getName()); } }</code><technical_language>nit: is a static import for assert.* above, avoid Assert</technical_language>

Target:
public void testViewFSOverloadSchemeWithoutAnyMountLinks() throws Exception { try (FileSystem fs = FileSystem.get(TEST_DIR.toPath().toUri(), conf)) { ViewFileSystemOverloadScheme vfs = (ViewFileSystemOverloadScheme) fs; assertEquals(0, vfs.getMountPoints().length); Path testFallBack = new Path("test", FILE_NAME); assertTrue(vfs.mkdirs(testFallBack)); FileStatus[] status = vfs.listStatus(testFallBack.getParent()); assertEquals(FILE_NAME, status[0].getPath().getName()); assertEquals(testFallBack.getName(), vfs.getFileLinkStatus(testFallBack).getPath().getName()); } }
Source:
<code>private void checkInternetPermission() { PackageManager pm = mContext.getPackageManager(); if (PackageManager.PERMISSION_GRANTED != pm.checkPermission("android.permission.INTERNET", mContext.getPackageName())) { throw new IllegalArgumentException( <START> "android.permission.INTERNET is not added to AndroidManifest file"); <END> } }</code><technical_language>throw a more specific exception? Do ADAL branded one? E.g. ADAuthenticationException? I IllegalOperation better</technical_language>

Target:
private void checkInternetPermission() { PackageManager pm = mContext.getPackageManager(); if (PackageManager.PERMISSION_GRANTED != pm.checkPermission("android.permission.INTERNET", mContext.getPackageName())) { throw new AuthenticationException(ADALError.DEVELOPER_INTERNET_PERMISSION_MISSING); } }
Source:
<code>protected void executeCommand() { getNetwork().setId(Guid.newGuid()); NetworkUtils.setNetworkVdsmName(getNetwork()); TransactionSupport.executeInNewTransaction(() -> { networkDao.save(getNetwork()); if (getNetwork().isVmNetwork() && getParameters().isVnicProfileRequired()) { vnicProfileDao.save(networkHelper.createVnicProfile(getNetwork())); } networkHelper.addPermissionsOnNetwork(getUserId(), getNetwork().getId()); return null; }); List<NetworkCluster> networkAttachments = getParameters().getNetworkClusterList(); boolean clusterAttachmentsSucceeded = true; if (networkAttachments != null) { clusterAttachmentsSucceeded = attachToClusters(networkAttachments).getSucceeded(); } Guid <START> networkId = <END> getNetwork().getId(); if (getNetwork().isVmNetwork() && !getNetwork().isExternal()) { runInternalAction(ActionType.AutodefineExternalNetwork, new IdParameters(networkId)); } getReturnValue().setActionReturnValue(clusterAttachmentsSucceeded ? networkId : null); setSucceeded(clusterAttachmentsSucceeded); }</code><technical_language>I nice readable move added lines a new method</technical_language>

Target:
protected void executeCommand() { getNetwork().setId(Guid.newGuid()); NetworkUtils.setNetworkVdsmName(getNetwork()); TransactionSupport.executeInNewTransaction(() -> { networkDao.save(getNetwork()); if (getNetwork().isVmNetwork() && getParameters().isVnicProfileRequired()) { vnicProfileDao.save(networkHelper.createVnicProfile(getNetwork())); } networkHelper.addPermissionsOnNetwork(getUserId(), getNetwork().getId()); return null; }); List<NetworkCluster> networkAttachments = getParameters().getNetworkClusterList(); if (networkAttachments != null) { ActionReturnValue attachToClustersResult = attachToClusters(networkAttachments); if (!attachToClustersResult.getSucceeded()) { propagateFailure(attachToClustersResult); return; } } runAutodefine(); getReturnValue().setActionReturnValue(getNetwork().getId()); setSucceeded(true); }
Source:
<code>public CurveUnitParameterSensitivity mapSensitivity(DoubleUnaryOperator operator) { <START> double[] updated = new double[sensitivity.length]; <END> for (int i = 0; i < sensitivity.length; i++) { updated[i] = operator.applyAsDouble(sensitivity[i]); } return new CurveUnitParameterSensitivity(metadata, updated); }</code><technical_language>DoubleStream</technical_language>

Target:
public CurveUnitParameterSensitivity mapSensitivity(DoubleUnaryOperator operator) { return new CurveUnitParameterSensitivity(metadata, DoubleArrayMath.apply(sensitivity, operator)); }
Source:
<code>public boolean canAppendRow() { final boolean countCheck = size() < maxRowCount; boolean sizeCheck = true; if (maxBytesInMemory != -1) { sizeCheck = sizeInBytes() < maxBytesInMemory; } final boolean canAdd = countCheck && sizeCheck; if (!countCheck) { outOfRowsReason = StringUtils.format("Maximum number of rows [%d] reached", maxRowCount); } if (!sizeCheck) { <START> outOfRowsReason = StringUtils.format("Maximum size in bytes [%d] reached", maxBytesInMemory); <END> } return canAdd; }</code><technical_language>This replace outOfRowsReason. checked countCheck sizeCheck false</technical_language>

Target:
public boolean canAppendRow() { final boolean countCheck = size() < maxRowCount; final boolean sizeCheck = maxBytesInMemory <= 0 || getBytesInMemory() < maxBytesInMemory; final boolean canAdd = countCheck && sizeCheck; if (!countCheck && !sizeCheck) { outOfRowsReason = StringUtils.format( "Maximum number of rows [%d] and maximum size in bytes [%d] reached", maxRowCount, maxBytesInMemory ); } else { if (!countCheck) { outOfRowsReason = StringUtils.format("Maximum number of rows [%d] reached", maxRowCount); } else if (!sizeCheck) { outOfRowsReason = StringUtils.format("Maximum size in bytes [%d] reached", maxBytesInMemory); } } return canAdd; }
Source:
<code>public void start() throws ReplicationException { try { for (String mountPath : mountPathToPartitionInfoList.keySet()) { retrieveReplicaTokensAndPersistIfNecessary(mountPath); } if (replicaThreadPoolByDc.size() == 0) { logger.warn("Number of Datacenters to replicate from is 0, not starting any replica threads"); return; } replicationMetrics.trackReplicationDisabledPartitions(replicaThreadPoolByDc); for (List<ReplicaThread> replicaThreads : replicaThreadPoolByDc.values()) { for (ReplicaThread thread : replicaThreads) { Thread replicaThread = Utils.newThread(thread.getName(), thread, false); logger.info("Starting replica thread " + thread.getName()); replicaThread.start(); } } if (persistor != null) { this.scheduler.scheduleAtFixedRate(persistor, replicationConfig.replicationTokenFlushDelaySeconds, replicationConfig.replicationTokenFlushIntervalSeconds, TimeUnit.SECONDS); } } catch (IOException e) { <START> logger.error("IO error while starting replication", e); <END> } }</code><technical_language>I this is copied code, throwing ReplicationException in this case</technical_language>

Target:
public void start() throws ReplicationException { try { for (String mountPath : mountPathToPartitionInfos.keySet()) { retrieveReplicaTokensAndPersistIfNecessary(mountPath); } if (replicaThreadPoolByDc.size() == 0) { logger.warn("Number of Datacenters to replicate from is 0, not starting any replica threads"); return; } replicationMetrics.trackReplicationDisabledPartitions(replicaThreadPoolByDc); for (List<ReplicaThread> replicaThreads : replicaThreadPoolByDc.values()) { for (ReplicaThread thread : replicaThreads) { Thread replicaThread = Utils.newThread(thread.getName(), thread, false); logger.info("Starting replica thread " + thread.getName()); replicaThread.start(); } } if (persistor != null) { this.scheduler.scheduleAtFixedRate(persistor, replicationConfig.replicationTokenFlushDelaySeconds, replicationConfig.replicationTokenFlushIntervalSeconds, TimeUnit.SECONDS); } } catch (IOException e) { logger.error("IO error while starting replication", e); } }
Source:
<code>String resolveFieldName(String solrFieldName) { String originalName = solrFieldName; <START> boolean suffixExists = true; <END> while (suffixExists) { suffixExists = false; for (String suffix : SchemaFields.SUFFIX_LIST) { if (originalName.endsWith(suffix)) { suffixExists = true; originalName = originalName.substring(0, originalName.indexOf(suffix)); } } } return originalName; }</code><technical_language>benchmark this premature optimization initial concern this method is called field of metacard converted a Solr doc. Another option care if suffix is end. pass suffix list once. A slight optimization for find index of underscore offset indexOf of suffix suffixes start underscore</technical_language>

Target:
String resolveFieldName(String solrFieldName) { int lastIndexOfUndercore = solrFieldName.lastIndexOf(FIRST_CHAR_OF_SUFFIX); if (lastIndexOfUndercore != -1) { return solrFieldName.substring(0, lastIndexOfUndercore); } return solrFieldName; }
Source:
<code>public void onMapReady(@NonNull final MapboxMap mapboxMap) { this.mapboxMap = mapboxMap; mapboxMap.setStyle(Style.MAPBOX_STREETS, new Style.OnStyleLoaded() { @Override public void onStyleLoaded(@NonNull Style style) { staticMapImageView = findViewById(R.id.static_map_imageview); createStaticImageButton = findViewById(R.id.create_static_image_button); mapStyleRadioGroup = findViewById(R.id.map_style_radio_group); mapStyleRadioGroup.setOnCheckedChangeListener(StaticImageActivity.this); createStaticImageButton.setOnClickListener(new View.OnClickListener() { @Override public void onClick(View view) { if (mapStyleRadioGroup.getCheckedRadioButtonId() == -1) { Toast.makeText(StaticImageActivity.this, R.string.select_a_style, Toast.LENGTH_SHORT).show(); } else { Picasso.with(StaticImageActivity.this).load(takeSnapshot( mapboxMap.getCameraPosition().zoom, mapboxMap.getStyle().getUrl().equals("mapbox://styles/mapbox/dark-v9") ? StaticMapCriteria.DARK_STYLE : StaticMapCriteria.STREET_STYLE, mapboxMap.getCameraPosition().target, mapboxMap.getCameraPosition().bearing, <START> mapboxMap.getCameraPosition().tilt, <END> (int) MathUtils.clamp(findViewById(R.id.static_map_imageview).getMeasuredWidth(), 0, 1280), (int) MathUtils.clamp(findViewById(R.id.static_map_imageview).getMeasuredHeight(), 0, 1280)) .url().toString()).into(staticMapImageView); } } }); } }); }</code><technical_language>local variable camera position</technical_language>

Target:
public void onMapReady(@NonNull final MapboxMap mapboxMap) { this.mapboxMap = mapboxMap; mapboxMap.setStyle(Style.MAPBOX_STREETS); initViews(); }
Source:
<code><START> protected static KeyManagerFactory buildKeyManagerFactory(File certChainFile, <END> String keyAlgorithm, File keyFile, String keyPassword, KeyManagerFactory kmf, String keyStore) throws KeyStoreException, NoSuchAlgorithmException, NoSuchPaddingException, InvalidKeySpecException, InvalidAlgorithmParameterException, IOException, CertificateException, KeyException, UnrecoverableKeyException { return buildKeyManagerFactory(toX509Certificates(certChainFile), keyAlgorithm, toPrivateKey(keyFile, keyPassword), keyPassword, kmf, keyStore); }</code><technical_language>sense expose a protected method mark @Deprecated beginning. remove annotation package-private</technical_language>

Target:
static KeyManagerFactory buildKeyManagerFactory(File certChainFile, String keyAlgorithm, File keyFile, String keyPassword, KeyManagerFactory kmf, String keyStore) throws KeyStoreException, NoSuchAlgorithmException, NoSuchPaddingException, InvalidKeySpecException, InvalidAlgorithmParameterException, IOException, CertificateException, KeyException, UnrecoverableKeyException { return buildKeyManagerFactory(toX509Certificates(certChainFile), keyAlgorithm, toPrivateKey(keyFile, keyPassword), keyPassword, kmf, keyStore); }
Source:
<code>public void run(String[] args) { Set<Param> allParams = getAllParams(); CommandLine cli = getCli(args, allParams); try { requiredOperations.forEach(operation -> { checkForMissingParams(cli, operation.requiredParams); operation.argsConsumer.accept(Args.from(cli, operation.requiredParams)); }); operations.forEach(operation -> { if (cli.hasOption(operation.param.shortCode)) { checkForMissingParams(cli, operation.requiredParams); <START> if (operation.param.shortCode.equals("e")) { <END> if (cli.hasOption("start")) checkForDateFormat(cli.getOptionValue("start")); if (cli.hasOption("end")) checkForDateFormat(cli.getOptionValue("end")); } operation.argsConsumer.accept(Args.from(cli, operation.getAllParams())); executedOperations.add(operation); } }); if (executedOperations.isEmpty()) otherwiseRunnables.forEach(Runnable::run); } catch (BriefcaseException e) { System.err.println("Error: " + e.message); log.error("Error", e); System.exit(1); } catch (Throwable t) { System.err.println("Briefcase unexpected error. Please review the logs and contact maintainers on the following URLs:"); System.err.println("\t<LINK_0>"); System.err.println("\t<LINK_1>"); log.error("Error", t); System.exit(1); } }</code><technical_language>Cli operations runs. checks done here. I fine LocalDate.parse() throw a DateTimeParseException. catch Param's mapper transform a BriefcaseException get gracefully caught Cli afterwards. problematic is mapper is big. time create a factory for Param<LocalDate> this: java class Param<T> { // more stuff public static Param<LocalDate> localDate(String shortCode, String longCode, String description) { return Param.arg( shortCode, longCode, description + " (yyyy-MM-dd yyyy/MM/dd)", dateAsText -> { try { return LocalDate.parse(dateAsText.replaceAll("/", "-")); } catch (DateTimeParseException e) { throw new BriefcaseException("Invalid date format"); } } ); } } This standardize creation of LocalDate params in Briefcase specifically write a test for this factory. forget write a test for this factory ;)</technical_language>

Target:
public void run(String[] args) { Set<Param> allParams = getAllParams(); CommandLine cli = getCli(args, allParams); try { requiredOperations.forEach(operation -> { checkForMissingParams(cli, operation.requiredParams); operation.argsConsumer.accept(Args.from(cli, operation.requiredParams)); }); operations.forEach(operation -> { if (cli.hasOption(operation.param.shortCode)) { checkForMissingParams(cli, operation.requiredParams); operation.argsConsumer.accept(Args.from(cli, operation.getAllParams())); executedOperations.add(operation); } }); if (executedOperations.isEmpty()) otherwiseRunnables.forEach(Runnable::run); } catch (BriefcaseException e) { System.err.println("Error: " + e.message); log.error("Error", e); System.exit(1); } catch (Throwable t) { System.err.println("Briefcase unexpected error. Please review the logs and contact maintainers on the following URLs:"); System.err.println("\t<LINK_0>"); System.err.println("\t<LINK_1>"); log.error("Error", t); System.exit(1); } }
Source:
<code>public DeprecatedApiEntry getDeprecated( String reqApiVersion ) { if ( isBlank( reqApiVersion )) { return null; } Float reqVer; try { reqVer = Float.parseFloat( reqApiVersion ); } <START> catch ( NumberFormatException e ) <END> { logger.warn( "Unknown api version: {}", reqApiVersion ); return null; } for ( DeprecatedApiEntry et : deprecatedApis ) { if ( et.range != null && et.range.containsFloat( reqVer ) ) { return et; } } for ( DeprecatedApiEntry et : deprecatedApis ) { if ( et.endVersion != null && reqVer <= et.endVersion ) { return et; } } return null; }</code><technical_language>@ligangty null. checking for NullPointerException is god thing</technical_language>

Target:
public Optional<DeprecatedApiEntry> getDeprecated( String reqApiVersion ) { if ( isBlank( reqApiVersion )) { return empty(); } Float reqVer; try { reqVer = Float.parseFloat( reqApiVersion ); } catch ( NumberFormatException e ) { logger.warn( "Unknown api version: {}", reqApiVersion ); return empty(); } for ( DeprecatedApiEntry et : deprecatedApis ) { if ( et.range != null && et.range.containsFloat( reqVer ) ) { return of( et ); } } for ( DeprecatedApiEntry et : deprecatedApis ) { if ( et.endVersion != null && reqVer <= et.endVersion ) { return of( et ); } } return empty(); }
Source:
<code>public void encode(ByteBuf buf) { buf.writeByte('*'); String[] commands = null; <START> if (type.name().contains("$")) { <END> commands = type.name().split("\\$"); } CommandArgs.IntegerArgument.writeInteger(buf, (commands == null ? 1 : commands.length) + (args != null ? args.count() : 0)); buf.writeBytes(CommandArgs.CRLF); if (commands != null) { for (String cmd : commands) { CommandArgs.BytesArgument.writeBytes(buf, cmd.getBytes(LettuceCharsets.ASCII)); } } else { CommandArgs.BytesArgument.writeBytes(buf, type.getBytes()); } if (args != null) { args.encode(buf); } }</code><technical_language>This change is required</technical_language>

Target:
public void encode(ByteBuf buf) { buf.writeByte('*'); CommandArgs.IntegerArgument.writeInteger(buf, 1 + (args != null ? args.count() : 0)); buf.writeBytes(CommandArgs.CRLF); CommandArgs.BytesArgument.writeBytes(buf, type.getBytes()); if (args != null) { args.encode(buf); } }
Source:
<code>private static MultiValueMap<String, Object> extractFromRequest(HttpServletRequest request) throws IOException { MultiValueMap<String, Object> builder = new LinkedMultiValueMap<>(); Set<String> queryParams = findQueryParams(request); for (Entry<String, String[]> entry : request.getParameterMap().entrySet()) { String key = entry.getKey(); if (!queryParams.contains(key)) { for (String value : entry.getValue()) { <START> builder.add(entry.getKey(), value); <END> } } } return builder; }</code><technical_language>entry.getKey() replaced key</technical_language>

Target:
private static MultiValueMap<String, Object> extractFromRequest(HttpServletRequest request) throws IOException { MultiValueMap<String, Object> builder = new LinkedMultiValueMap<>(); Set<String> queryParams = findQueryParams(request); for (Entry<String, String[]> entry : request.getParameterMap().entrySet()) { String key = entry.getKey(); if (!queryParams.contains(key)) { for (String value : entry.getValue()) { builder.add(key, value); } } } return builder; }
Source:
<code>static LockRequest of(Set<LockDescriptor> lockDescriptors, long acquireTimeoutMs, String clientDescription) { <START> return ImmutableLockRequestV2.of( <END> UUID.randomUUID(), lockDescriptors, acquireTimeoutMs, Optional.of(clientDescription)); }</code><technical_language>before, need change this ImmutableLockRequest (and in other of() too)</technical_language>

Target:
static LockRequest of(Set<LockDescriptor> lockDescriptors, long acquireTimeoutMs, String clientDescription) { return ImmutableLockRequest.of( UUID.randomUUID(), lockDescriptors, acquireTimeoutMs, Optional.of(clientDescription)); }
Source:
<code>protected void assertResultEquals(Change expected, ChangeInfo actual) { <START> assertEquals(expected.getId().get(), (int) actual._number); <END> }</code><technical_language>Unnecessary cast</technical_language>

Target:
protected void assertResultEquals(Change expected, ChangeInfo actual) { assertEquals(expected.getId().get(), actual._number); }
Source:
<code>private void updateBCSID(Container container, DispatcherContext dispatcherContext, ContainerProtos.Type cmdType) { <START> long bcsID = container.getBlockCommitSequenceId(); <END> long containerId = container.getContainerData().getContainerID(); Map<Long, Long> container2BCSIDMap; if (dispatcherContext != null && (cmdType == ContainerProtos.Type.PutBlock || cmdType == ContainerProtos.Type.PutSmallFile)) { container2BCSIDMap = dispatcherContext.getContainer2BCSIDMap(); Preconditions.checkNotNull(container2BCSIDMap); Preconditions.checkArgument(container2BCSIDMap.containsKey(containerId)); container2BCSIDMap.computeIfPresent(containerId, (u, v) -> v = bcsID); } }</code><technical_language>alternative implementation ignore cmdType. For requests, read BCS ID map compare bcsid container. if map is lower, update container. Advantage: updateBCSID function de-coupled knowledge of cmdType changes bcsid. Disadvantage: possibly more CPU cost, request pay cost of reading bcsid map. premature assume this additional cost significant</technical_language>

Target:
private void updateBCSID(Container container, DispatcherContext dispatcherContext, ContainerProtos.Type cmdType) { if (dispatcherContext != null && (cmdType == ContainerProtos.Type.PutBlock || cmdType == ContainerProtos.Type.PutSmallFile)) { Preconditions.checkNotNull(container); long bcsID = container.getBlockCommitSequenceId(); long containerId = container.getContainerData().getContainerID(); Map<Long, Long> container2BCSIDMap; container2BCSIDMap = dispatcherContext.getContainer2BCSIDMap(); Preconditions.checkNotNull(container2BCSIDMap); Preconditions.checkArgument(container2BCSIDMap.containsKey(containerId)); container2BCSIDMap.computeIfPresent(containerId, (u, v) -> v = bcsID); } }
Source:
<code>private void executeUnaryExpression(Tree tree) { ProgramState.Pop unstackUnary = programState.unstackValue(1); programState = unstackUnary.state; SymbolicValue unarySymbolicValue = constraintManager.createSymbolicValue(tree); unarySymbolicValue.computedFrom(unstackUnary.valuesAndSymbols); if (tree.is(Tree.Kind.POSTFIX_DECREMENT, Tree.Kind.POSTFIX_INCREMENT)) { ProgramState.SymbolicValueSymbol symbolicValueSymbol = unstackUnary.valuesAndSymbols.get(0); programState = programState.stackValue(symbolicValueSymbol.sv, symbolicValueSymbol.symbol); } else { programState = programState.stackValue(unarySymbolicValue); } <START> if (tree.is(Tree.Kind.POSTFIX_DECREMENT, Tree.Kind.POSTFIX_INCREMENT, Tree.Kind.PREFIX_DECREMENT, Tree.Kind.PREFIX_INCREMENT)) { <END> ExpressionTree expr = ExpressionUtils.skipParentheses(((UnaryExpressionTree) tree).expression()); Symbol symbol = null; if (expr.is(Tree.Kind.IDENTIFIER)) { symbol = ((IdentifierTree) expr).symbol(); } else if (expr.is(Tree.Kind.MEMBER_SELECT)) { MemberSelectExpressionTree mset = (MemberSelectExpressionTree) expr; symbol = ExpressionUtils.isSelectOnThisOrSuper(mset) ? mset.identifier().symbol() : null; } if (symbol != null) { programState = programState.put(symbol, unarySymbolicValue); } } }</code><technical_language>reuse symbol is stack symbolicValueSymbol.symbol unstacked. This reuse logic in executeIdentifier resolve symbol</technical_language>

Target:
private void executeUnaryExpression(Tree tree) { ProgramState.Pop unstackUnary = programState.unstackValue(1); programState = unstackUnary.state; SymbolicValue unarySymbolicValue = constraintManager.createSymbolicValue(tree); unarySymbolicValue.computedFrom(unstackUnary.valuesAndSymbols); ProgramState.SymbolicValueSymbol symbolicValueSymbol = unstackUnary.valuesAndSymbols.get(0); if (tree.is(Tree.Kind.POSTFIX_DECREMENT, Tree.Kind.POSTFIX_INCREMENT)) { programState = programState.stackValue(symbolicValueSymbol.sv, symbolicValueSymbol.symbol); } else { programState = programState.stackValue(unarySymbolicValue); } if (tree.is(Tree.Kind.POSTFIX_DECREMENT, Tree.Kind.POSTFIX_INCREMENT, Tree.Kind.PREFIX_DECREMENT, Tree.Kind.PREFIX_INCREMENT) && symbolicValueSymbol.symbol != null) { programState = programState.put(symbolicValueSymbol.symbol, unarySymbolicValue); } }