auphong2707/dl4se-code-review-dataset huggingface dataset:
Source:
<code><START> public static int numOracles(CuratorFramework curator) { <END> int numOracles = 0; try { if (curator.checkExists().forPath(ZookeeperPath.ORACLE_SERVER) != null) { LeaderLatch leaderLatch = new LeaderLatch(curator, ZookeeperPath.ORACLE_SERVER); numOracles = leaderLatch.getParticipants().size(); } } catch (Exception e) { throw new RuntimeException(e); } return numOracles; }</code><technical_language>need public</technical_language>

Target:
private static int numOracles(CuratorFramework curator) { try { LeaderLatch leaderLatch = new LeaderLatch(curator, ZookeeperPath.ORACLE_SERVER); return leaderLatch.getParticipants().size(); } catch (Exception e) { throw new RuntimeException(e); } }
Source:
<code>public DynamicConfigServiceImpl(NodeContext nodeContext, LicenseService licenseService, NomadServerManager nomadServerManager, ObjectMapperFactory objectMapperFactory) { this.upcomingNodeContext = requireNonNull(nodeContext); this.runtimeNodeContext = requireNonNull(nodeContext); this.licenseService = requireNonNull(licenseService); this.nomadServerManager = requireNonNull(nomadServerManager); this.licensePath = nomadServerManager.getConfigurationManager().getLicensePath().resolve(LICENSE_FILE_NAME); this.objectMapper = objectMapperFactory.create(); if (hasLicenseFile()) { validateAgainstLicense(upcomingNodeContext.getCluster()); } <START> } <END></code><technical_language>I remove that.... This is a safeguard prevent server start if computed topology is right point. If a bug day (cli parsing, config parsing, migration, etc) invalid topology in config system parsed startup</technical_language>

Target:
public DynamicConfigServiceImpl(NodeContext nodeContext, LicenseService licenseService, NomadServerManager nomadServerManager, ObjectMapperFactory objectMapperFactory) { this.upcomingNodeContext = requireNonNull(nodeContext); this.runtimeNodeContext = requireNonNull(nodeContext); this.licenseService = requireNonNull(licenseService); this.nomadServerManager = requireNonNull(nomadServerManager); this.licensePath = nomadServerManager.getConfigurationManager().getLicensePath().resolve(LICENSE_FILE_NAME); this.objectMapper = objectMapperFactory.create(); if (hasLicenseFile()) { validateAgainstLicense(upcomingNodeContext.getCluster()); } new ClusterValidator(nodeContext.getCluster()).validate(); }
Source:
<code>public Expanded expanded(String ori) { final Map<SqlParserPos, SqlIdentifier> identifiers = new HashMap<>(); final SqlNode oriNode; final SqlNode validated; <START> oriNode = planner.parser().parse(ori); <END> validated = planner.validate(planner.parser().parse(ori)); validated.accept(new SqlBasicVisitor<Void>() { @Override public Void visit(SqlIdentifier identifier) { identifiers.putIfAbsent(identifier.getParserPosition(), identifier); return null; } }); return new Expanded(planner.config().getParserConfig(), oriNode, identifiers); }</code><technical_language>nit: inline assignment</technical_language>

Target:
public Expanded expanded(String ori) { final Map<SqlParserPos, SqlIdentifier> identifiers = new HashMap<>(); final Map<String, SqlIdentifier> funcNameToId = new HashMap<>(); final SqlNode oriNode = planner.parser().parse(ori); final SqlNode validated = planner.validate(planner.parser().parse(ori)); validated.accept(new SqlBasicVisitor<Void>() { @Override public Void visit(SqlCall call) { SqlOperator operator = call.getOperator(); if (operator instanceof BridgingSqlFunction) { final SqlIdentifier functionID = ((BridgingSqlFunction) operator) .getSqlIdentifier(); if (!functionID.isSimple()) { funcNameToId.put(Util.last(functionID.names), functionID); } } return super.visit(call); } @Override public Void visit(SqlIdentifier identifier) { identifiers.putIfAbsent(identifier.getParserPosition(), identifier); return null; } }); return new Expanded(oriNode, identifiers, funcNameToId); }
Source:
<code>public static ApiResultWrapper makeApiCall(HttpUriRequest clientRequest){ HttpResponse response; String errMsg = ""; int statusCode; String apiResponse = ""; try { response = Utils.executeApiCall(clientRequest); <START> if (response == null) { <END> errMsg = String.format("{\"errorMsg\":\"The request %s failed with errors\"}", clientRequest.getURI().toString()); return new ApiResultWrapper(Utils.API_UNKNOWN_ERROR, errMsg, ""); } statusCode = response.getStatusLine().getStatusCode(); errMsg = "{\"errorMsg\":\"The request %s has failed to extract the response due to %s\"}"; apiResponse = EntityUtils.toString(response.getEntity(), "UTF-8"); } catch (IOException e) { return new ApiResultWrapper(Utils.API_EXCEPTION_ERROR, String.format(errMsg, clientRequest.getURI().toString(), e.getMessage()), ""); } catch (Exception e) { return new ApiResultWrapper(Utils.API_EXCEPTION_ERROR, String.format(errMsg, clientRequest.getURI().toString(), e.getMessage()), ""); } return new ApiResultWrapper(statusCode, "", apiResponse); }</code><technical_language>white space</technical_language>

Target:
public static ApiResultWrapper makeApiCall(HttpUriRequest clientRequest){ HttpResponse response; String errMsg = ""; int statusCode; String apiResponse = ""; try { response = Utils.executeApiCall(clientRequest); if (response == null) { errMsg = String.format("{\"errorMsg\":\"The request %s failed with errors\"}", clientRequest.getURI().toString()); return new ApiResultWrapper(Utils.API_UNKNOWN_ERROR, errMsg, ""); } statusCode = response.getStatusLine().getStatusCode(); errMsg = "{\"errorMsg\":\"The request %s has failed to extract the response due to %s\"}"; apiResponse = EntityUtils.toString(response.getEntity(), CONSTANT_UTF_8); } catch (IOException e) { return new ApiResultWrapper(Utils.API_EXCEPTION_ERROR, String.format(errMsg, clientRequest.getURI().toString(), e.getMessage()), ""); } catch (Exception e) { return new ApiResultWrapper(Utils.API_EXCEPTION_ERROR, String.format(errMsg, clientRequest.getURI().toString(), e.getMessage()), ""); } return new ApiResultWrapper(statusCode, "", apiResponse); }
Source:
<code>private boolean isRedirectedToHomePage() { String nextUrl = getRequestParamValue(Const.ParamsNames.NEXT_URL); <START> boolean isHomePageUrl = nextUrl != null && nextUrl.equals(Const.ActionURIs.INSTRUCTOR_HOME_PAGE); <END> return isHomePageUrl; }</code><technical_language>more (...)</technical_language>

Target:
private boolean isRedirectedToHomePage() { String nextUrl = getRequestParamValue(Const.ParamsNames.NEXT_URL); boolean isHomePageUrl = (nextUrl != null && nextUrl.equals(Const.ActionURIs.INSTRUCTOR_HOME_PAGE)); return isHomePageUrl; }
Source:
<code>public PMetaData addTable(PTable table) throws SQLException { Map<String,PTable> tables = Maps.newHashMap(metaData); PTable oldTable = tables.put(table.getName().getString(), table); <START> if (table.getType() == INDEX && table.getParentName() != null) { END> String parentName = table.getParentName().getString(); PTable parentTable = tables.get(parentName); List<PTable> oldIndexes = parentTable.getIndexes(); List<PTable> newIndexes = Lists.newArrayListWithExpectedSize(oldIndexes.size() + 1); newIndexes.addAll(oldIndexes); if (oldTable != null) { newIndexes.remove(oldTable); } newIndexes.add(table); tables.put(parentName, PTableImpl.makePTable(parentTable, table.getTimeStamp(), newIndexes)); } for (PTable index : table.getIndexes()) { tables.put(index.getName().getString(), index); } return new PMetaDataImpl(tables); }</code><technical_language>sure, other places need add this additional check. This means, though, want try maintain link base PTable child PTables (which sense, a huge number)</technical_language>

Target:
public PMetaData addTable(PTable table) throws SQLException { Map<String,PTable> tables = Maps.newHashMap(metaData); PTable oldTable = tables.put(table.getName().getString(), table); if (table.getParentName() != null) { String parentName = table.getParentName().getString(); PTable parentTable = tables.get(parentName); if (parentTable != null) { List<PTable> oldIndexes = parentTable.getIndexes(); List<PTable> newIndexes = Lists.newArrayListWithExpectedSize(oldIndexes.size() + 1); newIndexes.addAll(oldIndexes); if (oldTable != null) { newIndexes.remove(oldTable); } newIndexes.add(table); tables.put(parentName, PTableImpl.makePTable(parentTable, table.getTimeStamp(), newIndexes)); } } for (PTable index : table.getIndexes()) { tables.put(index.getName().getString(), index); } return new PMetaDataImpl(tables); }
Source:
<code>private static <T extends Nameable> List<ClusterEditWarnings.Warning> getProblematicEntities( VDSGroup oldCluster, VDSGroup newCluster, Iterable<ClusterEditChecker<T>> checkers, ClusterEntityResolver<T> entityResolver) { List<ClusterEditWarnings.Warning> warnings = new ArrayList<>(); List<ClusterEditChecker<T>> applicableChecks = stream(checkers.spliterator(), false) .filter(checker -> checker.isApplicable(oldCluster, newCluster)) .collect(toList()); if (!applicableChecks.isEmpty()) { List<T> entities = entityResolver.getClusterEntities(oldCluster); for (ClusterEditChecker<T> checker : applicableChecks) { ClusterEditWarnings.Warning warning = new ClusterEditWarnings.Warning(checker.getMainMessage()); <START> entities.stream().filter(entity -> !checker.check(entity)).forEach(entity -> { <END> warning.getDetailsByName().put(entity.getName(), checker.getDetailMessage(entity)); }); if (!warning.isEmpty()) { warnings.add(warning); } } } return warnings; }</code><technical_language>Do need braces here</technical_language>

Target:
private static <T extends Nameable> List<ClusterEditWarnings.Warning> getProblematicEntities( VDSGroup oldCluster, VDSGroup newCluster, Iterable<ClusterEditChecker<T>> checkers, ClusterEntityResolver<T> entityResolver) { List<ClusterEditWarnings.Warning> warnings = new ArrayList<>(); List<ClusterEditChecker<T>> applicableChecks = stream(checkers.spliterator(), false) .filter(checker -> checker.isApplicable(oldCluster, newCluster)) .collect(toList()); if (!applicableChecks.isEmpty()) { List<T> entities = entityResolver.getClusterEntities(oldCluster); for (ClusterEditChecker<T> checker : applicableChecks) { ClusterEditWarnings.Warning warning = new ClusterEditWarnings.Warning(checker.getMainMessage()); entities.stream().filter(entity -> !checker.check(entity)).forEach(entity -> warning.getDetailsByName().put(entity.getName(), checker.getDetailMessage(entity))); if (!warning.isEmpty()) { warnings.add(warning); } } } return warnings; }
Source:
<code>public int hashCode() { <START> int result = Objects.hash(tripId, serviceDate); <END> return result; }</code><technical_language>hashCode-method include feedId</technical_language>

Target:
public int hashCode() { int result = Objects.hash(tripId, serviceDate, feedId); return result; }
Source:
<code>public void putFailureTest() throws Exception { <START> RestRequest restRequest = new BadRestRequest(); <END> MockRestResponseChannel restResponseChannel = new MockRestResponseChannel(); responseHandler.reset(); ambryBlobStorageService.handlePut(restRequest, restResponseChannel); Exception e = restResponseChannel.getException(); assertTrue("Unexpected exception", e instanceof RestServiceException); }</code><technical_language>this is a BadRestRequest() is bound fail. This test similar in AdminBlobStorageService in sense create a valid request PUT method</technical_language>

Target:
public void putFailureTest() throws Exception { RestRequest restRequest = createRestRequest(RestMethod.PUT, "/", null, null); MockRestResponseChannel restResponseChannel = new MockRestResponseChannel(); try { doOperation(restRequest, restResponseChannel); fail("PUT should have failed because Ambry does not support it"); } catch (RestServiceException e) { assertEquals("PUT is an unsupported method", RestServiceErrorCode.UnsupportedHttpMethod, e.getErrorCode()); } }
Source:
<code><START> private <T extends ComputerLauncher> void selectType(Class<T> type) { <END> findCaption(type, new Resolver() { @Override protected void resolve(String caption) { launchMethod.select(caption); } }); }</code><technical_language>throws NoSuchElementException</technical_language>

Target:
private <T extends ComputerLauncher> void selectType(Class<T> type) throws NoSuchElementException { findCaption(type, new Resolver() { @Override protected void resolve(String caption) { launchMethod.select(caption); } }); }
Source:
<code>private Expression readRank(boolean isPercent) { SortAndSlice sortAndSlice = null; read(); readThis(Tokens.OPENBRACKET); readThis(Tokens.CLOSEBRACKET); readThis(Tokens.OVER); readThis(Tokens.OPENBRACKET); List<Expression> partitionByList = new ArrayList<Expression>(); if (token.tokenType == Tokens.PARTITION) { read(); readThis(Tokens.BY); while (true) { Expression e = XreadValueExpression(); partitionByList.add(e); if (token.tokenType == Tokens.COMMA) { read(); continue; } break; } } if (token.tokenType != Tokens.ORDER) { throw unexpectedToken(); } <START> assert(token.tokenType == Tokens.ORDER); <END> read(); readThis(Tokens.BY); sortAndSlice = XreadOrderBy(); readThis(Tokens.CLOSEBRACKET); ExpressionRank erank = new ExpressionRank(sortAndSlice, partitionByList, isPercent); return erank; }</code><technical_language>point in asserting throw works</technical_language>

Target:
private Expression readRank(boolean isPercent) { SortAndSlice sortAndSlice = null; read(); readThis(Tokens.OPENBRACKET); readThis(Tokens.CLOSEBRACKET); readThis(Tokens.OVER); readThis(Tokens.OPENBRACKET); List<Expression> partitionByList = new ArrayList<Expression>(); if (token.tokenType == Tokens.PARTITION) { read(); readThis(Tokens.BY); while (true) { Expression e = XreadValueExpression(); partitionByList.add(e); if (token.tokenType == Tokens.COMMA) { read(); continue; } break; } } if (token.tokenType != Tokens.ORDER) { throw unexpectedToken(); } read(); readThis(Tokens.BY); sortAndSlice = XreadOrderBy(); readThis(Tokens.CLOSEBRACKET); ExpressionRank erank = new ExpressionRank(sortAndSlice, partitionByList, isPercent); return erank; }
Source:
<code>public void onActivityCreated(Bundle savedInstanceState) { super.onActivityCreated(savedInstanceState); mImageGetter = new HttpImageGetter(getActivity()); fillData(); setContentShown(true); mLoadPullRequestsCount = result -> { Log.d("TEST", "getPullRequest onNext called: " + result); View v = getView(); v.findViewById(R.id.issues_progress).setVisibility(View.GONE); v.findViewById(R.id.pull_requests_progress).setVisibility(View.GONE); TextView tvIssuesCount = (TextView) mContentView.findViewById(R.id.tv_issues_count); tvIssuesCount.setText(String.valueOf(mRepository.getOpenIssues() - (Integer) result)); TextView tvPullRequestsCountView = (TextView) v.findViewById(R.id.tv_pull_requests_count); tvPullRequestsCountView.setText(String.valueOf(result)); }; mReadmeConsumer = result -> { Log.d("TEST-RE", "readme flatMap called"); setContentShown(true); TextView readmeView = (TextView) mContentView.findViewById(R.id.readme); View progress = mContentView.findViewById(R.id.pb_readme); if (result != null) mImageGetter.encode(getContext(), mRepository.getId(), String.valueOf(result)); if (result != null) { readmeView.setMovementMethod(UiUtils.CHECKING_LINK_METHOD); mImageGetter.bind(readmeView, String.valueOf(result), mRepository.getId()); } else { readmeView.setText(R.string.repo_no_readme); readmeView.setTypeface(Typeface.DEFAULT, Typeface.ITALIC); } readmeView.setVisibility(View.VISIBLE); progress.setVisibility(View.GONE); }; loadReadme() .compose(RxTools.handle(getActivity(), RepositoryService.LOAD_README)) <START> .subscribe(mReadmeConsumer, e -> { <END> Log.d("TEST-RE", "error readme: " + e); }); loadPullRequestsCount() .compose(RxTools.handle(getActivity(), RepositoryService.LOAD_PULL_REQUESTS_COUNT)) .subscribe(mLoadPullRequestsCount, e -> {}); }</code><technical_language>I prefer myself</technical_language>

Target:
public void onActivityCreated(Bundle savedInstanceState) { super.onActivityCreated(savedInstanceState); mImageGetter = new HttpImageGetter(getActivity()); fillData(); setContentShown(true); loadReadme(false); loadPullRequestsCount(false); }
Source:
<code>private boolean isServerInteresting(GerritTriggeredEvent event) { <START> return event.getProvider().getName().equals(serverName); <END> }</code><technical_language>is a risk provider is null name of provider null. I forgotten initializeProvider does</technical_language>

Target:
private boolean isServerInteresting(GerritTriggeredEvent event) { Provider provider = initializeProvider(event); return provider.getName().equals(serverName); }
Source:
<code>public MarshallableEntry<K, V> loadEntry(Object key) { String lockingKey = key2Str(key); Connection conn = null; PreparedStatement ps = null; ResultSet rs = null; MarshallableEntry<K, V> storedValue = null; try { String sql = tableManager.getSelectRowSql(); conn = connectionFactory.getConnection(); ps = conn.prepareStatement(sql); ps.setString(1, lockingKey); rs = ps.executeQuery(); if (rs.next()) { InputStream inputStream = rs.getBinaryStream(2); StoreEntry entry = unmarshall(inputStream); <START> storedValue = marshalledEntryFactory.create(key, entry.getValue(), entry.getMetadata(), entry.getCreated(), entry.getLastUsed()); <END> } } catch (SQLException e) { log.sqlFailureReadingKey(key, lockingKey, e); throw new PersistenceException(String.format( "SQL error while fetching stored entry with key: %s, lockingKey: %s", key, lockingKey), e); } finally { JdbcUtil.safeClose(rs); JdbcUtil.safeClose(ps); connectionFactory.releaseConnection(conn); } if (storedValue != null && storedValue.metadata() != null && storedValue.isExpired(timeService.wallClockTime())) { return null; } return storedValue; }</code><technical_language>entry storedValue names other :)</technical_language>

Target:
public MarshallableEntry<K, V> loadEntry(Object key) { String lockingKey = key2Str(key); Connection conn = null; PreparedStatement ps = null; ResultSet rs = null; MarshallableEntry<K, V> entry = null; try { String sql = tableManager.getSelectRowSql(); conn = connectionFactory.getConnection(); ps = conn.prepareStatement(sql); ps.setString(1, lockingKey); rs = ps.executeQuery(); if (rs.next()) { InputStream inputStream = rs.getBinaryStream(2); entry = marshalledEntryFactory.create(key, unmarshall(inputStream)); } } catch (SQLException e) { log.sqlFailureReadingKey(key, lockingKey, e); throw new PersistenceException(String.format( "SQL error while fetching stored entry with key: %s, lockingKey: %s", key, lockingKey), e); } finally { JdbcUtil.safeClose(rs); JdbcUtil.safeClose(ps); connectionFactory.releaseConnection(conn); } if (entry != null && entry.getMetadata() != null && entry.isExpired(timeService.wallClockTime())) { return null; } return entry; }
Source:
<code>public boolean applyTo(Project project) <START> throws FileNotFoundException { <END> final Module[] modules = ModuleManager.getInstance(project).getModules(); for (Module module : modules) { ModuleData data = myData.get(module.getName()); if (data == null) { return false; } AndroidFacet androidFacet = AndroidFacet.getInstance(module); String moduleFilePath = module.getModuleFilePath(); if (androidFacet != null) { if (data.myAndroidProject != null) { File moduleFile = new File(moduleFilePath); assert moduleFile.getParent() != null : moduleFile.getPath(); File moduleRootDirPath = moduleFile.getParentFile(); IdeaAndroidProject ideaAndroidProject = new IdeaAndroidProject(module.getName(), moduleRootDirPath, data.myAndroidProject, data.mySelectedVariant); androidFacet.setIdeaAndroidProject(ideaAndroidProject); } else { return false; } } AndroidGradleFacet gradleFacet = AndroidGradleFacet.getInstance(module); if (gradleFacet != null) { gradleFacet.setGradleProject(data.myIdeaGradleProject); } JavaGradleFacet javaFacet = JavaGradleFacet.getInstance(module); if (javaFacet != null && data.myJavaModel != null) { javaFacet.setJavaModel(data.myJavaModel); } } GradleSyncState syncState = GradleSyncState.getInstance(project); syncState.setLastGradleSyncTimestamp(myLastGradleSyncTimestamp); return true; }</code><technical_language>Is thrown</technical_language>

Target:
public boolean applyTo(Project project) { final Module[] modules = ModuleManager.getInstance(project).getModules(); for (Module module : modules) { ModuleData data = myData.get(module.getName()); if (data == null) { return false; } AndroidFacet androidFacet = AndroidFacet.getInstance(module); String moduleFilePath = module.getModuleFilePath(); if (androidFacet != null) { if (data.myAndroidProject != null) { File moduleFile = new File(moduleFilePath); assert moduleFile.getParent() != null : moduleFile.getPath(); File moduleRootDirPath = moduleFile.getParentFile(); IdeaAndroidProject ideaAndroidProject = new IdeaAndroidProject(module.getName(), moduleRootDirPath, data.myAndroidProject, data.mySelectedVariant); androidFacet.setIdeaAndroidProject(ideaAndroidProject); } else { return false; } } AndroidGradleFacet gradleFacet = AndroidGradleFacet.getInstance(module); if (gradleFacet != null) { gradleFacet.setGradleProject(data.myIdeaGradleProject); } JavaGradleFacet javaFacet = JavaGradleFacet.getInstance(module); if (javaFacet != null && data.myJavaModel != null) { javaFacet.setJavaModel(data.myJavaModel); } } GradleSyncState syncState = GradleSyncState.getInstance(project); syncState.setLastGradleSyncTimestamp(myLastGradleSyncTimestamp); return true; }
Source:
<code><START> public EventBus getEventBus() { <END> return eventBus; }</code><technical_language>Thinking it, this method protected final</technical_language>

Target:
protected final EventBus getEventBus() { return eventBus; }
Source:
<code>private void setupLoaders() { final LoaderManager manager = this.getSupportLoaderManager(); Bundle args = new Bundle(4); args.putString("measurementId", measurementId); args.putString("ministryId", ministryId); args.putString("mcc", mcc); <START> args.putString("period", period); <END> manager.initLoader(LOADER_MEASUREMENT_DETAILS, args, measurementDetailsLoaderCallback); }</code><technical_language>strings referenced in multiple places (and classes), beneficial shared static constants guarantee consistent used</technical_language>

Target:
private void setupLoaders() { final LoaderManager manager = this.getSupportLoaderManager(); Bundle args = new Bundle(4); args.putString(Constants.ARG_MEASUREMENT_ID, measurementId); args.putString(Constants.ARG_MINISTRY_ID, ministryId); args.putString(Constants.ARG_MCC, mcc); args.putString(Constants.ARG_PERIOD, period); manager.initLoader(LOADER_MEASUREMENT_DETAILS, args, measurementDetailsLoaderCallback); }
Source:
<code>public void bulkImport(Collection<T> items) { User authenticatedUser = new User(); authenticatedUser.setUsername(AuthenticatedRequest.getSpinnakerUser().orElse("anonymous")); if (service instanceof BulkStorageService) { <START> items.forEach( item -> { item.setLastModifiedBy(AuthenticatedRequest.getSpinnakerUser().orElse("anonymous")); item.setLastModified(System.currentTimeMillis()); }); ((BulkStorageService) service).storeObjects(objectType, items); return; <END> } Observable.from(items) .buffer(10) .flatMap( itemSet -> Observable.from(itemSet) .flatMap( item -> { try { return AuthenticatedRequest.propagate( () -> { update(item.getId(), item); return Observable.just(item); }, true, authenticatedUser) .call(); } catch (Exception e) { throw new RuntimeException(e); } }) .subscribeOn(scheduler)) .subscribeOn(scheduler) .toList() .toBlocking() .single(); }</code><technical_language>prob out values set loop, faster update time for items suggestion long updateTime = System.currentTimeMillis(); String modifiedBy = AuthenticatedRequest.getSpinnakerUser().orElse("anonymous"); items.forEach( item -> { item.setLastModifiedBy(modifiedBy); item.setLastModified(updateTime); });</technical_language>

Target:
public void bulkImport(Collection<T> items) { User authenticatedUser = new User(); authenticatedUser.setUsername(AuthenticatedRequest.getSpinnakerUser().orElse("anonymous")); if (service instanceof BulkStorageService) { String lastModifiedBy = AuthenticatedRequest.getSpinnakerUser().orElse("anonymous"); Long lastModified = System.currentTimeMillis(); items.forEach( item -> { item.setLastModifiedBy(lastModifiedBy); item.setLastModified(lastModified); }); ((BulkStorageService) service).storeObjects(objectType, items); return; } Observable.from(items) .buffer(10) .flatMap( itemSet -> Observable.from(itemSet) .flatMap( item -> { try { return AuthenticatedRequest.propagate( () -> { update(item.getId(), item); return Observable.just(item); }, true, authenticatedUser) .call(); } catch (Exception e) { throw new RuntimeException(e); } }) .subscribeOn(scheduler)) .subscribeOn(scheduler) .toList() .toBlocking() .single(); }
Source:
<code>public RequestInfo execute(Context context) { Map<String, Object> params = new HashMap<String, Object>(); params.put("now", new Date()); params.put("owner", ExecutorService.EXECUTOR_ID); RequestInfo request = null; try { org.jbpm.shared.services.impl.JpaPersistenceContext ctx = (org.jbpm.shared.services.impl.JpaPersistenceContext) context; if ("org.jbpm.persistence.jpa.hibernate.DisabledFollowOnLockOracle10gDialect".equals(ctx.get("hibernate.dialect"))) { Object[] lockedRequest = (Object[])ctx.nativeQueryAndLockWithParametersInTransaction("NativePendingRequestsForProcessing", params, true, Object.class); if (lockedRequest != null && lockedRequest.length > 0) { try { request = ctx.find(org.jbpm.executor.entities.RequestInfo.class, ((Number)lockedRequest[0]).longValue()); } catch(NumberFormatException nfe) { <START> } <END> } } else { params.put("firstResult", 0); params.put("maxResults", 1); request = ctx.queryAndLockWithParametersInTransaction("PendingRequestsForProcessing", params, true, RequestInfo.class); } if (request != null) { request.setStatus(STATUS.RUNNING); ((org.jbpm.executor.entities.RequestInfo) request).setTime(new Date()); ctx.merge(request); } } catch (NoResultException e) { } return request; }</code><technical_language>include a warning log message? Empty catch blocks a good practice if is a chance of throwing exception</technical_language>

Target:
public RequestInfo execute(Context context) { Map<String, Object> params = new HashMap<String, Object>(); params.put("now", new Date()); params.put("owner", ExecutorService.EXECUTOR_ID); RequestInfo request = null; try { org.jbpm.shared.services.impl.JpaPersistenceContext ctx = (org.jbpm.shared.services.impl.JpaPersistenceContext) context; if ("org.jbpm.persistence.jpa.hibernate.DisabledFollowOnLockOracle10gDialect".equals(ctx.get("hibernate.dialect"))) { Object[] lockedRequest = (Object[])ctx.nativeQueryAndLockWithParametersInTransaction("NativePendingRequestsForProcessing", params, true, Object.class); if (lockedRequest != null && lockedRequest.length > 0) { try { request = ctx.find(org.jbpm.executor.entities.RequestInfo.class, ((Number)lockedRequest[0]).longValue()); } catch(NumberFormatException nfe) { logger.error("Error while retrieving request id", nfe); } } } else { params.put("firstResult", 0); params.put("maxResults", 1); request = ctx.queryAndLockWithParametersInTransaction("PendingRequestsForProcessing", params, true, RequestInfo.class); } if (request != null) { request.setStatus(STATUS.RUNNING); ((org.jbpm.executor.entities.RequestInfo) request).setTime(new Date()); ctx.merge(request); } } catch (NoResultException e) { } return request; }
Source:
<code>public void actionPerformed(ActionEvent e) { if (seq != null && seq.getKey() != null) { Iterator<MapillaryAbstractImage> iterator; <START> iterator = seq.getImages().iterator(); <END> if (isSeqDeleted()) { while (iterator.hasNext()) { MapillaryAbstractImage img = iterator.next(); if (img instanceof MapillaryImage) { ((MapillaryImage) img).unmarkDeleted(); } } } else { while (iterator.hasNext()) { MapillaryAbstractImage img = iterator.next(); if (img instanceof MapillaryImage) { ((MapillaryImage) img).markDeleted(); } } } updateText(); MapillaryLayer.getInstance().invalidate(); } }</code><technical_language>is this a separate line? (Why a specific iterator?)</technical_language>

Target:
public void actionPerformed(ActionEvent e) { if (seq != null && seq.getKey() != null) { if (isSeqDeleted()) { for (MapillaryAbstractImage img : seq.getImages()) { if (img instanceof MapillaryImage) { ((MapillaryImage) img).unmarkDeleted(); } } } else { for (MapillaryAbstractImage img : seq.getImages()) { if (img instanceof MapillaryImage) { ((MapillaryImage) img).unmarkDeleted(); } } } updateText(); MapillaryLayer.getInstance().invalidate(); } }
Source:
<code>public SymmetricHashJoin construct(final ConstructArgs args) { SymmetricHashJoin join = new SymmetricHashJoin( null, null, argColumns1, argColumns2, argSelect1, argSelect2, argSetSemanticsLeft, argSetSemanticsRight, argColumnNames); <START> join.setPullOrder(argOrder); <END> return join; }</code><technical_language>If this setter is called moved constructor</technical_language>

Target:
public SymmetricHashJoin construct(final ConstructArgs args) { return new SymmetricHashJoin( null, null, argColumns1, argColumns2, argSelect1, argSelect2, argSetSemanticsLeft, argSetSemanticsRight, argColumnNames, argOrder); }
Source:
<code>public PersistentUpperLimit(TimestampBoundStore tbs, Clock clock, TimestampAllocationFailures allocationFailures) { <START> DebugLogger.logger.info("Creating PersistentUpperLimit object on thread {}. This should only happen once." <END> + " If you are running embedded AtlasDB, this should only happen once." + " If you are using Timelock, this should happen once per client per leadership election", Thread.currentThread().getName()); this.tbs = tbs; this.clock = clock; this.allocationFailures = checkNotNull(allocationFailures); cachedValue = tbs.getUpperLimit(); lastIncreasedTime = clock.getTimeMillis(); }</code><technical_language>nit: I This happen once. removed (probably hanging copypaste)</technical_language>

Target:
public PersistentUpperLimit(TimestampBoundStore tbs, Clock clock, TimestampAllocationFailures allocationFailures) { DebugLogger.logger.info("Creating PersistentUpperLimit object on thread {}." + " If you are running embedded AtlasDB, this should only happen once." + " If you are using Timelock, this should happen once per client per leadership election", Thread.currentThread().getName()); this.tbs = tbs; this.clock = clock; this.allocationFailures = checkNotNull(allocationFailures); cachedValue = tbs.getUpperLimit(); lastIncreasedTime = clock.getTimeMillis(); }
Source:
<code>public static void main(String[] args) { HealthCheck healthCheckHandler = new HealthCheck(); Karyon.forRequestHandler(8888, new RxNettyHandler("/healthcheck", new HealthCheckEndpoint(healthCheckHandler)), new KaryonBootstrapModule(healthCheckHandler), new ArchaiusBootstrapModule("hello-netflix-oss"), Karyon.toBootstrapModule(KaryonWebAdminModule.class), ShutdownModule.asBootstrapModule(), KaryonServoModule.asBootstrapModule(), <START> Karyon.toBootstrapModule(HealthCheckStrategyModule.class) <END> ) .startAndWaitTillShutdown(); }</code><technical_language>I encourage people admin healthcheck strategy module give a comprehensive indication of health of application</technical_language>

Target:
public static void main(String[] args) { HealthCheck healthCheckHandler = new HealthCheck(); Karyon.forRequestHandler(8888, new RxNettyHandler("/healthcheck", new HealthCheckEndpoint(healthCheckHandler)), new KaryonBootstrapModule(healthCheckHandler), new ArchaiusBootstrapModule("hello-netflix-oss"), Karyon.toBootstrapModule(KaryonWebAdminModule.class), ShutdownModule.asBootstrapModule(), KaryonServoModule.asBootstrapModule(), Karyon.toBootstrapModule(HealthCheckHandlerModule.class) ) .startAndWaitTillShutdown(); }
Source:
<code>private boolean attributeLineCommentToNodeOrChild(Node node, LineComment lineComment) { <START> <END> if (node.getRange().get().begin.line == lineComment.getRange().get().begin.line && !node.hasComment()) { if (!(node instanceof Comment)) { node.setComment(lineComment); } return true; } else { List<Node> children = new LinkedList<>(); children.addAll(node.getChildNodes()); PositionUtils.sortByBeginPosition(children); Collections.reverse(children); for (Node child : children) { if (attributeLineCommentToNodeOrChild(child, lineComment)) { return true; } } return false; } }</code><technical_language>extra white line</technical_language>

Target:
private boolean attributeLineCommentToNodeOrChild(Node node, LineComment lineComment) { if (node.getBegin().get().line == lineComment.getBegin().get().line && !node.hasComment()) { if (!(node instanceof Comment)) { node.setComment(lineComment); } return true; } else { List<Node> children = new LinkedList<>(); children.addAll(node.getChildNodes()); PositionUtils.sortByBeginPosition(children); Collections.reverse(children); for (Node child : children) { if (attributeLineCommentToNodeOrChild(child, lineComment)) { return true; } } return false; } }
Source:
<code><START> int findItemIndex(ITimeGraphEntry entry) { <END> Item item = fItemMap.get(entry); if (item == null) { return -1; } return item.fExpandedIndex; }</code><technical_language>public modifier, for consistency</technical_language>

Target:
public int findItemIndex(ITimeGraphEntry entry) { Item item = fItemMap.get(entry); if (item == null) { return -1; } return item.fExpandedIndex; }
Source:
<code>public void persistBaseline(Map<String, ResourceAssignment> globalBaseline) { _globalBaseline = globalBaseline; HelixProperty combinedAssignments = combineAssignments(BASELINE_KEY, globalBaseline); try { _dataAccessor.compressedBucketWrite(_baselinePath, combinedAssignments); } catch (IOException e) { <START> throw new HelixException("Failed to persist baseline!", e); <END> } }</code><technical_language>Please cleanup new values fro memory, set in-memory part this write is done successfully</technical_language>

Target:
public void persistBaseline(Map<String, ResourceAssignment> globalBaseline) { HelixProperty combinedAssignments = combineAssignments(BASELINE_KEY, globalBaseline); try { _dataAccessor.compressedBucketWrite(_baselinePath, combinedAssignments); } catch (IOException e) { throw new HelixException("Failed to persist baseline!", e); } _globalBaseline = globalBaseline; }
Source:
<code>public void select() { log.info("Select view menu with text " + getText()); if (item == null) { mh.select(menuItem); } else { <START> if ((item.getAction().getStyle() == IAction.AS_CHECK_BOX) || (item.getAction().getStyle() == IAction.AS_RADIO_BUTTON)) { <END> Display.syncExec(new Runnable() { @Override public void run() { item.getAction().setChecked(!item.getAction().isChecked()); item.getAction().run(); } }); } else { mh.select(item); } } }</code><technical_language>good prefer sync async operations executed Handler classes. please move this logic MenuHandler class <LINK_0> ? Thanks</technical_language>

Target:
public void select() { log.info("Select view menu with text " + getText()); if (item == null) { mh.select(menuItem); } else { mh.select(item); } }
Source:
<code>public void reset() { activeLoadId.incrementAndGet(); adapter.clear(); hasMoreItems = true; <START> loading = false; <END> loadMore(); }</code><technical_language>This redundantly check loading hasMoreItems values. more correct instead change loadMore call onLoadMore</technical_language>

Target:
public void reset() { activeLoadId.incrementAndGet(); adapter.clear(); hasMoreItems = true; loading = true; onLoadMore(); }
Source:
<code>ParsedRegistryID(String id) { try { id = URLDecoder.decode(id, StandardCharsets.UTF_8.displayName()); } catch (UnsupportedEncodingException e) { throw new RuntimeException(e); } List<String> textSegments = Splitter.on('/').omitEmptyStrings().splitToList(id); if (textSegments.get(0).equalsIgnoreCase("#workflow")) { tool = false; <START> registry = textSegments.get(1); <END> organization = textSegments.get(2); name = textSegments.get(3); toolName = textSegments.size() > 4 ? textSegments.get(4) : ""; } else { registry = textSegments.get(0); organization = textSegments.get(1); name = textSegments.get(2); toolName = textSegments.size() > 3 ? textSegments.get(3) : ""; } }</code><technical_language>This a method index avoid copy-paste</technical_language>

Target:
ParsedRegistryID(String id) { try { id = URLDecoder.decode(id, StandardCharsets.UTF_8.displayName()); } catch (UnsupportedEncodingException e) { throw new RuntimeException(e); } List<String> textSegments = Splitter.on('/').omitEmptyStrings().splitToList(id); List<String> list = new ArrayList<>(textSegments); if (list.get(0).equalsIgnoreCase("#workflow")) { list.remove(0); tool = false; } registry = list.get(0); organization = list.get(1); name = list.get(2); toolName = list.size() > SEGMENTS_IN_ID ? list.get(SEGMENTS_IN_ID) : ""; }
Source:
<code>public void onClick(View view) { Intent intent = new Intent(); switch (view.getId()) { case R.id.nav_item_today: ((PageActivity)getActivity()).displayMainPage(); break; case R.id.nav_item_history: ((PageActivity)getActivity()).pushFragment(new HistoryFragment()); break; case R.id.nav_item_saved_pages: ((PageActivity)getActivity()).pushFragment(new SavedPagesFragment()); break; case R.id.nav_item_nearby: ((PageActivity)getActivity()).pushFragment(new NearbyFragment()); break; case R.id.nav_item_more: intent.setClass(this.getActivity(), SettingsActivity.class); startActivityForResult(intent, SettingsActivity.ACTIVITY_REQUEST_SHOW_SETTINGS); break; case R.id.nav_item_login: intent.setClass(this.getActivity(), LoginActivity.class); intent.putExtra(LoginActivity.LOGIN_REQUEST_SOURCE, LoginFunnel.SOURCE_NAV); startActivity(intent); break; case R.id.nav_item_random: <START> if (app.getReleaseType() == WikipediaApp.RELEASE_BETA){ <END> ((PageActivity)getActivity()).pushFragment(new RandomFragment()); } else { randomHandler.doVisitRandomArticle(); } break; default: throw new RuntimeException("Unknown ID clicked!"); } }</code><technical_language>!= RELEASE_PROD, feature in Beta Alpha</technical_language>

Target:
public void onClick(View view) { Intent intent = new Intent(); switch (view.getId()) { case R.id.nav_item_today: ((PageActivity)getActivity()).displayMainPage(); break; case R.id.nav_item_history: ((PageActivity)getActivity()).pushFragment(new HistoryFragment()); break; case R.id.nav_item_saved_pages: ((PageActivity)getActivity()).pushFragment(new SavedPagesFragment()); break; case R.id.nav_item_nearby: ((PageActivity)getActivity()).pushFragment(new NearbyFragment()); break; case R.id.nav_item_more: intent.setClass(this.getActivity(), SettingsActivity.class); startActivityForResult(intent, SettingsActivity.ACTIVITY_REQUEST_SHOW_SETTINGS); break; case R.id.nav_item_login: intent.setClass(this.getActivity(), LoginActivity.class); intent.putExtra(LoginActivity.LOGIN_REQUEST_SOURCE, LoginFunnel.SOURCE_NAV); startActivity(intent); break; case R.id.nav_item_random: if (app.getReleaseType() != WikipediaApp.RELEASE_PROD){ ((PageActivity)getActivity()).pushFragment(new RandomFragment()); } else { randomHandler.doVisitRandomArticle(); } break; default: throw new RuntimeException("Unknown ID clicked!"); } }
Source:
<code>public void onChildRemoved(Object parentElement, Object childElement) { Integer parentNodeId = mObjectIdMapper.getIdForObject(parentElement); Integer childNodeId = mObjectIdMapper.getIdForObject(childElement); if (parentNodeId == null || childNodeId == null) { LogUtil.w( <START> "DOM.onChildRemoved() called for a non-mapped node: " <END> + "parentElement=(nodeId=%s, %s), childElement=(nodeId=%s, %s)", parentNodeId, parentElement, childNodeId, childElement); } else { ChildNodeRemovedEvent message = new ChildNodeRemovedEvent(); message.parentNodeId = parentNodeId; message.nodeId = childNodeId; mPeerManager.sendNotificationToPeers("DOM.childNodeRemoved", message); } removeElementTree(childElement); }</code><technical_language>this spam in practice? I want avoid confusing folks internal error messages. Specifically, if this is expected and/or fires often, consider debug info level</technical_language>

Target:
public void onChildRemoved(Object parentElement, Object childElement) { Integer parentNodeId = mObjectIdMapper.getIdForObject(parentElement); Integer childNodeId = mObjectIdMapper.getIdForObject(childElement); if (parentNodeId == null || childNodeId == null) { LogUtil.d( "DOM.onChildRemoved() called for a non-mapped node: " + "parentElement=(nodeId=%s, %s), childElement=(nodeId=%s, %s)", parentNodeId, parentElement, childNodeId, childElement); } else { ChildNodeRemovedEvent message = new ChildNodeRemovedEvent(); message.parentNodeId = parentNodeId; message.nodeId = childNodeId; mPeerManager.sendNotificationToPeers("DOM.childNodeRemoved", message); } removeElementTree(childElement); }
Source:
<code>public OzoneAcl(ACLIdentityType type, String name, BitSet acls) { Objects.requireNonNull(type); Objects.requireNonNull(acls); if(acls.cardinality() > ACLType.getNoOfAcls()) { throw new IllegalArgumentException("Acl bitset passed has unexpected " + "size. bitset size:" + acls.cardinality() + ", bitset:" + acls.toString()); } <START> this.aclBitSet = new BitSet(); <END> acls.stream().forEach(a -> aclBitSet.set(a)); this.name = name; this.type = type; if (type == ACLIdentityType.WORLD && name.length() != 0) { throw new IllegalArgumentException("Unexpected name part in world type"); } if (((type == ACLIdentityType.USER) || (type == ACLIdentityType.GROUP)) && (name.length() == 0)) { throw new IllegalArgumentException("User or group name is required"); } }</code><technical_language>this simplified this.aclBitSet= acls.clone();</technical_language>

Target:
public OzoneAcl(ACLIdentityType type, String name, BitSet acls) { Objects.requireNonNull(type); Objects.requireNonNull(acls); if(acls.cardinality() > ACLType.getNoOfAcls()) { throw new IllegalArgumentException("Acl bitset passed has unexpected " + "size. bitset size:" + acls.cardinality() + ", bitset:" + acls.toString()); } this.aclBitSet = (BitSet) acls.clone(); acls.stream().forEach(a -> aclBitSet.set(a)); this.name = name; this.type = type; if (type == ACLIdentityType.WORLD && name.length() != 0) { throw new IllegalArgumentException("Unexpected name part in world type"); } if (((type == ACLIdentityType.USER) || (type == ACLIdentityType.GROUP)) && (name.length() == 0)) { throw new IllegalArgumentException("User or group name is required"); } }
Source:
<code>private static TopologyDef loadYaml(Yaml yaml, InputStream in, Properties properties, boolean envSubstitution) { LOG.info("loading YAML from input stream..."); StringBuilder bos = new StringBuilder(); <START> BufferedReader reader = new BufferedReader(new InputStreamReader(in)); <END> reader.lines().forEach(line -> { Matcher m = propertyPattern.matcher(line); if (m.find()) { String target = "${" + m.group("var") + "}"; Optional<String> replacement = getPropertyReplacement(properties, m, envSubstitution); replacement.ifPresent(propValue -> bos.append(line.replace(target, propValue))); if (!replacement.isPresent()) { LOG.warn("Could not found replacement for property: " + m.group("var")); bos.append(line); } } else { bos.append(line); } bos.append(System.lineSeparator()); }); return (TopologyDef) yaml.load(bos.toString()); }</code><technical_language>closing readers</technical_language>

Target:
private static TopologyDef loadYaml(Yaml yaml, InputStream in, Properties properties, boolean envSubstitution) throws IOException { LOG.info("loading YAML from input stream..."); try (BufferedReader reader = new BufferedReader(new InputStreamReader(in))) { String conf = reader.lines().map(line -> { Matcher m = propertyPattern.matcher(line); return m.find() ? getPropertyReplacement(properties, m, envSubstitution) .map(propValue -> line.replace("${" + m.group("var") + "}", propValue)) .orElseGet(() -> { LOG.warn("Could not find replacement for property: " + m.group("var")); return line; }) : line; }).collect(Collectors.joining(System.lineSeparator())); return (TopologyDef) yaml.load(conf); } }
Source:
<code>public HelixRestServer(String zkAddr, int port, String urlPrefix) { <START> this(zkAddr, port, urlPrefix, Collections.emptyList()); <END> }</code><technical_language>Tip: If change logic, please avoid formatting existing code. a separate PR reformatting clear logic changes. reviewing harder longer get reviewed</technical_language>

Target:
public HelixRestServer(String zkAddr, int port, String urlPrefix) { this(zkAddr, port, urlPrefix, Collections.<AuditLogger>emptyList()); }
Source:
<code>public void close() throws IOException { <START> if (watchService != null) { <END> watchService.close(); } watchers.clear(); }</code><technical_language>watchService null</technical_language>

Target:
public void close() throws IOException { for (WatchKey key : watchers.keySet()) { key.cancel(); } watchers.clear(); watchService.close(); }
Source:
<code>public static void assertEqualsByteArray(byte[] expected,byte[] current){ <START> for(int k = 0; k < expected.length; k++){ <END> assertEquals(expected[k], current[k]); } }</code><technical_language>if arrays difference sizes. get index out of bounds checking element</technical_language>

Target:
public static void assertEqualsByteArray(byte[] expected,byte[] current){ assertEquals("Byte arrays' lengths not the same", expected.length , current.length); for(int k = 0; k < expected.length; k++){ assertEquals(k + "th index not equal" , expected[k] , current[k]); } }
Source:
<code>public boolean exec() throws CliException { String path = args[1]; String aclStr = args[2]; List<ACL> acl = AclParser.parse(aclStr); int version; if (cl.hasOption("v")) { version = Integer.parseInt(cl.getOptionValue("v")); } else { version = -1; } try { if (cl.hasOption("R")) { ZKUtil.visitSubTreeDFS(zk, path, false, new StringCallback() { @Override <START> public void processResult(int rc, String path, Object ctx, String name) { <END> try { zk.setACL(path, acl, version); } catch (KeeperException | InterruptedException e) { out.print(e.getMessage()); } } }); } else { Stat stat = zk.setACL(path, acl, version); if (cl.hasOption("s")) { new StatPrinter(out).print(stat); } } } catch (IllegalArgumentException ex) { throw new MalformedPathException(ex.getMessage()); } catch (KeeperException|InterruptedException ex) { throw new CliWrapperException(ex); } return false; }</code><technical_language>avoid overriding path variable here</technical_language>

Target:
public boolean exec() throws CliException { String path = args[1]; String aclStr = args[2]; List<ACL> acl = AclParser.parse(aclStr); int version; if (cl.hasOption("v")) { version = Integer.parseInt(cl.getOptionValue("v")); } else { version = -1; } try { if (cl.hasOption("R")) { ZKUtil.visitSubTreeDFS(zk, path, false, new StringCallback() { @Override public void processResult(int rc, String p, Object ctx, String name) { try { zk.setACL(p, acl, version); } catch (KeeperException | InterruptedException e) { out.print(e.getMessage()); } } }); } else { Stat stat = zk.setACL(path, acl, version); if (cl.hasOption("s")) { new StatPrinter(out).print(stat); } } } catch (IllegalArgumentException ex) { throw new MalformedPathException(ex.getMessage()); } catch (KeeperException|InterruptedException ex) { throw new CliWrapperException(ex); } return false; }
Source:
<code>public void requestNewAccessToken() { AccessTokenDTO newToken = callConcurEndpoint( <START> this::callRequestAccessTokenEndpoint, AccessTokenDTO.class); <END> setWebserivceCredentialValues(newToken.getToken(), newToken.getExpirationDate(), newToken.getRefreshToken()); }</code><technical_language>do add clarity move "this::CallRequestAccessTokenEndpoint" a variable: Function<Client, Response> endpointCaller</technical_language>

Target:
public void requestNewAccessToken() { AccessTokenDTO newToken = callConcurEndpoint( this::buildRequestAccessTokenClientRequest, AccessTokenDTO.class); setWebserivceCredentialValues(newToken.getToken(), newToken.getExpirationDate(), newToken.getRefreshToken()); }
Source:
<code><START> private LifecycleInjector createInjector(List<Module> modules, List<Module> overrides) { <END> return InjectorBuilder.fromModules(modules).overrideWith(overrides).createInjector(); }</code><technical_language>Is this method necessary? This code is called place</technical_language>

Target:
protected LifecycleInjector createInjector(List<Module> modules, List<Module> overrides) { return InjectorBuilder.fromModules(modules).overrideWith(overrides).createInjector(); }