auphong2707/dl4se-code-review-dataset huggingface dataset:
Source:
<code>public static List<ItemStack> getItemStackFromBlock(World world, int i, int j, int k) { Block block = Block.blocksList[world.getBlockId(i, j, k)]; if (block == null) return null; if (block.isAirBlock(world, i, j, k)) return null; int meta = world.getBlockMetadata(i, j, k); ArrayList<ItemStack> dropsList = block.getBlockDropped(world, i, j, k, meta, 0); <START> float dropChance = ForgeEventFactory.fireBlockHarvesting(dropsList, world, block, i, j, k, world.getBlockMetadata(i, j, k), 0, 1.0F, false, null); <END> ArrayList<ItemStack> returnList = new ArrayList<ItemStack>(); for (ItemStack s : dropsList) { if (world.rand.nextFloat() <= dropChance) { returnList.add(s); } } return returnList; }</code><technical_language>local meta defined a lines above. Saves a method call;</technical_language>

Target:
public static List<ItemStack> getItemStackFromBlock(World world, int i, int j, int k) { Block block = Block.blocksList[world.getBlockId(i, j, k)]; if (block == null) return null; if (block.isAirBlock(world, i, j, k)) return null; int meta = world.getBlockMetadata(i, j, k); ArrayList<ItemStack> dropsList = block.getBlockDropped(world, i, j, k, meta, 0); float dropChance = ForgeEventFactory.fireBlockHarvesting(dropsList, world, block, i, j, k, meta, 0, 1.0F, false, null); ArrayList<ItemStack> returnList = new ArrayList<ItemStack>(); for (ItemStack s : dropsList) { if (world.rand.nextFloat() <= dropChance) { returnList.add(s); } } return returnList; }
Source:
<code>private void flush(List<String> cacheNames) throws UnprocessableEntityException, AuthException { List<CacheResource> cacheResources = new <START> ArrayList<>(); <END> for (String n : cacheNames) { String pluginName = "gerrit"; String cacheName = n; int i = cacheName.lastIndexOf('-'); if (i != -1) { pluginName = cacheName.substring(0, i); cacheName = cacheName.length() > i + 1 ? cacheName.substring(i + 1) : ""; } Cache<?, ?> cache = cacheMap.get(pluginName, cacheName); if (cache != null) { cacheResources.add(new CacheResource(pluginName, cacheName, cache)); } else { throw new UnprocessableEntityException(String.format( "cache %s not found", n)); } } for (CacheResource rsrc : cacheResources) { flushCache.get().apply(rsrc, new FlushCache.Input()); } }</code><technical_language>Pass capacity cacheNames.size() construct array right size</technical_language>

Target:
private void flush(List<String> cacheNames) throws UnprocessableEntityException, AuthException { List<CacheResource> cacheResources = new ArrayList<>(cacheNames.size()); for (String n : cacheNames) { String pluginName = "gerrit"; String cacheName = n; int i = cacheName.lastIndexOf('-'); if (i != -1) { pluginName = cacheName.substring(0, i); cacheName = cacheName.length() > i + 1 ? cacheName.substring(i + 1) : ""; } Cache<?, ?> cache = cacheMap.get(pluginName, cacheName); if (cache != null) { cacheResources.add(new CacheResource(pluginName, cacheName, cache)); } else { throw new UnprocessableEntityException(String.format( "cache %s not found", n)); } } for (CacheResource rsrc : cacheResources) { flushCache.apply(rsrc, null); } }
Source:
<code>protected ClientHttpResponse run() throws Exception { final RequestContext context = RequestContext.getCurrentContext(); RQ request = createRequest(); RS response; <START> if (!isExecuteWithLoadBalancer() <END> && request!= null && request.isRetriable()) { response = this.client.execute(request, config); } else { response = this.client.executeWithLoadBalancer(request, config); } context.set("ribbonResponse", response); if (this.isResponseTimedOut()) { if (response != null) { response.close(); } } return new RibbonHttpResponse(response); }</code><technical_language>I understanding RestClientRibbonCommand call execute directly, explain</technical_language>

Target:
protected ClientHttpResponse run() throws Exception { final RequestContext context = RequestContext.getCurrentContext(); RQ request = createRequest(); RS response; boolean retryableClient = this.client instanceof AbstractLoadBalancingClient && ((AbstractLoadBalancingClient)this.client).isClientRetryable((ContextAwareRequest)request); if (retryableClient) { response = this.client.execute(request, config); } else { response = this.client.executeWithLoadBalancer(request, config); } context.set("ribbonResponse", response); if (this.isResponseTimedOut()) { if (response != null) { response.close(); } } return new RibbonHttpResponse(response); }
Source:
<code>public void onBlogClicked(Object item) { long blogId; long feedId; if (item instanceof ReaderRecommendedBlog) { ReaderRecommendedBlog blog = (ReaderRecommendedBlog) item; blogId = blog.blogId; feedId = 0; } else if (item instanceof ReaderBlog) { ReaderBlog blog = (ReaderBlog) item; blogId = blog.blogId; feedId = blog.feedId; } else { return; } <START> ReaderActivityLauncher.showReaderBlogPreview(getActivity(), blogId, feedId); <END> }</code><technical_language>This method simplified into: @Override public void onBlogClicked(Object item) { if (item instanceof ReaderRecommendedBlog) { ReaderRecommendedBlog blog = (ReaderRecommendedBlog) item; ReaderActivityLauncher.showReaderBlogPreview(getActivity(), blog.blogId); } else if (item instanceof ReaderBlog) { ReaderBlog blog = (ReaderBlog) item; ReaderActivityLauncher.showReaderBlogPreview(getActivity(), blog.blogId, blog.feedId); } }</technical_language>

Target:
public void onBlogClicked(Object item) { if (item instanceof ReaderRecommendedBlog) { ReaderRecommendedBlog blog = (ReaderRecommendedBlog) item; ReaderActivityLauncher.showReaderBlogPreview(getActivity(), blog.blogId); } else if (item instanceof ReaderBlog) { ReaderBlog blog = (ReaderBlog) item; ReaderActivityLauncher.showReaderBlogOrFeedPreview(getActivity(), blog.blogId, blog.feedId); } }
Source:
<code>public static void main(String... args) throws Exception { Options opts = new OptionsBuilder() .include( ".*" ) .warmupIterations( 20 ) .measurementIterations( 20 ) .jvmArgs( "-server" ) <START> .jvmArgsAppend( "-XX:+UnlockCommercialFeatures", "-XX:+FlightRecorder" ) <END> .forks( 1 ) .build(); new Runner(opts).run(); }</code><technical_language>option? of run OpenJDK: fail</technical_language>

Target:
public static void main(String... args) throws Exception { String benchmarkArgsString = System.getProperty( BENCHMARK_VM_ARGS_KEY ); String[] benchMarkArgs; if ( benchmarkArgsString != null ) { benchMarkArgs = benchmarkArgsString.split( "\\s+" ); } else { benchMarkArgs = new String[0]; } Options opts = new OptionsBuilder() .include( ".*" ) .warmupIterations( 20 ) .measurementIterations( 20 ) .jvmArgs( "-server" ) .jvmArgsAppend( benchMarkArgs ) .forks( 1 ) .build(); new Runner(opts).run(); }
Source:
<code>protected IntegrationNode(int nodeId, String name, Object nodeObject, Stats stats) { this.nodeId = nodeId; this.name = name; this.componentType = nodeObject instanceof NamedComponent ? ((NamedComponent) nodeObject).getComponentType() : nodeObject.getClass().getSimpleName(); this.stats = stats; <START> if (nodeObject instanceof IntegrationObjectSupport) { <END> String expressionString = ((IntegrationObjectSupport) nodeObject).getExpressionString(); if (expressionString != null) { this.properties.put("expression", expressionString); } } }</code><technical_language>Yeah... problem is IOS is class, proxy issue a place anyway. I agree hell marker interfaces wearies a bit, bad analysis distinguish components marker interfaces. I mind for ExpressionBased, thrilled package for it... arguments do in IOS</technical_language>

Target:
protected IntegrationNode(int nodeId, String name, Object nodeObject, Stats stats) { this.nodeId = nodeId; this.name = name; this.componentType = nodeObject instanceof NamedComponent ? ((NamedComponent) nodeObject).getComponentType() : nodeObject.getClass().getSimpleName(); this.stats = stats; if (nodeObject instanceof ExpressionCapable) { Expression expression = ((ExpressionCapable) nodeObject).getExpression(); if (expression != null) { this.properties.put("expression", expression.getExpressionString()); } } }
Source:
<code>public void testSystemPropertiesOverrideConfigurationValues() { final String keyName = CoreConfig.MAX_CASSANDRA_CONNECTIONS.toString(); Configuration config = Configuration.getInstance(); try { Assert.assertEquals("75", config.getStringProperty(CoreConfig.MAX_CASSANDRA_CONNECTIONS)); System.setProperty(keyName, "something else"); Assert.assertEquals("something else", config.getStringProperty(CoreConfig.MAX_CASSANDRA_CONNECTIONS)); } finally { System.clearProperty(keyName); <START> Configuration.clearProperty(keyName); <END> } }</code><technical_language>access this method staticly</technical_language>

Target:
public void testSystemPropertiesOverrideConfigurationValues() { final String keyName = CoreConfig.MAX_CASSANDRA_CONNECTIONS.toString(); Configuration config = Configuration.getInstance(); try { Assert.assertEquals("75", config.getStringProperty(CoreConfig.MAX_CASSANDRA_CONNECTIONS)); System.setProperty(keyName, "something else"); Assert.assertEquals("something else", config.getStringProperty(CoreConfig.MAX_CASSANDRA_CONNECTIONS)); } finally { System.clearProperty(keyName); config.clearProperty(keyName); } }
Source:
<code><START> public String[] getIndexNames() { <END> return indexNames; }</code><technical_language>follow immutable approach create a new instance of IndexCoordinates IndexCoordinates a fully immutable object</technical_language>

Target:
public String[] getIndexNames() { return Arrays.copyOf(indexNames, indexNames.length); }
Source:
<code>public Response getKafkaSourceSchema(@PathParam("topicName") String topicName) throws JsonProcessingException { try { LOG.info("Received path: [{}]", topicName); <START> SchemaVersionInfo schemaVersionInfo = schemaRegistryClient.getLatestSchemaVersionInfo(topicName); <END> String schema = schemaVersionInfo != null ? schemaVersionInfo.getSchemaText() : null; LOG.debug("######### Received schema from schema registry: ", schema); if (schema != null && !schema.isEmpty()) { schema = avroStreamsSchemaConverter.convertAvro(schema); } LOG.debug("######### Converted schema: ", schema); return WSUtils.respondEntity(schema, OK); } catch (SchemaNotFoundException e) { LOG.error("Schema not found for name: [{}]", topicName, e); throw EntityNotFoundException.byId(topicName); } catch (JsonProcessingException ex) { LOG.error("Error occurred while retrieving schema with name [{}]", topicName, ex); throw ex; } }</code><technical_language>change this. SchemaResource unrelated MLRegistry. require topicName + ":v" for schema registry work</technical_language>

Target:
public Response getKafkaSourceSchema(@PathParam("topicName") String topicName) throws JsonProcessingException { try { LOG.info("Received path: [{}]", topicName); String schemaName = topicName + ":v"; SchemaVersionInfo schemaVersionInfo = schemaRegistryClient.getLatestSchemaVersionInfo(schemaName); String schema = schemaVersionInfo != null ? schemaVersionInfo.getSchemaText() : null; LOG.debug("######### Received schema from schema registry: ", schema); if (schema != null && !schema.isEmpty()) { schema = avroStreamsSchemaConverter.convertAvro(schema); } LOG.debug("######### Converted schema: ", schema); return WSUtils.respondEntity(schema, OK); } catch (SchemaNotFoundException e) { LOG.error("Schema not found for name: [{}]", topicName, e); throw EntityNotFoundException.byId(topicName); } catch (JsonProcessingException ex) { LOG.error("Error occurred while retrieving schema with name [{}]", topicName, ex); throw ex; } }
Source:
<code>private String getFullLogMessage(MessageContext synCtx) { StringBuffer sb = new StringBuffer(); sb.append(getSimpleLogMessage(synCtx)); try { org.apache.axis2.context.MessageContext a2mc = ((Axis2MessageContext) synCtx).getAxis2MessageContext(); <START> if (JsonUtil.hasAJsonPayload(a2mc) && synCtx.getEnvelope() == null) { <END> sb.append(separator).append("Payload: ").append(JsonUtil.jsonPayloadToString(a2mc)); } else if (synCtx.getEnvelope() != null) { sb.append(separator).append("Envelope: ").append(synCtx.getEnvelope()); } } catch (Exception e) { SOAPEnvelope envelope = synCtx.isSOAP11() ? OMAbstractFactory.getSOAP11Factory().getDefaultEnvelope() :OMAbstractFactory.getSOAP12Factory().getDefaultEnvelope(); try { synCtx.setEnvelope(envelope); } catch (Exception e1) { log.error("Could not replace faulty SOAP Envelop. Error: " + e1.getLocalizedMessage()); return sb.toString(); } handleException("Could not build full log message: " + e.getLocalizedMessage(), e, synCtx); } return trimLeadingSeparator(sb); }</code><technical_language>explain reason for null check here</technical_language>

Target:
private String getFullLogMessage(MessageContext synCtx) { StringBuffer sb = new StringBuffer(); sb.append(getSimpleLogMessage(synCtx)); try { org.apache.axis2.context.MessageContext a2mc = ((Axis2MessageContext) synCtx).getAxis2MessageContext(); if (synCtx.getEnvelope() != null) { sb.append(separator).append("Envelope: ").append(synCtx.getEnvelope()); } else if (JsonUtil.hasAJsonPayload(a2mc)) { sb.append(separator).append("Payload: ").append(JsonUtil.jsonPayloadToString(a2mc)); } } catch (Exception e) { SOAPEnvelope envelope = synCtx.isSOAP11() ? OMAbstractFactory.getSOAP11Factory().getDefaultEnvelope() :OMAbstractFactory.getSOAP12Factory().getDefaultEnvelope(); try { synCtx.setEnvelope(envelope); } catch (Exception e1) { log.error("Could not replace faulty SOAP Envelop. Error: " + e1.getLocalizedMessage()); return sb.toString(); } handleException("Could not build full log message: " + e.getLocalizedMessage(), e, synCtx); } return trimLeadingSeparator(sb); }
Source:
<code>KafkaSinkConfiguration(@JsonProperty(defaultValue=DEFAULT_TOPIC) final String topic, @JsonProperty final KafkaSinkMode mode) { this.topic = Optional.ofNullable(topic).orElse(DEFAULT_TOPIC); <START> this.mode = Optional.ofNullable(mode).orElse(KafkaSinkMode.NAKED); <END> }</code><technical_language>extract KafkaSinkMode.NAKED a constant named DEFAULT_SINK_MODE explicit setting a default here</technical_language>

Target:
KafkaSinkConfiguration(@JsonProperty(defaultValue=DEFAULT_TOPIC) final String topic, @JsonProperty final KafkaSinkMode mode) { this.topic = Optional.ofNullable(topic).orElse(DEFAULT_TOPIC); this.mode = Optional.ofNullable(mode).orElse(DEFAULT_SINK_MODE); }
Source:
<code>private double estimateOutlierProbability(final AlleleFractionData data) { final UnivariateObjectiveFunction objective = new UnivariateObjectiveFunction(outlierProbability -> AlleleFractionModeller.logLikelihood(state.shallowCopyWithProposedOutlierProbability(outlierProbability), data)); <START> final SearchInterval searchInterval = new SearchInterval(0.0, 0.1, state.outlierProbability()); <END> return new BrentOptimizer(0.01, 0.001).optimize(objective, GoalType.MAXIMIZE, searchInterval, new MaxEval(1000)).getPoint(); }</code><technical_language>extract max of search interval (same necessary---probably needed for MAF)</technical_language>

Target:
private double estimateOutlierProbability(final AlleleFractionData data) { final UnivariateObjectiveFunction objective = new UnivariateObjectiveFunction(outlierProbability -> AlleleFractionModeller.logLikelihood(state.shallowCopyWithProposedOutlierProbability(outlierProbability), data)); final SearchInterval searchInterval = new SearchInterval(0.0, MAX_REASONABLE_OUTLIER_PROBABILITY, state.outlierProbability()); return OPTIMIZER.optimize(objective, GoalType.MAXIMIZE, searchInterval, BRENT_MAX_EVAL).getPoint(); }
Source:
<code>private void installConnectionsToolbar() { toolbar_.removeAllWidgets(); <START> newConnectionButton_ = <END> toolbar_.addLeftWidget(commands_.newConnection().createToolbarButton()); toolbar_.addLeftSeparator(); toolbar_.addRightWidget(searchWidget_); setSecondaryToolbarVisible(false); }</code><technical_language>Addition of this member variable unnecessary, un-done I think</technical_language>

Target:
private void installConnectionsToolbar() { toolbar_.removeAllWidgets(); toolbar_.addLeftWidget(commands_.newConnection().createToolbarButton()); toolbar_.addLeftSeparator(); toolbar_.addRightWidget(searchWidget_); setSecondaryToolbarVisible(false); }
Source:
<code>public void testGetFileCounts() { Response response = utilizationService.getFileCounts(); Map<Long, Long> resultMap = (LinkedHashMap<Long, Long>) response.getEntity(); int totalBins = 16; assertEquals(totalBins, resultMap.size()); assertEquals(1L, (long) resultMap.get(1024L)); assertEquals(1L, (long) resultMap.get(10240L)); assertEquals(2L, (long) resultMap.get(10240000L)); <START> assertEquals(0L, (long) resultMap.get(1024000L)); <END> }</code><technical_language>add more assertions for boundary values</technical_language>

Target:
public void testGetFileCounts() { List<FileCountBySize> resultList = setUpResultList(); utilizationService = mock(UtilizationService.class); when(utilizationService.getFileCounts()).thenCallRealMethod(); when(utilizationService.getDao()).thenReturn(fileCountBySizeDao); when(fileCountBySizeDao.findAll()).thenReturn(resultList); Response response = utilizationService.getFileCounts(); List<FileCountBySize> responseList = (List<FileCountBySize>) response.getEntity(); verify(fileCountBySizeDao, times(1)).findAll(); assertEquals(maxBinSize, responseList.size()); assertEquals(resultList, responseList); }
Source:
<code>public void reportIssueWithFlow(JavaCheck javaCheck, Tree syntaxNode, String message, Iterable<List<Location>> flows, @Nullable Integer cost) { <START> if(sonarComponents == null) { <END> return; } Iterable<List<Location>> reportedFlows; if (sonarComponents.isSQGreaterThan64()) { reportedFlows = flows; } else { reportedFlows = javaCheck instanceof SECheck ? Iterables.limit(flows, 1) : flows; } sonarComponents.reportIssue(createAnalyzerMessage(file, javaCheck, syntaxNode, null, message, reportedFlows, cost)); }</code><technical_language>need condition? able cover test case? null-test present I test related that</technical_language>

Target:
public void reportIssueWithFlow(JavaCheck javaCheck, Tree syntaxNode, String message, Iterable<List<Location>> flows, @Nullable Integer cost) { Iterable<List<Location>> reportedFlows; if (sonarComponents.isSQGreaterThan64()) { reportedFlows = flows; } else { reportedFlows = javaCheck instanceof SECheck ? Iterables.limit(flows, 1) : flows; } sonarComponents.reportIssue(createAnalyzerMessage(file, javaCheck, syntaxNode, null, message, reportedFlows, cost)); }
Source:
<code>public Optional<TimeZoneHistory> updateTimeZone(long accountId, final String clientTimeZoneId, int clientTimeZoneOffsetMillis){ final long updatedAt = DateTime.now().getMillis(); DateTimeZone clientTimeZone = DateTimeZone.UTC; try{ clientTimeZone = DateTimeZone.forID(clientTimeZoneId); }catch (IllegalArgumentException ex){ <START> LOGGER.warn("Unrecognized Timezone ID {}, proceeding to derive from offset millis", clientTimeZoneId); <END> clientTimeZone = DateTimeZone.forOffsetMillis(clientTimeZoneOffsetMillis); } String timeZoneId = clientTimeZone.getID(); final Map<String, AttributeValue> item = new HashMap<String, AttributeValue>(); item.put(ACCOUNT_ID_ATTRIBUTE_NAME, new AttributeValue().withN(String.valueOf(accountId))); item.put(UPDATED_AT_ATTRIBUTE_NAME, new AttributeValue().withN(String.valueOf(updatedAt))); item.put(TIMEZONE_NAME_ATTRIBUTE_NAME, new AttributeValue().withS(timeZoneId)); final PutItemRequest putItemRequest = new PutItemRequest(this.tableName, item); final PutItemResult putItemResult = dynamoDBClient.putItem(putItemRequest); if(putItemResult != null){ LOGGER.debug("Update time zone for account: {}, offset: {}, id: {}", accountId, clientTimeZone.getOffset(DateTime.now().getMillis()), timeZoneId); return Optional.of(new TimeZoneHistory(updatedAt, clientTimeZone.getOffset(DateTime.now().getMillis()), timeZoneId)); } LOGGER.warn("Account update timezone failed, AWS error.", accountId); return Optional.absent(); }</code><technical_language>log account_id</technical_language>

Target:
public Optional<TimeZoneHistory> updateTimeZone(long accountId, final String clientTimeZoneId, int clientTimeZoneOffsetMillis){ final long updatedAt = DateTime.now().getMillis(); DateTimeZone clientTimeZone = DateTimeZone.UTC; try{ clientTimeZone = DateTimeZone.forID(clientTimeZoneId); }catch (IllegalArgumentException ex){ LOGGER.warn("Unrecognized Timezone ID from account {}, proceeding to derive from offset millis", clientTimeZoneId, accountId); clientTimeZone = DateTimeZone.forOffsetMillis(clientTimeZoneOffsetMillis); } String timeZoneId = clientTimeZone.getID(); final Map<String, AttributeValue> item = new HashMap<String, AttributeValue>(); item.put(ACCOUNT_ID_ATTRIBUTE_NAME, new AttributeValue().withN(String.valueOf(accountId))); item.put(UPDATED_AT_ATTRIBUTE_NAME, new AttributeValue().withN(String.valueOf(updatedAt))); item.put(TIMEZONE_NAME_ATTRIBUTE_NAME, new AttributeValue().withS(timeZoneId)); final PutItemRequest putItemRequest = new PutItemRequest(this.tableName, item); final PutItemResult putItemResult = dynamoDBClient.putItem(putItemRequest); if(putItemResult != null){ LOGGER.debug("Update time zone for account: {}, offset: {}, id: {}", accountId, clientTimeZone.getOffset(DateTime.now().getMillis()), timeZoneId); return Optional.of(new TimeZoneHistory(updatedAt, clientTimeZone.getOffset(DateTime.now().getMillis()), timeZoneId)); } LOGGER.warn("Account update timezone failed, AWS error.", accountId); return Optional.absent(); }
Source:
<code>@Override protected Void run(String name) throws IgniteException { new SnapshotMXBeanImpl(ignite.context()).createSnapshot(name); <START> return null; <END> }</code><technical_language>I suggest success command execution prints informative message. For example, snapshot was(will be) created. monitor status</technical_language>

Target:
@Override protected String run(String name) throws IgniteException { new SnapshotMXBeanImpl(ignite.context()).createSnapshot(name); return "Snapshot operation started: " + name; }
Source:
<code>public void openLevel(String mainUlCSSClasses) { <START> openLevel(new TreeSet<String>(Arrays.asList(StringUtils.split(mainUlCSSClasses, ' ')))); <END> }</code><technical_language>LinkedHashSet here? TreeSet sorts mainUlCSSClasses lexicographically change behaviour of openLevel</technical_language>

Target:
public void openLevel(String mainUlCSSClasses) { openLevel(new LinkedHashSet<String>(Arrays.asList(StringUtils.split(mainUlCSSClasses, ' ')))); }
Source:
<code>public boolean canPushMerges() { if <START> (projectControl.controlForRef(getRefName()).canPerform( <END> Permission.PUSH_MERGE) && canWrite()) { return true; } else if (projectControl.controlForRef( MagicBranch.NEW_CHANGE + getRefName()) .canPerform(Permission.PUSH_MERGE) && canWrite()) { return true; } return false; }</code><technical_language>is this expression "this"</technical_language>

Target:
public boolean canPushMerges() { if (this.canPerform(Permission.PUSH_MERGE) && canWrite()) { return true; } else if (projectControl.controlForRef(MagicBranch.NEW_CHANGE + getRefName()) .canPerform(Permission.PUSH_MERGE) && canWrite()) { return true; } return false; }
Source:
<code>public JsonNode toJson() { <START> return toJson("requests","request"); <END> }</code><technical_language>iterate entries call toJson methods</technical_language>

Target:
public JsonNode toJson() { throw new UnsupportedOperationException(); }
Source:
<code>protected void <START> refreshFile(IFile <END> file) throws CoreException { if (file == null) { return; } class RefreshFileOperation extends DocumentProviderOperation implements ISchedulingRuleProvider { @Override protected void execute(IProgressMonitor m) throws CoreException { refreshFile(file, m); } @Override public ISchedulingRule getSchedulingRule() { return fResourceRuleFactory.refreshRule(file); } } executeOperation(new RefreshFileOperation(), getProgressMonitor()); }</code><technical_language>Providing a implementation #refreshFile(IFile, IProgressMonitor) is a go</technical_language>

Target:
protected void refreshFile(IFile file) throws CoreException { refreshFile(file, getProgressMonitor()); }
Source:
<code>public static IntervalList invert(final IntervalList list) { final IntervalList inverse = new IntervalList(list.header.clone()); final ListMap<Integer, Interval> map = new ListMap<>(); for (final Interval i : list.uniqued().getIntervals()) { final int sequenceIndex = list.getHeader().getSequenceIndex(i.getContig()); <START> ValidationUtils.nonNull(sequenceIndex, <END> () -> String.format("Cannot add interval %s, contig not in header", i.toString())); map.add(sequenceIndex, i); } int intervals = 0; for (final SAMSequenceRecord samSequenceRecord : list.getHeader().getSequenceDictionary().getSequences()) { final Integer sequenceIndex = samSequenceRecord.getSequenceIndex(); final String sequenceName = samSequenceRecord.getSequenceName(); final int sequenceLength = samSequenceRecord.getSequenceLength(); int lastCoveredPosition = 0; if (map.containsKey(sequenceIndex)) { for (final Interval i : map.get(sequenceIndex)) { if (i.getStart() > lastCoveredPosition + 1) { inverse.add(new Interval(sequenceName, lastCoveredPosition + 1, i.getStart() - 1, false, "interval-" + (++intervals))); } lastCoveredPosition = i.getEnd(); } } if (sequenceLength > lastCoveredPosition) { inverse.add(new Interval(sequenceName, lastCoveredPosition + 1, sequenceLength, false, "interval-" + (++intervals))); } } return inverse; }</code><technical_language>I meant this change (sequenceIndex is a primitive, a reference type, validateArg is more in this case)</technical_language>

Target:
public static IntervalList invert(final IntervalList list) { final IntervalList inverse = new IntervalList(list.header.clone()); final ListMap<Integer, Interval> map = new ListMap<>(); for (final Interval i : list.uniqued().getIntervals()) { final int sequenceIndex = list.getHeader().getSequenceIndex(i.getContig()); ValidationUtils.validateArg(sequenceIndex != SAMSequenceRecord.UNAVAILABLE_SEQUENCE_INDEX, () -> String.format("Cannot add interval %s, contig not in header", i.toString())); map.add(sequenceIndex, i); } int intervals = 0; for (final SAMSequenceRecord samSequenceRecord : list.getHeader().getSequenceDictionary().getSequences()) { final Integer sequenceIndex = samSequenceRecord.getSequenceIndex(); final String sequenceName = samSequenceRecord.getSequenceName(); final int sequenceLength = samSequenceRecord.getSequenceLength(); int lastCoveredPosition = 0; if (map.containsKey(sequenceIndex)) { for (final Interval i : map.get(sequenceIndex)) { if (i.getStart() > lastCoveredPosition + 1) { inverse.add(new Interval(sequenceName, lastCoveredPosition + 1, i.getStart() - 1, false, "interval-" + (++intervals))); } lastCoveredPosition = i.getEnd(); } } if (sequenceLength > lastCoveredPosition) { inverse.add(new Interval(sequenceName, lastCoveredPosition + 1, sequenceLength, false, "interval-" + (++intervals))); } } return inverse; }
Source:
<code>public String apply(long value) { <START> return this.apply(Long.valueOf(value)); <END> }</code><technical_language>I if a reason auto-box</technical_language>

Target:
public String apply(long value) { return this.apply((Long)value); }
Source:
<code>public void testInit() throws Exception { ApplicationServiceBean serviceBean = new ApplicationServiceBean( <START> testAppService, <END> testConfigAdminExt, mBeanServer, mockFeaturesService, mockSystemService); serviceBean.init(); verify(mBeanServer).registerMBean(serviceBean, objectName); }</code><technical_language>Instead of repeating lines everywhere, create a private factory method creates ApplicationServiceBean right arguments</technical_language>

Target:
public void testInit() throws Exception { ApplicationServiceBean serviceBean = newApplicationServiceBean(); serviceBean.init(); verify(mBeanServer).registerMBean(serviceBean, objectName); }
Source:
<code>public void testPullNonExistingImage() throws Exception { try { dockerRule.getClient().pullImageCmd("xvxcv/foo") .exec(new PullImageResultCallback()) .awaitCompletion(30, TimeUnit.SECONDS); fail("An exception is expected."); <START> } catch (NotFoundException | DockerClientException e) { <END> } }</code><technical_language>a wrong junit exception usage. test suppress exceptions, need configure exception (that is Rule)</technical_language>

Target:
public void testPullNonExistingImage() throws Exception { if (isNotSwarm(dockerRule.getClient()) && getVersion(dockerRule.getClient()) .isGreaterOrEqual(RemoteApiVersion.VERSION_1_26)) { exception.expect(NotFoundException.class); } else { exception.expect(DockerClientException.class); } dockerRule.getClient().pullImageCmd("xvxcv/foo") .exec(new PullImageResultCallback()) .awaitCompletion(30, TimeUnit.SECONDS); }
Source:
<code>private static Engine.SpiAndProvider tryTransformWithProvider(InitParams initParams, String[] transformParts, NeedToSet type, Provider.Service service) throws InvalidKeyException, InvalidAlgorithmParameterException { try { if (!matchAttribute(service, ATTRIBUTE_MODES, transformParts[1]) || !matchAttribute(service, ATTRIBUTE_PADDINGS, transformParts[2])) { return null; } Engine.SpiAndProvider sap = ENGINE.getInstance(service, null); if (sap.spi == null || sap.provider == null) { return null; } <START> if (!(sap.spi instanceof CipherSpi)) { <END> return null; } CipherSpi spi = (CipherSpi) sap.spi; if (((type == NeedToSet.MODE) || (type == NeedToSet.BOTH)) && (transformParts[1] != null)) { spi.engineSetMode(transformParts[1]); } if (((type == NeedToSet.PADDING) || (type == NeedToSet.BOTH)) && (transformParts[2] != null)) { spi.engineSetPadding(transformParts[2]); } if (initParams != null) { switch (initParams.initType) { case ALGORITHM_PARAMS: spi.engineInit(initParams.opmode, initParams.key, initParams.params, initParams.random); break; case ALGORITHM_PARAM_SPEC: spi.engineInit(initParams.opmode, initParams.key, initParams.spec, initParams.random); break; case KEY: spi.engineInit(initParams.opmode, initParams.key, initParams.random); break; default: throw new AssertionError("This should never be reached"); } } return sap; } catch (NoSuchAlgorithmException ignored) { } catch (NoSuchPaddingException ignored) { } return null; }</code><technical_language>confirmed RI throws a ClassCastException instead</technical_language>

Target:
private static Engine.SpiAndProvider tryTransformWithProvider(InitParams initParams, String[] transformParts, NeedToSet type, Provider.Service service) throws InvalidKeyException, InvalidAlgorithmParameterException { try { if (!matchAttribute(service, ATTRIBUTE_MODES, transformParts[1]) || !matchAttribute(service, ATTRIBUTE_PADDINGS, transformParts[2])) { return null; } Engine.SpiAndProvider sap = ENGINE.getInstance(service, null); if (sap.spi == null || sap.provider == null) { return null; } CipherSpi spi = (CipherSpi) sap.spi; if (((type == NeedToSet.MODE) || (type == NeedToSet.BOTH)) && (transformParts[1] != null)) { spi.engineSetMode(transformParts[1]); } if (((type == NeedToSet.PADDING) || (type == NeedToSet.BOTH)) && (transformParts[2] != null)) { spi.engineSetPadding(transformParts[2]); } if (initParams != null) { switch (initParams.initType) { case ALGORITHM_PARAMS: spi.engineInit(initParams.opmode, initParams.key, initParams.params, initParams.random); break; case ALGORITHM_PARAM_SPEC: spi.engineInit(initParams.opmode, initParams.key, initParams.spec, initParams.random); break; case KEY: spi.engineInit(initParams.opmode, initParams.key, initParams.random); break; default: throw new AssertionError("This should never be reached"); } } return sap; } catch (NoSuchAlgorithmException ignored) { } catch (NoSuchPaddingException ignored) { } return null; }
Source:
<code>public MacPool getMacPoolForDataCenter(Guid dataCenterId, CommandContext commandContext) { <START> final MacPool macPool; <END> try { macPool = getMacPoolById(getMacPoolId(dataCenterId), commandContext); } catch (Exception e) { throw new IllegalStateException( String.format("An exception was thrown while retrieving the mac-pool for DC='%s'", dataCenterId), e); } return macPool; }</code><technical_language>modern java programming require single return point. contrary - this produce ugly overgrown code for nothing. This creates spaghetti flow: reach 'return' if exception thrown. Do 'return' in try if anything</technical_language>

Target:
public MacPool getMacPoolForDataCenter(Guid dataCenterId, CommandContext commandContext) { try { return getMacPoolById(getMacPoolId(dataCenterId), commandContext); } catch (RuntimeException e) { throw new IllegalStateException( String.format("An exception was thrown while retrieving the mac-pool for DC='%s'", dataCenterId), e); } }
Source:
<code>private PostUploadHookChain(List<PostUploadHook> hooks) { this.hooks = new <START> ArrayList<>(hooks); <END> }</code><technical_language>For consistency, Collections.unmodifiableList</technical_language>

Target:
private PostUploadHookChain(List<PostUploadHook> hooks) { this.hooks = Collections.unmodifiableList(hooks); }
Source:
<code>public void init(LogFeederProps logFeederProperties) throws Exception { super.init(logFeederProperties); <START> port = (int) ObjectUtils.defaultIfNull(((InputSocketDescriptor)getInputDescriptor()).getPort(), 0); <END> if (port == 0) { throw new IllegalArgumentException(String.format("Port needs to be set for socket input (type: %s)", getInputDescriptor().getType())); } protocol = (String) ObjectUtils.defaultIfNull(((InputSocketDescriptor)getInputDescriptor()).getProtocol(), "tcp"); secure = (boolean) ObjectUtils.defaultIfNull(((InputSocketDescriptor)getInputDescriptor()).isSecure(), false); log4j = (boolean) ObjectUtils.defaultIfNull(((InputSocketDescriptor)getInputDescriptor()).isLog4j(), false); }</code><technical_language>Is get rid of type casts? For example a generic parameter TInputDescriptor</technical_language>

Target:
public void init(LogFeederProps logFeederProperties) throws Exception { super.init(logFeederProperties); port = (int) ObjectUtils.defaultIfNull(getInputDescriptor().getPort(), 0); if (port == 0) { throw new IllegalArgumentException(String.format("Port needs to be set for socket input (type: %s)", getInputDescriptor().getType())); } protocol = (String) ObjectUtils.defaultIfNull(getInputDescriptor().getProtocol(), "tcp"); secure = (boolean) ObjectUtils.defaultIfNull(getInputDescriptor().isSecure(), false); log4j = (boolean) ObjectUtils.defaultIfNull(getInputDescriptor().isLog4j(), false); }
Source:
<code>public void ensureBucketExists() { <START> List<Bucket> buckets = amazonS3.listBuckets(); <END> Optional<Bucket> existingBucket = buckets.stream().filter(b -> b.getName().equals(bucket)).findFirst(); if (!existingBucket.isPresent()) { if (StringUtils.isNullOrEmpty(region)) { log.info("Creating bucket " + bucket + " in default region"); amazonS3.createBucket(bucket); } else { log.info("Creating bucket " + bucket + " in region " + region + "..."); amazonS3.createBucket(bucket, region); } } }</code><technical_language>[headBucket](<LINK_0> is a fit iterating existing buckets</technical_language>

Target:
public void ensureBucketExists() { HeadBucketRequest request = new HeadBucketRequest(bucket); try { amazonS3.headBucket(request); } catch (AmazonServiceException e) { if (e.getStatusCode() == 404) { if (StringUtils.isNullOrEmpty(region)) { log.info("Creating bucket " + bucket + " in default region"); amazonS3.createBucket(bucket); } else { log.info("Creating bucket " + bucket + " in region " + region + "..."); amazonS3.createBucket(bucket, region); } } else { throw e; } } }
Source:
<code>public void addFilter(ITmfFilterTreeNode filter) { ITmfFilterTreeNode root = fViewer.getInput(); for (int i = 0; i < root.getChildrenCount(); i++) { <START> if (root.getChild(0).equals(filter)) { <END> return; } } root.addChild(filter); fViewer.setInput(root); }</code><technical_language>getChild(i)</technical_language>

Target:
public void addFilter(ITmfFilterTreeNode filter) { ITmfFilterTreeNode root = fViewer.getInput(); for (int i = 0; i < root.getChildrenCount(); i++) { if (root.getChild(i).equals(filter)) { return; } } root.addChild(filter); fViewer.setInput(root); }
Source:
<code>public static Integer getIntegerParamValue(String paramName, Configuration configuration) throws NumberFormatException { String paramValue = configuration.get(paramName); if (StringUtils.isNotBlank(paramValue) && !UNDEFINED_NONEMPTY_VALUE.equals(paramValue)) { <START> return Integer.parseInt(paramValue); <END> } else { return null; } }</code><technical_language>Integer.valueOf</technical_language>

Target:
public static Integer getIntegerParamValue(String paramName, Configuration configuration) throws NumberFormatException { String paramValue = getParamValue(paramName, configuration); return paramValue!=null?Integer.valueOf(paramValue):null; }
Source:
<code>public void createServiceNoUser() throws Exception { CommonTestUtilities.cleanStatePrivate2(SUPPORT, false); final ApiClient webClient = getWebClient("admin@admin.com"); WorkflowsApi client = new WorkflowsApi(webClient); String serviceRepo = "DockstoreTestUser2/test-service"; String installationId = "1179416"; io.swagger.client.model.Workflow service = null; try { service = client.addService(serviceRepo, "iamnotarealuser", installationId); } catch (ApiException ex) { <START> <END> } assertNull("Should not be able to add service since the username does not exist on Dockstore.", service); }</code><technical_language>a big deal, this nervous, this fail in a pass test. I prefer check database instead</technical_language>

Target:
public void createServiceNoUser() throws Exception { final CommonTestUtilities.TestingPostgres testingPostgres = getTestingPostgres(); CommonTestUtilities.cleanStatePrivate2(SUPPORT, false); final ApiClient webClient = getWebClient("admin@admin.com"); WorkflowsApi client = new WorkflowsApi(webClient); String serviceRepo = "DockstoreTestUser2/test-service"; String installationId = "1179416"; try { client.addService(serviceRepo, "iamnotarealuser", installationId); } catch (ApiException ex) { } final long count = testingPostgres .runSelectStatement("select count(*) from service where sourcecontrol = 'github.com' and organization = 'DockstoreTestUser2' and repository = 'test-service'", new ScalarHandler<>()); Assert.assertEquals("there should be no matching service", 0, count); }
Source:
<code>public void deleteLabel(String user, String labelId) throws APIManagementException { if (isAttachedLabel(user, labelId)) { <START> APIUtil.handleException("Unable to delete label. Label is already attached to a API"); <END> } apiMgtDAO.deleteLabel(labelId); }</code><technical_language>suggestion APIUtil.handleException("Unable delete label. is attached API");</technical_language>

Target:
public void deleteLabel(String user, String labelId) throws APIManagementException { if (isAttachedLabel(user, labelId)) { APIUtil.handleException("Unable to delete the label. It is attached to an API"); } apiMgtDAO.deleteLabel(labelId); }
Source:
<code>public void shutdownShouldStopAllSolvers() { <START> int[] problemIds = new int[Runtime.getRuntime().availableProcessors() * 3]; <END> for (int i = 0; i < problemIds.length; i++) { problemIds[i] = i; } Arrays.stream(problemIds) .forEach(problemId -> { TestdataSolution problem = createTestProblem((long) problemId); solverManager.solve(problemId, problem, null, null); }); solverManager.shutdown(); Arrays.stream(problemIds) .forEach(problemId -> assertEquals(SolverStatus.TERMINATED_EARLY, solverManager.getSolverStatus(problemId))); }</code><technical_language>Tip: IntStream get rid of array for loop: java int problemCount = Runtime.getRuntime().availableProcessors() * 3; IntStream.range(0, problemCount) .forEach(problemId -> {</technical_language>

Target:
public void shutdownShouldStopAllSolvers() throws InterruptedException { int problemCount = Runtime.getRuntime().availableProcessors() * 3; IntStream.range(0, problemCount) .forEach(problemId -> { TestdataSolution problem = createTestProblem((long) problemId); solverManager.solve(problemId, problem, null, null); }); solverManager.shutdown(); IntStream.range(0, problemCount) .forEach(problemId -> { assertFalse(solverManager.isProblemSubmitted(problemId)); }); }
Source:
<code>private void add(byte[] bytes) { int[] hashes = createHashes(bytes); for (int hash : hashes) <START> bitset.set(Math.abs(hash % bitSetSize), true); <END> numberOfAddedElements ++; }</code><technical_language>Please apply apex style. braces missing</technical_language>

Target:
private void add(byte[] bytes) { int[] hashes = createHashes(bytes); for (int hash : hashes) { bitset.set(Math.abs(hash % bitSetSize), true); } numberOfAddedElements++; }
Source:
<code>public void receiveRequest(final Exchange exchange, final Request request) { if (request.isDuplicate()) { Response currentResponse = exchange.getCurrentResponse(); if (currentResponse != null) { LOGGER.debug("respond with the current response to the duplicate request"); <START> if (currentResponse.isConfirmable()) { <END> exchange.setFailedTransmissionCount(1); EmptyMessage ack = EmptyMessage.newACK(request); sendEmptyMessage(exchange, ack); } lower().sendResponse(exchange, currentResponse); } else if (exchange.getCurrentRequest().isAcknowledged()) { LOGGER.debug("duplicate request was acknowledged but no response computed yet. Retransmit ACK"); EmptyMessage ack = EmptyMessage.newACK(request); sendEmptyMessage(exchange, ack); } else if (exchange.getCurrentRequest().isRejected()) { LOGGER.debug("duplicate request was rejected. Reject again"); EmptyMessage rst = EmptyMessage.newRST(request); sendEmptyMessage(exchange, rst); } else { LOGGER.debug("server has not yet decided what to do with the request. We ignore the duplicate."); } } else { exchange.setCurrentRequest(request); upper().receiveRequest(exchange, request); } }</code><technical_language>I send ACK for separated responses (non for CON)</technical_language>

Target:
public void receiveRequest(final Exchange exchange, final Request request) { if (request.isDuplicate()) { Response currentResponse = exchange.getCurrentResponse(); if (currentResponse != null) { if (currentResponse.getType() == Type.NON || currentResponse.getType() == Type.CON) { if (request.isConfirmable()) { EmptyMessage ack = EmptyMessage.newACK(request); sendEmptyMessage(exchange, ack); } if (currentResponse.isConfirmable()) { int failedCount; synchronized (exchange) { failedCount = exchange.getFailedTransmissionCount() + 1; exchange.setFailedTransmissionCount(failedCount); } LOGGER.debug("Request Duplicate: retransmit response, failed: {}, response: {}", new Object[] { failedCount, currentResponse }); currentResponse.retransmitting(); sendResponse(exchange, currentResponse); return; } } LOGGER.debug("respond with the current response to the duplicate request"); lower().sendResponse(exchange, currentResponse); } else if (exchange.getCurrentRequest().isAcknowledged()) { LOGGER.debug("duplicate request was acknowledged but no response computed yet. Retransmit ACK"); EmptyMessage ack = EmptyMessage.newACK(request); sendEmptyMessage(exchange, ack); } else if (exchange.getCurrentRequest().isRejected()) { LOGGER.debug("duplicate request was rejected. Reject again"); EmptyMessage rst = EmptyMessage.newRST(request); sendEmptyMessage(exchange, rst); } else { LOGGER.debug("server has not yet decided what to do with the request. We ignore the duplicate."); } } else { exchange.setCurrentRequest(request); upper().receiveRequest(exchange, request); } }
Source:
<code>public List<LogEntry> getLogEntries() { <START> return logEntries; <END> }</code><technical_language>return Collections.immutableList(logEntries)</technical_language>

Target:
public List<LogEntry> getLogEntries() { return Collections.unmodifiableList(logEntries); }
Source:
<code>public CompletableFuture<?> updateIndex(Object key, Object value, int segment) { if (value == null || Thread.currentThread().isInterrupted()) { return CompletableFuture.completedFuture(null); } if (!getGlobalScope().getIncludedIndexedTypes().contains(value.getClass())) { return CompletableFuture.completedFuture(null); } PojoIndexer indexer = searchMappingHolder.getSearchMapping().getMappingSession().createIndexer(); final String idInString = keyTransformationHandler.keyToString(key, segment); <START> return indexer.add(PojoRawTypeIdentifier.of(value.getClass()), idInString, value); <END> }</code><technical_language>Also, this work for protobuf entities, PojoRawTypeIdentifier.of(value.getClass())</technical_language>

Target:
public CompletableFuture<?> updateIndex(Object key, Object value, int segment) { if (value == null || Thread.currentThread().isInterrupted()) { return CompletableFuture.completedFuture(null); } final String idInString = keyTransformationHandler.keyToString(key, segment); return searchMappingHolder.getSearchMapping().getSearchIndexer().addOrUpdate(idInString, value); }
Source:
<code>public RpslObject getAbuseContactRole(final RpslObject rpslObject) { <START> if(!ripeSources.contains(rpslObject.getValueForAttribute(AttributeType.SOURCE))) { <END> return null; } switch (rpslObject.getType()) { case INETNUM: case INET6NUM: final RpslObject role = getAbuseContactRoleInternal(rpslObject); if (role == null) { final RpslObject parentObject = getParentObject(rpslObject); if (parentObject != null && !isMaintainedByRs(rpslObject)) { return getAbuseContactRole(parentObject); } } return role; case AUT_NUM: return getAbuseContactRoleInternal(rpslObject); default: return null; } }</code><technical_language>Good pattern (return early)</technical_language>

Target:
public RpslObject getAbuseContactRole(final RpslObject rpslObject) { if(!mainSources.contains(rpslObject.getValueForAttribute(AttributeType.SOURCE))) { return null; } switch (rpslObject.getType()) { case INETNUM: case INET6NUM: final RpslObject role = getAbuseContactRoleInternal(rpslObject); if (role == null) { final RpslObject parentObject = getParentObject(rpslObject); if (parentObject != null && !isMaintainedByRs(rpslObject)) { return getAbuseContactRole(parentObject); } } return role; case AUT_NUM: return getAbuseContactRoleInternal(rpslObject); default: return null; } }
Source:
<code>protected void runChild(final FrameworkMethod method, RunNotifier notifier) { <START> Description description = describeChild(method); <END> if (isIgnored(method)) { notifier.fireTestIgnored(description); } else { Object test = null; try { test = new ReflectiveCallable() { @Override protected Object runReflectiveCall() throws Throwable { return createTest(); } }.run(); } catch (Throwable e) { e.printStackTrace(); } boolean skipped = false; if (test != null) { List<TestRule> testRules = getTestRules(test); for (TestRule testRule : testRules) { Class<? extends TestRule> klass = testRule.getClass(); klass.getCanonicalName(); if ("org.eclipse.mylyn.commons.sdk.util.ConditionalIgnoreRule" .equals(klass.getCanonicalName())) { Statement statement = testRule.apply(null, description); if (statement != null) { skipped = true; break; } } } } if (skipped) { notifier.fireTestIgnored(description); } else { runTest(methodBlock(method), description, notifier); } } }</code><technical_language>this moved else block</technical_language>

Target:
protected void runChild(final FrameworkMethod method, RunNotifier notifier) { Description description = describeChild(method); if (isIgnored(method)) { notifier.fireTestIgnored(description); } else { Object test = null; try { test = new ReflectiveCallable() { @Override protected Object runReflectiveCall() throws Throwable { return createTest(); } }.run(); } catch (Throwable e) { StatusHandler.log(new Status(IStatus.ERROR, "org.eclipse.mylyn.commons.sdk.util", NLS.bind("TestClassRunnerForFixture: Testclass {0} has no public constructor", getTestClass().getName()), e)); return; } boolean skipped = false; if (test != null) { List<TestRule> testRules = getTestRules(test); for (TestRule testRule : testRules) { Class<? extends TestRule> klass = testRule.getClass(); klass.getCanonicalName(); if (klass == ConditionalIgnoreRule.class) { Statement statement = testRule.apply(null, description); if (statement != null) { skipped = true; break; } } } if (skipped) { notifier.fireTestIgnored(description); } else { runTest(methodBlock(method), description, notifier); } } } }