auphong2707/dl4se-code-review-dataset huggingface dataset:
Source:
<code>public void monitor(SharedInformerFactory sharedInformerFactory) { SharedIndexInformer<V1NetworkAttachmentDefinition> networksInformer = sharedInformerFactory.sharedIndexInformerFor( (CallGeneratorParams params) -> { return cniApi.listV1NetworkAttachmentDefinitionForAllNamespacesCall( null, null, null, null, null, null, params.resourceVersion, params.timeoutSeconds, params.watch, null, null); }, V1NetworkAttachmentDefinition.class, V1NetworkAttachmentDefinitionList.class); networksInformer.addEventHandler( new ResourceEventHandler<>() { @Override public void onAdd(V1NetworkAttachmentDefinition network) { if <START> (networkUpdater.addNetwork(network, clusterId)) <END> { log.info("network added!", network.getMetadata().getName()); } } @Override public void onUpdate(V1NetworkAttachmentDefinition oldNet, V1NetworkAttachmentDefinition newNet) { log.debug("{} => network updated!", oldNet.getMetadata().getName(), newNet.getMetadata().getName()); } @Override public void onDelete(V1NetworkAttachmentDefinition network, boolean deletedFinalStateUnknown) { if (networkUpdater.removeNetwork(network.getMetadata().getName(), clusterId)) { log.info("network removed!", network.getMetadata().getName()); } } }); }</code><technical_language>naming convention namespace-name</technical_language>

Target:
public void monitor(SharedInformerFactory sharedInformerFactory) { SharedIndexInformer<V1NetworkAttachmentDefinition> networksInformer = sharedInformerFactory.sharedIndexInformerFor( (CallGeneratorParams params) -> { return cniApi.listV1NetworkAttachmentDefinitionForAllNamespacesCall( null, null, null, null, null, null, params.resourceVersion, params.timeoutSeconds, params.watch, null, null); }, V1NetworkAttachmentDefinition.class, V1NetworkAttachmentDefinitionList.class); networksInformer.addEventHandler( new ResourceEventHandler<>() { @Override public void onAdd(V1NetworkAttachmentDefinition network) { if (networkUpdater.addNetwork(network, clusterId)) { log.info("network added!", network.getMetadata().getName()); } } @Override public void onUpdate(V1NetworkAttachmentDefinition oldNet, V1NetworkAttachmentDefinition newNet) { log.debug("{} => network updated!", oldNet.getMetadata().getName(), newNet.getMetadata().getName()); } @Override public void onDelete(V1NetworkAttachmentDefinition network, boolean deletedFinalStateUnknown) { if (networkUpdater.removeNetwork(NetworkUpdater.getNetworkName(network), clusterId)) { log.info("network removed!", network.getMetadata().getName()); } } }); }
Source:
<code>public void close() throws IOException { <START> level1.close(); <END> level2.close(); }</code><technical_language>organise this in a double empty try-with-resources idiom: java try (Closeable ignore = level1; Closeable ignore2 = level2) { // for closing } delegate boilerplate exception suppression handling Java construct. If appears unnatural, extract this in a utility method, e. g. called void closeBoth(Closeable, Closeable) throws IOException</technical_language>

Target:
public void close() throws IOException { try (Closeable closeable1 = level1; Closeable closeable2 = level2) { } }
Source:
<code>public DOM(DOMProvider.Factory providerFactory) { mDOMProviderFactory = Util.throwIfNull(providerFactory); mPeerManager = new ChromePeerManager(); mPeerManager.setListener(new PeerManagerListener()); mObjectMapper = new ObjectMapper(); mObjectIdMapper = new DOMObjectIdMapper(); mSearchResults = Collections.synchronizedMap( <START> new HashMap<String, List<Integer>>()); <END> }</code><technical_language>Pretty write new HashMap<>();</technical_language>

Target:
public DOM(DOMProvider.Factory providerFactory) { mDOMProviderFactory = Util.throwIfNull(providerFactory); mPeerManager = new ChromePeerManager(); mPeerManager.setListener(new PeerManagerListener()); mObjectMapper = new ObjectMapper(); mObjectIdMapper = new DOMObjectIdMapper(); mSearchResults = Collections.synchronizedMap( new HashMap<String, List<Integer>>()); mResultCounter = new AtomicInteger(0); }
Source:
<code>protected void setContents(String contents) { this.contents = Arrays.asList(contents.split("\n")); ListIterator<String> li = this.contents.listIterator(getContentLineCount()); while (li.hasPrevious()) { int index = li.previousIndex(); <START> if ("".equals(li.previous().trim())) { <END> this.contents.remove(index); } else { break; } } }</code><technical_language>if (li.previous().trim().length() == 0) {</technical_language>

Target:
protected void setContents(String contents) { this.contents = Arrays.asList(contents.split("\n")); ListIterator<String> li = this.contents.listIterator(getContentLineCount()); while (li.hasPrevious()) { int index = li.previousIndex(); if (li.previous().trim().length() == 0) { this.contents.remove(index); } else { break; } } }
Source:
<code>protected void parseTransparencyAttestation(final PendingCertifiedProductEntity pendingCertifiedProduct, final CSVRecord record) { pendingCertifiedProduct.setTransparencyAttestationUrl(record.get(getColumnIndexMap().getK1Index()).trim()); if (getColumnIndexMap().getK2Index() >= 0) { String k2AttestationStr = record.get(getColumnIndexMap().getK2Index()).trim(); if (!StringUtils.isEmpty(k2AttestationStr)) { <START> if ("0".equals(k2AttestationStr.trim())) { <END> pendingCertifiedProduct.setTransparencyAttestation(AttestationType.Negative); } else if ("1".equals(k2AttestationStr.trim())) { pendingCertifiedProduct.setTransparencyAttestation(AttestationType.Affirmative); } else if ("2".equals(k2AttestationStr.trim())) { pendingCertifiedProduct.setTransparencyAttestation(AttestationType.NA); } } else { pendingCertifiedProduct.setTransparencyAttestation(null); } } }</code><technical_language>trim-ing k2AttestationStr assigned; need in check</technical_language>

Target:
protected void parseTransparencyAttestation(final PendingCertifiedProductEntity pendingCertifiedProduct, final CSVRecord record) { pendingCertifiedProduct.setTransparencyAttestationUrl(record.get(getColumnIndexMap().getK1Index()).trim()); if (getColumnIndexMap().getK2Index() >= 0) { String k2AttestationStr = record.get(getColumnIndexMap().getK2Index()).trim(); if (!StringUtils.isEmpty(k2AttestationStr)) { if ("0".equals(k2AttestationStr)) { pendingCertifiedProduct.setTransparencyAttestation(AttestationType.Negative); } else if ("1".equals(k2AttestationStr)) { pendingCertifiedProduct.setTransparencyAttestation(AttestationType.Affirmative); } else if ("2".equals(k2AttestationStr)) { pendingCertifiedProduct.setTransparencyAttestation(AttestationType.NA); } } else { pendingCertifiedProduct.setTransparencyAttestation(null); } } }
Source:
<code>public String getAnonymousSubmissionId() { String anonTitle = rb.getString("grading.anonymous.title") ; String id = ""; try { Site site = SiteService.getSite( this.getAssignment().getContext() ); if(candidateDetailProvider.useInstitutionalAnonymousId(site)) { id = candidateDetailProvider.getCandidateID(UserDirectoryService.getUser(this.getSubmitterId()), site).orElse(this.getId().substring(27)); } else { id = this.getId().substring(27); } <START> } catch(Exception ignore){ignore.printStackTrace();} <END> return id + " (" + anonTitle + ")"; }</code><technical_language>Exception.printStacktrace(), logger instead</technical_language>

Target:
public String getAnonymousSubmissionId() { String id = this.getId().substring(27); try { Site site = SiteService.getSite( this.getAssignment().getContext() ); if(candidateDetailProvider.useInstitutionalAnonymousId(site)) { id = candidateDetailProvider.getCandidateID(UserDirectoryService.getUser(this.getSubmitterId()), site).orElse(this.getId().substring(27)); } } catch(IdUnusedException e){ M_log.warn("Site not found " + this.getAssignment().getContext(), e); } catch(UserNotDefinedException e){ M_log.warn("User not found " + this.getSubmitterId(), e); } return id + " (" + rb.getString("grading.anonymous.title") + ")"; }
Source:
<code>protected void RunStage() { switch (_currentInstallStage) { case Start: case SignCertificateRequest: case UploadSignedCertificate: case UploadCA: case DownloadCertificateRequest: { log.infoFormat("Installation of {0}. Executing oVirt installation stage. (Stage: {1})", _serverName, getCurrentInstallStage()); super.RunStage(); break; } case ConnectToServer: { log.infoFormat("Installation of {0}. Executing oVirt installation stage. (Stage: {1})", _serverName, getCurrentInstallStage()); _executionSucceded = _wrapper.connect(_serverName); break; } case RunScript: { log.infoFormat("Installation of {0}. Executing oVirt installation stage. (Stage: {1})", _serverName, getCurrentInstallStage()); <START> _wrapper.execute(createCertReqCommand); <END> break; } case FinishCommand: { log.infoFormat( "Installation of {0}. Executing oVirt installation stage, sending SSH Command {1}. (Stage: {2})", _serverName, finishCommandInitial, getCurrentInstallStage()); _wrapper.execute(finishCommandInitial); break; } default: { _executionSucceded = true; _currentInstallStage = VdsInstallStages.forValue(_currentInstallStage.getValue() + 1); break; } } }</code><technical_language>In opinion "executeCommand" is a bit "execute"</technical_language>

Target:
protected void RunStage() { switch (_currentInstallStage) { case Start: case SignCertificateRequest: case UploadSignedCertificate: case UploadCA: case DownloadCertificateRequest: { log.infoFormat("Installation of {0}. Executing oVirt installation stage. (Stage: {1})", _serverName, getCurrentInstallStage()); super.RunStage(); break; } case ConnectToServer: { log.infoFormat("Installation of {0}. Executing oVirt installation stage. (Stage: {1})", _serverName, getCurrentInstallStage()); _executionSucceded = _wrapper.connect(_serverName); break; } case RunScript: { log.infoFormat("Installation of {0}. Executing oVirt installation stage. (Stage: {1})", _serverName, getCurrentInstallStage()); _wrapper.executeCommand(createCertReqCommand); break; } case FinishCommand: { log.infoFormat( "Installation of {0}. Executing oVirt installation stage, sending SSH Command {1}. (Stage: {2})", _serverName, finishCommandInitial, getCurrentInstallStage()); _wrapper.executeCommand(finishCommandInitial); break; } default: { _executionSucceded = true; _currentInstallStage = VdsInstallStages.forValue(_currentInstallStage.getValue() + 1); break; } } }
Source:
<code>List<GermplasmListData> getGermplasmListDataListWithExistingReservations(final List<GermplasmListData> germplasmListDataList) { final List<GermplasmListData> germplasmListDataListWithReservations = new ArrayList<>(); for (final GermplasmListData germplasmListData : germplasmListDataList) { if (germplasmListData.getInventoryInfo() != null && germplasmListData.getInventoryInfo().getLotRows() != null) { for (final LotDetails lotDetails : germplasmListData.getInventoryInfo().getLotRows()) { <START> if (lotDetails.getWithdrawalBalance() > 0 && <END> lotDetails.getWithdrawalStatus().equalsIgnoreCase(GermplasmInventory.RESERVED)) { germplasmListDataListWithReservations.add(germplasmListData); } } } } return germplasmListDataListWithReservations; }</code><technical_language>Withdrawal means Reserved + Committed. give reserved amount. condition put solve purpose check if lot is in reserved status. I working similar kind of ticket BMS-3545. I noticed commits</technical_language>

Target:
List<GermplasmListData> getGermplasmListDataListWithExistingReservations(final List<GermplasmListData> germplasmListDataList) { final List<GermplasmListData> germplasmListDataListWithReservations = new ArrayList<>(); for (final GermplasmListData germplasmListData : germplasmListDataList) { if (germplasmListData.getInventoryInfo() != null && germplasmListData.getInventoryInfo().getLotRows() != null) { for (final LotDetails lotDetails : germplasmListData.getInventoryInfo().getLotRows()) { if (lotDetails.getWithdrawalStatus().equalsIgnoreCase(GermplasmInventory.RESERVED)) { germplasmListDataListWithReservations.add(germplasmListData); } } } } return germplasmListDataListWithReservations; }
Source:
<code>public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState){ layout = (LinearLayout) inflater.inflate(R.layout.recording_fragment, container); disableScreenRotation(); prepareButtons(); prepareText(); setWindowSize(); <START> fileName = Environment.getExternalStorageDirectory().getAbsolutePath() + FILE_EXT; <END> File f = new File(fileName); if(f.exists()){ recordAgain.setVisibility(View.VISIBLE); saveRecording.setVisibility(View.VISIBLE); recordingDuration.setVisibility(View.VISIBLE); toggleRecording.setBackgroundResource(R.drawable.play); toggleRecording.setOnClickListener(new View.OnClickListener() { @Override public void onClick(View v) { playAudio(); } }); saveRecording.setEnabled(true); instruction.setText(Localization.get("after.recording")); } return layout; }</code><technical_language>If audioprototype widgets, this record one</technical_language>

Target:
public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState){ layout = (LinearLayout) inflater.inflate(R.layout.recording_fragment, container); disableScreenRotation((Activity) getContext()); prepareButtons(); prepareText(); setWindowSize(); fileName = Environment.getExternalStorageDirectory().getAbsolutePath() + FILE_EXT + listener.getFileExtension(); File f = new File(fileName); if(f.exists()){ reloadSavedRecording(); } return layout; }
Source:
<code>private ResolvableType obtainResolvableType(Message<?> message) { try { return this.valueTypeExpression.getValue(this.evaluationContext, message, ResolvableType.class); } catch (Exception ex) { if (ex.getCause() instanceof ClassNotFoundException) { <START> logger.info("Cannot build a ResolvableType from a request message '" + message + <END> "' evaluating expression '" + this.valueTypeExpression.getExpressionString() + "'", ex); return null; } else { throw ex; } } }</code><technical_language>request message</technical_language>

Target:
private ResolvableType obtainResolvableType(Message<?> message) { try { return this.valueTypeExpression.getValue(this.evaluationContext, message, ResolvableType.class); } catch (Exception ex) { if (ex.getCause() instanceof ClassNotFoundException) { logger.info("Cannot build a ResolvableType from the request message '" + message + "' evaluating expression '" + this.valueTypeExpression.getExpressionString() + "'", ex); return null; } else { throw ex; } } }
Source:
<code>private boolean isNewerVersion(Version isoClusterVersion) { VDS vds = getVdsByVdsId(getParameters().getVdsId()); Version vdsClusterVersion = vds.getVdsGroupCompatibilityVersion(); log.debugFormat( "vdsClusterVersion {0} isoClusterVersion {1}", vdsClusterVersion.toString(), <START> isoClusterVersion.toString() <END> ); return (vdsClusterVersion.getMajor() == isoClusterVersion.getMajor() && vdsClusterVersion.getMinor() <= isoClusterVersion.getMinor()); }</code><technical_language>I (or want believe) .toString() is implicit formatting, removed here</technical_language>

Target:
private boolean isNewerVersion(Version isoClusterVersion) { VDS vds = getVdsByVdsId(getParameters().getVdsId()); Version vdsClusterVersion = vds.getVdsGroupCompatibilityVersion(); log.debugFormat( "vdsClusterVersion {0} isoClusterVersion {1}", vdsClusterVersion, isoClusterVersion ); return (vdsClusterVersion.getMajor() == isoClusterVersion.getMajor() && vdsClusterVersion.getMinor() <= isoClusterVersion.getMinor()); }
Source:
<code>@Override public boolean capabilityExist( String id ) { for ( ICapabilityProvider iCapabilityProvider : providers.values() ) { boolean isTrue = iCapabilityProvider.capabilityExist( id ); <START> if ( isTrue ) { <END> return true; } } return false; }</code><technical_language>small nitpicky thing. collapse this 1 line</technical_language>

Target:
@Override public boolean capabilityExist( String id ) { for ( ICapabilityProvider iCapabilityProvider : providers.values() ) { if ( iCapabilityProvider.capabilityExist( id ) ) { return true; } } return false; }
Source:
<code>public void reload() { logger.debug("Requesting configuration from: " + configUrl); httpClient.send("GET", configUrl, new HashMap<String, String>(), null, new HttpClient.ResponseHandler<Void>() { @Override public Void handleResponse(HttpRequest<?> httpRequest, InputStream is, Integer statusCode, IOException e) throws IOException { if (e != null || statusCode != 200 || is == null) { logger.warn("Couldn't GET configuration. " + configUrl + " returned " + statusCode); return null; } logger.debug("Reloading RemotePropertiesConfigurationSource with: " + properties); <START> properties.clear(); <END> properties.load(is); return null; } }); }</code><technical_language>create a small time window properties</technical_language>

Target:
public void reload() { logger.debug("Requesting configuration from: " + configUrl.toExternalForm()); httpClient.send("GET", configUrl.toExternalForm(), new HashMap<String, String>(), null, new HttpClient.ResponseHandler<Void>() { @Override public Void handleResponse(HttpRequest<?> httpRequest, InputStream is, Integer statusCode, IOException e) throws IOException { if (e != null || statusCode != 200 || is == null) { logger.warn("Couldn't GET configuration. " + configUrl.toExternalForm() + " returned " + statusCode); return null; } logger.debug("Reloading RemotePropertiesConfigurationSource with: " + properties); final Properties newProperties = new Properties(); newProperties.load(is); RemotePropertiesConfigurationSource.this.properties = newProperties; return null; } }); }
Source:
<code>private void ensureAccessToken() { String href = getStringProperty(HREF_PROP_NAME); if (href != null) { <START> Assert.isTrue(href.contains("/accessTokens/"), "href does not belong to an access token."); <END> } }</code><technical_language>/accessTokens/ a constant defined in this class? a show stopper - a thought</technical_language>

Target:
private void ensureAccessToken() { String href = getStringProperty(HREF_PROP_NAME); if (href != null) { Assert.isTrue(href.contains(ACCESS_TOKEN_PATH), "href does not belong to an access token."); } }
Source:
<code>void onDevtoolsLoadAll() { <START> source_.withSaveFilesBeforeCommand(new Command() { <END> @Override public void execute() { withDevtoolsLoadAllPath(new CommandWithArg<String>() { @Override public void execute(String loadAllPath) { sendLoadCommandToConsole( "devtools::load_all(\"" + loadAllPath + "\")"); } }); } }, new Command() { public void execute() { } }, "Build"); }</code><technical_language>While touching this... lambda-fied. Braces newlines fit: source_.withSaveFilesBeforeCommand(() -> { withDevtoolsLoadAllPath(loadAllPath -> { sendLoadCommandToConsole("devtools::load_all(\"" + loadAllPath + "\")"); }); }, () -> {}, "Build");</technical_language>

Target:
void onDevtoolsLoadAll() { source_.withSaveFilesBeforeCommand(() -> { withDevtoolsLoadAllPath(loadAllPath -> { sendLoadCommandToConsole("devtools::load_all(\"" + loadAllPath + "\")"); }); }, () -> {}, "Build"); }
Source:
<code>public void setAndGetAttachmentsTest() { String attachmentName = "attachment_1.txt"; BasicDocumentRevision rev_1 = datastore.createDocument(bodyOne); File f = new File("fixture", attachmentName); <START> UnsavedFileAttachment att = new UnsavedFileAttachment(f, "text/plain"); <END> List<UnsavedFileAttachment> atts = new ArrayList<UnsavedFileAttachment>(); atts.add(att); DocumentRevision newRevision = null; try { newRevision = datastore.updateAttachments(rev_1, atts); } catch (ConflictException ce){ Assert.fail("ConflictException thrown: "+ce); } catch (IOException ioe) { Assert.fail("IOException thrown: "+ioe); } try { byte[] expectedSha1 = Misc.getSha1(new FileInputStream(f)); SavedAttachment savedAtt = (SavedAttachment) datastore.getAttachment(newRevision, attachmentName); Assert.assertArrayEquals(expectedSha1, savedAtt.key); SavedAttachment savedAtt2 = (SavedAttachment) datastore.attachmentsForRevision(newRevision).get(0); Assert.assertArrayEquals(expectedSha1, savedAtt2.key); } catch (FileNotFoundException fnfe) { Assert.fail("FileNotFoundException thrown "+fnfe); } }</code><technical_language>Class methods create exposing subclass types? check returned types in tests</technical_language>

Target:
public void setAndGetAttachmentsTest() { String attachmentName = "attachment_1.txt"; BasicDocumentRevision rev_1 = datastore.createDocument(bodyOne); File f = new File("fixture", attachmentName); Attachment att = new UnsavedFileAttachment(f, "text/plain"); List<Attachment> atts = new ArrayList<Attachment>(); atts.add(att); DocumentRevision newRevision = null; try { newRevision = datastore.updateAttachments(rev_1, atts); } catch (ConflictException ce){ Assert.fail("ConflictException thrown: "+ce); } try { byte[] expectedSha1 = Misc.getSha1(new FileInputStream(f)); SavedAttachment savedAtt = (SavedAttachment) datastore.getAttachment(newRevision, attachmentName); Assert.assertArrayEquals(expectedSha1, savedAtt.key); SavedAttachment savedAtt2 = (SavedAttachment) datastore.attachmentsForRevision(newRevision).get(0); Assert.assertArrayEquals(expectedSha1, savedAtt2.key); } catch (FileNotFoundException fnfe) { Assert.fail("FileNotFoundException thrown "+fnfe); } }
Source:
<code>public Date getLastModified() { Date max = new Date(0); for (ChangeLog c : changeLog) { if (c.getTime().after(max)) { max = c.getTime(); } } <START> return max; <END> }</code><technical_language>of main ways this attribute is is sortBy column list pools page, ORDER column selecting pools. this implementation of getLastModified faster XDerivedInfo method for returning query (aka changing this for Samples, Libraries Runs well)</technical_language>

Target:
public Date getLastModified() { return (derivedInfo == null ? null : derivedInfo.getLastModified()); }
Source:
<code>private IscsiDetails mapLogicalUnitToIscsiDetails(LogicalUnit logicalUnit) { IscsiDetails iscsiDetails = new IscsiDetails(); iscsiDetails.setAddress(logicalUnit.getAddress()); iscsiDetails.setPort(logicalUnit.getPort()); <START> iscsiDetails.setTarget(logicalUnit.getTarget()); <END> return iscsiDetails; }</code><technical_language>Can/should set portal, serial, productId vendorId attributes</technical_language>

Target:
private IscsiDetails mapLogicalUnitToIscsiDetails(LogicalUnit logicalUnit) { IscsiDetails iscsiDetails = new IscsiDetails(); iscsiDetails.setAddress(logicalUnit.getAddress()); iscsiDetails.setPort(logicalUnit.getPort()); iscsiDetails.setTarget(logicalUnit.getTarget()); iscsiDetails.setPortal(logicalUnit.getPortal()); iscsiDetails.setPaths(logicalUnit.getPaths()); iscsiDetails.setVendorId(logicalUnit.getVendorId()); iscsiDetails.setProductId(logicalUnit.getProductId()); iscsiDetails.setSerial(logicalUnit.getSerial()); return iscsiDetails; }
Source:
<code>private static void log(String message) { <START> System.out.println(message); <END> }</code><technical_language>a logger here, print a file? In case issues updating need diagnose</technical_language>

Target:
public static void log(String message) { System.out.println(message); }
Source:
<code>public void subscribeActual(Subscriber<? super T> t) { BaseEmitter<T> emitter; switch (backpressure) { case NONE: { emitter = new NoneEmitter<T>(t); break; } case ERROR: { emitter = new ErrorAsyncEmitter<T>(t); break; } case DROP: { emitter = new DropAsyncEmitter<T>(t); break; } case LATEST: { emitter = new LatestAsyncEmitter<T>(t); break; } <START> case BUFFER: { <END> emitter = new BufferAsyncEmitter<T>(t, bufferSize()); break; } default: { throw new UnsupportedOperationException(); } } t.onSubscribe(emitter); try { source.subscribe(emitter); } catch (Throwable ex) { Exceptions.throwIfFatal(ex); emitter.onError(ex); } }</code><technical_language>changing this</technical_language>

Target:
public void subscribeActual(Subscriber<? super T> t) { BaseEmitter<T> emitter; switch (backpressure) { case NONE: { emitter = new NoneEmitter<T>(t); break; } case ERROR: { emitter = new ErrorAsyncEmitter<T>(t); break; } case DROP: { emitter = new DropAsyncEmitter<T>(t); break; } case LATEST: { emitter = new LatestAsyncEmitter<T>(t); break; } default: { emitter = new BufferAsyncEmitter<T>(t, bufferSize()); break; } } t.onSubscribe(emitter); try { source.subscribe(emitter); } catch (Throwable ex) { Exceptions.throwIfFatal(ex); emitter.onError(ex); } }
Source:
<code><START> void configureServers(boolean dataStoreWithWriter, boolean accessorWithWriter) { dataStore1.invoke(() -> initDataStore(true, dataStoreWithWriter)); dataStore2.invoke(() -> initDataStore(true, dataStoreWithWriter)); dataStore3.invoke(() -> initDataStore(true, dataStoreWithWriter)); accessor.invoke(() -> initAccessor(true, accessorWithWriter)); dataStore1.invoke(() -> { Region region = getRegion(false); region.getAttributesMutator().setCacheWriter(null); }); dataStore2.invoke(() -> { Region region = getRegion(false); region.getAttributesMutator().setCacheWriter(null); }); <END> }</code><technical_language>inefficient confusing set cache writer for data stores, immediately remove writers for datastores1 2. instead pass false argument for initDataStore() for datastores</technical_language>

Target:
void configureServers(boolean dataStoreWithWriter, boolean accessorWithWriter) { dataStore1.invoke(() -> initDataStore(dataStoreWithWriter)); dataStore2.invoke(() -> initDataStore(dataStoreWithWriter)); dataStore3.invoke(() -> initDataStore(dataStoreWithWriter)); accessor.invoke(() -> initAccessor(accessorWithWriter)); dataStore1.invoke(() -> { Region region = getRegion(false); region.getAttributesMutator().setCacheWriter(null); }); dataStore2.invoke(() -> { Region region = getRegion(false); region.getAttributesMutator().setCacheWriter(null); }); }
Source:
<code>public void onCreate(Bundle savedInstanceState) { super.onCreate(savedInstanceState); setContentView(R.layout.people_management_activity); Toolbar toolbar = (Toolbar) findViewById(R.id.toolbar); setSupportActionBar(toolbar); ActionBar actionBar = getSupportActionBar(); if (actionBar != null) { actionBar.setTitle(R.string.people); actionBar.setHomeButtonEnabled(true); actionBar.setDisplayHomeAsUpEnabled(true); } int localBlogId = BlogUtils.getBlogLocalId(WordPress.getCurrentBlog()); <START> Blog blog = WordPress.getBlog(localBlogId); <END> if (savedInstanceState == null) { PeopleListFragment peopleListFragment = PeopleListFragment.newInstance(localBlogId); getFragmentManager().beginTransaction() .add(R.id.fragment_container, peopleListFragment, KEY_PEOPLE_LIST_FRAGMENT) .commit(); } if (blog != null) { refreshUsersList(blog.getDotComBlogId(), localBlogId); } }</code><technical_language>This odd ID of current blog in order lookup current blog. code this line deal current blog null - activity exit in situation. this instead? Blog blog = WordPress.getCurrentBlog(); if (blog == null) { ToastUtils.showToast(this, R.string.blog_not_found); finish(); return; } if (savedInstanceState == null) { PeopleListFragment peopleListFragment = PeopleListFragment.newInstance(blog.getLocalTableBlogId()); getFragmentManager().beginTransaction() .add(R.id.fragment_container, peopleListFragment, KEY_PEOPLE_LIST_FRAGMENT) .commit(); } refreshUsersList(blog.getDotComBlogId(), blog.getLocalTableBlogId());</technical_language>

Target:
public void onCreate(Bundle savedInstanceState) { super.onCreate(savedInstanceState); setContentView(R.layout.people_management_activity); Toolbar toolbar = (Toolbar) findViewById(R.id.toolbar); setSupportActionBar(toolbar); ActionBar actionBar = getSupportActionBar(); if (actionBar != null) { actionBar.setTitle(R.string.people); actionBar.setHomeButtonEnabled(true); actionBar.setDisplayHomeAsUpEnabled(true); } Blog blog = WordPress.getCurrentBlog(); if (blog == null) { ToastUtils.showToast(this, R.string.blog_not_found); finish(); return; } if (savedInstanceState == null) { if (NetworkUtils.isNetworkAvailable(this)) { PeopleTable.deletePeopleForLocalBlogIdExceptForFirstPage(blog.getLocalTableBlogId()); } PeopleListFragment peopleListFragment = PeopleListFragment.newInstance(blog.getLocalTableBlogId()); peopleListFragment.setOnPersonSelectedListener(this); peopleListFragment.setOnFetchPeopleListener(this); mPeopleEndOfListReached = false; mFetchRequestInProgress = false; getFragmentManager().beginTransaction() .add(R.id.fragment_container, peopleListFragment, KEY_PEOPLE_LIST_FRAGMENT) .commit(); } else { mPeopleEndOfListReached = savedInstanceState.getBoolean(KEY_END_OF_LIST_REACHED); mFetchRequestInProgress = savedInstanceState.getBoolean(KEY_FETCH_REQUEST_IN_PROGRESS); FragmentManager fragmentManager = getFragmentManager(); PeopleListFragment peopleListFragment = (PeopleListFragment) fragmentManager .findFragmentByTag(KEY_PEOPLE_LIST_FRAGMENT); if (peopleListFragment != null) { peopleListFragment.setOnPersonSelectedListener(this); peopleListFragment.setOnFetchPeopleListener(this); } } }
Source:
<code>public FingerprintHandler(Context context, FingerprintManager fingerprintManager, Callback callback) { <START> appContext = context; <END> mFingerprintManager = fingerprintManager; mCallback = callback; }</code><technical_language>names consistent, if mCallback mAppContext</technical_language>

Target:
public FingerprintHandler(Context context, FingerprintManager fingerprintManager, Callback callback) { mAppContext = context; mFingerprintManager = fingerprintManager; mCallback = callback; }
Source:
<code>public void init() { <START> _sut = new BasicScopeAuthorizationStrategy(TEST_SCOPE); <END> _sut.setMetadataClient(metadataClient); }</code><technical_language>reason _ prefix</technical_language>

Target:
public void init() { sut = new BasicScopeAuthorizationStrategy(TEST_SCOPE); sut.setMetadataService(metadataService); }
Source:
<code>public boolean onHandleIntent(Intent intent, GoogleCloudMessaging gcm) { <START> return false; <END> }</code><technical_language>removing interface class a option? If deprecate customers update notice deprecated warning, push stops working for apparent reason</technical_language>

Target:
public boolean onHandleIntent(Intent intent, GoogleCloudMessaging gcm) { return onMessageReceived("", intent.getExtras()); }
Source:
<code>public static void testUndoApproveSavingsAccount() throws MambuApiException { System.out.println("\nIn test Undo Approve Savings Account"); SavingsService service = MambuAPIFactory.getSavingsService(); <START> String accountId = "JLXD301"; END> SavingsAccount account = service .undoApproveSavingsAccount(accountId, "UNDO Approve Savings account demo notes"); System.out.println("UNDO Approved Savings account with id=" + account.getId() + "\tName=" + account.getName() + "\tAccount State=" + account.getAccountState().toString()); }</code><technical_language>this more portable, create approve a savings account API undo approval created account</technical_language>

Target:
public static void testUndoApproveSavingsAccount() throws MambuApiException { System.out.println("\nIn test Undo Approve Savings Account"); SavingsService service = MambuAPIFactory.getSavingsService(); String accountId = SAVINGS_ACCOUNT_ID; SavingsAccount account = service .undoApproveSavingsAccount(accountId, "UNDO Approve Savings account demo notes"); System.out.println("UNDO Approved Savings account with id=" + account.getId() + "\tName=" + account.getName() + "\tAccount State=" + account.getAccountState().toString()); }
Source:
<code>public Revision(ObjectId sha1, Collection<Branch> branches) { <START> if (sha1 == null) throw new NullPointerException("sha1 can't be null"); <END> this.sha1 = sha1; this.branches = branches; }</code><technical_language>throw IllegalArgumentException</technical_language>

Target:
public Revision(ObjectId sha1, Collection<Branch> branches) { this.sha1 = sha1; this.branches = branches; }
Source:
<code>private void broadcast(String noteId, Message m) { synchronized (noteSocketMap) { List<NotebookSocket> socketLists = noteSocketMap.get(noteId); if (socketLists == null || socketLists.size() == 0) { return; } LOG.debug("SEND >> " + m.op); <START> broadcastToWatchers(noteId, StringUtils.EMPTY, m); <END> for (NotebookSocket conn : socketLists) { try { conn.send(serializeMessage(m)); } catch (IOException e) { LOG.error("socket error", e); } } } }</code><technical_language>move this if statement message is broadcasted if client connection opened note</technical_language>

Target:
private void broadcast(String noteId, Message m) { synchronized (noteSocketMap) { broadcastToWatchers(noteId, StringUtils.EMPTY, m); List<NotebookSocket> socketLists = noteSocketMap.get(noteId); if (socketLists == null || socketLists.size() == 0) { return; } LOG.debug("SEND >> " + m.op); for (NotebookSocket conn : socketLists) { try { conn.send(serializeMessage(m)); } catch (IOException e) { LOG.error("socket error", e); } } } }
Source:
<code>public CdoSnapshot fromJson(JsonElement json, JsonDeserializationContext context) { JsonObject jsonObject = (JsonObject) json; CommitId commitId = parseCommitId(jsonObject); GlobalCdoId cdoId = context.deserialize(jsonObject.get(GLOBAL_CDO_ID), GlobalCdoId.class); CdoSnapshotBuilder cdoSnapshotBuilder = cdoSnapshot(cdoId); cdoSnapshotBuilder.withCommitId(commitId); JsonObject state = jsonObject.get(STATE).getAsJsonObject(); <START> for (Property property : propertyScanner.scan(cdoId.getCdoClass().getSourceClass())) { <END> cdoSnapshotBuilder.withPropertyValue(property, decodeValue(state, context, property)); } return cdoSnapshotBuilder.build(); }</code><technical_language>for (Property property : cdoId.getCdoClass().getProperties()) {</technical_language>

Target:
public CdoSnapshot fromJson(JsonElement json, JsonDeserializationContext context) { JsonObject jsonObject = (JsonObject) json; CommitId commitId = parseCommitId(jsonObject); GlobalCdoId cdoId = context.deserialize(jsonObject.get(GLOBAL_CDO_ID), GlobalCdoId.class); CdoSnapshotBuilder cdoSnapshotBuilder = cdoSnapshot(cdoId); cdoSnapshotBuilder.withCommitId(commitId); JsonObject state = jsonObject.get(STATE).getAsJsonObject(); for (Property property : cdoId.getCdoClass().getProperties()) { cdoSnapshotBuilder.withPropertyValue(property, decodeValue(state, context, property)); } return cdoSnapshotBuilder.build(); }
Source:
<code>public static boolean handleCommands(DedicatedServer server) { final Terminal terminal = TerminalConsoleAppender.getTerminal(); if (terminal == null) return false; LineReader reader = LineReaderBuilder.builder() .appName("Forge") .terminal(terminal) .completer(new ConsoleCommandCompleter(server)) .build(); <START> reader.unsetOpt(LineReader.Option.INSERT_TAB); <END> TerminalConsoleAppender.setReader(reader); try { String line; while (!server.isServerStopped() && server.isServerRunning()) { try { line = reader.readLine("> "); } catch (EndOfFileException ignored) { continue; } if (line == null) break; line = line.trim(); if (!line.isEmpty()) { server.addPendingCommand(line, server); } } } catch (UserInterruptException e) { server.initiateShutdown(); } finally { TerminalConsoleAppender.setReader(null); } return true; }</code><technical_language>Need call reader.setOpt(LineReader.Option.DISABLE_EVENT_EXPANSION); additionally avoid <LINK_0> for Forge. (This is equivalent reader.setExpandEvents(false) in JLine 2.x code)</technical_language>

Target:
public static boolean handleCommands(DedicatedServer server) { final Terminal terminal = TerminalConsoleAppender.getTerminal(); if (terminal == null) return false; LineReader reader = LineReaderBuilder.builder() .appName("Forge") .terminal(terminal) .completer(new ConsoleCommandCompleter(server)) .build(); reader.setOpt(LineReader.Option.DISABLE_EVENT_EXPANSION); reader.unsetOpt(LineReader.Option.INSERT_TAB); TerminalConsoleAppender.setReader(reader); try { String line; while (!server.isServerStopped() && server.isServerRunning()) { try { line = reader.readLine("> "); } catch (EndOfFileException ignored) { continue; } if (line == null) break; line = line.trim(); if (!line.isEmpty()) { server.addPendingCommand(line, server); } } } catch (UserInterruptException e) { server.initiateShutdown(); } finally { TerminalConsoleAppender.setReader(null); } return true; }
Source:
<code>private void parseJaxbLayer(LayerType lt, ILayer parentLayer) throws LayerException { if(!lt.getLayer().isEmpty() || (lt.getDataURL()==null )) { parseJaxbLayerCollection(lt, parentLayer); } else { URLType dataUrl = lt.getDataURL(); if (dataUrl != null) { OnlineResourceType resType = dataUrl.getOnlineResource(); try { URI layerURI = new URI(resType.getHref()); if(!layerURI.isAbsolute() && getLocation()!=null) { try { layerURI = getLocation().resolve(layerURI); } catch (IllegalArgumentException ex) { <START> LOGGER.warn("Error while trying to find an absolute path for an external resource", ex); <END> } } ILayer leafLayer; try { leafLayer = createLayer(registerLayerResource(layerURI)); } catch (Exception ex) { throw new LayerException(I18N.tr("Unable to load the data source uri {0}.", resType.getHref()), ex); } leafLayer.setDescription(new Description(lt)); leafLayer.setVisible(!lt.isHidden()); if(lt.isSetStyleList()) { for(StyleType st : lt.getStyleList().getStyle()) { if(st.isSetSLD()) { if(st.getSLD().isSetAbstractStyle()) { leafLayer.addStyle(new Style((JAXBElement<net.opengis.se._2_0.core.StyleType>)st.getSLD().getAbstractStyle(), leafLayer)); } } } } parentLayer.addLayer(leafLayer); } catch (URISyntaxException ex) { throw new LayerException(I18N.tr("Unable to parse the href URI {0}.", resType.getHref()), ex); } catch (InvalidStyle ex) { throw new LayerException(I18N.tr("Unable to load the description of the layer {0}", lt.getTitle().toString()), ex); } } } }</code><technical_language>internationalized</technical_language>

Target:
private void parseJaxbLayer(LayerType lt, ILayer parentLayer) throws LayerException { if(!lt.getLayer().isEmpty() || (lt.getDataURL()==null )) { parseJaxbLayerCollection(lt, parentLayer); } else { URLType dataUrl = lt.getDataURL(); if (dataUrl != null) { OnlineResourceType resType = dataUrl.getOnlineResource(); try { URI layerURI = new URI(resType.getHref()); if(!layerURI.isAbsolute() && getLocation()!=null) { try { layerURI = getLocation().resolve(layerURI); } catch (IllegalArgumentException ex) { LOGGER.warn(I18N.tr("Error while trying to find an absolute path for an external resource"), ex); } } ILayer leafLayer; try { leafLayer = createLayer(registerLayerResource(layerURI)); } catch (Exception ex) { throw new LayerException(I18N.tr("Unable to load the data source uri {0}.", resType.getHref()), ex); } leafLayer.setDescription(new Description(lt)); leafLayer.setVisible(!lt.isHidden()); if(lt.isSetStyleList()) { for(StyleType st : lt.getStyleList().getStyle()) { if(st.isSetSLD()) { if(st.getSLD().isSetAbstractStyle()) { leafLayer.addStyle(new Style((JAXBElement<net.opengis.se._2_0.core.StyleType>)st.getSLD().getAbstractStyle(), leafLayer)); } } } } parentLayer.addLayer(leafLayer); } catch (URISyntaxException ex) { throw new LayerException(I18N.tr("Unable to parse the href URI {0}.", resType.getHref()), ex); } catch (InvalidStyle ex) { throw new LayerException(I18N.tr("Unable to load the description of the layer {0}", lt.getTitle().toString()), ex); } } } }
Source:
<code>protected boolean validate() { if (getParameters() == null || getParameters().getAgent() == null || getParameters().getAgent().getId() == null) { return failValidation(EngineMessage.VDS_REMOVE_FENCE_AGENT_ID_REQUIRED); } VDS <START> host = <END> getVds(); if (host == null) { return failValidation(EngineMessage.VDS_INVALID_SERVER_ID); } if (host.isPmEnabled()) { List<FenceAgent> fenceAgents = fenceAgentDao.getFenceAgentsForHost(getVdsId()); if (fenceAgents.size() == 1) { return failValidation(EngineMessage.VDS_REMOVE_LAST_FENCE_AGENT_PM_ENABLED); } } return super.validate(); }</code><technical_language>populate host ? I in command set a it. other commands perform: Guid vdsId = getParameters().getAgent().getHostId(); VDS vds = vdsDao.get(vdsId); I suspect host null</technical_language>

Target:
protected boolean validate() { if (getParameters() == null || getParameters().getAgent() == null || getParameters().getAgent().getId() == null) { return failValidation(EngineMessage.VDS_REMOVE_FENCE_AGENT_ID_REQUIRED); } Guid vdsId = getParameters().getAgent().getHostId(); VDS host = vdsDao.get(vdsId); if (host == null) { return failValidation(EngineMessage.VDS_INVALID_SERVER_ID); } if (host.isPmEnabled()) { List<FenceAgent> fenceAgents = fenceAgentDao.getFenceAgentsForHost(getVdsId()); if (fenceAgents.size() == 1) { return failValidation(EngineMessage.VDS_REMOVE_LAST_FENCE_AGENT_PM_ENABLED); } } return super.validate(); }
Source:
<code>private Object getInstance(String className) { try { Class descriptorClass = null; String errorMsg = null; if (classLoader != null) { try { descriptorClass = Class.forName(className, true, classLoader); } catch (Exception e) { errorMsg = e.getMessage(); } } if (descriptorClass == null) { try { descriptorClass = Class.forName(className); } catch (Exception e) { errorMsg = e.getMessage(); } } if (descriptorClass == null) { try { descriptorClass = Class.forName(className, true, ClassLoader.getSystemClassLoader()); } catch (Exception e) { errorMsg = e.getMessage(); } } if (descriptorClass == null) { registryFileError(errorMsg); return null; } return descriptorClass.newInstance(); } catch (Exception e) { registryFileError(e.getMessage()); <START> e.printStackTrace(); <END> } return null; }</code><technical_language>Never</technical_language>

Target:
private Object getInstance(String className) { try { Class descriptorClass = null; String errorMsg = null; if (classLoader != null) { try { descriptorClass = Class.forName(className, true, classLoader); } catch (Exception e) { LOGGER.log(Level.SEVERE, e.getMessage(), e); errorMsg = e.getMessage(); } } if (descriptorClass == null) { try { descriptorClass = Class.forName(className); } catch (Exception e) { LOGGER.log(Level.SEVERE, e.getMessage(), e); errorMsg = e.getMessage(); } } if (descriptorClass == null) { try { descriptorClass = Class.forName(className, true, ClassLoader.getSystemClassLoader()); } catch (Exception e) { LOGGER.log(Level.SEVERE, e.getMessage(), e); errorMsg = e.getMessage(); } } if (descriptorClass == null) { registryFileError(errorMsg); return null; } return descriptorClass.newInstance(); } catch (Exception e) { registryFileError(e.getMessage()); LOGGER.log(Level.SEVERE, e.getMessage(), e); } return null; }
Source:
<code>public String getQuestionResultStatisticsHtml(List<FeedbackResponseAttributes> responses, FeedbackQuestionAttributes question, String studentEmail, FeedbackSessionResultsBundle bundle, String view) { if ("student".equals(view) || responses.isEmpty()) { return ""; } Map<String, Integer> answerFrequency = new LinkedHashMap<String, Integer>(); <START> int numChoicesSelected = getNumberOfEmptyResponse(responses, answerFrequency); <END> if (numChoicesSelected == -1) { return ""; } DecimalFormat df = new DecimalFormat("#.##"); StringBuilder fragments = new StringBuilder(); for (Entry<String, Integer> entry : answerFrequency.entrySet()) { fragments.append(Templates.populateTemplate(FormTemplates.MCQ_RESULT_STATS_OPTIONFRAGMENT, Slots.MCQ_CHOICE_VALUE, entry.getKey(), Slots.COUNT, entry.getValue().toString(), Slots.PERCENTAGE, df.format(100 * divideOrReturnZero((double) entry.getValue(), numChoicesSelected)))); } return Templates.populateTemplate(FormTemplates.MCQ_RESULT_STATS, Slots.FRAGMENTS, fragments.toString()); }</code><technical_language>assign return of getNumberOfEmptyResponse a variable called numChoicesSelected. odd you? of names is inaccurate; both</technical_language>

Target:
public String getQuestionResultStatisticsHtml(List<FeedbackResponseAttributes> responses, FeedbackQuestionAttributes question, String studentEmail, FeedbackSessionResultsBundle bundle, String view) { if ("student".equals(view) || responses.isEmpty()) { return ""; } Map<String, Integer> answerFrequency = new LinkedHashMap<String, Integer>(); int numChoicesSelected = getNumberOfResponse(responses, answerFrequency); if (numChoicesSelected == -1) { return ""; } DecimalFormat df = new DecimalFormat("#.##"); StringBuilder fragments = new StringBuilder(); for (Entry<String, Integer> entry : answerFrequency.entrySet()) { fragments.append(Templates.populateTemplate(FormTemplates.MCQ_RESULT_STATS_OPTIONFRAGMENT, Slots.MCQ_CHOICE_VALUE, entry.getKey(), Slots.COUNT, entry.getValue().toString(), Slots.PERCENTAGE, df.format(100 * divideOrReturnZero((double) entry.getValue(), numChoicesSelected)))); } return Templates.populateTemplate(FormTemplates.MCQ_RESULT_STATS, Slots.FRAGMENTS, fragments.toString()); }
Source:
<code>public Aggregator factorize(ColumnSelectorFactory columnFactory) { BloomKFilter filter = new BloomKFilter(maxNumEntries); ColumnCapabilities capabilities = columnFactory.getColumnCapabilities(field.getDimension()); BaseNullableColumnValueSelector selector = columnFactory.makeColumnValueSelector(field.getDimension()); if (selector instanceof NilColumnValueSelector) { <START> return new NilBloomFilterAggregator((NilColumnValueSelector) selector, filter); <END> } if (capabilities == null) { throw new IAE( "Cannot create bloom filter buffer aggregator for column selector type [%s]", selector.getClass().getName() ); } ValueType type = capabilities.getType(); switch (type) { case STRING: return new StringBloomFilterAggregator(columnFactory.makeDimensionSelector(field), filter); case LONG: return new LongBloomFilterAggregator(columnFactory.makeColumnValueSelector(field.getDimension()), filter); case FLOAT: return new FloatBloomFilterAggregator(columnFactory.makeColumnValueSelector(field.getDimension()), filter); case DOUBLE: return new DoubleBloomFilterAggregator(columnFactory.makeColumnValueSelector(field.getDimension()), filter); default: throw new IAE("Cannot create bloom filter aggregator for invalid column type [%s]", type); } }</code><technical_language>Is important BloomKFilter specifically maxNumEntries? If not, new BloomKFilter(0) (or 1) cached in a constant</technical_language>

Target:
public Aggregator factorize(ColumnSelectorFactory columnFactory) { BloomKFilter filter = new BloomKFilter(maxNumEntries); ColumnCapabilities capabilities = columnFactory.getColumnCapabilities(field.getDimension()); if (capabilities == null) { BaseNullableColumnValueSelector selector = columnFactory.makeColumnValueSelector(field.getDimension()); if (selector instanceof NilColumnValueSelector) { return new EmptyBloomFilterAggregator(filter); } throw new IAE( "Cannot create bloom filter buffer aggregator for column selector type [%s]", selector.getClass().getName() ); } ValueType type = capabilities.getType(); switch (type) { case STRING: return new StringBloomFilterAggregator(columnFactory.makeDimensionSelector(field), filter); case LONG: return new LongBloomFilterAggregator(columnFactory.makeColumnValueSelector(field.getDimension()), filter); case FLOAT: return new FloatBloomFilterAggregator(columnFactory.makeColumnValueSelector(field.getDimension()), filter); case DOUBLE: return new DoubleBloomFilterAggregator(columnFactory.makeColumnValueSelector(field.getDimension()), filter); default: throw new IAE("Cannot create bloom filter aggregator for invalid column type [%s]", type); } }
Source:
<code>public String getCachedString() { <START> String rv; <END> if (variableData.expression == null || variableData.expression.length() == 0) rv = "_"; else if (Double.isNaN(getCachedValue())) rv = "*"; else rv = "" + (int) getCachedValue(); return rv; }</code><technical_language>This variable is useless. Please return in if/ branches</technical_language>

Target:
public String getCachedString() { final String rv; if (variableData.expression == null || variableData.expression.length() == 0) { rv = "_"; } else if (Double.isNaN(getCachedValue())) { rv = "*"; } else { rv = String.valueOf((int) getCachedValue()); } return rv; }