auphong2707/dl4se-code-review-dataset huggingface dataset:
Source:
<code>public static void setUp() throws InterruptedException, TimeoutException, IOException { operations.add(HTTP_SERVER_ADDRESS); <START> administration.reloadIfRequired(); <END> operations.add(HOST_ADDRESS); operations.add(HOST_TBR_ADDRESS); administration.reloadIfRequired(); }</code><technical_language>Is this reload necessary</technical_language>

Target:
public static void setUp() throws InterruptedException, TimeoutException, IOException { operations.add(HTTP_SERVER_ADDRESS); operations.add(HOST_ADDRESS); operations.add(HOST_TBR_ADDRESS); administration.reloadIfRequired(); }
Source:
<code>public MavenProject resolveParentProject(final MavenProject child, IProgressMonitor monitor) throws CoreException { return context().execute(child, new ICallable<MavenProject>() { <START> public MavenProject call(IMavenExecutionContext context, IProgressMonitor monitor) throws CoreException { <END> return resolveParentProject(context.getRepositorySession(), child, context.getExecutionRequest() .getProjectBuildingRequest()); } }, monitor); }</code><technical_language>unnecessary change</technical_language>

Target:
public MavenProject resolveParentProject(final MavenProject child, IProgressMonitor monitor) throws CoreException { return context().execute(child, (context, pm) -> resolveParentProject(context.getRepositorySession(), child, context.getExecutionRequest().getProjectBuildingRequest()), monitor); }
Source:
<code>private PathMatcher folderMatcher() { <START> return it -> isSourceFolder(it); <END> }</code><technical_language>This is causing communicate jdt.ls for folder change in file system. I more efficient send folder change jdt.ls jdt.ls do filtering. Also, interested in change in create/delete</technical_language>

Target:
private PathMatcher folderMatcher() { return it -> isDirectory(it); }
Source:
<code>private Filter createLowerBoundFilter(Object value, boolean inclusive) { Filter filter = createBoundFilter(Bound.LOWER, value, inclusive); <START> filter.setBooleanOperator(booleanOperator); <END> return filter; }</code><technical_language>pass operator of (lower upper)? "and" is for boolean operator previous this this next</technical_language>

Target:
private Filter createLowerBoundFilter(Object value, boolean inclusive) { return createBoundFilter(Bound.LOWER, value, inclusive, booleanOperator); }
Source:
<code>public int compareTo(final DayProfileAction other) { <START> return other.scriptLogicalName.compareTo(this.scriptLogicalName); <END> }</code><technical_language>Is reversed comparison intentional</technical_language>

Target:
public int compareTo(final DayProfileAction other) { final int rank = this.scriptSelector.compareTo(other.scriptSelector); if (rank != 0) { return rank; } return this.startTime.compareTo(other.startTime); }
Source:
<code><START> protected static URI createAnnouncementLocation(URI baseUri, String nodeId) <END> { return HttpUriBuilder.uriBuilderFrom(baseUri) .appendPath("/v1/announcement") .appendPath(nodeId) .build(); }</code><technical_language>suggestion @VisibleForTesting static URI createAnnouncementLocation(URI baseUri, String nodeId)</technical_language>

Target:
static URI createAnnouncementLocation(URI baseUri, String nodeId) { return uriBuilderFrom(baseUri) .appendPath("/v1/announcement") .appendPath(nodeId) .build(); }
Source:
<code>private void evaluate(String target, Map<String, BucketPoint> queryResults, ConditionEvaluator evaluator) { Map<String, String> preparedCondition = null; try { preparedCondition = evaluator.prepare(queryResults); } catch (Exception e) { log.debugf("Could not prepare evaluation, Skipping due to [%s]", e.getMessage()); } if (evaluator.evaluate()) { try { <START> Data externalData = Data.forString(externalCondition.getTenantId(), <END> externalCondition.getDataId(), System.currentTimeMillis(), preparedCondition.toString()); if (log.isDebugEnabled()) { log.debug("Sending External Condition Data to Alerting! " + externalData); } alertsService.sendData(Collections.singleton(externalData)); } catch (Exception e) { log.error("Failed to send external data to alerts system.", e); } } }</code><technical_language>So, I 100% if I understand some details of logic. in mode, ExternalCondition expect Event in mode a Data trigger Alert. I right</technical_language>

Target:
private void evaluate(String target, Map<String, BucketPoint> queryResults, ConditionEvaluator evaluator) { Map<String, String> preparedCondition = null; try { preparedCondition = evaluator.prepare(queryResults); } catch (Exception e) { log.debugf("Could not prepare evaluation, Skipping due to [%s]", e.getMessage()); } if (evaluator.evaluate()) { try { Event externalEvent = new Event(externalCondition.getTenantId(), UUID.randomUUID().toString(), System.currentTimeMillis(), externalCondition.getDataId(), TAG_EXTERNAL_CONDITION_VALUE, preparedCondition.toString()); log.debugf("Sending External Condition Event to Alerting %s", externalEvent); alertsService.sendEvents(Collections.singleton(externalEvent)); } catch (Exception e) { log.error("Failed to send external [ALL] event to alerts system.", e); } } }
Source:
<code>public String addEndpointRegistryEntry(EndpointRegistryEntry registryEntry) throws EndpointRegistryException { <START> if (StringUtils.isEmpty(registryEntry.getDisplayName())) { <END> registryEntry.setDisplayName(registryEntry.getEntryName()); } if (registryDAO.isRegistryEntryNameExists(registryEntry, false)) { EndpointRegistryUtil.raiseResourceAlreadyExistsException("Endpoint Registry Entry with name '" + registryEntry.getEntryName() + "' already exists"); } else if (registryDAO.isRegistryEntryNameExists(registryEntry, true)) { EndpointRegistryUtil.raiseResourceAlreadyExistsException("Endpoint Registry Entry with display name '" + registryEntry.getDisplayName() + "' already exists"); } return registryDAO.addEndpointRegistryEntry(registryEntry, username); }</code><technical_language>done logic in multiple places, move this logic some common place, mappingUtils</technical_language>

Target:
public String addEndpointRegistryEntry(EndpointRegistryEntry registryEntry) throws EndpointRegistryException { if (registryDAO.isRegistryEntryNameExists(registryEntry, false)) { EndpointRegistryUtil.raiseResourceAlreadyExistsException("Endpoint Registry Entry with name '" + registryEntry.getEntryName() + "' already exists"); } else if (registryDAO.isRegistryEntryNameExists(registryEntry, true)) { EndpointRegistryUtil.raiseResourceAlreadyExistsException("Endpoint Registry Entry with display name '" + registryEntry.getDisplayName() + "' already exists"); } return registryDAO.addEndpointRegistryEntry(registryEntry, username); }
Source:
<code>protected <E> Long remove( final E entity ) throws BackendlessException { if( entity == null ) throw new IllegalArgumentException( ExceptionMessage.NULL_ENTITY ); Object result; if( ReflectionUtil.hasField( entity.getClass(), Persistence.DEFAULT_OBJECT_ID_FIELD ) ) { result = Invoker.invokeSync( PERSISTENCE_MANAGER_SERVER_ALIAS, "remove", new Object[] { Backendless.getApplicationId(), Backendless.getVersion(), getSimpleName( entity.getClass() ), entity } ); } else { String objectId = FootprintsManager.getInstance().getObjectId( entity ); <START> result = Invoker.invokeSync( PERSISTENCE_MANAGER_SERVER_ALIAS, "remove", new Object[] { Backendless.getApplicationId(), Backendless.getVersion(), getSimpleName( entity.getClass() ), objectId } ); <END> } FootprintsManager.getInstance().Inner.removeFootprintForObject( BackendlessSerializer.serializeToMap( entity ), entity ); return ((Number) result).longValue(); }</code><technical_language>nice get rid of code duplication (lines 271 276)</technical_language>

Target:
protected <E> Long remove( final E entity ) throws BackendlessException { if( entity == null ) throw new IllegalArgumentException( ExceptionMessage.NULL_ENTITY ); Object entityArg = ReflectionUtil.hasField( entity.getClass(), Persistence.DEFAULT_OBJECT_ID_FIELD ) ? entity : FootprintsManager.getInstance().getObjectId( entity ); Object result = Invoker.invokeSync( PERSISTENCE_MANAGER_SERVER_ALIAS, "remove", new Object[] { Backendless.getApplicationId(), Backendless.getVersion(), getSimpleName( entity.getClass() ), entityArg } ); FootprintsManager.getInstance().Inner.removeFootprintForObject( BackendlessSerializer.serializeToMap( entity ), entity ); return ((Number) result).longValue(); }
Source:
<code>public boolean containsAll(Collection<?> c) { for (Object <START> name : <END> c) if (!wrappedSet.contains(IdentityWrapper.wrap(name))) return false; return true; }</code><technical_language>rename 'element'</technical_language>

Target:
public boolean containsAll(Collection<?> c) { for (Object element : c) if (!wrappedSet.contains(IdentityWrapper.wrap(element))) return false; return true; }
Source:
<code>private SegmentEvent transformSegmentEvent(org.atlasapi.media.segment.SegmentEvent input, Version version) throws UnresolvedLegacySegmentException { SegmentEvent se = new SegmentEvent(); setIdentifiedFields(se, input); se.setOffset(input.getOffset()); se.setIsChapter(input.getIsChapter()); org.atlasapi.media.entity.Description d = input.getDescription(); <START> se.setDescription(d.getSynopsis()); <END> se.setTitle(d.getTitle()); se.setImage(d.getImage()); se.setThumbnail(d.getThumbnail()); org.atlasapi.media.segment.SegmentRef sr = input.getSegment(); Id segmentId = Id.valueOf(sr.identifier()); WriteResult<Segment, Segment> legacyMigrationResult = legacySegmentMigrator.migrateLegacySegment(segmentId); se.setSegment(new SegmentRef(segmentId, legacyMigrationResult.getResource().getPublisher())); se.setVersionId(version.getCanonicalUri()); return se; }</code><technical_language>this; Description object is a nicer approach. adding interface Sourced is right approach here</technical_language>

Target:
private SegmentEvent transformSegmentEvent(org.atlasapi.media.segment.SegmentEvent input, Version version) throws UnresolvedLegacySegmentException { SegmentEvent se = new SegmentEvent(); setIdentifiedFields(se, input); se.setOffset(input.getOffset()); se.setIsChapter(input.getIsChapter()); org.atlasapi.media.entity.Description d = input.getDescription(); se.setDescription(new Description(d.getTitle(), d.getSynopsis(), d.getImage(), d.getThumbnail())); org.atlasapi.media.segment.SegmentRef sr = input.getSegment(); Id segmentId = Id.valueOf(sr.identifier()); WriteResult<Segment, Segment> legacyMigrationResult = legacySegmentMigrator.migrateLegacySegment(segmentId); se.setSegment(new SegmentRef(segmentId, legacyMigrationResult.getResource().getPublisher())); se.setVersionId(version.getCanonicalUri()); return se; }
Source:
<code>public PeriodicMeterReadGasResponseDto(final PeriodTypeDto periodType, final List<PeriodicMeterReadsGasResponseItemDto> periodicMeterReadsGas) { <START> this.periodicMeterReadsGas = new ArrayList<PeriodicMeterReadsGasResponseItemDto>(periodicMeterReadsGas); <END> this.periodType = periodType; }</code><technical_language>In Java7 repeat type in concrete type</technical_language>

Target:
public PeriodicMeterReadGasResponseDto(final PeriodTypeDto periodType, final List<PeriodicMeterReadsGasResponseItemDto> periodicMeterReadsGas) { this.periodicMeterReadsGas = new ArrayList<>(periodicMeterReadsGas); this.periodType = periodType; }
Source:
<code>private void onFailure(Throwable caught) { if (failed) { return; } failed = true; Throwable caughtDuringOnFailure = null; for (Object o : callbacks) { try { if (o instanceof AsyncCallback) { @SuppressWarnings("unchecked") AsyncCallback<Object> cb = (AsyncCallback<Object>) o; cb.onFailure(caught); } else { @SuppressWarnings("unchecked") com.google.gwtjsonrpc.common.AsyncCallback<Object> cb = (com.google.gwtjsonrpc.common.AsyncCallback<Object>) o; cb.onFailure(caught); } <START> } catch (Throwable t) { <END> if (caughtDuringOnFailure == null) { caughtDuringOnFailure = t; } } } propagate(caught); }</code><technical_language>This worth effort. call stack crash event loop</technical_language>

Target:
private void onFailure(Throwable caught) { if (failed) { return; } failed = true; for (Object o : callbacks) { if (o instanceof AsyncCallback) { @SuppressWarnings("unchecked") AsyncCallback<Object> cb = (AsyncCallback<Object>) o; cb.onFailure(caught); } else { @SuppressWarnings("unchecked") com.google.gwtjsonrpc.common.AsyncCallback<Object> cb = (com.google.gwtjsonrpc.common.AsyncCallback<Object>) o; cb.onFailure(caught); } } }
Source:
<code><START> public void readInto(ByteBuffer buffer, long position) <END> throws IOException { if (position < 0 || position > getEndOffset()) { throw new IllegalArgumentException( "Provided position [" + position + "] is out of bounds for the segment [" + file.getAbsolutePath() + "] with end offset [" + getEndOffset() + "]"); } if (position + buffer.remaining() > getEndOffset()) { metrics.overflowReadError.inc(); throw new IllegalArgumentException("Cannot read from segment [" + file.getAbsolutePath() + "] from position [" + position + "] for size [" + buffer.remaining() + "] because it exceeds the end offset [" + endOffset + "]"); } long bytesRead = 0; int size = buffer.remaining(); while (bytesRead < size) { bytesRead += fileChannel.read(buffer, position + bytesRead); } }</code><technical_language>here, in interface, data is read buffer. clear: other similar apis, is "read EOF", "read buffer.remaining() throw"</technical_language>

Target:
public void readInto(ByteBuffer buffer, long position) throws IOException { if (position < 0 || position >= getEndOffset()) { throw new IndexOutOfBoundsException( "Provided position [" + position + "] is out of bounds for the segment [" + file.getAbsolutePath() + "] with end offset [" + getEndOffset() + "]"); } if (position + buffer.remaining() > getEndOffset()) { metrics.overflowReadError.inc(); throw new IndexOutOfBoundsException("Cannot read from segment [" + file.getAbsolutePath() + "] from position [" + position + "] for size [" + buffer.remaining() + "] because it exceeds the end offset [" + endOffset + "]"); } long bytesRead = 0; int size = buffer.remaining(); while (bytesRead < size) { bytesRead += fileChannel.read(buffer, position + bytesRead); } }
Source:
<code>public Builder withSingleValuedColumn(VSizeIndexedInts singleValuedColumn) { Preconditions.checkState(compressedSingleValuedColumn == null, "Cannot set both singleValuedColumn and compressedSingleValuedColumn"); Preconditions.checkState(multiValuedColumn == null, "Cannot set both singleValuedColumn and multiValuedColumn"); <START> this.singleValuedColumn = singleValuedColumn; <END> return this; }</code><technical_language>this do .asWriteableSupplier() simplify build() call thing</technical_language>

Target:
public Builder withSingleValuedColumn(VSizeIndexedInts singleValuedColumn) { Preconditions.checkState(multiValuedColumn == null, "Cannot set both singleValuedColumn and multiValuedColumn"); this.version = VERSION.UNCOMPRESSED_SINGLE_VALUE; this.singleValuedColumn = singleValuedColumn.asWritableSupplier(); return this; }
Source:
<code>public <T> void spawnParticle(Particle particle, Location location, int count, double offsetX, double offsetY, double offsetZ, double extra, T data) { if (particle == null) { throw new IllegalArgumentException("particle cannot be null!"); } if (data != null && !particle.getDataType().isInstance(data)) { throw new IllegalArgumentException("wrong data type " + data.getClass() + " should be " + particle.getDataType()); } <START> for (Player player : getPlayers()) { <END> GlowPlayer glowPlayer = (GlowPlayer) player; double distance = player.getLocation().distanceSquared(location); boolean isLongDistance = GlowParticle.isLongDistance(particle); int particleId = GlowParticle.getId(particle); int[] particleData = GlowParticle.getData(particle, data); if (distance <= 1024.0D || isLongDistance && distance <= 262144.0D) { glowPlayer.getSession().send(new PlayParticleMessage(particleId, isLongDistance, (float) location.getX(), (float) location.getY(), (float) location.getZ(), (float) offsetX, (float) offsetY, (float) offsetZ, (float) extra, count, particleData)); } } }</code><technical_language>getRawPlayers() skip cast</technical_language>

Target:
public <T> void spawnParticle(Particle particle, Location location, int count, double offsetX, double offsetY, double offsetZ, double extra, T data) { if (particle == null) { throw new IllegalArgumentException("particle cannot be null!"); } if (data != null && !particle.getDataType().isInstance(data)) { throw new IllegalArgumentException("wrong data type " + data.getClass() + " should be " + particle.getDataType()); } for (GlowPlayer player : getRawPlayers()) { double distance = player.getLocation().distanceSquared(location); boolean isLongDistance = GlowParticle.isLongDistance(particle); int particleId = GlowParticle.getId(particle); int[] particleData = GlowParticle.getExtData(particle, data); if (distance <= 1024.0D || isLongDistance && distance <= 262144.0D) { player.getSession().send(new PlayParticleMessage(particleId, isLongDistance, (float) location.getX(), (float) location.getY(), (float) location.getZ(), (float) offsetX, (float) offsetY, (float) offsetZ, (float) extra, count, particleData)); } } }
Source:
<code>public void destroy() { this.canvasHandler = null; this.canvasHighlight = null; this.sourceNode = null; this.palette.destroy(); this.nodeDragProxyFactory.destroy(); this.nodeBuilderControl.setCommandManagerProvider(null); this.nodeBuilderControl.disable(); this.graphBoundsIndexer.destroy(); <START> this.canvasHighlight.destroy(); <END> }</code><technical_language>This method lead NullPointerException: java this.canvasHighlight = null; [...] this.canvasHighlight.destroy();</technical_language>

Target:
public void destroy() { this.palette.destroy(); this.nodeDragProxyFactory.destroy(); this.nodeBuilderControl.setCommandManagerProvider(null); this.nodeBuilderControl.disable(); this.graphBoundsIndexer.destroy(); this.canvasHighlight.destroy(); this.canvasHandler = null; this.canvasHighlight = null; this.sourceNode = null; }
Source:
<code>private String arrayToStr(Header[] headers) { StringBuilder sb = new StringBuilder(); for (Header header : headers) { <START> sb.append(header.toString()); <END> } return sb.toString(); }</code><technical_language>append CRLF well</technical_language>

Target:
private static String arrayToStr(Header[] headers) { StringBuilder sb = new StringBuilder(); for (Header header : headers) { sb.append(header.toString()).append("\r\n"); } return sb.toString(); }
Source:
<code><START> boolean evaluate() throws E, IOException; <END> } @InterfaceAudience.Private public interface ExplainingPredicate<E extends Exception> extends Predicate<E> { String explainFailure() throws E; }</code><technical_language>this change? E exception type..</technical_language>

Target:
boolean evaluate() throws E; } @InterfaceAudience.Private public interface ExplainingPredicate<E extends Exception> extends Predicate<E> { String explainFailure() throws E; }
Source:
<code>public Description getDescription() { Description spec = Description.createSuiteDescription(getName(), classAnnotations()); <START> List<Method> testMethods = this.testMethods; <END> for (Method method : testMethods) { spec.addChild(methodDescription(method)); } return spec; }</code><technical_language>rename testMethods shadow this.testMethods</technical_language>

Target:
public Description getDescription() { Description spec = Description.createSuiteDescription(getName(), classAnnotations()); List<Method> methods = testMethods; for (Method method : methods) { spec.addChild(methodDescription(method)); } return spec; }
Source:
<code>public HttpResponse doAddFixedToken(@AncestorInPath User u, @QueryParameter String newTokenName, @QueryParameter String newTokenPlainValue) throws IOException { if (!hasCurrentUserRightToGenerateNewToken(u)) { return HttpResponses.forbidden(); } final String tokenName; if (StringUtils.isBlank(newTokenName)) { tokenName = String.format("Token created on %s", DateTimeFormatter.ISO_OFFSET_DATE_TIME.format(ZonedDateTime.now())); } else { tokenName = newTokenName; } <START> ApiTokenProperty p = u.getProperty(ApiTokenProperty.class); <END> if (p == null) { p = forceNewInstance(u, false); u.addProperty(p); } String tokenUuid = p.tokenStore.addFixedNewToken(tokenName, newTokenPlainValue); u.save(); return HttpResponses.okJSON(new HashMap<String, String>() {{ put("tokenUuid", tokenUuid); put("tokenName", tokenName); }}); }</code><technical_language>a nice opportunity improve API some sort of computeIfAbsent type method in Map</technical_language>

Target:
public HttpResponse doAddFixedToken(@AncestorInPath User u, @QueryParameter String newTokenName, @QueryParameter String newTokenPlainValue) throws IOException { if (!hasCurrentUserRightToGenerateNewToken(u)) { return HttpResponses.forbidden(); } final String tokenName; if (StringUtils.isBlank(newTokenName)) { tokenName = String.format("Token created on %s", DateTimeFormatter.ISO_OFFSET_DATE_TIME.format(ZonedDateTime.now())); } else { tokenName = newTokenName; } ApiTokenProperty p = u.getProperty(ApiTokenProperty.class); if (p == null) { p = forceNewInstance(u, false); u.addProperty(p); } String tokenUuid = p.tokenStore.addFixedNewToken(tokenName, newTokenPlainValue); u.save(); Map<String, String> data = new HashMap<>(); data.put("tokenUuid", tokenUuid); data.put("tokenName", tokenName); return HttpResponses.okJSON(data); }
Source:
<code><START> public void createNorthAnt() { <END> inputFile = new String[] { "0000", "0000", "0a00", "0000" }; runs = new Run[] { new ExactRun("ant", is("a")), new NoOutputRun("create B,1,1"), new ExactRun("ant", is("a,b")), new ExactRun("position b", is("1,1")), new ExactRun("direction b", is("N")), new ExactRun("field 1,1", is("b")), quit() }; sessionTest(runs, Input.getFile(inputFile)); inputFile = new String[] { "b000", "0000", "0a00", "Z000" }; runs = new Run[] { new ExactRun("ant", is("a,b,z")), new NoOutputRun("create H,1,3"), new ExactRun("ant", is("a,b,h,z")), new ExactRun("position h", is("1,3")), new ExactRun("direction h", is("N")), new ExactRun("field 1,3", is("b")), quit() }; sessionTest(runs, Input.getFile(inputFile)); }</code><technical_language>Missing @Test, this test is run</technical_language>

Target:
public void createNorthAnt() { inputFile = new String[] { "0000", "0000", "0a00", "0000" }; runs = new Run[] { new ExactRun("ant", is("a")), new NoOutputRun("create B,1,1"), new ExactRun("ant", is("a,b")), new ExactRun("position b", is("1,1")), new ExactRun("direction b", is("N")), new ExactRun("field 1,1", is("b")), quit() }; sessionTest(runs, Input.getFile(inputFile)); inputFile = new String[] { "b000", "0000", "0a00", "Z000" }; runs = new Run[] { new ExactRun("ant", is("a,b,z")), new NoOutputRun("create H,1,3"), new ExactRun("ant", is("a,b,h,z")), new ExactRun("position h", is("1,3")), new ExactRun("direction h", is("N")), new ExactRun("field 1,3", is("h")), quit() }; sessionTest(runs, Input.getFile(inputFile)); }
Source:
<code>public File getLocalFile(String pdbId) { LinkedList<File> searchdirs = new LinkedList<File>(); String middle = pdbId.substring(1,3).toLowerCase(); File splitdir = new File(splitDirPath, middle); searchdirs.add(splitdir); if(getObsoleteBehavior() == ObsoleteBehavior.FETCH_OBSOLETE) { File obsdir = new File(obsoleteDirPath,middle); searchdirs.add(obsdir); } String[] prefixes = new String[] {"", "pdb"}; for( File searchdir :searchdirs){ for( String prefix : prefixes) { for(String ex : getExtensions() ){ File f = new File(searchdir,prefix + pdbId.toLowerCase() + ex) ; if ( f.exists()) { if( f.length() < MIN_PDB_FILE_SIZE ) { boolean success = f.delete(); if( ! success) { return null; } <START> assert(!f.exists()); <END> } return f; } } } } return null; }</code><technical_language>log a warning here. Assert is in normal situations</technical_language>

Target:
public File getLocalFile(String pdbId) throws IOException { LinkedList<File> searchdirs = new LinkedList<File>(); String middle = pdbId.substring(1,3).toLowerCase(); File splitdir = new File(splitDirPath, middle); searchdirs.add(splitdir); if(getObsoleteBehavior() == ObsoleteBehavior.FETCH_OBSOLETE) { File obsdir = new File(obsoleteDirPath,middle); searchdirs.add(obsdir); } String[] prefixes = new String[] {"", "pdb"}; for( File searchdir :searchdirs){ for( String prefix : prefixes) { for(String ex : getExtensions() ){ File f = new File(searchdir,prefix + pdbId.toLowerCase() + ex) ; if ( f.exists()) { if( f.length() < MIN_PDB_FILE_SIZE ) { Files.delete(f.toPath()); return null; } return f; } } } } return null; }
Source:
<code>private Map<String, ?> determineUriVariables(Message<?> requestMessage) { if (this.uriVariablesExpression != null) { return this.uriVariablesExpression.getValue(this.evaluationContext, requestMessage, Map.class); } else { return ExpressionEvalMap.from(this.uriVariableExpressions) .usingEvaluationContext(this.evaluationContext) .withRoot(requestMessage) .build(); } <START> } <END></code><technical_language>Oh, I - however, I need support injected map (found evaluating expression) expressions themselves, constants</technical_language>

Target:
private Map<String, ?> determineUriVariables(Message<?> requestMessage) { Map<String, ?> expressions; if (this.uriVariablesExpression != null) { expressions = this.uriVariablesExpression.getValue(this.evaluationContext, requestMessage, Map.class); } else { expressions = this.uriVariableExpressions; } return ExpressionEvalMap.from(expressions) .usingEvaluationContext(this.evaluationContext) .withRoot(requestMessage) .build(); }
Source:
<code>public int isApplicable(VElement vElement, ViewModelContext viewModelContext) { if (!VControl.class.isInstance(vElement)) { return NOT_APPLICABLE; } final VControl control = (VControl) vElement; final IObservableValue observableValue = Activator.getDefault().getEMFFormsDatabinding() .getObservableValue(control.getDomainModelReference(), viewModelContext.getDomainModel()); final EStructuralFeature feature = (EStructuralFeature) observableValue.getValueType(); final EObject eObject = (EObject) ((IObserving) observableValue).getObserved(); <START> if (VKeyAttributeDomainModelReference.class.isInstance(eObject) <END> && VKeyattributedmrPackage.eINSTANCE.getKeyAttributeDomainModelReference_KeyDMR() == feature) { return 6; } if (VKeyAttributeDomainModelReference.class.isInstance(eObject) && VKeyattributedmrPackage.eINSTANCE.getKeyAttributeDomainModelReference_ValueDMR() == feature) { return 6; } return NOT_APPLICABLE; }</code><technical_language>check unnecessary</technical_language>

Target:
public int isApplicable(VElement vElement, ViewModelContext viewModelContext) { if (!VControl.class.isInstance(vElement)) { return NOT_APPLICABLE; } final VControl control = (VControl) vElement; final IValueProperty valueProperty = Activator.getDefault().getEMFFormsDatabinding() .getValueProperty(control.getDomainModelReference()); final EStructuralFeature feature = (EStructuralFeature) valueProperty.getValueType(); if (VKeyattributedmrPackage.eINSTANCE.getKeyAttributeDomainModelReference_KeyDMR() == feature) { return 6; } if (VKeyattributedmrPackage.eINSTANCE.getKeyAttributeDomainModelReference_ValueDMR() == feature) { return 6; } return NOT_APPLICABLE; }
Source:
<code>public SQLExecEnvironment registerTable(String name, Endpoint endpoint) { <START> registerTable(name, new ApexSQLTable(schema, name, endpoint)); <END> return this; }</code><technical_language>is expected behavior if registerTable() called call withModel()</technical_language>

Target:
public SQLExecEnvironment registerTable(String name, Endpoint endpoint) { Preconditions.checkNotNull(name, "Table name cannot be null"); registerTable(name, new ApexSQLTable(schema, name, endpoint)); return this; }
Source:
<code>public void execute(OutboundPatientLocationQueryOrchestratable message) { LOG.trace("Begin OutboundPatientLocationQueryStrategyImpl.execute"); <START> NhinPatientLocationQueryProxy nhincDocSubmission = getNhinDocDataSubmissionProxy(); <END> PatientLocationQueryResponseType response = nhincDocSubmission.processPatientLocationQuery(message.getRequest(), message.getAssertion(), message.getTarget(), NhincConstants.GATEWAY_API_LEVEL.LEVEL_g0); message.setResponse(response); LOG.trace("End OutboundPatientLocationQueryStrategyImpl.execute"); }</code><technical_language>referencing 'DocDataSubmission' recommend rename</technical_language>

Target:
public void execute(OutboundPatientLocationQueryOrchestratable message) { LOG.trace("Begin OutboundPatientLocationQueryStrategyImpl.execute"); NhinPatientLocationQueryProxy plqProxy = getNhinPatientLocationQueryProxy(); PatientLocationQueryResponseType response = plqProxy.processPatientLocationQuery(message.getRequest(), message.getAssertion(), message.getTarget(), NhincConstants.GATEWAY_API_LEVEL.LEVEL_g0); message.setResponse(response); LOG.trace("End OutboundPatientLocationQueryStrategyImpl.execute"); }
Source:
<code>public void validateItemType(Item item, String bindingConfig) throws BindingConfigParseException { if (!(item instanceof SwitchItem || item instanceof NumberItem || item instanceof DimmerItem || item instanceof RollershutterItem || item instanceof StringItem)) { throw new BindingConfigParseException( "item '" + item.getName() + "' is of type '" + item.getClass().getSimpleName() <START> + "', only SwitchItem, NumberItem, DimmerItem, RollershutterItem and StringItem are allowed - please check your *.items configuration"); <END> } }</code><technical_language>More user-friendly "', Switch, Number, Dimmer, Rollershutter String items allowed - please check *.items configuration"</technical_language>

Target:
public void validateItemType(Item item, String bindingConfig) throws BindingConfigParseException { if (!(item instanceof SwitchItem || item instanceof NumberItem || item instanceof DimmerItem || item instanceof RollershutterItem || item instanceof StringItem)) { throw new BindingConfigParseException("item '" + item.getName() + "' is of type '" + item.getClass().getSimpleName() + "', only Switch, Number, Dimmer, Rollershutter and String are allowed - please check your *.items configuration"); } }
Source:
<code>public void execute(TupleWindow inputWindow) { Map<K, KeyValue<V1, V2>> joinMap = new HashMap<>(); for (Tuple tuple : inputWindow.get()) { if (tuple.getSourceComponent().equals(leftComponent)) { KeyValue<K, V1> tup = (KeyValue<K, V1>) tuple.getValue(0); if (tup.getKey() != null) { addMapLeft(joinMap, tup); } } else { KeyValue<K, V2> tup = (KeyValue<K, V2>) tuple.getValue(0); if (tup.getKey() != null) { addMapRight(joinMap, tup); } } } for (K key : joinMap.keySet()) { KeyValue<V1, V2> val = joinMap.get(key); switch (joinType) { case INNER: if (val.getKey() != null && val.getValue() != null) { joinAndEmit(key, val); } break; case LEFT: if (val.getKey() != null) { joinAndEmit(key, val); } break; case OUTER: joinAndEmit(key, val); break; default: <START> throw new RuntimeException("Unknown jointype"); <END> } } }</code><technical_language>include unknown join type in message</technical_language>

Target:
public void execute(TupleWindow inputWindow) { Map<K, KeyValue<V1, V2>> joinMap = new HashMap<>(); for (Tuple tuple : inputWindow.get()) { if (tuple.getSourceComponent().equals(leftComponent)) { KeyValue<K, V1> tup = (KeyValue<K, V1>) tuple.getValue(0); if (tup.getKey() != null) { addMapLeft(joinMap, tup); } } else { KeyValue<K, V2> tup = (KeyValue<K, V2>) tuple.getValue(0); if (tup.getKey() != null) { addMapRight(joinMap, tup); } } } evaluateJoinMap(joinMap, inputWindow); }
Source:
<code>void updatePartitions(Collection<? extends PartitionId> allPartitions, String localDatacenterName) { this.allPartitions = allPartitions; partitionIdsByClassAndLocalReplicaCount = new TreeMap<>(String.CASE_INSENSITIVE_ORDER); for (PartitionId partition : allPartitions) { String partitionClass = partition.getPartitionClass(); int localReplicaCount = 0; for (ReplicaId replicaId : partition.getReplicaIds()) { if (localDatacenterName != null && !localDatacenterName.isEmpty() && replicaId.getDataNodeId() .getDatacenterName() .equals(localDatacenterName)) { localReplicaCount++; } } <START> if (!partitionIdsByClassAndLocalReplicaCount.containsKey(partitionClass)) { <END> partitionIdsByClassAndLocalReplicaCount.put(partitionClass, new TreeMap<>()); } SortedMap<Integer, List<PartitionId>> replicaCountToPartitionIds = partitionIdsByClassAndLocalReplicaCount.get(partitionClass); if (!replicaCountToPartitionIds.containsKey(localReplicaCount)) { replicaCountToPartitionIds.put(localReplicaCount, new ArrayList<>()); } replicaCountToPartitionIds.get(localReplicaCount).add(partition); } }</code><technical_language>replace lines 285-289 with: java SortedMap<Integer, List<PartitionId>> replicaCountToPartitionIds = partitionIdsByClassAndLocalReplicaCount.computeIfAbsent(partitionClass, key -> new TreeMap<>())</technical_language>

Target:
void updatePartitions(Collection<? extends PartitionId> allPartitions, String localDatacenterName) { this.allPartitions = allPartitions; partitionIdsByClassAndLocalReplicaCount = new TreeMap<>(String.CASE_INSENSITIVE_ORDER); for (PartitionId partition : allPartitions) { String partitionClass = partition.getPartitionClass(); int localReplicaCount = 0; for (ReplicaId replicaId : partition.getReplicaIds()) { if (localDatacenterName != null && !localDatacenterName.isEmpty() && replicaId.getDataNodeId() .getDatacenterName() .equals(localDatacenterName)) { localReplicaCount++; } } SortedMap<Integer, List<PartitionId>> replicaCountToPartitionIds = partitionIdsByClassAndLocalReplicaCount.computeIfAbsent(partitionClass, key -> new TreeMap<>()); replicaCountToPartitionIds.computeIfAbsent(localReplicaCount, key -> new ArrayList<>()).add(partition); } }
Source:
<code>public TimeLineTopComponent(TimeLineController controller) { initComponents(); this.controller = controller; associateLookup(ExplorerUtils.createLookup(em, getActionMap())); setName(NbBundle.getMessage(TimeLineTopComponent.class, "CTL_TimeLineTopComponent")); setToolTipText(NbBundle.getMessage(TimeLineTopComponent.class, "HINT_TimeLineTopComponent")); setIcon(WindowManager.getDefault().getMainWindow().getIconImage()); dataContentPanel = DataContentPanel.createInstance(); this.contentViewerContainerPanel.add(dataContentPanel, BorderLayout.CENTER); tlrv = new TimeLineResultView(controller, dataContentPanel); <START> final DataResultPanel dataResultPanel = tlrv.getDataResultPanel(); <END> this.resultContainerPanel.add(dataResultPanel, BorderLayout.CENTER); dataResultPanel.open(); customizeFXComponents(); controller.viewModeProperty().addListener((Observable observable) -> { switch (controller.getViewMode()) { case COUNTS: case DETAIL: SwingUtilities.invokeLater(() -> { splitYPane.remove(contentViewerContainerPanel); if ((lowerSplitXPane.getParent() == splitYPane) == false) { splitYPane.add(lowerSplitXPane); lowerSplitXPane.add(contentViewerContainerPanel); } }); break; case LIST: SwingUtilities.invokeLater(() -> { splitYPane.remove(lowerSplitXPane); splitYPane.add(contentViewerContainerPanel); dataResultPanel.setNode(null); }); break; default: throw new UnsupportedOperationException("Unknown ViewMode: " + controller.getViewMode()); } }); }</code><technical_language>tlrv is choice for a variable name</technical_language>

Target:
public TimeLineTopComponent(TimeLineController controller) { initComponents(); this.controller = controller; associateLookup(ExplorerUtils.createLookup(em, getActionMap())); setName(NbBundle.getMessage(TimeLineTopComponent.class, "CTL_TimeLineTopComponent")); setToolTipText(NbBundle.getMessage(TimeLineTopComponent.class, "HINT_TimeLineTopComponent")); setIcon(WindowManager.getDefault().getMainWindow().getIconImage()); dataContentPanel = DataContentPanel.createInstance(); this.contentViewerContainerPanel.add(dataContentPanel, BorderLayout.CENTER); tlResultView = new TimeLineResultView(controller, dataContentPanel); final DataResultPanel dataResultPanel = tlResultView.getDataResultPanel(); this.resultContainerPanel.add(dataResultPanel, BorderLayout.CENTER); dataResultPanel.open(); customizeFXComponents(); controller.viewModeProperty().addListener(viewMode -> { switch (controller.getViewMode()) { case COUNTS: case DETAIL: SwingUtilities.invokeLater(() -> { splitYPane.remove(contentViewerContainerPanel); if ((lowerSplitXPane.getParent() == splitYPane) == false) { splitYPane.add(lowerSplitXPane); lowerSplitXPane.add(contentViewerContainerPanel); } }); break; case LIST: SwingUtilities.invokeLater(() -> { splitYPane.remove(lowerSplitXPane); splitYPane.add(contentViewerContainerPanel); dataResultPanel.setNode(null); }); break; default: throw new UnsupportedOperationException("Unknown ViewMode: " + controller.getViewMode()); } }); }
Source:
<code><START> public TxKeyCacheSet(VisitableCommand rCommand, CacheSet<K> set, boolean isRemoteIteration, <END> InvocationContext rCtx) { super(Caches.getCacheWithFlags(TxInterceptor.this.cache, (FlagAffectedCommand) rCommand), set); this.isRemoteIteration = isRemoteIteration; this.rCtx = rCtx; }</code><technical_language>need for public, package local is good</technical_language>

Target:
TxKeyCacheSet(VisitableCommand rCommand, CacheSet<K> set, boolean isRemoteIteration, InvocationContext rCtx) { super(Caches.getCacheWithFlags(TxInterceptor.this.cache, (FlagAffectedCommand) rCommand), set); this.isRemoteIteration = isRemoteIteration; this.rCtx = rCtx; }
Source:
<code>private void replaceVariables(Node node) throws Exception { boolean failFast = false; List<ConfigReplacer> replacers = new ArrayList<ConfigReplacer>(); PropertyReplacer propertyReplacer = new PropertyReplacer(); propertyReplacer.init(properties); replacers.add(propertyReplacer); Node replacersNode = node.getAttributes().getNamedItem(ConfigSections.CONFIG_REPLACERS.name); if (replacersNode != null) { String failFastAttr = getAttribute(replacersNode, "fail-if-value-missing", true); <START> failFast = isNullOrEmpty(failFastAttr) ? true : Boolean.parseBoolean(failFastAttr); <END> for (Node n : childElements(replacersNode)) { String nodeName = cleanNodeName(n); if ("replacers".equals(nodeName)) { for (Node replacerNode : childElements(n)) { replacers.add(createReplacer(replacerNode)); } } } } ConfigReplacerHelper.traverseChildrenAndReplaceVariables(node, replacers, failFast); }</code><technical_language>isNullOrEmpty(failFastAttr) || Boolean.parseBoolean(failFastAttr)</technical_language>

Target:
private void replaceVariables(Node node) throws Exception { boolean failFast = false; List<ConfigReplacer> replacers = new ArrayList<ConfigReplacer>(); PropertyReplacer propertyReplacer = new PropertyReplacer(); propertyReplacer.init(properties); replacers.add(propertyReplacer); Node replacersNode = node.getAttributes().getNamedItem(ConfigSections.CONFIG_REPLACERS.name); if (replacersNode != null) { String failFastAttr = getAttribute(replacersNode, "fail-if-value-missing", true); failFast = isNullOrEmpty(failFastAttr) || Boolean.parseBoolean(failFastAttr); for (Node n : childElements(replacersNode)) { String nodeName = cleanNodeName(n); if ("replacers".equals(nodeName)) { for (Node replacerNode : childElements(n)) { replacers.add(createReplacer(replacerNode)); } } } } ConfigReplacerHelper.traverseChildrenAndReplaceVariables(node, replacers, failFast, new YamlDomVariableReplacer()); }
Source:
<code>public synchronized void setup() { ExecutorType type = ExecutorType.valueOf(executorType); switch (type) { case defaultEventExecutor: executor = new DefaultEventExecutor(); executorToShutdown = executor; break; case juc: executor = Executors.newSingleThreadScheduledExecutor(); executorToShutdown = executor; break; case nioEventLoop: NioEventLoopGroup group = new NioEventLoopGroup(1); <START> group.setIoRatio(1); <END> executor = group.next(); executorToShutdown = group; break; } }</code><technical_language>1 default is 50</technical_language>

Target:
public void setup() { ExecutorType type = ExecutorType.valueOf(executorType); switch (type) { case spinning: executor = new SpinExecutorService(Math.min(1024, burstLength * 4)); executorToShutdown = executor; break; case defaultEventExecutor: executor = new DefaultEventExecutor(); executorToShutdown = executor; break; case juc: executor = Executors.newSingleThreadScheduledExecutor(); executorToShutdown = executor; break; case nioEventLoop: NioEventLoopGroup nioEventLoopGroup = new NioEventLoopGroup(1); nioEventLoopGroup.setIoRatio(1); executor = nioEventLoopGroup.next(); executorToShutdown = nioEventLoopGroup; break; case epollEventLoop: Epoll.ensureAvailability(); EpollEventLoopGroup epollEventLoopGroup = new EpollEventLoopGroup(1); epollEventLoopGroup.setIoRatio(1); executor = epollEventLoopGroup.next(); executorToShutdown = epollEventLoopGroup; break; case kqueueEventLoop: KQueue.ensureAvailability(); KQueueEventLoopGroup kQueueEventLoopGroup = new KQueueEventLoopGroup(1); kQueueEventLoopGroup.setIoRatio(1); executor = kQueueEventLoopGroup.next(); executorToShutdown = kQueueEventLoopGroup; break; } }
Source:
<code>private List<String> getProcessedFileList(String processedFileTable, Date preProcessedDate) throws Exception { DataSetManager<KeyValueTable> dataSetManager = getDataset(processedFileTable); KeyValueTable table = dataSetManager.get(); <START> CloseableIterator<KeyValue<byte[], byte[]>> iterator = table.scan(null, null); <END> List<String> processedFileList = new ArrayList<String>(); while (iterator.hasNext()) { KeyValue<byte[], byte[]> keyValue = iterator.next(); Date date = new Date(Long.valueOf(new String(keyValue.getValue(), Charsets.UTF_8))); if (date.after(preProcessedDate)) { processedFileList.add(new String(keyValue.getKey(), Charsets.UTF_8)); } } return processedFileList; }</code><technical_language>try resources</technical_language>

Target:
private List<String> getProcessedFileList(String processedFileTable, Date preProcessedDate) throws Exception { List<String> processedFileList = new ArrayList<String>(); DataSetManager<KeyValueTable> dataSetManager = getDataset(processedFileTable); KeyValueTable table = dataSetManager.get(); try (CloseableIterator<KeyValue<byte[], byte[]>> iterator = table.scan(null, null)) { if (iterator != null) { while (iterator.hasNext()) { KeyValue<byte[], byte[]> keyValue = iterator.next(); Date date = new Date(Bytes.toLong(keyValue.getValue())); if (date.after(preProcessedDate)) { processedFileList.add(Bytes.toString(keyValue.getKey())); } } } } return processedFileList; }
Source:
<code>} catch (IOException e) { <START> Assumption.fail(e.toString()); <END> }</code><technical_language>e.toString() give root</technical_language>

Target:
} catch (IOException e) { Assumption.fail(TeammatesException.toStringWithStackTrace(e)); }
Source:
<code><START> protected Network findVnicNetwork() { <END> if (nic.getVnicProfileId() == null) { return null; } VnicProfile vnicProfile = getDbFacade().getVnicProfileDao().get(nic.getVnicProfileId()); if (vnicProfile == null) { validationResult = new ValidationResult(VdcBllMessages.ACTION_TYPE_FAILED_VNIC_PROFILE_NOT_EXISTS); return null; } return getNetworkByVnicProfile(vnicProfile); }</code><technical_language>This method is unneeded. functionality 'NetworkHelper.getNetworkByVnicProfileId(..)'. difference is check if profile exists. is a separate validation for it. other validations 'profileValid(..)' assume profile is valid</technical_language>

Target:
protected Network findVnicNetwork() { if (nic.getVnicProfileId() == null) { return null; } VnicProfile vnicProfile = findVnicProfile(); if (vnicProfile == null) { return null; } return getNetworkByVnicProfile(vnicProfile); }
Source:
<code>private void initChapters(@NonNull ArrayList<Chapter> chapters) { Chapter selectedChapter = null; if (getIntent().hasExtra(Const.EXTRA_CHAPTER_ID)) { final String chapterId = getIntent().getStringExtra(Const.EXTRA_CHAPTER_ID); for (Chapter c : chapters) { if (c.getGplusId().equals(chapterId)) { selectedChapter = c; break; } } } else if (getIntent().getData() != null && getIntent().getData().getScheme().equals("https")) { final String chapterId = getIntent().getData().getLastPathSegment(); <START> for (Chapter c : chapters) { <END> if (c.getGplusId().equals(chapterId)) { selectedChapter = c; break; } } } if (selectedChapter == null) { selectedChapter = chapters.get(0); } initChapters(chapters, selectedChapter); }</code><technical_language>is a duplicate code here. :smile: pull chapterId in [line 247](<LINK_0> above. check if exists in chapters array in 1 for loop</technical_language>

Target:
private void initChapters(@NonNull ArrayList<Chapter> chapters) { String chapterId = getChapterIdFromIntent(getIntent()); Chapter selectedChapter = null; if (chapterId != null) { for (Chapter c : chapters) { if (c.getGplusId().equals(chapterId)) { selectedChapter = c; break; } } } if (selectedChapter == null) { selectedChapter = chapters.get(0); } initChapters(chapters, selectedChapter); }
Source:
<code>public BakingActionResult checkActionIsApplicableInState(State state, String[] params) { BakingActionResult superResult = super.checkActionIsApplicableInState(state, params); if (!superResult.getIsSuccess()) { return superResult; } String containerName = params[1]; ObjectInstance container = state.getObject(params[1]); ObjectInstance grease = state.getObject(params[2]); if (!ContainerFactory.isEmptyContainer(container)) { return BakingActionResult.failure(containerName + " is not an empty container"); } if (!ContainerFactory.isBakingContainer(container)) { return BakingActionResult.failure(containerName + " is not an baking container"); } if (ContainerFactory.isGreasedContainer(container)) { return BakingActionResult.failure(containerName + " is not an greased container"); } if (!IngredientFactory.isLubricant(grease)) { <START> return BakingActionResult.failure(containerName + " is not an greased container"); <END> } return BakingActionResult.success(); }</code><technical_language>This failure related container, ingredient a lubricant! (not a fat, chicken grease!)</technical_language>

Target:
public BakingActionResult checkActionIsApplicableInState(State state, String[] params) { BakingActionResult superResult = super.checkActionIsApplicableInState(state, params); if (!superResult.getIsSuccess()) { return superResult; } String containerName = params[1]; ObjectInstance container = state.getObject(params[1]); String ingredientName = params[2]; ObjectInstance grease = state.getObject(params[2]); if (!ContainerFactory.isEmptyContainer(container)) { return BakingActionResult.failure(containerName + " is not an empty container"); } if (!ContainerFactory.isBakingContainer(container)) { return BakingActionResult.failure(containerName + " is not an baking container"); } if (ContainerFactory.isGreasedContainer(container)) { return BakingActionResult.failure(containerName + " is not an greasable container"); } if (!IngredientFactory.isLubricant(grease)) { return BakingActionResult.failure(ingredientName + " is not a suitable grease"); } return BakingActionResult.success(); }
Source:
<code>static public void writeErrors(JsonGenerator writer, List<Exception> exceptions) throws IOException { for (Exception e : exceptions) { StringWriter sw = new StringWriter(); e.printStackTrace(new PrintWriter(sw)); writer.writeStartObject(); String errorMessage = e.getLocalizedMessage(); if(e instanceof TreeReaderException) { <START> errorMessage += "\nPlease correct the format of your input file, or choose another" + <END> " importer type such as Line-based"; } writer.writeStringField("message", errorMessage); writer.writeStringField("stack", sw.toString()); writer.writeEndObject(); } }</code><technical_language>add 1 more new line separate error more in dialog stand out. Also, this get localized properly for translations support</technical_language>

Target:
static public void writeErrors(JsonGenerator writer, List<Exception> exceptions) throws IOException { for (Exception e : exceptions) { StringWriter sw = new StringWriter(); e.printStackTrace(new PrintWriter(sw)); writer.writeStartObject(); writer.writeStringField("message", e.getLocalizedMessage()); writer.writeStringField("stack", sw.toString()); writer.writeEndObject(); } }
Source:
<code>public long nextLong() { long s1 = this.seed0; final long s0 = this.seed1; this.seed0 = s0; s1 ^= s1 << 23; <START> return (this.seed1 = s1 ^ s0 ^ (s1 >>> 17) ^ (s0 >>> 26)) + s0; <END> }</code><technical_language>separate this statements readability? this: this.seed1 = s1 ^ s0 ^ (s1 >>> 17) ^ (s0 >>> 26); return this.seed1 + s0; Feel free drop this if needed</technical_language>

Target:
public long nextLong() { long s1 = seed0; final long s0 = seed1; seed0 = s0; s1 ^= s1 << 23; seed1 = s1 ^ s0 ^ (s1 >>> 17) ^ (s0 >>> 26); return seed1 + s0; }