auphong2707/dl4se-code-review-dataset huggingface dataset:
Source:
<code>public Page<AuthorizationRest> findByObject(@Parameter(value = "uri", required = true) String uri, @Parameter(value = "eperson") UUID epersonUuid, Pageable pageable) throws AuthorizeException, SQLException { Context context = obtainContext(); BaseObjectRest obj = utils.getBaseObjectRestFromUri(context, uri); if (obj == null) { return null; } EPerson currUser = context.getCurrentUser(); EPerson user = getUserFromRequestParameter(context, epersonUuid); context.setCurrentUser(user); List<AuthorizationFeature> features = authorizationFeatureService.findByResourceType(obj.getUniqueType()); List<Authorization> authorizations = new ArrayList<Authorization>(); for (AuthorizationFeature f : features) { <START> if (authorizationFeatureService.isAuthorized(context, f, obj)) { <END> authorizations.add(new Authorization(user, f, obj)); } } context.setCurrentUser(currUser); return converter.toRestPage(utils.getPage(authorizations, pageable), utils.obtainProjection()); }</code><technical_language>Similar above, check impact of special groups</technical_language>

Target:
public Page<AuthorizationRest> findByObject(@Parameter(value = "uri", required = true) String uri, @Parameter(value = "eperson") UUID epersonUuid, Pageable pageable) throws AuthorizeException, SQLException { Context context = obtainContext(); BaseObjectRest obj = utils.getBaseObjectRestFromUri(context, uri); if (obj == null) { return null; } EPerson currUser = context.getCurrentUser(); EPerson user = getUserFromRequestParameter(context, epersonUuid); if (currUser != user) { context.switchContextUser(user); } List<AuthorizationFeature> features = authorizationFeatureService.findByResourceType(obj.getUniqueType()); List<Authorization> authorizations = new ArrayList<Authorization>(); for (AuthorizationFeature f : features) { if (authorizationFeatureService.isAuthorized(context, f, obj)) { authorizations.add(new Authorization(user, f, obj)); } } if (currUser != user) { context.restoreContextUser(); } return converter.toRestPage(utils.getPage(authorizations, pageable), utils.obtainProjection()); }
Source:
<code>public void shouldThrowExceptionWithBadMethodName() throws Exception { MyActivity myActivity = buildActivity(MyActivity.class).create().get(); <START> RoboAttributeSet attrs = shadowOf(RuntimeEnvironment.application).createAttributeSet( <END> new Attribute("android:onClick", "clickYou", R.class.getPackage().getName()) ); view = new View(myActivity, attrs); view.performClick(); }</code><technical_language>Prefer ShadowApplication.getInstance() I think, apply throughout</technical_language>

Target:
public void shouldThrowExceptionWithBadMethodName() throws Exception { MyActivity myActivity = buildActivity(MyActivity.class).create().get(); RoboAttributeSet attrs = ShadowApplication.getInstance().createAttributeSet( new Attribute("android:onClick", "clickYou", R.class.getPackage().getName()) ); view = new View(myActivity, attrs); view.performClick(); }
Source:
<code>public Queues createOrPropagate(Throwable t) throws Exception { return valOnNotFoundOr404(Queues.EMPTY, <START> checkNotNull(t, "throwable")); <END> }</code><technical_language>[minor] this fit line</technical_language>

Target:
public Queues createOrPropagate(Throwable t) throws Exception { if ((getFirstThrowableOfType(checkNotNull(t, "throwable"), ResourceNotFoundException.class) != null) || contains404(t)) { return Queues.EMPTY; } throw propagate(t); }
Source:
<code>public DataSet< V> union(DataSet<V> dataSet, OperationContext operationContext, String name, boolean pushScope, String scopeDetail) { pushScopeIfNeeded((SpliceFunction)null, pushScope, scopeDetail); try { <START> Dataset rdd1 = dataset.union(((NativeSparkDataSet) dataSet).dataset); <END> return new NativeSparkDataSet<>(rdd1, operationContext); } finally { if (pushScope) SpliceSpark.popScope(); } }</code><technical_language>want convert NativeDataSet, similar intersect</technical_language>

Target:
public DataSet< V> union(DataSet<V> dataSet, OperationContext operationContext, String name, boolean pushScope, String scopeDetail) { pushScopeIfNeeded((SpliceFunction)null, pushScope, scopeDetail); try { Dataset right = getDataset(dataSet); Dataset rdd1 = dataset.union(right); return new NativeSparkDataSet<>(rdd1, operationContext); } catch (Exception se){ throw new RuntimeException(se); } finally { if (pushScope) SpliceSpark.popScope(); } }
Source:
<code>public List<String> tabComplete(CommandSender sender, String alias, String[] args) throws IllegalArgumentException { if (args.length == 1) { return StringUtil.copyPartialMatches(args[0], BAN_TYPES, new ArrayList(BAN_TYPES_SIZE)); } <START> return super.tabComplete(sender, alias, args); <END> }</code><technical_language>I this return Collections.emptyList() if args.length is 1 (this remove player auto-completion, is necessary here)</technical_language>

Target:
public List<String> tabComplete(CommandSender sender, String alias, String[] args) throws IllegalArgumentException { if (args.length == 1) { return StringUtil.copyPartialMatches(args[0], BAN_TYPES, new ArrayList(BAN_TYPES.size())); } else { return args.length == 0 ? super.tabComplete(sender, alias, args) : Collections.emptyList(); } }
Source:
<code>protected Properties createProducerConfigs() { Properties producerProps = new Properties(); producerProps.setProperty(CommonClientConfigs.BOOTSTRAP_SERVERS_CONFIG, bootstrapServers()); <START> producerProps.setProperty(KEY_SERIALIZER_CLASS_CONFIG, STRING_SERIALIZER); <END> producerProps.setProperty(VALUE_SERIALIZER_CLASS_CONFIG, STRING_SERIALIZER); return producerProps; }</code><technical_language>implement this calling super.createProducerConfigs, override serializers? for createConsumerConfigs</technical_language>

Target:
protected Properties createProducerConfigs() { Properties producerProps = super.createProducerConfigs(); producerProps.setProperty(KEY_SERIALIZER_CLASS_CONFIG, STRING_SERIALIZER); producerProps.setProperty(VALUE_SERIALIZER_CLASS_CONFIG, STRING_SERIALIZER); return producerProps; }
Source:
<code>String invoke(RequestContext reqctx, MethodInfo mi) { final Class[] argTypes = mi.method.getParameterTypes(); final Object[] args = mi.arguments; if (reqctx != null) { for (int j = 0; j < args.length; ++j) if (ServletRequest.class.isAssignableFrom(argTypes[j])) args[j] = reqctx.request; else if (ServletResponse.class.isAssignableFrom(argTypes[j])) args[j] = reqctx.response; else if (ServletContext.class.isAssignableFrom(argTypes[j])) args[j] = getServletContext(); } try { Object o = mi.method.invoke(null, args); return o instanceof String ? (String) o : ""; } catch (Throwable ex) { log.error("Unable to invoke " + mi.method, ex); return ""; } finally { <START> mi.arguments = new Object[0]; <END> } }</code><technical_language>null safe in line 131</technical_language>

Target:
String invoke(RequestContext reqctx, MethodInfo mi) { final Class[] argTypes = mi.method.getParameterTypes(); final Object[] args = mi.arguments; if (reqctx != null) { for (int j = 0; j < args.length; ++j) if (ServletRequest.class.isAssignableFrom(argTypes[j])) args[j] = reqctx.request; else if (ServletResponse.class.isAssignableFrom(argTypes[j])) args[j] = reqctx.response; else if (ServletContext.class.isAssignableFrom(argTypes[j])) args[j] = getServletContext(); } try { Object o = mi.method.invoke(null, args); return o instanceof String ? (String) o : ""; } catch (Throwable ex) { log.error("Unable to invoke " + mi.method, ex); return ""; } finally { Arrays.fill(mi.arguments, null); } }
Source:
<code>public void start(@SuppressWarnings("rawtypes") Observable[] os, AtomicLong requested) { <START> Object[] observers = new Object[os.length]; <END> for (int i = 0; i < os.length; i++) { InnerSubscriber io = new InnerSubscriber(); observers[i] = io; childSubscription.add(io); } this.requested = requested; this.observers = observers; for (int i = 0; i < os.length; i++) { os[i].unsafeSubscribe((InnerSubscriber) observers[i]); } }</code><technical_language>final name please avoid misusage mistake</technical_language>

Target:
public void start(@SuppressWarnings("rawtypes") Observable[] os, AtomicLong requested) { final Object[] subscribers = new Object[os.length]; for (int i = 0; i < os.length; i++) { InnerSubscriber io = new InnerSubscriber(); subscribers[i] = io; childSubscription.add(io); } this.requested = requested; this.subscribers = subscribers; for (int i = 0; i < os.length; i++) { os[i].unsafeSubscribe((InnerSubscriber) subscribers[i]); } }
Source:
<code>private void onChunkOperationComplete(GetChunk chunk) { if (chunk.getChunkException() != null) { setOperationException(chunk.getChunkException()); } if (chunk == firstChunk) { if (operationCallbackInvoked.compareAndSet(false, true)) { Exception e = getOperationException(); if (options.getChunkIdsOnly) { operationCompleted = true; List<StoreKey> chunkIds = e == null && compositeBlobInfo != null ? compositeBlobInfo.getKeys() : null; <START> operationResult = new GetBlobResultInternal(new GetBlobResult(blobInfo, blobDataChannel, chunkIds), chunkIds); END> } else { long timeElapsed = time.milliseconds() - submissionTimeMs; routerMetrics.getBlobOperationLatencyMs.update(timeElapsed); if (e == null) { blobDataChannel = new BlobDataReadableStreamChannel(); operationResult = new GetBlobResultInternal(new GetBlobResult(blobInfo, blobDataChannel), null); } else { blobDataChannel = null; operationResult = null; routerMetrics.onGetBlobError(e, options); } } NonBlockingRouter.completeOperation(null, getOperationCallback, operationResult, e); } } chunk.postCompletionCleanup(); if (blobDataChannel != null) { blobDataChannel.maybeWriteToChannel(); } }</code><technical_language>need GetBlobResultInternal anymore if GetBlobResult contains chunk IDs</technical_language>

Target:
private void onChunkOperationComplete(GetChunk chunk) { if (chunk.getChunkException() != null) { setOperationException(chunk.getChunkException()); } if (chunk == firstChunk) { if (operationCallbackInvoked.compareAndSet(false, true)) { Exception e = getOperationException(); if (options.getChunkIdsOnly) { operationCompleted = true; List<StoreKey> chunkIds = e == null && compositeBlobInfo != null ? compositeBlobInfo.getKeys() : null; operationResult = new GetBlobResultInternal(new GetBlobResult(blobInfo, chunkIds), chunkIds); } else { long timeElapsed = time.milliseconds() - submissionTimeMs; routerMetrics.getBlobOperationLatencyMs.update(timeElapsed); if (e == null) { blobDataChannel = new BlobDataReadableStreamChannel(); operationResult = new GetBlobResultInternal(new GetBlobResult(blobInfo, blobDataChannel), null); } else { blobDataChannel = null; operationResult = null; routerMetrics.onGetBlobError(e, options); } } NonBlockingRouter.completeOperation(null, getOperationCallback, operationResult, e); } } chunk.postCompletionCleanup(); if (blobDataChannel != null) { blobDataChannel.maybeWriteToChannel(); } }
Source:
<code>public void init() { paletteDefinitionBuilder <START> .itemFilter(defId -> true) <END> .categoryFilter(category -> !EXCLUDED_CATEGORIES.contains(category)); }</code><technical_language>AbstractPaletteDefinitionBuilder#initDefaults I this line omitted</technical_language>

Target:
public void init() { paletteDefinitionBuilder .categoryFilter(category -> !EXCLUDED_CATEGORIES.contains(category)); }
Source:
<code><START> public Map<String, String> thumbnails() { <END> return thumbnail; }</code><technical_language>Consider Integer Uri map instead. I Gson handle default now. If want avoid a null check, check for null in constructor initialize empty map</technical_language>

Target:
public Map<String, Uri> thumbnails() { return thumbnail; }
Source:
<code>public void testPurgeExpired() throws Exception { long lifespan = 6000; long idle = 4000; InternalCacheEntry ice1 = TestInternalCacheEntryFactory.create("k1", "v1", lifespan); cl.write(marshalledEntry(ice1, getMarshaller())); InternalCacheEntry ice2 = TestInternalCacheEntryFactory.create("k2", "v2", -1, idle); cl.write(marshalledEntry(ice2, getMarshaller())); InternalCacheEntry ice3 = TestInternalCacheEntryFactory.create("k3", "v3", lifespan, idle); cl.write(marshalledEntry(ice3, getMarshaller())); InternalCacheEntry ice4 = TestInternalCacheEntryFactory.create("k4", "v4", -1, -1); cl.write(marshalledEntry(ice4, getMarshaller())); InternalCacheEntry ice5 = TestInternalCacheEntryFactory.create("k5", "v5", lifespan * 1000, idle * 1000); cl.write(marshalledEntry(ice5, getMarshaller())); assert cl.contains("k1"); assert cl.contains("k2"); assert cl.contains("k3"); assert cl.contains("k4"); assert cl.contains("k5"); Thread.sleep(lifespan + 10); HashSet<String> expiredKeys = new HashSet<String>(); expiredKeys.add("k1"); expiredKeys.add("k2"); <START> expiredKeys.add("k3"); <END> purgeExpired(Collections.unmodifiableSet(expiredKeys), 1000); for (String key : expiredKeys) { assertFalse(cl.contains(key)); } assert cl.contains("k4"); assert cl.contains("k5"); }</code><technical_language>new HashSet<String>(Arrays.asList("k1", "k2", "k3"))</technical_language>

Target:
public void testPurgeExpired() throws Exception { long lifespan = 6000; long idle = 4000; InternalCacheEntry ice1 = TestInternalCacheEntryFactory.create("k1", wrap("k1", "v1"), lifespan); cl.write(marshalledEntry(ice1, getMarshaller())); InternalCacheEntry ice2 = TestInternalCacheEntryFactory.create("k2", wrap("k2", "v2"), -1, idle); cl.write(marshalledEntry(ice2, getMarshaller())); InternalCacheEntry ice3 = TestInternalCacheEntryFactory.create("k3", wrap("k3", "v3"), lifespan, idle); cl.write(marshalledEntry(ice3, getMarshaller())); InternalCacheEntry ice4 = TestInternalCacheEntryFactory.create("k4", wrap("k4", "v4"), -1, -1); cl.write(marshalledEntry(ice4, getMarshaller())); InternalCacheEntry ice5 = TestInternalCacheEntryFactory.create("k5", wrap("k5", "v5"), lifespan * 1000, idle * 1000); cl.write(marshalledEntry(ice5, getMarshaller())); assert cl.contains("k1"); assert cl.contains("k2"); assert cl.contains("k3"); assert cl.contains("k4"); assert cl.contains("k5"); Thread.sleep(lifespan + 10); HashSet<String> expiredKeys = new HashSet<String>(Arrays.asList("k1", "k2", "k3")); purgeExpired(Collections.unmodifiableSet(expiredKeys), 1000); for (String key : expiredKeys) { assertFalse(cl.contains(key)); } assert cl.contains("k4"); assert cl.contains("k5"); }
Source:
<code>private Constructor<E> getEntityConstructor() { final Class<E> entityClass = getEntityClass(); final Class<I> idClass = getIdClass(); try { final Constructor<E> result = entityClass.getDeclaredConstructor(idClass); checkConstructorAccessModifier(result.getModifiers(), entityClass.getSimpleName()); return result; } catch (NoSuchMethodException ignored) { <START> throw noSuchConstructorException(entityClass.getSimpleName()); <END> } }</code><technical_language>short class name confusing. cases of large applications name of things, in bounded contexts. E.g. consider "Order" for in parts of a larger app deal kinds of orders. Please pass FQN</technical_language>

Target:
private Constructor<E> getEntityConstructor() { final Class<E> entityClass = getEntityClass(); final Class<I> idClass = getIdClass(); try { final Constructor<E> result = entityClass.getDeclaredConstructor(idClass); checkConstructorAccessModifier(result.getModifiers(), entityClass.getName()); return result; } catch (NoSuchMethodException ignored) { throw noSuchConstructorException(entityClass.getName(), idClass.getName()); } }
Source:
<code><START> public ApprovalsUtil(ReviewDb <END> db) { this.db = db; }</code><technical_language>This longer needs public, for MergeOp</technical_language>

Target:
ApprovalsUtil(ReviewDb db) { this.db = db; }
Source:
<code>public void privateSubscriber() throws Exception { thrown.expect(IllegalArgumentException.class); thrown.expectMessage("Event Subscriber class needs to be public"); bus.register(new PrivateSubscriber()); <START> TestEvent e = new TestEvent(); <END> bus.post(e); }</code><technical_language>of error cases need post events</technical_language>

Target:
public void privateSubscriber() throws Exception { thrown.expect(IllegalArgumentException.class); thrown.expectMessage("Event Subscriber class com.cloudant.sync.event.EventBusTest$PrivateSubscriber needs to be public"); bus.register(new PrivateSubscriber()); }
Source:
<code>public void getBytes(int index, OutputStream out, int length) throws IOException { checkIndexLength(index, length); if (hasBackingByteArray()) { <START> out.write(backingByteArray(), (backingByteArrayOffset() + index), length); <END> return; } byte[] buffer = new byte[4096]; while (length > 0) { int size = min(buffer.length, length); getBytes(index, buffer, 0, size); out.write(buffer, 0, size); length -= size; index += size; } }</code><technical_language>Nit: need for parenthesis</technical_language>

Target:
public void getBytes(int index, OutputStream out, int length) throws IOException { checkIndexLength(index, length); if (hasByteArray()) { out.write(byteArray(), byteArrayOffset() + index, length); return; } byte[] buffer = new byte[4096]; while (length > 0) { int size = min(buffer.length, length); getBytes(index, buffer, 0, size); out.write(buffer, 0, size); length -= size; index += size; } }
Source:
<code>public void createDirectory(ServiceInvocationContext context, List<PathFragment> pathWithRoot, String name){ Object object = GenericTreeStatefulService.getNodeByPathFor(pathWithRoot, null); String path = ((Pair<File, Object>)object).a.getPath() + "\\" + name; <START> if(true){ <END> } File theDir = new File(path); if (!theDir.exists()) { boolean result = theDir.mkdir(); if(!result) { } }else { context.getCommunicationChannel().appendCommandToCurrentHttpResponse( new DisplaySimpleMessageClientCommand(WebPlugin.getInstance().getMessage("explorer.createDirectory.error.title"), WebPlugin.getInstance().getMessage( "explorer.createDirectory.error.alreadyExists"), DisplaySimpleMessageClientCommand.ICON_ERROR)); } }</code><technical_language>garbage</technical_language>

Target:
public void createDirectory(ServiceInvocationContext context, List<PathFragment> pathWithRoot, String name) { GenericTreeStatefulService service = GenericTreeStatefulService .getServiceFromPathWithRoot(pathWithRoot); String clientID = GenericTreeStatefulService.getClientIDFromPathWithRoot(pathWithRoot); Object object = GenericTreeStatefulService.getNodeByPathFor( pathWithRoot, null); @SuppressWarnings("unchecked") String path = ((Pair<File, Object>) object).a.getPath() + "\\" + name; File theDir = new File(path); if (!theDir.exists()) { boolean result = theDir.mkdirs(); if (result) { expandNodesAfterCreate(context, service, clientID, object, theDir, name); FileEvent event = new FileEvent(theDir, FileEvent.FILE_CREATED); CommonPlugin.getInstance().getFileEventDispatcher() .dispatch(event); } else { printMessageToUser(context, "explorer.createDirectory.error.title", "explorer.createDirectory.error.couldNotCreate"); } } else if(theDir.isFile()) { printMessageToUser(context, "explorer.createDirectory.error.title", "explorer.createDirectory.error.alreadyExistsAsFile"); } else { printMessageToUser(context, "explorer.createDirectory.error.title", "explorer.createDirectory.error.alreadyExists"); } }
Source:
<code>private void writeRegionIndex() throws IOException { if (Arrays.stream(subpartitionBytes).sum() > 0) { for (int subpartition = 0; subpartition < numSubpartitions; ++subpartition) { if (!indexBuffer.hasRemaining()) { flushIndexBuffer(); indexBuffer.clear(); canCacheAllIndexData = false; } indexBuffer.putLong(totalBytesWritten); <START> indexBuffer.putInt(subpartitionBuffers[subpartition]); <END> totalBytesWritten += subpartitionBytes[subpartition]; } ++numRegions; currentSubpartition = 0; Arrays.fill(subpartitionBytes, 0); Arrays.fill(subpartitionBuffers, 0); } }</code><technical_language>I guess current assumes data redistributed in subpartitions for flush call. If in data skew scenario 10 of 1000 subpartitions actual data for some flush, index buffer written empty holes waste space execution time. I curious is design write subpartitions in sequence I touched detail logics view reader side? is performance sensitive for easy implementation ATM</technical_language>

Target:
private void writeRegionIndex() throws IOException { if (Arrays.stream(subpartitionBuffers).sum() > 0) { for (int channel = 0; channel < numSubpartitions; ++channel) { writeIndexEntry(subpartitionOffsets[channel], subpartitionBuffers[channel]); } currentSubpartition = -1; ++numRegions; Arrays.fill(subpartitionBuffers, 0); } }
Source:
<code>public void testTransaction() throws RemoteException, SystemException { <START> log.info("Method stateful #testTransaction called"); <END> Transaction txn; txn = tm.getTransaction(); TxTestUtil.enlistTestXAResource(txn); TxTestUtil.enlistTestXAResource(txn); }</code><technical_language>log.tracef</technical_language>

Target:
public void testTransaction() throws RemoteException, SystemException { log.trace("Method stateful #testTransaction called"); Transaction txn; txn = tm.getTransaction(); TxTestUtil.enlistTestXAResource(txn); TxTestUtil.enlistTestXAResource(txn); }
Source:
<code>public void testGenerateSingleTypedefEnum() throws IOException, ParserException, ResponseTypeNotFoundException, TypeRenamingConflictException { final String inputSpecFile = "/input/TypedefEnum.xml"; final TestFileUtilsImpl fileUtils = new TestFileUtilsImpl(); final Ds3SpecParser parser = new Ds3SpecParserImpl(); final Ds3ApiSpec spec = parser.getSpec(CCodeGenerator_Test.class.getResourceAsStream(inputSpecFile)); final CCodeGenerator codeGenerator = new CCodeGenerator(); <START> try { <END> final Header header = new Header(CCodeGenerator.getAllEnums(spec), CCodeGenerator.getAllStructs(spec), CCodeGenerator.getAllRequests(spec)); codeGenerator.processTemplate(header, "TypedefEnum.ftl", fileUtils.getOutputStream()); final ByteArrayOutputStream bstream = (ByteArrayOutputStream) fileUtils.getOutputStream(); final String output = new String(bstream.toByteArray()); LOG.info("Generated code:\n" + output); assertTrue(output.contains("typedef enum {")); assertTrue(output.contains(" IN_PROGRESS,")); assertTrue(output.contains(" COMPLETED,")); assertTrue(output.contains(" CANCELED")); assertFalse(output.contains(" CANCELED,")); assertTrue(output.contains("}ds3_job_status;")); } catch (final ParseException e) { LOG.error("Error parsing " + inputSpecFile, e); } }</code><technical_language>Remove try catch here</technical_language>

Target:
public void testGenerateSingleTypedefEnum() throws IOException, ParserException, ResponseTypeNotFoundException, TypeRenamingConflictException, ParseException { final String inputSpecFile = "/input/TypedefEnum.xml"; final TestFileUtilsImpl fileUtils = new TestFileUtilsImpl(); final Ds3SpecParser parser = new Ds3SpecParserImpl(); final Ds3ApiSpec spec = parser.getSpec(CCodeGenerator_Test.class.getResourceAsStream(inputSpecFile)); final CCodeGenerator codeGenerator = new CCodeGenerator(); final Header header = new Header(CCodeGenerator.getAllEnums(spec), CCodeGenerator.getAllStructs(spec), CCodeGenerator.getAllRequests(spec)); codeGenerator.processTemplate(header, "TypedefEnum.ftl", fileUtils.getOutputStream()); final ByteArrayOutputStream bstream = (ByteArrayOutputStream) fileUtils.getOutputStream(); final String output = new String(bstream.toByteArray()); LOG.info("Generated code:\n" + output); assertTrue(output.contains("typedef enum {")); assertTrue(output.contains(" IN_PROGRESS,")); assertTrue(output.contains(" COMPLETED,")); assertTrue(output.contains(" CANCELED")); assertFalse(output.contains(" CANCELED,")); assertTrue(output.contains("}ds3_job_status;")); }
Source:
<code>private void analyzeCreateDatabase(ASTNode ast) throws SemanticException { String dbName = unescapeIdentifier(ast.getChild(0).getText()); boolean ifNotExists = false; String dbComment = null; String dbLocation = null; Map<String, String> dbProps = null; for (int i = 1; i < ast.getChildCount(); i++) { ASTNode childNode = (ASTNode) ast.getChild(i); switch (childNode.getToken().getType()) { case HiveParser.TOK_IFNOTEXISTS: ifNotExists = true; break; case HiveParser.TOK_DATABASECOMMENT: dbComment = unescapeSQLString(childNode.getChild(0).getText()); break; case TOK_DATABASEPROPERTIES: dbProps = DDLSemanticAnalyzer.getProps((ASTNode) childNode.getChild(0)); break; case TOK_DATABASELOCATION: dbLocation = unescapeSQLString(childNode.getChild(0).getText()); addLocationToOutputs(dbLocation); break; default: throw new SemanticException("Unrecognized token in CREATE DATABASE statement"); } } CreateDatabaseDesc createDatabaseDesc = <START> new CreateDatabaseDesc(dbName, dbComment, dbLocation, ifNotExists, new ReplicationSpec()); <END> if (dbProps != null) { createDatabaseDesc.setDatabaseProperties(dbProps); } Database database = new Database(dbName, dbComment, dbLocation, dbProps); outputs.add(new WriteEntity(database, WriteEntity.WriteType.DDL_NO_LOCK)); rootTasks.add(TaskFactory.get(new DDLWork(getInputs(), getOutputs(), createDatabaseDesc), conf)); }</code><technical_language>remove argument</technical_language>

Target:
private void analyzeCreateDatabase(ASTNode ast) throws SemanticException { String dbName = unescapeIdentifier(ast.getChild(0).getText()); boolean ifNotExists = false; String dbComment = null; String dbLocation = null; Map<String, String> dbProps = null; for (int i = 1; i < ast.getChildCount(); i++) { ASTNode childNode = (ASTNode) ast.getChild(i); switch (childNode.getToken().getType()) { case HiveParser.TOK_IFNOTEXISTS: ifNotExists = true; break; case HiveParser.TOK_DATABASECOMMENT: dbComment = unescapeSQLString(childNode.getChild(0).getText()); break; case TOK_DATABASEPROPERTIES: dbProps = DDLSemanticAnalyzer.getProps((ASTNode) childNode.getChild(0)); break; case TOK_DATABASELOCATION: dbLocation = unescapeSQLString(childNode.getChild(0).getText()); addLocationToOutputs(dbLocation); break; default: throw new SemanticException("Unrecognized token in CREATE DATABASE statement"); } } CreateDatabaseDesc createDatabaseDesc = new CreateDatabaseDesc(dbName, dbComment, dbLocation, ifNotExists); if (dbProps != null) { createDatabaseDesc.setDatabaseProperties(dbProps); } Database database = new Database(dbName, dbComment, dbLocation, dbProps); outputs.add(new WriteEntity(database, WriteEntity.WriteType.DDL_NO_LOCK)); rootTasks.add(TaskFactory.get(new DDLWork(getInputs(), getOutputs(), createDatabaseDesc), conf)); }
Source:
<code>private Message receiveForReply(final String queueName, Channel channel, Message receiveMessage) throws Exception { boolean channelTransacted = isChannelTransacted(); boolean channelLocallyTransacted = isChannelLocallyTransacted(channel); if (RabbitTemplate.this.receiveTimeout == 0) { GetResponse response = channel.basicGet(queueName, !channelTransacted); if (response != null) { long deliveryTag1 = response.getEnvelope().getDeliveryTag(); if (channelLocallyTransacted) { channel.basicAck(deliveryTag1, false); } else if (channelTransacted) { ConnectionFactoryUtils.registerDeliveryTag(getConnectionFactory(), channel, deliveryTag1); } receiveMessage = buildMessageFromResponse(response); } } else { CompletableFuture<Delivery> future = new CompletableFuture<>(); <START> long timeoutMillis = this.receiveTimeout; <END> Delivery delivery = getDeliveryAndCancelConsumer(channel, future, createConsumer(queueName, channel, future), timeoutMillis); if (delivery != null) { long deliveryTag2 = delivery.getEnvelope().getDeliveryTag(); if (channelTransacted && !channelLocallyTransacted) { ConnectionFactoryUtils.registerDeliveryTag(getConnectionFactory(), channel, deliveryTag2); } else { channel.basicAck(deliveryTag2, false); } receiveMessage = buildMessageFromDelivery(delivery); } } logReceived(receiveMessage); return receiveMessage; }</code><technical_language>is reason in this variable? Thanks</technical_language>

Target:
private Message receiveForReply(final String queueName, Channel channel, Message receiveMessage) throws Exception { boolean channelTransacted = isChannelTransacted(); boolean channelLocallyTransacted = isChannelLocallyTransacted(channel); if (RabbitTemplate.this.receiveTimeout == 0) { GetResponse response = channel.basicGet(queueName, !channelTransacted); if (response != null) { long deliveryTag1 = response.getEnvelope().getDeliveryTag(); if (channelLocallyTransacted) { channel.basicAck(deliveryTag1, false); } else if (channelTransacted) { ConnectionFactoryUtils.registerDeliveryTag(getConnectionFactory(), channel, deliveryTag1); } receiveMessage = buildMessageFromResponse(response); } } else { Delivery delivery = consumeDelivery(channel, queueName, this.receiveTimeout); if (delivery != null) { long deliveryTag2 = delivery.getEnvelope().getDeliveryTag(); if (channelTransacted && !channelLocallyTransacted) { ConnectionFactoryUtils.registerDeliveryTag(getConnectionFactory(), channel, deliveryTag2); } else { channel.basicAck(deliveryTag2, false); } receiveMessage = buildMessageFromDelivery(delivery); } } logReceived(receiveMessage); return receiveMessage; }
Source:
<code>public void testCollectRows() throws Exception { List<Row> rows = Arrays.asList(new Row1(10), new Row1(20)); Supplier<BatchIterator<Row>> batchIteratorSupplier = () -> InMemoryBatchIterator.of(rows, SentinelRow.SENTINEL, <START> true); <END> BatchIteratorTester tester = new BatchIteratorTester(batchIteratorSupplier); List<Object[]> expectedResult = Arrays.asList(new Object[]{10}, new Object[]{20}); tester.verifyResultAndEdgeCaseBehaviour(expectedResult); }</code><technical_language>here, this involveIO</technical_language>

Target:
public void testCollectRows() throws Exception { List<Row> rows = Arrays.asList(new Row1(10), new Row1(20)); Supplier<BatchIterator<Row>> batchIteratorSupplier = () -> InMemoryBatchIterator.of(rows, SentinelRow.SENTINEL, false); BatchIteratorTester tester = new BatchIteratorTester(batchIteratorSupplier); List<Object[]> expectedResult = Arrays.asList(new Object[]{10}, new Object[]{20}); tester.verifyResultAndEdgeCaseBehaviour(expectedResult); }
Source:
<code><START> public RowInsertionBuilder value(final int columnIndex, final Object value) { <END> values.set(columnIndex, value); return this; }</code><technical_language>extend abstract class here, need override methods. Is some special reason for that? I worry new method addition forgotten abstract class'es methods</technical_language>

Target:
public RowInsertionBuilder value(final int columnIndex, final Object value) { return value(columnIndex, value, null); }
Source:
<code>public CONTENT extract(RoviProgramLine roviLine) { CONTENT content = createContent(); content.setTitle(roviLine.getLongTitle()); content.setCanonicalUri(canonicalUriForProgram(roviLine.getProgramId())); content.setPublisher(getPublisherForLanguage(roviLine.getLanguage())); content.setLanguages(Sets.newHashSet(roviLine.getLanguage())); if (roviLine.getReleaseYear().isPresent()) { content.setYear(roviLine.getReleaseYear().get()); } Optional<String> descriptionCulture = Optional.absent(); try { <START> descriptionCulture = setDescriptionAndGetCulture(content, roviLine); <END> } catch (IOException e) { log().error("Error while trying to populate the description for program " + roviLine.getKey(), e); } content.setPublisher(getPublisherForLanguageAndCulture(roviLine.getLanguage(), descriptionCulture)); setParentIfNeeded(roviLine, content); createVersionIfNeeded(content, roviLine); CONTENT extracted = addSpecificData(content, roviLine); log().trace("Extracted with canonical uri {}", extracted.getClass().getName(), extracted.getCanonicalUri()); return extracted; }</code><technical_language>If reading this correctly this continues if failed set descriptions Content means unset extracted content is written. extraction of this content aborted potentially entire task too, of IOException remedied</technical_language>

Target:
public CONTENT extract(RoviProgramLine roviLine) throws IndexAccessException { CONTENT content = createContent(); content.setTitle(roviLine.getLongTitle()); content.setCanonicalUri(canonicalUriForProgram(roviLine.getProgramId())); content.setPublisher(getPublisherForLanguage(roviLine.getLanguage())); content.setLanguages(Sets.newHashSet(roviLine.getLanguage())); if (roviLine.getReleaseYear().isPresent()) { content.setYear(roviLine.getReleaseYear().get()); } Optional<String> descriptionCulture = Optional.absent(); descriptionCulture = setDescriptionAndGetCulture(content, roviLine); content.setPublisher(getPublisherForLanguageAndCulture(roviLine.getLanguage(), descriptionCulture)); setParentIfNeeded(roviLine, content); createVersionIfNeeded(content, roviLine); CONTENT extracted = addSpecificData(content, roviLine); log().trace("Extracted with canonical uri {}", extracted.getClass().getName(), extracted.getCanonicalUri()); return extracted; }
Source:
<code>public void retract(FirstLastValueWithRetractAccumulator<T> acc, Object value, Long order) throws Exception { if (value != null) { T v = (T) value; List<Long> orderList = acc.valueToOrderMap.get(v); if (orderList != null && orderList.size() > 0) { orderList.remove(0); if (orderList.isEmpty()) { acc.valueToOrderMap.remove(v); } else { acc.valueToOrderMap.put(v, orderList); } } else { List<Long> retractOrderList = acc.valueToOrderRetractMap.get(v); if (retractOrderList == null) { retractOrderList = new ArrayList<>(); } retractOrderList.add(order); acc.valueToOrderRetractMap.put(v, retractOrderList); } List<T> valueList = acc.orderToValueMap.get(order); <START> int index = -1; <END> if (valueList != null && (index = valueList.indexOf(v)) >= 0) { valueList.remove(index); if (valueList.isEmpty()) { acc.orderToValueMap.remove(order); } else { acc.orderToValueMap.put(order, valueList); } } else { List<T> retractValueList = acc.orderToValueRetractMap.get(order); if (retractValueList == null) { retractValueList = new ArrayList<>(); } retractValueList.add(v); acc.orderToValueRetractMap.put(order, retractValueList); } if (v.equals(acc.value)) { updateValue(acc); } } }</code><technical_language>suggestion int index;</technical_language>

Target:
public void retract(FirstLastValueWithRetractAccumulator<T> acc, Object value, Long order) throws Exception { if (value != null) { T v = (T) value; List<Long> orderList = acc.valueToOrderMap.get(v); if (orderList != null && orderList.size() > 0) { orderList.remove(0); if (orderList.isEmpty()) { acc.valueToOrderMap.remove(v); } else { acc.valueToOrderMap.put(v, orderList); } } else { List<Long> retractOrderList = acc.valueToOrderRetractMap.get(v); if (retractOrderList == null) { retractOrderList = new ArrayList<>(); } retractOrderList.add(order); acc.valueToOrderRetractMap.put(v, retractOrderList); } List<T> valueList = acc.orderToValueMap.get(order); int index; if (valueList != null && (index = valueList.indexOf(v)) >= 0) { valueList.remove(index); if (valueList.isEmpty()) { acc.orderToValueMap.remove(order); } else { acc.orderToValueMap.put(order, valueList); } } else { List<T> retractValueList = acc.orderToValueRetractMap.get(order); if (retractValueList == null) { retractValueList = new ArrayList<>(); } retractValueList.add(v); acc.orderToValueRetractMap.put(order, retractValueList); } if (v.equals(acc.value)) { updateValue(acc); } } }
Source:
<code>public void updateCertificatePolicyCodeSnippets() { CertificateAsyncClient certificateAsyncClient = getCertificateAsyncClient(); certificateAsyncClient.getCertificatePolicy("certificateName") .subscriberContext(Context.of(key1, value1, key2, value2)) .subscribe(certificatePolicyResponseValue -> { CertificatePolicy certificatePolicy = certificatePolicyResponseValue; certificatePolicy.setCertificateTransparent(true); certificateAsyncClient.updateCertificatePolicy("certificateName", certificatePolicy) .subscribe(updatedPolicy -> System.out.printf("Certificate policy's updated transparency status %s %n", <START> updatedPolicy.isCertificateTransparent().toString())); <END> }); END: com.azure.security.keyvault.certificates.CertificateAsyncClient.updateCertificatePolicy#string certificateAsyncClient.getCertificatePolicy("certificateName") .subscriberContext(Context.of(key1, value1, key2, value2)) .subscribe(certificatePolicyResponseValue -> { CertificatePolicy certificatePolicy = certificatePolicyResponseValue; certificatePolicy.setCertificateTransparent(true); certificateAsyncClient.updateCertificatePolicyWithResponse("certificateName", certificatePolicy) .subscribe(updatedPolicyResponse -> System.out.printf("Certificate policy's updated transparency status %s %n", updatedPolicyResponse.getValue().isCertificateTransparent().toString())); }); END: com.azure.security.keyvault.certificates.CertificateAsyncClient.updateCertificatePolicyWithResponse#string }</code><technical_language>need toString() ? below</technical_language>

Target:
public void updateCertificatePolicyCodeSnippets() { CertificateAsyncClient certificateAsyncClient = getCertificateAsyncClient(); certificateAsyncClient.getCertificatePolicy("certificateName") .subscriberContext(Context.of(key1, value1, key2, value2)) .subscribe(certificatePolicyResponseValue -> { CertificatePolicy certificatePolicy = certificatePolicyResponseValue; certificatePolicy.setCertificateTransparent(true); certificateAsyncClient.updateCertificatePolicy("certificateName", certificatePolicy) .subscribe(updatedPolicy -> System.out.printf("Certificate policy's updated transparency status %s %n", updatedPolicy.isCertificateTransparent())); }); END: com.azure.security.keyvault.certificates.CertificateAsyncClient.updateCertificatePolicy#string certificateAsyncClient.getCertificatePolicy("certificateName") .subscriberContext(Context.of(key1, value1, key2, value2)) .subscribe(certificatePolicyResponseValue -> { CertificatePolicy certificatePolicy = certificatePolicyResponseValue; certificatePolicy.setCertificateTransparent(true); certificateAsyncClient.updateCertificatePolicyWithResponse("certificateName", certificatePolicy) .subscribe(updatedPolicyResponse -> System.out.printf("Certificate policy's updated transparency status %s %n", updatedPolicyResponse.getValue().isCertificateTransparent())); }); END: com.azure.security.keyvault.certificates.CertificateAsyncClient.updateCertificatePolicyWithResponse#string }
Source:
<code>public StoreKey getStoreKey(DataInputStream value) throws IOException { <START> return BlobId.fromDataInputStream(value, clusterMap); <END> }</code><technical_language>is this changed a constructor this</technical_language>

Target:
public StoreKey getStoreKey(DataInputStream value) throws IOException { return new BlobId(value, clusterMap); }
Source:
<code>private void handleStateChange(StateManager.CommunicationsState newState ){ if(newState == null) { return; } if(newState.isZoomChange()) { graph.getView().setScale(newState.getZoomValue()); return; } CVTEvents.getCVTEventBus().post(new CVTEvents.StateEvent(newState)); setStateButtonsEnabled(); graph.getModel().beginUpdate(); graph.resetGraph(); if(newState.getPinnedList() != null) { pinnedAccountModel.pinAccount(newState.getPinnedList()); } else { pinnedAccountModel.clear(); } currentFilter = new CommunicationsFilter(); <START> currentFilter.addAndFilter(new CommunicationsFilter.RelationshipTypeFilter( <END> ImmutableSet.of(CALL_LOG, MESSAGE))); newState.getCommunicationsFilters().forEach(filter -> { currentFilter.addAndFilter(filter); }); rebuildGraph(); graph.getModel().endUpdate(); fitGraph(); }</code><technical_language>Right, a stupid question, me. I mean, is initializing CALL_LOG MESSAGE. seams new, I missing something..</technical_language>

Target:
private void handleStateChange(StateManager.CommunicationsState newState ){ if(newState == null) { return; } if(newState.isZoomChange()) { graph.getView().setScale(newState.getZoomValue()); return; } CVTEvents.getCVTEventBus().post(new CVTEvents.StateEvent(newState)); setStateButtonsEnabled(); graph.getModel().beginUpdate(); graph.resetGraph(); if(newState.getPinnedList() != null) { pinnedAccountModel.pinAccount(newState.getPinnedList()); } else { pinnedAccountModel.clear(); } currentFilter = newState.getCommunicationsFilter(); rebuildGraph(); graph.getModel().endUpdate(); fitGraph(); }
Source:
<code>private static void log(final RqFallback req) throws IOException { final ByteArrayOutputStream baos = new ByteArrayOutputStream(); final Throwable error = req.throwable(); final PrintStream stream = new PrintStream( baos, false, StandardCharsets.UTF_8.toString() ); error.printStackTrace(stream); <START> stream.close(); <END> Logger.getLogger(FbLog4j.class).error( String.format( "%s %s failed with %s: %s", new RqMethod.Base(req).method(), new RqHref.Base(req).href(), req.code(), baos.toString("UTF-8") ) ); }</code><technical_language>@sebing close stream in finally block</technical_language>

Target:
private static void log(final RqFallback req) throws IOException { final ByteArrayOutputStream baos = new ByteArrayOutputStream(); final Throwable error = req.throwable(); final PrintStream stream = new PrintStream( baos, false, StandardCharsets.UTF_8.toString() ); try { error.printStackTrace(stream); } finally { stream.close(); } Logger.getLogger(FbLog4j.class).error( String.format( "%s %s failed with %s: %s", new RqMethod.Base(req).method(), new RqHref.Base(req).href(), req.code(), baos.toString("UTF-8") ) ); }
Source:
<code>public void setUp() throws Exception { r.jenkins.getDescriptorByType(GlobalDefaultFlowDurabilityLevel.DescriptorImpl.class).setDurabilityHint(FlowDurabilityHint.PERFORMANCE_OPTIMIZED); deletePods(cloud.connect(), getLabels(cloud, this, name), false); warnings.record("", Level.WARNING).capture(1000); assertNotNull(createJobThenScheduleRun()); <START> logs = logs.recordPackage(ContainerExecDecorator.class, Level.FINEST); <END> }</code><technical_language>Ah, need revert this line, verbose for Jenkins collects. useful debug though</technical_language>

Target:
public void setUp() throws Exception { r.jenkins.getDescriptorByType(GlobalDefaultFlowDurabilityLevel.DescriptorImpl.class).setDurabilityHint(FlowDurabilityHint.PERFORMANCE_OPTIMIZED); deletePods(cloud.connect(), getLabels(cloud, this, name), false); warnings.record("", Level.WARNING).capture(1000); assertNotNull(createJobThenScheduleRun()); }
Source:
<code><START> private boolean validateServers(Set<String> serverNames) { <END> for (String serverName : serverNames) { if (getVdsStaticDao().getAllForHost(serverName).size() > 0 || getVdsStaticDao().getAllWithIpAddress(serverName).size() > 0) { return true; } } return false; }</code><technical_language>Normally, a 'validate' method return true in case of success, false if validation failed</technical_language>

Target:
private boolean validateServers(Set<String> serverNames) { for (String serverName : serverNames) { if (getVdsStaticDao().getAllForHost(serverName).size() > 0 || getVdsStaticDao().getAllWithIpAddress(serverName).size() > 0) { return false; } } return true; }
Source:
<code>public int[] order(int[] sortVector, SortModel.Dir direction, int[] range) { switch(direction) { case ASC: if (range == null || range.length == numRows) { HeapsortColumn.heapsortBitSet(bitSet, sortVector, numRows, true); } else { <START> HeapsortColumn.heapsortBitSet(bitSet, sortVector, range.length, range, true); <END> } break; case DESC: if (range == null || range.length == numRows) { HeapsortColumn.heapsortBitSet(bitSet, sortVector, numRows, false); } else { HeapsortColumn.heapsortBitSet(bitSet, sortVector, range.length, range, false); } break; } return sortVector; }</code><technical_language>collapse branches pass parameter (direction == Direction.ASC)</technical_language>

Target:
public int[] order(int[] sortVector, SortModel.Dir direction, int[] range) { if (range == null || range.length == numRows) { HeapsortColumn.heapsortBitSet(bitSet, sortVector, numRows, direction == SortModel.Dir.ASC); } else { HeapsortColumn.heapsortBitSet(bitSet, sortVector, range.length, range, direction == SortModel.Dir.ASC); } return sortVector; }
Source:
<code>public RtReleases(final Request req, final Repo repo) { this.entry = req; this.owner = repo; this.request = this.releaseURI(repo) <START> .back(); <END> this.latest = this.releaseURI(repo) .path("/latest") .back(); this.tagged = this.releaseURI(repo) .path("/tags/"); }</code><technical_language>@weisebrazil indentations 4 spaces, 8</technical_language>

Target:
public RtReleases(final Request req, final Repo repo) { this.entry = req; this.owner = repo; this.request = this.entry.uri() .path("/repos") .path(repo.coordinates().user()) .path(repo.coordinates().repo()) .path("/releases").back(); }
Source:
<code>public Object[] getUserAndServerUrl(RealmConfiguration config) { if (config instanceof SyncConfiguration) { SyncConfiguration syncConfig = (SyncConfiguration) config; SyncUser user = syncConfig.getUser(); String rosServerUrl = syncConfig.getServerUrl().toString(); String rosUserIdentity = user.getIdentity(); String syncRealmAuthUrl = user.getAuthenticationUrl().toString(); String rosSerializedUser = user.toJson(); return new Object[]{rosUserIdentity, rosServerUrl, syncRealmAuthUrl, rosSerializedUser, syncConfig.syncClientValidateSsl(), syncConfig.getServerCertificateFilePath(), syncConfig.isPartialSync()}; } else { <START> return new Object[7]; <END> } }</code><technical_language>Merge conflict #5356 .... race</technical_language>

Target:
public Object[] getUserAndServerUrl(RealmConfiguration config) { if (config instanceof SyncConfiguration) { SyncConfiguration syncConfig = (SyncConfiguration) config; SyncUser user = syncConfig.getUser(); String rosServerUrl = syncConfig.getServerUrl().toString(); String rosUserIdentity = user.getIdentity(); String syncRealmAuthUrl = user.getAuthenticationUrl().toString(); String rosSerializedUser = user.toJson(); byte sessionStopPolicy = syncConfig.getSessionStopPolicy().getNativeValue(); return new Object[]{rosUserIdentity, rosServerUrl, syncRealmAuthUrl, rosSerializedUser, syncConfig.syncClientValidateSsl(), syncConfig.getServerCertificateFilePath(), sessionStopPolicy, syncConfig.isPartialRealm()}; } else { return new Object[8]; } }
Source:
<code>public boolean handle(ResponseMsg response, ChannelHandlerContext ctx) { IClientRouter router = client.getRouter(); long requestId = response.getHeader().getRequestId(); PayloadCase payloadCase = response.getPayload().getPayloadCase(); if (payloadCase.equals(PayloadCase.SERVER_ERROR)) { ErrorCase errorCase = response.getPayload().getServerError().getErrorCase(); if (errorHandlerMap.containsKey(errorCase)) { try{ errorHandlerMap.get(errorCase).handle(response, ctx, router); } catch (Throwable e) { router.completeExceptionally(requestId, e); <START> } <END> } } else if (handlerMap.containsKey(payloadCase)) { try { Object ret = handlerMap.get(payloadCase).handle(response, ctx, router); if (ret != null) { router.completeRequest(requestId, ret); } } catch (Throwable e) { router.completeExceptionally(requestId, e); } return true; } return false; }</code><technical_language>missing java doc</technical_language>

Target:
public boolean handle(ResponseMsg response, ChannelHandlerContext ctx) { IClientRouter router = client.getRouter(); final long requestId = response.getHeader().getRequestId(); PayloadCase payloadCase = response.getPayload().getPayloadCase(); if (payloadCase == PayloadCase.SERVER_ERROR) { ErrorCase errorCase = response.getPayload().getServerError().getErrorCase(); if (errorHandlerMap.containsKey(errorCase)) { try{ errorHandlerMap.get(errorCase).handle(response, ctx, router); } catch (Throwable e) { router.completeExceptionally(requestId, e); } } } else if (handlerMap.containsKey(payloadCase)) { try { Object ret = handlerMap.get(payloadCase).handle(response, ctx, router); if (ret != null) { router.completeRequest(requestId, ret); } } catch (Throwable e) { router.completeExceptionally(requestId, e); } return true; } return false; }