auphong2707/dl4se-code-review-dataset huggingface dataset:
Source:
<code>public void init(ICommonActionExtensionSite site) { if (site.getViewSite() instanceof ICommonViewerWorkbenchSite) { final ICommonViewerWorkbenchSite viewSite = (ICommonViewerWorkbenchSite) site.getViewSite(); final ISelectionProvider selectionProvider = viewSite.getSelectionProvider(); CommonViewer viewer = (CommonViewer) selectionProvider; <START> final ReviewExplorer explorer = (ReviewExplorer) viewer.getCommonNavigator(); <END> openAction = new Action() { @Override public void run() { IStructuredSelection selection = (IStructuredSelection) selectionProvider.getSelection(); if (selection.size() == 1) { IFileItem fileItem = getFileFor(selection.getFirstElement()); if (fileItem != null) { IWorkbenchPart currentPart = ReviewsUiPlugin.getDefault() .getReviewManager() .getCurrentPart(); if (currentPart instanceof TaskEditor) { TaskEditor part = (TaskEditor) currentPart; TaskEditorInput input = (TaskEditorInput) part.getEditorInput(); GerritReviewBehavior behavior = new GerritReviewBehavior(input.getTask()); CompareConfiguration configuration = new CompareConfiguration(); CompareUI.openCompareEditor(new FileItemCompareEditorInput(configuration, fileItem, behavior)); } } } } @Override public boolean isEnabled() { return true; } }; } }</code><technical_language>remove a lot of this</technical_language>

Target:
public void init(ICommonActionExtensionSite site) { if (site.getViewSite() instanceof ICommonViewerWorkbenchSite) { final ICommonViewerWorkbenchSite viewSite = (ICommonViewerWorkbenchSite) site.getViewSite(); final ISelectionProvider selectionProvider = viewSite.getSelectionProvider(); openAction = new Action() { @Override public void run() { IStructuredSelection selection = (IStructuredSelection) selectionProvider.getSelection(); if (selection.size() == 1) { IFileItem fileItem = getFileFor(selection.getFirstElement()); if (fileItem != null) { ActiveReviewManager reviewManager = ReviewsUiPlugin.getDefault().getReviewManager(); if (reviewManager != null) { IWorkbenchPart currentPart = reviewManager.getCurrentPart(); if (currentPart instanceof TaskEditor) { TaskEditor part = (TaskEditor) currentPart; TaskEditorInput input = (TaskEditorInput) part.getEditorInput(); GerritReviewBehavior behavior = new GerritReviewBehavior(input.getTask()); CompareConfiguration configuration = new CompareConfiguration(); CompareUI.openCompareEditor(new FileItemCompareEditorInput(configuration, fileItem, behavior)); } } } } } @Override public boolean isEnabled() { return true; } }; } }
Source:
<code>private boolean validateAccountingLine(ConcurStandardAccountingExtractDetailLine line, ConcurStandardAccountingExtractBatchReportData reportData) { <START> reportErrorsWithOriginalAccountingDetails(line); <END> String overriddenObjectCode = getParameterService().getParameterValueAsString(CUKFSConstants.ParameterNamespaces.CONCUR, CUKFSParameterKeyConstants.ALL_COMPONENTS, ConcurParameterConstants.CONCUR_SAE_PDP_DEFAULT_OBJECT_CODE); ConcurAccountInfo overriddenConcurAccountingInformation = new ConcurAccountInfo(line.getChartOfAccountsCode(), line.getAccountNumber(), line.getSubAccountNumber(), overriddenObjectCode, StringUtils.EMPTY, line.getProjectCode()); ValidationResult overriddenValidationResults = buildValidationResult(overriddenConcurAccountingInformation, true); if (overriddenValidationResults.isNotValid()) { reportData.addValidationErrorFileLine(new ConcurBatchReportLineValidationErrorItem(line.getReportId(), line.getEmployeeId(), line.getEmployeeLastName(), line.getEmployeeFirstName(), line.getEmployeeMiddleInitital(), overriddenValidationResults.getMessages())); } return overriddenValidationResults.isValid(); }</code><technical_language>reports logs here, clearer rename this function logErrorsWithOriginalAccountingDetails</technical_language>

Target:
private boolean validateAccountingLine(ConcurStandardAccountingExtractDetailLine line, ConcurStandardAccountingExtractBatchReportData reportData) { logErrorsWithOriginalAccountingDetails(line); String overriddenObjectCode = getParameterService().getParameterValueAsString(CUKFSConstants.ParameterNamespaces.CONCUR, CUKFSParameterKeyConstants.ALL_COMPONENTS, ConcurParameterConstants.CONCUR_SAE_PDP_DEFAULT_OBJECT_CODE); ConcurAccountInfo overriddenConcurAccountingInformation = new ConcurAccountInfo(line.getChartOfAccountsCode(), line.getAccountNumber(), line.getSubAccountNumber(), overriddenObjectCode, StringUtils.EMPTY, line.getProjectCode()); ValidationResult overriddenValidationResults = buildValidationResult(overriddenConcurAccountingInformation, true); if (overriddenValidationResults.isNotValid()) { reportData.addValidationErrorFileLine(new ConcurBatchReportLineValidationErrorItem(line.getReportId(), line.getEmployeeId(), line.getEmployeeLastName(), line.getEmployeeFirstName(), line.getEmployeeMiddleInitital(), overriddenValidationResults.getMessages())); } return overriddenValidationResults.isValid(); }
Source:
<code>public void setHotspot(float x, float y) { <START> for (Drawable drawable : mLayers) { <END> if (drawable != null) { drawable.setHotspot(x, y); } } }</code><technical_language>Please change this foreach a for loop array other method loops drawables</technical_language>

Target:
public void setHotspot(float x, float y) { for (int i = 0; i < mLayers.length; i++) { Drawable drawable = mLayers[i]; if (drawable != null) { drawable.setHotspot(x, y); } } }
Source:
<code>public void run() { while (isRunning && containerPlacementMetadataStore.isRunning()) { try { for (ContainerPlacementRequestMessage message : containerPlacementMetadataStore.readAllContainerPlacementRequestMessages()) { LOG.info("Received a container placement message {}", message); containerProcessManager.registerContainerPlacementAction(message); } Thread.sleep(DEFAULT_CLUSTER_MANAGER_CONTAINER_PLACEMENT_HANDLER_SLEEP_MS); } catch (InterruptedException e) { LOG.warn("Got InterruptedException in ContainerPlacementRequestAllocator thread.", e); Thread.currentThread().interrupt(); } catch (Exception e) { LOG.error( <START> "Got unknown Exception while reading ContainerPlacementRequestMessage in ContainerPlacementRequestAllocator thread", <END> e); } } }</code><technical_language>Well, if Exception "unknown" :-)</technical_language>

Target:
public void run() { while (isRunning && containerPlacementMetadataStore.isRunning()) { try { for (ContainerPlacementRequestMessage message : containerPlacementMetadataStore.readAllContainerPlacementRequestMessages()) { LOG.info("Received a container placement message {}", message); containerProcessManager.registerContainerPlacementAction(message); } Thread.sleep(DEFAULT_CLUSTER_MANAGER_CONTAINER_PLACEMENT_HANDLER_SLEEP_MS); } catch (InterruptedException e) { LOG.warn("Got InterruptedException in ContainerPlacementRequestAllocator thread.", e); Thread.currentThread().interrupt(); } catch (Exception e) { LOG.error( "Got an exception while reading ContainerPlacementRequestMessage in ContainerPlacementRequestAllocator thread", e); } } }
Source:
<code>protected Boolean doInBackground(String... urls) { try { byte[] buffer; ByteArrayOutputStream output = new ByteArrayOutputStream(); if (URLUtil.isDataUrl(urls[0])) { String[] parts = urls[0].split("base64,"); String encoded = parts[1]; buffer = Base64.decode(encoded, Base64.DEFAULT); output.write(buffer, 0, buffer.length); } else { URL url = new URL(urls[0]); InputStream is = (InputStream) url.getContent(); buffer = new byte[8192]; int bytesRead; while ((bytesRead = is.read(buffer)) != -1) { output.write(buffer, 0, bytesRead); <START> } <END> } File path = Environment.getExternalStoragePublicDirectory( Environment.DIRECTORY_DOWNLOADS); String fileExtenstion = MimeTypeMap.getFileExtensionFromUrl(urls[0]); String name = URLUtil.guessFileName(urls[0], null, fileExtenstion); name = System.currentTimeMillis() + name; imagePath = new File(path, name); FileOutputStream fos = new FileOutputStream(imagePath); fos.write(output.toByteArray()); fos.flush(); fos.close(); return true; } catch (IOException e) { CrashTracking.logHandledException(e); return false; } }</code><technical_language>output.close() called explicitly</technical_language>

Target:
protected Boolean doInBackground(String... urls) { try { String fileExtenstion; String name; String sUrl = urls[0]; byte[] buffer; ByteArrayOutputStream output = new ByteArrayOutputStream(); if (URLUtil.isDataUrl(sUrl)) { String[] parts = sUrl.split(","); String encoded = parts[1]; String extension = ""; if (parts[0].toLowerCase().contains("image/")) { Pattern pattern = Pattern.compile("image/([a-zA-Z]*)"); Matcher matcher = pattern.matcher(parts[0]); matcher.find(); extension = matcher.group(1); } name = "dataimage" + extension; if (sUrl.toLowerCase().contains(";base64")) { buffer = Base64.decode(encoded, Base64.DEFAULT); output.write(buffer, 0, buffer.length); output.close(); } else { buffer = Uri.decode(encoded).getBytes(); output.write(buffer, 0, buffer.length); output.close(); } } else { fileExtenstion = MimeTypeMap.getFileExtensionFromUrl(sUrl); name = URLUtil.guessFileName(sUrl, null, fileExtenstion); URL url = new URL(sUrl); InputStream is = (InputStream) url.getContent(); buffer = new byte[8192]; int bytesRead; while ((bytesRead = is.read(buffer)) != -1) { output.write(buffer, 0, bytesRead); } output.close(); } File path = Environment.getExternalStoragePublicDirectory( Environment.DIRECTORY_DOWNLOADS); name = System.currentTimeMillis() + name; imagePath = new File(path, name); FileOutputStream fos = new FileOutputStream(imagePath); fos.write(output.toByteArray()); fos.flush(); fos.close(); return true; } catch (IOException e) { CrashTracking.logHandledException(e); return false; } }
Source:
<code>private static void addHostNetworksAndUpdateInterfaces(VDS vds, XmlRpcStruct xmlRpcStruct, Map<String, Integer> currVlans, Map<String, Integer> networkVlans) { Map<String, Object> networks = (Map<String, Object>) xmlRpcStruct.getItem(VdsProperties.network_networks); Map<String, VdsNetworkInterface> vdsInterfaces = Entities.entitiesByName(vds.getInterfaces()); if (networks != null) { vds.getNetworks().clear(); for (Entry<String, Object> entry : networks.entrySet()) { Map<String, Object> network = (Map<String, Object>) entry.getValue(); if (network != null) { Network net = new Network(); net.setname(entry.getKey()); net.setaddr((String) network.get("addr")); net.setsubnet((String) network.get("netmask")); net.setgateway((String) network.get(VdsProperties.GLOBAL_GATEWAY)); if (StringUtils.isNotBlank((String) network.get(VdsProperties.mtu))) { net.setMtu(Integer.parseInt((String) network.get(VdsProperties.mtu))); } <START> <END> if (vds.getvds_group_compatibility_version().compareTo(Version.v3_1) >= 0) { VdsNetworkInterface iface = null; String interfaceName = network.get("interface") == null ? null : (String)network.get("interface"); if (interfaceName != null) { iface = vdsInterfaces.get(interfaceName); if (iface == null) { iface = findInterfaceInBridges(xmlRpcStruct, interfaceName, vdsInterfaces); } } updateNetworkDetailsInInterface(iface, currVlans, networkVlans, network, net); } else { Object[] ports = (Object[]) network.get("ports"); if (ports != null) { for (Object port : ports) { updateNetworkDetailsInInterface(vdsInterfaces.get(port.toString()), currVlans, networkVlans, network, net); } } } vds.getNetworks().add(net); } } } }</code><technical_language>need add supportBridgesReportByVDSM config options for versions</technical_language>

Target:
private static void addHostNetworksAndUpdateInterfaces(VDS vds, XmlRpcStruct xmlRpcStruct, Map<String, Integer> currVlans, Map<String, Integer> networkVlans) { Map<String, Object> networks = (Map<String, Object>) xmlRpcStruct.getItem(VdsProperties.network_networks); if (networks != null) { vds.getNetworks().clear(); for (Entry<String, Object> entry : networks.entrySet()) { Map<String, Object> network = (Map<String, Object>) entry.getValue(); if (network != null) { Network net = createNetworkData(entry.getKey(), network); List<VdsNetworkInterface> interfaces = findNetworkInterfaces(vds, xmlRpcStruct, network); for (VdsNetworkInterface iface : interfaces) { updateNetworkDetailsInInterface(iface, currVlans, networkVlans, network, net); } vds.getNetworks().add(net); reportInvalidInterfacesForNetwork(interfaces, net, vds); } } } }
Source:
<code>public void climbTest() { super.climbTest(); SWTWorkbenchBot bot = new SWTWorkbenchBot(); SWTBotTable tableBot = new SWTBotTable(getTable().getTableViewer().getTable()); tableBot.header("System Call").click(); bot.waitUntil(ConditionHelpers.isTableCellFilled(tableBot, "0", 0, 2)); tableBot.header("System Call").click(); <START> bot.waitUntil(ConditionHelpers.isTableCellFilled(tableBot, "0", 0, 2)); <END> tableBot.header("Duration").click(); bot.waitUntil(ConditionHelpers.isTableCellFilled(tableBot, "0", 0, 2)); tableBot.header("Duration").click(); bot.waitUntil(ConditionHelpers.isTableCellFilled(tableBot, "99", 0, 2)); tableBot.header("Start Time").click(); bot.waitUntil(ConditionHelpers.isTableCellFilled(tableBot, "99", 0, 2)); }</code><technical_language>clicking system call, hard check of of system call instead of "0"? I guess 0, 2 row, column read, hard</technical_language>

Target:
public void climbTest() { super.climbTest(); SWTWorkbenchBot bot = new SWTWorkbenchBot(); SWTBotTable tableBot = new SWTBotTable(getTable().getTableViewer().getTable()); tableBot.header("System Call").click(); bot.waitUntil(ConditionHelpers.isTableCellFilled(tableBot, "99", 0, 2)); tableBot.header("System Call").click(); bot.waitUntil(ConditionHelpers.isTableCellFilled(tableBot, "98", 0, 2)); tableBot.header("Duration").click(); bot.waitUntil(ConditionHelpers.isTableCellFilled(tableBot, "0", 0, 2)); tableBot.header("Duration").click(); bot.waitUntil(ConditionHelpers.isTableCellFilled(tableBot, "99", 0, 2)); tableBot.header("Start Time").click(); bot.waitUntil(ConditionHelpers.isTableCellFilled(tableBot, "99", 0, 2)); }
Source:
<code>public TaskResult run() { Timer.Context deprecationTaskRunTimer = vcrMetrics.deprecationTaskRunTime.time(); try { logger.info("DeprecatedContainerCloudSyncTask run started."); Timer.Context accountServiceFetchTimer = vcrMetrics.accountServiceFetchTime.time(); Set<Container> deprecatedContainers = AccountUtils.getDeprecatedContainers(accountService, containerDeletionRetentionDays); accountServiceFetchTimer.stop(); <START> logger.info(String.format("Attempting deprecation of %d containers.", deprecatedContainers.size())); <END> cloudDestination.deprecateContainers(deprecatedContainers); } catch (CloudStorageException cloudStorageException) { logger.error("Error in updating deprecated containers from account service to cloud: ", cloudStorageException); } finally { logger.info("DeprecatedContainerCloudSyncTask done."); deprecationTaskRunTimer.stop(); } return null; }</code><technical_language>Minor: need String..format in logger call, instead</technical_language>

Target:
public TaskResult run() { Timer.Context deprecationTaskRunTimer = vcrMetrics.deprecationTaskRunTime.time(); try { logger.info("DeprecatedContainerCloudSyncTask run started."); Timer.Context accountServiceFetchTimer = vcrMetrics.accountServiceFetchTime.time(); Set<Container> deprecatedContainers = AccountUtils.getDeprecatedContainers(accountService, containerDeletionRetentionDays); accountServiceFetchTimer.stop(); logger.info("Attempting deprecation of containers.", deprecatedContainers.size()); cloudDestination.deprecateContainers(deprecatedContainers); } catch (CloudStorageException cloudStorageException) { logger.error("Error in updating deprecated containers from account service to cloud: ", cloudStorageException); } finally { logger.info("DeprecatedContainerCloudSyncTask done."); deprecationTaskRunTimer.stop(); } return null; }
Source:
<code>protected IStatus validate() { if (selectedDataObservable.getValue() instanceof BusinessObjectData) { if (checkedElements.isEmpty()) { return ValidationStatus.error(Messages.atLeastOneAttributeShouldBeSelectedError); } else { final StringBuilder sb = new StringBuilder(); validateMandatoryFieldsNotSelected(sb, mappings, checkedElements); if (sb.length() > 0) { <START> if (sb.indexOf(",") == sb.lastIndexOf(",")) { <END> sb.replace(sb.lastIndexOf(","), sb.lastIndexOf(",") + 1, ""); } final String message = container instanceof Task ? Messages.mandatoryFieldsNotSelectedStepWarning : Messages.mandatoryFieldsNotSelectedWarning; return ValidationStatus.warning(Messages.bind(message, sb.toString())); } } } return ValidationStatus.ok(); }</code><technical_language>extract variable sb.lastIndexOf(",")</technical_language>

Target:
protected IStatus validate() { if (selectedDataObservable.getValue() instanceof BusinessObjectData) { if (checkedElements.isEmpty()) { return ValidationStatus.error(Messages.atLeastOneAttributeShouldBeSelectedError); } else { final StringBuilder sb = new StringBuilder(); validateMandatoryFieldsNotSelected(sb, mappings, checkedElements); if (sb.length() > 0) { int lastIndexOf = sb.lastIndexOf(","); if (sb.indexOf(",") == lastIndexOf) { sb.replace(lastIndexOf, lastIndexOf + 1, ""); } final String message = container instanceof Task ? Messages.mandatoryFieldsNotSelectedStepWarning : Messages.mandatoryFieldsNotSelectedWarning; return ValidationStatus.warning(Messages.bind(message, sb.toString())); } } } return ValidationStatus.ok(); }
Source:
<code>private SAMLAttributeParser() { super(SAMLAssertionQNames.ATTRIBUTE); <START> <END> Set<String> localAttributeNames = new HashSet<>(); for (SAMLAssertionQNames name : Arrays.asList(SAMLAssertionQNames.ATTR_NAME, SAMLAssertionQNames.ATTR_FRIENDLY_NAME, SAMLAssertionQNames.ATTR_NAME_FORMAT)) { localAttributeNames.add(name.getQName().getLocalPart()); } DEFAULT_KNOWN_LOCAL_ATTRIBUTE_NAMES = localAttributeNames; }</code><technical_language>Remove this block (l49-54) this moved static initialization above</technical_language>

Target:
private SAMLAttributeParser() { super(SAMLAssertionQNames.ATTRIBUTE); }
Source:
<code>private MethodInvoker createMethodInvoker(final Method method) { try { BiFunction<Object, Object[], Object> fastMethod = BytecodeGen.fastMethod(method); if (fastMethod != null) { return new MethodInvoker() { @Override public Object invoke(Object target, Object... parameters) throws IllegalAccessException, InvocationTargetException { try { return fastMethod.apply(target, parameters); <START> } catch (Throwable e) { <END> throw new InvocationTargetException(e); } } }; } } catch (Exception | LinkageError e) { } int modifiers = method.getModifiers(); if (!Modifier.isPublic(modifiers) || !Modifier.isPublic(method.getDeclaringClass().getModifiers())) { method.setAccessible(true); } return new MethodInvoker() { @Override public Object invoke(Object target, Object... parameters) throws IllegalAccessException, InvocationTargetException { return method.invoke(target, parameters); } }; }</code><technical_language>(same q wrapping w/ InvocationTargetException here)</technical_language>

Target:
private MethodInvoker createMethodInvoker(final Method method) { try { BiFunction<Object, Object[], Object> fastMethod = BytecodeGen.fastMethod(method); if (fastMethod != null) { return new MethodInvoker() { @Override public Object invoke(Object target, Object... parameters) throws InvocationTargetException { try { return fastMethod.apply(target, parameters); } catch (Throwable e) { throw new InvocationTargetException(e); } } }; } } catch (Exception | LinkageError e) { } int modifiers = method.getModifiers(); if (!Modifier.isPublic(modifiers) || !Modifier.isPublic(method.getDeclaringClass().getModifiers())) { method.setAccessible(true); } return new MethodInvoker() { @Override public Object invoke(Object target, Object... parameters) throws IllegalAccessException, InvocationTargetException { return method.invoke(target, parameters); } }; }
Source:
<code>public DelegatingResourceDescription getRepresentationDescription(Representation rep) { if (rep instanceof DefaultRepresentation) { DelegatingResourceDescription description = new DelegatingResourceDescription(); description.addProperty("uuid"); description.addProperty("display"); description.addProperty("templateId"); description.addProperty("dcTermsIdentifier"); description.addProperty("dcTermsTitle"); description.addProperty("dcTermsType"); description.addProperty("dcTermsPublisher"); description.addProperty("dcTermsCreator"); description.addProperty("dcTermsRights"); <START> description.addProperty("display"); <END> description.addSelfLink(); description.addLink("full", ".?v=" + RestConstants.REPRESENTATION_FULL); return description; } else if (rep instanceof FullRepresentation) { DelegatingResourceDescription description = new DelegatingResourceDescription(); description.addProperty("uuid"); description.addProperty("charset"); description.addProperty("path"); description.addProperty("templateId"); description.addProperty("dcTermsIdentifier"); description.addProperty("dcTermsTitle"); description.addProperty("dcTermsDescription"); description.addProperty("dcTermsType"); description.addProperty("dcTermsLanguage"); description.addProperty("dcTermsPublisher"); description.addProperty("dcTermsCreator"); description.addProperty("dcTermsRights"); description.addProperty("dcTermsLicense"); description.addProperty("dcTermsDate"); description.addProperty("display"); description.addSelfLink(); return description; } else { return null; } }</code><technical_language>display is duplicate</technical_language>

Target:
public DelegatingResourceDescription getRepresentationDescription(Representation rep) { if (rep instanceof DefaultRepresentation) { DelegatingResourceDescription description = new DelegatingResourceDescription(); description.addProperty("uuid"); description.addProperty("templateId"); description.addProperty("dcTermsIdentifier"); description.addProperty("dcTermsTitle"); description.addProperty("dcTermsType"); description.addProperty("dcTermsPublisher"); description.addProperty("dcTermsCreator"); description.addProperty("dcTermsRights"); description.addProperty("display"); description.addSelfLink(); description.addLink("full", ".?v=" + RestConstants.REPRESENTATION_FULL); return description; } else if (rep instanceof FullRepresentation) { DelegatingResourceDescription description = new DelegatingResourceDescription(); description.addProperty("uuid"); description.addProperty("charset"); description.addProperty("path"); description.addProperty("templateId"); description.addProperty("dcTermsIdentifier"); description.addProperty("dcTermsTitle"); description.addProperty("dcTermsDescription"); description.addProperty("dcTermsType"); description.addProperty("dcTermsLanguage"); description.addProperty("dcTermsPublisher"); description.addProperty("dcTermsCreator"); description.addProperty("dcTermsRights"); description.addProperty("dcTermsLicense"); description.addProperty("dcTermsDate"); description.addProperty("display"); description.addSelfLink(); return description; } else { return null; } }
Source:
<code>public KafkaBasedLog(String topic, Map<String, Object> producerConfigs, Map<String, Object> consumerConfigs, Callback<ConsumerRecord<K, V>> consumedCallback, Time time, Runnable initializer) { this.topic = topic; this.producerConfigs = producerConfigs; this.consumerConfigs = consumerConfigs; this.consumedCallback = consumedCallback; this.stopRequested = false; this.readLogEndOffsetCallbacks = new ArrayDeque<>(); this.time = time; <START> this.initializer = initializer != null ? initializer : () -> { }; <END> }</code><technical_language>this change functionality, want change this update modern syntax. more changes this, harder is backport other fixes overlap this diff, ideally backport fixes aggressively (and in fact, this example want backport a version supports jdk7)</technical_language>

Target:
public KafkaBasedLog(String topic, Map<String, Object> producerConfigs, Map<String, Object> consumerConfigs, Callback<ConsumerRecord<K, V>> consumedCallback, Time time, Runnable initializer) { this(topic, producerConfigs, consumerConfigs, consumedCallback, time, initializer, CREATE_TOPIC_TIMEOUT_MS); }
Source:
<code>public boolean verify() throws ScriptSignatureException { if (fContainSignature) { byte[] signByte = SignatureHelper.convertBase64ToBytes(fSignatureString); byte[] certByte = SignatureHelper.convertBase64ToBytes(fCertificateChainString[0]); Certificate userCert = getCertificate(certByte); try { PublicKey publicKey = userCert.getPublicKey(); String encryptionAlgo = publicKey.getAlgorithm(); Signature signature = Signature.getInstance(fHashAlgorithm + "with" + encryptionAlgo, fProvider); signature.initVerify(publicKey); signature.update(fContent.getBytes()); boolean <START> verified = <END> signature.verify(signByte); return verified; } catch (SignatureException e) { Logger.error(Activator.PLUGIN_ID, "Signature object not initialized properly or signature is not readable.", e); throw new ScriptSignatureException("Signature is not readable.", e); } catch (NoSuchAlgorithmException e) { throw new ScriptSignatureException("Algorithm used by signature is not recognized by provider.", e); } catch (InvalidKeyException e) { throw new ScriptSignatureException("Public key is invalid.", e); } catch (NoSuchProviderException e) { throw new ScriptSignatureException("No such provider is registered in Security Providers' list.", e); } } throw new ScriptSignatureException("Script does not contain signature."); }</code><technical_language>return data, need assign a variable anymore</technical_language>

Target:
public boolean verify() throws ScriptSignatureException { if (fSignatureInfo != null) { byte[] signByte = SignatureHelper.convertBase64ToBytes(fSignatureInfo.getSignature()); byte[] certByte = SignatureHelper.convertBase64ToBytes(fSignatureInfo.getCertificateChain()[0]); Certificate userCert = getCertificate(certByte); try { PublicKey publicKey = userCert.getPublicKey(); String encryptionAlgo = publicKey.getAlgorithm(); Signature signature = Signature.getInstance(fSignatureInfo.getMessageDigestAlgo() + "with" + encryptionAlgo, fSignatureInfo.getProvider()); signature.initVerify(publicKey); signature.update(fSignatureInfo.getContentOnly().getBytes()); return signature.verify(signByte); } catch (SignatureException e) { Logger.error(Activator.PLUGIN_ID, "Signature object not initialized properly or signature is not readable.", e); throw new ScriptSignatureException("Signature is not readable.", e); } catch (NoSuchAlgorithmException e) { throw new ScriptSignatureException("Algorithm used by signature is not recognized by provider.", e); } catch (InvalidKeyException e) { throw new ScriptSignatureException("Public key is invalid.", e); } catch (NoSuchProviderException e) { throw new ScriptSignatureException("No such provider is registered in Security Providers' list.", e); } } throw new ScriptSignatureException("Script does not contain signature."); }
Source:
<code>protected boolean matchEntity(DiskImage entity, Guid id) { <START> return id != null && (id.equals(entity.getId()) || id.equals(entity.getImageId()) || id.equals(entity.getvm_snapshot_id())); <END> }</code><technical_language>disk identifier is ID, I compare imageId anymore</technical_language>

Target:
protected boolean matchEntity(DiskImage entity, Guid id) { return id != null && (id.equals(entity.getId()) || id.equals(entity.getvm_snapshot_id())); }
Source:
<code>public void setupRoutes() { path(controllerBasePath(), () -> { before("/*", mimeType, this::setContentType); before("/*", mimeType, this.apiAuthenticationHelper::checkUserAnd403); get(Routes.FeedsAPI.PIPELINES_XML, this.mimeType, this::pipelinesXML); get(Routes.FeedsAPI.STAGES_XML, this.mimeType, this::stagesXML); get(Routes.FeedsAPI.PIPELINE_XML, this.mimeType, this::pipelineXML); get(Routes.FeedsAPI.STAGE_XML, this.mimeType, this::stageXML); get(Routes.FeedsAPI.JOB_XML, this.mimeType, this::jobXML); <START> get(Routes.FeedsAPI.SCHEDULED_JOB_XML, this.mimeType, this::scheduledJobs); <END> get(Routes.FeedsAPI.MATERIAL_URL, this.mimeType, this::materialXML); }); }</code><technical_language>NormalUserSecurity? this based some permissions (pipeline, pipeline group level view permissions)? if keeping public for security implications. \cc: @arvindsv @bdpiparva</technical_language>

Target:
public void setupRoutes() { path(controllerBasePath(), () -> { before("/*", mimeType, super::setContentType); before("/*", mimeType, this.apiAuthenticationHelper::checkUserAnd403); get(Routes.FeedsAPI.PIPELINES_XML, this.mimeType, this::pipelinesXML); get(Routes.FeedsAPI.STAGES_XML, this.mimeType, this::stagesXML); get(Routes.FeedsAPI.PIPELINE_XML, this.mimeType, this::pipelineXML); get(Routes.FeedsAPI.STAGE_XML, this.mimeType, this::stageXML); get(Routes.FeedsAPI.JOB_XML, this.mimeType, this::jobXML); get(Routes.FeedsAPI.SCHEDULED_JOB_XML, this.mimeType, this::scheduledJobs); get(Routes.FeedsAPI.MATERIAL_URL, this.mimeType, this::materialXML); after("/*", this::setContentType); }); }
Source:
<code>private Optional<VariantWithSamplesAndAnnotation> getVariantByCoordinatesAndAnnotationVersion( String variantCoreString, String annotationVepVersion, String annotationVepCacheVersion) throws AnnotationMetadataNotFoundException, IllegalArgumentException { String[] regionId = variantCoreString.split(":"); Optional<String> alternate = Optional.ofNullable(regionId[3]); if (!alternate.isPresent()) { <START> return Optional.ofNullable(null); <END> } AnnotationMetadata annotationMetadata = null; if (annotationVepVersion != null && annotationVepCacheVersion != null) { annotationMetadata = new AnnotationMetadata(annotationVepVersion, annotationVepCacheVersion); } List<VariantWithSamplesAndAnnotation> variantWithSamplesAndAnnotationList = service. findByChromosomeAndStartAndReferenceAndAlternate(regionId[0], Integer.parseInt(regionId[1]), regionId[2], alternate.get(), annotationMetadata); if (variantWithSamplesAndAnnotationList.size() == 1) { return Optional.of(variantWithSamplesAndAnnotationList.get(0)); } else if (variantWithSamplesAndAnnotationList.size() > 1) { throw new IllegalArgumentException("More than one variant retireved. Please enter a unique VariantId"); } return Optional.ofNullable(null); }</code><technical_language>no, I meant method *requires* 4 fields. if split ":" give 4 fields, throw exception asking for them. Try imagine a user happen code made. ask for chr:start:ref, get? a 404, found. is happened? response explain user request work? :)</technical_language>

Target:
private Optional<VariantWithSamplesAndAnnotation> getVariantByCoordinatesAndAnnotationVersion( String variantCoreString, String annotationVepVersion, String annotationVepCacheVersion) throws AnnotationMetadataNotFoundException, IllegalArgumentException { String[] regionId = variantCoreString.split(":"); AnnotationMetadata annotationMetadata = null; if (annotationVepVersion != null && annotationVepCacheVersion != null) { annotationMetadata = new AnnotationMetadata(annotationVepVersion, annotationVepCacheVersion); } List<VariantWithSamplesAndAnnotation> variantWithSamplesAndAnnotationList = service. findByChromosomeAndStartAndReferenceAndAlternate(regionId[0], Integer.parseInt(regionId[1]), regionId[2], regionId[3], annotationMetadata); if (variantWithSamplesAndAnnotationList.size() == 1) { return Optional.of(variantWithSamplesAndAnnotationList.get(0)); } else if (variantWithSamplesAndAnnotationList.size() > 1) { throw new IllegalArgumentException("More than one variant has been found."); } return Optional.ofNullable(null); }
Source:
<code>public VillagerCareer getCareer(String name) { for (VillagerCareer car : this.careers) { <START> if (car.getName() == name) <END> return car; } return null; }</code><technical_language>equals comparing Strings in Java</technical_language>

Target:
public VillagerCareer getCareer(String name) { for (VillagerCareer car : this.careers) { if (car.getName().equals(name)) return car; } return null; }
Source:
<code>private void checkEntityForRollback(BusinessEntity<?> entity) { if(entity == null) { throw new IllegalArgumentException("Can not create snapshot from a null entity"); } <START> Class<? extends BusinessEntity> entityClazz = entity.getClass(); <END> if(DbFacade.getInstance().getDaoForEntity((Class<BusinessEntity<Serializable>>)entityClazz) == null) { throw new IllegalArgumentException("There is no rollback DAO registered for entity type "+entityClazz.getName()); } }</code><technical_language>call variable entityClass</technical_language>

Target:
private void checkEntityForRollback(BusinessEntity<?> entity) { if(entity == null) { throw new IllegalArgumentException("Can not create snapshot from a null entity"); } if (DbFacade.getInstance().getDaoForEntity((Class<BusinessEntity<Serializable>>) entity.getClass()) == null) { throw new IllegalArgumentException("There is no rollback DAO registered for entity type " + entity.getClass().getName()); } }
Source:
<code>public static MBLayer create(JSONObject layer ){ if( layer.containsKey("type") && layer.get("type") instanceof String){ String type = (String) layer.get("type"); switch( type ){ case "line": return new LineMBLayer(layer); case "fill": return new FillMBLayer(layer); case "raster": return new RasterMBLayer(layer); default: throw new MBFormatException(("\"type\" " + type + " is not a valid layer type. Must be one of: " <START> + "background, fill, line, symbol, raster, circle, fill-extrusion")); <END> } } throw new MBFormatException("\"type\" required to create layer."); }</code><technical_language>This error message confusing for (a "background" type trigger it) -- a problem</technical_language>

Target:
public static MBLayer create(JSONObject layer ){ if( layer.containsKey("type") && layer.get("type") instanceof String){ String type = (String) layer.get("type"); switch( type ){ case "line": return new LineMBLayer(layer); case "fill": return new FillMBLayer(layer); case "raster": return new RasterMBLayer(layer); case "symbol": case "circle": case "fill-extrusion": throw new UnsupportedOperationException("MBLayer type "+type+" not yet implemented"); default: throw new MBFormatException(("\"type\" " + type + " is not a valid layer type. Must be one of: " + "background, fill, line, symbol, raster, circle, fill-extrusion")); } } throw new MBFormatException("\"type\" required to create layer."); }
Source:
<code>public void sendNotifications( Map preference, String application, Event event, Map config, String status) { Map<String, ?> execution = (Map<String, ?>) event.getContent().get("execution"); String pipelineConfigId = (String) execution.get("pipelineConfigId"); if (pipelineConfigId == null) { return; } log.info("Received dry run notification for {}", pipelineConfigId); Optional<Pipeline> match = front50 .getPipelines(application) .stream() .filter(pipeline -> pipeline.getId().equals(pipelineConfigId)) .findFirst(); if (!match.isPresent()) { log.error("No pipeline with config id found for {}", pipelineConfigId, application); return; } try { Pipeline pipeline = match.get(); log.warn("Triggering dry run of {}", pipeline.getApplication(), pipeline.getName()); Trigger trigger = Trigger.builder() .type(Trigger.Type.DRYRUN.toString()) .lastSuccessfulExecution(execution) .build(); orca.trigger( pipeline .withName(format("%s (dry run)", pipeline.getName())) .withId(null) .withTrigger(trigger) .withNotifications(mapper.convertValue(properties.getNotifications(), List.class))) .subscribe(response -> log.info("Pipeline triggered: {}", response)); } catch (Exception ex) { <START> log.error(format("Error triggering dry run of %s", pipelineConfigId), ex); <END> } }</code><technical_language>drop format</technical_language>

Target:
public void sendNotifications( Map preference, String application, Event event, Map config, String status) { Map<String, ?> execution = (Map<String, ?>) event.getContent().get("execution"); String pipelineConfigId = (String) execution.get("pipelineConfigId"); if (pipelineConfigId == null) { return; } log.info("Received dry run notification for {}", pipelineConfigId); Optional<Pipeline> match = front50 .getPipelines(application) .stream() .filter(pipeline -> pipeline.getId().equals(pipelineConfigId)) .findFirst(); if (!match.isPresent()) { log.error("No pipeline with config id found for {}", pipelineConfigId, application); return; } try { Pipeline pipeline = match.get(); log.warn("Triggering dry run of {}", pipeline.getApplication(), pipeline.getName()); Trigger trigger = Trigger.builder() .type(Trigger.Type.DRYRUN.toString()) .lastSuccessfulExecution(execution) .build(); orca.trigger( pipeline .withName(format("%s (dry run)", pipeline.getName())) .withId(null) .withTrigger(trigger) .withNotifications(mapper.convertValue(properties.getNotifications(), List.class))) .subscribe(response -> log.info("Pipeline triggered: {}", response)); } catch (Exception ex) { log.error("Error triggering dry run of {}", pipelineConfigId, ex); } }
Source:
<code>public void DeleteAndRestoreMapTests_004_StaffUserCanDeleteMap() { WikiBasePageObject base = new WikiBasePageObject(driver); base.logInCookie(credentials.userNameStaff, credentials.passwordStaff, wikiURL); <START> InteractiveMapPageObject selectedMap = base.openInteractiveMapById(wikiURL, InteractiveMapsContent.mapToDeleteAndRestore); <END> selectedMap.verifyMapOpened(); String deletedMapId = selectedMap.getEmbedMapID(); DeleteAMapComponentObject deleteMapModal = selectedMap.deleteMap(); InteractiveMapsPageObject specialMap = deleteMapModal.deleteMap(); specialMap.verifyMapDeletedMessage(); }</code><technical_language>suggest another MapID for 004 005 break dependency 001 002 successful</technical_language>

Target:
public void DeleteAndRestoreMapTests_004_StaffUserCanDeleteMap() { WikiBasePageObject base = new WikiBasePageObject(driver); base.logInCookie(credentials.userNameStaff, credentials.passwordStaff, wikiURL); InteractiveMapPageObject selectedMap = base.openInteractiveMapById(wikiURL, InteractiveMapsContent.mapToDeleteAndRestore[2]); selectedMap.verifyMapOpened(); DeleteAMapComponentObject deleteMapModal = selectedMap.deleteMap(); InteractiveMapsPageObject specialMap = deleteMapModal.deleteMap(); }
Source:
<code>public void testList() { List<CloudService> response = api().list(); <START> for (CloudService cloudService : api().list()) { <END> checkHostedService(cloudService); } if (!response.isEmpty()) { CloudService cloudService = response.iterator().next(); assertEquals(api().get(cloudService.name()), cloudService); } }</code><technical_language>[minor] for (CS cloudService : response)</technical_language>

Target:
public void testList() { List<CloudService> response = api().list(); for (CloudService cloudService : response) { checkHostedService(cloudService); } if (!response.isEmpty()) { CloudService cloudService = response.iterator().next(); assertEquals(api().get(cloudService.name()), cloudService); } }
Source:
<code>public void setMode(Mode mode) { <START> if (!mode.name().equals(model.getOptionsParam().getViewParam().getMode())) { <END> this.mode = mode; getExtensionLoader().sessionModeChangedAllPlugin(mode); model.getOptionsParam().getViewParam().setMode(mode.name()); } }</code><technical_language>do this.mode != mode instead of comparing name</technical_language>

Target:
public void setMode(Mode mode) { if (this.mode != mode) { this.mode = mode; getExtensionLoader().sessionModeChangedAllPlugin(mode); model.getOptionsParam().getViewParam().setMode(mode.name()); } }
Source:
<code>public synchronized void loadAccounts() { accounts = new HashMap<String, Account>(); accountsInOrder = new LinkedList<Account>(); String accountUuids = getStorage().getString("accountUuids", null); if ((accountUuids != null) && (accountUuids.length() != 0)) { String[] uuids = accountUuids.split(","); for (String uuid : uuids) { Account newAccount = new Account(this, uuid); accounts.put(uuid, newAccount); accountsInOrder.add(newAccount); } } if ((newAccount != null) && newAccount.getAccountNumber() != -1) { accounts.put(newAccount.getUuid(), newAccount); <START> if (!accountsInOrder.contains(newAccount)) <END> accountsInOrder.add(newAccount); newAccount = null; } }</code><technical_language>Code style issue: if body is wrapped in braces</technical_language>

Target:
public synchronized void loadAccounts() { accounts = new HashMap<String, Account>(); accountsInOrder = new LinkedList<Account>(); String accountUuids = getStorage().getString("accountUuids", null); if ((accountUuids != null) && (accountUuids.length() != 0)) { String[] uuids = accountUuids.split(","); for (String uuid : uuids) { Account newAccount = new Account(this, uuid); accounts.put(uuid, newAccount); accountsInOrder.add(newAccount); } } if ((newAccount != null) && newAccount.getAccountNumber() != -1) { accounts.put(newAccount.getUuid(), newAccount); if (!accountsInOrder.contains(newAccount)) { accountsInOrder.add(newAccount); } newAccount = null; } }
Source:
<code>private byte[] wrapConfidentialityProtectedMessage(byte[] message, int offset, int len) throws SaslException { byte[] messageMac = computeHMAC(wrapHmacKeyIntegrity, wrapSeqNum, hmacMD5, message, offset, len); int paddingLength = 0; byte[] pad = null; int blockSize = wrapCipher.getBlockSize(); if (blockSize > 0) { paddingLength = blockSize - ((len + 10) % blockSize); pad = new byte[paddingLength]; Arrays.fill(pad, (byte)paddingLength); } byte[] toCipher = new byte[len + paddingLength + 10]; System.arraycopy(message, offset, toCipher, 0, len); if (paddingLength > 0) { System.arraycopy(pad, 0, toCipher, len, paddingLength); } System.arraycopy(messageMac, 0, toCipher, len + paddingLength, 10); byte[] cipheredPart = null; byte[] result = null; try { cipheredPart = wrapCipher.update(toCipher); <START> <END> result = new byte[cipheredPart.length + 6]; System.arraycopy(cipheredPart, 0, result, 0, cipheredPart.length); integerByteOrdered(1, result, cipheredPart.length, 2); integerByteOrdered(wrapSeqNum, result, cipheredPart.length + 2, 4); } catch (Exception e) { throw log.mechProblemDuringCrypt(getMechanismName(), e).toSaslException(); } wrapSeqNum++; return result; }</code><technical_language>This change allowing NullPointerException thrown wrap later. Instead I detect handle null - specific cases null I a message logged trace error better</technical_language>

Target:
private byte[] wrapConfidentialityProtectedMessage(byte[] message, int offset, int len) throws SaslException { byte[] messageMac = computeHMAC(wrapHmacKeyIntegrity, wrapSeqNum, hmacMD5, message, offset, len); int paddingLength = 0; byte[] pad = null; int blockSize = wrapCipher.getBlockSize(); if (blockSize > 0) { paddingLength = blockSize - ((len + 10) % blockSize); pad = new byte[paddingLength]; Arrays.fill(pad, (byte)paddingLength); } byte[] toCipher = new byte[len + paddingLength + 10]; System.arraycopy(message, offset, toCipher, 0, len); if (paddingLength > 0) { System.arraycopy(pad, 0, toCipher, len, paddingLength); } System.arraycopy(messageMac, 0, toCipher, len + paddingLength, 10); byte[] cipheredPart = null; try { cipheredPart = wrapCipher.update(toCipher); } catch (Exception e) { throw log.mechProblemDuringCrypt(getMechanismName(), e).toSaslException(); } if (cipheredPart == null){ throw log.mechProblemDuringCryptResultIsNull(getMechanismName()).toSaslException(); } byte[] result = new byte[cipheredPart.length + 6]; System.arraycopy(cipheredPart, 0, result, 0, cipheredPart.length); integerByteOrdered(1, result, cipheredPart.length, 2); integerByteOrdered(wrapSeqNum, result, cipheredPart.length + 2, 4); wrapSeqNum++; return result; }
Source:
<code>public PingServiceGrpc.PingServiceBlockingStub getBlockingPingClient( final String serverHost, final int serverPort ) { <START> final Channel channel = channelFactory.getSharedManagedChannel(serverHost, serverPort); <END> return PingServiceGrpc.newBlockingStub(channel); }</code><technical_language>combine return line</technical_language>

Target:
public PingServiceGrpc.PingServiceBlockingStub getBlockingPingClient( final String serverHost, final int serverPort ) { return PingServiceGrpc.newBlockingStub( channelFactory.getSharedManagedChannel(serverHost, serverPort) ); }
Source:
<code>public String getInstallationLocationNamespace() { <START> String kubernetesNamespace = System.getenv("KUBERNETES_NAMESPACE"); String podNamespace = System.getenv("POD_NAMESPACE"); <END> return kubernetesNamespace == null ? podNamespace : kubernetesNamespace; }</code><technical_language>move logic of obtaining env vars @PostConstruct avoid reading env vars call</technical_language>

Target:
public String getInstallationLocationNamespace() { if (kubernetesNamespace == null && podNamespace == null) { LOG.warn( "Neither KUBERNETES_NAMESPACE nor POD_NAMESPACE is defined. Unable to determine Che installation location"); } return kubernetesNamespace == null ? podNamespace : kubernetesNamespace; }
Source:
<code>public void init() { if (initialized) { return; } this.totalBuffer = bufferSupplier.get(); <START> LimitedBufferGrouper.validateBufferCapacity( <END> limit, maxLoadFactor, totalBuffer, bucketSize ); int heapByteSize = (limit + 1) * Ints.BYTES; int hashTableSize = ByteBufferHashTable.calculateTableArenaSizeWithFixedAdditionalSize( totalBuffer.capacity(), bucketSize, heapByteSize ); hashTableBuffer = totalBuffer.duplicate(); hashTableBuffer.position(0); hashTableBuffer.limit(hashTableSize); hashTableBuffer = hashTableBuffer.slice(); offsetHeapBuffer = totalBuffer.duplicate(); offsetHeapBuffer.position(hashTableSize); offsetHeapBuffer = offsetHeapBuffer.slice(); offsetHeapBuffer.limit(totalBuffer.capacity() - hashTableSize); this.hashTable = new AlternatingByteBufferHashTable( maxLoadFactor, initialBuckets, bucketSize, hashTableBuffer, keySize, bufferGrouperMaxSize ); this.heapIndexUpdater = new BufferGrouperOffsetHeapIndexUpdater(totalBuffer, bucketSize - Ints.BYTES); this.offsetHeap = new ByteBufferMinMaxOffsetHeap(offsetHeapBuffer, limit, makeHeapComparator(), heapIndexUpdater); reset(); initialized = true; }</code><technical_language>validateBufferCapacity private called instead of qualifying classname? a private utility method me</technical_language>

Target:
public void init() { if (initialized) { return; } this.totalBuffer = bufferSupplier.get(); validateBufferCapacity( limit, maxLoadFactor, totalBuffer, bucketSize ); int heapByteSize = (limit + 1) * Ints.BYTES; int hashTableSize = ByteBufferHashTable.calculateTableArenaSizeWithFixedAdditionalSize( totalBuffer.capacity(), bucketSize, heapByteSize ); hashTableBuffer = totalBuffer.duplicate(); hashTableBuffer.position(0); hashTableBuffer.limit(hashTableSize); hashTableBuffer = hashTableBuffer.slice(); offsetHeapBuffer = totalBuffer.duplicate(); offsetHeapBuffer.position(hashTableSize); offsetHeapBuffer = offsetHeapBuffer.slice(); offsetHeapBuffer.limit(totalBuffer.capacity() - hashTableSize); this.hashTable = new AlternatingByteBufferHashTable( maxLoadFactor, initialBuckets, bucketSize, hashTableBuffer, keySize, bufferGrouperMaxSize ); this.heapIndexUpdater = new BufferGrouperOffsetHeapIndexUpdater(totalBuffer, bucketSize - Ints.BYTES); this.offsetHeap = new ByteBufferMinMaxOffsetHeap(offsetHeapBuffer, limit, makeHeapComparator(), heapIndexUpdater); reset(); initialized = true; }
Source:
<code>public Disk update(Disk incoming) { if (incoming.isSetQcowVersion()) { <START> return performUpdate( <END> incoming, new QueryIdResolver<>(QueryType.GetDiskByDiskId, IdQueryParameters.class), ActionType.AmendImageGroupVolumes, new UpdateParametersProvider()); } return performUpdate(incoming, new DiskResolver(), ActionType.UpdateVmDisk, new BackendDiskResource.UpdateParametersProvider()); }</code><technical_language>updating QCOW other parameters in call</technical_language>

Target:
public Disk update(Disk incoming) { if (incoming.isSetQcowVersion()) { return performUpdate( incoming, new QueryIdResolver<>(QueryType.GetDiskByDiskId, IdQueryParameters.class), ActionType.AmendImageGroupVolumes, new UpdateParametersProvider()); } return performUpdate(incoming, new QueryIdResolver<>(QueryType.GetDiskByDiskId, IdQueryParameters.class), ActionType.UpdateVmDisk, new BackendDiskResource.UpdateParametersProvider()); }