auphong2707/dl4se-code-review-dataset huggingface dataset:
Source:
<code><START> public Map<String, String> buildVocabularyVersionMap() { <END> final List<VocabularyV5> allVersions = vocabularyRepository.findAll(); return allVersions.stream() .collect(HashMap::new, (m, v) -> m.put(v.getId(), v.getVersion()), HashMap::putAll); }</code><technical_language>this public. providing internal structure is needed</technical_language>

Target:
private Map<String, String> buildVocabularyVersionMap() { final List<VocabularyV5> allVersions = vocabularyRepository.findAll(); return allVersions.stream() .collect(HashMap::new, (m, v) -> m.put(v.getId(), v.getVersion()), HashMap::putAll); }
Source:
<code>private static BagitFileValues parseValues(final Path bagitFile) throws UnparsableVersionException, IOException, InvalidBagMetadataException{ logger.debug("Reading file", bagitFile); final List<SimpleImmutableEntry<String, String>> pairs = KeyValueReader.readKeyValuesFromFile(bagitFile, ":", StandardCharsets.UTF_8); final BagitFileValues values = new BagitFileValues(); String version = ""; Charset encoding = StandardCharsets.UTF_8; for(final SimpleImmutableEntry<String, String> pair : pairs){ if("BagIt-Version".equals(pair.getKey())){ version = pair.getValue(); logger.debug("BagIt-Version is [{}]", version); values.version = parseVersion(version); } if("Tag-File-Character-Encoding".equals(pair.getKey())){ encoding = Charset.forName(pair.getValue()); logger.debug("Tag-File-Character-Encoding is [{}]", encoding); values.encoding = encoding; } if("Payload-Byte-Count".equals(pair.getKey())){ <START> logger.debug("Payload-Byte-Count is [{}]", pair.getKey()); <END> values.payloadByteCount = Long.valueOf(pair.getValue()); } if("Payload-File-Count".equals(pair.getKey())){ logger.debug("Payload-File-Count is [{}]", pair.getKey()); values.payloadFileCount = Long.valueOf(pair.getValue()); } } return values; }</code><technical_language>this getValue</technical_language>

Target:
public static BagitFileValues parseValues(final Path bagitFile) throws UnparsableVersionException, IOException, InvalidBagMetadataException{ logger.debug("Reading file", bagitFile); final List<SimpleImmutableEntry<String, String>> pairs = KeyValueReader.readKeyValuesFromFile(bagitFile, ":", StandardCharsets.UTF_8); Version version = null; Charset encoding = StandardCharsets.UTF_8; Long payloadByteCount = null; Long payloadFileCount = null; for(final SimpleImmutableEntry<String, String> pair : pairs){ if("BagIt-Version".equals(pair.getKey())){ version = parseVersion(pair.getValue()); } if("Tag-File-Character-Encoding".equals(pair.getKey())){ encoding = Charset.forName(pair.getValue()); } if("Payload-Byte-Count".equals(pair.getKey())){ payloadByteCount = Long.valueOf(pair.getValue()); } if("Payload-File-Count".equals(pair.getKey())){ payloadFileCount = Long.valueOf(pair.getValue()); } logger.debug("[{}] is [{}]", pair.getKey(), pair.getValue()); } return new BagitFileValues(version, encoding, payloadByteCount, payloadFileCount); }
Source:
<code>public void testTaskCreate() { AnnotationConfigApplicationContext createContext = new AnnotationConfigApplicationContext(); <START> createContext.register(TestDefaultConfiguration.class, PropertyPlaceholderAutoConfiguration.class); <END> final Appender mockAppender = TestVerifierUtils.getMockAppender(); createContext.refresh(); this.listener = createContext.getBean(TaskLifecycleListener.class); TestVerifierUtils.verifyLogEntryExists(mockAppender, "Creating: TaskExecution{executionId='" + listener.getTaskExecution().getExecutionId()); assertEquals("Create should report that exit code is zero", 0, listener.getTaskExecution().getExitCode()); }</code><technical_language>create a @Before method handle initializtion of context registration of configuration classes (i.e. lines 48-49, 63-64, 78-79). a @After method close context</technical_language>

Target:
public void testTaskCreate() { final Appender mockAppender = TestVerifierUtils.getMockAppender(); context.refresh(); this.listener = context.getBean(TaskLifecycleListener.class); TestVerifierUtils.verifyLogEntryExists(mockAppender, "Creating: TaskExecution{executionId='" + listener.getTaskExecution().getExecutionId()); assertEquals("Create should report that exit code is zero", 0, listener.getTaskExecution().getExitCode()); }
Source:
<code>public MantaConnectionFactory(final ConfigContext config, final KeyPair keyPair, final ThreadLocalSigner signer, final MantaConnectionFactoryConfigurator connectionFactoryConfigurator) { Validate.notNull(config, "Configuration context must not be null"); this.config = config; if (connectionFactoryConfigurator != null) { <START> this.connectionManager = connectionFactoryConfigurator.getConnectionManager(); <END> this.httpClientBuilder = connectionFactoryConfigurator.getHttpClientBuilder(); this.connectionManagerShared = true; } else { this.connectionManager = buildConnectionManager(); this.httpClientBuilder = createStandardBuilder(); this.connectionManagerShared = false; } configureHttpClientBuilderDefaults(keyPair, signer); }</code><technical_language>Set null instead</technical_language>

Target:
public MantaConnectionFactory(final ConfigContext config, final KeyPair keyPair, final ThreadLocalSigner signer, final MantaConnectionFactoryConfigurator connectionFactoryConfigurator) { Validate.notNull(config, "Configuration context must not be null"); this.config = config; if (connectionFactoryConfigurator != null) { this.connectionManager = null; this.httpClientBuilder = connectionFactoryConfigurator.getHttpClientBuilder(); } else { this.connectionManager = buildConnectionManager(); this.httpClientBuilder = createStandardBuilder(); } configureHttpClientBuilderDefaults(keyPair, signer); }
Source:
<code>public void bufferExactFailingSupplier() { <START> Scheduler.Worker w = new TestScheduler().createWorker(); <END> TestObserver<List<Integer>> observer = new TestObserver<List<Integer>>(); BufferExactBoundedObserver<Integer, List<Integer>> buf = new BufferExactBoundedObserver<Integer, List<Integer>>(observer, ArrayListSupplier.<Integer>asCallable(), 100, TimeUnit.MILLISECONDS, 10, false, w); buf.onError(new Throwable()); buf.onComplete(); }</code><technical_language>list supplier fail, calling onError onCompleted this is a plain protocol violation. Do this instead: java Observable.empty() .buffer(10, 10, TimeUnit.SECONDS, Schedulers.computation(), new Callable<List<Object>>() { @Override public void call() { throw new TestException(); } }) .test() .awaitDone(5, TimeUnit.SECONDS) .assertFailure(TestException.class) ;</technical_language>

Target:
public void bufferExactFailingSupplier() { Observable.empty() .buffer(1, TimeUnit.SECONDS, Schedulers.computation(), 10, new Callable<List<Object>>() { @Override public List<Object> call() throws Exception { throw new TestException(); } }, false) .test() .awaitDone(1, TimeUnit.SECONDS) .assertFailure(TestException.class) ; }
Source:
<code>private String generateSequenceId() { <START> if (!Sirius.isFrameworkEnabled(Sequences.FRAMEWORK_SEQUENCES)) { <END> throw Exceptions.handle() .to(Mongo.LOG) .withSystemErrorMessage( "Can not generate sequential id for entity of type %s, as the framework %s is not active!", getTypeName(), Sequences.FRAMEWORK_SEQUENCES) .handle(); } return String.valueOf(sequences.generateId(getTypeName())); }</code><technical_language>suggestion if (sequences == null) {</technical_language>

Target:
private String generateSequenceId() { if (sequences == null) { throw Exceptions.handle() .to(Mongo.LOG) .withSystemErrorMessage( "Can not generate sequential id for entity of type %s, as the framework %s is not active!", getTypeName(), Sequences.FRAMEWORK_SEQUENCES) .handle(); } return String.valueOf(sequences.generateId(getTypeName())); }
Source:
<code><START> protected UberallsClient getUberallsClient(Logger logger, String gitUrl, String branch) { <END> if (uberallsClient != null) { return uberallsClient; } return new UberallsClient( getDescriptor().getUberallsURL(), logger, gitUrl, branch ); }</code><technical_language>this is used. set uberallsClient return instance if null with. This way, if this is called multiple times, return cached instance</technical_language>

Target:
protected UberallsClient getUberallsClient(Logger logger, String gitUrl, String branch) { if (uberallsClient != null) { return uberallsClient; } setUberallsClient(new UberallsClient( getDescriptor().getUberallsURL(), logger, gitUrl, branch )); return uberallsClient; }
Source:
<code>public static void setup() { topLimitSwitch.send(new BooleanOutput() { public void set(boolean value) { if (value && elevatorSpeed.get() > 0) { elevatorSpeed.set(0.0f); } } }); bottomLimitSwitch.send(new BooleanOutput() { public void set(boolean value) { if (value && elevatorSpeed.get() < 0) { elevatorSpeed.set(0.0f); } } <START> }); <END> raisingInput.send(new BooleanOutput() { public void set(boolean value) { if (value) { elevatorControl.set(value); } } }); loweringInput.send(new BooleanOutput() { public void set(boolean value) { if (value) { elevatorControl.set(!value); } } }); }</code><technical_language>this section done in a more dataflow-like manner. Consider flipping elevatorSpeed.setWhen. note this currently update (and stop elevator) limit switch changes. This means if bottom, stopped down. Consider adding this input control, start moving if target</technical_language>

Target:
public static void setup() { elevatorSpeed.setWhen(0.0f, EventMixing.filterEvent(topLimitSwitch, true, Igneous.globalPeriodic)); elevatorSpeed.setWhen(0.0f, EventMixing.filterEvent(bottomLimitSwitch, true, Igneous.globalPeriodic)); elevatorControl.setTrueWhen(raisingInput); elevatorControl.setFalseWhen(loweringInput); elevatorSpeed.set(0.0f); }
Source:
<code>ReturnStmpVisitor(IASTFunctionDefinition func) { shouldVisitStatements = true; shouldVisitDeclarations = true; shouldVisitExpressions = true; this.func = func; this.hasret = false; <START> IASTPointerOperator[] ptr = func.getDeclarator().getPointerOperators(); <END> if (ptr.length > 0 && ptr[0] instanceof ICPPASTReferenceOperator) { analizer = new ReturnTypeAnalizer(RET_TYPE.BY_REF); } else if (ptr.length > 0 && ptr[0] instanceof IASTPointer) { analizer = new ReturnTypeAnalizer(RET_TYPE.BY_PTR); } else analizer = null; }</code><technical_language>in const/static checker, want check for a pointer / reference based IType, based pointer operators, handle typedefs</technical_language>

Target:
ReturnStmpVisitor(IASTFunctionDefinition func) { shouldVisitStatements = true; shouldVisitDeclarations = true; shouldVisitExpressions = true; this.func = func; this.hasret = false; IBinding binding = func.getDeclarator().getName().resolveBinding(); if (binding instanceof IFunction) { IType retType = SemanticUtil.getNestedType(((IFunction) binding).getType().getReturnType(), SemanticUtil.TDEF); if (retType instanceof ICPPReferenceType) { analyzer = new ReturnTypeAnalyzer(RetType.BY_REF); } else if (retType instanceof IPointerType) { analyzer = new ReturnTypeAnalyzer(RetType.BY_PTR); } else analyzer = null; } else analyzer = null; }
Source:
<code>HardDeleteThread() { <START> this.throttler = <END> new Throttler(config.storeHardDeleteBytesPerSec, throttlerCheckIntervalMs, true, SystemTime.getInstance()); }</code><technical_language>related this patch. hardDeleterSleepTimeWhenCaughtUpMs is configurable hardcoded</technical_language>

Target:
HardDeleteThread() { this.throttler = new Throttler(config.storeHardDeleteBytesPerSec, throttlerCheckIntervalMs, true, time); }
Source:
<code>public void emitTuples() { if (windowId > lastCompletedWId) { <START> if (pendingMessage != null) { <END> super.emitTuples(); } else { processMessage(pendingMessage); pendingMessage = null; } } }</code><technical_language>pendingMessage == null check</technical_language>

Target:
public void emitTuples() { if (windowId > lastCompletedWId) { if (pendingMessage == null) { super.emitTuples(); } else { processMessage(pendingMessage); pendingMessage = null; } } }
Source:
<code>private void restartPythonProcess() { PythonInterpreter python = getPythonInterpreter(); <START> logger.info("-----------> " + python); <END> python.close(); python.open(); }</code><technical_language>logger.debug more appropriate</technical_language>

Target:
private void restartPythonProcess() { PythonInterpreter python = getPythonInterpreter(); python.close(); python.open(); }
Source:
<code>public SpinExecutorService(int maxTasks) { tasks = PlatformDependent.newFixedMpscQueue(maxTasks); executorThread = new Thread(new Runnable() { @Override public void run() { final Queue<Runnable> tasks = SpinExecutorService.this.tasks; while (true) { final Runnable task = tasks.poll(); if (task != null) { if (task == POISON_PILL) { return; <START> } else { <END> task.run(); } } } } }); executorThread.start(); }</code><technical_language>this simplified: java Runnable task; while ((task = tasks.poll()) != POISON_PILL) { if (task != null) { task.run(); } }</technical_language>

Target:
public SpinExecutorService(int maxTasks) { tasks = PlatformDependent.newFixedMpscQueue(maxTasks); executorThread = new Thread(new Runnable() { @Override public void run() { final Queue<Runnable> tasks = SpinExecutorService.this.tasks; Runnable task; while ((task = tasks.poll()) != POISON_PILL) { if (task != null) { task.run(); } } } }); executorThread.start(); }
Source:
<code><START> public ImmutableList<K> keys() { <END> K[] pairs = ((K[]) new Object[this.length]); int[] i = new int[1]; this.forEach(x -> pairs[i[0]++] = x.left()); return ImmutableList.from(pairs); }</code><technical_language>return ImmutableSet, right</technical_language>

Target:
public ImmutableSet<K> keys() { return new ImmutableSet<>(this.map(F.constant(Unit.unit))); }
Source:
<code>EventStore eventStore() { <START> return this.boundedContext() <END> .eventBus() .eventStore(); }</code><technical_language>need this.. refer instance methods else this</technical_language>

Target:
EventStore eventStore() { return boundedContext() .eventBus() .eventStore(); }
Source:
<code>public String getMessage(NetworkItemModel<?> op1, NetworkItemModel<?> op2) { <START> return appendDetachNetworkSuggestion(getVerb(getNotInSyncNetwork(op2)), op2); <END> }</code><technical_language>appendDetachNetworkSuggestion takes problematic network 'CulpritNetwork'. work 'getNotInSyncNetwork' return a nework 'CulpritNetwork'. I a running env code a bug, print network parts of message, it</technical_language>

Target:
public String getMessage(NetworkItemModel<?> op1, NetworkItemModel<?> op2) { return appendDetachNetworkSuggestion(getVerb(op1), op2); }
Source:
<code>public void dispose() { mSimRecords.unregisterForRecordsLoaded(this); mSimCard.unregisterForAbsent(this); <START> <END> this.removeMessages(EVENT_SIM_LOADED); this.removeMessages(EVENT_SIM_ABSENT); mSimRecords = null; mSimCard = null; }</code><technical_language>this.removeCallbacksAndMessages(null) instead</technical_language>

Target:
public void dispose() { mSimRecords.unregisterForRecordsLoaded(this); mSimCard.unregisterForAbsent(this); mCmdIf.unSetOnStkSessionEnd(this); mCmdIf.unSetOnStkProactiveCmd(this); mCmdIf.unSetOnStkEvent(this); mCmdIf.unSetOnStkCallSetUp(this); this.removeCallbacksAndMessages(null); mSimRecords = null; mSimCard = null; }
Source:
<code>Type(String name, Repetition repetition, OriginalType originalType, ID id) { super(); name = checkNotNull(name, "name"); if (name.charAt(0) == '`') { name = name.substring(1, name.length() - 1).replace("``", "`"); <START> } <END> this.repetition = checkNotNull(repetition, "repetition"); this.name = name; this.originalType = originalType; this.id = id; }</code><technical_language>check character is a quote. factor out logic MessageTypeParser.Tokenizer.getName()</technical_language>

Target:
Type(String name, Repetition repetition, OriginalType originalType, ID id) { super(); name = checkNotNull(name, "name"); this.repetition = checkNotNull(repetition, "repetition"); this.name = name; this.originalType = originalType; this.id = id; }
Source:
<code>public static void checkShouldRefreshFeeds(Context context) { long interval = 0; if(UserPreferences.getUpdateInterval() > 0) { interval = UserPreferences.getUpdateInterval(); } else if(UserPreferences.getUpdateTimeOfDay().length > 0){ interval = TimeUnit.DAYS.toMillis(1); } if(interval == 0) { return; } SharedPreferences prefs = context.getSharedPreferences(PREF_NAME, MODE_PRIVATE); long lastRefresh = prefs.getLong(PREF_LAST_REFRESH, 0); Log.d(TAG, "last refresh: " + Converter.getDurationStringLocalized(context, System.currentTimeMillis() - lastRefresh) + " ago"); if(lastRefresh <= System.currentTimeMillis() - interval) { <START> DBTasks.refreshAllFeeds(context, null, null); <END> } }</code><technical_language>Please overload method. Passing null is a bad practice</technical_language>

Target:
public static void checkShouldRefreshFeeds(Context context) { long interval = 0; if(UserPreferences.getUpdateInterval() > 0) { interval = UserPreferences.getUpdateInterval(); } else if(UserPreferences.getUpdateTimeOfDay().length > 0){ interval = TimeUnit.DAYS.toMillis(1); } if(interval == 0) { return; } SharedPreferences prefs = context.getSharedPreferences(PREF_NAME, MODE_PRIVATE); long lastRefresh = prefs.getLong(PREF_LAST_REFRESH, 0); Log.d(TAG, "last refresh: " + Converter.getDurationStringLocalized(context, System.currentTimeMillis() - lastRefresh) + " ago"); if(lastRefresh <= System.currentTimeMillis() - interval) { DBTasks.refreshAllFeeds(context, null); } }
Source:
<code>private void lookupDatabase() { try { log.tracef( "Retrieving MongoDatabase from JNDI at %1$s", config.getNativeClientResource() ); mongoDb = (MongoDatabase) jndiService.locate( config.getNativeClientResource() ); } catch (RuntimeException e) { throw log.errorOnFetchJndiClientProperty( config.getNativeClientResource() ); } <START> this.jndiService = null; <END> }</code><technical_language>critical I find counter intuitive lookup method clear, move end of start method</technical_language>

Target:
private void lookupDatabase() { try { log.tracef( "Retrieving MongoDatabase from JNDI at %1$s", config.getNativeClientResource() ); mongoDb = (MongoDatabase) jndiService.locate( config.getNativeClientResource() ); } catch (RuntimeException e) { throw log.errorOnFetchJndiClientProperty( config.getNativeClientResource() ); } }
Source:
<code>public ModelAndView editCollectionFormGenerator(HttpServletRequest request, @RequestParam(value="collectionId") Long collectionId) { CollectedSample collectedSample = collectedSampleRepository.findCollectedSampleById(collectionId); CollectedSampleBackingForm form = new CollectedSampleBackingForm(collectedSample); ModelAndView mv = new ModelAndView("collections/editCollectionForm"); mv.addObject("editCollectionForm", form); mv.addObject("refreshUrl", getUrl(request)); addEditSelectorOptions(mv.getModelMap()); Map<String, Map<String, Object>> formFields = utilController.getFormFieldsForForm("collectedSample"); mv.addObject("collectionFields", formFields); <START> return mv; <END> }</code><technical_language>@gtlnikita - justify changes formatting of CollectedSampleController.java? If not, changes reverted original formatting. This difficult if changes formatting indenting code. Also, new method List<String> findLastDonationForDonor follow standard formatting guidelines</technical_language>

Target:
public ModelAndView editCollectionFormGenerator(HttpServletRequest request, @RequestParam(value="collectionId") Long collectionId) { CollectedSample collectedSample = collectedSampleRepository.findCollectedSampleById(collectionId); CollectedSampleBackingForm form = new CollectedSampleBackingForm(collectedSample); form.getCollectedSampleIntegerProps(); ModelAndView mv = new ModelAndView("collections/editCollectionForm"); mv.addObject("editCollectionForm", form); mv.addObject("refreshUrl", getUrl(request)); addEditSelectorOptions(mv.getModelMap()); Map<String, Map<String, Object>> formFields = utilController.getFormFieldsForForm("collectedSample"); mv.addObject("collectionFields", formFields); return mv; }
Source:
<code>public boolean preProcess(BindContext context) { Consumer consumer = context.getConsumer(); Map<String, Entitlement> entitlements = context.getEntitlementMap(); Map<String, PoolQuantity> poolQuantities = context.getPoolQuantities(); Set<String> stackIds = new HashSet<>(); for (PoolQuantity poolQuantity : poolQuantities.values()) { if (poolQuantity.getPool().isStacked()) { stackIds.add(poolQuantity.getPool().getStackId()); } } ConsumerType ctype = this.consumerTypeCurator.getConsumerType(consumer); for (Entry<String, Entitlement> entitlementEntry : entitlements.entrySet()) { String poolId = entitlementEntry.getKey(); Entitlement entitlement = entitlementEntry.getValue(); entitlement.setPool(poolQuantities.get(poolId).getPool()); } if (!stackIds.isEmpty() && !ctype.isType(ConsumerTypeEnum.SHARE) && !ctype.isManifest()) { subPoolsForStackIds = poolCurator.getSubPoolForStackIds(consumer, stackIds); if (CollectionUtils.isNotEmpty(subPoolsForStackIds)) { poolManager.updatePoolsFromStackWithoutDeletingStack(consumer, subPoolsForStackIds, entitlements.values()); } } else { subPoolsForStackIds = new ArrayList<>(); } delayedPoolOp.appendDelayedOp( <START> enforcer.postEntitlement(poolManager, <END> consumer, context.getOwner(), entitlements, subPoolsForStackIds, false, poolQuantities)); for (Entitlement entitlement : entitlements.values()) { entitlement.setPool(null); } return true; }</code><technical_language>indentation is kind of here. java delayedPoolOp.appendDelayedOp(enforcer.postEntitlement( poolManager, consumer, context.getOwner(), entitlements, subPoolsForStackIds, false, poolQuantities )); more clear</technical_language>

Target:
public boolean preProcess(BindContext context) { Consumer consumer = context.getConsumer(); Map<String, Entitlement> entitlements = context.getEntitlementMap(); Map<String, PoolQuantity> poolQuantities = context.getPoolQuantities(); Set<String> stackIds = new HashSet<>(); for (PoolQuantity poolQuantity : poolQuantities.values()) { if (poolQuantity.getPool().isStacked()) { stackIds.add(poolQuantity.getPool().getStackId()); } } ConsumerType ctype = this.consumerTypeCurator.getConsumerType(consumer); for (Entry<String, Entitlement> entitlementEntry : entitlements.entrySet()) { String poolId = entitlementEntry.getKey(); Entitlement entitlement = entitlementEntry.getValue(); entitlement.setPool(poolQuantities.get(poolId).getPool()); } if (!stackIds.isEmpty() && !ctype.isType(ConsumerTypeEnum.SHARE) && !ctype.isManifest()) { subPoolsForStackIds = poolCurator.getSubPoolForStackIds(consumer, stackIds); if (CollectionUtils.isNotEmpty(subPoolsForStackIds)) { poolManager.updatePoolsFromStackWithoutDeletingStack(consumer, subPoolsForStackIds, entitlements.values()); } } else { subPoolsForStackIds = new ArrayList<>(); } poolOperationCallback.appendCallback(enforcer.postEntitlement(poolManager, consumer, context.getOwner(), entitlements, subPoolsForStackIds, false, poolQuantities )); for (Entitlement entitlement : entitlements.values()) { entitlement.setPool(null); } return true; }
Source:
<code>protected void emitContent(String content) throws IOException { if (isEmptyContent(content)) { content <START> = prefix + <END> " "; } content = content.replaceAll("(\\r|\\n)+", " "); super.emitContent(content); }</code><technical_language>is prefix added here</technical_language>

Target:
protected void emitContent(String content) throws IOException { if (Strings.isNullOrEmpty(content)) { content = " "; } content = content.replaceAll("(\\r|\\n)+", " "); super.emitContent(content); }
Source:
<code>public boolean isInQualifier(BitSet bitSet) throws StandardException { if (bitSet == null) return false; InListOperatorNode sourceInList=getSourceInList(); if(sourceInList==null) return false; for (Object o : sourceInList.getLeftOperandList()) { ValueNode lo = (ValueNode) o; if (!(lo instanceof ColumnReference)) return false; ColumnReference colRef = (ColumnReference) lo; int colNum = colRef.getColumnNumber(); if (!bitSet.get(colNum)) return false; } ValueNodeList rightOperandList=sourceInList.getRightOperandList(); for(Object o:rightOperandList){ if(!(o instanceof ConstantNode)) { if (o instanceof ListValueNode) { if (!((ListValueNode)o).allConstantsNodesInList()) return false; } <START> return false; END> } } return true; }</code><technical_language>I "return false" here(at line 1313) need put in else block, otherwise, o of ListValueNode constant values a chance returned true</technical_language>

Target:
public boolean isInQualifier(BitSet bitSet) throws StandardException { if (bitSet == null) return false; InListOperatorNode sourceInList=getSourceInList(); if(sourceInList==null) return false; for (Object o : sourceInList.getLeftOperandList()) { ValueNode lo = (ValueNode) o; if (!(lo instanceof ColumnReference)) return false; ColumnReference colRef = (ColumnReference) lo; int colNum = colRef.getColumnNumber(); if (!bitSet.get(colNum)) return false; } ValueNodeList rightOperandList=sourceInList.getRightOperandList(); for(Object o:rightOperandList){ if(!(o instanceof ConstantNode)) { if (o instanceof ListValueNode) { if (!((ListValueNode)o).allConstantsNodesInList()) return false; } else return false; } } return true; }
Source:
<code>private void relinquishLeadership(HelixManager manager, ControllerManagerHelper controllerHelper) { long start = System.currentTimeMillis(); LOG.info(manager.getInstanceName() + " tries to relinquish leadership for cluster: " + manager .getClusterName()); controllerHelper.stopControllerTimerTasks(); controllerHelper.removeListenersFromController(_controller); manager.getHelixDataAccessor().getBaseDataAccessor().reset(); <START> LOG.info("{} relinquishes leadership for cluster: {}, took: {}", manager.getInstanceName(), <END> manager.getClusterName(), System.currentTimeMillis() - start); }</code><technical_language>Correct if I wrong, I record "onControllerChange" processing time. easy derive latency log. I feel this log redundant a bit</technical_language>

Target:
private void relinquishLeadership(HelixManager manager, ControllerManagerHelper controllerHelper) { long start = System.currentTimeMillis(); LOG.info(manager.getInstanceName() + " tries to relinquish leadership for cluster: " + manager .getClusterName()); controllerHelper.stopControllerTimerTasks(); controllerHelper.removeListenersFromController(_controller); manager.getHelixDataAccessor().getBaseDataAccessor().reset(); LOG.info("{} relinquishes leadership for cluster: {}, took: {}ms", manager.getInstanceName(), manager.getClusterName(), System.currentTimeMillis() - start); }
Source:
<code>public static void configureTransactionManager(ModelControllerClient mcc, HashMap<String, String> serverProperties) throws Exception { TransactionsJBossASClient client = new TransactionsJBossASClient(mcc); client.setDefaultTransactionTimeout(600); LOG.info("Default transaction timeout set to 600 seconds."); final HashMap<String, String> transactionNodeIdDefault = new HashMap(); transactionNodeIdDefault.put(ServerProperties.PROP_JBOSS_HA_NODE_ID, "1"); String nodeId = buildExpression(ServerProperties.PROP_JBOSS_HA_NODE_ID, transactionNodeIdDefault, true, false, false); client.setTransactionNodeId(nodeId); <START> LOG.info("Set high availability nodeId to " + nodeId); <END> }</code><technical_language>I this logging removed if setting defined. confusing otherwise-</technical_language>

Target:
public static void configureTransactionManager(ModelControllerClient mcc, HashMap<String, String> serverProperties) throws Exception { TransactionsJBossASClient client = new TransactionsJBossASClient(mcc); client.setDefaultTransactionTimeout(600); LOG.info("Default transaction timeout set to 600 seconds."); final HashMap<String, String> transactionNodeIdDefault = new HashMap(); transactionNodeIdDefault.put(ServerProperties.PROP_JBOSS_HA_NODE_ID, "1"); String nodeId = buildExpression(ServerProperties.PROP_JBOSS_HA_NODE_ID, transactionNodeIdDefault, true, false, false); client.setTransactionNodeId(nodeId); }
Source:
<code>public void destroy() { <START> if(null != FormEditorContext.getActiveEditorHelper() && FormEditorContext.getActiveEditorHelper().equals(editorHelper)) { <END> FormEditorContext.setActiveEditorHelper(null); } editorFieldLayoutComponents.destroyAll(); }</code><technical_language>suggestion if (null != FormEditorContext.getActiveEditorHelper() && FormEditorContext.getActiveEditorHelper().equals(editorHelper)) {</technical_language>

Target:
public void destroy() { if (Objects.equals(FormEditorContext.getActiveEditorHelper(), editorHelper)) { FormEditorContext.setActiveEditorHelper(null); } editorFieldLayoutComponents.destroyAll(); }
Source:
<code><START> public boolean add(JobTaskMoveAssignment assignment) { <END> List<JobKey> jobKeysToTargetHost = moveAssignmentList.stream() .filter(moveAssignment -> moveAssignment.getTargetUUID().equals(assignment.getTargetUUID())) .map(moveAssignment -> moveAssignment.getJobKey()) .collect(Collectors.toList()); if(!jobKeysToTargetHost.contains(assignment.getJobKey())) { bytesUsed += taskSizer.estimateTrueSize(spawn.getTask(assignment.getJobKey())); return this.moveAssignmentList.add(assignment); } return false; }</code><technical_language>big this list get? ArrayList iterations worry if this list large. if stays small (like max=total rebalances a time=6), worried</technical_language>

Target:
public boolean add(JobTaskMoveAssignment assignment) { boolean isJobKeyPresent = this.moveAssignmentList.stream() .anyMatch(moveAssignment -> moveAssignment.getJobKey().equals(assignment.getJobKey()) && moveAssignment.getTargetUUID() != null && moveAssignment.getTargetUUID().equals(assignment.getTargetUUID())); if(!isJobKeyPresent) { bytesUsed += taskSizer.estimateTrueSize(spawn.getTask(assignment.getJobKey())); this.moveAssignmentList.add(assignment); return true; } return false; }
Source:
<code>public void update(CruiseConfig preprocessedConfig) throws Exception { <START> ElasticProfile existingProfile = findExistingProfile(preprocessedConfig); <END> preprocessedConfig.server().getElasticConfig().getProfiles().remove(existingProfile); }</code><technical_language>throw ElasticProfileNotFoundException() if existing profile is null? remove function successfully run null is passed it, user changed</technical_language>

Target:
public void update(CruiseConfig preprocessedConfig) throws Exception { ElasticProfile existingProfile = findExistingProfile(preprocessedConfig); if (existingProfile == null) { throw new ElasticProfileNotFoundException(); } preprocessedConfig.server().getElasticConfig().getProfiles().remove(existingProfile); }
Source:
<code>public void commitTransaction() throws ProducerFencedException { verifyProducerState(); verifyTransactionsInitialized(); verifyNoTransactionInFlight(); if (this.commitTransactionException != null) { throw this.commitTransactionException; } <START> if (this.producerFencedOnCommitTxn) { <END> throw new ProducerFencedException("Producer is fenced"); } flush(); this.sent.addAll(this.uncommittedSends); if (!this.uncommittedConsumerGroupOffsets.isEmpty()) this.consumerGroupOffsets.add(this.uncommittedConsumerGroupOffsets); this.uncommittedSends.clear(); this.uncommittedConsumerGroupOffsets = new HashMap<>(); this.transactionCommitted = true; this.transactionAborted = false; this.transactionInFlight = false; ++this.commitCount; }</code><technical_language>nit: consolidate producerFencedOnCommitTxn more-general commitTransactionException? I.e. if want fence commit, register commitTransactionException a ProducerFencedException</technical_language>

Target:
public void commitTransaction() throws ProducerFencedException { verifyProducerState(); verifyTransactionsInitialized(); verifyTransactionInFlight(); if (this.commitTransactionException != null) { throw this.commitTransactionException; } flush(); this.sent.addAll(this.uncommittedSends); if (!this.uncommittedConsumerGroupOffsets.isEmpty()) this.consumerGroupOffsets.add(this.uncommittedConsumerGroupOffsets); this.uncommittedSends.clear(); this.uncommittedConsumerGroupOffsets = new HashMap<>(); this.transactionCommitted = true; this.transactionAborted = false; this.transactionInFlight = false; ++this.commitCount; }
Source:
<code>protected void afterRunInternal() { for (EventDescriptor descriptor : unpublishedEvents) { <START> mapEventPublisher.publishEvent(descriptor.caller, descriptor.mapName, <END> descriptor.eventType, descriptor.dataKey, descriptor.oldValue, descriptor.dataValue); } invalidateNearCache(invalidationKeys); disposeDeferredBlocks = true; super.afterRunInternal(); }</code><technical_language>catch log exceptions publishEvent method of MapEventPublisherImpl? Reasonings: 1. Centralize place for map operations, some other map operations issue. 2. catch exceptions listener basis minimize blast of failure. For instance, attached 100 listener map of is throwing exceptions, this failure block event flow other listener</technical_language>

Target:
protected void afterRunInternal() { invalidateNearCache(invalidationKeys); super.afterRunInternal(); }
Source:
<code>public void resetIndex(long index, long timestamp) { currentOperation = OperationType.COMMAND; operationIndex = index; currentIndex = index; <START> commitIndex = index; <END> currentTimestamp = timestamp; }</code><technical_language>super this</technical_language>

Target:
public void resetIndex(long index, long timestamp) { currentOperation = OperationType.COMMAND; operationIndex = index; currentIndex = index; currentTimestamp = timestamp; setCommitIndex(index); service.tick(new WallClockTimestamp(currentTimestamp)); }
Source:
<code>private RMContainer createContainer( Resource request, ApplicationAttemptId appAttemptId) { RMContainer container = mock(RMContainer.class); Container containerInner = mock(Container.class); ContainerId id = mock(ContainerId.class); when(id.getContainerId()).thenReturn(containerNum); when(containerInner.getResource()). thenReturn(Resources.clone(request)); when(containerInner.getId()).thenReturn(id); when(containerInner.getExecutionType()). thenReturn(ExecutionType.GUARANTEED); when(container.getApplicationAttemptId()).thenReturn(appAttemptId); when(container.getContainerId()).thenReturn(id); when(container.getContainer()).thenReturn(containerInner); <START> when(container.getExecutionType()).thenReturn(ExecutionType.GUARANTEED); <END> when(container.getAllocatedResource()). thenReturn(Resources.clone(request)); containers.add(container); containerNum++; return container; }</code><technical_language>execution type is repeated. Also, do need add a for these</technical_language>

Target:
private RMContainer createContainer( Resource request, ApplicationAttemptId appAttemptId) { RMContainer container = mock(RMContainer.class); Container containerInner = mock(Container.class); ContainerId id = mock(ContainerId.class); when(id.getContainerId()).thenReturn((long)containers.size()); when(containerInner.getResource()). thenReturn(Resources.clone(request)); when(containerInner.getId()).thenReturn(id); when(containerInner.getExecutionType()). thenReturn(ExecutionType.GUARANTEED); when(container.getApplicationAttemptId()).thenReturn(appAttemptId); when(container.getContainerId()).thenReturn(id); when(container.getContainer()).thenReturn(containerInner); when(container.getExecutionType()).thenReturn(ExecutionType.GUARANTEED); when(container.getAllocatedResource()). thenReturn(Resources.clone(request)); containers.add(container); return container; }
Source:
<code>public void addContents(@NonNull Container container) { Jenkins jenkins = Jenkins.getInstance(); if (jenkins != null) { File dir = jenkins.getRootDir(); File[] files = dir.listFiles(new FilenameFilter() { public boolean accept(File dir, String name) { return name.toLowerCase().endsWith(".xml") && !name.equals("credentials.xml"); } }); if (files != null) { <START> for (int i = 0; i < files.length; i++) { <END> File configFile = files[i]; if (configFile.exists()) { try { File patchedXmlFile = SecretHandler.findSecrets(configFile); container.add(new FileContent("jenkins-root-configuration-files/" + configFile.getName(), patchedXmlFile)); } catch (Exception e) { logger.log(Level.WARNING, "could not add the {0} configuration file to the support bundle because of: {1}", new Object[]{configFile.getName(), e}); } } } } } }</code><technical_language>java for(File configFile : files) { ... ? Indentation incorrect, also. shifted if(files!=null)</technical_language>

Target:
public void addContents(@NonNull Container container) { Jenkins jenkins = Helper.getActiveInstance(); if (jenkins != null) { File dir = jenkins.getRootDir(); File[] files = dir.listFiles(new FilenameFilter() { public boolean accept(File dir, String name) { return name.toLowerCase().endsWith(".xml") && !name.equals("credentials.xml") && !name.equals("config.xml"); } }); if (files != null) { for (File configFile : files) { if (configFile.exists()) { try { File patchedXmlFile = SecretHandler.findSecrets(configFile); container.add(new FileContent("jenkins-root-configuration-files/" + configFile.getName(), patchedXmlFile)); } catch (IOException | ParserConfigurationException | XMLStreamException | SAXException | TransformerException e) { LOGGER.log(Level.WARNING, "could not add the {0} configuration file to the support bundle because of: {1}", new Object[]{configFile.getName(), e}); } } } } else { LOGGER.log(Level.WARNING, "Cannot list files in Jenkins root, probably something is wrong with the path"); } } }
Source:
<code>public static void makeBucket_test1() throws Exception { if (!mintEnv) { System.out.println("Test: makeBucket(String bucketName)"); } long startTime = System.currentTimeMillis(); try { String name = getRandomName(); client.makeBucket(name); client.removeBucket(name); if (mintEnv) { System.out.println( mintLog("makeBucket(String bucketName)", null, System.currentTimeMillis() - startTime, pass, null, null, null)); <START> } <END> } catch (Exception e) { if (mintEnv) { System.out.println( mintLog("makeBucket(String bucketName)", null, System.currentTimeMillis() - startTime, failed, null, null, e)); } throw e; } }</code><technical_language>move this if statement mintLog()</technical_language>

Target:
public static void makeBucket_test1() throws Exception { if (!mintEnv) { System.out.println("Test: makeBucket(String bucketName)"); } long startTime = System.currentTimeMillis(); try { String name = getRandomName(); client.makeBucket(name); client.removeBucket(name); mintSuccessLog("makeBucket(String bucketName)", null, startTime); } catch (Exception e) { mintFailedLog("makeBucket(String bucketName)", null, startTime, null, e.toString() + " >>> " + Arrays.toString(e.getStackTrace())); throw e; } }
Source:
<code>public void openNotification() throws Exception { driver.closeApp(); driver.openNotifications(); WebDriverWait wait = new WebDriverWait(driver, 20); assertNotEquals(0, wait.until(input -> { List<AndroidElement> result = input .findElements(id("com.android.systemui:id/carrier_label")); <START> if (result.size() == 0) { <END> return null; } return result; }).size()); }</code><technical_language>return result.isEmpty() ? null : result;</technical_language>

Target:
public void openNotification() throws Exception { driver.closeApp(); driver.openNotifications(); WebDriverWait wait = new WebDriverWait(driver, 20); assertNotEquals(0, wait.until(input -> { List<AndroidElement> result = input .findElements(id("com.android.systemui:id/carrier_label")); return result.isEmpty() ? null : result; }).size()); }
Source:
<code>private long getOffsetFromStorageForPartition(int partition) { long offset; Map<Integer, Long> metadataOffsets = getOffsetsFromMetadataStorage(); if (metadataOffsets.get(partition) != null) { offset = metadataOffsets.get(partition); log.debug("Getting offset [%,d] from metadata storage for partition [%d]", offset, partition); long latestKafkaOffset = getOffsetFromKafkaForPartition(partition, false); if (offset > latestKafkaOffset) { throw new ISE( "Offset in metadata storage [%,d] > latest Kafka offset [%,d] for partition[%d] dataSource[%s]. If your " <START> + "Kafka offsets have been reset, you will need to use the supervisor reset API to remove the old entry.", <END> offset, latestKafkaOffset, partition, dataSource ); } } else { offset = getOffsetFromKafkaForPartition(partition, ioConfig.isUseEarliestOffset()); log.debug("Getting offset [%,d] from Kafka for partition [%d]", offset, partition); } return offset; }</code><technical_language>Potential alternate wording: "If messages longer (perhaps deleted re-created Kafka topic) supervisor reset API restart ingestion." choice if want not</technical_language>

Target:
private long getOffsetFromStorageForPartition(int partition) { long offset; Map<Integer, Long> metadataOffsets = getOffsetsFromMetadataStorage(); if (metadataOffsets.get(partition) != null) { offset = metadataOffsets.get(partition); log.debug("Getting offset [%,d] from metadata storage for partition [%d]", offset, partition); long latestKafkaOffset = getOffsetFromKafkaForPartition(partition, false); if (offset > latestKafkaOffset) { throw new ISE( "Offset in metadata storage [%,d] > latest Kafka offset [%,d] for partition[%d] dataSource[%s]. If these " + "messages are no longer available (perhaps you deleted and re-created your Kafka topic) you can use the " + "supervisor reset API to restart ingestion.", offset, latestKafkaOffset, partition, dataSource ); } } else { offset = getOffsetFromKafkaForPartition(partition, ioConfig.isUseEarliestOffset()); log.debug("Getting offset [%,d] from Kafka for partition [%d]", offset, partition); } return offset; }
Source:
<code>public ReadResult readInputData(InputChannelInfo info, Buffer buffer) throws IOException { <START> log.debug("readInputData, resultSubpartitionInfo: , bufferBuilder {}", info, buffer); <END> return getReader(info, inputChannelHandleReaders).readInto(buffer); }</code><technical_language>nit: bufferBuilder -> buffer:</technical_language>

Target:
public ReadResult readInputData(InputChannelInfo info, Buffer buffer) throws IOException { log.debug("readInputData, resultSubpartitionInfo: , buffer {}", info, buffer); return getReader(info, inputChannelHandleReaders).readInto(buffer); }
Source:
<code>public void writeProcessorMsg(ProcessorMsg processorMsg) throws IOException { <START> ObjectMapper objectMapper = new ObjectMapper(); <END> String jsonString = objectMapper.writeValueAsString(processorMsg); writeString(jsonString); }</code><technical_language>move this initialize reuse it? Is initialize() guaranteed called for time</technical_language>

Target:
public void writeProcessorMsg(ProcessorMsg processorMsg) throws IOException { String jsonString = objectMapper.writeValueAsString(processorMsg); writeString(jsonString); }
Source:
<code>public static ArrayList<SimpleTeam> getTeamList(String json) { ArrayList<SimpleTeam> teams = new ArrayList<>(); JsonArray data = JSONManager.getasJsonArray(json); Iterator iterator = data.iterator(); while (iterator.hasNext()) { <START> teams.add(JSONManager.getGson().fromJson((JsonObject) (iterator.next()), SimpleTeam.class)); <END> } return teams; }</code><technical_language>case JsonObject is redundant - parser methods do that. declaration for Iterator Iterator<JsonElement>, set</technical_language>

Target:
public static ArrayList<SimpleTeam> getTeamList(String json) { ArrayList<SimpleTeam> teams = new ArrayList<>(); JsonArray data = JSONManager.getasJsonArray(json); Iterator<JsonElement> iterator = data.iterator(); while (iterator.hasNext()) { teams.add(JSONManager.getGson().fromJson(iterator.next(), SimpleTeam.class)); } return teams; }
Source:
<code>void generateConstant(ExpressionClassBuilder acb, MethodBuilder mb) { if (SanityManager.DEBUG) { <START> SanityManager.THROWASSERT("generateConstant() not expected to be called for UntypedNullConstantNode because we have implemented our own generateExpression()."); <END> } }</code><technical_language>here, correct error messages</technical_language>

Target:
void generateConstant(ExpressionClassBuilder acb, MethodBuilder mb) { if (SanityManager.DEBUG) { SanityManager.THROWASSERT("generateConstant() not expected to be called for EmptyDefaultConstantNode."); } }
Source:
<code>private void setBuildsAndWorkspacesDir() throws IOException, InvalidBuildsDir { boolean mustSave = false; String newBuildsDir = SystemProperties.getString(BUILDS_DIR_PROP); if (newBuildsDir != null && !buildsDir.equals(newBuildsDir)) { checkRawBuildsDir(newBuildsDir); LOGGER.log(Level.WARNING, "Changing builds directories from {0} to {1}. Beware that no automated data migration will occur.", new String[]{buildsDir, newBuildsDir}); buildsDir = newBuildsDir; mustSave = true; } else if (!isDefaultBuildDir()) { LOGGER.log(Level.INFO, "Using non default builds directories: {0}.", buildsDir); } String newWorkspacesDir = SystemProperties.getString(WORKSPACES_DIR_PROP); <START> if (newWorkspacesDir != null) { <END> Level level; if(!workspaceDir.equals(newWorkspacesDir)) { level = Level.INFO; } else { level = Level.WARNING; } LOGGER.log(level, "Changing workspaces directories from {0} to {1}. Beware that no automated data migration will occur.", new String[]{workspaceDir, newWorkspacesDir}); workspaceDir = newWorkspacesDir; mustSave = true; } else if (!isDefaultWorkspaceDir()) { LOGGER.log(Level.INFO, "Using non default workspaces directories: {0}.", workspaceDir); } if (mustSave) { save(); } }</code><technical_language>NB: written more concisely Level level = workspaceDir.equals(newWorkspacesDir) ? Level.WARNING : Level.INFO;</technical_language>

Target:
private void setBuildsAndWorkspacesDir() throws IOException, InvalidBuildsDir { boolean mustSave = false; String newBuildsDir = SystemProperties.getString(BUILDS_DIR_PROP); boolean freshStartup = STARTUP_MARKER_FILE.isOff(); if (newBuildsDir != null && !buildsDir.equals(newBuildsDir)) { checkRawBuildsDir(newBuildsDir); Level level = freshStartup ? Level.INFO : Level.WARNING; LOGGER.log(level, "Changing builds directories from {0} to {1}. Beware that no automated data migration will occur.", new String[]{buildsDir, newBuildsDir}); buildsDir = newBuildsDir; mustSave = true; } else if (!isDefaultBuildDir()) { LOGGER.log(Level.INFO, "Using non default builds directories: {0}.", buildsDir); } String newWorkspacesDir = SystemProperties.getString(WORKSPACES_DIR_PROP); if (newWorkspacesDir != null && !workspaceDir.equals(newWorkspacesDir)) { Level level = freshStartup ? Level.INFO : Level.WARNING; LOGGER.log(level, "Changing workspaces directories from {0} to {1}. Beware that no automated data migration will occur.", new String[]{workspaceDir, newWorkspacesDir}); workspaceDir = newWorkspacesDir; mustSave = true; } else if (!isDefaultWorkspaceDir()) { LOGGER.log(Level.INFO, "Using non default workspaces directories: {0}.", workspaceDir); } if (mustSave) { save(); } }
Source:
<code>void timezoneJsPositive() { ClientProperties props = new ClientProperties(); props.setUtcOffset("11"); <START> props.setUtcDSTOffset("10"); <END> props.setJsTimeZone("Asia/Novosibirsk"); assertEquals(TimeZone.getTimeZone("Asia/Novosibirsk"), props.getTimeZone()); }</code><technical_language>offsets needed for test</technical_language>

Target:
void timezoneJsPositive() { ClientProperties props = new ClientProperties(); props.setJsTimeZone("Asia/Novosibirsk"); assertEquals(TimeZone.getTimeZone("Asia/Novosibirsk"), props.getTimeZone()); }
Source:
<code>public void addProviderProperties(Map properties, PersistenceUnitMetadata pu) { if (!properties.containsKey(ECLIPSELINK_TARGET_SERVER)) { properties.put(ECLIPSELINK_TARGET_SERVER, JBossAS7ServerPlatform.class.getName()); properties.put(ECLIPSELINK_ARCHIVE_FACTORY, JBossArchiveFactoryImpl.class.getName()); properties.put(ECLIPSELINK_LOGGING_LOGGER, JBossLogger.class.getName()); } logger.trace("Property " + ECLIPSELINK_TARGET_SERVER + " set to " + properties.get(ECLIPSELINK_TARGET_SERVER)); logger.trace("Property " + ECLIPSELINK_ARCHIVE_FACTORY + " set to " + properties.get(ECLIPSELINK_ARCHIVE_FACTORY)); <START> logger.trace("Property " + ECLIPSELINK_LOGGING_LOGGER + " set to " + properties.get(ECLIPSELINK_LOGGING_LOGGER)); <END> }</code><technical_language>tracef</technical_language>

Target:
public void addProviderProperties(Map properties, PersistenceUnitMetadata pu) { if (!properties.containsKey(ECLIPSELINK_TARGET_SERVER)) { properties.put(ECLIPSELINK_TARGET_SERVER, WildFlyServerPlatform.class.getName()); properties.put(ECLIPSELINK_ARCHIVE_FACTORY, JBossArchiveFactoryImpl.class.getName()); properties.put(ECLIPSELINK_LOGGING_LOGGER, JBossLogger.class.getName()); } }