auphong2707/dl4se-code-review-dataset huggingface dataset:
Source:
<code>public Object visitGetKeysInGroupCommand(final InvocationContext ctx, GetKeysInGroupCommand command) throws Throwable { final String groupName = command.getGroupName(); if (!command.isGroupOwner() || !enabled || shouldSkipCacheLoader(command)) { return invokeNextInterceptor(ctx, command); } final GroupFilter<Object> groupFilter = new GroupFilter<>(groupName, groupManager); final CollectionKeyFilter<Object> collectionKeyFilter = new CollectionKeyFilter<>(ctx.getLookedUpEntries().keySet()); <START> persistenceManager.processOnAllStores(new KeyFilter() { <END> @Override public boolean accept(Object key) { return groupFilter.accept(key) && collectionKeyFilter.accept(key); } }, new AdvancedCacheLoader.CacheLoaderTask() { @Override public void processEntry(MarshalledEntry marshalledEntry, AdvancedCacheLoader.TaskContext taskContext) throws InterruptedException { synchronized (ctx) { ctx.putLookedUpEntry(marshalledEntry.getKey(), null); } } }, false, false); return invokeNextInterceptor(ctx, command); }</code><technical_language>CompositeKeyFilter instead need another class definition</technical_language>

Target:
public Object visitGetKeysInGroupCommand(final InvocationContext ctx, GetKeysInGroupCommand command) throws Throwable { final String groupName = command.getGroupName(); if (!command.isGroupOwner() || !enabled || shouldSkipCacheLoader(command)) { return invokeNextInterceptor(ctx, command); } final KeyFilter<Object> keyFilter = new CompositeKeyFilter<>(new GroupFilter<>(groupName, groupManager), new CollectionKeyFilter<>(ctx.getLookedUpEntries().keySet())); persistenceManager.processOnAllStores(keyFilter, new AdvancedCacheLoader.CacheLoaderTask() { @Override public void processEntry(MarshalledEntry marshalledEntry, AdvancedCacheLoader.TaskContext taskContext) throws InterruptedException { synchronized (ctx) { entryFactory.wrapEntryForReading(ctx, marshalledEntry.getKey(), convert(marshalledEntry, iceFactory)).setSkipLookup(true); } } }, true, true); return invokeNextInterceptor(ctx, command); }
Source:
<code>public void onUndoMediaCheck(final String undoedContent) { List <MediaModel> currentlyUploadingMedia = UploadService.getAllInProgressOrQueuedMediaItemsForPost(mPost); List<String> mediaMarkedUploading = AztecEditorFragment.getMediaMarkedUploadingInPostContent(EditPostActivity.this, undoedContent); for (String mediaId : mediaMarkedUploading) { boolean found = false; for (MediaModel media : currentlyUploadingMedia) { <START> if (Integer.valueOf(mediaId) == media.getId()) { <END> found = true; break; } } if (!found) { if (mEditorFragment instanceof AztecEditorFragment) { ((AztecEditorFragment)mEditorFragment).setMediaToFailed(mediaId); } } } }</code><technical_language>StringUtils.stringToInt here</technical_language>

Target:
public void onUndoMediaCheck(final String undoedContent) { List <MediaModel> currentlyUploadingMedia = UploadService.getPendingOrInProgressMediaUploadsForPost(mPost); List<String> mediaMarkedUploading = AztecEditorFragment.getMediaMarkedUploadingInPostContent(EditPostActivity.this, undoedContent); for (String mediaId : mediaMarkedUploading) { boolean found = false; for (MediaModel media : currentlyUploadingMedia) { if (StringUtils.stringToInt(mediaId) == media.getId()) { found = true; break; } } if (!found) { if (mEditorFragment instanceof AztecEditorFragment) { ((AztecEditorFragment)mEditorFragment).setMediaToFailed(mediaId); } } } }
Source:
<code>public void beforeRunningTestMethod() throws IOException { HELPERS.ensureBucketExists(BUCKET_NAME, envDataPolicyId); final Ds3Object obj = new Ds3Object(OBJ_NAME, OBJ_BYTES.length); final Ds3ClientHelpers.Job job = HELPERS.startWriteJob(BUCKET_NAME, Lists.newArrayList(obj)); job.transfer(new ObjectInputStreamBuilder() { @Override <START> public InputStream buildInputStream(String key) { <END> return new ByteArrayInputStream(OBJ_BYTES); } }); }</code><technical_language>Missing final</technical_language>

Target:
public void beforeRunningTestMethod() throws IOException { HELPERS.ensureBucketExists(BUCKET_NAME, envDataPolicyId); final Ds3Object obj = new Ds3Object(OBJ_NAME, OBJ_BYTES.length); final Ds3ClientHelpers.Job job = HELPERS.startWriteJob(BUCKET_NAME, Lists.newArrayList(obj)); job.transfer(new ObjectInputStreamBuilder() { @Override public InputStream buildInputStream(final String key) { return new ByteArrayInputStream(OBJ_BYTES); } }); }
Source:
<code>public void deleteEventByOrganizationID(long organizationId) { currentSession().flush(); <START> Query<Event> query = this.currentSession().getNamedQuery("io.dockstore.webservice.core.Event.deleteByOrganizationId"); <END> query.setParameter("organizationId", organizationId); query.executeUpdate(); currentSession().flush(); }</code><technical_language>is a namedQuery method able use</technical_language>

Target:
public void deleteEventByOrganizationID(long organizationId) { Query query = namedQuery("io.dockstore.webservice.core.Event.deleteByOrganizationId"); query.setParameter("organizationId", organizationId); query.executeUpdate(); currentSession().flush(); }
Source:
<code>public void canPersistAndRetrieveAsync() throws ExecutionException, InterruptedException { List<CompletableFuture<Long>> putFutures = new ArrayList<>(); for (int i = 0; i < 1000; i++) { String iStr = Integer.toString(i); putFutures.add(kvStore.putAsync(iStr, new CassandraKVStoreIT.State(i, iStr))); } CompletableFuture[] allPutFutures = putFutures.toArray(new CompletableFuture[0]); <START> assertThat(CompletableFuture.allOf(allPutFutures).isDone(), equalTo(false)); <END> CompletableFuture.allOf(allPutFutures).get(); List<CompletableFuture<Optional<Serializable>>> getFutures = new ArrayList<>(); for (int i = 0; i < 1000; i++) { String iStr = Integer.toString(i); getFutures.add(kvStore.getAsync(iStr)); } CompletableFuture[] allGetFutures = getFutures.toArray(new CompletableFuture[0]); assertThat(CompletableFuture.allOf(allGetFutures).isDone(), equalTo(false)); CompletableFuture.allOf(allGetFutures).get(); getFutures.stream() .filter(f -> { try { return f.get().equals(Optional.empty()); } catch (InterruptedException | ExecutionException e) { throw new RuntimeException(e); } }) .findAny() .ifPresent(f -> fail("Should not have found empty optional")); }</code><technical_language>remove this - *if* do finish quickly</technical_language>

Target:
public void canPersistAndRetrieveAsync() throws ExecutionException, InterruptedException, TimeoutException { List<CompletableFuture<Long>> putFutures = new ArrayList<>(); String context = "canPersistAndRetrieveAsync"; for (int i = 0; i < 1000; i++) { String iStr = Integer.toString(i); putFutures.add(serializingKeyValueStore.putAsync(iStr, Integer.toString(i), context)); } CompletableFuture[] allPutFutures = putFutures.toArray(new CompletableFuture[0]); CompletableFuture.allOf(allPutFutures).get(1, TimeUnit.MINUTES); List<CompletableFuture<Optional<String>>> getFutures = new ArrayList<>(); for (int i = 0; i < 1000; i++) { getFutures.add(serializingKeyValueStore.getAsync(Integer.toString(i), context)); } CompletableFuture[] allGetFutures = getFutures.toArray(new CompletableFuture[0]); CompletableFuture.allOf(allGetFutures).get(1, TimeUnit.MINUTES); getFutures.stream() .filter(f -> { try { return f.get().equals(Optional.empty()); } catch (InterruptedException | ExecutionException e) { throw new RuntimeException(e); } }) .findAny() .ifPresent(f -> fail("Should not have found empty optional")); }
Source:
<code>protected String getNumberVersion(String firstV) { String res = firstV; <START> if (!firstV.matches("[0-9.]+") && firstV.contains("-")) { <END> String[] splittedVersion = firstV.split("-"); if(splittedVersion.length > 1) { res = splittedVersion[1]; } } return res; }</code><technical_language>pls remove number regexp matching match if is a '-' in input string anyway</technical_language>

Target:
protected String getNumberVersion(String firstV) { String res = firstV; if (firstV.contains("-")) { String[] splittedVersion = firstV.split("-"); if(splittedVersion.length > 1) { res = splittedVersion[1]; } } return res; }
Source:
<code>public static IResource getTargetResource(ILaunchConfiguration configuration) throws CoreException { String target = getTargetName(configuration); <START> <END> IResource targetResource = ResourcesPlugin.getWorkspace().getRoot().findMember(target); return targetResource; }</code><technical_language>This null check is necessary do want pass null findMember</technical_language>

Target:
public static IResource getTargetResource(ILaunchConfiguration configuration) throws CoreException { String target = getTargetName(configuration); if (target == null) return null; IResource targetResource = ResourcesPlugin.getWorkspace().getRoot().findMember(target); return targetResource; }
Source:
<code>public void testEmitter() { PrometheusEmitterConfig config = new PrometheusEmitterConfig(null, null, 0); PrometheusEmitter emitter = new PrometheusEmitter(config); ServiceMetricEvent build = ServiceMetricEvent.builder() .setDimension("server", "druid-data01.vpc.region") <START> .build("segment/loadQueue/count", 10) <END> .build(ImmutableMap.of("service", "historical")); assertEquals("historical", build.getService()); assertFalse(build.getUserDims().isEmpty()); emitter.emit(build); Double count = CollectorRegistry.defaultRegistry.getSampleValue( "druid_segment_loadqueue_count", new String[]{"server"}, new String[]{"druid_data01_vpc_region"} ); assertEquals(10, count.intValue()); }</code><technical_language>license is missing in this file</technical_language>

Target:
public void testEmitter() { PrometheusEmitterConfig config = new PrometheusEmitterConfig(PrometheusEmitterConfig.Strategy.exporter, null, null, 0, null); PrometheusEmitter emitter = new PrometheusEmitter(config); ServiceMetricEvent build = ServiceMetricEvent.builder() .setDimension("server", "druid-data01.vpc.region") .build("segment/loadQueue/count", 10) .build(ImmutableMap.of("service", "historical")); Assert.assertEquals("historical", build.getService()); Assert.assertFalse(build.getUserDims().isEmpty()); emitter.emit(build); Double count = CollectorRegistry.defaultRegistry.getSampleValue( "druid_segment_loadqueue_count", new String[]{"server"}, new String[]{"druid_data01_vpc_region"} ); Assert.assertEquals(10, count.intValue()); }
Source:
<code><START> public Address createCredentialStoreWithCredentialReferenceClearText(String credentialStoreName, String clearTextValue) throws IOException { <END> final ModelNode credentialReference = new ModelNodeGenerator.ModelNodePropertiesBuilder().addProperty(CLEAR_TEXT, clearTextValue).build(); final Address credentialStoreAddress = ELYTRON_SUBSYSTEM_ADDRESS.and(CREDENTIAL_STORE, credentialStoreName); ops.add(credentialStoreAddress, Values.of(CREDENTIAL_REFERENCE, credentialReference) .and(CREATE, true) .and(MODIFIABLE, true)); return credentialStoreAddress; }</code><technical_language>Please avoid code duplication createCredentialStoreWithCredentialReferenceClearText methods. I this PR bring this duplication please fix if there</technical_language>

Target:
private Address createCredentialStoreWithCredentialReferenceClearText(String credentialStoreName, String clearTextValue) throws IOException { final ModelNode credentialReference = new ModelNodeGenerator.ModelNodePropertiesBuilder().addProperty(CLEAR_TEXT, clearTextValue).build(); final Address credentialStoreAddress = ELYTRON_SUBSYSTEM_ADDRESS.and(CREDENTIAL_STORE, credentialStoreName); ops.add(credentialStoreAddress, Values.of(CREDENTIAL_REFERENCE, credentialReference) .and(CREATE, true) .and(MODIFIABLE, true)); return credentialStoreAddress; }
Source:
<code>private static void normalizeCourseStructure(CourseStructureV1Model courseStructureV1Model, BlockModel block, CourseComponent parent) { if (block.isContainer()) { CourseComponent child = new CourseComponent(block, parent); for (BlockModel m : courseStructureV1Model.getDescendants(block)) { normalizeCourseStructure(courseStructureV1Model, m, child); } } else { if (BlockType.VIDEO == block.type && block.data != null && (block.data instanceof VideoData)) { new VideoBlockModel(block, parent); } else if (BlockType.DISCUSSION == block.type && block.data != null <START> && (block.data instanceof DiscussionData)) { <END> new DiscussionBlockModel(block, parent); } else { new HtmlBlockModel(block, parent); } } }</code><technical_language>Note instanceof check performs a safe null check implicitly, null check block.data property removed if conditions</technical_language>

Target:
private static void normalizeCourseStructure(CourseStructureV1Model courseStructureV1Model, BlockModel block, CourseComponent parent) { if (block.isContainer()) { CourseComponent child = new CourseComponent(block, parent); for (BlockModel m : courseStructureV1Model.getDescendants(block)) { normalizeCourseStructure(courseStructureV1Model, m, child); } } else { if (BlockType.VIDEO == block.type && block.data instanceof VideoData) { new VideoBlockModel(block, parent); } else if (BlockType.DISCUSSION == block.type && block.data instanceof DiscussionData) { new DiscussionBlockModel(block, parent); } else { new HtmlBlockModel(block, parent); } } }
Source:
<code>protected void executeMultiTargetChildren(PathAddress base, PathElement currentElement, PathAddress newRemaining, OperationContext context, ImmutableManagementResourceRegistration registration, boolean ignoreMissing) { final String childType = currentElement.getKey().equals("*") ? null : currentElement.getKey(); if (registration.isRemote()) { throw new IllegalStateException(); } final Set<PathElement> children = context.getResourceRegistration().getChildAddresses(base); if (children == null || children.isEmpty()) { return; } boolean isServerWildcardWithRemaining = currentElement.getKey().equals(RUNNING_SERVER) && currentElement.isWildcard() && newRemaining.size() > 0; for (final PathElement path : children) { if (childType != null && !childType.equals(path.getKey())) { continue; } <START> if (isServerWildcardWithRemaining && path.getKey().equals(RUNNING_SERVER) && path.isWildcard() && newRemaining.size() > 0) { <END> continue; } final PathAddress next = base.append(path); final ImmutableManagementResourceRegistration nr = context.getResourceRegistration().getSubModel(next); execute(next, newRemaining, context, nr, ignoreMissing); } }</code><technical_language>This confuses me. L837 is a similar check "currentElement" is done "path". newRemaining.size() > 0 check is redundant</technical_language>

Target:
protected void executeMultiTargetChildren(PathAddress base, PathElement currentElement, PathAddress newRemaining, OperationContext context, ImmutableManagementResourceRegistration registration, boolean ignoreMissing) { final String childType = currentElement.getKey().equals("*") ? null : currentElement.getKey(); if (registration.isRemote()) { throw new IllegalStateException(); } final Set<PathElement> children = context.getResourceRegistration().getChildAddresses(base); if (children == null || children.isEmpty()) { return; } for (final PathElement path : children) { if (childType != null && !childType.equals(path.getKey())) { continue; } if (path.getKey().equals(RUNNING_SERVER) && path.isWildcard() && newRemaining.size() > 0) { continue; } final PathAddress next = base.append(path); final ImmutableManagementResourceRegistration nr = context.getResourceRegistration().getSubModel(next); execute(next, newRemaining, context, nr, ignoreMissing); } }
Source:
<code><START> public void testGetGlyphWithConsumer() { <END> assertEquals(DMNSVGGlyphFactory.BUSINESS_KNOWLEDGE_MODEL_PALETTE, shapeDef.getGlyph(BusinessKnowledgeModel.class, PaletteGlyphConsumer.class, DEFINITION_ID)); assertEquals(DMNSVGGlyphFactory.DECISION_PALETTE, shapeDef.getGlyph(Decision.class, PaletteGlyphConsumer.class, DEFINITION_ID)); assertEquals(DMNSVGGlyphFactory.DIAGRAM_GLYPH, shapeDef.getGlyph(DMNDiagram.class, PaletteGlyphConsumer.class, DEFINITION_ID)); assertEquals(DMNSVGGlyphFactory.INPUT_DATA_PALETTE, shapeDef.getGlyph(InputData.class, PaletteGlyphConsumer.class, DEFINITION_ID)); assertEquals(DMNSVGGlyphFactory.KNOWLEDGE_SOURCE_PALETTE, shapeDef.getGlyph(KnowledgeSource.class, PaletteGlyphConsumer.class, DEFINITION_ID)); assertEquals(DMNSVGGlyphFactory.TEXT_ANNOTATION_PALETTE, shapeDef.getGlyph(TextAnnotation.class, PaletteGlyphConsumer.class, DEFINITION_ID)); }</code><technical_language>in this test check unknown type? I similar line in test above</technical_language>

Target:
public void testGetGlyphWithConsumer() { assertEquals(DMNSVGGlyphFactory.BUSINESS_KNOWLEDGE_MODEL_PALETTE, shapeDef.getGlyph(BusinessKnowledgeModel.class, PaletteGlyphConsumer.class, DEFINITION_ID)); assertEquals(DMNSVGGlyphFactory.DECISION_PALETTE, shapeDef.getGlyph(Decision.class, PaletteGlyphConsumer.class, DEFINITION_ID)); assertEquals(DMNSVGGlyphFactory.DIAGRAM_TOOLBOX, shapeDef.getGlyph(DMNDiagram.class, PaletteGlyphConsumer.class, DEFINITION_ID)); assertEquals(DMNSVGGlyphFactory.INPUT_DATA_PALETTE, shapeDef.getGlyph(InputData.class, PaletteGlyphConsumer.class, DEFINITION_ID)); assertEquals(DMNSVGGlyphFactory.KNOWLEDGE_SOURCE_PALETTE, shapeDef.getGlyph(KnowledgeSource.class, PaletteGlyphConsumer.class, DEFINITION_ID)); assertEquals(DMNSVGGlyphFactory.TEXT_ANNOTATION_PALETTE, shapeDef.getGlyph(TextAnnotation.class, PaletteGlyphConsumer.class, DEFINITION_ID)); assertTrue(shapeDef.getGlyph(DMNViewDefinition.class, PaletteGlyphConsumer.class, DEFINITION_ID) instanceof ShapeGlyph); }
Source:
<code>protected String getParsedValue(String fileURI, String yamlPath) throws SecretDecryptionException { <START> String[] pathElts = yamlPath.split("\\."); <END> Map<String,Object> parsed = cache.get(fileURI); for (String pathElt : pathElts) { Object o = parsed.get(pathElt); if (o instanceof Map) { parsed = (Map<String, Object>) o; } else if (o instanceof List) { parsed = ((List<Map<String, Object>>) o).get(Integer.valueOf(pathElt)); } else { return (String) o; } } throw new SecretDecryptionException("Invalid secret key specified: " + yamlPath); }</code><technical_language>a Splitter instead</technical_language>

Target:
protected String getParsedValue(String fileURI, String yamlPath) throws SecretDecryptionException { Map<String,Object> parsed = cache.get(fileURI); for (Iterator<String> it = Splitter.on(".").split(yamlPath).iterator(); it.hasNext(); ) { String pathElt = it.next(); Object o = parsed.get(pathElt); if (o instanceof Map) { parsed = (Map<String, Object>) o; } else if (o instanceof List) { parsed = ((List<Map<String, Object>>) o).get(Integer.valueOf(pathElt)); } else { return (String) o; } } throw new SecretDecryptionException("Invalid secret key specified: " + yamlPath); }
Source:
<code>public String toString() { return toStringHelper(this) <START> .add("path", path) <END> .toString(); }</code><technical_language>add("path", Iterables.toString(path))</technical_language>

Target:
public String toString() { return Joiner.on(", ").join(path); }
Source:
<code>public void setLockScreenArt( NotificationCompat.Builder builder, @Nullable Bitmap thumbnailBitmap ) { <END> <START> if (thumbnailBitmap == null) { return; } if (!mediaSession.isActive()) { return; } mediaSession.setMetadata( new MediaMetadataCompat.Builder() .putBitmap(MediaMetadata.METADATA_KEY_ALBUM_ART, thumbnailBitmap) .build() ); MediaStyle mediaStyle = new MediaStyle() .setMediaSession(mediaSession.getSessionToken()); builder.setStyle(mediaStyle); }</code><technical_language>This simplified into: if (thumbnailBitmap == null || !!mediaSession.isActive()) { return; }</technical_language>

Target:
public void setLockScreenArt(NotificationCompat.Builder builder, @Nullable Bitmap thumbnailBitmap) { if (thumbnailBitmap == null || !mediaSession.isActive()) { return; } mediaSession.setMetadata( new MediaMetadataCompat.Builder() .putBitmap(MediaMetadata.METADATA_KEY_ALBUM_ART, thumbnailBitmap) .build() ); MediaStyle mediaStyle = new MediaStyle() .setMediaSession(mediaSession.getSessionToken()); builder.setStyle(mediaStyle); }
Source:
<code>private static IFile getFile(String path) throws FileNotFoundException { IWorkspaceRoot root = ResourcesPlugin.getWorkspace().getRoot(); IFile traceChild = root.getFile(new Path(path)); if (traceChild != null) { return traceChild; } <START> throw new FileNotFoundException(); <END> }</code><technical_language>Put a message in exception</technical_language>

Target:
private static IFile getFile(String path) throws FileNotFoundException { IWorkspaceRoot root = ResourcesPlugin.getWorkspace().getRoot(); IFile traceChild = root.getFile(new Path(path)); if (traceChild != null) { return traceChild; } throw new FileNotFoundException("The file: " + path + " could not be found"); }
Source:
<code><START> public static INDArray minv(@Nonnull final INDArray mat) { <END> if (mat.isScalar()) { return Nd4j.onesLike(mat).divi(mat); } if (!mat.isSquare()) { throw new IllegalArgumentException("Invalid array: must be square matrix"); } final RealMatrix rm = Nd4jApacheAdapterUtils.convertINDArrayToApacheMatrix(mat); final RealMatrix rmInverse = new LUDecomposition(rm).getSolver().getInverse(); return Nd4jApacheAdapterUtils.convertApacheMatrixToINDArray(rmInverse); }</code><technical_language>A more verbose method name</technical_language>

Target:
public static INDArray minv(@Nonnull final INDArray mat) { return minv(mat, DEFAULT_LU_DECOMPOSITION_SINGULARITY_THRESHOLD); }
Source:
<code>private ResourceIdentifier(String service, String instance, String type, String locator) { <START> String safeInstnace = instance == null ? "" : instance; <END> resourceIdentifier = RID_CLASS + SEPARATOR + service + SEPARATOR + safeInstnace + SEPARATOR + type + SEPARATOR + locator; serviceIndex = RID_CLASS.length() + SEPARATOR.length() + service.length(); instanceIndex = serviceIndex + SEPARATOR.length() + safeInstnace.length(); typeIndex = instanceIndex + SEPARATOR.length() + type.length(); locatorIndex = typeIndex + SEPARATOR.length() + locator.length(); }</code><technical_language>typo</technical_language>

Target:
private ResourceIdentifier(String service, String instance, String type, String locator) { String safeInstance = instance == null ? "" : instance; resourceIdentifier = RID_CLASS + SEPARATOR + service + SEPARATOR + safeInstance + SEPARATOR + type + SEPARATOR + locator; serviceIndex = RID_CLASS.length() + SEPARATOR.length() + service.length(); instanceIndex = serviceIndex + SEPARATOR.length() + safeInstance.length(); typeIndex = instanceIndex + SEPARATOR.length() + type.length(); locatorIndex = typeIndex + SEPARATOR.length() + locator.length(); }
Source:
<code><START> public List<Monitor<?>> getMonitors() { <END> lastUsed = clock.now(); if (myFutureRef.get() == null) { LOGGER.info("Attempting to get the value for an expired monitor: {}." + "Will start computing stats again.", getConfig().getName()); startComputingStats(executor, statsConfig.getFrequencyMillis()); return Collections.emptyList(); } return monitors; }</code><technical_language>check understanding, expected flow is: 1. User registers StatMonitor, getMonitors start called. 2. some point unregister, StatMonitor get collected of reference executor. 3. getMonitors longer called lastUsed get updated expire. condition is catching case register a monitor previous unregistered</technical_language>

Target:
public List<Monitor<?>> getMonitors() { lastUsed = clock.now(); if (isExpired()) { LOGGER.info("Attempting to get the value for an expired monitor: {}." + "Will start computing stats again.", getConfig().getName()); startComputingStats(executor, statsConfig.getFrequencyMillis()); return Collections.emptyList(); } return monitors; }
Source:
<code>public String toString() { StringBuilder builder = new StringBuilder(); <START> builder.append("NetworkProvider [name=") <END> .append(getName()) .append(", description=") .append(getDescription()) .append(", url=") .append(getUrl()) .append("]"); return builder.toString(); }</code><technical_language>'Network' omitted this context this is a specific provider</technical_language>

Target:
public String toString() { StringBuilder builder = new StringBuilder(); builder.append("Provider [id=") .append(getId()) .append(", name=") .append(getName()) .append(", description=") .append(getDescription()) .append(", type=") .append(getType()) .append(", url=") .append(getUrl()) .append("]"); return builder.toString(); }
Source:
<code>private void decorateWiretap(FlowElementMetaData flowElement, AbstractWiretapNode node) { if(flowElement.getDecorators() != null) { flowElement.getDecorators().forEach(decoratorMetaData -> { <START> if (decoratorMetaData.getType().equals("Wiretap") && decoratorMetaData.getName().startsWith("BEFORE")) { <END> node.setWiretapBeforeStatus(NodeFoundStatus.FOUND); node.setDecoratorMetaDataList(flowElement.getDecorators()); } else if (decoratorMetaData.getType().equals("Wiretap") && decoratorMetaData.getName().startsWith("AFTER")) { node.setWiretapAfterStatus(NodeFoundStatus.FOUND); node.setDecoratorMetaDataList(flowElement.getDecorators()); } else if (decoratorMetaData.getType().equals("LogWiretap") && decoratorMetaData.getName().startsWith("BEFORE")) { node.setLogWiretapBeforeStatus(NodeFoundStatus.FOUND); node.setDecoratorMetaDataList(flowElement.getDecorators()); } else if (decoratorMetaData.getType().equals("LogWiretap") && decoratorMetaData.getName().startsWith("AFTER")) { node.setLogWiretapAfterStatus(NodeFoundStatus.FOUND); node.setDecoratorMetaDataList(flowElement.getDecorators()); } }); } }</code><technical_language>Do constants for literals ("Wiretap", BEFORE", "AFTER") in Wiretap spec</technical_language>

Target:
private void decorateWiretap(FlowElementMetaData flowElement, AbstractWiretapNode node) { if(flowElement.getDecorators() != null) { flowElement.getDecorators().forEach(decoratorMetaData -> { if (decoratorMetaData.getType().equals(TriggerJobType.WIRETAP.getDescription()) && decoratorMetaData.getName() .startsWith(TriggerRelationship.BEFORE.getDescription().toUpperCase())) { node.setWiretapBeforeStatus(NodeFoundStatus.FOUND); node.setDecoratorMetaDataList(flowElement.getDecorators()); } else if (decoratorMetaData.getType().equals(TriggerJobType.WIRETAP.getDescription()) && decoratorMetaData.getName() .startsWith(TriggerRelationship.AFTER.getDescription().toUpperCase())) { node.setWiretapAfterStatus(NodeFoundStatus.FOUND); node.setDecoratorMetaDataList(flowElement.getDecorators()); } else if (decoratorMetaData.getType().equals(TriggerJobType.LOG_WIRETAP.getDescription()) && decoratorMetaData.getName() .startsWith(TriggerRelationship.BEFORE.getDescription().toUpperCase())) { node.setLogWiretapBeforeStatus(NodeFoundStatus.FOUND); node.setDecoratorMetaDataList(flowElement.getDecorators()); } else if (decoratorMetaData.getType().equals(TriggerJobType.LOG_WIRETAP.getDescription()) && decoratorMetaData.getName() .startsWith(TriggerRelationship.AFTER.getDescription().toUpperCase())) { node.setLogWiretapAfterStatus(NodeFoundStatus.FOUND); node.setDecoratorMetaDataList(flowElement.getDecorators()); } }); } }
Source:
<code>public ScheduledReporter build(MetricRegistry registry) { try { file.mkdir(); } <START> catch (Exception e) { <END> } return CsvReporter.forRegistry(registry) .convertDurationsTo(getDurationUnit()) .convertRatesTo(getRateUnit()) .filter(getFilter()) .formatFor(getLocale()) .build(getFile()); }</code><technical_language>more sense wrap IOException a RuntimeException throw it? Depending frequency in metrics published, this spam logs. prefer a fail fast approach here</technical_language>

Target:
public ScheduledReporter build(MetricRegistry registry) { boolean creation = file.mkdirs(); if (!creation && !file.exists()) { String msg = "Failed to create" + file.getAbsolutePath(); throw new RuntimeException(msg); } return CsvReporter.forRegistry(registry) .convertDurationsTo(getDurationUnit()) .convertRatesTo(getRateUnit()) .filter(getFilter()) .formatFor(getLocale()) .build(getFile()); }
Source:
<code>public void ruleAddedTableLayoutToTableScan() { Map<String, Domain> emptyConstraint = ImmutableMap.<String, Domain>builder().build(); tester().assertThat(pickTableLayout) .on(p -> p.tableScan( nationTableHandle, <START> ImmutableList.of(p.symbol("nationkey", BIGINT)), <END> ImmutableMap.of(p.symbol("nationkey", BIGINT), new TpchColumnHandle("nationkey", BIGINT)))) .matches( constrainedTableScanWithTableLayout("nation", emptyConstraint, ImmutableMap.of("nationkey", "nationkey"))); }</code><technical_language>gone</technical_language>

Target:
public void ruleAddedTableLayoutToTableScan() { Map<String, Domain> emptyConstraint = ImmutableMap.<String, Domain>builder().build(); tester.assertThat(pickTableLayout) .on(p -> p.tableScan( nationTableHandle, ImmutableList.of(p.symbol("nationkey", BIGINT)), ImmutableMap.of(p.symbol("nationkey", BIGINT), new TpchColumnHandle("nationkey", BIGINT)))) .matches( constrainedTableScanWithTableLayout("nation", emptyConstraint, ImmutableMap.of("nationkey", "nationkey"))); }
Source:
<code>private void showResource(final IResource resource) { IProject project = resource.getProject(); RepositoryMapping mapping = RepositoryMapping.getMapping(project); if (mapping == null) return; Repository newRep = mapping.getRepositoryOrNestedSubmoduleRepository(resource); if (newRep != currentRepository) <START> { <END> reload(newRep); } }</code><technical_language>style nit: braces single line blocks</technical_language>

Target:
private void showResource(final IResource resource) { Repository newRep = getRepositoryOrNestedSubmoduleRepository(resource); if (newRep != null && newRep != currentRepository) { reload(newRep); } }
Source:
<code>public Boolean getCleanup() { if (cleanup != null) { return cleanup; } <START> return false; <END> }</code><technical_language>is valid</technical_language>

Target:
public Boolean getCleanup() { return cleanup; }
Source:
<code>public void testBootWriteReadShutdown() throws Exception { Assert.assertTrue(BookKeeperClusterUtils.startAllBookiesWithVersion(docker, currentVersion)); String zookeeper = BookKeeperClusterUtils.zookeeperConnectString(docker); BookKeeper bk = new BookKeeper(zookeeper); long ledgerId; <START> try (LedgerHandle writelh = bk.createLedger(BookKeeper.DigestType.CRC32, PASSWD)) { <END> ledgerId = writelh.getId(); for (int i = 0; i < 100; i++) { writelh.addEntry(("entry-" + i).getBytes()); } } Thread.sleep(10000); try (LedgerHandle readlh = bk.openLedger(ledgerId, BookKeeper.DigestType.CRC32, PASSWD)) { long lac = readlh.getLastAddConfirmed(); int i = 0; Enumeration<LedgerEntry> entries = readlh.readEntries(0, lac); while (entries.hasMoreElements()) { LedgerEntry e = entries.nextElement(); String readBack = new String(e.getEntry()); Assert.assertEquals(readBack, "entry-" + i++); } Assert.assertEquals(i, 100); } bk.close(); if (!BookKeeperClusterUtils.stopAllBookies(docker)) { Thread.sleep(20000); Assert.fail("A bookie failed to stop"); } }</code><technical_language>new API</technical_language>

Target:
public void testBootWriteReadShutdown() throws Exception { Assert.assertTrue(BookKeeperClusterUtils.startAllBookiesWithVersion(docker, currentVersion)); String zookeeper = BookKeeperClusterUtils.zookeeperConnectString(docker); BookKeeper bk = new BookKeeper(zookeeper); long ledgerId; try (LedgerHandle writelh = bk.createLedger(BookKeeper.DigestType.CRC32, PASSWD)) { ledgerId = writelh.getId(); for (int i = 0; i < 100; i++) { writelh.addEntry(("entry-" + i).getBytes()); } } try (LedgerHandle readlh = bk.openLedger(ledgerId, BookKeeper.DigestType.CRC32, PASSWD)) { long lac = readlh.getLastAddConfirmed(); int i = 0; Enumeration<LedgerEntry> entries = readlh.readEntries(0, lac); while (entries.hasMoreElements()) { LedgerEntry e = entries.nextElement(); String readBack = new String(e.getEntry()); Assert.assertEquals(readBack, "entry-" + i++); } Assert.assertEquals(i, 100); } bk.close(); Assert.assertTrue(BookKeeperClusterUtils.stopAllBookies(docker)); }
Source:
<code>public RefractiveReflectiveBlocksNode(Context context) { renderQueues = context.get(RenderQueuesHelper.class); <START> worldRenderer = context.get(WorldRenderer.class); <END> displayResolutionDependentFBOs = context.get(DisplayResolutionDependentFBOs.class); playerCamera = worldRenderer.getActiveCamera(); addDesiredStateChange(new LookThrough(playerCamera)); requiresFBO(new FBOConfig(REFRACTIVE_REFLECTIVE_FBO, FULL_SCALE, FBO.Type.HDR).useNormalBuffer(), displayResolutionDependentFBOs); addDesiredStateChange(new BindFBO(REFRACTIVE_REFLECTIVE_FBO, displayResolutionDependentFBOs)); update(); displayResolutionDependentFBOs.subscribe(this); addDesiredStateChange(new EnableMaterial(CHUNK_MATERIAL)); chunkMaterial = getMaterial(CHUNK_MATERIAL); }</code><technical_language>This line playerCamera line below. line closer block starting requiresFBO line</technical_language>

Target:
public RefractiveReflectiveBlocksNode(Context context) { renderQueues = context.get(RenderQueuesHelper.class); worldRenderer = context.get(WorldRenderer.class); playerCamera = worldRenderer.getActiveCamera(); addDesiredStateChange(new LookThrough(playerCamera)); displayResolutionDependentFBOs = context.get(DisplayResolutionDependentFBOs.class); requiresFBO(new FBOConfig(REFRACTIVE_REFLECTIVE_FBO, FULL_SCALE, FBO.Type.HDR).useNormalBuffer(), displayResolutionDependentFBOs); addDesiredStateChange(new BindFBO(REFRACTIVE_REFLECTIVE_FBO, displayResolutionDependentFBOs)); update(); displayResolutionDependentFBOs.subscribe(this); addDesiredStateChange(new EnableMaterial(CHUNK_MATERIAL)); chunkMaterial = getMaterial(CHUNK_MATERIAL); }
Source:
<code>default int concurrentGetRangesThreadPoolSize() { <START> return poolSize() * servers().thrift().size(); <END> }</code><technical_language>yeah, I add a numberOfHosts field, @Value.Derived of impls</technical_language>

Target:
default int concurrentGetRangesThreadPoolSize() { return poolSize() * servers().numberOfHosts(); }
Source:
<code>public void add(int value) { short key = Util.highbits(value); short low = Util.lowbits(value); if (key != currentKey) { if (Util.compareUnsigned(key, currentKey) < 0) { throw new IllegalStateException("Must write in ascending key order"); } flush(); } int valueIndex = valuesCount++; if (valueIndex > 0 && Util.compareUnsigned(low, values[valueIndex - 1]) <= 0) { throw new IllegalStateException("Must write in ascending order."); } if (valueIndex >= values.length) { valuesCount = values.length; throw new IllegalStateException( String.format("Exceeded limit of %d values per container.", values.length)); } <START> currentKey = key; <END> values[valueIndex] = low; }</code><technical_language>move this block flush occurs more obvious this change</technical_language>

Target:
public void add(int value) { short key = Util.highbits(value); short low = Util.lowbits(value); if (key != currentKey) { if (Util.compareUnsigned(key, currentKey) < 0) { throw new IllegalStateException("Must write in ascending key order"); } flush(); } int valueIndex = valuesCount++; if (valueIndex > 0 && Util.compareUnsigned(low, values[valueIndex - 1]) <= 0) { throw new IllegalStateException("Must write in ascending order."); } if (valueIndex >= values.length) { valuesCount = values.length; throw new IndexOutOfBoundsException( String.format("Exceeded limit of %d values per container.", values.length)); } currentKey = key; values[valueIndex] = low; }
Source:
<code>public static double inverseBetaCdf( @SqlType(StandardTypes.DOUBLE) double a, @SqlType(StandardTypes.DOUBLE) double b, @SqlType(StandardTypes.DOUBLE) double p) { checkCondition(p >= 0 && p <= 1, INVALID_FUNCTION_ARGUMENT, "p must be 0 >= p >= 1"); checkCondition(a > 0 && b > 0, INVALID_FUNCTION_ARGUMENT, "a, b must be > 0"); <START> BetaDistribution dist = new BetaDistribution(a, b); <END> return dist.inverseCumulativeProbability(p); }</code><technical_language>abbreviate variable names. Call this distribution</technical_language>

Target:
public static double inverseBetaCdf( @SqlType(StandardTypes.DOUBLE) double a, @SqlType(StandardTypes.DOUBLE) double b, @SqlType(StandardTypes.DOUBLE) double p) { checkCondition(p >= 0 && p <= 1, INVALID_FUNCTION_ARGUMENT, "p must be in the interval [0, 1]"); checkCondition(a > 0, INVALID_FUNCTION_ARGUMENT, "a must be > 0"); checkCondition(b > 0, INVALID_FUNCTION_ARGUMENT, "b must be > 0"); BetaDistribution distribution = new BetaDistribution(null, a, b, BetaDistribution.DEFAULT_INVERSE_ABSOLUTE_ACCURACY); return distribution.inverseCumulativeProbability(p); }
Source:
<code>public void onMatch(RelOptRuleCall call) { if (call.rel(0) instanceof VoltLogicalCalc && call.rel(1) instanceof VoltLogicalTableScan) { VoltLogicalCalc calc = call.rel(0); VoltLogicalTableScan tableScan = call.rel(1); RelDistribution tableDist = tableScan.getTable().getDistribution(); <START> if (tableDist.getType() != RelDistribution.Type.SINGLETON) { <END> if (calc.getProgram().getCondition() == null || !isSinglePartitioned(calc.getProgram(), calc.getProgram().getCondition(), tableDist.getKeys())) { throw new UnsupportedOperationException("MP query not supported in Calcite planner."); } } call.transformTo(calc.copy(calc.getTraitSet().replace(tableDist), calc.getInputs())); } else { RelNode child = call.rel(1); RelDistribution childDist = child.getTraitSet().getTrait(RelDistributionTraitDef.INSTANCE); if (childDist != RelDistributions.ANY) { SingleRel node = call.rel(0); call.transformTo(node.copy(node.getTraitSet().replace(childDist), node.getInputs())); } } }</code><technical_language>combine if's in L97-98</technical_language>

Target:
@Override public void onMatch(RelOptRuleCall call) { if (call.rel(0) instanceof VoltLogicalCalc && call.rel(1) instanceof VoltLogicalTableScan) { VoltLogicalCalc calc = call.rel(0); VoltLogicalTableScan tableScan = call.rel(1); RelDistribution tableDist = tableScan.getTable().getDistribution(); if (tableDist.getType() == RelDistribution.Type.RANDOM_DISTRIBUTED) { throw new PlannerFallbackException("MP query not supported in Calcite planner."); } if (tableDist.getType() != RelDistribution.Type.SINGLETON && (calc.getProgram().getCondition() == null || ! isSinglePartitioned(calc.getProgram(), calc.getProgram().getCondition(), tableDist.getKeys()))) { throw new PlannerFallbackException("MP query not supported in Calcite planner."); } call.transformTo(calc.copy(calc.getTraitSet().replace(tableDist), calc.getInputs())); } else { RelNode child = call.rel(1); RelDistribution childDist = child.getTraitSet().getTrait(RelDistributionTraitDef.INSTANCE); if (childDist != RelDistributions.ANY) { SingleRel node = call.rel(0); call.transformTo(node.copy(node.getTraitSet().replace(childDist), node.getInputs())); } } }
Source:
<code>public void scanHttpResponseReceive(HttpMessage msg, int id, Source source) { checkJsoInHeaders(msg); checkJsoInCookies(msg); <START> checkJsoInBody(msg); <END> }</code><technical_language>worth this in scanHttpRequestSend well? In case Jso is POSTed, etc. method changed msg accepting body</technical_language>

Target:
public void scanHttpResponseReceive(HttpMessage msg, int id, Source source) { checkJsoInHeaders(msg, msg.getResponseHeader().getHeaders()); checkJsoInCookies(msg, msg.getResponseHeader().getHttpCookies(null)); checkJsoInBody(msg, msg.getResponseBody()); }
Source:
<code>private Mono<Void> doHandle(ServerWebExchange exchange) { return Mono.just(exchange) .doOnSubscribe(s -> this.activeCount.incrementAndGet()) .flatMap(this::extractRequestBody) <START> .switchIfEmpty(Mono.just(exchange.getRequest().getQueryParams())) <END> .map(body -> new HttpEntity<>(body, exchange.getRequest().getHeaders())) .map(entity -> buildMessage(entity, exchange)) .flatMap(requestMessage -> { if (this.expectReply) { return sendAndReceiveMessageReactive(requestMessage) .flatMap(replyMessage -> populateResponse(exchange, replyMessage)); } else { send(requestMessage); return setStatusCode(exchange); } }) .doOnTerminate((e, t) -> this.activeCount.decrementAndGet()); }</code><technical_language>Mono.just + flatMap extractRequestBody()</technical_language>

Target:
private Mono<Void> doHandle(ServerWebExchange exchange) { return extractRequestBody(exchange) .doOnSubscribe(s -> this.activeCount.incrementAndGet()) .map(body -> new HttpEntity<>(body, exchange.getRequest().getHeaders())) .map(entity -> buildMessage(entity, exchange)) .flatMap(requestMessage -> { if (this.expectReply) { return sendAndReceiveMessageReactive(requestMessage) .flatMap(replyMessage -> populateResponse(exchange, replyMessage)); } else { send(requestMessage); return setStatusCode(exchange); } }) .doOnTerminate((e, t) -> this.activeCount.decrementAndGet()); }
Source:
<code>protected void onBasicMessage(AvailDataMessage msg) { AvailData availData = msg.getAvailData(); if (log.isTraceEnabled()) { log.trace("Message received with [" + availData.getData().size() + "] avails."); } List<SingleAvail> data = availData.getData(); List<Data> alertData = null; Set<String> activeAvailabilityIds = cacheManager.getActiveAvailabilityIds(); for (SingleAvail a : data) { <START> String fullMetricId = AVAILABILITY + "-" + a.getId(); <END> if (isNeeded(activeAvailabilityIds, fullMetricId)) { if (null == alertData) { alertData = new ArrayList<>(data.size()); } alertData.add(Data.forAvailability(a.getTenantId(), fullMetricId, a.getTimestamp(), AvailabilityType.valueOf(a.getAvail()))); } } if (null == alertData) { if (log.isTraceEnabled()) { log.trace("Forwarding 0 of [" + data.size() + "] avails to Alerts Engine..."); } } else { if (log.isDebugEnabled()) { log.debug("Forwarding [" + alertData.size() + "] of [" + data.size() + "] avails to Alerts Engine " + "(filtered [" + (data.size() - alertData.size()) + "])..."); } try { alerts.sendData(alertData); } catch (Exception e) { throw new RuntimeException(e); } } }</code><technical_language>mentioned, I need this prefix</technical_language>

Target:
protected void onBasicMessage(AvailDataMessage msg) { AvailData availData = msg.getAvailData(); if (log.isTraceEnabled()) { log.trace("Message received with [" + availData.getData().size() + "] avails."); } List<SingleAvail> data = availData.getData(); List<Data> alertData = null; Set<DataIdKey> activeAvailabilityIds = cacheManager.getActiveAvailabilityIds(); for (SingleAvail a : data) { String fullMetricId = AVAILABILITY + "-" + a.getId(); if (isNeeded(activeAvailabilityIds, new DataIdKey(a.getTenantId(), fullMetricId))) { if (null == alertData) { alertData = new ArrayList<>(data.size()); } alertData.add(Data.forAvailability(a.getTenantId(), fullMetricId, a.getTimestamp(), AvailabilityType.valueOf(a.getAvail()))); } } if (null == alertData) { if (log.isTraceEnabled()) { log.trace("Forwarding 0 of [" + data.size() + "] avails to Alerts Engine..."); } } else { if (log.isDebugEnabled()) { log.debug("Forwarding [" + alertData.size() + "] of [" + data.size() + "] avails to Alerts Engine " + "(filtered [" + (data.size() - alertData.size()) + "])..."); } try { alerts.sendData(alertData); } catch (Exception e) { throw new RuntimeException(e); } } }
Source:
<code>public void iterateReader() { String ionText = "1 2 3 4"; IonReader ionReader = system().newReader(ionText); Iterator<IonValue> iterate = system().iterate(ionReader); assertTrue(iterate.hasNext()); assertEquals(1, ((IonInt) iterate.next()).intValue()); assertTrue(iterate.hasNext()); assertEquals(2, ((IonInt) iterate.next()).intValue()); assertTrue(iterate.hasNext()); assertEquals(3, ((IonInt) iterate.next()).intValue()); assertTrue(iterate.hasNext()); assertEquals(4, ((IonInt) iterate.next()).intValue()); assertFalse(iterate.hasNext()); <START> } <END></code><technical_language>ionReader.close() ? (not necessary, if this is right habit, follow it)</technical_language>

Target:
public void iterateReader() throws IOException { String ionText = "1 2 3 4"; IonReader ionReader = system().newReader(ionText); Iterator<IonValue> iterate = system().iterate(ionReader); assertTrue(iterate.hasNext()); assertEquals(1, ((IonInt) iterate.next()).intValue()); assertTrue(iterate.hasNext()); assertEquals(2, ((IonInt) iterate.next()).intValue()); assertTrue(iterate.hasNext()); assertEquals(3, ((IonInt) iterate.next()).intValue()); assertTrue(iterate.hasNext()); assertEquals(4, ((IonInt) iterate.next()).intValue()); assertFalse(iterate.hasNext()); ionReader.close(); }
Source:
<code>public static HCatSchema toHiveSchema(Schema schema, HCatSchema tableSchema) { List<HCatFieldSchema> fields = Lists.newArrayList(); for (Schema.Field field : schema.getFields()) { String name = field.getName(); try { HCatFieldSchema hCatFieldSchema = tableSchema.get(name); Preconditions.checkNotNull(hCatFieldSchema, "Missing field %s in table schema", name); PrimitiveTypeInfo hiveType = hCatFieldSchema.getTypeInfo(); PrimitiveTypeInfo type = getType(name, field.getSchema()); if (!hiveType.equals(type)) { LOG.warn("The given schema for the field does not match the schema from the table. " + "The schema for field will be used.", type, name, hiveType, hiveType, name); } fields.add(hCatFieldSchema); } catch (HCatException e) { LOG.error("Failed to create HCatFieldSchema field of type from schema", name, field.getSchema().getType(), e); <START> Throwables.propagate(e); <END> } } return new HCatSchema(fields); }</code><technical_language>I throw exception message is logged, e parent instead of logging throwing a RuntimeException. IllegalArgumentException caller is, sending in bad input? kind of a moot point. code, tableSchema.get(name) declares throws HCatException, throw HCatException. Good job Hive..</technical_language>

Target:
public static HCatSchema toHiveSchema(Schema schema, HCatSchema tableSchema) { List<HCatFieldSchema> fields = Lists.newArrayList(); for (Schema.Field field : schema.getFields()) { String name = field.getName(); try { HCatFieldSchema hCatFieldSchema = tableSchema.get(name); Preconditions.checkNotNull(hCatFieldSchema, "Missing field %s in table schema", name); PrimitiveTypeInfo hiveType = hCatFieldSchema.getTypeInfo(); PrimitiveTypeInfo type = getType(name, field.getSchema()); if (!hiveType.equals(type)) { LOG.warn("The given schema for the field does not match the schema from the table. " + "The schema for field will be used.", type, name, hiveType, hiveType, name); } fields.add(hCatFieldSchema); } catch (HCatException e) { throw new IllegalArgumentException( String.format("Failed to create HCatFieldSchema field %s of type %s from schema", name, field.getSchema().getType()), e); } } return new HCatSchema(fields); }