auphong2707/dl4se-code-review-dataset huggingface dataset:
Source:
<code>void shouldUpdateChargeToExpire_IfEpdqStatusIs6WithRelevantChargeStatus() { final String payload = notificationPayloadForTransaction(payId, EPDQ_AUTHORISED_CANCELLED); charge = Charge.from(ChargeEntityFixture.aValidChargeEntity() .withStatus(EXPIRE_CANCEL_SUBMITTED) .build()); setUpGatewayAccountToReturnGatewayAccountEntity(Optional.of(gatewayAccountEntity)); setUpChargeServiceToReturnCharge(Optional.of(charge)); <START> final boolean result = notificationService.handleNotificationFor(payload, FORWARDED_IP_ADDRESSES); assertTrue(result); <END> verify(mockChargeNotificationProcessor).invoke(payId, charge, EXPIRE_FLOW.getSuccessTerminalState(), null); }</code><technical_language>inlined</technical_language>

Target:
void shouldUpdateChargeToExpire_IfEpdqStatusIs6WithRelevantChargeStatus() { final String payload = notificationPayloadForTransaction(payId, EPDQ_AUTHORISED_CANCELLED); charge = Charge.from(ChargeEntityFixture.aValidChargeEntity() .withStatus(EXPIRE_CANCEL_SUBMITTED) .build()); setUpGatewayAccountToReturnGatewayAccountEntity(Optional.of(gatewayAccountEntity)); setUpChargeServiceToReturnCharge(Optional.of(charge)); assertTrue(notificationService.handleNotificationFor(payload, FORWARDED_IP_ADDRESSES)); verify(mockChargeNotificationProcessor).invoke(payId, charge, EXPIRE_FLOW.getSuccessTerminalState(), null); }
Source:
<code>public XPathFuncExpr(XPathQName id, XPathExpression[] args) throws XPathSyntaxException { if ("if".equals(id.name) && args.length != 3) { throw new XPathSyntaxException("if() function requires 3 arguments but " + args.length + " are present."); } else if ("cond".equals(id.name)) { if (args.length < 3 || args.length % 2 != 1) { <START> throw new XPathSyntaxException("cond() function requires an odd number of arguments. " + args.length + " are present."); <END> } } this.id = id; this.args = args; }</code><technical_language>Technically call cond() 1 argument here, error message confusing. split 2 checks a error message for args.length < 3,</technical_language>

Target:
public XPathFuncExpr(XPathQName id, XPathExpression[] args) throws XPathSyntaxException { if ("if".equals(id.name) && args.length != 3) { throw new XPathSyntaxException("if() function requires 3 arguments but " + args.length + " are present."); } else if ("cond".equals(id.name)) { if (args.length < 3) { throw new XPathSyntaxException("cond() function requires at least 3 arguments. " + args.length + " arguments provided."); } else if (args.length % 2 != 1) { throw new XPathSyntaxException("cond() function requires an odd number of arguments. " + args.length + " arguments provided."); } } this.id = id; this.args = args; }
Source:
<code>static StoreDraft of(final String key, @Nullable final LocalizedString name) { <START> return new StoreDraftDsl(key, Collections.emptyList(), name); <END> }</code><technical_language>new ArrayList<>();</technical_language>

Target:
static StoreDraft of(final String key, @Nullable final LocalizedString name) { return new StoreDraftDsl(key, new ArrayList<>(), name); }
Source:
<code>private static Statement rhsAssignWithValue( VariableDeclarationExpr vdExpr, Type exprType, String value) { if (vdExpr.getVars().size() != 1) { return null; } VariableDeclarationExpr resultExpr = (VariableDeclarationExpr) vdExpr.clone(); VariableDeclarator vd = resultExpr.getVars().get(0); if (exprType instanceof PrimitiveType) { switch (((PrimitiveType) exprType).getType()) { case Boolean: if (value == null) { vd.setInit(new BooleanLiteralExpr(Boolean.parseBoolean("false"))); } else { vd.setInit(new BooleanLiteralExpr(Boolean.parseBoolean(value))); } break; case Char: case Byte: case Short: case Int: if (value == null) { vd.setInit(new IntegerLiteralExpr("0")); } else { vd.setInit(new IntegerLiteralExpr(value)); } break; case Float: if (value == null) { vd.setInit(new DoubleLiteralExpr("0f")); } else { vd.setInit(new DoubleLiteralExpr(value)); } break; case Double: if (value == null) { vd.setInit(new DoubleLiteralExpr("0.0")); } else { vd.setInit(new DoubleLiteralExpr(value)); } break; case Long: if (value == null) { <START> vd.setInit(new LongLiteralExpr("0l")); <END> } else { vd.setInit(new LongLiteralExpr(value)); } break; } } else { vd.setInit(new NullLiteralExpr()); } return new ExpressionStmt(resultExpr); }</code><technical_language>uppercase "L" in long literal expressions. lowercase letter "l" number "1"</technical_language>

Target:
private static Statement rhsAssignWithValue( VariableDeclarationExpr vdExpr, Type exprType, String value) { if (vdExpr.getVars().size() != 1) { return null; } VariableDeclarationExpr resultExpr = (VariableDeclarationExpr) vdExpr.clone(); VariableDeclarator vd = resultExpr.getVars().get(0); if (exprType instanceof PrimitiveType) { vd.setInit(getLiteralExpression(value, ((PrimitiveType) exprType).getType())); } else { vd.setInit(new NullLiteralExpr()); } return new ExpressionStmt(resultExpr); }
Source:
<code><START> public static boolean IsWindowsXPOrGreater() { <END> return IsWindowsVersionOrGreater(HIBYTE(WinNT.WIN32_WINNT_WINXP), LOBYTE(WinNT.WIN32_WINNT_WINXP), 0); }</code><technical_language>I this, I a saner version, repeats... worth evaluation is, if pulling HIBYTE(WinNT.WIN32_WINNT_WINXP) LOBYTE(WinNT.WIN32_WINNT_WINXP) private static final variables worth it</technical_language>

Target:
public static boolean IsWindowsXPOrGreater() { return IsWindowsVersionOrGreater((byte) (Kernel32.WIN32_WINNT_WINXP >>> 8), (byte) Kernel32.WIN32_WINNT_WINXP, 0); }
Source:
<code>public GridCacheContextInfo(DynamicCacheDescriptor cacheDesc) { <START> config = new CacheConfiguration(cacheDesc.cacheConfiguration()); <END> dynamicDeploymentId = cacheDesc.deploymentId(); groupId = cacheDesc.groupId(); cacheId = CU.cacheId(config.getName()); clientCache = true; }</code><technical_language>new CacheConfiguration<> remove compiler warning</technical_language>

Target:
public GridCacheContextInfo(DynamicCacheDescriptor cacheDesc) { config = cacheDesc.cacheConfiguration(); dynamicDeploymentId = cacheDesc.deploymentId(); groupId = cacheDesc.groupId(); cacheId = CU.cacheId(config.getName()); clientCache = true; }
Source:
<code>public JSchConnection getProxyConnection() { String proxyConnectionName = getProxyConnectionName(); if (proxyConnectionName.equals(EMPTY_STRING)) { return null; <START> } else { <END> return (JSchConnection) fManager.getConnection(proxyConnectionName); } }</code><technical_language>Redundant else</technical_language>

Target:
public JSchConnection getProxyConnection() { String proxyConnectionName = getProxyConnectionName(); if (proxyConnectionName.equals(EMPTY_STRING)) { return null; } return (JSchConnection) fManager.getConnection(proxyConnectionName); }
Source:
<code>public void doAuthorise_shouldRespondAuthorisationSuccess() throws Exception { Auth3dsDetails auth3dsDetails = AuthUtils.buildAuth3dsDetails(); ArgumentCaptor<Auth3dsResponseGatewayRequest> argumentCaptor = ArgumentCaptor.forClass(Auth3dsResponseGatewayRequest.class); when(mockedChargeDao.findByExternalId(charge.getExternalId())) .thenReturn(Optional.of(charge)); setupMockExecutorServiceMock(); setupPaymentProviderMock(charge.getGatewayTransactionId(), AuthoriseStatus.AUTHORISED, null, argumentCaptor); when(mockedProviders.byName(charge.getPaymentGatewayName())).thenReturn(mockedPaymentProvider); <START> PaymentRequestEntity paymentRequestEntity = PaymentRequestEntityFixture.aValidPaymentRequestEntity().build(); <END> when(mockPaymentRequestDao.updateChargeTransactionStatus(charge.getExternalId(), AUTHORISATION_SUCCESS)) .thenReturn(Optional.of(paymentRequestEntity)); GatewayResponse response = card3dsResponseAuthService.doAuthorise(charge.getExternalId(), auth3dsDetails); assertThat(response.isSuccessful(), is(true)); assertThat(charge.getStatus(), is(AUTHORISATION_SUCCESS.getValue())); assertThat(charge.getGatewayTransactionId(), is(GENERATED_TRANSACTION_ID)); assertThat(paymentRequestEntity.getChargeTransaction().getGatewayTransactionId(), is(GENERATED_TRANSACTION_ID)); assertTrue(argumentCaptor.getValue().getTransactionId().isPresent()); assertThat(argumentCaptor.getValue().getTransactionId().get(), is(GENERATED_TRANSACTION_ID)); }</code><technical_language>another test result of PaymentRequestEntityFixture.aValidPaymentRequestEntity().build(), move this a field</technical_language>

Target:
public void doAuthorise_shouldRespondAuthorisationSuccess() throws Exception { Auth3dsDetails auth3dsDetails = AuthUtils.buildAuth3dsDetails(); ArgumentCaptor<Auth3dsResponseGatewayRequest> argumentCaptor = ArgumentCaptor.forClass(Auth3dsResponseGatewayRequest.class); when(mockedChargeDao.findByExternalId(charge.getExternalId())) .thenReturn(Optional.of(charge)); setupMockExecutorServiceMock(); setupPaymentProviderMock(charge.getGatewayTransactionId(), AuthoriseStatus.AUTHORISED, null, argumentCaptor); when(mockedProviders.byName(charge.getPaymentGatewayName())).thenReturn(mockedPaymentProvider); when(mockPaymentRequestDao.findByExternalId(charge.getExternalId())) .thenReturn(Optional.of(aValidPaymentRequestEntity)); GatewayResponse response = card3dsResponseAuthService.doAuthorise(charge.getExternalId(), auth3dsDetails); assertThat(response.isSuccessful(), is(true)); assertThat(charge.getStatus(), is(AUTHORISATION_SUCCESS.getValue())); assertThat(charge.getGatewayTransactionId(), is(GENERATED_TRANSACTION_ID)); assertThat(aValidPaymentRequestEntity.getChargeTransaction().getGatewayTransactionId(), is(GENERATED_TRANSACTION_ID)); assertTrue(argumentCaptor.getValue().getTransactionId().isPresent()); assertThat(argumentCaptor.getValue().getTransactionId().get(), is(GENERATED_TRANSACTION_ID)); verify(mockStatusUpdater).updateChargeTransactionStatus(charge.getExternalId(), AUTHORISATION_SUCCESS); }
Source:
<code>HelixNotifier(HelixPropertyStore<ZNRecord> helixStore) { if (helixStore == null) { <START> throw new IllegalArgumentException("helixStore and metricRegistry cannot be null."); <END> } this.helixStore = helixStore; }</code><technical_language>minor: more metric registry</technical_language>

Target:
HelixNotifier(HelixPropertyStore<ZNRecord> helixStore) { if (helixStore == null) { throw new IllegalArgumentException("helixStore cannot be null."); } this.helixStore = helixStore; }
Source:
<code>private void appendSemanticElementsToDestroy(final DDiagramElement currentDiagramElement, Set<EObject> elementsToDestroy) { for (final EObject semantic : currentDiagramElement.getSemanticElements()) { if (semantic != null && !elementsToDestroy.contains(semantic)) { elementsToDestroy.add(semantic); <START> elementsToDestroy.addAll(getAllChildren(semantic)); <END> } } for (final EObject child : currentDiagramElement.eContents()) { if (child instanceof DDiagramElement) { appendSemanticElementsToDestroy((DDiagramElement) child, elementsToDestroy); } } }</code><technical_language>If need eAllContents() getAllChildren(), avoid creating intermediate HashSet getAllChilren with: Iterators.addAll(elementsToDestroy, semantic.eAllContents()); lines replaced a single one: Iterators.addAll(elementsToDestroy, AllContents.of(semantic, true));</technical_language>

Target:
private void appendSemanticElementsToDestroy(final DDiagramElement currentDiagramElement, Set<EObject> elementsToDestroy) { for (final EObject semantic : currentDiagramElement.getSemanticElements()) { if (semantic != null && !elementsToDestroy.contains(semantic)) { Iterables.addAll(elementsToDestroy, AllContents.of(semantic, true)); } } for (final EObject child : currentDiagramElement.eContents()) { if (child instanceof DDiagramElement) { appendSemanticElementsToDestroy((DDiagramElement) child, elementsToDestroy); } } }
Source:
<code>public void onPartitionBecomeLeaderFromStandby(String partitionName) { logger.info("Partition state change notification from Standby to Leader received for partition {}", partitionName); ReplicaId localReplica = storeManager.getReplica(partitionName); List<? extends ReplicaId> leaderReplicas = localReplica.getPartitionId().getReplicaIdsByState(ReplicaState.LEADER, null); List<ReplicaId> peerLeaderReplicas = new ArrayList<>(); for (ReplicaId leaderReplica : leaderReplicas) { if (leaderReplica.getDataNodeId() != localReplica.getDataNodeId()) { peerLeaderReplicas.add(leaderReplica); <START> logger.info("Partition on Node is leader in remote dc {}", partitionName, <END> leaderReplica.getDataNodeId().toString(), leaderReplica.getDataNodeId().getDatacenterName()); } } peerLeaderReplicasByPartition.put(partitionName, peerLeaderReplicas); }</code><technical_language>minor: I noticed AmbryDataNode.toString() print out DataNode, remove Node in log message</technical_language>

Target:
public void onPartitionBecomeLeaderFromStandby(String partitionName) { logger.info("Partition state change notification from Standby to Leader received for partition {}", partitionName); ReplicaId localReplica = storeManager.getReplica(partitionName); List<? extends ReplicaId> leaderReplicas = localReplica.getPartitionId().getReplicaIdsByState(ReplicaState.LEADER, null); List<ReplicaId> peerLeaderReplicas = new ArrayList<>(); for (ReplicaId leaderReplica : leaderReplicas) { if (leaderReplica.getDataNodeId() != localReplica.getDataNodeId()) { peerLeaderReplicas.add(leaderReplica); logger.info("Partition on node instance is leader in remote dc {}", partitionName, getInstanceName(leaderReplica.getDataNodeId().getHostname(), leaderReplica.getDataNodeId().getPort()), leaderReplica.getDataNodeId().getDatacenterName()); } } peerLeaderReplicasByPartition.put(partitionName, peerLeaderReplicas); }
Source:
<code>public String downloadRecording(String callID, String legId, String recordingId, String basePath) throws NotFoundException, GeneralException, UnauthorizedException { if (callID == null) { throw new IllegalArgumentException("Voice call ID must be specified."); } if (legId == null) { throw new IllegalArgumentException("Leg ID must be specified."); } if (recordingId == null) { throw new IllegalArgumentException("Recording ID must be specified."); } <START> <END> String url = String.format( "%s%s/%s%s/%s%s/%s%s", VOICE_CALLS_BASE_URL, VOICECALLSPATH, callID, LEGSPATH, legId, RECORDINGPATH, recordingId, RECORDING_DOWNLOAD_FORMAT ); String fileName = String.format("%s%s",recordingId, RECORDING_DOWNLOAD_FORMAT); return messageBirdService.getBinaryData(url, basePath, fileName); }</code><technical_language>is basePath null check basePath param optional. default, download endpoint download recording in downloads directly. If customer wants path give basePath variable. do think? this change is specific constraint developer doc</technical_language>

Target:
public String downloadRecording(String callID, String legId, String recordingId, String basePath) throws NotFoundException, GeneralException, UnauthorizedException { if (callID == null) { throw new IllegalArgumentException("Voice call ID must be specified."); } if (legId == null) { throw new IllegalArgumentException("Leg ID must be specified."); } if (recordingId == null) { throw new IllegalArgumentException("Recording ID must be specified."); } if (basePath == null) { String homePath = System.getProperty("user.home"); if (homePath == null) { throw new IllegalArgumentException("BasePath must be specified."); } basePath = String.format("%s/%s",homePath,DOWNLOADS); } String url = String.format( "%s%s/%s%s/%s%s/%s%s", VOICE_CALLS_BASE_URL, VOICECALLSPATH, callID, LEGSPATH, legId, RECORDINGPATH, recordingId, RECORDING_DOWNLOAD_FORMAT ); String fileName = String.format("%s%s",recordingId, RECORDING_DOWNLOAD_FORMAT); return messageBirdService.getBinaryData(url, basePath, fileName); }
Source:
<code>public Optional<PlanNode> apply(PlanNode node, Lookup lookup, PlanNodeIdAllocator idAllocator, SymbolAllocator symbolAllocator, Session session) { FilterNode filterNode = (FilterNode) node; Expression canonicalized = canonicalizeExpression(filterNode.getPredicate()); <START> if (canonicalized.equals(TRUE_LITERAL)) { <END> return Optional.of(filterNode.getSource()); } if (canonicalized.equals(filterNode.getPredicate())) { return Optional.empty(); } return Optional.of(new FilterNode(node.getId(), filterNode.getSource(), canonicalized)); }</code><technical_language>case predicate evaluates FALSE_LITERAL</technical_language>

Target:
public Optional<PlanNode> apply(PlanNode node, Lookup lookup, PlanNodeIdAllocator idAllocator, SymbolAllocator symbolAllocator, Session session) { FilterNode filterNode = (FilterNode) node; Expression canonicalized = canonicalizeExpression(filterNode.getPredicate()); if (canonicalized.equals(filterNode.getPredicate())) { return Optional.empty(); } return Optional.of(new FilterNode(node.getId(), filterNode.getSource(), canonicalized)); }
Source:
<code>public Map<UserPrivilege.Keys, UserPrivilege> getPrivileges() { <START> return this.privileges; <END> }</code><technical_language>Map mutated caller</technical_language>

Target:
public synchronized ConcurrentMap<UserPrivilege.Keys, UserPrivilege> getPrivileges() { return this.privileges; }
Source:
<code>public void fetchesOpenTasks() throws Exception { final Repo repo = new MkRepo(); <START> final long[] closed = new long[]{0L, 1L, 2L}; <END> final long[] open = new long[]{3L, 4L}; final Region region = DyTasksTest.region(repo.name(), closed); final Table table = region.table(DyTask.TBL); for (final long tid : open) { table.put(task(repo.name(), tid, true)); } final Iterable<Task> tasks = new DyTasks(region, repo).open(); MatcherAssert.assertThat( tasks, Matchers.<Task>iterableWithSize(open.length) ); for (final Task task : tasks) { MatcherAssert.assertThat( task.number(), Matchers.isIn(Arrays.asList(ArrayUtils.toObject(open))) ); } }</code><technical_language>this inlined</technical_language>

Target:
public void fetchesOpenTasks() throws Exception { final Repo repo = new MkRepo(); final Region region = DyTasksTest.region(repo.name(), new long[]{0L, 1L, 2L}); final long[] open = new long[]{3L, 4L}; final Table table = region.table(DyTask.TBL); for (final long tid : open) { table.put(task(repo.name(), tid, true)); } final Iterable<Task> tasks = new DyTasks(region, repo).open(); MatcherAssert.assertThat( tasks, Matchers.<Task>iterableWithSize(open.length) ); for (final Task task : tasks) { MatcherAssert.assertThat( task.number(), Matchers.isIn(Arrays.asList(ArrayUtils.toObject(open))) ); } }
Source:
<code>public void define(WebService.NewController context) { WebService.NewAction action = context.createAction("template_groups") .setSince("5.2") .setInternal(true) .setDescription("Lists the groups with their permission as individual groups rather than through user affiliation on the chosen template.<br />" + "This service defaults to all groups, but can be limited to groups with a specific permission by providing the desired permission.<br>" + "Requires the following permission: 'Administer System'.") .addPagingParams(DEFAULT_PAGE_SIZE, RESULTS_MAX_SIZE) .setResponseExample(getClass().getResource("template_groups-example.json")) .setHandler(this); action.createParam(TEXT_QUERY) .setMinimumLength(SEARCH_QUERY_MIN_LENGTH) .setDescription("Limit search to group names that contain the supplied string. <br/>" + "When this parameter is not set, only group having at least one permission are returned.") <START> .setExampleValue("eri"); <END> action.createParam(PARAM_PERMISSION) .setDescription(PROJECT_PERMISSION_PARAM_DESCRIPTION) .setPossibleValues(ProjectPermissions.ALL); createTemplateParameters(action); }</code><technical_language>suggestion: method add isRequired(false)</technical_language>

Target:
public void define(WebService.NewController context) { WebService.NewAction action = context.createAction("template_groups") .setSince("5.2") .setInternal(true) .setDescription("Lists the groups with their permission as individual groups rather than through user affiliation on the chosen template.<br />" + "This service defaults to all groups, but can be limited to groups with a specific permission by providing the desired permission.<br>" + "Requires the following permission: 'Administer System'.") .addPagingParams(DEFAULT_PAGE_SIZE, RESULTS_MAX_SIZE) .setResponseExample(getClass().getResource("template_groups-example.json")) .setHandler(this); action.createParam(TEXT_QUERY) .setMinimumLength(SEARCH_QUERY_MIN_LENGTH) .setDescription("Limit search to group names that contain the supplied string. <br/>" + "When this parameter is not set, only group having at least one permission are returned.") .setExampleValue("eri"); createProjectPermissionParameter(action, false); createTemplateParameters(action); }
Source:
<code>public boolean isAPIPublishedInAnyGateway(String APIId) throws APIManagementException { int count = 0; <START> try (Connection connection = GatewayArtifactsMgtDBUtil.getArtifactSynchronizerConnection(); <END> PreparedStatement statement = connection.prepareStatement(SQLConstants.GET_PUBLISHED_GATEWAYS_FOR_API)) { statement.setString(1, APIId); statement.setString(2, APIConstants.GatewayArtifactSynchronizer.GATEWAY_INSTRUCTION_PUBLISH); ResultSet rs = statement.executeQuery(); while (rs.next()) { count = rs.getInt("COUNT"); } } catch (SQLException e) { handleException("Failed check whether API is published in any gateway " + APIId, e); } return count != 0; }</code><technical_language>a practice a good idea call commit a connection is returned pool performing a SELECT operation. This ensures uncommitted data returned DB. pattern be, try (Connection connection = GatewayArtifactsMgtDBUtil.getArtifactSynchronizerConnection(); connection.setAutoCommit(false); connection.commit(); PreparedStatement statement = connection.prepareStatement("SELECT ...")) { }</technical_language>

Target:
public boolean isAPIPublishedInAnyGateway(String APIId) throws APIManagementException { int count = 0; ResultSet rs = null; try (Connection connection = GatewayArtifactsMgtDBUtil.getArtifactSynchronizerConnection(); PreparedStatement statement = connection .prepareStatement(SQLConstants.GET_PUBLISHED_GATEWAYS_FOR_API)) { connection.setAutoCommit(false); connection.commit(); statement.setString(1, APIId); statement.setString(2, APIConstants.GatewayArtifactSynchronizer.GATEWAY_INSTRUCTION_PUBLISH); rs = statement.executeQuery(); while (rs.next()) { count = rs.getInt("COUNT"); } } catch (SQLException e) { handleException("Failed check whether API is published in any gateway " + APIId, e); } finally { GatewayArtifactsMgtDBUtil.closeResultSet(rs); } return count != 0; }
Source:
<code>public void stream(String url, String sinkId) throws AudioException { <START> <END> AudioStream audioStream = new URLAudioStream(url); AudioSink sink = null; if (sinkId == null) { sink = getSink(); } else { sink = audioSinks.get(sinkId); } if (sink != null) { try { sink.process(audioStream); } catch (UnsupportedAudioFormatException e) { logger.error("Error playing '{}': {}", url, e.getMessage()); } } }</code><technical_language>need touch this file, I this empty line removed</technical_language>

Target:
public void stream(String url, String sinkId) throws AudioException { AudioStream audioStream = new URLAudioStream(url); AudioSink sink = getSink(sinkId); if (sink != null) { try { sink.process(audioStream); } catch (UnsupportedAudioFormatException e) { logger.error("Error playing '{}': {}", url, e.getMessage()); } } }
Source:
<code>public int getDataState() { try { ITelephony telephony = getITelephony(); if (telephony == null) return DATA_DISCONNECTED; return telephony.getDataState( <START> getSubId(SubscriptionManager.getDefaultDataSubscriptionId())); <END> } catch (RemoteException ex) { return DATA_DISCONNECTED; } catch (NullPointerException ex) { return DATA_DISCONNECTED; } }</code><technical_language>getSubId(SubscriptionManager.getActiveDataSubscriptionId()) is more accurate CBRS data connection is preferred subId default subId set users</technical_language>

Target:
public int getDataState() { try { ITelephony telephony = getITelephony(); if (telephony == null) return DATA_DISCONNECTED; return telephony.getDataState( getSubId(SubscriptionManager.getActiveDataSubscriptionId())); } catch (RemoteException ex) { return DATA_DISCONNECTED; } catch (NullPointerException ex) { return DATA_DISCONNECTED; } }
Source:
<code>getDefaultOutputFormatters( TargetAccessor<ConfiguredTarget> accessor, ExtendedEventHandler eventHandler, OutputStream out, SkyframeExecutor skyframeExecutor, BuildConfiguration hostConfiguration, @Nullable TransitionFactory<Rule> trimmingTransitionFactory, PackageManager packageManager) { AspectResolver aspectResolver = cqueryOptions.aspectDeps.createResolver(packageManager, eventHandler); return ImmutableList.of( new LabelAndConfigurationOutputFormatterCallback( eventHandler, cqueryOptions, out, skyframeExecutor, accessor), <START> new LabelKindAndConfigurationOutputFormatterCallback( <END> eventHandler, cqueryOptions, out, skyframeExecutor, accessor, getAccessor()), new TransitionsOutputFormatterCallback( eventHandler, cqueryOptions, out, skyframeExecutor, accessor, hostConfiguration, trimmingTransitionFactory), new ProtoOutputFormatterCallback( eventHandler, cqueryOptions, out, skyframeExecutor, accessor, aspectResolver, OutputType.BINARY), new ProtoOutputFormatterCallback( eventHandler, cqueryOptions, out, skyframeExecutor, accessor, aspectResolver, OutputType.TEXT), new ProtoOutputFormatterCallback( eventHandler, cqueryOptions, out, skyframeExecutor, accessor, aspectResolver, OutputType.JSON), new BuildOutputFormatterCallback( eventHandler, cqueryOptions, out, skyframeExecutor, accessor)); }</code><technical_language>PR included a file defines this class</technical_language>

Target:
getDefaultOutputFormatters( TargetAccessor<ConfiguredTarget> accessor, ExtendedEventHandler eventHandler, OutputStream out, SkyframeExecutor skyframeExecutor, BuildConfiguration hostConfiguration, @Nullable TransitionFactory<Rule> trimmingTransitionFactory, PackageManager packageManager) { AspectResolver aspectResolver = cqueryOptions.aspectDeps.createResolver(packageManager, eventHandler); return ImmutableList.of( new LabelAndConfigurationOutputFormatterCallback( eventHandler, cqueryOptions, out, skyframeExecutor, accessor, true), new LabelAndConfigurationOutputFormatterCallback( eventHandler, cqueryOptions, out, skyframeExecutor, accessor, false), new TransitionsOutputFormatterCallback( eventHandler, cqueryOptions, out, skyframeExecutor, accessor, hostConfiguration, trimmingTransitionFactory), new ProtoOutputFormatterCallback( eventHandler, cqueryOptions, out, skyframeExecutor, accessor, aspectResolver, OutputType.BINARY), new ProtoOutputFormatterCallback( eventHandler, cqueryOptions, out, skyframeExecutor, accessor, aspectResolver, OutputType.TEXT), new ProtoOutputFormatterCallback( eventHandler, cqueryOptions, out, skyframeExecutor, accessor, aspectResolver, OutputType.JSON), new BuildOutputFormatterCallback( eventHandler, cqueryOptions, out, skyframeExecutor, accessor)); }
Source:
<code>public static void enableVault(SuiteContext suiteContext, EnableVault.PROVIDER_ID provider) throws IOException, CliException, TimeoutException, InterruptedException { if (suiteContext.getAuthServerInfo().isUndertow()) { System.setProperty("keycloak.vault." + provider.getName() + ".provider.enabled", "true"); } else { OnlineManagementClient client = AuthServerTestEnricher.getManagementClient(); client.execute("/subsystem=keycloak-server/spi=vault/:add"); <START> client.execute("/subsystem=keycloak-server/spi=vault/provider=elytron-cs-keystore/:add(enabled=" + (provider == ELYTRON_CS_KEYSTORE) + <END> ",properties={location => \"${jboss.home.dir}/standalone/configuration/vault/credential-store.p12\", " + "secret => \"MASK-3u2HNQaMogJJ8VP7J6gRIl;12345678;321\", keyStoreType => \"PKCS12\"})"); client.execute("/subsystem=keycloak-server/spi=vault/provider=files-plaintext/:add(enabled=" + (provider == PLAINTEXT) + ",properties={dir => \"${jboss.home.dir}/standalone/configuration/vault\"})"); client.close(); } }</code><technical_language>This a bit fragile. Is better, more declarative object oriented implement this? If - I guess this is fine</technical_language>

Target:
public static void enableVault(SuiteContext suiteContext, EnableVault.PROVIDER_ID provider) throws IOException, CliException, TimeoutException, InterruptedException { if (suiteContext.getAuthServerInfo().isUndertow()) { System.setProperty("keycloak.vault." + provider.getName() + ".provider.enabled", "true"); } else { OnlineManagementClient client = AuthServerTestEnricher.getManagementClient(); client.execute("/subsystem=keycloak-server/spi=vault/:add(default-provider=" + provider.getName() + ")"); client.execute(provider.getCliInstallationCommand()); client.close(); } }
Source:
<code>public void shouldAllowRequestToShare() { final String resourceName = "Resource 12"; myResourcesPage.clickPendingRequest(resourceName); <START> waitForModalFadeIn(); <END> myResourcesPage.acceptRequest(resourceName, 0); waitForModalFadeOut(); myResourcesPage.clickSignOut(); myResourcesPage.navigateTo(); loginPage.form().login(createUser("alice")); myResourcesPage.clickSharedWithMeTab(); assertTrue(myResourcesPage.containsResource(resourceName)); }</code><technical_language>waitForModalFadeIn waitForModalFadeOut is meant Admin Console. apparent sight, Admin Console testsuite is a mess. a coincidence works I rely that. Consider [testModalDialog](<LINK_0> discussed</technical_language>

Target:
public void shouldAllowRequestToShare() { final String resourceName = "Resource 12"; assertEquals("1", myResourcesPage.getPendingRequestText(resourceName)); switchUserSharedWithMeTab(); assertFalse(myResourcesPage.containsResource(resourceName)); login("jdoe"); myResourcesPage.clickPendingRequest(resourceName); assertEquals("alice", myResourcesPage.getPendingRequestRequestor(0)); final String permissions = myResourcesPage.getPendingRequestPermissions(0); assertTrue(permissions.contains("Scope A")); assertTrue(permissions.contains("Scope B")); myResourcesPage.acceptRequest(resourceName, 0); assertNoPendingRequest(resourceName); switchUserSharedWithMeTab(); assertTrue(myResourcesPage.containsResource(resourceName)); }
Source:
<code>public void setUp() { mAppStartupHelper = new AppStartupHelper(); HelperTestUtility.clearApp(String.format(KILL_TEST_APP_CMD_TEMPLATE, CALENDAR_PKG_NAME)); <START> HelperTestUtility.clearApp(String.format(KILL_TEST_APP_CMD_TEMPLATE, SETTINGS_PKG_NAME)); <END> HelperTestUtility.clearApp(String.format(KILL_TEST_APP_CMD_TEMPLATE, SETTINGS_PKG_NAME)); HelperTestUtility.wakeUpAndUnlock(); }</code><technical_language>remove this</technical_language>

Target:
public void setUp() { mAppStartupHelper = new AppStartupHelper(); HelperTestUtility.clearApp(String.format(KILL_TEST_APP_CMD_TEMPLATE, CALENDAR_PKG_NAME)); HelperTestUtility.clearApp(String.format(KILL_TEST_APP_CMD_TEMPLATE, SETTINGS_PKG_NAME)); HelperTestUtility.wakeUpAndUnlock(); }
Source:
<code><START> public void onForgotPasswordClicked() { <END> startActivity(RecoverPasswordActivity.createIntent( this, getFlowParams(), mEmail)); }</code><technical_language>reason for this public</technical_language>

Target:
private void onForgotPasswordClicked() { startActivity(RecoverPasswordActivity.createIntent( this, getFlowParams(), mEmail)); }
Source:
<code>public void createQuestionValidationErrorsTest() throws Exception { Branch branch = new Branch("name", "description"); branch.setSection(new Section("namesection")); Topic createdQuestion = new Topic(); createdQuestion.setId(1); TopicDto topicDto = new TopicDto(new Topic()); topicDto.setBodyText("text"); Model model = new ExtendedModelMap(); when(result.hasErrors()).thenReturn(true); when(branchService.get(anyLong())).thenReturn(branch); List<Breadcrumb> breadcrumbs = new BreadcrumbBuilder().getNewTopicBreadcrumb(branch); when(breadcrumbBuilder.getNewTopicBreadcrumb(branch)).thenReturn(breadcrumbs); String actual = controller.createQuestion(topicDto, result , model, 1L, request); for (int i = 1; i < breadcrumbs.size(); i++) { <START> if(i == 1) <END> assertEquals(breadcrumbs.get(1).getValue(), branch.getSection().getName()); if(i == 2) assertEquals(breadcrumbs.get(2).getValue(), branch.getName()); } assertEquals(actual, QuestionsAndAnswersController.PLUGIN_VIEW_NAME); assertEquals(model.asMap().get(QuestionsAndAnswersController.CONTENT), content); }</code><technical_language>If block is redundant here. advice out section loop</technical_language>

Target:
public void createQuestionValidationErrorsTest() throws Exception { Branch branch = new Branch("name", "description"); branch.setSection(new Section("namesection")); Topic createdQuestion = new Topic(); createdQuestion.setId(1); TopicDto topicDto = new TopicDto(new Topic()); topicDto.setBodyText("text"); Model model = new ExtendedModelMap(); when(result.hasErrors()).thenReturn(true); when(branchService.get(anyLong())).thenReturn(branch); List<Breadcrumb> breadcrumbs = new BreadcrumbBuilder().getNewTopicBreadcrumb(branch); when(breadcrumbBuilder.getNewTopicBreadcrumb(branch)).thenReturn(breadcrumbs); String actual = controller.createQuestion(topicDto, result , model, 1L, request); assertEquals(breadcrumbs.get(2).getValue(), branch.getName()); assertEquals(breadcrumbs.get(1).getValue(), branch.getSection().getName()); assertEquals(actual, QuestionsAndAnswersController.PLUGIN_VIEW_NAME); assertEquals(model.asMap().get(QuestionsAndAnswersController.CONTENT), content); }
Source:
<code>public final boolean test(IPerson person) { Object[] atts = person.getAttributeValues(getAttributeName()); <START> if (atts != null && atts.length > 0) { <END> return false; } return true; }</code><technical_language>art: return atts == null || atts.length < 1</technical_language>

Target:
public final boolean test(IPerson person) { Object[] atts = person.getAttributeValues(getAttributeName()); return atts == null || atts.length < 1; }
Source:
<code>public void testAddSecretVolumeToPodSpec() throws JSONException { IVolumeMount volumeMount = new IVolumeMount() { public String getName() { return "my-secret"; } public String getMountPath() { return "/path/to/my/secret/"; } public boolean isReadOnly() { return true; } public void setName(String name) public void setMountPath(String path) public void setReadOnly(boolean readonly) }; ((ReplicationController) rc).addSecretVolumeToPodSpec(volumeMount, "the-secret"); Set<IVolumeSource> podSpecVolumes = rc.getVolumes(); <START> boolean found = false; <END> for (IVolumeSource vol : podSpecVolumes) { if(vol.getName().equals(volumeMount.getName())) { found = true; break; } } assertTrue("Expected to find secret volume in pod spec", found); }</code><technical_language>This cleaner a stream, like: Optional<IVolumeSource> vol = podSpecVolumes.stream() .filter(v->v.getName().equals(volumeMount.getName())) .findFirst(); assertTrue("Expected find secret volume in pod spec", vol.isPresent());</technical_language>

Target:
public void testAddSecretVolumeToPodSpec() throws JSONException { IVolumeMount volumeMount = new IVolumeMount() { public String getName() { return "my-secret"; } public String getMountPath() { return "/path/to/my/secret/"; } public boolean isReadOnly() { return true; } public void setName(String name) public void setMountPath(String path) public void setReadOnly(boolean readonly) }; ((ReplicationController) rc).addSecretVolumeToPodSpec(volumeMount, "the-secret"); Set<IVolumeSource> podSpecVolumes = rc.getVolumes(); Optional vol = podSpecVolumes.stream() .filter(v->v.getName().equals(volumeMount.getName())) .findFirst(); assertTrue("Expected to find secret volume in pod spec", vol.isPresent()); }
Source:
<code><START> public int hashCode() { <END> int result = userName == null ? 0 : userName.hashCode(); result = 31 * result + (groups == null ? 0 : groups.hashCode()); result = 31 * result + (roles == null ? 0 : roles.hashCode()); result = 31 * result + (firstName == null ? 0 : firstName.hashCode()); result = 31 * result + (lastName == null ? 0 : lastName.hashCode()); result = 31 * result + (company == null ? 0 : company.hashCode()); result = 31 * result + (password == null ? 0 : password.hashCode()); return result; }</code><technical_language>do org.apache.commons.lang3.builder.EqualsBuilder return new EqualsBuilder().append(company, that.company).append(firstName, that.firstName)... suggestion for future implementation of hashCode org.apache.commons.lang3.builder.HashCodeBuilder</technical_language>

Target:
public int hashCode() { return new HashCodeBuilder().append(userName) .append(groups) .append(roles) .append(firstName) .append(lastName) .append(company) .append(password) .toHashCode(); }
Source:
<code>public IStatus validate(String path) { if (fTrace == null) { <START> return new Status(IStatus.ERROR, Activator.PLUGIN_ID, Messages.TraceTypeHelper_ValidateNoTrace); <END> } return fTrace.validate(null, path); }</code><technical_language>I sense for trace null here. create a new Message file for this case..</technical_language>

Target:
public IStatus validate(String path) { return fTrace.validate(null, path); }
Source:
<code>public void purgeDefinition_shouldPurgeReportDesigns() throws Exception { executeDataSet("org/openmrs/module/reporting/include/ReportDefinitionServiceImplTest.xml"); ReportDefinition definition = reportDefinitionService.getDefinition(80); reportDefinitionService.purgeDefinition(definition); <START> assertThat(reportService.getReportDesign(3), nullValue()); <END> assertThat(reportService.getReportDesign(4), nullValue()); }</code><technical_language>I this done originally, add in checks confirm report designs 3 4 null purge definition operation</technical_language>

Target:
public void purgeDefinition_shouldPurgeReportDesigns() throws Exception { executeDataSet("org/openmrs/module/reporting/include/ReportDefinitionServiceImplTest.xml"); assertThat(reportService.getReportDesign(3), notNullValue()); assertThat(reportService.getReportDesign(4), notNullValue()); Context.clearSession(); ReportDefinition definition = reportDefinitionService.getDefinition(80); reportDefinitionService.purgeDefinition(definition); assertThat(reportService.getReportDesign(3), nullValue()); assertThat(reportService.getReportDesign(4), nullValue()); }
Source:
<code>private static String decodeComponent(String s, int from, int toExcluded, Charset charset, boolean isPath) { int len = toExcluded - from; if (len <= 0) { return EMPTY_STRING; } int firstEscaped = -1; for (int i = from; i < toExcluded; i++) { char c = s.charAt(i); if (c == '%' || c == '+' && !isPath) { firstEscaped = i; break; } } if (firstEscaped == -1) { return s.substring(from, toExcluded); } CharsetDecoder decoder = CharsetUtil.decoder(charset); int decodedCapacity = (toExcluded - firstEscaped) / 3; byte[] buf = PlatformDependent.allocateUninitializedArray(decodedCapacity); int bufIdx; StringBuilder strBuf = new StringBuilder(len); strBuf.append(s, from, firstEscaped); for (int i = firstEscaped; i < toExcluded; i++) { char c = s.charAt(i); if (c != '%') { strBuf.append(c != '+' || isPath? c : SPACE); continue; } bufIdx = 0; do { if (i + 3 > toExcluded) { throw new IllegalArgumentException("unterminated escape sequence at index " + i + " of: " + s); } buf[bufIdx++] = decodeHexByte(s, i + 1); i += 3; } while (i < toExcluded && s.charAt(i) == '%'); i--; strBuf.append(new String(buf, 0, bufIdx, charset)); } <START> return strBuf.toString(); <END> }</code><technical_language>decoder variable dropped now</technical_language>

Target:
private static String decodeComponent(String s, int from, int toExcluded, Charset charset, boolean isPath) { int len = toExcluded - from; if (len <= 0) { return EMPTY_STRING; } int firstEscaped = -1; for (int i = from; i < toExcluded; i++) { char c = s.charAt(i); if (c == '%' || c == '+' && !isPath) { firstEscaped = i; break; } } if (firstEscaped == -1) { return s.substring(from, toExcluded); } int decodedCapacity = (toExcluded - firstEscaped) / 3; byte[] buf = PlatformDependent.allocateUninitializedArray(decodedCapacity); int bufIdx; StringBuilder strBuf = new StringBuilder(len); strBuf.append(s, from, firstEscaped); for (int i = firstEscaped; i < toExcluded; i++) { char c = s.charAt(i); if (c != '%') { strBuf.append(c != '+' || isPath? c : SPACE); continue; } bufIdx = 0; do { if (i + 3 > toExcluded) { throw new IllegalArgumentException("unterminated escape sequence at index " + i + " of: " + s); } buf[bufIdx++] = decodeHexByte(s, i + 1); i += 3; } while (i < toExcluded && s.charAt(i) == '%'); i--; strBuf.append(new String(buf, 0, bufIdx, charset)); } return strBuf.toString(); }
Source:
<code>public void signalProcessInstancesCmdExecutorTest() { SignalProcessInstancesCmd signalProcessInstancesCmd = new SignalProcessInstancesCmd("x"); <START> assertThat(signalProcessInstancesCmdExecutor).isNotNull(); <END> assertThat(signalProcessInstancesCmdExecutor.getHandledType()).isEqualTo(SignalProcessInstancesCmd.class); signalProcessInstancesCmdExecutor.execute(signalProcessInstancesCmd); verify(processEngine).signal(signalProcessInstancesCmd); verify(commandResults).send(ArgumentMatchers.<Message<SignalProcessInstancesResults>>any()); }</code><technical_language>removed</technical_language>

Target:
public void signalProcessInstancesCmdExecutorTest() { SignalProcessInstancesCmd signalProcessInstancesCmd = new SignalProcessInstancesCmd("x"); assertThat(signalProcessInstancesCmdExecutor.getHandledType()).isEqualTo(SignalProcessInstancesCmd.class); signalProcessInstancesCmdExecutor.execute(signalProcessInstancesCmd); verify(processEngine).signal(signalProcessInstancesCmd); verify(commandResults).send(ArgumentMatchers.<Message<SignalProcessInstancesResults>>any()); }
Source:
<code>private static String getAddonDirectory(List<String> arguments) <START> { <END> int addDirectoryIndex = arguments.indexOf("--immutableAddonDir") + 1; return arguments.get(addDirectoryIndex); }</code><technical_language>asuming allways argument. Is case</technical_language>

Target:
private static String getAddonDirectory(List<String> arguments) { int index = arguments.indexOf("--immutableAddonDir"); if (index == -1) { return ""; } return arguments.get(++index); }
Source:
<code>public GetDiskAlignmentParameters(Guid diskId) { <START> setEntityId(diskId); <END> }</code><technical_language>entity id is generally for async tasks, suggest avoid it</technical_language>

Target:
public GetDiskAlignmentParameters(Guid diskId) { setDiskId(diskId); }
Source:
<code>public FtraceEvent(ITmfTrace trace, long rank, FtraceField field) { super(trace, rank, TmfTimestamp.fromNanos(field.getTs()), FtraceEventTypeFactory.get(field.getName()), field.getContent()); fField = field; fName = field.getName(); <START> fLogLevel = Level.INFO; <END> fCallsite = null; }</code><technical_language>Do need this</technical_language>

Target:
public FtraceEvent(ITmfTrace trace, long rank, FtraceField field) { super(trace, rank, TmfTimestamp.fromNanos(field.getTs()), FtraceEventTypeFactory.get(field.getName()), field.getContent()); fField = field; fName = field.getName(); fCallsite = null; }
Source:
<code>public ValidationResult validateCinderDiskLimits() { return validate(new Callable<ValidationResult>() { @Override public ValidationResult call() { for (CinderDisk disk : cinderDisks) { OpenStackVolumeProviderProxy proxy = diskProxyMap.get(disk.getId()); Limits limits = proxy.getLimits(); <START> if (limits.getAbsolute().getTotalVolumesUsed() >= limits.getAbsolute().getMaxTotalVolumes()) { <END> return new ValidationResult(VdcBllMessages.CANNOT_ADD_CINDER_DISK_VOLUME_LIMIT_EXCEEDED, String.format("$maxTotalVolumes %d", limits.getAbsolute().getMaxTotalVolumes()), String.format("$diskAlias %s", disk.getDiskAlias())); } } return ValidationResult.VALID; } }); }</code><technical_language>if add disks, need summarize other</technical_language>

Target:
public ValidationResult validateCinderDiskLimits() { return validate(new Callable<ValidationResult>() { @Override public ValidationResult call() { int diskIndex = 0; for (CinderDisk disk : cinderDisks) { OpenStackVolumeProviderProxy proxy = diskProxyMap.get(disk.getId()); Limits limits = proxy.getLimits(); if (limits.getAbsolute().getTotalVolumesUsed() + diskIndex >= limits.getAbsolute().getMaxTotalVolumes()) { return new ValidationResult(VdcBllMessages.CANNOT_ADD_CINDER_DISK_VOLUME_LIMIT_EXCEEDED, String.format("$maxTotalVolumes %d", limits.getAbsolute().getMaxTotalVolumes()), String.format("$diskAlias %s", disk.getDiskAlias())); } diskIndex++; } return ValidationResult.VALID; } }); }
Source:
<code>public void onCreateOptionsMenu(final Menu menu, final MenuInflater inflater) { if (DEBUG) { <START> Log.d(TAG, "onCreateOptionsMenu() called with: menu = [" + menu + "], inflater = [" + inflater + "]"); <END> } super.onCreateOptionsMenu(menu, inflater); inflater.inflate(R.menu.menu_local_playlist, menu); }</code><technical_language>personally prefer formatting like: suggestion Log.d(TAG, "onCreateOptionsMenu() called with: " + "menu = [" + menu + "], inflater = [" + inflater + "]");</technical_language>

Target:
public void onCreateOptionsMenu(final Menu menu, final MenuInflater inflater) { if (DEBUG) { Log.d(TAG, "onCreateOptionsMenu() called with: " + "menu = [" + menu + "], inflater = [" + inflater + "]"); } super.onCreateOptionsMenu(menu, inflater); inflater.inflate(R.menu.menu_local_playlist, menu); }
Source:
<code>public void setLaunchType(ServletRequest request, HttpSession session) { if ( BASIC_LTI_LAUNCH_REQUEST.equals(request.getParameter(LTI_MESSAGE_TYPE)) && session.getAttribute(LAUNCH_TYPE) == null) { session.setAttribute(LAUNCH_TYPE, "lti"); } <START> else if (session.getAttribute(LAUNCH_TYPE) == null){ <END> session.setAttribute(LAUNCH_TYPE, "sc"); } }</code><technical_language>this else? work fine if is nested</technical_language>

Target:
public void setLaunchType(ServletRequest request, HttpSession session) { if ( BASIC_LTI_LAUNCH_REQUEST.equals(request.getParameter(LTI_MESSAGE_TYPE)) && session.getAttribute(LAUNCH_TYPE) == null) { session.setAttribute(LAUNCH_TYPE, "lti"); } if (session.getAttribute(LAUNCH_TYPE) == null){ session.setAttribute(LAUNCH_TYPE, "sc"); } }
Source:
<code><START> public AnalyzedStatement analyze(DropView dropView, CoordinatorTxnCtx txnCtx) { <END> ArrayList<RelationName> views = new ArrayList<>(dropView.names().size()); ArrayList<RelationName> missing = new ArrayList<>(); for (QualifiedName qualifiedName : dropView.names()) { try { views.add(schemas.resolveView(qualifiedName, txnCtx.sessionContext().searchPath()).v2()); } catch (RelationUnknown e) { if (!dropView.ifExists()) { missing.add(RelationName.of(qualifiedName, txnCtx.sessionContext().searchPath().currentSchema())); } } } if (!missing.isEmpty()) { throw new RelationsUnknown(missing); } return new AnalyzedDropView(views, dropView.ifExists()); }</code><technical_language>suggestion public AnalyzedDropView analyze(DropView dropView, CoordinatorTxnCtx txnCtx) {</technical_language>

Target:
public AnalyzedDropView analyze(DropView dropView, CoordinatorTxnCtx txnCtx) { ArrayList<RelationName> views = new ArrayList<>(dropView.names().size()); ArrayList<RelationName> missing = new ArrayList<>(); for (QualifiedName qualifiedName : dropView.names()) { try { views.add(schemas.resolveView(qualifiedName, txnCtx.sessionContext().searchPath()).v2()); } catch (RelationUnknown e) { if (!dropView.ifExists()) { missing.add(RelationName.of(qualifiedName, txnCtx.sessionContext().searchPath().currentSchema())); } } } if (!missing.isEmpty()) { throw new RelationsUnknown(missing); } return new AnalyzedDropView(views, dropView.ifExists()); }
Source:
<code>public List<String> getDependencies() { List<String> dependencies = new ArrayList<>(); dependencies.add(A_G_unixGID_namespace + ":*"); <START> dependencies.add(A_R_unixGID_namespace + ":*"); <END> return dependencies; }</code><technical_language>Similar urn_perun_group_attribute_def_def_unixGID_namespace.java output like: //Disallowed of crosschecks modules peformance reason //dependencies.add(A_G_unixGID_namespace + ":*"); //dependencies.add(A_R_unixGID_namespace + ":*"); //dependencies.add(A_R_unixGroupName_namespace + ":*");</technical_language>

Target:
public List<String> getDependencies() { List<String> dependencies = new ArrayList<>(); return dependencies; }