auphong2707/dl4se-code-review-dataset huggingface dataset:
Source:
<code>public final HSQuery targetedTypes(List<CustomTypeMetadata> types) { if ( types == null ) { return targetedEntities( null ); } List<IndexedTypeIdentifier> entityTypes = types.stream() <START> .map( CustomTypeMetadata::getEntityType ).collect( toList() ); <END> IndexedTypesSet typesSet = IndexedTypesSets.fromIdentifiers( entityTypes ); setTargetedEntities( typesSet ); this.customTypeMetadata = new ArrayList<>( types ); return this; }</code><technical_language>worth it, simply create a Stream pass this stream a new IndexedTypeSets.fromIdentifiers(Stream<IndexedTypeIdentifier>) method, a Set collector directly. avoid a List instantiation. Alternatively, create Collector<IndexedTypeIdentifier, ?, IndexedTypeSets> (wrapping a Collectors.toSet), more complex</technical_language>

Target:
public final HSQuery targetedTypes(List<CustomTypeMetadata> types) { if ( types == null ) { return targetedEntities( null ); } IndexedTypeSet typesSet = types.stream() .map( CustomTypeMetadata::getEntityType ) .collect( IndexedTypesSets.streamCollector() ); setTargetedEntities( typesSet ); this.customTypeMetadata = new ArrayList<>( types ); return this; }
Source:
<code>public void editProblemDescription(String newDescription) { driver.findElement(PROBLEM_DESCRIPTION).click(); driver.findElement(EDIT_PROBLEM_DESCRIPTION).clear(); driver.findElement(EDIT_PROBLEM_DESCRIPTION).sendKeys(newDescription); clickAtVisibleMapCenter(0); <START> System.out.println("ddddddddddddddddddddddddddddddddddddd"); <END> }</code><technical_language>please delete :)</technical_language>

Target:
public void editProblemDescription(String newDescription) { driver.findElement(PROBLEM_DESCRIPTION).click(); driver.findElement(EDIT_PROBLEM_DESCRIPTION).clear(); driver.findElement(EDIT_PROBLEM_DESCRIPTION).sendKeys(newDescription); clickAtVisibleMapCenter(0); }
Source:
<code>private static void save(String table, Person person, SQLiteDatabase database) { ContentValues values = new ContentValues(); values.put("person_id", person.getPersonID()); values.put("local_blog_id", person.getLocalTableBlogId()); values.put("display_name", person.getDisplayName()); values.put("avatar_url", person.getAvatarUrl()); switch (table) { case TEAM_TABLE: values.put("user_name", person.getUsername()); <START> values.put("role", person.getRole().toString()); <END> break; case FOLLOWERS_TABLE: values.put("user_name", person.getUsername()); values.put("subscribed", person.getSubscribed()); break; case EMAIL_FOLLOWERS_TABLE: values.put("subscribed", person.getSubscribed()); break; case VIEWERS_TABLE: values.put("user_name", person.getUsername()); break; } database.insertWithOnConflict(table, null, values, SQLiteDatabase.CONFLICT_REPLACE); }</code><technical_language>I need getRole() null here, a NPE</technical_language>

Target:
private static void save(String table, Person person, SQLiteDatabase database) { ContentValues values = new ContentValues(); values.put("person_id", person.getPersonID()); values.put("local_blog_id", person.getLocalTableBlogId()); values.put("display_name", person.getDisplayName()); values.put("avatar_url", person.getAvatarUrl()); switch (table) { case TEAM_TABLE: values.put("user_name", person.getUsername()); if (person.getRole() != null) { values.put("role", person.getRole().toString()); } break; case FOLLOWERS_TABLE: values.put("user_name", person.getUsername()); values.put("subscribed", person.getSubscribed()); break; case EMAIL_FOLLOWERS_TABLE: values.put("subscribed", person.getSubscribed()); break; case VIEWERS_TABLE: values.put("user_name", person.getUsername()); break; } database.insertWithOnConflict(table, null, values, SQLiteDatabase.CONFLICT_REPLACE); }
Source:
<code>public Viewer createViewer(final Composite parent, CompareConfiguration config) { return new Viewer() { @Override public void setSelection(ISelection selection, boolean reveal) { } @Override public void setInput(Object input) { } @Override public void refresh() { } @Override public ISelection getSelection() { return StructuredSelection.EMPTY; } @Override public Object getInput() { return null; } @Override public Control getControl() { Composite control = new Composite(parent, SWT.NONE); GridLayout layout = new GridLayout(1, true); control.setLayout(layout); Label label = new Label(control, SWT.NONE); <START> label.setText(EMFCompareIDEUIMessages.getString("wait.viewer.desc")); <END> label.setFont(JFaceResources.getBannerFont()); label.setLayoutData(new GridData(SWT.CENTER, SWT.CENTER, true, true)); control.setData(CompareUI.COMPARE_VIEWER_TITLE, EMFCompareIDEUIMessages .getString("wait.viewer.title")); return control; } }; }</code><technical_language>add NON-NLS</technical_language>

Target:
public Viewer createViewer(final Composite parent, CompareConfiguration config) { return new WaitViewer(parent); }
Source:
<code>public void importManifest( @PathParam("owner_key") @Verify(Owner.class) String ownerKey, @QueryParam("force") String[] overrideConflicts, MultipartInput input) { ConflictOverrides overrides = createConflictOverrides(overrideConflicts); Owner owner = findOwner(ownerKey); Map<String, Object> data = new HashMap<String, Object>(); String filename = ""; try { InputPart part = input.getParts().get(0); filename = extractFileNameFromHeaders(part); File archive = part.getBody(new GenericType<File>() {}); <START> log.info("Importing archive " + archive.getAbsolutePath() + <END> " for owner " + owner.getDisplayName()); data = importer.loadExport(owner, archive, overrides); sink.emitImportCreated(owner); recordImportSuccess(owner, data, overrides, filename); } catch (IOException e) { recordImportFailure(owner, data, e, filename); throw new IseException(i18n.tr("Error reading export archive"), e); } catch (SyncDataFormatException e) { recordImportFailure(owner, data, e, filename); throw new BadRequestException(e.getMessage(), e); } catch (ImporterException e) { recordImportFailure(owner, data, e, filename); throw new IseException(e.getMessage(), e); } catch (CandlepinException e) { recordImportFailure(owner, data, e, filename); throw e; } finally { log.info("Import attempt completed for owner " + owner.getDisplayName()); } }</code><technical_language>a pretty significant refactor of this area, fix log lines substitution instead of concatenation? log.info("Importing archive: {}", archive.getAbsolutePath());</technical_language>

Target:
public void importManifest( @PathParam("owner_key") @Verify(Owner.class) String ownerKey, @QueryParam("force") String[] overrideConflicts, MultipartInput input) { ConflictOverrides overrides = createConflictOverrides(overrideConflicts); Owner owner = findOwner(ownerKey); Map<String, Object> data = new HashMap<String, Object>(); String filename = ""; try { InputPart part = input.getParts().get(0); filename = extractFileNameFromHeaders(part); File archive = part.getBody(new GenericType<File>() {}); log.info("Importing archive for owner {}", archive.getAbsolutePath(), owner.getDisplayName()); data = importer.loadExport(owner, archive, overrides); sink.emitImportCreated(owner); recordImportSuccess(owner, data, overrides, filename); } catch (IOException e) { recordImportFailure(owner, data, e, filename); throw new IseException(i18n.tr("Error reading export archive"), e); } catch (SyncDataFormatException e) { recordImportFailure(owner, data, e, filename); throw new BadRequestException(e.getMessage(), e); } catch (ImporterException e) { recordImportFailure(owner, data, e, filename); throw new IseException(e.getMessage(), e); } catch (CandlepinException e) { recordImportFailure(owner, data, e, filename); throw e; } finally { log.info("Import attempt completed for owner {}", owner.getDisplayName()); } }
Source:
<code>static boolean handleIMEIDisplay(Context context, String input, boolean useSystemWindow) { if (input.equals(MMI_IMEI_DISPLAY)) { int networkType = ((TelephonyManager)context.getSystemService( Context.TELEPHONY_SERVICE)).getNetworkType(); if (networkType == TelephonyManager.NETWORK_TYPE_CDMA) { showNotSupportedPanel(context, useSystemWindow); return false; <START> } <END> else { showIMEIPanel(context, useSystemWindow); return true; } } return false; }</code><technical_language>} else { line</technical_language>

Target:
static boolean handleIMEIDisplay(Context context, String input, boolean useSystemWindow) { if (input.equals(MMI_IMEI_DISPLAY)) { int networkType = ((TelephonyManager)context.getSystemService( Context.TELEPHONY_SERVICE)).getNetworkType(); if(networkType == TelephonyManager.NETWORK_TYPE_GPRS || networkType == TelephonyManager.NETWORK_TYPE_EDGE || networkType == TelephonyManager.NETWORK_TYPE_UMTS ) { showIMEIPanel(context, useSystemWindow); return true; } } return false; }
Source:
<code><START> private PyExpressionTree getExpression(PyExpressionTree expr) { <END> if (expr.is(Tree.Kind.MODULO) || expr.is(Tree.Kind.PLUS)) { return getExpression(((PyBinaryExpressionTree) expr).leftOperand()); } return expr; }</code><technical_language>a small SonarQube this method static :)</technical_language>

Target:
private static PyExpressionTree getExpression(PyExpressionTree expr) { if (expr.is(Tree.Kind.MODULO) || expr.is(Tree.Kind.PLUS)) { return getExpression(((PyBinaryExpressionTree) expr).leftOperand()); } return expr; }
Source:
<code>public void testQueryElementNoFollowingSibling() throws Exception { final String xpath = " final RootNode rootNode = getRootNode("InputXpathMapperAst.java"); <START> final DetailAST[] actual = convertToArray(getXpathItems(xpath, rootNode)); <END> assertEquals("Invalid number of nodes", 0, actual.length); }</code><technical_language>personal, some time verify this, expectedMethodDefNode.getNextSibling() is abstract. human verify this test, execution of deep dive in Input AST structure. sense extend test assertThat("...", RCURLY, expectedMethodDefNode.getNextSibling().getType()); users is expected. , flollowing assertArrayEquals do this, extra assert test expected result verified human. this is blocker for merge, some other reviewer experience issue, is do it</technical_language>

Target:
public void testQueryElementNoFollowingSibling() throws Exception { final String xpath = " final RootNode rootNode = getRootNode("InputXpathMapperAst.java"); final DetailAST[] actual = convertToArray(getXpathItems(xpath, rootNode)); assertThat("Invalid number of nodes", actual.length, equalTo(0)); }
Source:
<code>public void setUnmanagedDeviceList(List<VmDevice> list) { <START> mVmStatic.setUnmanagedDeviceList(list); <END> }</code><technical_language>here, access vmStatic null safe</technical_language>

Target:
public void setUnmanagedDeviceList(List<VmDevice> list) { if (mVmStatic == null) { mVmStatic = new VmStatic(); } mVmStatic.setUnmanagedDeviceList(list); }
Source:
<code>public BigInteger computeHash() { final Funnel<StructNode> nodeFunnel = (StructNode node, PrimitiveSink into) -> { <START> if(lastChild != -2L) { <END> into.putLong(node.getChildCount()).putLong(node.getDescendantCount()).putLong(node.getLeftSiblingKey()).putLong( node.getRightSiblingKey()).putLong(node.getFirstChildKey()); } else { into.putLong(node.getChildCount()).putLong(node.getDescendantCount()).putLong(node.getLeftSiblingKey()).putLong( node.getRightSiblingKey()).putLong(node.getFirstChildKey()).putLong(node.getLastChildKey()); } }; final BigInteger hash = new BigInteger(1, nodeDelegate.getHashFunction().hashObject(this, nodeFunnel).asBytes()); return Node.to128BitsAtMaximumBigInteger(hash); }</code><technical_language>above. a constant</technical_language>

Target:
public BigInteger computeHash() { final Funnel<StructNode> nodeFunnel = (StructNode node, PrimitiveSink into) -> { if(lastChild != Fixed.INVALID_KEY_FOR_TYPE_CHECK.getStandardProperty()) { into.putLong(node.getChildCount()).putLong(node.getDescendantCount()).putLong(node.getLeftSiblingKey()).putLong( node.getRightSiblingKey()).putLong(node.getFirstChildKey()); } else { into.putLong(node.getChildCount()).putLong(node.getDescendantCount()).putLong(node.getLeftSiblingKey()).putLong( node.getRightSiblingKey()).putLong(node.getFirstChildKey()).putLong(node.getLastChildKey()); } }; final BigInteger hash = new BigInteger(1, nodeDelegate.getHashFunction().hashObject(this, nodeFunnel).asBytes()); return Node.to128BitsAtMaximumBigInteger(hash); }
Source:
<code>public void removeMemberWaitsForStartManager() throws Exception { CountDownLatch latch = new CountDownLatch(1); CyclicBarrier barrier = new CyclicBarrier(2); ExecutorService executorService = mock(ExecutorService.class); List<Future<InternalDistributedMember>> futureTaskList = Collections.emptyList(); when(executorService.invokeAll(any())).thenAnswer(invocation -> { awaitCyclicBarrier(barrier); awaitCountDownLatch(latch); return futureTaskList; }); FederatingManager federatingManager = <START> spy(new FederatingManager(repo, system, service, cache, statisticsFactory, statisticsClock, <END> proxyFactory, messenger, cancelCriterion, executorService)); executorServiceRule.submit(() -> { federatingManager.startManager(); }); executorServiceRule.submit(() -> { awaitCyclicBarrier(barrier); federatingManager.removeMember(member(), true); }); await().untilAsserted(() -> { assertThat(federatingManager.pendingTasks()).hasSize(1); }); latch.countDown(); await().untilAsserted(() -> { assertThat(federatingManager.pendingTasks()).isEmpty(); }); }</code><technical_language>this need a spy? I of spyness (spyity?) in this test</technical_language>

Target:
public void removeMemberWaitsForStartManager() throws Exception { CountDownLatch latch = new CountDownLatch(1); CyclicBarrier barrier = new CyclicBarrier(2); ExecutorService executorService = mock(ExecutorService.class); List<Future<InternalDistributedMember>> futureTaskList = Collections.emptyList(); when(executorService.invokeAll(any())).thenAnswer(invocation -> { awaitCyclicBarrier(barrier); awaitCountDownLatch(latch); return futureTaskList; }); FederatingManager federatingManager = new FederatingManager(repo, system, service, cache, statisticsFactory, statisticsClock, proxyFactory, messenger, cancelCriterion, executorService); executorServiceRule.submit(() -> { federatingManager.startManager(); }); executorServiceRule.submit(() -> { awaitCyclicBarrier(barrier); federatingManager.removeMember(member(), true); }); await().untilAsserted(() -> { assertThat(federatingManager.pendingTasks()).hasSize(1); }); latch.countDown(); await().untilAsserted(() -> { assertThat(federatingManager.pendingTasks()).isEmpty(); }); }
Source:
<code>public void renderText(float renderCoordX, float renderCoordY) { <START> for (int i = 0; i < text.length; i++) { <END> typeFont.drawString(renderCoordX, renderCoordY + i * 50, text[i], controller.decideColor(severities[i])); } }</code><technical_language>This method private</technical_language>

Target:
private void renderText(float renderCoordX, float renderCoordY) { for (int i = 0; i < text.length; i++) { typeFont.drawString(renderCoordX, renderCoordY + i * 50, text[i], controller.decideColor(severities[i])); } }
Source:
<code>private HttpUriRequest toApacheRequest(final HttpRequest httpRequest) throws UnsupportedEncodingException { final String method = httpRequest.getHttpMethod().toString(); final String uri = httpRequest.getUrl(); final RequestBuilder builder = RequestBuilder .create(method) .setUri(uri); httpRequest.getHeaders().getHeadersAsMap().forEach((name, values) -> values.forEach(value -> builder.addHeader(name, value))); if (httpRequest.getBody() != null) { final HttpRequestBody body = httpRequest.getBody(); final HttpEntity httpEntity; if (body instanceof StringHttpRequestBody) { <START> StringEntity stringEntity = new StringEntity(((StringHttpRequestBody) body).getString(),"UTF-8"); <END> stringEntity.setContentType(ContentType.APPLICATION_JSON.toString()); httpEntity = stringEntity; } else if (body instanceof FileHttpRequestBody) { httpEntity = new FileEntity(((FileHttpRequestBody)body).getFile()); } else if (body instanceof FormUrlEncodedHttpRequestBody) { httpEntity = urlEncodedOf((FormUrlEncodedHttpRequestBody) body); } else { throw new HttpException("Cannot interpret request " + httpRequest); } builder.setEntity(httpEntity); } return builder.build(); }</code><technical_language>this vraible final. instead of UTF-8 java.nio.charset.StandardCharsets.UTF_8.name()</technical_language>

Target:
private HttpUriRequest toApacheRequest(final HttpRequest httpRequest) throws UnsupportedEncodingException { final String method = httpRequest.getHttpMethod().toString(); final String uri = httpRequest.getUrl(); final RequestBuilder builder = RequestBuilder .create(method) .setUri(uri); httpRequest.getHeaders().getHeadersAsMap().forEach((name, values) -> values.forEach(value -> builder.addHeader(name, value))); if (httpRequest.getBody() != null) { final HttpRequestBody body = httpRequest.getBody(); final HttpEntity httpEntity; if (body instanceof StringHttpRequestBody) { final StringEntity stringEntity = new StringEntity(((StringHttpRequestBody) body).getString(), StandardCharsets.UTF_8); stringEntity.setContentType(ContentType.APPLICATION_JSON.toString()); httpEntity = stringEntity; } else if (body instanceof FileHttpRequestBody) { httpEntity = new FileEntity(((FileHttpRequestBody)body).getFile()); } else if (body instanceof FormUrlEncodedHttpRequestBody) { httpEntity = urlEncodedOf((FormUrlEncodedHttpRequestBody) body); } else { throw new HttpException("Cannot interpret request " + httpRequest); } builder.setEntity(httpEntity); } return builder.build(); }
Source:
<code>public CDPStructuredFlowEvent createStructuredFlowEvent(Long resourceId, FlowDetails flowDetails, Boolean detailed) { <START> Optional<Environment> environmentOptional = environmentService.findEnvironmentById(resourceId); Environment environment = environmentOptional.orElseThrow(notFound("Environment", resourceId)); <END> String resourceType = CDPStructuredFlowEvent.class.getSimpleName(); CDPOperationDetails operationDetails = new CDPOperationDetails(clock.getCurrentTimeMillis(), FLOW, resourceType, environment.getId(), environment.getName(), nodeConfig.getId(), serviceVersion, environment.getAccountId(), environment.getResourceCrn(), environment.getCreator(), environment.getResourceCrn(), null); return new CDPStructuredFlowEvent(resourceType, operationDetails, flowDetails, null); }</code><technical_language>I prefer if add getEnvironmentById method EnvironmentService throw exception I this kind of usage a lot in code generally</technical_language>

Target:
public CDPStructuredFlowEvent createStructuredFlowEvent(Long resourceId, FlowDetails flowDetails, Boolean detailed) { return createStructuredFlowEvent(resourceId, flowDetails, detailed, null); }
Source:
<code>private void deleteExistingLinkLocalRouteTable(String linkLocalBr) { Script command = new Script("/bin/bash", _timeout); command.add("-c"); command.add("ip route | grep " + _controlCidr); OutputInterpreter.AllLinesParser parser = new OutputInterpreter.AllLinesParser(); String result = command.execute(parser); boolean foundLinkLocalBr = false; if (result == null && parser.getLines() != null) { String[] lines = parser.getLines().split("\\n"); for (String line : lines) { String[] tokens = line.split(" "); if (tokens != null && tokens.length < 2) { continue; } final String device = tokens[2]; if (!Strings.isNullOrEmpty(device) && !device.equalsIgnoreCase(linkLocalBr)) { Script.runSimpleBashScript("ip route del " + _controlCidr + " dev " + tokens[2]); } else { foundLinkLocalBr = true; } } } if (!foundLinkLocalBr) { Script.runSimpleBashScript("ip address add " + NetUtils.getLinkLocalAddressFromCIDR(_controlCidr) + " dev " + linkLocalBr); <START> Script.runSimpleBashScript("ip route add " + _controlCidr + " dev " + linkLocalBr + " src " + NetUtils.getLinkLocalFirstAddressFromCIDR(_controlCidr)); <END> } }</code><technical_language>keeping NetUtils.getLinkLocalGateway() extending accept a CIDR parameter? internally invokes getLinkLocalFirstAddressFromCIDR</technical_language>

Target:
private void deleteExistingLinkLocalRouteTable(String linkLocalBr) { Script command = new Script("/bin/bash", _timeout); command.add("-c"); command.add("ip route | grep " + _controlCidr); OutputInterpreter.AllLinesParser parser = new OutputInterpreter.AllLinesParser(); String result = command.execute(parser); boolean foundLinkLocalBr = false; if (result == null && parser.getLines() != null) { String[] lines = parser.getLines().split("\\n"); for (String line : lines) { String[] tokens = line.split(" "); if (tokens != null && tokens.length < 2) { continue; } final String device = tokens[2]; if (!Strings.isNullOrEmpty(device) && !device.equalsIgnoreCase(linkLocalBr)) { Script.runSimpleBashScript("ip route del " + _controlCidr + " dev " + tokens[2]); } else { foundLinkLocalBr = true; } } } if (!foundLinkLocalBr) { Script.runSimpleBashScript("ip address add " + NetUtils.getLinkLocalAddressFromCIDR(_controlCidr) + " dev " + linkLocalBr); Script.runSimpleBashScript("ip route add " + _controlCidr + " dev " + linkLocalBr + " src " + NetUtils.getLinkLocalGateway(_controlCidr)); } }
Source:
<code>public Optional<Response> handleWithObaData(final ObaUserDataItem obaUserDataItem, final ObaUserClient obaUserClient) { try { final ObaStopResponse stop = obaUserClient.getStopDetails(obaUserDataItem.getStopId()); final String stopName = replaceSpecialCharactersFromAddress(stop.getName()); <START> final String speech = <END> promptHelper.getPrompt(GET_STOP, Integer.toString(stop.getCode()), String.format(ADDRESS_SSML_FORMAT, stopName)); StorageUtil.saveOutputForRepeat(speech, obaDao, obaUserDataItem); return promptHelper.getResponse(speech); } catch (IOException e) { log.error(e); throw new OneBusAwayException(promptHelper.getPrompt(COMMUNICATION_ERROR_MESSAGE)); } }</code><technical_language>Integer.toString(stop.getCode()) stop.getStopCode() (it's a string). reading HTTP 200 code response user stop ID. :)</technical_language>

Target:
public Optional<Response> handleWithObaData(final ObaUserDataItem obaUserDataItem, final ObaUserClient obaUserClient) { try { final ObaStopResponse stop = obaUserClient.getStopDetails(obaUserDataItem.getStopId()); final String stopName = replaceSpecialCharactersFromAddress(stop.getName()); final String speech = promptHelper.getPrompt(GET_STOP, stop.getStopCode(), String.format(ADDRESS_SSML_FORMAT, stopName)); StorageUtil.saveOutputForRepeat(speech, obaDao, obaUserDataItem); return promptHelper.getResponse(speech); } catch (IOException e) { log.error(e); throw new OneBusAwayException(promptHelper.getPrompt(COMMUNICATION_ERROR_MESSAGE)); } }
Source:
<code>public void endSpanAmqpException() { final Tracer tracer1 = mock(Tracer.class); List<Tracer> tracers = Arrays.asList(tracer1); final TracerProvider tracerProvider = new TracerProvider(tracers); <START> final Exception exception = new AmqpException(true, ErrorCondition.NOT_FOUND, "", null); <END> Context sendContext = new Context(OPENTELEMETRY_SPAN_KEY, "value"); tracerProvider.endSpan(sendContext, Signal.error(exception)); verify(tracer1, times(1)).end("amqp:not-found", exception, sendContext); }</code><technical_language>In verify, explicitly type out "ampq:not-found". if decide change this amqp error condition string in future, break this test. do like: java final ErrorCondition condition = ErrorCondition.NOT_FOUND; final Exception exception = new AmqpException(true, condition, "", null); // Act ... // Assert verify(tracer1, times(1)).end(condition.getErrorCondition(), exception, sendContext);</technical_language>

Target:
public void endSpanAmqpException() { final ErrorCondition errorCondition = ErrorCondition.NOT_FOUND; final Exception exception = new AmqpException(true, errorCondition, "", null); Context sendContext = new Context(OPENTELEMETRY_SPAN_KEY, "value"); tracerProvider.endSpan(sendContext, Signal.error(exception)); for (Tracer t : tracers) { verify(t, times(1)) .end(errorCondition.getErrorCondition(), exception, sendContext); } }
Source:
<code>public List<String> getStudentsWhoResponded() { <START> studentsWhoResponded.sort(compareByTeamNameStudentName); <END> return studentsWhoResponded; }</code><technical_language>Similar - revert changes add a new method getStudentsWhoRespondedSorted, need sorted list</technical_language>

Target:
public List<String> getStudentsWhoResponded() { return studentsWhoResponded; }
Source:
<code>private IgniteBiTuple<Integer, IgniteBiTuple<Integer, Double>> findBestSplitIndexForFeatures(int featuresCnt, IgniteBiFunction<Integer, Ignite, Object> affinity, UUID trainingUUID) { Set<Integer> featureIndexes = IntStream.range(0, featuresCnt).boxed().collect(Collectors.toSet()); return CacheUtils.reduce(COLUMN_DECISION_TREE_TRAINER_SPLIT_CACHE_NAME, ignite, <START> (Object ctx, Cache.Entry<SplitKey, IgniteBiTuple<Integer, Double>> e, IgniteBiTuple<Integer, IgniteBiTuple<Integer, Double>> r) -> <END> Functions.MAX_GENERIC(new IgniteBiTuple<>(e.getKey().featureIdx(), e.getValue()), r, comparator()), () -> null, () -> SplitCache.localEntries(featureIndexes, affinity, trainingUUID), (i1, i2) -> Functions.MAX_GENERIC(i1, i2, Comparator.comparingDouble(bt -> bt.get2().get2())), () -> new IgniteBiTuple<>(-1, new IgniteBiTuple<>(-1, Double.NEGATIVE_INFINITY)) ); }</code><technical_language>a previous</technical_language>

Target:
private IgniteBiTuple<Integer, IgniteBiTuple<Integer, Double>> findBestSplitIndexForFeatures(int featuresCnt, IgniteBiFunction<Integer, Ignite, Object> affinity, UUID trainingUUID) { Set<Integer> featureIndexes = IntStream.range(0, featuresCnt).boxed().collect(Collectors.toSet()); return CacheUtils.reduce(SplitCache.CACHE_NAME, ignite, (Object ctx, Cache.Entry<SplitKey, IgniteBiTuple<Integer, Double>> e, IgniteBiTuple<Integer, IgniteBiTuple<Integer, Double>> r) -> Functions.MAX_GENERIC(new IgniteBiTuple<>(e.getKey().featureIdx(), e.getValue()), r, comparator()), () -> null, () -> SplitCache.localEntries(featureIndexes, affinity, trainingUUID), (i1, i2) -> Functions.MAX_GENERIC(i1, i2, Comparator.comparingDouble(bt -> bt.get2().get2())), () -> new IgniteBiTuple<>(-1, new IgniteBiTuple<>(-1, Double.NEGATIVE_INFINITY)) ); }
Source:
<code>public Object addInheritableProperty(String key, Object value) { if (getNonInheritableProperties().containsKey(key)) { <START> final Object oldValue = getNonInheritableProperties().get(key); <END> getNonInheritableProperties().removeKey(key); getInheritableProperties().put(key, value); return oldValue; } return getInheritableProperties().put(key, value); }</code><technical_language>removeKey returns need fetch</technical_language>

Target:
public Object addInheritableProperty(String key, Object value) { if (getNonInheritableProperties().containsKey(key)) { final Object oldValue = getNonInheritableProperties().removeKey(key); getInheritableProperties().put(key, value); return oldValue; } return getInheritableProperties().put(key, value); }
Source:
<code>protected void addMutations(Element element, Mutation... mutations) { <START> _addMutations(getWriterFromElementType(element), mutations); <END> if (isHistoryInSeparateTable()) { _addMutations(getHistoryWriterFromElementType(element), mutations); } }</code><technical_language>Body of this method replaced with: addMutations(ElementType.getTypeFromElement(element), mutations);</technical_language>

Target:
protected void addMutations(Element element, Mutation... mutations) { addMutations(ElementType.getTypeFromElement(element), mutations); }
Source:
<code>public void create() { try { serviceLoader.load(PmHealthCheckManager.class); serviceLoader.load(EngineBackupAwarenessManager.class); serviceLoader.load(DataCenterCompatibilityChecker.class); serviceLoader.load(ResourceManager.class); serviceLoader.load(HostDeviceManager.class); serviceLoader.load(IrsProxyManager.class); serviceLoader.load(OvfDataUpdater.class); StoragePoolStatusHandler.init(); serviceLoader.load(GlusterJobsManager.class); resourceManager.get().scheduleJobsForHosts(); try { log.info("Init VM custom properties utilities"); VmPropertiesUtils.getInstance().init(); } catch (InitializationException e) { log.error("Initialization of vm custom properties failed.", e); } try { log.info("Init device custom properties utilities"); DevicePropertiesUtils.getInstance().init(); } catch (InitializationException e) { log.error("Initialization of device custom properties failed.", e); } serviceLoader.load(SchedulingManager.class); sessionDataContainer.cleanupEngineSessionsOnStartup(); <START> serviceLoader.load(HostDeviceManager.class); <END> serviceLoader.load(DwhHeartBeat.class); if(Config.<Boolean> getValue(ConfigValues.AffinityRulesEnforcementManagerEnabled)) { serviceLoader.load(AffinityRulesEnforcementManager.class); } serviceLoader.load(CertificationValidityChecker.class); serviceLoader.load(HostUpdatesCheckerService.class); serviceLoader.load(IPTablesDeprecationNotifier.class); } catch (Exception ex) { log.error("Failed to initialize backend", ex); throw ex; } }</code><technical_language>this line added - this initialization is done in line 67 needs removed</technical_language>

Target:
public void create() { try { serviceLoader.load(PmHealthCheckManager.class); serviceLoader.load(EngineBackupAwarenessManager.class); serviceLoader.load(DataCenterCompatibilityChecker.class); serviceLoader.load(ResourceManager.class); serviceLoader.load(HostDeviceManager.class); serviceLoader.load(IrsProxyManager.class); serviceLoader.load(OvfDataUpdater.class); StoragePoolStatusHandler.init(); serviceLoader.load(GlusterJobsManager.class); resourceManager.get().scheduleJobsForHosts(); try { log.info("Init VM custom properties utilities"); VmPropertiesUtils.getInstance().init(); } catch (InitializationException e) { log.error("Initialization of vm custom properties failed.", e); } try { log.info("Init device custom properties utilities"); DevicePropertiesUtils.getInstance().init(); } catch (InitializationException e) { log.error("Initialization of device custom properties failed.", e); } serviceLoader.load(SchedulingManager.class); sessionDataContainer.cleanupEngineSessionsOnStartup(); serviceLoader.load(DwhHeartBeat.class); if(Config.<Boolean> getValue(ConfigValues.AffinityRulesEnforcementManagerEnabled)) { serviceLoader.load(AffinityRulesEnforcementManager.class); } serviceLoader.load(CertificationValidityChecker.class); serviceLoader.load(HostUpdatesCheckerService.class); serviceLoader.load(IPTablesDeprecationNotifier.class); } catch (Exception ex) { log.error("Failed to initialize backend", ex); throw ex; } }
Source:
<code>public LauncherSettingsValidator() { <START> validationRules = new ArrayList<>(); <END> setupRules(); }</code><technical_language>do ... java validationRules = setupRules();</technical_language>

Target:
private LauncherSettingsValidator() { }
Source:
<code>public void savePluginSettings(String pluginId, String settingsAsJson) { DefaultGoPluginApiRequest request = new DefaultGoPluginApiRequest("", "", "save-settings"); request.setRequestBody(settingsAsJson); <START> GoPluginApiResponse response = submitTo(pluginId, request); <END> if (SUCCESS_RESPONSE_CODE != response.responseCode()) { throw new RuntimeException(format("Error while saving settings for plugin %s. [%s]", pluginId, response.responseBody())); } }</code><technical_language>here, is a possibility of exception</technical_language>

Target:
public void savePluginSettings(String pluginId, String settingsAsJson) { DefaultGoPluginApiRequest request = new DefaultGoPluginApiRequest("", "", "save-settings"); request.setRequestBody(settingsAsJson); GoPluginApiResponse response; try { response = submitTo(pluginId, request); } catch (Exception e) { LOGGER.warn(format("Could not save settings for Plugin %s. %s", pluginId, e.getMessage()), e); throw new RuntimeException(format("Could not save settings for Plugin %s. %s", pluginId, e.getMessage())); } if (SUCCESS_RESPONSE_CODE != response.responseCode()) { throw new RuntimeException(format("Error while saving settings for plugin %s. [%s]", pluginId, response.responseBody())); } }
Source:
<code>public JLoadScenario jaasSmokeTest() { <START> return new JaasSmokeTest().getHttpScenarios(); <END> }</code><technical_language>getHttpScenarios plural? returning single scenario</technical_language>

Target:
public JLoadScenario jaasSmokeTest() { return new JaasSmokeTest().getHttpScenario(); }
Source:
<code>public BrooklynMemento loadMemento(LookupContext lookupContext) { try { Stopwatch stopwatch = Stopwatch.createStarted(); List<String> lines; synchronized (mutex) { lines = Files.readLines(file, Charsets.UTF_8); } String xml = Joiner.on("\n").join(lines); serializer.setLookupContext(lookupContext); try { <START> BrooklynMemento result = serializer.fromString(xml); <END> if (LOG.isDebugEnabled()) LOG.debug("Loaded memento; took {}", Time.makeTimeStringRounded(stopwatch.elapsed(TimeUnit.MILLISECONDS))); return result; } finally { serializer.unsetLookupContext(); } } catch (IOException e) { throw Throwables.propagate(e); } }</code><technical_language>move some of this a private method (note change Files#asCharSource read()) called synchronised block. private BrooklynMemento readMemento() { try { return serializer.fromString(Files.asCharSource(file, Charsets.UTF_8).read()); } catch (IOException e) { LOG.error("Failed persist memento", e); throw Exceptions.propagate(e); } } synchronised block assume scope current try/catch is longer needed</technical_language>

Target:
public BrooklynMemento loadMemento(LookupContext lookupContext) { Stopwatch stopwatch = Stopwatch.createStarted(); String xml = readFile(); serializer.setLookupContext(lookupContext); try { BrooklynMemento result = serializer.fromString(xml); if (LOG.isDebugEnabled()) LOG.debug("Loaded memento; took {}", Time.makeTimeStringRounded(stopwatch)); return result; } finally { serializer.unsetLookupContext(); } }
Source:
<code>public void testTransaction() throws RemoteException, SystemException { <START> log.info("Method stateless #testTransaction called"); <END> Transaction txn; txn = tm.getTransaction(); TxTestUtil.enlistTestXAResource(txn); TxTestUtil.enlistTestXAResource(txn); }</code><technical_language>log.trace if</technical_language>

Target:
public void testTransaction() throws RemoteException, SystemException { log.trace("Method stateless #testTransaction called"); Transaction txn; txn = tm.getTransaction(); TxTestUtil.enlistTestXAResource(txn); TxTestUtil.enlistTestXAResource(txn); }
Source:
<code>public static Community[] findAllTop(Context context) throws SQLException { TableRowIterator tri = null; try { String query = "SELECT c.* FROM community c " + "LEFT JOIN metadatavalue m on (m.resource_id = c.community_id and m.resource_type_id = ? and m.metadata_field_id = ?) " + "WHERE NOT c.community_id IN (SELECT child_comm_id FROM community2community) "; <START> if("oracle".equals(ConfigurationManager.getProperty("db.name"))){ <END> query += " ORDER BY cast(m.text_value as varchar2(128))"; }else{ query += " ORDER BY m.text_value"; } tri = DatabaseManager.query(context, query, Constants.COMMUNITY, MetadataField.findByElement(context, MetadataSchema.find(context, MetadataSchema.DC_SCHEMA).getSchemaID(), "title", null).getFieldID() ); } catch (SQLException e) { log.error("Find all Top Communities - ",e); throw e; } List<Community> topCommunities = new ArrayList<Community>(); try { while (tri.hasNext()) { TableRow row = tri.next(); Community fromCache = (Community) context.fromCache( Community.class, row.getIntColumn("community_id")); if (fromCache != null) { topCommunities.add(fromCache); } else { topCommunities.add(new Community(context, row)); } } } finally { if (tri != null) { tri.close(); } } Community[] communityArray = new Community[topCommunities.size()]; communityArray = (Community[]) topCommunities.toArray(communityArray); return communityArray; }</code><technical_language>DatabaseManager.isOracle()</technical_language>

Target:
public static Community[] findAllTop(Context context) throws SQLException { TableRowIterator tri = null; try { String query = "SELECT c.* FROM community c " + "LEFT JOIN metadatavalue m on (m.resource_id = c.community_id and m.resource_type_id = ? and m.metadata_field_id = ?) " + "WHERE NOT c.community_id IN (SELECT child_comm_id FROM community2community) "; if(DatabaseManager.isOracle()){ query += " ORDER BY cast(m.text_value as varchar2(128))"; }else{ query += " ORDER BY m.text_value"; } tri = DatabaseManager.query(context, query, Constants.COMMUNITY, MetadataField.findByElement(context, MetadataSchema.find(context, MetadataSchema.DC_SCHEMA).getSchemaID(), "title", null).getFieldID() ); } catch (SQLException e) { log.error("Find all Top Communities - ",e); throw e; } List<Community> topCommunities = new ArrayList<Community>(); try { while (tri.hasNext()) { TableRow row = tri.next(); Community fromCache = (Community) context.fromCache( Community.class, row.getIntColumn("community_id")); if (fromCache != null) { topCommunities.add(fromCache); } else { topCommunities.add(new Community(context, row)); } } } finally { if (tri != null) { tri.close(); } } Community[] communityArray = new Community[topCommunities.size()]; communityArray = (Community[]) topCommunities.toArray(communityArray); return communityArray; }
Source:
<code>public void testSort() { <START> statisticsAssertion.check("SELECT * from nation order by n_nationkey", <END> checks -> checks.estimate(OUTPUT_ROW_COUNT, noError())); }</code><technical_language>Reformat this SELECT * nation ORDER n_nationkey</technical_language>

Target:
public void testSort() { statisticsAssertion.check("SELECT * FROM nation ORDER BY n_nationkey", checks -> checks.estimate(OUTPUT_ROW_COUNT, noError())); }
Source:
<code><START> public static byte[] readBytesFromByteBuf(ByteBuf buffer, byte[] data, int offset, int size) throws IOException { <END> return readBytesFromStream(new ByteBufInputStream(buffer), data, offset, size); }</code><technical_language>this differ public abstract ByteBuf readBytes(byte[] dst, int dstIndex, int length); method</technical_language>

Target:
public static byte[] readBytesFromByteBuf(ByteBuf buffer, byte[] data, int offset, int size) throws IOException { buffer.readBytes(data, offset, size); return data; }
Source:
<code>public static boolean isAttributeGroupMetacard(Metacard metacard) { <START> return metacard != null && metacard.getTags().stream().anyMatch(ATTRIBUTE_GROUP_TAG::equals); <END> }</code><technical_language>metacard.getTags().contains(ATTRIBUTE_GROUP_TAG) getTags() returns a Set</technical_language>

Target:
public static boolean isAttributeGroupMetacard(Metacard metacard) { return metacard != null && metacard.getTags().contains(ATTRIBUTE_GROUP_TAG); }
Source:
<code>protected boolean validateImages() { List<DiskImage> imagesToValidate = getDiskImagesToValidate(); DiskImagesValidator diskImagesValidator = new DiskImagesValidator(imagesToValidate); <START> return (!getParameters().isNeedsLocking() || validate(diskImagesValidator.diskImagesNotLocked())) && <END> (getVm().isQualifiedForLiveSnapshotMerge() || validate(diskImagesValidator.diskImagesNotIllegal())); }</code><technical_language>export part a method, if unreadable</technical_language>

Target:
protected boolean validateImages() { List<DiskImage> imagesToValidate = getDiskImagesToValidate(); DiskImagesValidator diskImagesValidator = new DiskImagesValidator(imagesToValidate); return validateImagesNotLocked(diskImagesValidator) && (getVm().isQualifiedForLiveSnapshotMerge() || validate(diskImagesValidator.diskImagesNotIllegal())); }
Source:
<code>public void checkVaultFileSystemLocation() { String userName = new NTSystem().getName(); ForgedAlliancePrefs forgedAlliance = preferencesService.getPreferences().getForgedAlliance(); if (forgedAlliance.isVaultCheckDone()) { return; } Action revertAction = new Action(i18n.get("revert.alreadySymlinked"), event -> forgedAlliance.setVaultBaseDirectory(preferencesService.getPrimaryVaultLocation())); if (userName != null && !CharMatcher.ascii().matchesAllOf(userName) && isWindows()) { forgedAlliance.setVaultBaseDirectory(preferencesService.getSecondaryFallbackVaultLocation()); PersistentNotification notification = new PersistentNotification(i18n.get("mapDir.changed.noneAscii"), Severity.INFO, Collections.singletonList(revertAction)); notificationService.addNotification(notification); } else { <START> String myDocumnetsParentFolder = preferencesService.getPrimaryVaultLocation().getParent().toString(); <END> if (isWindows() && ONE_DRIVE_FOLDER_NAME_IDENTIFIER.matcher(myDocumnetsParentFolder).matches()) { PersistentNotification notification = new PersistentNotification(i18n.get("mapDir.changed.oneDrive"), Severity.INFO, Collections.singletonList(revertAction)); notificationService.addNotification(notification); } else if (isUnix()) { forgedAlliance.setVaultBaseDirectory(preferencesService.getSecondaryFallbackVaultLocation()); PersistentNotification notification = new PersistentNotification(i18n.get("mapDir.changed.unix"), Severity.INFO, Collections.singletonList(revertAction)); notificationService.addNotification(notification); } } forgedAlliance.setVaultCheckDone(true); preferencesService.storeInBackground(); }</code><technical_language>typo</technical_language>

Target:
public void checkVaultFileSystemLocation() { ForgedAlliancePrefs forgedAlliance = preferencesService.getPreferences().getForgedAlliance(); if (forgedAlliance.isVaultCheckDone()) { return; } String userName = System.getProperty("user.name"); if (userName != null && !CharMatcher.ascii().matchesAllOf(userName) && isWindows()) { setSecondaryVaultLocationAndNotifyUser("mapDir.changed.noneAscii"); } else { String myDocumentsParentFolder = preferencesService.getPrimaryVaultLocation().getParent().toString(); if (isWindows() && ONE_DRIVE_FOLDER_NAME_IDENTIFIER.matcher(myDocumentsParentFolder).matches()) { setSecondaryVaultLocationAndNotifyUser("mapDir.changed.oneDrive"); } } if (isUnix()) { setSecondaryVaultLocationAndNotifyUser("mapDir.changed.unix"); } forgedAlliance.setVaultCheckDone(true); preferencesService.storeInBackground(); }
Source:
<code><START> public static Features getFeaturesFromRequest(HttpServletRequest request) throws IOException { <END> Features features = new Features(); String has = getHasConditionsFromRequest(request); if (has != null) { if (log.isLoggable(Level.FINEST)) log.finest("Adding has parameters from request: " + has); for (String s : has.split("[;|]")) { boolean value = true; if (s.startsWith("!")) { s = s.substring(1); value = false; } features.put(s, value); } if (log.isLoggable(Level.FINEST)) log.finest("features = " + features.toString()); } return features.unmodifiableFeatures(); }</code><technical_language>is this changed protected public</technical_language>

Target:
protected static Features getFeaturesFromRequest(HttpServletRequest request) throws IOException { Features features = new Features(); String has = getHasConditionsFromRequest(request); if (has != null) { if (log.isLoggable(Level.FINEST)) log.finest("Adding has parameters from request: " + has); for (String s : has.split("[;|]")) { boolean value = true; if (s.startsWith("!")) { s = s.substring(1); value = false; } features.put(s, value); } if (log.isLoggable(Level.FINEST)) log.finest("features = " + features.toString()); } return features.unmodifiableFeatures(); }
Source:
<code>public List<UIExtension> get(String extensionPointId) { List<UIExtension> panels = new ArrayList<UIExtension>(); String panelConfigurationString = getConfiguration(); if (!StringUtils.isEmpty(panelConfigurationString)) { List<String> panelSerializedReferences = new ArrayList<String>(); for (String serializedReference : getConfiguration().split(",")) { panelSerializedReferences.add(serializer.serialize(resolver.resolve(serializedReference.trim()))); } try { List<UIExtension> allExtensions = contextComponentManagerProvider.get().getInstanceList(UIExtension.class); for (String panelSerializedReference : panelSerializedReferences) { for (UIExtension extension : allExtensions) { String extensionId; <START> if (extension instanceof WikiUIExtension) { <END> WikiUIExtension wikiUIExtension = (WikiUIExtension) extension; extensionId = serializer.serialize(wikiUIExtension.getDocumentReference()); } else { extensionId = serializer.serialize(resolver.resolve(extension.getId())); } if (extensionId.equals(panelSerializedReference)) { panels.add(extension); } } } } catch (ComponentLookupException e) { logger.error("Failed to lookup Panels instances, error: [{}]", e); } } return panels; }</code><technical_language>manipulate WikiComponent instead of WikiUIExtension PanelWikiUIExtension WikiUIExtension implement it</technical_language>

Target:
public List<UIExtension> get(String extensionPointId) { List<UIExtension> panels = new ArrayList<UIExtension>(); String panelConfigurationString = getConfiguration(); if (!StringUtils.isEmpty(panelConfigurationString)) { Set<DocumentReference> panelSerializedReferences = new HashSet<>(); for (String serializedReference : getConfiguration().split(",")) { panelSerializedReferences.add(resolver.resolve(serializedReference.trim())); } try { List<UIExtension> allExtensions = contextComponentManagerProvider.get().getInstanceList(UIExtension.class); for (UIExtension extension : allExtensions) { DocumentReference extensionId; if (extension instanceof WikiComponent) { WikiComponent wikiComponent = (WikiComponent) extension; extensionId = wikiComponent.getDocumentReference(); } else { extensionId = resolver.resolve(extension.getId()); } if (panelSerializedReferences.contains(extensionId)) { panels.add(extension); } } } catch (ComponentLookupException e) { logger.error("Failed to lookup Panels instances, error: [{}]", e); } } return panels; }
Source:
<code>private TableWriter openWriterAndOverrideImportTypes( CairoSecurityContext cairoSecurityContext, ObjList<TypeAdapter> detectedTypes ) { TableWriter writer = engine.getWriter(cairoSecurityContext, tableName); RecordMetadata metadata = writer.getMetadata(); if (metadata.getColumnCount() < detectedTypes.size()) { writer.close(); throw CairoException.instance(0) .put("column count mismatch [textColumnCount=").put(detectedTypes.size()) .put(", tableColumnCount=").put(metadata.getColumnCount()) .put(", table=").put(tableName) .put(']'); } this.types = detectedTypes; for (int i = 0, n = this.types.size(); i < n; i++) { final int columnType = metadata.getColumnType(i); int detectedType = this.types.getQuick(i).getType(); if (detectedType != columnType) { switch (columnType) { case ColumnType.DATE: logTypeError(i); this.types.setQuick(i, BadDateAdapter.INSTANCE); break; case ColumnType.TIMESTAMP: if (detectedType == ColumnType.DATE) { <START> this.types.setQuick(i, dateToTimestampAdapter.of((DateAdapter) this.types.getQuick(i))); <END> } else { logTypeError(i); this.types.setQuick(i, BadTimestampAdapter.INSTANCE); } break; case ColumnType.BINARY: writer.close(); throw CairoException.instance(0).put("cannot import text into BINARY column [index=").put(i).put(']'); default: this.types.setQuick(i, typeManager.getTypeAdapter(columnType)); break; } } } return writer; }</code><technical_language>Table more timestamp more date is misplaced target column type. A single instance of dateToTimestampAdapter overwritten. is ObjectPool produce multiple adaptors needed</technical_language>

Target:
private TableWriter openWriterAndOverrideImportTypes( CairoSecurityContext cairoSecurityContext, ObjList<TypeAdapter> detectedTypes ) { TableWriter writer = engine.getWriter(cairoSecurityContext, tableName); RecordMetadata metadata = writer.getMetadata(); if (metadata.getColumnCount() < detectedTypes.size()) { writer.close(); throw CairoException.instance(0) .put("column count mismatch [textColumnCount=").put(detectedTypes.size()) .put(", tableColumnCount=").put(metadata.getColumnCount()) .put(", table=").put(tableName) .put(']'); } this.types = detectedTypes; for (int i = 0, n = this.types.size(); i < n; i++) { final int columnType = metadata.getColumnType(i); int detectedType = this.types.getQuick(i).getType(); if (detectedType != columnType) { switch (columnType) { case ColumnType.DATE: logTypeError(i); this.types.setQuick(i, BadDateAdapter.INSTANCE); break; case ColumnType.TIMESTAMP: if (detectedType == ColumnType.DATE) { this.types.setQuick(i, dateToTimestampAdapterPool.next().of((DateAdapter) this.types.getQuick(i))); } else { logTypeError(i); this.types.setQuick(i, BadTimestampAdapter.INSTANCE); } break; case ColumnType.BINARY: writer.close(); throw CairoException.instance(0).put("cannot import text into BINARY column [index=").put(i).put(']'); default: this.types.setQuick(i, typeManager.getTypeAdapter(columnType)); break; } } } return writer; }