auphong2707/dl4se-code-review-dataset huggingface dataset:
Source:
<code>private Result runCommand(Context taskContext, Config taskConfig, JobConsoleLogger console) throws IOException, InterruptedException { ProcessBuilder curl = createCurlCommandWithOptions(taskContext, taskConfig); <START> logger.error("Launching command: " + curl.command()); <END> console.printLine("Launching command: " + curl.command()); curl.environment().putAll(taskContext.getEnvironmentVariables()); console.printEnvironment(curl.environment()); Process curlProcess = curl.start(); console.readErrorOf(curlProcess.getErrorStream()); console.readOutputOf(curlProcess.getInputStream()); int exitCode = curlProcess.waitFor(); curlProcess.destroy(); if (exitCode != 0) { return new Result(false, "Failed downloading file. Please check the output"); } return new Result(true, "Downloaded file: " + CURLED_FILE); }</code><technical_language>a reason. But, logger.error? log logger, if in console? able correlate</technical_language>

Target:
private Result runCommand(Context taskContext, Config taskConfig, JobConsoleLogger console) throws IOException, InterruptedException { ProcessBuilder curl = createCurlCommandWithOptions(taskContext, taskConfig); console.printLine("Launching command: " + curl.command()); curl.environment().putAll(taskContext.getEnvironmentVariables()); console.printEnvironment(curl.environment()); Process curlProcess = curl.start(); console.readErrorOf(curlProcess.getErrorStream()); console.readOutputOf(curlProcess.getInputStream()); int exitCode = curlProcess.waitFor(); curlProcess.destroy(); if (exitCode != 0) { return new Result(false, "Failed downloading file. Please check the output"); } return new Result(true, "Downloaded file: " + CURLED_FILE); }
Source:
<code>private void postProcess(Path tmpDir, GoGoDuckModule module) throws GoGoDuckException { File[] directoryListing = tmpDir.toFile().listFiles(); if (directoryListing != null) { for (File file : directoryListing) { try { logger.info(String.format("Checking file %s for packed variable", file.getAbsolutePath())); if (!module.unpackNetcdf()) { <START> logger.info(String.format("No packed variable found in %s", file.getAbsolutePath())); <END> return; } File tmpFile = File.createTempFile("ncpdq", ".nc"); logger.info(String.format("Unpacking file (ncpdq) '%s' to '%s'", file.toPath(), tmpFile.toPath())); List<String> command = new ArrayList<>(); command.add(goGoDuckConfig.getNcpdqPath()); command.add("-O"); command.add("-U"); command.add(file.getAbsolutePath()); command.add(tmpFile.getAbsolutePath()); GoGoDuck.execute(command); Files.delete(file.toPath()); Files.move(tmpFile.toPath(), file.toPath()); } catch (Exception e) { throw new GoGoDuckException(String.format("Could not run ncpdq on file '%s'", file.toPath())); } } } else { throw new GoGoDuckException("No files available for post processing"); } }</code><technical_language>'Not unpacking {file name}... 'would - this impression unpacked variables in file - this case - config overriding this</technical_language>

Target:
private void postProcess(Path tmpDir, GoGoDuckModule module) throws GoGoDuckException { File[] directoryListing = tmpDir.toFile().listFiles(); if (directoryListing != null) { for (File file : directoryListing) { try { if (!module.unpackNetcdf()) { logger.info(String.format("Not unpacking file %s", file.getAbsolutePath())); return; } File tmpFile = File.createTempFile("ncpdq", ".nc"); logger.info(String.format("Unpacking file (ncpdq) '%s' to '%s'", file.toPath(), tmpFile.toPath())); List<String> command = new ArrayList<>(); command.add(goGoDuckConfig.getNcpdqPath()); command.add("-O"); command.add("-U"); command.add(file.getAbsolutePath()); command.add(tmpFile.getAbsolutePath()); GoGoDuck.execute(command); Files.delete(file.toPath()); Files.move(tmpFile.toPath(), file.toPath()); } catch (Exception e) { throw new GoGoDuckException(String.format("Could not run ncpdq on file '%s'", file.toPath())); } } } else { throw new GoGoDuckException("No files available for post processing"); } }
Source:
<code>public QRCodeGenerator providesQRCodeGenerator() { return new QRCodeGenerator() { @Override public Observable<Bitmap> generateQRCode(Collection<String> selectedPasswordKeys) { <START> return QRCodeUtils.getQRCodeGeneratorObservable(selectedPasswordKeys); <END> } }; }</code><technical_language>If nicer for QRCodeUtils.getQRCodeGeneratorObservable's logic move this implementation (and in class file). Wrapping this is a nice trick for dealing statics control do control this one</technical_language>

Target:
public QRCodeGenerator providesQRCodeGenerator() { return new ObservableQRCodeGenerator(); }
Source:
<code>public MaxwellKafkaProducer(MaxwellContext context, Properties kafkaProperties, String kafkaTopic) { super(context); this.queue = new LinkedBlockingQueue<>(100); this.worker = new MaxwellKafkaProducerWorker(context, kafkaProperties, kafkaTopic, this.queue); <START> new Thread(this.worker, "maxwell-kafka-producer").start(); <END> }</code><technical_language>name of thread maxwell-kafka-producer-worker instead</technical_language>

Target:
public MaxwellKafkaProducer(MaxwellContext context, Properties kafkaProperties, String kafkaTopic) { super(context); this.queue = new ArrayBlockingQueue<>(100); this.worker = new MaxwellKafkaProducerWorker(context, kafkaProperties, kafkaTopic, this.queue); new Thread(this.worker, "maxwell-kafka-worker").start(); }
Source:
<code>public void completeBuilderShouldUpdateUriObject() { Uri oldUri = mock(Uri.class); Uri newUri = mock(Uri.class); DeleteQuery query = DeleteQuery.builder() .uri(oldUri) .uri(newUri) .build(); <START> assertThat(query.uri()).isEqualTo(newUri); <END> }</code><technical_language>isSame()</technical_language>

Target:
public void completeBuilderShouldUpdateUriObject() { Uri oldUri = mock(Uri.class); Uri newUri = mock(Uri.class); DeleteQuery query = DeleteQuery.builder() .uri(oldUri) .uri(newUri) .build(); assertThat(query.uri()).isSameAs(newUri); }
Source:
<code>public static SendTabData fromBundle(Bundle bundle) { if (bundle == null) { throw new IllegalArgumentException("bundle must not be null"); } String text = bundle.getString(Intent.EXTRA_TEXT); String subject = bundle.getString(Intent.EXTRA_SUBJECT); String title = bundle.getString(Intent.EXTRA_TITLE); String theTitle = subject; if (theTitle == null) { theTitle = title; } String theUri = null; if (text != null && WebURLFinder.isWebURL(text)) { theUri = text; } else { StringBuffer sb = new StringBuffer(); for (String data : new String[] { text, subject, title }) { if (data != null) { sb.append(data); sb.append("\n\n"); } } <START> theUri = new WebURLFinder(sb.toString()).bestWebURL(); <END> } return new SendTabData(theTitle, theUri); }</code><technical_language>WebURLFinder a collection? Cheaper concatenating a new string</technical_language>

Target:
protected static SendTabData fromBundle(Bundle bundle) { if (bundle == null) { throw new IllegalArgumentException("bundle must not be null"); } String text = bundle.getString(Intent.EXTRA_TEXT); String subject = bundle.getString(Intent.EXTRA_SUBJECT); String title = bundle.getString(Intent.EXTRA_TITLE); String theTitle = subject; if (theTitle == null) { theTitle = title; } List<String> strings = new ArrayList<String>(); strings.add(text); strings.add(subject); strings.add(title); String theUri = new WebURLFinder(strings).bestWebURL(); return new SendTabData(theTitle, theUri); }
Source:
<code>public static void markAsLinkNote(View view) { EAnnotation specificStyles = view.getEAnnotation(ViewQuery.SPECIFIC_STYLES); <START> if (specificStyles == null) { specificStyles = EcoreFactory.eINSTANCE.createEAnnotation(); specificStyles.setSource(ViewQuery.SPECIFIC_STYLES); specificStyles.getDetails().put(SiriusNoteEditPart.LINK_NOTE_STYLE, null); view.getEAnnotations().add(specificStyles); } else { specificStyles.getDetails().put(SiriusNoteEditPart.LINK_NOTE_STYLE, null); } <END> }</code><technical_language>if (specificStyles == null) { specificStyles = EcoreFactory.eINSTANCE.createEAnnotation(); specificStyles.setSource(ViewQuery.SPECIFIC_STYLES); view.getEAnnotations().add(specificStyles); } specificStyles.getDetails().put(SiriusNoteEditPart.LINK_NOTE_STYLE, null);</technical_language>

Target:
public static void markAsLinkNote(View view) { EAnnotation specificStyles = view.getEAnnotation(ViewQuery.SPECIFIC_STYLES); if (specificStyles == null) { specificStyles = EcoreFactory.eINSTANCE.createEAnnotation(); specificStyles.setSource(ViewQuery.SPECIFIC_STYLES); view.getEAnnotations().add(specificStyles); } specificStyles.getDetails().put(SiriusNoteEditPart.LINK_NOTE_STYLE, null); }
Source:
<code>private Map<String, Object> toModel() { HashMap<String, Object> model = new HashMap<>(); model.put("knowSomeone", knowSomeone.length() > 0 ? "checked" : ""); model.put("connectToStrangers", connectToStrangers.length() > 0 ? "checked" : ""); model.put("haveMonthlyLimit", haveMonthlyLimit.length() > 0 ? "checked" : ""); model.put("downloadLimit", downloadLimit); model.put("uploadLimit", uploadLimit); model.put("bandwidthMonthlyLimit", bandwidthMonthlyLimit); model.put("storageLimit", storageLimit); model.put("setPassword", setPassword.length() > 0 ? "checked" : ""); if (downloadLimitDetected == null || uploadLimitDetected == null) <START> detectBandwidthLimit(); <END> model.put("downloadLimitDetected", downloadLimitDetected != null ? downloadLimitDetected : l10n("bandwidthCommonInternetConnectionSpeedsDetectedUnavailable")); model.put("uploadLimitDetected", uploadLimitDetected != null ? uploadLimitDetected : l10n("bandwidthCommonInternetConnectionSpeedsDetectedUnavailable")); model.put("errors", errors); return model; }</code><technical_language>please add curly braces if-body. This done in existing code, touch code, fix it</technical_language>

Target:
private Map<String, Object> toModel() { HashMap<String, Object> model = new HashMap<>(); model.put("knowSomeone", knowSomeone.length() > 0 ? "checked" : ""); model.put("connectToStrangers", connectToStrangers.length() > 0 ? "checked" : ""); model.put("haveMonthlyLimit", haveMonthlyLimit.length() > 0 ? "checked" : ""); model.put("downloadLimit", downloadLimit); model.put("uploadLimit", uploadLimit); model.put("bandwidthMonthlyLimit", bandwidthMonthlyLimit); model.put("minBandwidthMonthlyLimit", String.format("%.2f", BandwidthLimit.minMonthlyLimit)); model.put("storageLimit", storageLimit); if (isPasswordEmpty) { model.put("setPassword", setPassword.length() > 0 ? "checked" : ""); } model.put("isPasswordEmpty", isPasswordEmpty); if (downloadLimitDetected == null || uploadLimitDetected == null) { detectBandwidthLimit(); } model.put("downloadLimitDetected", downloadLimitDetected != null ? downloadLimitDetected : l10n("bandwidthCommonInternetConnectionSpeedsDetectedUnavailable")); model.put("uploadLimitDetected", uploadLimitDetected != null ? uploadLimitDetected : l10n("bandwidthCommonInternetConnectionSpeedsDetectedUnavailable")); model.put("errors", errors); return model; }
Source:
<code>private int calculateDigits(long time0, long time1) { int numDigits = 5; long timeRange = time1 - time0; if (fTimeProvider.getTimeFormat().equals(TimeFormat.CALENDAR)) { numDigits += 8; if (timeRange < 10000) { numDigits += 10; } else if (timeRange < 10000000) { numDigits += 6; } } else { long sec = time1 / SEC_IN_NS; numDigits = Long.toString(sec).length(); int thousandGroups = (numDigits - 1) / 3; numDigits += thousandGroups; numDigits += 12; <START> if (fTimeProvider.getTimeFormat().equals(TimeFormat.CYCLES)) { <END> numDigits += Messages.Utils_ClockCyclesUnit.length(); } } return numDigits; }</code><technical_language>compare enums ==, more null-safe. @NonNull ;)</technical_language>

Target:
private int calculateDigits(long time0, long time1) { int numDigits = 5; long timeRange = time1 - time0; if (fTimeProvider.getTimeFormat() == TimeFormat.CALENDAR) { numDigits += 8; if (timeRange < 10000) { numDigits += 10; } else if (timeRange < 10000000) { numDigits += 6; } } else { long sec = time1 / SEC_IN_NS; numDigits = Long.toString(sec).length(); int thousandGroups = (numDigits - 1) / 3; numDigits += thousandGroups; numDigits += 12; if (fTimeProvider.getTimeFormat() == TimeFormat.CYCLES) { numDigits += Messages.Utils_ClockCyclesUnit.length(); } } return numDigits; }
Source:
<code>public void run() { scheduler.freeze(); try { DateTime deadLine = DateTime.now().plusSeconds(possibleDealyInSeconds); while (DateTime.now().isBefore(deadLine) && otherTaskIsRunning()) { Thread.sleep(10000); } if (!otherTaskIsRunning()) { synchronizationAPI.freeze(); try { removeOldBackups(); performBackup(); } finally { synchronizationAPI.resume(); } } else { <START> LOGGER.info("Backup will not be performed because there is still some jobs running"); <END> } } catch (IOException | InterruptedException e) { LOGGER.error("", e); } finally { scheduler.resume(); } }</code><technical_language>LOGGER.warn Add a message amount of time wait increased property pa.server.backup.possile.delay</technical_language>

Target:
public void run() { scheduler.freeze(); try { DateTime deadLine = DateTime.now().plusSeconds(possibleDelayInSeconds); while (DateTime.now().isBefore(deadLine) && someTaskIsRunning()) { Thread.sleep(10000); } if (noTaskIsRunning()) { synchronizationAPI.freeze(); try { removeOldBackups(); performBackup(); } finally { synchronizationAPI.resume(); } } else { LOGGER.warn("Backup will not be performed because there is still some jobs running. " + "Waititng time can be changed by using the property 'pa.server.backup.possile.delay'."); } } catch (IOException | InterruptedException e) { LOGGER.error("", e); } finally { scheduler.resume(); } }
Source:
<code>private boolean canBridgeFirewall(final String prvNic) { <START> final Script cmd = new Script(_securityGroupPath, _timeout.getMillis(), s_logger); <END> cmd.add("can_bridge_firewall"); cmd.add(prvNic); final String result = cmd.execute(); if (result != null) { return false; } return true; }</code><technical_language>Please consider adding overridden version of Script(String, int, Logger) constructor accepts Duration encapsulate this type conversion</technical_language>

Target:
private boolean canBridgeFirewall(final String prvNic) { final Script cmd = new Script(_securityGroupPath, _timeout, s_logger); cmd.add("can_bridge_firewall"); cmd.add(prvNic); final String result = cmd.execute(); if (result != null) { return false; } return true; }
Source:
<code>public Response createCluster(@PathParam("clusterId") String clusterId, @DefaultValue("false") @QueryParam("recreate") String recreate, @DefaultValue("false") @QueryParam("addCloudConfig") String addCloudConfig, String content) { boolean recreateIfExists = Boolean.valueOf(recreate); boolean cloudConfigIncluded = Boolean.valueOf(addCloudConfig); ClusterSetup clusterSetup = getClusterSetup(); <START> if (!cloudConfigIncluded) { <END> try { clusterSetup.addCluster(clusterId, recreateIfExists, null); } catch (Exception ex) { _logger.error("Failed to create cluster " + clusterId + ", exception: " + ex); return serverError(ex); } return created(); } else { ZNRecord record; try { record = toZNRecord(content); } catch (IOException e) { _logger.error("Failed to deserialize user's input " + content + ", Exception: " + e); return badRequest("Input is not a vaild ZNRecord!"); } try { CloudConfig cloudConfig = new CloudConfig.Builder(record).build(); clusterSetup.addCluster(clusterId, recreateIfExists, cloudConfig); } catch (Exception ex) { _logger.error("Error in adding a CloudConfig to cluster: " + clusterId, ex); return badRequest(ex.getMessage()); } return created(); } }</code><technical_language>reorganize code. duplicated pieces. can: 1. Define CloudConfig object 2. Create this object if enabled move this piece of code a separate function. Otherwise, null. 3. Call addCluster CloudConfig object</technical_language>

Target:
public Response createCluster(@PathParam("clusterId") String clusterId, @DefaultValue("false") @QueryParam("recreate") String recreate, @DefaultValue("false") @QueryParam("addCloudConfig") String addCloudConfig, String content) { boolean recreateIfExists = Boolean.valueOf(recreate); boolean cloudConfigIncluded = Boolean.valueOf(addCloudConfig); ClusterSetup clusterSetup = getClusterSetup(); CloudConfig cloudConfig = null; if (cloudConfigIncluded) { ZNRecord record; try { record = toZNRecord(content); } catch (IOException e) { _logger.error("Failed to deserialize user's input " + content + ", Exception: " + e); return badRequest("Input is not a vaild ZNRecord!"); } try { cloudConfig = new CloudConfig.Builder(record).build(); clusterSetup.addCluster(clusterId, recreateIfExists, cloudConfig); } catch (Exception ex) { _logger.error("Error in adding a CloudConfig to cluster: " + clusterId, ex); return badRequest(ex.getMessage()); } } clusterSetup.addCluster(clusterId, recreateIfExists, cloudConfig); return created(); }
Source:
<code>private void columnDelta1(SafeHtmlBuilder sb, FileInfo info) { sb.openTd().setStyleName(R.css().deltaColumn1()); if (!Patch.COMMIT_MSG.equals(info.path()) && !info.binary()) { if <START> (Gerrit.getUserAccount().getGeneralPreferences() <END> .isSizeBarInChangeTable()) { sb.append(info.lines_inserted() + info.lines_deleted()); } else if (!ChangeType.DELETED.matches(info.status())) { if (ChangeType.ADDED.matches(info.status())) { sb.append(info.lines_inserted()) .append(" lines"); } else { sb.append("+") .append(info.lines_inserted()) .append(", -") .append(info.lines_deleted()); } } } sb.closeTd(); }</code><technical_language>IIRC anonymous users crash user account get prefs from</technical_language>

Target:
private void columnDelta1(SafeHtmlBuilder sb, FileInfo info) { sb.openTd().setStyleName(R.css().deltaColumn1()); if (!Patch.COMMIT_MSG.equals(info.path()) && !info.binary()) { if (showChangeSizeBars) { sb.append(info.lines_inserted() + info.lines_deleted()); } else if (!ChangeType.DELETED.matches(info.status())) { if (ChangeType.ADDED.matches(info.status())) { sb.append(info.lines_inserted()) .append(" lines"); } else { sb.append("+") .append(info.lines_inserted()) .append(", -") .append(info.lines_deleted()); } } } sb.closeTd(); }
Source:
<code>public void generateElasticChangeEvents(int oldPartitionCnt, int newPartitionCnt, long spHandle, long uniqueId) { <START> hostLog.info("Generating Elastic Change event"); <END> ByteBuffer paramBuffer = ByteBuffer.allocate(8); paramBuffer.putInt(oldPartitionCnt); paramBuffer.putInt(newPartitionCnt); generateDREvent( EventType.DR_ELASTIC_CHANGE, uniqueId, m_lastCommittedSpHandle, spHandle, paramBuffer.array()); }</code><technical_language>Nit: This debug level, right</technical_language>

Target:
public void generateElasticChangeEvents(int oldPartitionCnt, int newPartitionCnt, long spHandle, long uniqueId) { ByteBuffer paramBuffer = ByteBuffer.allocate(8); paramBuffer.putInt(oldPartitionCnt); paramBuffer.putInt(newPartitionCnt); generateDREvent( EventType.DR_ELASTIC_CHANGE, uniqueId, m_lastCommittedSpHandle, spHandle, paramBuffer.array()); }
Source:
<code><START> public static synchronized int getStyledColor(Theme theme, @AttrRes int attr) { <END> theme.resolveAttribute(attr, TYPED_VALUE, true); return TYPED_VALUE.data; }</code><technical_language>synchronized? This called main thread, right</technical_language>

Target:
public static int getStyledColor(Theme theme, @AttrRes int attr) { theme.resolveAttribute(attr, TYPED_VALUE, true); return TYPED_VALUE.data; }
Source:
<code>public SparkAnalysisRunner(JavaSparkContext sparkContext, SparkJobContext sparkJobContext, Integer minPartitions) { _sparkContext = sparkContext; _sparkJobContext = sparkJobContext; if ((minPartitions != null) && (minPartitions > 0)) { _minPartitions = minPartitions; } else { <START> logger.warn( <END> "Minimum number of partitions needs to be a positive number, but specified: {}. Disregarding the value and inferring the number of partitions automatically", minPartitions); _minPartitions = null; } }</code><technical_language>raise a warning for is default behaviour ... I throw exception if minPartitions is non-null less-or-equal 0</technical_language>

Target:
public SparkAnalysisRunner(JavaSparkContext sparkContext, SparkJobContext sparkJobContext, Integer minPartitions) { _sparkContext = sparkContext; _sparkJobContext = sparkJobContext; if (minPartitions != null) { if (minPartitions > 0) { _minPartitions = minPartitions; } else { logger.warn( "Minimum number of partitions needs to be a positive number, but specified: {}. Disregarding the value and inferring the number of partitions automatically", minPartitions); _minPartitions = null; } } else { _minPartitions = null; } }
Source:
<code>public void testExtensionClassLoader() throws ClassNotFoundException { final ClassLoader globalParent = ClassLoaderUtils.getParentClassLoader(); final File[] jarFiles = new File[] { new File("src/test/resources/FooBarPlugin.jar") }; final ClassLoader parent1 = ClassLoaderUtils.createClassLoader(jarFiles, null); final ClassLoader c1 = new ExtensionClassLoader(parent1, globalParent, "Extension1"); final Class<?> bazTransformer1 = c1.loadClass("foo.bar.transformer.BazTransformer"); Assert.assertNotNull(bazTransformer1); final ClassLoader parent2 = ClassLoaderUtils.createClassLoader(jarFiles, null); final ClassLoader c2 = new ExtensionClassLoader(parent2, globalParent, "Extension2"); final Class<?> bazTransformer2 = c2.loadClass("foo.bar.transformer.BazTransformer"); Assert.assertNotNull(bazTransformer2); final ClassLoader loader1 = bazTransformer1.getClassLoader(); final ClassLoader loader2 = bazTransformer2.getClassLoader(); <START> Assert.assertEquals("Extension classloader for: Extension1", loader1.toString()); <END> Assert.assertEquals("Extension classloader for: Extension2", loader2.toString()); }</code><technical_language>extra explicit add: assertNotEquals(bazTransformer1, bazTransformer2)</technical_language>

Target:
public void testExtensionClassLoader() throws ClassNotFoundException { final ClassLoader globalParent = ClassLoaderUtils.getParentClassLoader(); final File[] jarFiles = new File[] { new File("src/test/resources/FooBarPlugin.jar") }; final ClassLoader parent1 = ClassLoaderUtils.createClassLoader(jarFiles, null); final ClassLoader c1 = new ExtensionClassLoader(parent1, globalParent, "Extension1"); final Class<?> bazTransformer1 = c1.loadClass("foo.bar.transformer.BazTransformer"); Assert.assertNotNull(bazTransformer1); final ClassLoader parent2 = ClassLoaderUtils.createClassLoader(jarFiles, null); final ClassLoader c2 = new ExtensionClassLoader(parent2, globalParent, "Extension2"); final Class<?> bazTransformer2 = c2.loadClass("foo.bar.transformer.BazTransformer"); Assert.assertNotNull(bazTransformer2); final ClassLoader loader1 = bazTransformer1.getClassLoader(); final ClassLoader loader2 = bazTransformer2.getClassLoader(); Assert.assertEquals("Extension classloader for: Extension1", loader1.toString()); Assert.assertEquals("Extension classloader for: Extension2", loader2.toString()); Assert.assertNotEquals(bazTransformer1, bazTransformer2); }
Source:
<code>public AssetReportCreateRequest withFirstName(String firstName) { notNull(firstName, "firstName"); options = options.orElse(new Options()); options.get().user = options.get().user.orElse(new Options.UserOptions()); <START> options.get().user.get().clientUserId = firstName; <END> return this; }</code><technical_language>client user id is name</technical_language>

Target:
public AssetReportCreateRequest withFirstName(String firstName) { notNull(firstName, "firstName"); options = options.orElse(new Options()); options.get().user = options.get().user.orElse(new Options.UserOptions()); options.get().user.get().firstName = firstName; return this; }
Source:
<code>public void onResponseContent(Buffer content) { logger.debug("Jetty received response content of size " + String.valueOf(content.length())); JSONObject responseJson = new JSONObject(); try { responseJson.put("id", mRequestId); responseJson.put("body", content.asArray()); <START> if (this.getStatus() != STATUS_CANCELLING && this.getStatus() != STATUS_CANCELLED) <END> mSocket.emit("responseContentBinary", responseJson); logger.debug(String.format("Sent content to request %d", mRequestId)); } catch (JSONException e) { logger.error(e.getMessage()); } }</code><technical_language>curly braces for sake of readability alltough this is Oneliner (also applies subsequent callback methods)</technical_language>

Target:
public void onResponseContent(Buffer content) { logger.debug("Jetty received response content of size " + String.valueOf(content.length())); JSONObject responseJson = new JSONObject(); try { responseJson.put("id", mRequestId); responseJson.put("body", content.asArray()); if (this.getStatus() != STATUS_CANCELLING && this.getStatus() != STATUS_CANCELLED) { mSocket.emit("responseContentBinary", responseJson); } logger.debug("Sent content to request {}", mRequestId); } catch (JSONException e) { logger.error(e.getMessage()); } }
Source:
<code>public void testFetchLabelIdsForEmptyString() throws Exception { NGramGenerator ngram = new NGramGenerator(""); List<ResultSetFuture> result = searchPlugin.fetchLabelIds(ngram); <START> assertNotNull(result); <END> }</code><technical_language>Testing n-grams is a good test case I NGramGenerator couples hard. Letting #fetchLabelIds method accept a general Iterator<String> instead ImmutableSet.of().iterator() is more I believe. change assrtNotNull assertTrue(result.isEmpty())</technical_language>

Target:
public void testFetchLabelIdsForEmptyString() throws Exception { List<ResultSetFuture> result = searchPlugin.fetchLabelIds(ImmutableSet.<String>of().iterator()); assertTrue(result.isEmpty()); }
Source:
<code>private static RemediationFunction remediationFunction(AnalyzerMessage issue) { String ruleKey = ruleKey(issue); try { RuleJSON rule = getRuleJSON(ruleKey); if (rule.remediation == null) { return null; } switch (rule.remediation.func) { case "Linear": return RemediationFunction.LINEAR; case "Constant/Issue": return RemediationFunction.CONST; default: return null; } <START> } catch (IOException | JsonParseException e) { <END> LOG.warn("JSON metadata for rule " + ruleKey + " couldn't be loaded. Constant remediation function will be assumed." + " Provide rule JSON file if you want to customize metadata for tests."); LOG.debug(e.getMessage()); return null; } }</code><technical_language>![MAJOR](<LINK_0> 'Severity: MAJOR') log rethrow this exception. [![rule](<LINK_2>](<LINK_1></technical_language>

Target:
private static RemediationFunction remediationFunction(AnalyzerMessage issue) { String ruleKey = ruleKey(issue); try { RuleJSON rule = getRuleJSON(ruleKey); if (rule.remediation == null) { return null; } switch (rule.remediation.func) { case "Linear": return RemediationFunction.LINEAR; case "Constant/Issue": return RemediationFunction.CONST; default: return null; } } catch (IOException | JsonParseException e) { LOG.debug("Remediation function and cost not provided, \"constant\" is assumed."); return null; } }
Source:
<code>protected boolean checkIfLunDiskCanBeAdded() { LUNs lun = ((LunDisk) getParameters().getDiskInfo()).getLun(); switch (lun.getLunType()) { case UNKNOWN: return failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_DISK_LUN_HAS_NO_VALID_TYPE); case ISCSI: if (lun.getLunConnections() == null || lun.getLunConnections().isEmpty()) { return failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_DISK_LUN_ISCSI_MISSING_CONNECTION_PARAMS); } for (StorageServerConnections conn : lun.getLunConnections()) { if (StringUtils.isEmpty(conn.getiqn()) || StringUtils.isEmpty(conn.getconnection()) || StringUtils.isEmpty(conn.getport())) { return failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_DISK_LUN_ISCSI_MISSING_CONNECTION_PARAMS); } } break; } if (getDiskLunMapDao().getDiskIdByLunId(lun.getLUN_id()) != null) { return failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_DISK_LUN_IS_ALREADY_IN_USE); } if (getVm() == null) { return true; } <START> return <END> validate(getSnapshotValidator().vmNotDuringSnapshot(getVmId())) && validate(getSnapshotValidator().vmNotInPreview(getVmId())) && validate(new VmValidator(getVm()).vmNotLocked()); }</code><technical_language>i do: if (getVm() != null && validate...) return true is confusing add checks in future miss</technical_language>

Target:
protected boolean checkIfLunDiskCanBeAdded() { LUNs lun = ((LunDisk) getParameters().getDiskInfo()).getLun(); switch (lun.getLunType()) { case UNKNOWN: return failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_DISK_LUN_HAS_NO_VALID_TYPE); case ISCSI: if (lun.getLunConnections() == null || lun.getLunConnections().isEmpty()) { return failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_DISK_LUN_ISCSI_MISSING_CONNECTION_PARAMS); } for (StorageServerConnections conn : lun.getLunConnections()) { if (StringUtils.isEmpty(conn.getiqn()) || StringUtils.isEmpty(conn.getconnection()) || StringUtils.isEmpty(conn.getport())) { return failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_DISK_LUN_ISCSI_MISSING_CONNECTION_PARAMS); } } break; } if (getDiskLunMapDao().getDiskIdByLunId(lun.getLUN_id()) != null) { return failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_DISK_LUN_IS_ALREADY_IN_USE); } if (getVm() != null) { if (!isVmNotInPreviewSnapshot()) { return false; } if (!isVmNotLocked()) { return false; } } return true; }
Source:
<code>public int hashCode() { if (isDisposed()) return 0; <START> return (((alpha * 31) + this.getGreen()) * 31 + this.getBlue()) * 31 + this.getRed(); <END> }</code><technical_language>do this. getters alpha? I skip this. getAlpha()</technical_language>

Target:
public int hashCode() { if (isDisposed()) return 0; return (((this.getAlpha() * 31) + this.getGreen()) * 31 + this.getBlue()) * 31 + this.getRed(); }
Source:
<code><START> void setResourceInformation(Resource resource, String resourceName, long amount) throws Exception { <END> if (!isYarnResourceTypesAvailable) { throw new UnsupportedOperationException("Should not try to set ResourceInformation because the underlying Yarn does not support it."); } setResourceInfoMethod.invoke( resource, resourceName, resourceInfoNewInstance.invoke(null, resourceName, amount)); }</code><technical_language>handle exceptions this class, caller need aware of version differences</technical_language>

Target:
void setResourceInformation(Resource resource, String resourceName, long amount) { setResourceInformationUnSafe(resource, resourceName, amount); }
Source:
<code>public void setUpTestData() throws Exception { AbstractAuditBackend backend = (AbstractAuditBackend) this.auditBackend; AuditQueryBuilder builder = new AuditQueryBuilder().predicates( Predicates.eq(LOG_EVENT_ID, ID_FOR_AUDIT_STORAGE_TESTS)); List<LogEntry> logs = backend.queryLogs(builder); if (logs.isEmpty()) { List<String> jsonEntries = new ArrayList<>(); for (int i = 1; i <= NUM_OF_EVENTS; i++) { ObjectNode logEntryJson = mapper.createObjectNode(); <START> logEntryJson.put(LOG_ID, Integer.valueOf(i).longValue()); <END> logEntryJson.put(LOG_EVENT_ID, ID_FOR_AUDIT_STORAGE_TESTS); logEntryJson.put(LOG_DOC_PATH, i % 2 == 0 ? "/is/even" : "/is/odd"); jsonEntries.add(mapper.writeValueAsString(logEntryJson)); } backend.append(jsonEntries); flush(); } }</code><technical_language>(long) i is simpler</technical_language>

Target:
public void setUpTestData() throws Exception { AbstractAuditBackend backend = (AbstractAuditBackend) this.auditBackend; AuditQueryBuilder builder = new AuditQueryBuilder().predicates( Predicates.eq(LOG_EVENT_ID, ID_FOR_AUDIT_STORAGE_TESTS)); List<LogEntry> logs = backend.queryLogs(builder); if (logs.isEmpty()) { List<String> jsonEntries = new ArrayList<>(); for (int i = 1; i <= NUM_OF_EVENTS; i++) { ObjectNode logEntryJson = mapper.createObjectNode(); logEntryJson.put(LOG_ID, 1000L + i); logEntryJson.put(LOG_EVENT_ID, ID_FOR_AUDIT_STORAGE_TESTS); logEntryJson.put(LOG_DOC_PATH, i % 2 == 0 ? "/is/even" : "/is/odd"); jsonEntries.add(mapper.writeValueAsString(logEntryJson)); } backend.append(jsonEntries); flush(); } }
Source:
<code>private int getMaxChildrenSeverityInCache(IContainer container) { if (!container.isAccessible()) { return -1; } Set<IResource> children = new HashSet<>(); try { children.addAll(Arrays.asList(container.members())); } catch (CoreException ex) { WorkbenchNavigatorPlugin.log("Cannot access members", WorkbenchNavigatorPlugin.createErrorStatus(ex.getMessage(), ex)); } children.addAll(Arrays.asList(NestedProjectManager.getInstance().getDirectChildrenProjects(container))); int severity = -1; for (IResource child : children) { Integer cachedSeverity = cache.get(child); if (cachedSeverity != null && cachedSeverity.intValue() > severity) { <START> severity = cachedSeverity.intValue(); <END> } } ; return severity; }</code><technical_language>do: if(severity >= IMarker.SEVERITY_ERROR){ return severity; }</technical_language>

Target:
private int getMaxChildrenSeverityInCache(IContainer container) { if (!container.isAccessible()) { return -1; } Set<IResource> children = new HashSet<>(); try { children.addAll(Arrays.asList(container.members())); } catch (CoreException ex) { WorkbenchNavigatorPlugin.log("Cannot access members", WorkbenchNavigatorPlugin.createErrorStatus(ex.getMessage(), ex)); } children.addAll(Arrays.asList(NestedProjectManager.getInstance().getDirectChildrenProjects(container))); int severity = -1; for (IResource child : children) { Integer cachedSeverity = cache.get(child); if (cachedSeverity != null && cachedSeverity.intValue() > severity) { severity = cachedSeverity.intValue(); if (severity >= IMarker.SEVERITY_ERROR) { return severity; } } } ; return severity; }
Source:
<code>void checkAndMaybeComplete() { boolean done = false; if (operationTracker.isDone()) { if (!operationTracker.hasSucceeded()) { failedAttempts++; if (failedAttempts <= routerConfig.routerMaxSlippedPutAttempts) { logger.trace("Attempt to put chunk with id: failed, attempting slipped put ", chunkBlobId); routerMetrics.slippedPutAttemptCount.inc(); prepareForSending(); } else { <START> logger.error("Elapsed slipped puts. Failing the operation for {}", getChunkBlobId()); <END> chunkBlobId = null; setOperationExceptionAndComplete(chunkException); done = true; } } else { chunkException = null; done = true; } } if (done) { state = ChunkState.Complete; } }</code><technical_language>"Slipped puts failed" is</technical_language>

Target:
void checkAndMaybeComplete() { boolean done = false; if (operationTracker.isDone()) { if (!operationTracker.hasSucceeded()) { failedAttempts++; if (failedAttempts <= routerConfig.routerMaxSlippedPutAttempts) { logger.trace("Attempt to put chunk with id: failed, attempting slipped put ", chunkBlobId); routerMetrics.slippedPutAttemptCount.inc(); prepareForSending(); } else { logger.error("Slipped puts failed for {}", getChunkBlobId()); chunkBlobId = null; setOperationExceptionAndComplete(chunkException); done = true; } } else { chunkException = null; done = true; } } if (done) { state = ChunkState.Complete; } }
Source:
<code>public VepInputGeneratorStepParametersValidator() { <START> super(new String[]{JobParametersNames.CONFIG_RESTARTABILITY_ALLOW, <END> JobParametersNames.DB_COLLECTIONS_VARIANTS_NAME, JobParametersNames.DB_NAME, JobParametersNames.INPUT_STUDY_ID, JobParametersNames.INPUT_VCF_ID, JobParametersNames.OUTPUT_DIR_ANNOTATION}, new String[]{}); }</code><technical_language>Is this parameters mandatory? I thought default false</technical_language>

Target:
public VepInputGeneratorStepParametersValidator() { super(new String[]{JobParametersNames.DB_COLLECTIONS_VARIANTS_NAME, JobParametersNames.DB_NAME, JobParametersNames.INPUT_STUDY_ID, JobParametersNames.INPUT_VCF_ID, JobParametersNames.OUTPUT_DIR_ANNOTATION}, new String[]{JobParametersNames.CONFIG_RESTARTABILITY_ALLOW}); }
Source:
<code>public default DataStreamGenerator mapVectors(IgniteFunction<Vector, Vector> f) { DataStreamGenerator orig = this; return new DataStreamGenerator() { @Override public Stream<LabeledVector<Vector, Double>> labeled() { <START> return orig.labeled().map(v -> new LabeledVector<>(f.apply(v.features()), v.label())); <END> } }; }</code><technical_language>DataStreamGenerator.this.labeled()</technical_language>

Target:
public default DataStreamGenerator mapVectors(IgniteFunction<Vector, Vector> f) { return new DataStreamGenerator() { @Override public Stream<LabeledVector<Vector, Double>> labeled() { return DataStreamGenerator.this.labeled() .map(v -> new LabeledVector<>(f.apply(v.features()), v.label())); } }; }
Source:
<code>public List<ProgramState> constrain(ProgramState state, Constraint constraint) { ProgramState newState = state.constrainOwnSV(this, constraint); if (newState == null) { return ImmutableList.of(); } if (constraint.isStricterOrEqualTo(Constraint.TRUTHY)) { return checkRelationsAndConstrain(newState, relationWhenTrue); } else if (constraint.isStricterOrEqualTo(Constraint.FALSY)) { return checkRelationsAndConstrain(newState, relationWhenTrue.not()); } <START> return ImmutableList.of(state); <END> }</code><technical_language>newState</technical_language>

Target:
public List<ProgramState> constrain(ProgramState state, Constraint constraint) { ProgramState newState = state.constrainOwnSV(this, constraint); if (newState == null) { return ImmutableList.of(); } if (constraint.isStricterOrEqualTo(Constraint.TRUTHY)) { return checkRelationsAndConstrain(newState, relationWhenTrue); } else if (constraint.isStricterOrEqualTo(Constraint.FALSY)) { return checkRelationsAndConstrain(newState, relationWhenTrue.not()); } return ImmutableList.of(newState); }
Source:
<code>private static PlanFragment createBroadcastJoinPlanFragment(String name, PlanFragment buildFragment) { Symbol symbol = new Symbol("column"); PlanNode tableScan = new TableScanNode( new PlanNodeId(name), new TableHandle( new ConnectorId("test"), new TestingTableHandle(), TestingTransactionHandle.create(), <START> Optional.of(TestingHandle.INSTANCE)), <END> ImmutableList.of(symbol), ImmutableMap.of(symbol, new TestingColumnHandle("column"))); RemoteSourceNode remote = new RemoteSourceNode(new PlanNodeId("build_id"), buildFragment.getId(), ImmutableList.of(), Optional.empty(), REPLICATE); PlanNode join = new JoinNode( new PlanNodeId(name + "_id"), INNER, tableScan, remote, ImmutableList.of(), ImmutableList.<Symbol>builder() .addAll(tableScan.getOutputSymbols()) .addAll(remote.getOutputSymbols()) .build(), Optional.empty(), Optional.empty(), Optional.empty(), Optional.of(REPLICATED)); return createFragment(join); }</code><technical_language>I Optional.empty(), TableScanNode created a TableLayoutHandle. In general, TableScanNode.tableLayout == TableScanNode.table.layout deprecate in TableScanNode (I assume this is PR do later, I wrong...)</technical_language>

Target:
private static PlanFragment createBroadcastJoinPlanFragment(String name, PlanFragment buildFragment) { Symbol symbol = new Symbol("column"); PlanNode tableScan = new TableScanNode( new PlanNodeId(name), new TableHandle( new ConnectorId("test"), new TestingTableHandle(), TestingTransactionHandle.create(), Optional.empty()), ImmutableList.of(symbol), ImmutableMap.of(symbol, new TestingColumnHandle("column"))); RemoteSourceNode remote = new RemoteSourceNode(new PlanNodeId("build_id"), buildFragment.getId(), ImmutableList.of(), Optional.empty(), REPLICATE); PlanNode join = new JoinNode( new PlanNodeId(name + "_id"), INNER, tableScan, remote, ImmutableList.of(), ImmutableList.<Symbol>builder() .addAll(tableScan.getOutputSymbols()) .addAll(remote.getOutputSymbols()) .build(), Optional.empty(), Optional.empty(), Optional.empty(), Optional.of(REPLICATED)); return createFragment(join); }
Source:
<code>public HibernateErrorReportingServiceDao() { <START> this.errorOccurrenceConverter = new ErrorOccurrenceConverter(); <END> }</code><technical_language>I converter part of DAO. save single entity I suggest i move code Service layer</technical_language>

Target:
public HibernateErrorReportingServiceDao() { }
Source:
<code>public ExtensionListInfo(@Nonnull final IMAPResponse resp) throws ParsingException { super(resp); for (int i = 0; i < attrs.length; i++) { if (NON_EXISTENT.equalsIgnoreCase(attrs[i])) { <START> isNonExistent = true; <END> } else if (SUBSCRIBED.equalsIgnoreCase(attrs[i])) { isSubscribed = true; } else if (REMOTE.equalsIgnoreCase(attrs[i])) { isRemote = true; } else if (HAS_CHILDREN.equalsIgnoreCase(attrs[i])) { isHasChildren = true; } else if (HAS_NO_CHILDREN.equalsIgnoreCase(attrs[i])) { isHasNoChildren = true; } } }</code><technical_language>updated canOpen in parent class? I wanted set canOpen correctly. Also, please check if need 2 separate flags for hasChildren hasNoChildren</technical_language>

Target:
public ExtensionListInfo(@Nonnull final IMAPResponse resp) throws ParsingException { super(resp); final Set<ExtendedListAttribute> localSet = new HashSet<ExtendedListAttribute>(); for (int i = 0; i < attrs.length; i++) { if (ExtendedListAttribute.NON_EXISTENT.getValue().equalsIgnoreCase(attrs[i])) { localSet.add(ExtendedListAttribute.NON_EXISTENT); this.canOpen = false; } else if (ExtendedListAttribute.SUBSCRIBED.getValue().equalsIgnoreCase(attrs[i])) { localSet.add(ExtendedListAttribute.SUBSCRIBED); } else if (ExtendedListAttribute.REMOTE.getValue().equalsIgnoreCase(attrs[i])) { localSet.add(ExtendedListAttribute.REMOTE); } else if (ExtendedListAttribute.HAS_CHILDREN.getValue().equalsIgnoreCase(attrs[i])) { localSet.add(ExtendedListAttribute.HAS_CHILDREN); } else if (ExtendedListAttribute.HAS_NO_CHILDREN.getValue().equalsIgnoreCase(attrs[i])) { localSet.add(ExtendedListAttribute.HAS_NO_CHILDREN); } } extendedAttrs = Collections.unmodifiableSet(localSet); }
Source:
<code>public IStatus validate(@Nullable IProject project, @Nullable String path) { if (path == null) { return new Status(IStatus.ERROR, Activator.PLUGIN_ID, EMPTY_STRING); } Path filePath = checkNotNull(Paths.get(path)); <START> if (filePath.getFileName().toString().endsWith(PCAPNG_EXTENSION)) { try (PcapFile file = new PcapNgFile(filePath)) { } catch (IOException | BadPcapFileException e) { return new Status(IStatus.ERROR, Activator.PLUGIN_ID, e.toString()); } } else { try (PcapFile file = new PcapOldFile(filePath)) { } catch (IOException | BadPcapFileException e) { return new Status(IStatus.ERROR, Activator.PLUGIN_ID, e.toString()); } } <END> return new TraceValidationStatus(CONFIDENCE, Activator.PLUGIN_ID); }</code><technical_language>PcapHelper</technical_language>

Target:
public IStatus validate(@Nullable IProject project, @Nullable String path) { if (path == null) { return new Status(IStatus.ERROR, Activator.PLUGIN_ID, EMPTY_STRING); } Path filePath = checkNotNull(Paths.get(path)); try { fPcapFile = PcapHelper.getPcapFile(filePath); } catch (IOException | BadPcapFileException e) { return new Status(IStatus.ERROR, Activator.PLUGIN_ID, e.toString()); } return new TraceValidationStatus(CONFIDENCE, Activator.PLUGIN_ID); }
Source:
<code>private boolean assignTask(TaskWrapper taskWrapper) { try { WorkerWrapper workerWrapper; <START> if ((workerWrapper = findWorkerRunningTask(taskWrapper)) != null) { <END> final Worker worker = workerWrapper.getWorker(); log.info("Worker[%s] is already running task{%s].", worker.getHost(), taskWrapper.getTask().getId()); TaskStatus taskStatus = jsonMapper.readValue( cf.getData().forPath(JOINER.join(config.getStatusPath(), worker.getHost(), taskWrapper.getTask().getId())), TaskStatus.class ); if (taskStatus.isComplete()) { TaskCallback callback = taskWrapper.getCallback(); if (callback != null) { callback.notify(taskStatus); } new CleanupPaths(worker.getHost(), taskWrapper.getTask().getId()).run(); } else { tasks.put(taskWrapper.getTask().getId(), taskWrapper); } return true; } } catch (Exception e) { throw Throwables.propagate(e); } WorkerWrapper workerWrapper = getWorkerForTask(); if (workerWrapper != null) { announceTask(workerWrapper.getWorker(), taskWrapper); return true; } return false; }</code><technical_language>benefit of setting this if instead of declaration? I flow harder follow</technical_language>

Target:
private void assignTask(TaskWrapper taskWrapper) { WorkerWrapper workerWrapper = findWorkerRunningTask(taskWrapper); if (workerWrapper != null) { final Worker worker = workerWrapper.getWorker(); try { log.info("Worker[%s] is already running task[%s].", worker.getHost(), taskWrapper.getTask().getId()); TaskStatus taskStatus = jsonMapper.readValue( workerWrapper.getStatusCache() .getCurrentData( JOINER.join(config.getStatusPath(), worker.getHost(), taskWrapper.getTask().getId()) ) .getData(), TaskStatus.class ); if (taskStatus.isComplete()) { TaskCallback callback = taskWrapper.getCallback(); if (callback != null) { callback.notify(taskStatus); } new CleanupPaths(worker.getHost(), taskWrapper.getTask().getId()).run(); } } catch (Exception e) { log.error(e, "Task exists, but hit exception!"); retryTask(new CleanupPaths(worker.getHost(), taskWrapper.getTask().getId()), taskWrapper); } } else { workerWrapper = findWorkerForTask(); if (workerWrapper != null) { announceTask(workerWrapper.getWorker(), taskWrapper); } else { retryTask(null, taskWrapper); } } }
Source:
<code>public TimeZone getTimeZone(){ <START> return Strings.isNullOrEmpty(getString("secor.parser.timezone")) ? TimeZone.getTimeZone("UTC") : TimeZone.getTimeZone(getString("secor.parser.timezone")); <END> }</code><technical_language>This line is a bit long, break two? I of coding style 100 chars line width</technical_language>

Target:
public TimeZone getTimeZone() { String timezone = getString("secor.parser.timezone"); return Strings.isNullOrEmpty(timezone) ? TimeZone.getTimeZone("UTC") : TimeZone.getTimeZone(timezone); }
Source:
<code>static public junit.framework.Test suite() { VoltServerConfig config = null; MultiConfigSuiteBuilder builder = new MultiConfigSuiteBuilder( TestLongRunningReadQuery.class); VoltProjectBuilder project = new VoltProjectBuilder(); final String literalSchema = "CREATE TABLE R1 ( " + " ID BIGINT DEFAULT 0 NOT NULL);" + "" ; try { project.addLiteralSchema(literalSchema); } catch (IOException e) { assertFalse(true); } boolean success; <START> config = new LocalCluster("plansgroupby-onesite.jar", 1, 1, 0, BackendTarget.NATIVE_EE_JNI); <END> success = config.compile(project); assertTrue(success); builder.addServerConfig(config); return builder; }</code><technical_language>Minor: inappropriate dummy name: plansgroupby</technical_language>

Target:
static public junit.framework.Test suite() { VoltServerConfig config = null; MultiConfigSuiteBuilder builder = new MultiConfigSuiteBuilder( TestLongRunningReadQuery.class); VoltProjectBuilder project = new VoltProjectBuilder(); final String literalSchema = "CREATE TABLE R1 ( " + " ID BIGINT DEFAULT 0 NOT NULL);" + "" ; try { project.addLiteralSchema(literalSchema); } catch (IOException e) { assertFalse(true); } boolean success; config = new LocalCluster("longreads-onesite.jar", 1, 1, 0, BackendTarget.NATIVE_EE_JNI); success = config.compile(project); assertTrue(success); builder.addServerConfig(config); return builder; }