auphong2707/dl4se-code-review-dataset huggingface dataset:
Source:
<code>public Fake(final Request req, final String... dispositions) throws IOException { this.fake = new RqMultipart.Base( new RqFake( RqMultipart.Fake.convert(req.head()), <START> this.fakeBody(dispositions) <END> ) ); }</code><technical_language>this method is static? convert()</technical_language>

Target:
public Fake(final Request req, final String... dispositions) throws IOException { this.fake = new RqMultipart.Base( new Request() { @Override public Iterable<String> head() throws IOException { return new RqWithHeader( req, "Content-Type", String.format( "multipart/form-data; boundary=%s", BOUNDARY ) ).head(); } @Override public InputStream body() throws IOException { return RqMultipart.Fake.fakeBody(dispositions); } } ); }
Source:
<code>public void setRules(List<Rule> rules) { this.rules = rules; Set<String> streamIds = new HashSet<>(Collections2.transform(getOutputStreams(), new Function<Stream, String>() { @Nullable @Override public String apply(@Nullable Stream input) { return input.getId(); } })); for (Rule rule : rules) { for (Action action : rule.getActions()) { for (String stream : action.getOutputStreams()) { if(!streamIds.contains(stream)) { <START> throw new RuntimeException("Action's stream: "+stream+" does nto exist in processor's output streams"); <END> } } } } getConfig().setAny(CONFIG_KEY_RULES, rules); }</code><technical_language>typo: nto -> minor: re-format line in intellij</technical_language>

Target:
public void setRules(List<Rule> rules) { this.rules = rules; Set<String> streamIds = new HashSet<>(Collections2.transform(getOutputStreams(), new Function<Stream, String>() { @Nullable @Override public String apply(@Nullable Stream input) { return input.getId(); } })); for (Rule rule : rules) { for (Action action : rule.getActions()) { for (String stream : action.getOutputStreams()) { if(!streamIds.contains(stream)) { String errorMsg = String.format("Action [%s] stream [%s] does not exist in processor [%s]'s output streams [%s]", action, stream, getName(), streamIds); log.error(errorMsg); throw new IllegalArgumentException(errorMsg); } } } } getConfig().setAny(CONFIG_KEY_RULES, rules); }
Source:
<code>public void sawOpcode(int seen){ if(seen == Const.INVOKEVIRTUAL && ( <START> getNameConstantOperand().equals("getPackageName().equalsIgnoreCase") <END> )) { bugReporter.reportBug(new BugInstance(this,ANDROID_CASE_INSENSITIVE_PACKAGE_NAME_COMPARISON_TYPE,Priorities.NORMAL_PRIORITY) .addClass(this).addMethod(this).addSourceLine(this)); } }</code><technical_language>getNameConstantOperand().equals("getPackageName().equalsIgnoreCase") This work. operation INVOKEVIRTUAL, method called time. getNameConstantOperand().equals("equalsIgnoreCase")</technical_language>

Target:
public void sawOpcode(int seen){ if(seen == Const.INVOKEVIRTUAL && ( getNameConstantOperand().equals("getPackageName") && getNameConstantOperand().equals("equalsIgnoreCase") )) { bugReporter.reportBug(new BugInstance(this,ANDROID_CASE_INSENSITIVE_PACKAGE_NAME_COMPARISON_TYPE,Priorities.NORMAL_PRIORITY) .addClass(this).addMethod(this).addSourceLine(this)); } }
Source:
<code>public int getLightValue(IBlockAccess access, BlockPos pos) { Block blockInstance = getBlockInstance(access, new Vector3D(pos.getX(), pos.getY(), pos.getZ())); Optional<LightEmitter> opEmitter = blockInstance.components.getOp(LightEmitter.class); if (opEmitter.isPresent()) { <START> return (int) Math.min(0, Math.max(Math.round(opEmitter.get().emittedLevel.getAsDouble() * 15), 15)); <END> } else { return 0; } }</code><technical_language>MathUtil.clamp</technical_language>

Target:
public int getLightValue(IBlockAccess access, BlockPos pos) { Block blockInstance = getBlockInstance(access, new Vector3D(pos.getX(), pos.getY(), pos.getZ())); Optional<LightEmitter> opEmitter = blockInstance.components.getOp(LightEmitter.class); if (opEmitter.isPresent()) { return (int) MathUtil.clamp(Math.round(opEmitter.get().emittedLevel.getAsDouble() * 15), 0, 15); } else { return 0; } }
Source:
<code>public void onResponse(final List<T> data) { if (data.isEmpty()) { state.setValue(State.ENDED); } else { if (!isEmpty()) { <START> data.addAll(0, this.data.getValue()); <END> } this.data.setValue(data); state.setValue(State.FETCHED); } }</code><technical_language>appended beginning</technical_language>

Target:
public void onResponse(final List<T> data) { if (data.isEmpty()) { state.setValue(State.COMPLETED); } else { List<T> newData = this.data.getValue(); newData.addAll(data); this.data.setValue(newData); state.setValue(State.FETCH_COMPLETE); } }
Source:
<code>public void onAttach(@NotNull Context context) { super.onAttach(context); try { <START> listener = (AdminPasswordDialogListener) getActivity(); <END> } catch (ClassCastException e) { Timber.w(e); } }</code><technical_language>I feel more sense a instanceof check caching ClassCastException. This means get warnings if Fragment in contexts interested in listener (tests for instance)</technical_language>

Target:
public void onAttach(@NotNull Context context) { super.onAttach(context); if (context instanceof AdminPasswordDialogCallback) { callback = (AdminPasswordDialogCallback) context; } }
Source:
<code>public void submit(String eventBody) throws IOException { Socket socket = null; PrintStream output = null; try { socket = attach(); output = new PrintStream(socket.getOutputStream()); <START> output.print(eventBody + "\r\n"); <END> output.flush(); output.close(); socket.close(); } finally { if (output != null) { output.close(); } if (socket != null) { socket.close(); } } }</code><technical_language>This implementation forces single events submitted. I other SDKs allow _multiple_ events submitted submit methods. I check semantics consistent SDKs. Also, I recommend a PrintStream here. swallows IOExceptions. OutputStream.write work fine</technical_language>

Target:
public void submit(String eventBody) throws IOException { Socket socket = null; OutputStream output = null; try { socket = attach(); output = socket.getOutputStream(); output.write(eventBody.getBytes("UTF8")); output.flush(); output.close(); socket.close(); } finally { if (output != null) { output.close(); } if (socket != null) { socket.close(); } } }
Source:
<code>public static Dimension getBrowserSize() { String size = getProp("browserSize"); if (StringUtils.isNotBlank(size) || "max".equals(size) || size.split("x").length == 2) { if ("max".equals(size)) { <START> return null; <END> } else { return new Dimension(Integer.valueOf(size.split("x")[0]), Integer.valueOf(size.split("x")[1])); } } else { throw new WebDriverException("browser size: " + size + " is not a proper value"); } }</code><technical_language>null proper for maximised window, return calculated real dimensions? information is maximised window</technical_language>

Target:
public static Dimension getBrowserSize() { String size = getProp("browserSize"); if (StringUtils.isNotBlank(size) || "maximised".equals(size) || size.split("x").length == 2) { if ("maximised".equals(size)) { return null; } else { return new Dimension(Integer.valueOf(size.split("x")[0]), Integer.valueOf(size.split("x")[1])); } } else { throw new WebDriverException("browser size: " + size + " is not a proper value"); } }
Source:
<code>public void verifyCommentDeleted(String comment) { <START> if (commentTextList.isEmpty()) { <END> PageObjectLogging.log("verifyCommentDeleted", "comment: " + comment + " was deleted as no comments were found on the article", true); } else { PageObjectLogging.log("verifyCommentDeleted", "comments were found on the article, next step will make sure if comment: " + comment + " is not among them", true); for (WebElement elem : commentTextList) { Assertion.assertTrue(!comment.equals(elem.getText())); } } }</code><technical_language>1. will, line broken, 2. add a message assertTrue()</technical_language>

Target:
public void verifyCommentDeleted(String comment) { if (!commentTextList.isEmpty()) { for (WebElement elem : commentTextList) { Assertion.assertTrue(!comment.equals(elem.getText())); } } PageObjectLogging.log("verifyCommentDeleted", "comment " + comment + " was deleted", true); }
Source:
<code>public void run() { LOG.info("ForceWrite Thread started"); boolean shouldForceWrite = true; int numReqInLastForceWrite = 0; while (running) { ForceWriteRequest req = null; try { req = forceWriteRequests.take(); if (!req.isMarker) { if (shouldForceWrite) { if (enableGroupForceWrites) { forceWriteRequests.put(createForceWriteRequest(req.logFile, 0, 0, null, false, true)); } if (numReqInLastForceWrite > 0) { forceWriteGroupingCountStats.registerSuccessfulValue(numReqInLastForceWrite); numReqInLastForceWrite = 0; } } <START> numReqInLastForceWrite += req.process(shouldForceWrite); <END> } if (enableGroupForceWrites && !req.isMarker && !req.shouldClose) { shouldForceWrite = false; } else { shouldForceWrite = true; } } catch (IOException ioe) { LOG.error("I/O exception in ForceWrite thread", ioe); running = false; } catch (InterruptedException e) { LOG.error("ForceWrite thread interrupted", e); if (null != req) { req.shouldClose = true; req.closeFileIfNecessary(); } running = false; } finally { if (req != null) { req.recycle(); } } } threadToNotifyOnEx.interrupt(); }</code><technical_language>I changes in this file needed. merge</technical_language>

Target:
public void run() { LOG.info("ForceWrite Thread started"); boolean shouldForceWrite = true; int numReqInLastForceWrite = 0; while (running) { ForceWriteRequest req = null; try { req = forceWriteRequests.take(); if (!req.isMarker) { if (shouldForceWrite) { if (enableGroupForceWrites) { forceWriteRequests.put(createForceWriteRequest(req.logFile, 0, 0, null, false, true)); } if (numReqInLastForceWrite > 0) { forceWriteGroupingCountStats.registerSuccessfulValue(numReqInLastForceWrite); numReqInLastForceWrite = 0; } } } numReqInLastForceWrite += req.process(shouldForceWrite); if (enableGroupForceWrites && !req.isMarker && !req.shouldClose) { shouldForceWrite = false; } else { shouldForceWrite = true; } } catch (IOException ioe) { LOG.error("I/O exception in ForceWrite thread", ioe); running = false; } catch (InterruptedException e) { LOG.error("ForceWrite thread interrupted", e); if (null != req) { req.shouldClose = true; req.closeFileIfNecessary(); } running = false; } finally { if (req != null) { req.recycle(); } } } threadToNotifyOnEx.interrupt(); }
Source:
<code>void setUpTypeSpecificUIComponents() { promptTitle.setText( <START> Localization.get("apk.reinstall.needed.title", getCurrentClientName())); <END> actionButton.setText(Localization.get("apk.reinstall.action")); actionButton.setOnClickListener(v -> launchCurrentAppOnPlayStore()); imageCue.setVisibility(View.GONE); }</code><technical_language>I this needs a protected Localization call english fallback. Localization broken if app install is broken</technical_language>

Target:
void setUpTypeSpecificUIComponents() { promptTitle.setText(StringUtils.getStringRobust(this, R.string.reinstall_prompt_title, getCurrentClientName())); actionButton.setText(Localization.get("apk.reinstall.action")); actionButton.setOnClickListener(v -> launchCurrentAppOnPlayStore()); imageCue.setVisibility(View.GONE); }
Source:
<code>private StorageConnections mapCollection(List<StorageServerConnections> entities) { StorageConnections collection = new StorageConnections(); for (org.ovirt.engine.core.common.businessentities.StorageServerConnections entity : entities) { Storage connection = map(entity); if (connection != null) { <START> collection.getStorageConnections().add(connection); <END> } } return collection; }</code><technical_language>calling 'addLinks(populate(' entity adding, links call doPopulate() All-Content header request path</technical_language>

Target:
private StorageConnections mapCollection(List<StorageServerConnections> entities) { StorageConnections collection = new StorageConnections(); for (org.ovirt.engine.core.common.businessentities.StorageServerConnections entity : entities) { Storage connection = map(entity); if (connection != null) { collection.getStorageConnections().add(addLinks(connection)); } } return collection; }
Source:
<code>protected boolean validateSpaceRequirements() { if (!isStorageDomainSpaceWithinThresholds()) { return false; } getImage().getSnapshots().addAll(getAllImageSnapshots()); <START> if (!doesStorageDomainHaveSpaceForRequest(Math.round(getImage().getActualDiskWithSnapshotsSize()))) { <END> addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_DISK_SPACE_LOW); return false; } return true; }</code><technical_language>part of this patch, IMHO, pessimistic Math.ceil Math.round</technical_language>

Target:
protected boolean validateSpaceRequirements() { if (!isStorageDomainSpaceWithinThresholds()) { return false; } getImage().getSnapshots().addAll(getAllImageSnapshots()); if (!isDomainHasStorageSpaceForRequest()) { return false; } return true; }
Source:
<code><START> public Map<String,String> fetchVersionGET() <END> { return Collections.singletonMap("version", "1.0"); }</code><technical_language>I remember, returning a Map causing errors for swagger API client generator</technical_language>

Target:
public InfoServiceImpl.Version fetchVersionGET() { return infoService.getVersion(); }
Source:
<code>private Process createProcess() { Process process; try { <START> String command = "ps --no-headers -o rss " + getCurrentPid(); <END> ProcessBuilder builder = new ProcessBuilder().command("bash", "-c", command); process = builder.start(); } catch (IOException e) { throw new IllegalStateException("Error when starting the process.", e); } return process; }</code><technical_language>Do versions of ps support options? wondering this monitor work Linux</technical_language>

Target:
private Process createProcess() { try { return Runtime.getRuntime().exec("ps --no-headers -o rss " + Utils.getProcessID()); } catch (IOException e) { throw new IllegalStateException("Error when starting the process.", e); } }
Source:
<code>public MachineTreeNode(@Assisted MachineTreeNode parent, @Assisted("data") Object data, @Assisted Collection<MachineTreeNode> children) { this.parent = parent; this.data = data; this.children = children; boolean isMachine = data instanceof Machine; <START> id = isMachine ? ((Machine)data).getId() : ROOT; <END> name = isMachine ? ((Machine)data).getConfig().getName() : ROOT; }</code><technical_language>Ugly unconditional type casting, I significantly if check instance type throw warning/error/exception if suit logic instead of implicit type casting. sense for you</technical_language>

Target:
public MachineTreeNode(@Assisted MachineTreeNode parent, @Assisted("data") Object data, @Assisted Collection<MachineTreeNode> children) { this.parent = parent; this.data = data; this.children = children; if (data instanceof Machine) { Machine machine = (Machine)data; id = machine.getId(); name = machine.getConfig().getName(); } else { id = ROOT; name = ROOT; } }
Source:
<code>void initializeWebrtc(boolean videoEnabled) { RCLogger.i(TAG, "initializeWebrtc "); Context context = RCClient.getContext(); iceConnected = false; signalingParameters = null; scalingType = VideoRendererGui.ScalingType.SCALE_ASPECT_FILL; for (String permission : MANDATORY_PERMISSIONS) { if (context.checkCallingOrSelfPermission(permission) != PackageManager.PERMISSION_GRANTED) { logAndToast("Permission " + permission + " is not granted"); <START> listener.onPermissionNotGranted(this, permission); <END> return; } } if (videoEnabled) { for (String permission : MANDATORY_PERMISSIONS_VIDEO) { if (context.checkCallingOrSelfPermission(permission) != PackageManager.PERMISSION_GRANTED) { logAndToast("Permission " + permission + " is not granted"); listener.onPermissionNotGranted(this, permission); return; } } } peerConnectionParameters = new PeerConnectionClient.PeerConnectionParameters( videoEnabled, false, 0, 0, 0, 0, "VP8", true, 0, "OPUS", false, true); createPeerConnectionFactory(); }</code><technical_language>please add a new error code, PERMISSION_NOT_GRANTED_MANIFEST_ERROR differentiate error text audio video case</technical_language>

Target:
Status initializeWebrtc(boolean videoEnabled) { RCLogger.i(TAG, "initializeWebrtc "); Context context = RCClient.getContext(); iceConnected = false; signalingParameters = null; scalingType = VideoRendererGui.ScalingType.SCALE_ASPECT_FILL; for (String permission : MANDATORY_PERMISSIONS) { if (context.checkCallingOrSelfPermission(permission) != PackageManager.PERMISSION_GRANTED) { String errorText = "Permission " + permission + " is not granted"; logAndToast(errorText); listener.onDisconnected(this, RCClient.ErrorCodes.PERMISSION_NOT_GRANTED_ERROR.ordinal(), errorText); return Status.FAIL; } } if (videoEnabled) { for (String permission : MANDATORY_PERMISSIONS_VIDEO) { if (context.checkCallingOrSelfPermission(permission) != PackageManager.PERMISSION_GRANTED) { String errorText = "Permission " + permission + " is not granted"; logAndToast(errorText); listener.onDisconnected(this, RCClient.ErrorCodes.PERMISSION_NOT_GRANTED_ERROR.ordinal(), errorText); return Status.FAIL; } } } peerConnectionParameters = new PeerConnectionClient.PeerConnectionParameters( videoEnabled, false, 0, 0, 0, 0, "VP8", true, 0, "OPUS", false, true); createPeerConnectionFactory(); return Status.PASS; }
Source:
<code>private String nodeNamesMapper(final Node<View, Edge> node) { if (node.getContent().getDefinition() instanceof NamedElement) { <START> NamedElement namedElement = (NamedElement) node.getContent().getDefinition(); <END> return namedElement.getName().getValue(); } if (node.getContent().getDefinition() instanceof HasText) { HasText hasText = (HasText) node.getContent().getDefinition(); return hasText.getText().getValue(); } return null; }</code><technical_language>final</technical_language>

Target:
private String nodeNamesMapper(final Node<View, Edge> node) { if (node.getContent().getDefinition() instanceof NamedElement) { final NamedElement namedElement = (NamedElement) node.getContent().getDefinition(); return namedElement.getName().getValue(); } if (node.getContent().getDefinition() instanceof HasText) { final HasText textWrapper = (HasText) node.getContent().getDefinition(); return textWrapper.getText().getValue(); } return null; }
Source:
<code>synchronized IndexReference syncGetIndexSearcher( IndexIdentifier identifier ) { try { IndexReference indexReference = indexSearchers.get( identifier ); if ( indexReference == null ) { indexReference = indexReferenceFactory.createIndexReference( identifier ); indexSearchers.put( identifier, indexReference ); <START> HashMap<String,DocValuesType> fieldTypes = new HashMap<>(); <END> for ( LeafReaderContext leafReaderContext : indexReference.getSearcher().getTopReaderContext().leaves() ) { for ( FieldInfo fieldInfo : leafReaderContext.reader().getFieldInfos() ) { fieldTypes.put( fieldInfo.name, fieldInfo.getDocValuesType() ); } } indexTypeMap.put( identifier, fieldTypes ); } else { if ( !readOnly ) { synchronized ( indexReference ) { indexReference = refreshSearcherIfNeeded( indexReference ); } } } indexReference.incRef(); return indexReference; } catch ( IOException e ) { throw new RuntimeException( e ); } }</code><technical_language>mentioned earlier, some sort of conc. map</technical_language>

Target:
synchronized IndexReference syncGetIndexSearcher( IndexIdentifier identifier ) { try { IndexReference indexReference = indexSearchers.get( identifier ); if ( indexReference == null ) { indexReference = indexReferenceFactory.createIndexReference( identifier ); indexSearchers.put( identifier, indexReference ); ConcurrentHashMap<String,DocValuesType> fieldTypes = new ConcurrentHashMap<>(); for ( LeafReaderContext leafReaderContext : indexReference.getSearcher().getTopReaderContext().leaves() ) { for ( FieldInfo fieldInfo : leafReaderContext.reader().getFieldInfos() ) { fieldTypes.put( fieldInfo.name, fieldInfo.getDocValuesType() ); } } indexTypeMap.put( identifier, fieldTypes ); } else { if ( !readOnly ) { synchronized ( indexReference ) { indexReference = refreshSearcherIfNeeded( indexReference ); } } } indexReference.incRef(); return indexReference; } catch ( IOException e ) { throw new RuntimeException( e ); } }
Source:
<code>private void initFieldsMetaData(TypeSymbol classSymbol) { fieldsReadOnAnotherInstance = FieldsReadOnAnotherInstanceVisitor.getFrom(classSymbol); <START> for (Symbol memberSymbol : classSymbol.memberSymbols()) { <END> if (memberSymbol.isMethodSymbol() && memberSymbol.declaration() != null) { MethodTree methodTree = (MethodTree) memberSymbol.declaration(); if (methodTree.block() != null) { CFG cfg = CFG.build(methodTree); LiveVariables liveVariables = LiveVariables.analyze(cfg, true); fieldsLiveInMethodEntryPerMethod.put(methodTree, liveVariables.getIn(cfg.entry())); } } } }</code><technical_language>Styling : This expressed nicely streams classSymbol.memberSymbols().stream().filter(...).map( ms-> ms.declaration()).filter(..).forEach( //build CFG LVA etc);</technical_language>

Target:
private void initFieldsMetaData(TypeSymbol classSymbol) { fieldsReadOnAnotherInstance = FieldsReadOnAnotherInstanceVisitor.getFrom(classSymbol); for (Symbol memberSymbol : classSymbol.memberSymbols()) { if (memberSymbol.isMethodSymbol() && memberSymbol.declaration() != null) { MethodTree methodTree = (MethodTree) memberSymbol.declaration(); if (methodTree.block() != null) { CFG cfg = CFG.build(methodTree); LiveVariables liveVariables = LiveVariables.analyzeWithFields(cfg); fieldsLiveInMethodEntry.addAll(liveVariables.getIn(cfg.entry())); } } } }
Source:
<code>protected JdbcSourceConnectorConfig sourceConfigWithUrl( String url, String... propertyPairs ) { Map<String, String> connProps = new HashMap<>(); connProps.put(JdbcSourceConnectorConfig.MODE_CONFIG, JdbcSourceConnectorConfig.MODE_BULK); connProps.put(JdbcSourceConnectorConfig.TOPIC_PREFIX_CONFIG, "test-"); connProps.putAll(propertiesFromPairs(propertyPairs)); connProps.put(JdbcSourceConnectorConfig.CONNECTION_URL_CONFIG, url); <START> if (quoteTableNames != null) { <END> connProps.put( JdbcSourceConnectorConfig.QUOTE_TABLE_NAMES_CONFIG, quoteTableNames.toString() ); } if (quoteColumnNames != null) { connProps.put( JdbcSourceConnectorConfig.QUOTE_COLUMN_NAMES_CONFIG, quoteColumnNames.toString() ); } return new JdbcSourceConnectorConfig(connProps); }</code><technical_language>initialize Config objects default values in baseclass avoid protections</technical_language>

Target:
protected JdbcSourceConnectorConfig sourceConfigWithUrl( String url, String... propertyPairs ) { Map<String, String> connProps = new HashMap<>(); connProps.put(JdbcSourceConnectorConfig.MODE_CONFIG, JdbcSourceConnectorConfig.MODE_BULK); connProps.put(JdbcSourceConnectorConfig.TOPIC_PREFIX_CONFIG, "test-"); connProps.putAll(propertiesFromPairs(propertyPairs)); connProps.put(JdbcSourceConnectorConfig.CONNECTION_URL_CONFIG, url); if (quoteIdentfiiers != null) { connProps.put("quote.sql.identifiers", quoteIdentfiiers.toString()); } return new JdbcSourceConnectorConfig(connProps); }
Source:
<code>public Job copyAs(CopyRequest request) { <START> return execute(RefactoringJobs.COPY, request); <END> }</code><technical_language>If right fix method name is wrong</technical_language>

Target:
public Job copyAs(CopyRequest request) { return execute(RefactoringJobs.COPY_AS, request); }
Source:
<code>public void printCertificates() { DefaultTable table = new DefaultTable(); for (int i = 0; i < table.rowCount(); i++) { <START> System.out.println("On index " + i + " is : " + table.getItem(i).getText(1)); <END> } }</code><technical_language>logger instead for sysout for logging</technical_language>

Target:
public void printCertificates() { DefaultTable table = new DefaultTable(); for (int i = 0; i < table.rowCount(); i++) { log.info("On index " + i + " is : " + table.getItem(i).getText(1)); } }
Source:
<code>public ASTValue eval(WordsEnvironment environment) throws WordsRuntimeException { ASTValue referenceObject = children.get(0).eval(environment); ASTValue identifier = children.get(1).eval(environment); AST lengthExpression = children.get(2); ASTValue doNow = children.get(3) != null ? children.get(3).eval(environment) : null; WordsObject object; if (referenceObject.type.equals(ASTValue.ValueType.OBJ)){ WordsProperty property = referenceObject.objValue.getProperty(identifier.stringValue); if (property.type != WordsProperty.PropertyType.OBJECT) { throw new WordsInvalidTypeException(ASTValue.ValueType.OBJ.toString(), property.type.toString()); } object = property.objProperty; } else { object = environment.getObject(identifier.stringValue); } <START> if (object == null) { <END> throw new WordsObjectNotFoundException(identifier.stringValue); } WordsWait action = new WordsWait(lengthExpression); if (doNow == null) { object.enqueueAction(action); } else { object.enqueueActionAtFront(action); } return null; }</code><technical_language>This pattern of code lines 25:34 appears in places. open issue factor this out a separate method. (That need done this branch, address in next sprint.)</technical_language>

Target:
public ASTValue eval(WordsEnvironment environment) throws WordsRuntimeException { ASTValue referenceObject = children.get(0).eval(environment); ASTValue identifier = children.get(1).eval(environment); AST lengthExpression = children.get(2); ASTValue doNow = children.get(3) != null ? children.get(3).eval(environment) : null; WordsObject object; if (referenceObject.type.equals(ASTValue.ValueType.OBJ)){ WordsProperty property = referenceObject.objValue.getProperty(identifier.stringValue); if (property.type != WordsProperty.PropertyType.OBJECT) { throw new WordsInvalidTypeException(ASTValue.ValueType.OBJ.toString(), property.type.toString()); } object = property.objProperty; } else { object = environment.getObject(identifier.stringValue); } WordsWait action = new WordsWait(lengthExpression); if (doNow == null) { object.enqueueAction(action); } else { object.enqueueActionAtFront(action); } return null; }
Source:
<code>public void childContextAdded(VElement parentElement, EMFFormsViewContext childContext) { final EMFFormsSettingToControlMapper mapper = childContext.getService(EMFFormsSettingToControlMapper.class); <START> validate(getAllEObjectsToValidate(mapper)); <END> }</code><technical_language>root controlMapper instead</technical_language>

Target:
public void childContextAdded(VElement parentElement, EMFFormsViewContext childContext) { validate(getAllEObjectsToValidate()); }
Source:
<code>public void createInstantiator() { Instantiator<Object> objectInstantiator = new ObjectInstantiator(this, provider, parameterNameProvider); if (!instantiateNullParameters()) { <START> objectInstantiator = new NullDecorator(objectInstantiator); <END> } List<Instantiator<?>> instantiatorList = ImmutableList.of( new RequestAttributeInstantiator(request), new VRaptorTypeConverter(converters), FallbackConverter.fallbackToNull(new StringConverter()), new ArrayAdapter(new ArrayInstantiator(this)), new NullDecorator(new ListInstantiator(this)), new NullDecorator(new SetInstantiator(this)), new DependencyInstantiator(), objectInstantiator); multiInstantiator = new MultiInstantiator(instantiatorList); }</code><technical_language>smart :)</technical_language>

Target:
public void createInstantiator() { Instantiator<Object> objectInstantiator = new ObjectInstantiator(this, provider, parameterNameProvider); if (useNullForMissingParameters()) { objectInstantiator = new NullDecorator(objectInstantiator); } List<Instantiator<?>> instantiatorList = ImmutableList.of( new RequestAttributeInstantiator(request), new VRaptorTypeConverter(converters), FallbackConverter.fallbackToNull(new StringConverter()), new ArrayAdapter(new ArrayInstantiator(this)), new NullDecorator(new ListInstantiator(this)), new NullDecorator(new SetInstantiator(this)), new DependencyInstantiator(), objectInstantiator); multiInstantiator = new MultiInstantiator(instantiatorList); }
Source:
<code>public Optional<DeviceData> getMostRecent(final Long accountId, final String externalDeviceId, final DateTime maxTsLimit, final DateTime minTsLimit) { final Expression keyConditionExpression = Expressions.and( Expressions.equals(DeviceDataAttribute.ACCOUNT_ID, toAttributeValue(accountId)), Expressions.between(DeviceDataAttribute.RANGE_KEY, getRangeKey(minTsLimit, externalDeviceId), getRangeKey(maxTsLimit, externalDeviceId))); final Expression filterExpression = Expressions.contains(DeviceDataAttribute.RANGE_KEY, toAttributeValue(externalDeviceId)); final Collection<DeviceDataAttribute> attributes = ALL_ATTRIBUTES; final List<String> tableNames = getTableNames(minTsLimit, maxTsLimit); final Optional<Map<String, AttributeValue>> result = getLatest(tableNames, keyConditionExpression, filterExpression, attributes); if (result.isPresent()) { return Optional.of(attributeMapToDeviceData(result.get())); <START> } else { <END> return Optional.absent(); } }</code><technical_language>else needed here</technical_language>

Target:
public Optional<DeviceData> getMostRecent(final Long accountId, final String externalDeviceId, final DateTime maxTsLimit, final DateTime minTsLimit) { final Expression keyConditionExpression = Expressions.and( Expressions.equals(DeviceDataAttribute.ACCOUNT_ID, toAttributeValue(accountId)), Expressions.between(DeviceDataAttribute.RANGE_KEY, getRangeKey(minTsLimit, externalDeviceId), getRangeKey(maxTsLimit, externalDeviceId))); final Expression filterExpression = Expressions.contains(DeviceDataAttribute.RANGE_KEY, toAttributeValue(externalDeviceId)); final Collection<DeviceDataAttribute> attributes = ALL_ATTRIBUTES; final List<String> tableNames = getTableNames(minTsLimit, maxTsLimit); final Optional<Map<String, AttributeValue>> result = getLatest(tableNames, keyConditionExpression, filterExpression, attributes); if (result.isPresent()) { return Optional.of(attributeMapToDeviceData(result.get())); } return Optional.absent(); }
Source:
<code>public void addIssue() { <START> IssuesLabelService.addIssue(IssueLabelListActivity.this, getRootLayout(), mRepoOwner, mRepoName, mLabel.editedName, mLabel.editedColor) <END> .doOnError(error -> { mAdapter.remove(mAddedLabel); mAddedLabel = null; }) .subscribe(result -> { forceLoaderReload(0); mAddedLabel = null; setResult(RESULT_OK); }, e -> {}); }</code><technical_language>100 chars</technical_language>

Target:
private void addIssue() { IssuesLabelService.addIssue( IssueLabelListActivity.this, mRepoOwner, mRepoName, mLabel.editedName, mLabel.editedColor ).subscribe(result -> { forceLoaderReload(0); mAddedLabel = null; setResult(RESULT_OK); }, error -> { mAdapter.remove(mAddedLabel); mAddedLabel = null; }); }
Source:
<code>public void visitNode(Tree tree) { if (!hasSemantic()) { return; } ExpressionTree statement = ((ExpressionStatementTree) tree).expression(); if (statement.is(Kind.METHOD_INVOCATION)) { ExpressionTree methodSelect = ((MethodInvocationTree) statement).methodSelect(); if (methodSelect.is(Kind.MEMBER_SELECT)) { <START> MethodSymbol symbol = (MethodSymbol) getSemanticModel().getReference(((MemberSelectExpressionTree) methodSelect).identifier()); <END> if (symbol != null && symbol.owner().type().isSubtypeOf("java.io.InputStream") && (isRead(symbol) || isSkip(symbol))) { addIssue(methodSelect, "Check the return value of the \"" + symbol.name() + "\" call to see how many bytes were read."); } } } }</code><technical_language>need getSemanticModel getSymbol MethodInvocationTreeImpl (and upcoming symbol() method interface)</technical_language>

Target:
public void visitNode(Tree tree) { if (!hasSemantic()) { return; } ExpressionTree statement = ((ExpressionStatementTree) tree).expression(); if (statement.is(Kind.METHOD_INVOCATION)) { Symbol symbol = ((MethodInvocationTreeImpl) statement).getSymbol(); if (symbol.isMethodSymbol()) { checkMethod(statement, (MethodSymbol) symbol); } } }
Source:
<code>public void coverage() { FixedCouponBondTrade test1 = FixedCouponBondTrade.builder() .securityLink(SECURITY_LINK_RESOLVED) .tradeInfo(TRADE_INFO) .quantity(QUANTITY) .payment(UPFRONT_PAYMENT) .build(); coverImmutableBean(test1); FixedCouponBondTrade test2 = FixedCouponBondTrade.builder() .securityLink(SecurityLink.resolved(UnitSecurity.builder(PRODUCT) .standardId(StandardId.of("Ticker", "GOV1-BND1")) .build())) .quantity(100L) <START> .payment(Payment.of(CurrencyAmount.of(EUR, NOTIONAL * 0.05), SETTLEMENT_DATE)) <END> .build(); coverBeanEquals(test1, test2); }</code><technical_language>Tests realistic values: payment amount = -NOTIONAL \* QUANTITY \* 0.99 similar</technical_language>

Target:
public void coverage() { FixedCouponBondTrade test1 = FixedCouponBondTrade.builder() .securityLink(SECURITY_LINK_RESOLVED) .tradeInfo(TRADE_INFO) .quantity(QUANTITY) .payment(UPFRONT_PAYMENT) .build(); coverImmutableBean(test1); FixedCouponBondTrade test2 = FixedCouponBondTrade.builder() .securityLink(SecurityLink.resolved(UnitSecurity.builder(PRODUCT) .standardId(StandardId.of("Ticker", "GOV1-BND1")) .build())) .quantity(100L) .payment(Payment.of(CurrencyAmount.of(EUR, -NOTIONAL * QUANTITY * 0.99), SETTLEMENT_DATE)) .build(); coverBeanEquals(test1, test2); }
Source:
<code>public void elevatedAccessEvent(ElevatedAccessEvent elevatedAccessEvent) { ImmutableSet.Builder<ListenableFuture<Void>> builder = ImmutableSet.builder(); for (final SingularityEventSender eventListener : eventListeners) { builder.add( listenerExecutorService.submit( <START> new Callable<Void>() { <END> @Override public Void call() { eventListener.elevatedAccessEvent(elevatedAccessEvent); return null; } } ) ); } processFutures(builder.build()); }</code><technical_language>feel free change of lambdas too. of this is pre-java8 code is callables/runnables</technical_language>

Target:
public void elevatedAccessEvent(ElevatedAccessEvent elevatedAccessEvent) { ImmutableSet.Builder<ListenableFuture<Void>> builder = ImmutableSet.builder(); for (final SingularityEventSender eventListener : eventListeners) { builder.add( listenerExecutorService.submit( () -> { eventListener.elevatedAccessEvent(elevatedAccessEvent); return null; } ) ); } processFutures(builder.build()); }
Source:
<code>private static boolean isBinaryValid(CallExpression callExpression) { <START> return callExpression.getChildren().size() == 2 && ((callExpression.getChildren().get(0) instanceof FieldReferenceExpression && callExpression.getChildren().get(1) instanceof ValueLiteralExpression) || <END> (callExpression.getChildren().get(0) instanceof ValueLiteralExpression && callExpression.getChildren().get(1) instanceof FieldReferenceExpression)); }</code><technical_language>lines long... Line breaks appropriate</technical_language>

Target:
private static boolean isBinaryValid(CallExpression callExpression) { return callExpression.getChildren().size() == 2 && ( isRef(callExpression.getChildren().get(0)) && isLit(callExpression.getChildren().get(1)) || isLit(callExpression.getChildren().get(0)) && isRef(callExpression.getChildren().get(1)) ); }
Source:
<code><START> public Enum canOpen() { <END> if (isModified()) { int userChoice = JOptionPane.showConfirmDialog(this, "This document has been modified. Do you want to save it first?", "Save document", JOptionPane.YES_NO_CANCEL_OPTION, JOptionPane.QUESTION_MESSAGE); if (userChoice == JOptionPane.YES_OPTION) { return CanOpenState.SAVE_AND_OPEN; } else if (userChoice == JOptionPane.NO_OPTION) { return CanOpenState.OPEN; } else { return CanOpenState.CANCEL; } } else { return CanOpenState.OPEN; } }</code><technical_language>return CanOpenState, Enum</technical_language>

Target:
public UnsavedWorkState canOpen() { if (isModified() && !isPreviewDisplayed()) { int userChoice = JOptionPane.showConfirmDialog(this, "This document has been modified. Do you want to save it first?", "Save document", JOptionPane.YES_NO_CANCEL_OPTION, JOptionPane.QUESTION_MESSAGE); if (userChoice == JOptionPane.YES_OPTION) { return UnsavedWorkState.SAVE_AND_OPEN; } else if (userChoice == JOptionPane.NO_OPTION) { return UnsavedWorkState.OPEN; } else { return UnsavedWorkState.CANCEL; } } else { return UnsavedWorkState.OPEN; } }
Source:
<code>public void setupTestRepos() throws Exception { final RepositoryMock snapshotRepoMock = createSnapshotRepo(); final DefaultUnzipRepository unzipRepo = createUnzipRepo(snapshotRepoMock); snapshotRepoUnzipCache = unzipRepo.getCache(); <START> Assert.assertNotNull(snapshotRepoUnzipCache.getRepository().getRepositoryItemUidAttributeManager()); <END> oldZip = snapshotRepoUnzipCache.getArchive(PATH_TO_OLD_ZIP); Assert.assertNotNull(snapshotRepoUnzipCache.getRepository().getRepositoryItemUidAttributeManager()); oldOtherzip = snapshotRepoUnzipCache.getArchive(PATH_TO_OLD_OTHER_ZIP); latestOtherZip = snapshotRepoUnzipCache.getArchive(PATH_TO_LATEST_OTHER_ZIP); Assert.assertTrue(oldOtherzip.exists()); Assert.assertTrue(oldZip.exists()); Assert.assertTrue(latestOtherZip.exists()); }</code><technical_language>(minor) import static org.junit.Assert.* remove clutter minimize diff</technical_language>

Target:
public void setupTestRepos() throws Exception { final RepositoryMock snapshotRepoMock = createSnapshotRepo(); final DefaultUnzipRepository unzipRepo = createUnzipRepo(snapshotRepoMock); snapshotRepoUnzipCache = unzipRepo.getCache(); Assert.assertNotNull(snapshotRepoUnzipCache.repository.getRepositoryItemUidAttributeManager()); oldZip = snapshotRepoUnzipCache.getArchive(PATH_TO_OLD_ZIP); Assert.assertNotNull(snapshotRepoUnzipCache.repository.getRepositoryItemUidAttributeManager()); oldOtherzip = snapshotRepoUnzipCache.getArchive(PATH_TO_OLD_OTHER_ZIP); latestOtherZip = snapshotRepoUnzipCache.getArchive(PATH_TO_LATEST_OTHER_ZIP); Assert.assertTrue(oldOtherzip.exists()); Assert.assertTrue(oldZip.exists()); Assert.assertTrue(latestOtherZip.exists()); }
Source:
<code>protected void onActivityResult(int requestCode,int resultCode,Intent capturedData){ if(requestCode == REQUEST_IMAGE_CAPTURE && resultCode == RESULT_OK){ new CheckAvailableSpaceTask(getCapturedImageFile().getAbsolutePath()).execute(); } else if(requestCode == REQUEST_IMAGE_CAPTURE && resultCode == RESULT_CANCELED){ if(image != null){ image.delete(); <START> Log_OC.d(TAG,getResources().getString(R.string.file_deleted)); <END> } setResult(RESULT_CANCELED); finish(); } else if(resultCode == RESULT_CANCELED){ setResult(RESULT_CANCELED); finish(); } }</code><technical_language>do need create string resources (that automatically translated) log something, include string here</technical_language>

Target:
protected void onActivityResult(int requestCode,int resultCode,Intent capturedData){ if(requestCode == REQUEST_IMAGE_CAPTURE && resultCode == RESULT_OK){ new CheckAvailableSpaceTask(getCapturedImageFile().getAbsolutePath()).execute(); } else if(requestCode == REQUEST_IMAGE_CAPTURE && resultCode == RESULT_CANCELED){ if(image != null){ image.delete(); Log_OC.d(TAG,"File deleted"); } setResult(RESULT_CANCELED); finish(); } else if(resultCode == RESULT_CANCELED){ setResult(RESULT_CANCELED); finish(); } }
Source:
<code>private static GoAssignmentStatement getValidAssignmentParent(@Nullable PsiElement element) { return ObjectUtils.nullizeByCondition(PsiTreeUtil.getNonStrictParentOfType(element, GoAssignmentStatement.class), <START> assignment -> assignment == null || <END> !assignment.isValid() || !isAssignmentEqualsSized(assignment)); }</code><technical_language>I better: GoAssignmentStatement assignment = PsiTreeUtil.getNonStrictParentOfType(element, GoAssignmentStatement.class); return assignment != null && assignment.isValid() && isAssignmentEqualsSized(assignment) ? assignment : null; Please, lambdas if give some gain in readability</technical_language>

Target:
private static GoAssignmentStatement getValidAssignmentParent(@Nullable PsiElement element) { GoAssignmentStatement assignment = PsiTreeUtil.getNonStrictParentOfType(element, GoAssignmentStatement.class); return assignment != null && assignment.isValid() && isAssignmentEqualsSized(assignment) ? assignment : null; }
Source:
<code><START> public GraphService(Class<T> type) <END> { this.type = type; }</code><technical_language>this constructor protected</technical_language>

Target:
protected GraphService(Class<T> type) { this.type = type; }
Source:
<code>public void subscribe(Pattern pattern) { <START> delegate.subscribe(pattern, new ConsumerRebalanceListener() { <END> @Override public void onPartitionsRevoked(Collection<TopicPartition> partitions) @Override public void onPartitionsAssigned(Collection<TopicPartition> partitions) }); }</code><technical_language>in hind sight a constant avoid allocation call</technical_language>

Target:
public void subscribe(Pattern pattern) { delegate.subscribe(pattern, NO_OP_CONSUMER_REBALANCE_LISTENER); }
Source:
<code>@Override public void accept(List<Span> spans, final Callback<Void> callback) { StringBuilder request = new StringBuilder(); for (Span s : spans) { createSpanIndexRequest(s, request); } HttpEntity entity = new NStringEntity(request.toString(), ContentType.APPLICATION_JSON); <START> client.performRequest("POST", "/_bulk", Collections.<String, String>emptyMap(), entity, <END> new ResponseListener() { @Override public void onSuccess(Response response) { callback.onSuccess(null); } @Override public void onFailure(Exception e) { callback.onError(e); } }); }</code><technical_language>In order authenticate requests amazon locking security domain, need able add authentication header is a signature based request body. <LINK_1> <LINK_0></technical_language>

Target:
@Override public void accept(List<Span> spans, final Callback<Void> callback) { Buffer body = new Buffer(); try { for (Span s : spans) indexSpan(s, body); } catch (IOException e) { callback.onError(e); return; } Call post = client.newCall(new Request.Builder() .url(baseUrl.resolve("/_bulk")) .post(RequestBody.create(APPLICATION_JSON, body.readByteString())).build()); post.enqueue(new okhttp3.Callback() { @Override public void onFailure(Call call, IOException e) { callback.onError(e); } @Override public void onResponse(Call call, Response response){ if (ElasticsearchRestStorage.FLUSH_ON_WRITES) { try { client.newCall(flushRequest).execute(); } catch (IOException e) { callback.onError(e); return; } } callback.onSuccess(null); } }); }
Source:
<code><START> public SpliceSchemaWatcher(String dbName, String schemaName) { <END> this.dbName = dbName; this.schemaName = schemaName.toUpperCase(); }</code><technical_language>original constructor SpliceSchemaWatcher(String schemaName call SpliceSchemaWatcher(null, schemaName)? avoid touching ITs</technical_language>

Target:
public SpliceSchemaWatcher(String dbName, String schemaName) { this(schemaName); this.dbName = dbName; }
Source:
<code>private void transitionTo(String name, Application.Status status) { <START> Application target = applications.get(name); <END> LOG.info("Transitioning '{}' application from to {}", name, target.getStatus(), status); boolean replaced = applications.replace(name, target, target.transitionTo(status)); if (!replaced) { throw new ConcurrentModificationException("Unable to transition '" + name + "' application to " + status); } }</code><technical_language>guard null, throw exception missing name NPE</technical_language>

Target:
private void transitionTo(String name, Application.Status status) { Application target = checkNotNull(applications.get(name), "No application found with name '%'", name); LOG.info("Transitioning '{}' application from to {}", name, target.getStatus(), status); boolean replaced = applications.replace(name, target, target.transitionTo(status)); if (!replaced) { throw new ConcurrentModificationException("Unable to transition '" + name + "' application to " + status); } }
Source:
<code>protected String[] fillTypeCombo() { <START> ArrayList<String> <END> list = new ArrayList<>(); for(DataType dataType : DataTypeLibrary.getInstance().getDataTypesSorted()){ list.add(dataType.getName()); } return list.toArray(new String[0]); }</code><technical_language>change interface list</technical_language>

Target:
protected String[] fillTypeCombo() { List<String> list = new ArrayList<>(); for(DataType dataType : DataTypeLibrary.getInstance().getDataTypesSorted()){ list.add(dataType.getName()); } return list.toArray(new String[0]); }
Source:
<code>protected void executeQueryCommand() { Provider hostProvider = getProvider(); <START> HostProviderProxy proxy = ((HostProviderProxy) ProviderProxyFactory.getInstance().create(hostProvider)); <END> getQueryReturnValue().setReturnValue(chainToString(proxy.getCertificateChain())); }</code><technical_language>do cast HostProviderProxy</technical_language>

Target:
protected void executeQueryCommand() { Provider hostProvider = getProvider(); HostProviderProxy proxy = ProviderProxyFactory.getInstance().create(hostProvider); getQueryReturnValue().setReturnValue(chainToString(proxy.getCertificateChain())); }
Source:
<code>public synchronized void addReferencePointResources( Map<IReferencePoint, List<IResource>> referencePointResourcesMapping) { if (referencePointResourcesMapping == null) { return; } Map<IReferencePoint, List<IResource>> referencePointMapping = new HashMap<>(); <START> for (Map.Entry<IReferencePoint, List<IResource>> entry : <END> referencePointResourcesMapping.entrySet()) { referencePointMapping.put(entry.getKey(), entry.getValue()); } nextProjectNegotiation.add(referencePointMapping); if (nextProjectNegotiationWorker != null && nextProjectNegotiationWorker.isAlive()) { return; } else if (currentProjectNegotiations.isEmpty()) { startNextProjectNegotiation(); return; } Runnable worker = new Runnable() { @Override public void run() { synchronized (nextProjectNegotiation) { while (!currentProjectNegotiations.isEmpty()) { try { nextProjectNegotiation.wait(); } catch (InterruptedException e) { Thread.currentThread().interrupt(); return; } } } startNextProjectNegotiation(); } }; nextProjectNegotiationWorker = ThreadUtils.runSafeAsync(log, worker); }</code><technical_language>Minor - forEach iterate map. This easier, especially in this case a method reference instead of a lambda expression. loop replaced a single line: Java referencePointResourcesMapping.forEach(referencePointMapping::put);</technical_language>

Target:
public synchronized void addReferencePointResources( Map<IReferencePoint, List<IResource>> referencePointResourcesMapping) { if (referencePointResourcesMapping == null) { return; } nextProjectNegotiation.add(referencePointResourcesMapping); if (nextProjectNegotiationWorker != null && nextProjectNegotiationWorker.isAlive()) { return; } else if (currentProjectNegotiations.isEmpty()) { startNextProjectNegotiation(); return; } Runnable worker = new Runnable() { @Override public void run() { synchronized (nextProjectNegotiation) { while (!currentProjectNegotiations.isEmpty()) { try { nextProjectNegotiation.wait(); } catch (InterruptedException e) { Thread.currentThread().interrupt(); return; } } } startNextProjectNegotiation(); } }; nextProjectNegotiationWorker = ThreadUtils.runSafeAsync(log, worker); }
Source:
<code>public void canHandleDuplicateQueries() { writeToLogs(1, 100); int minLastVerified = 27; List<HistoryQuery> queries = IntStream.range(0, 10) .boxed() <START> .map(idx -> HistoryQuery.of(NAMESPACE_AND_USE_CASE, minLastVerified + idx, minLastVerified + 500)) <END> .collect(Collectors.toList()); List<LogsForNamespaceAndUseCase> paxosHistory = HistoryLoaderAndTransformer.getLogsForHistoryQueries(history, queries); sanityCheckLoadedHistory(paxosHistory, 100 - minLastVerified + 1); }</code><technical_language>reference this 500 constant somewhere</technical_language>

Target:
public void canHandleDuplicateQueries() { writeToLogs(1, 100); int minLastVerified = 27; List<HistoryQuery> queries = IntStream.range(0, 10) .boxed() .map(idx -> HistoryQueries.unboundedHistoryQuerySinceSeq(minLastVerified)) .collect(Collectors.toList()); List<LogsForNamespaceAndUseCase> paxosHistory = HistoryLoaderAndTransformer.getLogsForHistoryQueries(history, queries); sanityCheckLoadedHistory(paxosHistory, 100 - minLastVerified + 1); }