auphong2707/dl4se-code-review-dataset huggingface dataset:
Source:
<code>CellData format(Project project, Column column, Cell cell) { if (cell != null) { String link = null; String text = null; if (cell.recon != null) { Recon recon = cell.recon; if (recon.judgment == Recon.Judgment.Matched) { if (recon_outputMode == ReconOutputMode.ENTITY_NAME) { text = recon.match.name; } else if (recon_outputMode == ReconOutputMode.ENTITY_ID) { text = recon.match.id; } if (recon_linkToEntityPages) { buildIdentifierSpaceToUrlMap(); String service = recon.service; String viewUrl = identifierSpaceToUrl.get(service); if (viewUrl != null) { link = StringUtils.replace(viewUrl, "{{id}}", recon.match.id); } } } else if (recon_blankUnmatchedCells) { return null; } } Object value = cell.value; if (value != null) { if (text == null) { if (value instanceof String) { text = (String) value; if(text.contains(":")) { try { <START> link = new URL(text).toString(); <END> } catch (MalformedURLException e) { } } } else if (value instanceof OffsetDateTime) { text = ((OffsetDateTime) value).format(DateTimeFormatter.ISO_INSTANT); } else { text = value.toString(); } } return new CellData(column.getName(), value, text, link); } }else { if(includeNullFieldValue) { return new CellData(column.getName(), "", "", ""); } } return null; }</code><technical_language>check if text is a valid URL other converting string</technical_language>

Target:
CellData format(Project project, Column column, Cell cell) { if (cell != null) { String link = null; String text = null; if (cell.recon != null) { Recon recon = cell.recon; if (recon.judgment == Recon.Judgment.Matched) { if (recon_outputMode == ReconOutputMode.ENTITY_NAME) { text = recon.match.name; } else if (recon_outputMode == ReconOutputMode.ENTITY_ID) { text = recon.match.id; } if (recon_linkToEntityPages) { buildIdentifierSpaceToUrlMap(); String service = recon.service; String viewUrl = identifierSpaceToUrl.get(service); if (viewUrl != null) { link = StringUtils.replace(viewUrl, "{{id}}", recon.match.id); } } } else if (recon_blankUnmatchedCells) { return null; } } Object value = cell.value; if (value != null) { if (text == null) { if (value instanceof String) { text = (String) value; if(text.contains(":")) { if(urlValidator.isValid(text)) { link = text; } } } else if (value instanceof OffsetDateTime) { text = ((OffsetDateTime) value).format(DateTimeFormatter.ISO_INSTANT); } else { text = value.toString(); } } return new CellData(column.getName(), value, text, link); } }else { if(includeNullFieldValue) { return new CellData(column.getName(), "", "", ""); } } return null; }
Source:
<code>private void addOpenWals(ServerContext c, Set<String> allWalsSeen) throws Exception { int open = 0; int attempts = 0; boolean foundWal = false; while (open == 0) { attempts++; Map<String,WalState> wals = WALSunnyDayIT._getWals(c); Set<Entry<String,WalState>> es = wals.entrySet(); for (Entry<String,WalState> entry : es) { if (entry.getValue() == WalState.OPEN) { open++; allWalsSeen.add(entry.getKey()); foundWal = true; } else { log.error("The WalState is " + entry.getValue()); } } if (!foundWal) { Thread.sleep(50); if (attempts % 50 == 0) log.info("Has not found an open WAL in " + attempts + " attempts."); } } <START> log.debug("It took " + attempts + " attempt(s) to find an open WAL"); <END> assertTrue("Open WALs not in expected range " + open, open > 0 && open < 4); }</code><technical_language>suggestion log.debug("It attempt(s) find open WALs", attempts, open);</technical_language>

Target:
private void addOpenWals(ServerContext c, Set<String> allWalsSeen) throws Exception { int open = 0; int attempts = 0; boolean foundWal = false; while (open == 0) { attempts++; Map<String,WalState> wals = WALSunnyDayIT._getWals(c); Set<Entry<String,WalState>> es = wals.entrySet(); for (Entry<String,WalState> entry : es) { if (entry.getValue() == WalState.OPEN) { open++; allWalsSeen.add(entry.getKey()); foundWal = true; } else { log.debug("The WalState for is {}", entry.getKey(), entry.getValue()); } } if (!foundWal) { Thread.sleep(50); if (attempts % 50 == 0) log.debug("No open WALs found in attempts.", attempts); } } log.debug("It took attempt(s) to find open WALs", attempts, open); assertTrue("Open WALs not in expected range " + open, open > 0 && open < 4); }
Source:
<code>protected void checkVdsActivateSucceeded(final GuideModel guideModel, final String searchStr) { Frontend.getInstance().runQuery(VdcQueryType.Search, new SearchParameters(searchStr, SearchType.VDS), new AsyncQuery(this, new INewAsyncCallback() { @Override public void onSuccess(Object target, Object returnValue) { <START> ArrayList<VDS> hosts = ((VdcQueryReturnValue) returnValue).getReturnValue(); <END> boolean succeeded = true; for (VDS host : hosts) { if (host.getStatus() != VDSStatus.Up) { succeeded = false; } } guideModel.getWindow().stopProgress(); guideModel.cancel(); if (succeeded) { guideModel.postAction(); } else { errorPopupManager.show(ConstantsManager.getInstance().getConstants().hostActivationTimeOut()); } } })); }</code><technical_language>This a List</technical_language>

Target:
protected void checkVdsActivateSucceeded(final GuideModel guideModel, final String searchStr) { Frontend.getInstance().runQuery(VdcQueryType.Search, new SearchParameters(searchStr, SearchType.VDS), new AsyncQuery(this, new INewAsyncCallback() { @Override public void onSuccess(Object target, Object returnValue) { List<VDS> hosts = ((VdcQueryReturnValue) returnValue).getReturnValue(); boolean succeeded = true; for (VDS host : hosts) { if (host.getStatus() != VDSStatus.Up) { succeeded = false; } } guideModel.getWindow().stopProgress(); guideModel.cancel(); if (succeeded) { guideModel.postAction(); } else { errorPopupManager.show(ConstantsManager.getInstance().getConstants().hostActivationTimeOut()); } } })); }
Source:
<code>private void commitUpTo(long checkpointId) throws Exception { final Iterator<Map.Entry<Long, List<CommT>>> it = committablesPerCheckpoint.headMap(checkpointId, true).entrySet().iterator(); while (it.hasNext()) { final Map.Entry<Long, List<CommT>> entry = it.next(); <START> final List<CommT> neededToRetryCommittables = committer.commit(entry.getValue()); <END> if (!neededToRetryCommittables.isEmpty()) { throw new UnsupportedOperationException("Currently does not support the re-commit!"); } for (CommT committable : entry.getValue()) { output.collect(new StreamRecord<>(committable)); } it.remove(); } }</code><technical_language>Remove this empty line</technical_language>

Target:
private void commitUpTo(long checkpointId) throws Exception { final Iterator<Map.Entry<Long, List<CommT>>> it = committablesPerCheckpoint.headMap(checkpointId, true).entrySet().iterator(); final List<CommT> readyCommittables = new ArrayList<>(); while (it.hasNext()) { final Map.Entry<Long, List<CommT>> entry = it.next(); final List<CommT> committables = entry.getValue(); readyCommittables.addAll(committables); it.remove(); } LOG.info("Committing the state for checkpoint {}", checkpointId); final List<CommT> neededToRetryCommittables = commit(readyCommittables); if (!neededToRetryCommittables.isEmpty()) { throw new UnsupportedOperationException("Currently does not support the re-commit!"); } for (CommT committable : readyCommittables) { output.collect(new StreamRecord<>(committable)); } }
Source:
<code>NormalizeFunction getNormalizeFunction() { <START> return score -> (score == 0f? 1f: (float) Math.tanh(1 / (score * this.alpha))); <END> }</code><technical_language>assume soft constraints this formula? I fit partition movement constraint. suggestion is that, scale (max min), change constraints individually calculating percentage. applicable ones</technical_language>

Target:
NormalizeFunction getNormalizeFunction() { return score -> (score == 0f ? 1f : (float) Math.tanh(1 / (_alpha * score))); }
Source:
<code>public void onEvent(WorkspaceStatusEvent event) { String workspaceId = event.getWorkspaceId(); if (WorkspaceStatusEvent.EventType.STOPPED.equals(event.getEventType())) { workspaceOwners.remove(workspaceId); while (userIdToWorkspaces.values().remove(workspaceId)) } if (WorkspaceStatusEvent.EventType.STARTING.equals(event.getEventType())) { Subject subject = EnvironmentContext.getCurrent().getSubject(); if (subject == Subject.ANONYMOUS) { <START> LOG.warn("Workspace is being started by the 'anonymous' user.", workspaceId); <END> return; } userIdToWorkspaces.put(subject.getUserId(), workspaceId); updateSubject(subject); } }</code><technical_language>This case is impossible AFAIK. throw error instead</technical_language>

Target:
public void onEvent(WorkspaceStatusEvent event) { String workspaceId = event.getWorkspaceId(); if (WorkspaceStatusEvent.EventType.STOPPED.equals(event.getEventType())) { while (userIdToWorkspaces.values().remove(workspaceId)) workspaceOwners.remove(workspaceId); } if (WorkspaceStatusEvent.EventType.STARTING.equals(event.getEventType())) { Subject subject = EnvironmentContext.getCurrent().getSubject(); if (subject == Subject.ANONYMOUS) { throw new IllegalStateException( "Workspace " + workspaceId + " is being started by the 'Anonymous' user.\n" + "This shouldn't happen, and workspaces should always be created by a real user."); } userIdToWorkspaces.put(subject.getUserId(), workspaceId); updateSubject(subject); } }
Source:
<code>public boolean canStart(String line, int lineOffset) { blockLineCount = 0; matcher = START_PATTERN.matcher(line); if (lineOffset > 0) { <START> if (ParagraphBlock.startPattern.matcher(line).region(0, lineOffset).matches()) { return false; } <END> matcher.region(lineOffset, line.length()); } if (matcher.matches()) { return true; } matcher = null; return false; }</code><technical_language>do need check paragraph start pattern here? This wrong approach me, introduces unnecessary coupling ParagraphBlock DefinitionListBlock</technical_language>

Target:
public boolean canStart(String line, int lineOffset) { blockLineCount = 0; matcher = START_PATTERN.matcher(line); if (lineOffset > 0) { matcher.region(lineOffset, line.length()); } if (matcher.matches()) { return true; } matcher = null; return false; }
Source:
<code>public String getChangeDescription() { <START> if (UtilMethods.isSet(this.changeDescription) && this.changeDescription.trim().startsWith("{")) { <END> return(String) this.getChangeMap().get("description"); } return this.changeDescription; }</code><technical_language>I StringUtils.isJson method. needs a null check a trim() good have</technical_language>

Target:
public String getChangeDescription() { if (UtilMethods.isSet(this.changeDescription) && StringUtils.isJson(this.changeDescription.trim())) { return(String) this.getChangeMap().get("description"); } return this.changeDescription; }
Source:
<code>protected void doFilterInternal(HttpServletRequest request, HttpServletResponse response, FilterChain filterChain) throws ServletException, IOException { <START> final String xForwardedProto = request.getHeader("X-Forwarded-Proto"); <END> final String xForwardedFor = request.getHeader("X-Forwarded-For"); if (xForwardedProto != null) { swaggerProtocol = xForwardedProto; } if (xForwardedFor != null) { swaggerPort = xForwardedFor; } logger.debug("swagger.protocol: {}", swaggerProtocol); logger.debug("swagger.port: {}", swaggerPort); URL requestUrl = new URL(request.getRequestURL().toString()); logger.debug("Swagger filter triggered by '{}: {}'. Request will be redirected to swagger page", request.getMethod(), requestUrl); String swaggerJsonUrl = String.format("%s://%s:%s%s%s/swagger.json", swaggerProtocol, requestUrl.getHost(), swaggerPort, request.getContextPath(), JerseyConfig.REST_PATH); String url = request.getContextPath() + "/swagger.html?url=" + swaggerJsonUrl; logger.debug("Request is being redirected to '{}'", url); response.sendRedirect(url); }</code><technical_language>move strings variables? reuse</technical_language>

Target:
protected void doFilterInternal(HttpServletRequest request, HttpServletResponse response, FilterChain filterChain) throws ServletException, IOException { final String xForwardedProto = request.getHeader(X_FORWARDED_PROTO_HEADER_NAME); final String xForwardedPort = request.getHeader(X_FORWARDED_PORT_HEADER_NAME); if (xForwardedProto != null) { swaggerProtocol = xForwardedProto; } if (xForwardedPort != null) { swaggerPort = xForwardedPort; } logger.debug("swagger.protocol: {}", swaggerProtocol); logger.debug("swagger.port: {}", swaggerPort); URL requestUrl = new URL(request.getRequestURL().toString()); logger.debug("Swagger filter triggered by '{}: {}'. Request will be redirected to swagger page", request.getMethod(), requestUrl); String swaggerJsonUrl = String.format("%s://%s:%s%s%s/swagger.json", swaggerProtocol, requestUrl.getHost(), swaggerPort, request.getContextPath(), JerseyConfig.REST_PATH); String url = request.getContextPath() + "/swagger.html?url=" + swaggerJsonUrl; logger.debug("Request is being redirected to '{}'", url); response.sendRedirect(url); }
Source:
<code>public static void copyFile(File from, File to) { try (InputStream in = new FileInputStream(from)) { to.getParentFile().mkdirs(); <START> try (OutputStream out = new FileOutputStream(to)) { <END> byte[] buf = new byte[1024]; int len; while ((len = in.read(buf)) > 0) { out.write(buf, 0, len); } } } catch(IOException e){ e.printStackTrace(); } }</code><technical_language>try-with-resources block for in out</technical_language>

Target:
public static void copyFile(File from, File to) { to.getParentFile().mkdirs(); try (InputStream in = new FileInputStream(from); OutputStream out = new FileOutputStream(to)) { byte[] buf = new byte[1024]; int len; while ((len = in.read(buf)) > 0) { out.write(buf, 0, len); } } catch(IOException e){ e.printStackTrace(); } }
Source:
<code>protected String requestString() { try { return objectMapper.writeValueAsString(parameter); } <START> catch (JsonProcessingException e) { <END> return ""; } }</code><technical_language>log exception. in understanding wrong here</technical_language>

Target:
protected String requestString() { try { return objectMapper.writeValueAsString(parameter); } catch (JsonProcessingException e) { logger.error("Error serializing request: ", e); return ""; } }
Source:
<code><START> public String generateReport() { <END> return "Generated JSON representations of "+processed+" documents from a total of "+this.filelist.size()+" documents."; }</code><technical_language>Ideally, this method generates a report includes counts of annotations generated (e.g. # of NEs of type; # of coref constituents # of gold coref arcs) a summary of errors encountered (most important, # of files read -- if -- names). goal is allow users accurately compute performance, accounting for annotations read all</technical_language>

Target:
public String generateReport() { StringBuffer sb = new StringBuffer("Generated JSON representations of "+processed+ " documents from a total of "+this.filelist.size()+" document\n"); sb.append("Of the documents, "+this.badFiles.size()+" files could not be parsed, they are as follows:\n"); for (String badfile : this.badFiles) { sb.append(" "+badfile+"\n"); } return sb.toString(); }
Source:
<code>protected AbstractAsyncKeyValueStore() { executor = new ThreadPoolExecutor(1, Runtime.getRuntime().availableProcessors() * 10, 60, TimeUnit.SECONDS, new SynchronousQueue<>(), <START> r -> new Thread(r, "kvstore-async-thread"), <END> new ThreadPoolExecutor.CallerRunsPolicy()); }</code><technical_language>nice give threads unique names. Guava's ThreadFactoryBuilder this for other thread pools</technical_language>

Target:
protected AbstractAsyncKeyValueStore() { executor = new ThreadPoolExecutor(1, Runtime.getRuntime().availableProcessors() * 10, 60, TimeUnit.SECONDS, new SynchronousQueue<>(), new ThreadFactoryBuilder().setNameFormat("kvstore-async-thread-%d").build(), new ThreadPoolExecutor.CallerRunsPolicy()); }
Source:
<code>public Semaphore getActivesSemaphore(int maxThreadNum) { <START> if(maxThreadNum <= 0) { <END> return null; } if (activesLimit == null || activesPermits != maxThreadNum) { synchronized (this) { if (activesLimit == null || activesPermits != maxThreadNum) { activesLimit = new Semaphore(maxThreadNum); activesPermits = maxThreadNum; } } } return activesLimit; }</code><technical_language>format code, pls</technical_language>

Target:
public Semaphore getActivesSemaphore(int maxThreadNum) { if (activesLimit == null || activesPermits != maxThreadNum) { synchronized (this) { if (activesLimit == null || activesPermits != maxThreadNum) { activesLimit = new Semaphore(maxThreadNum); activesPermits = maxThreadNum; } } } return activesLimit; }
Source:
<code>public void testRebalance() throws IOException, HelixRebalanceException, JMException { _metadataStore.clearMetadataStore(); <START> WagedRebalancer rebalancer = new WagedRebalancer(_metadataStore, _algorithm, null); <END> ResourceControllerDataProvider clusterData = setupClusterDataCache(); Map<String, Resource> resourceMap = clusterData.getIdealStates().entrySet().stream() .collect(Collectors.toMap(entry -> entry.getKey(), entry -> { Resource resource = new Resource(entry.getKey()); entry.getValue().getPartitionSet().stream() .forEach(partition -> resource.addPartition(partition)); return resource; })); Map<String, IdealState> newIdealStates = rebalancer.computeNewIdealStates(clusterData, resourceMap, new CurrentStateOutput()); Map<String, ResourceAssignment> algorithmResult = _algorithm.getRebalanceResult(); validateRebalanceResult(resourceMap, newIdealStates, algorithmResult); }</code><technical_language>usage, if test code is passing null, remove this parameter this constructor</technical_language>

Target:
public void testRebalance() throws IOException, HelixRebalanceException { _metadataStore.clearMetadataStore(); WagedRebalancer rebalancer = new WagedRebalancer(_metadataStore, _algorithm, new DelayedAutoRebalancer()); ResourceControllerDataProvider clusterData = setupClusterDataCache(); Map<String, Resource> resourceMap = clusterData.getIdealStates().entrySet().stream() .collect(Collectors.toMap(entry -> entry.getKey(), entry -> { Resource resource = new Resource(entry.getKey()); entry.getValue().getPartitionSet().stream() .forEach(partition -> resource.addPartition(partition)); return resource; })); Map<String, IdealState> newIdealStates = rebalancer.computeNewIdealStates(clusterData, resourceMap, new CurrentStateOutput()); Map<String, ResourceAssignment> algorithmResult = _algorithm.getRebalanceResult(); validateRebalanceResult(resourceMap, newIdealStates, algorithmResult); }
Source:
<code>public boolean internalHasNext() { try { while (leftRS.hasNext()) { if (left == null) left = leftRS.next().getClone(); else left.transfer(leftRS.next()); <START> left = leftRS.next(); <END> currentRightIterator = rightsForLeft(left); boolean returnedRows = false; while (currentRightIterator.hasNext()) { currentExecRow = mergeRows(left, currentRightIterator.next()); if (mergeJoinOperation.getRestriction().apply(currentExecRow)) { returnedRows = true; break; } operationContext.recordFilter(); } if (!returnedRows) { currentExecRow = mergeRows(left, null); return true; } } return false; } catch (Exception e) { throw new RuntimeException(e); } }</code><technical_language>This line removed. pass I guess this is covered test, write a quick John</technical_language>

Target:
public boolean internalHasNext() { try { while (leftRS.hasNext()) { if (left == null) left = leftRS.next().getClone(); else left.transfer(leftRS.next()); currentRightIterator = rightsForLeft(left); boolean returnedRows = false; while (currentRightIterator.hasNext()) { currentExecRow = mergeRows(left, currentRightIterator.next()); if (mergeJoinOperation.getRestriction().apply(currentExecRow)) { returnedRows = true; break; } operationContext.recordFilter(); } if (!returnedRows) { currentExecRow = mergeRows(left, null); return true; } } return false; } catch (Exception e) { throw new RuntimeException(e); } }
Source:
<code>public void testCurrentTaskThreadPoolSizeCreation() throws Exception { <START> final int testThreadPoolSize = TaskConstants.DEFAULT_TASK_THREAD_POOL_SIZE + 1; <END> final String className = TestHelper.getTestClassName(); final String methodName = TestHelper.getTestMethodName(); final String clusterName = className + "_" + methodName; final ZKHelixDataAccessor accessor = new ZKHelixDataAccessor(clusterName, new ZkBaseDataAccessor<>(ZK_ADDR)); final PropertyKey.Builder keyBuilder = accessor.keyBuilder(); TestHelper.setupCluster(clusterName, ZK_ADDR, 12918, "localhost", "TestDB", 1, 10, 5, 3, "MasterSlave", true); final String instanceName = "localhost_12918"; final MockParticipantManager manager = new MockParticipantManager(ZK_ADDR, clusterName, instanceName); InstanceConfig instanceConfig = accessor.getProperty(keyBuilder.instanceConfig(instanceName)); instanceConfig.setTargetTaskThreadPoolSize(testThreadPoolSize); accessor.setProperty(keyBuilder.instanceConfig(instanceName), instanceConfig); manager.syncStart(); final LiveInstance liveInstance = accessor.getProperty(keyBuilder.liveInstance(instanceName)); Assert.assertNotNull(liveInstance); Assert.assertEquals(liveInstance.getCurrentTaskThreadPoolSize(), testThreadPoolSize); }</code><technical_language>Nit: a display of craftsmanship/readability if explain adding 1 here. I a 40</technical_language>

Target:
public void testCurrentTaskThreadPoolSizeCreation() throws Exception { final int testThreadPoolSize = TaskConstants.DEFAULT_TASK_THREAD_POOL_SIZE + 1; final String className = TestHelper.getTestClassName(); final String methodName = TestHelper.getTestMethodName(); final String clusterName = className + "_" + methodName; final ZKHelixDataAccessor accessor = new ZKHelixDataAccessor(clusterName, new ZkBaseDataAccessor.Builder<ZNRecord>().setZkAddress(ZK_ADDR).build()); final PropertyKey.Builder keyBuilder = accessor.keyBuilder(); TestHelper.setupCluster(clusterName, ZK_ADDR, 12918, "localhost", "TestDB", 1, 10, 5, 3, "MasterSlave", true); final String instanceName = "localhost_12918"; final MockParticipantManager manager = new MockParticipantManager(ZK_ADDR, clusterName, instanceName); InstanceConfig instanceConfig = accessor.getProperty(keyBuilder.instanceConfig(instanceName)); instanceConfig.setTargetTaskThreadPoolSize(testThreadPoolSize); accessor.setProperty(keyBuilder.instanceConfig(instanceName), instanceConfig); manager.syncStart(); final LiveInstance liveInstance = accessor.getProperty(keyBuilder.liveInstance(instanceName)); Assert.assertNotNull(liveInstance); Assert.assertEquals(liveInstance.getCurrentTaskThreadPoolSize(), testThreadPoolSize); manager.syncStop(); deleteCluster(clusterName); }
Source:
<code>protected void updateResults( TopNParams params, Aggregator[][] rowSelector, Map<Comparable, Aggregator[]> aggregatesStore, TopNResultBuilder resultBuilder ) { if (needsResultTypeConversion(params)) { final Function<Object, Object> valueTransformer = TopNMapFn.getValueTransformer( query.getDimensionSpec().getOutputType() ); for (Map.Entry<Comparable, Aggregator[]> entry : aggregatesStore.entrySet()) { Aggregator[] aggs = entry.getValue(); if (aggs != null && aggs.length > 0) { Object[] vals = new Object[aggs.length]; for (int i = 0; i < aggs.length; i++) { vals[i] = aggs[i].get(); } Comparable convertedKey = (Comparable) valueTransformer.apply(entry.getKey()); resultBuilder.addEntry( convertedKey, convertedKey, vals ); } } } else { for (Map.Entry<Comparable, Aggregator[]> entry : aggregatesStore.entrySet()) { Aggregator[] aggs = entry.getValue(); if (aggs != null && aggs.length > 0) { Object[] vals = new Object[aggs.length]; for (int i = 0; i < aggs.length; i++) { vals[i] = aggs[i].get(); } resultBuilder.addEntry( <START> entry.getKey(), <END> entry.getKey(), vals ); } } } }</code><technical_language>miss null handling</technical_language>

Target:
protected void updateResults( TopNParams params, Aggregator[][] rowSelector, Map<Comparable, Aggregator[]> aggregatesStore, TopNResultBuilder resultBuilder ) { final ColumnSelectorPlus<TopNColumnSelectorStrategy> selectorPlus = params.getSelectorPlus(); final boolean needsResultTypeConversion = needsResultTypeConversion(params); final Function<Object, Object> valueTransformer = TopNMapFn.getValueTransformer( query.getDimensionSpec().getOutputType() ); selectorPlus.getColumnSelectorStrategy().updateDimExtractionResults( aggregatesStore, needsResultTypeConversion ? valueTransformer : null, resultBuilder ); }
Source:
<code>public void removeOrg(Org keeper, Org duplicate) throws Exception { OrganizationInfo orgInfo = managementService.getOrganizationByUuid( duplicate.getId() ); orgInfo.setName( "dup_" + keeper.getId() + "_" + RandomStringUtils.randomAlphanumeric(10) ); managementService.updateOrganization( orgInfo ); OrganizationInfo orgInfoKeeper = managementService.getOrganizationByUuid( duplicate.getId() ); try { <START> managementService.updateOrganizationUniqueIndex( orgInfo, duplicate.getId() ); <END> } catch ( Exception e ) { logger.warn("Error repairing unique value keeper duplicate {}", keeper.getId(), duplicate.getId()); } }</code><technical_language>this in keeper org's OrganizationInfo, duplicate's ID. passing in duplicates OrganizationInfo ID</technical_language>

Target:
public void removeOrg(Org keeper, Org duplicate) throws Exception { OrganizationInfo orgInfo = managementService.getOrganizationByUuid( duplicate.getId() ); orgInfo.setName( "dup_" + keeper.getId() + "_" + RandomStringUtils.randomAlphanumeric(10) ); managementService.updateOrganization( orgInfo ); OrganizationInfo orgInfoKeeper = managementService.getOrganizationByUuid( keeper.getId() ); try { managementService.updateOrganizationUniqueIndex( orgInfoKeeper, duplicate.getId() ); } catch ( Exception e ) { logger.warn("Error repairing unique value keeper duplicate {}", keeper.getId(), duplicate.getId()); } }
Source:
<code><START> static Object[] copy(Object arrayObject, int minLength) { <END> final Object[] array = (arrayObject == null) ? EMPTY : (Object[]) arrayObject; return (array.length >= minLength) ? array.clone() : arrayCopy(minLength, array, 0, 0, array.length); }</code><technical_language>a assert minLength >= 0 (or similar) sense</technical_language>

Target:
static Object[] copy(Object arrayObject, int minLength) { final Object[] array = (Object[]) arrayObject; final int arrayLength = (array == null) ? 0 : array.length; final int length = Math.max(arrayLength, minLength); return arrayCopy(length, array, 0, 0, arrayLength); }
Source:
<code>public void testBigDecimalToLong() { Object r = ParameterConverter.tryToMakeCompatible(long.class, new BigDecimal(1000)); assertTrue("expect long", r.getClass() == Long.class); assertEquals(1000L, ((Long)r).longValue()); <START> boolean hasException = false; <END> try { r = ParameterConverter.tryToMakeCompatible(long.class, new BigDecimal(1000.01)); } catch (VoltTypeException e) { hasException = true; } assertEquals(true, hasException); hasException = false; try { r = ParameterConverter.tryToMakeCompatible(long.class, new BigDecimal("10000000000000000000000000000000000")); } catch (VoltTypeException e) { hasException = true; } assertEquals(true, hasException); }</code><technical_language>Replace lossy conversion a static util function. failWithInvalidConversion(Class<?> class, BigDecimal bigDecimal);</technical_language>

Target:
public void testBigDecimalToLong() { Object r = ParameterConverter.tryToMakeCompatible(long.class, new BigDecimal(1000)); assertTrue("expect long", r.getClass() == Long.class); assertEquals(1000L, ((Long)r).longValue()); testBigDecimalFailWithInvalidConversion(long.class, new BigDecimal(1000.01)); testBigDecimalFailWithInvalidConversion(long.class, new BigDecimal("10000000000000000000000000000000000")); }
Source:
<code><START> protected String getSamzaProperty(SystemStream systemStream, String property, String defaultValue) { <END> String streamVal = getSamzaProperty(systemStream, property); return streamVal != null ? streamVal : defaultValue; }</code><technical_language>getSamzaProperty (here below) private? please move helpers in class file in some of public methods</technical_language>

Target:
private String getSamzaProperty(SystemStream systemStream, String property, String defaultValue) { String streamVal = getSamzaProperty(systemStream, property); return streamVal != null ? streamVal : defaultValue; }
Source:
<code>void readsLineFromExceedsMaxCharsFileWithCustomConfig(@TempDir Path tempDir) throws java.io.IOException { Path csvFile = writeClasspathResourceToFile("/exceeds-default-max-chars.csv", tempDir.resolve("exceeds-default-max-chars.csv")); CsvFileSource annotation = csvFileSource() .encoding("ISO-8859-1") .resources("/exceeds-default-max-chars.csv") <START> .maxCharsPerColumn(4097).files(csvFile.toAbsolutePath().toString()) END> .build(); Stream<Object[]> arguments = provideArguments(new CsvFileArgumentsProvider(), annotation); assertThat(arguments).hasSize(2 * 1); }</code><technical_language>suggestion .maxCharsPerColumn(4097)// .files(csvFile.toAbsolutePath().toString())//</technical_language>

Target:
void readsLineFromExceedsMaxCharsFileWithCustomConfig(@TempDir Path tempDir) throws java.io.IOException { Path csvFile = writeClasspathResourceToFile("/exceeds-default-max-chars.csv", tempDir.resolve("exceeds-default-max-chars.csv")); CsvFileSource annotation = csvFileSource() .encoding("ISO-8859-1") .resources("/exceeds-default-max-chars.csv") .maxCharsPerColumn(4097) .files(csvFile.toAbsolutePath().toString()) .build(); Stream<Object[]> arguments = provideArguments(new CsvFileArgumentsProvider(), annotation); assertThat(arguments).hasSize(2); }
Source:
<code>protected boolean matchesSafely(final MutableReasonDetail reasonDetail) { final CodeLocation<?> codeLocation = reasonDetail.codeLocation(); if (reasonDetail.reason().isOneOf(MUTABLE_TYPE_TO_FIELD) && codeLocation instanceof FieldLocation) { final FieldLocation location = (FieldLocation) reasonDetail.codeLocation(); <START> final Dotted fieldType = location.fieldType(); <END> for (final Dotted allowedClass : classNames) { if (fieldType.equals(allowedClass)) { return true; } } } return false; }</code><technical_language>cost a lot of code in other places, this nicer now</technical_language>

Target:
protected boolean matchesSafely(final MutableReasonDetail reasonDetail) { final CodeLocation<?> codeLocation = reasonDetail.codeLocation(); if (reasonDetail.reason().isOneOf(MUTABLE_TYPE_TO_FIELD) && codeLocation instanceof FieldLocation) { final FieldLocation location = (FieldLocation) reasonDetail.codeLocation(); final Dotted fieldType = location.fieldType(); return StreamSupport.stream(classNames.spliterator(), false).anyMatch(fieldType::equals); } return false; }
Source:
<code>private void removeWorker(final Worker worker) { log.info("Kaboom! Worker[%s] removed!", worker.getHost()); final ZkWorker zkWorker = zkWorkers.get(worker.getHost()); if (zkWorker != null) { try { List<String> tasksToFail = Lists.newArrayList( cf.getChildren().forPath(JOINER.join(config.getIndexerTaskPath(), worker.getHost())) ); log.info("%s: Found %d tasks assigned", worker.getHost(), tasksToFail.size()); for (Map.Entry<String, RemoteTaskRunnerWorkItem> entry : runningTasks.entrySet()) { <START> if (entry.getValue().getWorker().getHost().equalsIgnoreCase(worker.getHost())) { <END> log.info("%s: Found %s running", worker.getHost(), entry.getKey()); tasksToFail.add(entry.getKey()); } } for (String assignedTask : tasksToFail) { RemoteTaskRunnerWorkItem taskRunnerWorkItem = runningTasks.remove(assignedTask); if (taskRunnerWorkItem != null) { String taskPath = JOINER.join(config.getIndexerTaskPath(), worker.getHost(), assignedTask); if (cf.checkExists().forPath(taskPath) != null) { cf.delete().guaranteed().forPath(taskPath); } log.info("Failing task %s", assignedTask); taskRunnerWorkItem.setResult(TaskStatus.failure(taskRunnerWorkItem.getTask().getId())); } else { log.warn("RemoteTaskRunner has no knowledge of task %s", assignedTask); } } } catch (Exception e) { throw Throwables.propagate(e); } finally { try { zkWorker.close(); } catch (Exception e) { log.error(e, "Exception closing worker %s!", worker.getHost()); } zkWorkers.remove(worker.getHost()); } } }</code><technical_language>a massive chain. fugly. though</technical_language>

Target:
private void removeWorker(final Worker worker) { log.info("Kaboom! Worker[%s] removed!", worker.getHost()); final ZkWorker zkWorker = zkWorkers.get(worker.getHost()); if (zkWorker != null) { try { List<String> tasksToFail = Lists.newArrayList( cf.getChildren().forPath(JOINER.join(config.getIndexerTaskPath(), worker.getHost())) ); log.info("[%s]: Found %d tasks assigned", worker.getHost(), tasksToFail.size()); for (Map.Entry<String, RemoteTaskRunnerWorkItem> entry : runningTasks.entrySet()) { if (entry.getValue().getWorker().getHost().equalsIgnoreCase(worker.getHost())) { log.info("[%s]: Found [%s] running", worker.getHost(), entry.getKey()); tasksToFail.add(entry.getKey()); } } for (String assignedTask : tasksToFail) { RemoteTaskRunnerWorkItem taskRunnerWorkItem = runningTasks.remove(assignedTask); if (taskRunnerWorkItem != null) { String taskPath = JOINER.join(config.getIndexerTaskPath(), worker.getHost(), assignedTask); if (cf.checkExists().forPath(taskPath) != null) { cf.delete().guaranteed().forPath(taskPath); } log.info("Failing task[%s]", assignedTask); taskRunnerWorkItem.setResult(TaskStatus.failure(taskRunnerWorkItem.getTask().getId())); } else { log.warn("RemoteTaskRunner has no knowledge of task[%s]", assignedTask); } } } catch (Exception e) { throw Throwables.propagate(e); } finally { try { zkWorker.close(); } catch (Exception e) { log.error(e, "Exception closing worker[%s]!", worker.getHost()); } zkWorkers.remove(worker.getHost()); } } }
Source:
<code>public void setVisible(boolean visible) { super.setVisible(visible); if (visible) { welcomeTextLabel .setText("WatchDog is a free, open-source plugin that tells how you code your software."); welcomeTextLabel.setLayoutData(new GridData( GridData.FILL_HORIZONTAL)); welcomeTextLabel.getParent().layout(); welcomeTextLabel.getParent().update(); <START> String descriptionText = "It measures how you write Java code and tests. We never do anything bad with <a href=\"<LINK_1>\">your purely numerical data</a>.\nYou can win <a href=\"<LINK_0>\">amazing prizes</a>, <a href=\"<LINK_2>\">a detailed report on your development behaviour</a> and our eternal gratitude! :-)\n"; <END> linkedTextLink.setText(descriptionText); linkedTextLink .setLayoutData(new GridData(GridData.FILL_HORIZONTAL)); linkedTextLink.getParent().layout(); linkedTextLink.getParent().update(); linkedTextLink.getParent().getParent().layout(); linkedTextLink.getParent().getParent().update(); } }</code><technical_language>link detailed report, please :)</technical_language>

Target:
public void setVisible(boolean visible) { super.setVisible(visible); if (visible) { welcomeTextLabel .setText("WatchDog is a free, open-source plugin that tells how you code your software."); welcomeTextLabel.setLayoutData(new GridData( GridData.FILL_HORIZONTAL)); welcomeTextLabel.getParent().layout(); welcomeTextLabel.getParent().update(); String descriptionText = "It measures how you write Java code and tests. We never do anything bad with <a href=\"<LINK_1>\">your purely numerical data</a>.\nYou can win <a href=\"<LINK_0>\">amazing prizes</a>, a <a href=\"<LINK_2>\">detailed report</a> on your development behaviour and our eternal gratitude! :-)\n"; linkedTextLink.setText(descriptionText); linkedTextLink .setLayoutData(new GridData(GridData.FILL_HORIZONTAL)); linkedTextLink.getParent().layout(); linkedTextLink.getParent().update(); linkedTextLink.getParent().getParent().layout(); linkedTextLink.getParent().getParent().update(); } }
Source:
<code>public String toString() { if (this.equals(CANNOT_REPLACE_SIMPLE_NAME)) { <START> return "CAN_NOT_REPLACE_SIMPLE_NAME"; <END> } return fullyQualifiedName + (fromImport ? " (imported)" : " (member)"); }</code><technical_language>Doh! Thanks! Please leave CANNOT_..</technical_language>

Target:
public String toString() { if (this.equals(CANNOT_REPLACE_SIMPLE_NAME)) { return "CANNOT_REPLACE_SIMPLE_NAME"; } return fullyQualifiedName + (fromImport ? " (imported)" : " (member)"); }
Source:
<code>protected void tearDown() throws Exception { <START> super.tearDown(); <END> File file = new File( PATH + FILE ); if ( file.exists() ) { if ( !file.delete() ) { throw new RuntimeException( String.format( "Can't delete %s", file ) ); } } }</code><technical_language>super.tearDown called last. this method right setUp() tests</technical_language>

Target:
protected void tearDown() throws Exception { File file = new File( PATH + FILE ); if ( file.exists() ) { if ( !file.delete() ) { throw new IOException( "Can't delete " + file ); } } super.tearDown(); }
Source:
<code>public boolean removeContent(ProductDTO product, Set<String> contentIds) { if (contentIds == null) { throw new IllegalArgumentException("contentId is null"); } if (contentIds.isEmpty()) { return false; } Set<ProductContentDTO> toRemove = product.getProductContent().stream() .filter(content -> contentIds.contains(content.getContent().getId())) .collect(Collectors.toSet()); <START> product.getProductContent().removeAll(toRemove); <END> return !toRemove.isEmpty(); }</code><technical_language>encapsulation</technical_language>

Target:
public boolean removeContent(ProductDTO product, Set<String> contentIds) { if (contentIds == null) { throw new IllegalArgumentException("contentId is null"); } if (contentIds.isEmpty()) { return false; } int originalSize = product.getProductContent().size(); Set<ProductContentDTO> updatedContents = product.getProductContent().stream() .filter(content -> !contentIds.contains(content.getContent().getId())) .collect(Collectors.toSet()); product.setProductContent(updatedContents); return originalSize != updatedContents.size(); }
Source:
<code>protected Object getInstanceToRun(Map paramsMap) { String instanceName = (String) paramsMap.get(SchedulerUtilQuartzImpl.RUNNABLE_INSTANCE); try { <START> Class<?> clazz = Class.forName(instanceName); <END> Constructor<?> constructor = clazz.getConstructor(); Object instance = constructor.newInstance(); return instance; } catch (ClassNotFoundException e) { log.error("could not instantiate class '{}' due to error '{}'", instanceName, e.getMessage()); log.debug("Exception", e); return null; } catch (NoSuchMethodException | SecurityException | InstantiationException | IllegalAccessException | IllegalArgumentException | InvocationTargetException e) { log.error("could not instantiate class '{}' due to error '{}'", instanceName, e.getMessage()); log.debug("Exception", e); return null; } }</code><technical_language>for DB Scheduled scheduler existence of class examined ? able resolve correct class set map, this logic applied for simple scheduler for consistency</technical_language>

Target:
protected Object getInstanceToRun(Map paramsMap) { String instanceName = (String) paramsMap.get(SchedulerUtilBaseImpl.RUNNABLE_INSTANCE); try { Class<?> clazz = Class.forName(instanceName); Constructor<?> constructor = clazz.getConstructor(); Object instance = constructor.newInstance(); return instance; } catch (ClassNotFoundException | NoSuchMethodException | SecurityException | InstantiationException | IllegalAccessException | IllegalArgumentException | InvocationTargetException e) { log.error("could not instantiate class '{}' due to error '{}'", instanceName, e.getMessage()); log.debug("Exception", e); return null; } }
Source:
<code>private Map<Client, PaxosLong> unsafeGetLatest(Set<Client> clients) { if (cacheKey == null) { processDigest(delegate.latestSequencesPreparedOrAccepted(Optional.empty(), clients)); <START> return Collections.unmodifiableMap(cachedEntries); END> } Set<Client> newClients = Sets.difference(clients, cachedEntries.keySet()); if (newClients.isEmpty()) { delegate.latestSequencesPreparedOrAcceptedCached(cacheKey).ifPresent(this::processDigest); return Collections.unmodifiableMap(cachedEntries); } else { processDigest(delegate.latestSequencesPreparedOrAccepted(Optional.of(cacheKey), newClients)); return Collections.unmodifiableMap(cachedEntries); } }</code><technical_language>do copy, view change calls method</technical_language>

Target:
private Map<Client, PaxosLong> unsafeGetLatest(Set<Client> clients) { if (cacheKey == null) { processDigest(delegate.latestSequencesPreparedOrAccepted(Optional.empty(), clients)); return ImmutableMap.copyOf(cachedEntries); } Set<Client> newClients = Sets.difference(clients, cachedEntries.keySet()); if (newClients.isEmpty()) { delegate.latestSequencesPreparedOrAcceptedCached(cacheKey).ifPresent(this::processDigest); return ImmutableMap.copyOf(cachedEntries); } else { processDigest(delegate.latestSequencesPreparedOrAccepted(Optional.of(cacheKey), newClients)); return ImmutableMap.copyOf(cachedEntries); } }
Source:
<code>public PushPartialAggregationThroughExchange(FunctionRegistry functionRegistry) { <START> this.functionRegistry = functionRegistry; <END> }</code><technical_language>require null</technical_language>

Target:
public PushPartialAggregationThroughExchange(FunctionRegistry functionRegistry) { this.functionRegistry = requireNonNull(functionRegistry, "functionRegistry is null"); }
Source:
<code>private void notifyLightStatusListeners(final FullLight fullLight, final String type) { <START> if (lightStatusListeners.size() < 1) { <END> logger.debug("No light status listeners to notify of light change for light {}", fullLight.getId()); return; } for (LightStatusListener lightStatusListener : lightStatusListeners) { try { switch (type) { case LIGHT_STATE_ADDED: lightStatusListener.onLightAdded(bridge, fullLight); logger.debug("Sending lightAdded for light {}", fullLight.getId()); break; case LIGHT_STATE_CHANGED: logger.debug("Sending lightStateChanged for light {}", fullLight.getId()); lightStatusListener.onLightStateChanged(bridge, fullLight); break; default: throw new IllegalArgumentException( "Could not notify lightStatusListeners for unknown event type " + type); } } catch (Exception e) { logger.error("An exception occurred while calling the BridgeHeartbeatListener", e); } } }</code><technical_language>lightStatusListeners.isEmpty() :wink:</technical_language>

Target:
private void notifyLightStatusListeners(final FullLight fullLight, final String type) { if (lightStatusListeners.isEmpty()) { logger.debug("No light status listeners to notify of light change for light {}", fullLight.getId()); return; } for (LightStatusListener lightStatusListener : lightStatusListeners) { try { switch (type) { case LIGHT_STATE_ADDED: lightStatusListener.onLightAdded(hueBridge, fullLight); logger.debug("Sending lightAdded for light {}", fullLight.getId()); break; case LIGHT_STATE_CHANGED: logger.debug("Sending lightStateChanged for light {}", fullLight.getId()); lightStatusListener.onLightStateChanged(hueBridge, fullLight); break; default: throw new IllegalArgumentException( "Could not notify lightStatusListeners for unknown event type " + type); } } catch (Exception e) { logger.error("An exception occurred while calling the BridgeHeartbeatListener", e); } } }
Source:
<code>public void setAcceptableValues(Collection<List<T>> values) { List<T> acceptableValues = (List<T>) <START> values.toArray()[0]; <END> for(T currentValue : acceptableValues) { if(!checkBoxes.containsKey(currentValue)) { addCheckBox(currentValue); } } showCheckBoxes(); }</code><technical_language>want check if is (and well) in collection, this throw exception if values collection is empty</technical_language>

Target:
public void setAcceptableValues(Collection<List<T>> values) { if (values.isEmpty()) { throw new IllegalArgumentException("Widget has nothing to do"); } List<T> acceptableValues = (List<T>) values.toArray()[0]; for(T currentValue : acceptableValues) { if(!checkBoxes.containsKey(currentValue)) { addCheckBox(currentValue); } } showCheckBoxes(); }
Source:
<code>void checkAndWaitForResource() { long timeToWait = 0; while(!applicationStartupDependentResource.isAvailable()) { timeToWait += PROGRESSIVE_SECONDS_TO_WAIT; logger.info("Waiting for seconds until is available ...", timeToWait, applicationStartupDependentResource); waiter.accept(Duration.ofSeconds(timeToWait)); } <START> logger.info("Database available."); <END> }</code><technical_language>I guess, if want applicationStartupDependentResource generic (an interface) implementations, avoid logging database here, waiting other</technical_language>

Target:
void checkAndWaitForResource() { long timeToWait = 0; while(!applicationStartupDependentResource.isAvailable()) { timeToWait += PROGRESSIVE_SECONDS_TO_WAIT; logger.info("Waiting for seconds until is available ...", timeToWait, applicationStartupDependentResource); waiter.accept(Duration.ofSeconds(timeToWait)); } logger.info("{} available.", applicationStartupDependentResource); }
Source:
<code>protected void executeCommand() { List<VmNumaNode> vmNumaNodes = getParameters().getVmNumaNodeList(); <START> Guid vdsId = getVm().getDedicatedVmForVdsList().get(0); <END> List<VdsNumaNode> vdsNumaNodes = new ArrayList<>(); if (vdsId != null) { vdsNumaNodes = getVdsNumaNodeDao().getAllVdsNumaNodeByVdsId(vdsId); } List<VmNumaNode> nodes = new ArrayList<>(); for (VmNumaNode vmNumaNode : vmNumaNodes) { vmNumaNode.setId(Guid.newGuid()); for (Pair<Guid, Pair<Boolean, Integer>> pair : vmNumaNode.getVdsNumaNodeList()) { if (pair.getSecond() != null && pair.getSecond().getSecond() != null) { int index = pair.getSecond().getSecond(); if (pair.getSecond().getFirst()) { for (VdsNumaNode vdsNumaNode : vdsNumaNodes) { if (vdsNumaNode.getIndex() == index) { pair.setFirst(vdsNumaNode.getId()); break; } } } } } nodes.add(vmNumaNode); } getVmNumaNodeDao().massSaveNumaNode(nodes, null, getVm().getId()); setActionReturnValue(nodes.get(0).getId()); setSucceeded(true); }</code><technical_language>a potential NPE do it</technical_language>

Target:
protected void executeCommand() { List<VmNumaNode> vmNumaNodes = getParameters().getVmNumaNodeList(); List<VdsNumaNode> vdsNumaNodes = getVdsNumaNodes(); List<VmNumaNode> nodes = new ArrayList<>(); for (VmNumaNode vmNumaNode : vmNumaNodes) { vmNumaNode.setId(Guid.newGuid()); for (Pair<Guid, Pair<Boolean, Integer>> pair : vmNumaNode.getVdsNumaNodeList()) { if (pair.getSecond() != null && pair.getSecond().getSecond() != null) { int index = pair.getSecond().getSecond(); if (pair.getSecond().getFirst()) { for (VdsNumaNode vdsNumaNode : vdsNumaNodes) { if (vdsNumaNode.getIndex() == index) { pair.setFirst(vdsNumaNode.getId()); break; } } } } } nodes.add(vmNumaNode); } getVmNumaNodeDao().massSaveNumaNode(nodes, null, getVm().getId()); setActionReturnValue(nodes.get(0).getId()); setSucceeded(true); }
Source:
<code>public List<GerritQueryResult> queryMyReviews(IProgressMonitor monitor) throws GerritException { <START> return executeQuery(monitor, <END> "owner:self OR reviewer:self", ImmutableList.of(GET_LABELS_OPTION, GET_DETAILED_ACCOUNTS_OPTION)); }</code><technical_language>need pass labels in</technical_language>

Target:
public List<GerritQueryResult> queryMyReviews(IProgressMonitor monitor) throws GerritException { return executeQuery(monitor, "owner:self OR reviewer:self", ImmutableList.of(GET_DETAILED_ACCOUNTS_OPTION)); }
Source:
<code>public Validator getValidator() { return createValidator( constraintValidatorManager.getDefaultConstraintValidatorFactory(), messageInterpolator, traversableResolver, parameterNameProvider, clockProvider, scriptEvaluatorFactory, failFast, <START> clockSkewTolerance, <END> valueExtractorManager, methodValidationConfiguration, traversableResolverResultCacheEnabled ); }</code><technical_language>concern is methods start grow in parameter numbers time add some new config property ... I guess <LINK_0> this, right? If add a "subcontainer" for kind of properties..</technical_language>

Target:
public Validator getValidator() { return createValidator( constraintValidatorManager.getDefaultConstraintValidatorFactory(), messageInterpolator, traversableResolver, parameterNameProvider, clockProvider, scriptEvaluatorFactory, failFast, temporalValidationTolerance, valueExtractorManager, methodValidationConfiguration, traversableResolverResultCacheEnabled ); }