GHSA-4wr4-f2qf-x5wj: Admidio has an HTMLPurifier Bypass in eCard Message Allows HTML Email Injection
SummaryThe eCard send handler in Admidio uses the raw `$_POST['ecard_message']` value instead of the HTMLPurifier-sanitized `$formValues['ecard_message']` when constructing the greeting card HTML. This allows an authenticated attacker to inject arbitrary HTML and JavaScript into greeting card emails sent to other members, bypassing the server-side HTMLPurifier sanitization that is properly applied to the `ecard_message` field during form validation.DetailsRoot CauseFile: `D:\bugcrowd\admidio\repo\modules\photos\ecard_send.php`At line 38, the raw POST value is captured BEFORE form validation runs:At line 61, the form validation runs and properly sanitizes the message through HTMLPurifier (since ecard_message is registered as an editor field):The sanitized value is stored in `$formValues['ecard_message']`, but this value is never used. Instead, the raw `$postMessage` is passed to `parseEcardTemplate()` at lines 159 and 201:Template InjectionFile: `D:\bugcrowd\admidio\repo\src\Photos\ValueObject\ECard.php`, line 144The `parseEcardTemplate()` method places the message directly into the HTML template without any encoding:Compare this to the recipient fields which ARE properly encoded:Inconsistency with PreviewFile: `D:\bugcrowd\admidio\repo\modules\photos\ecard_preview.php`, line 56The preview correctly uses the sanitized value:This means the preview shows the sanitized version, but the actual sent email contains the unsanitized content.Delivery MechanismThe unsanitized HTML is delivered via two channels:**HTML Email** (primary vector): At line 218 of `ECard.php`, the parsed template is set as the email body via `$email->setText($ecardHtmlData)` followed by `$email->setHtmlMail()`. The malicious HTML is rendered by the recipient's email client.**Database Storage**: At line 214 of `ecard_send.php`, `$message->addContent($ecardHtmlData)` stores the raw HTML in the messages table. However, `MessageContent::getValue()` applies `SecurityUtils::encodeHTML()` on output, mitigating the stored XSS in the web interface.PoC**Prerequisites:** Logged-in user with access to the photo module and eCard feature enabled.**Step 1: Send an eCard with injected HTML**The HTMLPurifier validation runs but its result is discarded. The raw HTML including the phishing link and tracking pixel is sent in the greeting card email.**Step 2: Escalated payload with script injection**Most modern email clients block script execution, but older clients or webmail interfaces with relaxed CSP may execute it.Impact**Phishing via Trusted Sender:** The attacker sends crafted greeting cards that appear to come from the organization's system. The email sender address is the attacker's real address from their Admidio profile, but the email template and branding make it appear legitimate.**HTML Email Injection:** Arbitrary HTML content including fake forms, misleading links, and tracking pixels can be injected into emails sent to any member or role.**Scope Change:** The vulnerability crosses a security boundary -- the attack originates from the Admidio web application but impacts email recipients who may view the content outside of Admidio.**Bypasses Defense-in-Depth:** The HTMLPurifier sanitization is applied but its result is discarded, defeating the intended security control.Recommended FixIn `ecard_send.php`, use the sanitized `$formValues['ecard_message']` instead of the raw `$_POST['ecard_message']`:Additionally, in `ECard::parseEcardTemplate()`, apply encoding to the message placeholder as defense-in-depth, or at minimum document that the message is expected to contain trusted HTML:
CVSS v3.1: 5.4