GHSA-54hh-g5mx-jqcp: pnpm: Unsafe default behavior breaks integrity check
While it is unclear whether this should be classified as a vulnerability, it is being reported through this channel because the current behavior may represent an unsafe default.Summary`pnpm install` in non-frozen mode can accept new remote package content after detecting that the downloaded tarball does not match the integrity recorded in `pnpm-lock.yaml`.When a package is already locked with an `integrity` value, and the registry later serves different metadata and tarball content for the same package name and version, pnpm initially reports an integrity mismatch. However, plain `pnpm install` then performs a resolution repair, accepts the registry's new integrity, updates the lockfile, installs the new content, and exits successfully.This means the lockfile integrity check does not act as a hard stop by default.Reproduction ScenarioRun a local npm-compatible registry.Publish or serve `example-package@1.0.0` with tarball content `v1`.Install it with pnpm:Confirm `pnpm-lock.yaml` contains the `v1` integrity:Change the registry metadata and tarball for the same `example-package@1.0.0` to content `v2`.On a clean store/cache, run:Observed Behaviorpnpm detects the checksum mismatch:However, the install still succeeds:The lockfile is then rewritten to trust the new remote integrity:Expected BehaviorIf a downloaded tarball does not match the integrity recorded in `pnpm-lock.yaml`, the install should fail by default.The lockfile integrity should be treated as authoritative unless the user explicitly requests lockfile repair or dependency update behavior.Security ImpactThis behavior weakens the protection normally expected from a committed lockfile.If a registry is compromised and an attacker overwrites the metadata and tarball for an existing package version, a new environment without the old pnpm store/cache may install the attacker's replacement package even though the project already has a lockfile with the original integrity.Examples of affected new or clean environments include:an engineer setting up the project on a new machinea new team member onboarding to the projectIn this situation, pnpm first detects that the downloaded tarball does not match the integrity stored in `pnpm-lock.yaml`. However, instead of failing by default, plain `pnpm install` performs a resolution repair, trusts the current remote registry metadata, updates the lockfile to the new integrity, and installs the new registry content.In other words, when the lockfile and registry disagree, the default non-frozen behavior can end up trusting the remote registry over the content previously recorded in the lockfile.This is especially relevant for:private registries that allow overwriting or republishing the same versionregistry mirrors or proxies that can serve changed metadata and tarballscompromised public or private registriescompromised registry proxy infrastructureThe behavior is also surprising because the command reports an integrity error but still exits successfully after resolution repair.This issue does not occur when `--frozen-lockfile` is enabled. In frozen mode, the same integrity mismatch fails the install and does not install the changed package content.However, since the lockfile already records an integrity value, the integrity for the same package version should normally not change. If it does change, one likely explanation is that the server or registry has been compromised or is serving mutated package content. Under normal package publishing workflows, changed package content should be published as a new version instead of replacing an existing version.For that reason, it may be safer for pnpm's default behavior to be closer to frozen mode for this specific case. At minimum, pnpm should not automatically repair the lockfile and trust the registry after an integrity mismatch. It should fail and let the user explicitly decide whether to discard the locked integrity, re-resolve the package from the remote registry, and update the lockfile.ComparisonIn the same scenario, `npm install` with an existing `package-lock.json` fails with `EINTEGRITY` and does not install the changed tarball.`pnpm install --frozen-lockfile` also fails as expected:The issue is specific to the default non-frozen behavior of plain `pnpm install` in non-CI environment.
CVSS v3.1: 6.8