GHSA-vgh8-c6fp-7gcg: Sylius has a XSS vulnerability in checkout login form
ImpactA cross-site scripting (XSS) vulnerability exists in the shop checkout login form handled by the ApiLoginController Stimulus controller.When a login attempt fails, AuthenticationFailureHandler returns a JSON response whose message field is rendered into the DOM using innerHTML, allowing any HTML or JavaScript in that value to be parsed and executed by the browser.The message value originates from `AuthenticationException::getMessageKey()` passed through Symfony's translator (security domain, using the request locale). In the default Sylius installation, this returns a hardcoded translation key (e.g. "Invalid credentials."), which is not directly user-controlled. However, using innerHTML with server-derived data violates defense-in-depth principles, and the risk escalates significantly under realistic scenarios:Customized authentication handlers — if a project overrides AuthenticationFailureHandler to include user-supplied data in the message (e.g. "No account found for <username>"), an attacker can inject arbitrary JavaScript directly via the login
form without any privileged access.Translation injection — if translation files are sourced from an untrusted database or CMS and contain HTML, the message could carry a malicious payload.Man-in-the-Middle — if the response is intercepted (e.g. on HTTP or via a compromised proxy), an attacker can inject arbitrary HTML/JS into the message field.Server-side injection — if any middleware, reverse proxy, or error handler modifies the JSON response body, malicious content could be injected into the message field.Exploitation could lead to session hijacking, credential theft, cart/order manipulation, or phishing within the trusted shop domain.The vulnerability affects all Sylius installations that use the default shop checkout login form with the bundled ApiLoginController.js.PatchesThe issue is fixed in versions: 2.0.16, 2.1.12, 2.2.3 and above.WorkaroundsOverride the vulnerable JavaScript controller at the project level.Note: Step 2 differs between Sylius 2.0 and upStep 1. Override JavaScript controller handling loginPatch ApiLoginController.jsCopy the original from `vendor/sylius/sylius/src/Sylius/Bundle/ShopBundle/Resources/assets/controllers/ApiLoginController.js` to `assets/shop/controllers/ApiLoginController.js` and apply:Step 2. Register the patched controllerSylius 2.1+ (Stimulus Bridge with `controllers.json`)Disable the vendor controller in `assets/shop/controllers.json`:Register the overwritten controller in `assets/shop/bootstrap.js`Sylius 2.0 (explicit imports in vendor `app.js`)Use Webpack's `NormalModuleReplacementPlugin` to swap the controller at build time. In `webpack.config.js`, after `shopConfig` is created:Step 3. Rebuild assetsReportersWe would like to extend our gratitude to the following individuals for their detailed reporting and responsible disclosure of this vulnerability:Bartłomiej Nowiński (@bnBart)For more informationIf you have any questions or comments about this advisory:Open an issue in [Sylius issues](https://github.com/Sylius/Sylius/issues?q=sort%3Aupdated-desc+is%3Aissue+is%3Aopen)Email us at [security@sylius.com](mailto:security@sylius.com)
CVSS v4.0: 5.3