GHSA-wwg8-6ffr-h4q2: Admidio is Missing CSRF Validation on Role Delete, Activate, and Deactivate Actions
SummaryThe `delete`, `activate`, and `deactivate` modes in `modules/groups-roles/groups_roles.php` perform destructive state changes on organizational roles but never validate an anti-CSRF token. The client-side UI passes a CSRF token to `callUrlHideElement()`, which includes it in the POST body, but the server-side handlers ignore `$_POST["adm_csrf_token"]` entirely for these three modes. An attacker who can discover a role UUID (visible in the public `cards` view when the module is publicly accessible) can embed a forged POST form on any external page and trick any user with the `rol_assign_roles` right into deleting or toggling roles for the organization. Role deletion is permanent and cascades to all memberships, event associations, and rights data.DetailsCSRF Token Is Sent but Never ValidatedFile: `D:/bugcrowd/admidio/repo/modules/groups-roles/groups_roles.php`, lines 150-173The `save` mode (lines 143-148) is CSRF-protected via `RolesService::save()` which calls `getFormObject($_POST["adm_csrf_token"])->validate()`. The `delete`, `activate`, and `deactivate` modes receive no equivalent protection:The only input validated is `$getRoleUUID` at line 41, checked as a `'uuid'` type. This prevents SQL injection but provides no CSRF protection.Client-Side UI Passes Token; Server Ignores ItFile: `D:/bugcrowd/admidio/repo/system/js/common_functions.js`, lines 101-129The presenter embeds the CSRF token into the JavaScript `callUrlHideElement()` call (GroupsRolesPresenter.php line 131). The function sends it in an AJAX POST body:The server-side handler reads `mode` from `$_GET` but never reads or validates `$_POST["adm_csrf_token"]` for `delete`, `activate`, or `deactivate`. An attacker omits the token field entirely; the server does not check for its presence.Who Can Be the CSRF VictimFile: `D:/bugcrowd/admidio/repo/modules/groups-roles/groups_roles.php`, lines 49-54`isAdministratorRoles()` maps to `checkRolesRight('rol_assign_roles')`. This is a delegated organizational right, not full system administrator (`isAdministrator()`) access. Any member granted the right to manage roles -- for example, a volunteer coordinator or chapter secretary -- is a valid CSRF victim.Role UUIDs Are Discoverable Without AuthenticationFile: `D:/bugcrowd/admidio/repo/src/UI/Presenter/GroupsRolesPresenter.php`, line 84The `cards` mode (the default view) does not require the `rol_assign_roles` right and is publicly reachable when the module is enabled. Role UUIDs appear as HTML element IDs and in action data attributes in the page source. An unauthenticated visitor can collect all role UUIDs before staging the CSRF attack against a logged-in victim.Role::delete() Is Permanent and CascadingFile: `D:/bugcrowd/admidio/repo/src/Roles/Entity/Role.php`, lines 264-288There is no soft-delete or recycle bin. Deletion permanently removes the role record, all memberships within it, all role dependency rules, and all per-module access rights granted to the role.PoCThe attacker hosts the following HTML page and tricks a user with the `rol_assign_roles` right into visiting it while logged in to Admidio.**Step 1: Collect role UUIDs from the public cards view (no login required)**Role UUIDs appear in the HTML source as element IDs (`id="role_<UUID>"`) and in action data attributes.**Step 2: Forge a deletion request (no CSRF token needed)**Expected response: `{"status":"success"}`The role, all its memberships, all event associations, and all access-right entries are permanently deleted. No `adm_csrf_token` field is required.**Step 3 (CSRF delivery -- attacker hosts externally)**When any user with `rol_assign_roles` views this page while authenticated, the targeted role is permanently deleted without any confirmation from the victim.**Step 4 (Deactivate via CSRF -- disables a role without deleting it)**Deactivating a role removes all active members from the role and hides it, effectively revoking access for all members without destroying the role record.Impact**Permanent Role Deletion:** A CSRF-triggered `delete` request irrecoverably removes the targeted role and all associated memberships, event links, and permission grants. There is no undo path other than a database restore.**Mass Membership Revocation:** Every member of the deleted role loses their membership record simultaneously. Role membership in Admidio controls access to events, document folders, mailing lists, and custom profile-field visibility.**Role State Manipulation:** An attacker can force `activate` or `deactivate` on any role. Deactivation silently strips access from an entire group without deleting the role record.**Low Attack Surface Requirement:** The attacker only needs to trick a user with the delegated `rol_assign_roles` right -- not a full system administrator. Such users are common in organizations that delegate group management to department heads or committee chairs.**UUID Pre-Collection Without Authentication:** Role UUIDs are harvested from the public cards view before the CSRF attack is staged, making target selection trivial.Recommended FixAdd `SecurityUtils::validateCsrfToken($_POST["adm_csrf_token"])` at the beginning of each vulnerable case, consistent with how other mutative actions in the codebase are protected.Since `callUrlHideElement` already sends `adm_csrf_token` in the POST body, adding the server-side validation call is a one-line fix per case and requires no changes to the front-end JavaScript or templates.
CVSS v3.1: 5.7