GHSA-w4hp-w536-jg64: AVideo: DOM XSS via Unsanitized Display Name in WebSocket Call Notification
SummaryThe AVideo YPTSocket plugin's caller feature renders incoming call notifications using the jQuery Toast Plugin, passing the caller's display name directly as the `heading` parameter. The toast plugin constructs the heading as raw HTML (`'<h2>' + heading + '</h2>'`) and inserts it into the DOM via jQuery's `.html()` method, which parses and executes any embedded HTML or script content. An attacker can set their display name to an XSS payload and trigger code execution on any online user's browser simply by initiating a call - no victim interaction is required beyond being connected to the WebSocket.DetailsWhen a call notification arrives via WebSocket, the caller's identity is extracted from the JSON message:This value is passed directly to the jQuery Toast Plugin as the heading:Inside the jQuery Toast Plugin, the heading is rendered as raw HTML:jQuery's `.html()` method parses the string as HTML and executes any script-bearing elements (such as `<img onerror>`, `<svg onload>`, etc.).There is a secondary injection vector in the same file where the full JSON message is placed inside a single-quoted `onclick` attribute:`JSON.stringify(json)` is placed inside a single-quoted `onclick` attribute. If any field in `json` contains a single quote, it breaks the attribute boundary and allows attribute injection.Proof of Concept**Important note on the attack vector:** `User::setName()` at `objects/user.php:2069` uses `strip_tags()`, so the display name IS sanitized on the server side when set through the normal UI or API. However, the WebSocket server relays call messages as-is without server-side validation of the `from_identification` field. A malicious WebSocket client can send any `from_identification` value directly over the WebSocket protocol, bypassing the server-side sanitization entirely. The attack requires a custom WebSocket client, not the normal UI.**Step 1: Connect a malicious WebSocket client and send a forged call message**The following JavaScript connects directly to the AVideo WebSocket server and sends a call message with an XSS payload in the `from_identification` field:**Step 2:** When the victim receives the call notification, the toast renders `from_identification` as HTML via jQuery's `.html()`. The `<img>` tag triggers the `onerror` handler, executing JavaScript in the victim's browser context.More advanced payload for credential exfiltration:Reproduction steps:Identify the WebSocket server address for the target AVideo instance (typically port 8888).Connect a custom WebSocket client to the server.Send a call message with `from_identification` set to `<img src=x onerror=alert(document.cookie)>`.Ensure a victim user is online and connected to the WebSocket (any authenticated page with YPTSocket loaded).Observe the XSS payload executing in the victim's browser when the toast notification appears. No victim interaction is required.ImpactThis is a zero-click stored XSS vulnerability. The victim does not need to click anything - merely being connected to the WebSocket (which happens automatically on any authenticated page load) is sufficient for the attack to succeed. The attacker controls when the payload fires by initiating a call.Consequences include:**Session hijacking**: Steal the victim's session cookie and impersonate them.**Account takeover**: If the victim is an administrator, the attacker gains full platform control.**Worm propagation**: The XSS payload can automatically change the victim's display name to the same payload and call other online users, creating a self-propagating worm.**Keylogging and credential theft**: Inject persistent scripts that capture keystrokes on the current page.The attack is zero-click and can target any specific online user.**CWE**: CWE-79 (Cross-Site Scripting - DOM-based)Recommended FixHTML-escape the heading value before passing it to `$.toast()` at `plugin/YPTSocket/caller.js:89`:This uses jQuery's `.text()` to safely encode the user-controlled string, then extracts the escaped HTML via `.html()`.*Found by [aisafe.io](https://aisafe.io)*
CVSS v3.1: 6.4