GHSA-22cj-m4wf-fv2c: PraisonAI Dynamic Context history and terminal tools read files outside configured storage via path traversal
PraisonAI Dynamic Context history and terminal tools read files outside configured storage via path traversalSummaryPraisonAI's Dynamic Context module provides filesystem-backed history and
terminal-log storage. The SDK reference describes the module as providing:artifact storage for tool outputs, history, and terminal logs;history persistence with search; andterminal session logging.The module also exports agent-callable tool factories:`create_history_tools()` returns `history_search`, `history_tail`, and
`history_get`.`create_terminal_tools()` returns `terminal_tail`, `terminal_grep`, and
`terminal_commands`.Those tools accept `run_id` and `agent_id` arguments from the tool caller. The
underlying stores join those values into filesystem paths without rejecting
absolute paths or `..` traversal:Because `run_id` can be an absolute path and `agent_id` can contain traversal,
a lower-trust prompt/user that can call these tools can read `.jsonl` and
`.log` files outside the configured Dynamic Context base directory.Affected ProductRepository: `MervinPraison/PraisonAI`Ecosystem: `pip`Package: `praisonai`Component: Dynamic Context history and terminal toolsCurrent source paths:`src/praisonai/praisonai/context/history_store.py``src/praisonai/praisonai/context/terminal_logger.py`Latest PyPI version validated: `4.6.58`Current `origin/main` validated:
`1ad58ca02975ff1398efeda694ea2ab78f20cf3e`Current `origin/main` tag validated: `v4.6.58`Suggested affected range:Representative local sweep:`3.8.1`: vulnerable`4.0.0`: vulnerable`4.5.113`: vulnerable`4.6.33`: vulnerable`4.6.34`: vulnerable`4.6.40`: vulnerable`4.6.50`: vulnerable`4.6.58`: vulnerableRoot Cause`HistoryStore._get_history_path()` and `TerminalLogger._get_log_path()` treat
logical identifiers as path segments, but never validate that the resolved path
stays under `base_dir`.History path construction:Terminal path construction:The agent tools pass caller-controlled `run_id` and `agent_id` directly into
these helpers:There is no check equivalent to:There is also no identifier allowlist preventing `/`, `\`, or `..` in
`run_id` or `agent_id`.Local PoVRun against the latest PyPI package:The PoV:Creates a temporary Dynamic Context base directory.Creates a separate outside directory containing `secret.jsonl` and
`secret.log`.Creates legitimate in-base history and terminal log controls.Calls `history_tail()` and `history_get()` with
`run_id=<outside-dir>` and `agent_id=../secret`.Calls `terminal_tail()` and `terminal_grep()` with the same traversal.Confirms the traversal paths resolve to files outside the configured base.Observed output summary from `evidence/pov-pypi-4.6.58.json`:The PoV is local-only. It does not start a server, contact a third-party
target, or use real credentials.Why This Is Not Intended BehaviorThis report does not claim that history and terminal helpers should be unable
to read legitimate history or terminal logs. The issue is narrower: logical
`run_id` and `agent_id` values can escape the configured Dynamic Context base
directory.The controls show the intended boundary:legitimate in-base history remains readable;legitimate in-base terminal logs remain readable;the outside `.jsonl` and `.log` files are not under the configured
`base_dir`; andthe tools still disclose those outside files through traversal identifiers.The official context reference describes history persistence and terminal
logging as filesystem-backed Dynamic Context features. The context security
documentation also treats absolute paths, path traversal, and sensitive files
as privacy/security risks. Reading files outside the configured context store
conflicts with that documented boundary.ImpactIf a PraisonAI application exposes these Dynamic Context tools to untrusted or
lower-trust prompts, the lower-trust caller can read files outside the
configured context storage when the target file can be reached with the
tool-imposed suffix:`history_*` tools can disclose reachable `.jsonl` files;`terminal_*` tools can disclose reachable `.log` files; andcross-run or cross-agent context/history/logs can be disclosed if their path
is known or guessable.This can expose conversation history, prompts, terminal output, command logs,
tokens, API keys, cloud credentials, operational data, or other secrets stored
in JSONL/log files readable by the PraisonAI process.The impact is confidentiality-only in the tested surface. Integrity and
availability are not claimed for this report.SeveritySuggested severity: High.Rationale:`AV`: applies when an application exposes an agent with these tools over a
network chat/API surface.`AC`: the traversal needs only chosen `run_id` and `agent_id` values.`PR`: an unauthenticated or public-facing agent endpoint can be exploited
without an account. Deployments that require authenticated chat/API access
may score this as `PR:L`.`UI`: the attacker directly supplies the prompt/tool argument to the
exposed agent surface.`C`: conversation history and terminal logs can contain secrets and private
operational data.`I:N/A`: this report demonstrates read-only disclosure.RemediationTreat `run_id` and `agent_id` as logical identifiers, not path components.Recommended fixes:Reject absolute paths, path separators, and traversal components in
`run_id` and `agent_id`.Build candidate paths, call `.resolve()`, and reject any path that is not
under `self.base_dir.resolve()`.Apply the same containment helper to history append/read/search/clear/export
and terminal log/read/search/clear/export paths.Prefer opaque server-generated run and agent IDs in tool schemas.Add regression tests for absolute `run_id`, `../` in `run_id`, and `../` in
`agent_id` for history and terminal tool factories.Minimal containment shape:Pair this with an identifier allowlist, because `run_id` and `agent_id` should
not need filesystem syntax.
CVSS v3.1: 7.5