GHSA-ppvx-rwh9-7rj7: pyload-ng: Authorization Bypass for SSL Certificate/Key Configuration Due to Option Name Mismatch in pyload-ng
SummaryThe `ADMIN_ONLY_CORE_OPTIONS` authorization set in `set_config_value()` uses incorrect option names `ssl_cert` and `ssl_key`, while the actual configuration option names are `ssl_certfile` and `ssl_keyfile`. This name mismatch causes the admin-only check to always evaluate to False, allowing any user with SETTINGS permission to overwrite the SSL certificate and key file paths. Additionally, the `ssl_certchain` option was never added to the admin-only set at all.DetailsThe vulnerability is in `src/pyload/core/api/__init__.py`. The `ADMIN_ONLY_CORE_OPTIONS` set is defined at lines 237-248:The actual config option names are defined in `src/pyload/core/config/default.cfg:39-41`:The authorization check at line 267 compares the incoming `(category, option)` tuple against this set:When a request arrives with `option=ssl_certfile`, the check evaluates `("webui", "ssl_certfile") in ADMIN_ONLY_CORE_OPTIONS` which is **False** because the set contains `("webui", "ssl_cert")`, not `("webui", "ssl_certfile")`. The admin-only guard is bypassed and `config.set()` at line 271 proceeds to write the attacker-supplied value.The value is cast as a `file` type in `parser.py:300-305`, which resolves it via `os.path.realpath()` but performs no further validation:On server restart with SSL enabled, the webserver loads the attacker-controlled paths (`webserver_thread.py:22-23,51-52`):PoCPrerequisites: A pyLoad instance with SSL enabled and a non-admin user account that has SETTINGS permission.**Step 1:** Authenticate as the non-admin user to get a session cookie:**Step 2:** Set the SSL certificate to an attacker-controlled file path:Expected response: `true` (config saved successfully)**Step 3:** Set the SSL key to an attacker-controlled file path:Expected response: `true` (config saved successfully)**Step 4:** Set the SSL certificate chain (never protected):Expected response: `true` (config saved successfully)**Step 5:** After the server restarts, it will load the attacker's certificate and key for all HTTPS connections.ImpactA non-admin user with SETTINGS permission can replace the SSL certificate and key used by the pyLoad HTTPS server. When the server restarts (or is restarted by an admin), it will serve HTTPS using the attacker's certificate/key pair. This enables:**Man-in-the-Middle attacks:** The attacker, possessing the private key for the now-active certificate, can intercept and decrypt all HTTPS traffic to the pyLoad instance, including admin credentials and session tokens.**Credential theft:** All users (including admins) connecting over HTTPS will have their credentials exposed to the attacker.**Configuration tampering:** With intercepted admin credentials, the attacker can escalate to full admin access.The attack requires SSL to already be enabled by an admin (the `use_ssl` option is correctly protected), the attacker to place certificate/key files on the filesystem (potentially achievable via pyLoad's download functionality), and a server restart.Recommended FixFix the option names in `ADMIN_ONLY_CORE_OPTIONS` and add the missing `ssl_certchain` option in `src/pyload/core/api/__init__.py`:
CVSS v3.1: 6.8