GHSA-xg76-5qj2-2hhv: Admidio: CSRF in SSO client `enable` action toggles SAML/OIDC clients without token validation
Summary`modules/sso/clients.php` validates an `adm_csrf_token` on every state-changing branch except `enable`. The `enable` case loads the SAML or OIDC client by UUID, calls `$client->enable($enabled)`, and persists the new state with no token check. Because the action is reachable via plain GET parameters, a third-party page can trick an authenticated administrator into disabling (or silently re-enabling) any configured SAML or OIDC client. Disabling an SSO client breaks every downstream relying-party application that authenticates through it.DetailsVulnerable Code`modules/sso/clients.php:84-115` — the file's other branches each begin with `SecurityUtils::validateCsrfToken($_POST['adm_csrf_token']);`, but `case 'enable':` does not:The `enable($enabled)` call is documented to set a single boolean column on the SAML / OIDC client row — `smc_enabled` for SAML, `ocl_enabled` for OIDC — and `save()` persists the change immediately. The handler accepts plain GET (`admFuncVariableIsValid($_GET, 'enabled', 'boolean')`), so a `<img src=...>` or auto-submitting form is sufficient.Exploitation FlowAttacker prepares a hostile page that loads (e.g.) `<img src="http://victim.example/modules/sso/clients.php?mode=enable&uuid=<known-sso-client-uuid>&enabled=0">`. The client UUID can be observed by anyone who has visited the SSO settings, by anyone who has crawled the SAML metadata endpoint, or by anyone with read access to the SSO clients table — but the value is also enumerable: an admin viewing the list of SSO clients in the UI exposes `data-uuid` attributes in the rendered HTML, and SSO metadata endpoints (e.g. `modules/sso/saml.php?metadata=1&uuid=...`) confirm valid UUIDs by returning XML.An Admidio administrator visits the hostile page while logged in. The browser sends Admidio's session cookie (which does not set `SameSite=Strict`).The server runs `case 'enable':` as the admin, sets `smc_enabled=0` (or `ocl_enabled=0`), and replies `{"success":true}`.The configured SAML / OIDC client is now disabled. Every downstream application authenticating through it gets `SYS_SSO_INVALID_CLIENT` on its next AuthnRequest / token-endpoint call. The outage persists until an admin notices and toggles it back on.The attacker can also flip the bit the other way: silently *re-enabling* a client that an admin had previously deactivated (perhaps because of a security concern with that relying party).PoCTested on HEAD `c5cde53`. To produce a deterministic test target, an SSO client is provisioned directly in the DB:The change persists. The legitimate admin's UI continues to show the client as configured, but every SAML AuthnRequest fails until the bit is toggled back.ImpactIn an Admidio deployment that uses SSO for downstream relying parties, a CSRF lure targeted at an administrator results in:**SSO outage** for whichever client UUID the attacker chose. Users who depend on `app1.example/sso` (or similar) cannot log in. The outage persists until a human admin notices and re-enables the client by hand.**Stealthy re-activation** of a client the admin had previously deactivated for a security reason — for example, a relying party whose certificate had been compromised — by passing `enabled=1` instead of `0`.The impact is limited to the SAML / OIDC `_enabled` column; nothing else in the SSO state machine is mutated by this branch. Confidentiality is not affected. Availability is partial (`A:L`) because only one client at a time is hit, and only the SSO path of that client. Integrity is `I:L` because the `_enabled` bit is the only mutated column. `UI:R` reflects the admin-must-visit requirement; `PR:N` because the attacker needs no Admidio credentials of their own.Recommended FixAdd the CSRF check and switch the trigger from GET to POST:Update the JS call site that drives the enable/disable toggle to POST the form's CSRF token (the page already renders `adm_csrf_token`).A regression test should issue a `GET /modules/sso/clients.php?mode=enable&uuid=<x>&enabled=0` with an admin cookie but no token, and assert the response rejects the request and the client's `_enabled` column is unchanged.
CVSS v3.1: 5.4