GHSA-rxmp-8h9v-56cx: NetBird has Race Condition on UpdateUser Function, Resulting in Privilege Escalation From Admin to Owner
SummaryA race condition vulnerability allows authenticated admin-privileged users to escalate to owner privilege.DetailsThe vulnerability exists in the `updateUser` function, which is connected to the `/users/{userId}` PUT request. This function then calls the `SaveOrAddUsers` function, which checks the user's permissions on two separate occasions. The first check verifies whether the initiator is an admin or owner and rejects the request if the initiator is not. The second check retrieves the user role details from the database again and saves them in a variable called `initiatorUser`.`SaveOrAddUsers` Function**Location:** `netbird/management/server/user.go` — Line 556![SaveOrAddUsers function code showing the two separate permission checks](https://github.com/user-attachments/assets/821e79a2-ad3e-45d7-a952-daf5422c1801)Afterwards, the `validateUserUpdate` function is called, which checks if the initiator has permission to update that specific user's role. This validation is lacking, as it assumes the initiator is an admin or owner. In the case that the initiator is a regular user, these conditions do not apply, and the target can be updated to owner even when the initiator holds only a user role.`validateUserUpdate` Function**Location:** `netbird/management/server/user.go` — Line 862![validateUserUpdate function code showing the insufficient permission validation logic](https://github.com/user-attachments/assets/a7e7f2df-ee4c-45b4-9b4d-c71c605dbaaa)In summary, if the initiator's permission is **admin** at the first check and gets dropped to **user** at the second check, the initiator can update a user to **owner**.Proof of ConceptIt is possible to create the following attack:The initiator (`old_admin`) creates two different accounts — one with a **user** role and another with an **admin** role. These will be referred to as `new_user` and `new_admin` from here on.Two different requests are needed:**Request 1** — Using `new_admin`'s JWT, a request is created that changes `old_admin`'s role to **user**.**Request 2** — Using `old_admin`'s JWT, a request is created that changes `new_user`'s role to **owner**.Both requests need valid user IDs and `auto_groups` group IDs. They should be sent simultaneously without waiting for prior requests to return.There is a very small time gap between the first and second permission checks, so multiple tries and multiple copies of the requests may be needed. During a penetration test engagement, privilege escalation was achieved by using **5 copies of Request 1** and **100 copies of Request 2** without waiting for any request to complete. The request that updated the role to owner returned **500** status codes instead of **403**, which when retried returned **200** and successfully applied the update.The following Burp Suite race condition script was used. Note that it may still require multiple tries, and the `old_admin` account role must be reset to **admin** after every failed attempt.ImpactAn attacker with an admin account on the self-hosted NetBird management application **v0.65.2 or lower** can escalate to owner privileges.
CVSS v3.1: 4.4