GHSA-958h-qp3x-q4gj: AVideo: IDOR in PayPalYPT Plugin Allows Any Authenticated User to Cancel Arbitrary PayPal Subscription Agreements
Summary`plugin/PayPalYPT/agreementCancel.json.php` cancels a PayPal billing agreement using an attacker-supplied `agreement` parameter without verifying that the authenticated user owns the agreement. A low-privilege authenticated user who learns or obtains another user's PayPal billing agreement ID can silently suspend the victim's recurring subscription, causing revenue loss to the platform and loss of paid service to the victim.DetailsAVideo's PayPalYPT plugin ships two near-duplicate endpoints that cancel a PayPal billing agreement. Only one of them enforces ownership:`plugin/PayPalYPT/PayPalAgreementCancel.json.php:19` — correctly requires either admin or the agreement's owner:`plugin/PayPalYPT/agreementCancel.json.php:9-26` — only checks `User::isLogged()` (in fact twice, redundantly) and then calls the cancellation directly:`PayPalYPT::cancelAgreement()` at `plugin/PayPalYPT/PayPalYPT.php:548-566` resolves the agreement ID against PayPal and calls `$createdAgreement->suspend($agreementStateDescriptor, $apiContext)` unconditionally — the server does not verify that the logged-in user's `users_id` matches the owner recorded in `PayPalYPT_log` (or wherever the agreement was registered):The intended UI caller is `subscriptions_list.php:84` which posts the current user's own agreement IDs — but the server accepts any `agreement` parameter from any logged-in user. Agreement IDs can leak via `_error_log` entries written in `agreementCancel.json.php:34` and `webhook.php` during normal operation, via PayPal receipt emails, or via other administrative and payment-log screens. No CSRF token is required, but the root defect is missing authorization, not CSRF.PoCLog in as any low-privilege user (registered subscriber, commenter, free-tier account created via `signUp`).Obtain the target's PayPal agreement ID (e.g., `I-ABCD1234XYZ`). This may come from server error logs, email receipts, admin/payment screens, or other disclosures.Send the request with the victim's agreement ID:Expected response:The victim's billing agreement is suspended at PayPal via `Agreement::suspend()` (PayPalYPT.php:560). The victim stops being billed; AVideo subsequently reflects the subscription as inactive.ImpactAny authenticated user can silently cancel another user's active PayPal recurring billing agreement.Revenue disruption for the platform operator — any affected subscribers stop being billed.Service disruption for the victim — their paid subscription lapses.The defect is purely an authorization gap; the sister endpoint `PayPalAgreementCancel.json.php` demonstrates that the owner/admin check was intentional for this action but was not applied to this duplicate.Recommended FixPort the ownership check from the sister endpoint into `agreementCancel.json.php`:Alternative, preferred remediation: delete the duplicate `agreementCancel.json.php` entirely and point the `cancelAgreement()` JS helper in `subscriptions_list.php:84` at the already-protected `PayPalAgreementCancel.json.php` endpoint (sending the expected `agreement_id` POST field). While patching, also remove the redundant second `User::isLogged()` branch at line 19.
CVSS v3.1: 4.2