GHSA-q8r6-5hfw-5jff: guzzlehttp/guzzle-services' XML Request Serialization Vulnerable to XML Injection via CDATA Terminator
Impact`guzzlehttp/guzzle-services` does not safely serialize scalar XML element values containing the CDATA terminator `]]>`. The XML request serializer writes values containing `<`, `>`, or `&` with `XMLWriter::writeCData($value)`. If attacker-controlled input contains `]]>`, the CDATA section closes early and the remainder is interpreted as XML markup. This is an outgoing request-body integrity issue, not a response parsing issue. The attacker does not need to control the service description or schema.Users are affected when all of the following are true:The application uses `guzzlehttp/guzzle-services` to serialize outgoing requests.A request parameter or `additionalParameters` schema uses `location: xml`.The value is serialized as XML element text, not an XML attribute.The value can contain attacker-controlled, user-controlled, tenant-controlled, or otherwise untrusted input.The value is not constrained by a safe `enum`, `pattern`, or custom filter that excludes `]]>`.The downstream service parses the generated XML structurally and may act on unexpected, duplicated, or injected elements.Applications that serialize untrusted input into `location: xml` request parameters can emit XML containing attacker-controlled elements outside the intended text node. Depending on the receiving service, this can alter operation semantics, smuggle privileged fields, bypass modeled parameter boundaries, or create conflicting duplicated elements. Fixed service descriptions are sufficient if they contain an XML element parameter populated from attacker-controlled input.Users are not directly affected if they only use Guzzle Services to deserialize HTTP response bodies. Response XML parsing uses the response XML location visitor and does not invoke the vulnerable request XML serializer. Response bodies matter only in a second-order flow, such as parsing attacker-controlled response XML, storing or forwarding a parsed string value, and later using it as a `location: xml` request parameter.Example fixed service description:If an attacker-controlled display name is:the vulnerable serializer can emit an injected element outside the intended `DisplayName` text node:If the downstream service treats `<Role>` as meaningful, the attacker has set a field the modeled `DisplayName` parameter was not intended to set.PatchesThe issue is patched in `1.5.4` and later by safely splitting embedded CDATA terminators before serialization. The fix preserves the original scalar value as XML text and prevents injected nodes.WorkaroundsIf you cannot upgrade immediately, constrain attacker-controlled XML element values with a strict `enum`, `pattern`, or custom filter that excludes `]]>`, or avoid serializing untrusted data into `location: xml` element text until patched. Where appropriate for the service schema, XML attributes are not affected because they are written with XMLWriter attribute APIs rather than CDATA sections.To determine whether action is needed, search service descriptions for request parameters using `location: xml`, including operation `parameters` and `additionalParameters`. Response-only `models` are not directly affected unless parsed values are reused for request serialization. For object and array parameters, review nested scalar properties because leaf element values can still be affected.Referenceshttps://www.w3.org/TR/xml/#sec-cdata-secthttps://www.php.net/manual/en/xmlwriter.writecdata.phphttps://www.php.net/manual/en/xmlwriter.text.php
CVSS v3.1: 5.8