GHSA-57f6-pvx8-hwj6: turso-cli persists Turso platform JWT with world-readable (0o644) file permissions
Summary`turso-cli` persists the user's Turso platform JWT to `settings.json` using Viper's default `configPermissions` of `0o644`, leaving the credential file world-readable on standard Linux and macOS systems. Any other local UID on the host can read the file and recover the platform JWT, which grants full Turso platform access scoped to the user's organizations.ImpactThe token in `settings.json` grants the holder full Turso platform access — create or destroy databases, rotate credentials, exfiltrate data, change billing settings — for any organization the user belongs to.Because the file is world-readable, the credential is reachable by:Cron jobs or daemons running as a different system user on the same hostSandboxed CI runners with a mounted home directoryContainers with a bind-mounted host homeCo-tenants on a shared multi-user developer or jumpbox hostThe file path resolves through `configdir.LocalConfig("turso")`:macOS: `~/Library/Application Support/turso/settings.json`Linux: `~/.config/turso/settings.json` (or `$XDG_CONFIG_HOME/turso/settings.json`)It contains the platform JWT in plaintext JSON alongside `organization` and `username` fields.Comparable CLIs (`gh`, `aws`, `docker`, `gcloud`, plus close peers `planetscale`, `neon`, `upstash`) write credential files at `0o600` explicitly, so this is a deviation from the cross-vendor baseline rather than a deliberate trade-off.DetailsThe OAuth callback handler stores the platform JWT via the settings layer:`SetToken` writes through Viper:Persistence runs through `viper.WriteConfig`:Viper v1.21.0 (pinned in `turso-cli` `go.mod`) initializes `configPermissions` to `os.FileMode(0o644)` at `viper.go:198` and passes that mode straight to `os.OpenFile` at `viper.go:1688`. Without a call to `viper.SetConfigPermissions(0o600)`, the resulting `settings.json` is created at `0o644`.A `grep` over the auth-config write path under `internal/` returns zero hits for `Chmod`, `0o600`, or `0600`, confirming there is no follow-up tightening of the file mode anywhere on the persistence path.Proof of conceptMinimal reproducer using the same Viper version `turso-cli` pins (`github.com/spf13/viper v1.21.0`):$ go run main.go mode: 644The same `SafeWriteConfig` / `WriteConfig` calls `turso-cli` uses produce the same `0o644` mode in a real `turso auth login` flow.RemediationOne-line fix at the existing Viper configuration site in `internal/settings/settings.go` (around lines 48-50):Defense in depth:Add `os.Chmod(configFile, 0o600)` after `TryToPersistChanges`, or on read (as PlanetScale does in `internal/config/config.go` — they `Stat` the token file and self-heal if `Mode() &^ 0o600` is nonzero).  `viper.SetConfigPermissions` applies only on file creation, so an existing wider-mode file is not tightened otherwise.Add `os.Chmod(configPath, 0o700)` after `configdir.MakePath(configPath)` (line 43) to close the equivalent gap on the enclosing directory, which is otherwise created under the default umask.Patch: https://github.com/tursodatabase/turso-cli/commit/ffb914849216ef5a86353b3fa6cee66f33af3b66WorkaroundsUntil upgraded, users can tighten the existing files manually:This must be repeated after any operation that recreates the file (e.g.
`turso auth login`) until the patched version is installed.ResourcesPatch commit: https://github.com/tursodatabase/turso-cli/commit/ffb914849216ef5a86353b3fa6cee66f33af3b66Viper `configPermissions` default: https://github.com/spf13/viper/blob/v1.21.0/viper.go#L198Viper write path: https://github.com/spf13/viper/blob/v1.21.0/viper.go#L1688CWE-276: https://cwe.mitre.org/data/definitions/276.htmlCWE-732: https://cwe.mitre.org/data/definitions/732.html
CVSS v3.1: 5.5