GHSA-g6vg-wj8f-48cj: Centrifugo's dynamic JWKS key cache keyed only by `kid` allows cross-issuer JWT authentication bypass
SummaryCentrifugo's dynamic JWKS endpoint feature can verify a JWT for one allowed issuer using a public key cached from another allowed issuer. The JWKS cache and `singleflight` lookup are keyed only by the JWT header `kid`, not by the resolved JWKS endpoint, issuer, audience, or other trust-domain namespace.In a documented multi-issuer dynamic JWKS configuration, an attacker who can obtain or mint a valid token for issuer/tenant A can authenticate as issuer/tenant B if both JWKS documents use the same `kid` value and tenant A's key is cached first. This affects connection token verification and subscription token verification because both paths use the same JWKS verification manager.DetailsThe vulnerable path is reachable when either of these shipped configuration options is set to a templated JWKS URL using values derived from JWT `iss` or `aud` claims:`client.token.jwks_public_endpoint``client.subscription_token.jwks_public_endpoint`Relevant shipped config fields are defined in `internal/configtypes/types.go:59-65`, mapped into verifier configuration in `internal/confighelpers/jwt.go:36-41`, and exposed in the generated config schema at `internal/cli/configdoc/schema.json:3927`, `3947`, `3967`, `3987`, `4069`, `4089`, `4109`, and `4129`. Dynamic JWKS endpoints based on `iss` and `aud` are documented in the project changelog at `CHANGELOG.md:107`.External clients control JWT connection and subscription tokens:Connection tokens reach `VerifyConnectToken` from `internal/client/handler.go:350-352`.Normal subscription tokens reach `VerifySubscribeToken` from `internal/client/handler.go:769-775`.Subscription refresh tokens reach `VerifySubscribeToken` from `internal/client/handler.go:628-632`.The verifier must parse token claims before signature verification to resolve the dynamic JWKS endpoint:`VerifyConnectToken` parses without verification at `internal/jwtverify/token_verifier_jwt.go:528-535`, extracts template variables before signature verification at `internal/jwtverify/token_verifier_jwt.go:539-548`, then validates claims only after signature verification at `internal/jwtverify/token_verifier_jwt.go:557-560`.`VerifySubscribeToken` follows the same pattern at `internal/jwtverify/token_verifier_jwt.go:700-732`.The problem is that the JWKS cache lookup ignores the endpoint/trust domain selected by those token variables. `internal/jwtverify/token_verifier_jwt.go:242-245` passes only the JWT header `kid` plus token-derived variables to the JWKS manager:`internal/jwks/manager.go:96-117` checks cache and `singleflight` using only `kid`:The resolved JWKS URL is computed only later in `internal/jwks/manager.go:133-149`:The TTL cache also stores and retrieves keys only by `kid` at `internal/jwks/cache_ttl.go:82-101`:As a result, a key fetched from tenant A's JWKS endpoint can be reused to verify a token claiming tenant B before tenant B's JWKS endpoint is consulted.I also reviewed the template safety mitigation in `internal/jwtverify/validate.go:99-154`. It restricts placeholder regex groups to finite literal alternatives, which helps prevent arbitrary endpoint substitution, but it does not scope cached keys by the resolved endpoint or issuer/audience namespace. The PoC uses a validator-accepted issuer regex: `^(?P<tenant>tenant-a|tenant-b)$`.PoCThis is a safe local-only unit test using `httptest.Server` and generated RSA key pairs. It does not contact external systems.From a clean checkout of `centrifugal/centrifugo` at commit `458ee0500f046877d7e8375e32f5e842bc95535b`, add this file as `internal/jwtverify/jwks_cache_poc_test.go`:Run the focused test with the project-supported Go toolchain:Observed vulnerable output in my local test environment using Go 1.26.3:The passing test demonstrates the vulnerable behavior because it asserts these controls:A legitimate tenant-B token signed by tenant B succeeds with a fresh verifier.A forged tenant-B token signed by tenant A fails with a fresh verifier.A legitimate tenant-A token succeeds and primes the JWKS cache with tenant A's `shared-kid` key.The forged tenant-B token signed by tenant A then succeeds with user ID `victim`.The tenant-B JWKS request counter does not increase during forged verification, proving the forged token was accepted from the cross-tenant cache hit rather than from tenant B's JWKS endpoint.Expected behavior after a fix: the forged tenant-B token should remain rejected after tenant A primes the cache, or the verifier should fetch/consult tenant B's independent JWKS cache namespace before verification.ImpactThis is a cross-issuer / cross-tenant JWT authentication bypass in dynamic JWKS deployments.Impacted deployments are those that use dynamic JWKS endpoint templates to select different JWKS URLs for different allowed issuers or audiences, for example multi-tenant deployments using `{{tenant}}` values extracted from `iss` or `aud`.An attacker who can obtain or mint a valid token for one allowed issuer/tenant can authenticate as another allowed issuer/tenant if both JWKS documents use the same `kid` value and the attacker's issuer key is cached first. `kid` values are not globally unique by specification and are often operational labels such as `current`, `default`, or rotation identifiers, so the verifier should not rely on `kid` uniqueness across different JWKS trust domains.Potential consequences include:Authentication as a user in another issuer/tenant namespace.Unauthorized connection-token acceptance.Unauthorized subscription-token acceptance where separate subscription JWTs are configured.Cross-tenant confidentiality and integrity impact when issuer-derived JWKS endpoints are used as separate trust domains.Suggested remediationScope JWKS cache entries and `singleflight` keys to the resolved JWKS trust domain, not only to the JWT `kid`.For dynamic endpoints, compute the endpoint namespace before cache lookup and use a composite cache key such as:or an equivalent canonical trust-domain identifier plus `kid`.The same composite namespace should be used for:TTL cache lookup.TTL cache storage.`singleflight.Group.Do` keys.A regression test should prime tenant A's cache and then verify that a forged tenant-B token signed by tenant A remains rejected.
CVSS v3.1: 8.2