The location of Kaanapali shores is decent, it's in the center of Lahaina, roughly equidistant from Lahaina town (about 10 minutes away) and from many beaches (10 minutes to start of Road to Hana). You can walk to markets and other things. There is a food truck area right next door which is nice. The property itself is mediocre, everything looks like it was built 40 years ago. There are two pools: one with rocks and walk in, decent for little kids. The other is a deeper swimming pool, closer to the beach. The beach at the property is not usable, it's just rocks. Fortunately there are lots of other beaches nearby, but not particularly walking distance (you could, but it's far). But 5-10min drive away there are lots of beaches.
The unit itself is quite dated and rundown. The master suite has a tiny bathroom, but it's nice to have two full bathrooms in the unit. The second bedroom doesn't really have any natural light, there's a small window that opens to the outside hallway. There's also a glass-topped nightstand, which seems like a bad idea between your kids' beds (we removed it and stored it while we were there). The room itself is kind of smelly, like old carpet. There is a fully galley kitchen which is nice, induction stove top, dishwasher, microwave, some random useful appliances (like a blender and electric grill). But almost no basic ingredients (there was some table salt, soy sauce, and oil). There are some beach items like boogie board and chairs which are nice to have around, we used the chairs daily. The view is not bad, you can see the water from the living room area (which has a couch and a dining table), but it's kind of far. Mostly you see the pool. It faces west. There are three TVs in the unit, but we tried two of them and neither worked, we didn't bother with the third.
There's onsite parking for additional money. There is a restaurant on site, but it's mediocre. There's a fun, make-your-own pancake shop across the street, the kids enjoyed it! There's a great fish market and an organic market about half a mile up the street, coffee shops, and local markets.
While we stayed, the building wanted us to leave the unit to clean the glass on the inside and outside of the unit AND they also wanted to spray the unit with aerosol-based chemicals for bugs. We refused either, it was pretty annoying-- plus we didn't want to return to an old unit that was now filled with pesticide. We messaged the host and their answer was polite but not helpful.
What else? A bonus is that adjacent to the unit is a "meeting room" -- and no one was ever in it, so that's nice and quiet, the whole unit was relatively quiet. Some banging around early in the morning (travelers are often jet lagged). The water pressure is good.
Altogether, the unit is not as expensive as nearby, nicer hotels. But it's also less expensive. I think the value is not amazing, but it's "fine". Don't expect much and you'll be pretty happy.