We had a great time in Edinburgh, views from the apartment are really cool. Even in the middle/tail end (hopefully) of the pandemic Edinburgh was busy, though lots of things needed pre-booking that wouldn't normally, including pubs!!
Access to the attic bedroom won't be suitable for all, the stairs are closer to a wide rung ladder, but it's a nice bedroom with a decent bed and top views from the window. Overall a great place to stay.