We loved the location! The castle was literally right outside the flat!!
For us being close to everything is important, but don't need to be right in the thick of it. Having Grassmarket so close was great to grab a drink on our way home in the evenings.
We are on a 3 week holiday so the washing machine (and dryer) was important to us! We appreciated the drying rack as well.