Apartment location is more than perfect. There is no need for any kind of transportation since most of attractions are nearby.
Definitely I will recommend it for any one planning to visit Edinburgh.