Great location for a weekend trip to Edinburgh.
Portobello itself is a great area with a beach, promenade and some good pubs, but also just an hour walk or 20 min bus ride into central Edinburgh.
Cozy flat with everything you could need we would definitely recommend.