Perfect location for our month long family vacation. The flat was very spacious and the kitchen well stocked. There were plenty of retail shops and restaurants nearby plus a Tesco Express and Margiotta (grocery store). We walked to St Andrew's Square, Stockbridge, Cannonmills, and the Royal Mile, but if you'd rather ride a bus, there was a stop very nearby and Waverly train station was less than a mile. The only downside was the internet, which glitched in and out frequently. If you are here just for holiday, then it shouldn't be a problem; but for us working from home it was a bit cumbersome.
Our favorite family places: Cumberland Bar (just down the street and kid friendly until 9p); Neighbourgood Market (outdoor food trucks and music); St Andrews Square (picnics and lots to see); Dynamic Earth (interactive museum); Chocolatarium (tour and make your own chocolate bar) and of course all the historical spots like the Castle, Arthur's Seat and Holyrood Palace. The Hop on/Hop off bus tour is a great way to get familiar with the city.
Our favorite adult places: 56 North (gin bar in the University area); SipAntics (Gary will guide you through making your own bottle of gin); Condita (Michelin star restaurant); Queens Arms (bar with tvs and trivia...most bars in Edinburgh do not have tvs like the US); Leith area bars.
A few things I would find helpful for spring/summer travel: lots of walking up and down steep hills, so leave those fancy shoes behind and opt for sneakers or boots; it rains a lot, but not for long periods of time, so don't fret over an umbrella, just carry a poncho or rain jacket at all times; the wind can pick up to 30 mph gusts so carry a scarf/hat to fight the chill and wear layers...the weather changes by the hour; June is the shoulder season...kids are still in school in the UK so the city is not too crowded, but after July 1 the crowds increase dramatically.
All in all, we will be back!! I fell in love with the city and can't wait to visit again next year. Cheers!