A perfect location if you're visiting the Castle or the Tattoo! In fact most places easily reached. Edinburgh is definitely worth a visit - it's such a lovely place! We particularly enjoyed exploring the New Town - and climbing Arthur's Seat!
A useful bit of info from us: The luggage store at the train station charges £6 for up to three hours, with the next option at £12 for up to 12 hours - per case/bag!! Alternatively, at the bus station in Elder Street luggage lockers (which can hold multiple bags) charge £5 for small, £6.50 medium, £8 large for each 12 hour period.