You will not beat this location. Right in the heart of the Grassmarket. Step out the door, walk 5 secs and you’re looking up at the castle.
4 of us stayed there and we’d go back again. It’s lovely and modern and fresh.
Book the roof terrace across the road at Cold Town House for views of the castle while you eat freshly made pizza. They brew their own beer too.