This location was good for us because we were only staying one night before flying home.
It is on the harbor and has great views but I wouldn't want to stay there during my entire time in Edinburgh. It is very industrial and surrounded by multiple high rise, identical apartments. There is an ASDA about 10-15 minute walk away but really nothing else. No restaurants or shopping nearby. And of course, asda isn't really where you want to go while in Scotland.
The flat itself was quite large and the kitchen was nice and updated. It wasn't as clean as other places we've stayed and some of the windows were broken so we couldn't open them.
Overall though, it worked quite well for us. The TV was large and the sofa comfy if you're into that kind of thing. Check out was also seamless!