This is a very good location. But we knew that before booking, as we are originally from Edinburgh. Loads of restaurants, pubs by the dozen, and a grocery store are all within 5 minutes walk. The major attractions of the city; Castle, Princes St., Palace, etc, are also within walking distance, and if it is necessary to go further afield, public transit is plentiful and easy (they take visa). Only the minimal amount of cash would be needed. Visa works for just about everything and is contactless. There is no parking, but you are better off without a car.
The unit is very small, but big enough and comfortable enough for a couple for a week or two.