I used to live in Edinburgh and can say this is a great location. You are on the Royal Mile which is the central hub of the city, but far enough down the street that it is quiet and less foot traffic. The flat is warm and has plenty of light, and heated bathroom tiles were a great plus!