We had a great time in Edinburgh. The flat was nice, clean and in a good location. Beds were comfortable, which is always a plus! A short walk to the train station, restaurants, market and taxi pick up. Very easy to hop on the train and go to Glasgow for the day. It was a little difficult to get an Uber. I would recommend a taxi here. Be aware that there are 2 sets of long winding stairs up to the flat and no elevator. If you have any medical issues, this might not be for you.
The only problem we had, is that one of the days the hot water was not working so well. The shower would go from very hot to ice cold in a matter of seconds and then back to very hot after fiddling with it for a bit. Never could get it to be warm. Took me an hour to take a shower while I mostly froze. It took my husband a while to figure out how to fix it. If you have this problem, turn the water heater off and then on to reset. It only happened once during our week stay. Other than that, it was great!