Datasets:

akumoth

/

peewee-issues

like 0

{ "login": "extesy", "id": 65872, "node_id": "MDQ6VXNlcjY1ODcy", "avatar_url": "https://avatars.githubusercontent.com/u/65872?v=4", "gravatar_id": "", "url": "https://api.github.com/users/extesy", "html_url": "https://github.com/extesy", "followers_url": "https://api.github.com/users/extesy/followers", "following_url": "https://api.github.com/users/extesy/following{/other_user}", "gists_url": "https://api.github.com/users/extesy/gists{/gist_id}", "starred_url": "https://api.github.com/users/extesy/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/extesy/subscriptions", "organizations_url": "https://api.github.com/users/extesy/orgs", "repos_url": "https://api.github.com/users/extesy/repos", "events_url": "https://api.github.com/users/extesy/events{/privacy}", "received_events_url": "https://api.github.com/users/extesy/received_events", "type": "User", "site_admin": false }

[]

[]

[ "What SQL was generated previously? Was an alias used? Sorry I don't recall.\n", "I don't know, probably just quotes around the table name, just like right after UPDATE word.\n", "This should be fixed by bb48ca37fcdd2728c469c50aee8cb824a8aff4f1\n" ]

"2014-08-14T04:12:04"

"2014-08-19T20:17:37"

"2014-08-19T18:17:54"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/414/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "alexlatchford", "id": 628146, "node_id": "MDQ6VXNlcjYyODE0Ng==", "avatar_url": "https://avatars.githubusercontent.com/u/628146?v=4", "gravatar_id": "", "url": "https://api.github.com/users/alexlatchford", "html_url": "https://github.com/alexlatchford", "followers_url": "https://api.github.com/users/alexlatchford/followers", "following_url": "https://api.github.com/users/alexlatchford/following{/other_user}", "gists_url": "https://api.github.com/users/alexlatchford/gists{/gist_id}", "starred_url": "https://api.github.com/users/alexlatchford/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/alexlatchford/subscriptions", "organizations_url": "https://api.github.com/users/alexlatchford/orgs", "repos_url": "https://api.github.com/users/alexlatchford/repos", "events_url": "https://api.github.com/users/alexlatchford/events{/privacy}", "received_events_url": "https://api.github.com/users/alexlatchford/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Nice, thanks for this!\n" ]

"2014-08-10T23:45:38"

"2014-09-06T12:49:50"

"2014-09-06T12:49:47"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/413/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/413", "html_url": "https://github.com/coleifer/peewee/pull/413", "diff_url": "https://github.com/coleifer/peewee/pull/413.diff", "patch_url": "https://github.com/coleifer/peewee/pull/413.patch", "merged_at": "2014-09-06T12:49:46" }

{ "login": "arski", "id": 904818, "node_id": "MDQ6VXNlcjkwNDgxOA==", "avatar_url": "https://avatars.githubusercontent.com/u/904818?v=4", "gravatar_id": "", "url": "https://api.github.com/users/arski", "html_url": "https://github.com/arski", "followers_url": "https://api.github.com/users/arski/followers", "following_url": "https://api.github.com/users/arski/following{/other_user}", "gists_url": "https://api.github.com/users/arski/gists{/gist_id}", "starred_url": "https://api.github.com/users/arski/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/arski/subscriptions", "organizations_url": "https://api.github.com/users/arski/orgs", "repos_url": "https://api.github.com/users/arski/repos", "events_url": "https://api.github.com/users/arski/events{/privacy}", "received_events_url": "https://api.github.com/users/arski/received_events", "type": "User", "site_admin": false }

[]

[]

[ "You were very close -- the best way to get the result size if you plan to iterate anyways, is to call `list()` on the query and then take the length of that.\n\n``` python\nquery = User.select()\nnum_results = len(list(query))\nfor item in query:\n print item\n```\n\nThis will only result in a single select query being issued.\n", "Aha, thank you!\n" ]

"2014-08-07T07:11:39"

"2014-08-07T13:12:53"

"2014-08-07T13:10:33"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/412/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "Amleto", "id": 2996796, "node_id": "MDQ6VXNlcjI5OTY3OTY=", "avatar_url": "https://avatars.githubusercontent.com/u/2996796?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Amleto", "html_url": "https://github.com/Amleto", "followers_url": "https://api.github.com/users/Amleto/followers", "following_url": "https://api.github.com/users/Amleto/following{/other_user}", "gists_url": "https://api.github.com/users/Amleto/gists{/gist_id}", "starred_url": "https://api.github.com/users/Amleto/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Amleto/subscriptions", "organizations_url": "https://api.github.com/users/Amleto/orgs", "repos_url": "https://api.github.com/users/Amleto/repos", "events_url": "https://api.github.com/users/Amleto/events{/privacy}", "received_events_url": "https://api.github.com/users/Amleto/received_events", "type": "User", "site_admin": false }

[]

[]

[ "You can try logging: http://docs.peewee-orm.com/en/latest/peewee/cookbook.html#logging-queries\n\nOr you can implement `Database.sql_error_handler` http://docs.peewee-orm.com/en/latest/peewee/api.html?highlight=sql_error_handler#Database.sql_error_handler\n\nPlease comment if you find that this is an error in peewee.\n" ]

"2014-08-04T20:04:44"

"2014-08-04T20:06:50"

"2014-08-04T20:06:50"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/411/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "tfeldmann", "id": 385566, "node_id": "MDQ6VXNlcjM4NTU2Ng==", "avatar_url": "https://avatars.githubusercontent.com/u/385566?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tfeldmann", "html_url": "https://github.com/tfeldmann", "followers_url": "https://api.github.com/users/tfeldmann/followers", "following_url": "https://api.github.com/users/tfeldmann/following{/other_user}", "gists_url": "https://api.github.com/users/tfeldmann/gists{/gist_id}", "starred_url": "https://api.github.com/users/tfeldmann/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tfeldmann/subscriptions", "organizations_url": "https://api.github.com/users/tfeldmann/orgs", "repos_url": "https://api.github.com/users/tfeldmann/repos", "events_url": "https://api.github.com/users/tfeldmann/events{/privacy}", "received_events_url": "https://api.github.com/users/tfeldmann/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Yeah, I think you're right... Perhaps the `ExceptionWrapper` code is getting in the way. Let me look into it.\n\nPS, you can use the `playhouse.pool.PooledMySQLDatabase` with a stale timeout and it will automatically recycle connections for you. Docs: http://docs.peewee-orm.com/en/latest/peewee/playhouse.html#pool\n", "How experimental is this module really? Anything I have to consider?\n", "> How experimental is this module really?\n\nI myself have not used it in deployment (I use SQLite for most of my projects), but it's been unit tested and I believe it should be safe to use.\n\nAs an aside, I made a script that does what you described -- connect to a mysql db, create a row, kill the database server, try to create another row.\n\nWhen I try to create another row, the `sql_error_handler()` is being called.\n", "Strange. I tested this in an iPython Notebook and stopped the db manually. I'm using pymysql instead of MySQLdb -- maybe that's the cause?\nIf you send me the script I can test it on my machine.\n", "``` python\n#!/usr/bin/env python\n\nimport logging\n\nfrom peewee import *\nfrom peewee import create_model_tables\n\nclass FakeMySQLDatabase(MySQLDatabase):\n def sql_error_handler(self, exception, sql, params, require_commit):\n import ipdb; ipdb.set_trace()\n\ndb = FakeMySQLDatabase('peewee_test')\n\nclass BaseModel(Model):\n class Meta:\n database = db\n\nclass Testmodel(BaseModel):\n data = CharField()\n\ndef main():\n create_model_tables([Testmodel], fail_silently=True)\n Testmodel.create(data='1')\n raw_input('stop server and press enter')\n Testmodel.create(data='2')\n\nif __name__ == '__main__':\n main()\n```\n", "Alright, well I think that `sql_error_handler` is behaving correctly so I'm going to close. Please comment if you feel there is still an issue.\n", "Thanks for the script. I found it works successfully in Python2 with MySQLdb driver but fails with PyMySQL (0.6.2) in both Python2 and Python3. \n", "I got the error handler with pymysql using my script. The exception was:\n\n``` python\nOperationalError(2013, 'Lost connection to MySQL server during query')\n```\n", "The error is handled, but an ArgumentError follows:\n[peewee_issue410.py](http://pastebin.com/E2ZSWey3)\n\nMySqlDb\n\n```\npip install -U virtualenv\nvirtualenv test1\nsource test1/bin/activate\npip install mysql-python peewee\npython peewee_issue410.py\n\n# Output:\nStarting MySQL\n. SUCCESS! \nShutting down MySQL\n.... SUCCESS! \nError handled: (OperationalError(2006, 'MySQL server has gone away'), 'INSERT INTO `testmodel` (`data`) VALUES (%s)', [u'2'], True) {}\n```\n\nPyMySql:\n\n```\npip install -U virtualenv\nvirtualenv test2\nsource test2/bin/activate\npip install pymysql peewee\npython peewee_issue410.py\n\n# Output:\nStarting MySQL\n. SUCCESS! \nShutting down MySQL\n.... SUCCESS! \nError handled: (OperationalError(2013, \"Lost connection to MySQL server during query (error(54, 'Connection reset by peer'))\"), 'INSERT INTO `testmodel` (`data`) VALUES (%s)', [u'2'], True) {}\nTraceback (most recent call last):\n File \"peewee_issue410.py\", line 33, in <module>\n main()\n File \"peewee_issue410.py\", line 30, in main\n Testmodel.create(data='2')\n File \"/Users/thomasfeldmann/Desktop/test2/lib/python2.7/site-packages/peewee.py\", line 3038, in create\n inst.save(force_insert=True)\n File \"/Users/thomasfeldmann/Desktop/test2/lib/python2.7/site-packages/peewee.py\", line 3163, in save\n pk_from_cursor = self.insert(**field_dict).execute()\n File \"/Users/thomasfeldmann/Desktop/test2/lib/python2.7/site-packages/peewee.py\", line 2247, in execute\n return self.database.last_insert_id(self._execute(), self.model_class)\n File \"/Users/thomasfeldmann/Desktop/test2/lib/python2.7/site-packages/peewee.py\", line 2388, in last_insert_id\n return cursor.lastrowid\nAttributeError: 'Cursor' object has no attribute 'lastrowid'\n```\n", "Right -- you need to `return True` from the `sql_error_handler()` in order to re-raise the original exception.\n", "Okay, didn't know that, I didn't find that in the docs. But how would you stop the exception being thrown? `return False` doesn't work.\n", "Yeah, I guess the issue is with `pymysql` not assigning the `lastrowid` if the insert doesn't succeed. I think this behavior is acceptable, since you can still reconnect and re-execute the query from within the error handler.\n", "Upgrade your openssl. Also that is not even remotely related to peewee or\nthis ticket. Go away.\nOn Aug 22, 2015 6:35 AM, \"Sateesh H\" notifications@github.com wrote:\n\n> I have the below connection and using the Pooled database as shown below.\n> DATABASE = {\n> 'name': 'testdb',\n> 'engine': 'playhouse.pool.PooledPostgresqlExtDatabase',\n> 'register_hstore': False,\n> 'user': 'test',\n> 'host':'localhost',\n> 'password':'test',\n> 'port':5432,\n> 'max_connections': 100,\n> 'stale_timeout': 6000,\n> }\n> Still i m facing the same the error\n> \"OpenSSL error of the type “decryption failed or bad record mac”?\n> \n> Is there other way to solve this issue?\n> \n> —\n> Reply to this email directly or view it on GitHub\n> https://github.com/coleifer/peewee/issues/410#issuecomment-133678364.\n" ]

"2014-08-01T11:23:57"

"2015-08-22T12:59:49"

"2014-08-04T12:26:34"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/410/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "alexlatchford", "id": 628146, "node_id": "MDQ6VXNlcjYyODE0Ng==", "avatar_url": "https://avatars.githubusercontent.com/u/628146?v=4", "gravatar_id": "", "url": "https://api.github.com/users/alexlatchford", "html_url": "https://github.com/alexlatchford", "followers_url": "https://api.github.com/users/alexlatchford/followers", "following_url": "https://api.github.com/users/alexlatchford/following{/other_user}", "gists_url": "https://api.github.com/users/alexlatchford/gists{/gist_id}", "starred_url": "https://api.github.com/users/alexlatchford/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/alexlatchford/subscriptions", "organizations_url": "https://api.github.com/users/alexlatchford/orgs", "repos_url": "https://api.github.com/users/alexlatchford/repos", "events_url": "https://api.github.com/users/alexlatchford/events{/privacy}", "received_events_url": "https://api.github.com/users/alexlatchford/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I'm presuming the raw SQL produced should be something like this, which shows it's possible:\n\n``` sql\nSELECT\n a.title\nFROM\n article a,\n INNER JOIN news_feed nf ON a.news_feed_id = a.uuid\n INNER JOIN article_state ars ON ars.article_id = a.uuid\nWHERE\n nf.enabled = 1\n AND ars.state = 'a'\nGROUP BY\n a.title\nHAVING\n COUNT(ars.article_id) > 0\n```\n", "You can use [.switch()](http://docs.peewee-orm.com/en/latest/peewee/api.html#Query.switch) to switch the query context. I believe that's what you're looking for.\n", "Awesome, was looking for change instead of switch. Hate it when that happens! And with the docs literally just below where I was looking!\n" ]

"2014-07-31T23:38:04"

"2014-08-04T06:54:50"

"2014-08-01T12:51:44"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/409/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "tfeldmann", "id": 385566, "node_id": "MDQ6VXNlcjM4NTU2Ng==", "avatar_url": "https://avatars.githubusercontent.com/u/385566?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tfeldmann", "html_url": "https://github.com/tfeldmann", "followers_url": "https://api.github.com/users/tfeldmann/followers", "following_url": "https://api.github.com/users/tfeldmann/following{/other_user}", "gists_url": "https://api.github.com/users/tfeldmann/gists{/gist_id}", "starred_url": "https://api.github.com/users/tfeldmann/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tfeldmann/subscriptions", "organizations_url": "https://api.github.com/users/tfeldmann/orgs", "repos_url": "https://api.github.com/users/tfeldmann/repos", "events_url": "https://api.github.com/users/tfeldmann/events{/privacy}", "received_events_url": "https://api.github.com/users/tfeldmann/received_events", "type": "User", "site_admin": false }

[]

[]

[ "As a workaround I overrode the `create` method. Please let me know if there is a better way.\n\n``` python\nclass Dataset(BaseModel):\n id = BigIntegerField(primary_key=True)\n\n @classmethod\n def create(cls, *args, **kwargs):\n next_id = cls.select(fn.Max(cls.id)).scalar() + 1\n return super().create(id=next_id, *args, **kwargs)\n```\n", "Yes but it's not built-in at the moment. You can create a new field type and register it with the db, or create a subclass of the bigint field and override the `__ddl__()` method. [Here are docs on creating a custom field](http://docs.peewee-orm.com/en/latest/peewee/models.html#creating-a-custom-field).\n\nGoing the former route, you might:\n\n``` python\nclass AutoBigIntegerField(BigIntegerField):\n db_field = 'auto_bigint'\n\ndb = MySQLDatabase('mydb', ...)\ndb.register_fields('auto_bigint', 'BIGINT AUTO_INCREMENT')\n```\n\nI _believe_ that should do what you want.\n", "Thank you, cool stuff!\n`fields` must be a dict and `register_fields()` did not work (KeyError on `create_table()`, so I did this:\n\n``` python\ndatabase = MySQLDatabase(\n user=...\n ...\n fields={'auto_bigint': 'BIGINT AUTO_INCREMENT'},\n)\n```\n", "Oh right, yep just woke up... Cool well if that's working then I'm going to close. Please let me know if you are still encountering issues.\n" ]

"2014-07-25T11:40:46"

"2014-07-25T12:27:30"

"2014-07-25T12:27:30"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/408/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "lalstef", "id": 1503661, "node_id": "MDQ6VXNlcjE1MDM2NjE=", "avatar_url": "https://avatars.githubusercontent.com/u/1503661?v=4", "gravatar_id": "", "url": "https://api.github.com/users/lalstef", "html_url": "https://github.com/lalstef", "followers_url": "https://api.github.com/users/lalstef/followers", "following_url": "https://api.github.com/users/lalstef/following{/other_user}", "gists_url": "https://api.github.com/users/lalstef/gists{/gist_id}", "starred_url": "https://api.github.com/users/lalstef/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/lalstef/subscriptions", "organizations_url": "https://api.github.com/users/lalstef/orgs", "repos_url": "https://api.github.com/users/lalstef/repos", "events_url": "https://api.github.com/users/lalstef/events{/privacy}", "received_events_url": "https://api.github.com/users/lalstef/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Just an FYI that the `filter()` API is actually deprecated.\n\nThat aside, it looks like it's interpreting the foreign key as a column requiring a join. This query should accomplish what you want:\n\n``` python\nDataRow.select().where(DataRow.parent == 1234)\n```\n\nAlso, if you find yourself wanting to perform a join on the parent row, you need to use [Model.alias()](http://docs.peewee-orm.com/en/latest/peewee/api.html#Model.alias).\n" ]

"2014-07-25T10:06:38"

"2014-07-25T12:33:38"

"2014-07-25T12:33:38"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/407/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "bryhoyt", "id": 4769854, "node_id": "MDQ6VXNlcjQ3Njk4NTQ=", "avatar_url": "https://avatars.githubusercontent.com/u/4769854?v=4", "gravatar_id": "", "url": "https://api.github.com/users/bryhoyt", "html_url": "https://github.com/bryhoyt", "followers_url": "https://api.github.com/users/bryhoyt/followers", "following_url": "https://api.github.com/users/bryhoyt/following{/other_user}", "gists_url": "https://api.github.com/users/bryhoyt/gists{/gist_id}", "starred_url": "https://api.github.com/users/bryhoyt/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/bryhoyt/subscriptions", "organizations_url": "https://api.github.com/users/bryhoyt/orgs", "repos_url": "https://api.github.com/users/bryhoyt/repos", "events_url": "https://api.github.com/users/bryhoyt/events{/privacy}", "received_events_url": "https://api.github.com/users/bryhoyt/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I agree and have updated wrapped_count() to have `clear_limit` default to `False`. I also added the option to pass that parameter through the call to `count()`. Finally, I made it so that calls to `count()` for queries that have a limit or offset will use wrapped_count() instead.\n", "If for some reason I have misunderstood your concerns, please leave a comment. Based on my understanding of your comments I think I've fixed the behavior of count. Thanks for taking the time to bring these issues to my attention. I hope that you'll keep submitting quality issues like these!\n", "Everything looks great to me -- your commit addresses my concerns perfectly.\n\nMy only question at this point would be whether anyone out there is depending on the current behaviour. But hopefully not -- and it could be something you could perhaps handle better with a comment in the release notes or docs for the next version. I've checked flask-admin's peewee module, and it has no problems in either case, because it calls .count() before the limit is applied anyway.\n" ]

"2014-07-23T22:59:36"

"2014-07-24T02:57:08"

"2014-07-24T02:16:48"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/406/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "bryhoyt", "id": 4769854, "node_id": "MDQ6VXNlcjQ3Njk4NTQ=", "avatar_url": "https://avatars.githubusercontent.com/u/4769854?v=4", "gravatar_id": "", "url": "https://api.github.com/users/bryhoyt", "html_url": "https://github.com/bryhoyt", "followers_url": "https://api.github.com/users/bryhoyt/followers", "following_url": "https://api.github.com/users/bryhoyt/following{/other_user}", "gists_url": "https://api.github.com/users/bryhoyt/gists{/gist_id}", "starred_url": "https://api.github.com/users/bryhoyt/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/bryhoyt/subscriptions", "organizations_url": "https://api.github.com/users/bryhoyt/orgs", "repos_url": "https://api.github.com/users/bryhoyt/repos", "events_url": "https://api.github.com/users/bryhoyt/events{/privacy}", "received_events_url": "https://api.github.com/users/bryhoyt/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Additionally, I think count() should have a clear_limit parameter which it passes through to wrapped_count() -- I'm mentioning this as a comment here, not a separate issue, because it would only make sense if count deferred to wrapped_count for limits and offsets.\n", "> I think that's nice; exactly what you want in the case of distinct or group by. Wouldn't it make sense for it to do the same if the query has a limit or offset?\n\nYeah, now that I think about it I agree.\n", "Thanks, looks great -- really appreciate the quick fixes. I'm loving using Peewee with Flask -- thanks for the great ORM!\n" ]

"2014-07-23T22:43:39"

"2014-07-24T02:53:51"

"2014-07-24T02:13:18"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/405/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "bryhoyt", "id": 4769854, "node_id": "MDQ6VXNlcjQ3Njk4NTQ=", "avatar_url": "https://avatars.githubusercontent.com/u/4769854?v=4", "gravatar_id": "", "url": "https://api.github.com/users/bryhoyt", "html_url": "https://github.com/bryhoyt", "followers_url": "https://api.github.com/users/bryhoyt/followers", "following_url": "https://api.github.com/users/bryhoyt/following{/other_user}", "gists_url": "https://api.github.com/users/bryhoyt/gists{/gist_id}", "starred_url": "https://api.github.com/users/bryhoyt/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/bryhoyt/subscriptions", "organizations_url": "https://api.github.com/users/bryhoyt/orgs", "repos_url": "https://api.github.com/users/bryhoyt/repos", "events_url": "https://api.github.com/users/bryhoyt/events{/privacy}", "received_events_url": "https://api.github.com/users/bryhoyt/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Thanks for pointing this out.\n" ]

"2014-07-23T22:40:03"

"2014-07-24T02:03:16"

"2014-07-24T02:03:11"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/404/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "denilsonsa", "id": 121676, "node_id": "MDQ6VXNlcjEyMTY3Ng==", "avatar_url": "https://avatars.githubusercontent.com/u/121676?v=4", "gravatar_id": "", "url": "https://api.github.com/users/denilsonsa", "html_url": "https://github.com/denilsonsa", "followers_url": "https://api.github.com/users/denilsonsa/followers", "following_url": "https://api.github.com/users/denilsonsa/following{/other_user}", "gists_url": "https://api.github.com/users/denilsonsa/gists{/gist_id}", "starred_url": "https://api.github.com/users/denilsonsa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/denilsonsa/subscriptions", "organizations_url": "https://api.github.com/users/denilsonsa/orgs", "repos_url": "https://api.github.com/users/denilsonsa/repos", "events_url": "https://api.github.com/users/denilsonsa/events{/privacy}", "received_events_url": "https://api.github.com/users/denilsonsa/received_events", "type": "User", "site_admin": false }

[]

[]

[]

"2014-07-23T17:38:40"

"2014-07-23T17:39:38"

"2014-07-23T17:39:38"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/403/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/403", "html_url": "https://github.com/coleifer/peewee/pull/403", "diff_url": "https://github.com/coleifer/peewee/pull/403.diff", "patch_url": "https://github.com/coleifer/peewee/pull/403.patch", "merged_at": "2014-07-23T17:39:38" }

{ "login": "stas", "id": 112147, "node_id": "MDQ6VXNlcjExMjE0Nw==", "avatar_url": "https://avatars.githubusercontent.com/u/112147?v=4", "gravatar_id": "", "url": "https://api.github.com/users/stas", "html_url": "https://github.com/stas", "followers_url": "https://api.github.com/users/stas/followers", "following_url": "https://api.github.com/users/stas/following{/other_user}", "gists_url": "https://api.github.com/users/stas/gists{/gist_id}", "starred_url": "https://api.github.com/users/stas/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/stas/subscriptions", "organizations_url": "https://api.github.com/users/stas/orgs", "repos_url": "https://api.github.com/users/stas/repos", "events_url": "https://api.github.com/users/stas/events{/privacy}", "received_events_url": "https://api.github.com/users/stas/received_events", "type": "User", "site_admin": false }

[]

[]

[]

"2014-07-23T16:02:42"

"2014-09-06T13:36:34"

"2014-09-06T12:48:22"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/402/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/402", "html_url": "https://github.com/coleifer/peewee/pull/402", "diff_url": "https://github.com/coleifer/peewee/pull/402.diff", "patch_url": "https://github.com/coleifer/peewee/pull/402.patch", "merged_at": null }

{ "login": "stas", "id": 112147, "node_id": "MDQ6VXNlcjExMjE0Nw==", "avatar_url": "https://avatars.githubusercontent.com/u/112147?v=4", "gravatar_id": "", "url": "https://api.github.com/users/stas", "html_url": "https://github.com/stas", "followers_url": "https://api.github.com/users/stas/followers", "following_url": "https://api.github.com/users/stas/following{/other_user}", "gists_url": "https://api.github.com/users/stas/gists{/gist_id}", "starred_url": "https://api.github.com/users/stas/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/stas/subscriptions", "organizations_url": "https://api.github.com/users/stas/orgs", "repos_url": "https://api.github.com/users/stas/repos", "events_url": "https://api.github.com/users/stas/events{/privacy}", "received_events_url": "https://api.github.com/users/stas/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I think I'm going to pass on merging this, but thank you for your hard work!\n", "@coleifer It would be great if you could share your opinions on this.\n\nBtw, this issue is not directly relevant to the PR #402 you just closed, which is fine tbh.\n", "> It would be great if you could share your opinions on this.\n\nFor sure, sorry for being vague. I think this could lead to subtle bugs, especially if you wanted to work with the raw value stored in the column (without the function). I also think that there are limited use-cases -- encryption/decryption is really the only one that comes to mind.\n\nIn my opinion, it would be better to be explicit:\n\n``` python\n\nSecretModel.select(\n SecretModel.id,\n fn.decrypt_iv(SecretModel.data, 'my key', 'iv', 'aes').alias('data'))\n\nSecretModel.insert(\n data=fn.encrypt_iv('shhhh', 'my key', 'iv', 'aes')).execute()\n```\n", "Thanks, this is really helpful!\n" ]

"2014-07-23T15:50:21"

"2014-09-06T15:02:49"

"2014-09-06T12:48:17"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/401/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "denilsonsa", "id": 121676, "node_id": "MDQ6VXNlcjEyMTY3Ng==", "avatar_url": "https://avatars.githubusercontent.com/u/121676?v=4", "gravatar_id": "", "url": "https://api.github.com/users/denilsonsa", "html_url": "https://github.com/denilsonsa", "followers_url": "https://api.github.com/users/denilsonsa/followers", "following_url": "https://api.github.com/users/denilsonsa/following{/other_user}", "gists_url": "https://api.github.com/users/denilsonsa/gists{/gist_id}", "starred_url": "https://api.github.com/users/denilsonsa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/denilsonsa/subscriptions", "organizations_url": "https://api.github.com/users/denilsonsa/orgs", "repos_url": "https://api.github.com/users/denilsonsa/repos", "events_url": "https://api.github.com/users/denilsonsa/events{/privacy}", "received_events_url": "https://api.github.com/users/denilsonsa/received_events", "type": "User", "site_admin": false }

[]

[]

[ "You can always implement a custom field type: http://peewee.readthedocs.org/en/latest/peewee/models.html#creating-a-custom-field\n\nI do not have any plans at the moment to implement the timestamp field, however.\n", "For future reference, MySQL's `TIMESTAMP` field behaves almost like `DateTimeField`, so a trivial implementation looks like this:\n\n```\n# Custom field, behaves just like DateTimeField.\nclass TimestampField(DateTimeField):\n db_field = 'timestamp'\n\nMySQLDatabase.register_fields({'timestamp': 'TIMESTAMP'})\n```\n\nHowever, this implementation is likely incomplete. In special, a `DATETIME` field stores the date in the exact format passed to the database, while a `TIMESTAMP` field will convert to UTC while writing, and convert from UTC to local time in a SELECT result.\n\nFor a simple order_by, I can use `TIMESTAMP` and `DATETIME` the same way. For anything else, we might need extra code.\n" ]

"2014-07-23T15:12:34"

"2014-07-24T03:11:13"

"2014-07-24T02:18:29"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/400/reactions", "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "alvra", "id": 470642, "node_id": "MDQ6VXNlcjQ3MDY0Mg==", "avatar_url": "https://avatars.githubusercontent.com/u/470642?v=4", "gravatar_id": "", "url": "https://api.github.com/users/alvra", "html_url": "https://github.com/alvra", "followers_url": "https://api.github.com/users/alvra/followers", "following_url": "https://api.github.com/users/alvra/following{/other_user}", "gists_url": "https://api.github.com/users/alvra/gists{/gist_id}", "starred_url": "https://api.github.com/users/alvra/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/alvra/subscriptions", "organizations_url": "https://api.github.com/users/alvra/orgs", "repos_url": "https://api.github.com/users/alvra/repos", "events_url": "https://api.github.com/users/alvra/events{/privacy}", "received_events_url": "https://api.github.com/users/alvra/received_events", "type": "User", "site_admin": false }

[]

[]

[ "``` python\nthings = Thing.select().alias('j1')\nRelated.select().join(things, on=(Related.thing == things.c.id))\n```\n", "Thanks :)\n" ]

"2014-07-21T15:36:47"

"2014-08-14T06:35:24"

"2014-08-14T03:44:27"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/399/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "alexlatchford", "id": 628146, "node_id": "MDQ6VXNlcjYyODE0Ng==", "avatar_url": "https://avatars.githubusercontent.com/u/628146?v=4", "gravatar_id": "", "url": "https://api.github.com/users/alexlatchford", "html_url": "https://github.com/alexlatchford", "followers_url": "https://api.github.com/users/alexlatchford/followers", "following_url": "https://api.github.com/users/alexlatchford/following{/other_user}", "gists_url": "https://api.github.com/users/alexlatchford/gists{/gist_id}", "starred_url": "https://api.github.com/users/alexlatchford/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/alexlatchford/subscriptions", "organizations_url": "https://api.github.com/users/alexlatchford/orgs", "repos_url": "https://api.github.com/users/alexlatchford/repos", "events_url": "https://api.github.com/users/alexlatchford/events{/privacy}", "received_events_url": "https://api.github.com/users/alexlatchford/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Unfortunately this is not currently supported using `.dicts()`. Searching 1 -> N can be accomplished using the special `prefetch` API. Behind-the-scenes, `prefetch` will construct the appropriate subqueries to ensure you don't have O(n) queries when fetching \"keywords\" in your example.\n\nYour best bet is to write something like the following:\n\n``` python\nfilters = Filter.select().order_by(Filter.name.desc())\nkeywords = Keyword.select().order_by(Keyword.keyword.desc())\nfilter_keyword = prefetch(filters, keywords)\n\ndef filter_to_dict(f):\n data = f._data.copy()\n data['keywords'] = [k.keyword for k in f.keywords_prefetch]\n return data\n\nprint map(filter_to_dict, filter_keyword)\n```\n\nWould print:\n\n```\n[{'keywords': [u'k3-3', u'k3-2', u'k3-1'], 'id': 3, 'name': u'filter3'},\n {'keywords': [u'k2-3', u'k2-2', u'k2-1'], 'id': 2, 'name': u'filter2'},\n {'keywords': [u'k1-3', u'k1-2', u'k1-1'], 'id': 1, 'name': u'filter1'}]\n```\n", "Awesome, cheers :)\n" ]

"2014-07-21T04:05:56"

"2014-07-22T02:36:06"

"2014-07-22T02:36:06"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/398/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "yadutaf", "id": 739985, "node_id": "MDQ6VXNlcjczOTk4NQ==", "avatar_url": "https://avatars.githubusercontent.com/u/739985?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yadutaf", "html_url": "https://github.com/yadutaf", "followers_url": "https://api.github.com/users/yadutaf/followers", "following_url": "https://api.github.com/users/yadutaf/following{/other_user}", "gists_url": "https://api.github.com/users/yadutaf/gists{/gist_id}", "starred_url": "https://api.github.com/users/yadutaf/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yadutaf/subscriptions", "organizations_url": "https://api.github.com/users/yadutaf/orgs", "repos_url": "https://api.github.com/users/yadutaf/repos", "events_url": "https://api.github.com/users/yadutaf/events{/privacy}", "received_events_url": "https://api.github.com/users/yadutaf/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Thank you but I will pass on this, since it can be accomplished with an `UpdateQuery`.\n" ]

"2014-07-19T14:34:37"

"2014-07-20T12:31:02"

"2014-07-20T12:31:02"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/397/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/397", "html_url": "https://github.com/coleifer/peewee/pull/397", "diff_url": "https://github.com/coleifer/peewee/pull/397.diff", "patch_url": "https://github.com/coleifer/peewee/pull/397.patch", "merged_at": null }

{ "login": "jhorman", "id": 323697, "node_id": "MDQ6VXNlcjMyMzY5Nw==", "avatar_url": "https://avatars.githubusercontent.com/u/323697?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jhorman", "html_url": "https://github.com/jhorman", "followers_url": "https://api.github.com/users/jhorman/followers", "following_url": "https://api.github.com/users/jhorman/following{/other_user}", "gists_url": "https://api.github.com/users/jhorman/gists{/gist_id}", "starred_url": "https://api.github.com/users/jhorman/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jhorman/subscriptions", "organizations_url": "https://api.github.com/users/jhorman/orgs", "repos_url": "https://api.github.com/users/jhorman/repos", "events_url": "https://api.github.com/users/jhorman/events{/privacy}", "received_events_url": "https://api.github.com/users/jhorman/received_events", "type": "User", "site_admin": false }

[]

[]

[ "``` sql\nSELECT t1.\"id\"\nFROM \"users\" AS t1 \nWHERE Exists((SELECT t2.\"id\" FROM \"users\" AS t2))\n```\n", "Nice, thanks!\n" ]

"2014-07-18T08:14:40"

"2014-07-18T17:20:44"

"2014-07-18T15:28:55"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/396/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "goir", "id": 586209, "node_id": "MDQ6VXNlcjU4NjIwOQ==", "avatar_url": "https://avatars.githubusercontent.com/u/586209?v=4", "gravatar_id": "", "url": "https://api.github.com/users/goir", "html_url": "https://github.com/goir", "followers_url": "https://api.github.com/users/goir/followers", "following_url": "https://api.github.com/users/goir/following{/other_user}", "gists_url": "https://api.github.com/users/goir/gists{/gist_id}", "starred_url": "https://api.github.com/users/goir/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/goir/subscriptions", "organizations_url": "https://api.github.com/users/goir/orgs", "repos_url": "https://api.github.com/users/goir/repos", "events_url": "https://api.github.com/users/goir/events{/privacy}", "received_events_url": "https://api.github.com/users/goir/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Peewee does not currently support this, unfortunately. You can always pass in the model class to `.select()` and it will select the appropriate columns.\n" ]

"2014-07-18T07:34:05"

"2014-07-18T12:46:55"

"2014-07-18T12:46:55"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/395/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "alexlatchford", "id": 628146, "node_id": "MDQ6VXNlcjYyODE0Ng==", "avatar_url": "https://avatars.githubusercontent.com/u/628146?v=4", "gravatar_id": "", "url": "https://api.github.com/users/alexlatchford", "html_url": "https://github.com/alexlatchford", "followers_url": "https://api.github.com/users/alexlatchford/followers", "following_url": "https://api.github.com/users/alexlatchford/following{/other_user}", "gists_url": "https://api.github.com/users/alexlatchford/gists{/gist_id}", "starred_url": "https://api.github.com/users/alexlatchford/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/alexlatchford/subscriptions", "organizations_url": "https://api.github.com/users/alexlatchford/orgs", "repos_url": "https://api.github.com/users/alexlatchford/repos", "events_url": "https://api.github.com/users/alexlatchford/events{/privacy}", "received_events_url": "https://api.github.com/users/alexlatchford/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Awesome cheers Charles. \n\nThis is amazing, I've already taken your code and am currently building and about to push to live :)\n" ]

"2014-07-16T00:43:42"

"2014-07-16T01:15:51"

"2014-07-16T01:05:09"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/394/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/394", "html_url": "https://github.com/coleifer/peewee/pull/394", "diff_url": "https://github.com/coleifer/peewee/pull/394.diff", "patch_url": "https://github.com/coleifer/peewee/pull/394.patch", "merged_at": null }

{ "login": "danieldiekmeier", "id": 2098462, "node_id": "MDQ6VXNlcjIwOTg0NjI=", "avatar_url": "https://avatars.githubusercontent.com/u/2098462?v=4", "gravatar_id": "", "url": "https://api.github.com/users/danieldiekmeier", "html_url": "https://github.com/danieldiekmeier", "followers_url": "https://api.github.com/users/danieldiekmeier/followers", "following_url": "https://api.github.com/users/danieldiekmeier/following{/other_user}", "gists_url": "https://api.github.com/users/danieldiekmeier/gists{/gist_id}", "starred_url": "https://api.github.com/users/danieldiekmeier/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/danieldiekmeier/subscriptions", "organizations_url": "https://api.github.com/users/danieldiekmeier/orgs", "repos_url": "https://api.github.com/users/danieldiekmeier/repos", "events_url": "https://api.github.com/users/danieldiekmeier/events{/privacy}", "received_events_url": "https://api.github.com/users/danieldiekmeier/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Your models need to be using the `playhouse.sqlite_ext.SqliteExtDatabase` instead of the normal `peewee.SqliteDatabase`.\n", "So:\n\n``` python\nclass FTSBook(FTSModel):\n content = TextField()\n class Meta:\n database = <some SqliteExtDatabase() instance>\n```\n" ]

"2014-07-15T11:39:33"

"2014-07-15T13:49:21"

"2014-07-15T13:49:21"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/393/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "alexlatchford", "id": 628146, "node_id": "MDQ6VXNlcjYyODE0Ng==", "avatar_url": "https://avatars.githubusercontent.com/u/628146?v=4", "gravatar_id": "", "url": "https://api.github.com/users/alexlatchford", "html_url": "https://github.com/alexlatchford", "followers_url": "https://api.github.com/users/alexlatchford/followers", "following_url": "https://api.github.com/users/alexlatchford/following{/other_user}", "gists_url": "https://api.github.com/users/alexlatchford/gists{/gist_id}", "starred_url": "https://api.github.com/users/alexlatchford/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/alexlatchford/subscriptions", "organizations_url": "https://api.github.com/users/alexlatchford/orgs", "repos_url": "https://api.github.com/users/alexlatchford/repos", "events_url": "https://api.github.com/users/alexlatchford/events{/privacy}", "received_events_url": "https://api.github.com/users/alexlatchford/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Thanks for reporting this -- yes, peewee replaces the `order_by` string with a clause, but this is acting up in the chlid-classes. I will get a fix out soon.\n" ]

"2014-07-15T08:13:13"

"2014-07-15T14:14:18"

"2014-07-15T14:14:18"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/392/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "bryhoyt", "id": 4769854, "node_id": "MDQ6VXNlcjQ3Njk4NTQ=", "avatar_url": "https://avatars.githubusercontent.com/u/4769854?v=4", "gravatar_id": "", "url": "https://api.github.com/users/bryhoyt", "html_url": "https://github.com/bryhoyt", "followers_url": "https://api.github.com/users/bryhoyt/followers", "following_url": "https://api.github.com/users/bryhoyt/following{/other_user}", "gists_url": "https://api.github.com/users/bryhoyt/gists{/gist_id}", "starred_url": "https://api.github.com/users/bryhoyt/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/bryhoyt/subscriptions", "organizations_url": "https://api.github.com/users/bryhoyt/orgs", "repos_url": "https://api.github.com/users/bryhoyt/repos", "events_url": "https://api.github.com/users/bryhoyt/events{/privacy}", "received_events_url": "https://api.github.com/users/bryhoyt/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I think I'm going to leave the API as-is, but thank you for the suggestion.\n", "Thanks for getting back to me really quickly. This does leave me with a couple questions:\n\nI love Peewee, and I love how using an ORM means I can factor my queries by using separate functions to further refine a query, without the messy string manipulation that would be necessary to factor plain-old-sql queries. But (without hacking peewee's internals) I can only refine existing queries with further restrictions, not extend them with further allowable criteria.\n\nIn most cases, this isn't a problem, because you can write your query from scratch. But I have a use-case in flask-admin, where I want to override a ModelView's `get_list()` method to further extend the search. I have a `Picture` model, where each `Picture` has multiple `Tags`. The builtin flask-admin search will filter on various columns I give it, but I want to include pictures that have tags included in the search keywords.\n\nCan you make a better suggestion than hacking into peewee's internals? \n", "Sorry for necroposting but I have exactly the same issue. Actually this problem is not related with peewee. E.g. django ORM has the same API. If you want to extend your query you need to work with expression instead of query:\r\n\r\n expression = (Model.a == 'x') & (Model.b == 'y')\r\n if something:\r\n expression |= (Model.c == 'z')\r\n\r\n result = Model.select().where(expression)\r\n", "Yes, necroposting but this really helped me @askabelin. \r\nFollowing up on that I'll post how I solve my problem:\r\n\r\n```\r\nfor item in list:\r\n if item is not None:\r\n expression &= (getattr(Model,item) == 'x')\r\n\r\nresult = Model.select().where(expression)\r\n```", "The best way is to:\r\n\r\n```python\r\nimport operator\r\nfrom functools import reduce\r\n\r\nexpr_list = [\r\n (Foo.bar == 1),\r\n (Foo.baz == 2),\r\n (Foo.biz == 4)]\r\n\r\norexpr = reduce(operator.or_, expr_list)\r\n```\r\n\r\nYou can use `operator.and_` to AND- them together.", "The original problem here was not chaining expressions together, but extending the WHERE clause of a full query. If you have a situation where you're provided with an existing query (`query = Model.select().where()`), there's no clear way to extend that query with an OR clause, when you don't have direct access to the underlying WHERE expression.\r\n\r\n@coleifer added `.orwhere()` for this purpose in https://github.com/coleifer/peewee/commit/f5ca758358f4de88e337399cd156b044208e167c but I notice that `.orwhere()` no longer exists in the latest peewee.py (unless I'm missing something). Did you decide it wasn't worth keeping in there?\r\n", "I've re-added orwhere, thanks for the comment and the clarification:\r\n\r\nd8ff4d2bffd7ed1db97a6ddd016e8db3a73b3437", "@askabelin Thank You for the answer. I need to write a conditioning script, which should change due to global parameter. Now I have a long if-else case:\r\n```\r\n if q is not None and ordering.find('starting_time'):\r\n tasks = Task.select().where(Task.name.contains(q)).order_by(Task.start_time).paginate(page, per_page)\r\n elif q is None and ordering.find('starting_time'):\r\n tasks = Task.select().order_by(Task.start_time)\r\n```\r\nCan You help how can I make it easier?\r\nThank You in advance!\r\n", "```python\r\ntasks = Task.select().order_by(Task.start_time)\r\nif q is not None:\r\n tasks = tasks.where(Task.name.contains(q))\r\n```" ]

"2014-07-13T23:40:26"

"2021-04-30T05:01:34"

"2014-07-14T03:21:36"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/391/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "Casyfill", "id": 2675621, "node_id": "MDQ6VXNlcjI2NzU2MjE=", "avatar_url": "https://avatars.githubusercontent.com/u/2675621?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Casyfill", "html_url": "https://github.com/Casyfill", "followers_url": "https://api.github.com/users/Casyfill/followers", "following_url": "https://api.github.com/users/Casyfill/following{/other_user}", "gists_url": "https://api.github.com/users/Casyfill/gists{/gist_id}", "starred_url": "https://api.github.com/users/Casyfill/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Casyfill/subscriptions", "organizations_url": "https://api.github.com/users/Casyfill/orgs", "repos_url": "https://api.github.com/users/Casyfill/repos", "events_url": "https://api.github.com/users/Casyfill/events{/privacy}", "received_events_url": "https://api.github.com/users/Casyfill/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Hi\n\nAre you using Python3? This may be a case for PyMySQL.\n\nMaybe the error message should be edited.\n", "no, python 2.7\n", "I installed PyMySQL already – still same issue(\n", "This is not a peewee bug. You need to install one of the mysql python drivers:\n- mysql-python\n- pymysql\n\nYou can verify one of them is installed by running either:\n- import MySQLdb\n- import pymysql\n", "I have both installed and passing this 'import test'\n", "same error \n\n```\nraise ImproperlyConfigured('MySQLdb or PyMySQL must be installed.')\npeewee.ImproperlyConfigured: MySQLdb or PyMySQL must be installed.\n>>> \n>>> \n>>> import pymysql\n>>>\n```\n", "This is the code, I'm not sure how it's failing:\n\n``` python\ntry:\n import MySQLdb as mysql # prefer the C module.\nexcept ImportError:\n try:\n import pymysql as mysql\n except ImportError:\n mysql = None\n```\n\nThen later...\n\n``` python\nclass MySQLDatabase(Database):\n ...\n def _connect(self, database, **kwargs):\n if not mysql:\n raise ImproperlyConfigured('MySQLdb or PyMySQL must be installed.')\n\n```\n", "If you want to run that exact code and let me know the output that'd help to debug.\n\nYou can also try: `from peewee import mysql; print mysql` and share the output.\n", "I have also pysqlite, but it always says , \"peewee.ImproperlyConfigured: pysqlite or sqlite3 must be installed. \"\n\nBelow is the list of PIP\nantiorm (1.2.1)\nblinker (1.4)\ncffi (1.7.0)\nclick (6.6)\nConfigArgParse (0.10.0)\ncryptography (1.4)\ndb (0.1.1)\ndb-sqlite3 (0.0.1)\nenum34 (1.1.6)\nFlask (0.11.1)\nFlask-Compress (1.3.0)\nFlask-Cors (2.1.2)\nFlask-MySQL (1.3)\nflask-peewee (0.6.7)\nfuture (0.15.2)\ngeopy (1.11.0)\ngpsoauth (0.3.0)\nidna (2.1)\nipaddress (1.0.16)\nitsdangerous (0.24)\nJinja2 (2.8)\nMarkupSafe (0.23)\nMySQL-python (1.2.5)\nmysql-replication (0.9)\nmysqli (0.5.3)\nneopysqlite (0.2.2)\npeewee (2.8.1)\npip (8.1.2)\nprotobuf (2.6.1)\nprotobuf-to-dict (0.1.0)\npyasn1 (0.1.9)\npycparser (2.14)\npycryptodomex (3.4.2)\nPyMySQL (0.7.5)\nPyMySQL3 (0.5)\npymysqlblinker (1.2)\npymysqlrpc (0.1.4)\npyOpenSSL (16.0.0)\npysqlite (2.8.2)\npython-dateutil (2.5.3)\nrequests (2.10.0)\ns2sphere (0.2.4)\nsetuptools (25.1.1)\nsix (1.10.0)\nsqlist (0.2.1b0)\nSQLite3Database (0.2.0)\ntermcolor (1.1.0)\ntomdb (0.5.1)\nWerkzeug (0.11.10)\nwheel (0.29.0)\nwtf-peewee (0.2.6)\nWTForms (2.1)\n\nI have tried many package, but it dose not work.\n", "My Code is very simple\n\n`#!/usr/bin/python\n\n# -_\\- coding: utf-8 -_-\n\nimport logging\nimport logging.handlers\nfrom peewee import SqliteDatabase,Model, InsertQuery, IntegerField, CharField, \\\n FloatField, BooleanField, DateTimeField\n\nLOG_FILE = 'tst.log'\nhandler = logging.handlers.RotatingFileHandler(LOG_FILE, maxBytes=1024*1024, backupCount=5)\n # 实例化handler\nfmt = '%(asctime)s - %(filename)s:%(lineno)s - %(name)s - %(message)s'\n\nformatter = logging.Formatter(fmt) # 实例化formatter\nhandler.setFormatter(formatter) # 为handler添加formatter\nconsole = logging.StreamHandler()\nconsole.setLevel(logging.INFO)\nlogging.getLogger('').addHandler(console)\n\nlogger = logging.getLogger('test') \nlogger.addHandler(handler) \nlogger.setLevel(logging.DEBUG)\n\ndb = SqliteDatabase(\"peewee_db_learn.db\")\nprint db\nlogger.info(\"In die Software\")\n\nclass TestModel(Model):\n class Meta:\n database = db\n order_by = ('-num_id',)\n\n```\nnum_id = IntegerField(primary_key=True)\nname = CharField()\ntime = DateTimeField()\n```\n\ndef create_db():\n logger.info(\"PeeWee Connection\")\n db.connect()\n db.create_table(TestModel, safe=True)\n db.close()\n logger.info(\"PeeWee Finished\")\n\nif **name** == '**main**':\n create_db()\n`\n\nThe error is:\n\n`\nTraceback (most recent call last):\n File \"pwee.py\", line 49, in <module>\n create_db()\n File \"pwee.py\", line 43, in create_db\n db.connect()\n File \"/usr/local/lib/python2.7/site-packages/peewee.py\", line 3402, in connect\n **self.connect_kwargs)\n File \"/usr/local/lib/python2.7/site-packages/peewee.py\", line 3657, in _connect\n raise ImproperlyConfigured('pysqlite or sqlite3 must be installed.')\npeewee.ImproperlyConfigured: pysqlite or sqlite3 must be installed.\n`\n\nand now I have no idea, please help me . Thanks very much.\n", "Well, apparently you don't have SQLite installed. If you're going to use\nthe SQLiteDatabase class, then you need SQLite bindings installed.\nTypically these are part of the normal python installation, but I'm not\nsure what kind of system you're running on so perhaps your Python was\ncompiled without SQLite.\n\nIt's an easy fix, though, just do:\n\npip install pysqlite\n\nOr you can install my fork of pysqlite ;)\n\npip install -e git+https://github.com/coleifer/pysqlite#egg=pysqlite\n\nCharles\n\nOn Sat, Jul 30, 2016 at 12:48 PM, Kevin Hao notifications@github.com\nwrote:\n\n> My Code is very simple\n> \n> `#!/usr/bin/python\n> -_\\- coding: utf-8 -_-\n> \n> import logging\n> import logging.handlers\n> from peewee import SqliteDatabase,Model, InsertQuery, IntegerField,\n> CharField, \\\n> FloatField, BooleanField, DateTimeField\n> \n> LOG_FILE = 'tst.log'\n> handler = logging.handlers.RotatingFileHandler(LOG_FILE,\n> maxBytes=1024*1024, backupCount=5)\n> \n> # 实例化handler\n> \n> fmt = '%(asctime)s - %(filename)s:%(lineno)s - %(name)s - %(message)s'\n> \n> formatter = logging.Formatter(fmt) # 实例化formatter\n> handler.setFormatter(formatter) # 为handler添加formatter\n> console = logging.StreamHandler()\n> console.setLevel(logging.INFO)\n> logging.getLogger('').addHandler(console)\n> \n> logger = logging.getLogger('test')\n> \n> logger.addHandler(handler)\n> \n> logger.setLevel(logging.DEBUG)\n> \n> db = SqliteDatabase(\"peewee_db_learn.db\")\n> print db\n> logger.info(\"In die Software\")\n> \n> class TestModel(Model):\n> class Meta:\n> database = db\n> order_by = ('-num_id',)\n> \n> num_id = IntegerField(primary_key=True)\n> name = CharField()\n> time = DateTimeField()\n> \n> def create_db():\n> logger.info(\"PeeWee Connection\")\n> db.connect()\n> db.create_table(TestModel, safe=True)\n> db.close()\n> logger.info(\"PeeWee Finished\")\n> \n> if _name_ == '_main_':\n> create_db()\n> `\n> \n> The error is:\n> \n> Traceback (most recent call last):\n> File \"pwee.py\", line 49, in <module>\n> create_db()\n> File \"pwee.py\", line 43, in create_db\n> db.connect()\n> File \"/usr/local/lib/python2.7/site-packages/peewee.py\", line 3402, in\n> connect\n> **self.connect_kwargs)\n> File \"/usr/local/lib/python2.7/site-packages/peewee.py\", line 3657, in\n> _connect\n> raise ImproperlyConfigured('pysqlite or sqlite3 must be installed.')\n> peewee.ImproperlyConfigured: pysqlite or sqlite3 must be installed.\n> \n> and now I have no idea, please help me . Thanks very much.\n> \n> —\n> You are receiving this because you modified the open/close state.\n> Reply to this email directly, view it on GitHub\n> https://github.com/coleifer/peewee/issues/390#issuecomment-236379147,\n> or mute the thread\n> https://github.com/notifications/unsubscribe-auth/AAHUpnMKSCkjxn279qFXy11v3WkvP-L_ks5qa45xgaJpZM4CL55a\n> .\n", "Sorry, I read your post a bit more closely, and I see now that you have\ninstalled pysqlite 2.8.2. You can uninstall all that bullshit like\nneopysqlite (whatever the hell that is) and Sqlite3Database.\n\nIn your virtualenv, try activating it (assuming you are comfortable working\nwith virtualenv), running python and typing:\n\n> > > from pysqlite2 import dbapi2 as sqlite3\n> > > conn = sqlite3.connect(':memory:')\n\nDo you get an ImportError? If you do, then something is wrong with your\ninstallation of pysqlite.\n\nIf you do not get an ImportError, try the following:\n\n> > > from peewee import sqlite3\n> > > sqlite3 # just type the name of the module and press \"Enter\".\n\nWhat does it show for your sqlite3? Here's an example from one of my\nvirtualenvs where I've got a custom version of pysqlite:\n\n> > > from peewee import sqlite3\n> > > sqlite3\n> > > <module 'pysqlite2.dbapi2' from\n> > > '/home/code/envs/media_manager/lib/python2.7/site-packages/pysqlite2/dbapi2.pyc'>\n\nLet me know, thanks!\n\nOn Sat, Jul 30, 2016 at 1:42 PM, Charles Leifer coleifer@gmail.com wrote:\n\n> Well, apparently you don't have SQLite installed. If you're going to use\n> the SQLiteDatabase class, then you need SQLite bindings installed.\n> Typically these are part of the normal python installation, but I'm not\n> sure what kind of system you're running on so perhaps your Python was\n> compiled without SQLite.\n> \n> It's an easy fix, though, just do:\n> \n> pip install pysqlite\n> \n> Or you can install my fork of pysqlite ;)\n> \n> pip install -e git+https://github.com/coleifer/pysqlite#egg=pysqlite\n> \n> Charles\n> \n> On Sat, Jul 30, 2016 at 12:48 PM, Kevin Hao notifications@github.com\n> wrote:\n> \n> > My Code is very simple\n> > \n> > `#!/usr/bin/python\n> > -_\\- coding: utf-8 -_-\n> > \n> > import logging\n> > import logging.handlers\n> > from peewee import SqliteDatabase,Model, InsertQuery, IntegerField,\n> > CharField, \\\n> > FloatField, BooleanField, DateTimeField\n> > \n> > LOG_FILE = 'tst.log'\n> > handler = logging.handlers.RotatingFileHandler(LOG_FILE,\n> > maxBytes=1024*1024, backupCount=5)\n> > \n> > # 实例化handler\n> > \n> > fmt = '%(asctime)s - %(filename)s:%(lineno)s - %(name)s - %(message)s'\n> > \n> > formatter = logging.Formatter(fmt) # 实例化formatter\n> > handler.setFormatter(formatter) # 为handler添加formatter\n> > console = logging.StreamHandler()\n> > console.setLevel(logging.INFO)\n> > logging.getLogger('').addHandler(console)\n> > \n> > logger = logging.getLogger('test')\n> > \n> > logger.addHandler(handler)\n> > \n> > logger.setLevel(logging.DEBUG)\n> > \n> > db = SqliteDatabase(\"peewee_db_learn.db\")\n> > print db\n> > logger.info(\"In die Software\")\n> > \n> > class TestModel(Model):\n> > class Meta:\n> > database = db\n> > order_by = ('-num_id',)\n> > \n> > num_id = IntegerField(primary_key=True)\n> > name = CharField()\n> > time = DateTimeField()\n> > \n> > def create_db():\n> > logger.info(\"PeeWee Connection\")\n> > db.connect()\n> > db.create_table(TestModel, safe=True)\n> > db.close()\n> > logger.info(\"PeeWee Finished\")\n> > \n> > if _name_ == '_main_':\n> > create_db()\n> > `\n> > \n> > The error is:\n> > \n> > Traceback (most recent call last):\n> > File \"pwee.py\", line 49, in <module>\n> > create_db()\n> > File \"pwee.py\", line 43, in create_db\n> > db.connect()\n> > File \"/usr/local/lib/python2.7/site-packages/peewee.py\", line 3402, in\n> > connect\n> > **self.connect_kwargs)\n> > File \"/usr/local/lib/python2.7/site-packages/peewee.py\", line 3657, in\n> > _connect\n> > raise ImproperlyConfigured('pysqlite or sqlite3 must be installed.')\n> > peewee.ImproperlyConfigured: pysqlite or sqlite3 must be installed.\n> > \n> > and now I have no idea, please help me . Thanks very much.\n> > \n> > —\n> > You are receiving this because you modified the open/close state.\n> > Reply to this email directly, view it on GitHub\n> > https://github.com/coleifer/peewee/issues/390#issuecomment-236379147,\n> > or mute the thread\n> > https://github.com/notifications/unsubscribe-auth/AAHUpnMKSCkjxn279qFXy11v3WkvP-L_ks5qa45xgaJpZM4CL55a\n> > .\n", "@Casyfill Thanks for your answer, but in my server I have installed the MySQL-python. It seems not to work for me. And I program it not for managing MySQL ,instead of Sqlite. I have tried for 1 day, but still not solved. Thanks. \n", "@Casyfill Now I will follow your advice to create a table. Then , tell you the results. Thanks.\n", "@Casyfill I have tried to create a table , but it still does not work.\n", "@seriousdude No , I am programing with Python 2.7 \n", "I have solved the problem. Before I compiled the Python 2.7, I have not still installed the Sqlite. There is no sqlite.so. Thanks.\n", "needs to `pip install PyMySQL`\r\nin python3.5.2\r\n\r\nthat fixed my problem, thanks @seriousdude ", "Hi, first let me thank you for all the hard work. Thanks!\r\nI'm facing this same issue on an ubuntu server, production deploy. But not all the times, I got it for most of reuquests for my Flask app, but for some some others it does work.\r\n\r\nIts on a virtualenv python 3.5.2, I have installed pymysql and imports work, I also got peewee working just fine on separate anaconda 3.6 environment.\r\n\r\nNot sure how to debug this, as the modules and all this threads point that I'm doing OK.\r\n\r\nThanks in advice ! \r\n\r\n", "@laureanoarcanio -- that sounds very much like a deployment issue. Peewee needs to be installed in the same virtual environment as pymysql in order to work correctly.", "Hi,\r\nI have bumped into the same issue today, except with psycopg2.\r\nI have deployed a Flask application with apache mod_wsgi, with virtualenv.\r\nRunning `from peewee import psycopg2` from console is successful.\r\nBut when accessed through the web application peewee raises `ImproperlyConfigured: psycopg2 must be installed.`\r\n", "You're surely running your app using a different python-path (sys.path) than when you run your console.", "The wsgi starts the same venv, and everything is visible from there. It turns out, the actual error when importing pycopg2 is this:\r\n`ImportError: /home/sysadm/customizer/venv/local/lib/python2.7/site-packages/psycopg2/_psycopg.so: wrong ELF class: ELFCLASS32`", "Aha, thanks @asztalosdani -- hope you got things working." ]

"2014-07-10T09:58:29"

"2018-03-14T13:57:51"

"2014-07-10T14:34:42"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/390/reactions", "total_count": 2, "+1": 2, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "jhorman", "id": 323697, "node_id": "MDQ6VXNlcjMyMzY5Nw==", "avatar_url": "https://avatars.githubusercontent.com/u/323697?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jhorman", "html_url": "https://github.com/jhorman", "followers_url": "https://api.github.com/users/jhorman/followers", "following_url": "https://api.github.com/users/jhorman/following{/other_user}", "gists_url": "https://api.github.com/users/jhorman/gists{/gist_id}", "starred_url": "https://api.github.com/users/jhorman/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jhorman/subscriptions", "organizations_url": "https://api.github.com/users/jhorman/orgs", "repos_url": "https://api.github.com/users/jhorman/repos", "events_url": "https://api.github.com/users/jhorman/events{/privacy}", "received_events_url": "https://api.github.com/users/jhorman/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Another related question is just, why not default to always only saving dirty fields. Just wondering if I am missing something where that would be unsafe? That does seem to be the behavior when you have a CompositeKey? https://github.com/coleifer/peewee/blob/2.2.5/peewee.py#L3159\n", "> Another related question is just, why not default to always only saving dirty fields.\n\nIt's easier to understand.\n", "I can just actually lead to some unclear behavior. What happened to me is that I have an incrementing field on an object, num_members. I never modify this in code, only in a trigger, but save was overwriting num_members with an older value. The advantage of only saving modified fields is that you can be sure there are no unintended overwrites like this.\n" ]

"2014-07-09T05:50:32"

"2014-07-09T17:36:03"

"2014-07-09T17:32:07"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/389/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "moloney", "id": 1376566, "node_id": "MDQ6VXNlcjEzNzY1NjY=", "avatar_url": "https://avatars.githubusercontent.com/u/1376566?v=4", "gravatar_id": "", "url": "https://api.github.com/users/moloney", "html_url": "https://github.com/moloney", "followers_url": "https://api.github.com/users/moloney/followers", "following_url": "https://api.github.com/users/moloney/following{/other_user}", "gists_url": "https://api.github.com/users/moloney/gists{/gist_id}", "starred_url": "https://api.github.com/users/moloney/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/moloney/subscriptions", "organizations_url": "https://api.github.com/users/moloney/orgs", "repos_url": "https://api.github.com/users/moloney/repos", "events_url": "https://api.github.com/users/moloney/events{/privacy}", "received_events_url": "https://api.github.com/users/moloney/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I found that wrapping the for loop in a transaction solves the problem, so I guess this is expected behavior. It does still seem worth it to make this more clear in the documentation.\n", "Check out:\n- https://github.com/coleifer/peewee/issues/12#issuecomment-5614404\n- https://github.com/coleifer/peewee/issues/81\n" ]

"2014-07-09T03:46:51"

"2014-10-01T20:16:47"

"2014-07-09T12:50:30"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/388/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "alexlatchford", "id": 628146, "node_id": "MDQ6VXNlcjYyODE0Ng==", "avatar_url": "https://avatars.githubusercontent.com/u/628146?v=4", "gravatar_id": "", "url": "https://api.github.com/users/alexlatchford", "html_url": "https://github.com/alexlatchford", "followers_url": "https://api.github.com/users/alexlatchford/followers", "following_url": "https://api.github.com/users/alexlatchford/following{/other_user}", "gists_url": "https://api.github.com/users/alexlatchford/gists{/gist_id}", "starred_url": "https://api.github.com/users/alexlatchford/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/alexlatchford/subscriptions", "organizations_url": "https://api.github.com/users/alexlatchford/orgs", "repos_url": "https://api.github.com/users/alexlatchford/repos", "events_url": "https://api.github.com/users/alexlatchford/events{/privacy}", "received_events_url": "https://api.github.com/users/alexlatchford/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Looks good, thanks for this!\n", "Awesome cheers Charles. Just me being cheeky but what's your release schedule normally? Is it just when it hits a critical mass or is timed etc., obviously looking to get this into my product officially (I'll use a git dependency for now though :))\n\nThanks again,\nAlex\n", "It's very abstract at the moment, but I can push a new release, no probs.\n", "2.2.5 now available on pypi.\n", "Awesome, thanks! Love this module :smile: \n" ]

"2014-07-07T06:48:30"

"2014-07-08T22:37:57"

"2014-07-07T11:41:17"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/387/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/387", "html_url": "https://github.com/coleifer/peewee/pull/387", "diff_url": "https://github.com/coleifer/peewee/pull/387.diff", "patch_url": "https://github.com/coleifer/peewee/pull/387.patch", "merged_at": "2014-07-07T11:41:17" }

{ "login": "pitchforks", "id": 4378791, "node_id": "MDQ6VXNlcjQzNzg3OTE=", "avatar_url": "https://avatars.githubusercontent.com/u/4378791?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pitchforks", "html_url": "https://github.com/pitchforks", "followers_url": "https://api.github.com/users/pitchforks/followers", "following_url": "https://api.github.com/users/pitchforks/following{/other_user}", "gists_url": "https://api.github.com/users/pitchforks/gists{/gist_id}", "starred_url": "https://api.github.com/users/pitchforks/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pitchforks/subscriptions", "organizations_url": "https://api.github.com/users/pitchforks/orgs", "repos_url": "https://api.github.com/users/pitchforks/repos", "events_url": "https://api.github.com/users/pitchforks/events{/privacy}", "received_events_url": "https://api.github.com/users/pitchforks/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I'm not sure what to do about this on the peewee side -- perhaps you could just add the following to your models:\n\n``` python\nid = PrimaryKeyField()\n```\n", "This works. Thank you.\n" ]

"2014-07-06T00:16:45"

"2014-07-07T03:31:28"

"2014-07-07T00:30:17"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/386/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "kramer65", "id": 596581, "node_id": "MDQ6VXNlcjU5NjU4MQ==", "avatar_url": "https://avatars.githubusercontent.com/u/596581?v=4", "gravatar_id": "", "url": "https://api.github.com/users/kramer65", "html_url": "https://github.com/kramer65", "followers_url": "https://api.github.com/users/kramer65/followers", "following_url": "https://api.github.com/users/kramer65/following{/other_user}", "gists_url": "https://api.github.com/users/kramer65/gists{/gist_id}", "starred_url": "https://api.github.com/users/kramer65/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kramer65/subscriptions", "organizations_url": "https://api.github.com/users/kramer65/orgs", "repos_url": "https://api.github.com/users/kramer65/repos", "events_url": "https://api.github.com/users/kramer65/events{/privacy}", "received_events_url": "https://api.github.com/users/kramer65/received_events", "type": "User", "site_admin": false }

[]

[]

[ "In your `DATABASE` declaration just put `'threadlocals': True` -- that's all you need to do.\n" ]

"2014-07-05T00:01:55"

"2014-07-05T18:12:21"

"2014-07-05T18:12:21"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/385/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "alexlatchford", "id": 628146, "node_id": "MDQ6VXNlcjYyODE0Ng==", "avatar_url": "https://avatars.githubusercontent.com/u/628146?v=4", "gravatar_id": "", "url": "https://api.github.com/users/alexlatchford", "html_url": "https://github.com/alexlatchford", "followers_url": "https://api.github.com/users/alexlatchford/followers", "following_url": "https://api.github.com/users/alexlatchford/following{/other_user}", "gists_url": "https://api.github.com/users/alexlatchford/gists{/gist_id}", "starred_url": "https://api.github.com/users/alexlatchford/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/alexlatchford/subscriptions", "organizations_url": "https://api.github.com/users/alexlatchford/orgs", "repos_url": "https://api.github.com/users/alexlatchford/repos", "events_url": "https://api.github.com/users/alexlatchford/events{/privacy}", "received_events_url": "https://api.github.com/users/alexlatchford/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Aha, scratch that I found the 1.0 -> 2.0 upgrade notes. My bad, closing...\n\nFor anyone finding this:\n\n``` python\nclass MyModel(Model):\n uuid = UUIDField(primary_key=True)\n ...\n```\n" ]

"2014-07-04T03:45:09"

"2014-07-04T03:52:06"

"2014-07-04T03:52:06"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/384/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "yueyoum", "id": 2081686, "node_id": "MDQ6VXNlcjIwODE2ODY=", "avatar_url": "https://avatars.githubusercontent.com/u/2081686?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yueyoum", "html_url": "https://github.com/yueyoum", "followers_url": "https://api.github.com/users/yueyoum/followers", "following_url": "https://api.github.com/users/yueyoum/following{/other_user}", "gists_url": "https://api.github.com/users/yueyoum/gists{/gist_id}", "starred_url": "https://api.github.com/users/yueyoum/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yueyoum/subscriptions", "organizations_url": "https://api.github.com/users/yueyoum/orgs", "repos_url": "https://api.github.com/users/yueyoum/repos", "events_url": "https://api.github.com/users/yueyoum/events{/privacy}", "received_events_url": "https://api.github.com/users/yueyoum/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Yes it does, You need to set Threadlocals to True\n\n```\n# app configuration\nDATABASE = {\n 'name': 'my_db',\n 'engine': 'peewee.PostgresqlDatabase',\n 'user': 'postgres',\n 'threadlocals': True, # <-- this\n}\n```\n\nand then just monkey patch the thread module.\n", "If you're using it with postgresql you need to monkeypatch `psycopg2`:\n\n``` python\nfrom gevent import monkey\n\nfrom gevent.socket import wait_read, wait_write\ntry:\n from psycopg2 import extensions\nexcept ImportError:\n extensions = None\n\n\ndef monkeypatch_psycopg2():\n extensions.set_wait_callback(gevent_wait_callback)\n\ndef gevent_wait_callback(conn, timeout=None):\n \"\"\"A wait callback useful to allow gevent to work with Psycopg.\"\"\"\n while 1:\n state = conn.poll()\n if state == extensions.POLL_OK:\n break\n elif state == extensions.POLL_READ:\n wait_read(conn.fileno(), timeout=timeout)\n elif state == extensions.POLL_WRITE:\n wait_write(conn.fileno(), timeout=timeout)\n else:\n raise psycopg2.OperationalError(\n \"Bad result from poll: %r\" % state)\n```\n" ]

"2014-07-02T07:56:38"

"2014-07-02T13:35:10"

"2014-07-02T13:35:10"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/383/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "jonathan-s", "id": 2124818, "node_id": "MDQ6VXNlcjIxMjQ4MTg=", "avatar_url": "https://avatars.githubusercontent.com/u/2124818?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jonathan-s", "html_url": "https://github.com/jonathan-s", "followers_url": "https://api.github.com/users/jonathan-s/followers", "following_url": "https://api.github.com/users/jonathan-s/following{/other_user}", "gists_url": "https://api.github.com/users/jonathan-s/gists{/gist_id}", "starred_url": "https://api.github.com/users/jonathan-s/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jonathan-s/subscriptions", "organizations_url": "https://api.github.com/users/jonathan-s/orgs", "repos_url": "https://api.github.com/users/jonathan-s/repos", "events_url": "https://api.github.com/users/jonathan-s/events{/privacy}", "received_events_url": "https://api.github.com/users/jonathan-s/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Try adding `UserOrder.link_to_id` to the select clause:\n\n``` python\n(ExtensionData.\n select(\n ExtensionData, UserOrder.avg_user, UserOrder.link_to_id)\n .join(UserOrder, on=(ExtensionData.id == UserOrder.link_to_id))\n .order_by(UserOrder.avg_user.desc()))\n```\n\nIf that doesn't work, could you share a minimal set of model code so that I can attempt to reproduce the issue?\n", "Nope, your suggested solution did not work. I've shared my model code below. UserOrder is a view. \n\n```\nclass BaseModel(Model):\n class Meta:\n database = db\n\nclass ExtensionData(BaseModel):\n name = CharField()\n link = CharField(unique=True) \n hp = CharField(null=True)\n email = CharField(null=True)\n category = CharField(null=True)\n browser = CharField()\n updated = DateField(default=datetime.date.today())\n\nclass DailyData(BaseModel):\n date_scraped = DateField(default=datetime.date.today())\n link_to = ForeignKeyField(ExtensionData, related_name='data_entries')\n nr_users = IntegerField()\n nr_reviews = IntegerField()\n downloads = IntegerField(null=True)\n rating = DecimalField()\n\nclass UserOrder(BaseModel):\n link_to_id = PrimaryKeyField()\n avg_user = FloatField()\n\n class Meta:\n db_table = 'user_order'\n```\n", "The issue is that the `id` field is getting overwritten by the related `UserOrder`. To fix this:\n\n``` python\n(ExtensionData.\n select(\n ExtensionData, UserOrder.avg_user, UserOrder.link_to_id)\n .join(\n UserOrder, \n on=(ExtensionData.id == UserOrder.link_to_id).alias('user_order'))\n .order_by(UserOrder.avg_user.desc()))\n```\n", "Great, thank you. I'm thinking of writing something about this in the documentation, it would be nice to include something about referring views as well as I couldn't find that in the documentation either when I was looking. Perhaps under Peewee cookbook section?\n", "Sounds good, feel free to submit a pull-request.\n" ]

"2014-06-30T20:44:48"

"2014-07-01T20:32:41"

"2014-07-01T19:42:47"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/382/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "jpttrssn", "id": 194305, "node_id": "MDQ6VXNlcjE5NDMwNQ==", "avatar_url": "https://avatars.githubusercontent.com/u/194305?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jpttrssn", "html_url": "https://github.com/jpttrssn", "followers_url": "https://api.github.com/users/jpttrssn/followers", "following_url": "https://api.github.com/users/jpttrssn/following{/other_user}", "gists_url": "https://api.github.com/users/jpttrssn/gists{/gist_id}", "starred_url": "https://api.github.com/users/jpttrssn/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jpttrssn/subscriptions", "organizations_url": "https://api.github.com/users/jpttrssn/orgs", "repos_url": "https://api.github.com/users/jpttrssn/repos", "events_url": "https://api.github.com/users/jpttrssn/events{/privacy}", "received_events_url": "https://api.github.com/users/jpttrssn/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I'm going to pass on merging this changeset. Even though MySQL does not support LIMIT on subqueries, you still could perform the limit prior to calling `prefetch()`, e.g.:\n\n``` python\nq1 = User.select()\nq2 = Blog.select().limit(10)\nprefetch(q1, q2) # does not work on mysql\n```\n\nInstead do:\n\n``` python\nq1 = User.select()\nq2 = Blog.select().limit(10)\nq2_fixed = Blog.select().where(Blog.id << [x.id for x in q2])\nprefetch(q1, q2_fixed) # this should work fine.\n```\n", "What if I need to limit the User query and not the Blog query?\n\n```\nq1 = User.select().limit(10)\nq2 = Blog.select()\nprefetch(q1, q2) # does not work on mysql\n```\n", "Do the same thing...\n\n``` python\nq1 = User.select().limit(10)\nq1_fixed = User.select().where(User.id << [x.id for x in q1])\nprefetch(q1_fixed, Blog.select())\n```\n", "I'm trying to avoid running extra queries, but this will do. Thanks, man!\n" ]

"2014-06-30T16:11:52"

"2014-07-02T19:54:48"

"2014-07-02T19:20:33"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/381/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/381", "html_url": "https://github.com/coleifer/peewee/pull/381", "diff_url": "https://github.com/coleifer/peewee/pull/381.diff", "patch_url": "https://github.com/coleifer/peewee/pull/381.patch", "merged_at": null }

{ "login": "coleifer", "id": 119974, "node_id": "MDQ6VXNlcjExOTk3NA==", "avatar_url": "https://avatars.githubusercontent.com/u/119974?v=4", "gravatar_id": "", "url": "https://api.github.com/users/coleifer", "html_url": "https://github.com/coleifer", "followers_url": "https://api.github.com/users/coleifer/followers", "following_url": "https://api.github.com/users/coleifer/following{/other_user}", "gists_url": "https://api.github.com/users/coleifer/gists{/gist_id}", "starred_url": "https://api.github.com/users/coleifer/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/coleifer/subscriptions", "organizations_url": "https://api.github.com/users/coleifer/orgs", "repos_url": "https://api.github.com/users/coleifer/repos", "events_url": "https://api.github.com/users/coleifer/events{/privacy}", "received_events_url": "https://api.github.com/users/coleifer/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I can confirm the weird behavior with the testcase above and on my code too. In my case the models are similar: a Feed model and an Entry model, with the latter having a FK to Feed. \n\nOn my machine it gives this error:\n\n> peewee.OperationalError: table page__tmp__ has no column named FOREIGN\n\nI'm using:\n\n```\nUnderworld:$ python\nPython 2.7.6 (v2.7.6:3a1db0d2747e, Nov 10 2013, 00:42:54) \n>>> import sqlite3 as s\n>>> s.version\n'2.6.0'\n>>> s.sqlite_version\n'3.7.13'\n```\n", "Replicated this in a test-case, working up a fix.\n" ]

"2014-06-23T13:11:32"

"2014-07-09T18:24:02"

"2014-07-09T18:24:02"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/380/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "frewsxcv", "id": 416575, "node_id": "MDQ6VXNlcjQxNjU3NQ==", "avatar_url": "https://avatars.githubusercontent.com/u/416575?v=4", "gravatar_id": "", "url": "https://api.github.com/users/frewsxcv", "html_url": "https://github.com/frewsxcv", "followers_url": "https://api.github.com/users/frewsxcv/followers", "following_url": "https://api.github.com/users/frewsxcv/following{/other_user}", "gists_url": "https://api.github.com/users/frewsxcv/gists{/gist_id}", "starred_url": "https://api.github.com/users/frewsxcv/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/frewsxcv/subscriptions", "organizations_url": "https://api.github.com/users/frewsxcv/orgs", "repos_url": "https://api.github.com/users/frewsxcv/repos", "events_url": "https://api.github.com/users/frewsxcv/events{/privacy}", "received_events_url": "https://api.github.com/users/frewsxcv/received_events", "type": "User", "site_admin": false }

[]

[]

[]

"2014-06-20T16:20:07"

"2014-06-20T19:07:11"

"2014-06-20T16:35:33"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/379/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/379", "html_url": "https://github.com/coleifer/peewee/pull/379", "diff_url": "https://github.com/coleifer/peewee/pull/379.diff", "patch_url": "https://github.com/coleifer/peewee/pull/379.patch", "merged_at": "2014-06-20T16:35:33" }

{ "login": "jonathan-s", "id": 2124818, "node_id": "MDQ6VXNlcjIxMjQ4MTg=", "avatar_url": "https://avatars.githubusercontent.com/u/2124818?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jonathan-s", "html_url": "https://github.com/jonathan-s", "followers_url": "https://api.github.com/users/jonathan-s/followers", "following_url": "https://api.github.com/users/jonathan-s/following{/other_user}", "gists_url": "https://api.github.com/users/jonathan-s/gists{/gist_id}", "starred_url": "https://api.github.com/users/jonathan-s/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jonathan-s/subscriptions", "organizations_url": "https://api.github.com/users/jonathan-s/orgs", "repos_url": "https://api.github.com/users/jonathan-s/repos", "events_url": "https://api.github.com/users/jonathan-s/events{/privacy}", "received_events_url": "https://api.github.com/users/jonathan-s/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Ok, I solved it. \n\nI created a view in my database and then in my models.py I created a model for it. \n\n```\nclass UserOrder(BaseModel):\n link_to_id = PrimaryKeyField()\n avg_user = FloatField()\n\n class Meta:\n db_table = 'user_order'\n```\n\nWhere db_table is the reference to the actual view and the fields in the view are listed above. Then I could happily join the two together. \n" ]

"2014-06-18T18:18:50"

"2014-06-19T15:20:22"

"2014-06-19T15:07:31"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/378/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "demongoo", "id": 941459, "node_id": "MDQ6VXNlcjk0MTQ1OQ==", "avatar_url": "https://avatars.githubusercontent.com/u/941459?v=4", "gravatar_id": "", "url": "https://api.github.com/users/demongoo", "html_url": "https://github.com/demongoo", "followers_url": "https://api.github.com/users/demongoo/followers", "following_url": "https://api.github.com/users/demongoo/following{/other_user}", "gists_url": "https://api.github.com/users/demongoo/gists{/gist_id}", "starred_url": "https://api.github.com/users/demongoo/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/demongoo/subscriptions", "organizations_url": "https://api.github.com/users/demongoo/orgs", "repos_url": "https://api.github.com/users/demongoo/repos", "events_url": "https://api.github.com/users/demongoo/events{/privacy}", "received_events_url": "https://api.github.com/users/demongoo/received_events", "type": "User", "site_admin": false }

[]

[]

[ "pwiz certainly has limitations and it's very possible cross-schema foreign keys are one of them. I think I will close this as wontfix but feel free to submit a patch.\n" ]

"2014-06-18T15:18:27"

"2014-06-19T18:02:17"

"2014-06-19T18:02:17"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/377/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "soasme", "id": 369081, "node_id": "MDQ6VXNlcjM2OTA4MQ==", "avatar_url": "https://avatars.githubusercontent.com/u/369081?v=4", "gravatar_id": "", "url": "https://api.github.com/users/soasme", "html_url": "https://github.com/soasme", "followers_url": "https://api.github.com/users/soasme/followers", "following_url": "https://api.github.com/users/soasme/following{/other_user}", "gists_url": "https://api.github.com/users/soasme/gists{/gist_id}", "starred_url": "https://api.github.com/users/soasme/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/soasme/subscriptions", "organizations_url": "https://api.github.com/users/soasme/orgs", "repos_url": "https://api.github.com/users/soasme/repos", "events_url": "https://api.github.com/users/soasme/events{/privacy}", "received_events_url": "https://api.github.com/users/soasme/received_events", "type": "User", "site_admin": false }

[]

[]

[ ":+1: \n" ]

"2014-06-17T09:29:37"

"2014-06-18T14:54:46"

"2014-06-18T14:51:16"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/376/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "demongoo", "id": 941459, "node_id": "MDQ6VXNlcjk0MTQ1OQ==", "avatar_url": "https://avatars.githubusercontent.com/u/941459?v=4", "gravatar_id": "", "url": "https://api.github.com/users/demongoo", "html_url": "https://github.com/demongoo", "followers_url": "https://api.github.com/users/demongoo/followers", "following_url": "https://api.github.com/users/demongoo/following{/other_user}", "gists_url": "https://api.github.com/users/demongoo/gists{/gist_id}", "starred_url": "https://api.github.com/users/demongoo/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/demongoo/subscriptions", "organizations_url": "https://api.github.com/users/demongoo/orgs", "repos_url": "https://api.github.com/users/demongoo/repos", "events_url": "https://api.github.com/users/demongoo/events{/privacy}", "received_events_url": "https://api.github.com/users/demongoo/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Nice, I've added your changes.\n" ]

"2014-06-17T09:25:58"

"2014-06-18T14:49:44"

"2014-06-18T14:49:44"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/375/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/375", "html_url": "https://github.com/coleifer/peewee/pull/375", "diff_url": "https://github.com/coleifer/peewee/pull/375.diff", "patch_url": "https://github.com/coleifer/peewee/pull/375.patch", "merged_at": null }

{ "login": "scls19fr", "id": 109167, "node_id": "MDQ6VXNlcjEwOTE2Nw==", "avatar_url": "https://avatars.githubusercontent.com/u/109167?v=4", "gravatar_id": "", "url": "https://api.github.com/users/scls19fr", "html_url": "https://github.com/scls19fr", "followers_url": "https://api.github.com/users/scls19fr/followers", "following_url": "https://api.github.com/users/scls19fr/following{/other_user}", "gists_url": "https://api.github.com/users/scls19fr/gists{/gist_id}", "starred_url": "https://api.github.com/users/scls19fr/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/scls19fr/subscriptions", "organizations_url": "https://api.github.com/users/scls19fr/orgs", "repos_url": "https://api.github.com/users/scls19fr/repos", "events_url": "https://api.github.com/users/scls19fr/events{/privacy}", "received_events_url": "https://api.github.com/users/scls19fr/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Try reading\nhttp://peewee.readthedocs.org/en/latest/peewee/models.html#non-integer-primary-keys\nOn Jun 14, 2014 2:56 PM, \"scls19fr\" notifications@github.com wrote:\n\n> Hello,\n> \n> I'm new to Peewee.\n> \n> I did this code:\n> \n> from peewee import *\n> \n> db = SqliteDatabase('json_rpc.sqlite')\n> \n> class RPC(Model):\n> terminal_id = CharField()\n> request_id = CharField()\n> request = CharField()\n> response = CharField()\n> \n> ```\n> class Meta:\n> database = db\n> primary_key = CompositeKey('terminal_id', 'request_id')\n> ```\n> \n> # connect to our database\n> \n> db.connect()\n> \n> RPC.create_table()\n> \n> terminal_id = 'test01'\n> request_id = 2\n> request = '{\"jsonrpc\": \"2.0\", \"method\": \"subtract\", \"params\": [42, 23], \"id\": '+ str(request_id) + '}'\n> response = \"\"\n> rpc = RPC(\n> terminal_id=terminal_id,\n> request_id = request_id,\n> request=request,\n> response=response\n> )\n> rpc.save()\n> \n> Unfortunatelly row is not inserted into SQLite database (without any\n> error).\n> \n> If I comment primary_key = CompositeKey('terminal_id', 'request_id')\n> row is inserted (but there is no security to ensure that there is a unique\n> couple (terminal_id, request_id)).\n> \n> So I don't know if this is really an issue or a misunderstanding from my\n> side.\n> \n> Kind regards\n> \n> —\n> Reply to this email directly or view it on GitHub\n> https://github.com/coleifer/peewee/issues/374.\n", "Thanks for the tip\n`rpc.save(force_insert=True)` fixes my problem\n" ]

"2014-06-14T19:56:06"

"2014-06-16T02:32:59"

"2014-06-16T02:32:59"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/374/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "scls19fr", "id": 109167, "node_id": "MDQ6VXNlcjEwOTE2Nw==", "avatar_url": "https://avatars.githubusercontent.com/u/109167?v=4", "gravatar_id": "", "url": "https://api.github.com/users/scls19fr", "html_url": "https://github.com/scls19fr", "followers_url": "https://api.github.com/users/scls19fr/followers", "following_url": "https://api.github.com/users/scls19fr/following{/other_user}", "gists_url": "https://api.github.com/users/scls19fr/gists{/gist_id}", "starred_url": "https://api.github.com/users/scls19fr/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/scls19fr/subscriptions", "organizations_url": "https://api.github.com/users/scls19fr/orgs", "repos_url": "https://api.github.com/users/scls19fr/repos", "events_url": "https://api.github.com/users/scls19fr/events{/privacy}", "received_events_url": "https://api.github.com/users/scls19fr/received_events", "type": "User", "site_admin": false }

[]

[]

[]

"2014-06-14T19:32:22"

"2014-06-16T02:33:03"

"2014-06-16T02:33:03"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/373/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "stas", "id": 112147, "node_id": "MDQ6VXNlcjExMjE0Nw==", "avatar_url": "https://avatars.githubusercontent.com/u/112147?v=4", "gravatar_id": "", "url": "https://api.github.com/users/stas", "html_url": "https://github.com/stas", "followers_url": "https://api.github.com/users/stas/followers", "following_url": "https://api.github.com/users/stas/following{/other_user}", "gists_url": "https://api.github.com/users/stas/gists{/gist_id}", "starred_url": "https://api.github.com/users/stas/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/stas/subscriptions", "organizations_url": "https://api.github.com/users/stas/orgs", "repos_url": "https://api.github.com/users/stas/repos", "events_url": "https://api.github.com/users/stas/events{/privacy}", "received_events_url": "https://api.github.com/users/stas/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Good catch, thanks I will look into fixing this.\n", "The thing is that the migrator methods for adding indexes are not aware of the column types, so this doesn't really make sense. Maybe it would be better to subclass `Migrator` and allow the `add_index` operation to accept some additional arguments?\n\nFor now I am closing as wontfix.\n", "You're right, the problem is that migrator has no idea about the column type. As a solution right now, I'm calling the `Model._meta.database.add_index` instead. Tbh, I would just make the migrator method do the same: pass the call to the existent database instance method.\n" ]

"2014-06-14T18:02:00"

"2014-07-11T08:22:17"

"2014-07-09T18:27:23"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/372/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "amedeedaboville", "id": 826619, "node_id": "MDQ6VXNlcjgyNjYxOQ==", "avatar_url": "https://avatars.githubusercontent.com/u/826619?v=4", "gravatar_id": "", "url": "https://api.github.com/users/amedeedaboville", "html_url": "https://github.com/amedeedaboville", "followers_url": "https://api.github.com/users/amedeedaboville/followers", "following_url": "https://api.github.com/users/amedeedaboville/following{/other_user}", "gists_url": "https://api.github.com/users/amedeedaboville/gists{/gist_id}", "starred_url": "https://api.github.com/users/amedeedaboville/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/amedeedaboville/subscriptions", "organizations_url": "https://api.github.com/users/amedeedaboville/orgs", "repos_url": "https://api.github.com/users/amedeedaboville/repos", "events_url": "https://api.github.com/users/amedeedaboville/events{/privacy}", "received_events_url": "https://api.github.com/users/amedeedaboville/received_events", "type": "User", "site_admin": false }

[]

[]

[]

"2014-06-09T19:31:45"

"2014-06-13T13:31:25"

"2014-06-10T00:44:53"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/371/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/371", "html_url": "https://github.com/coleifer/peewee/pull/371", "diff_url": "https://github.com/coleifer/peewee/pull/371.diff", "patch_url": "https://github.com/coleifer/peewee/pull/371.patch", "merged_at": "2014-06-10T00:44:53" }

{ "login": "jpttrssn", "id": 194305, "node_id": "MDQ6VXNlcjE5NDMwNQ==", "avatar_url": "https://avatars.githubusercontent.com/u/194305?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jpttrssn", "html_url": "https://github.com/jpttrssn", "followers_url": "https://api.github.com/users/jpttrssn/followers", "following_url": "https://api.github.com/users/jpttrssn/following{/other_user}", "gists_url": "https://api.github.com/users/jpttrssn/gists{/gist_id}", "starred_url": "https://api.github.com/users/jpttrssn/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jpttrssn/subscriptions", "organizations_url": "https://api.github.com/users/jpttrssn/orgs", "repos_url": "https://api.github.com/users/jpttrssn/repos", "events_url": "https://api.github.com/users/jpttrssn/events{/privacy}", "received_events_url": "https://api.github.com/users/jpttrssn/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Nice, could you rebase your commits into a single commit?\n", "Done.\n", "Nice, thank you very much!\n" ]

"2014-06-09T06:16:52"

"2014-06-20T17:41:56"

"2014-06-09T19:36:13"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/370/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/370", "html_url": "https://github.com/coleifer/peewee/pull/370", "diff_url": "https://github.com/coleifer/peewee/pull/370.diff", "patch_url": "https://github.com/coleifer/peewee/pull/370.patch", "merged_at": "2014-06-09T19:36:13" }

{ "login": "jpttrssn", "id": 194305, "node_id": "MDQ6VXNlcjE5NDMwNQ==", "avatar_url": "https://avatars.githubusercontent.com/u/194305?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jpttrssn", "html_url": "https://github.com/jpttrssn", "followers_url": "https://api.github.com/users/jpttrssn/followers", "following_url": "https://api.github.com/users/jpttrssn/following{/other_user}", "gists_url": "https://api.github.com/users/jpttrssn/gists{/gist_id}", "starred_url": "https://api.github.com/users/jpttrssn/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jpttrssn/subscriptions", "organizations_url": "https://api.github.com/users/jpttrssn/orgs", "repos_url": "https://api.github.com/users/jpttrssn/repos", "events_url": "https://api.github.com/users/jpttrssn/events{/privacy}", "received_events_url": "https://api.github.com/users/jpttrssn/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I think I might take a crack at this myself. I'm surprised that there's no sqlite on GAE!\n", "Fixed in 6838d8ec54093ebefca4b436abff601e14f94795 -- thanks for the diff and bringing this to my attention! Look forward to more PRs in the future!\n" ]

"2014-06-07T21:37:06"

"2014-07-06T01:49:55"

"2014-06-08T11:33:44"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/369/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/369", "html_url": "https://github.com/coleifer/peewee/pull/369", "diff_url": "https://github.com/coleifer/peewee/pull/369.diff", "patch_url": "https://github.com/coleifer/peewee/pull/369.patch", "merged_at": null }

{ "login": "jonathan-s", "id": 2124818, "node_id": "MDQ6VXNlcjIxMjQ4MTg=", "avatar_url": "https://avatars.githubusercontent.com/u/2124818?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jonathan-s", "html_url": "https://github.com/jonathan-s", "followers_url": "https://api.github.com/users/jonathan-s/followers", "following_url": "https://api.github.com/users/jonathan-s/following{/other_user}", "gists_url": "https://api.github.com/users/jonathan-s/gists{/gist_id}", "starred_url": "https://api.github.com/users/jonathan-s/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jonathan-s/subscriptions", "organizations_url": "https://api.github.com/users/jonathan-s/orgs", "repos_url": "https://api.github.com/users/jonathan-s/repos", "events_url": "https://api.github.com/users/jonathan-s/events{/privacy}", "received_events_url": "https://api.github.com/users/jonathan-s/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Where is the `TypeError` originating from? Can you include the full traceback?\n", "Actually I think I know what might be happening.\n\nTry changing your `__getattribute__()` to `getattr`, e.g.\n\n``` python\nExtensionData.select().order_by(getattr(DailyData, prop).desc()).limit(500).iterator()\n```\n", "Thanks!\n" ]

"2014-06-03T12:10:03"

"2014-06-03T13:56:42"

"2014-06-03T13:53:06"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/368/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "idella", "id": 1655078, "node_id": "MDQ6VXNlcjE2NTUwNzg=", "avatar_url": "https://avatars.githubusercontent.com/u/1655078?v=4", "gravatar_id": "", "url": "https://api.github.com/users/idella", "html_url": "https://github.com/idella", "followers_url": "https://api.github.com/users/idella/followers", "following_url": "https://api.github.com/users/idella/following{/other_user}", "gists_url": "https://api.github.com/users/idella/gists{/gist_id}", "starred_url": "https://api.github.com/users/idella/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/idella/subscriptions", "organizations_url": "https://api.github.com/users/idella/orgs", "repos_url": "https://api.github.com/users/idella/repos", "events_url": "https://api.github.com/users/idella/events{/privacy}", "received_events_url": "https://api.github.com/users/idella/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I run continuous integration with python versions 2.6, 2.7, 3.2 and 3.3 and both sqlite and postgresql backends. All appear to be passing:\n\nhttps://travis-ci.org/coleifer/peewee\n", "On current Gentoo (unstable), I observe the same test failures and output as idella attached above when running `PEEWEE_TEST_BACKEND=sqlite python runtests.py` under Python 3.3.5, and also the same (apart from test_tuples_dicts which does not fail) under Python 3.4.0. Adding the '-a' switch, as per .travis.yml yields `ImportError: No module named 'StringIO'`.\n", "ok with a prompt from eroen, it came to my attention that 2.2.1 is in fact an old release. How this came about is frankly an unhelpful factor here. Suffice to say we figured it. Now have a 2.2.4 passing the testsuite under all pythons\n", "Glad you have 2.2.4 passing, sorry for the confusion this must have caused.\n" ]

"2014-06-02T05:03:56"

"2014-06-02T13:41:03"

"2014-06-02T09:57:12"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/367/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "ayang", "id": 556676, "node_id": "MDQ6VXNlcjU1NjY3Ng==", "avatar_url": "https://avatars.githubusercontent.com/u/556676?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ayang", "html_url": "https://github.com/ayang", "followers_url": "https://api.github.com/users/ayang/followers", "following_url": "https://api.github.com/users/ayang/following{/other_user}", "gists_url": "https://api.github.com/users/ayang/gists{/gist_id}", "starred_url": "https://api.github.com/users/ayang/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ayang/subscriptions", "organizations_url": "https://api.github.com/users/ayang/orgs", "repos_url": "https://api.github.com/users/ayang/repos", "events_url": "https://api.github.com/users/ayang/events{/privacy}", "received_events_url": "https://api.github.com/users/ayang/received_events", "type": "User", "site_admin": false }

[]

[]

[ "You can use `Pet._data['owner']`.\n", "Thank you\n" ]

"2014-06-01T12:35:32"

"2014-06-01T14:28:42"

"2014-06-01T13:51:33"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/366/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "arnuschky", "id": 179920, "node_id": "MDQ6VXNlcjE3OTkyMA==", "avatar_url": "https://avatars.githubusercontent.com/u/179920?v=4", "gravatar_id": "", "url": "https://api.github.com/users/arnuschky", "html_url": "https://github.com/arnuschky", "followers_url": "https://api.github.com/users/arnuschky/followers", "following_url": "https://api.github.com/users/arnuschky/following{/other_user}", "gists_url": "https://api.github.com/users/arnuschky/gists{/gist_id}", "starred_url": "https://api.github.com/users/arnuschky/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/arnuschky/subscriptions", "organizations_url": "https://api.github.com/users/arnuschky/orgs", "repos_url": "https://api.github.com/users/arnuschky/repos", "events_url": "https://api.github.com/users/arnuschky/events{/privacy}", "received_events_url": "https://api.github.com/users/arnuschky/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I am now monkey-patching my models (see issue mentioned above). Would be great if we could come up with a less 'hacky' solutions, though.\n", "Check out these docs: http://peewee.readthedocs.org/en/latest/peewee/cookbook.html#dynamically-defining-a-database\n", "Ah. D'oh. Thank you. Works like a charm.\n", "Link http://peewee.readthedocs.org/en/latest/peewee/cookbook.html#dynamically-defining-a-database doesn't exist anymore. Can you help?", "* http://docs.peewee-orm.com/en/latest/peewee/database.html#run-time-database-configuration\r\n* http://docs.peewee-orm.com/en/latest/peewee/database.html#dynamically-defining-a-database", "Thank you,\n\nworks very well!\nRegards / Liebe Grüße,\n\nRalph Mueller\n\nAnnastrasse 44, 64673 Zwingenberg\nMobile: +49 177 449 0460\nOffice: +49 6251 789545\nemail: ralph.mueller.de@gmail.com <mailto:ralph.mueller.de@gmail.com>\nhttps://www.ralph-mueller.net <https://www.ralph-mueller.net/>\n\n\n\n> Am 15.03.2018 um 14:51 schrieb Charles Leifer <notifications@github.com>:\n> \n> http://docs.peewee-orm.com/en/latest/peewee/database.html#run-time-database-configuration <http://docs.peewee-orm.com/en/latest/peewee/database.html#run-time-database-configuration>\n> http://docs.peewee-orm.com/en/latest/peewee/database.html#dynamically-defining-a-database <http://docs.peewee-orm.com/en/latest/peewee/database.html#dynamically-defining-a-database>\n> —\n> You are receiving this because you commented.\n> Reply to this email directly, view it on GitHub <https://github.com/coleifer/peewee/issues/365#issuecomment-373382277>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADTj_Fu6e-McLX3HmyYyH7Pm9bsnFbHRks5tenHggaJpZM4CABL7>.\n> \n\n" ]

"2014-06-01T00:13:55"

"2018-03-15T16:07:48"

"2014-06-01T13:49:33"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/365/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "coleifer", "id": 119974, "node_id": "MDQ6VXNlcjExOTk3NA==", "avatar_url": "https://avatars.githubusercontent.com/u/119974?v=4", "gravatar_id": "", "url": "https://api.github.com/users/coleifer", "html_url": "https://github.com/coleifer", "followers_url": "https://api.github.com/users/coleifer/followers", "following_url": "https://api.github.com/users/coleifer/following{/other_user}", "gists_url": "https://api.github.com/users/coleifer/gists{/gist_id}", "starred_url": "https://api.github.com/users/coleifer/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/coleifer/subscriptions", "organizations_url": "https://api.github.com/users/coleifer/orgs", "repos_url": "https://api.github.com/users/coleifer/repos", "events_url": "https://api.github.com/users/coleifer/events{/privacy}", "received_events_url": "https://api.github.com/users/coleifer/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I did a bit of digging and it looks like you can write:\n\n```\nSELECT DISTINCT(col1, col2), col1, ... FROM\n```\n\nSo I'm going to close this since you can emulate this:\n\n``` python\nMyModel.select(fn.DISTINCT(MyModel.col1, MyModel.col2), MyModel.col1)...\n```\n", "Actually it turns out the semantics are a bit different... reopening.\n", "Fixed by 19d2c2e738f874c\n" ]

"2014-05-28T18:54:13"

"2014-05-29T03:32:17"

"2014-05-29T03:32:07"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/364/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "andmart", "id": 303252, "node_id": "MDQ6VXNlcjMwMzI1Mg==", "avatar_url": "https://avatars.githubusercontent.com/u/303252?v=4", "gravatar_id": "", "url": "https://api.github.com/users/andmart", "html_url": "https://github.com/andmart", "followers_url": "https://api.github.com/users/andmart/followers", "following_url": "https://api.github.com/users/andmart/following{/other_user}", "gists_url": "https://api.github.com/users/andmart/gists{/gist_id}", "starred_url": "https://api.github.com/users/andmart/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/andmart/subscriptions", "organizations_url": "https://api.github.com/users/andmart/orgs", "repos_url": "https://api.github.com/users/andmart/repos", "events_url": "https://api.github.com/users/andmart/events{/privacy}", "received_events_url": "https://api.github.com/users/andmart/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I am going to pass on this, but if you would like you can always subclass `MySQLDatabase` and implement this logic yourself. Catching `Exception` is far too broad and I believe this will lead to unpredictable behavior.\n", "It's true. I created a MySQLWithReconnectDatabase and narrowed the exception to _mysql_exceptions.OperationalError error code 2006.\n\nThanks, Charles.\n", "I actually like the idea of having it auto-reconnect on that error, I've\nhad the same issue before and fixed it by manually making a new connection\nevery time.\n\nOn Wed, May 28, 2014 at 10:56 PM, André Martins notifications@github.comwrote:\n\n> It's true. I created a MySQLWithReconnectDatabase and narrowed the\n> exception to _mysql_exceptions.OperationalError error code 2006.\n> \n> Thanks, Charles.\n> \n> —\n> Reply to this email directly or view it on GitHubhttps://github.com/coleifer/peewee/pull/363#issuecomment-44438590\n> .\n", "Perhaps this database subclass could go in `playhouse.mysql_ext`?\n", "I think there is no need for auto-reconnect feature. \n\nThe connection must be explicitly handled on every request by the developer of the app, not by peewee. That includes opening/closing it when needed.\n", "> The connection must be explicitly handled on every request by the developer of the app, not by peewee. That includes opening/closing it when needed.\n\n**Yes.**\n", "I agree, but there is not a single point in code to handle this. Instead, every use of peewee can throw this error. How could separate responsabilities and use peewee with a datapool, for example?\n", "In case you're interested, I've got a mixin for retrying failed queries in 017e4e4952f0b429dd21f0e90465a0f644cf6015 . Docs:\n\nhttp://docs.peewee-orm.com/en/latest/peewee/database.html#automatic-reconnect\n" ]

"2014-05-28T12:42:52"

"2015-09-30T03:40:31"

"2014-05-28T15:22:24"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/363/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/363", "html_url": "https://github.com/coleifer/peewee/pull/363", "diff_url": "https://github.com/coleifer/peewee/pull/363.diff", "patch_url": "https://github.com/coleifer/peewee/pull/363.patch", "merged_at": null }

{ "login": "mchaput", "id": 362643, "node_id": "MDQ6VXNlcjM2MjY0Mw==", "avatar_url": "https://avatars.githubusercontent.com/u/362643?v=4", "gravatar_id": "", "url": "https://api.github.com/users/mchaput", "html_url": "https://github.com/mchaput", "followers_url": "https://api.github.com/users/mchaput/followers", "following_url": "https://api.github.com/users/mchaput/following{/other_user}", "gists_url": "https://api.github.com/users/mchaput/gists{/gist_id}", "starred_url": "https://api.github.com/users/mchaput/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/mchaput/subscriptions", "organizations_url": "https://api.github.com/users/mchaput/orgs", "repos_url": "https://api.github.com/users/mchaput/repos", "events_url": "https://api.github.com/users/mchaput/events{/privacy}", "received_events_url": "https://api.github.com/users/mchaput/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Docs:\n- http://peewee.readthedocs.org/en/latest/peewee/cookbook.html#deferring-initialization\n- http://peewee.readthedocs.org/en/latest/peewee/cookbook.html#dynamically-defining-a-database\n\n> If the only way to use it is with globals, I don't think I can use peewee at all and I'll have to try something else.\n\nTo be honest, I don't want users with an attitude like yours.\n" ]

"2014-05-27T20:01:13"

"2014-05-27T20:12:16"

"2014-05-27T20:12:16"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/362/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "idella", "id": 1655078, "node_id": "MDQ6VXNlcjE2NTUwNzg=", "avatar_url": "https://avatars.githubusercontent.com/u/1655078?v=4", "gravatar_id": "", "url": "https://api.github.com/users/idella", "html_url": "https://github.com/idella", "followers_url": "https://api.github.com/users/idella/followers", "following_url": "https://api.github.com/users/idella/following{/other_user}", "gists_url": "https://api.github.com/users/idella/gists{/gist_id}", "starred_url": "https://api.github.com/users/idella/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/idella/subscriptions", "organizations_url": "https://api.github.com/users/idella/orgs", "repos_url": "https://api.github.com/users/idella/repos", "events_url": "https://api.github.com/users/idella/events{/privacy}", "received_events_url": "https://api.github.com/users/idella/received_events", "type": "User", "site_admin": false }

[]

[]

[ "The latest version, 0.2.3, is passing for me.\n", "sorry, still get 1 fail; Updated to peewee>=2.0.0, also wtforms.\n$ python -V\nPython 2.7.6\n\n``` python\nwtf-peewee-0.2.3 $ PYTHONPATH=. python ./runtests.py \ntest_blog_form (wtfpeewee.tests.WTFPeeweeTestCase) ... ok\ntest_blog_form_saving (wtfpeewee.tests.WTFPeeweeTestCase) ... ok\ntest_blog_form_with_obj (wtfpeewee.tests.WTFPeeweeTestCase) ... ok\ntest_choices (wtfpeewee.tests.WTFPeeweeTestCase) ... ok\ntest_defaults (wtfpeewee.tests.WTFPeeweeTestCase) ... ok\ntest_entry_form (wtfpeewee.tests.WTFPeeweeTestCase) ... ok\ntest_entry_form_saving (wtfpeewee.tests.WTFPeeweeTestCase) ... ok\ntest_entry_form_with_obj (wtfpeewee.tests.WTFPeeweeTestCase) ... ok\ntest_form_multiple (wtfpeewee.tests.WTFPeeweeTestCase) ... ok\ntest_form_with_only_exclude (wtfpeewee.tests.WTFPeeweeTestCase) ... ok\ntest_hidden_field (wtfpeewee.tests.WTFPeeweeTestCase) ... ok\ntest_hidden_field_none (wtfpeewee.tests.WTFPeeweeTestCase) ... ok\ntest_non_int_pk (wtfpeewee.tests.WTFPeeweeTestCase) ... ok\ntest_null_form_saving (wtfpeewee.tests.WTFPeeweeTestCase) ... FAIL\n\n======================================================================\nFAIL: test_null_form_saving (wtfpeewee.tests.WTFPeeweeTestCase)\n----------------------------------------------------------------------\nTraceback (most recent call last):\n File \"/mnt/gen2/TmpDir/portage/dev-python/wtf-peewee-0.2.3/work/wtf-peewee-0.2.3/wtfpeewee/tests.py\", line 348, in test_null_form_saving\n self.assertEqual(nfm.b, True)\nAssertionError: False != True\n\n----------------------------------------------------------------------\nRan 14 tests in 0.097s\n\nFAILED (failures=1)\n```\n" ]

"2014-05-25T03:11:34"

"2014-07-07T02:41:13"

"2014-05-25T09:33:44"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/361/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "oz123", "id": 1083045, "node_id": "MDQ6VXNlcjEwODMwNDU=", "avatar_url": "https://avatars.githubusercontent.com/u/1083045?v=4", "gravatar_id": "", "url": "https://api.github.com/users/oz123", "html_url": "https://github.com/oz123", "followers_url": "https://api.github.com/users/oz123/followers", "following_url": "https://api.github.com/users/oz123/following{/other_user}", "gists_url": "https://api.github.com/users/oz123/gists{/gist_id}", "starred_url": "https://api.github.com/users/oz123/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/oz123/subscriptions", "organizations_url": "https://api.github.com/users/oz123/orgs", "repos_url": "https://api.github.com/users/oz123/repos", "events_url": "https://api.github.com/users/oz123/events{/privacy}", "received_events_url": "https://api.github.com/users/oz123/received_events", "type": "User", "site_admin": false }

[]

[]

[ "The `Database` class has an `interpolation` attribute which you could set:\n\n``` python\nclass OracleDatabase(Database):\n interpolation = '%s'\n```\n\nUnfortunately there is no support for automatically numbering parameters. Will `%s` work?\n" ]

"2014-05-23T13:12:56"

"2014-05-23T17:02:47"

"2014-05-23T17:02:47"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/360/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "DarkRedman", "id": 367844, "node_id": "MDQ6VXNlcjM2Nzg0NA==", "avatar_url": "https://avatars.githubusercontent.com/u/367844?v=4", "gravatar_id": "", "url": "https://api.github.com/users/DarkRedman", "html_url": "https://github.com/DarkRedman", "followers_url": "https://api.github.com/users/DarkRedman/followers", "following_url": "https://api.github.com/users/DarkRedman/following{/other_user}", "gists_url": "https://api.github.com/users/DarkRedman/gists{/gist_id}", "starred_url": "https://api.github.com/users/DarkRedman/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/DarkRedman/subscriptions", "organizations_url": "https://api.github.com/users/DarkRedman/orgs", "repos_url": "https://api.github.com/users/DarkRedman/repos", "events_url": "https://api.github.com/users/DarkRedman/events{/privacy}", "received_events_url": "https://api.github.com/users/DarkRedman/received_events", "type": "User", "site_admin": false }

[]

[]

[ "> could it be updated to work with unique constraint too?\n\nThat would be a couple line function to write, so I think I will leave it out of peewee for now.\n" ]

"2014-05-19T03:09:43"

"2014-05-19T14:53:30"

"2014-05-19T14:53:30"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/359/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "jonathan-s", "id": 2124818, "node_id": "MDQ6VXNlcjIxMjQ4MTg=", "avatar_url": "https://avatars.githubusercontent.com/u/2124818?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jonathan-s", "html_url": "https://github.com/jonathan-s", "followers_url": "https://api.github.com/users/jonathan-s/followers", "following_url": "https://api.github.com/users/jonathan-s/following{/other_user}", "gists_url": "https://api.github.com/users/jonathan-s/gists{/gist_id}", "starred_url": "https://api.github.com/users/jonathan-s/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jonathan-s/subscriptions", "organizations_url": "https://api.github.com/users/jonathan-s/orgs", "repos_url": "https://api.github.com/users/jonathan-s/repos", "events_url": "https://api.github.com/users/jonathan-s/events{/privacy}", "received_events_url": "https://api.github.com/users/jonathan-s/received_events", "type": "User", "site_admin": false }

[]

[]

[ "You have many options, actually. You can:\n1. Set `ModelClass._meta.database` by hand, changing it to a test database.\n2. Use a `Proxy` for your `Database` and initialize it with a different database when testing [how-to](http://peewee.readthedocs.org/en/latest/peewee/cookbook.html#dynamically-defining-a-database).\n3. Use an uninitialized `Database` and initialize it with a different db name [how-to](http://peewee.readthedocs.org/en/latest/peewee/cookbook.html#deferring-initialization).\n4. Use `test_utils.test_database` context manager. [how-to](http://peewee.readthedocs.org/en/latest/peewee/playhouse.html#test_database)\n", "You can also create and drop tables.\n\n``` python\nfrom peewee import create_model_tables\nfrom peewee import drop_model_tables\n\nMODELS = [ModelA, ModelB, ...]\n\n...\ndef setUp(self):\n create_model_tables(MODELS)\n\ndef tearDown(self):\n drop_model_tables(MODELS)\n```\n", "Thanks a lot! I'm still learning obviously. :)\n", "> When you create a model, the database is tightly coupled with the model itself.\n\nI understand, you just sounded like you were speaking from a point of authority.\n" ]

"2014-05-16T20:41:17"

"2014-05-16T21:49:49"

"2014-05-16T21:43:03"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/358/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "devsli", "id": 3928644, "node_id": "MDQ6VXNlcjM5Mjg2NDQ=", "avatar_url": "https://avatars.githubusercontent.com/u/3928644?v=4", "gravatar_id": "", "url": "https://api.github.com/users/devsli", "html_url": "https://github.com/devsli", "followers_url": "https://api.github.com/users/devsli/followers", "following_url": "https://api.github.com/users/devsli/following{/other_user}", "gists_url": "https://api.github.com/users/devsli/gists{/gist_id}", "starred_url": "https://api.github.com/users/devsli/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/devsli/subscriptions", "organizations_url": "https://api.github.com/users/devsli/orgs", "repos_url": "https://api.github.com/users/devsli/repos", "events_url": "https://api.github.com/users/devsli/events{/privacy}", "received_events_url": "https://api.github.com/users/devsli/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Interesting, I think this should be fixable but will require a quick code change.\n\n``` python\n def parse_node(self, node, alias_map=None, conv=None):\n sql, params, unknown = self._parse(node, alias_map, conv)\n if unknown and conv and params:\n params = [conv.db_value(i) for i in params]\n\n if isinstance(node, Node):\n if node._negated:\n sql = 'NOT %s' % sql\n if node._alias:\n sql = ' '.join((sql, 'AS', node._alias))\n if node._ordering:\n sql = ' '.join((sql, node._ordering))\n return sql, params\n```\n\nAlternatively, you could subclass `QueryCompiler` and specify it in your subclass of `Database` that uses firebird's driver. Can you share your firebird db class, btw? I'd be interested in integrating it into the `playhouse` module.\n", "Thank you for response! By the way, [my class](https://github.com/devsli/peewee-fdb/blob/master/peewee_fdb.py) is untidy now (I'm just learning Python). If you are interested, I'll let you know when it will become better.\n" ]

"2014-05-16T14:13:45"

"2014-05-17T18:33:25"

"2014-05-17T18:30:02"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/357/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "gmcnutt", "id": 1097321, "node_id": "MDQ6VXNlcjEwOTczMjE=", "avatar_url": "https://avatars.githubusercontent.com/u/1097321?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gmcnutt", "html_url": "https://github.com/gmcnutt", "followers_url": "https://api.github.com/users/gmcnutt/followers", "following_url": "https://api.github.com/users/gmcnutt/following{/other_user}", "gists_url": "https://api.github.com/users/gmcnutt/gists{/gist_id}", "starred_url": "https://api.github.com/users/gmcnutt/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gmcnutt/subscriptions", "organizations_url": "https://api.github.com/users/gmcnutt/orgs", "repos_url": "https://api.github.com/users/gmcnutt/repos", "events_url": "https://api.github.com/users/gmcnutt/events{/privacy}", "received_events_url": "https://api.github.com/users/gmcnutt/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Duplicate of #353. The latest pypi release (2.2.4) has the fix.\n", "Confirmed, thanks.\n" ]

"2014-05-15T15:23:47"

"2014-05-15T16:25:09"

"2014-05-15T15:27:28"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/356/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "tfeldmann", "id": 385566, "node_id": "MDQ6VXNlcjM4NTU2Ng==", "avatar_url": "https://avatars.githubusercontent.com/u/385566?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tfeldmann", "html_url": "https://github.com/tfeldmann", "followers_url": "https://api.github.com/users/tfeldmann/followers", "following_url": "https://api.github.com/users/tfeldmann/following{/other_user}", "gists_url": "https://api.github.com/users/tfeldmann/gists{/gist_id}", "starred_url": "https://api.github.com/users/tfeldmann/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tfeldmann/subscriptions", "organizations_url": "https://api.github.com/users/tfeldmann/orgs", "repos_url": "https://api.github.com/users/tfeldmann/repos", "events_url": "https://api.github.com/users/tfeldmann/events{/privacy}", "received_events_url": "https://api.github.com/users/tfeldmann/received_events", "type": "User", "site_admin": false }

[]

[]

[ "The issue is that the samples are instantiated before the `Group` has an ID. Peewee looks at the group passed in (`group=self`) and attempts to read an ID off it. Since it has no ID at the time of assignment, you get the error you're seeing. Put the call to `g.save()` before `g.samples()[0].name` and you'll be set.\n", "Thank you for your answer.\nIs it possible to make the samples reread the group id?\nI want to assign properties to the samples before saving the group itself.\n(I think I could work around that by using a transaction, but unfortunately the corresponding code is quite distributed.)\n", "It's just python so you can do whatever you want!\n\n``` python\n def samples(self):\n \"\"\"Samples are generated the first time they are requested\"\"\"\n if self._samples is None:\n self._samples = [Sample() for _ in range(10)]\n for sample in self._samples:\n sample.group = self\n return self._samples\n```\n", " Thanks! :+1:\nDidn't think of that.\n" ]

"2014-05-15T11:54:47"

"2014-05-15T14:00:28"

"2014-05-15T13:44:59"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/355/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "kmarekspartz", "id": 969868, "node_id": "MDQ6VXNlcjk2OTg2OA==", "avatar_url": "https://avatars.githubusercontent.com/u/969868?v=4", "gravatar_id": "", "url": "https://api.github.com/users/kmarekspartz", "html_url": "https://github.com/kmarekspartz", "followers_url": "https://api.github.com/users/kmarekspartz/followers", "following_url": "https://api.github.com/users/kmarekspartz/following{/other_user}", "gists_url": "https://api.github.com/users/kmarekspartz/gists{/gist_id}", "starred_url": "https://api.github.com/users/kmarekspartz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kmarekspartz/subscriptions", "organizations_url": "https://api.github.com/users/kmarekspartz/orgs", "repos_url": "https://api.github.com/users/kmarekspartz/repos", "events_url": "https://api.github.com/users/kmarekspartz/events{/privacy}", "received_events_url": "https://api.github.com/users/kmarekspartz/received_events", "type": "User", "site_admin": false }

[]

[]

[ "That's too bad you found a \"code smell\".\n\nThe example app is meant to be very simple and approachable, especially for someone new to peewee. The fact that it doesn't handle concurrent requests to create a new account was acceptable to me when I wrote it, but I guess that is a code smell.\n\nSince you point it out, I have changed the code smell and also updated due to some changes in flask's session serialization: 5fa6d43f0a806f6b965f8ae3bacaf3e42b2335de .\n", "Thanks! I've been bitten in the past by this exact bug with other libraries because I hadn't seen examples done \"correctly\". Now I know how to account for this.\n" ]

"2014-05-14T20:57:41"

"2014-05-14T23:03:50"

"2014-05-14T22:42:31"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/354/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "justinrosenthal", "id": 804338, "node_id": "MDQ6VXNlcjgwNDMzOA==", "avatar_url": "https://avatars.githubusercontent.com/u/804338?v=4", "gravatar_id": "", "url": "https://api.github.com/users/justinrosenthal", "html_url": "https://github.com/justinrosenthal", "followers_url": "https://api.github.com/users/justinrosenthal/followers", "following_url": "https://api.github.com/users/justinrosenthal/following{/other_user}", "gists_url": "https://api.github.com/users/justinrosenthal/gists{/gist_id}", "starred_url": "https://api.github.com/users/justinrosenthal/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/justinrosenthal/subscriptions", "organizations_url": "https://api.github.com/users/justinrosenthal/orgs", "repos_url": "https://api.github.com/users/justinrosenthal/repos", "events_url": "https://api.github.com/users/justinrosenthal/events{/privacy}", "received_events_url": "https://api.github.com/users/justinrosenthal/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Are you sure about this? Any way you can demonstrate this behavior?\nOn May 13, 2014 6:58 PM, \"Justin Rosenthal\" notifications@github.com\nwrote:\n\n> If you do a Model.create with a PostgresqlDatabase that has autocommit\n> enabled, you'll be left with an unclosed transaction. Since it's in\n> autocommit mode, it's most likely the case that you won't close it yourself.\n> \n> InsertQuery.execute returns self.database.last_insert_id(self._execute(),\n> self.model_class). The last_insert_id method does a cursor.execute('SELECT\n> ...') and then returns the result. The execute() will have implicitly\n> started a new transaction that doesn't get closed. I think the solution\n> might be as simple as adding a couple self.commit() calls, as shown\n> below, but I don't know the codebase well enough to know if that's the\n> right thing to do or not.\n> \n> ```\n> def last_insert_id(self, cursor, model):\n> meta = model._meta\n> seq = meta.primary_key.sequence\n> schema = ''\n> if meta.schema:\n> schema = '%s.' % meta.schema\n> if seq:\n> cursor.execute(\"SELECT CURRVAL('%s\\\"%s\\\"')\" % (schema, seq))\n> self.commit() # <----------- HERE\n> return cursor.fetchone()[0]\n> elif meta.auto_increment:\n> cursor.execute(\"SELECT CURRVAL('%s\\\"%s_%s_seq\\\"')\" % (\n> schema, meta.db_table, meta.primary_key.db_column))\n> self.commit() # <----------- AND HERE\n> return cursor.fetchone()[0]\n> ```\n> \n> —\n> Reply to this email directly or view it on GitHubhttps://github.com/coleifer/peewee/issues/353\n> .\n", "This is the best way I could think to prove the point:\nhttps://gist.github.com/justinrosenthal/873ca0bfbf938ccf5689\n\nYou'll want to run that against a quiet database (optimally no other connections, so the SELECT only returns you a single row).\n\nNote that the Event table does not have a primary key defined, which causes Postgres to assign one via a sequence. If you specify your own primary key, `last_insert_id` doesn't run a SELECT, so you won't see the issue.\n", "Yipes you're totally right.\n" ]

"2014-05-13T23:58:14"

"2014-05-15T15:27:28"

"2014-05-14T02:22:35"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/353/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "andmart", "id": 303252, "node_id": "MDQ6VXNlcjMwMzI1Mg==", "avatar_url": "https://avatars.githubusercontent.com/u/303252?v=4", "gravatar_id": "", "url": "https://api.github.com/users/andmart", "html_url": "https://github.com/andmart", "followers_url": "https://api.github.com/users/andmart/followers", "following_url": "https://api.github.com/users/andmart/following{/other_user}", "gists_url": "https://api.github.com/users/andmart/gists{/gist_id}", "starred_url": "https://api.github.com/users/andmart/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/andmart/subscriptions", "organizations_url": "https://api.github.com/users/andmart/orgs", "repos_url": "https://api.github.com/users/andmart/repos", "events_url": "https://api.github.com/users/andmart/events{/privacy}", "received_events_url": "https://api.github.com/users/andmart/received_events", "type": "User", "site_admin": false }

[]

[]

[]

"2014-05-12T15:44:58"

"2014-05-12T16:14:22"

"2014-05-12T16:14:22"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/352/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "FashtimeDotCom", "id": 3240392, "node_id": "MDQ6VXNlcjMyNDAzOTI=", "avatar_url": "https://avatars.githubusercontent.com/u/3240392?v=4", "gravatar_id": "", "url": "https://api.github.com/users/FashtimeDotCom", "html_url": "https://github.com/FashtimeDotCom", "followers_url": "https://api.github.com/users/FashtimeDotCom/followers", "following_url": "https://api.github.com/users/FashtimeDotCom/following{/other_user}", "gists_url": "https://api.github.com/users/FashtimeDotCom/gists{/gist_id}", "starred_url": "https://api.github.com/users/FashtimeDotCom/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/FashtimeDotCom/subscriptions", "organizations_url": "https://api.github.com/users/FashtimeDotCom/orgs", "repos_url": "https://api.github.com/users/FashtimeDotCom/repos", "events_url": "https://api.github.com/users/FashtimeDotCom/events{/privacy}", "received_events_url": "https://api.github.com/users/FashtimeDotCom/received_events", "type": "User", "site_admin": false }

[]

[]

[ "This is not a bug with peewee per-se. This has been brought up a few times.\n- #225\n- #239 \n- #67 \n\nPlease search before creating new issues in the future!\n", "## http://docs.peewee-orm.com/en/latest/peewee/database.html#error-2006-mysql-server-has-gone-away\n", "An alternate fix is implemented in 017e4e4952f0b429dd21f0e90465a0f644cf6015\n", "Hi @coleifer: Apologies for re-addressing this closed issue, which I see you have addressed in numerous places. I have reviewed the issues and StackOverflow, and the error persists for me.\r\n\r\nI am using a single connection (not a pool), and using the connection context manager, as described in the PeeWee documentation. The data volume is small (~100KB per row), and the problem only arises with using `self.model.insert_many(rows).execute()`. Writing a small number of rows at one time works (~1-30 rows), and debugging shows that the connection object displaying the expected behavior: the connection is closed prior to entering the context manager, open during the context manager, and closes thereafter. Writing 30+ rows fails with the 2006 error. \r\n\r\n```\r\n batch_size = 100\r\n logger.info(db_to_use.is_closed())\r\n with db_to_use.connection_context():\r\n logger.info(db_to_use.is_closed())\r\n with db_to_use.atomic():\r\n logger.info(db_to_use.is_closed())\r\n for idx in range(0, len(row_data), batch_size):\r\n logger.info(db_to_use.is_closed())\r\n rows = row_data[idx:idx + batch_size]\r\n self.model.insert_many(rows).execute()\r\n logger.info(db_to_use.is_closed())\r\n```\r\n\r\nAlternatively, using `batch_commit` does not create a 2006 error, regardless of batch size.\r\n```\r\nbatch_size = 100\r\nlogger.info(db_to_use.is_closed())\r\nwith db_to_use.connection_context():\r\n logger.info(db_to_use.is_closed())\r\n with db_to_use.atomic():\r\n logger.info(db_to_use.is_closed())\r\n for row in db_to_use.batch_commit(row_data, batch_size):\r\n logger.info(db_to_use.is_closed())\r\n self.model.create(**row)\r\nlogger.info(db_to_use.is_closed())\r\n```\r\n\r\nAnd, committing without batches also works:\r\n```\r\nlogger.info(db_to_use.is_closed())\r\nwith db_to_use.connection_context():\r\n logger.info(db_to_use.is_closed())\r\n with db_to_use.atomic():\r\n logger.info(db_to_use.is_closed())\r\n for row in row_data:\r\n logger.info(db_to_use.is_closed())\r\n self.model.create(**row)\r\nlogger.info(db_to_use.is_closed())\r\n```\r\n\r\nFor now, I can workaround this issue by using `batch_commit`. It would be helpful to understand why `insert_many` has this behavior. Thanks.", "I can't explain it, no idea. All this stuff is unit-tested across python versions and supported databases (sqlite/mysql/python), so I'm confident there's nothing fundamentally broken in the implementations. Did you try committing after each round of `insert_many` with success? Are you running out of memory because of a large transaction and mysql is closing the connection? You might check your server logs to see why mysql is dropping you." ]

"2014-05-09T01:09:13"

"2019-09-13T16:26:05"

"2014-05-09T13:21:26"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/351/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "PatSmuk", "id": 75297, "node_id": "MDQ6VXNlcjc1Mjk3", "avatar_url": "https://avatars.githubusercontent.com/u/75297?v=4", "gravatar_id": "", "url": "https://api.github.com/users/PatSmuk", "html_url": "https://github.com/PatSmuk", "followers_url": "https://api.github.com/users/PatSmuk/followers", "following_url": "https://api.github.com/users/PatSmuk/following{/other_user}", "gists_url": "https://api.github.com/users/PatSmuk/gists{/gist_id}", "starred_url": "https://api.github.com/users/PatSmuk/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/PatSmuk/subscriptions", "organizations_url": "https://api.github.com/users/PatSmuk/orgs", "repos_url": "https://api.github.com/users/PatSmuk/repos", "events_url": "https://api.github.com/users/PatSmuk/events{/privacy}", "received_events_url": "https://api.github.com/users/PatSmuk/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Is this example code related to bitcoin in some way?\n", "It is. We're using peewee to power [our website](http://blackcoinpool.com/). If you drop a wallet address I'd be happy to send some Bitcoin or Blackcoin your way. :smiley: \n", "> It is. We're using peewee to power our website. If you drop a wallet address I'd be happy to send some Bitcoin or Blackcoin your way. \n\nHaha awesome, I appreciate that. I don't have a wallet but thank you.\n", "Just thought I'd re-open the issue because I just encountered the same problem with count() and flask-peewee's admin system.\n", "I have the same erron in count().\n", "Currently count is implemented as the [following](https://github.com/coleifer/peewee/blob/master/peewee.py#L2068-2073): \n\n```\ndef count(self):\n if self._distinct or self._group_by:\n return self.wrapped_count()\n\n # defaults to a count() of the primary key\n return self.aggregate(convert=False) or 0\n```\n\nWhat is the purpose that it \"defaults to a count() of the primary key\" rather than `COUNT(*)`?\n", "Thanks @coleifer !\n" ]

"2014-05-08T21:57:47"

"2014-06-18T21:19:07"

"2014-06-18T14:47:09"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/350/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "nullism", "id": 730290, "node_id": "MDQ6VXNlcjczMDI5MA==", "avatar_url": "https://avatars.githubusercontent.com/u/730290?v=4", "gravatar_id": "", "url": "https://api.github.com/users/nullism", "html_url": "https://github.com/nullism", "followers_url": "https://api.github.com/users/nullism/followers", "following_url": "https://api.github.com/users/nullism/following{/other_user}", "gists_url": "https://api.github.com/users/nullism/gists{/gist_id}", "starred_url": "https://api.github.com/users/nullism/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/nullism/subscriptions", "organizations_url": "https://api.github.com/users/nullism/orgs", "repos_url": "https://api.github.com/users/nullism/repos", "events_url": "https://api.github.com/users/nullism/events{/privacy}", "received_events_url": "https://api.github.com/users/nullism/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I added a testcase in deef4531b9fc0c87cbecdec8d059650d6e83936c and it is passing. You may need to upgrade your peewee version. What version are you using currently?\n", "I'm currently on 2.2.2. I'll test with the upgrade ASAP. Thanks for the assistance ;)\n\n```\n>>> import peewee\n>>> peewee.__version__\n'2.2.2'\n```\n", "Yup! That totally fixed it. Thanks again!\n\n```\nCurrent branches: \n----------------------------------------\nmaster 1\nfoo 1\ntest-branch 1\nCurrent branch count: 3\nDeleting 1 branch: foo\nactual delete count: 1\nRemaining branches: \n----------------------------------------\nmaster 1\ntest-branch 1\nRemaining branch count: 2\n```\n" ]

"2014-04-29T17:05:19"

"2014-04-29T20:22:55"

"2014-04-29T20:22:55"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/349/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "ticapix", "id": 3089662, "node_id": "MDQ6VXNlcjMwODk2NjI=", "avatar_url": "https://avatars.githubusercontent.com/u/3089662?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ticapix", "html_url": "https://github.com/ticapix", "followers_url": "https://api.github.com/users/ticapix/followers", "following_url": "https://api.github.com/users/ticapix/following{/other_user}", "gists_url": "https://api.github.com/users/ticapix/gists{/gist_id}", "starred_url": "https://api.github.com/users/ticapix/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ticapix/subscriptions", "organizations_url": "https://api.github.com/users/ticapix/orgs", "repos_url": "https://api.github.com/users/ticapix/repos", "events_url": "https://api.github.com/users/ticapix/events{/privacy}", "received_events_url": "https://api.github.com/users/ticapix/received_events", "type": "User", "site_admin": false }

[]

[]

[ "You can put together a clause:\n\n``` python\n>>> query = User.select().where(User.username ** Clause('t\\_t', SQL(\"ESCAPE '\\\\'\")))\n>>> print query.sql()\n('SELECT t1.\"id\", t1.\"username\" FROM \"user\" AS t1 WHERE (t1.\"username\" LIKE ? ESCAPE \\'\\\\\\')', [u't\\\\_t'])\n\n```\n" ]

"2014-04-28T11:18:20"

"2014-04-28T16:34:41"

"2014-04-28T16:34:41"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/348/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "caelx", "id": 1686351, "node_id": "MDQ6VXNlcjE2ODYzNTE=", "avatar_url": "https://avatars.githubusercontent.com/u/1686351?v=4", "gravatar_id": "", "url": "https://api.github.com/users/caelx", "html_url": "https://github.com/caelx", "followers_url": "https://api.github.com/users/caelx/followers", "following_url": "https://api.github.com/users/caelx/following{/other_user}", "gists_url": "https://api.github.com/users/caelx/gists{/gist_id}", "starred_url": "https://api.github.com/users/caelx/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/caelx/subscriptions", "organizations_url": "https://api.github.com/users/caelx/orgs", "repos_url": "https://api.github.com/users/caelx/repos", "events_url": "https://api.github.com/users/caelx/events{/privacy}", "received_events_url": "https://api.github.com/users/caelx/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I'm not very familiar with MySQL's handling of `table_schema`. What is the effect of saying `table_schema = DATABASE()`?\n", "Also, fwiw, I just pushed a rewrite of pwiz (183cf77cb9446d428f12612c8a0e47a5279a0fcc), so any changes will be against that code.\n", "the table_schema is the database that the table comes from. I'm not sure with how postgres handles the connection, but when you query information schema it's not restricted to the database that you are currently using, which is why there is a need to add table_schema to the where clause.\n\nHere's an example:\n\n```\nmysql> show databases;\n+--------------------+\n| Database |\n+--------------------+\n| information_schema |\n| mysql |\n| performance_schema |\n| phpmyadmin |\n| test1 |\n| test2 |\n+--------------------+\n6 rows in set (0.00 sec)\n\nmysql> describe test1.test_table;\n+-------+---------+------+-----+---------+-------+\n| Field | Type | Null | Key | Default | Extra |\n+-------+---------+------+-----+---------+-------+\n| id1 | int(11) | NO | | NULL | |\n+-------+---------+------+-----+---------+-------+\n1 row in set (0.00 sec)\n\nmysql> describe test2.test_table;\n+-------+---------+------+-----+---------+-------+\n| Field | Type | Null | Key | Default | Extra |\n+-------+---------+------+-----+---------+-------+\n| id2 | int(11) | NO | | NULL | |\n+-------+---------+------+-----+---------+-------+\n1 row in set (0.00 sec)\n\nmysql> SELECT column_name, is_nullable, data_type, character_maximum_length\n -> FROM information_schema.columns\n -> WHERE table_name='test_table';\n+-------------+-------------+-----------+--------------------------+\n| column_name | is_nullable | data_type | character_maximum_length |\n+-------------+-------------+-----------+--------------------------+\n| id1 | NO | int | NULL |\n| id2 | NO | int | NULL |\n+-------------+-------------+-----------+--------------------------+\n2 rows in set (0.00 sec)\n\nmysql> use test1\nReading table information for completion of table and column names\nYou can turn off this feature to get a quicker startup with -A\n\nDatabase changed\nmysql> SELECT column_name, is_nullable, data_type, character_maximum_length\n -> FROM information_schema.columns\n -> WHERE table_name='test_table';\n+-------------+-------------+-----------+--------------------------+\n| column_name | is_nullable | data_type | character_maximum_length |\n+-------------+-------------+-----------+--------------------------+\n| id1 | NO | int | NULL |\n| id2 | NO | int | NULL |\n+-------------+-------------+-----------+--------------------------+\n2 rows in set (0.00 sec)\n\nmysql> SELECT column_name, is_nullable, data_type, character_maximum_length\n -> FROM information_schema.columns\n -> WHERE table_name='test_table'\n -> AND table_schema=DATABASE();\n+-------------+-------------+-----------+--------------------------+\n| column_name | is_nullable | data_type | character_maximum_length |\n+-------------+-------------+-----------+--------------------------+\n| id1 | NO | int | NULL |\n+-------------+-------------+-----------+--------------------------+\n1 row in set (0.00 sec)\n\nmysql>\n```\n" ]

"2014-04-25T01:48:16"

"2014-05-03T14:54:05"

"2014-05-03T14:54:05"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/347/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "nullism", "id": 730290, "node_id": "MDQ6VXNlcjczMDI5MA==", "avatar_url": "https://avatars.githubusercontent.com/u/730290?v=4", "gravatar_id": "", "url": "https://api.github.com/users/nullism", "html_url": "https://github.com/nullism", "followers_url": "https://api.github.com/users/nullism/followers", "following_url": "https://api.github.com/users/nullism/following{/other_user}", "gists_url": "https://api.github.com/users/nullism/gists{/gist_id}", "starred_url": "https://api.github.com/users/nullism/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/nullism/subscriptions", "organizations_url": "https://api.github.com/users/nullism/orgs", "repos_url": "https://api.github.com/users/nullism/repos", "events_url": "https://api.github.com/users/nullism/events{/privacy}", "received_events_url": "https://api.github.com/users/nullism/received_events", "type": "User", "site_admin": false }

[]

[]

[ "When performing a LIMIT or OFFSET you need to wrap the call to count:\n\n``` python\nCommit.select().paginate(1, 5).count() # 8\nCommit.select().paginate(1, 5).wrapped_count(False) # 5\n```\n", "Ah understood. I apologize for submitting this. Apparently I assume too much ;)\n" ]

"2014-04-23T22:05:33"

"2014-04-24T01:17:43"

"2014-04-23T22:14:33"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/346/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "thedod", "id": 225574, "node_id": "MDQ6VXNlcjIyNTU3NA==", "avatar_url": "https://avatars.githubusercontent.com/u/225574?v=4", "gravatar_id": "", "url": "https://api.github.com/users/thedod", "html_url": "https://github.com/thedod", "followers_url": "https://api.github.com/users/thedod/followers", "following_url": "https://api.github.com/users/thedod/following{/other_user}", "gists_url": "https://api.github.com/users/thedod/gists{/gist_id}", "starred_url": "https://api.github.com/users/thedod/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/thedod/subscriptions", "organizations_url": "https://api.github.com/users/thedod/orgs", "repos_url": "https://api.github.com/users/thedod/repos", "events_url": "https://api.github.com/users/thedod/events{/privacy}", "received_events_url": "https://api.github.com/users/thedod/received_events", "type": "User", "site_admin": false }

[]

[]

[]

"2014-04-21T08:41:29"

"2014-07-06T01:49:58"

"2014-04-21T14:04:17"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/345/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/345", "html_url": "https://github.com/coleifer/peewee/pull/345", "diff_url": "https://github.com/coleifer/peewee/pull/345.diff", "patch_url": "https://github.com/coleifer/peewee/pull/345.patch", "merged_at": "2014-04-21T14:04:17" }

{ "login": "CodeZombieCH", "id": 729017, "node_id": "MDQ6VXNlcjcyOTAxNw==", "avatar_url": "https://avatars.githubusercontent.com/u/729017?v=4", "gravatar_id": "", "url": "https://api.github.com/users/CodeZombieCH", "html_url": "https://github.com/CodeZombieCH", "followers_url": "https://api.github.com/users/CodeZombieCH/followers", "following_url": "https://api.github.com/users/CodeZombieCH/following{/other_user}", "gists_url": "https://api.github.com/users/CodeZombieCH/gists{/gist_id}", "starred_url": "https://api.github.com/users/CodeZombieCH/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/CodeZombieCH/subscriptions", "organizations_url": "https://api.github.com/users/CodeZombieCH/orgs", "repos_url": "https://api.github.com/users/CodeZombieCH/repos", "events_url": "https://api.github.com/users/CodeZombieCH/events{/privacy}", "received_events_url": "https://api.github.com/users/CodeZombieCH/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Peewee doesn't try to be too clever here, but you're right, the update statement will fail silently, which I agree is bad.\n", "Fixed in e73d3db12fb370c48cca8f45514a7fed9637949c -- returns number of rows affected (1 always in case of inserts, but could be 0/1 for updates).\n", "Cool, thanks a lot.\n" ]

"2014-04-19T02:18:21"

"2014-04-22T12:50:11"

"2014-04-20T12:14:57"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/344/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "thedod", "id": 225574, "node_id": "MDQ6VXNlcjIyNTU3NA==", "avatar_url": "https://avatars.githubusercontent.com/u/225574?v=4", "gravatar_id": "", "url": "https://api.github.com/users/thedod", "html_url": "https://github.com/thedod", "followers_url": "https://api.github.com/users/thedod/followers", "following_url": "https://api.github.com/users/thedod/following{/other_user}", "gists_url": "https://api.github.com/users/thedod/gists{/gist_id}", "starred_url": "https://api.github.com/users/thedod/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/thedod/subscriptions", "organizations_url": "https://api.github.com/users/thedod/orgs", "repos_url": "https://api.github.com/users/thedod/repos", "events_url": "https://api.github.com/users/thedod/events{/privacy}", "received_events_url": "https://api.github.com/users/thedod/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Ouch :cold_sweat: forgot to test _without_ `-e pysqlcipher`. Sorting it out now...\n", "If you take a look at peewee's source code you will see that I have tried to stick to pep8 in most places. I've also tried to have uniform formatting of comments.\n", "I believe your tests are failing because you have not registered some default type converters. Take a look at the top of the peewee module and you'll see what I'm referring to (line ~130, `sqlite3.register_adapter()`).\n\nAlso there should be some basic unit tests for this module. You can see the other modules in the `playhouse` have some unit tests.\n", "> I believe your tests are failing because you have not registered some default type converters. Take a look at the top of the peewee module and you'll see what I'm referring to (line ~130, sqlite3.register_adapter()).\n\nThanks. I'll look into this.\n\n> Also there should be some basic unit tests for this module. You can see the other modules in the playhouse have some unit tests.\n\nThe only `--pyciphersql` test I can think of (that is not covered by running the regular tests with `-e pysqlcipher`) is: Create a db, store something, try to open it with wrong passphrase and fail, try with the right one and succeed. Would that do?\n", "This is close but not quite ready. I don't know how many times I need to mention this but pay attention to spacing in your operations. Read pep8.\n", "Lookin good mane. Last thing (I promise) is some docs in the `playhouse` documentation file.\n", "This is now merged, thanks for the contribution!\n" ]

"2014-04-18T23:06:38"

"2014-06-19T08:10:04"

"2014-05-03T15:37:22"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/343/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/343", "html_url": "https://github.com/coleifer/peewee/pull/343", "diff_url": "https://github.com/coleifer/peewee/pull/343.diff", "patch_url": "https://github.com/coleifer/peewee/pull/343.patch", "merged_at": null }

{ "login": "caelx", "id": 1686351, "node_id": "MDQ6VXNlcjE2ODYzNTE=", "avatar_url": "https://avatars.githubusercontent.com/u/1686351?v=4", "gravatar_id": "", "url": "https://api.github.com/users/caelx", "html_url": "https://github.com/caelx", "followers_url": "https://api.github.com/users/caelx/followers", "following_url": "https://api.github.com/users/caelx/following{/other_user}", "gists_url": "https://api.github.com/users/caelx/gists{/gist_id}", "starred_url": "https://api.github.com/users/caelx/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/caelx/subscriptions", "organizations_url": "https://api.github.com/users/caelx/orgs", "repos_url": "https://api.github.com/users/caelx/repos", "events_url": "https://api.github.com/users/caelx/events{/privacy}", "received_events_url": "https://api.github.com/users/caelx/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Unfortunately that code is there for a reason. Consider a field like this:\n\n``` python\nclass CSVField(CharField):\n def db_value(self, value):\n return ','.join(value)\n\n def python_value(self, value):\n return value.split(',')\n```\n\nThis field would be used to store or retrieve lists of data encoded in CSV.\n\nWhat if you wanted to do a case insensitive search for some particular items? Then we'd want to pass the value to the field's conversion function:\n\n``` python\nMyModel.select().where(MyModel.csv_data == fn.LOWER(Param(['item1', 'item2'])))\n```\n\nI admit it's a bit of a contrived example, but that was the reasoning behind the conversion.\n", "This is now fixed. In order to avoid coercing the values you would write:\n\n``` python\nIP.select().where(IP.ip == fn.INET_ATON('8.8.8.8').coerce(False)).execute()\n```\n", "Awesome as usual, thanks!\n\nI understand why you need to do the coercion, I was just looking for an expressive interface for manually disabling it which you have provided perfectly.\n\nI actually tried calling the coerce method with false myself but it didn't do what I hoped it did at that time.\n" ]

"2014-04-17T01:25:53"

"2014-04-17T22:06:53"

"2014-04-17T12:45:49"

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/342/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }