DataParallel imbalanced memory usage

JuanFMontesinos: <p>Hi there,<br>
I’m going to re-edit the whole thread to introduce a unlikely behavior with <code>DataParallel</code><br>
Right now there are several recent posts about this topic and I would like to summarize the problem.</p>
<aside class="quote quote-modified" data-post="1" data-topic="22556">
  <div class="title">
    <div class="quote-controls"></div>
    <img loading="lazy" alt="" width="24" height="24" src="https://discuss.pytorch.org/user_avatar/discuss.pytorch.org/soulless/48/40008_2.png" class="avatar">
    <a href="https://discuss.pytorch.org/t/cuda-error-out-of-memory-huge-embedding-layer/22556">CUDA error: out of memory - huge embedding layer</a> <a class="badge-category__wrapper " href="/c/nlp/8"><span data-category-id="8" style="--category-badge-color: #AB9364; --category-badge-text-color: #FFFFFF;" data-drop-close="true" class="badge-category " title="Topics related to Natural Language Processing"><span class="badge-category__name">nlp</span></span></a>
  </div>
  <blockquote>
    I am working on a CNN autoencoder for text with an architecture and loss function like this: 
[screen shot 2018-08-06 at 4 32 25 pm] 
def computeCrossEntropy(log_prob, target):
    loss = [F.nll_loss(sentence_emb_matrix, word_ids, size_average=False) for sentence_emb_matrix, word_ids in zip(log_prob, target)]
    average_loss = sum([torch.sum(l) for l in loss]) / log_prob.size()[0]
    return average_loss

I understand the embedding is huge and I can only have a batch size of 8. Otherwise, I wou…
  </blockquote>
</aside>
<aside class="quote quote-modified" data-post="1" data-topic="18221">
  <div class="title">
    <div class="quote-controls"></div>
    <img loading="lazy" alt="" width="24" height="24" src="https://discuss.pytorch.org/letter_avatar_proxy/v4/letter/a/e274bd/48.png" class="avatar">
    <a href="https://discuss.pytorch.org/t/dataparallel-not-effective/18221">DataParallel not effective</a> 
  </div>
  <blockquote>
    Hi all, 
I have a quite large model and need to do data parallel among multiple GPUs. 
I used: 
model = nn.DataParallel(model)

And there are three visible GPUs. The GPU usage is: 
+-----------------------------------------------------------------------------+
| Processes:                                                       GPU Memory |
|  GPU       PID   Type   Process name                             Usage      |
|=============================================================================|…
  </blockquote>
</aside>
<aside class="quote quote-modified" data-post="1" data-topic="15049">
  <div class="title">
    <div class="quote-controls"></div>
    <img loading="lazy" alt="" width="24" height="24" src="https://discuss.pytorch.org/user_avatar/discuss.pytorch.org/yuzhou_song/48/3937_2.png" class="avatar">
    <a href="https://discuss.pytorch.org/t/imbalanced-gpu-memory-usage-training-lstm/15049">Imbalanced GPU memory usage training LSTM</a> <a class="badge-category__wrapper " href="/c/nlp/8"><span data-category-id="8" style="--category-badge-color: #AB9364; --category-badge-text-color: #FFFFFF;" data-drop-close="true" class="badge-category " title="Topics related to Natural Language Processing"><span class="badge-category__name">nlp</span></span></a>
  </div>
  <blockquote>
    I’m training a language model using the code here: <a href="https://github.com/pytorch/examples/blob/master/word_language_model/main.py" rel="noopener nofollow ugc">https://github.com/pytorch/examples/blob/master/word_language_model/main.py</a> 
I have made some slight changes so that the model can be trained across multiple GPUs. However, the GPU memory usage is extremely imbalanced. 
 <a class="lightbox" href="https://discuss.pytorch.org/uploads/default/original/2X/5/5aba409800ca4813fc11eead25b891e4befe3dd8.png" data-download-href="https://discuss.pytorch.org/uploads/default/5aba409800ca4813fc11eead25b891e4befe3dd8" title="WX20180316-152226.png">[WX20180316-152226]</a> 
I can understand that one GPU is set to gather and store all outputs. I wonder if there is any way I can balance the memory usage? Or can I set one GPU for gathering outputs and the rest for training on batc…
  </blockquote>
</aside>

<p>Right now it seems there is an imbalaced usage of GPUs when calling DataParallel.<br>
          <a href="https://discuss.pytorch.org/uploads/default/optimized/2X/5/5aba409800ca4813fc11eead25b891e4befe3dd8_1_690x119.png" target="_blank" rel="noopener" class="onebox">
            <span class="broken-image" title="This image is broken"><svg class="fa d-icon d-icon-unlink svg-icon" aria-hidden="true"><use href="#unlink"></use></svg></span>
          </a>
</p>
<p>From my experience and other users’ explanations I will explain why this happens:<br>
Using DataParallel there are 4 types of data to consider:</p>
<ol>
<li>Input</li>
<li>Output</li>
<li>Ground-truth</li>
<li>Optimizer Parameters</li>
</ol>
<p>DataParallel has a main GPU, which is the GPU where the model is stored.<br>
As <a class="mention" href="/u/yuzhou_song">@Yuzhou_Song</a> indicates in another post, DataParallel splits the batch in as many GPUs as choosen, copy the model in each of them, compute the forward pass independently and then <strong>collect back to one GPU the outputs of each GPU to calculate the loss instead of computing loss independently in each GPU</strong>. This is the main cause of imbalance memory usage. Consider that ground-truth and output (target of loss) must be in the same GPU</p>
<p>I discovered by my self that some optimizers requires lot of memory to save their parameters. However all <strong>these parameters are located in the already mentioned main GPU</strong>. This makes the problem worse.</p>
<p>There is a last reason. Model inputs are usually allocated to GPU by using <code>.cuda()</code>, which usually points to the main GPU and generates more imbalance.</p>
<p>There are some ways to minimize this:<br>
DataParallel have 2 arguments, <code>device_ids</code> which allows to choose in which GPUs the model will be trained out of all available GPUs (<code>CUDA_VISIBLE_DEVICES</code>) and <code>output_device</code> which allows to choose in which GPU output will be stored.</p>
<p>Let’s imagine we have 3 devices, [0,1,2].<br>
calling<br>
<code>model = DataParallel(model).cuda()</code> would set device0 as main gpu. Then, optimizers parameters will be stored here.<br>
calling  <code>model = DataParallel(model,output_device=1).cuda()</code> and <code>grountruth.cuda(1)</code> will collect all the outputs and compute loss in cuda:1<br>
lastly, you can allocate inputs to cuda2.<br>
This way the memory usage is distributed as much as possible.</p>
<p>Is there a way of solving this problem? <a class="mention" href="/u/smth">@smth</a> <a class="mention" href="/u/ptrblck">@ptrblck</a> <a class="mention" href="/u/alband">@albanD</a>   <a class="mention" href="/u/soulless">@soulless</a><br>
I guess this behavior is very inconvenient.</p>

soulless: <p>I am having a similar issue. Could this be because the loss calculation is not done in the forward function?</p>
<aside class="quote" data-post="2" data-topic="15049">
  <div class="title">
    <div class="quote-controls"></div>
    <img loading="lazy" alt="" width="24" height="24" src="https://discuss.pytorch.org/user_avatar/discuss.pytorch.org/yuzhou_song/48/3937_2.png" class="avatar">
    <a href="https://discuss.pytorch.org/t/imbalanced-gpu-memory-usage-training-lstm/15049/2">Imbalanced GPU memory usage training LSTM</a> <a class="badge-category__wrapper " href="/c/nlp/8"><span data-category-id="8" data-drop-close="true" class="badge-category " title="Topics related to Natural Language Processing"><span class="badge-category__name">nlp</span></span></a>
  </div>
  <blockquote>
    I found the reason, it is because we collect the output back to one gpu and calculate loss there. If move loss calculation into model.forward(), the problem is resolved.
  </blockquote>
</aside>


JuanFMontesinos: <p>Well the op you cited is right, in the end pytorch collect the whole batch output in one gpu to calculate the loss. That’s what generates the imbalanced usage. At the same time optimizers’ parameters are stored in by-default gpu, what makes the problem worse. There is no apparent solution since dataparallel allows you to choose output gpu but the problem remains. There are several open threads asking about the same issue. I tried to play with dataparallel arguments: device_ids and output_device but no way.</p>

albanD: <p>If you want the loss to be splitted among gpus, just make your loss layer part of the DataParallel and add a <code>sum</code> or <code>mean</code> operation on what you get out of it. That way if you use DataParallel on 4 devices, only 4 extra numbers will be allocated on the output_device. Is that a good solution for you?</p>

JuanFMontesinos: <p>Thanks it seems a good solution.<br>
If i call loss=DataParallel(loss).cuda() I would get an array of losses?</p>
<p>Apart of that, is it possible to split optimizers among all gpus?</p>

albanD: <p>You would need to have the following:</p>
<pre><code class="lang-auto">class FullModel(nn.Module):
  def __init__(self, model, loss):
    self.model = model
    self.loss = loss

  def forward(self, inputs, targets):
    outputs = self.model(inputs)
    loss = self.loss(outputs, targets)

full_model = DataParallel(FullModel(model, loss), device_ids=[0, 1, 2], ***)
full_model.cuda()

loss = full_model(fake_input, fake_target)
print(loss.size) # returns [3] (If you loss returns a 0-dimensional tensor containing the loss value)
final_loss = loss.sum()
</code></pre>
<p>For the optimizer that would depend on the optimizer I guess.<br>
For Adam for example, it need to store one (if I remember correctly?) extra copy of all the weights. And it need this copy to update the weights. That means that if all the gradients are accumulated on a single gpu, then this state should be there as well.<br>
That being said. The size of the weights of your network should not be a very large part of the memory consumption for classic nets. Intermediary states are the most demanding. So hopefully this extra memory as big as the set of weights should not be too big a problem.</p>

Yuzhou_Song: <p>I had tried put the loss inside of forward() before. It did mitigate this imbalanced issue but not fully resolved it. BTW, I wonder if PyTorch has plans to implement the functionality to store model parameters in CPU instead of one main GPU? I’m training production scale data which is super big. If the GPU memory is used by 99% after mounting the model, there is little room for me to mount data anymore, which totally lose the scalability of multiple GPU training.</p>

albanD: <p>Well you need to store model parameters on the gpu to be able to do the forward.<br>
The backward computes gradients on the gpu so they will be there.<br>
Not sure what you mean by “store model parameters in CPU instead of one main GPU” ?</p>

Yuzhou_Song: <p>According to my understanding, one/multiple CPUs could serve as Parameter Server storing model parameters. In forward step, each GPU could mount a batch of data and part of model parameters (let’s say first 10 layers’), do the calculation. Then, abandon the first 10 layers’ and mount 11-20 layers’ and do calculation again. We repeat this until get the final output of forward(). The benefit is model size is no longer limited by GPU memory. I guess typical distributed training framework is implemented this way, right?</p>
<p>If my understanding is incorrect, what’s the best way to train a model with parameter size exceeds GPU memory?</p>

albanD: <p>Hi,</p>
<p>You could do that but transferring few GB of data many times between the cpu and gpu will be quite slow.<br>
But in practice, as I said above, what is going to take a lot of space are the intermediary results. And that is going to be even worst.</p>
<p>That being said, if your problem is that your net is too big, even for a batch size of 1, then you don’t want data parallelism but model parallelism.<br>
This can be done very easily by adding some <code>.cuda(1)</code> then <code>.cuda(2)</code>… during your forward pass, and sending part of your net to different gpus. according to this split.<br>
There is no builtin method to do this as it need to be done in your forward method directly and you need to ensure that the right part of each model is moved to the right gpu.</p>

Yuzhou_Song: <p>That makes sense to me! It could be great if you guys can make a post/blog/sample code about what we discussing here. It must be very helpful!</p>
<p>Thanks a lot,<br>
Best,<br>
Yuzhou</p>

JuanFMontesinos: <p>Hi there <a class="mention" href="/u/alband">@albanD</a>, <a class="mention" href="/u/yuzhou_song">@Yuzhou_Song</a><br>
I noticed there is an small mistake with the code you provided:<br>
It’s necessary to unsqueeze loss inside forward pass to DataParallel were able to build loss back. Loss provided by PyTorch loss functions seems not to have dimensions, and DataParallel mount batch back in dim 0 by default. It also requires to class super class not to raise up with an error. Anyway thank you very much. Awesome help.</p>
<pre><code class="lang-auto">class FullModel(nn.Module):
  def __init__(self, model, loss):
    super(FullModel, self).__init__()
    self.model = model
    self.loss = loss

  def forward(self, targets, *inputs):
    outputs = self.model(*inputs)
    loss = self.loss(outputs, targets)
    return torch.unsqueeze(loss,0),outputs
    

def DataParallel_withLoss(model,loss,**kwargs):
    model=FullModel(model, loss)
    if 'device_ids' in kwargs.keys():
        device_ids=kwargs['device_ids']
    else:
        device_ids=None
    if 'output_device' in kwargs.keys():
        output_device=kwargs['output_device']
    else:
        output_device=None
    if 'cuda' in kwargs.keys():
        cudaID=kwargs['cuda'] 
        model=torch.nn.DataParallel(model, device_ids=device_ids, output_device=output_device).cuda(cudaID)
    else:
        model=torch.nn.DataParallel(model, device_ids=device_ids, output_device=output_device).cuda()
    return model
</code></pre>
<p>I was trying this implementation and it works.<br>
However imbalance keeps happening<br>
<div class="lightbox-wrapper"><a class="lightbox" href="https://discuss.pytorch.org/uploads/default/original/2X/c/cade79ccad98b96837d067587ca953362ee3dd95.png" data-download-href="https://discuss.pytorch.org/uploads/default/cade79ccad98b96837d067587ca953362ee3dd95" title="Selection_037"><img src="https://discuss.pytorch.org/uploads/default/optimized/2X/c/cade79ccad98b96837d067587ca953362ee3dd95_2_690x77.png" alt="Selection_037" data-base62-sha1="sWF6gYlPBYXoGQ4jT8DvqnHPSmN" width="690" height="77" srcset="https://discuss.pytorch.org/uploads/default/optimized/2X/c/cade79ccad98b96837d067587ca953362ee3dd95_2_690x77.png, https://discuss.pytorch.org/uploads/default/original/2X/c/cade79ccad98b96837d067587ca953362ee3dd95.png 1.5x, https://discuss.pytorch.org/uploads/default/original/2X/c/cade79ccad98b96837d067587ca953362ee3dd95.png 2x" data-dominant-color="38142D"><div class="meta"><svg class="fa d-icon d-icon-far-image svg-icon" aria-hidden="true"><use href="#far-image"></use></svg><span class="filename">Selection_037</span><span class="informations">709×80 8.68 KB</span><svg class="fa d-icon d-icon-discourse-expand svg-icon" aria-hidden="true"><use href="#discourse-expand"></use></svg></div></a></div></p>
<p>So, as far as i could check printing parameter.device model weights are stored in gpu by-default gpu. In the case I run, we can roughly say each mini-batch requires ~5Gb and model weights ~4Gb (8500-4500)<br>
There is a gain in computing loss in a distributed way.</p>
<p>Is not possible to share model weights among all gpus? Cos in this example, i can increase batch size until gpu uses 12Gb, but it would mean gpu1 and gpu2 would be using only 8.</p>
<p>Even a worse case, if i were using Adam (you mentioned it copies all the model weigths), memory usage in GPU0 would be 12 Gb meanwhile gpu1 and gpu2 would be using 4.</p>
<p>If this were not possible due to pytorch requirements (I guess pytorch requires all tensors to be in the same gpu to be able to operate them)<br>
Is there are way of penalizing workload, this is, an imbalanced amount of samples per gpu to reduce by-default gpu memory requirements?</p>
<p>Toy example<br>
BS=30<br>
gpu0–&gt;4<br>
gpu1–&gt;13<br>
gpu2–&gt;13</p>

albanD: <p>I am by no mean a specialist on DataParallel and I have a cpu-only install so I couldn’t test the code.<br>
The doc states explicitly that if the module returns a 0dim tensor, then you will get a 1D tensor with size the number of gpus. That does not work? Maybe that’s only supported in the latest version.</p>
<p>Sharing the weights among gpus is not possible as they need to be on the device to perform computations.</p>
<p>I am not sure at the moment what creates this inbalance…<br>
Maybe <a class="mention" href="/u/smth">@smth</a> knows? <img src="https://discuss.pytorch.org/images/emoji/apple/slight_smile.png?v=5" title=":slight_smile:" class="emoji" alt=":slight_smile:"></p>

soulless: <p>I am able to reach a relatively balanced memory usage by incorporating the loss calculation in the forward pass. Thanks for the help<br>
<img src="https://discuss.pytorch.org/uploads/default/original/2X/a/ad4295b39872f17fb4b560bc2fedddcedea8a9fc.png" alt="19%20PM" data-base62-sha1="oIJg5UFJLa5LNwlTrl8m22fnKIA" width="553" height="244"></p>

albanD: <p>Perfect !</p>
<p>That means that the inbalance that <a class="mention" href="/u/juanfmontesinos">@JuanFMontesinos</a> sees is due to something in his code that creates that. Not a problem with DataParallel.</p>

JuanFMontesinos: <p>Well glad to hear that, then i will find a way to solve it ^^ Ty <a class="mention" href="/u/alband">@albanD</a> for your help.<br>
Just for discarding, how many parameters does your net have <a class="mention" href="/u/soulless">@soulless</a>?<br>
Cos I’m using a very deep multimodal net</p>

soulless: <p>I am using a CNN autoencoder with around 8 million trainable parameters. How many parameters do you have?</p>

JuanFMontesinos: <p>I guess, not confirmed yet, that if we save/load a model and this model is directly stored from gpu, the memory is not freed.</p>
<p>I mean, I’ve been working is several clusters and saving model directly from dataparallel module. I’ve had all these troubles loading pretrained weights from this dataparallel state dic.  However I found that saving the model prepared for cpu, loading the model again and then moving it to cuda uses less memory.</p>

soulless: <p>Do you mean it would save more memory by moving the dataparallel model back to the cpu model before saving it ?</p>

Hjules: <p>Dear soulless,</p>
<p>Do you by any chance still have the script around for which you made this work?</p>
<p>I am trying to do what albanD suggested above, but it just won’t work. It’d be really nice to have an example to look at.</p>
<p>Regards,<br>
Hjules</p>