Born in Whitburn, Smith played for North Shields Athletic, before moving to South Shields, where he made 264 League appearances in eight seasons. He went on to join Portsmouth and played in the 1934 FA Cup Final side that lost to Manchester City in April 1934.