Weir made 237 appearances and scored 38 goals whilst at Pittodrie, and was capped by Scotland on six occasions. He won two League titles and three Scottish Cups, as well as the European Cup Winners' Cup in 1983, playing a crucial role in the final.