Smith was born in Abbots Bromley, Staffordshire. He played for Aston Villa from 1893 to 1901, helping them to win the Football League title in 1893–94, 1895–96, 1896–97, 1898–99 and 1899–1900, as well as the 1895 FA Cup Final. Although Villa also won the cup in 1897 (thereby taking the "double"), Smith was not selected to play in the final although he made four appearances in the earlier rounds. He made one England appearance against Scotland in 1895.