McCarthy made over 100 appearances for Hamilton Academical as a teenager, before being transferred to Wigan Athletic in 2009 for an initial £1.2 million which was a record sale fee for Hamilton Academical. After winning the FA Cup with Wigan in 2013 he moved to Everton, suffering from various injuries including a broken leg in 2018 which ruled him out for over a year.