An inside-left, he was one of the top players of his time, gaining 16 caps for Ireland (IFA). He played for Coleraine and Glentoran, winning the Irish Cup with Glentoran in 1933, before winning a move to English club Blackpool later in the year. He was sold to Manchester City in February 1936 for a fee of £10,000 and helped the club to win the First Division title for the first time in the 1936–37 season. The outbreak of World War II cost him the chance to play competitive football during his peak years and he was transferred to Derby County as the war drew to a close. He won the FA Cup with Derby, scoring in the 1946 FA Cup final victory over Charlton Athletic. He moved on to Huddersfield Town later in the year.