In June 1926, after six years with Dundee, Irving signed for Football League First Division side Cardiff City in an exchange deal that led to Joe Cassidy moving to Dundee, with the Scottish club also paying a fee towards the move. Irving had nearly joined Cardiff in February 1924 but the move had collapsed. He made his debut for Cardiff in a goalless draw with Leeds United on 30 August, before scoring his first goal on 9 October in a 3–0 win over Sheffield United. His early months were disrupted by a knee injury sustained after slipping down steps at a team hotel before a game against Bury and an infected finger that caused him to miss several matches in November. Having initially played at half back, he was moved to inside right in February 1927 and remained there for the rest of the campaign. Irving made 27 league appearances, scoring three times as Cardiff finished in 14th place. He also played in all six of the club's matches en route to reaching the 1927 FA Cup Final and was instrumental in his side's 3–2 victory over Chelsea in a sixth round replay, scoring one and assisting Len Davies for another. In the final, Irving started at inside right as Cardiff went on to beat Arsenal 1–0 to become the only side from outside England to win the competition. Two weeks later, Irving scored in the final of the Welsh Cup as Cardiff defeated Rhyl to complete a cup double.