He played for Aston Villa from 1907 to 1915, and then joined Port Vale in January 1917. Five years later he moved on to Walsall as a player-coach. He helped Villa to win the First Division in 1909–10 and the FA Cup in 1913. They also finished second in the league in 1907–08, 1910–11, 1912–13, and 1913–14, and was also on the losing side in the 1910 FA Charity Shield.