Miller started his playing career with Clydebank Strollers before he made the move to Rangers. He played for Rangers from 1967 until 1982 and made 309 appearances during his spell at Ibrox, scoring 33 goals. After being coached by David White he was promoted to the first team, and won his first medal in the 1970 Scottish League Cup Final. He impressed the supporters having played in the 1971 Scottish Cup Final against Celtic despite having a broken jaw. However, under coach William Waddell, he was mostly a second choice player and was not in the squad in one of the biggest successes of the club's history, the triumph in the 1972 European Cup Winners' Cup Final.