McGiffin was assigned to Admiral Ting Ju ch'ang's Beiyang fleet (literally "Northern Fleet"). The fleet was partially organized and trained by McGiffin, and he would serve as an executive officer aboard the Chinese battleship "Zhen Yuan" during the Battle of the Yellow Sea (1894). He was severely wounded during the battle and returned to the United States, suffering from mental instability due to his wounds.