Shah was a long-term close associate of President Pervez Musharraf, and was Director of the Inter-Services Intelligence (ISI) Punjab during Musharraf's 1999 coup. Musharraf appointed Shah as Director-General of Intelligence Bureau of Pakistan from 2004 to 2008. Shah's tenure as the head of Intelligence Bureau was controversial with accusations of political victimisation and for undermining the judiciary.