As a player, he played for Newtown, Cardiff City, Liverpool, Stoke and Southport Central, and played 10 times for Wales. He coached Cardiff City during its greatest period of success between 1911 and 1936. The team won the FA Cup in 1927, and only missed out on the League Championship by goal difference. He also coached Great Britain at the 1920 Summer Olympics.