Smith, who played in either full-back position, spent the majority of his career at Portsmouth, having previously played League football for South Shields. After joining Portsmouth in 1928, he made 311 League appearances, and played in the 1934 FA Cup Final side that lost to Manchester City in April 1934.