In 1911, he joined Cardiff City along with his Stockport manager Fred Stewart where he quickly became established in the first team. Prior to World War I, he helped the side win their first Welsh Cup in 1912 and the Second Division of the Southern Football League a year later. After the war, he was part of the Cardiff side that joined the Football League in 1920 and won promotion to the Football League First Division in their first season. He remained a mainstay in the first team for seven more years in the First Division, helping the side finish as runners-up in the 1923–24 season and reach two FA Cup finals, in 1925 and 1927. In the latter, Cardiff became the first team from outside England to win the competition.