Nationalist historiography celebrates various victories of "Koreans" over "foreigners" including the Goguryeo–Sui War (612), Goguryeo–Tang War (645), Goryeo–Khitan War (1018), Korean-Jurchen wars (1107), Mongol invasions of Korea (1231–73), and Japanese invasions of Korea (1592–1598). Accordingly, military heroes such as Eulji Mundeok of Goguryeo—and indeed all the generals of the Three contemporary kingdoms of Goguryeo, Baekje, and Silla—are assigned a common, "national" identity of Korean. In the words of John Duncan, however, it is "extremely unlikely" that the people of those kingdoms would identify with "a larger, 'Korean' collectivity that transcended local boundaries and state loyalties". Yi Sang-ryong, who argued that history "raised the dignity of the country and fostered patriotism" ("kungmin chŏngshin") claimed that during the "northern history" of Koreans in Manchuria, from the time of Dangun to Balhae, the Sushen ("Suksin") and Japanese people were subordinate to Dangun.