He was elected district attorney in 1862 and served for three years. He was solicitor for the city of Reading from 1867 to 1870, and a member of the board of school control of Reading from 1868 to 1876. He was a delegate to the Democratic National Conventions in 1868 and 1880. He was chairman of the standing committee of Berks County, Pennsylvania, in 1869, 1872, and 1873. He served as a member of the Pennsylvania State Senate for the 1st district from 1873 to 1874 and the 11th district from 1875 to 1887. He was appointed in October 1877 by Governor John F. Hartranft as a member of the Pennsylvania Statuary Commission.