Educated at Harrow School, Upcher was commissioned as an ensign in the 67th Regiment of Foot on 21 November 1862. He commanded the British troops at the Battle of Quintana in February 1878 during the 9th Xhosa War and commanded the 1st Battalion of the 24th Regiment of Foot in the aftermath of the Battle of Isandlwana in January 1879 during the Anglo-Zulu War. He also served in the Third Anglo-Burmese War in 1885 before becoming General Officer Commanding the 5th and 68th Regimental Districts and then retiring on 3 September 1902. He was also colonel of the Durham Light Infantry.