[05:09] morning [05:18] hey mborzecki [05:19] mvo: hey [05:20] PR snapd#8777 closed: packaging: disable buildmode=pie for riscv64 [05:22] mvo: there is no docs for the snapd API besides the code, right? i recall we discussed tools to use for documenting it nicely, but i don't recall seeing any readmes or whatnot [06:19] mborzecki: sorry for the delay, did not see the msg - here are the docs https://github.com/snapcore/snapd/wiki/REST-API [06:20] mborzecki: but very outdated [06:23] mvo: thanks! [06:24] mvo: hm maybe we should move that to the forum [06:35] mvo: added the snapd REST API docs page in the forum https://forum.snapcraft.io/t/snapd-rest-api/17954 we'll need to update it though [06:37] mborzecki: oh, nice [06:38] mborzecki: yes, it needs updating but having it here is a good step, I wonder if we can delete the wiki version or if we can redirect it or something [06:38] funny, i've never looked in the wiki section in the snapd repo, immediately assumed that forums is where it would live since we have all the docs there [06:39] mvo: perhaps we can discuss that quickly during the standup? [06:40] mborzecki: +1 [06:41] mborzecki: yeah, the issue was that we always wanted to move it but there was never time and the perfect was (maybe) the enemey of the good [06:41] mborzecki: i.e. just moving it to the forum as is not that much work and beneficial but we always wanted to do more (like auto-generating it) hence the delay :/ [06:41] mborzecki: anyway, thanks for doing this! [06:42] mvo: with gh actions, maybe we could update the forum doc automatically? :) [06:42] mborzecki: heh - nice idea! [06:58] o/ [06:58] good morning zyga [06:58] mborzecki: actions can trigger on directories [06:58] good morning [06:59] though it's bad, I can barely stand :/ [06:59] zyga: oh no :( [07:00] zyga: nice, so we'd need to agree on a format of the doc, swagger or maybe just plain markdown, and then push that to the forum automatically from master? [07:01] same markdown should work on github wiki if we want to keep maintaining that [07:02] morning [07:12] eh, thinkpad died on the spot again [07:13] mvo: mborzecki: what is this https://forum.snapcraft.io/t/snapd-rest-api/17954 ? [07:16] pedronis: tried moving the snapd api docs from github wiki to the forum where they can be found, quick HO to discuss what to do with this? [07:16] pedronis: it's the old rest API from the wiki, mborzecki moved it over to the forum this morning [07:16] I would really like to involved in this kind of things [07:17] mvo: there are bit that we probably don't want to document anymore at all [07:17] pedronis: sorry, maybe i was a bit quick to move that [07:19] pedronis: sure, what do you recommend? hiding the post? or "fixing", i.e. marking the bits we don't want as obsolete or removing them? [07:19] mvo: did we plan to work on this right now? [07:20] but yes, moving it over without a plan of how to improve it doesn't seem a great idea to me, but my 2cts [07:20] pedronis: we did not plan this [07:21] PR snapd#8520 closed: data: fix shellcheck warnings in snapd.sh.in [07:21] pedronis: if you think it's a net-negative we can just hide/remove it again [07:21] mvo: did you at least talk with Graham? [07:22] pedronis: i'm happy to have a chat about that, the reason i moved it was that it was not easy to find them, so if they're in the forum could start updating them incrementally [07:23] mborzecki: the problem is, we should discuss what to simply scrub before moving it over at least [07:23] pedronis: I did not, this happend this morning. but I think the intention is good and give us a chance to improve things. I understand your concerns though, maybe we can hide it and tweak it with the help of graham and then add it back? how does that sound? [07:24] mvo: it should have been put in some place easier to edit at least initially [07:25] pedronis: ok, let me find out where degville keeps the pages for editing, move it to that location and we can take it from ther, wdyt? [07:26] PR snapd#8767 closed: snap: (small) refactor of `snap download` code for testing/extending [07:33] mvo: small tweak https://github.com/snapcore/snapd/pull/8722#discussion_r434363214 [07:33] PR #8722: tests: check that host settings like hostname are settable on core [07:36] mborzecki: let's do that then, move into degville queue and hide until it's a bit nicer (we need to remove some bits like "buy") [07:36] ack [07:37] mvo: https://github.com/snapcore/snapd/pull/8722#pullrequestreview-423293055 [07:37] PR #8722: tests: check that host settings like hostname are settable on core [07:46] mborzecki / mvo / pedronis: (morning!) it's great we're updating those API docs (thanks mborzecki!) - they've been on my mind for a long time. I think it's ok marking them WIP on the forum for now until we can go over them. They won't be published outside the forum until we add the page to the whitelist. They're currently only as broken as the GH wiki version :) [07:49] degville: hi, thanks for the tip, was about to add the header you have in other docs but i see you're already editing the page [07:50] mborzecki: yeah, I just expanded on your note a little. [07:51] degville: great, thank you [07:54] degville: there are really some things that we want to stop documenting, that's the part I'm unhappy about [07:55] becaue they are again in fron of people [07:56] pedronis: ok. would you rather I unlist the page? or would you simply prefer us to move it to a google doc for now? [07:57] degville: well unlist for now and we talk in the standup about what needs removing and we decide how to proceed? [07:57] pedronis: yep, np. [07:57] done [07:59] pedronis: should we unlist the wiki page too? https://github.com/snapcore/snapd/wiki/REST-API [08:03] mvo: playing with your gdbserver branch, i think i've hit: https://sourceware.org/bugzilla/show_bug.cgi?id=18945 [08:05] mvo: maybe it'd also be nice to pass a port number in --gdbserver[=], otherwise the gdb command is different for each invocation [08:08] mborzecki: looking, sorry [08:09] mborzecki: we can do that once we have decided what to do with the moving to the forum [08:09] pedronis: ok [08:16] PR snapd#8773 closed: overlord/configstate: add sysctl option [08:18] mborzecki: reading this bug makes me wonder if the approach is doomed [08:18] mborzecki: actually, hm [08:18] mborzecki: maybe a quick ho? [08:18] mvo: ok [08:18] standup? [08:19] mborzecki: yeah, 1min [08:19] mborzecki: ready when you are === ricab__ is now known as ricab [09:48] pedronis: can you look at https://github.com/snapcore/snapd/pull/8778 again please [09:48] PR #8778: tests: modernize and use snapd.tool <⛔ Blocked> [09:48] zyga: not now, just mark it unblocked I suppose [09:48] ok [09:48] I put it on PATH [09:48] I guess that's okay [09:55] mvo: pushed some tweaks to https://github.com/snapcore/snapd/pull/8784 please take a look when you have a slot [09:55] PR #8784: snap: add new `snap run --gdbserver` option [09:57] mborzecki: \o/ thank you, looking [09:58] mborzecki: thanks for https://github.com/snapcore/snapd/pull/8784#discussion_r434384356 - I like this idea a lot [09:58] PR #8784: snap: add new `snap run --gdbserver` option [10:00] mborzecki: I really like your idea of breaking at exec and avoid the raise(SIGTRAP) but that's for later I guess :) [10:30] hmm actually surprised, i'm looking at the backtrace from a segfault in snap-store [10:31] target:/snap/snap-store/467/gnome-platform/usr/lib/x86_64-linux-gnu/libgdk-3.so.0 gtk3 in gnome platform snap are built with symbols? [10:31] the entries in backtrace are pretty detailed, eg `#5 0x00007f473cedab04 in gtk_label_get_preferred_layout_size (label=0x5612253d4ef0, smallest=0x7ffcf00c89b0, widest=0x7ffcf00c89a0) at ../gtk/gtklabel.c:3725` [10:32] heh, info sharedlibrary definitely lists some of the libraries in snap-store & gnome snaps are cotnainig debug symbols [10:42] pedronis: do you have a moment to summarize what you want to do about snapd tools? [10:43] pedronis: you said you want them to behave more like in classic [10:43] are you thinking about making whatever tools we have available in the initial mount ns and then just inheriting all of that (and change propagation) into snap namespaces? [10:44] zyga: probably better to chat tomorrow [10:44] pedronis: I may be off tomorrow for a medical visit, if you have the time just summarize this in an email and share that when you have the time [10:44] pedronis: but that's fine, I have things to do [10:44] just wanted to understand your ideas better [10:46] PR snapd#8796 opened: tests: modernize retry tool [10:48] zyga: https://forum.snapcraft.io/t/gimp-broken/17958 [10:49] hmm [10:49] * zyga tries [10:50] mborzecki: I wonder if we released robust mount namespace updates? [10:51] wasn't that in 2.44 already? [10:52] ah no, it was but disabled, 2.45 made it default in https://github.com/snapcore/snapd/commit/716ec3de3526e7c6eb1b22e3d077b4fc48d69a6e [10:54] mborzecki: works on my machine :/ [10:56] heh ;) [10:56] quick errand, back in 30 === facundo__ is now known as facubatista [11:29] re [11:45] pstolowski: follow up from the parsed security tag branch https://github.com/snapcore/snapd/pull/8797 [11:45] PR #8797: snap/naming: add helpers to parse app and hook security tags [11:46] zyga: ty! [11:47] PR snapd#8797 opened: snap/naming: add helpers to parse app and hook security tags [11:51] zyga: something is wrong with the spread jobs, ther's a bunch of queued jobs, some from 15h ago [11:52] mborzecki: checking [11:53] hmmm [11:53] odd [11:53] zyga: https://github.com/snapcore/snapd/actions?query=workflow%3ATests [11:53] yeah, I looked [11:53] I saw something similar yesterda [11:53] when after a unit test job was finished [11:53] all of a sudden *all* the spread jobs started [11:54] maybe it's somehow related to slot allocation [11:56] mborzecki: I did a pass on #8775, it's a bit unclear what should happen with the recovery partition scripts [11:56] PR #8775: [RFC] bootloader, boot: boot scripts, edition <⛔ Blocked> [11:56] it seems to support updates but not installing [11:56] but then updates are called install [11:57] mborzecki: ha, it just happened [11:57] brb [12:03] pedronis: thanks, will check the comments [12:03] zyga: anything interesting there? did the spread jobs start? [12:04] mvo, pstolowski: is tests/lib/nested.sh supposed to be shellcheck clean on bionic? [12:05] jdstrand: it should be clean everywhere, yes [12:06] let me get you a paste [12:06] (me dev container is still bionic) [12:07] my* [12:07] pstolowski: https://paste.ubuntu.com/p/wPYVVt4VdX/ [12:08] pstolowski: you did touch that line recently, but if I change it back, more errors are unconvered [12:10] jdstrand: that's unexpected, should have been caught on travis; thanks, i'll check it [12:11] pstolowski: thank you. note, it had been a while (weeks?) since I last ran run-checks (tasked with work that didn't involve submitting PRs), so not sure when it was introduced [12:14] hmmm [12:14] mborzecki: lxd refreshed and we ran out of memory [12:14] we allocated all the memory and the system was in limbo state after oom killer went hunting [12:15] jdstrand: ok, weird.. even recently i had a shellcheck error there and it was preventing merging. very weird it get through [12:15] *got [12:15] zyga: hm, w8, how much mem does this system have? [12:15] I'm looking though the logs now [12:15] 8GB [12:15] mborzecki: but it's not usually staturated, it's happened the moment lxd refresh ran [12:16] https://usercontent.irccloud-cdn.com/file/DTVVZl9c/overnight%20lxd%20refresh%20crash [12:16] load average approaching 1K? [12:17] hmm auto update ;) [12:17] maybe I should configure lxd with memory limits [12:17] zyga: can you see what got killed by oom? [12:18] https://usercontent.irccloud-cdn.com/file/j5i39wAk/dashboard%20over%20last%20two%20weeks [12:27] pstolowski: I noticed that shellcheck is only conditionally run on if it is installed. not sure if that helps track things down for you... [12:28] jdstrand: interesting.. thanks! [12:34] pstolowski: should we re-run things to land #8567? or do you want to see #8780 green first? [12:34] PR #8567: o/devicestate: core20 early config from gadget defaults [12:34] PR #8780: tests: core20 early defaults spread test [12:36] pedronis: restarted. i don't think it needs to wait for 8780 [12:36] ok [12:37] PR snapd#8798 opened: data/selinux: allow checking /var/cache/app-info [12:37] PR snapd#8799 opened: interfaces/system-packages-doc: fix typo in variable names === KindTwo is now known as KindOne [12:46] jdstrand: I tried to answer your questions in a couple of open PRs [12:47] mvo: what needs to happen to have https://github.com/snapcore/bolt/pull/1 merged & then vendorized version updated? [12:47] PR bolt#1: Enable riscv64 build [12:47] given it is #1 i fear this has never been excercised =) [12:50] pedronis: updated the parsed tag PR [12:50] I need to reboot, my thinkpad is acting up again, x input broke [12:50] eh [12:51] mvo: fyi, https://github.com/snapcore/snapd/pull/8398#issuecomment-638175977 (I deconflicted but there are cla-check issues still) [12:51] PR #8398: usersession/userd: add "slack" to the white list of URL schemes handled by xdg-open [12:54] jdstrand: o/ 8788 is not more strict (the hwcaps PR) [12:54] is *now* more strict [12:59] pe [12:59] xnox: merged now, now it just needs an update to the vendor.json in snapd, I can do that after the meeting [13:00] pedronis: thanks! I responded to PR 8789 (note, that isn't urgent so if you're busy, feel free to circle back) [13:00] PR #8789: interfaces/docker: use implicitOnClassic: true <⛔ Blocked> [13:00] mvo: I don't really feel able to attend the meeting today [13:00] mvo: tah. I don't know how to correctly do govendor stuff. and plus then the ci will run against this bolt change for the first time. [13:00] it better not regress anything on non-riscv64! [13:01] pstolowski: https://github.com/snapcore/snapd/blob/master/.github/workflows/test.yaml#L74-L78 [13:02] maybe we should use --edge there [13:02] zyga: no worries, get well! [13:02] xnox: no worries [13:03] mborzecki: thanks, is it run only on 16.04 or am I reading it wrong? [13:08] jdstrand: turns out we run shellcheck from a snap (which is shellcheck 0.7.0). bionic has shellcheck 0.4.6 [13:10] jdstrand: can you try with the version from snap? [13:17] oh! [13:17] PR snapd#8800 opened: usersession/userd: add "slack" to the white list of URL schemes handled by xdg-open - 2.45 [13:18] pstolowski: absolutely yes. I was thinking I needed to backport shellcheck from focal, but then when you said it was supposed to work everywhere, I stopped [13:20] mvo: ok, sorry to keep pinging you. as mentioned, I deconflicted PR 8398. The submitter signed the cla (see my PR comment) but cla-check is still failing. so I milestoned that to 2.46 and then created PR 8800 for 2.45 with 'Original-Author: troyready ' [13:20] PR #8398: usersession/userd: add "slack" to the white list of URL schemes handled by xdg-open [13:20] PR #8800: usersession/userd: add "slack" to the white list of URL schemes handled by xdg-open - 2.45 [13:20] mvo: but it failed with: 'troy@troyready.com (https://api.launchpad.net/1.0/~troyready) has NOT signed the CLA' [13:20] jdstrand: ok, good; so for clarity, we only care about latest shellcheck [13:21] mvo: oh, actually, I see troyready signed the code of conduct, I don't know about the cla, but he has a screenshot in the original PR [13:21] mvo: so, yeah, I'll defer to you on how to proceed [13:27] pstolowski: yep, understood === facundo__ is now known as facubatista [13:35] gah, another sudden power off [14:01] xnox: I pushed 8801 with the bolt update [14:02] jdstrand: thanks, I have a look why the cla is acting up, it's unfortunately a constant hassle :( [14:02] PR snapd#8801 opened: vendor: update to latest github.com/snapcore/bolt for riscv64 [14:05] mvo: :\ [14:20] * cachio afk [14:41] cmatsuoka: when would be a good time to update spread? [14:41] do you need the new master deployed? [14:42] zyga: let me update the yaml and prepare a PR to update the secure-boot attribute [14:42] cmatsuoka: I think we should burn through the current queue first [14:43] cmatsuoka: can we agree on a a time, perhaps tonight when europe stops working [14:43] zyga: sounds good, I'll leave the PR ready and then we can switch at any convenient time [14:43] ok [14:51] zyga: https://github.com/snapcore/snapd/pull/8802 [14:51] PR #8802: spread.yaml: update secure boot attribute name <⛔ Blocked> [14:52] hmm perhaps skip spread is undesired :) [14:52] but I think we can close and reopen without it [14:52] that's fine, I'll do this late at night when there is less activity [14:52] PR snapd#8802 opened: spread.yaml: update secure boot attribute name <⛔ Blocked> [14:53] zyga: it will fail with the current spread, but we can remove the skip tag after spread is updated [14:53] ok [14:53] yeah, we learned that the tags tend to stick though :) [14:53] that's fine [14:53] we can use the close / open trick [14:53] oh really? well ok then [14:53] * zyga breaks for some time to just rest and avoid pain [14:53] yeah, we noticed when the tag was first used in actions but perhaps this was not common knowledge in the team yet [14:56] if everything else fails we can close it and open another PR :) [14:57] or run it manually and land :) [15:10] cachio: could you take a look at the new spread test in https://github.com/snapcore/snapd/pull/8780 ? [15:10] PR #8780: tests: core20 early defaults spread test [15:13] PR snapcraft#3154 opened: cmake v2 plugin: take source-subdir into account [15:46] ijohnson: you froze for me [15:47] yes rejoingin one moemnt sorry [15:50] * cjp256 laughed at`Download snap "snapcraft" (4852) from channel "latest/edge" 0% 0B/s ages!` [15:51] Specifically at the 'ages!', not the fact it's not downloading anything :) [15:53] PR snapd#8803 opened: tests: port interfaces-many-core-provided to tests.session [16:03] pstolowski, sorry, I was with the doctor [16:03] pstolowski, I'll check it now [16:06] cjp256: at 0B/s it should really be never, not ages [16:06] cjp256: haha, i've never seen this; interestingly i've just checked, and we have a TODO there saying "// TODO: figure out exactly what overflow causes the ==0" [16:07] cmatsuoka: I think it is being optimistic ;) [16:07] hah [16:07] yeah, it wants to give hope [16:17] pstolowski, review done [16:17] just minor changes required. [16:17] cachio: thanks! [16:17] pstolowski, yaw [16:43] the day of constant pain is not a good day [16:52] hrm [16:52] I have a patch I cannot find [16:52] where did I put it [16:53] PR snapd#8804 opened: tests: port xdg-settings test to tests.session [16:56] I'll make some coffee and get painkillers [16:56] and then do one more PR [16:56] and maybe help drain the queue by running more workers [16:56] afk [17:11] re [17:13] cachio: hey, re your comment for " 2 functions: 1 for unsign and 1 for sign " [17:14] cachio: do you think just one function that does sbattach --remove & sbsign would be ok? i'm not sure we need more granularity [17:15] pstolowski, yes [17:15] ok [17:15] the idea is to have that as a function so the tests are more easy to read / understand [17:15] in the future [17:15] thanks [17:28] https://github.com/snapcore/snapd/pull/8805 is the last one :) [17:28] PR #8805: tests: port interfaces-calendar-service to tests.session [17:28] PR snapd#8805 opened: tests: port interfaces-calendar-service to tests.session [17:28] please look at the two "test robustness" PRs [17:28] no more leaking dbus [17:30] Is there a place to track progress of UbuntuCore 20, its "what's new" and an expected timeline for its release ? [17:32] om26er: good question [17:32] om26er: it's a bit hazy, apart from what's in the PRs that are landing [17:33] om26er: I heard that beta is coming soon but there are still some TODOs in the code [17:34] maybe there is a public kanban I could look at ? [17:35] nope [17:35] I wish we used github projects for the public side but that didn't go far [17:35] you can expect ongoing releases to broaden core20 support [17:43] PR snapd#8806 opened: tests: install/run the lzo test snap too [17:48] * cachio -> app with doctor part 2 [17:50] cachio: updated #8780 [17:50] PR #8780: tests: core20 early defaults spread test [18:13] hmm [18:13] I will fight the pain and go and turn on some extra workers [18:13] this queue is not shrinking fast enough [18:45] hmm, tests stalled again [18:47] sorry, I was not able to go down [18:48] back hurts badly and affects leg [18:49] ah ugh, yeah, don't do anything that could make it worse [19:34] PR snapcraft#3155 opened: storeapi: specify Content-Type for icon [19:44] PR snapcraft#3156 opened: log: trace HTTP connections with developer debug [19:53] zyga, any idea why jobs for #8790 are queued? [19:53] PR #8790: tests: update the file used to detect the boot path on uc20 [19:53] because we are burning through this backlog: https://github.com/snapcore/snapd/actions?query=is%3Aqueued [19:56] zyga, I see [20:19] degville (cc emitorino): hi! is https://github.com/snapcore/snapd/wiki/REST-API the right place to look at the rest api of /run/snapd.socket? I expected something more like https://api.snapcraft.io/docs/info.html but for snapd's socket (also, what about a similar page for snapctl?) [20:21] jdstrand: unfortunately, yes, right now. Moving it to somewhere more appropriate is on our immediate to do list, and we're meeting this week to discuss it. [20:21] And of course updating it and the process to keep it updated. [20:22] degville: oh, heh. nice. AIUI, the snapctl api could probably live on the same page since it will largely be a subset of the snapd api [20:23] ack jdstrand [20:23] degville: but emitorino and I were talking about how there is a lack of documentation on the security properties of /run/snapd.socket (snap) vs /run/snapd-snap.socket (snapctl), so perhaps some verbiage on that could be included? 2 cents [20:26] degville: thanks for all your doc work btw :) [20:26] jdstrand / emitorino: yes, definitely. after we've sorted its location and how we'll keep it updated, maybe i could ping you for your thoughts. Also, thanks for the snapctl api (oh, thanks :) still lots to do!) [20:29] degville: perhaps add userd's DBus API to the list as well (along with its security properties, if it makes sense there)? (sorry, that is the last one I had in my mind) [20:29] degville: and yes, emitorino and I would be happy to chat about the security aspects whenever it makes sense for you [20:30] jdstrand: ok. Thank you! [20:58]