=== kadams54-away is now known as kadams54
=== kadams54 is now known as kadams54-away
=== kadams54-away is now known as kadams54
[02:27] <rick_h_> hatch: miss another reviewq/qa before landing?
=== kadams54_ is now known as kadams54-away
=== kadams54-away is now known as kadams54_
[03:50] <hatch> oh yeah woops :/ I think I got the two mixed up 
[03:50] <hatch> although 677 still needs that final qa
[03:57] <rick_h_> hatch: k, can try tomorrow
[04:06] <rick_h_> hatch: don't forget you had a review today too
[04:06] <rick_h_> first thing
[04:06] <rick_h_> hatch: and we can check with frankban but I think the charm is fine and we can start the gui release first thing tomorrow
[04:07] <rick_h_> just so you're not bored tomorrow
[04:07] <rick_h_> :)
[04:08]  * rick_h_ considers caught up enough for tonight
[04:34] <hatch> haha 
=== kadams54_ is now known as kadams54-away
=== nottrobin__ is now known as nottrobin_
=== nottrobin_ is now known as nottrobin
=== alexpilotti_ is now known as alexpilotti
[14:44] <hatch> kadams54: can you do another review of 677 so I can land it?
[14:45] <kadams54> hatch: Sure, taking a look
[15:03] <kadams54> hatch: is the juju-gui charm supposed to be filtered out?
[15:05] <hatch> kadams54: I didn't because it only shows up sometimes now
[15:05] <kadams54> k
[15:05] <hatch> ooo ghost added xml sitemaps
[15:06] <kadams54> QA is OK
[15:07] <hatch> thanks
[15:20] <hatch> rick_h_: hey you mentioned that I should start looking at doing a gui release? 
[15:20] <hatch> still looking like that's good?
[15:20] <rick_h_> hatch: let's verify with frankban but last I recall we don't need gui charm changes so release is unblocked
[15:21] <frankban> rick_h_: confirmed
[15:21] <hatch> oh? none of the quickstart changes effect the gui?
[15:21] <hatch> nice
[15:21] <hatch> ok I'll start qa'ing
[15:49] <hatch> the related charms section in charm details page has all the icons broken 
[15:50] <hatch> will need to fix that
[15:52] <rick_h_> hatch: rgr
[15:52] <rick_h_> hatch: can you add a card please?
[15:52] <hatch> already done :)
[15:52] <rick_h_> ty
[15:52] <rick_h_> uiteam call in 10 kanban please
[15:53] <hatch> https://api.jujucharms.com/charmstore/v4/yui_3_11_0_1_1418744920875_6993/icon.svg
[15:53] <hatch> heh nope that's not right
[15:53] <hatch> :)
[15:58] <hatch> boom fixed!
[15:58] <hatch> I still think this page makes no sense
[15:58] <hatch> lol
[15:58] <hatch> another time!
[16:34] <frankban> uiteam: I need reviews/QA for https://codereview.appspot.com/188300043 (quickstart / python). anyone available?
=== kadams54 is now known as kadams54-away
[16:46] <hatch> uiteam I need a review and qa for a small bug fix (release blocker)
[16:46] <hatch> https://github.com/juju/juju-gui/pull/679
[16:47] <hatch> ok just need qa now 
[16:47] <hatch> now this next bug is interesting....quite interesting indeed
=== kadams54-away is now known as kadams54
[17:12] <hatch> uiteam ok I now need reviews on #679 and #680 both release blockers
[17:13] <hatch> now onto flag removal
[17:17] <hatch> rick_h_: do we have mockups for the login stuff? The markup that the 'showGetJujuButton' references is no longer there
[17:19] <rick_h_> hatch: kadams54 jcsackett ^
[17:20] <kadams54> hatch: Looking at both.
[17:20] <hatch> we'll need to update the gui charm to not set that config value
[17:21] <hatch> there is some conflicting comments in the code around the logout-trigger button too
[17:21] <hatch> some areas say it can be removed but it's actually being used
[17:25] <hatch> kadams54: ok I'm ready to push the removal of this flags stuff - any word on the mockups?
[17:26] <kadams54> hatch: I'm very confused at this point. Do you mean mockups for login work in GUI or blues browser?
[17:26] <hatch> gui
[17:26] <hatch> this is the gui channel afterall :)
[17:26] <hatch> I just can't find anything searching in the drive
[17:26] <kadams54> hatch: Not that I've seen.
[17:27] <kadams54> Or can remember ;-)
[17:27] <hatch> haha hmm
[17:27] <hatch> maybe it's in the email somewhere
[17:28] <hatch> yup email hah
[17:28] <hatch> man we need to make a rule that this stuff needs to go in one spot
[17:28] <hatch> rick_h_: ok yeah so it looks like the charm will need to be updated to not set this flag 'showGetJujuButton'
[17:30] <hatch> card created
[17:30] <hatch> will get on that next
[17:34] <hatch> uiteam reviews and qa's on #680 #681 :D 
[17:34] <kadams54> Looking
[17:34] <kadams54> Just out of curiosity, how many more of these we got left?
[17:34] <hatch> 0 for the GUI, 1 for the charm
[17:35] <hatch> but of course I still need to do another round of qa
[17:35] <hatch> so....TBD :P
[17:35] <hatch> kadams54: fyi you were sent the email with the logout dropdown :P
[17:47] <hatch> forgot - new computer, no guicharm branches locally
[17:47] <hatch> cya in 2 weeks :P
[17:50] <hatch> uiteam I need one more review on #680
[17:54] <hatch> kadams54: will you be able to review/qa 681 as well?
[17:54] <kadams54> hatch: In progress
[17:54] <hatch> thanks
[17:57] <hatch> rick_h_: changes to the charm get done in lp:~juju-gui/charms/trusty/juju-gui/trunk/ then merged into precise?
[17:57] <hatch> It's been a while since I've done charm work 
[17:57] <rick_h_> hatch: yes 
[17:58]  * rick_h_ has to get food finally off calls
[17:58] <hatch> thanks
[17:58] <hatch> :)
[18:01] <kadams54> hatch: Done on 681.
[18:04] <hatch> kadams54: thanks
[18:07] <hatch> kadams54: turns out the test failure is because the new logout button is hidden so I need to update the selenium test to open the dropdown first
[18:11] <rick_h_> hatch: have reviews?
[18:11] <rick_h_> hatch: no pr link in the card in review
[18:12] <hatch> doh did I miss one
[18:12] <hatch> updating
[18:12] <hatch> updated
[18:13] <hatch> 680 is in need of another review
[18:13] <hatch> 681 has a selenium failure which I'm fixing
[18:13] <rick_h_> k
[18:13] <hatch> so a review can hold off on that
[18:18] <hatch> ok pushed the fix for the selenium tests, hope it works ;)
[18:19] <rick_h_> :)
[18:19] <hatch> replied
[18:49] <hatch> annnd charm modified
[18:53] <hatch> bleh selenium test changes didn't work - looks like I'll have to set it up locally and test
[18:57] <hatch> but first, lunch
=== kadams54 is now known as kadams54-away
=== kadams54-away is now known as kadams54
=== kadams54 is now known as kadams54-away
=== kadams54-away is now known as kadams54
[22:40] <hatch> uiteam lf reviews and qa on https://github.com/juju/juju-gui/pull/682
[22:40] <hatch> thx
[22:40] <hatch> ^ rick_h_ the fruits of our discussion (from the GUI side)
=== kadams54 is now known as kadams54-away
=== kadams54-away is now known as kadams54
=== kadams54 is now known as kadams54-away
[23:26] <rick_h_> hatch: ty will look
=== kadams54 is now known as kadams54-away