=== chihchun is now known as chihchun_afk === hyperair is now known as Guest84654 === _salem is now known as salem_ === chihchun_afk is now known as chihchun === salem_ is now known as _salem === chihchun is now known as chihchun_afk === chihchun_afk is now known as chihchun [07:51] is there a way to send or read text messages in an app ? [08:04] nik90_: hey, tried to use the alarm clock today. doesn't seem to ring off for me. what's the state there? [08:05] is it supposed to work or still WIP? [08:36] Good morning all; happy Friday and happy World Population Day! :-D === chriadam is now known as chriadam|away [08:38] mzanetti: Good morning [08:38] nik90_: Good morning [08:38] mzanetti: The alarm should work as expected. I woke up to them for the past 4-5 days [08:39] nik90_: hmm... can I verify on the command line somehow if the alarm is actually set? or any other means to debu git? [08:39] really doesn't ring ever here [08:40] mzanetti: the alarm is stored at .local/share/evolution/tasks/randomfoldername/tasks.ics [08:40] mzanetti: if you can get me that folder, I can check if EDS has saved it properly or no [08:40] not* [08:41] nik90_: ack. can't fetch it right now as I'm working on another device. but will get you that folder in a few [08:41] mzanetti: np, I will be here [08:41] cool [08:55] https://github.com/loqui/im interesting [08:55] its in the FFOS store. [08:55] has WhatsApp support (unofficial) [08:57] popey: how do you change the title of a note book in reminders or for that matter delete one the only options I see when I click on a note book are search and refresh [08:57] davmor2: do it on the web [08:59] davmor2, click on the edit button on the header, it should let you edit the title and the content of the note [08:59] popey: also if you edit a note in a notebook why does it move it auto change the notebook I'm in to first notebook. IE Notebook 1,2,3 I have a note in 3 I hit edit change the note text hit save and it default to save it in 1 [09:00] davmor2, and the notebook thing is probably a bug [09:00] bugs.launchpad.net/reminders-app [09:01] dpm: I have =Notebooks + = if I click on the notebook in question I get < Personal nores + = hence wanting to change the title :) [09:01] davmor2, ah, sorry, I misread the notebook title change [09:01] I read "note" [09:01] So that is a feature request and a bug then thanks [09:01] dpm: you sure you want me to test this? [09:02] davmor2, indeed, it makes sense as a feature, I think [09:02] davmor2, I'm never sure to have you test things, as you always manage to break them! :) [09:03] dpm: also if you setup an account, and then open the app after the account is added it say you have no account add one click here, you click there it takes you to a page where you click accept and then goes back to the app, that doesn't seem right some how [09:22] davmor2, the workflow is right, but the message needs to change. The reason being, if you create the account outside the app, then you need to authorize the app to use the account the first time. If you create the account from within the app, it then does the authorisation transparently for you [09:23] but I noticed that one with the message too. We need to be able to detect whether there is genuinely no account, or whether there is an account that needs authorisation [09:24] dpm: oh indeed, it's not a wrong workflow but it saying there is No account when you know for a fact you just created one is the but thats meh [09:24] indeed [09:28] nik90_: here you go: http://paste.ubuntu.com/7779376 [09:28] nik90_: interesting thing that there are 4 alarms in there, should be 2 only [09:29] mzanetti: are you running the latest image? [09:29] nik90_: promoted one [09:29] not devel-proposed [09:30] mzanetti: ok [09:30] nik90_: but even if those 4 alarms would be what I want. I never heard any of those actually ring [09:33] mzanetti: does the saved alarm appear in the date time indicator? [09:33] nik90_: no... nothing in there [09:33] which probably explains why they're not ringing [09:33] yeah [09:34] can you create an alarm to ring in the next 5 minutes and see if it appears in the indicator? [09:34] ack [09:35] uuh. clock app crashed switching to the alarm tab [09:35] were you trying to create a new alarm? [09:35] or editing an existing one? [09:35] i was on the stop watch tab, wanted to switch to the alarms tab -> boom [09:35] now it works [09:36] nik90_: ack. set an alarm to go off in 5 mins, it appeard in the indicators [09:38] hmm... I have a suspicion... let me wait until this one went off and I'll play around a bit more [09:38] mzanetti: there is one case where the alarm might not ring, When you create a single type alarm and it rings. After which if you are try editing that alarm to set a new time, that will fail [09:39] * nik90_ checks for that [09:39] that sounds like I could have fallen for a couple of times already [09:40] the other thing is, if you change the recurrance, I have the feeling that it changes it to the day last week or so [09:40] ringing now / [09:40] \o/ [09:41] ringtone is very stuttery though [09:41] like pauses for 3 seconds, plays half a sec, pauses again for 3 etc [09:42] that seems to be related to the screen being locked [09:42] turning the screen on makes it play smoothly, turning it off again makes it bad again [09:49] mzanetti: I don't notice the stuttery ringtone anymore in the devel-proposed. We had that issue a couple of images before since the system-settings was hogging a lot of CPU. [09:50] mzanetti: we have another bug in place where the alarm keeps ringing even after you dismiss it :) [09:50] nik90_: ok... [09:51] dpm, popey: https://bugs.launchpad.net/reminders-app/+bug/1340635 and https://bugs.launchpad.net/reminders-app/+bug/1340640 and https://bugs.launchpad.net/reminders-app/+bug/1340644 [09:51] Ubuntu bug 1340635 in Ubuntu Reminders app "Right workflow wrong wording on error on Initlial run of the app" [Undecided,New] [09:51] Ubuntu bug 1340640 in Ubuntu Reminders app "No way to Edit a notebook name" [Undecided,New] [09:51] Ubuntu bug 1340644 in Ubuntu Reminders app "Editing a note defaults to the First Notebook instead of the notebook it was edited in" [Undecided,New] [09:51] thanks davmor2 [10:01] nik90_: for https://code.launchpad.net/~nik90/ubuntu-ui-toolkit/improve-header-api-docs/+merge/226113 can you do a bzr commit -m "empty commit" --unchanged && bzr push, to see what happens? [10:01] t1mp: sure. [10:01] nik90_: thanks [10:50] huh? what happened to the calculator? === chihchun is now known as chihchun_afk [11:10] kalikiana: up for a review? https://code.launchpad.net/~tpeeters/ubuntu-ui-toolkit/panelHeight/+merge/225493 [11:10] kalikiana: ignore the bad jenkins results for now, its broken [11:11] tell me about it, I want to land stuff :-( [11:13] t1mp: can we have a test for the position? === MacSlow is now known as MacSlow|lunch [11:16] kalikiana: a test that verifies the new y-coordinate after changing height? [11:16] kalikiana: yeah, makes sense, I'll work on that [11:19] cool [11:26] popey, dpm: I created another bug for adding new notes to notebooks, it is pretty much the same as the bug 1340644 bug but it is a slightly different workflow so created a new one do you want me to mention the other bug in both? [11:26] bug 1340644 in Ubuntu Reminders app "Editing a note defaults to the First Notebook instead of the notebook it was edited in" [Undecided,New] https://launchpad.net/bugs/1340644 === MacSlow|lunch is now known as MacSlow [12:18] t1mp: the empty commit for https://code.launchpad.net/~nik90/ubuntu-ui-toolkit/improve-header-api-docs/+merge/226113 didn't trigger jenkins [12:19] zsombi: hey, Good Afternoon, you are back :) [12:19] t1mp: ok, I just saw the jenkins message :P [12:20] nik90_: thanks, I'm back for few days, then will be away again [12:21] nik90_: wow... weird failure [12:21] hmm it ends with NoSuchProcess: no process found with pid 5311 [12:21] zsombi: ah ok [12:21] nik90_: I'll happrove it anyway, see if it lands [12:21] t1mp: hmm [12:22] t1mp: ok..if it fails again, we can get the help of elopio === _salem is now known as salem_ [12:38] kalikiana: I re-happroved noArchErrors and englishButtons [12:39] t1mp: thanks [12:43] zsombi: added the test fixes https://code.launchpad.net/~ubuntu-sdk-team/ubuntu-ui-toolkit/blueCursor/+merge/225304 [12:45] kalikiana: I was thinking, shouldn't we set the palette.foreground with alpha=0.2 instead of having the magic in the text inputs... [12:49] kalikiana: you got comments [12:51] zsombi: "TextField changes"? [12:52] kalikiana: you had color changes in textarea, shouldn't the same be done in textfield as well? [12:53] hmm I thought I did, checking [12:54] okay seems it's not in there [13:02] zsombi: if we want to have alpha in the palette there's a problem: we can't use the hex notation we agreed on [13:02] kalikiana: why can't you use hex notation? [13:03] I'm not sure if in general it's expected to have alpha in the colors [13:03] t1mp: becasue it doesn't exist [13:03] kalikiana: you can, you convert 0.2 into hex :) [13:03] zsombi: and writing it how? there's no standard for it afair [13:03] kalikiana: http://qt-project.org/doc/qt-4.8/qml-color.html [13:03] kalikiana: alpha is a value 0..255, and in Qt.rgba is (0..1) [13:04] kalikiana: #AARRGGBB [13:04] #AARRGGBB [13:04] :) [13:04] oh [13:04] I was faster :P [13:04] nice [13:04] zsombi: I started typing that 5 minutes ago ;) but on this keyboard, there is a search-key instead of caps-lock.. and it works as super-key :s [13:05] t1mp: yeah, excuses.... [13:06] t1mp: +1000 I love that the chrome book actually has a modern layout instead of following the stone age [13:06] few laptops do [13:06] kalikiana: caps lock is handy some times [13:06] it's not, dude, nobody uses it [13:06] I USE IT WHEN I AM UPSET! ;) [13:06] kalikiana: only old farts.... as me :D [13:07] kalikiana: but okay, it is not an essential key [13:07] kalikiana: and it misses PgUp and PgDn keys.. which is not so handy [13:07] kalikiana: other than that the keyboard layout is fine :) [13:08] t1mp: who needs those… :-P [13:08] kalikiana: I need it to scroll back on irc in irssi [13:08] kalikiana: ah, home and end buttons are also missing.. [13:08] t1mp: use a wheel :-D [13:08] kalikiana: I need those to go to the beginning/end of a line that I'm editing [13:09] what about ctrl+left/right [13:09] kalikiana: that only moves left/right one word [13:09] on mac its Fn+left/right [13:10] kalikiana: one more thing to that MR: shouldn't actually we add the blue color to the UbuntuColors as well? [13:10] zsombi: that was done in tim's mr [13:10] kalikiana: then you would only need to use Qt.rgba() on the UbuntuColors.blue [13:10] actually lemme check if I can use the colors now [13:10] since it was merged [13:11] zsombi: it has readonly property color blue: "#1ab6ef" [13:11] t1mp: yes, I see it now, it slipped my eyes before [13:12] kalikiana: so, if you use that, then you can use the rgba() function and set the alpha you used in the TextArea [13:12] kalikiana: UbuntuColors.DarkGrey is also there [13:12] kalikiana: and #888888 is LightGrey [13:12] seems like blue isn't [13:13] err *blue/lightGrey/darkGrey (first letter small) [13:13] kalikiana: it is, but it didn't merge to staging yet [13:14] kalikiana: you'd need this as a pre https://code.launchpad.net/~tpeeters/ubuntu-ui-toolkit/NewColors/+merge/225230 [13:14] t1mp: aaaarg still approved :-( [13:14] so annoying [13:14] I don't really want pre at this point… I want to get rid of branches [13:15] if you add a pre it should automatically land after the pre landed [13:15] kalikiana: there is a section in the api docs for UbuntuColor on developer.ubuntu.com [13:15] and you can use the color names instead of re-defining them then [13:15] t1mp: "should" in real life means it will randomly fail [13:15] but what the heck I'll rebase on that [13:16] davmor2: new colors will land soon [13:16] * kalikiana just a bit annoyed at this point with baby sitting more than anything else [13:17] ohhh green by any chance? [13:17] seeing lots of green recently [13:17] davmor2: yes, also green :) see https://code.launchpad.net/~tpeeters/ubuntu-ui-toolkit/NewColors/+merge/225230 [13:18] davmor2: here is a short list of new colors https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/1335826 [13:18] Ubuntu bug 1335826 in Ubuntu UI Toolkit "Update UbuntuColors with new colors" [High,In progress] [13:19] it takes too much time now in CI to get things landed.... [13:26] zsombi: btw with regard to "old fart" http://xkcd.com/1393/ [13:30] http://xkcd.com/303/ %s/compiling/landing/g [13:30] kalikiana: ^ [13:33] zsombi: https://code.launchpad.net/~ubuntu-sdk-team/ubuntu-ui-toolkit/blueCursor/+merge/226457 [13:33] t1mp: :-D [13:34] kalikiana: will check it asap [13:49] seb128, or Laney or jgdx: can you please review https://code.launchpad.net/~elopio/ubuntu-system-settings/refactor_about_tests/+merge/225425 ? [13:50] elopio, sure [13:50] thanks! [13:51] elopio, oh, I just looked at that, looks fine from me (though I didn't look too much into details because I don't know autopilot that well, but I didn't see anything obvious wrong and jenkins seems happy) [13:51] so +1 from me [13:51] let's see jgdx says [13:51] thanks seb128. [13:51] elopio, might have to merge in https://code.launchpad.net/~jonas-drange/ubuntu-system-settings/1211804-allow-technology-preference/+merge/226125 [13:52] elopio, jgdx: not sure I see the point of those license boilerplate changes [13:52] jgdx: looks like you are right. I'll make it a prerequisite. [13:53] seb128: the license used to say it was LGPL in some files, GPL in some others. [13:54] elopio, that's only the __init__.py one [13:54] which is fine fixing [13:54] the other ones looks like pointless [13:59] seb128: the other ones are to use the same template. If you are missing one of the GPL header paragraphs it can cause you legal problems. [13:59] it's unlikely, and a minor problem for sure [14:00] but on so many projects we have found weird things on the headers that we are trying to use the same template everywhere. [14:00] seb128: I can revert that on this branch, and propose it on a different one to discuss only that if you prefer. [14:04] elopio, don't bother, but I'm going to put your changes on hold because they might conflict with some other work due to that [14:04] so your call [14:04] if you want to see that in the next landing better to rever the changes out of the init [14:06] you are convincing :) [14:42] elopio, I'm seeing this on 28 tests http://pastebin.ubuntu.com/7780470/ [14:43] I'm most likely lacking something [14:44] elopio, I have to go away for some hours. Be back later. [14:51] jgdx: I'll take a look. I think that you must run the tests with autopilot3 after my previous branch. === chihchun_afk is now known as chihchun === chihchun is now known as chihchun_afk [16:28] popey: u having fun with the back and forth email with mhall119 :P ? [16:29] haha [17:26] t1mp, are you around to look at some strange behaviour we are having with the searching? === renato is now known as Guest85133 [17:42] ahayzen: yes [17:42] :) [17:42] t1mp, this is our WIP mp... https://code.launchpad.net/~andrew-hayzen/music-app/add-sdk-search-support/+merge/226045 [17:43] t1mp, the behaviour we are seeing is... === ken_ is now known as kenvandine [17:43] t1mp, if you start searching on one tab...then cancel the search... move to another tab and start searching...it *sometimes* (usually after repeating enough times)... doesn't actually search and ur result from the previous tab is sometimes there? [17:44] t1mp, furthermore sometimes u can see it flicker between the tabs as you press the search button [17:45] t1mp, is this todo with the way i've done our MusicPage and the implementation of the searching... or is this an SDK issue? [17:46] * t1mp reading the MR [17:46] ahayzen: what do you see flicker between tabs? [17:46] t1mp, i see the title of the previous tab appear then switch back to the current... then the text field appears [17:47] t1mp, that happens more rarely than the issue (maybe because it happens so fast) === Guest85133 is now known as renato___ [17:47] t1mp, but we suspect somehow you end up on tab A but actually searching on tab B as the text field sometimes has what you had when you were searching in tab B and would explain why it appears like nothing is happening [17:48] seeing the title of the previous tab is weird [17:49] t1mp, yeah thats what i thought [17:49] hmmm [17:49] [ 1%] Merging translations into com.ubuntu.music_music.desktop [17:49] /bin/sh: 1: INTLTOOL_MERGE-NOTFOUND: not found [17:49] I have a new laptop, so probably I still need to install some dependencies [17:49] errr [17:49] ah i had that [17:50] t1mp, try installing intltool [17:53] that helps, but I still get errors when starting the app: [17:53] tim@C720:~/dev/add-sdk-search-support$ qmlscene music-app.qml [17:53] file:///home/tim/dev/add-sdk-search-support/music-app.qml:832 Type MusicStart unavailable [17:53] file:///home/tim/dev/add-sdk-search-support/MusicStart.qml:235 GenresModel is not a type [17:53] woah [17:54] t1mp, what are you runing this on? [17:54] on my laptop [17:54] looks like your missing mediascanner2 qmlplugin [17:54] t1mp, ensure you have all of our depends in here http://bazaar.launchpad.net/~music-app-dev/music-app/trunk/view/head:/debian/control [17:55] t1mp, also note i've been doing this on device (utopic with latest devel-proposed image) as my laptop is trusty [17:57] seems like I have all the dependencies [17:57] I am also running trusty [17:57] it won't work on trusty? [17:58] t1mp, ah yes mediascanner2 could be interesting on trusty... and sdk doesn't have search on trusty for me? [17:58] ...but that is a strange error your ending up with... [17:58] t1mp, oh do u have the coreapps ppa? [17:58] t1mp, yeah thats what it is...coreapps ppa has the new ms2 which includes genremodel :) [17:59] t1mp, this one https://launchpad.net/~ubuntu-touch-coreapps-drivers/+archive/ubuntu/daily [18:00] I have a mediascanner2.0, but no qtdeclarative5 mediascanner package.. [18:00] t1mp, you need qtdeclarative5-ubuntu-mediascanner0.1 to be installed [18:01] I have that one [18:01] maybe I need the version from the ppa to get GenresModel [18:01] t1mp, yeah you need to have a version after ~20 may or something [18:02] coreapps ppa has 0.101+14.10.20140627 [18:02] t1mp, however if ur on trusty i still think it won't work [18:02] trusty has 0.100+14.04.20140403-0ubuntu1 [18:03] t1mp, i get 'PageHeadState is not a type' on my machine [18:03] I'm using a spare laptop now with trusty.. my main laptop has utopic, but I had to send it for repair, I'll wait for that one to come back [18:03] ahayzen: which version of UITK? [18:03] t1mp, and we get this from ms2 'pure virtual method called [18:03] terminate called without an active exception' [18:03] ^^ which has been fixed in qt5.3 [18:04] ahayzen: did you import Ubuntu.Components 1.1 for PageHeadState? [18:04] yep i changed all of them to 1.1 as u can see in the mp [18:05] t1mp, qtdeclarative5-ubuntu-ui-toolkit-plugin: [18:05] Installed: 0.1.46+14.10.20140520-0ubuntu1~0trusty2 [18:06] t1mp, that is coming from our ppa... hmm so do we just need the package updating again? ... and will it work with qt5.2 we were under the impression things will start breaking as trusty doesn't have qt5.3 [18:06] true, that's tricky [18:06] t1mp, but even if that works u won't be able to test because mediascanner2 will explode with its bug when you try search etc [18:07] newer UITK works on trusty and with qt 5.2 [18:08] I have the same problem with old UITK package [18:08] let me compile an UITK from bzr.. [18:08] t1mp, this is the mediascanner2 bug for reference https://bugs.launchpad.net/mediascanner2/+bug/1334843 [18:08] Ubuntu bug 1334843 in mediascanner2 "Mediascanner2 crash on model change with header in listview" [Undecided,New] [18:09] t1mp, it is failing because u have an old mediascanner...but if u update it is pretty broken on trusty :/ so ur best off using a device to test [18:11] ahayzen: I replaced the model: SortFilterModel { } by model: 10 to test [18:11] hah [18:11] also doens't work.. but I can see that the PageHeadState works with a more recent UITK [18:12] what happens then i suspect something bad [18:12] oh like the rowCount errors will be everywhere and there was anotehr one... [18:12] so if you bzr branch lp:ubuntu-ui-toolkit && cd ubuntu-ui-toolkit && qmake && make && ./export_modules_dir.sh, then you can run your app with the newer UITK [18:12] well.. you could if there was a working mediascanner for trusty [18:12] hah [18:12] t1mp, i've been testing on my device [18:14] t1mp, you should just be able to run in the branches dir to push the app to device $ click-buddy --dir . --provision [18:15] (assuming u have click-buddy installed ;) ) [18:15] probably not, I just installed ubuntu on this laptop a few hours ago [18:16] hehe [18:18] I have to leave now [18:18] ok no worries [18:18] so the flickering of the previous title is weird.. do you think you can reproduce that with a small test program without dependencies? [18:18] i'll see if i can figure out if it is us or not and yeah if i think it isn't us...i'll try and build a test app [18:18] t1mp, thanks for ur help so far [18:19] and the wrong search results is also strange. The contents basically only sets the textfield in the header, doesn't deal with the results [18:19] I'm not ruling out UITK, it is all new stuff so not many people used it so far [18:19] t1mp, it is like it is searching on the other tab [18:19] t1mp, (the one that flickered) [18:20] that other tab title should only become visible when that tab is active [18:20] maybe it quickly switches tabs before going to search mode? [18:20] t1mp, yeah something funky going on here lol [18:21] t1mp, i'll continue playing about see if i can narrow it down a bit [18:21] ahayzen: in the MR I only see one PageHeadState, where do you have the other pages where you can search? [18:22] t1mp, that is in our generic MusicPage {} [18:22] t1mp, all of our pages are based of MusicPage which is a Page {} itself [18:23] t1mp, but searching will appear on the Artists/Albums/Tracks tabs (pages) [18:24] ahayzen: I see now [18:24] ahayzen: can you check that tabs.selectedTabIndex doesn't change when you get the flickering? [18:25] t1mp, yep i'll add tracing to that and the page states and see if i can figure out anything [18:26] t1mp, anyway i gotta go in a minute as well so i'll investigate further tonight [18:27] hmm [18:27] I see you have several Tabs/Page/PageStack instances defined directly inside the MainView [18:27] perhaps the MainView gets problems determining which is the active page [18:28] if you move those inside the PageStack you avoid that [18:28] t1mp, hmmm but they are all visible: false ... and we should have one pageStack... [18:28] t1mp, oh so the hidden ones should be inside the pageStack? [18:29] t1mp, i gotta go i'll try moving things around later thanks for the pointers o/ [18:29] yes, could be related to that [18:30] they are not visible, but the MainView has only one page listed as activePage internally, that's not the same as visible [18:30] I gotta go too [18:30] have a nice weekend :) [18:30] t1mp, ok thanks.... you to o/ [18:51] DanChapman: btw, http://bazaar.launchpad.net/~mhall119/ureadit/trunk/view/head:/models/CommentListModel.qml shows what I was talking about earlier about flattening a comment thread [18:52] mhall119, heh i was half way through writing a message to you about that :-D how weird. Thanks i'll take a look, i can't download the reddit app for some reason to see it in action [18:53] DanChapman: :) [18:53] DanChapman: how are you trying to download it? [18:53] from the Ubuntu Store scope on a device? [18:55] through the store, yes. Getting a rather generic "error downloading or installing" message. It happens straight after tapping install so i presume it's the download failing [18:57] beuno: ^^ that's like the third person I've heard say they can't download apps from the store, any idea what's going on? [19:10] mhall119: beuno is not around today; afaict, everything seems ok (there were some firewall issues yesterday that could have caused some problems, but that should be all fixed now) [19:11] thanks matiasb [19:11] mhall119: np, if you get any more details, or cases, let me know [20:27] balloons, ping [20:37] t1mp, if your there i just added tracing http://pastebin.ubuntu.com/7781949/ ... if you look at the last few lines you can see artists page has its state changed to 'search' but the textfield appears to be from the songs page! [20:38] ahayzen, poing [20:38] balloons, i've been thinking about doing refactor/cleanup of our ap tests at somepoint in the near future.... [20:39] balloons, and was wondering if our tests should be python3 rather than python2? is that the long term goal? [20:39] balloons, as if me or victor did a cleanup it could be a good opportunity to move [20:49] ahayzen, yes, the tests should be py3 [20:49] balloons, ok cool [20:51] balloons, i may do that over the new week or so if i get stuck in qml stuff :) ... as it is getting annoying having all our methods in a random order with strange namings (songsPage vs songsTab?) ... and i suspect there is some stale code in there as well [20:51] ahayzen, I'd recommend looking at http://developer.ubuntu.com/apps/platform/guides/acceptance-testing-using-the-page-object-model/ [20:52] and yes, you likely could sync and cleanup object names and the qml and tests at the same time :-) [20:52] balloons, was it the clock-app ap test that where split into different classes/modules per tab? [20:52] balloons, thanks for the link :) [21:00] ahayzen, clock was the first, but others show it as well [21:00] generally we write anything new in it [21:00] balloons, cool [21:00] reminders is done the same way [21:15] balloons, oh yeah and while looking at the system-apps i saw they have QML tests? are they beneficial in any way or should all of ours be python/autopilot [21:16] ahayzen, you should consider qml tests for your custom components [21:16] balloons, what is the purpose of them? just to test a component rather than a use case/user story? [21:21] * nik90_ is proud to hear clock do it first ;) [21:21] ahayzen, it's different tech. I would recommend using them for any low level tests you might want to do as well [21:21] nik90_, :-) [21:22] balloons, ok i may have a look at those after any refactoring is done [21:23] balloons: ping [21:24] gerlowskija, pong [21:24] ahayzen, definitely.. feel free to ping with specifics [21:25] balloons, cool thanks [21:25] balloons: I saw you commented on this MP: https://code.launchpad.net/~gerlowskija/ubuntu-calendar-app/revised-fix-for-bug1334883/+merge/226049. Is there anything that I can do to help take a look at it? [21:26] gerlowskija, ohh my did that not land? [21:26] * balloons looks [21:26] no, it's still getting UNSTABLE on one of the test runs [21:27] I see http://91.189.93.70:8080/job/generic-mediumtests-utopic/974/artifact/calendar_app.tests.test_new_event.NewEventTestCase.test_delete_event_must_remove_it_from_day_view%20%28with%20mouse%29.ogv [21:31] stupid realization, but I didn't realize the autopilot tests were screen recorded. [21:31] gerlowskija, no worries! yea, it's in the test output [21:31] thats awesome. Though the failure isn't. [21:32] anyways, yea, let me grab and try locally. If it works locally, then it gets a bit harder but not impossible [21:34] ok cool. It looks like the test ends (terminates/crashes?) early. The test should go on to delete the event. [21:35] gerlowskija, it seems it just tries to find the event and then ends [21:35] perhaps using an eventually on the assert would be useful [21:36] * balloons runs [21:36] Hmm.. based on the test name, and this line: [21:36] day_view = day_view.delete_event(event.name, len(original_events) > 0) [21:37] I would expect it to go through deleting the event, but I didn't write the test, so that's just my impression [21:37] ok, it does run on the desktop :-) [21:37] gerlowskija, the source looks weird.. [21:38] see line 68 in test_new_event? def get_new_events()? [21:38] yep [21:39] mm.. not part of your mp.. weird it's in trunk I guess? [21:39] Yeah, I didn't change anything in the autopilot tests other than removing a skip on the last test [21:39] I'm making some changes.. [21:40] gerlowskija, http://paste.ubuntu.com/7782180/ [21:41] I like_method for private stuff.. but otherwise, just moving it out [21:41] now as for the logic.. [21:42] I think we can fix that too, since you are fixing https://bugs.launchpad.net/ubuntu-calendar-app/+bug/1334833 [21:42] Ubuntu bug 1334833 in Ubuntu Calendar App "After adding an event, the TimelineBase on DayView duplicates the old EventBubbles" [High,Confirmed] [21:43] I *think/hope* I'm fixing 1334833 haha [21:43] gerlowskija, well let's change the logic and see eh> [21:43] I hope so too.. so many events in the stack! [21:46] ok. I'll re-push with the _get_new_events() change you had, and see if that helps. Thanks as always balloons: [21:47] gerlowskija, one sec [21:47] sure [21:47] I missed adding self as the arg for def _get_new_events(self): [21:47] and there might be more things :-) [21:48] I'm guessing elopio actually set it up this way.. but I do wonder why [21:51] gerlowskija, I think I'll just push something.. the diff is getting bif [21:52] Haha, ok then. I'll be interested to see what the final changes are! [21:53] Anything I should do then? I feel like I asked what I could do to help but you ended up getting stuck with all the work yourself ;-p [21:55] no worries [21:55] I think it's good now [21:59] gerlowskija, lp:~nskaggs/ubuntu-calendar-app/filter_dupes [22:03] Cool, looks like it works for me on my desktop (though it was originally too) [22:04] balloons: So the plan is to delete my existing branch, link your newer one to the 2 bug reports, and propose for merging? [22:04] gerlowskija, yep, let me know when you push and I'll sic jenkins on it === salem_ is now known as _salem [22:04] gerlowskija, no, I would just merge my branch into yours and then push a new rev [22:04] same mp and everything [22:05] Ok. My bzr skills are a little lacking...off to the man page! [22:07] gerlowskija, :-) [22:07] haha [22:08] bzr merge lp:~nskaggs/ubuntu-calendar-app/filter_dupes [22:08]