[00:19] jelmer: poolie: fwiw dealing with tarmac failures is ~ the same opaqueness as pqm, from my observations of nontrivial projects that have migrated :) [00:20] :/ [00:21] don't know what you're smiling about [00:21] ;) [00:23] habit [00:23] or something [01:17] what does conflicting tags mean on 'bzr pull' ? [01:18] thumper: both sides have a tag named 'FOO', but they disagree on which revid FOO refers to. [01:18] spiv: so how can I say 'pull and use their tags' ? [01:18] --overwrite [01:19] hmm... [01:19] ok [01:19] there is also bug 681792 [01:19] Launchpad bug 681792 in Bazaar "wishlist: bzr pull --overwrite-tags" [Medium,In progress] https://launchpad.net/bugs/681792 [01:19] (Or delete the offending tag(s) locally and pull again) [01:19] jelmer: thanks [01:20] jelmer: do you understand the package recipes? robert_ancell was asking me about them [01:20] I'm trying again to get the logs of what goes wrong... [01:21] simple question: does http://paste.ubuntu.com/752089/ look correct and are the branches in the correct format? [01:22] I tried to use lp:ubuntu/simple-scan as a packaging branch initially but I don't think it has the correct relationship to lp:simple-scan to work (it had merge conflicts) [01:22] robert_ancell: yes, though I don't think that version of bzr-builder can be entered on launchpad yet [01:22] jelmer, yes, I subscribed to that bug [01:23] robert_ancell: the version looks a bit odd, though with {date} as the debian revision [01:23] Now it is failing with 'dpkg-buildpackage: error: version number does not start with digit' because it pulls out the wrong version number (I was using simple-scan-VERSION tags but I'm now using just VERSION). Any way to delete the old tags on the server? [01:23] robert_ancell: it's fine if the branches aren't related, so long as they don't have overlapping files [01:24] robert_ancell: bzr tag -d lp:simple-scan --delete TAGNAME [01:25] jelmer, yes, been playing around with the version number, needs some work [01:27] jelmer, I have to build with --allow-fallback-to-native - will that work on the server? [01:27] robert_ancell: yes, launchpad has --allow-fallback-to-native enabled by default [01:28] robert_ancell: alternatively, you could tag the upstream version with 'upstream-X.Y', and it would create an orig tarball for you [01:28] or change the package to be native [01:29] ok [01:31] jelmer, any idea when 0.4 will work? Or is there another method of getting the version number in 0.3 I can use? [01:39] robert_ancell: {debupstream-base} might do what you need to [01:39] *too [01:40] jelmer, the issue is that requires me to update debian/changelog right? [01:41] robert_ancell: yes, but only for upstream releases [01:41] robert_ancell: in bzr we e.g. use {debupstream-base}bzr{revno}~daily{revno:packaging} for most packages [01:42] right. For most of the packages I want to do I am upstream and I want to set it up and then forget about it [01:42] robert_ancell: that works for us too, because we end up updating the debian/changelog version when we do a release [01:44] robert_ancell: and then do a matching upload to debian/ubuntu [01:44] jelmer, I know I'll forget to do it :) [01:44] robert_ancell: you're not uploading to ubuntu ? :-) [01:45] (we use the same branch for ubuntu packaging as for the daily PPA) [01:45] jelmer, no, these are daily builds to a PPA for upstream testers [01:46] the Ubuntu packaging has some patches, merges from Debian and may not be running the latest version [01:46] robert_ancell: in that case you'd probably indeed want to wait for the 0.4 support [02:03] jelmer, thanks for the help [04:54] so apparently if you call accept from one thread and connect from another, python can sometimes deadlock in futex() [04:54] nice [05:00] on different sockets? [05:08] on the two sides of the same socketpair [05:08] simulating a server in process [05:09] interesting [05:09] ie this fixes it http://bazaar.launchpad.net/~mbp/bzr/2.5-client-reconnect-819604/revision/6209#bzrlib/tests/test_bundle.py [05:09] "fixes" [05:10] the loop doesn't fix it, only changing to a nonblocking select [05:10] possibly accept isn't giving up the GIL ? [05:10] seems likely [05:12] i guess i should see if i can reproduce it and file a bug [05:12] it's kind of a stupid thing to do imo [05:13] It pretty clearly releases the GIL in 2.7.2: http://hg.python.org/cpython/file/8527427914a2/Modules/socketmodule.c#l1656 [05:14] hm [05:15] In the past all our sockets+threads deadlocks have turned out to be bugs in our logic, not cpython [05:15] :) [05:15] that does seem likely [05:15] but, strace shows one side in accept and one in futex [05:15] ... [05:16] (Although arguably perhaps because the APIs offered aren't as convenient/safe as one might hope?) [05:16] the futex not being released by getting eintr from accept [05:16] when i say it's stupid i mean i think running the server inprocess is a bit likely to fail [05:16] anyhwo [05:17] Well, that shows that one side is in accept, and the other side is stuck in a lock — quite possibly a lock owned by pure Python code (e.g. a threading.Mutex in a Queue.Queue) [05:17] that is possible [05:17] It would be extremely helpful if strace could magically distinguish between "Python VM internal lock" and "Lock exposed to Python application code" [05:18] pytrace is pretty good at that [05:18] (gdb + py* macros I mean) [05:18] i was excited for a second there [05:18] i'll try to hit it again and use gdb [05:38] it's inside lock_PyThread_acquire_lock [05:40] ah inside threading.join? [05:40] poolie: doesn't sound like a vm bug :P [05:41] :) [05:41] ah :) [05:41] apparently closing a socket does not interrupt threads that are accepting on that socket [05:42] so that explains why alternating selecting and accepting avoids the problem [05:44] That sounds familiar. [05:44] yeah [07:01] spiv, so basically the patch is reasonable but the explanation is wrong [07:31] hi all ! [07:31] hi there vila [07:31] poolie: hmm, what patch and explanation are you talking about ? [07:31] i think i understand why that was hanging [07:32] great ! I'm all ears :) [07:33] https://code.launchpad.net/~mbp/bzr/2.5-client-reconnect-819604 [07:33] oops no mp [07:33] I can review that locally, nw [07:34] no apparently that's not everything [07:38] poolie: 'accept from one thread and connect from another' leading to hang rings a 'ipv6' bell [07:38] where one side get an ipv4 socket but the other got an ipv6 one [07:38] may not apply but encountered several times [07:39] pretty sure that's not it here [07:39] also, 'not being released by getting eintr from accept', *only* the main thread get interrupts [07:44] poolie: which test(s) is/are hanging ? [07:45] test_bundle test_smart_server_connection_reset [07:45] at least [07:46] poolie: will it help to focus on getting an external smart server running first and only then look at those failures ? [07:47] mm [07:47] i think no, really [07:47] although i'm down on running the server in process, in this case the bug could have happened the same way externally [07:47] * vila get a weird 'table turned' feeling [07:47] genuine surprise, no smiley there [07:50] poolie: I only get one failure with your branch and it looks genuine: bzrlib.tests.test_smart_request.TestSmartRequest.test_all_registered_requests_are_safety_qualified [07:51] we seem to have a regression that selftest does not exit 1 on failure [07:51] that might be a known bug [07:53] vila, right that seems genuinely out of date with jelmer's changes [07:55] vila, you ran everything and that was the only one? [07:55] yes [07:55] twice [07:56] ha, spoke too soon, the second is hanging at 26507 in 4m50s, 1 failed (hanging test unknown though) [07:56] i wonder if we couldn't have a test fixture that sets an alarm [07:57] which one? [07:58] ok, got it by lurking below /tmp: bzrlib.tests.test_bundle.TestReadMergeableFromUrl.test_smart_server_connection_reset [08:08] that's the one i'm fixing [08:13] that's the one i'm fixing [08:16] vila, i'm adding a config option for a timeout [08:18] for the select ? [08:18] globally [08:18] :/ [08:18] how do i actually get a value from the command line? [08:18] for the test ? [08:20] nm [08:20] poolie: from a config stack ? conf.get('mytimeout') but remember those are reset for tests, we may want something like -E (used for debug flags) but for test options [08:21] i think a regular option is ok as long as it's read early enough [08:21] possibly we need a way inside tests to get the real config stack [08:23] if you get the option before the test is started, you're fine [08:23] s/started/create/ [08:23] d [08:23] yep, it's ok now [08:23] i wonder if there should be a timeout by default [08:23] perhapsonly from make check [08:26] vila does babune run make check or just selftest directly? [08:26] selftest directly [08:27] why does the test name mentions smart server when no smart server is involved there ? (Or do I misread the test?) [08:27] ha, silly, bzr: [08:28] i wonder if there should be a timeout by default [08:28] a timeout for what ? All socket based requests from the clients ? [08:29] for tests [08:29] well https://code.launchpad.net/~mbp/bzr/test-timeout/+merge/83559 [08:33] hmm, lp downtime [08:34] Nearly back. [08:34] back [08:34] Nope. [08:34] err, weird [08:34] heh [08:34] There we are. [08:36] the importer said: down, down... back.. down, down... back [08:37] vila: Ah, yeah. [08:37] It went down for 35 seconds, came back because it failed, then we retried. [08:37] ooh, thanks [08:38] But it was down for the second time when you mentioned it here. [08:38] yeah, I lag :) [08:39] but the importer did cope well, not fallout failures [08:50] poolie: reviewed, BB:tweak [08:52] thanks [08:52] got to go [08:52] back later maybe [09:06] morning all [09:13] mgz: _o/ [09:34] * jelmer waves [09:37] hey jelmer [09:56] what's the right way to delete a branch? [09:59] m1sc: delete the directory. there's also `bzr rmbranch` [10:01] mgz: ok. it's a shared repo - the data is garbage collected automatically? [10:02] nope, but it's generally insignificant. if not... I don't think we have a better way than making a new shared repo, mirroring all the branches you care about, then replacing the old repo. [10:03] mgz: bzr rmbranch gives me "Not a branch.." oO special syntax required? [10:04] when `bzr info` on the same path tells you it's a branch? [10:04] * mgz just deletes the directories, with shared repos there's not much that can go wrong there. [10:05] mgz: nope, it doesn't. must be my fault, works for other branches.. thank you. === zyga is now known as zyga-brb [11:07] hmm, it seems that the hpss-call-count test for 'bzr verify-signatures' is spuriously failing [11:08] as in, some runs gives a different value and some runs doesn't? [11:08] rather than just the value being wrong, which wouldn't need much comment :) [11:08] jelmer: yup, was about to mention it, could it be that some variations happens because readv groups differently depending on the compression results ? [11:09] jelmer: in other words: if both 22 and 21 can occur, you may just relax the assertion there to accept both [11:11] vila: yeah, indeed [11:11] indeed as in related to readv grouping ? [11:13] yes, and also indeed: we should just be accepting both [11:13] hehe, double indeed then ;) === zyga-brb is now known as zyga [11:19] jelmer: yup, spurious, I got 2 failures out of 3 runs locally [11:20] vil: https://code.launchpad.net/~jelmer/bzr/verify-signatures-spurious-hpss-call-counts/+merge/83583 [11:20] jelmer: yes, that sort of thing is another reason to remove VFS calls: to make the call counts more deterministic :) [11:21] hello everyone [11:21] am i mistaken (doing something very wrong) or does bzr ignore *.o files by default? [11:22] hi deni [11:22] and is there a way to disable that behavior? [11:22] deni: it does, see ~/.bazaar/ignore [11:22] spiv: :) [11:25] jelmer: oh ok, tnx...didn't realize it [11:27] deni: versioning build artefacts is a very bad idea, what's the reason behind wanting to commit a .o file? [11:28] jelmer: approved [11:29] vila: thanks! [11:35] vila: are you going to post a followup branch to 2.5-client-reconnect-819604 ? [11:36] * jelmer bumps his branch back to needs-review [11:36] dunno :-/ I see your vote *after* posting my 2 comments and refreshing the page [11:37] vila: I posted that vote before you commented [11:37] yup, I realizeD that [11:37] vila: so, with your comments in mind, I think it would be nice to improve the branch [11:38] ok, I'll submit one then [11:48] mgz: i know i know....it's a whole tree of bad ideas that lead to this. :D anyway, deployment reasons [11:50] jelmer: your branch still fails test_smart_request.TestSmartRequest.test_all_registered_requests_are_safety_qualified [11:50] jelmer: with AssertionError: These requests were not categorized as safe/unsafe to retry: ['Repository.get_stream_1.19', 'Repository.insert_stream_1.19'] [11:51] jelmer: which is weird as there were more of them earlier this morning (but I haven't precisely tracked which version I used vs what you fixed since then) [11:52] vila: r6124 ? [11:52] vila: err, r6214 ? [11:52] 6215 [11:52] but the last one is mine [11:52] test_smart_request.TestSmartRequest.test_all_registered_requests_are_safety_qualified passes here [11:53] and get_stream_1.19/insert_stream_1.19 do indeed have a categorizatin [11:53] urgh, it just passed 8-/ [11:54] trying again, that was woth --parallel=fork [11:55] (the failure was for a full run with --parallel that is) [11:56] jelmer: hmm, I've pushed my fix on lp:~vila/bzr/819604-fix-test-bundle [11:57] it may be easier for all involved if you just merge it into your proposal rather than me using yours as a pre-requisite [11:57] safety_qualified failed again [11:58] isolation ? [11:58] lazy loading ? [12:00] I want the result of `bzr branch -rA t t_A; bzr branch -rB t t_B; cd t_A; bzr missing --include-merges ../t_B`. A is a parent of B. Can I do it without needing to create the two branches t_A and t_B? [12:00] `bzr log -n0 -rA..B` does not work when A is not the primary (main-line) parent of B [12:00] `bzr missing` has --my-revision and --revision arguments, but again it seems not to work for non-mainline parents (the docs seem unhelpful for this) [12:03] knielsen: doesn't 'bzr log -n0 -rA..B --exclude-common-ancestry' work ? [12:03] vila: with the same requests? [12:03] jelmer: yes [12:03] * knielsen checking [12:08] vila: pulled into lp:~bzr/bzr/2.5-client-reconnect-819604 [12:08] vila: no, it doesn't work. `bzr log -n0 -rA..B` is missing a changeset that `bzr missing` shows (and --exclude-common-ancestry does not help with this) [12:16] * vila curses complicated log implementation [12:16] knielsen: you know branch accepts a --no-tree parameter ? Branches are way cheaper to create this way if you have a big working tree [12:17] the obvious answer would be `bzr missing --include-merges --my-revision=A --revision=B .`, but I could not get this to work, in fact I could not get --my-revision to do anything for some reason... [12:17] vila: yes, probably will need to go with explicit branches and --no-tree [12:18] should be ok, though I need to do this for a couple of 1000 revisions [12:18] if '--revision A --revision B' is accepted, it should translate to '-rA..B' or nothing is really wrong [12:24] knielsen: Don't overlook that you don't need to keep creating new branches for all those thousand. You can just create A and B branches once, and use 'pull' in 'em to reset their revs for each run. [12:24] fullermd: right, interesting idea, might help [12:25] (and with them in a shared repo with your source branch, all those resets will be cheap, since no data needs to be transferred) [12:25] knielsen: 1.000 revisions... I can't imagine what you're trying to achieve... [12:27] hehe. I'm trying to get an overview of a very complicated merge. I have a list of commits that were merged and pushed into a tree in sequence, and I want to for each one know how many revisions were merged in that push [12:28] and I just wanted to try understand how `bzr log` worked with non-mainline revision ranges. But `bzr branch --no-tree` branches several trees per second, so I think that will be plenty sufficient for my needs [12:28] tnx for the help [12:28] knielsen: did you give 'bzr qlog' a shot ? It's pretty good at showing which revisions were merged into each mainline revision [12:28] * knielsen will try qlog also ... [12:29] It may be slow to start (for big & complex histories), but you'll start it only once [12:29] vila: the main thing is that the mainline revisions do not correspond to the pushes into the tree, as there has been no discipline about in which order to merge before pushing [12:30] You can also give several branches and it gives a pretty good view of what has been merged [12:30] knielsen: argh, yeah, makes it hard to understand what is shared :-/ [12:30] so I re-constructed a list of the commits that existed in the main tree during time. Many of these commits are not mainline revision, and many main-line revisions are not on the list [12:31] knielsen: append_revisions_only is your friend to converge to such a workflow [12:31] vila: yep :) [12:55] vila: do you have any plugins loaded when running the testsuite? [12:56] jelmer: I ran with BZR_PLUGIN_PATH=-site [12:56] vila: found it - we override verbs in the testsuite, but don't cope with info= [12:58] jelmer: where ? [12:59] vila: override_verb() and disable_verb() [13:00] ha, right, bad cleanup, I see [13:00] vila: can you try again with my last commit to ~bzr/bzr/2.5-client-reconnect-819604 ? [13:02] revno 6217 [13:02] running [13:11] jelmer: right fix, confirming isolation issue, note that the proper (and usual way) to do that is to overiddeAttr(request.request_handler) and populate it with a copy (out of scope for your branch) [13:11] jelmer: run succeeded, the fix is good === yofel_ is now known as yofel [13:12] I got one spurious failure though: [13:12] bzrlib.tests.per_interrepository.test_fetch.TestInterRepository.test_fetch_parent_inventories_at_stacking_boundary_smart_old(InterDifferingSerializer,RepositoryFormatKnitPack6RichRoot,RepositoryFormat2a) [13:12] with a slightly different error for the client: ConnectionReset: Connection closed: Unexpected end of message. Please check connectivity and permissions, and report a bug if problems persist. [13:12] so reconnecting doesn't help there (despite the hopes) [13:12] yeah, me too [13:16] jelmer: reliably ? [13:19] vila: no, it seems to be spurious [13:19] right, would have been too nice [13:39] ugh, the reconnection branch changes the way our current random failures fail? [13:40] * fullermd . o O ( If they're really random, you can't tell :p ) [13:40] they have a limit axis of randomness fullermd :) [13:40] they either pass, or fail in a specific way. [13:40] they don't turn into elephants. [13:41] Well, that sucks. No wonder nobody runs the test suite. [13:41] Without a good payoff like that, it's so not worth it. [13:49] mgz: ugh indeed [13:50] * jelmer thinks the value of elephants is widely overestimated [13:51] How else could we get revision info into pachyderm files? [14:12] fullermd: zlib? === treaves_ is now known as treaves [15:48] jelmer: are you nearly done passing all your hpss branches? :) [15:51] * mgz doesn't want to merge trunk for news till he's sure of getting a free slot [16:00] mgz: it's all in the queue now [16:03] cool [17:22] mgz, vila: so, I wonder what we should do about the ~bzr/bzr/2.5-client-reconnect-819604 branch [17:22] cry? [17:22] is the remaining spurious failure worse than what we have at the moment? [17:23] the only way to know is to land it [17:23] why should it be worse ? [17:24] vila: for me, it *seems* to occur more often than the ones currently present, which I can't reproduce at all [17:24] of course that's all totally unscientific, and I don't think we should hold that against it [17:25] vila: but yeah, perhaps we should JFDI and rather than let it sit there for a couple more weeks [17:26] as an experiment I'm running for i in {1..10000} ; do echo $i ; ./bzr selftest -s bzrlib.tests.per_interrepository.test_fetch.TestInterRepository.test_fetch_parent_inventories_at_stacking_boundary_smart_old -v InterDifferingSerializer -Ethreads ; done for bzr.dev revno 6311 [17:26] I had 58 failures for 1837 runs so far [17:26] vila: ah, interesting [17:27] more failures when babune run jobs [17:27] but at least it means there is a way to reproduce, slow, painful but reproducing nevertheless ;) [17:29] * jelmer does another merge of lp:bzr [17:31] vila, mgz: can either of you have another look at it again too? [17:32] hmm [17:32] vila: "merg hokk", is that Swedish for merge hook ? :P [17:37] sry was afk (cooking), oook ? In the COVER or in the code ? [17:38] Well, we wouldn't want to interrupt your cokking... [17:38] vila: in the cover, so not really something that requires fixing [17:38] arf, in the cover letter ;) Right, tyop, I thought hhtp was too last century ;) [17:38] fullermd: vila is the Swedish chef? [17:42] Dunno. Do you actually cook Swedes? I thought they were better just smoked... [17:43] tagliatelles a la carbonara, more likely to be Italian [17:52] vila: nice work on the po merge hook! submitted a review [18:02] I wish writing these was easier.. [18:03] * jelmer calls it a day [18:27] im making some build scripts, and I was wondering if there was a way to get a revison number for just a file or a directory and the files under it? or maybe just a way to tell if thoese files have changed since a specified revision? [20:04] hey bzr, im trying to do bzr lp-propose-merge but it seems to be coughing since im using pipes and colo [20:04] bzr: ERROR: file:///home/alex/Code/unity/.bzr/branches/rip-out-ap/trunk/ is not registered on Launchpad [20:04] any ideas? [20:04] do i just need to push my first pipe (which is just a clone of trunk) to lp? [21:10] hi poolie, jelmer [21:10] has Markdown support landed on LP yet? [21:21] hi lamalex [21:21] hi Noldorin [21:21] Noldorin: this isn't really the right channel for that question [21:22] hola jelmer [21:22] noldorin: the lp folks are working on markdown support? [21:24] jelmer, true, but it's not that inappropiate either ;-) [21:24] jelmer, they are indeed. poolie for one [21:25] jelmer, how are you coming along on bzr-git anyway? i'm looking forward to the repo fix i want as a christmas present :-) [21:25] Noldorin: sorry, lots of other more important stuff to fix first.. [21:26] :( :-( [21:26] jelmer, what's so much more important, i want to know? [21:26] this seems like a MAJOR bug...it prevents the most basic functionality of bzr git on some repositories [21:26] and not even very special repositories [21:26] for me, this would be #1 priority... i struggle to think of a more important one [21:27] sorry, i just find it hard to believe :-S [21:27] Noldorin: push support in bzr-git is still experimental, the focus is on importing from git into bzr at the moment [21:27] jelmer, oh is that right? [21:27] Noldorin: in addition, you're hitting a particular corner case [21:27] jelmer, sorry didn't know [21:28] jelmer, i'd dispute calling it a "corner case" (seems fairly simple), but i can accept that git -> bzr importing is more important :-) [21:36] Noldorin: I use dpush on a regular basis and I've never hit that particular issue. [21:36] jelmer, oh well. maybe i'm jsut strange ;P [21:36] Noldorin: I'm not trying to say the bug doesn't matter, but there's more things that deserve attention. This is just one. [21:40] jelmer, no no, i concede that. now that you've stated that git to bzr importing is your main goal [21:40] jelmer, i'm going to hope, but not expect, for new year :-P [21:49] Noldorin: There's a good chance there'll be one in a month or so ;p [21:51] fullermd, oh yes? that's good to know :-P [21:54] fullermd, you work on bzr-git too huh? [21:54] Never touched it. [21:55] oh [21:55] how do you knwo good chance ina month or so then? :-P [21:56] 15:40 i'm going to hope [...] for new year [21:56] 'cuz I can read a calendar ;p [21:56] fullermd, yeah but that's making the bold assumption that my hope is a liklihood :-P [21:57] Well, unless the world ends, it's going to be hard to NOT wind up with a new year in about 5 weeks. [21:58] (I don't rule that out, to be sure. I just hope there's enough warning to make popcorn.) [22:00] fullermd, oh dear. you were making a cheesy joke by taking my sentence out of context. i just saw :-P [22:00] fullermd, makes sense now at least. [22:00] It does? That should worry you... [22:03] heh [22:03] perhaps [22:03] but not too much [22:15] hi all [22:17] hi poolie [22:19] hello [22:32] jelmer, the reconnect thing still has some logical conflicts with your new hpss verbs [22:32] i'll try to fix them up and send it [22:43] 'evening poolie, GRiD [22:43] poolie: the ~bzr -owned version? That merges lp:bzr fine here [22:46] jelmer: logical, not textural [22:46] texual [22:46] bah [22:46] textual. [22:47] lifeless: oh, right.. logical and logical conflicts... [22:49] specifically some tests fail because your new verbs do not specify whether they can be safely retried [22:49] anyhow i will finish it today [22:50] poolie: are you sure you have the last revision? vila and I had it pass the full testsuite today, including the HPSS stuff [22:51] jelmer, no i probably don't [22:51] i was just talking about my last result yesterday [22:51] if you guys fixed that, do land it [22:51] or perhaps you already did [22:51] ah, cool [22:52] poolie: actually, vila had some follow-up to your blocking-accept fixes, and I did some conflict resolution [22:52] poolie: it should be ready to land, but if you'd like to have another look at the recent changes, that'd be great [22:53] ok i will