[05:49] <mup> PR snapd#9700 closed: client/snapctl, store: fix typos <Simple 😃> <Skip spread> <Created by anonymouse64> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9700>
[05:54] <mup> PR snapd#9670 closed: devicestate: make checkEncryption fde-setup hook aware <Skip spread> <Squash-merge> <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9670>
[07:58] <zyga> good morning
[08:01] <pstolowski> morning
[08:02] <zyga> good morning pawel
[08:02] <zyga> I will do the changes to export manager after work today
[08:03] <pstolowski> hey zyga
[08:39] <pedronis> #9675 needs 2nd reviews
[08:39] <mup> PR #9675: bootloader/lkenv: add v2 struct + support using it <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9675>
[08:40] <pedronis> it needs a tweak as well
[08:42] <pedronis> no, no tweaks
[08:43] <mvo> pedronis: I started yesterday to look, will try to finish after the desktop meeting
[08:45] <mup> PR snapd#9697 closed: daemon: move general api to api_general*.go <Created by pedronis> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/9697>
[08:48] <pedronis> mvo: pstolowski: thanks for the reviews ^
[08:58] <pedronis> pstolowski: hi, when you have time #9526 needs a re-review
[08:58] <mup> PR #9526: snapshotstate: add cleanup of abandonded snapshot imports <Created by mvo5> <https://github.com/snapcore/snapd/pull/9526>
[09:01] <pstolowski> ok
[10:34] <pstolowski> mvo: tiny remark re tests in #9526 and +1
[10:34] <mup> PR #9526: snapshotstate: add cleanup of abandonded snapshot imports <Created by mvo5> <https://github.com/snapcore/snapd/pull/9526>
[10:36] <pstolowski> i'm seeing google:ubuntu-20.04-64:tests/main/uc20-create-partitions* failures, i think that's the same pedronis mentioned yesterday
[10:48] <pedronis> mvo: I did a pass on #9699
[10:48] <mup> PR #9699: hookstate: implement snapctl fde-setup-{request,result} <UC20> <Created by mvo5> <https://github.com/snapcore/snapd/pull/9699>
[10:48] <pedronis> mvo: I think it can maybe be simplified further
[10:50] <mvo> pedronis: nice, thank you
[11:03] <pedronis> mvo: pstolowski: the simplification I described yesterday for daemon request testing:  https://github.com/snapcore/snapd/pull/9703  (this one is small)
[11:03] <mup> PR #9703: daemon: simplify test helper Get|PostReq into Req <Created by pedronis> <https://github.com/snapcore/snapd/pull/9703>
[11:04] <pstolowski> thanks, will take a look shortly
[11:04] <mvo> pedronis: nice, I have a look
[11:05] <mup> PR snapd#9703 opened: daemon: simplify test helpers Get|PostReq into Req <Created by pedronis> <https://github.com/snapcore/snapd/pull/9703>
[12:06] <pstolowski> pedronis: i wonder if "forget" should be passed via mode field in postData , or should be a separate flag on post data (mutually exclusive with mode if set)
[12:16] <mup> PR snapd#9703 closed: daemon: simplify test helpers Get|PostReq into Req <Skip spread> <Created by pedronis> <Merged by stolowski> <https://github.com/snapcore/snapd/pull/9703>
[12:16] <mvo> pedronis, pstolowski thanks for the reviews in 9699, I addressed them
[12:18] <pedronis> pstolowski: that's a valid point
[12:18] <pstolowski> pedronis: alternatively, rename mode to action in the requests
[12:23] <pedronis> pstolowski: probably best is to have action=apply and mode and action=forget, and have an explict client.Forget... for forget?
[12:23] <pedronis> that is probably more inline with how we do this for other entities
[12:28] <pedronis> pstolowski: I answered your question as well
[12:30] <pstolowski> pedronis: thanks. yes i think this makes sense
[12:39]  * pstolowski lunch
[13:43] <mvo> pedronis: thanks for 9699 - updated it again
[13:51] <mup> PR snapd#9690 closed: tests: enable nested on 20.10 <Run nested> <Created by stolowski> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9690>
[14:27] <pedronis> mvo: #9526 can be merged now?
[14:27] <mup> PR #9526: snapshotstate: add cleanup of abandonded snapshot imports <Created by mvo5> <https://github.com/snapcore/snapd/pull/9526>
[14:33] <mvo> pedronis: yeah, I can do the error format tests as a followup, I think that was the only piece I wanted to do still
[14:35] <pedronis> ah, those
[14:35] <mvo> sil2100: do you think we could promote snapcraft from focal-proposed to -updates? it has a fix for autopkgtests and cachio  just noticed that snapd tests fail because this was not done yet
[14:35] <pedronis> mvo: I have a question in 9699
[14:35] <mvo> pedronis: sure, looking
[14:40] <mvo> pedronis: no deep reason, are you suggesting to set it on context and then have a OnDone that sets it on the task? or that in the runner I should get it from the hook context instead of using the task for that?
[14:43] <mvo> pedronis: but yeah, I can change it maybe that's easiest and then with the runner see how it all fits
[14:43] <mvo> pedronis: actually I think I see what you mean now, let me try that
[15:15]  * cachio lunch
[15:51] <pedronis> mvo: btw, now that I think, you probably don't want a change if possible, a change means that if you crash,  the change will be there to be run again without any relation to the context that needed it, that is awkward
[15:57] <mvo> pedronis: good point
[16:27] <mup> PR snapd#9704 opened: daemon: split out /v2/interfaces to api_interfaces_test.go <Skip spread> <Created by pedronis> <https://github.com/snapcore/snapd/pull/9704>
[16:30] <mvo> pstolowski: I addressed your comments 9699
[16:31] <pstolowski> mvo: ty
[16:34] <pstolowski> mvo: have you pushed?
[16:35] <mvo> pstolowski: ups, sorry
[16:36] <mvo> pstolowski: now I pushed
[16:36] <pstolowski> mvo: ty. btw can you use superpowers to merge #9678?
[16:36] <mup> PR #9678: wrappers, o/devicestate: remove EnableSnapServices <Run nested> <Services ⚙️> <Simple 😃> <Created by stolowski> <https://github.com/snapcore/snapd/pull/9678>
[16:37] <mvo> pstolowski: sure
[16:38] <pstolowski> \o/
[16:40] <pedronis> mvo: pstolowski: #9704 is the next refactoring bit
[16:40] <mup> PR #9704: daemon: split out /v2/interfaces to api_interfaces_test.go <Skip spread> <Created by pedronis> <https://github.com/snapcore/snapd/pull/9704>
[16:42] <mup> PR snapd#9678 closed: wrappers, o/devicestate: remove EnableSnapServices <Run nested> <Services ⚙️> <Simple 😃> <Created by stolowski> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9678>
[16:43] <mvo> pedronis: cool, thanks
[16:51] <mvo> fwiw I expect to push a fix for the uc20-create-paritions-* failure shortly
[18:02] <mup> PR snapd#9699 closed: hookstate: implement snapctl fde-setup-{request,result} <Skip spread> <UC20> <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9699>
[18:07] <mup> PR snapd#9705 opened: devicestate: add runFDESetupHook() helper <Squash-merge> <Created by mvo5> <https://github.com/snapcore/snapd/pull/9705>
[18:07] <mvo> pedronis: I pushed the runFDESetupHook code, I could not make it work without using a task but I am open for ideas and will sleep over it
[18:17] <mup> PR snapd#9706 opened: tests: fix uc20-create-parition-* tests for updated gadget <⚠ Critical> <Created by mvo5> <https://github.com/snapcore/snapd/pull/9706>
[18:18] <pedronis> mvo: to do that we probably needa new exported helper from hookstate
[18:18] <pedronis> or the hook manager
[18:19] <pedronis> mvo: I stil think that the change will be a nuisance/problematic conceptually for this situation
[18:24] <pedronis> mvo: let's chat tomorrow morning
[19:00] <mvo> pedronis: sure, let's chat tomorrow
[19:13]  * cachio afk
[19:38] <mup> PR snapd#9704 closed: daemon: split out /v2/interfaces tests to api_interfaces_test.go <Skip spread> <Created by pedronis> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/9704>