=== KindTwo is now known as KindOne [05:43] morning [06:46] PR snapd#8636 closed: tests: add dependency needed for next upgrade of bionic [06:48] PR snapd#8634 closed: usersession/agent,wrappers: fix races between Shutdown and Serve [06:49] mvo: hey [06:49] good morning mborzecki [06:50] PR snapd#8630 closed: tests: inject snapd from edge into seeds of the image in manual preseed test [06:53] PR snapd#8617 closed: tests: new directory used to store the cloud images on gce [06:54] PR snapd#8611 closed: tests: not fail when boot dir cannot be determined [07:00] morning [07:06] good morning pstolowski === tinwood is now known as tinwood-afk [07:13] PR snapd#8577 closed: secboot,cmd/snap-bootstrap: move initramfs-mounts tpm access to secboot [07:17] mborzecki: there is one comment from ian in 8628, is that still relevant to address? this looks like a fine 2.45 piece [07:18] o/ [07:18] mvo: yes, i'll be pushing a patch there, filepath.Glob() sorts internally but it isn't mentioned in the doc so it's fair to call it an implementation detail and just sort eplxiciltly outside [07:18] hey guys [07:22] zyga: hey [07:23] mborzecki: thanks, I want to cherry pick this to 2.45 so I will wait for this update first :9 [07:23] hey zyga === juergh_ is now known as juergh [07:35] mvo: updated #8628 [07:35] PR #8628: cmd/snap: coldplug auto-import assertions from all removable devices [07:40] mborzecki: thank you === tinwood-afk is now known as tinwood === ondra_ is now known as ondra === TooLmaN_ is now known as TooLmaN === Wouter01008 is now known as Wouter0100 === mcphail7 is now known as mcphail [08:18] zyga: something random? https://paste.ubuntu.com/p/V7PhBg73zj/ [08:18] 1;1 [08:19] btw. 14.04 deb does not build anymore? [08:19] https://paste.ubuntu.com/p/f4CdkXsVwm/ getting 2020-05-11T07:32:20.0517313Z E: Unable to locate package dbus-user-session on 14.04 [08:21] mvo: the ci job in #8628 has finished, please take a look and merge, there's a couple of unrelated failures in the tests [08:21] PR #8628: cmd/snap: coldplug auto-import assertions from all removable devices [08:22] mborzecki: thanks, in a meeting [08:32] mborzecki: maybe new image? [08:33] I think it's the new image with a new package preinstalled [08:37] re [08:37] zyga: we try to install dbus-user-session in prepare, but there's no such package on 14.04 apparently [08:37] mborzecki: is it on master now [08:37] zyga: yeah, it's on master [08:37] mborzecki: is that on 14.04? [08:37] mborzecki: IIRC it only was a factor on 16.04 [08:37] ubuntu-16.04-64 [08:37] the log says 16.04 [08:37] sergio preinstalled that package [08:37] it landed this morning [08:37] so we just need a matching test correction [08:38] the test measures what's the state of our image [08:38] so that we understand what to do in tests and what to expect [08:38] zyga: i'm confused, which log? [08:38] ah [08:38] you said: "something random? ..." [08:38] zyga: that's separate issue :) [08:38] right [08:39] yeah, this package does not exist in 14.04 [08:39] we should not try to install it there [08:39] hmm, didn't this land after a spread run? [08:39] anyway, both need to be fixed [08:39] zyga: 8633 is the one that fails in core with the strange ownership, right? [08:40] mvo: yes [08:40] zyga: so if I run this in core16 I should see the same failure? [08:40] mvo: checkout that PR and run core16 spread tests [08:40] yeah [08:40] zyga: I wonder if it also fails on qemu, maybe it's really something cloud specific [08:40] mvo: aaah [08:40] brilliant idea [08:40] I'm sure it will be a decisive test for the cloud-init theory [08:42] zyga: running it now locally here [08:42] ok, I'll grab one thing from upstairs and look at the thing maciek reported [08:46] ok [08:46] let's get to it [08:50] #8613 needs a 2nd review and is fairly straightforward [08:50] PR #8613: o/configcore: pass extra options to FileSystemOnlyApply [09:09] mborzecki: testing a fix, should be available shortly [09:09] zyga: thanks [09:20] pedronis: mvo: should i start looking into snap repair for uc20 perhaps or the cli bits for recovery systems? [09:21] PR snapd#8637 opened: tests: test adjustments and fixes for recently published images [09:22] mborzecki: ^ [09:22] mborzecki: probably reviews [09:26] mborzecki: also I think Ian PR can panic in some cases: https://github.com/snapcore/snapd/pull/8635#discussion_r422906005 [09:26] PR #8635: o/devicestate: support doing system action reboots from recover mode [09:26] pedronis: ok, let me check that, i can push a fix if needed [09:36] PR snapd#8628 closed: cmd/snap: coldplug auto-import assertions from all removable devices [09:36] yay [09:36] mborzecki: thank *you* - and cherry-picked to 2.45 [09:37] mvo: anything else we need to do for auto import right now? (aside from little tweaks) [09:37] mborzecki: I think that's it, this should work now [09:37] mborzecki: once it's on beta/edge I will ask taipei to test it [09:37] mvo: great, thanks! [09:45] we broke 14.04 testing ? [09:45] pedronis: yes [09:45] pedronis: fix is up [09:45] :/ [09:45] 8637 [09:46] pedronis: I updated https://github.com/snapcore/snapd/pull/8566 [09:46] PR #8566: c/snaplock/runinhibit: add run inhibition operations [09:47] pedronis: it was merged earlier today https://github.com/snapcore/snapd/pull/8636 [09:48] PR #8636: tests: add dependency needed for next upgrade of bionic [09:53] zyga: again a pulseaudio failure as well: https://pipelines.actions.githubusercontent.com/xS8oSnypZkPEQZqiZgDaRp2kdvQJKbOY08TesHp7E8vn7g4hYR/_apis/pipelines/1/runs/4124/signedlogcontent/31?urlExpires=2020-05-11T09%3A53%3A40.8345409Z&urlSigningMethod=HMACV1&urlSignature=CGXZSIWuB1%2B%2FEaA9iyF9qXEMhUFFa5d0nk8fHPh%2BXic%3D [09:54] that's interesting, it looks like a real issue, look that within the same test we did interact with pulse already [09:54] and also issues with session agent on core16 [09:54] I have an idea about that failure [09:54] pedronis: is that a random or have you seen this more than once? [09:55] is the one when we cannot talk to the socket [09:55] but this time is the a different socket not root [09:55] read unix @->/run/user/12345/snapd-session-agent.socket: read: connection reset by peer [09:57] do you think that the agent is crashing or just shutting down at the wrong moment? [09:58] pedronis: perhaps a debug line would help, something like [09:58] session-tool -u test journalctl --user [10:02] brb, [10:18] pedronis: hm perhaps we should error out when trying to request a system action and the system is not yet fully seeded [10:19] pedronis: looking at current code, the 'current' system would also be incorrectly detected in such case [10:19] so any systemLabel == current.Label checks make no sense at all [10:19] mborzecki: well, it's complicated [10:19] you don't get any run or recover [10:19] action [10:19] if there's no current I think [10:20] pedronis: yes, that also [10:20] it's install that is strange [10:20] honestly I think we should just error if you try to install while installing [10:21] even if it's the same system [10:21] is just a strange request [10:21] maybe just error out early if in install mode [10:21] yeah [10:27] re [10:28] pedronis: we could do two things that would have better perception of working [10:28] 1) if we are already performing an operation that is being requested (.e.g. refresh while refreshing) we could just display the progress instead of failing [10:28] this sometimes fails when you open gnome software and it tries to refresh snaps but we're already doing that [10:29] 2) we could perhaps queue a install command if we are in a special state (not seeded, but perhaps other states as well) [10:34] https://github.com/snapcore/snapd/pull/8637 fixes master and needs a 2nd review [10:35] PR #8637: tests: test adjustments and fixes for recently published images [10:43] zyga: this is about mode, not normal snap operations [10:43] I see [10:43] so run vs other? [10:45] mborzecki: actually, I was confused, we set things into seeded-systems even for the ephemeral ones? [10:46] mborzecki: it sounds slightly wrong (in terms of defining what is current) [10:46] mvo: did your qemu experiment turn up passing or failing? [10:47] pedronis: yes, it's set in mark seeded, which ephemeral does too for itself [10:47] zyga: it failed but in a different test :( in snap-user-service-socket-activation on uc16 [10:47] mborzecki: it sounds kind of wrong [10:47] zyga: sounds like I need to run it again [10:47] mvo: that's a known warning [10:47] mborzecki: we need to think a bit [10:47] mvo: dit it fail on just that? roughly how many tests did you get throguh? [10:48] mvo: in GCE I see the failure really quickly [10:48] mvo: all kind of snap-user-service tests fail sometimes on UC16 [10:54] pedronis: upated #8635 [10:54] PR #8635: o/devicestate: support doing system action reboots from recover mode [10:55] mborzecki: thx [10:58] zyga: around ~100, I can run it again on gce [10:58] mvo: I'm running int on GCE now with some more ideas [10:58] mvo: but I think this shows it's cloud-init and, presumably, around tests that reboot [10:58] mvo: the naive workaround I added just fixes one reboot case (the initial reboot) [10:59] need to think where to put a fix for something that can happen at any time [10:59] I wonder if we could turn off cloud-init somehow as well, not sure if it should do stuff on core during CI [11:02] in which sense? some our CI flows use cloud-init [11:02] pedronis: it seems that cloud init data in GCE causes creation of an "ubuntu" user with broken home directory [11:02] but only on core16/18 [11:02] (though only *broken* there, it may be that we create it everywhere0 [11:03] well, it's easy to know [11:03] look what's the user data there [11:03] at cloud-init data? I'm not deeply familiar with it but I looked that some on Friday and [11:04] 1) cloud-init.service sets up the password for ubuntu user, so it's likely it is creating it as well (this is evident in the log file) [11:04] 2) user data contains gustavo's account but I was not able to find the string "ubuntu" there - perhaps I looked at the wrong files as I'm not familiar with cloud-init that much [11:05] ok, but I doubt turning it off completely is an option [11:05] I see [11:06] anywway I have no time to help with this atm [11:10] zyga: is this breaking some tests directly? or it's breaking some sanity checks? [11:10] just a sanity check [11:10] I was wondering where it came from [11:11] given all the things we have to fix it, seems it should go in the ignore for now bucket [11:13] indeed, [11:16] zyga: running it again in qemu/google on core18, maybe that is more robust [11:22] ok, the 14.04 issue is gone [11:23] PR snapd#8637 closed: tests: test adjustments and fixes for recently published images [11:27] PR snapcraft#3112 opened: spread: remove dead code for lxd setup and add debug prints [11:27] PR snapd#8638 opened: tests: do not add pkg dbus-user-session on ubuntu-14.04 === woutervb[m] is now known as woutervb [11:29] PR snapd#8334 closed: many: add core.resiliance.vitality-hint config setting [11:36] mvo: I added a workaround as samuele suggested, I'll rebase on top of the master fixes and pushed [11:36] mvo: we can return there if we are really bored one day ;-) [11:37] zyga: heh, maybe what is running already contains this workaround, no failure so far on gce [11:37] zyga: anyway, I have lunch now [11:37] oh?! [11:37] weird [11:37] I saw this very quickly [11:37] (before the workaround) [11:37] on core16 or core18? [11:37] I kept running core16 [11:40] PR snapd#8639 opened: o/cmdstate: handle ignore flag on exec-command tasks (1/N) [11:50] re [11:51] in the times of home schooling, fixing the printer is a rather important duty :/ [11:51] mvo: we can close https://github.com/snapcore/snapd/pull/8638 [11:51] PR #8638: tests: do not add pkg dbus-user-session on ubuntu-14.04 [11:53] PR snapd#8572 closed: packaging: add the inhibit directory === woutervb is now known as wvanbommel [11:54] pedronis: is there a particular name we can settle on in https://github.com/snapcore/snapd/pull/8578 [11:54] PR #8578: interfaces: add host-docs interface [11:55] pedronis: I'd like to do a small pass, update the name, adjust the test as pawel suggested, and be done with it [11:57] zyga: so : session-tool -u test journalctl --user gets a permission error about test not being systemd-journal, and I haven't found an easy way to see the same logs when driving things as root [11:58] curious, let me look [11:59] I mean, the whole point of journalctl --user is to look at your own logs [11:59] was this on core 16? [11:59] yes [12:00] can you paste the entire message if you have it handy [12:00] I'm looking now [12:01] session-tool -u test journalctl --user [12:01] Hint: You are currently not seeing messages from other users and the system. [12:01] Users in the 'systemd-journal' group can see all messages. Pass -q to [12:01] turn off this notice. [12:01] No journal files were opened due to insufficient permissions. [12:01] huh, that's very confusing [12:02] checking what happens under the cover [12:03] interesting, it could be a permission error on core [12:04] user logs are in /var/log/journal/*/user-UID@* [12:04] so presumably part of that path is not available to the test user [12:04] it could be that we are lacking some basic group ownership [12:05] oddly all logs are owned by root and systemd-journal group (on classic) [12:05] I'll check if we can simply create the test user with systemd-journal group to solve it [12:06] it's core so groups is readonly, maybe there's a way around that [12:06] we work around that alreay [12:06] core has extra setup for it [12:13] pedronis: trying something like this now [12:13] https://www.irccloud.com/pastebin/DL4hLdWP/ [12:16] PR snapd#8640 opened: wrappers: pass 'disable' flag to StopServices wrapper [12:27] PR snapcraft#3108 closed: tools: install wheel in snapcraft-dev [12:28] almost but not quite ;) [12:30] PR snapcraft#3103 closed: python v2 plugin: set path to the interpreter [12:39] pedronis: re, can we settle on the final name for the host-docs proposal? I'd love to have that branch behind us :) [12:40] zyga: I made some proposals, nobody gave feedback on them [12:40] pedronis: I think the word "misc" is probably bet to be avoided [12:40] so perhaps just system-doc? [12:41] no [12:41] they are eally not the system docs [12:41] though I personally perfer the plural because there's more than one document there [12:41] what do you mean? [12:41] they are not the main system doc [12:42] the manpages and mayb share/info are [12:42] I see what you mean [12:42] as I said, the FHS call them miscelleanous documentation, I didn't make that up [12:42] arguably we could explore providing both info and man pages but I would not expect those to be much use [12:43] I think FHS naming is not really that great, it's only misc from a mainframe era point of view [12:44] on my system there are nearly 200MB in /usr/share/doc and only about 50 in both info and man pages [12:45] pedronis: I was wondering about "system" as well, because it's a dual-purpose word in snap world - it can mean the "system" as as a whole, including the core part of it, or the "host system" when thinking about classic systems with snapd also installed [12:47] I made a 2nd proposal as well: system-packages-doc [12:48] I'm happy with that one, because packages are plural and the "doc" refers to the directory name, not to "documentation" or "documents" [12:48] if you are okay I can apply that quickly [12:48] PR snapcraft#3105 closed: build provider: clean incompatible build-environments [13:09] PR snapcraft#3111 closed: elf: fix parsing of notes after patchelf mangling [13:11] cmatsuoka: if you can access the shell after booting in recovery mode and chooser failed to trigger, can you try to obtain the log from snapd.recovery-chooser-trigger.service ? [13:11] mborzecki: will do [13:11] cmatsuoka: thanks! [13:14] mborzecki: I'll re-image ian's PR because sudo doesn't work in this image [13:23] PR snapd#8638 closed: tests: do not add pkg dbus-user-session on ubuntu-14.04 [13:39] PR core-build#59 closed: initramfs: add new handle_writable_defaults() [13:41] mborzecki: this how Pool is going to be used in the end: https://github.com/snapcore/snapd/pull/8569/files#diff-763375e1fe8805703f81dfb94060286f [13:41] PR #8569: o/assertstate,asserts: use bulk refresh to refresh snap-declarations [13:56] PR snapd#8641 opened: tests: improve debugging of user session agent tests [14:08] cmatsuoka: chooser seems to start correctly with core20_634.snap, pc_100.snap, pc-kernel_495.snap in recover mode here [14:09] mborzecki: did you remaster the kernel? [14:09] cmatsuoka: no, i did not try to repack it [14:09] mborzecki: in my tests this situation works too [14:09] mborzecki: once you repack the kernel it starts to fail [14:10] you don't really need to inject anything or even change the efi [14:14] PR snapd#8642 opened: tests: add dbus-user-session to bionic and reorder package names [14:15] zyga, hey, when you have 5 minutes, could you please take a look to #8642 [14:16] PR #8642: tests: add dbus-user-session to bionic and reorder package names [14:16] I'm looking [14:17] does it affect anything? I mean session-tool already shows 18.04 has this, or is that just because the current image has recommended packages? [14:18] zyga, I was testing and the images dont have it [14:19] do you mean the upcoming images? [14:19] zyga, yes, upcomming https://paste.ubuntu.com/p/PRTDY963dY/ [14:19] ok [14:19] yeah, looks good [14:19] pedronis: this should help https://github.com/snapcore/snapd/pull/8641 [14:19] PR #8641: tests: improve debugging of user session agent tests [14:20] zyga, once we have that, I can push the image which will fail with the mount-ns test [14:21] cachio: sounds good [14:21] zyga, nice, thanks [14:23] * zyga goes for lunch [14:31] mborzecki: https://pastebin.ubuntu.com/p/67KsBSvCP4/ [14:32] cmatsuoka: does it reboot? [14:33] hmm [14:33] sorry, I didn't wait again [14:33] I just rebooted it by hand to get the other log [14:34] mborzecki: the other log: https://pastebin.ubuntu.com/p/Gkz77ksFK3/ [14:36] cmatsuoka: from what i've seen you need to hold it super long to trigger the chooser in recovery [14:37] I press it then the tianocore logo is still on screen, and release it only when the key fingerprints appear [14:38] and I got a lot of 1111111111 during the boot messages [14:41] hmm ok i think i know what's going on [14:42] ah excellent [14:42] pstolowski: fwiw I uploaded https://github.com/snapcore/core-build/pull/59 to bionic,xenial so the next kernel rebuild should have support for _writable_defaults [14:42] PR core-build#59: initramfs: add new handle_writable_defaults() [14:42] mvo: great! thanks! [14:43] cmatsuoka: mvo: looking at the logs here, when system is booting in recovery mode, the trigger watch is started in initramfs (your only chance to trigger the chooser is now!), then once we switch root snapd won't start the trigger monitor since it has `# X-Snapd-Snap: do-not-start`, so there's no chance to trigger it during first boot [14:44] mborzecki: but why does it work when you don't repack the kernel snap? [14:53] mborzecki: it's a bit unclear why snapd shouldn't start if it's not started already [14:53] *start it [14:54] cmatsuoka: idk, if the log can be trusted, the key triggered in < 10s? weird [15:10] zyga, does it makes sense to have a script which created the github actions workflows based on a cofiguration file? [15:10] cachio: if we end up editing them a lot, maybe, otherwise I would not bother [15:11] cachio: depending on how actions evolve I would expect to see unification, not further shattering of the workflow files [15:11] so it is easy to have a workflow by system [15:11]