=== juergh_ is now known as juergh
[10:46] <cjwatson> Crossing fingers and landing my buildmaster-fetch-in-thread branch
[10:48]  * SpecialK|Canon eats^Wsacrifices a biscuit to the concurrency deities
[11:11]  * tomwardill -> lunch
[12:43] <cjwatson> ilasc: I'm starting to look at your question in https://code.launchpad.net/~ilasc/launchpad/+git/launchpad/+merge/383333 now (sorry for the delay).  Is there a failing test that exhibits the problem, or do I need to set something up in a browser?
[12:47] <ilasc> cjwatson: thanks! there is a Unit Test that you can use to avoid all the browser action, putting together a pastebin now
[12:53] <ilasc> cjwatson: this is how I test without browser: https://pastebin.canonical.com/p/dytcVy7vmS/
[12:55] <cjwatson> ilasc: OK, thanks
[16:30] <teward> cjwatson: thanks for looking @ my merge request, changes made to the branch accordingly.
[16:31] <teward> question though: if we're replacing Person.displayname -> Person.display_name does that apply for all cases of a 'person' including bug owner, etc.?
[16:31] <teward> 'cause if so there's a *lot* of deprecated usages in the bug notification builder
[16:32] <cjwatson> teward: We should eventually fix it tree-wide, but it'll be a massive change so for now it's fine to just chase the deprecation on lines we're changing anyway
[16:32] <teward> ok
[16:32] <teward> 'cause if we WANT I can start a change for the bug notification part
[16:32] <teward> since i'm already stabbing that xD
[16:33] <cjwatson> teward: It's not urgent
[16:33] <teward> ok
[16:33] <cjwatson> I'll land your change once I've fixed the buildbot chaos I just caused
[16:41] <teward> heh no problem.  let me guess it exploded hard :)
[16:41] <teward> cjwatson: does Canonical and the LP team need to make an announcement about the DMARC compliance change?
[16:41] <teward> (for bug notifications only at the moment)
[16:42] <cjwatson> I don't think it's vital, since it's already the status quo for users with hidden email addresses
[16:42] <cjwatson> But we'll probably put something about it on blog.launchpad.net
[16:57] <cjwatson> tomwardill: if you're still around?  https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/383734 (Fix proxy token handling for buildd-manager changes)
[16:57] <cjwatson> or maybe pappacena
[16:58] <tomwardill> looking
[17:02] <tomwardill> +1
[17:25] <cjwatson> Thanks
[18:44] <cjwatson> pappacena: http://lpbuildbot.canonical.com/builders/lp-devel-xenial/builds/1247/steps/shell_9/logs/summary looks like your bug so far FYI
[18:45] <pappacena> let me check
[18:45] <cjwatson> (assuming no more of mine show up ...)
[18:45] <pappacena> ah, it's probably something I've changed in the previous lp-signing MP, and didn't fix the tests here. Should be easy. Give me a minute
[18:52] <cjwatson> Yeah, it looked like something along those lines
[18:52] <pappacena> I'll run all the tests here and open a MP in some minutes
[18:52] <cjwatson> Ta
[18:53] <cjwatson> I've mostly EODed but can manage a testfix review if you need it
[18:54] <pappacena> I'm opening the MP right now
[18:55] <pappacena> Here: https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/383739
[18:56] <pappacena> bin/test -vvct lp.services.signing -t lp.archivepublisher.tests.test_signing
[18:56] <pappacena> Total: 100 tests, 0 failures, 0 errors, 0 skipped in 48.322 seconds.
[19:05] <pappacena> cjwatson, it's a quite easy test fix. Not a big deal if you EODed and I self-approve it...
[19:53] <cjwatson> pappacena: r=me
[19:53]  * pappacena Thanks!