Repository: Spotifyd/spotifyd (language: rust)

Issue:
New release
Would it be possible, that a new release is created? Version 0.3.3 is now already 8 month old and, e.g. #1025 is still missing therein.

Thanks in advance.



Discussion / hints:
If there is to be a release soon, it would be really great to have AArch64 support (https://github.com/Spotifyd/spotifyd/issues/280).

With Raspberry Pi OS moving to 64-bit earlier this year, this is likely to be increasingly frequently requested.
I created a new milestone https://github.com/Spotifyd/spotifyd/milestone/11 and moved all the issues still left over in the v0.3.1 milestone to it.

If there's anything else we want to hash out before bumping the number we can track it there.
With the merging of the big mpris bugfix just now, I'm wondering if there's appetite for doing the 0.3.4 release now (well, once we merge the changelog update) and pushing everything else outstanding to 0.3.5.

@Spotifyd/maintainers thoughts on the above? This would have the benefit of putting the mpris updates in the hands of users following stable releases etc. 

In any case, I created another milestone for 0.3.5 [here](https://github.com/Spotifyd/spotifyd/milestone/12), for whenever that becomes relevant.
> With the merging of the big mpris bugfix just now, I'm wondering if there's appetite for doing the 0.3.4 release now (well, once we merge the changelog update) and pushing everything else outstanding to 0.3.5.

Generally, I agree. As you can see [here](https://github.com/Spotifyd/spotifyd/blob/master/CHANGELOG.md#unreleased), the changelog is already quite big for this release. The remaining points in the [next milestone](https://github.com/Spotifyd/spotifyd/milestone/11) seem to be mostly related to CI, however, which might be relevant for the release (so that the binaries are built correctly).
Yes, please!
Alright, with some agreement and no dissent yet, I'll move forward with preparing 0.3.4 at the current master + updating the changelog.

Fix patch:
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 6230f265..920e533f 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -4,12 +4,14 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
-## [Unreleased]
+## [0.3.4]
 ### Added 
 - Implement the `PropertiesChanged` and `Seeked` events for the MPRIS-interface ([#1025])
 - Add `cache_size` configuration option ([#1092])
+- Add `dbus_type` configuration option ([#954])
+- Added formal documentation of the minimum required Rust version - which is currently 1.62 ([#1127])
 ### Changed
-- Improvements to the documentation ([#955], [#1030], [#1039], [#1054], [#1055], [#1067])
+- Improvements to the documentation ([#894], [#955], [#1030], [#1039], [#1054], [#1055], [#1067])
 - Fix cumulating delay in `on_song_change_hook` ([#1059])
 - Only enable one of zeroconf discovery and password-authentication at the same time ([#1059])
 - Convert mainloop to using `async` / `await` ([#1059])
@@ -18,9 +20,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Make `spotifyd` bus name unique ([#1100])  
   **Note:** If you were relying on the consistent bus name of `org.mpris.MediaPlayer2.spotifyd`,
   you can adapt your script e.g. by querying the name like `qdbus | grep "org.mpris.MediaPlayer2.spotifyd"`
+- Fix wrong handling of credential cache ([#1121])
 ### Removed
 - Replace redundant `reqwest` dependency ([#1120])
 
+[#894]: https://github.com/Spotifyd/spotifyd/pull/894
+[#954]: https://github.com/Spotifyd/spotifyd/pull/954
 [#955]: https://github.com/Spotifyd/spotifyd/pull/955
 [#1025]: https://github.com/Spotifyd/spotifyd/pull/1025
 [#1030]: https://github.com/Spotifyd/spotifyd/pull/1030
@@ -34,6 +39,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 [#1100]: https://github.com/Spotifyd/spotifyd/pull/1100
 [#1108]: https://github.com/Spotifyd/spotifyd/pull/1108
 [#1120]: https://github.com/Spotifyd/spotifyd/pull/1120
+[#1121]: https://github.com/Spotifyd/spotifyd/pull/1120
 
 ## [0.3.3]
 ### Added 
@@ -76,7 +82,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [0.2.24]
 
-[Unreleased]: https://github.com/Spotifyd/spotifyd/compare/v0.3.3...HEAD
+[Unreleased]: https://github.com/Spotifyd/spotifyd/compare/v0.3.4...HEAD
+[0.3.4]: https://github.com/Spotifyd/spotifyd/releases/tag/v0.3.4
 [0.3.3]: https://github.com/Spotifyd/spotifyd/releases/tag/v0.3.3
 [0.3.1]: https://github.com/Spotifyd/spotifyd/releases/tag/v0.3.1
 [0.3.0]: https://github.com/Spotifyd/spotifyd/releases/tag/v0.3.0
diff --git a/Cargo.lock b/Cargo.lock
index c35beed1..3976756c 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -2760,7 +2760,7 @@ checksum = "6e63cff320ae2c57904679ba7cb63280a3dc4613885beafb148ee7bf9aa9042d"
 
 [[package]]
 name = "spotifyd"
-version = "0.3.3"
+version = "0.3.4"
 dependencies = [
  "alsa 0.5.0",
  "chrono",
diff --git a/Cargo.toml b/Cargo.toml
index 50738010..100bc1c9 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -5,7 +5,7 @@ name = "spotifyd"
 description = "A Spotify daemon"
 repository = "https://github.com/Spotifyd/spotifyd"
 license = "GPL-3.0-only"
-version = "0.3.3"
+version = "0.3.4"
 rust-version = "1.62"
 
 [dependencies]
diff --git a/src/dbus_mpris.rs b/src/dbus_mpris.rs
index c4d3e0a0..0fa9677a 100644
--- a/src/dbus_mpris.rs
+++ b/src/dbus_mpris.rs
@@ -776,7 +776,7 @@ fn insert_metadata(m: &mut HashMap<String, Variant<Box<dyn RefArg>>>, item: Play
         Variant(Box::new(
             item.images
                 .into_iter()
-                .next()
+                .max_by_key(|i| i.width.unwrap_or(0))
                 .map(|i| i.url)
                 .unwrap_or_default(),
         )),


Test patch: