Repository: elastic-rs/elastic (language: rust)

Issue:
Consider bumping `nom` version
I recently ran into this problem:

https://users.rust-lang.org/t/a-dependency-compiles-on-its-own-but-does-not-compile-as-dependency-lettre-nom/18097/6

tl;dr nom has this weird opt-out flag that breaks compatibility if you depend on 2 crates with different feature flags. It's a pretty annoying bug with how Rust handles dependencies.

As a temporary solution I just bumped the `nom` version from 2 -> 3 and the issue went away because the other crate ([`procinfo`](https://github.com/danburkert/procinfo-rs/blob/master/Cargo.toml#L22)) depends on `nom = "0.2"`.

There are 2 possibilities for resolving this:

1. Upgrade the `nom` dependency
2. Use verbose-errors (this seems less preferable)

Thoughts?


Discussion / hints:
Hi @brndnmtthws :wave:

We don't use `nom` as a public dependency so bumping it shouldn't be a problem.

Fix patch:
diff --git a/src/elastic/Cargo.toml b/src/elastic/Cargo.toml
index 3fe18a5cdb..3994a25307 100644
--- a/src/elastic/Cargo.toml
+++ b/src/elastic/Cargo.toml
@@ -30,7 +30,7 @@ quick-error = "~1"
 error-chain = "~0.11"
 log = "~0.4"
 uuid = { version = "~0.6", features = [ "v4" ] }
-url = "~1"
+url = "~2"
 bytes = "~0.4"
 http = "~0.1"
 serde = "~1"
diff --git a/src/elastic_derive/Cargo.toml b/src/elastic_derive/Cargo.toml
index 992903b8ae..08e1667d9b 100644
--- a/src/elastic_derive/Cargo.toml
+++ b/src/elastic_derive/Cargo.toml
@@ -17,5 +17,5 @@ syn = { version = "~0.11.0", features = ["aster", "visit", "parsing", "full"] }
 quote = "~0.3.0"
 serde_derive_internals = { version = "~0.15.0", default-features = false }
 quick-error = "~1"
-nom = "~2"
+nom = "~3"
 chrono = { version = "~0.4.0", features = [ "serde" ]}


Test patch: