Repository: ALEZ-DEV/Babylonia-terminal (language: rust)

Issue:
Gigabit or Gigabyte?
Gb is Gigabit, GB is Gigabyte (the most correct option would likely be GiB tho, which is already widely used on linux)

https://github.com/ALEZ-DEV/Babylonia-terminal/blob/fb4e47eac72678a114b38f4a0abd8db4e9aec552/babylonia_terminal_launcher/lib/widgets/steps/game_steps_widget.dart#L121


Discussion / hints:
I will change this as soon as I can or you can make a PR if you want
I am currently trying out what unit it's even trying to report (like if it's actually be Gigabit or whatever, it would need to be converted) but I obviously know nothing really about the language, let alone the framework, just some general programming knowledge and trying to follow the chain while googling anything on the way XD
I checked and I think it's bytes which are downloaded, so we need to write it as `GB` or `GiB`

and btw when checking the code I saw I made really dumb conversion, if you can simplify it would be cool :
https://github.com/ALEZ-DEV/Babylonia-terminal/blob/fb4e47eac72678a114b38f4a0abd8db4e9aec552/babylonia_terminal_launcher/lib/widgets/steps/game_steps_widget.dart#L110-L111

Fix patch:
diff --git a/babylonia_terminal_launcher/CHANGELOG.md b/babylonia_terminal_launcher/CHANGELOG.md
index a71570c..c1c7cd6 100644
--- a/babylonia_terminal_launcher/CHANGELOG.md
+++ b/babylonia_terminal_launcher/CHANGELOG.md
@@ -7,6 +7,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+- Changed "Gb" (which ordinarily would be Gigabits) to "GiB" in the download progress
+
 ## [0.1.2] - 2024-10-28
 
 ### Changed
diff --git a/babylonia_terminal_launcher/lib/widgets/steps/game_steps_widget.dart b/babylonia_terminal_launcher/lib/widgets/steps/game_steps_widget.dart
index c4cb54e..34f5d4b 100644
--- a/babylonia_terminal_launcher/lib/widgets/steps/game_steps_widget.dart
+++ b/babylonia_terminal_launcher/lib/widgets/steps/game_steps_widget.dart
@@ -107,8 +107,9 @@ class _DownloadingGame extends StatelessWidget {
     final provider = Provider.of<Game>(context);
     final pourcent =
         (provider.currentProgress.toInt() / provider.maxProgress.toInt()) * 100;
-    final currentGb = provider.currentProgress.toInt() / 1024 / 1024 / 1024;
-    final maxGb = provider.maxProgress.toInt() / 1024 / 1024 / 1024;
+    //1024^3 = 1073741824 
+    final currentGb = provider.currentProgress.toInt() / 1073741824;
+    final maxGb = provider.maxProgress.toInt() / 1073741824;
 
     return Padding(
       padding: const EdgeInsets.only(bottom: 40.0),
@@ -118,7 +119,7 @@ class _DownloadingGame extends StatelessWidget {
           Padding(
             padding: const EdgeInsets.only(bottom: 8.0),
             child: Text(
-              "${currentGb.toStringAsFixed(2)} / ${maxGb.toStringAsFixed(2)} Gb (${pourcent.toStringAsFixed(2)}%)",
+              "${currentGb.toStringAsFixed(2)} / ${maxGb.toStringAsFixed(2)} GiB (${pourcent.toStringAsFixed(2)}%)",
             ),
           ),
           YaruLinearProgressIndicator(


Test patch: