Repository: cantino/mcfly (language: rust)

Issue:
Vim key scheme - Insert mode by default?
I am really enjoying mcfly.  

I have been using the vim edit mode, but there is one bit that I have yet to get used to: 

After hitting ctrl-r and getting to the mcfly input screen,  I have to press `i` to enter insert mode before typing my search query.  
I can never remember to hit i first, so it is a frustrating experience.  I can't think of a scenario where someone wouldn't want to just start off in insert mode, so could it be made to be the default? 

Thanks. 


Discussion / hints:
I didn't implement vim mode, so I'm not sure. @JamJar00, do you have an opinion?
This has actualy been annoying me recently now I'm back using the Vim scheme.

Starting in normal mode works fine when you have text already typed (e.g. `psql^Rjjj<enter>`) but isn't great if you're starting from an empty buffer (e.g. `^Rpsqljjj<enter>`).

I wonder if an empty buffer should start it in insert mode and a filled buffer should start in normal mode? Could break out another variable to select this behaviour?
Probably best to avoid adding another setting. It seems like it could just start in insert mode always?
The only time I see it being annoying is if you've already typed something and just want to scroll down the list, but that's probably not my majority use case personally.

This should be a pretty simple change to the default value [here](https://github.com/cantino/mcfly/blob/master/src/interface.rs#L91) if we just want to fix it to always open in `insert` mode.
I'm open to this change.

Fix patch:
diff --git a/README.md b/README.md
index 4f5ff53a..5a4fd2eb 100644
--- a/README.md
+++ b/README.md
@@ -159,7 +159,7 @@ When suggesting a command, McFly takes into consideration:
 
 ### Install manually from source
 
-1. [Install Rust 1.29 or later](https://www.rust-lang.org/tools/install)
+1. [Install Rust 1.40 or later](https://www.rust-lang.org/tools/install)
 1. Run `git clone https://github.com/cantino/mcfly` and `cd mcfly`
 1. Run `cargo install --path .`
 1. Ensure `~/.cargo/bin` is in your `$PATH`.
diff --git a/src/interface.rs b/src/interface.rs
index 8cca7102..03b326f2 100644
--- a/src/interface.rs
+++ b/src/interface.rs
@@ -88,7 +88,7 @@ impl<'a> Interface<'a> {
             run: false,
             delete_requests: Vec::new(),
             menu_mode: MenuMode::Normal,
-            in_vim_insert_mode: false,
+            in_vim_insert_mode: true,
         }
     }
 


Test patch: