Repository: scs/substrate-api-client (language: rust)

Issue:
Fix `/// This method is blocking.` comments
There are quite a few function that have the comment `/// This method is blocking.`. However, since the introduction of the async option, that is not always true any more. We should either
1. Remove the comment completely
2. Correct it by stating that this only holds true in the `sync` mode. 


Discussion / hints:

Fix patch:
diff --git a/src/api/rpc_api/author.rs b/src/api/rpc_api/author.rs
index 6208faa16..2d0dc46df 100644
--- a/src/api/rpc_api/author.rs
+++ b/src/api/rpc_api/author.rs
@@ -87,6 +87,8 @@ pub trait SubmitAndWatch {
 
 	/// Submit an extrinsic an return a Subscription
 	/// to watch the extrinsic progress.
+	///
+	/// This method is blocking if the sync-api feature is activated
 	async fn submit_and_watch_extrinsic<Address, Call, Signature, SignedExtra>(
 		&self,
 		extrinsic: UncheckedExtrinsicV4<Address, Call, Signature, SignedExtra>,
@@ -99,6 +101,8 @@ pub trait SubmitAndWatch {
 
 	/// Submit an encoded, opaque extrinsic an return a Subscription to
 	/// watch the extrinsic progress.
+	///
+	/// This method is blocking if the sync-api feature is activated
 	async fn submit_and_watch_opaque_extrinsic(
 		&self,
 		encoded_extrinsic: &Bytes,
@@ -123,7 +127,7 @@ pub trait SubmitAndWatch {
 	/// - extrinsic hash
 	/// - last known extrinsic (transaction) status
 	///
-	/// This method is blocking.
+	/// This method is blocking if the sync-api feature is activated
 	async fn submit_and_watch_extrinsic_until<Address, Call, Signature, SignedExtra>(
 		&self,
 		extrinsic: UncheckedExtrinsicV4<Address, Call, Signature, SignedExtra>,
@@ -154,7 +158,7 @@ pub trait SubmitAndWatch {
 	/// - extrinsic hash
 	/// - last known extrinsic (transaction) status
 	///
-	/// This method is blocking.
+	/// This method is blocking if the sync-api feature is activated
 	async fn submit_and_watch_opaque_extrinsic_until(
 		&self,
 		encoded_extrinsic: &Bytes,
@@ -170,7 +174,8 @@ pub trait SubmitAndWatch {
 	/// - if watched until at least `InBlock`:
 	///   hash of the block the extrinsic was included in
 	/// - last known extrinsic (transaction) status
-	/// This method is blocking.
+	///
+	/// This method is blocking if the sync-api feature is activated
 	async fn submit_and_watch_extrinsic_until_without_events<
 		Address,
 		Call,
@@ -196,7 +201,8 @@ pub trait SubmitAndWatch {
 	/// - if watched until at least `InBlock`:
 	///   hash of the block the extrinsic was included in
 	/// - last known extrinsic (transaction) status
-	/// This method is blocking.
+	///
+	/// This method is blocking if the sync-api feature is activated
 	async fn submit_and_watch_opaque_extrinsic_until_without_events(
 		&self,
 		encoded_extrinsic: &Bytes,


Test patch: