Repository: rusoto/rusoto (language: rust)

Issue:
Remove AsciiExt imports and bump minimum Rust version supported
The fix for https://github.com/rusoto/rusoto/issues/877 involved turning off unused imports as to not break the beta build.  When the current beta channel of Rust becomes stable (EG when Rust stable is 1.23), we should bump our minimum supported version of Rust to 1.12 and remove our AsciiExt imports and turn unused imports back on.


Discussion / hints:
This should be good to go, as Rust 1.23 was just released: https://blog.rust-lang.org/2018/01/04/Rust-1.23.html

Fix patch:
diff --git a/.travis.yml b/.travis.yml
index 1ff54e2010d..f43e1087667 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -5,6 +5,7 @@ language: rust
 cache: cargo
 # run builds for all the trains (and more)
 rust:
+  - 1.23.0 # test against minimum Rust version supported
   - stable
   - beta
   - nightly
diff --git a/CHANGELOG.md b/CHANGELOG.md
index f29dc980753..57aa5315e1d 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -5,8 +5,8 @@
  
 - Allow setting both, Region name and endpoint, via `Region::Custom`
 - Added China-northwest, US-Gov-West & Paris regions
-
 - Switched crategen from rustfmt to rustfmt-nightly
+- Removed unused AsciiExt imports 
 
 ## [0.30.0] - 2017-12-02
 
diff --git a/README.md b/README.md
index 961d1b0e40f..a12427370b8 100644
--- a/README.md
+++ b/README.md
@@ -31,7 +31,7 @@ You may be looking for:
 
 ## Requirements
 
-Rust 1.17.0 or later is required.
+Rust 1.23.0 or later is required.
 
 On Linux, OpenSSL is required.
 
diff --git a/rusoto/core/src/lib.rs b/rusoto/core/src/lib.rs
index baab646f500..2c347cb423b 100644
--- a/rusoto/core/src/lib.rs
+++ b/rusoto/core/src/lib.rs
@@ -3,6 +3,7 @@
 #![cfg_attr(feature = "nightly-testing", plugin(clippy))]
 #![cfg_attr(feature = "nightly-testing", allow(cyclomatic_complexity, used_underscore_binding, ptr_arg, suspicious_else_formatting))]
 #![allow(dead_code)]
+#![cfg_attr(not(feature = "unstable"), deny(warnings))]
 #![deny(missing_docs)]
 
 //! Rusoto is an [AWS](https://aws.amazon.com/) SDK for Rust.
diff --git a/rusoto/core/src/signature.rs b/rusoto/core/src/signature.rs
index 9d618397162..fd50944f1f8 100644
--- a/rusoto/core/src/signature.rs
+++ b/rusoto/core/src/signature.rs
@@ -6,7 +6,6 @@
 //! If needed, the request will be re-issued to a temporary redirect endpoint.  This can happen with
 //! newly created S3 buckets not in us-standard/us-east-1.
 
-use std::ascii::AsciiExt;
 use std::collections::BTreeMap;
 use std::collections::btree_map::Entry;
 use std::str;
diff --git a/rusoto/credential/src/lib.rs b/rusoto/credential/src/lib.rs
index 08d3f983706..a0e9eb4c4e5 100644
--- a/rusoto/credential/src/lib.rs
+++ b/rusoto/credential/src/lib.rs
@@ -1,5 +1,6 @@
 #![cfg_attr(feature = "nightly-testing", feature(plugin))]
 #![cfg_attr(feature = "nightly-testing", plugin(clippy))]
+#![cfg_attr(not(feature = "unstable"), deny(warnings))]
 #![deny(missing_docs)]
 
 //! Types for loading and managing AWS access credentials for API requests.
diff --git a/rusoto/credential/src/profile.rs b/rusoto/credential/src/profile.rs
index af77f8fe31e..b7067c67c75 100644
--- a/rusoto/credential/src/profile.rs
+++ b/rusoto/credential/src/profile.rs
@@ -1,7 +1,6 @@
 //! The Credentials Provider for Credentials stored in a profile inside of a Credentials file.
 
 use regex::Regex;
-use std::ascii::AsciiExt;
 use std::collections::HashMap;
 use std::env::{home_dir, var as env_var};
 use std::fs;


Test patch: