Repository: paritytech/parity-bitcoin (language: rust)

Issue:
Treat compilation errors as errors (not warnings) on CI
see this build: https://gitlab.parity.io/parity/parity-bitcoin/-/jobs/142346

It was marked as "completed with warnings" in #559, though `cargo build` has failed. Probably because `linux-beta-test` and `linux-nightly-test` are allowed to fail AND we do not `cargo build` in `linux-stable-test`?

+ It also seems that regtests aren't running anymore on CI => we need to recover this


Discussion / hints:

Fix patch:
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 160386e70..cd9a380f2 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -45,6 +45,15 @@ linux-stable-test:
   <<:                              *test_tags
   script:
     - rustup default stable
+    - echo 'Building in release mode' && echo -en 'gitlab_fold:start:build.release'
+    - time cargo build --release && strip target/release/pbtc
+    - echo 'gitlab_fold:end:build.release'
+    - echo 'Running regtests from ./tools/regtests.sh' && echo -en 'gitlab_fold:start:regtests'
+    - time ./tools/regtests.sh
+    - echo -en 'gitlab_fold:end:regtests'
+    - echo 'Running bench from ./tools/bench.sh' && echo -en 'gitlab_fold:start:bench'
+    - time ./tools/bench.sh
+    - echo -en 'gitlab_fold:end:bench'
     - echo 'Running tests' && echo -en 'gitlab_fold:start:tests'
     - time cargo test --all
     - echo -en 'gitlab_fold:end:tests'


Test patch:
diff --git a/tools/regtests.sh b/tools/regtests.sh
index effb9f141..7b7a92058 100755
--- a/tools/regtests.sh
+++ b/tools/regtests.sh
@@ -1,6 +1,6 @@
 #!/bin/bash
 
-./target/$CARGO_TARGET/release/pbtc --btc --regtest --db-cache=192 &
+./target/release/pbtc --btc --regtest --db-cache=192 &
 ! java -jar ./tools/compare-tool/pull-tests-be0eef7.jar /tmp/regtest-db 2>&1 | tee regtests-full.log | grep -E --color=auto 'org.bitcoinj.store.BlockStoreException\:|BitcoindComparisonTool.main\: ERROR|bitcoind sent us a block it already had, make sure bitcoind has no blocks!|java.lang.NullPointerException'
 GREP_COLOR="01;32" grep 'BitcoindComparisonTool.main: Block "b1001" completed processing' regtests-full.log
 result=$?