Repository: scs/substrate-api-client (language: rust)

Issue:
Suggestion: Rename substrate-client-keystore to ac-keystore
All our crates are named with ac-.. , where ac is short for `api-client`, except for the substrate-client-keystore. 

ac-keystore was still free at time of writing this issue. Before doing it, one should check if the crate name is still available: https://crates.io/search?q=ac-keystore


Discussion / hints:

Fix patch:
diff --git a/Cargo.lock b/Cargo.lock
index a22582d53..0ec68c28a 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -61,6 +61,22 @@ dependencies = [
  "substrate-api-client",
 ]
 
+[[package]]
+name = "ac-keystore"
+version = "0.10.0"
+dependencies = [
+ "array-bytes",
+ "async-trait",
+ "parking_lot",
+ "sc-keystore",
+ "serde_json",
+ "sp-application-crypto",
+ "sp-core",
+ "sp-keyring",
+ "sp-keystore",
+ "tempfile",
+]
+
 [[package]]
 name = "ac-node-api"
 version = "0.6.0"
@@ -140,11 +156,11 @@ dependencies = [
 name = "ac-testing-sync"
 version = "0.4.0"
 dependencies = [
+ "ac-keystore",
  "sp-application-crypto",
  "sp-core",
  "sp-runtime",
  "substrate-api-client",
- "substrate-client-keystore",
 ]
 
 [[package]]
@@ -7341,22 +7357,6 @@ dependencies = [
  "zeroize",
 ]
 
-[[package]]
-name = "substrate-client-keystore"
-version = "0.10.0"
-dependencies = [
- "array-bytes",
- "async-trait",
- "parking_lot",
- "sc-keystore",
- "serde_json",
- "sp-application-crypto",
- "sp-core",
- "sp-keyring",
- "sp-keystore",
- "tempfile",
-]
-
 [[package]]
 name = "substrate-wasm-builder"
 version = "17.0.0"
diff --git a/Cargo.toml b/Cargo.toml
index e7f72ab0c..fd0316e0b 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -14,7 +14,7 @@ categories = ["no-std", "wasm"]
 [workspace]
 members = [
     ".",
-    "client-keystore",
+    "keystore",
     "compose-macros",
     "examples/async",
     "examples/sync",
diff --git a/client-keystore/Cargo.toml b/keystore/Cargo.toml
similarity index 95%
rename from client-keystore/Cargo.toml
rename to keystore/Cargo.toml
index 35333c26f..a9cec8ac2 100644
--- a/client-keystore/Cargo.toml
+++ b/keystore/Cargo.toml
@@ -1,5 +1,5 @@
 [package]
-name = "substrate-client-keystore"
+name = "ac-keystore"
 version = "0.10.0"
 authors = ["Supercomputing Systems AG <info@scs.ch>"]
 license = "Apache-2.0"
diff --git a/client-keystore/src/keystore_ext.rs b/keystore/src/keystore_ext.rs
similarity index 100%
rename from client-keystore/src/keystore_ext.rs
rename to keystore/src/keystore_ext.rs
diff --git a/client-keystore/src/lib.rs b/keystore/src/lib.rs
similarity index 100%
rename from client-keystore/src/lib.rs
rename to keystore/src/lib.rs


Test patch:
diff --git a/testing/sync/Cargo.toml b/testing/sync/Cargo.toml
index b16026fcf..34c40cd8d 100644
--- a/testing/sync/Cargo.toml
+++ b/testing/sync/Cargo.toml
@@ -13,4 +13,4 @@ sp-runtime = { git = "https://github.com/paritytech/polkadot-sdk.git", branch =
 
 # local deps
 substrate-api-client = { path = "../..", version = "0.17", default-features = false, features = ["tungstenite-client", "ws-client"] }
-substrate-client-keystore = { path = "../../client-keystore" }
+ac-keystore = { path = "../../keystore" }
diff --git a/testing/sync/examples/keystore_tests.rs b/testing/sync/examples/keystore_tests.rs
index ceb3c7915..42fb03224 100644
--- a/testing/sync/examples/keystore_tests.rs
+++ b/testing/sync/examples/keystore_tests.rs
@@ -15,10 +15,10 @@
 
 //! Tests for the author rpc interface functions.
 
+use ac_keystore::{Keystore, KeystoreExt, LocalKeystore};
 use sp_application_crypto::sr25519;
 use sp_core::crypto::{KeyTypeId, Ss58Codec};
 use std::path::PathBuf;
-use substrate_client_keystore::{Keystore, KeystoreExt, LocalKeystore};
 
 pub const KEYSTORE_PATH: &str = "my_keystore";
 pub const SR25519: KeyTypeId = KeyTypeId(*b"sr25");