Repository: seanmonstar/reqwest (language: rust)

Issue:
document the internal Arc
The documentation suggests, that the client should be reused and most people will do this
```rust
Arc::new(Client::new());
```
but this is kinda pointless, because there is already an internal `Arc`.

So maybe this should be mentioned in the docs?


Discussion / hints:
+1. I'm relying on this property in one of my projects, but would be good to know if it's a part of the API or just an implementation detail.
Sure, would be a nice addition to the docs for the `Client` struct.
https://github.com/seanmonstar/reqwest/blob/6433db78b1c961efc23cebc731be06bbb3189d49/src/async_impl/client.rs#L40-L51

Fix patch:
diff --git a/src/async_impl/client.rs b/src/async_impl/client.rs
index 55b1ffdfd..2525a02db 100644
--- a/src/async_impl/client.rs
+++ b/src/async_impl/client.rs
@@ -51,6 +51,11 @@ use crate::{IntoUrl, Method, Proxy, StatusCode, Url};
 ///
 /// The `Client` holds a connection pool internally, so it is advised that
 /// you create one and **reuse** it.
+///
+/// You do **not** have to wrap the `Client` it in an [`Rc`] or [`Arc`] to **reuse** it,
+/// because it already uses an [`Arc`] internally.
+///
+/// [`Rc`]: std::rc::Rc
 #[derive(Clone)]
 pub struct Client {
     inner: Arc<ClientRef>,


Test patch: