Repository: atuinsh/atuin (language: rust)

Issue:
serde_yaml is deprecated
As of the latest release, serde_yaml is deprecated. We need to find a replacement, and swap it out


Discussion / hints:
Seems to be only used in the doctor output, let's rip it out and use either the pretty-print debug formatter with `println!("{:#?}", dump);`, or `serde_json::to_string_pretty`?

The output will be a bit longer, but who cares.
For sure - no rush to swap it out, and this could be a nice first issue for someone

Fix patch:
diff --git a/Cargo.lock b/Cargo.lock
index 9b42ce80618..8e1d45e0016 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -234,7 +234,6 @@ dependencies = [
  "semver",
  "serde",
  "serde_json",
- "serde_yaml",
  "sysinfo",
  "time",
  "tiny-bip39",
@@ -3281,19 +3280,6 @@ dependencies = [
  "syn 2.0.66",
 ]
 
-[[package]]
-name = "serde_yaml"
-version = "0.9.34+deprecated"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "6a8b1a1a2ebf674015cc02edccce75287f1a0130d394307b36743c2f5d504b47"
-dependencies = [
- "indexmap 2.2.6",
- "itoa",
- "ryu",
- "serde",
- "unsafe-libyaml",
-]
-
 [[package]]
 name = "sha1"
 version = "0.10.6"
@@ -4271,12 +4257,6 @@ dependencies = [
  "subtle",
 ]
 
-[[package]]
-name = "unsafe-libyaml"
-version = "0.2.11"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "673aac59facbab8a9007c7f6108d11f63b603f7cabff99fabf650fea5c32b861"
-
 [[package]]
 name = "untrusted"
 version = "0.9.0"
diff --git a/crates/atuin/Cargo.toml b/crates/atuin/Cargo.toml
index 2ec575c06eb..fbd6ebb3f99 100644
--- a/crates/atuin/Cargo.toml
+++ b/crates/atuin/Cargo.toml
@@ -83,7 +83,6 @@ tracing = "0.1"
 tracing-subscriber = { workspace = true }
 uuid = { workspace = true }
 unicode-segmentation = "1.11.0"
-serde_yaml = "0.9.34"
 sysinfo = "0.30.7"
 regex="1.10.4"
 
diff --git a/crates/atuin/src/command/client/doctor.rs b/crates/atuin/src/command/client/doctor.rs
index 4e7bc170752..6bad9a6abcb 100644
--- a/crates/atuin/src/command/client/doctor.rs
+++ b/crates/atuin/src/command/client/doctor.rs
@@ -349,7 +349,7 @@ pub async fn run(settings: &Settings) -> Result<()> {
 
     checks(&dump);
 
-    let dump = serde_yaml::to_string(&dump)?;
+    let dump = serde_json::to_string_pretty(&dump)?;
 
     println!("\nPlease include the output below with any bug reports or issues\n");
     println!("{dump}");


Test patch: