Repository: qarmin/czkawka (language: rust)

Issue:
Strange sentence on CLI “may speed up will cause”
> assigning bigger value may speed up will cause that lower amount of files

It's written here: https://github.com/qarmin/czkawka/blob/e3cea6763453516d251ada0013a32ef41dadc2e8/czkawka_cli/src/commands.rs#L25

I would open a PR but I'm not sure to understand the meaning of this part.


Discussion / hints:
Probably this was something like:
bigger value, slower loading of cache but faster scan
smaller value, faster loading of cache but some files will need to be hashed again

loading < 1million cache entries should take probably on most machines < 1s
Maybe means

"Minimum size of cached files in bytes, setting to bigger value for faster scanning, or smaller value for faster loading yet some files may required to be re-hash again."
I think this could cause less misinterpretations:
"Minimum size of cached files in bytes, a bigger value can make the cache faster at the expense of more small files to be reloaded every time"

Fix patch:
diff --git a/czkawka_cli/src/commands.rs b/czkawka_cli/src/commands.rs
index 16791a67f..c40afcea9 100644
--- a/czkawka_cli/src/commands.rs
+++ b/czkawka_cli/src/commands.rs
@@ -22,7 +22,7 @@ pub enum Commands {
         minimal_file_size: u64,
         #[clap(short = 'i', long, parse(try_from_str = parse_maximal_file_size), default_value = "18446744073709551615", help = "Maximum size in bytes", long_help = "Maximum size of checked files in bytes, assigning lower value may speed up searching")]
         maximal_file_size: u64,
-        #[clap(short = 'c', long, parse(try_from_str = parse_minimal_file_size), default_value = "257144", help = "Minimum cached file size in bytes", long_help = "Minimum size of cached files in bytes, assigning bigger value may speed up will cause that lower amount of files will be cached, but loading of cache will be faster")]
+        #[clap(short = 'c', long, parse(try_from_str = parse_minimal_file_size), default_value = "257144", help = "Minimum cached file size in bytes", long_help = "Minimum size of cached files in bytes, assigning bigger value may speed up the scan but loading the cache will be slower, assigning smaller value may slow down the scan and some files may need to be hashed again but loading the cache will be faster")]
         minimal_cached_file_size: u64,
         #[clap(flatten)]
         allowed_extensions: AllowedExtensions,


Test patch: