Repository: RustCrypto/password-hashes (language: rust)

Issue:
PBKDF2 defult number of rounds not correct?
The following is a snippet from [`simple.rs`](https://github.com/RustCrypto/password-hashes/blob/pbkdf2-v0.12.1/pbkdf2/src/simple.rs#L177-L195):

```rs
impl Params {
    /// Recommended number of PBKDF2 rounds (used by default).
    ///
    /// This number is adopted from the [OWASP cheat sheet]:
    ///
    /// > Use PBKDF2 with a work factor of 600,000 or more
    ///
    /// [OWASP cheat sheet]: https://cheatsheetseries.owasp.org/cheatsheets/Password_Storage_Cheat_Sheet.html
    pub const RECOMMENDED_ROUNDS: usize = 600_000;
}

impl Default for Params {
    fn default() -> Params {
        Params {
            rounds: 10_000,
            output_length: 32,
        }
    }
}
```
Is the Default impl correct here? Shouldn't it be something like this instead?
```rs
impl Default for Params {
    fn default() -> Params {
        Params {
            rounds: Self::RECOMMENDED_ROUNDS,
            output_length: 32,
        }
    }
}
```

I'd be happy to send a PR if this is the case.

Side note: The [security advisory](https://github.com/RustCrypto/password-hashes/security/advisories/new) link in `SECURITY.md` does not work.


Discussion / hints:
Yes, please prepare a PR.

Also the security advisory reporting should be enabled now.

Fix patch:
diff --git a/pbkdf2/src/simple.rs b/pbkdf2/src/simple.rs
index 9ed12aac..957f00b1 100644
--- a/pbkdf2/src/simple.rs
+++ b/pbkdf2/src/simple.rs
@@ -188,7 +188,7 @@ impl Params {
 impl Default for Params {
     fn default() -> Params {
         Params {
-            rounds: 10_000,
+            rounds: Self::RECOMMENDED_ROUNDS as u32,
             output_length: 32,
         }
     }


Test patch: