Repository: ansible/ansible-navigator (language: python)

Issue:
`pull-policy` should be a dictionary in the settings (`pull: policy: ""`)
Just like pull_arguments, see PR below




Discussion / hints:

Fix patch:
diff --git a/docs/changelog-fragments.d/1029.breaking.md b/docs/changelog-fragments.d/1029.breaking.md
new file mode 100644
index 000000000..deafcd5cf
--- /dev/null
+++ b/docs/changelog-fragments.d/1029.breaking.md
@@ -0,0 +1,12 @@
+Moved the configuration of ``pull-policy`` under the ``pull`` key
+in the settings file.
+
+Here is a sample:
+```yaml
+ansible-navigator
+  execution-environment:
+    pull:
+      policy: never
+```
+
+-- by {user}`cidrblock`
diff --git a/src/ansible_navigator/configuration_subsystem/navigator_configuration.py b/src/ansible_navigator/configuration_subsystem/navigator_configuration.py
index f3f1ce038..4aa207a06 100644
--- a/src/ansible_navigator/configuration_subsystem/navigator_configuration.py
+++ b/src/ansible_navigator/configuration_subsystem/navigator_configuration.py
@@ -488,7 +488,7 @@ class Internals(SimpleNamespace):
             name="pull_policy",
             choices=["always", "missing", "never", "tag"],
             cli_parameters=CliParameters(short="--pp"),
-            settings_file_path_override="execution-environment.pull-policy",
+            settings_file_path_override="execution-environment.pull.policy",
             short_description=(
                 "Specify the image pull policy."
                 " always:Always pull the image,"


Test patch:
diff --git a/tests/fixtures/unit/configuration_subsystem/ansible-navigator.yml b/tests/fixtures/unit/configuration_subsystem/ansible-navigator.yml
index 0449d0cd8..71094635f 100644
--- a/tests/fixtures/unit/configuration_subsystem/ansible-navigator.yml
+++ b/tests/fixtures/unit/configuration_subsystem/ansible-navigator.yml
@@ -41,10 +41,10 @@ ansible-navigator:
         KEY2: VALUE2
         KEY3: VALUE3
     image: test_image:latest
-    pull-policy: never
     pull:
       arguments:
         - "--tls-verify=false"
+      policy: never
     volume-mounts:
       - src: "/test1"
         dest: "/test1"