Repository: plannigan/columbo (language: python)

Issue:
Removing deprecated validator signature
- Removed the legacy validator signature
- Updated the tests to account for this
- Updated the docs
- Update the change log

closes #40 


Discussion / hints:
# [Codecov](https://codecov.io/gh/wayfair-incubator/columbo/pull/123?src=pr&el=h1) Report
> Merging [#123](https://codecov.io/gh/wayfair-incubator/columbo/pull/123?src=pr&el=desc) (b349d8d) into [main](https://codecov.io/gh/wayfair-incubator/columbo/commit/bb8eb6a3c63637577f4163de16cb8ff884f59657?el=desc) (bb8eb6a) will **decrease** coverage by `0.07%`.
> The diff coverage is `100.00%`.

> :exclamation: Current head b349d8d differs from pull request most recent head 240eb5a. Consider uploading reports for the commit 240eb5a to get more accurate results

```diff
@@            Coverage Diff             @@
##             main     #123      +/-   ##
==========================================
- Coverage   96.72%   96.64%   -0.08%     
==========================================
  Files           6        6              
  Lines         336      328       -8     
  Branches       39       37       -2     
==========================================
- Hits          325      317       -8     
  Misses          9        9              
  Partials        2        2              
```

| [Impacted Files](https://codecov.io/gh/wayfair-incubator/columbo/pull/123?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [columbo/\_interaction.py](https://codecov.io/gh/wayfair-incubator/columbo/pull/123/diff?src=pr&el=tree#diff-Y29sdW1iby9faW50ZXJhY3Rpb24ucHk=) | `99.25% <100.00%> (-0.05%)` | :arrow_down: |
| [columbo/\_types.py](https://codecov.io/gh/wayfair-incubator/columbo/pull/123/diff?src=pr&el=tree#diff-Y29sdW1iby9fdHlwZXMucHk=) | `100.00% <100.00%> (ø)` | |

@fhightower @plannigan this PR LGTM, I can't merge, so feel free to merge at your leisure! 

Fix patch:
diff --git a/CHANGELOG.md b/CHANGELOG.md
index dd641d49..8c64264b 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -83,10 +83,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [0.11.0] - 2021-08-04
 
-### Changed
-
-- Removed legacy validator signature and logic
-
 ### Added
 
 - `value_if_not_asked` kwarg for `Question` interactions to set a value if the question is not asked ([#169](https://github.com/plannigan/columbo/pull/169))
@@ -97,6 +93,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 * `dataclasses` was not listed as a dependency for versions of Python < 3.7
 
+### Removed
+
+- Support for `Validator`s that return `Optional[str]`
+
 ## [0.10.0] - 2021-02-18
 
 ### Added


Test patch:
diff --git a/tests/cli_test.py b/tests/cli_test.py
index a7d85452..1c47767d 100644
--- a/tests/cli_test.py
+++ b/tests/cli_test.py
@@ -304,8 +304,7 @@ def test_to_answer__basic_question_value_not_valid__exception():
     ]
 
     with pytest.raises(CliException):
-        with pytest.deprecated_call():
-            to_answers(questions, Namespace(**{SOME_NAME: SOME_STRING}))
+        to_answers(questions, Namespace(**{SOME_NAME: SOME_STRING}))
 
 
 def test_to_answer__basic_question_dont_ask__value_not_stored():