Repository: lbl-srg/funnel (language: python)

Issue:
Untrack results in tests/test_bin
Testing python wrapper with `COMMAND ${Python_EXECUTABLE} "${CMAKE_SOURCE_DIR}/pyfunnel/pyfunnel.py" ${TEST_ARGS_0}` may yield results that differ between different platforms, at floating-point number precision.

However, this is not the purpose of this test which rather checks that the library is properly loaded and that the function call `lib.compareAndReport` succeeds. Numerical behavior is tested through the set of `test_numerics*`.

This ticket is to add `tests/test_bin/results/*` to `.gitignore`.


Discussion / hints:

Fix patch:
diff --git a/.github/workflows/cmake.yml b/.github/workflows/cmake.yml
index fb5e35cc..6df4aac2 100644
--- a/.github/workflows/cmake.yml
+++ b/.github/workflows/cmake.yml
@@ -82,6 +82,4 @@ jobs:
           git config --global user.email $GH_USERNAME@users.noreply.github.com
           git config --global pull.rebase false
           git add ${{ github.workspace }}/pyfunnel/lib
-          git diff-index --quiet HEAD || git commit -m "Add ${{ matrix.os }} binaries"
-          git pull
-          git push
+          git diff-index --quiet HEAD || { git commit -m "Add ${{ matrix.os }} binaries" && git pull && git push; }
diff --git a/.gitignore b/.gitignore
index 7ca1fa47..f541cdb8 100644
--- a/.gitignore
+++ b/.gitignore
@@ -7,6 +7,7 @@
 # Tests outputs
 tests/**/*.html
 tests/test_numerics*/
+tests/test_bin/results/*
 
 # Generated by CMake
 DartConfiguration.tcl


Test patch:
diff --git a/tests/test_bin/results/errors.csv b/tests/test_bin/results/errors.csv
deleted file mode 100644
index 3f5034ee..00000000
--- a/tests/test_bin/results/errors.csv
+++ /dev/null
@@ -1,22 +0,0 @@
-x,y
-0,0
-0.05,0
-0.1,0
-0.15,0
-0.2,0
-0.25,0
-0.3,0
-0.35,0
-0.4,0
-0.45,0
-0.5,0
-0.55,0
-0.6,0
-0.65,0
-0.7,0
-0.75,0
-0.8,0
-0.85,0
-0.9,0
-0.95,0
-1,0
diff --git a/tests/test_bin/results/lowerBound.csv b/tests/test_bin/results/lowerBound.csv
deleted file mode 100644
index afe5de4d..00000000
--- a/tests/test_bin/results/lowerBound.csv
+++ /dev/null
@@ -1,19 +0,0 @@
-x,y
--0.002,-0.002
-0.052,-0.002
-0.102,0.998
-0.198,0.998
-0.248,-0.002
-0.252,-0.002
-0.302,2.998
-0.348,2.998
-0.398,-0.002
-0.452,-0.002
-0.502,3.998
-0.548,3.998
-0.598,-0.002
-0.652,-0.002
-0.702,0.498
-0.748,0.498
-0.798,-0.002
-1.002,-0.002
diff --git a/tests/test_bin/results/reference.csv b/tests/test_bin/results/reference.csv
deleted file mode 100644
index 134e23ce..00000000
--- a/tests/test_bin/results/reference.csv
+++ /dev/null
@@ -1,22 +0,0 @@
-x,y
-0,0
-0.05,0
-0.1,1
-0.15,1
-0.2,1
-0.25,0
-0.3,3
-0.35,3
-0.4,0
-0.45,0
-0.5,4
-0.55,4
-0.6,0
-0.65,0
-0.7,0.5
-0.75,0.5
-0.8,0
-0.85,0
-0.9,0
-0.95,0
-1,0
diff --git a/tests/test_bin/results/test.csv b/tests/test_bin/results/test.csv
deleted file mode 100644
index 134e23ce..00000000
--- a/tests/test_bin/results/test.csv
+++ /dev/null
@@ -1,22 +0,0 @@
-x,y
-0,0
-0.05,0
-0.1,1
-0.15,1
-0.2,1
-0.25,0
-0.3,3
-0.35,3
-0.4,0
-0.45,0
-0.5,4
-0.55,4
-0.6,0
-0.65,0
-0.7,0.5
-0.75,0.5
-0.8,0
-0.85,0
-0.9,0
-0.95,0
-1,0
diff --git a/tests/test_bin/results/upperBound.csv b/tests/test_bin/results/upperBound.csv
deleted file mode 100644
index c207fcbb..00000000
--- a/tests/test_bin/results/upperBound.csv
+++ /dev/null
@@ -1,18 +0,0 @@
-x,y
--0.002,0.002
-0.048,0.002
-0.098,1.002
-0.202,1.002
-0.249,0.06199999999999956
-0.298,3.002
-0.352,3.002
-0.402,0.002
-0.448,0.002
-0.498,4.002
-0.552,4.002
-0.602,0.002
-0.648,0.002
-0.698,0.502
-0.752,0.502
-0.802,0.002
-1.002,0.002