Repository: virtual-vehicle/pointcloudset (language: python)

Issue:
JOSS Review: Conda file environment name
The name `base` should be avoided since it would install or override the default environment - a name like `pointcloudset` or `pointcloudset-dev` would be a better solution.
https://github.com/virtual-vehicle/pointcloudset/blob/09f7bfe22b11a9fc0ec967c92854f5cf69622529/conda/environment.yml#L1


Discussion / hints:

Fix patch:
diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index fa682181..f9b962a9 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -14,6 +14,11 @@ Added
 - random_down_sample method for pointclouds.
 
 
+Changed
+~~~~~~
+
+- set conda environment name to "pointcloudset" not "base"
+
 
 [0.2.3] - 2021-07-12
 ---------------------
diff --git a/conda/environment.yml b/conda/environment.yml
index b28a8829..b8a0a72c 100644
--- a/conda/environment.yml
+++ b/conda/environment.yml
@@ -1,4 +1,4 @@
-name: base
+name: pointcloudset
 channels:
   - defaults
   - conda-forge
diff --git a/docker/Dockerfile b/docker/Dockerfile
index 95c7d654..7a9c8f60 100644
--- a/docker/Dockerfile
+++ b/docker/Dockerfile
@@ -84,7 +84,7 @@ RUN /opt/conda/bin/conda update -n base -c defaults conda
 RUN if [ -f "/tmp/conda-tmp/environment.yml" ]; then /opt/conda/bin/conda env update -n base -f /tmp/conda-tmp/environment.yml; fi \
     && rm -rf /tmp/conda-tmp \
     # install the kernel to use with jupyter and some extensions
-    && python -m ipykernel install --user --name base
+    && python -m ipykernel install --user --name pointcloudset
 
 # ROSPY loggging configuation file
 COPY docker/python_logging.conf /etc/ros/


Test patch:
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
index ceeb4cb6..9a2105f4 100644
--- a/.github/workflows/tests.yml
+++ b/.github/workflows/tests.yml
@@ -20,7 +20,7 @@ jobs:
             hashFiles('etc/example-environment.yml') }}
       - uses: conda-incubator/setup-miniconda@v2
         with:
-          activate-environment: test
+          activate-environment: pointcloudset
           auto-activate-base: false
           environment-file: conda/environment.yml
           use-only-tar-bz2: true # IMPORTANT: This needs to be set for caching to work properly!