Repository: OpenFreeEnergy/gufe (language: python)

Issue:
test_json_round_trip fails without openff-models pin
https://github.com/OpenFreeEnergy/gufe/actions/runs/4132763872/jobs/7141851982


Discussion / hints:

Fix patch:
diff --git a/environment.yml b/environment.yml
index 0ca1e75b..3c667a9a 100644
--- a/environment.yml
+++ b/environment.yml
@@ -10,6 +10,7 @@ dependencies:
   - openeye-toolkits
   - openff-toolkit
   - openff-units >=0.2.0
+  - openff-models >=0.0.4
   - pip
   - pydantic
   - pytest
@@ -22,5 +23,3 @@ dependencies:
   - pydata-sphinx-theme
   - sphinx-pydantic
   - sphinx-jsonschema==1.15
-  - pip:
-    - git+https://github.com/mikemhenry/openff-models.git@support_nested_models


Test patch:
diff --git a/gufe/tests/test_models.py b/gufe/tests/test_models.py
index 5f98e298..53efd8c4 100644
--- a/gufe/tests/test_models.py
+++ b/gufe/tests/test_models.py
@@ -7,6 +7,7 @@
 import json
 
 from openff.units import unit
+import pytest
 
 from gufe.settings.models import Settings
 
@@ -15,6 +16,7 @@ def test_model_schema():
     Settings.schema_json(indent=2)
 
 
+@pytest.mark.xfail  # issue #125
 def test_json_round_trip(all_settings_path, tmp_path):
     with open(all_settings_path) as fd:
         settings = Settings.parse_raw(fd.read())