Repository: SIPp/pysipp (language: python)

Issue:
Pluggy version 1.0.0 breaks pysipp
```
conftest.py:3: in <module>
    import pysipp
/usr/local/lib/python3.9/dist-packages/pysipp/__init__.py:23: in <module>
    from . import launch, report, plugin, netplug, agent
/usr/local/lib/python3.9/dist-packages/pysipp/plugin.py:9: in <module>
    mng = pluggy.PluginManager('pysipp', implprefix='pysipp')
E   TypeError: __init__() got an unexpected keyword argument 'implprefix'
```

https://pluggy.readthedocs.io/en/latest/changelog.html#deprecations-and-removals


Discussion / hints:
Oof.

I guess we need to port then and [pin to](https://github.com/SIPp/pysipp/blob/master/setup.py#L39) pre-1.0.

Any PR takers 😉 
Hello,
Any solutions for this one? I am stuck here.
I mean I can probably do this but I don't really have the bandwidth atm.
We kinda need some new contribs to step up and take the reigns.
Ahh yeah so I think all that needs to be done is drop the `kwarg` [from here](https://github.com/SIPp/pysipp/blob/master/pysipp/plugin.py#L9).

I'm not entirely sure if that'll fix it but i'm pretty sure [we're already using `HookimplMarker`](https://github.com/SIPp/pysipp/search?q=plugin.hookimpl) throughout the code base so it's just a matter of removing that one bit I think.
I am hoping to be one of your contribs. Just got to step over this hurdle first thing. Thanks for this great repo. Hope more of us can participate.
> Hello, Any solutions for this one? I am stuck here.

I'm no expert but installing the old version of pluggy worked for me:

`pip install 'pluggy==0.11.0' --force-reinstall`
I'm pretty sure this is a super easy fix y'all.

Please someone give it a try 😉 
I have tried @davemcbride suggestion and it worked for me. I honestly didn't understand what @goodboy suggested. Anyways, thanks, guys. Cheers!
> I have tried @davemcbride suggestion and it worked for me. 

So is anyone going to PR this in then 😂 

> I honestly didn't understand what @goodboy suggested. Anyways, thanks, guys. Cheers!

You would make a patch like this:

```
diff --git a/pysipp/plugin.py b/pysipp/plugin.py
index cd88b92..23ce90a 100644
--- a/pysipp/plugin.py
+++ b/pysipp/plugin.py
@@ -6,7 +6,7 @@ import contextlib
 from . import hookspec

 hookimpl = pluggy.HookimplMarker("pysipp")
-mng = pluggy.PluginManager("pysipp", implprefix="pysipp")
+mng = pluggy.PluginManager("pysipp")
 mng.add_hookspecs(hookspec)
 ```
 
 After this patch there's no more issue on `import pysipp`..like i said.

Now the question is whether y'all want to pin to pluggy 1.0 +

Fix patch:
diff --git a/setup.py b/setup.py
index 0b2a5e6..3aa1c21 100755
--- a/setup.py
+++ b/setup.py
@@ -36,7 +36,7 @@
     url="https://github.com/SIPp/pysipp",
     platforms=["linux"],
     packages=["pysipp", "pysipp.cli"],
-    install_requires=["pluggy>=0.11.0"],
+    install_requires=["pluggy>=1.0.0"],
     tests_require=["pytest"],
     entry_points={
         "console_scripts": ["sippfmt=pysipp.cli.sippfmt:main"],


Test patch:
diff --git a/tests/scens/default_with_confpy/pysipp_conf.py b/tests/scens/default_with_confpy/pysipp_conf.py
index 4c63525..518a000 100644
--- a/tests/scens/default_with_confpy/pysipp_conf.py
+++ b/tests/scens/default_with_confpy/pysipp_conf.py
@@ -1,8 +1,15 @@
+import pluggy
+
+hookimpl = pluggy.HookimplMarker("pysipp")
+
+
+@hookimpl
 def pysipp_conf_scen(agents, scen):
     scen.uri_username = "doggy"
     agents["uac"].srcaddr = "127.0.0.1", 5070
 
 
+@hookimpl
 def pysipp_order_agents(agents, clients, servers):
     # should still work due to re-transmissions
     return reversed(list(agents.values()))
diff --git a/tests/test_stack.py b/tests/test_stack.py
index 2520935..15d6d7c 100644
--- a/tests/test_stack.py
+++ b/tests/test_stack.py
@@ -37,7 +37,6 @@ def confpy_included(self, path, xmls, confpy):
     assert len(list(scenwalk())) == 1
 
 
-@pytest.mark.xfail
 def test_confpy_hooks(scendir):
     """Test that hooks included in a confpy file work