Repository: popsim-consortium/stdpopsim (language: python)

Issue:
QC for Anole (AnoCar)
**PR for new species:** #874

If you volunteer to QC this species, please use the checklist below.
While this list is intended to be comprehensive, it may not be exhaustive.
Where relevant, the QC reviewer should identify that parameter values match
those given in the linked citation(s).

The QC reviewer should start a pull request that fills out the test stubs
with independently obtained values. The reviewer may look at the python code
for rationale provided in comments, but should ignore the actual code
as much as possible - comments in the code should give enough information
that it's obvious how to get the correct value from the provided references.
(In particular, we shouldn't copy-paste the value from the code into the test!)

- [ ] Recombination rate.
  - This might be genome-wide, or per-chromosome. Both are fine.
  - Check there's a comment describing where it came from, and/or how calculated.
  - From a publication? Check the value(s) match the publication.
  - Calculated somehow? Average over a recombination map? Redo the calculation.
- [ ] Mutation rate.
  - This might be genome-wide, or per-chromosome. Both are fine.
  - Check there's a comment describing where it came from, and/or how calculated.
  - From a publication? Check the value(s) match the publication.
  - Calculated somehow? Redo the calculation.
- [ ] Recombination map (if present).
  - Does it match the assembly? Liftover is fine, if clearly stated.
  - Is the description/long_description a good summary of how the map was created?
- [ ] Population size.
- [ ] Generation time.

For each citation, check:
- Doi link.
- Is publication a preprint? Is there a peer-reviewed publication instead?
- Is the year correct.
- Is the author correct (spelling, accents/ligatures/etc.)

Citations are required for:
- [ ] Genome reference assembly.
- [ ] Mutation rate.
- [ ] Recombination rate.
- [ ] Recombination map(s) (if relevant).
- [ ] Population size.
- [ ] Generation time.

The final PR should:
- [ ] fill out the test stubs
- [ ] delete the `pytest.mark.skip` lines that make the tests not run
- [ ] make sure they pass, talking to the original author to figure out discrepancies



Discussion / hints:
i'm going to try to do this one

Fix patch:
diff --git a/stdpopsim/catalog/AnoCar/species.py b/stdpopsim/catalog/AnoCar/species.py
index 8a9f225e0..8d653d75d 100644
--- a/stdpopsim/catalog/AnoCar/species.py
+++ b/stdpopsim/catalog/AnoCar/species.py
@@ -75,11 +75,11 @@
     name="Anolis carolinensis",
     common_name="Anole lizard",
     genome=_genome,
-    generation_time=2.5,
+    generation_time=1.5,
     # they live between 1-2 years after they are able to mate
     # they mature 8 to 9 months after they are born
     # can live up to 8 years in captivity
-    population_size=5.34e6,
+    population_size=3.05e6,
     # poulation size caculated from theta caculations
     # theta = 4Neu, theta from table 1
     # Ne averaged across the 5 populations from BourgeoisEtAl


Test patch:
diff --git a/tests/test_AnoCar.py b/tests/test_AnoCar.py
index 289b9ed2f..bbdea139a 100644
--- a/tests/test_AnoCar.py
+++ b/tests/test_AnoCar.py
@@ -21,60 +21,60 @@ def test_common_name(self):
     # independently referring to the citations provided in the
     # species definition, filling in the appropriate values
     # and deleting the pytest "skip" annotations.
-    @pytest.mark.skip("Population size QC not done yet")
     def test_qc_population_size(self):
-        assert self.species.population_size == -1
+        assert self.species.population_size == 3.05e6
 
-    @pytest.mark.skip("Generation time QC not done yet")
     def test_qc_generation_time(self):
-        assert self.species.generation_time == -1
+        assert self.species.generation_time == 1.5
 
 
 class TestGenomeData(test_species.GenomeTestBase):
 
     genome = stdpopsim.get_species("AnoCar").genome
 
-    @pytest.mark.skip("Recombination rate QC not done yet")
+    rec_rate = 1e-8  # placeholder as we wait for map
+
     @pytest.mark.parametrize(
         ["name", "rate"],
         {
-            "1": -1,
-            "2": -1,
-            "3": -1,
-            "4": -1,
-            "5": -1,
-            "6": -1,
-            "LGa": -1,
-            "LGb": -1,
-            "LGc": -1,
-            "LGd": -1,
-            "LGf": -1,
-            "LGg": -1,
-            "LGh": -1,
-            "MT": -1,
+            "1": rec_rate,
+            "2": rec_rate,
+            "3": rec_rate,
+            "4": rec_rate,
+            "5": rec_rate,
+            "6": rec_rate,
+            "LGa": rec_rate,
+            "LGb": rec_rate,
+            "LGc": rec_rate,
+            "LGd": rec_rate,
+            "LGf": rec_rate,
+            "LGg": rec_rate,
+            "LGh": rec_rate,
+            "MT": rec_rate,
         }.items(),
     )
     def test_recombination_rate(self, name, rate):
         assert pytest.approx(rate, self.genome.get_chromosome(name).recombination_rate)
 
-    @pytest.mark.skip("Mutation rate QC not done yet")
+    mu = 2.1e-10
+
     @pytest.mark.parametrize(
         ["name", "rate"],
         {
-            "1": -1,
-            "2": -1,
-            "3": -1,
-            "4": -1,
-            "5": -1,
-            "6": -1,
-            "LGa": -1,
-            "LGb": -1,
-            "LGc": -1,
-            "LGd": -1,
-            "LGf": -1,
-            "LGg": -1,
-            "LGh": -1,
-            "MT": -1,
+            "1": mu,
+            "2": mu,
+            "3": mu,
+            "4": mu,
+            "5": mu,
+            "6": mu,
+            "LGa": mu,
+            "LGb": mu,
+            "LGc": mu,
+            "LGd": mu,
+            "LGf": mu,
+            "LGg": mu,
+            "LGh": mu,
+            "MT": mu,
         }.items(),
     )
     def test_mutation_rate(self, name, rate):