Repository: timo-reymann/python-binary-wheel-builder (language: python)

Issue:
Rename LINUX_GENERIC_x84_64 to LINUX_GENERIC_x86_64
### Description

The WellKnownPlatform definition `LINUX_GENERIC_x84_64` seems to be a typo (it ought to be `x86_64`?)

Putting the issue as feature rather than a bug as it doesn't affect functionality per se and thus many fields weren't applicable, but let me know if you'd rather re-categorize it.

FWIW, for backwards-compatibility it's probably worth keeping `LINUX_GENERIC_x84_64` as an alias in case anyone is already using it.

### References

_No response_


Discussion / hints:

Fix patch:
diff --git a/README.md b/README.md
index a2ba80b..1d9bc88 100644
--- a/README.md
+++ b/README.md
@@ -82,13 +82,13 @@ pipx install binary_wheel_builder[cli]
      asset_name_mapping:
        !WellknownPlatform MAC_SILICON: "mycli-darwin-arm64"
        !WellknownPlatform MAC_INTEL: "mycli-darwin-amd64"
-       !WellknownPlatform LINUX_GENERIC_x84_64: "my-cli-linux-amd64"
+       !WellknownPlatform LINUX_GENERIC_x86_64: "my-cli-linux-amd64"
        !WellKnownPlatform LINUX_GENERIC_aarch64: "my-cli-linux-arm"
      # Supported platforms by the wheel
      platforms:
        - !WellknownPlatform MAC_INTEL
        - !WellknownPlatform MAC_SILICON
-       - !WellknownPlatform LINUX_GENERIC_x84_64
+       - !WellknownPlatform LINUX_GENERIC_x86_64
        - !WellKnownPlatform LINUX_GENERIC_aarch64
    ```
 2. Build your wheel for all platforms
@@ -121,7 +121,7 @@ class MyCliGithubReleaseSource(GithubReleaseBinarySource):
             {
                 well_known_platforms.MAC_SILICON: "mycli-darwin-arm64",
                 well_known_platforms.MAC_INTEL: "mycli-darwin-amd64",
-                well_known_platforms.LINUX_GENERIC_x84_64: "my-cli-linux-amd64",
+                well_known_platforms.LINUX_GENERIC_x86_64: "my-cli-linux-amd64",
                 well_known_platforms.LINUX_GENERIC_aarch64: "my-cli-linux-arm",
             },
             "my_cli/my-cli-bin"
@@ -153,7 +153,7 @@ for result in build_wheel(
             platforms=[
                 well_known_platforms.MAC_INTEL,
                 well_known_platforms.MAC_SILICON,
-                well_known_platforms.LINUX_GENERIC_x84_64,
+                well_known_platforms.LINUX_GENERIC_x86_64,
                 well_known_platforms.LINUX_GENERIC_aarch64
             ]
         ),
diff --git a/binary_wheel_builder/api/well_known_platforms.py b/binary_wheel_builder/api/well_known_platforms.py
index 34ba800..92680c6 100644
--- a/binary_wheel_builder/api/well_known_platforms.py
+++ b/binary_wheel_builder/api/well_known_platforms.py
@@ -7,7 +7,8 @@
 WINDOWS_x86_64 = WheelPlatformIdentifier(platform="win_amd64")
 MAC_INTEL = WheelPlatformIdentifier(platform="macosx_10_9_x86_64")
 MAC_SILICON = WheelPlatformIdentifier(platform="macosx_11_0_arm64")
-LINUX_GENERIC_x84_64 = WheelPlatformIdentifier(platform="manylinux_2_12_x86_64.manylinux2010_x86_64")
+LINUX_GENERIC_x86_64 = WheelPlatformIdentifier(platform="manylinux_2_12_x86_64.manylinux2010_x86_64")
+LINUX_GENERIC_x84_64 = LINUX_GENERIC_x86_64  # backwards compatibility (issue #12)
 LINUX_GENERIC_i386 = WheelPlatformIdentifier(platform="manylinux_2_12_i686.manylinux2010_i686")
 LINUX_GENERIC_armv7a = WheelPlatformIdentifier(platform="manylinux_2_17_armv7l.manylinux2014_armv7l")
 LINUX_GENERIC_aarch64 = WheelPlatformIdentifier(platform="manylinux_2_17_aarch64.manylinux2014_aarch64")


Test patch:
diff --git a/integration_tests/github_releases_test.py b/integration_tests/github_releases_test.py
index 78c8bb6..9bceb26 100644
--- a/integration_tests/github_releases_test.py
+++ b/integration_tests/github_releases_test.py
@@ -16,7 +16,7 @@ def __init__(self, version: str):
                              well_known_platforms.MAC_SILICON: "buf-Darwin-arm64",
                              well_known_platforms.MAC_INTEL: "buf-Darwin-x86_64",
                              well_known_platforms.WINDOWS_x86_64: "buf-Windows-x86_64.exe",
-                             well_known_platforms.LINUX_GENERIC_x84_64: "buf-Linux-x86_64",
+                             well_known_platforms.LINUX_GENERIC_x86_64: "buf-Linux-x86_64",
                              well_known_platforms.LINUX_GENERIC_aarch64: "buf-Linux-aarch64",
                              well_known_platforms.LINUX_GENERIC_armv7a: "buf-Linux-aarch64",
                          },
@@ -30,7 +30,7 @@ def __init__(self, version: str):
                          {
                              well_known_platforms.MAC_SILICON: "deterministic-zip_darwin-arm64",
                              well_known_platforms.MAC_INTEL: "deterministic-zip_darwin-amd64",
-                             well_known_platforms.LINUX_GENERIC_x84_64: "deterministic-zip_linux-amd64",
+                             well_known_platforms.LINUX_GENERIC_x86_64: "deterministic-zip_linux-amd64",
                              well_known_platforms.LINUX_GENERIC_aarch64: "deterministic-zip_linux-arm",
                              well_known_platforms.LINUX_GENERIC_armv7a: "deterministic-zip_linux-arm",
                          },
@@ -64,7 +64,7 @@ def test_buf(self):
                         well_known_platforms.MAC_INTEL,
                         well_known_platforms.WINDOWS_x86_64,
                         well_known_platforms.MAC_SILICON,
-                        well_known_platforms.LINUX_GENERIC_x84_64,
+                        well_known_platforms.LINUX_GENERIC_x86_64,
                     ]
                 ),
                 dist_folder
@@ -108,7 +108,7 @@ def test_zip(self):
                     platforms=[
                         well_known_platforms.MAC_INTEL,
                         well_known_platforms.MAC_SILICON,
-                        well_known_platforms.LINUX_GENERIC_x84_64,
+                        well_known_platforms.LINUX_GENERIC_x86_64,
                     ]
                 ),
                 dist_folder
diff --git a/integration_tests/testdata/wheel.yaml b/integration_tests/testdata/wheel.yaml
index 71536ab..2648c8b 100644
--- a/integration_tests/testdata/wheel.yaml
+++ b/integration_tests/testdata/wheel.yaml
@@ -26,10 +26,10 @@ source: !WheelSource
   asset_name_mapping:
     !WellknownPlatform MAC_SILICON: "deterministic-zip_darwin-arm64"
     !WellknownPlatform MAC_INTEL: "deterministic-zip_darwin-amd64"
-    !WellknownPlatform LINUX_GENERIC_x84_64: "deterministic-zip_linux-amd64"
+    !WellknownPlatform LINUX_GENERIC_x86_64: "deterministic-zip_linux-amd64"
     *python3_libc3_linux_platform: "deterministic-zip_linux-amd64"
 platforms:
   - !WellknownPlatform MAC_INTEL
   - !WellknownPlatform MAC_SILICON
-  - !WellknownPlatform LINUX_GENERIC_x84_64
+  - !WellknownPlatform LINUX_GENERIC_x86_64
   - *python3_libc3_linux_platform
diff --git a/integration_tests/write_test.py b/integration_tests/write_test.py
index 27a63e6..189f0a5 100644
--- a/integration_tests/write_test.py
+++ b/integration_tests/write_test.py
@@ -50,7 +50,7 @@ def test_idempotent_creation(self):
                     well_known_platforms.MAC_INTEL,
                     well_known_platforms.MAC_SILICON,
                     well_known_platforms.LINUX_GENERIC_i386,
-                    well_known_platforms.LINUX_GENERIC_x84_64,
+                    well_known_platforms.LINUX_GENERIC_x86_64,
                     well_known_platforms.LINUX_GENERIC_armv7a,
                     well_known_platforms.LINUX_GENERIC_aarch64,
                 ],