Repository: Yakifo/amqtt (language: python)

Issue:
TestPluginManager fail
the tests in `tests/plugins/test_manager.py` fail. Needs investigating


Discussion / hints:

Fix patch:
diff --git a/pyproject.toml b/pyproject.toml
index 190cee7d..422827c5 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -49,7 +49,7 @@ hbmqtt_sub = 'hbmqtt.scripts.sub_script:main'
 [tool.poetry.plugins]
 
 [tool.poetry.plugins."hbmqtt.test.plugins"]
-"test_plugin" = "tests.plugins.test_manager:TestPlugin"
+"test_plugin" = "tests.plugins.test_manager:EmptyTestPlugin"
 "event_plugin" = "tests.plugins.test_manager:EventTestPlugin"
 "packet_logger_plugin" = "hbmqtt.plugins.logging:PacketLoggerPlugin"
 


Test patch:
diff --git a/tests/plugins/test_manager.py b/tests/plugins/test_manager.py
index fde0f2b5..42ef049c 100644
--- a/tests/plugins/test_manager.py
+++ b/tests/plugins/test_manager.py
@@ -5,8 +5,6 @@
 import logging
 import asyncio
 
-import pytest
-
 from hbmqtt.plugins.manager import PluginManager
 
 formatter = (
@@ -15,7 +13,7 @@
 logging.basicConfig(level=logging.INFO, format=formatter)
 
 
-class TestPlugin:
+class EmptyTestPlugin:
     def __init__(self, context):
         self.context = context
 
@@ -41,16 +39,10 @@ class TestPluginManager(unittest.TestCase):
     def setUp(self):
         self.loop = asyncio.new_event_loop()
 
-    @pytest.mark.xfail(
-        reason="see https://github.com/Yakifo/aio-hbmqtt/issues/15", strict=False
-    )
     def test_load_plugin(self):
         manager = PluginManager("hbmqtt.test.plugins", context=None)
         assert len(manager._plugins) > 0
 
-    @pytest.mark.xfail(
-        reason="see https://github.com/Yakifo/aio-hbmqtt/issues/15", strict=False
-    )
     def test_fire_event(self):
         async def fire_event():
             await manager.fire_event("test")
@@ -62,9 +54,6 @@ async def fire_event():
         plugin = manager.get_plugin("event_plugin")
         assert plugin.object.test_flag
 
-    @pytest.mark.xfail(
-        reason="see https://github.com/Yakifo/aio-hbmqtt/issues/15", strict=False
-    )
     def test_fire_event_wait(self):
         async def fire_event():
             await manager.fire_event("test", wait=True)
@@ -75,9 +64,6 @@ async def fire_event():
         plugin = manager.get_plugin("event_plugin")
         assert plugin.object.test_flag
 
-    @pytest.mark.xfail(
-        reason="see https://github.com/Yakifo/aio-hbmqtt/issues/15", strict=False
-    )
     def test_map_coro(self):
         async def call_coro():
             await manager.map_plugin_coro("test_coro")
@@ -87,9 +73,6 @@ async def call_coro():
         plugin = manager.get_plugin("event_plugin")
         assert plugin.object.test_coro
 
-    @pytest.mark.xfail(
-        reason="see https://github.com/Yakifo/aio-hbmqtt/issues/15", strict=False
-    )
     def test_map_coro_return(self):
         async def call_coro():
             return await manager.map_plugin_coro("ret_coro")
@@ -99,9 +82,6 @@ async def call_coro():
         plugin = manager.get_plugin("event_plugin")
         self.assertEqual(ret[plugin], "TEST")
 
-    @pytest.mark.xfail(
-        reason="see https://github.com/Yakifo/aio-hbmqtt/issues/15", strict=False
-    )
     def test_map_coro_filter(self):
         """
         Run plugin coro but expect no return as an empty filter is given