Repository: teemtee/tmt (language: python)

Issue:
rpminspect, rpmlint errors and warnings
rpminspect fails on current rawhide: https://artifacts.dev.testing-farm.io/e3a16e91-a0d0-4a66-b873-9cc5ecbf7285/

Here is a list issues from rpmlint and rpminspect

#### rpminspect w/ `--release=fc41`:
`/var/tmp/tmt (inode/directory) is world-writable on noarch`


#### rpmlint errors
tmt.noarch: E: env-script-interpreter /usr/share/doc/tmt/examples/redis/test.sh /usr/bin/env bash
- `/usr/bin/` vs `/usr/bin/env` ?
 
tmt.noarch: E: dir-or-file-in-var-tmp /var/tmp/tmt
 - "A file in the package is located in /var/tmp. It's not permitted for packages to install files in this directory."
 
tmt.noarch: E: non-standard-dir-perm /var/tmp/tmt 1777
tmt.noarch: E: non-executable-script /usr/lib/python3.12/site-packages/tmt/templates/script/beakerlib.j2 644 /bin/bash
tmt.noarch: E: non-executable-script /usr/lib/python3.12/site-packages/tmt/templates/script/shell.j2 644 /bin/sh -eux

#### rpmlint warnings
tmt.noarch: W: obsolete-not-provided tmt-report-html
tmt.noarch: W: obsolete-not-provided tmt-report-junit
tmt.noarch: W: obsolete-not-provided tmt-report-polarion
tmt.noarch: W: obsolete-not-provided tmt-report-reportportal
 - Perhaps we can get rid the obsoletes in new Fedora versions?

tmt.noarch: W: incoherent-version-in-changelog 1.32.1 ['1.32.1-1.fc40', '1.32.1-1']
  - Missing dash, release (1.0.0 vs 1.0.0-1)


Discussion / hints:

Fix patch:
diff --git a/tmt.spec b/tmt.spec
index 580a35689c..0df6e9693b 100644
--- a/tmt.spec
+++ b/tmt.spec
@@ -20,8 +20,6 @@ Obsoletes:      tmt-report-reportportal < %{version}-%{release}
 
 Recommends:     bash-completion
 
-%define workdir_root /var/tmp/tmt
-
 %py_provides    python3-tmt
 
 %description
@@ -126,7 +124,6 @@ mkdir -p %{buildroot}%{_mandir}/man1
 install -pm 644 tmt.1 %{buildroot}%{_mandir}/man1
 mkdir -p %{buildroot}%{_datadir}/bash-completion/completions
 install -pm 644 completions/bash/%{name} %{buildroot}%{_datadir}/bash-completion/completions/%{name}
-mkdir -pm 1777 %{buildroot}%{workdir_root}
 mkdir -p %{buildroot}/etc/%{name}/
 install -pm 644 %{name}/steps/provision/mrack/mrack* %{buildroot}/etc/%{name}/
 
@@ -137,7 +134,6 @@ install -pm 644 %{name}/steps/provision/mrack/mrack* %{buildroot}/etc/%{name}/
 %doc README.rst examples
 %{_bindir}/tmt
 %{_mandir}/man1/tmt.1.gz
-%dir %{workdir_root}
 %{_datadir}/bash-completion/completions/%{name}
 
 %files -n tmt+provision-container -f %{_pyproject_ghost_distinfo}


Test patch:
diff --git a/examples/redis/test.sh b/examples/redis/test.sh
index 2b8d618feb..8f21b3c779 100755
--- a/examples/redis/test.sh
+++ b/examples/redis/test.sh
@@ -1,4 +1,4 @@
-#!/usr/bin/env bash
+#!/usr/bin/bash
 
 set -eux