Repository: deephaven/deephaven-plugins (language: python)

Issue:
Fix E2E server log dumping
Server logs are not being dumped properly after E2E tests fail


Discussion / hints:

Fix patch:
diff --git a/docker-compose.yml b/docker-compose.yml
index f78e91799..8b11f5448 100644
--- a/docker-compose.yml
+++ b/docker-compose.yml
@@ -2,6 +2,7 @@ version: '3'
 
 services:
   deephaven-plugins:
+    container_name: deephaven-plugins
     build:
       dockerfile: ./Dockerfile
       pull: true
diff --git a/tools/run_docker.sh b/tools/run_docker.sh
index 649c3b911..d2f9ab056 100755
--- a/tools/run_docker.sh
+++ b/tools/run_docker.sh
@@ -6,11 +6,13 @@ pushd "$(dirname "$0")"
 # Start the containers
 if [[ -z "${CI}" ]]; then
   docker compose run --service-ports --rm --build "$@"
+  exit_code=$?
+  docker compose down
 else
   docker compose run --service-ports --rm --build -e CI=true "$@"
+  exit_code=$?
+  docker compose stop deephaven-plugins
 fi
-exit_code=$?
-docker compose down
 
 # Reset pwd
 popd


Test patch:
diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml
index 26a098adc..37ebc1581 100644
--- a/.github/workflows/e2e.yml
+++ b/.github/workflows/e2e.yml
@@ -34,7 +34,7 @@ jobs:
       - name: Dump server logs
         if: failure()
         run: docker logs deephaven-plugins > /tmp/server-log.txt
-
+  
       - name: Upload server logs
         if: failure()
         uses: actions/upload-artifact@v4