Repository: codalab/codalab-worksheets (language: python)

Issue:
when upload, select 'File upload' by default
Currently, when hit 'a u', need to hit 'down' to select file upload.  Just make file upload the default.
![Screenshot from 2020-06-14 15-10-30](https://user-images.githubusercontent.com/435384/84605311-37cd3200-ae51-11ea-8d4c-56840d9817da.png)



Discussion / hints:
Hmmm I think we had a lengthy thread on why not having a default is necessary. Let me try to find it. 

Fix patch:
diff --git a/frontend/src/components/NavBar.js b/frontend/src/components/NavBar.js
index 6d77f36da..e8304d778 100644
--- a/frontend/src/components/NavBar.js
+++ b/frontend/src/components/NavBar.js
@@ -382,7 +382,7 @@ class NavBar extends React.Component<{
                         )}
                         <Tooltip title='Gallery'>
                             <Link to='/worksheets?name=home'>
-                                <IconButton>
+                                <IconButton aria-label='Gallery'>
                                     <GalleryIcon />
                                 </IconButton>
                             </Link>
diff --git a/frontend/src/components/worksheets/items/ActionButtons.js b/frontend/src/components/worksheets/items/ActionButtons.js
index 46cf130d0..e06bbd1a5 100644
--- a/frontend/src/components/worksheets/items/ActionButtons.js
+++ b/frontend/src/components/worksheets/items/ActionButtons.js
@@ -106,23 +106,6 @@ class ActionButtons extends React.Component<{
                             open={Boolean(uploadAnchor)}
                             onClose={closeUploadMenu}
                         >
-                            {/* we need to hide the first menuItem
-                            but make it available for accessibility
-                            reference: https://snook.ca/archives/
-                            html_and_css/hiding-content-for-accessibility */}
-                            <StyledMenuItem
-                                key='placeholder'
-                                style={{
-                                    position: 'absolute',
-                                    overflow: 'hidden',
-                                    clip: 'rect(0 0 0 0)',
-                                    height: '1px',
-                                    width: '1px',
-                                    margin: '-1px',
-                                    padding: 0,
-                                    border: 0,
-                                }}
-                            />
                             <StyledMenuItem key='file-upload-item' onClick={closeUploadMenu}>
                                 <label
                                     className={classes.uploadLabel}
diff --git a/frontend/src/components/worksheets/items/TableItem/BundleRow.js b/frontend/src/components/worksheets/items/TableItem/BundleRow.js
index 239f11b04..41180afd0 100644
--- a/frontend/src/components/worksheets/items/TableItem/BundleRow.js
+++ b/frontend/src/components/worksheets/items/TableItem/BundleRow.js
@@ -149,7 +149,11 @@ class BundleRow extends Component {
                     />
                 );
                 showDetailButton = (
-                    <IconButton onClick={this.handleDetailClick} style={{ padding: 2 }}>
+                    <IconButton
+                        onClick={this.handleDetailClick}
+                        style={{ padding: 2 }}
+                        aria-label='Expand'
+                    >
                         {showDetail ? <ExpandLessIcon /> : <ExpandMoreIcon />}
                     </IconButton>
                 );


Test patch:
diff --git a/frontend/src/__tests__/__snapshots__/Worksheet.test.js.snap b/frontend/src/__tests__/__snapshots__/Worksheet.test.js.snap
index 01d6be13a..9d9e31a88 100644
--- a/frontend/src/__tests__/__snapshots__/Worksheet.test.js.snap
+++ b/frontend/src/__tests__/__snapshots__/Worksheet.test.js.snap
@@ -800,17 +800,7 @@ Object {
           <li
             class="MuiButtonBase-root-141 MuiListItem-root-225 MuiListItem-default-228 MuiListItem-gutters-233 MuiListItem-button-234 MuiMenuItem-root-222 WithStyles-MenuItem--root-221 MuiMenuItem-gutters-223"
             role="menuitem"
-            style="position: absolute; overflow: hidden; height: 1px; width: 1px; margin: -1px; padding: 0px; border: 0px;"
             tabindex="0"
-          >
-            <span
-              class="MuiTouchRipple-root-237"
-            />
-          </li>
-          <li
-            class="MuiButtonBase-root-141 MuiListItem-root-225 MuiListItem-default-228 MuiListItem-gutters-233 MuiListItem-button-234 MuiMenuItem-root-222 WithStyles-MenuItem--root-221 MuiMenuItem-gutters-223"
-            role="menuitem"
-            tabindex="-1"
           >
             <label
               class="ActionButtons-uploadLabel-114"