Repository: hetznercloud/hcloud-python (language: python)

Issue:
Move hcloud.hcloud module to hcloud._client
## Feature Request

**Is your feature request related to a problem? Please describe.**

The `hcloud.hcloud` module is set as if it can be used by users. We also reexport the Client class in  `hcloud/__init__.py`. 
To have a clear definition of what the API exports and what API are usable by users, we should probably hide the `hcloud.hcloud` module.

**Describe the solution you'd like**

I propose to move the `hcloud.hcloud` module to `hcloud._client`. The `Client` class is already reexported in `hcloud/__init__.py` so most of the user should already use the "new" path.

In addition we can properly define all the exported APIs using the `__all__` array.

**Teachability, Documentation, Adoption, Migration Strategy**

This is a breaking change, should be done for v2.0.0.



Discussion / hints:
This issue has been marked as stale because it has not had recent activity. The bot will close the issue if no further action occurs.
This issue has been marked as stale because it has not had recent activity. The bot will close the issue if no further action occurs.

Fix patch:
diff --git a/hcloud/hcloud.py b/hcloud/hcloud.py
deleted file mode 100644
index 9de1cfe..0000000
--- a/hcloud/hcloud.py
+++ /dev/null
@@ -1,12 +0,0 @@
-from __future__ import annotations
-
-import warnings
-
-warnings.warn(
-    "The 'hcloud.hcloud' module is deprecated, please import from the 'hcloud' module instead (e.g. 'from hcloud import Client').",
-    DeprecationWarning,
-    stacklevel=2,
-)
-
-# pylint: disable=wildcard-import,wrong-import-position,unused-wildcard-import
-from ._client import *  # noqa


Test patch:
diff --git a/tests/unit/test_hcloud.py b/tests/unit/test_hcloud.py
deleted file mode 100644
index c6931d7..0000000
--- a/tests/unit/test_hcloud.py
+++ /dev/null
@@ -1,8 +0,0 @@
-from __future__ import annotations
-
-import pytest
-
-
-def test_deprecated_hcloud_hcloud_module():
-    with pytest.deprecated_call():
-        from hcloud.hcloud import Client  # noqa