Repository: ploxiln/paramiko-ng (language: python)

Issue:
Please remove blowfish usage
We're seeing blowfish warnings now that cryptography has deprecated it.  I assume it is similar if not the same as https://github.com/paramiko/paramiko/issues/2038.  If I get time, I'll dig into the code and submit a PR.  I see that you mentioned completely removing it in #9.  It's time. :)


Discussion / hints:
Bump - We are experiencing this too. A fix would be greatly appreciated :) 

Fix patch:
diff --git a/paramiko/transport.py b/paramiko/transport.py
index ab0c4ceda..115b53f61 100644
--- a/paramiko/transport.py
+++ b/paramiko/transport.py
@@ -172,12 +172,6 @@ class Transport(threading.Thread, ClosingContextManager):
             'block-size': 16,
             'key-size': 32
         },
-        'blowfish-cbc': {
-            'class': algorithms.Blowfish,
-            'mode': modes.CBC,
-            'block-size': 8,
-            'key-size': 16
-        },
         'aes128-cbc': {
             'class': algorithms.AES,
             'mode': modes.CBC,


Test patch:
diff --git a/tests/test_transport.py b/tests/test_transport.py
index 254785a70..df13ad943 100644
--- a/tests/test_transport.py
+++ b/tests/test_transport.py
@@ -169,9 +169,9 @@ def setup_test_server(
     def test_security_options(self):
         o = self.tc.get_security_options()
         self.assertEqual(type(o), SecurityOptions)
-        self.assertTrue(('aes256-cbc', 'blowfish-cbc') != o.ciphers)
-        o.ciphers = ('aes256-cbc', 'blowfish-cbc')
-        self.assertEqual(('aes256-cbc', 'blowfish-cbc'), o.ciphers)
+        self.assertTrue(('aes256-cbc', 'aes192-cbc') != o.ciphers)
+        o.ciphers = ('aes256-cbc', 'aes192-cbc')
+        self.assertEqual(('aes256-cbc', 'aes192-cbc'), o.ciphers)
         try:
             o.ciphers = ('aes256-cbc', 'made-up-cipher')
             self.assertTrue(False)