Repository: metno/pyaerocom (language: python)

Issue:
change obs name from EEA-NRT to EEA-UTD for cams2_83
from the observations session at the CAMS GA, we need to change from EEA-NRT to EEA-UTD (stands for Up-To-Date)


Discussion / hints:

Fix patch:
diff --git a/pyaerocom/scripts/cams2_83/config.py b/pyaerocom/scripts/cams2_83/config.py
index f1d826b38..b88dcdb74 100644
--- a/pyaerocom/scripts/cams2_83/config.py
+++ b/pyaerocom/scripts/cams2_83/config.py
@@ -181,7 +181,7 @@ def get_ignore_list(species):
     obs_id="CAMS2_83.NRT",
     # obs_id="EEAAQeRep.NRT",
     obs_vars=species_list,
-    web_interface_name="EEA-NRT",
+    web_interface_name="EEA-UTD",
     obs_vert_type="Surface",
     read_opts_ungridded=dict(files=[], force_caching=True),
     obs_filters=obs_filters,


Test patch:
diff --git a/tests/cams2_83/test_cams2_83_cli_mos.py b/tests/cams2_83/test_cams2_83_cli_mos.py
index 5c2f8f2d3..b1d19dfeb 100644
--- a/tests/cams2_83/test_cams2_83_cli_mos.py
+++ b/tests/cams2_83/test_cams2_83_cli_mos.py
@@ -37,13 +37,13 @@ def test_eval_mos_standard(tmp_path: Path, coldata_mos: Path, caplog):
     map_dir = tmp_path / "cams2-83/mos-colocated-data/map"
     assert map_dir.is_dir()
 
-    ts_st1 = tmp_path / "cams2-83/mos-colocated-data/ts/AT0ENK1_EEA-NRT-concno2_Surface.json"
+    ts_st1 = tmp_path / "cams2-83/mos-colocated-data/ts/AT0ENK1_EEA-UTD-concno2_Surface.json"
     assert ts_st1.is_file()
 
-    ts_st2 = tmp_path / "cams2-83/mos-colocated-data/ts/AT0ILL1_EEA-NRT-concno2_Surface.json"
+    ts_st2 = tmp_path / "cams2-83/mos-colocated-data/ts/AT0ILL1_EEA-UTD-concno2_Surface.json"
     assert ts_st2.is_file()
 
-    ts_st3 = tmp_path / "cams2-83/mos-colocated-data/ts/XK0012A_EEA-NRT-concno2_Surface.json"
+    ts_st3 = tmp_path / "cams2-83/mos-colocated-data/ts/XK0012A_EEA-UTD-concno2_Surface.json"
     assert ts_st3.is_file()
 
     hm_dir = tmp_path / "cams2-83/mos-colocated-data/hm"
@@ -61,8 +61,8 @@ def test_eval_mos_standard(tmp_path: Path, coldata_mos: Path, caplog):
     cfg_out = tmp_path / "cams2-83/mos-colocated-data/cfg_cams2-83_mos-colocated-data.json"
     assert cfg_out.is_file()
 
-    colfileE = f"{coldata_mos}/cams2-83/mos-colocated-data/ENS/concno2_concno2_MOD-ENS_REF-EEA-NRT_20240301_20240301_hourly_ALL-wMOUNTAINS.nc"
-    colfileM = f"{coldata_mos}/cams2-83/mos-colocated-data/MOS/concno2_concno2_MOD-MOS_REF-EEA-NRT_20240301_20240301_hourly_ALL-wMOUNTAINS.nc"
+    colfileE = f"{coldata_mos}/cams2-83/mos-colocated-data/ENS/concno2_concno2_MOD-ENS_REF-EEA-UTD_20240301_20240301_hourly_ALL-wMOUNTAINS.nc"
+    colfileM = f"{coldata_mos}/cams2-83/mos-colocated-data/MOS/concno2_concno2_MOD-MOS_REF-EEA-UTD_20240301_20240301_hourly_ALL-wMOUNTAINS.nc"
 
     assert "Running Statistics (MOS)" in caplog.text
     assert f"Processing: {colfileE}" in caplog.text
@@ -76,7 +76,7 @@ def test_eval_mos_medianscores(tmp_path: Path, coldata_mos: Path, caplog):
     options = f"season 2024-03-01 2024-03-05 --data-path {tmp_path} --coldata-path {coldata_mos} --cache {tmp_path} --id mos-colocated-data --name 'Test'"
     result = runner.invoke(app, options.split())
     assert result.exit_code == 0
-    fc_out = tmp_path / "cams2-83/mos-colocated-data/forecast/ALL_EEA-NRT-concno2_Surface.json"
+    fc_out = tmp_path / "cams2-83/mos-colocated-data/forecast/ALL_EEA-UTD-concno2_Surface.json"
     assert fc_out.is_file()
     assert "Running CAMS2_83 Specific Statistics" in caplog.text
     assert "Processing Component: concno2"
diff --git a/tests/fixtures/cams2_83/config.py b/tests/fixtures/cams2_83/config.py
index d9c99db8f..37fb717dd 100644
--- a/tests/fixtures/cams2_83/config.py
+++ b/tests/fixtures/cams2_83/config.py
@@ -104,7 +104,7 @@ def dataset(model: str, day: int, start: date, end: date) -> xr.Dataset:
                         "pyaerocom": "0.18.dev0",
                         "CONV!min_num_obs": str(dict(daily=dict(hourly=18))),
                         "resample_how": "None",
-                        "obs_name": "EEA-NRT",
+                        "obs_name": "EEA-UTD",
                         "vert_code": "Surface",
                         "diurnal_only": 0,
                         "zeros_to_nan": 1,
@@ -136,7 +136,7 @@ def dataset(model: str, day: int, start: date, end: date) -> xr.Dataset:
     for model, day in product(("ENS", "MOS"), range(4)):
         path = (
             root
-            / f"cams2-83/mos-colocated-data/CAMS2-83-{model}-day{day}-FC/concno2_concno2_MOD-CAMS2-83-{model}-day{day}-FC_REF-EEA-NRT_{start:%Y%m%d}_{end:%Y%m%d}_hourly_ALL-wMOUNTAINS.nc"
+            / f"cams2-83/mos-colocated-data/CAMS2-83-{model}-day{day}-FC/concno2_concno2_MOD-CAMS2-83-{model}-day{day}-FC_REF-EEA-UTD_{start:%Y%m%d}_{end:%Y%m%d}_hourly_ALL-wMOUNTAINS.nc"
         )
         path.parent.mkdir(exist_ok=True, parents=True)
         dataset(model, day, start, end).to_netcdf(path)
@@ -145,7 +145,7 @@ def dataset(model: str, day: int, start: date, end: date) -> xr.Dataset:
     for model in ("ENS", "MOS"):
         path = (
             root
-            / f"cams2-83/mos-colocated-data/{model}/concno2_concno2_MOD-{model}_REF-EEA-NRT_{start:%Y%m%d}_{start:%Y%m%d}_hourly_ALL-wMOUNTAINS.nc"
+            / f"cams2-83/mos-colocated-data/{model}/concno2_concno2_MOD-{model}_REF-EEA-UTD_{start:%Y%m%d}_{start:%Y%m%d}_hourly_ALL-wMOUNTAINS.nc"
         )
         path.parent.mkdir(exist_ok=True, parents=True)
         ds = dataset(model, 0, start, end)