Repository: StackStorm/st2 (language: python)

Issue:
Use pants managed venv in Makefile
I don't intend to merge this. I want to use this to find any issues with the requirements pants is using and limit them appropriately. So, the changes to the Makefile are quite hacky.


Discussion / hints:
The pants-managed venv does not have PyOpenSSL.
- Apparently that was pulled in by `requests[security]` which was disabled in:
    - requests 2.24 (https://github.com/psf/requests/pull/5443):
        - eww. I didn't realize that the urllib3 module was getting monkey patched with pyopenssl.
    - requests 2.25 (https://github.com/psf/requests/pull/5867)

I don't know if that's related to the timeouts in the integration tests or not.

Nope. That's irrelevant because we're already pinned to requests==2.25.1, so we're only getting pyopenssl because of our pin now. If we dropped that it would probably go away. We can also drop the `[security]` extra since it does nothing.

Fix patch:
diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index 2df2339873..3e6b867cc4 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -9,6 +9,7 @@ Python 3.6 is no longer supported; Stackstorm requires at least Python 3.8.
 Fixed
 ~~~~~
 * Restore Pack integration testing (it was inadvertently skipped) and stop testing against `bionic` and `el7`. #6135
+* Fix Popen.pid typo in st2tests. #6184
 
 Changed
 ~~~~~~~


Test patch:
diff --git a/st2tests/st2tests/base.py b/st2tests/st2tests/base.py
index 6c3a04fb52..7847a93dc8 100644
--- a/st2tests/st2tests/base.py
+++ b/st2tests/st2tests/base.py
@@ -599,7 +599,7 @@ def _stop_running_processes(self):
                 except:
                     stderr = None
 
-                print("Stopping process with pid %s" % (process.id))
+                print("Stopping process with pid %s" % (process.pid))
                 print('Process "%s"' % (process.pid))
                 print("Stdout: %s" % (stdout))
                 print("Stderr: %s" % (stderr))