Repository: xtensor-stack/xtensor (language: python)

Issue:
[CI] Multiple failures in CI on Clang 16.0.6 MSVC
See build logs here: https://github.com/spectre-ns/xtensor/actions/runs/6799496375/job/18485932904


Discussion / hints:
@tdegeus This is a follow up to our previous PR.
The returned error code 0xc0000409 means STATUS_STACK_BUFFER_OVERRUN.
@spectre-ns Could we easily selectively switch-off test and spawn a matrix with different part of the test to see where the issue is? We could run only in windows/clang. I would probably start with commenting all tests, to see if there is no external bug.
Also, do you know if we can jump to clang17 directly?
@tdegeus  More verbose log for our records: https://github.com/spectre-ns/xtensor/actions/runs/6799804278/job/18486905187
> Also, do you know if we can jump to clang17 directly?

I think visual studio is typically behind on clang so I'm inclined to say no. This will likely be encountered in the wild.
> @spectre-ns Could we easily selectively switch-off test and spawn a matrix with different part of the test to see where the issue is? We could run only in windows/clang. I would probably start with commenting all tests, to see if there is no external bug.

I have VS 2022 on my personal computer (Which should have the right version of clang). When I get home from the office, I'll try to reproduce and comment on the failing tests on a WIP PR we can collaborate on.

Fix patch:
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index c87df8d70..ae11f8c5c 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -170,7 +170,7 @@ jobs:
           ninja
 
     - name: Configure using CMake
-      run: cmake -Bbuild -DCMAKE_INSTALL_PREFIX=$CONDA_PREFIX -DBUILD_TESTS=ON -G Ninja
+      run: cmake -Bbuild -DCMAKE_BUILD_TYPE:STRING=Release -DCMAKE_INSTALL_PREFIX=$CONDA_PREFIX -DBUILD_TESTS=ON -G Ninja
 
     - name: Install
       working-directory: build
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 693be0142..92c886dfc 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -7,7 +7,7 @@
 # The full license is in the file LICENSE, distributed with this software. #
 ############################################################################
 
-cmake_minimum_required(VERSION 3.1)
+cmake_minimum_required(VERSION 3.5)
 project(xtensor CXX)
 
 set(XTENSOR_INCLUDE_DIR ${CMAKE_CURRENT_SOURCE_DIR}/include)
diff --git a/README.md b/README.md
index 8f70ee24c..c98905996 100644
--- a/README.md
+++ b/README.md
@@ -1,7 +1,6 @@
 # ![xtensor](docs/source/xtensor.svg)
 
 [![GithubActions](https://github.com/xtensor-stack/xtensor/actions/workflows/ci.yml/badge.svg)](https://github.com/xtensor-stack/xtensor/actions/workflows/ci.yml)
-[![GithubActions](https://github.com/xtensor-stack/xtensor/actions/workflows/ci_extended.yaml/badge.svg)](https://github.com/xtensor-stack/xtensor/actions/workflows/ci_extended.yaml)
 [![Documentation](http://readthedocs.org/projects/xtensor/badge/?version=latest)](https://xtensor.readthedocs.io/en/latest/?badge=latest)
 [![Doxygen -> gh-pages](https://github.com/xtensor-stack/xtensor/workflows/gh-pages/badge.svg)](https://xtensor-stack.github.io/xtensor)
 [![Binder](https://mybinder.org/badge.svg)](https://mybinder.org/v2/gh/xtensor-stack/xtensor/stable?filepath=notebooks%2Fxtensor.ipynb)
diff --git a/benchmark/CMakeLists.txt b/benchmark/CMakeLists.txt
index 412d03644..c5fa3c407 100644
--- a/benchmark/CMakeLists.txt
+++ b/benchmark/CMakeLists.txt
@@ -6,7 +6,7 @@
 # The full license is in the file LICENSE, distributed with this software. #
 ############################################################################
 
-cmake_minimum_required(VERSION 3.1)
+cmake_minimum_required(VERSION 3.5)
 
 if (CMAKE_CURRENT_SOURCE_DIR STREQUAL CMAKE_SOURCE_DIR)
     project(xtensor-benchmark)


Test patch:
diff --git a/test/CMakeLists.txt b/test/CMakeLists.txt
index e6331f759..46127597e 100644
--- a/test/CMakeLists.txt
+++ b/test/CMakeLists.txt
@@ -7,7 +7,7 @@
 # The full license is in the file LICENSE, distributed with this software. #
 ############################################################################
 
-cmake_minimum_required(VERSION 3.1)
+cmake_minimum_required(VERSION 3.5)
 
 if (CMAKE_CURRENT_SOURCE_DIR STREQUAL CMAKE_SOURCE_DIR)
     project(xtensor-test CXX)