Repository: safe-global/safe-eth-py (language: python)

Issue:
Error running tests: `ganache-cli` fails to run (?)
**Describe the bug**
I'm using the latest version of ganache-cli (Ganache CLI v6.12.2 (ganache-core: 2.13.2)), and the tests fail because they cannot connect to the node.

When I check the logs, I see `Unknown argument: chain` in the first line (I assume that's ganache's output).

Also, at the end of the test output:
```
Killing opened Ganache-Cli
./run_tests.sh: line 27: kill: (72561) - No such process
```

**To Reproduce**
Steps to reproduce the behavior:
1. clone the project
2. Install ganache globally
3. execute `./run_tests.sh`

**Expected behavior**
Tests pass




Discussion / hints:
@mmv08 Last version of ganache is `v7.9.1 (@ganache/cli: 0.10.1, @ganache/core: 0.10.1)`

Remember that ganache package is now `ganache` and not `ganache-cli`
> @mmv08 Last version of ganache is `v7.9.1 (@ganache/cli: 0.10.1, @ganache/core: 0.10.1)`
> 
> Remember that ganache package is now `ganache` and not `ganache-cli`

I figured that out, but it was not mentioned anywhere in the readme that a global install of ganache-cli is a requirement. I created a PR that adjusts the script to not rely on global environment and use `npx` :
> npx is a command-line tool that comes with npm (Node Package Manager) and is used to execute JavaScript packages. It allows developers to run a package without having to install it globally or locally. 

Fix patch:
diff --git a/docker-compose.yml b/docker-compose.yml
index 09fb3b88a..ba0867d58 100644
--- a/docker-compose.yml
+++ b/docker-compose.yml
@@ -7,3 +7,8 @@ services:
       - "5432:5432"
     environment:
       POSTGRES_PASSWORD: postgres
+  ganache:
+    image: trufflesuite/ganache:latest
+    ports:
+      - "8545:8545"
+    command: --defaultBalanceEther 10000 --gasLimit 10000000 -a 30 --chain.chainId 1337 --chain.networkId 1337 -d


Test patch:
diff --git a/run_tests.sh b/run_tests.sh
index ea5d15807..af996472f 100755
--- a/run_tests.sh
+++ b/run_tests.sh
@@ -1,32 +1,9 @@
 #!/bin/sh
 # Postgresql and ganache-cli must be running for the tests
 
-ps aux | grep ganache-cli | grep -v grep > /dev/null
-if [ $? -eq 1 ]; then
-    echo 'Running Ganache-Cli'
-    ganache-cli --defaultBalanceEther 10000 --gasLimit 10000000 -a 30 --chain.chainId 1337 --chain.networkId 1337 -d > /dev/null &
-    GANACHE_PID=$!
-    sleep 3
-fi
-
-docker ps | grep '\->5432' > /dev/null
-if [ $? -eq 1 ]; then
-    docker-compose up -d db
-    sleep 3
-    DATABASE_UP=1
-else
-    DATABASE_UP=0
-fi
-
+docker-compose up -d db ganache
+sleep 3
 
 # python manage.py test --settings=config.settings.test
 DJANGO_SETTINGS_MODULE=config.settings.test pytest
-
-if [ ${GANACHE_PID:-0} -gt 1 ]; then
-    echo 'Killing opened Ganache-Cli'
-    kill $GANACHE_PID
-fi
-
-if [ $DATABASE_UP -eq 1 ]; then
-    docker-compose down
-fi
+docker-compose down