Repository: claritychallenge/clarity (language: python)

Issue:
The pip install method does not install msbg_hparams into the msbg folder
As described in the title, when installing pyclarity using pip, the installed msbg folder does not include msbg_hparams that include important json files for the cochlea simulation, and therefore prevents to use any auditory loss simulation since this folder is hard-coded in cochlea.py (line 244). 

I tested with both 0.1.0 and 0.2.0 versions and reproduced the bug each time.

When installing with the git method, the msbg_hparams is included as expected.

Could you fix this in the pipy installer ? 

Best regards,


Discussion / hints:
Dear Eric,

Thanks for pointing this out. We'll get this fixed.

In the meantime, I guess you've found the missing files in the repo, but in
case not I've attached them below

Cheers,

Jon


On Thu, 1 Dec 2022 at 15:11, Éric Bavu ***@***.***> wrote:

> As described in the title, when installing pyclarity using pip, the
> installed msbg folder does not include msbg_hparams that include important
> json files for the cochlea simulation, and therefore prevents to use any
> auditory loss simulation since this folder is hard-coded in cochlea.py
> (line 244).
>
> I tested with both 0.1.0 and 0.2.0 versions and reproduced the bug each
> time.
>
> When installing with the git method, the msbg_hparams is included as
> expected.
>
> Could you fix this in the pipy installer ?
>
> Best regards,
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/claritychallenge/clarity/issues/141>, or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ACO7SJBUZC7ZUXBUTRQQRUDWLC5ZLANCNFSM6AAAAAASQ4T6BI>
> .
> You are receiving this because you are subscribed to this thread.Message
> ID: ***@***.***>
>


-- 
Professor Jon Barker,
Department of Computer Science,
University of Sheffield
+44 (0) 114 222 1824


Fix patch:
diff --git a/.gitignore b/.gitignore
index 7d28241e7..f7a061526 100644
--- a/.gitignore
+++ b/.gitignore
@@ -62,4 +62,7 @@ docs/clarity.*.rst
 docs/recipes.*.rst
 
 # Emacs
-*~
\ No newline at end of file
+*~
+
+# Sound files
+*.wav
\ No newline at end of file
diff --git a/clarity/evaluator/msbg/msbg_hparams/__init__.py b/clarity/evaluator/msbg/msbg_hparams/__init__.py
new file mode 100644
index 000000000..e69de29bb
diff --git a/recipes/cec1/baseline/results/__init__.py b/recipes/cec1/baseline/results/__init__.py
new file mode 100644
index 000000000..e69de29bb
diff --git a/recipes/cec2/baseline/exp/__init__.py b/recipes/cec2/baseline/exp/__init__.py
new file mode 100644
index 000000000..e69de29bb
diff --git a/setup.cfg b/setup.cfg
index 9f83dec92..b91907504 100644
--- a/setup.cfg
+++ b/setup.cfg
@@ -96,7 +96,11 @@ pypi =
 
 [options.package_data]
 
-* = *.mat, *.yaml
+* =
+  *.csv
+  *.json
+  *.mat
+  *.yaml
 
 [flake8]
 ignore = E203, E501, W503


Test patch:
diff --git a/recipes/cpc1/test_listener_responses/__init__.py b/recipes/cpc1/test_listener_responses/__init__.py
new file mode 100644
index 000000000..e69de29bb