Repository: meltano/meltano (language: python)

Issue:
Replace use of flakeheaven with Ruff for pep8-naming
* Disable the flakeheaven plugin in `pyproject.toml`
* Migrate to Ruff's `Nxxx` rules
* Remove additional dependency from `pre-commit-config.yaml`
Replace use of flakeheaven with Ruff for pep8-naming
* Disable the flakeheaven plugin in `pyproject.toml`
* Migrate to Ruff's `Nxxx` rules
* Remove additional dependency from `pre-commit-config.yaml`
Replace use of flakeheaven with Ruff for pep8-naming
* Disable the flakeheaven plugin in `pyproject.toml`
* Migrate to Ruff's `Nxxx` rules
* Remove additional dependency from `pre-commit-config.yaml`
Replace use of flakeheaven with Ruff for pep8-naming
* Disable the flakeheaven plugin in `pyproject.toml`
* Migrate to Ruff's `Nxxx` rules
* Remove additional dependency from `pre-commit-config.yaml`


Discussion / hints:
Hi @edgarrmondragon, Can I work on this?
Go for it @nkclemson!
Hi @edgarrmondragon, Can I work on this?
Go for it @nkclemson!
Hi @edgarrmondragon, Can I work on this?
Go for it @nkclemson!
Hi @edgarrmondragon, Can I work on this?
Go for it @nkclemson!

Fix patch:
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
index 75e3c2efe2..9b36797d5b 100644
--- a/.pre-commit-config.yaml
+++ b/.pre-commit-config.yaml
@@ -103,5 +103,4 @@ repos:
           - flake8-rst-docstrings==0.2.7
           - flake8-string-format==0.3.0
           - flake8-typing-as-t==0.0.3
-          - pep8-naming==0.12.1
           - wemake-python-styleguide==0.16.1
diff --git a/pyproject.toml b/pyproject.toml
index adb72477d2..06ad69ffec 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -183,10 +183,6 @@ statistics = true
 mccabe = [
   "+*",
 ]
-"pep8-naming" = [
-  "+*",
-  "-N818", # Allow Exceptions to have suffix 'Exception' rather than 'Error'
-]
 pycodestyle = [
   "-*", # Covered by Ruff
 ]
@@ -324,9 +320,6 @@ pyflakes = [
   "-D103", # Don't require function docstrings in migrations
   "-D400", # Don't require periods in the first lines of dosctrings
 ]
-"pep8-naming" = [
-  "-N806", # Allow uppercase variable names
-]
 "wemake-python-styleguide" = [
   "-WPS102", # Allow module names starting with numbers
   "-WPS118", # Allow long filenames
@@ -586,6 +579,7 @@ exclude = [
 ignore = [
   "ANN101", # Missing type annotation for `self` in method
   "ANN102", # Missing type annotation for `cls` in class method
+  "N818",   # Allow Exceptions to have suffix 'Exception' rather than 'Error'
   "PT004",  # Add leading underscore to fixtures that do not return anything
   "UP026",  # Replace `mock` import with `unittest.mock` - remove once Python 3.7 support is dropped
   "S310",   # Allow `urllib.open`
@@ -604,6 +598,7 @@ select = [
   "G",   # flake8-logging-format
   "I",   # isort
   "ISC", # flake8-implicit-str-concat
+  "N",   # pep8-naming
   "PT",  # flake8-pytest-style
   "RSE", # flake8-raise
   "S",   # flake8-bandit


Test patch:
diff --git a/tests/meltano/core/logging/test_logging_utils.py b/tests/meltano/core/logging/test_logging_utils.py
index 7ab5fe5832..50b9d78764 100644
--- a/tests/meltano/core/logging/test_logging_utils.py
+++ b/tests/meltano/core/logging/test_logging_utils.py
@@ -20,14 +20,14 @@ async def readline(self) -> bytes:
 
 @pytest.mark.asyncio()
 async def test_capture_subprocess_output():
-    INPUT_LINES = [b"LINE\n", b"LINE 2\n", b"\xed\n"]
-    OUTPUT_LINES = []
+    input_lines = [b"LINE\n", b"LINE 2\n", b"\xed\n"]
+    output_lines = []
 
     class LineWriter:
         def writeline(self, line: str):
-            OUTPUT_LINES.append(line)
+            output_lines.append(line)
 
-    reader = AsyncReader(INPUT_LINES)
+    reader = AsyncReader(input_lines)
 
     await capture_subprocess_output(reader, LineWriter())
-    assert ["LINE\n", "LINE 2\n", "�\n"] == OUTPUT_LINES
+    assert ["LINE\n", "LINE 2\n", "�\n"] == output_lines