Repository: dbeatty10/dbt-mysql (language: python)

Issue:
Remove documentation for MySQL 5.6
### Describe the feature
Remove documentation for MySQL 5.6 since it reached its end of life (EOL) in February 2021.

### Describe alternatives you've considered
An alternative would be to keep this documentation around for some amount of time for folks still using a non-supported version.

### Who will this benefit?
This will benefit people who want less documentation/instructions to read through. Folks that want to see older documentation and gotchas related to MySQL 5.6 can look back at a tagged version.


Discussion / hints:

Fix patch:
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 4932fa1..b9a707c 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,4 +1,5 @@
 ## Unreleased (TBD)
+- Remove integration tests and docs for MySQL 5.6 ([#74](https://github.com/dbeatty10/dbt-mysql/issues/74), [#86](https://github.com/dbeatty10/dbt-mysql/pull/86))
 
 ## dbt-mysql 0.20.0 (March 13, 2022)
 - Support dbt v0.20.0 ([#83](https://github.com/dbeatty10/dbt-mysql/pull/83))
diff --git a/README.md b/README.md
index 1ba7b0a..0ff135a 100644
--- a/README.md
+++ b/README.md
@@ -6,7 +6,6 @@ This is an experimental plugin:
 - We have not tested it extensively
 - Storage engines other than the default of InnoDB are untested
 - Only tested with [dbt-adapter-tests](https://github.com/dbt-labs/dbt-adapter-tests) with the following:
-  - MySQL 5.6
   - MySQL 5.7
   - MySQL 8.0
   - MariaDB 10.5
@@ -19,10 +18,7 @@ Table of Contents
 
    * [Installation](#installation)
    * [Supported features](#supported-features)
-      * [MySQL 8.0](#mysql-80)
-      * [MySQL 5.6 and 5.7](#mysql-56-and-57)
-         * [MySQL 5.6 configuration gotchas](#mysql-56-configuration-gotchas)
-         * [MySQL 5.7 configuration gotchas](#mysql-57-configuration-gotchas)
+      * [MySQL 5.7 configuration gotchas](#mysql-57-configuration-gotchas)
    * [Configuring your profile](#configuring-your-profile)
    * [Notes](#notes)
    * [Running Tests](#running-tests)
@@ -37,7 +33,7 @@ $ pip install dbt-mysql
 
 ### Supported features
 
-| MariaDB 10.5 | MySQL 5.6 / 5.7 | MySQL 8.0 | Feature                     |
+| MariaDB 10.5 | MySQL 5.7 | MySQL 8.0 | Feature                     |
 |:---------:|:---------:|:---:|-----------------------------|
 |     ✅     |     ✅     |  ✅  | Table materialization       |
 |     ✅     |     ✅     |  ✅  | View materialization        |
@@ -51,21 +47,9 @@ $ pip install dbt-mysql
 
 Notes:
 - Ephemeral materializations rely upon [Common Table Expressions](https://en.wikipedia.org/wiki/Hierarchical_and_recursive_queries_in_SQL) (CTEs), which are not supported until MySQL 8.0
-- MySQL 5.6 and 5.7 have some configuration gotchas that affect snapshots (see below).
+- MySQL 5.7 has some configuration gotchas that affect snapshots (see below).
 
-##### MySQL 5.6 configuration gotchas
-
-dbt snapshots might not work properly due to [automatic initialization and updating for `TIMESTAMP`](https://dev.mysql.com/doc/refman/5.6/en/timestamp-initialization.html) if:
-- the output of `SHOW VARIABLES LIKE 'sql_mode'` includes `NO_ZERO_DATE`
-- the output of `SHOW GLOBAL VARIABLES LIKE 'explicit_defaults_for_timestamp'` has a value of `OFF`
-
-A solution is to include the following in a `*.cnf` file:
-```
-[mysqld]
-explicit_defaults_for_timestamp = true
-```
-
-##### MySQL 5.7 configuration gotchas
+#### MySQL 5.7 configuration gotchas
 
 dbt snapshots might not work properly due to [automatic initialization and updating for `TIMESTAMP`](https://dev.mysql.com/doc/refman/5.7/en/timestamp-initialization.html) if:
 - the output of `SHOW VARIABLES LIKE 'sql_mode'` includes `NO_ZERO_DATE`


Test patch:
diff --git a/test/README.md b/test/README.md
index 64539f9..857c0ae 100644
--- a/test/README.md
+++ b/test/README.md
@@ -41,16 +41,6 @@ If you use any bash special characters in your password (like `$`), then you wil
 #### MySQL 8.0
 `docker run --name mysql8.0 --net dev-network -v /Users/YOUR_USERNAME/Develop/mysql_data/8.0:/var/lib/mysql -p 3306:3306 -d -e MYSQL_ROOT_PASSWORD=$DBT_MYSQL_PASSWORD mysql:8.0`
 
-#### MySQL 5.6
-
-Contents of `/Users/YOUR_USERNAME/Develop/mysql_data/5.6/my.cnf`:
-```
-[mysqld]
-explicit_defaults_for_timestamp = true
-```
-
-`docker run --name mysql5.6 --net dev-network -v /Users/YOUR_USERNAME/Develop/mysql_data/5.6:/var/lib/mysql -v /Users/YOUR_USERNAME/Develop/mysql_data/5.6/my.cnf:/etc/my.cnf -p 3308:3306 -d -e MYSQL_ROOT_PASSWORD=$DBT_MYSQL_PASSWORD mysql:5.6`
-
 #### MySQL 5.7
 
 Contents of `/Users/YOUR_USERNAME/Develop/mysql_data/5.7/my.cnf`:
@@ -66,7 +56,7 @@ sql_mode = "ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,ALLOW_INVALID
 
 Run the test specs in this repository:
 ```
-pytest -v test/integration/mysql-5.6.dbtspec && \
+pytest -v test/integration/mariadb-10.5.dbtspec && \
 pytest -v test/integration/mysql-5.7.dbtspec && \
 pytest -v test/integration/mysql-8.0.dbtspec
 ```
diff --git a/test/integration/mysql-5.6.dbtspec b/test/integration/mysql-5.6.dbtspec
deleted file mode 100644
index 890fb5a..0000000
--- a/test/integration/mysql-5.6.dbtspec
+++ /dev/null
@@ -1,25 +0,0 @@
-
-target:
-  type: mysql5
-  port: 3308
-  schema: dbt_test_{{ var('_dbt_random_suffix') }}
-  server: "{{ env_var('DBT_MYSQL_SERVER_NAME', 'localhost') }}"
-  username: "{{ env_var('DBT_MYSQL_USERNAME', 'dbt_username') }}"
-  password: "{{ env_var('DBT_MYSQL_PASSWORD', 'dbt_password') }}"
-
-sequences:
-
-  # List of sequences:
-  # https://github.com/dbt-labs/dbt-adapter-tests/tree/main/pytest_dbt_adapter/sequences
-
-  test_dbt_empty: empty
-  test_dbt_base: base
-  # Ephemeral materializations not supported for MySQL 5.6
-  # test_dbt_ephemeral: ephemeral
-  test_dbt_incremental: incremental
-  test_dbt_snapshot_strategy_timestamp: snapshot_strategy_timestamp
-  test_dbt_snapshot_strategy_check_cols: snapshot_strategy_check_cols
-  test_dbt_data_test: data_test
-  test_dbt_schema_test: schema_test
-  # Ephemeral materializations not supported for MySQL 5.6
-  # test_dbt_ephemeral_data_tests: data_test_ephemeral_models