Repository: obriencj/koji-smoky-dingo (language: python)

Issue:
update action versions
github actions is warning us on some older action versions being used. Let's go through them all and ensure they're all at the most recent version.

current actions in use:
actions/checkout@v3
actions/deploy-pages@v2
actions/download-artifact@v3
actions/setup-python@v4
actions/upload-artifact@v3
actions/upload-pages-artifact@v2
coverallsapp/github-action@v2
github/codeql-action/upload-sarif@v2
next-actions/build-srpm@master
pypa/gh-action-pypi-publish@release/v1
rzr/fediverse-action@master



Discussion / hints:
updated versions to use:

actions/checkout@v4
actions/deploy-pages@v4
actions/download-artifact@v4
actions/setup-python@v5
actions/upload-artifact@v4
actions/upload-pages-artifact@v3
github/codeql-action/upload-sarif@v3

the rest are fine


Fix patch:
diff --git a/.github/workflows/build_docs.yml b/.github/workflows/build_docs.yml
index ceb5a4f..1184965 100644
--- a/.github/workflows/build_docs.yml
+++ b/.github/workflows/build_docs.yml
@@ -16,10 +16,10 @@ jobs:
 
     steps:
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Setup Python
-        uses: actions/setup-python@v4
+        uses: actions/setup-python@v5
         with:
           python-version: 3.9
 
@@ -33,7 +33,7 @@ jobs:
           make docs
 
       - name: Store Documentation
-        uses: actions/upload-pages-artifact@v2
+        uses: actions/upload-pages-artifact@v3
         with:
           path:
             build/sphinx
diff --git a/.github/workflows/build_rpms.yml b/.github/workflows/build_rpms.yml
index 0ca70ae..4eaf9f0 100644
--- a/.github/workflows/build_rpms.yml
+++ b/.github/workflows/build_rpms.yml
@@ -16,10 +16,10 @@ jobs:
 
     steps:
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Setup Python
-        uses: actions/setup-python@v4
+        uses: actions/setup-python@v5
         with:
           python-version: 3.9
 
@@ -44,9 +44,9 @@ jobs:
           specfile: kojismokydingo.spec
 
       - name: Store Source RPM
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
-          name: RPMs
+          name: RPMs-srpm
           path: ${{ steps.srpm.outputs.path }}
 
   build-rpm:
@@ -67,10 +67,10 @@ jobs:
 
     steps:
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Setup Python
-        uses: actions/setup-python@v4
+        uses: actions/setup-python@v5
         with:
           python-version: 3.9
 
@@ -87,9 +87,9 @@ jobs:
           tools/launch-build.sh ${{ matrix.platform }}
 
       - name: Store RPM ${{ matrix.platform }}
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
-          name: RPMs
+          name: RPMs-${{ matrix.platform }}
           path: dist/${{ matrix.platform }}/RPMS/noarch/*.rpm
 
 
diff --git a/.github/workflows/build_wheel.yml b/.github/workflows/build_wheel.yml
index 4bf3cbc..9d63dbf 100644
--- a/.github/workflows/build_wheel.yml
+++ b/.github/workflows/build_wheel.yml
@@ -16,10 +16,10 @@ jobs:
 
     steps:
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Setup Python
-        uses: actions/setup-python@v4
+        uses: actions/setup-python@v5
         with:
           python-version: 3.9
 
@@ -32,7 +32,7 @@ jobs:
           python -B -m build .
 
       - name: Store Wheel
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: Wheel
           path: dist/
diff --git a/.github/workflows/on_nightly.yml b/.github/workflows/on_nightly.yml
index c72376a..731877a 100644
--- a/.github/workflows/on_nightly.yml
+++ b/.github/workflows/on_nightly.yml
@@ -13,10 +13,10 @@ jobs:
 
     steps:
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Setup Python
-        uses: actions/setup-python@v4
+        uses: actions/setup-python@v5
         with:
           python-version: 3.9
 
diff --git a/.github/workflows/on_release.yml b/.github/workflows/on_release.yml
index c477690..69320aa 100644
--- a/.github/workflows/on_release.yml
+++ b/.github/workflows/on_release.yml
@@ -16,10 +16,10 @@ jobs:
 
     steps:
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Setup Python
-        uses: actions/setup-python@v4
+        uses: actions/setup-python@v5
         with:
           python-version: 3.9
 
@@ -33,7 +33,7 @@ jobs:
           cat VERSION >> $GITHUB_STEP_SUMMARY
 
       - name: Store Version
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: Version
           path: VERSION
@@ -43,7 +43,7 @@ jobs:
           make release-notes > release.md
 
       - name: Store Notes
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: Notes
           path: release.md
@@ -75,19 +75,20 @@ jobs:
           sudo apt-get install hub
 
       - name: Fetch Wheel
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: Wheel
           path: dist
 
       - name: Fetch RPMs
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
-          name: RPMs
           path: rpms
+          pattern: RPMs-*
+          merge-multiple: true
 
       - name: Fetch Notes
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: Notes
 
@@ -123,7 +124,7 @@ jobs:
     steps:
       - name: Deploy site
         id: deploy
-        uses: actions/deploy-pages@v2
+        uses: actions/deploy-pages@v4
 
   deploy-pypi:
     name: Upload release to PyPI
@@ -141,7 +142,7 @@ jobs:
 
     steps:
       - name: Fetch python dist content
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: Wheel
           path: dist
@@ -160,10 +161,10 @@ jobs:
 
     steps:
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Fetch python dist content
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: Version
 
diff --git a/.github/workflows/run_bandit.yml b/.github/workflows/run_bandit.yml
index 69be4dd..b0935a2 100644
--- a/.github/workflows/run_bandit.yml
+++ b/.github/workflows/run_bandit.yml
@@ -15,10 +15,10 @@ jobs:
 
     steps:
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Setup Python
-        uses: actions/setup-python@v4
+        uses: actions/setup-python@v5
         with:
           python-version: 3.9
 
@@ -31,7 +31,7 @@ jobs:
         run: tox -e bandit-sarif
 
       - name: Upload Bandit results
-        uses: github/codeql-action/upload-sarif@v2
+        uses: github/codeql-action/upload-sarif@v3
         with:
           category: Bandit
           sarif_file: bandit.sarif


Test patch:
diff --git a/.github/workflows/run_tests.yml b/.github/workflows/run_tests.yml
index 79e5d5a..0d03efc 100644
--- a/.github/workflows/run_tests.yml
+++ b/.github/workflows/run_tests.yml
@@ -15,10 +15,10 @@ jobs:
 
     steps:
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Setup Python
-        uses: actions/setup-python@v4
+        uses: actions/setup-python@v5
         with:
           python-version: 3.9
 
@@ -53,10 +53,10 @@ jobs:
 
     steps:
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Set up Python ${{ matrix.python-version }}
-        uses: actions/setup-python@v4
+        uses: actions/setup-python@v5
         with:
           python-version: ${{ matrix.python-version }}
 
@@ -70,9 +70,9 @@ jobs:
           tox
 
       - name: Store coverage
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
-          name: coverage-data
+          name: coverage-data-py${{ matrix.python-version }}
           path: .coverage.py*
 
   coverage:
@@ -86,10 +86,10 @@ jobs:
 
     steps:
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Set up Python
-        uses: actions/setup-python@v4
+        uses: actions/setup-python@v5
         with:
           python-version: 3.9
 
@@ -98,9 +98,10 @@ jobs:
           pip install coverage
 
       - name: Fetch coverage results
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
-          name: coverage-data
+          pattern: coverage-data-py*
+          merge-multiple: true
 
       - name: Combine and report coverage
         run: |