Repository: bacalhau-project/bacalhau (language: python)

Issue:
Orchestrators shouldn't have default publisher by default
In v1.4.0, the default configuration for requester nodes is to have no default publisher by default as shown in https://github.com/bacalhau-project/bacalhau/blob/v1.4.x/pkg/config/configenv/production.go and in:
```
→ bacalhau config list | egrep "KEY|defaultpublisher"
 KEY                                                             VALUE
 node.requester.defaultpublisher
```

Though now we are changing the behaviour and setting `local` as the default publisher always:
https://github.com/bacalhau-project/bacalhau/blob/1ca678c752371f790e84220e6061e63d3aed5e32/pkg/config/types/default_config.go#L73-L75


Discussion / hints:

Fix patch:
diff --git a/pkg/config/types/default_config.go b/pkg/config/types/default_config.go
index cfc39bd357..9a4f6d5e91 100644
--- a/pkg/config/types/default_config.go
+++ b/pkg/config/types/default_config.go
@@ -5,8 +5,6 @@ import (
 	"path/filepath"
 	"runtime"
 	"time"
-
-	"github.com/bacalhau-project/bacalhau/pkg/publisher/local"
 )
 
 const (
@@ -70,9 +68,6 @@ var Default = Bacalhau{
 					CPU:    "500m",
 					Memory: "1Gb",
 				},
-				Publisher: DefaultPublisherConfig{
-					Config: *local.NewSpecConfig(),
-				},
 			},
 		},
 		Ops: BatchJobDefaultsConfig{
@@ -82,9 +77,6 @@ var Default = Bacalhau{
 					CPU:    "500m",
 					Memory: "1Gb",
 				},
-				Publisher: DefaultPublisherConfig{
-					Config: *local.NewSpecConfig(),
-				},
 			},
 		},
 		Daemon: LongRunningJobDefaultsConfig{


Test patch:
diff --git a/pkg/test/devstack/default_publisher_test.go b/pkg/test/devstack/default_publisher_test.go
index 2e801f365a..95cd797138 100644
--- a/pkg/test/devstack/default_publisher_test.go
+++ b/pkg/test/devstack/default_publisher_test.go
@@ -26,11 +26,6 @@ func TestDefaultPublisherSuite(t *testing.T) {
 }
 
 func (s *DefaultPublisherSuite) TestNoDefaultPublisher() {
-	s.Config.JobDefaults.Batch.Task.Publisher.Config.Type = ""
-	s.Config.JobDefaults.Batch.Task.Publisher.Config.Params = make(map[string]interface{})
-	stack := &scenario.StackConfig{}
-	stack.RequesterConfig.JobDefaults.Batch.Task.Publisher.Config.Type = ""
-	stack.RequesterConfig.JobDefaults.Batch.Task.Publisher.Config.Params = make(map[string]interface{})
 	testcase := scenario.Scenario{
 		Job: &models.Job{
 			Name:  s.T().Name(),
@@ -49,7 +44,6 @@ func (s *DefaultPublisherSuite) TestNoDefaultPublisher() {
 				},
 			},
 		},
-		Stack:          stack,
 		ResultsChecker: expectResultsNone,
 		JobCheckers: []scenario.StateChecks{
 			scenario.WaitForSuccessfulCompletion(),