Repository: grapl-security/grapl (language: python)

Issue:
Revert "Merge pull request #1303 from grapl-security/reenableE2eTesting"
This reverts commit 016ac1f8ec5dba68e4117d10052107ef2213ef99, reversing
changes made to 8d7e612115787d2c699c3f7199f3f9c89079a2de.
Reverts https://github.com/grapl-security/grapl/pull/1303

The reasoning is due to the state described in this Pulumi ticket:
https://github.com/pulumi/pulumi/issues/8562

The plan here is:
remove the delete and then run an update and then re-add the delete

I'll get a successful `provision` run with this revert, and then revert-revert.


Discussion / hints:
# [Codecov](https://codecov.io/gh/grapl-security/grapl/pull/1304?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=grapl-security) Report
> Merging [#1304](https://codecov.io/gh/grapl-security/grapl/pull/1304?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=grapl-security) (3cdde0a) into [main](https://codecov.io/gh/grapl-security/grapl/commit/016ac1f8ec5dba68e4117d10052107ef2213ef99?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=grapl-security) (016ac1f) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/grapl-security/grapl/pull/1304/graphs/tree.svg?width=650&height=150&src=pr&token=HlrWgwYOvc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=grapl-security)](https://codecov.io/gh/grapl-security/grapl/pull/1304?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=grapl-security)

```diff
@@           Coverage Diff           @@
##             main    #1304   +/-   ##
=======================================
  Coverage   44.88%   44.88%           
=======================================
  Files         158      158           
  Lines        7503     7503           
  Branches       23       23           
=======================================
  Hits         3368     3368           
  Misses       4120     4120           
  Partials       15       15           
```



------

[Continue to review full report at Codecov](https://codecov.io/gh/grapl-security/grapl/pull/1304?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=grapl-security).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=grapl-security)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/grapl-security/grapl/pull/1304?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=grapl-security). Last update [016ac1f...3cdde0a](https://codecov.io/gh/grapl-security/grapl/pull/1304?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=grapl-security). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=grapl-security).


Fix patch:
diff --git a/.buildkite/pipeline.provision.yml b/.buildkite/pipeline.provision.yml
index d14c6fbb50..cdb3f096b9 100644
--- a/.buildkite/pipeline.provision.yml
+++ b/.buildkite/pipeline.provision.yml
@@ -34,19 +34,16 @@ steps:
 
   - wait
 
-  # https://github.com/grapl-security/issue-tracker/issues/793
-  # Uncomment once a successful `provision` created a pulumi output
-  # called 'stateful-resource-urns'
-  # - label: ":pulumi: Destroy stateful resources in Staging account"
-  #   plugins:
-  #     - grapl-security/vault-login#v0.1.0
-  #     - grapl-security/vault-env#v0.1.0:
-  #         secrets:
-  #           - PULUMI_ACCESS_TOKEN
-  #   command:
-  #     - .buildkite/scripts/grapl_testing_stack/destroy_stateful_resources.sh grapl/grapl/testing
-  #   agents:
-  #     queue: "pulumi-staging"
+  - label: ":pulumi: Destroy stateful resources in Staging account"
+    plugins:
+      - grapl-security/vault-login#v0.1.0
+      - grapl-security/vault-env#v0.1.0:
+          secrets:
+            - PULUMI_ACCESS_TOKEN
+    command:
+      - .buildkite/scripts/grapl_testing_stack/destroy_stateful_resources.sh grapl/grapl/testing
+    agents:
+      queue: "pulumi-staging"
 
   - wait
 


Test patch:
diff --git a/.buildkite/pipeline.testing.yml b/.buildkite/pipeline.testing.yml
index bc5301a276..dfadf15274 100644
--- a/.buildkite/pipeline.testing.yml
+++ b/.buildkite/pipeline.testing.yml
@@ -17,8 +17,5 @@ steps:
             - PULUMI_ACCESS_TOKEN
     command:
       - .buildkite/scripts/grapl_testing_stack/run_parameterized_job.sh e2e-tests 6
-    # We don't believe the test is currently repeatable until we execute on
-    # https://github.com/grapl-security/issue-tracker/issues/793
-    # But we also don't want these failures blocking the pipeline.
-    # Remove this once 793 is complete.
-    soft_fail: true
+    artifact_paths:
+      - "test_artifacts/**/*"
diff --git a/.buildkite/scripts/grapl_testing_stack/destroy_stateful_resources.sh b/.buildkite/scripts/grapl_testing_stack/destroy_stateful_resources.sh
index 26b7d576e2..0157c6a1d5 100755
--- a/.buildkite/scripts/grapl_testing_stack/destroy_stateful_resources.sh
+++ b/.buildkite/scripts/grapl_testing_stack/destroy_stateful_resources.sh
@@ -55,6 +55,7 @@ pulumi destroy \
     --non-interactive \
     --diff \
     --yes \
+    --refresh \
     --message="Destroying stateful resources" \
     --target-dependents \
     "${target_args[@]}"