Repository: damar-wicaksono/uqtestfuns (language: python)

Issue:
Fix input_dimension filtering in list_functions()
The filtering logic now correctly utilizes the `input_dimension` argument in the `list_functions()`. Previously, this argument was ineffective;
passing any value will give an empty list.

This PR should resolve Issue #426.


Discussion / hints:
## [Codecov](https://app.codecov.io/gh/damar-wicaksono/uqtestfuns/pull/437?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Damar+Wicaksono) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 98.90%. Comparing base [(`4725ba2`)](https://app.codecov.io/gh/damar-wicaksono/uqtestfuns/commit/4725ba259ac51d6786a739dd87141ac140c9c800?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Damar+Wicaksono) to head [(`0f43106`)](https://app.codecov.io/gh/damar-wicaksono/uqtestfuns/commit/0f431060a180024ced1794491e28d36a5aa24b43?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Damar+Wicaksono).
> Report is 10 commits behind head on dev.

<details><summary>Additional details and impacted files</summary>


```diff
@@            Coverage Diff             @@
##              dev     #437      +/-   ##
==========================================
+ Coverage   98.88%   98.90%   +0.02%     
==========================================
  Files          77       78       +1     
  Lines        2684     2739      +55     
  Branches      176      176              
==========================================
+ Hits         2654     2709      +55     
  Misses         16       16              
  Partials       14       14              
```

</details>

[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/damar-wicaksono/uqtestfuns/pull/437?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Damar+Wicaksono).   
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Damar+Wicaksono).


Fix patch:
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 776aa49..f71bc47 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -54,6 +54,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## Fixed
 
+- The fifth input variable of the Friedman is now active instead of the sixth.
+  Only the first five input variables of the Friedman functions are active.
 - The argument `input_dimension` to filter the output of `list_functions()`
   is now effective and does not always return zero result.
 


Test patch:
diff --git a/src/uqtestfuns/test_functions/friedman.py b/src/uqtestfuns/test_functions/friedman.py
index 5ec5ddf..03d89c7 100644
--- a/src/uqtestfuns/test_functions/friedman.py
+++ b/src/uqtestfuns/test_functions/friedman.py
@@ -80,8 +80,9 @@ def evaluate_friedman(xx: np.ndarray) -> np.ndarray:
     Parameters
     ----------
     xx : np.ndarray
-        6-Dimensional input values given by an N-by-6 array
-        where N is the number of input values.
+        6-Dimensional input values given by an N-by-M array
+        where N is the number of input values and M >= 5 is the number of
+        input dimensions.
 
     Returns
     -------
@@ -89,11 +90,15 @@ def evaluate_friedman(xx: np.ndarray) -> np.ndarray:
         The output of the six-dimensional Friedman function evaluated
         on the input values.
         The output is a 1-dimensional array of length N.
+
+    Notes
+    -----
+    - Only the first five input variables are active; the rest is inactive.
     """
     yy_1 = 10 * np.sin(np.pi * xx[:, 0] * xx[:, 1])
     yy_2 = 20 * (xx[:, 2] - 0.5) ** 2
     yy_3 = 10 * xx[:, 3]
-    yy_4 = 5 * xx[:, 5]
+    yy_4 = 5 * xx[:, 4]
 
     return yy_1 + yy_2 + yy_3 + yy_4