Repository: coderedcorp/wagtail-seo (language: python)

Issue:
Confusing struct_org_logo help text
In `struct_org_logo`, the help text is "Leave blank to use the logo in Settings > Layout > Logo".
But I don't see any Layout settings nor any mechanism for the `seo_logo` getter to use a fallback image


Discussion / hints:
Good catch. This package was original built-in to our other package `coderedcms`, and split out sometime in 2018/2019. I think that help text is a holdover from that.

The help text should be removed as the developer will need to choose the default logo when implementing it on their site.
I can propose the following help text, using the google organizational data struct definition constraints:
`"Logo representative of the organisation. Must be 112x112px minimum;  take note that it will be displayed on a white background"`
Sounds good to me!

Fix patch:
diff --git a/wagtailseo/models.py b/wagtailseo/models.py
index fa475a7..7aee70f 100644
--- a/wagtailseo/models.py
+++ b/wagtailseo/models.py
@@ -95,7 +95,10 @@ class Meta:
         on_delete=models.SET_NULL,
         related_name="+",
         verbose_name=_("Organization logo"),
-        help_text=_("Leave blank to use the logo in Settings > Layout > Logo"),
+        help_text=_(
+            "Logo representative of the organisation. Must be 112x112px minimum; "
+            "take note that it will be displayed on a white background"
+        ),
     )
     struct_org_image = models.ForeignKey(
         get_image_model_string(),


Test patch:
diff --git a/testproject/home/migrations/0004_alter_articlepage_struct_org_logo_and_more.py b/testproject/home/migrations/0004_alter_articlepage_struct_org_logo_and_more.py
new file mode 100644
index 0000000..438d03f
--- /dev/null
+++ b/testproject/home/migrations/0004_alter_articlepage_struct_org_logo_and_more.py
@@ -0,0 +1,30 @@
+# Generated by Django 4.0.10 on 2024-06-14 21:03
+
+from django.db import migrations, models
+import django.db.models.deletion
+
+
+class Migration(migrations.Migration):
+    dependencies = [
+        ('wagtailimages', '0024_index_image_file_hash'),
+        ('home', '0003_alter_articlepage_struct_org_actions_and_more'),
+    ]
+
+    operations = [
+        migrations.AlterField(
+            model_name='articlepage',
+            name='struct_org_logo',
+            field=models.ForeignKey(blank=True,
+                                    help_text='Logo representative of the organisation. Must be 112x112px minimum; take note that it will be displayed on a white background',
+                                    null=True, on_delete=django.db.models.deletion.SET_NULL, related_name='+',
+                                    to='wagtailimages.image', verbose_name='Organization logo'),
+        ),
+        migrations.AlterField(
+            model_name='seopage',
+            name='struct_org_logo',
+            field=models.ForeignKey(blank=True,
+                                    help_text='Logo representative of the organisation. Must be 112x112px minimum; take note that it will be displayed on a white background',
+                                    null=True, on_delete=django.db.models.deletion.SET_NULL, related_name='+',
+                                    to='wagtailimages.image', verbose_name='Organization logo'),
+        ),
+    ]
diff --git a/testproject/manage.py b/testproject/manage.py
old mode 100644
new mode 100755