Repository: robotframework/SeleniumLibrary (language: python)

Issue:
Acceptance tests: rebot option `--noncritical` is deprecated since RF 4
[`--noncritical`](https://github.com/robotframework/SeleniumLibrary/blob/master/atest/run.py#L100) is deprecated and ignored in RF 4 and a warning is issued. The option is completely removed in RF 5 and causes tests to fail.

This doesn't show up in Actions because they only test RF 3 & 4 with Chrome and even the tests tagged `Known Issue Chrome` actually pass.


Discussion / hints:

Fix patch:
diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml
index 75d50ab30..ab1718f21 100644
--- a/.github/workflows/CI.yml
+++ b/.github/workflows/CI.yml
@@ -12,9 +12,9 @@ jobs:
         rf-version: [3.2.2, 4.1.3]
 
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v3
     - name: Set up Python ${{ matrix.python-version }} with Robot Framework ${{ matrix.rf-version }}
-      uses: actions/setup-python@v2
+      uses: actions/setup-python@v4
       with:
         python-version: ${{ matrix.python-version }}
     - name: Start xvfb


Test patch:
diff --git a/atest/acceptance/windows.robot b/atest/acceptance/windows.robot
index b9a6c5d38..48a45d694 100644
--- a/atest/acceptance/windows.robot
+++ b/atest/acceptance/windows.robot
@@ -95,14 +95,14 @@ Get and Set Inner Window Size with Frames
     ...    Set Window Size         ${400}    ${300}    ${True}
 
 Get and Set Window Position
-    [Tags]  Known Issue Chrome    Known Issue Safari
+    [Tags]    Known Issue Safari
     Set Window Position    ${300}    ${200}
     ${x}    ${y}=    Get Window Position
     Should Be Equal    ${x}    ${300}
     Should Be Equal    ${y}    ${200}
 
 Set Window Position using strings
-    [Tags]  Known Issue Chrome    Known Issue Safari
+    [Tags]    Known Issue Safari
     Set Window Position    200    100
     ${x}    ${y}=    Get Window Position
     Should Be Equal    ${x}    ${200}
diff --git a/atest/run.py b/atest/run.py
index 583d801a2..d02d516e9 100755
--- a/atest/run.py
+++ b/atest/run.py
@@ -97,8 +97,6 @@
 REBOT_OPTIONS = [
     "--outputdir",
     RESULTS_DIR,
-    "--noncritical",
-    "known issue {browser}",
 ]
 
 
@@ -208,6 +206,7 @@ def execute_tests(interpreter, browser, rf_options, grid, event_firing):
     options.extend([opt.format(browser=browser) for opt in ROBOT_OPTIONS])
     if rf_options:
         options += rf_options
+    options += ["--exclude", f"known issue {browser.replace('headless', '')}"]
     command = runner
     if grid:
         command += [