Repository: grapl-security/grapl (language: python)

Issue:
Enable the stateful resources destroy step in E2E-in-AWS
<!-- Thank you for your contribution to Grapl! Please take some time
to fill out this short template to help us review and understand your
PR. -->

### Which issue does this PR correspond to?
Satisfies and closes out https://github.com/grapl-security/issue-tracker/issues/793
In doing so, may also close out https://github.com/grapl-security/issue-tracker/issues/770

<!-- Please provide a link to the GitHub Issue this pull request is
meant to address. -->

### What changes does this PR make to Grapl? Why?
- Uncomment the "stateful resources destroy" buildkite step, now that its precursor has been fulfilled (a certain pulumi output exists)
- (oops, forgot to add a thing about artifacts)

<!-- Please describe the functional impact of these changes and the
rationale behind them. This will help us understand your approach to
solving the problem. -->

### How were these changes tested?
they weren't

<!-- Please describe how these changes were tested. There should be
sufficient detail that reviewers can replicate your testing
procedure. If the procedure is a manual one that's OK, your
description will help us work with you to get it automated. -->



Discussion / hints:
# [Codecov](https://codecov.io/gh/grapl-security/grapl/pull/1303?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=grapl-security) Report
> Merging [#1303](https://codecov.io/gh/grapl-security/grapl/pull/1303?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=grapl-security) (0bb762a) into [main](https://codecov.io/gh/grapl-security/grapl/commit/8d7e612115787d2c699c3f7199f3f9c89079a2de?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=grapl-security) (8d7e612) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/grapl-security/grapl/pull/1303/graphs/tree.svg?width=650&height=150&src=pr&token=HlrWgwYOvc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=grapl-security)](https://codecov.io/gh/grapl-security/grapl/pull/1303?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=grapl-security)

```diff
@@           Coverage Diff           @@
##             main    #1303   +/-   ##
=======================================
  Coverage   44.88%   44.88%           
=======================================
  Files         158      158           
  Lines        7503     7503           
  Branches       23       23           
=======================================
  Hits         3368     3368           
  Misses       4120     4120           
  Partials       15       15           
```



------

[Continue to review full report at Codecov](https://codecov.io/gh/grapl-security/grapl/pull/1303?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=grapl-security).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=grapl-security)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/grapl-security/grapl/pull/1303?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=grapl-security). Last update [8d7e612...0bb762a](https://codecov.io/gh/grapl-security/grapl/pull/1303?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=grapl-security). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=grapl-security).


Fix patch:
diff --git a/.buildkite/pipeline.provision.yml b/.buildkite/pipeline.provision.yml
index cdb3f096b9..d14c6fbb50 100644
--- a/.buildkite/pipeline.provision.yml
+++ b/.buildkite/pipeline.provision.yml
@@ -34,16 +34,19 @@ steps:
 
   - wait
 
-  - label: ":pulumi: Destroy stateful resources in Staging account"
-    plugins:
-      - grapl-security/vault-login#v0.1.0
-      - grapl-security/vault-env#v0.1.0:
-          secrets:
-            - PULUMI_ACCESS_TOKEN
-    command:
-      - .buildkite/scripts/grapl_testing_stack/destroy_stateful_resources.sh grapl/grapl/testing
-    agents:
-      queue: "pulumi-staging"
+  # https://github.com/grapl-security/issue-tracker/issues/793
+  # Uncomment once a successful `provision` created a pulumi output
+  # called 'stateful-resource-urns'
+  # - label: ":pulumi: Destroy stateful resources in Staging account"
+  #   plugins:
+  #     - grapl-security/vault-login#v0.1.0
+  #     - grapl-security/vault-env#v0.1.0:
+  #         secrets:
+  #           - PULUMI_ACCESS_TOKEN
+  #   command:
+  #     - .buildkite/scripts/grapl_testing_stack/destroy_stateful_resources.sh grapl/grapl/testing
+  #   agents:
+  #     queue: "pulumi-staging"
 
   - wait
 


Test patch:
diff --git a/.buildkite/pipeline.testing.yml b/.buildkite/pipeline.testing.yml
index dfadf15274..bc5301a276 100644
--- a/.buildkite/pipeline.testing.yml
+++ b/.buildkite/pipeline.testing.yml
@@ -17,5 +17,8 @@ steps:
             - PULUMI_ACCESS_TOKEN
     command:
       - .buildkite/scripts/grapl_testing_stack/run_parameterized_job.sh e2e-tests 6
-    artifact_paths:
-      - "test_artifacts/**/*"
+    # We don't believe the test is currently repeatable until we execute on
+    # https://github.com/grapl-security/issue-tracker/issues/793
+    # But we also don't want these failures blocking the pipeline.
+    # Remove this once 793 is complete.
+    soft_fail: true