Repository: python-control/Slycot (language: python)

Issue:
Missing test_X.py files in slycot/tests/CMakeLists.txt
Currently, there are 20 test_X.py files in the "slycot/tests" folder, but only 17 in the "slycot/tests/CMakeLists.txt".
https://github.com/python-control/Slycot/blob/master/slycot/tests/CMakeLists.txt

It made no difference whether all 20 or 17 files were listed in CMakeLists.txt.

pytest --pyargs executed all tests.

What is the slycot/tests/CMakeLists.txt file needed for?


Discussion / hints:
Good catch. The `install(FILES <pythonfiles> ...)` are redundant and ignored/overruled by scikit-build.

Fix patch:
diff --git a/MANIFEST.in b/MANIFEST.in
index b8c04e7c..cd90447e 100644
--- a/MANIFEST.in
+++ b/MANIFEST.in
@@ -7,7 +7,6 @@ include CMakeLists.txt
 include pyproject.toml
 include conda-recipe/*
 include slycot/CMakeLists.txt
-include slycot/tests/CMakeLists.txt
 include slycot/*.py
 include slycot/src/*.f
 include slycot/tests/*.py
diff --git a/slycot/CMakeLists.txt b/slycot/CMakeLists.txt
index eb49edd1..37b4d34d 100644
--- a/slycot/CMakeLists.txt
+++ b/slycot/CMakeLists.txt
@@ -630,12 +630,6 @@ set(F2PYSOURCE_DEPS
   src/transform.pyf src/synthesis.pyf
   src/_helper.pyf)
 
-set(PYSOURCE
-
-  __init__.py  examples.py exceptions.py
-  analysis.py math.py synthesis.py transform.py
-)
-
 set(SLYCOT_MODULE "_wrapper")
 
 set(GENERATED_MODULE
@@ -681,6 +675,3 @@ endif()
 python_extension_module(${SLYCOT_MODULE})
 
 install(TARGETS ${SLYCOT_MODULE} LIBRARY DESTINATION slycot)
-install(FILES ${PYSOURCE} DESTINATION slycot)
-
-add_subdirectory(tests)


Test patch:
diff --git a/slycot/tests/CMakeLists.txt b/slycot/tests/CMakeLists.txt
deleted file mode 100644
index 80d751da..00000000
--- a/slycot/tests/CMakeLists.txt
+++ /dev/null
@@ -1,23 +0,0 @@
-set(PYSOURCE
-
-  __init__.py
-  test_ab01.py
-  test_ab04md.py
-  test_ab08n.py
-  test_ag08bd.py
-  test_examples.py
-  test_exceptions.py
-  test_mb.py
-  test_mc.py
-  test_sb.py
-  test_analysis.py
-  test_transform.py
-  test_sg02ad.py
-  test_sg03ad.py
-  test_tb05ad.py
-  test_td04ad.py
-  test_tg01ad.py
-  test_tg01fd.py )
-
-install(FILES ${PYSOURCE}
-        DESTINATION slycot/tests)