Repository: fission/fission (language: go)

Issue:
Error creating mqtrigger of type gcp-pubsub due to wrong env variable name
The `GCP-PUB-SUB` environment variable present under `mqtrigger-keda` deployment should not have a hyphen `-` between pub and sub. As defined in [keda](https://keda.sh/docs/2.5/scalers/gcp-pub-sub/), it must be `gcp-pubsub`

Currently this creates an issue while creating a `mqtrigger` of type `gcp-pubsub`.

Actual: 
```
 - name: GCP-PUB-SUB_IMAGE
          value: fission/keda-gcp-pubsub-http-connector:v0.3
```

Expected:
```
 - name: GCP-PUBSUB_IMAGE
          value: fission/keda-gcp-pubsub-http-connector:v0.3
```


Discussion / hints:
Hi @techmaharaj. This issue belongs to fission repository so I am transferring it there.

Fix patch:
diff --git a/charts/fission-all/templates/mqt-keda/deployment.yaml b/charts/fission-all/templates/mqt-keda/deployment.yaml
index 3807c68667..deeb5d2167 100644
--- a/charts/fission-all/templates/mqt-keda/deployment.yaml
+++ b/charts/fission-all/templates/mqt-keda/deployment.yaml
@@ -40,8 +40,8 @@ spec:
           value: "{{ .Values.mqt_keda.connector_images.aws_sqs.image }}:{{ .Values.mqt_keda.connector_images.aws_sqs.tag }}"
         - name: STAN_IMAGE
           value: "{{ .Values.mqt_keda.connector_images.nats_steaming.image }}:{{ .Values.mqt_keda.connector_images.nats_steaming.tag }}"
-        - name: GCP-PUB-SUB_IMAGE
-          value: "{{ .Values.mqt_keda.connector_images.gcp_pub_sub.image }}:{{ .Values.mqt_keda.connector_images.gcp_pub_sub.tag }}"
+        - name: GCP-PUBSUB_IMAGE
+          value: "{{ .Values.mqt_keda.connector_images.gcp_pubsub.image }}:{{ .Values.mqt_keda.connector_images.gcp_pubsub.tag }}"
         - name: REDIS_IMAGE
           value: "{{ .Values.mqt_keda.connector_images.redis.image }}:{{ .Values.mqt_keda.connector_images.redis.tag }}"
         {{- include "opentracing.envs" . | indent 8 }}
diff --git a/charts/fission-all/values.yaml b/charts/fission-all/values.yaml
index c68df7cf0f..c76abfd30f 100644
--- a/charts/fission-all/values.yaml
+++ b/charts/fission-all/values.yaml
@@ -676,7 +676,7 @@ mqt_keda:
     nats_steaming:
       image: fission/keda-nats-streaming-http-connector
       tag: v0.9
-    gcp_pub_sub:
+    gcp_pubsub:
       image: fission/keda-gcp-pubsub-http-connector
       tag: v0.3
     redis:


Test patch: