Repository: gohugoio/hugo (language: go)

Issue:
Regression related to HTML comments inside of Markdown blocks
I hit a regression on Hugo 0.94.1 related to comments, so it's probably due to the fix for #9650 and thus https://github.com/yuin/goldmark/issues/285. The error is:

```
[BUG] goldmark: runtime error: index out of range [73] with length 73: create an issue on GitHub attaching the file in: /var/folders/1d/bxcn0jrn65b1ry6v3vb2124r0000gp/T/hugo_bugs/goldmark_866979f02bdfd7b7803dee8213c41300.txt
```

The failing markdown is:

```
- This is a list item <!-- Comment: an innocent-looking comment -->
```


Discussion / hints:
While trying to get a minimal testcase for this, I also noticed that the file referred to in that error message doesn't get updated unless you trash it. So someone who has hit an error twice may end up uploading a stale example.
Thanks for the report. This looks like it could be an issue with Goldmark. Could you create an issue at https://github.com/yuin/goldmark/issues and link back to this issue so we could track it?
Tempted to go back to 1.4.7 and stay there for a while...
Yea, well, it's not happening this weekend.

Fix patch:
diff --git a/go.mod b/go.mod
index cacafa240cd..ed59a6871d4 100644
--- a/go.mod
+++ b/go.mod
@@ -58,7 +58,7 @@ require (
 	github.com/spf13/jwalterweatherman v1.1.0
 	github.com/spf13/pflag v1.0.5
 	github.com/tdewolff/minify/v2 v2.10.0
-	github.com/yuin/goldmark v1.4.9
+	github.com/yuin/goldmark v1.4.10
 	go.uber.org/atomic v1.9.0
 	gocloud.dev v0.20.0
 	golang.org/x/image v0.0.0-20211028202545-6944b10bf410
diff --git a/go.sum b/go.sum
index 93c1565bf87..5edeee53646 100644
--- a/go.sum
+++ b/go.sum
@@ -583,6 +583,8 @@ github.com/yuin/goldmark v1.4.8 h1:zHPiabbIRssZOI0MAzJDHsyvG4MXCGqVaMOwR+HeoQQ=
 github.com/yuin/goldmark v1.4.8/go.mod h1:rmuwmfZ0+bvzB24eSC//bk1R1Zp3hM0OXYv/G2LIilg=
 github.com/yuin/goldmark v1.4.9 h1:RmdXMGe/HwhQEWIjFAu8fjjvkxJ0tDRVbWGrsPNrclw=
 github.com/yuin/goldmark v1.4.9/go.mod h1:rmuwmfZ0+bvzB24eSC//bk1R1Zp3hM0OXYv/G2LIilg=
+github.com/yuin/goldmark v1.4.10 h1:+WgKGo8CQrlMTRJpGCFCyNddOhW801TKC2QijVV9QVg=
+github.com/yuin/goldmark v1.4.10/go.mod h1:rmuwmfZ0+bvzB24eSC//bk1R1Zp3hM0OXYv/G2LIilg=
 go.etcd.io/etcd/api/v3 v3.5.1/go.mod h1:cbVKeC6lCfl7j/8jBhAK6aIYO9XOjdptoxU/nLQcPvs=
 go.etcd.io/etcd/client/pkg/v3 v3.5.1/go.mod h1:IJHfcCEKxYu1Os13ZdwCwIUTUVGYTSAM3YSwc9/Ac1g=
 go.etcd.io/etcd/client/v2 v2.305.1/go.mod h1:pMEacxZW7o8pg4CrFE7pquyCJJzZvkvdD2RibOCCCGs=


Test patch:
diff --git a/markup/goldmark/integration_test.go b/markup/goldmark/integration_test.go
index 064ffb85d1a..e1d1445ee15 100644
--- a/markup/goldmark/integration_test.go
+++ b/markup/goldmark/integration_test.go
@@ -536,8 +536,7 @@ Link https procol: https://www.example.org
 	}
 }
 
-// Issue 9650
-func TestRenderingOfHtmlComments(t *testing.T) {
+func TestGoldmarkBugs(t *testing.T) {
 	t.Parallel()
 
 	files := `
@@ -548,8 +547,16 @@ unsafe = true
 ---
 title: "p1"
 ---
+
+## Issue 9650
+
 a <!-- b --> c
 
+## Issue 9658
+
+- This is a list item <!-- Comment: an innocent-looking comment -->
+
+
 -- layouts/_default/single.html --
 {{ .Content }}
 `
@@ -562,6 +569,9 @@ a <!-- b --> c
 	).Build()
 
 	b.AssertFileContentExact("public/p1/index.html",
+		// Issue 9650
 		"<p>a <!-- b --> c</p>",
+		// Issue 9658 (crash)
+		"<li>This is a list item <!-- Comment: an innocent-looking comment --></li>",
 	)
 }