Repository: syncthing/syncthing (language: go)

Issue:
lib/logger: Add date marker
With our default time-only log format it's annoying to read logs spanning more than a day because the timestamps become ambiguous, especially when there isn't much output to begin with. This adds a `Day changed to 2022-04-13` type log entry at local midnight.



Discussion / hints:
Just a suggestion, but wouldn't it be preferable to simply change the default format to add both date and time (i.e. `-logflags=3`) to the log? This is what I've been using since forever, as without it I found the logs basically useless for any serious inspection, and doing so would also make it consistent with the logs shown in the Web GUI, which display both time and date by default.
Agreed, I prefer having a date over having some obscure line somewhere burried.

Fix patch:
diff --git a/cmd/syncthing/main.go b/cmd/syncthing/main.go
index 3b9cfe59bc6..f248b3b9800 100644
--- a/cmd/syncthing/main.go
+++ b/cmd/syncthing/main.go
@@ -68,9 +68,9 @@ The --logflags value is a sum of the following:
    8  Long filename
   16  Short filename
 
-I.e. to prefix each log line with date and time, set --logflags=3 (1 + 2 from
-above). The value 0 is used to disable all of the above. The default is to
-show time only (2).
+I.e. to prefix each log line with time and filename, set --logflags=18 (2 + 16
+from above). The value 0 is used to disable all of the above. The default is
+to show date and time (3).
 
 Logging always happens to the command line (stdout) and optionally to the
 file at the path specified by --logfile=path. In addition to an path, the special
@@ -187,7 +187,7 @@ type serveOptions struct {
 func defaultVars() kong.Vars {
 	vars := kong.Vars{}
 
-	vars["logFlags"] = strconv.Itoa(log.Ltime)
+	vars["logFlags"] = strconv.Itoa(logger.DefaultFlags)
 	vars["logMaxSize"] = strconv.Itoa(10 << 20) // 10 MiB
 	vars["logMaxFiles"] = "3"                   // plus the current one
 
diff --git a/lib/logger/logger.go b/lib/logger/logger.go
index 731be426b09..ecf20fd41ea 100644
--- a/lib/logger/logger.go
+++ b/lib/logger/logger.go
@@ -31,7 +31,7 @@ const (
 )
 
 const (
-	DefaultFlags = log.Ltime
+	DefaultFlags = log.Ltime | log.Ldate
 	DebugFlags   = log.Ltime | log.Ldate | log.Lmicroseconds | log.Lshortfile
 )
 


Test patch: