Repository: microsoft/terminal (language: cpp)

Issue:
Acrylic Broken
### Windows Terminal version

1.13.10336.0

### Windows build number

Microsoft Windows [Version 10.0.19044.1503]

### Other Software

_No response_

### Steps to reproduce

1. Install The Latest Version Of Windows Terminal Preview On Windows 10.
2. Boom, Title bar Acrylic Broken

### Expected Behavior

Acrylic On Title Bar Works

### Actual Behavior

Acrylic Title Bar Very White


Discussion / hints:
Could you share your [settings.json file](https://github.com/microsoft/terminal/wiki/Frequently-Asked-Questions-(FAQ)#where-can-i-find-the-settings-file)?

Does acrylic work anywhere else in the OS?



In case it's not a coincidence, it could be an [AMD driver issue](https://old.reddit.com/r/Amd/comments/s1o19w/radeon_software_adrenalin_2211_release_notes/hsb8jjt/?context=10000).
@zadjii-msft I've been facing the same issue since the v1.13.10336 release of Terminal Preview yesterday. The acrylic has stopped working inside Terminal Preview, and works fine everywhere else in the system. 

I have the `"useAcrylic"` set to `True` under `"defaults"` of `"profiles"` in the settings.json, and it used to work just fine prior to this update. 

Attaching my settings.json here (_attached as a TEXT file since GitHub doesn't seem to support JSON file uploads_): [settings.txt](https://github.com/microsoft/terminal/files/8001655/settings.txt)
@zadjii-msft This issue resolved itself after a restart. Not sure how, but I don't have the problem anymore. 
Huh. Weird. Well, hopefully it was just a one off glitch 😅 
> Could you share your [settings.json file](https://github.com/microsoft/terminal/wiki/Frequently-Asked-Questions-(FAQ)#where-can-i-find-the-settings-file)?
> 
> Does acrylic work anywhere else in the OS?

How Do I Check Acrylic?

Settings.json:
[settings.txt](https://github.com/microsoft/terminal/files/8005191/settings.txt)

> @zadjii-msft I've been facing the same issue since the v1.13.10336 release of Terminal Preview yesterday. The acrylic has stopped working inside Terminal Preview, and works fine everywhere else in the system.
> 
> I have the `"useAcrylic"` set to `True` under `"defaults"` of `"profiles"` in the settings.json, and it used to work just fine prior to this update.
> 
> Attaching my settings.json here (_attached as a TEXT file since GitHub doesn't seem to support JSON file uploads_): [settings.txt](https://github.com/microsoft/terminal/files/8001655/settings.txt)

That Removed All Acrylic For Me

Update: Only Once
Wanted to report that this issue happens to me as well. I have `"useAcrylic": true` under `defaults`, and `"useAcrylicInTabRow": true` as well. The outcome is that the tab row is significantly brighter/whiter than previous versions, even though it does show a  bit of the acrylic effect. 

In addition, setting `"theme": "dark"` doesn't change the tab row color - still the same bright white, which is weird. The tab row should be dark acrylic in this case.

I'm using a laptop with Intel CPU/GPU and NVIDIA GPU. By default it's Intel GPU rendering.
Maybe It's NVIDIA Issue
> Maybe It's NVIDIA Issue

No, it's not. I already clarified that it is using Intel GPU to render. Plus, this problem doesn't exist in any previous versions - nor in any other apps using acrylic - on my computer.

I hope you won't say it is an Intel issue then - I don't want this thread to go from blaming AMD to blaming NVIDIA to blaming Intel... That would be a little excessive ;P
Sorry I Didn't see that
Drop-Down Acrylic Works
Title Bar Acrylic Actually Still Works, Just Very White
Can I get a screenshot? I wanna know exactly what I'm looking for here. Light theme + acrylic titlebar does seem... off... in Windows 10, but I'm not sure that's what you're reporting here. 


<details>
<summary>OPs settings</summary>

```jsonc
{
    "$help": "https://aka.ms/terminal-documentation",
    "$schema": "https://aka.ms/terminal-profiles-schema",
    "actions": [
        {
            "command": {
                "action": "copy",
                "singleLine": false
            },
            "keys": "ctrl+c"
        },
        {
            "command": "paste",
            "keys": "ctrl+v"
        },
        {
            "command": "find",
            "keys": "ctrl+shift+f"
        },
        {
            "command": {
                "action": "splitPane",
                "split": "auto",
                "splitMode": "duplicate"
            },
            "keys": "alt+shift+d"
        }
    ],
    "alwaysOnTop": true,
    "alwaysShowNotificationIcon": false,
    "copyFormatting": "all",
    "copyOnSelect": false,
    "defaultProfile": "{0caa0dad-35be-5f56-a8ff-afceeeaa6101}",
    "minimizeToNotificationArea": true,
    "profiles": {
        "defaults": {
            "colorScheme": "Campbell White",
            "useAcrylic": true,
            "font": {
                "face": "CaskaydiaCove Nerd Font"
            }
        },
        "list": [
            {
                "backgroundImage": "C:\\Users\\mukul\\Pictures\\Icons\\CommandPromptB1.gif",
                "colorScheme": "Campbell White",
                "commandline": "%SystemRoot%\\System32\\cmd.exe",
                "font": {
                    "face": "CaskaydiaCove Nerd Font"
                },
                "guid": "{0caa0dad-35be-5f56-a8ff-afceeeaa6101}",
                "hidden": false,
                "name": "Command Prompt"
            },
            {
                "backgroundImage": "C:\\Users\\mukul\\Pictures\\Icons\\PowerShellB2.gif",
                "colorScheme": "Campbell Powershell White",
                "commandline": "%SystemRoot%\\System32\\WindowsPowerShell\\v1.0\\powershell.exe",
                "font": {
                    "face": "CaskaydiaCove Nerd Font"
                },
                "guid": "{61c54bbd-c2c6-5271-96e7-009a87ff44bf}",
                "hidden": false,
                "name": "Windows PowerShell"
            },
            {
                "backgroundImage": "C:\\Users\\mukul\\Pictures\\Icons\\PowerShellB1.gif",
                "colorScheme": "Campbell Powershell White",
                "commandline": "C:\\Program Files\\PowerShell\\7-preview\\pwsh.exe",
                "guid": "{c87cd607-f129-4338-98ac-45a7e2fbe08f}",
                "hidden": false,
                "icon": "ms-appx:///ProfileIcons/pwsh-preview.png",
                "name": "PowerShell 7-Preview",
                "startingDirectory": "%USERPROFILE%"
            },
            {
                "backgroundImage": "C:\\Users\\mukul\\Pictures\\Icons\\CommandPromptB1.gif",
                "guid": "{a4a8db41-6718-5b25-80c8-688523b49d9e}",
                "hidden": false,
                "name": "Developer Command Prompt for VS 2019",
                "source": "Windows.Terminal.VisualStudio"
            },
            {
                "backgroundImage": "C:\\Users\\mukul\\Pictures\\Icons\\PowerShellB1.gif",
                "colorScheme": "Campbell Powershell White",
                "guid": "{4928d66a-b242-5df8-a7d0-6dc155d125e0}",
                "hidden": false,
                "name": "Developer PowerShell for VS 2019",
                "source": "Windows.Terminal.VisualStudio"
            },
            {
                "backgroundImage": "C:\\Users\\mukul\\Pictures\\Icons\\UbuntuB1.png",
                "commandline": "C:\\Windows\\system32\\wsl.exe -d Ubuntu",
                "guid": "{7931dd57-43da-4adf-8ff2-c8a3ccf9e2f8}",
                "hidden": false,
                "icon": "ms-appx:///ProfileIcons/{9acb9455-ca41-5af7-950f-6bca1bc9722f}.png",
                "name": "Ubuntu",
                "startingDirectory": "%USERPROFILE%"
            },
            {
                "backgroundImage": "C:\\Users\\mukul\\Pictures\\Icons\\Manjaro.png",
                "colorScheme": "Campbell White",
                "commandline": "C:\\Windows\\system32\\wsl.exe -d Manjaro",
                "guid": "{1a0a6ac6-5b06-411f-b0d9-c951baf89c61}",
                "hidden": false,
                "icon": "ms-appx:///ProfileIcons/{9acb9455-ca41-5af7-950f-6bca1bc9722f}.png",
                "name": "Manjaro",
                "startingDirectory": "%USERPROFILE%"
            },
            {
                "backgroundImage": "C:\\Users\\mukul\\Pictures\\Icons\\GitB1.jpg",
                "colorScheme": "Campbell White",
                "font": {
                    "face": "CaskaydiaCove Nerd Font"
                },
                "guid": "{2ece5bfe-50ed-5f3a-ab87-5cd4baafed2b}",
                "hidden": false,
                "icon": "C:\\Users\\mukul\\Pictures\\Icons\\Git.ico",
                "name": "Git Bash",
                "source": "Git"
            }
        ]
    },
    "schemes": [
        {
            "background": "#0C0C0C",
            "black": "#0C0C0C",
            "blue": "#0037DA",
            "brightBlack": "#767676",
            "brightBlue": "#3B78FF",
            "brightCyan": "#61D6D6",
            "brightGreen": "#16C60C",
            "brightPurple": "#B4009E",
            "brightRed": "#E74856",
            "brightWhite": "#F2F2F2",
            "brightYellow": "#F9F1A5",
            "cursorColor": "#FFFFFF",
            "cyan": "#3A96DD",
            "foreground": "#CCCCCC",
            "green": "#13A10E",
            "name": "Campbell",
            "purple": "#881798",
            "red": "#C50F1F",
            "selectionBackground": "#FFFFFF",
            "white": "#CCCCCC",
            "yellow": "#C19C00"
        },
        {
            "background": "#012456",
            "black": "#0C0C0C",
            "blue": "#0037DA",
            "brightBlack": "#767676",
            "brightBlue": "#3B78FF",
            "brightCyan": "#61D6D6",
            "brightGreen": "#16C60C",
            "brightPurple": "#B4009E",
            "brightRed": "#E74856",
            "brightWhite": "#F2F2F2",
            "brightYellow": "#F9F1A5",
            "cursorColor": "#FFFFFF",
            "cyan": "#3A96DD",
            "foreground": "#CCCCCC",
            "green": "#13A10E",
            "name": "Campbell Powershell",
            "purple": "#881798",
            "red": "#C50F1F",
            "selectionBackground": "#FFFFFF",
            "white": "#CCCCCC",
            "yellow": "#C19C00"
        },
        {
            "background": "#012456",
            "black": "#0C0C0C",
            "blue": "#0037DA",
            "brightBlack": "#767676",
            "brightBlue": "#3B78FF",
            "brightCyan": "#61D6D6",
            "brightGreen": "#16C60C",
            "brightPurple": "#B4009E",
            "brightRed": "#E74856",
            "brightWhite": "#FFFFFF",
            "brightYellow": "#F9F1A5",
            "cursorColor": "#FFFFFF",
            "cyan": "#3A96DD",
            "foreground": "#FFFFFF",
            "green": "#13A10E",
            "name": "Campbell Powershell White",
            "purple": "#881798",
            "red": "#C50F1F",
            "selectionBackground": "#FFFFFF",
            "white": "#FFFFFF",
            "yellow": "#C19C00"
        },
        {
            "background": "#000000",
            "black": "#0C0C0C",
            "blue": "#0037DA",
            "brightBlack": "#767676",
            "brightBlue": "#3B78FF",
            "brightCyan": "#61D6D6",
            "brightGreen": "#16C60C",
            "brightPurple": "#B4009E",
            "brightRed": "#E74856",
            "brightWhite": "#FFFFFF",
            "brightYellow": "#F9F1A5",
            "cursorColor": "#FFFFFF",
            "cyan": "#3A96DD",
            "foreground": "#FFFFFF",
            "green": "#13A10E",
            "name": "Campbell White",
            "purple": "#881798",
            "red": "#C50F1F",
            "selectionBackground": "#FFFFFF",
            "white": "#FFFFFF",
            "yellow": "#C19C00"
        },
        {
            "background": "#282C34",
            "black": "#282C34",
            "blue": "#61AFEF",
            "brightBlack": "#5A6374",
            "brightBlue": "#61AFEF",
            "brightCyan": "#56B6C2",
            "brightGreen": "#98C379",
            "brightPurple": "#C678DD",
            "brightRed": "#E06C75",
            "brightWhite": "#DCDFE4",
            "brightYellow": "#E5C07B",
            "cursorColor": "#FFFFFF",
            "cyan": "#56B6C2",
            "foreground": "#DCDFE4",
            "green": "#98C379",
            "name": "One Half Dark",
            "purple": "#C678DD",
            "red": "#E06C75",
            "selectionBackground": "#FFFFFF",
            "white": "#DCDFE4",
            "yellow": "#E5C07B"
        },
        {
            "background": "#FAFAFA",
            "black": "#383A42",
            "blue": "#0184BC",
            "brightBlack": "#4F525D",
            "brightBlue": "#61AFEF",
            "brightCyan": "#56B5C1",
            "brightGreen": "#98C379",
            "brightPurple": "#C577DD",
            "brightRed": "#DF6C75",
            "brightWhite": "#FFFFFF",
            "brightYellow": "#E4C07A",
            "cursorColor": "#4F525D",
            "cyan": "#0997B3",
            "foreground": "#383A42",
            "green": "#50A14F",
            "name": "One Half Light",
            "purple": "#A626A4",
            "red": "#E45649",
            "selectionBackground": "#FFFFFF",
            "white": "#FAFAFA",
            "yellow": "#C18301"
        },
        {
            "background": "#002B36",
            "black": "#002B36",
            "blue": "#268BD2",
            "brightBlack": "#073642",
            "brightBlue": "#839496",
            "brightCyan": "#93A1A1",
            "brightGreen": "#586E75",
            "brightPurple": "#6C71C4",
            "brightRed": "#CB4B16",
            "brightWhite": "#FDF6E3",
            "brightYellow": "#657B83",
            "cursorColor": "#FFFFFF",
            "cyan": "#2AA198",
            "foreground": "#839496",
            "green": "#859900",
            "name": "Solarized Dark",
            "purple": "#D33682",
            "red": "#DC322F",
            "selectionBackground": "#FFFFFF",
            "white": "#EEE8D5",
            "yellow": "#B58900"
        },
        {
            "background": "#FDF6E3",
            "black": "#002B36",
            "blue": "#268BD2",
            "brightBlack": "#073642",
            "brightBlue": "#839496",
            "brightCyan": "#93A1A1",
            "brightGreen": "#586E75",
            "brightPurple": "#6C71C4",
            "brightRed": "#CB4B16",
            "brightWhite": "#FDF6E3",
            "brightYellow": "#657B83",
            "cursorColor": "#002B36",
            "cyan": "#2AA198",
            "foreground": "#657B83",
            "green": "#859900",
            "name": "Solarized Light",
            "purple": "#D33682",
            "red": "#DC322F",
            "selectionBackground": "#FFFFFF",
            "white": "#EEE8D5",
            "yellow": "#B58900"
        },
        {
            "background": "#000000",
            "black": "#000000",
            "blue": "#3465A4",
            "brightBlack": "#555753",
            "brightBlue": "#729FCF",
            "brightCyan": "#34E2E2",
            "brightGreen": "#8AE234",
            "brightPurple": "#AD7FA8",
            "brightRed": "#EF2929",
            "brightWhite": "#EEEEEC",
            "brightYellow": "#FCE94F",
            "cursorColor": "#FFFFFF",
            "cyan": "#06989A",
            "foreground": "#D3D7CF",
            "green": "#4E9A06",
            "name": "Tango Dark",
            "purple": "#75507B",
            "red": "#CC0000",
            "selectionBackground": "#FFFFFF",
            "white": "#D3D7CF",
            "yellow": "#C4A000"
        },
        {
            "background": "#FFFFFF",
            "black": "#000000",
            "blue": "#3465A4",
            "brightBlack": "#555753",
            "brightBlue": "#729FCF",
            "brightCyan": "#34E2E2",
            "brightGreen": "#8AE234",
            "brightPurple": "#AD7FA8",
            "brightRed": "#EF2929",
            "brightWhite": "#EEEEEC",
            "brightYellow": "#FCE94F",
            "cursorColor": "#000000",
            "cyan": "#06989A",
            "foreground": "#555753",
            "green": "#4E9A06",
            "name": "Tango Light",
            "purple": "#75507B",
            "red": "#CC0000",
            "selectionBackground": "#FFFFFF",
            "white": "#D3D7CF",
            "yellow": "#C4A000"
        },
        {
            "background": "#300A24",
            "black": "#2E3436",
            "blue": "#3465A4",
            "brightBlack": "#555753",
            "brightBlue": "#729FCF",
            "brightCyan": "#34E2E2",
            "brightGreen": "#8AE234",
            "brightPurple": "#AD7FA8",
            "brightRed": "#EF2929",
            "brightWhite": "#EEEEEC",
            "brightYellow": "#FCE94F",
            "cursorColor": "#BBBBBB",
            "cyan": "#06989A",
            "foreground": "#EEEEEC",
            "green": "#4E9A06",
            "name": "Ubuntu Default",
            "purple": "#75507B",
            "red": "#CC0000",
            "selectionBackground": "#B5D5FF",
            "white": "#D3D7CF",
            "yellow": "#C4A000"
        },
        {
            "background": "#000000",
            "black": "#000000",
            "blue": "#000080",
            "brightBlack": "#808080",
            "brightBlue": "#0000FF",
            "brightCyan": "#00FFFF",
            "brightGreen": "#00FF00",
            "brightPurple": "#FF00FF",
            "brightRed": "#FF0000",
            "brightWhite": "#FFFFFF",
            "brightYellow": "#FFFF00",
            "cursorColor": "#FFFFFF",
            "cyan": "#008080",
            "foreground": "#C0C0C0",
            "green": "#008000",
            "name": "Vintage",
            "purple": "#800080",
            "red": "#800000",
            "selectionBackground": "#FFFFFF",
            "white": "#C0C0C0",
            "yellow": "#808000"
        }
    ],
    "theme": "dark",
    "trimBlockSelection": true,
    "useAcrylicInTabRow": true,
    "wordDelimiters": " /\\()\"'-.,:;<>~!@#$%^&*|+=[]{}~?\u2502"
}
```


</details>


Important bits: 
```jsonc

    "useAcrylicInTabRow": true,
    // ...
        "profiles": {
        "defaults": {
            "colorScheme": "Campbell White",
            "useAcrylic": true,
            "font": {
                "face": "CaskaydiaCove Nerd Font"
            }
        },
        "list": [
            {
                "backgroundImage": "C:\\Users\\mukul\\Pictures\\Icons\\CommandPromptB1.gif",
                "colorScheme": "Campbell White",
                "commandline": "%SystemRoot%\\System32\\cmd.exe",
                "font": {
                    "face": "CaskaydiaCove Nerd Font"
                },
                "guid": "{0caa0dad-35be-5f56-a8ff-afceeeaa6101}",
                "hidden": false,
                "name": "Command Prompt"
            },
            
```

None of the profiles have `opacity` set, to those won't be transparent... 
@zadjii-msft I cannot speak for the OP, but below is what I'm seeing. I do have `"acrylicOpacity": 0.75` set under `defaults`. There is also a weird white space (gap) under the tab row for inactive tabs.

![TerminalPreview](https://user-images.githubusercontent.com/9311082/152833092-9135b428-a02c-442c-a343-7e314e797c27.png)


That's exactly the kind of thing I'm looking for. That's great, thanks!
> 

I have The Exact Same Thing Important Parts, Here is An Image Also:
![Screenshot 2022-02-07 192509](https://user-images.githubusercontent.com/71291707/152894685-dc26cab0-feeb-41db-9b91-51d1df710f7a.png)


Also Even If The Thing behind The Terminal Is Black, It Is Still White.

Fix patch:
diff --git a/src/cascadia/TerminalApp/App.xaml b/src/cascadia/TerminalApp/App.xaml
index 07273a0151a..07c70c6b72f 100644
--- a/src/cascadia/TerminalApp/App.xaml
+++ b/src/cascadia/TerminalApp/App.xaml
@@ -54,17 +54,31 @@
                     <ResourceDictionary.ThemeDictionaries>
                         <ResourceDictionary x:Key="Dark">
                             <!--  Define resources for Dark mode here  -->
-                            <StaticResource x:Key="TabViewBackground"
-                                            ResourceKey="ApplicationPageBackgroundThemeBrush" />
+
+                            <!--
+                                This is the color of
+                                ApplicationPageBackgroundThemeBrush, which is
+                                evaluated as SolidBackgroundFillColorBase. If we try
+                                to use those resources directly though, we don't get
+                                the properly themed versions. Presumably because the
+                                App itself can't have it's RequestedTheme changed at
+                                runtime.
+                                
+                                See GH #12356 for more history on the subject.
+                            -->
+                            <SolidColorBrush x:Key="TabViewBackground"
+                                             Color="#202020" />
 
                             <StaticResource x:Key="UnfocusedBorderBrush"
                                             ResourceKey="ApplicationPageBackgroundThemeBrush" />
+
+
                         </ResourceDictionary>
 
                         <ResourceDictionary x:Key="Light">
                             <!--  Define resources for Light mode here  -->
-                            <StaticResource x:Key="TabViewBackground"
-                                            ResourceKey="ApplicationPageBackgroundThemeBrush" />
+                            <SolidColorBrush x:Key="TabViewBackground"
+                                             Color="#F3F3F3" />
 
                             <StaticResource x:Key="UnfocusedBorderBrush"
                                             ResourceKey="ApplicationPageBackgroundThemeBrush" />
diff --git a/src/cascadia/TerminalApp/TerminalPage.cpp b/src/cascadia/TerminalApp/TerminalPage.cpp
index 9b08ba85052..e5c382d132b 100644
--- a/src/cascadia/TerminalApp/TerminalPage.cpp
+++ b/src/cascadia/TerminalApp/TerminalPage.cpp
@@ -156,7 +156,6 @@ namespace winrt::TerminalApp::implementation
         if (_settings.GlobalSettings().UseAcrylicInTabRow())
         {
             const auto res = Application::Current().Resources();
-
             const auto lightKey = winrt::box_value(L"Light");
             const auto darkKey = winrt::box_value(L"Dark");
             const auto tabViewBackgroundKey = winrt::box_value(L"TabViewBackground");


Test patch: