Repository: microsoft/terminal (language: cpp)

Issue:
Rejuvenated UI doesn’t pick up Segoe UI Variable on Windows 11
What it says on the tin.


Discussion / hints:
*Huh.* That's... unexpected. I wonder how we broke that! Thanks for the report.
We might need to add another version of Windows into `maxversiontested` in our manifest to indicate compatibility.

```
    // After version 10.0.21251.0, Variable fonts will be used by default
```
@fitojb Is this what it's supposed to look like?

before/after:
![image](https://user-images.githubusercontent.com/18356694/153478518-2d81d218-9bfb-4868-8781-6df735927939.png)

before:
![image](https://user-images.githubusercontent.com/18356694/153478558-c4a7e250-bcb5-41bb-a21f-1134bc127246.png)
after:
![image](https://user-images.githubusercontent.com/18356694/153478590-14fab193-6dcc-4cc9-939d-c2d35f63d877.png)

Also, where's the documentation on the `maxversiontested` bit for this? This is spooky action at a distance. If this is how developers are supposed to use this feature, then it should be documented. 

Fix patch:
diff --git a/src/cascadia/WindowsTerminal/WindowsTerminal.manifest b/src/cascadia/WindowsTerminal/WindowsTerminal.manifest
index 47612326b28..8e1afe241f0 100644
--- a/src/cascadia/WindowsTerminal/WindowsTerminal.manifest
+++ b/src/cascadia/WindowsTerminal/WindowsTerminal.manifest
@@ -14,6 +14,11 @@
         <!-- This will cause unpackaged activation failures in XAML Islands. -->
         <!-- (We use unpackaged activation in test scenarios.) See GH#10265. -->
         <maxversiontested Id="10.0.18362.0"/>
+
+        <!-- You apparently are expected to include all the maxversiontested
+        entries separately. They are treated like an array. This one turns on Segoe
+        UI Variable, GH #12452 -->
+        <maxversiontested Id="10.0.22000.0"/>
         <supportedOS Id="{8e0f7a12-bfb3-4fe8-b9a5-48fd50a15a9a}" />
     </application>
   </compatibility>


Test patch: