Repository: microsoft/terminal (language: cpp)

Issue:
No GitHub/Feedback link in About box.
# Description of the new feature/enhancement
The current about dialog is pretty simple:

![image](https://user-images.githubusercontent.com/24302614/175428885-762497a4-4711-4085-b6bf-08b27f856c82.png)

It'd be nice to see:
- Terminal Icon
- A link to GitHub (maybe w/ GitHub Icon)
- A 'Send Feedback' link which leads here or Feedback Hub:
![image](https://user-images.githubusercontent.com/24302614/175429094-41542cd5-aadf-4d76-9716-433c4cb209ee.png)




Discussion / hints:
FWIW We used to have this in the top level dropdown, but it was just generating noise. 

In #789 we made it point at our GitHub issues, but at some point after that we redirected that to the `FeedbackUriValue` resource, which redirects to feedback hub now. 

We've discussed offline the idea of putting this back _somewhere_, once again pointing at GitHub, and again with the `in-app-feedback` label (or something like that). Of course, we can just change the `fwlink` on our side to point at whatever, so just adding a link back should be easy enough. 
Hello, I would like to work on this.

I have already implemented these buttons:

![WindowsTerminalAboutDialog](https://user-images.githubusercontent.com/92621643/179002517-a3f4bf3a-dde8-45ad-b066-80875fa75d43.png)

The buttons link directly to:
- Source Code -> https://github.com/microsoft/terminal
- Send Feedback -> https://github.com/microsoft/terminal/issues 
**(Change to Feedback Hub?)**


I would appreciate your feedback.

I think that would be perfect! Honestly, GitHub is a way better place for feedback than Feedback Hub 😄 
This might be one of those things where the stable version should direct users to the feedback hub, and the preview/dev versions should direct users to GitHub . . . @zadjii-msft, WDYT?

Motivation: I don't know if, when we become "DxD", we can rely on the large population of Stable users to _have GitHub accounts._
That's a good idea, but let's start small. Let's just start with the links as @AdamSotak has it now for now, and we can sort out the fwlinks on our side in post. 

Fix patch:
diff --git a/src/cascadia/TerminalApp/Resources/en-US/Resources.resw b/src/cascadia/TerminalApp/Resources/en-US/Resources.resw
index 29e70316f88..195535985d9 100644
--- a/src/cascadia/TerminalApp/Resources/en-US/Resources.resw
+++ b/src/cascadia/TerminalApp/Resources/en-US/Resources.resw
@@ -436,6 +436,9 @@
   <data name="AboutDialog.Title" xml:space="preserve">
     <value>About</value>
   </data>
+  <data name="AboutDialog.PrimaryButtonText" xml:space="preserve">
+    <value>Send Feedback</value>
+  </data>
   <data name="AboutDialog.CloseButtonText" xml:space="preserve">
     <value>OK</value>
   </data>
@@ -447,6 +450,10 @@
     <value>Getting Started</value>
     <comment>A hyperlink name for a guide on how to get started using Terminal</comment>
   </data>
+  <data name="AboutDialog_SourceCodeLink.Content" xml:space="preserve">
+    <value>Source Code</value>
+    <comment>A hyperlink name for the Terminal's documentation</comment>
+  </data>
   <data name="AboutDialog_DocumentationLink.Content" xml:space="preserve">
     <value>Documentation</value>
     <comment>A hyperlink name for user documentation</comment>
diff --git a/src/cascadia/TerminalApp/TerminalPage.cpp b/src/cascadia/TerminalApp/TerminalPage.cpp
index f4b2f262d62..2032125d0e4 100644
--- a/src/cascadia/TerminalApp/TerminalPage.cpp
+++ b/src/cascadia/TerminalApp/TerminalPage.cpp
@@ -693,8 +693,8 @@ namespace winrt::TerminalApp::implementation
 
     // Method Description:
     // - Show a dialog with "About" information. Displays the app's Display
-    //   Name, version, getting started link, documentation link, release
-    //   Notes link, and privacy policy link.
+    //   Name, version, getting started link, source code link, documentation link, release
+    //   Notes link, send feedback link and privacy policy link.
     void TerminalPage::_ShowAboutDialog()
     {
         _ShowDialogHelper(L"AboutDialog");
@@ -710,6 +710,11 @@ namespace winrt::TerminalApp::implementation
         return CascadiaSettings::ApplicationVersion();
     }
 
+    void TerminalPage::_SendFeedbackOnClick(const IInspectable& /*sender*/, const Windows::UI::Xaml::Controls::ContentDialogButtonClickEventArgs& /*eventArgs*/)
+    {
+        ShellExecute(nullptr, nullptr, L"https://github.com/microsoft/terminal/issues", nullptr, nullptr, SW_SHOW);
+    }
+
     void TerminalPage::_ThirdPartyNoticesOnClick(const IInspectable& /*sender*/, const Windows::UI::Xaml::RoutedEventArgs& /*eventArgs*/)
     {
         std::filesystem::path currentPath{ wil::GetModuleFileNameW<std::wstring>(nullptr) };
diff --git a/src/cascadia/TerminalApp/TerminalPage.h b/src/cascadia/TerminalApp/TerminalPage.h
index 9a4e0a13d55..3d5b70efe5e 100644
--- a/src/cascadia/TerminalApp/TerminalPage.h
+++ b/src/cascadia/TerminalApp/TerminalPage.h
@@ -251,6 +251,7 @@ namespace winrt::TerminalApp::implementation
         void _CommandPaletteButtonOnClick(const IInspectable& sender, const Windows::UI::Xaml::RoutedEventArgs& eventArgs);
         void _AboutButtonOnClick(const IInspectable& sender, const Windows::UI::Xaml::RoutedEventArgs& eventArgs);
         void _ThirdPartyNoticesOnClick(const IInspectable& sender, const Windows::UI::Xaml::RoutedEventArgs& eventArgs);
+        void _SendFeedbackOnClick(const IInspectable& sender, const Windows::UI::Xaml::Controls::ContentDialogButtonClickEventArgs& eventArgs);
 
         void _KeyDownHandler(const Windows::Foundation::IInspectable& sender, const Windows::UI::Xaml::Input::KeyRoutedEventArgs& e);
         static ::Microsoft::Terminal::Core::ControlKeyStates _GetPressedModifierKeys() noexcept;
diff --git a/src/cascadia/TerminalApp/TerminalPage.xaml b/src/cascadia/TerminalApp/TerminalPage.xaml
index 41bb331e405..a2f430cfcb1 100644
--- a/src/cascadia/TerminalApp/TerminalPage.xaml
+++ b/src/cascadia/TerminalApp/TerminalPage.xaml
@@ -100,13 +100,16 @@
                        x:Uid="AboutDialog"
                        Grid.Row="2"
                        x:Load="False"
-                       DefaultButton="Close">
+                       DefaultButton="Close"
+                       PrimaryButtonClick="_SendFeedbackOnClick">
             <StackPanel Orientation="Vertical">
                 <TextBlock IsTextSelectionEnabled="True">
                     <Run Text="{x:Bind ApplicationDisplayName}" /> <LineBreak />
                     <Run x:Uid="AboutDialog_VersionLabel" />
                     <Run Text="{x:Bind ApplicationVersion}" />
                 </TextBlock>
+                <HyperlinkButton x:Uid="AboutDialog_SourceCodeLink"
+                                 NavigateUri="https://github.com/microsoft/terminal" />
                 <HyperlinkButton x:Uid="AboutDialog_DocumentationLink"
                                  NavigateUri="https://go.microsoft.com/fwlink/?linkid=2125416" />
                 <HyperlinkButton x:Uid="AboutDialog_ReleaseNotesLink"


Test patch: