Repository: microsoft/terminal (language: cpp)

Issue:
Make Open JSON file easier to discover
<!-- 
🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨

I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING:
1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement.
2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement.
3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number).
4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement.
5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement.

All good? Then proceed!
-->

# Description of the new feature/enhancement
Once in a while I want to change something in the JSON settings file, and many times I spend several minutes to find that option. It mostly happens when the window is maximized. The button is too far away from the rest of the options.

![image](https://user-images.githubusercontent.com/5412540/171995491-4ba53e72-d9aa-4cbc-b407-ec2c32908517.png)

<!-- 
A clear and concise description of what the problem is that the new feature would solve.
Describe why and how a user would use this new functionality (if applicable).
-->

# Proposed technical implementation details (optional)
I think it can be added to this menu:

![image](https://user-images.githubusercontent.com/5412540/171995636-1c4a5959-adf2-4c5c-a6d9-9405af17cf70.png)

<!-- 
A clear and concise description of what you want to happen.
-->



Discussion / hints:
As a variant you can create environment variable or shell variable. I create in pwsh's profile `$WT_SETTINGS` var:

![Screenshot 2022-06-04 140059](https://user-images.githubusercontent.com/78153320/171996189-bbc97b45-648b-419e-8c5a-335267c2f743.png)

And edit file in your favorite editor, for example:
```powershell
> notepad $WT_SETTINGS
```

You can also get to the JSON file by holding down <kbd>Shift</kbd> and clicking on the "Settings" menu item, my pressing <kbd>Ctrl+Shift+,</kbd>, or by opening the command palette with <kbd>Ctrl+Shift+P</kbd> and searching for `JSON`.

Are any of those sufficient?
> Are any of those sufficient?

I first learned about the settings file through UI. Now that I know a JSON settings file exists, the last option is sufficient for me, I won't forget that one. However, the command is "Open settings file", searching `JSON` didn't work for me. I have version `1.12.10982.0` installed.

> opening the command palette with Ctrl+Shift+P and searching for `JSON`.

https://github.com/microsoft/terminal/blob/ed27737233714dea77877624d1beeb49e2ccd36e/src/cascadia/TerminalSettingsModel/defaults.json#L293

![image](https://user-images.githubusercontent.com/18356694/172175759-278ee681-18a7-4791-95e5-6bea8ce75b73.png)

Looks like that string doesn't actually have "JSON" in it - should it?

(part of #1571 would also cover the ability to add your own actions to the new tab menu, so you could feel free to add a "Open JSON" action that way)

> Looks like that string doesn't actually have "JSON" in it - should it?

IMO having JSON in that string would make the command more discoverable, at least for VS Code users:

![image](https://user-images.githubusercontent.com/5412540/172194668-5da330b0-0ac7-4877-8fa3-2fcb12ec57db.png)

Discussion:
* Yes we should change the string to "Open settings file (JSON)" with json locked
* We should also probably add a tooltip to the New Tab dropdown entry as well
> Discussion:
> 
> * Yes we should change the string to "Open settings file (JSON)" with json locked
> * We should also probably add a tooltip to the New Tab dropdown entry as well

Related: https://github.com/microsoft/terminal/issues/10354, sometimes "settings file" is clearer, sometimes "json", but consistency is even more important IMO

Fix patch:
diff --git a/src/cascadia/TerminalSettingsModel/Resources/en-US/Resources.resw b/src/cascadia/TerminalSettingsModel/Resources/en-US/Resources.resw
index 9b7e6fbe661..e71dcf94a0e 100644
--- a/src/cascadia/TerminalSettingsModel/Resources/en-US/Resources.resw
+++ b/src/cascadia/TerminalSettingsModel/Resources/en-US/Resources.resw
@@ -299,16 +299,19 @@
     <value>Next tab</value>
   </data>
   <data name="OpenBothSettingsFilesCommandKey" xml:space="preserve">
-    <value>Open both settings and default settings files</value>
+    <value>Open both settings and default settings files (JSON)</value>
+    <comment>{Locked="JSON"}. "JSON" is the extension of the file that will be opened.</comment>
   </data>
   <data name="OpenDefaultSettingsCommandKey" xml:space="preserve">
-    <value>Open default settings file</value>
+    <value>Open default settings file (JSON)</value>
+    <comment>{Locked="JSON"}. "JSON" is the extension of the file that will be opened.</comment>
   </data>
   <data name="OpenNewTabDropdownCommandKey" xml:space="preserve">
     <value>Open new tab dropdown</value>
   </data>
   <data name="OpenSettingsCommandKey" xml:space="preserve">
-    <value>Open settings file</value>
+    <value>Open settings file (JSON)</value>
+    <comment>{Locked="JSON"}. "JSON" is the extension of the file that will be opened.</comment>
   </data>
   <data name="OpenTabColorPickerCommandKey" xml:space="preserve">
     <value>Set the tab color...</value>


Test patch: