Repository: microsoft/terminal (language: cpp)

Issue:
break is missing here?
https://github.com/microsoft/terminal/blob/41ef5554f5cb946c4a48e2b8db791265c7217fce/src/cascadia/WindowsTerminal/IslandWindow.cpp#L597


Discussion / hints:
Yes, there absolutely is. Good eye! would you like to open a PR for that?
> Yes, there absolutely is. Good eye! would you like to open a PR for that?

OK I will do!

Fix patch:
diff --git a/src/cascadia/WindowsTerminal/IslandWindow.cpp b/src/cascadia/WindowsTerminal/IslandWindow.cpp
index e190eb672f5..98e9f208893 100644
--- a/src/cascadia/WindowsTerminal/IslandWindow.cpp
+++ b/src/cascadia/WindowsTerminal/IslandWindow.cpp
@@ -538,6 +538,7 @@ long IslandWindow::_calculateTotalSize(const bool isWidth, const long clientSize
             return 0;
         }
         CATCH_LOG();
+        break;
     case WM_THEMECHANGED:
         UpdateWindowIconForActiveMetrics(_window.get());
         return 0;
@@ -595,6 +596,7 @@ long IslandWindow::_calculateTotalSize(const bool isWidth, const long clientSize
                 return 0;
             }
         }
+        break;
     }
     case CM_NOTIFY_FROM_NOTIFICATION_AREA:
     {


Test patch: