Repository: microsoft/terminal (language: cpp)

Issue:
[Windows Terminal - Settings]: In dark mode, Luminosity ratio for 'Reset to inherited value' icon is '2.6:1', which is less than required '3:1'.
### Windows Terminal version

1.22.2362.0

### Windows build number

27695.1000

### Other Software

**Test Environment:**
OS: Windows 11 Version Dev (OS Build 27695.1000)
App: Windows Terminal Preview

### Steps to reproduce

**Prerequisites:**
Settings> Personalization> Colors> Choose your Mode> Dark Mode.

**Repro steps:**
1. Open the 'windows terminal' application.
2. Apply dark mode by following the prerequisites.
3. Now open 'Setting' and activate 'Startup' tab.
4. Navigate to the 'Defaults' tab and activate it.
5. Now navigate to the 'Appearance' button and activate it.
6. Now navigate to any control like 'Line height' and change value.
7. 'Reset to inherited value' button will appear.
8. Open Accessibility Insights for windows and check contrast ratio of 'Reset to inherited value' icon. 
9. Observe the issue.

**User experience:**
Low vision users will find difficulty in tracking the control, if contrast ratio for the control's icon is less than '3:1' (Required).

**WCAG Reference Link:**
[[MAS 4.3.1 – No Disruption of Accessibility Features.docx (sharepoint.com)](https://microsoft.sharepoint.com/:w:/s/accessibility/EegntkLK4KBBvzE1qsKpIoABG2UIxUY2y3uo1LomKoz_bg?e=wLbDEr)](https://www.w3.org/WAI/WCAG22/Understanding/non-text-contrast)

**Attachment:**
[MAS1.4.11 - In Dark mode, cca failed for 'Reset to inherited value' button..zip](https://github.com/user-attachments/files/16959865/MAS1.4.11.-.In.Dark.mode.cca.failed.for.Reset.to.inherited.value.button.zip)

### Expected Behavior

In dark mode, Luminosity ratio for 'Reset to inherited value' icon should be greater than or equal to 3:1. 

### Actual Behavior

In dark mode, Luminosity ratio for 'Reset to inherited value' icon is '2.6:1', which is less than required '3:1'.

**Note:**
Same issue repro for all 'Reset to inherited value' button's icon throughout.


Discussion / hints:
@SaurabhNew is there an associated severity rating for this issue?

Fix patch:
diff --git a/src/cascadia/TerminalSettingsEditor/SettingContainerStyle.xaml b/src/cascadia/TerminalSettingsEditor/SettingContainerStyle.xaml
index 0e12e7d3de7..72b254e4e41 100644
--- a/src/cascadia/TerminalSettingsEditor/SettingContainerStyle.xaml
+++ b/src/cascadia/TerminalSettingsEditor/SettingContainerStyle.xaml
@@ -44,6 +44,9 @@
             <StaticResource x:Key="SettingContainerMessageForeground"
                             ResourceKey="TextFillColorPrimaryBrush" />
 
+            <StaticResource x:Key="SettingContainerResetButtonIconForeground"
+                            ResourceKey="SystemAccentColorDark2" />
+
         </ResourceDictionary>
         <ResourceDictionary x:Key="HighContrast">
             <Style x:Key="SecondaryTextBlockStyle"
@@ -73,6 +76,9 @@
                             ResourceKey="SystemColorWindowTextColorBrush" />
             <StaticResource x:Key="SettingContainerMessageForeground"
                             ResourceKey="SystemColorWindowTextColorBrush" />
+
+            <StaticResource x:Key="SettingContainerResetButtonIconForeground"
+                            ResourceKey="SystemAccentColorLight1" />
         </ResourceDictionary>
         <ResourceDictionary x:Key="Dark">
             <Style x:Key="SecondaryTextBlockStyle"
@@ -106,6 +112,9 @@
                             ResourceKey="TextFillColorPrimaryBrush" />
             <StaticResource x:Key="SettingContainerMessageForeground"
                             ResourceKey="TextFillColorPrimaryBrush" />
+
+            <StaticResource x:Key="SettingContainerResetButtonIconForeground"
+                            ResourceKey="SystemAccentColorLight2" />
         </ResourceDictionary>
     </ResourceDictionary.ThemeDictionaries>
 
@@ -136,7 +145,7 @@
 
     <Style x:Key="SettingContainerFontIconStyle"
            TargetType="FontIcon">
-        <Setter Property="Foreground" Value="{StaticResource SystemAccentColor}" />
+        <Setter Property="Foreground" Value="{ThemeResource SettingContainerResetButtonIconForeground}" />
         <Setter Property="FontSize" Value="11" />
         <Setter Property="FontFamily" Value="{ThemeResource SymbolThemeFontFamily}" />
     </Style>


Test patch: