Repository: microsoft/terminal (language: cpp)

Issue:
Replace italic text in settings with a different text style
# Description of the new feature/enhancement

Currently, the settings pages "Color schemes" and "Rendering" (and possibly other pages) use italic text for some descriptional text, e.g.:

<img width="866" alt="image" src="https://github.com/microsoft/terminal/assets/15180557/bca96918-8393-42ee-9ab3-5523de7b32d0">


It is obviously my subjective opinion but I find this text style looking very out-of-place and inconsistent with the rest of the UI. I am not aware of any other inbuilt Windows apps that use italic text this way. Also, the [Windows 11 Design Guidelines](https://learn.microsoft.com/en-us/windows/apps/design/signature-experiences/typography#type-ramp) do not suggest italic text for any content elements.

# Proposed technical implementation details (optional)

My suggestion is to replace the text style with one of these alternatives:

1. normal, non-italic black text
2. non-italic, grey text, as it is used for descriptions in Windows Settings, for example:
   <img width="347" alt="image" src="https://github.com/microsoft/terminal/assets/15180557/877e71b3-937f-4288-be83-6fbd94f553e1">
3. an InfoBar
   <img width="501" alt="image" src="https://github.com/microsoft/terminal/assets/15180557/393de478-67c7-441f-ae84-94c72136d662">

I haven't tried out yet which of these would look best in Windows Terminal but I'd be happy to provide screenshots of each of these for further discussion.


Discussion / hints:
I think this is a good suggestion.

Fix patch:
diff --git a/src/cascadia/TerminalSettingsEditor/CommonResources.xaml b/src/cascadia/TerminalSettingsEditor/CommonResources.xaml
index b274e3cf58c..509e1782c29 100644
--- a/src/cascadia/TerminalSettingsEditor/CommonResources.xaml
+++ b/src/cascadia/TerminalSettingsEditor/CommonResources.xaml
@@ -115,7 +115,6 @@
     <!--  Used for disclaimers  -->
     <Style x:Key="DisclaimerStyle"
            TargetType="TextBlock">
-        <Setter Property="FontStyle" Value="Italic" />
         <Setter Property="TextWrapping" Value="WrapWholeWords" />
         <Setter Property="MaxWidth" Value="1000" />
     </Style>


Test patch: