Repository: cvxpy/cvxpy (language: cpp)

Issue:
Unnecessary pybind11 dependency?
https://github.com/cvxpy/cvxpy/pull/2125 (released in 1.4.0) added `pybind11` as a dependency, but it seems like it is just a build dependency, not a run time dependency?

One piece of evidence is that the cvxpy conda-forge feedstock did not add pybind11 as a dependency [here](https://github.com/conda-forge/cvxpy-feedstock/pull/83) and has gotten no complaints. I noticed this because I maintain a downstream feedstock that runs `pip check` as a test and that fails for cvxpy 1.4 because pybind11 is not installed.


Discussion / hints:
Hmm it may be only a build dependency. @akshayka @rileyjmurray is pybind11 needed as a runtime dependency? I'm not that familiar with it.
Definitely only for build-time.

On Thu, Jan 18, 2024 at 7:07 PM Steven Diamond ***@***.***>
wrote:

> Hmm it may be only a build dependency. @akshayka
> <https://github.com/akshayka> @rileyjmurray
> <https://github.com/rileyjmurray> is pybind11 needed as a runtime
> dependency? I'm not that familiar with it.
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/cvxpy/cvxpy/issues/2330#issuecomment-1899414285>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ACRLIFGKSXGMQKH46QO3NDLYPG2NVAVCNFSM6AAAAABCA47UW6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJZGQYTIMRYGU>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>


Fix patch:
diff --git a/pyproject.toml b/pyproject.toml
index e7e2118585..3510aae333 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -42,7 +42,6 @@ dependencies = [
     "scs >= 3.2.4.post1",
     "numpy >= 1.15",
     "scipy >= 1.1.0",
-    "pybind11"
 ]
 requires-python = ">=3.8"
 urls = {Homepage = "https://github.com/cvxpy/cvxpy"}
diff --git a/requirements.txt b/requirements.txt
index 42044d132c..8f1677b25d 100644
--- a/requirements.txt
+++ b/requirements.txt
@@ -4,4 +4,3 @@ ecos
 scs
 numpy
 scipy
-pybind11


Test patch: