Repository: microsoft/terminal (language: cpp)

Issue:
{Freeway-Bug}[Settings>Default terminal application]: Options present for the 'Default terminal application' combo box are getting truncated at 200% zoom.
### Windows Terminal version

1.18.902.0

### Windows build number

23031.1000

### Other Software

Test environment:
OS: Version 22H2 (OS build 23031.1000)
Application: Windows Terminal
Screen reader: Narrator

### Steps to reproduce

Pre-requisite:
Apply the resize using following path.
Settings>Accessibility>Display>Display resolution>Change display resolution to '1280 x 720>Keep changes>Drag the 'Text size' slider to '200%'>Apply>Re-open the application.

Repro steps:

1. Open the 'windows terminal' application.
2. Log in with valid credentials.
3. Follow the above-mentioned pre-requisite step.
4. Open settings using 'Ctrl + ,'.
5. Navigate to 'Start up' list-item & select it.
6. Navigate to the 'Default terminal application' combo box & activate it.
7. Navigate among the options present in the expanded combo box.
8. Observe the issue.

User experience:
Users with low vision rely on zooming features for navigation will feel difficulty in understanding the purpose of options present for the combo box, if options are not visible properly at 200% zoom.

Guideline reference:
https://www.w3.org/TR/WCAG21/#resize-text

Attachment:
[Options present for the combo box are not visible properly on re-sizing..zip](https://github.com/microsoft/terminal/files/11189870/Options.present.for.the.combo.box.are.not.visible.properly.on.re-sizing.zip)


### Expected Behavior

In 200% zoom, options present for the expanded 'Default terminal application' combo box should be visible completely without any overlapping, as they visible in 100%zoom.

### Actual Behavior

Options present for the 'Default terminal application' combo box are getting truncated & overlapping at 200% zoom.


Discussion / hints:

Fix patch:
diff --git a/src/cascadia/TerminalSettingsEditor/Appearances.xaml b/src/cascadia/TerminalSettingsEditor/Appearances.xaml
index ec20d9e418b..e37cdd2e1bf 100644
--- a/src/cascadia/TerminalSettingsEditor/Appearances.xaml
+++ b/src/cascadia/TerminalSettingsEditor/Appearances.xaml
@@ -59,8 +59,7 @@
                     <ComboBox.ItemTemplate>
                         <DataTemplate x:DataType="local:ColorSchemeViewModel">
                             <Grid Grid.Column="0"
-                                  Height="32"
-                                  Padding="8,8,0,0"
+                                  Padding="8"
                                   VerticalAlignment="Center"
                                   Background="{x:Bind local:Converters.ColorToBrush(BackgroundColor.Color), Mode=OneWay}"
                                   ColumnSpacing="1"
diff --git a/src/cascadia/TerminalSettingsEditor/Launch.xaml b/src/cascadia/TerminalSettingsEditor/Launch.xaml
index 1001f527704..a76d78cacec 100644
--- a/src/cascadia/TerminalSettingsEditor/Launch.xaml
+++ b/src/cascadia/TerminalSettingsEditor/Launch.xaml
@@ -84,18 +84,18 @@
 
                                     <Grid.ColumnDefinitions>
                                         <!--  icon  -->
-                                        <ColumnDefinition Width="24" />
-                                        <!--  profile name and author  -->
-                                        <ColumnDefinition Width="*" />
+                                        <ColumnDefinition Width="auto" />
+                                        <!--  terminal name and author  -->
+                                        <ColumnDefinition Width="auto" />
                                         <!--  version  -->
-                                        <ColumnDefinition Width="Auto" />
+                                        <ColumnDefinition Width="auto" />
                                     </Grid.ColumnDefinitions>
 
                                     <Grid.RowDefinitions>
-                                        <!--  profile name  -->
-                                        <RowDefinition Height="20" />
+                                        <!--  terminal name  -->
+                                        <RowDefinition Height="auto" />
                                         <!--  author and version  -->
-                                        <RowDefinition Height="*" />
+                                        <RowDefinition Height="auto" />
                                     </Grid.RowDefinitions>
 
                                     <IconSourceElement Grid.Row="0"
@@ -109,13 +109,11 @@
                                     <TextBlock Grid.Row="0"
                                                Grid.Column="1"
                                                Grid.ColumnSpan="2"
-                                               Height="20"
                                                AutomationProperties.AccessibilityView="Raw"
                                                Text="{x:Bind Name}" />
 
                                     <TextBlock Grid.Row="1"
                                                Grid.Column="1"
-                                               Height="20"
                                                AutomationProperties.AccessibilityView="Raw"
                                                Style="{ThemeResource SecondaryTextBlockStyle}"
                                                Text="{x:Bind Author}"
@@ -123,7 +121,6 @@
 
                                     <TextBlock Grid.Row="1"
                                                Grid.Column="2"
-                                               Height="20"
                                                AutomationProperties.AccessibilityView="Raw"
                                                Style="{ThemeResource SecondaryTextBlockStyle}"
                                                Text="{x:Bind Version}"


Test patch: