Repository: microsoft/terminal (language: cpp)

Issue:
People think the Color Scheme editor will change the current colors
### Windows Terminal version (or Windows build number)

10.0.21354 (Dev)

### Other Software

_No response_

### Steps to reproduce

1. Launch Terminal
2. Open Settings
3. Color Schemes
4. Select another color scheme from combo
5. Click to Save
6. Reopen Settings -> Color Scheme didn't applied

### Expected Behavior

_No response_

### Actual Behavior

Color Scheme.


Discussion / hints:
What terminal version.
I'm seeing this issue as well. Just updated to v1.7.1033.0 (the new release). No matter what I try, I can't seem to apply a color scheme using the new Settings UI. It gets reset back to Campbell on each relaunch.

Edit: This issue with with the default color scheme. Changing the scheme under individual profiles does apply the scheme properly to that profile.

Edit 2: Looking at recent commits, looks like it might be fixed in #9764 
Same issue. Version: 1.7.1033.0
Edit: Also would be nice to be able to get to settings json file with keyboard shortcut (as before graphical UI ctr ,) because graphical UI doesn't have all the options settings json has. thanks!
Wait HOLD UP.

Are you going to the "Color Schemes" page
![image](https://user-images.githubusercontent.com/18356694/115410049-eea7e600-a1b7-11eb-825c-c12ca8a3535c.png)

or are you changing the "color scheme" of a given profile:
![image](https://user-images.githubusercontent.com/18356694/115410168-05e6d380-a1b8-11eb-8a19-45f7acf4c6d1.png)


The first page is used for _editing the color scheme itself_. The second is for changing the appearance of the selected profile. The dropdown on the Color Schemes page is just used for _selecting which scheme you want to edit_. It doesn't apply that scheme to any profiles.

@zadjii-msft You're totally correct, now that I've taken a look into that. Gotta say though, it's definitely confusing on first use. I would assume that the Color schemes page is for selecting a default color scheme for all profiles (and yes you could edit the colors as well). Then you can go into individual profiles and override to a different color scheme.

Perhaps it just needs some some clarification on what the Coloring schemes page does. Maybe selecting a default color scheme would be better suited under Appearance (if setting a default color scheme is a goal).
Is it possible to change default theme that would apply to all profiles like via settings.json?
> Is it possible to change default theme that would apply to all profiles like via settings.json?

/cc @cinnamon-msft 
I'll make sure to pass that feedback along to the UI designers (and my "I" I mean @cinnamon-msft 😋)

I'll close the rest of this discussion about setting the default for all profiles as a /duplicate of #9539 - we're generally having that discussion in that thread.
Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!
We're reopening this, because it's come up a bunch of times now. The design clearly needs some improvement in this regard.

TODO:
* [ ] Do a competitive analysis, see what other terminals do for this UX. Clearly, we're doing something misleading

Ideas:

* Just get rid of the scheme editor entirely, replace it with a ContentDialog in the Profiles>Appearances page
* Maybe we should add a button to the color schemes page that says something like "Apply this scheme to all profiles". 
* Alternatively, we could add some help text to the top/bottom like "Trying to change the color scheme for a particular profile? Go change '[Profile > Appearance > Color scheme](in-app link to default appearances)'"


There were other suggestions too, just logging before 5pm.

Fix patch:
diff --git a/src/cascadia/TerminalSettingsEditor/ColorSchemes.xaml b/src/cascadia/TerminalSettingsEditor/ColorSchemes.xaml
index d4237e364cc..3515a213745 100644
--- a/src/cascadia/TerminalSettingsEditor/ColorSchemes.xaml
+++ b/src/cascadia/TerminalSettingsEditor/ColorSchemes.xaml
@@ -98,6 +98,10 @@
                     Margin="{StaticResource StandardIndentMargin}"
                     Spacing="24">
 
+            <TextBlock x:Uid="ColorSchemesDisclaimer"
+                       Margin="{StaticResource StandardIndentMargin}"
+                       Style="{StaticResource DisclaimerStyle}" />
+
             <!--  Select Color and Add New Button  -->
             <StackPanel Margin="0,5,0,0"
                         Orientation="Horizontal">
diff --git a/src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw b/src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw
index a069c7de6ec..3a22ea0bcf4 100644
--- a/src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw
+++ b/src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw
@@ -1210,6 +1210,10 @@
     <value>Cancel rename</value>
     <comment>Text label for a button that can be used to cancel a rename operation during the renaming process.</comment>
   </data>
+  <data name="ColorSchemesDisclaimer.Text" xml:space="preserve">
+    <value>Schemes defined here can be applied to your profiles under the "Appearances" section of the profile settings pages.</value>
+    <comment>A disclaimer presented at the top of a page. "Appearances" should match Profile_Appearance.Header.</comment>
+  </data>
   <data name="Profile_BaseLayerDisclaimer.Text" xml:space="preserve">
     <value>Settings defined here will apply to all profiles unless they are overridden by a profile's settings.</value>
     <comment>A disclaimer presented at the top of a page. See "Nav_ProfileDefaults.Content" for a description on what the defaults layer does in the app.</comment>


Test patch: