Repository: microsoft/terminal (language: cpp)

Issue:
About Dialog update check **crashes** after some time when network is slow or unreachable
Coroutines and exceptions, man, coroutines and exceptions. Wrap it in a try, it still don't catch.


Discussion / hints:
~This you? MSFT:43091127~

WAIT NO, that's 12% of our **1.17** crashes, and the about refactor isn't in 1.17. 

Fix patch:
diff --git a/src/cascadia/TerminalApp/AboutDialog.cpp b/src/cascadia/TerminalApp/AboutDialog.cpp
index 3fc9715dfa2..764f7b6dcaf 100644
--- a/src/cascadia/TerminalApp/AboutDialog.cpp
+++ b/src/cascadia/TerminalApp/AboutDialog.cpp
@@ -90,10 +90,13 @@ namespace winrt::TerminalApp::implementation
             {
                 const auto updates = co_await storeContext.GetAppAndOptionalStorePackageUpdatesAsync();
                 co_await wil::resume_foreground(strongThis->Dispatcher());
-                const auto numUpdates = updates.Size();
-                if (numUpdates > 0)
+                if (updates)
                 {
-                    UpdatesAvailable(true);
+                    const auto numUpdates = updates.Size();
+                    if (numUpdates > 0)
+                    {
+                        UpdatesAvailable(true);
+                    }
                 }
             }
 #endif


Test patch: