Repository: microsoft/terminal (language: cpp)

Issue:
Incorrect type in settings schema for `startingDirectory` property
In settings schema (https://aka.ms/terminal-profiles-schema) type of `startingDirectory` property described as `string`. But when you set inherit starting directory from parent process, the `null` value get saved to the property.


Discussion / hints:
Huh. Didn't know that `null` wasn't a valid value for a string in json schema. See: https://stackoverflow.com/questions/16241333/specify-a-value-can-be-a-string-or-null-with-json-schema

Fix patch:
diff --git a/doc/cascadia/profiles.schema.json b/doc/cascadia/profiles.schema.json
index 6366468e689..3cef5d1946e 100644
--- a/doc/cascadia/profiles.schema.json
+++ b/doc/cascadia/profiles.schema.json
@@ -2396,7 +2396,10 @@
         },
         "startingDirectory": {
           "description": "The directory the shell starts in when it is loaded.",
-          "type": "string"
+          "type": [
+            "string",
+            "null"
+          ]
         },
         "suppressApplicationTitle": {
           "description": "When set to true, tabTitle overrides the default title of the tab and any title change messages from the application will be suppressed. When set to false, tabTitle behaves as normal.",


Test patch: