Repository: microsoft/terminal (language: cpp)

Issue:
Inconsistency between 'opacity' and 'transparency' in settings UI
There's inconsistent help text for opacity/transparency:

https://github.com/microsoft/terminal/blob/788d33ce94d28e2903bc49f841ce279211b7f557/src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw#L530-L531

https://github.com/microsoft/terminal/blob/788d33ce94d28e2903bc49f841ce279211b7f557/src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw#L650-L651

The setting controls opacity, but the help text that appears when dragging the slider says transparency. Can we change these occurences of 'transparency' to 'opacity'? I can make a PR if needed 👍🏼 



Discussion / hints:
I think in these two cases "opacity" would be a good choice.

Fix patch:
diff --git a/src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw b/src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw
index 3a22ea0bcf4..fcafb0bcf4f 100644
--- a/src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw
+++ b/src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw
@@ -528,7 +528,7 @@
     <comment>Header for a control to determine the level of opacity for the background of the control. The user can choose to make the background of the app more or less opaque.</comment>
   </data>
   <data name="Profile_Opacity.HelpText" xml:space="preserve">
-    <value>Sets the transparency of the window.</value>
+    <value>Sets the opacity of the window.</value>
     <comment>A description for what the "opacity" setting does. Presented near "Profile_Opacity.Header".</comment>
   </data>
   <data name="Profile_Advanced.Header" xml:space="preserve">
@@ -648,7 +648,7 @@
     <comment>Header for a control to choose the opacity of the image presented on the background of the app.</comment>
   </data>
   <data name="Profile_BackgroundImageOpacity.HelpText" xml:space="preserve">
-    <value>Sets the transparency of the background image.</value>
+    <value>Sets the opacity of the background image.</value>
     <comment>A description for what the "background image opacity" setting does. Presented near "Profile_BackgroundImageOpacity".</comment>
   </data>
   <data name="Profile_BackgroundImageStretchMode.[using:Windows.UI.Xaml.Automation]AutomationProperties.Name" xml:space="preserve">


Test patch: