Repository: microsoft/terminal (language: cpp)

Issue:
Atlas engine does not fill the "gutters"
### Windows Terminal version

1.13

### Windows build number

_No response_

### Other Software

_No response_

### Steps to reproduce

Run at 150% scale with a fully opaque background.

### Expected Behavior

_No response_

### Actual Behavior

![image](https://user-images.githubusercontent.com/189190/142285549-8e948e7d-725a-48ac-ab1a-6ed954943f81.png)



Discussion / hints:
I can't replicate this issue:
![image](https://user-images.githubusercontent.com/2256941/151204843-bd81a675-e137-41e1-bae3-dbf06020a8c7.png)
Perhaps it is a fractional scaling issue! Try 150% or 175%.
The screenshot is at 150% and it doesn't happen for neither 125% nor 175%.
You know... I kinda suspect this might've been fixed with my `SMALL_RECT` PR, because that one removed `til::math::truncate`...
This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for **4 days**. It will be closed if no further activity occurs **within 3 days of this comment**.
Yeah, I definitely haven't seen this in a while!

Fix patch:
diff --git a/src/renderer/atlas/AtlasEngine.cpp b/src/renderer/atlas/AtlasEngine.cpp
index bf108602862..bd30b04faee 100644
--- a/src/renderer/atlas/AtlasEngine.cpp
+++ b/src/renderer/atlas/AtlasEngine.cpp
@@ -566,7 +566,9 @@ CATCH_RETURN()
 [[nodiscard]] HRESULT AtlasEngine::UpdateDrawingBrushes(const TextAttribute& textAttributes, const RenderSettings& renderSettings, const gsl::not_null<IRenderData*> /*pData*/, const bool usingSoftFont, const bool isSettingDefaultBrushes) noexcept
 try
 {
-    const auto [fg, bg] = renderSettings.GetAttributeColorsWithAlpha(textAttributes);
+    auto [fg, bg] = renderSettings.GetAttributeColorsWithAlpha(textAttributes);
+    fg |= 0xff000000;
+    bg |= _api.backgroundOpaqueMixin;
 
     if (!isSettingDefaultBrushes)
     {
@@ -588,7 +590,7 @@ try
             WI_ClearAllFlags(flags, CellFlags::UnderlineDotted | CellFlags::UnderlineDouble);
         }
 
-        const u32x2 newColors{ gsl::narrow_cast<u32>(fg | 0xff000000), gsl::narrow_cast<u32>(bg | _api.backgroundOpaqueMixin) };
+        const u32x2 newColors{ gsl::narrow_cast<u32>(fg), gsl::narrow_cast<u32>(bg) };
         const AtlasKeyAttributes attributes{ 0, textAttributes.IsIntense(), textAttributes.IsItalic(), 0 };
 
         if (_api.attributes != attributes)
@@ -602,7 +604,7 @@ try
     }
     else if (textAttributes.BackgroundIsDefault() && bg != _r.backgroundColor)
     {
-        _r.backgroundColor = bg | _api.backgroundOpaqueMixin;
+        _r.backgroundColor = bg;
         WI_SetFlag(_r.invalidations, RenderInvalidations::ConstBuffer);
     }
 


Test patch: