Repository: tektoncd/pipeline (language: go)

Issue:
Error message when PipelineRun is missing parameters required by Pipeline is nonsensical
# Expected Behavior
When not providing the required parameters, an error message occurs: `PipelineRun <namespace name>/<pipeline run name> parameters is missing some parameters required by Pipeline <namespace name>/<pipeline name>'s parameters: pipelineRun missing parameters`

This would align the error message with other error messages in the same file.

# Actual Behavior
When not providing the required parameters, an error message occurs: `PipelineRun<namespace name> parameters is missing some parameters required by Pipeline <pipeline run name>'s parameters: pipelineRun missing parameters`

# Steps to Reproduce the Problem

1. Fail to provide the required parameters for a pipeline
2. See that the error message is weird

# Additional Info
https://github.com/tektoncd/pipeline/blob/main/pkg/reconciler/pipelinerun/pipelinerun.go#L492-L493 <- Source of the nonsensical message. 



Discussion / hints:
Fixing it should be quite simple. The aforementioned lines should be changed to something like:
```			
			"PipelineRun %s/%s parameters is missing some parameters required by Pipeline %s/%s's parameters: %s",
			pr.Namespace, pr.Name, pr.Namespace, pipelineMeta.Name, err)
```

I do not have the time available at the moment to read the contribution guidelines and set up tools etc., so hoping someone else has :)
@jvmdc so one "challenge" to this is, there might not be a named `Pipeline` in the namespace, as one could use inline spec, or resolvers.
Isn't that also an issue in the other errors in the file then?
> Isn't that also an issue in the other errors in the file then?

Well, for example, this [`PipelineRun`](https://github.com/tektoncd/pipeline/blob/main/examples/v1/pipelineruns/pipelinerun-with-pipelinespec.yaml) does not refer any `Pipeline` as everything is inlined.
> > Isn't that also an issue in the other errors in the file then?
> 
> Well, for example, this [`PipelineRun`](https://github.com/tektoncd/pipeline/blob/main/examples/v1/pipelineruns/pipelinerun-with-pipelinespec.yaml) does not refer any `Pipeline` as everything is inlined.

Sure, I get that - But shouldn't that also be a challenge for the other errors in the file linked such as https://github.com/tektoncd/pipeline/blob/main/pkg/reconciler/pipelinerun/pipelinerun.go#L502-L503?

Fix patch:
diff --git a/pkg/reconciler/pipelinerun/pipelinerun.go b/pkg/reconciler/pipelinerun/pipelinerun.go
index 2caea94bd0e..b44ce72d58d 100644
--- a/pkg/reconciler/pipelinerun/pipelinerun.go
+++ b/pkg/reconciler/pipelinerun/pipelinerun.go
@@ -489,8 +489,8 @@ func (c *Reconciler) reconcile(ctx context.Context, pr *v1.PipelineRun, getPipel
 	if err := resources.ValidateRequiredParametersProvided(&pipelineSpec.Params, &pr.Spec.Params); err != nil {
 		// This Run has failed, so we need to mark it as failed and stop reconciling it
 		pr.Status.MarkFailed(v1.PipelineRunReasonParameterMissing.String(),
-			"PipelineRun %s parameters is missing some parameters required by Pipeline %s's parameters: %s",
-			pr.Namespace, pr.Name, err)
+			"PipelineRun %s/%s is missing some parameters required by Pipeline %s/%s: %s",
+			pr.Namespace, pr.Name, pr.Namespace, pipelineMeta.Name, err)
 		return controller.NewPermanentError(err)
 	}
 


Test patch:
diff --git a/pkg/reconciler/pipelinerun/pipelinerun_test.go b/pkg/reconciler/pipelinerun/pipelinerun_test.go
index 447fee02d63..648c4f31977 100644
--- a/pkg/reconciler/pipelinerun/pipelinerun_test.go
+++ b/pkg/reconciler/pipelinerun/pipelinerun_test.go
@@ -956,10 +956,26 @@ spec:
 			"Warning Failed [User error] PipelineRun foo/embedded-pipeline-mismatching-param-type parameters have mismatching types with Pipeline foo/embedded-pipeline-mismatching-param-type's parameters: parameters have inconsistent types : [some-param]",
 		},
 	}, {
-		name: "invalid-pipeline-run-missing-params-shd-stop-reconciling",
+		name: "invalid-pipeline-run-missing-params-with-ref-shd-stop-reconciling",
+		pipelineRun: parse.MustParseV1PipelineRun(t, `
+metadata:
+  name: pipelinerun-missing-params-1
+  namespace: foo
+spec:
+  pipelineRef:
+    name: a-pipeline-with-array-params
+`),
+		reason:         v1.PipelineRunReasonParameterMissing.String(),
+		permanentError: true,
+		wantEvents: []string{
+			"Normal Started",
+			"Warning Failed [User error] PipelineRun foo/pipelinerun-missing-params-1 is missing some parameters required by Pipeline foo/a-pipeline-with-array-params: pipelineRun missing parameters: [some-param]",
+		},
+	}, {
+		name: "invalid-pipeline-run-missing-params-with-spec-shd-stop-reconciling",
 		pipelineRun: parse.MustParseV1PipelineRun(t, fmt.Sprintf(`
 metadata:
-  name: pipelinerun-missing-params
+  name: pipelinerun-missing-params-2
   namespace: foo
 spec:
   pipelineSpec:
@@ -975,7 +991,7 @@ spec:
 		permanentError: true,
 		wantEvents: []string{
 			"Normal Started",
-			"Warning Failed [User error] PipelineRun foo parameters is missing some parameters required by Pipeline pipelinerun-missing-params's parameters: pipelineRun missing parameters: [some-param]",
+			"Warning Failed [User error] PipelineRun foo/pipelinerun-missing-params-2 is missing some parameters required by Pipeline foo/pipelinerun-missing-params-2: pipelineRun missing parameters: [some-param]",
 		},
 	}, {
 		name: "invalid-pipeline-with-invalid-dag-graph",