Repository: fission/fission (language: go)

Issue:
Duplicate Job names in helm chart templates
**Describe the bug**
There is a bug with the helm chart templates for jobs at `charts/fission-all/templates/analytics`. The Jobs are `post-upgrade-job.yaml` and `post-install-job.yaml`.

Both of the files are described using the following:

```yaml
{{- if .Values.analytics }}
apiVersion: batch/v1
kind: Job
metadata:
  name: {{ template "fullname" . }}-{{ .Chart.Version }}
```

In the helm values, if analytics are `true` (which is the default), both jobs will try to be created and cause a conflict within helm. If I set `analytics` to false, the chart will install with the default values.

**Resolution**

Would it be possible to change the name to 

```yaml
name: {{ template "fullname" . }}-{{ .Chart.Version }}-{{ randNumeric 3 }}` 
```

or

```yaml
name: {{ template "fullname" . }}-{{ .Chart.Version }}-post-upgrade` 
```



Discussion / hints:

Fix patch:
diff --git a/charts/fission-all/templates/analytics/post-install-job.yaml b/charts/fission-all/templates/analytics/post-install-job.yaml
index 97dfc3a5d3..ad49a3bd3e 100644
--- a/charts/fission-all/templates/analytics/post-install-job.yaml
+++ b/charts/fission-all/templates/analytics/post-install-job.yaml
@@ -2,7 +2,7 @@
 apiVersion: batch/v1
 kind: Job
 metadata:
-  name: {{ template "fullname" . }}-{{ .Chart.Version }}
+  name: {{ template "fullname" . }}-{{ .Chart.Version }}-post-install
   labels:
     # The "release" convention makes it easy to tie a release to all of the
     # Kubernetes resources that were created as part of that release.
diff --git a/charts/fission-all/templates/analytics/post-upgrade-job.yaml b/charts/fission-all/templates/analytics/post-upgrade-job.yaml
index b90cc1b877..16ba41b616 100644
--- a/charts/fission-all/templates/analytics/post-upgrade-job.yaml
+++ b/charts/fission-all/templates/analytics/post-upgrade-job.yaml
@@ -2,7 +2,7 @@
 apiVersion: batch/v1
 kind: Job
 metadata:
-  name: {{ template "fullname" . }}-{{ .Chart.Version }}
+  name: {{ template "fullname" . }}-{{ .Chart.Version }}-post-upgrade
   labels:
     # The "release" convention makes it easy to tie a release to all of the
     # Kubernetes resources that were created as part of that release.


Test patch: