Repository: electron/electron (language: cpp)

Issue:
`window.showSaveFilePicker()` shows warning in file picker UI
### Preflight Checklist

- [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [x] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a bug report that matches the one I want to file, without success.

### Electron Version

35.0.1, 36.0.0-alpha.2

### What operating system(s) are you using?

macOS

### Operating System Version

macOS Sequioa 15.3.1

### What arch are you using?

arm64 (including Apple Silicon)

### Last Known Working Electron version

29.4.6

### Expected Behavior

If I open a file picker with `window.showSaveFilePicker()`, it shows the standard file picker without any extra warnings.

In the context of an Electron app, I'd expect my app not to be referred to as a "site".

Additionally, in the context of a desktop app, a user expects the app to be able to continuously access files they select through a file picker. Warning them about that is unnecessary.

### Actual Behavior

The file picker contains an ugly warning: "Warning: this site can see edits you make"

![Screenshot](https://github.com/user-attachments/assets/b369517c-e6c3-480d-82b5-405b4abc38bb)

### Testcase Gist URL

https://gist.github.com/11316fce28ba719ce8446fb85955d50c

### Additional Information

_No response_


Discussion / hints:
This first appears in `v30.0.0`. In `v30.0.0-beta.8`, the title reads "All Files" when I test on Linux.
Looks like this broke in cf1087badd437906f280373decb923733a8523e6 which landed right before v30.0.0
It's coming from this line here:

https://github.com/electron/electron/blob/main/shell/browser/file_system_access/file_system_access_permission_context.cc#L830

The `Warning: the site can see changes you make` string is the default English value for `IDS_FILE_SYSTEM_ACCESS_CHOOSER_OPEN_SAVE_FILE_TITLE`.



Fix patch:
diff --git a/shell/browser/file_system_access/file_system_access_permission_context.cc b/shell/browser/file_system_access/file_system_access_permission_context.cc
index 9f4b43645332b..865fa06f19bac 100644
--- a/shell/browser/file_system_access/file_system_access_permission_context.cc
+++ b/shell/browser/file_system_access/file_system_access_permission_context.cc
@@ -825,13 +825,7 @@ std::u16string FileSystemAccessPermissionContext::GetPickerTitle(
               ? IDS_FILE_SYSTEM_ACCESS_CHOOSER_OPEN_WRITABLE_DIRECTORY_TITLE
               : IDS_FILE_SYSTEM_ACCESS_CHOOSER_OPEN_READABLE_DIRECTORY_TITLE);
       break;
-    case blink::mojom::TypeSpecificFilePickerOptionsUnion::Tag::
-        kSaveFilePickerOptions:
-      title = l10n_util::GetStringUTF16(
-          IDS_FILE_SYSTEM_ACCESS_CHOOSER_OPEN_SAVE_FILE_TITLE);
-      break;
-    case blink::mojom::TypeSpecificFilePickerOptionsUnion::Tag::
-        kOpenFilePickerOptions:
+    default:
       break;
   }
   return title;


Test patch: