Implement plan.md: Loss scaling, LR=5e-5, Step-logging
Browse files- local_train.py +2 -2
- src/model.py +2 -1
- src/train.py +14 -2
local_train.py
CHANGED
|
@@ -33,14 +33,14 @@ def main():
|
|
| 33 |
"--data_path", DATASET_DIR,
|
| 34 |
"--epochs", "5",
|
| 35 |
"--batch_size", "64",
|
| 36 |
-
"--lr", "
|
| 37 |
"--min_lr", "5e-6",
|
| 38 |
"--num_workers", "8", # 0 for local windows debugging usually safer
|
| 39 |
"--esm_model_name", "facebook/esm2_t6_8M_UR50D",
|
| 40 |
"--use_lora", "True",
|
| 41 |
"--lora_rank", "8",
|
| 42 |
# Asymmetric Loss defaults
|
| 43 |
-
"--gamma_neg", "
|
| 44 |
"--gamma_pos", "0",
|
| 45 |
"--clip", "0.05",
|
| 46 |
"--max_grad_norm", "1.0",
|
|
|
|
| 33 |
"--data_path", DATASET_DIR,
|
| 34 |
"--epochs", "5",
|
| 35 |
"--batch_size", "64",
|
| 36 |
+
"--lr", "5e-5",
|
| 37 |
"--min_lr", "5e-6",
|
| 38 |
"--num_workers", "8", # 0 for local windows debugging usually safer
|
| 39 |
"--esm_model_name", "facebook/esm2_t6_8M_UR50D",
|
| 40 |
"--use_lora", "True",
|
| 41 |
"--lora_rank", "8",
|
| 42 |
# Asymmetric Loss defaults
|
| 43 |
+
"--gamma_neg", "2",
|
| 44 |
"--gamma_pos", "0",
|
| 45 |
"--clip", "0.05",
|
| 46 |
"--max_grad_norm", "1.0",
|
src/model.py
CHANGED
|
@@ -202,7 +202,8 @@ class AsymmetricLoss(nn.Module):
|
|
| 202 |
loss = - (los_pos + los_neg)
|
| 203 |
|
| 204 |
if self.reduction == 'mean':
|
| 205 |
-
loss = loss.mean()
|
|
|
|
| 206 |
elif self.reduction == 'sum':
|
| 207 |
loss = loss.sum()
|
| 208 |
|
|
|
|
| 202 |
loss = - (los_pos + los_neg)
|
| 203 |
|
| 204 |
if self.reduction == 'mean':
|
| 205 |
+
# loss = loss.mean()
|
| 206 |
+
loss = loss.sum() / x.size(0)
|
| 207 |
elif self.reduction == 'sum':
|
| 208 |
loss = loss.sum()
|
| 209 |
|
src/train.py
CHANGED
|
@@ -319,7 +319,7 @@ def validate_loss(model, valid_loader, criterion, device):
|
|
| 319 |
def main():
|
| 320 |
parser = argparse.ArgumentParser()
|
| 321 |
parser.add_argument("--data_path", type=str, required=True, help="Path to mounted dataset")
|
| 322 |
-
parser.add_argument("--lr", type=float, default=
|
| 323 |
parser.add_argument("--batch_size", type=int, default=32)
|
| 324 |
parser.add_argument("--epochs", type=int, default=10)
|
| 325 |
parser.add_argument("--num_workers", type=int, default=4, help="Number of data loader workers")
|
|
@@ -327,7 +327,7 @@ def main():
|
|
| 327 |
parser.add_argument("--T_mult", type=int, default=1, help="CosineAnnealingWarmRestarts T_mult")
|
| 328 |
parser.add_argument("--min_lr", type=float, default=1e-6, help="Minimum learning rate")
|
| 329 |
parser.add_argument("--esm_model_name", type=str, default="facebook/esm2_t33_650M_UR50D", help="ESM model name")
|
| 330 |
-
parser.add_argument("--gamma_neg", type=float, default=
|
| 331 |
parser.add_argument("--gamma_pos", type=float, default=0, help="Asymmetric Loss gamma_pos")
|
| 332 |
parser.add_argument("--clip", type=float, default=0.05, help="Asymmetric Loss clip")
|
| 333 |
parser.add_argument("--max_grad_norm", type=float, default=1.0, help="Max gradient norm for clipping")
|
|
@@ -542,6 +542,18 @@ def main():
|
|
| 542 |
total_loss += loss.item()
|
| 543 |
total_grad_norm += grad_norm.item()
|
| 544 |
steps += 1
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 545 |
pbar.set_postfix({'loss': total_loss/steps})
|
| 546 |
|
| 547 |
if args.dry_run and steps >= 5:
|
|
|
|
| 319 |
def main():
|
| 320 |
parser = argparse.ArgumentParser()
|
| 321 |
parser.add_argument("--data_path", type=str, required=True, help="Path to mounted dataset")
|
| 322 |
+
parser.add_argument("--lr", type=float, default=5e-5)
|
| 323 |
parser.add_argument("--batch_size", type=int, default=32)
|
| 324 |
parser.add_argument("--epochs", type=int, default=10)
|
| 325 |
parser.add_argument("--num_workers", type=int, default=4, help="Number of data loader workers")
|
|
|
|
| 327 |
parser.add_argument("--T_mult", type=int, default=1, help="CosineAnnealingWarmRestarts T_mult")
|
| 328 |
parser.add_argument("--min_lr", type=float, default=1e-6, help="Minimum learning rate")
|
| 329 |
parser.add_argument("--esm_model_name", type=str, default="facebook/esm2_t33_650M_UR50D", help="ESM model name")
|
| 330 |
+
parser.add_argument("--gamma_neg", type=float, default=2, help="Asymmetric Loss gamma_neg")
|
| 331 |
parser.add_argument("--gamma_pos", type=float, default=0, help="Asymmetric Loss gamma_pos")
|
| 332 |
parser.add_argument("--clip", type=float, default=0.05, help="Asymmetric Loss clip")
|
| 333 |
parser.add_argument("--max_grad_norm", type=float, default=1.0, help="Max gradient norm for clipping")
|
|
|
|
| 542 |
total_loss += loss.item()
|
| 543 |
total_grad_norm += grad_norm.item()
|
| 544 |
steps += 1
|
| 545 |
+
|
| 546 |
+
# Step-wise Logging
|
| 547 |
+
if steps % 10 == 0:
|
| 548 |
+
current_gnorm = grad_norm.item() if isinstance(grad_norm, torch.Tensor) else grad_norm
|
| 549 |
+
global_step = (epoch - 1) * len(train_loader) + steps
|
| 550 |
+
|
| 551 |
+
mlflow.log_metrics({
|
| 552 |
+
"step_train_loss": loss.item(),
|
| 553 |
+
"step_grad_norm": current_gnorm,
|
| 554 |
+
"step_lr": optimizer.param_groups[0]['lr']
|
| 555 |
+
}, step=global_step)
|
| 556 |
+
|
| 557 |
pbar.set_postfix({'loss': total_loss/steps})
|
| 558 |
|
| 559 |
if args.dry_run and steps >= 5:
|