Project: gpac (gpac/gpac), language: c++
Vulnerability instance: gpac.cve-2020-22673
Sanitizer: address

================= Bug Report (1/1) ==================
## Source: GitHub Issue
## URL: https://github.com/gpac/gpac/issues/1342
## Description:
Issue: gpac/gpac#1342
Title: There are memory leaks in the senc_Parse function of box_code_drm.c:1349
State: closed
Created by: gutiniao
Created at: 2019-11-13 04:06:43+00:00

Issue Body:
Thanks for reporting your issue. Please make sure these boxes are checked before submitting your issue - thank you!

[ √] I looked for a similar issue and couldn't find any.
[ √] I tried with the latest version of GPAC. Installers available at http://gpac.io/downloads/gpac-nightly-builds/
[ √] I give enough information for contributors to reproduce my issue (meaningful title, github labels, platform and compiler, command-line ...). I can share files anonymously with this dropbox: https://www.mediafire.com/filedrop/filedrop_hosted.php?drop=eec9e058a9486fe4e99c33021481d9e1826ca9dbc242a6cfaab0fe95da5e5d95
Detailed guidelines: http://gpac.io/2013/07/16/how-to-file-a-bug-properly/

A crafted input will lead to crash in box_code_drm.c at gpac 0.8.0.

Triggered by
./MP4Box -diso POC -out /dev/null

Poc
[004-memleak-senc1349](https://github.com/gutiniao/afltest/blob/master/004-memleak-senc1349)

The ASAN information is as follows:

```
./MP4Box -diso 004-memleak-senc1349 -out /dev/null 
[iso file] Box "avcC" (start 939) has 34 extra bytes
[iso file] Unknown box type 0000 in parent sinf
[iso file] Unknown box type 75876C20 in parent dref
[iso file] Unknown box type 0000 in parent schi
[iso file] Unknown box type stts in parent stsd
[iso file] Unknown box type stsc in parent stsd
[iso file] Unknown box type stsz in parent stsd
[iso file] Unknown box type stco in parent stsd
[iso file] Unknown box type sgpd in parent stsd
[iso file] Unknown box type udta in parent stsd
[iso file] Box "stsd" (start 1439) has 8825 extra bytes
[iso file] Box "stsd" is larger than container box
[iso file] Box "stbl" size 291 (start 1431) invalid (read 9139)
[ISO file] dataReferenceIndex set to 0 in sample entry, overriding to 1
[ISO file] dataReferenceIndex set to 0 in sample entry, overriding to 1
[ISO file] dataReferenceIndex set to 0 in sample entry, overriding to 1
[ISO file] dataReferenceIndex set to 0 in sample entry, overriding to 1
[iso file] senc box without tenc, assuming MS smooth+piff
[isobmf] Failed to parse SENC box, invalid SAI size
[isobmf] could not get cenc info for sample 1: Invalid IsoMedia File
Error opening file 004-memleak-senc1349: Invalid IsoMedia File

=================================================================
==2371==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 32 byte(s) in 1 object(s) allocated from:
    #0 0x7f0fc2519b50 in __interceptor_malloc (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xdeb50)
    #1 0x564665fcabe9 in senc_Parse isomedia/box_code_drm.c:1349

SUMMARY: AddressSanitizer: 32 byte(s) leaked in 1 allocation(s).
```
about code:

```
#endif
        count = gf_bs_read_u32(bs);
        if (!senc->samp_aux_info) senc->samp_aux_info = gf_list_new();
        for (i=0; i<count; i++) {
                u32 is_encrypted;
---------->GF_CENCSampleAuxInfo *sai = (GF_CENCSampleAuxInfo *)gf_malloc(sizeof(GF_CENCSampleAuxInfo));
                memset(sai, 0, sizeof(GF_CENCSampleAuxInfo));
```


Comments:
Comment by aureliendavid on 2020-01-09 17:59:51+00:00:
thanks for the report

this should be fixed by the commit above 

reopen if needed

Commit References:
eec9e058a9486fe4e99c33021481d9e1826ca9db

Build script:
#!/bin/bash -eu
# Minimized build script with only core build commands
set -eu
./configure --static-build --extra-cflags="${CFLAGS}" --extra-ldflags="${CFLAGS}"
make -j$(nproc)

Dockerfile:
FROM hwiwonlee/secb.base:latest
RUN apt-get update && apt-get install -y build-essential pkg-config libz-dev
RUN git clone https://github.com/gpac/gpac gpac
RUN git -C gpac checkout 6b4ab401297be43b57f9eddd675971a8a5feab44
WORKDIR $SRC/gpac
COPY build.sh $SRC/

Additional files:
filename: fuzz_parse.c
content: /* Copyright 2021 Google LLC
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
      http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
#include <stdio.h>
#include <unistd.h>

#include <gpac/internal/isomedia_dev.h>
#include <gpac/constants.h>

int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size) {
    char filename[256];
    sprintf(filename, "/tmp/libfuzzer.%d", getpid());

    FILE *fp = fopen(filename, "wb");
    if (!fp) {
        return 0;
    }
    fwrite(data, size, 1, fp);
    fclose(fp);

    GF_ISOFile *movie = NULL;
    movie = gf_isom_open_file(filename, GF_ISOM_OPEN_READ_DUMP, NULL);
    if (movie != NULL) {
        gf_isom_close(movie);
    }
    unlink(filename);
    return 0;
}