Project: gpac (gpac/gpac), language: c++
Vulnerability instance: gpac.cve-2020-23931
Sanitizer: address

================= Bug Report (1/2) ==================
## Source: GitHub Issue
## URL: https://github.com/gpac/gpac/issues/1564
## Description:
Issue: gpac/gpac#1564
Title: A heap-buffer-overflow in box_code_adobe.c:109
State: closed
Created by: seviezhou
Created at: 2020-08-07 01:48:18+00:00

Issue Body:
## System info

Ubuntu x86_64, gcc (Ubuntu 5.5.0-12ubuntu1), MP4Box (latest master [2aa266](https://github.com/gpac/gpac/commit/2aa266dfaab6aaad9f9f4f216ad7d1e62adc7fa0))

## Configure

CFLAGS="-g -fsanitize=address" LDFLAGS="-fsanitize=address -ldl" ./configure --static-mp4box

## Command line

./bin/gcc/MP4Box -diso -out /dev/null @@

## AddressSanitizer output

```
=================================================================
==18613==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x60200000e11c at pc 0x7f33b3f553d5 bp 0x7ffd678545b0 sp 0x7ffd67853d58
READ of size 13 at 0x60200000e11c thread T0
    #0 0x7f33b3f553d4 in strdup (/usr/lib/x86_64-linux-gnu/libasan.so.2+0x623d4)
    #1 0x559646e8d0b7 in abst_box_read isomedia/box_code_adobe.c:109
    #2 0x559646cffd84 in gf_isom_box_read isomedia/box_funcs.c:1681
    #3 0x559646cffd84 in gf_isom_box_parse_ex isomedia/box_funcs.c:259
    #4 0x559646d01871 in gf_isom_parse_root_box isomedia/box_funcs.c:38
    #5 0x559646d30bf6 in gf_isom_parse_movie_boxes isomedia/isom_intern.c:259
    #6 0x559646d3a6c2 in gf_isom_parse_movie_boxes isomedia/isom_intern.c:247
    #7 0x559646d3a6c2 in gf_isom_open_file isomedia/isom_intern.c:740
    #8 0x559646897b30 in mp4boxMain /home/seviezhou/gpac/applications/mp4box/main.c:5331
    #9 0x7f33b2f1fb96 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21b96)
    #10 0x55964685e179 in _start (/home/seviezhou/gpac/bin/gcc/MP4Box+0x78179)

0x60200000e11c is located 0 bytes to the right of 12-byte region [0x60200000e110,0x60200000e11c)
allocated by thread T0 here:
    #0 0x7f33b3f8b612 in malloc (/usr/lib/x86_64-linux-gnu/libasan.so.2+0x98612)
    #1 0x559646e895e3 in abst_box_read isomedia/box_code_adobe.c:97

SUMMARY: AddressSanitizer: heap-buffer-overflow ??:0 strdup
Shadow bytes around the buggy address:
  0x0c047fff9bd0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c047fff9be0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c047fff9bf0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c047fff9c00: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c047fff9c10: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
=>0x0c047fff9c20: fa fa 00[04]fa fa 00 00 fa fa 00 00 fa fa 00 00
  0x0c047fff9c30: fa fa 00 00 fa fa 00 00 fa fa fd fa fa fa 00 fa
  0x0c047fff9c40: fa fa 00 00 fa fa 00 00 fa fa 00 07 fa fa fd fa
  0x0c047fff9c50: fa fa 00 02 fa fa 04 fa fa fa fd fa fa fa 07 fa
  0x0c047fff9c60: fa fa fd fa fa fa 05 fa fa fa fd fa fa fa 00 fa
  0x0c047fff9c70: fa fa fd fa fa fa 07 fa fa fa fd fa fa fa 07 fa
Shadow byte legend (one shadow byte represents 8 application bytes):
  Addressable:           00
  Partially addressable: 01 02 03 04 05 06 07
  Heap left redzone:       fa
  Heap right redzone:      fb
  Freed heap region:       fd
  Stack left redzone:      f1
  Stack mid redzone:       f2
  Stack right redzone:     f3
  Stack partial redzone:   f4
  Stack after return:      f5
  Stack use after scope:   f8
  Global redzone:          f9
  Global init order:       f6
  Poisoned by user:        f7
  Container overflow:      fc
  Array cookie:            ac
  Intra object redzone:    bb
  ASan internal:           fe
==18613==ABORTING
```

## POC

[heap-overflow-abst_box_read-box_code_adobe-109.zip](https://github.com/gpac/gpac/files/5038865/heap-overflow-abst_box_read-box_code_adobe-109.zip)



Comments:
Comment by jeanlf on 2020-09-01 14:43:15+00:00:
fixed, thanks for the report

Attachments:
https://github.com/gpac/gpac/files/5038865/heap-overflow-abst_box_read-box_code_adobe-109.zip

Commit References:
2aa266dfaab6aaad9f9f4f216ad7d1e62adc7fa0

================= Bug Report (2/2) ==================
## Source: GitHub Issue
## URL: https://github.com/gpac/gpac/issues/1567
## Description:
Issue: gpac/gpac#1567
Title: A heap-buffer-overflow in box_code_adobe.c:155
State: closed
Created by: seviezhou
Created at: 2020-08-07 04:38:51+00:00

Issue Body:
## System info

Ubuntu x86_64, gcc (Ubuntu 5.5.0-12ubuntu1), MP4Box (latest master [2aa266](https://github.com/gpac/gpac/commit/2aa266dfaab6aaad9f9f4f216ad7d1e62adc7fa0))

## Configure

CFLAGS="-g -fsanitize=address" LDFLAGS="-fsanitize=address" ./configure --static-mp4box

## Command line

./bin/gcc/MP4Box -diso -out /dev/null @@

## AddressSanitizer output

```
=================================================================
==38343==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x60600000ec94 at pc 0x7f6ebd7a53d5 bp 0x7ffd9261d2c0 sp 0x7ffd9261ca68
READ of size 53 at 0x60600000ec94 thread T0
    #0 0x7f6ebd7a53d4 in strdup (/usr/lib/x86_64-linux-gnu/libasan.so.2+0x623d4)
    #1 0x562152c228bf in abst_box_read isomedia/box_code_adobe.c:155
    #2 0x562152a11b64 in gf_isom_box_read isomedia/box_funcs.c:1681
    #3 0x562152a11b64 in gf_isom_box_parse_ex isomedia/box_funcs.c:259
    #4 0x562152a13041 in gf_isom_parse_root_box isomedia/box_funcs.c:38
    #5 0x562152a4a6f5 in gf_isom_parse_movie_boxes isomedia/isom_intern.c:259
    #6 0x562152a55951 in gf_isom_parse_movie_boxes isomedia/isom_intern.c:247
    #7 0x562152a55951 in gf_isom_open_file isomedia/isom_intern.c:740
    #8 0x56215237f7e3 in mp4boxMain /home/seviezhou/gpac/applications/mp4box/main.c:5331
    #9 0x7f6ebc76fb96 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21b96)
    #10 0x562152350f09 in _start (/home/seviezhou/gpac/bin/gcc/MP4Box+0x27ff09)

0x60600000ec94 is located 0 bytes to the right of 52-byte region [0x60600000ec60,0x60600000ec94)
allocated by thread T0 here:
    #0 0x7f6ebd7db612 in malloc (/usr/lib/x86_64-linux-gnu/libasan.so.2+0x98612)
    #1 0x562152c203a9 in abst_box_read isomedia/box_code_adobe.c:97

SUMMARY: AddressSanitizer: heap-buffer-overflow ??:0 strdup
Shadow bytes around the buggy address:
  0x0c0c7fff9d40: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c0c7fff9d50: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c0c7fff9d60: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c0c7fff9d70: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c0c7fff9d80: fa fa fa fa fa fa fa fa fa fa fa fa 00 00 00 00
=>0x0c0c7fff9d90: 00 00[04]fa fa fa fa fa 00 00 00 00 00 00 00 fa
  0x0c0c7fff9da0: fa fa fa fa 00 00 00 00 00 00 00 fa fa fa fa fa
  0x0c0c7fff9db0: 00 00 00 00 00 00 00 03 fa fa fa fa 00 00 00 00
  0x0c0c7fff9dc0: 00 00 02 fa fa fa fa fa fd fd fd fd fd fd fd fd
  0x0c0c7fff9dd0: fa fa fa fa fd fd fd fd fd fd fd fa fa fa fa fa
  0x0c0c7fff9de0: fd fd fd fd fd fd fd fd fa fa fa fa 00 00 00 00
Shadow byte legend (one shadow byte represents 8 application bytes):
  Addressable:           00
  Partially addressable: 01 02 03 04 05 06 07
  Heap left redzone:       fa
  Heap right redzone:      fb
  Freed heap region:       fd
  Stack left redzone:      f1
  Stack mid redzone:       f2
  Stack right redzone:     f3
  Stack partial redzone:   f4
  Stack after return:      f5
  Stack use after scope:   f8
  Global redzone:          f9
  Global init order:       f6
  Poisoned by user:        f7
  Container overflow:      fc
  Array cookie:            ac
  Intra object redzone:    bb
  ASan internal:           fe
==38343==ABORTING
```

## POC

[heap-overflow-abst_box_read-box_code_adobe-155.zip](https://github.com/gpac/gpac/files/5039343/heap-overflow-abst_box_read-box_code_adobe-155.zip)



Comments:
Comment by jeanlf on 2020-09-01 15:06:33+00:00:
fixed by #1564 

Attachments:
https://github.com/gpac/gpac/files/5039343/heap-overflow-abst_box_read-box_code_adobe-155.zip

Commit References:
2aa266dfaab6aaad9f9f4f216ad7d1e62adc7fa0

Build script:
#!/bin/bash -eu
# Minimized build script with only core build commands
set -eu
./configure --static-build --extra-cflags="${CFLAGS}" --extra-ldflags="${CFLAGS}"
make -j$(nproc)

Dockerfile:
FROM hwiwonlee/secb.base:latest
RUN apt-get update && apt-get install -y build-essential pkg-config libz-dev
RUN git clone https://github.com/gpac/gpac gpac
RUN git -C gpac checkout 348365dd176f4b03e607aaafce39674a4a0c8165
WORKDIR $SRC/gpac
COPY build.sh $SRC/

Additional files:
filename: fuzz_parse.c
content: /* Copyright 2021 Google LLC
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
      http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
#include <stdio.h>
#include <unistd.h>

#include <gpac/internal/isomedia_dev.h>
#include <gpac/constants.h>

int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size) {
    char filename[256];
    sprintf(filename, "/tmp/libfuzzer.%d", getpid());

    FILE *fp = fopen(filename, "wb");
    if (!fp) {
        return 0;
    }
    fwrite(data, size, 1, fp);
    fclose(fp);

    GF_ISOFile *movie = NULL;
    movie = gf_isom_open_file(filename, GF_ISOM_OPEN_READ_DUMP, NULL);
    if (movie != NULL) {
        gf_isom_close(movie);
    }
    unlink(filename);
    return 0;
}