Project: imagemagick (imagemagick/imagemagick), language: c++
Vulnerability instance: imagemagick.cve-2018-5246
Sanitizer: address

================= Bug Report (1/1) ==================
## Source: GitHub Issue
## URL: https://github.com/ImageMagick/ImageMagick/issues/929
## Description:
Issue: ImageMagick/ImageMagick#929
Title: memory leaks
State: closed
Created by: littleputa
Created at: 2018-01-04 01:33:05+00:00
Labels: bug

Issue Body:
ubuntu@ubuntu:~/fuzz_py$ magick -version
Version: ImageMagick 7.0.7-17 Q16 x86_64 2017-12-26 http://www.imagemagick.org
Copyright: © 1999-2018 ImageMagick Studio LLC
License: http://www.imagemagick.org/script/license.php
Features: Cipher DPC HDRI OpenMP 
Delegates (built-in): fontconfig freetype png x zlib


ubuntu@ubuntu:~/fuzz_py$ magick montage poc.pattern /dev/null
montage: unrecognized image format `poc.pattern' @ error/pattern.c/ReadPATTERNImage/980.
montage:  `/dev/null' @ error/montage.c/MontageImageCommand/1777.

=================================================================
==108470==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 13024 byte(s) in 1 object(s) allocated from:
    #0 0x4b9ad3 in malloc (/usr/local/bin/magick+0x4b9ad3)
    #1 0x7f1281f6b7dd in AcquireCriticalMemory /home/ubuntu/ImageMagick/./MagickCore/memory-private.h:57:10
    #2 0x7f1281f74d29 in AcquireImageInfo /home/ubuntu/ImageMagick/MagickCore/image.c:346:28
    #3 0x7f1281f74d29 in CloneImageInfo /home/ubuntu/ImageMagick/MagickCore/image.c:947
    #4 0x7f12823a6c3b in ReadPATTERNImage /home/ubuntu/ImageMagick/coders/pattern.c:966:13
    #5 0x7f1281dc9af1 in ReadImage /home/ubuntu/ImageMagick/MagickCore/constitute.c:497:13
    #6 0x7f1281dcc2f4 in ReadImages /home/ubuntu/ImageMagick/MagickCore/constitute.c:866:9
    #7 0x7f12816de3c7 in MontageImageCommand /home/ubuntu/ImageMagick/MagickWand/montage.c:410:20
    #8 0x7f12816652d2 in MagickCommandGenesis /home/ubuntu/ImageMagick/MagickWand/mogrify.c:183:14
    #9 0x4e4ce7 in MagickMain /home/ubuntu/ImageMagick/utilities/magick.c:149:10
    #10 0x4e4ce7 in main /home/ubuntu/ImageMagick/utilities/magick.c:180
    #11 0x7f127f1e5f44 in __libc_start_main /build/eglibc-oGUzwX/eglibc-2.19/csu/libc-start.c:287

Indirect leak of 88 byte(s) in 1 object(s) allocated from:
    #0 0x4b9ad3 in malloc (/usr/local/bin/magick+0x4b9ad3)
    #1 0x7f1282188369 in AcquireCriticalMemory /home/ubuntu/ImageMagick/./MagickCore/memory-private.h:57:10
    #2 0x7f1282188369 in NewSplayTree /home/ubuntu/ImageMagick/MagickCore/splay-tree.c:1148
    #3 0x7f128218802d in CloneSplayTree /home/ubuntu/ImageMagick/MagickCore/splay-tree.c:360:14
    #4 0x7f1281fe283a in CloneImageOptions /home/ubuntu/ImageMagick/MagickCore/option.c:2131:27
    #5 0x7f1281f75803 in CloneImageInfo /home/ubuntu/ImageMagick/MagickCore/image.c:1012:10
    #6 0x7f12823a6c3b in ReadPATTERNImage /home/ubuntu/ImageMagick/coders/pattern.c:966:13
    #7 0x7f1281dc9af1 in ReadImage /home/ubuntu/ImageMagick/MagickCore/constitute.c:497:13
    #8 0x7f1281dcc2f4 in ReadImages /home/ubuntu/ImageMagick/MagickCore/constitute.c:866:9
    #9 0x7f12816de3c7 in MontageImageCommand /home/ubuntu/ImageMagick/MagickWand/montage.c:410:20
    #10 0x7f12816652d2 in MagickCommandGenesis /home/ubuntu/ImageMagick/MagickWand/mogrify.c:183:14
    #11 0x4e4ce7 in MagickMain /home/ubuntu/ImageMagick/utilities/magick.c:149:10
    #12 0x4e4ce7 in main /home/ubuntu/ImageMagick/utilities/magick.c:180
    #13 0x7f127f1e5f44 in __libc_start_main /build/eglibc-oGUzwX/eglibc-2.19/csu/libc-start.c:287

Indirect leak of 64 byte(s) in 1 object(s) allocated from:
    #0 0x4ba78e in __interceptor_posix_memalign (/usr/local/bin/magick+0x4ba78e)
    #1 0x7f128216864a in AcquireSemaphoreMemory /home/ubuntu/ImageMagick/MagickCore/semaphore.c:154:7
    #2 0x7f128216864a in AcquireSemaphoreInfo /home/ubuntu/ImageMagick/MagickCore/semaphore.c:200
    #3 0x7f1282188451 in NewSplayTree /home/ubuntu/ImageMagick/MagickCore/splay-tree.c:1159:25
    #4 0x7f128218802d in CloneSplayTree /home/ubuntu/ImageMagick/MagickCore/splay-tree.c:360:14
    #5 0x7f1281fe283a in CloneImageOptions /home/ubuntu/ImageMagick/MagickCore/option.c:2131:27
    #6 0x7f1281f75803 in CloneImageInfo /home/ubuntu/ImageMagick/MagickCore/image.c:1012:10
    #7 0x7f12823a6c3b in ReadPATTERNImage /home/ubuntu/ImageMagick/coders/pattern.c:966:13
    #8 0x7f1281dc9af1 in ReadImage /home/ubuntu/ImageMagick/MagickCore/constitute.c:497:13
    #9 0x7f1281dcc2f4 in ReadImages /home/ubuntu/ImageMagick/MagickCore/constitute.c:866:9
    #10 0x7f12816de3c7 in MontageImageCommand /home/ubuntu/ImageMagick/MagickWand/montage.c:410:20
    #11 0x7f12816652d2 in MagickCommandGenesis /home/ubuntu/ImageMagick/MagickWand/mogrify.c:183:14
    #12 0x4e4ce7 in MagickMain /home/ubuntu/ImageMagick/utilities/magick.c:149:10
    #13 0x4e4ce7 in main /home/ubuntu/ImageMagick/utilities/magick.c:180
    #14 0x7f127f1e5f44 in __libc_start_main /build/eglibc-oGUzwX/eglibc-2.19/csu/libc-start.c:287

Indirect leak of 32 byte(s) in 1 object(s) allocated from:
    #0 0x4b9ad3 in malloc (/usr/local/bin/magick+0x4b9ad3)
    #1 0x7f12821871a6 in AddValueToSplayTree /home/ubuntu/ImageMagick/MagickCore/splay-tree.c:189:21
    #2 0x7f1282188171 in CloneSplayTree /home/ubuntu/ImageMagick/MagickCore/splay-tree.c:372:12
    #3 0x7f1281fe283a in CloneImageOptions /home/ubuntu/ImageMagick/MagickCore/option.c:2131:27
    #4 0x7f1281f75803 in CloneImageInfo /home/ubuntu/ImageMagick/MagickCore/image.c:1012:10
    #5 0x7f12823a6c3b in ReadPATTERNImage /home/ubuntu/ImageMagick/coders/pattern.c:966:13
    #6 0x7f1281dc9af1 in ReadImage /home/ubuntu/ImageMagick/MagickCore/constitute.c:497:13
    #7 0x7f1281dcc2f4 in ReadImages /home/ubuntu/ImageMagick/MagickCore/constitute.c:866:9
    #8 0x7f12816de3c7 in MontageImageCommand /home/ubuntu/ImageMagick/MagickWand/montage.c:410:20
    #9 0x7f12816652d2 in MagickCommandGenesis /home/ubuntu/ImageMagick/MagickWand/mogrify.c:183:14
    #10 0x4e4ce7 in MagickMain /home/ubuntu/ImageMagick/utilities/magick.c:149:10
    #11 0x4e4ce7 in main /home/ubuntu/ImageMagick/utilities/magick.c:180
    #12 0x7f127f1e5f44 in __libc_start_main /build/eglibc-oGUzwX/eglibc-2.19/csu/libc-start.c:287

Indirect leak of 12 byte(s) in 1 object(s) allocated from:
    #0 0x4b9ad3 in malloc (/usr/local/bin/magick+0x4b9ad3)
    #1 0x7f12821be97e in ConstantString /home/ubuntu/ImageMagick/MagickCore/string.c:700:26
    #2 0x7f1282188163 in CloneSplayTree /home/ubuntu/ImageMagick/MagickCore/splay-tree.c:373:7
    #3 0x7f1281fe283a in CloneImageOptions /home/ubuntu/ImageMagick/MagickCore/option.c:2131:27
    #4 0x7f1281f75803 in CloneImageInfo /home/ubuntu/ImageMagick/MagickCore/image.c:1012:10
    #5 0x7f12823a6c3b in ReadPATTERNImage /home/ubuntu/ImageMagick/coders/pattern.c:966:13
    #6 0x7f1281dc9af1 in ReadImage /home/ubuntu/ImageMagick/MagickCore/constitute.c:497:13
    #7 0x7f1281dcc2f4 in ReadImages /home/ubuntu/ImageMagick/MagickCore/constitute.c:866:9
    #8 0x7f12816de3c7 in MontageImageCommand /home/ubuntu/ImageMagick/MagickWand/montage.c:410:20
    #9 0x7f12816652d2 in MagickCommandGenesis /home/ubuntu/ImageMagick/MagickWand/mogrify.c:183:14
    #10 0x4e4ce7 in MagickMain /home/ubuntu/ImageMagick/utilities/magick.c:149:10
    #11 0x4e4ce7 in main /home/ubuntu/ImageMagick/utilities/magick.c:180
    #12 0x7f127f1e5f44 in __libc_start_main /build/eglibc-oGUzwX/eglibc-2.19/csu/libc-start.c:287

Indirect leak of 9 byte(s) in 1 object(s) allocated from:
    #0 0x4b9ad3 in malloc (/usr/local/bin/magick+0x4b9ad3)
    #1 0x7f12821be97e in ConstantString /home/ubuntu/ImageMagick/MagickCore/string.c:700:26
    #2 0x7f1282188131 in CloneSplayTree /home/ubuntu/ImageMagick/MagickCore/splay-tree.c:372:43
    #3 0x7f1281fe283a in CloneImageOptions /home/ubuntu/ImageMagick/MagickCore/option.c:2131:27
    #4 0x7f1281f75803 in CloneImageInfo /home/ubuntu/ImageMagick/MagickCore/image.c:1012:10
    #5 0x7f12823a6c3b in ReadPATTERNImage /home/ubuntu/ImageMagick/coders/pattern.c:966:13
    #6 0x7f1281dc9af1 in ReadImage /home/ubuntu/ImageMagick/MagickCore/constitute.c:497:13
    #7 0x7f1281dcc2f4 in ReadImages /home/ubuntu/ImageMagick/MagickCore/constitute.c:866:9
    #8 0x7f12816de3c7 in MontageImageCommand /home/ubuntu/ImageMagick/MagickWand/montage.c:410:20
    #9 0x7f12816652d2 in MagickCommandGenesis /home/ubuntu/ImageMagick/MagickWand/mogrify.c:183:14
    #10 0x4e4ce7 in MagickMain /home/ubuntu/ImageMagick/utilities/magick.c:149:10
    #11 0x4e4ce7 in main /home/ubuntu/ImageMagick/utilities/magick.c:180
    #12 0x7f127f1e5f44 in __libc_start_main /build/eglibc-oGUzwX/eglibc-2.19/csu/libc-start.c:287

SUMMARY: AddressSanitizer: 13229 byte(s) leaked in 6 allocation(s).

[poc.zip](https://github.com/ImageMagick/ImageMagick/files/1602200/poc.zip)



Comments:
Comment by urban-warrior on 2018-01-04 11:39:39+00:00:
Thanks for the problem report.  We can reproduce it and will have a patch to fix it in GIT master branch @ https://github.com/ImageMagick/ImageMagick later today.  The patch will be available in the beta releases of ImageMagick @ http://www.imagemagick.org/download/beta/ by sometime tomorrow. 


---

Comment by littleputa on 2018-01-05 00:50:07+00:00:
credit: nsfocus security team.

---

Comment by littleputa on 2018-01-08 00:57:35+00:00:
CVE-2018-5246

Attachments:
https://github.com/ImageMagick/ImageMagick/files/1602200/poc.zip

Build script:
#!/bin/bash -eu
# Minimized build script with only core build commands
set -eu
./configure --prefix="$WORK" --disable-shared --disable-docs
make "-j$(nproc)"
make install -j$(nproc)

Dockerfile:
FROM hwiwonlee/secb.base:latest
RUN apt-get update && apt-get install -y make autoconf automake libtool
RUN git clone https://github.com/imagemagick/imagemagick imagemagick
RUN git -C imagemagick checkout c9d4c4ecd1f7fb5168e512a0ba183b4bf8b47ce3
WORKDIR $SRC/imagemagick
COPY build.sh $SRC/

Additional files:
filename: crop_fuzzer.cc
content: #include <cstdint>

#include <Magick++/Blob.h>
#include <Magick++/Image.h>

extern "C" int LLVMFuzzerTestOneInput(const uint8_t *Data, size_t Size) {
  uint16_t Width;
  uint16_t Height;
  if (Size < (sizeof(Width) + sizeof(Height))) {
    return 0;
  }
  Width = *reinterpret_cast<const uint16_t *>(Data);
  Height = *reinterpret_cast<const uint16_t *>(Data + sizeof(Width));
  const Magick::Blob blob(Data + sizeof(Width) + sizeof(Height),
                          Size - (sizeof(Width) + sizeof(Height)));
  Magick::Image image;
  try {
    image.read(blob);
  } catch (Magick::Exception &e) {
    return 0;
  }
  image.crop(Magick::Geometry(Width, Height));
  return 0;
}

filename: encoder_fuzzer.cc
content: #include <cstdint>

#include <Magick++/Blob.h>
#include <Magick++/Image.h>

#define FUZZ_ENCODER_STRING_LITERAL(name) #name
#define FUZZ_ENCODER FUZZ_ENCODER_STRING_LITERAL(FUZZ_IMAGEMAGICK_ENCODER)

extern "C" int LLVMFuzzerTestOneInput(const uint8_t *Data, size_t Size) {
  const Magick::Blob blob(Data, Size);
  Magick::Image image;
  try {
    image.read(blob);
  } catch (Magick::Exception &e) {
    return 0;
  }

  Magick::Blob outBlob;
  try {
    image.write(&outBlob, FUZZ_ENCODER);
  } catch (Magick::Exception &e) {
  }
  return 0;
}

filename: encoder_list.cc
content: #include <iostream>

#include <Magick++/Blob.h>
#include <Magick++/Image.h>

extern "C" int main() {
  size_t nFormats;
  Magick::ExceptionInfo ex;
  const Magick::MagickInfo **formats = GetMagickInfoList("*", &nFormats, &ex);

  for (size_t i = 0; i < nFormats; i++) {
    const Magick::MagickInfo *format = formats[i];
    if (format->encoder && format->name) {
      std::cout << format->name << std::endl;
    }
  }
}

filename: enhance_fuzzer.cc
content: #include <cstdint>

#include <Magick++/Blob.h>
#include <Magick++/Image.h>

extern "C" int LLVMFuzzerTestOneInput(const uint8_t *Data, size_t Size) {
  const Magick::Blob blob(Data, Size);
  Magick::Image image;
  try {
    image.read(blob);
    image.enhance();
  } catch (Magick::Exception &e) {
    return 0;
  }
  return 0;
}

filename: huffman_decode_fuzzer.cc
content: #include <cstdint>

#include <Magick++/Blob.h>
#include <Magick++/Image.h>

extern "C" int LLVMFuzzerTestOneInput(const uint8_t *Data, size_t Size) {
  const Magick::Blob blob(Data, Size);
  Magick::Image image;
  try {
    image.read(blob);
  } catch (Magick::Exception &e) {
    return 0;
  }
  Magick::ExceptionInfo ex;
  auto res = HuffmanDecodeImage(image.image(), &ex);
  return 0;
}

filename: rotate_fuzzer.cc
content: #include <cstdint>

#include <Magick++/Blob.h>
#include <Magick++/Image.h>

extern "C" int LLVMFuzzerTestOneInput(const uint8_t *Data, size_t Size) {
  if (Size < sizeof(double)) {
    return 0;
  }
  double Degrees = *reinterpret_cast<const double *>(Data);
  if (!isfinite(Degrees)) {
    return 0;
  }
  const Magick::Blob blob(Data + sizeof(Degrees), Size - sizeof(Degrees));
  Magick::Image image;
  try {
    image.read(blob);
  } catch (Magick::Exception &e) {
    return 0;
  }
  image.rotate(Degrees);
  return 0;
}