Project: imagemagick (imagemagick/imagemagick), language: c++
Vulnerability instance: imagemagick.cve-2017-11639
Sanitizer: address

================= Bug Report (1/1) ==================
## Source: GitHub Issue
## URL: https://github.com/ImageMagick/ImageMagick/issues/588
## Description:
Issue: ImageMagick/ImageMagick#588
Title: Heap-Overflow in GetPixelLuma() MagickCore/pixel-accessor.h
State: closed
Created by: lcatro
Created at: 2017-07-19 02:30:29+00:00
Labels: bug

Issue Body:

Crash Link : https://raw.githubusercontent.com/lcatro/My_PoC/master/ImageMagick/heap-overflow_output_cip_READ_GetPixelLuma

Trigger Command : ./magick convert heap-overflow_output_cip_READ_GetPixelLuma output.cip

Crash Detail : 
```
fuzzing@ubuntu:~/fuzzing/ImageMagick/utilities$ ./magick convert fuzzdata_2017_7_18_10_57_5/crash/heap-buffer-overflow-READ-0x7f60f211f858_output_cip_1500414418.62 output.cip
=================================================================
==65448==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x625000008c00 at pc 0x7fc9ed7a1858 bp 0x7ffd0c857940 sp 0x7ffd0c857930
READ of size 4 at 0x625000008c00 thread T0
    #0 0x7fc9ed7a1857 in GetPixelLuma MagickCore/pixel-accessor.h:286
    #1 0x7fc9ed7a25bb in WriteCIPImage coders/cip.c:249
    #2 0x7fc9ed3fc22b in WriteImage MagickCore/constitute.c:1114
    #3 0x7fc9ed3fcea7 in WriteImages MagickCore/constitute.c:1333
    #4 0x7fc9ecc4c3bb in ConvertImageCommand MagickWand/convert.c:3280
    #5 0x7fc9ecd44d68 in MagickCommandGenesis MagickWand/mogrify.c:183
    #6 0x4017f1 in MagickMain utilities/magick.c:149
    #7 0x4019d2 in main utilities/magick.c:180
    #8 0x7fc9ec4b982f in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x2082f)
    #9 0x401308 in _start (/home/fuzzing/fuzzing/ImageMagick/utilities/.libs/lt-magick+0x401308)

0x625000008c00 is located 0 bytes to the right of 3072-byte region [0x625000008000,0x625000008c00)
allocated by thread T0 here:
    #0 0x7fc9ee0aa076 in __interceptor_posix_memalign (/usr/lib/x86_64-linux-gnu/libasan.so.2+0x99076)
    #1 0x7fc9ed5a6d17 in AcquireAlignedMemory MagickCore/memory.c:262
    #2 0x7fc9ed397796 in OpenPixelCache MagickCore/cache.c:3558
    #3 0x7fc9ed38ffd1 in GetImagePixelCache MagickCore/cache.c:1667
    #4 0x7fc9ed39f255 in SyncImagePixelCache MagickCore/cache.c:5257
    #5 0x7fc9ed572a42 in SetImageExtent MagickCore/image.c:2554
    #6 0x7fc9ed9473a2 in ReadTXTImage coders/txt.c:451
    #7 0x7fc9ed3f90cd in ReadImage MagickCore/constitute.c:497
    #8 0x7fc9ed3fb2cc in ReadImages MagickCore/constitute.c:866
    #9 0x7fc9ecbb607d in ConvertImageCommand MagickWand/convert.c:641
    #10 0x7fc9ecd44d68 in MagickCommandGenesis MagickWand/mogrify.c:183
    #11 0x4017f1 in MagickMain utilities/magick.c:149
    #12 0x4019d2 in main utilities/magick.c:180
    #13 0x7fc9ec4b982f in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x2082f)

SUMMARY: AddressSanitizer: heap-buffer-overflow MagickCore/pixel-accessor.h:286 GetPixelLuma
Shadow bytes around the buggy address:
  0x0c4a7fff9130: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x0c4a7fff9140: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x0c4a7fff9150: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x0c4a7fff9160: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x0c4a7fff9170: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
=>0x0c4a7fff9180:[fa]fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c4a7fff9190: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c4a7fff91a0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c4a7fff91b0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c4a7fff91c0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c4a7fff91d0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
Shadow byte legend (one shadow byte represents 8 application bytes):
  Addressable:           00
  Partially addressable: 01 02 03 04 05 06 07 
  Heap left redzone:       fa
  Heap right redzone:      fb
  Freed heap region:       fd
  Stack left redzone:      f1
  Stack mid redzone:       f2
  Stack right redzone:     f3
  Stack partial redzone:   f4
  Stack after return:      f5
  Stack use after scope:   f8
  Global redzone:          f9
  Global init order:       f6
  Poisoned by user:        f7
  Container overflow:      fc
  Array cookie:            ac
  Intra object redzone:    bb
  ASan internal:           fe
==65448==ABORTING
```



Comments:
Comment by mikayla-grace on 2017-07-19 11:26:17+00:00:
Thanks for the problem report.  We can reproduce it and will have a patch to fix it in GIT master branch @ https://github.com/ImageMagick/ImageMagick later today.  The patch will be available in the beta releases of ImageMagick @ http://www.imagemagick.org/download/beta/ by sometime tomorrow. 


---

Comment by lcatro on 2017-07-26 04:04:11+00:00:
Hello @mikayla-grace @dlemstra ,this heap-overflow fix incomplete , plaese reproduct my sample file : https://raw.githubusercontent.com/lcatro/Fuzzing-ImageMagick/master/ImageMagick_crash/heap-buffer-overflow-READ-0x7f78da4c320e_output_cip_1501014029.08

```
fuzzing@ubuntu:~/fuzzing/ImageMagick/utilities$ ./magick convert heap-buffer-overflow-READ-0x7f78da4c320e_output_cip_1501014029.08 output.cip
=================================================================
==806==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x60a000044780 at pc 0x7f7ff92c520e bp 0x7ffd7cb1dd60 sp 0x7ffd7cb1dd50
READ of size 4 at 0x60a000044780 thread T0
    #0 0x7f7ff92c520d in GetPixelLuma MagickCore/pixel-accessor.h:284
    #1 0x7f7ff92c520d in WriteCIPImage coders/cip.c:249
    #2 0x7f7ff8f92275 in WriteImage MagickCore/constitute.c:1114
    #3 0x7f7ff8f92f10 in WriteImages MagickCore/constitute.c:1333
    #4 0x7f7ff88de956 in ConvertImageCommand MagickWand/convert.c:3280
    #5 0x7f7ff89a3a6e in MagickCommandGenesis MagickWand/mogrify.c:183
    #6 0x4016d9 in MagickMain utilities/magick.c:149
    #7 0x7f7ff824a82f in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x2082f)
    #8 0x401348 in _start (/home/fuzzing/fuzzing/ImageMagick/utilities/.libs/lt-magick+0x401348)

0x60a000044780 is located 0 bytes to the right of 64-byte region [0x60a000044740,0x60a000044780)
allocated by thread T0 here:
    #0 0x7f7ff9b2f076 in __interceptor_posix_memalign (/usr/lib/x86_64-linux-gnu/libasan.so.2+0x99076)
    #1 0x7f7ff90d29d4 in AcquireAlignedMemory MagickCore/memory.c:262

SUMMARY: AddressSanitizer: heap-buffer-overflow MagickCore/pixel-accessor.h:284 GetPixelLuma
Shadow bytes around the buggy address:
  0x0c14800008a0: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
  0x0c14800008b0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c14800008c0: fd fd fd fd fd fd fd fd fa fa fa fa fa fa fa fa
  0x0c14800008d0: fd fd fd fd fd fd fd fd fa fa fa fa fa fa fa fa
  0x0c14800008e0: fa fa fa fa fa fa fa fa 00 00 00 00 00 00 00 00
=>0x0c14800008f0:[fa]fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
  0x0c1480000900: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c1480000910: fd fd fd fd fd fd fd fd fa fa fa fa fa fa fa fa
  0x0c1480000920: fd fd fd fd fd fd fd fd fa fa fa fa fa fa fa fa
  0x0c1480000930: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
  0x0c1480000940: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
Shadow byte legend (one shadow byte represents 8 application bytes):
  Addressable:           00
  Partially addressable: 01 02 03 04 05 06 07 
  Heap left redzone:       fa
  Heap right redzone:      fb
  Freed heap region:       fd
  Stack left redzone:      f1
  Stack mid redzone:       f2
  Stack right redzone:     f3
  Stack partial redzone:   f4
  Stack after return:      f5
  Stack use after scope:   f8
  Global redzone:          f9
  Global init order:       f6
  Poisoned by user:        f7
  Container overflow:      fc
  Array cookie:            ac
  Intra object redzone:    bb
  ASan internal:           fe
==806==ABORTING
```

---

Comment by mikayla-grace on 2017-07-26 10:45:04+00:00:
Thanks for the problem report.  We can reproduce it and will have a patch to fix it in GIT master branch @ https://github.com/ImageMagick/ImageMagick later today.  The patch will be available in the beta releases of ImageMagick @ http://www.imagemagick.org/download/beta/ by sometime tomorrow. 


---

Comment by bastien-roucaries on 2017-07-29 12:02:22+00:00:
This CVE-2017-11639

---

Comment by bastien-roucaries on 2017-07-29 15:12:55+00:00:
 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=870065


Build script:
#!/bin/bash -eu
# Minimized build script with only core build commands
set -eu
./configure --prefix="$WORK" --disable-shared --disable-docs
make "-j$(nproc)"
make install -j$(nproc)

Dockerfile:
FROM hwiwonlee/secb.base:latest
RUN apt-get update && apt-get install -y make autoconf automake libtool
RUN git clone https://github.com/imagemagick/imagemagick imagemagick
RUN git -C imagemagick checkout 9871b4ad7400606bbecf7f979b198080f4b107c3
WORKDIR $SRC/imagemagick
COPY build.sh $SRC/

Additional files:
filename: crop_fuzzer.cc
content: #include <cstdint>

#include <Magick++/Blob.h>
#include <Magick++/Image.h>

extern "C" int LLVMFuzzerTestOneInput(const uint8_t *Data, size_t Size) {
  uint16_t Width;
  uint16_t Height;
  if (Size < (sizeof(Width) + sizeof(Height))) {
    return 0;
  }
  Width = *reinterpret_cast<const uint16_t *>(Data);
  Height = *reinterpret_cast<const uint16_t *>(Data + sizeof(Width));
  const Magick::Blob blob(Data + sizeof(Width) + sizeof(Height),
                          Size - (sizeof(Width) + sizeof(Height)));
  Magick::Image image;
  try {
    image.read(blob);
  } catch (Magick::Exception &e) {
    return 0;
  }
  image.crop(Magick::Geometry(Width, Height));
  return 0;
}

filename: encoder_fuzzer.cc
content: #include <cstdint>

#include <Magick++/Blob.h>
#include <Magick++/Image.h>

#define FUZZ_ENCODER_STRING_LITERAL(name) #name
#define FUZZ_ENCODER FUZZ_ENCODER_STRING_LITERAL(FUZZ_IMAGEMAGICK_ENCODER)

extern "C" int LLVMFuzzerTestOneInput(const uint8_t *Data, size_t Size) {
  const Magick::Blob blob(Data, Size);
  Magick::Image image;
  try {
    image.read(blob);
  } catch (Magick::Exception &e) {
    return 0;
  }

  Magick::Blob outBlob;
  try {
    image.write(&outBlob, FUZZ_ENCODER);
  } catch (Magick::Exception &e) {
  }
  return 0;
}

filename: encoder_list.cc
content: #include <iostream>

#include <Magick++/Blob.h>
#include <Magick++/Image.h>

extern "C" int main() {
  size_t nFormats;
  Magick::ExceptionInfo ex;
  const Magick::MagickInfo **formats = GetMagickInfoList("*", &nFormats, &ex);

  for (size_t i = 0; i < nFormats; i++) {
    const Magick::MagickInfo *format = formats[i];
    if (format->encoder && format->name) {
      std::cout << format->name << std::endl;
    }
  }
}

filename: enhance_fuzzer.cc
content: #include <cstdint>

#include <Magick++/Blob.h>
#include <Magick++/Image.h>

extern "C" int LLVMFuzzerTestOneInput(const uint8_t *Data, size_t Size) {
  const Magick::Blob blob(Data, Size);
  Magick::Image image;
  try {
    image.read(blob);
    image.enhance();
  } catch (Magick::Exception &e) {
    return 0;
  }
  return 0;
}

filename: huffman_decode_fuzzer.cc
content: #include <cstdint>

#include <Magick++/Blob.h>
#include <Magick++/Image.h>

extern "C" int LLVMFuzzerTestOneInput(const uint8_t *Data, size_t Size) {
  const Magick::Blob blob(Data, Size);
  Magick::Image image;
  try {
    image.read(blob);
  } catch (Magick::Exception &e) {
    return 0;
  }
  Magick::ExceptionInfo ex;
  auto res = HuffmanDecodeImage(image.image(), &ex);
  return 0;
}

filename: rotate_fuzzer.cc
content: #include <cstdint>

#include <Magick++/Blob.h>
#include <Magick++/Image.h>

extern "C" int LLVMFuzzerTestOneInput(const uint8_t *Data, size_t Size) {
  if (Size < sizeof(double)) {
    return 0;
  }
  double Degrees = *reinterpret_cast<const double *>(Data);
  if (!isfinite(Degrees)) {
    return 0;
  }
  const Magick::Blob blob(Data + sizeof(Degrees), Size - sizeof(Degrees));
  Magick::Image image;
  try {
    image.read(blob);
  } catch (Magick::Exception &e) {
    return 0;
  }
  image.rotate(Degrees);
  return 0;
}