Project: gpac (gpac/gpac), language: c++
Vulnerability instance: gpac.cve-2020-22679
Sanitizer: address

================= Bug Report (1/1) ==================
## Source: GitHub Issue
## URL: https://github.com/gpac/gpac/issues/1345
## Description:
Issue: gpac/gpac#1345
Title: There are memory leaks in the sgpd_parse_entry function of box_code_base.c:9656
State: closed
Created by: gutiniao
Created at: 2019-11-13 05:25:14+00:00

Issue Body:
Thanks for reporting your issue. Please make sure these boxes are checked before submitting your issue - thank you!

[ √] I looked for a similar issue and couldn't find any.
[ √] I tried with the latest version of GPAC. Installers available at http://gpac.io/downloads/gpac-nightly-builds/
[ √] I give enough information for contributors to reproduce my issue (meaningful title, github labels, platform and compiler, command-line ...). I can share files anonymously with this dropbox: https://www.mediafire.com/filedrop/filedrop_hosted.php?drop=eec9e058a9486fe4e99c33021481d9e1826ca9dbc242a6cfaab0fe95da5e5d95
Detailed guidelines: http://gpac.io/2013/07/16/how-to-file-a-bug-properly/

A crafted input will lead to crash in box_code_base.c at gpac 0.8.0.

Triggered by
./MP4Box -diso POC -out /dev/null

Poc
[007-memleak-sgpd_parse_entry](https://github.com/gutiniao/afltest/blob/master/007-memleak-sgpd_parse_entry)

The ASAN information is as follows:

```
./MP4Box -diso 007-memleak-sgpd_parse_entry -out /dev/null 
[iso file] Unknown box type gods in parent moov
[iso file] Box "avcC" (start 939) has 34 extra bytes
[iso file] Unknown box type 0000 in parent sinf
[iso file] Invalid descriptor tag 0xc1 in esds
[iso file] Read Box "esds" (start 1491) failed (Invalid IsoMedia File) - skipping
[iso file] Invalid descriptor tag 0xc1 in esds
[iso file] Read Box "esds" (start 0) failed (Invalid IsoMedia File) - skipping
[isom] not enough bytes in box sgpd: 20 left, reading 63 (file isomedia/box_code_base.c, line 9926)
[iso file] Read Box "sgpd" (start 1678) failed (Invalid IsoMedia File) - skipping
[iso file] Read Box "stbl" (start 1431) failed (Invalid IsoMedia File) - skipping
[iso file] Read Box "minf" (start 1371) failed (Invalid IsoMedia File) - skipping
[iso file] Read Box "mdia" (start 1298) failed (Invalid IsoMedia File) - skipping
[iso file] Read Box "trak" (start 1198) failed (Invalid IsoMedia File) - skipping
[iso file] Read Box "moov" (start 351) failed (Invalid IsoMedia File) - skipping
Error opening file 007-memleak-sgpd_parse_entry: Invalid IsoMedia File

=================================================================
==6751==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 37 byte(s) in 1 object(s) allocated from:
    #0 0x7f25e0370b50 in __interceptor_malloc (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xdeb50)
    #1 0x55e8ff099553 in sgpd_parse_entry isomedia/box_code_base.c:9656
    #2 0x55e8ff099553 in sgpd_Read isomedia/box_code_base.c:9922

SUMMARY: AddressSanitizer: 37 byte(s) leaked in 1 allocation(s)
```



Comments:
Comment by aureliendavid on 2020-01-09 18:00:00+00:00:
thanks for the report

this should be fixed by the commit above 

reopen if needed

Commit References:
eec9e058a9486fe4e99c33021481d9e1826ca9db

Build script:
#!/bin/bash -eu
# Minimized build script with only core build commands
set -eu
./configure --static-build --extra-cflags="${CFLAGS}" --extra-ldflags="${CFLAGS}"
make -j$(nproc)

Dockerfile:
FROM hwiwonlee/secb.base:latest
RUN apt-get update && apt-get install -y build-essential pkg-config libz-dev
RUN git clone https://github.com/gpac/gpac gpac
RUN git -C gpac checkout 6b4ab401297be43b57f9eddd675971a8a5feab44
WORKDIR $SRC/gpac
COPY build.sh $SRC/

Additional files:
filename: fuzz_parse.c
content: /* Copyright 2021 Google LLC
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
      http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
#include <stdio.h>
#include <unistd.h>

#include <gpac/internal/isomedia_dev.h>
#include <gpac/constants.h>

int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size) {
    char filename[256];
    sprintf(filename, "/tmp/libfuzzer.%d", getpid());

    FILE *fp = fopen(filename, "wb");
    if (!fp) {
        return 0;
    }
    fwrite(data, size, 1, fp);
    fclose(fp);

    GF_ISOFile *movie = NULL;
    movie = gf_isom_open_file(filename, GF_ISOM_OPEN_READ_DUMP, NULL);
    if (movie != NULL) {
        gf_isom_close(movie);
    }
    unlink(filename);
    return 0;
}