Project: imagemagick (imagemagick/imagemagick), language: c++
Vulnerability instance: imagemagick.cve-2019-16708
Sanitizer: address

================= Bug Report (1/1) ==================
## Source: GitHub Issue
## URL: https://github.com/ImageMagick/ImageMagick/issues/1531
## Description:
Issue: ImageMagick/ImageMagick#1531
Title: memory leaks in XCreateImage
State: closed
Created by: butterflyhack
Created at: 2019-03-27 08:51:13+00:00
Labels: bug

Issue Body:
### Prerequisites

- [x] I have written a descriptive issue title
- [x] I have verified that I am using the latest version of ImageMagick
- [x] I have searched [open](https://github.com/ImageMagick/ImageMagick/issues) and [closed](https://github.com/ImageMagick/ImageMagick/issues?q=is%3Aissue+is%3Aclosed) issues to ensure it has not already been reported

### Description
```
=================================================================
==15742==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 136 byte(s) in 1 object(s) allocated from:
    #0 0x7fadbfd0c79a in __interceptor_calloc (/usr/lib/x86_64-linux-gnu/libasan.so.2+0x9879a)
    #1 0x7fadbcb0e220 in XCreateImage (/usr/lib/x86_64-linux-gnu/libX11.so.6+0x27220)

Indirect leak of 48000 byte(s) in 1 object(s) allocated from:
    #0 0x7fadbfd0c602 in malloc (/usr/lib/x86_64-linux-gnu/libasan.so.2+0x98602)
    #1 0x508cf3 in XMakeImage MagickCore/xwindow.c:5733
    #2 0x82940c in XConfigureImage MagickCore/display.c:4449
    #3 0x85e6bd in XDisplayImage MagickCore/display.c:15069
    #4 0x81b445 in DisplayImages MagickCore/display.c:1705
    #5 0x77475f in WriteXImage coders/x.c:202
    #6 0x808fb6 in WriteImage MagickCore/constitute.c:1226
    #7 0x8097ea in WriteImages MagickCore/constitute.c:1376
    #8 0xbb0499 in ConvertImageCommand MagickWand/convert.c:3305
    #9 0xc9c5ea in MagickCommandGenesis MagickWand/mogrify.c:184
    #10 0x40e941 in MagickMain utilities/magick.c:149
    #11 0x40eb22 in main utilities/magick.c:180
    #12 0x7fadbbffc82f in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x2082f)

SUMMARY: AddressSanitizer: 48136 byte(s) leaked in 2 allocation(s).
```

### Steps to Reproduce
```
$ touch output.x
$/usr/local/bin/magick convert Memory-Leak-2 output.x
```
then close the windows of ImageMagick.

### System Configuration
<!-- Tell us about the environment where you are experiencing the bug -->

- ImageMagick version: 7.0.8-35
- Environment (Operating system, version and so on): Linux ubuntu 4.15.0-42-generic #45~16.04.1-Ubuntu SMP Mon Nov 19 13:02:27 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
- Additional information:

<!-- Thanks for reporting the issue to ImageMagick! -->
[memory_leaks_2.zip](https://github.com/ImageMagick/ImageMagick/files/3012281/memory_leaks_2.zip)

credit：
 ADlab of venustech



Comments:
Comment by urban-warrior on 2019-03-27 16:29:39+00:00:
Thanks for the problem report.  We can reproduce it and will have a patch to fix it in GIT master branch @ https://github.com/ImageMagick/ImageMagick later today.  The patch will be available in the beta releases of ImageMagick @ http://www.imagemagick.org/download/beta/ by sometime tomorrow. 


---

Comment by abergmann on 2019-09-24 07:38:43+00:00:
[CVE-2019-16709](https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2019-16709) was assigned to this issue.

This CVE addresses the ```coders/dps.c``` issue.

---

Comment by abergmann on 2019-09-24 07:46:10+00:00:
[CVE-2019-16708](https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2019-16708) was assigned to this issue.

This CVE addresses the ```magick/xwindow.c``` issue.

Attachments:
https://github.com/ImageMagick/ImageMagick/files/3012281/memory_leaks_2.zip

Build script:
#!/bin/bash
# Default build script template for C/C++ projects
set -eu

# Define configuration options
CONFIG_OPTS="--disable-shared"
CMAKE_OPTS="-DCMAKE_BUILD_TYPE=Debug"
MAKE_OPTS="-j$(nproc)"
BUILD_DIR="build"

# 1. Run build preparation scripts if they exist
for prep_script in buildconf autogen.sh bootstrap; do
  if [ -x "$prep_script" ]; then
    echo "Running $prep_script..."
    ./$prep_script
    break
  elif [ -f "$prep_script" ]; then
    echo "Found $prep_script but it's not executable, setting permissions..."
    chmod +x $prep_script
    ./$prep_script
    break
  fi
done

# 2. Handle different build systems
if [ -f "configure" ]; then
  echo "Found configure script, running with options: $CONFIG_OPTS"
  ./configure $CONFIG_OPTS

  echo "Building with make $MAKE_OPTS"
  make $MAKE_OPTS
elif [ -f "CMakeLists.txt" ]; then
  echo "Found CMakeLists.txt, using CMake build system"
  mkdir -p $BUILD_DIR
  cd $BUILD_DIR
  cmake $CMAKE_OPTS ..
  make $MAKE_OPTS
elif [ -f "Makefile" ] || [ -f "makefile" ]; then
  echo "Found Makefile, building with make $MAKE_OPTS"
  make $MAKE_OPTS
elif [ -f "meson.build" ]; then
  echo "Found meson.build, using Meson build system"
  mkdir -p $BUILD_DIR
  meson setup $BUILD_DIR .
  cd $BUILD_DIR
  ninja
elif [ -f "GNUmakefile" ]; then
  echo "Found GNUmakefile, building with make $MAKE_OPTS"
  make $MAKE_OPTS
elif [ -d ".git" ] && [ -f "Makefile.am" ]; then
  echo "Found Makefile.am, running autoreconf"
  autoreconf -i
  ./configure $CONFIG_OPTS
  make $MAKE_OPTS
else
  echo "WARNING: No recognized build system found!"
  echo "Trying generic approach:"
  
  # Try to detect common source patterns and compile them
  if ls *.c >/dev/null 2>&1 || ls *.cpp >/dev/null 2>&1 || ls *.cc >/dev/null 2>&1; then
    echo "Found C/C++ source files, attempting direct compilation"
    if ls *.cpp >/dev/null 2>&1 || ls *.cc >/dev/null 2>&1; then
      CXX=${CXX:-g++}
      echo "Compiling C++ sources with $CXX"
      $CXX -g -O1 -fsanitize=address -fno-omit-frame-pointer -o main *.cpp *.cc 2>/dev/null || true
    elif ls *.c >/dev/null 2>&1; then
      CC=${CC:-gcc}
      echo "Compiling C sources with $CC"
      $CC -g -O1 -fsanitize=address -fno-omit-frame-pointer -o main *.c 2>/dev/null || true
    fi
  fi
fi

Dockerfile:
FROM hwiwonlee/secb.base:latest
RUN apt-get update && apt-get install -y make autoconf automake libtool pkg-config cmake nasm autopoint
RUN git clone https://github.com/imagemagick/imagemagick imagemagick
RUN git -C imagemagick checkout 224159dfcc0ae3da9a247921e3c8bfb44d39965e
WORKDIR $SRC/imagemagick
COPY build.sh $SRC/

Additional files: