Project: imagemagick (imagemagick/imagemagick), language: c++
Vulnerability instance: imagemagick.cve-2019-13308
Sanitizer: address

================= Bug Report (1/1) ==================
## Source: GitHub Issue
## URL: https://github.com/ImageMagick/ImageMagick/issues/1595
## Description:
Issue: ImageMagick/ImageMagick#1595
Title: heap-buffer-overflow in MagickCore/fourier.c:299:18 in ComplexImage
State: closed
Created by: SuhwanSong
Created at: 2019-06-17 02:21:01+00:00
Labels: bug

Issue Body:
### Prerequisites

- [x] I have written a descriptive issue title
- [x] I have verified that I am using the latest version of ImageMagick
- [x] I have searched [open](https://github.com/ImageMagick/ImageMagick/issues) and [closed](https://github.com/ImageMagick/ImageMagick/issues?q=is%3Aissue+is%3Aclosed) issues to ensure it has not already been reported

### Description
<!-- A description of the bug or feature -->
There's a heap-buffer-overflow in MagickCore/fourier.c:299:18 in ComplexImage, and I compiled the lasted version with --disable-openmp option.

### Steps to Reproduce
<!-- List of steps, sample code, failing test or link to a project that reproduces the behavior.
     Make sure you place a stack trace inside a code (```) block to avoid linking unrelated issues -->
run cmd:
`magick -seed 0 -mattecolor rgb"("225,230,14")" -debug Configure "(" magick:wizard +repage ")" "(" magick:netscape +repage ")" -fuzz 82 -caption "j$Y%Be" -blue-primary 727,475  -crop 405%-43-16 -crop 832x886>+11-13 -complex magnitude-phase   tmp`

and also this command
`magick -seed 0 "(" magick:netscape +repage ")" "(" magick:wizard -resample 24x44 -resample 47x83  ")" "(" magick:netscape -charcoal 4 -random-threshold 42x71 -shade 81x21  ")" -complex magnitude-phase   tmp112
`

Here's ASAN result.
```
==9231==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x7fd97efce800 at pc 0x7fd98dbdd221 bp 0x7ffff99e9790 sp 0x7ffff99e9788
WRITE of size 4 at 0x7fd97efce800 thread T0
    #0 0x7fd98dbdd220 in ComplexImages MagickCore/fourier.c:299:18
    #1 0x7fd98d4038c1 in CLIListOperatorImages MagickWand/operation.c:3890:22
    #2 0x7fd98d40f34e in CLIOption MagickWand/operation.c:5276:14
    #3 0x7fd98d250a99 in ProcessCommandOptions MagickWand/magick-cli.c:477:7
    #4 0x7fd98d251d0a in MagickImageCommand MagickWand/magick-cli.c:796:5
    #5 0x7fd98d29bba1 in MagickCommandGenesis MagickWand/mogrify.c:185:14
    #6 0x526f95 in MagickMain utilities/magick.c:149:10
    #7 0x5268e1 in main utilities/magick.c:180:10
    #8 0x7fd987d12b96 in __libc_start_main /build/glibc-OTsEL5/glibc-2.27/csu/../csu/libc-start.c:310
    #9 0x41b069 in _start (install/bin/magick+0x41b069)

0x7fd97efce800 is located 0 bytes to the right of 3686400-byte region [0x7fd97ec4a800,0x7fd97efce800)
allocated by thread T0 here:
    #0 0x4e6200 in __interceptor_posix_memalign (install/bin/magick+0x4e6200)
    #1 0x7fd98dc8a666 in AcquireAlignedMemory MagickCore/memory.c:265:7
    #2 0x7fd98d9d36ac in OpenPixelCache MagickCore/cache.c:3728:46
    #3 0x7fd98d9d9991 in GetImagePixelCache MagickCore/cache.c:1754:18
    #4 0x7fd98d9dfc59 in SyncImagePixelCache MagickCore/cache.c:5494:28
    #5 0x7fd98dc3dfc1 in SetImageStorageClass MagickCore/image.c:2627:10
    #6 0x7fd98dbdb4f7 in ComplexImages MagickCore/fourier.c:185:7
    #7 0x7fd98d4038c1 in CLIListOperatorImages MagickWand/operation.c:3890:22
    #8 0x7fd98d40f34e in CLIOption MagickWand/operation.c:5276:14
    #9 0x7fd98d250a99 in ProcessCommandOptions MagickWand/magick-cli.c:477:7
    #10 0x7fd98d251d0a in MagickImageCommand MagickWand/magick-cli.c:796:5
    #11 0x7fd98d29bba1 in MagickCommandGenesis MagickWand/mogrify.c:185:14
    #12 0x526f95 in MagickMain utilities/magick.c:149:10
    #13 0x5268e1 in main utilities/magick.c:180:10
    #14 0x7fd987d12b96 in __libc_start_main /build/glibc-OTsEL5/glibc-2.27/csu/../csu/libc-start.c:310

SUMMARY: AddressSanitizer: heap-buffer-overflow MagickCore/fourier.c:299:18 in ComplexImages

```

### System Configuration
<!-- Tell us about the environment where you are experiencing the bug -->

- ImageMagick version:
Version: ImageMagick 7.0.8-50 Q16 x86_64 2019-06-17 https://imagemagick.org
- Environment (Operating system, version and so on):
Description:	Ubuntu 18.04.1 LTS
Release:	18.04
Codename: bionic


- Additional information:
CC=clang-7 CXX=clang++-7 ./configure --disable-openmp
<!-- Thanks for reporting the issue to ImageMagick! -->



Comments:
Comment by urban-warrior on 2019-06-17 12:50:01+00:00:
Thanks for the problem report.  We can reproduce it and will have a patch to fix it in GIT master branch @ https://github.com/ImageMagick/ImageMagick later today.  The patch will be available in the beta releases of ImageMagick @ http://www.imagemagick.org/download/beta/ by sometime tomorrow. 


---

Comment by nohmask on 2019-07-08 01:53:01+00:00:
This was assigned CVE-2019-13308.

---

Comment by hlef on 2019-08-13 11:59:01+00:00:
I wonder... in https://github.com/ImageMagick/ImageMagick6/commit/19651f3db63fa1511ed83a348c4c82fa553f8d01 why is this change

```
-          if (images->matte != MagickFalse)
+          if (Cr_image->matte != MagickFalse)
```

only applied to `SubtractComplexOperator` and not to other operators such as `RealImaginaryComplexOperator` or `MultiplyComplexOperator`? Is this intentional?

Commit References:
19651f3db63fa1511ed83a348c4c82fa553f8d01

Build script:
#!/bin/bash
# Default build script template for C/C++ projects
set -eu

# Define configuration options
CONFIG_OPTS="--disable-shared"
CMAKE_OPTS="-DCMAKE_BUILD_TYPE=Debug"
MAKE_OPTS="-j$(nproc)"
BUILD_DIR="build"

# 1. Run build preparation scripts if they exist
for prep_script in buildconf autogen.sh bootstrap; do
  if [ -x "$prep_script" ]; then
    echo "Running $prep_script..."
    ./$prep_script
    break
  elif [ -f "$prep_script" ]; then
    echo "Found $prep_script but it's not executable, setting permissions..."
    chmod +x $prep_script
    ./$prep_script
    break
  fi
done

# 2. Handle different build systems
if [ -f "configure" ]; then
  echo "Found configure script, running with options: $CONFIG_OPTS"
  ./configure $CONFIG_OPTS

  echo "Building with make $MAKE_OPTS"
  make $MAKE_OPTS
elif [ -f "CMakeLists.txt" ]; then
  echo "Found CMakeLists.txt, using CMake build system"
  mkdir -p $BUILD_DIR
  cd $BUILD_DIR
  cmake $CMAKE_OPTS ..
  make $MAKE_OPTS
elif [ -f "Makefile" ] || [ -f "makefile" ]; then
  echo "Found Makefile, building with make $MAKE_OPTS"
  make $MAKE_OPTS
elif [ -f "meson.build" ]; then
  echo "Found meson.build, using Meson build system"
  mkdir -p $BUILD_DIR
  meson setup $BUILD_DIR .
  cd $BUILD_DIR
  ninja
elif [ -f "GNUmakefile" ]; then
  echo "Found GNUmakefile, building with make $MAKE_OPTS"
  make $MAKE_OPTS
elif [ -d ".git" ] && [ -f "Makefile.am" ]; then
  echo "Found Makefile.am, running autoreconf"
  autoreconf -i
  ./configure $CONFIG_OPTS
  make $MAKE_OPTS
else
  echo "WARNING: No recognized build system found!"
  echo "Trying generic approach:"
  
  # Try to detect common source patterns and compile them
  if ls *.c >/dev/null 2>&1 || ls *.cpp >/dev/null 2>&1 || ls *.cc >/dev/null 2>&1; then
    echo "Found C/C++ source files, attempting direct compilation"
    if ls *.cpp >/dev/null 2>&1 || ls *.cc >/dev/null 2>&1; then
      CXX=${CXX:-g++}
      echo "Compiling C++ sources with $CXX"
      $CXX -g -O1 -fsanitize=address -fno-omit-frame-pointer -o main *.cpp *.cc 2>/dev/null || true
    elif ls *.c >/dev/null 2>&1; then
      CC=${CC:-gcc}
      echo "Compiling C sources with $CC"
      $CC -g -O1 -fsanitize=address -fno-omit-frame-pointer -o main *.c 2>/dev/null || true
    fi
  fi
fi

Dockerfile:
FROM hwiwonlee/secb.base:latest
RUN apt-get update && apt-get install -y make autoconf automake libtool pkg-config cmake nasm autopoint
RUN git clone https://github.com/imagemagick/imagemagick imagemagick
RUN git -C imagemagick checkout b88e300799058d7a5f09efef89519591d9f3ada2
WORKDIR $SRC/imagemagick
COPY build.sh $SRC/

Additional files: