CVE-2021-41272: Incorrect Conversion between Numeric Types (CWE-681)
value: Besu is an Ethereum client written in Java. Starting in version 21.10.0, changes in the implementation of the SHL, SHR, and SAR operations resulted in the introduction of a signed type coercion error in values that represent negative values for 32 bit signed integers. Smart contracts that ask for shifts between approximately 2 billion and 4 billion bits (nonsensical but valid values for the operation) will fail to execute and hence fail to validate. In networks where vulnerable versions are mining with other clients or non-vulnerable versions this will result in a fork and the relevant transactions will not be included in the fork. In networks where vulnerable versions are not mining (such as Rinkeby) no fork will result and the validator nodes will stop accepting blocks. In networks where only vulnerable versions are mining the relevant transaction will not be included in any blocks. When the network adds a non-vulnerable version the network will act as in the first case. Besu 21.10.2 contains a patch for this issue. Besu 21.7.4 is not vulnerable and clients can roll back to that version. There is a workaround available: Once a transaction with the relevant shift operations is included in the canonical chain, the only remediation is to make sure all nodes are on non-vulnerable versions.
CWE description: When converting from one data type to another, such as long to integer, data can be omitted or translated in a way that produces unexpected values. If the resulting values are used in a sensitive context, then dangerous behaviors may occur.
CVSS v3 base score: 7.5
Published: 2021-12-13T21:15Z
Repository: https://github.com/hyperledger/besu
Language: Java
Files changed: evm/src/main/java/org/hyperledger/besu/evm/operation/SarOperation.java, evm/src/main/java/org/hyperledger/besu/evm/operation/ShlOperation.java, evm/src/main/java/org/hyperledger/besu/evm/operation/ShrOperation.java
Commit date: 2021-11-11 07:56:53 -0700
Commit message: Shift Optimization (#3039)

Reduce shift calculations to shifts that may have an actual result.

Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
Diff: diff --git a/evm/src/main/java/org/hyperledger/besu/evm/operation/SarOperation.java b/evm/src/main/java/org/hyperledger/besu/evm/operation/SarOperation.java
index fe241b909..8b6d984f2 100644
--- a/evm/src/main/java/org/hyperledger/besu/evm/operation/SarOperation.java
+++ b/evm/src/main/java/org/hyperledger/besu/evm/operation/SarOperation.java
@@ -42,11 +42,11 @@ public class SarOperation extends AbstractFixedCostOperation {
     if (shiftAmount.size() > 4 && (shiftAmount = shiftAmount.trimLeadingZeros()).size() > 4) {
       frame.pushStackItem(negativeNumber ? ALL_BITS : UInt256.ZERO);
     } else {
       final int shiftAmountInt = shiftAmount.toInt();
 
-      if (shiftAmountInt >= 256) {
+      if (shiftAmountInt >= 256 || shiftAmountInt < 0) {
         frame.pushStackItem(negativeNumber ? ALL_BITS : UInt256.ZERO);
       } else {
         // first perform standard shift right.
         Bytes result = value.shiftRight(shiftAmountInt);
 
diff --git a/evm/src/main/java/org/hyperledger/besu/evm/operation/ShlOperation.java b/evm/src/main/java/org/hyperledger/besu/evm/operation/ShlOperation.java
index 309e39006..40429a5ec 100644
--- a/evm/src/main/java/org/hyperledger/besu/evm/operation/ShlOperation.java
+++ b/evm/src/main/java/org/hyperledger/besu/evm/operation/ShlOperation.java
@@ -38,11 +38,11 @@ public class ShlOperation extends AbstractFixedCostOperation {
       frame.pushStackItem(UInt256.ZERO);
     } else {
       final int shiftAmountInt = shiftAmount.toInt();
       final Bytes value = leftPad(frame.popStackItem());
 
-      if (shiftAmountInt >= 256) {
+      if (shiftAmountInt >= 256 || shiftAmountInt < 0) {
         frame.pushStackItem(UInt256.ZERO);
       } else {
         frame.pushStackItem(value.shiftLeft(shiftAmountInt));
       }
     }
diff --git a/evm/src/main/java/org/hyperledger/besu/evm/operation/ShrOperation.java b/evm/src/main/java/org/hyperledger/besu/evm/operation/ShrOperation.java
index a69094c2f..f9f3eb063 100644
--- a/evm/src/main/java/org/hyperledger/besu/evm/operation/ShrOperation.java
+++ b/evm/src/main/java/org/hyperledger/besu/evm/operation/ShrOperation.java
@@ -38,11 +38,11 @@ public class ShrOperation extends AbstractFixedCostOperation {
       frame.pushStackItem(UInt256.ZERO);
     } else {
       final int shiftAmountInt = shiftAmount.toInt();
       final Bytes value = leftPad(frame.popStackItem());
 
-      if (shiftAmountInt >= 256) {
+      if (shiftAmountInt >= 256 || shiftAmountInt < 0) {
         frame.pushStackItem(UInt256.ZERO);
       } else {
         frame.pushStackItem(value.shiftRight(shiftAmountInt));
       }
     }

Vulnerable code:       if (shiftAmountInt >= 256) {
      if (shiftAmountInt >= 256) {
      if (shiftAmountInt >= 256) {
Fixed code:       if (shiftAmountInt >= 256 || shiftAmountInt < 0) {
      if (shiftAmountInt >= 256 || shiftAmountInt < 0) {
      if (shiftAmountInt >= 256 || shiftAmountInt < 0) {