CVE-2022-22984: Improper Neutralization of Special Elements used in an OS Command ('OS Command Injection') (CWE-78)
value: The package snyk before 1.1064.0; the package snyk-mvn-plugin before 2.31.3; the package snyk-gradle-plugin before 3.24.5; the package @snyk/snyk-cocoapods-plugin before 2.5.3; the package snyk-sbt-plugin before 2.16.2; the package snyk-python-plugin before 1.24.2; the package snyk-docker-plugin before 5.6.5; the package @snyk/snyk-hex-plugin before 1.1.6 are vulnerable to Command Injection due to an incomplete fix for [CVE-2022-40764](https://security.snyk.io/vuln/SNYK-JS-SNYK-3037342). A successful exploit allows attackers to run arbitrary commands on the host system where the Snyk CLI is installed by passing in crafted command line flags. In order to exploit this vulnerability, a user would have to execute the snyk test command on untrusted files. In most cases, an attacker positioned to control the command line arguments to the Snyk CLI would already be positioned to execute arbitrary commands. However, this could be abused in specific scenarios, such as continuous integration pipelines, where developers can control the arguments passed to the Snyk CLI to leverage this component as part of a wider attack against an integration/build pipeline. This issue has been addressed in the latest Snyk Docker images available at https://hub.docker.com/r/snyk/snyk as of 2022-11-29. Images downloaded and built prior to that date should be updated. The issue has also been addressed in the Snyk TeamCity CI/CD plugin as of version v20221130.093605.
CWE description: The product constructs all or part of an OS command using externally-influenced input from an upstream component, but it does not neutralize or incorrectly neutralizes special elements that could modify the intended OS command when it is sent to a downstream component.
CVSS v3 base score: 6.3
Published: 2022-11-30T13:15Z
Repository: https://github.com/snyk/snyk-cocoapods-plugin
Language: TypeScript
Files changed: .snyk, lib/sub-process.ts, package.json, test/lib/sub-process.test.ts
Commit date: 2022-11-29 11:12:03 +0200
Commit message: fix: quote args

Diff: diff --git a/.snyk b/.snyk
index b4e98b4..1afddca 100644
--- a/.snyk
+++ b/.snyk
@@ -1,8 +1,14 @@
 # Snyk (https://snyk.io) policy file, patches or ignores known vulnerabilities.
-version: v1.13.5
-ignore: {}
+version: v1.25.0
+# ignores vulnerabilities until expiry date; change duration by modifying expiry date
+ignore:
+  'snyk:lic:npm:shescape:MPL-2.0':
+    - '*':
+        reason: None Given
+        expires: 2022-12-29T09:11:54.820Z
+        created: 2022-11-29T09:11:54.829Z
 # patches apply the minimum changes required to fix a vulnerability
 patch:
   SNYK-JS-LODASH-450202:
     - lodash:
         patched: '2019-07-05T10:44:37.780Z'
diff --git a/lib/sub-process.ts b/lib/sub-process.ts
index c3b7841..fdcefe1 100644
--- a/lib/sub-process.ts
+++ b/lib/sub-process.ts
@@ -1,6 +1,7 @@
 import * as childProcess from 'child_process';
+import { quoteAll } from 'shescape';
 
 export function execute(
   command: string,
   args: string[] = [],
   options?: { cwd?: string }
@@ -11,10 +12,12 @@ export function execute(
   } = { shell: true };
   if (options && options.cwd) {
     spawnOptions.cwd = options.cwd;
   }
 
+  args = quoteAll(args, spawnOptions);
+
   return new Promise((resolve, reject) => {
     let stdout = '';
     let stderr = '';
 
     const proc = childProcess.spawn(command, args, spawnOptions);
diff --git a/package.json b/package.json
index 78323db..ed3c0f8 100644
--- a/package.json
+++ b/package.json
@@ -32,10 +32,11 @@
   "homepage": "https://github.com/snyk/snyk-cocoapods-plugin#readme",
   "dependencies": {
     "@snyk/cli-interface": "^2.11.0",
     "@snyk/cocoapods-lockfile-parser": "3.6.2",
     "@snyk/dep-graph": "^1.23.1",
+    "shescape": "1.6.1",
     "source-map-support": "^0.5.7",
     "tslib": "^2.0.0"
   },
   "devDependencies": {
     "@types/graphlib": "^2.1.6",
diff --git a/test/lib/sub-process.test.ts b/test/lib/sub-process.test.ts
index cd79b19..486ad24 100644
--- a/test/lib/sub-process.test.ts
+++ b/test/lib/sub-process.test.ts
@@ -25,11 +25,11 @@ describe('execute()', () => {
     ).rejects.toThrow('error msg\n');
   });
 
   test('Considers option.cwd', async () => {
     await expect(
-      subProcess.execute('basename', ['$PWD'], { cwd: __dirname }),
+      subProcess.execute('basename $PWD', [], { cwd: __dirname }),
     ).resolves.toEqual('lib\n');
   });
 
   test('Passes arguments', async () => {
     await expect(subProcess.execute('seq', ['2'])).resolves.toEqual('1\n2\n');

Vulnerable code: version: v1.13.5
ignore: {}
      subProcess.execute('basename', ['$PWD'], { cwd: __dirname }),
Fixed code: version: v1.25.0
# ignores vulnerabilities until expiry date; change duration by modifying expiry date
ignore:
  'snyk:lic:npm:shescape:MPL-2.0':
    - '*':
        reason: None Given
        expires: 2022-12-29T09:11:54.820Z
        created: 2022-11-29T09:11:54.829Z
import { quoteAll } from 'shescape';
  args = quoteAll(args, spawnOptions);

    "shescape": "1.6.1",
      subProcess.execute('basename $PWD', [], { cwd: __dirname }),