CVE-2023-45805: Insufficient Information (NVD-CWE-noinfo)
value: pdm is a Python package and dependency manager supporting the latest PEP standards. It's possible to craft a malicious `pdm.lock` file that could allow e.g. an insider or a malicious open source project to appear to depend on a trusted PyPI project, but actually install another project. A project `foo` can be targeted by creating the project `foo-2` and uploading the file `foo-2-2.tar.gz` to pypi.org. PyPI will see this as project `foo-2` version `2`, while PDM will see this as project `foo` version `2-2`. The version must only be `parseable as a version` and the filename must be a prefix of the project name, but it's not verified to match the version being installed. Version `2-2` is also not a valid normalized version per PEP 440. Matching the project name exactly (not just prefix) would fix the issue. When installing dependencies with PDM, what's actually installed could differ from what's listed in `pyproject.toml` (including arbitrary code execution on install). It could also be used for downgrade attacks by only changing the version. This issue has been addressed in commit `6853e2642df` which is included in release version `2.9.4`. Users are advised to upgrade. There are no known workarounds for this vulnerability.
CWE description: There is insufficient information about the issue to classify it; details are unkown or unspecified.
CVSS v3 base score: 7.8
Published: 2023-10-20T19:15Z
Repository: https://github.com/pdm-project/pdm
Language: Python
Files changed: src/pdm/models/repositories.py
Commit date: 2023-10-18 10:38:33 +0800
Commit message: Merge pull request from GHSA-j44v-mmf2-xvm9

Signed-off-by: Frost Ming <me@frostming.com>
Diff: diff --git a/src/pdm/models/repositories.py b/src/pdm/models/repositories.py
index 9711c3fd..70a000b6 100644
--- a/src/pdm/models/repositories.py
+++ b/src/pdm/models/repositories.py
@@ -8,11 +8,11 @@ import sys
 import warnings
 from functools import wraps
 from typing import TYPE_CHECKING, Generator, TypeVar, cast
 
 from pdm import termui
-from pdm.exceptions import CandidateInfoNotFound, CandidateNotFound, PackageWarning
+from pdm.exceptions import CandidateInfoNotFound, CandidateNotFound, PackageWarning, PdmException
 from pdm.models.candidates import Candidate, make_candidate
 from pdm.models.requirements import (
     Requirement,
     filter_requirements_with_extras,
     parse_requirement,
@@ -484,10 +484,11 @@ class LockedRepository(BaseRepository):
     def all_candidates(self) -> dict[str, Candidate]:
         return {can.req.identify(): can for can in self.packages.values()}
 
     def _read_lockfile(self, lockfile: Mapping[str, Any]) -> None:
         root = self.environment.project.root
+        static_urls = self.environment.project.lockfile.static_urls
         with cd(root):
             for package in lockfile.get("package", []):
                 version = package.get("version")
                 if version:
                     package["version"] = f"=={version}"
@@ -498,10 +499,14 @@ class LockedRepository(BaseRepository):
                 req = Requirement.from_req_dict(package_name, req_dict)
                 if req.is_file_or_url and req.path and not req.url:  # type: ignore[attr-defined]
                     req.url = path_to_url(posixpath.join(root, req.path))  # type: ignore[attr-defined]
                 can = make_candidate(req, name=package_name, version=version)
                 can.hashes = package.get("files", [])
+                if not static_urls and any("url" in f for f in can.hashes):
+                    raise PdmException(
+                        "Static URLs are not allowed in lockfile unless enabled by `pdm lock --static-urls`."
+                    )
                 can_id = self._identify_candidate(can)
                 self.packages[can_id] = can
                 candidate_info: CandidateInfo = (
                     package.get("dependencies", []),
                     package.get("requires_python", ""),

Vulnerable code: from pdm.exceptions import CandidateInfoNotFound, CandidateNotFound, PackageWarning
Fixed code: from pdm.exceptions import CandidateInfoNotFound, CandidateNotFound, PackageWarning, PdmException
        static_urls = self.environment.project.lockfile.static_urls
                if not static_urls and any("url" in f for f in can.hashes):
                    raise PdmException(
                        "Static URLs are not allowed in lockfile unless enabled by `pdm lock --static-urls`."
                    )