CVE-2024-23644: Interpretation Conflict (CWE-436)
value: Trillium is a composable toolkit for building internet applications with async rust. In `trillium-http` prior to 0.3.12 and `trillium-client` prior to 0.5.4, insufficient validation of outbound header values may lead to request splitting or response splitting attacks in scenarios where attackers have sufficient control over headers. This only affects use cases where attackers have control of request headers, and can insert "\r\n" sequences. Specifically, if untrusted and unvalidated input is inserted into header names or values.

Outbound `trillium_http::HeaderValue` and `trillium_http::HeaderName` can be constructed infallibly and were not checked for illegal bytes when sending requests from the client or responses from the server. Thus, if an attacker has sufficient control over header values (or names) in a request or response that they could inject `\r\n` sequences, they could get the client and server out of sync, and then pivot to gain control over other parts of requests or responses. (i.e. exfiltrating data from other requests, SSRF, etc.)

In `trillium-http` versions 0.3.12 and later, if a header name is invalid in server response headers, the specific header and any associated values are omitted from network transmission. Additionally, if a header value is invalid in server response headers, the individual header value is omitted from network transmission. Other headers values with the same header name will still be sent. In `trillium-client` versions 0.5.4 and later, if any header name or header value is invalid in the client request headers, awaiting the client Conn returns an `Error::MalformedHeader` prior to any network access. As a workaround, Trillium services and client applications should sanitize or validate untrusted input that is included in header values and header names. Carriage return, newline, and null characters are not allowed.
CWE description: Product A handles inputs or steps differently than Product B, which causes A to perform incorrect actions based on its perception of B's state.
CVSS v3 base score: 8.1
Published: 2024-01-24T20:15Z
Repository: https://github.com/trillium-rs/trillium
Language: Rust
Files changed: http/src/headers/unknown_header_name.rs
Commit date: 2024-01-23 16:48:50 -0800
Commit message: fix(security): allow all tchar in header names

Diff: diff --git a/http/src/headers/unknown_header_name.rs b/http/src/headers/unknown_header_name.rs
index 21031ad..2aaeb62 100644
--- a/http/src/headers/unknown_header_name.rs
+++ b/http/src/headers/unknown_header_name.rs
@@ -42,15 +42,39 @@ impl<'a> From<UnknownHeaderName<'a>> for HeaderName<'a> {
     fn from(value: UnknownHeaderName<'a>) -> Self {
         HeaderName(UnknownHeader(value))
     }
 }
 
+fn is_tchar(c: char) -> bool {
+    matches!(
+        c,
+        'a'..='z'
+        | 'A'..='Z'
+        | '0'..='9'
+        | '!'
+        | '#'
+        | '$'
+        | '%'
+        | '&'
+        | '\''
+        | '*'
+        | '+'
+        | '-'
+        | '.'
+        | '^'
+        | '_'
+        | '`'
+        | '|'
+        | '~'
+    )
+}
+
 impl UnknownHeaderName<'_> {
     pub(crate) fn is_valid(&self) -> bool {
-        self.0
-            .chars()
-            .all(|c| matches!(c, 'a'..='z'|'A'..='Z'|'0'..='9'|'-'|'_'))
+        // token per https://www.rfc-editor.org/rfc/rfc9110#section-5.1
+        // tchar per https://www.rfc-editor.org/rfc/rfc9110#section-5.6.2
+        !self.is_empty() && self.0.chars().all(is_tchar)
     }
 
     pub(crate) fn into_owned(self) -> UnknownHeaderName<'static> {
         UnknownHeaderName(self.0.into_owned())
     }

Vulnerable code:         self.0
            .chars()
            .all(|c| matches!(c, 'a'..='z'|'A'..='Z'|'0'..='9'|'-'|'_'))
Fixed code: fn is_tchar(c: char) -> bool {
    matches!(
        c,
        'a'..='z'
        | 'A'..='Z'
        | '0'..='9'
        | '!'
        | '#'
        | '$'
        | '%'
        | '&'
        | '\''
        | '*'
        | '+'
        | '-'
        | '.'
        | '^'
        | '_'
        | '`'
        | '|'
        | '~'
    )
}

        // token per https://www.rfc-editor.org/rfc/rfc9110#section-5.1
        // tchar per https://www.rfc-editor.org/rfc/rfc9110#section-5.6.2
        !self.is_empty() && self.0.chars().all(is_tchar)