CVE-2023-38491: Improper Neutralization of Input During Web Page Generation ('Cross-site Scripting') (CWE-79)
value: Kirby is a content management system. A vulnerability in versions prior to 3.5.8.3, 3.6.6.3, 3.7.5.2, 3.8.4.1, and 3.9.6 affects all Kirby sites that might have potential attackers in the group of authenticated Panel users or that allow external visitors to upload an arbitrary file to the content folder. Kirby sites are not affected if they don't allow file uploads for untrusted users or visitors or if the file extensions of uploaded files are limited to a fixed safe list. The attack requires user interaction by another user or visitor and cannot be automated.

An editor with write access to the Kirby Panel could upload a file with an unknown file extension like `.xyz` that contains HTML code including harmful content like `<script>` tags. The direct link to that file could be sent to other users or visitors of the site. If the victim opened that link in a browser where they are logged in to Kirby and the file had not been opened by anyone since the upload, Kirby would not be able to send the correct MIME content type, instead falling back to `text/html`. The browser would then run the script, which could for example trigger requests to Kirby's API with the permissions of the victim.

The issue was caused by the underlying `Kirby\Http\Response::file()` method, which didn't have an explicit fallback if the MIME type could not be determined from the file extension. If you use this method in site or plugin code, these uses may be affected by the same vulnerability.

The problem has been patched in Kirby 3.5.8.3, 3.6.6.3, 3.7.5.2, 3.8.4.1, and 3.9.6. In all of the mentioned releases, the maintainers have fixed the affected method to use a fallback MIME type of `text/plain` and set the `X-Content-Type-Options: nosniff` header if the MIME type of the file is unknown.
CWE description: The product does not neutralize or incorrectly neutralizes user-controllable input before it is placed in output that is used as a web page that is served to other users.
CVSS v3 base score: 5.4
Published: 2023-07-27T16:15Z
Repository: https://github.com/getkirby/kirby
Language: PHP
Files changed: src/Http/Response.php, tests/Http/ResponseTest.php, tests/Http/fixtures/download.json
Commit date: 2023-07-26 21:07:12 +0200
Commit message: Fix MIME detection vulnerability

https://github.com/getkirby/kirby/security/advisories/GHSA-8fv7-wq38-f5c9

Diff: diff --git a/src/Http/Response.php b/src/Http/Response.php
index 984aed4a5..914683272 100644
--- a/src/Http/Response.php
+++ b/src/Http/Response.php
@@ -174,10 +174,22 @@ class Response
 		$props = array_merge([
 			'body' => F::read($file),
 			'type' => F::extensionToMime(F::extension($file))
 		], $props);
 
+		// if we couldn't serve a correct MIME type, force
+		// the browser to display the file as plain text to
+		// harden against attacks from malicious file uploads
+		if ($props['type'] === null) {
+			if (isset($props['headers']) !== true) {
+				$props['headers'] = [];
+			}
+
+			$props['type'] = 'text/plain';
+			$props['headers']['X-Content-Type-Options'] = 'nosniff';
+		}
+
 		return new static($props);
 	}
 
 
 	/**
diff --git a/tests/Http/ResponseTest.php b/tests/Http/ResponseTest.php
index 0ba52fa78..efbd6e359 100644
--- a/tests/Http/ResponseTest.php
+++ b/tests/Http/ResponseTest.php
@@ -186,17 +186,45 @@ class ResponseTest extends TestCase
 		$this->assertSame($expected, $response->body());
 	}
 
 	public function testFile()
 	{
-		$file = __DIR__ . '/fixtures/download.txt';
+		$file = __DIR__ . '/fixtures/download.json';
+
+		$response = Response::file($file);
+
+		$this->assertSame('application/json', $response->type());
+		$this->assertSame(200, $response->code());
+		$this->assertSame('{"foo": "bar"}', $response->body());
+
+		$response = Response::file($file, [
+			'code'    => '201',
+			'headers' => [
+				'Pragma' => 'no-cache'
+			]
+		]);
+
+		$this->assertSame('application/json', $response->type());
+		$this->assertSame(201, $response->code());
+		$this->assertSame('{"foo": "bar"}', $response->body());
+		$this->assertSame([
+			'Pragma' => 'no-cache'
+		], $response->headers());
+	}
+
+	public function testFileInvalid()
+	{
+		$file = __DIR__ . '/fixtures/download.xyz';
 
 		$response = Response::file($file);
 
 		$this->assertSame('text/plain', $response->type());
 		$this->assertSame(200, $response->code());
 		$this->assertSame('test', $response->body());
+		$this->assertSame([
+			'X-Content-Type-Options' => 'nosniff',
+		], $response->headers());
 
 		$response = Response::file($file, [
 			'code'    => '201',
 			'headers' => [
 				'Pragma' => 'no-cache'
@@ -205,11 +233,12 @@ class ResponseTest extends TestCase
 
 		$this->assertSame('text/plain', $response->type());
 		$this->assertSame(201, $response->code());
 		$this->assertSame('test', $response->body());
 		$this->assertSame([
-			'Pragma' => 'no-cache'
+			'Pragma' => 'no-cache',
+			'X-Content-Type-Options' => 'nosniff',
 		], $response->headers());
 	}
 
 	public function testType()
 	{
diff --git a/tests/Http/fixtures/download.json b/tests/Http/fixtures/download.json
new file mode 100644
index 000000000..18d7acf58
--- /dev/null
+++ b/tests/Http/fixtures/download.json
@@ -0,0 +1 @@
+{"foo": "bar"}
\ No newline at end of file
diff --git a/tests/Http/fixtures/download.txt b/tests/Http/fixtures/download.xyz
similarity index 100%
rename from tests/Http/fixtures/download.txt
rename to tests/Http/fixtures/download.xyz

Vulnerable code: 		$file = __DIR__ . '/fixtures/download.txt';
			'Pragma' => 'no-cache'
Fixed code: 		// if we couldn't serve a correct MIME type, force
		// the browser to display the file as plain text to
		// harden against attacks from malicious file uploads
		if ($props['type'] === null) {
			if (isset($props['headers']) !== true) {
				$props['headers'] = [];
			}

			$props['type'] = 'text/plain';
			$props['headers']['X-Content-Type-Options'] = 'nosniff';
		}

		$file = __DIR__ . '/fixtures/download.json';

		$response = Response::file($file);

		$this->assertSame('application/json', $response->type());
		$this->assertSame(200, $response->code());
		$this->assertSame('{"foo": "bar"}', $response->body());

		$response = Response::file($file, [
			'code'    => '201',
			'headers' => [
				'Pragma' => 'no-cache'
			]
		]);

		$this->assertSame('application/json', $response->type());
		$this->assertSame(201, $response->code());
		$this->assertSame('{"foo": "bar"}', $response->body());
		$this->assertSame([
			'Pragma' => 'no-cache'
		], $response->headers());
	}

	public function testFileInvalid()
	{
		$file = __DIR__ . '/fixtures/download.xyz';
		$this->assertSame([
			'X-Content-Type-Options' => 'nosniff',
		], $response->headers());
			'Pragma' => 'no-cache',
			'X-Content-Type-Options' => 'nosniff',
{"foo": "bar"}